type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/330980489","pull_request_review_id":296792799,"id":330980489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDk4MDQ4OQ==","diff_hunk":"@@ -94,24 +94,25 @@ def test_logical_operators_int_dtype_with_int_scalar(self):\n def test_logical_operators_int_dtype_with_float(self):\n # GH#9016: support bitwise op for integer types\n s_0123 = Series(range(4), dtype=\"int64\")\n-\n- with pytest.raises(TypeError):\n+ msg = r\"cannot compare a dtyped \\[int64\\] array with a scalar of type \\[float\\]\"","path":"pandas/tests/series/test_operators.py","position":14,"original_position":14,"commit_id":"a38bc5e4928b83a9b00d47a0b5d697b31204f143","original_commit_id":"a38bc5e4928b83a9b00d47a0b5d697b31204f143","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"why are you changing things here?","created_at":"2019-10-03T10:59:16Z","updated_at":"2019-10-03T10:59:41Z","html_url":"https://github.com/pandas-dev/pandas/pull/28746#discussion_r330980489","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/330980489"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/28746#discussion_r330980489"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746","id":323677240,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzNjc3MjQw","html_url":"https://github.com/pandas-dev/pandas/pull/28746","diff_url":"https://github.com/pandas-dev/pandas/pull/28746.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/28746.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/28746","number":28746,"state":"open","locked":false,"title":"Test pytables refactor","user":{"login":"tolaa001","id":33249563,"node_id":"MDQ6VXNlcjMzMjQ5NTYz","avatar_url":"https://avatars1.githubusercontent.com/u/33249563?v=4","gravatar_id":"","url":"https://api.github.com/users/tolaa001","html_url":"https://github.com/tolaa001","followers_url":"https://api.github.com/users/tolaa001/followers","following_url":"https://api.github.com/users/tolaa001/following{/other_user}","gists_url":"https://api.github.com/users/tolaa001/gists{/gist_id}","starred_url":"https://api.github.com/users/tolaa001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tolaa001/subscriptions","organizations_url":"https://api.github.com/users/tolaa001/orgs","repos_url":"https://api.github.com/users/tolaa001/repos","events_url":"https://api.github.com/users/tolaa001/events{/privacy}","received_events_url":"https://api.github.com/users/tolaa001/received_events","type":"User","site_admin":false},"body":" - precursor to #18498 and continuation of #28715\r\n- No new tests added\r\n- black pandas ran successfully\r\n- This PR is the next step reference in #28715. \r\n\r\n@simonjayhawkins and @jreback as promised, this PR contains the following new and EXCITING changes:\r\n\r\n1. Created a contest.py in the pytables sub directory containing all the shared fixtures\r\n2. Created common.py which contains all the functions and variables used by the test classes such as tables, safe_remove, safe_close, create_tempfile, ensure_clean_path, ensure_clean_store, _maybe_remove\r\n3. Created separate modules for each of the test classes i.e. test_timezones, test_hdf_store, test_hdf_complex_values\r\n4. As a result of creating the common.py, I have update the ensure_clean_path import to the test_compat module to ensure safe deletion of the test_pytables module.\r\n\r\nThere has been no amendments to the body of the code. The next PR will involve focusing on removing the class in test_timezone and making it strictly functional. Followed by me doing this to the other 2 new modules i.e. test_hdf_store and test_hdf_complex_values.\r\n\r\nOnce the code base is strictly functional, I can start working on more fun refactoring of the functions :)","created_at":"2019-10-02T10:05:57Z","updated_at":"2019-10-03T10:59:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55e35204672f25d52d2ee3ff5077eff58e6fffa7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":211029535,"node_id":"MDU6TGFiZWwyMTEwMjk1MzU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Clean","name":"Clean","color":"207de5","default":false},{"id":47229190,"node_id":"MDU6TGFiZWw0NzIyOTE5MA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/IO%20HDF5","name":"IO HDF5","color":"5319e7","default":false},{"id":127685,"node_id":"MDU6TGFiZWwxMjc2ODU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Testing","name":"Testing","color":"C4A000","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/16","html_url":"https://github.com/pandas-dev/pandas/milestone/16","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/16/labels","id":174211,"node_id":"MDk6TWlsZXN0b25lMTc0MjEx","number":16,"title":"1.0","description":"","creator":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"open_issues":135,"closed_issues":478,"state":"open","created_at":"2012-09-13T02:13:00Z","updated_at":"2019-10-03T06:56:11Z","due_on":"2019-11-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/28746/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/a38bc5e4928b83a9b00d47a0b5d697b31204f143","head":{"label":"tolaa001:test_pytables_refactor","ref":"test_pytables_refactor","sha":"a38bc5e4928b83a9b00d47a0b5d697b31204f143","user":{"login":"tolaa001","id":33249563,"node_id":"MDQ6VXNlcjMzMjQ5NTYz","avatar_url":"https://avatars1.githubusercontent.com/u/33249563?v=4","gravatar_id":"","url":"https://api.github.com/users/tolaa001","html_url":"https://github.com/tolaa001","followers_url":"https://api.github.com/users/tolaa001/followers","following_url":"https://api.github.com/users/tolaa001/following{/other_user}","gists_url":"https://api.github.com/users/tolaa001/gists{/gist_id}","starred_url":"https://api.github.com/users/tolaa001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tolaa001/subscriptions","organizations_url":"https://api.github.com/users/tolaa001/orgs","repos_url":"https://api.github.com/users/tolaa001/repos","events_url":"https://api.github.com/users/tolaa001/events{/privacy}","received_events_url":"https://api.github.com/users/tolaa001/received_events","type":"User","site_admin":false},"repo":{"id":209962552,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk5NjI1NTI=","name":"pandas","full_name":"tolaa001/pandas","private":false,"owner":{"login":"tolaa001","id":33249563,"node_id":"MDQ6VXNlcjMzMjQ5NTYz","avatar_url":"https://avatars1.githubusercontent.com/u/33249563?v=4","gravatar_id":"","url":"https://api.github.com/users/tolaa001","html_url":"https://github.com/tolaa001","followers_url":"https://api.github.com/users/tolaa001/followers","following_url":"https://api.github.com/users/tolaa001/following{/other_user}","gists_url":"https://api.github.com/users/tolaa001/gists{/gist_id}","starred_url":"https://api.github.com/users/tolaa001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tolaa001/subscriptions","organizations_url":"https://api.github.com/users/tolaa001/orgs","repos_url":"https://api.github.com/users/tolaa001/repos","events_url":"https://api.github.com/users/tolaa001/events{/privacy}","received_events_url":"https://api.github.com/users/tolaa001/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tolaa001/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/tolaa001/pandas","forks_url":"https://api.github.com/repos/tolaa001/pandas/forks","keys_url":"https://api.github.com/repos/tolaa001/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tolaa001/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tolaa001/pandas/teams","hooks_url":"https://api.github.com/repos/tolaa001/pandas/hooks","issue_events_url":"https://api.github.com/repos/tolaa001/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/tolaa001/pandas/events","assignees_url":"https://api.github.com/repos/tolaa001/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/tolaa001/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/tolaa001/pandas/tags","blobs_url":"https://api.github.com/repos/tolaa001/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tolaa001/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tolaa001/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/tolaa001/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tolaa001/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/tolaa001/pandas/languages","stargazers_url":"https://api.github.com/repos/tolaa001/pandas/stargazers","contributors_url":"https://api.github.com/repos/tolaa001/pandas/contributors","subscribers_url":"https://api.github.com/repos/tolaa001/pandas/subscribers","subscription_url":"https://api.github.com/repos/tolaa001/pandas/subscription","commits_url":"https://api.github.com/repos/tolaa001/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/tolaa001/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/tolaa001/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/tolaa001/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/tolaa001/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/tolaa001/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tolaa001/pandas/merges","archive_url":"https://api.github.com/repos/tolaa001/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tolaa001/pandas/downloads","issues_url":"https://api.github.com/repos/tolaa001/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/tolaa001/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/tolaa001/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/tolaa001/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tolaa001/pandas/labels{/name}","releases_url":"https://api.github.com/repos/tolaa001/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/tolaa001/pandas/deployments","created_at":"2019-09-21T10:02:33Z","updated_at":"2019-09-21T10:02:36Z","pushed_at":"2019-10-03T10:50:07Z","git_url":"git://github.com/tolaa001/pandas.git","ssh_url":"git@github.com:tolaa001/pandas.git","clone_url":"https://github.com/tolaa001/pandas.git","svn_url":"https://github.com/tolaa001/pandas","homepage":"https://pandas.pydata.org","size":170134,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"bf6c5c3c7b466d211df663ae11e3c027b85982bc","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2019-10-03T10:28:33Z","pushed_at":"2019-10-03T10:50:12Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":170222,"stargazers_count":21586,"watchers_count":21586,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8549,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3314,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":8549,"open_issues":3314,"watchers":21586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/28746"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/28746"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/28746/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/28746/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/a38bc5e4928b83a9b00d47a0b5d697b31204f143"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
}
|
{
"id": 953992,
"login": "jreback",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/953992?",
"url": "https://api.github.com/users/jreback"
}
|
{
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
}
| 2019-10-03T10:59:16 |
10550410884
|
{"actor":{"display_login":"jreback"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/302156674","pull_request_review_id":260210396,"id":302156674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjE1NjY3NA==","diff_hunk":"@@ -0,0 +1,211 @@\n+\"\"\"\n+Low-dependency indexing utilities.\n+\"\"\"\n+import numpy as np\n+\n+from pandas.core.dtypes.common import is_list_like\n+from pandas.core.dtypes.generic import ABCIndexClass, ABCSeries\n+\n+\n+# -----------------------------------------------------------\n+# Indexer Identification\n+\n+def is_list_like_indexer(key) -> bool:\n+ # allow a list_like, but exclude NamedTuples which can be indexers\n+ return is_list_like(key) and not (isinstance(key, tuple) and type(key) is not tuple)\n+\n+\n+def is_scalar_indexer(indexer, arr_value) -> bool:","path":"pandas/core/indexers.py","position":29,"original_position":18,"commit_id":"39fa0141fb2a695fb47bac4a4895e3c6c8de41f5","original_commit_id":"7efe2d1bea8590c02a5794a2dd0750521bfee302","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"can you fix this doc-sring in followup and type as much as possible here","created_at":"2019-07-10T16:21:20Z","updated_at":"2019-07-10T16:21:20Z","html_url":"https://github.com/pandas-dev/pandas/pull/27229#discussion_r302156674","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/302156674"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/27229#discussion_r302156674"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229"}},"in_reply_to_id":300428204},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229","id":294608188,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NjA4MTg4","html_url":"https://github.com/pandas-dev/pandas/pull/27229","diff_url":"https://github.com/pandas-dev/pandas/pull/27229.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/27229.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/27229","number":27229,"state":"open","locked":false,"title":"REF: separate indexer utilities from indexing.py","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"A couple things going on here.\r\n\r\n- Take simple, low-dependency, not-used-in-indexing.py functions out of indexing.py and put them in indexers.py.\r\n - A couple of runtime-defined functions in internals get moved here too.\r\n - Avoids some runtime imports (i.e. simplify dependency structure)\r\n - Fixes some incorrect private names\r\n - Adds typing\r\n- Simplify some indexing.py methods\r\n - Avoid duplicated validation calls\r\n - Add typing\r\n - De-duplicate _get_slice_axis method\r\n - Move code outside of try/except blocks to clarify what the failure modes are.\r\n\r\nMedium-term goals in indexing.py\r\n - Isolate internals access\r\n - refactor _setitem_with_indexer (over 300 lines)","created_at":"2019-07-04T14:35:15Z","updated_at":"2019-07-10T16:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be1bb2e473860fcefbe1ae3b4e011a93c2563b78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":211029535,"node_id":"MDU6TGFiZWwyMTEwMjk1MzU=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Clean","name":"Clean","color":"207de5","default":false},{"id":2822098,"node_id":"MDU6TGFiZWwyODIyMDk4","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Indexing","name":"Indexing","color":"0b02e1","default":false},{"id":49094459,"node_id":"MDU6TGFiZWw0OTA5NDQ1OQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Internals","name":"Internals","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/27229/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/39fa0141fb2a695fb47bac4a4895e3c6c8de41f5","head":{"label":"jbrockmendel:clnindexing","ref":"clnindexing","sha":"39fa0141fb2a695fb47bac4a4895e3c6c8de41f5","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"repo":{"id":96820953,"node_id":"MDEwOlJlcG9zaXRvcnk5NjgyMDk1Mw==","name":"pandas","full_name":"jbrockmendel/pandas","private":false,"owner":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbrockmendel/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jbrockmendel/pandas","forks_url":"https://api.github.com/repos/jbrockmendel/pandas/forks","keys_url":"https://api.github.com/repos/jbrockmendel/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrockmendel/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrockmendel/pandas/teams","hooks_url":"https://api.github.com/repos/jbrockmendel/pandas/hooks","issue_events_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jbrockmendel/pandas/events","assignees_url":"https://api.github.com/repos/jbrockmendel/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jbrockmendel/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jbrockmendel/pandas/tags","blobs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrockmendel/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrockmendel/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrockmendel/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrockmendel/pandas/languages","stargazers_url":"https://api.github.com/repos/jbrockmendel/pandas/stargazers","contributors_url":"https://api.github.com/repos/jbrockmendel/pandas/contributors","subscribers_url":"https://api.github.com/repos/jbrockmendel/pandas/subscribers","subscription_url":"https://api.github.com/repos/jbrockmendel/pandas/subscription","commits_url":"https://api.github.com/repos/jbrockmendel/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrockmendel/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrockmendel/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrockmendel/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jbrockmendel/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrockmendel/pandas/merges","archive_url":"https://api.github.com/repos/jbrockmendel/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrockmendel/pandas/downloads","issues_url":"https://api.github.com/repos/jbrockmendel/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jbrockmendel/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrockmendel/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrockmendel/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrockmendel/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jbrockmendel/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jbrockmendel/pandas/deployments","created_at":"2017-07-10T21:01:07Z","updated_at":"2019-04-02T06:05:23Z","pushed_at":"2019-07-10T16:15:40Z","git_url":"git://github.com/jbrockmendel/pandas.git","ssh_url":"git@github.com:jbrockmendel/pandas.git","clone_url":"https://github.com/jbrockmendel/pandas.git","svn_url":"https://github.com/jbrockmendel/pandas","homepage":"http://pandas.pydata.org","size":165646,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"c64c9cb44222a42f7b02d4d6007919cd0645f1be","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2019-07-10T16:20:32Z","pushed_at":"2019-07-10T16:20:05Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":164238,"stargazers_count":20255,"watchers_count":20255,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8008,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3065,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":8008,"open_issues":3065,"watchers":20255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/27229"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/27229"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/27229/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/27229/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/39fa0141fb2a695fb47bac4a4895e3c6c8de41f5"}},"author_association":"MEMBER"}}
|
{
"id": 858127,
"name": "pandas-dev/pandas",
"url": "https://api.github.com/repos/pandas-dev/pandas"
}
|
{
"id": 953992,
"login": "jreback",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/953992?",
"url": "https://api.github.com/users/jreback"
}
|
{
"id": 21206976,
"login": "pandas-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21206976?",
"url": "https://api.github.com/orgs/pandas-dev"
}
| 2019-07-10T16:21:20 |
9985354847
|
{"actor":{"display_login":"jreback"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/RasaHQ/rasa/pulls/comments/318121974","pull_request_review_id":280248868,"id":318121974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxODEyMTk3NA==","diff_hunk":"@@ -0,0 +1,99 @@\n+:desc: Glossary for all Rasa-related terms\n+\n+.. _glossary:\n+\n+Glossary\n+========\n+\n+.. glossary::\n+\n+ Action\n+ A single step that a bot takes in a conversation (e.g. calling an API or sending a response back to the user).\n+\n+ Annotation\n+ Adding labels to messages and conversations so that they can be used to train a model.\n+\n+ CMS\n+ A Content Management System (CMS) can be used to store bot responses externally instead of directly including it as part of the domain. This provides more flexibility in changing them as they are not tightly-coupled with the training data.\n+\n+ Custom Action\n+ An action written by a Rasa developer that can run arbitrary code mainly to interact with the outside world.\n+\n+ Default Action\n+ A built-in action that comes with predefined functionality.\n+\n+ Domain\n+ Defines the inputs and outputs of an assistant.\n+\n+ It includes a list of all the intents, entities, slots, actions, and forms that the assistant knows about.\n+\n+ Entity\n+ Structured information that can be extracted from a user message.\n+\n+ For example a telephone number, a person's name, a location, the name of a product\n+\n+ Event\n+ All conversations in Rasa are represented as a sequence of events. For instance, a ``UserUttered`` represents a user entering a message, and an ``ActionExecuted`` represents the assistant executing an action. You can learn more about them :ref:`here <events>`.\n+\n+ Form\n+ A type of custom action that asks the user for multiple pieces of information.\n+\n+ For example, if you need a city, a cuisine, and a price range to recommend a restaurant, you can create a restaurant form to do that. You can describe any business logic inside a form. For example, if you want to ask for a particular neighbourhood if a user mentions a large city like Los Angeles, you can write that logic inside the form.\n+\n+ Happy / Unhappy Paths\n+ If your assistant asks a user for some information and the user provides it, we call that a happy path. Unhappy paths are all the possible edge cases of a bot. For example, the user refusing to give some input, changing the topic of conversation, or correcting something they said earlier.\n+\n+ Intent\n+ Something that a user is trying to convey or accomplish (e,g., greeting, specifying a location).\n+\n+ Interactive Learning\n+ A mode of training the bot where the user provides feedback to the bot while talking to it.\n+\n+ This is a powerful way to write complicated stories by enabling users to explore what a bot can do and easily fix any mistakes it makes.\n+\n+ NLG\n+ Natural Language Generation (NLG) is the process of generating natural language messages to send to a user.\n+\n+ Rasa uses a simple template-based approach for NLG. Data-driven approaches (such as neural NLG) can be implemented by creating a custom NLG component.\n+\n+ Rasa NLU\n+ Natural Language Understanding (NLU) deals with parsing and understanding human language into a structured format.\n+\n+ Rasa NLU is the part of Rasa that performs intent classification and entity extraction.\n+\n+ Pipeline\n+ A Rasa bot's NLU system is defined by a pipeline, which is a list of NLU components (see \"Rasa NLU Component\") in a particular order. A user input is processed by each component one by one before finally giving out the structured output.\n+\n+ Policy\n+ Policies make decisions on how conversation flow should proceed. At every turn, the policy which predicts the next action with the highest confidence will be used. A Core model can have multiple policies included, and the policy whose prediction has the highest confidence decides the next action to be taken.\n+\n+ Rasa Core\n+ The dialogue engine that decides on what to do next in a conversation based on the context.\n+\n+ Rasa NLU Component\n+ An element in the Rasa NLU pipeline (see \"Pipeline\").\n+\n+ Incoming messages are processed by a sequence of components called a pipeline. A component can perform tasks ranging from entity extraction to intent classification to pre-processing.\n+\n+ Slot\n+ A key-value store that Rasa uses to track information over the course of a conversation.\n+\n+ For the different types of slots, see :ref:`here <slot-classes>`.\n+\n+ Story\n+ A template of a conversation between a user and a bot annotated with the intent / entities of the users' messages as well as the sequence of actions to be performed by the bot","path":"docs/glossary.rst","position":84,"original_position":84,"commit_id":"70e65690765a26252593ced533424fd0a0418ad8","original_commit_id":"70e65690765a26252593ced533424fd0a0418ad8","user":{"login":"amn41","id":5114084,"node_id":"MDQ6VXNlcjUxMTQwODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5114084?v=4","gravatar_id":"","url":"https://api.github.com/users/amn41","html_url":"https://github.com/amn41","followers_url":"https://api.github.com/users/amn41/followers","following_url":"https://api.github.com/users/amn41/following{/other_user}","gists_url":"https://api.github.com/users/amn41/gists{/gist_id}","starred_url":"https://api.github.com/users/amn41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amn41/subscriptions","organizations_url":"https://api.github.com/users/amn41/orgs","repos_url":"https://api.github.com/users/amn41/repos","events_url":"https://api.github.com/users/amn41/events{/privacy}","received_events_url":"https://api.github.com/users/amn41/received_events","type":"User","site_admin":false},"body":"I think the word template is awkward here. It is a conversation between a user and a bot, represented as intents, entities, and actions.","created_at":"2019-08-27T14:42:44Z","updated_at":"2019-08-27T14:43:31Z","html_url":"https://github.com/RasaHQ/rasa/pull/4297#discussion_r318121974","pull_request_url":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa/pulls/comments/318121974"},"html":{"href":"https://github.com/RasaHQ/rasa/pull/4297#discussion_r318121974"},"pull_request":{"href":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297"}}},"pull_request":{"url":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297","id":309449333,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5NDQ5MzMz","html_url":"https://github.com/RasaHQ/rasa/pull/4297","diff_url":"https://github.com/RasaHQ/rasa/pull/4297.diff","patch_url":"https://github.com/RasaHQ/rasa/pull/4297.patch","issue_url":"https://api.github.com/repos/RasaHQ/rasa/issues/4297","number":4297,"state":"open","locked":false,"title":"Add glossary page","user":{"login":"msamogh","id":1230386,"node_id":"MDQ6VXNlcjEyMzAzODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1230386?v=4","gravatar_id":"","url":"https://api.github.com/users/msamogh","html_url":"https://github.com/msamogh","followers_url":"https://api.github.com/users/msamogh/followers","following_url":"https://api.github.com/users/msamogh/following{/other_user}","gists_url":"https://api.github.com/users/msamogh/gists{/gist_id}","starred_url":"https://api.github.com/users/msamogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msamogh/subscriptions","organizations_url":"https://api.github.com/users/msamogh/orgs","repos_url":"https://api.github.com/users/msamogh/repos","events_url":"https://api.github.com/users/msamogh/events{/privacy}","received_events_url":"https://api.github.com/users/msamogh/received_events","type":"User","site_admin":false},"body":"**Proposed changes**:\r\n- Fix https://github.com/RasaHQ/roadmap/issues/635\r\n\r\n**Status (please check what you already did)**:\r\n- [x] made PR ready for code review\r\n- [ ] added some tests for the functionality\r\n- [ ] updated the documentation\r\n- [ ] updated the changelog\r\n- [ ] reformat files using `black` (please check [Readme](https://github.com/RasaHQ/rasa_nlu#code-style) for instructions)\r\n","created_at":"2019-08-21T11:15:15Z","updated_at":"2019-08-27T14:43:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13b75127e8dac2da1aa7adfd1194b9521bf22d3a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"akelad","id":32450038,"node_id":"MDQ6VXNlcjMyNDUwMDM4","avatar_url":"https://avatars3.githubusercontent.com/u/32450038?v=4","gravatar_id":"","url":"https://api.github.com/users/akelad","html_url":"https://github.com/akelad","followers_url":"https://api.github.com/users/akelad/followers","following_url":"https://api.github.com/users/akelad/following{/other_user}","gists_url":"https://api.github.com/users/akelad/gists{/gist_id}","starred_url":"https://api.github.com/users/akelad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akelad/subscriptions","organizations_url":"https://api.github.com/users/akelad/orgs","repos_url":"https://api.github.com/users/akelad/repos","events_url":"https://api.github.com/users/akelad/events{/privacy}","received_events_url":"https://api.github.com/users/akelad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297/commits","review_comments_url":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297/comments","review_comment_url":"https://api.github.com/repos/RasaHQ/rasa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RasaHQ/rasa/issues/4297/comments","statuses_url":"https://api.github.com/repos/RasaHQ/rasa/statuses/70e65690765a26252593ced533424fd0a0418ad8","head":{"label":"RasaHQ:glossary","ref":"glossary","sha":"70e65690765a26252593ced533424fd0a0418ad8","user":{"login":"RasaHQ","id":21214473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjE0NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":70908208,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkwODIwOA==","name":"rasa","full_name":"RasaHQ/rasa","private":false,"owner":{"login":"RasaHQ","id":21214473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjE0NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RasaHQ/rasa","description":"💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants","fork":false,"url":"https://api.github.com/repos/RasaHQ/rasa","forks_url":"https://api.github.com/repos/RasaHQ/rasa/forks","keys_url":"https://api.github.com/repos/RasaHQ/rasa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RasaHQ/rasa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RasaHQ/rasa/teams","hooks_url":"https://api.github.com/repos/RasaHQ/rasa/hooks","issue_events_url":"https://api.github.com/repos/RasaHQ/rasa/issues/events{/number}","events_url":"https://api.github.com/repos/RasaHQ/rasa/events","assignees_url":"https://api.github.com/repos/RasaHQ/rasa/assignees{/user}","branches_url":"https://api.github.com/repos/RasaHQ/rasa/branches{/branch}","tags_url":"https://api.github.com/repos/RasaHQ/rasa/tags","blobs_url":"https://api.github.com/repos/RasaHQ/rasa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RasaHQ/rasa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RasaHQ/rasa/git/refs{/sha}","trees_url":"https://api.github.com/repos/RasaHQ/rasa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RasaHQ/rasa/statuses/{sha}","languages_url":"https://api.github.com/repos/RasaHQ/rasa/languages","stargazers_url":"https://api.github.com/repos/RasaHQ/rasa/stargazers","contributors_url":"https://api.github.com/repos/RasaHQ/rasa/contributors","subscribers_url":"https://api.github.com/repos/RasaHQ/rasa/subscribers","subscription_url":"https://api.github.com/repos/RasaHQ/rasa/subscription","commits_url":"https://api.github.com/repos/RasaHQ/rasa/commits{/sha}","git_commits_url":"https://api.github.com/repos/RasaHQ/rasa/git/commits{/sha}","comments_url":"https://api.github.com/repos/RasaHQ/rasa/comments{/number}","issue_comment_url":"https://api.github.com/repos/RasaHQ/rasa/issues/comments{/number}","contents_url":"https://api.github.com/repos/RasaHQ/rasa/contents/{+path}","compare_url":"https://api.github.com/repos/RasaHQ/rasa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RasaHQ/rasa/merges","archive_url":"https://api.github.com/repos/RasaHQ/rasa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RasaHQ/rasa/downloads","issues_url":"https://api.github.com/repos/RasaHQ/rasa/issues{/number}","pulls_url":"https://api.github.com/repos/RasaHQ/rasa/pulls{/number}","milestones_url":"https://api.github.com/repos/RasaHQ/rasa/milestones{/number}","notifications_url":"https://api.github.com/repos/RasaHQ/rasa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RasaHQ/rasa/labels{/name}","releases_url":"https://api.github.com/repos/RasaHQ/rasa/releases{/id}","deployments_url":"https://api.github.com/repos/RasaHQ/rasa/deployments","created_at":"2016-10-14T12:27:49Z","updated_at":"2019-08-27T12:22:10Z","pushed_at":"2019-08-27T14:33:28Z","git_url":"git://github.com/RasaHQ/rasa.git","ssh_url":"git@github.com:RasaHQ/rasa.git","clone_url":"https://github.com/RasaHQ/rasa.git","svn_url":"https://github.com/RasaHQ/rasa","homepage":"https://rasa.com/docs/","size":391261,"stargazers_count":6275,"watchers_count":6275,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1904,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":249,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1904,"open_issues":249,"watchers":6275,"default_branch":"master"}},"base":{"label":"RasaHQ:1.2.x","ref":"1.2.x","sha":"867792bea56207fe518b81608fc559a3b3a8560f","user":{"login":"RasaHQ","id":21214473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjE0NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":70908208,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkwODIwOA==","name":"rasa","full_name":"RasaHQ/rasa","private":false,"owner":{"login":"RasaHQ","id":21214473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjE0NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RasaHQ/rasa","description":"💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants","fork":false,"url":"https://api.github.com/repos/RasaHQ/rasa","forks_url":"https://api.github.com/repos/RasaHQ/rasa/forks","keys_url":"https://api.github.com/repos/RasaHQ/rasa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RasaHQ/rasa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RasaHQ/rasa/teams","hooks_url":"https://api.github.com/repos/RasaHQ/rasa/hooks","issue_events_url":"https://api.github.com/repos/RasaHQ/rasa/issues/events{/number}","events_url":"https://api.github.com/repos/RasaHQ/rasa/events","assignees_url":"https://api.github.com/repos/RasaHQ/rasa/assignees{/user}","branches_url":"https://api.github.com/repos/RasaHQ/rasa/branches{/branch}","tags_url":"https://api.github.com/repos/RasaHQ/rasa/tags","blobs_url":"https://api.github.com/repos/RasaHQ/rasa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RasaHQ/rasa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RasaHQ/rasa/git/refs{/sha}","trees_url":"https://api.github.com/repos/RasaHQ/rasa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RasaHQ/rasa/statuses/{sha}","languages_url":"https://api.github.com/repos/RasaHQ/rasa/languages","stargazers_url":"https://api.github.com/repos/RasaHQ/rasa/stargazers","contributors_url":"https://api.github.com/repos/RasaHQ/rasa/contributors","subscribers_url":"https://api.github.com/repos/RasaHQ/rasa/subscribers","subscription_url":"https://api.github.com/repos/RasaHQ/rasa/subscription","commits_url":"https://api.github.com/repos/RasaHQ/rasa/commits{/sha}","git_commits_url":"https://api.github.com/repos/RasaHQ/rasa/git/commits{/sha}","comments_url":"https://api.github.com/repos/RasaHQ/rasa/comments{/number}","issue_comment_url":"https://api.github.com/repos/RasaHQ/rasa/issues/comments{/number}","contents_url":"https://api.github.com/repos/RasaHQ/rasa/contents/{+path}","compare_url":"https://api.github.com/repos/RasaHQ/rasa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RasaHQ/rasa/merges","archive_url":"https://api.github.com/repos/RasaHQ/rasa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RasaHQ/rasa/downloads","issues_url":"https://api.github.com/repos/RasaHQ/rasa/issues{/number}","pulls_url":"https://api.github.com/repos/RasaHQ/rasa/pulls{/number}","milestones_url":"https://api.github.com/repos/RasaHQ/rasa/milestones{/number}","notifications_url":"https://api.github.com/repos/RasaHQ/rasa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RasaHQ/rasa/labels{/name}","releases_url":"https://api.github.com/repos/RasaHQ/rasa/releases{/id}","deployments_url":"https://api.github.com/repos/RasaHQ/rasa/deployments","created_at":"2016-10-14T12:27:49Z","updated_at":"2019-08-27T12:22:10Z","pushed_at":"2019-08-27T14:33:28Z","git_url":"git://github.com/RasaHQ/rasa.git","ssh_url":"git@github.com:RasaHQ/rasa.git","clone_url":"https://github.com/RasaHQ/rasa.git","svn_url":"https://github.com/RasaHQ/rasa","homepage":"https://rasa.com/docs/","size":391261,"stargazers_count":6275,"watchers_count":6275,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1904,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":249,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1904,"open_issues":249,"watchers":6275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297"},"html":{"href":"https://github.com/RasaHQ/rasa/pull/4297"},"issue":{"href":"https://api.github.com/repos/RasaHQ/rasa/issues/4297"},"comments":{"href":"https://api.github.com/repos/RasaHQ/rasa/issues/4297/comments"},"review_comments":{"href":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297/comments"},"review_comment":{"href":"https://api.github.com/repos/RasaHQ/rasa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RasaHQ/rasa/pulls/4297/commits"},"statuses":{"href":"https://api.github.com/repos/RasaHQ/rasa/statuses/70e65690765a26252593ced533424fd0a0418ad8"}},"author_association":"MEMBER"}}
|
{
"id": 70908208,
"name": "RasaHQ/rasa",
"url": "https://api.github.com/repos/RasaHQ/rasa"
}
|
{
"id": 5114084,
"login": "amn41",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5114084?",
"url": "https://api.github.com/users/amn41"
}
|
{
"id": 21214473,
"login": "RasaHQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21214473?",
"url": "https://api.github.com/orgs/RasaHQ"
}
| 2019-08-27T16:42:44 |
10292582568
|
{"actor":{"display_login":"amn41"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments/355600444","pull_request_review_id":329114287,"id":355600444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTYwMDQ0NA==","diff_hunk":"@@ -37,6 +37,7 @@ export default {\n control_panel_url: `${urlControlPanelMain}`,\n copyright_MD: `© ${year} Doppler LLC. Todos los derechos reservados. [Política de Privacidad y Legales](${urlPrivacy}).`,\n empty_data: `Tu dominio no tiene datos para mostrar en esta sección aún.`,\n+ general_error: `¡Ouch! Ocurrio un error inesperado, vuelva a intentar nuevamente`,","path":"src/i18n/es.js","position":null,"original_position":4,"commit_id":"2768073e3a0b2b16f3faffdab2269d42c2272e45","original_commit_id":"d558bae62153f7ace2e732ffd9ce1eaa51580070","user":{"login":"cbernat","id":2439363,"node_id":"MDQ6VXNlcjI0MzkzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2439363?v=4","gravatar_id":"","url":"https://api.github.com/users/cbernat","html_url":"https://github.com/cbernat","followers_url":"https://api.github.com/users/cbernat/followers","following_url":"https://api.github.com/users/cbernat/following{/other_user}","gists_url":"https://api.github.com/users/cbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/cbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbernat/subscriptions","organizations_url":"https://api.github.com/users/cbernat/orgs","repos_url":"https://api.github.com/users/cbernat/repos","events_url":"https://api.github.com/users/cbernat/events{/privacy}","received_events_url":"https://api.github.com/users/cbernat/received_events","type":"User","site_admin":false},"body":"And here remember we try to use neutral language, not argentinian. (intente, vuelva, etc)","created_at":"2019-12-09T18:07:46Z","updated_at":"2019-12-09T18:07:47Z","html_url":"https://github.com/FromDoppler/doppler-webapp/pull/632#discussion_r355600444","pull_request_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments/355600444"},"html":{"href":"https://github.com/FromDoppler/doppler-webapp/pull/632#discussion_r355600444"},"pull_request":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632"}},"in_reply_to_id":355592824},"pull_request":{"url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632","id":350842038,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwODQyMDM4","html_url":"https://github.com/FromDoppler/doppler-webapp/pull/632","diff_url":"https://github.com/FromDoppler/doppler-webapp/pull/632.diff","patch_url":"https://github.com/FromDoppler/doppler-webapp/pull/632.patch","issue_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/632","number":632,"state":"open","locked":false,"title":"refactor(General): change name of general errors","user":{"login":"fcoronelmakingsense","id":8861133,"node_id":"MDQ6VXNlcjg4NjExMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8861133?v=4","gravatar_id":"","url":"https://api.github.com/users/fcoronelmakingsense","html_url":"https://github.com/fcoronelmakingsense","followers_url":"https://api.github.com/users/fcoronelmakingsense/followers","following_url":"https://api.github.com/users/fcoronelmakingsense/following{/other_user}","gists_url":"https://api.github.com/users/fcoronelmakingsense/gists{/gist_id}","starred_url":"https://api.github.com/users/fcoronelmakingsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcoronelmakingsense/subscriptions","organizations_url":"https://api.github.com/users/fcoronelmakingsense/orgs","repos_url":"https://api.github.com/users/fcoronelmakingsense/repos","events_url":"https://api.github.com/users/fcoronelmakingsense/events{/privacy}","received_events_url":"https://api.github.com/users/fcoronelmakingsense/received_events","type":"User","site_admin":false},"body":"- change the name for a common name because it's a general error message","created_at":"2019-12-09T17:48:32Z","updated_at":"2019-12-09T18:07:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea28ef9d4821b36263cc3e428129a0c3eea6bd5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632/commits","review_comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632/comments","review_comment_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/632/comments","statuses_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/2768073e3a0b2b16f3faffdab2269d42c2272e45","head":{"label":"fcoronelmakingsense:general_error_messages","ref":"general_error_messages","sha":"2768073e3a0b2b16f3faffdab2269d42c2272e45","user":{"login":"fcoronelmakingsense","id":8861133,"node_id":"MDQ6VXNlcjg4NjExMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8861133?v=4","gravatar_id":"","url":"https://api.github.com/users/fcoronelmakingsense","html_url":"https://github.com/fcoronelmakingsense","followers_url":"https://api.github.com/users/fcoronelmakingsense/followers","following_url":"https://api.github.com/users/fcoronelmakingsense/following{/other_user}","gists_url":"https://api.github.com/users/fcoronelmakingsense/gists{/gist_id}","starred_url":"https://api.github.com/users/fcoronelmakingsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcoronelmakingsense/subscriptions","organizations_url":"https://api.github.com/users/fcoronelmakingsense/orgs","repos_url":"https://api.github.com/users/fcoronelmakingsense/repos","events_url":"https://api.github.com/users/fcoronelmakingsense/events{/privacy}","received_events_url":"https://api.github.com/users/fcoronelmakingsense/received_events","type":"User","site_admin":false},"repo":{"id":160521853,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1MjE4NTM=","name":"doppler-webapp","full_name":"fcoronelmakingsense/doppler-webapp","private":false,"owner":{"login":"fcoronelmakingsense","id":8861133,"node_id":"MDQ6VXNlcjg4NjExMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8861133?v=4","gravatar_id":"","url":"https://api.github.com/users/fcoronelmakingsense","html_url":"https://github.com/fcoronelmakingsense","followers_url":"https://api.github.com/users/fcoronelmakingsense/followers","following_url":"https://api.github.com/users/fcoronelmakingsense/following{/other_user}","gists_url":"https://api.github.com/users/fcoronelmakingsense/gists{/gist_id}","starred_url":"https://api.github.com/users/fcoronelmakingsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcoronelmakingsense/subscriptions","organizations_url":"https://api.github.com/users/fcoronelmakingsense/orgs","repos_url":"https://api.github.com/users/fcoronelmakingsense/repos","events_url":"https://api.github.com/users/fcoronelmakingsense/events{/privacy}","received_events_url":"https://api.github.com/users/fcoronelmakingsense/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fcoronelmakingsense/doppler-webapp","description":null,"fork":true,"url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp","forks_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/forks","keys_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/teams","hooks_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/hooks","issue_events_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/events","assignees_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/tags","blobs_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/languages","stargazers_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/stargazers","contributors_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/contributors","subscribers_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/subscribers","subscription_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/subscription","commits_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/merges","archive_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/downloads","issues_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/labels{/name}","releases_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/fcoronelmakingsense/doppler-webapp/deployments","created_at":"2018-12-05T13:23:52Z","updated_at":"2018-12-05T13:23:55Z","pushed_at":"2019-12-09T18:07:14Z","git_url":"git://github.com/fcoronelmakingsense/doppler-webapp.git","ssh_url":"git@github.com:fcoronelmakingsense/doppler-webapp.git","clone_url":"https://github.com/fcoronelmakingsense/doppler-webapp.git","svn_url":"https://github.com/fcoronelmakingsense/doppler-webapp","homepage":null,"size":8433,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FromDoppler:master","ref":"master","sha":"10a904c7fb8a3a09571258d5294e2ca98804397a","user":{"login":"FromDoppler","id":21225122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjI1MTIy","avatar_url":"https://avatars3.githubusercontent.com/u/21225122?v=4","gravatar_id":"","url":"https://api.github.com/users/FromDoppler","html_url":"https://github.com/FromDoppler","followers_url":"https://api.github.com/users/FromDoppler/followers","following_url":"https://api.github.com/users/FromDoppler/following{/other_user}","gists_url":"https://api.github.com/users/FromDoppler/gists{/gist_id}","starred_url":"https://api.github.com/users/FromDoppler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FromDoppler/subscriptions","organizations_url":"https://api.github.com/users/FromDoppler/orgs","repos_url":"https://api.github.com/users/FromDoppler/repos","events_url":"https://api.github.com/users/FromDoppler/events{/privacy}","received_events_url":"https://api.github.com/users/FromDoppler/received_events","type":"Organization","site_admin":false},"repo":{"id":160403660,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDM2NjA=","name":"doppler-webapp","full_name":"FromDoppler/doppler-webapp","private":false,"owner":{"login":"FromDoppler","id":21225122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjI1MTIy","avatar_url":"https://avatars3.githubusercontent.com/u/21225122?v=4","gravatar_id":"","url":"https://api.github.com/users/FromDoppler","html_url":"https://github.com/FromDoppler","followers_url":"https://api.github.com/users/FromDoppler/followers","following_url":"https://api.github.com/users/FromDoppler/following{/other_user}","gists_url":"https://api.github.com/users/FromDoppler/gists{/gist_id}","starred_url":"https://api.github.com/users/FromDoppler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FromDoppler/subscriptions","organizations_url":"https://api.github.com/users/FromDoppler/orgs","repos_url":"https://api.github.com/users/FromDoppler/repos","events_url":"https://api.github.com/users/FromDoppler/events{/privacy}","received_events_url":"https://api.github.com/users/FromDoppler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FromDoppler/doppler-webapp","description":null,"fork":false,"url":"https://api.github.com/repos/FromDoppler/doppler-webapp","forks_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/forks","keys_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/teams","hooks_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/hooks","issue_events_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/events","assignees_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/tags","blobs_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/languages","stargazers_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/stargazers","contributors_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/contributors","subscribers_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/subscribers","subscription_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/subscription","commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/merges","archive_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/downloads","issues_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/labels{/name}","releases_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/deployments","created_at":"2018-12-04T18:47:26Z","updated_at":"2019-12-09T13:01:26Z","pushed_at":"2019-12-09T18:07:15Z","git_url":"git://github.com/FromDoppler/doppler-webapp.git","ssh_url":"git@github.com:FromDoppler/doppler-webapp.git","clone_url":"https://github.com/FromDoppler/doppler-webapp.git","svn_url":"https://github.com/FromDoppler/doppler-webapp","homepage":null,"size":9231,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":12,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632"},"html":{"href":"https://github.com/FromDoppler/doppler-webapp/pull/632"},"issue":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/632"},"comments":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/2768073e3a0b2b16f3faffdab2269d42c2272e45"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 160403660,
"name": "FromDoppler/doppler-webapp",
"url": "https://api.github.com/repos/FromDoppler/doppler-webapp"
}
|
{
"id": 2439363,
"login": "cbernat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2439363?",
"url": "https://api.github.com/users/cbernat"
}
|
{
"id": 21225122,
"login": "FromDoppler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21225122?",
"url": "https://api.github.com/orgs/FromDoppler"
}
| 2019-12-09T18:07:46 |
11047052679
|
{"actor":{"display_login":"cbernat"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments/298300256","pull_request_review_id":255389131,"id":298300256,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5ODMwMDI1Ng==","diff_hunk":"@@ -12,7 +13,9 @@ const Notifications = ({ plan, notifications, emptyNotificationText }) => {\n <div className=\"user-menu helper--right dp-notifications\">\n <div className=\"dp-msj-notif\">\n {!showNotifications ? (\n- <i>{emptyNotificationText}</i>\n+ <i>\n+ <FormattedMessage id=\"empty_notification_text\" />\n+ </i>","path":"src/components/Header/Notifications.js","position":22,"original_position":16,"commit_id":"1ac38680dc7c9937260474e69cf6abf8e9391a0d","original_commit_id":"7bf81f9251e625ee1f47244a02dd3bb255989df2","user":{"login":"andresmoschini","id":1157864,"node_id":"MDQ6VXNlcjExNTc4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1157864?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmoschini","html_url":"https://github.com/andresmoschini","followers_url":"https://api.github.com/users/andresmoschini/followers","following_url":"https://api.github.com/users/andresmoschini/following{/other_user}","gists_url":"https://api.github.com/users/andresmoschini/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmoschini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmoschini/subscriptions","organizations_url":"https://api.github.com/users/andresmoschini/orgs","repos_url":"https://api.github.com/users/andresmoschini/repos","events_url":"https://api.github.com/users/andresmoschini/events{/privacy}","received_events_url":"https://api.github.com/users/andresmoschini/received_events","type":"User","site_admin":false},"body":"La ventaja de intentar tomarlo desde el backend es que por defecto vamos a tener consistencia con el comportamiento actual de Doppler, pero agregamos un poquito de complejidad.\r\n\r\nNo tengo una posición fuerte en este tema.","created_at":"2019-06-27T17:59:50Z","updated_at":"2019-06-27T17:59:51Z","html_url":"https://github.com/FromDoppler/doppler-webapp/pull/268#discussion_r298300256","pull_request_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments/298300256"},"html":{"href":"https://github.com/FromDoppler/doppler-webapp/pull/268#discussion_r298300256"},"pull_request":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268"}},"in_reply_to_id":298198671},"pull_request":{"url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268","id":291133268,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMTMzMjY4","html_url":"https://github.com/FromDoppler/doppler-webapp/pull/268","diff_url":"https://github.com/FromDoppler/doppler-webapp/pull/268.diff","patch_url":"https://github.com/FromDoppler/doppler-webapp/pull/268.patch","issue_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/268","number":268,"state":"open","locked":false,"title":"feat: add notifications","user":{"login":"GusBaamonde","id":46735526,"node_id":"MDQ6VXNlcjQ2NzM1NTI2","avatar_url":"https://avatars0.githubusercontent.com/u/46735526?v=4","gravatar_id":"","url":"https://api.github.com/users/GusBaamonde","html_url":"https://github.com/GusBaamonde","followers_url":"https://api.github.com/users/GusBaamonde/followers","following_url":"https://api.github.com/users/GusBaamonde/following{/other_user}","gists_url":"https://api.github.com/users/GusBaamonde/gists{/gist_id}","starred_url":"https://api.github.com/users/GusBaamonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GusBaamonde/subscriptions","organizations_url":"https://api.github.com/users/GusBaamonde/orgs","repos_url":"https://api.github.com/users/GusBaamonde/repos","events_url":"https://api.github.com/users/GusBaamonde/events{/privacy}","received_events_url":"https://api.github.com/users/GusBaamonde/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2019-06-24T13:28:30Z","updated_at":"2019-06-27T17:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40bcc09d7055e4e23995f72d7029c8e34b4838e3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cbernat","id":2439363,"node_id":"MDQ6VXNlcjI0MzkzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2439363?v=4","gravatar_id":"","url":"https://api.github.com/users/cbernat","html_url":"https://github.com/cbernat","followers_url":"https://api.github.com/users/cbernat/followers","following_url":"https://api.github.com/users/cbernat/following{/other_user}","gists_url":"https://api.github.com/users/cbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/cbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbernat/subscriptions","organizations_url":"https://api.github.com/users/cbernat/orgs","repos_url":"https://api.github.com/users/cbernat/repos","events_url":"https://api.github.com/users/cbernat/events{/privacy}","received_events_url":"https://api.github.com/users/cbernat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268/commits","review_comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268/comments","review_comment_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/268/comments","statuses_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/1ac38680dc7c9937260474e69cf6abf8e9391a0d","head":{"label":"GusBaamonde:show_upgrade_or_trial_bell","ref":"show_upgrade_or_trial_bell","sha":"1ac38680dc7c9937260474e69cf6abf8e9391a0d","user":{"login":"GusBaamonde","id":46735526,"node_id":"MDQ6VXNlcjQ2NzM1NTI2","avatar_url":"https://avatars0.githubusercontent.com/u/46735526?v=4","gravatar_id":"","url":"https://api.github.com/users/GusBaamonde","html_url":"https://github.com/GusBaamonde","followers_url":"https://api.github.com/users/GusBaamonde/followers","following_url":"https://api.github.com/users/GusBaamonde/following{/other_user}","gists_url":"https://api.github.com/users/GusBaamonde/gists{/gist_id}","starred_url":"https://api.github.com/users/GusBaamonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GusBaamonde/subscriptions","organizations_url":"https://api.github.com/users/GusBaamonde/orgs","repos_url":"https://api.github.com/users/GusBaamonde/repos","events_url":"https://api.github.com/users/GusBaamonde/events{/privacy}","received_events_url":"https://api.github.com/users/GusBaamonde/received_events","type":"User","site_admin":false},"repo":{"id":169294757,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkyOTQ3NTc=","name":"doppler-webapp","full_name":"GusBaamonde/doppler-webapp","private":false,"owner":{"login":"GusBaamonde","id":46735526,"node_id":"MDQ6VXNlcjQ2NzM1NTI2","avatar_url":"https://avatars0.githubusercontent.com/u/46735526?v=4","gravatar_id":"","url":"https://api.github.com/users/GusBaamonde","html_url":"https://github.com/GusBaamonde","followers_url":"https://api.github.com/users/GusBaamonde/followers","following_url":"https://api.github.com/users/GusBaamonde/following{/other_user}","gists_url":"https://api.github.com/users/GusBaamonde/gists{/gist_id}","starred_url":"https://api.github.com/users/GusBaamonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GusBaamonde/subscriptions","organizations_url":"https://api.github.com/users/GusBaamonde/orgs","repos_url":"https://api.github.com/users/GusBaamonde/repos","events_url":"https://api.github.com/users/GusBaamonde/events{/privacy}","received_events_url":"https://api.github.com/users/GusBaamonde/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GusBaamonde/doppler-webapp","description":null,"fork":true,"url":"https://api.github.com/repos/GusBaamonde/doppler-webapp","forks_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/forks","keys_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/teams","hooks_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/hooks","issue_events_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/events","assignees_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/tags","blobs_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/languages","stargazers_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/stargazers","contributors_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/contributors","subscribers_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/subscribers","subscription_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/subscription","commits_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/merges","archive_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/downloads","issues_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/labels{/name}","releases_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/GusBaamonde/doppler-webapp/deployments","created_at":"2019-02-05T18:58:27Z","updated_at":"2019-02-08T20:35:54Z","pushed_at":"2019-06-27T16:33:19Z","git_url":"git://github.com/GusBaamonde/doppler-webapp.git","ssh_url":"git@github.com:GusBaamonde/doppler-webapp.git","clone_url":"https://github.com/GusBaamonde/doppler-webapp.git","svn_url":"https://github.com/GusBaamonde/doppler-webapp","homepage":null,"size":2409,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FromDoppler:master","ref":"master","sha":"4c9027c03bfb3584930b20ea2af5e371fb693943","user":{"login":"FromDoppler","id":21225122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjI1MTIy","avatar_url":"https://avatars3.githubusercontent.com/u/21225122?v=4","gravatar_id":"","url":"https://api.github.com/users/FromDoppler","html_url":"https://github.com/FromDoppler","followers_url":"https://api.github.com/users/FromDoppler/followers","following_url":"https://api.github.com/users/FromDoppler/following{/other_user}","gists_url":"https://api.github.com/users/FromDoppler/gists{/gist_id}","starred_url":"https://api.github.com/users/FromDoppler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FromDoppler/subscriptions","organizations_url":"https://api.github.com/users/FromDoppler/orgs","repos_url":"https://api.github.com/users/FromDoppler/repos","events_url":"https://api.github.com/users/FromDoppler/events{/privacy}","received_events_url":"https://api.github.com/users/FromDoppler/received_events","type":"Organization","site_admin":false},"repo":{"id":160403660,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDM2NjA=","name":"doppler-webapp","full_name":"FromDoppler/doppler-webapp","private":false,"owner":{"login":"FromDoppler","id":21225122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjI1MTIy","avatar_url":"https://avatars3.githubusercontent.com/u/21225122?v=4","gravatar_id":"","url":"https://api.github.com/users/FromDoppler","html_url":"https://github.com/FromDoppler","followers_url":"https://api.github.com/users/FromDoppler/followers","following_url":"https://api.github.com/users/FromDoppler/following{/other_user}","gists_url":"https://api.github.com/users/FromDoppler/gists{/gist_id}","starred_url":"https://api.github.com/users/FromDoppler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FromDoppler/subscriptions","organizations_url":"https://api.github.com/users/FromDoppler/orgs","repos_url":"https://api.github.com/users/FromDoppler/repos","events_url":"https://api.github.com/users/FromDoppler/events{/privacy}","received_events_url":"https://api.github.com/users/FromDoppler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FromDoppler/doppler-webapp","description":null,"fork":false,"url":"https://api.github.com/repos/FromDoppler/doppler-webapp","forks_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/forks","keys_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/teams","hooks_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/hooks","issue_events_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/events","assignees_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/tags","blobs_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/languages","stargazers_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/stargazers","contributors_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/contributors","subscribers_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/subscribers","subscription_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/subscription","commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/merges","archive_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/downloads","issues_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/labels{/name}","releases_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/deployments","created_at":"2018-12-04T18:47:26Z","updated_at":"2019-06-27T17:14:21Z","pushed_at":"2019-06-27T17:38:51Z","git_url":"git://github.com/FromDoppler/doppler-webapp.git","ssh_url":"git@github.com:FromDoppler/doppler-webapp.git","clone_url":"https://github.com/FromDoppler/doppler-webapp.git","svn_url":"https://github.com/FromDoppler/doppler-webapp","homepage":null,"size":2643,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":12,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268"},"html":{"href":"https://github.com/FromDoppler/doppler-webapp/pull/268"},"issue":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/268"},"comments":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/1ac38680dc7c9937260474e69cf6abf8e9391a0d"}},"author_association":"COLLABORATOR"}}
|
{
"id": 160403660,
"name": "FromDoppler/doppler-webapp",
"url": "https://api.github.com/repos/FromDoppler/doppler-webapp"
}
|
{
"id": 1157864,
"login": "andresmoschini",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1157864?",
"url": "https://api.github.com/users/andresmoschini"
}
|
{
"id": 21225122,
"login": "FromDoppler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21225122?",
"url": "https://api.github.com/orgs/FromDoppler"
}
| 2019-06-27T17:59:50 |
9908326275
|
{"actor":{"display_login":"andresmoschini"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/comments/263392045","pull_request_review_id":211793853,"id":263392045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzM5MjA0NQ==","diff_hunk":"@@ -0,0 +1,64 @@\n+import R from 'ramda'\n+import { AsyncStorage } from 'react-native'\n+\n+const msPerDay = 24*60*60*1000\n+export const imageLabels = ['Awful', 'Poor', 'Average', 'Good', 'Great']\n+\n+export const emojiSrc = [\n+ {\n+ unselected: require('../assets/Emojis/Simple/Awful.png'),\n+ selected: require('../assets/Emojis/Color/Awful.png')\n+ },\n+ {\n+ unselected: require('../assets/Emojis/Simple/Poor.png'),\n+ selected: require('../assets/Emojis/Color/Poor.png')\n+ },\n+ {\n+ unselected: require('../assets/Emojis/Simple/Average.png'),\n+ selected: require('../assets/Emojis/Color/Average.png')\n+ },\n+ {\n+ unselected: require('../assets/Emojis/Simple/Good.png'),\n+ selected: require('../assets/Emojis/Color/Good.png')\n+ },\n+ {\n+ unselected: require('../assets/Emojis/Simple/Great.png'),\n+ selected: require('../assets/Emojis/Color/Great.png')\n+ }\n+]\n+\n+export const star = {\n+ unselected: require('../assets/Stars/simple.png'),\n+ selected: require('../assets/Stars/color.png')\n+}\n+\n+export function setAlpha(color, alpha) {\n+ const alphaValue = (() => {\n+ const hex = Math.floor(R.clamp(0, 100, alpha) * (255 / 100)).toString(16)\n+ if (hex.length === 1) {\n+ return `0${hex}`\n+ }\n+ return hex\n+ })()\n+ return color.substring(0, 7) + alphaValue // Format: #rrggbbaa\n+}\n+\n+export function getCurrentTime() {\n+ return (new Date().getTime() / msPerDay)\n+}\n+\n+export function setShowDate(ratings = 0, noOfDays) {\n+ const today = getCurrentTime()\n+ const nextTime = today + noOfDays","path":"src/utils.js","position":52,"original_position":52,"commit_id":"a078b96b8f02f90e04b41998b5c657e45a13fdae","original_commit_id":"a078b96b8f02f90e04b41998b5c657e45a13fdae","user":{"login":"jitendralakhmani-proptiger","id":47135295,"node_id":"MDQ6VXNlcjQ3MTM1Mjk1","avatar_url":"https://avatars2.githubusercontent.com/u/47135295?v=4","gravatar_id":"","url":"https://api.github.com/users/jitendralakhmani-proptiger","html_url":"https://github.com/jitendralakhmani-proptiger","followers_url":"https://api.github.com/users/jitendralakhmani-proptiger/followers","following_url":"https://api.github.com/users/jitendralakhmani-proptiger/following{/other_user}","gists_url":"https://api.github.com/users/jitendralakhmani-proptiger/gists{/gist_id}","starred_url":"https://api.github.com/users/jitendralakhmani-proptiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitendralakhmani-proptiger/subscriptions","organizations_url":"https://api.github.com/users/jitendralakhmani-proptiger/orgs","repos_url":"https://api.github.com/users/jitendralakhmani-proptiger/repos","events_url":"https://api.github.com/users/jitendralakhmani-proptiger/events{/privacy}","received_events_url":"https://api.github.com/users/jitendralakhmani-proptiger/received_events","type":"User","site_admin":false},"body":"We can store unix milli sec","created_at":"2019-03-07T13:56:46Z","updated_at":"2019-03-07T13:56:47Z","html_url":"https://github.com/housinghq/react-native-app-rater/pull/1#discussion_r263392045","pull_request_url":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/comments/263392045"},"html":{"href":"https://github.com/housinghq/react-native-app-rater/pull/1#discussion_r263392045"},"pull_request":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1","id":258702370,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4NzAyMzcw","html_url":"https://github.com/housinghq/react-native-app-rater/pull/1","diff_url":"https://github.com/housinghq/react-native-app-rater/pull/1.diff","patch_url":"https://github.com/housinghq/react-native-app-rater/pull/1.patch","issue_url":"https://api.github.com/repos/housinghq/react-native-app-rater/issues/1","number":1,"state":"open","locked":false,"title":"App Rating Library","user":{"login":"manthan-25","id":47346562,"node_id":"MDQ6VXNlcjQ3MzQ2NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/47346562?v=4","gravatar_id":"","url":"https://api.github.com/users/manthan-25","html_url":"https://github.com/manthan-25","followers_url":"https://api.github.com/users/manthan-25/followers","following_url":"https://api.github.com/users/manthan-25/following{/other_user}","gists_url":"https://api.github.com/users/manthan-25/gists{/gist_id}","starred_url":"https://api.github.com/users/manthan-25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manthan-25/subscriptions","organizations_url":"https://api.github.com/users/manthan-25/orgs","repos_url":"https://api.github.com/users/manthan-25/repos","events_url":"https://api.github.com/users/manthan-25/events{/privacy}","received_events_url":"https://api.github.com/users/manthan-25/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-06T12:36:40Z","updated_at":"2019-03-07T13:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d387b182a6682e75f4b6f6b4796e2088c4d95aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1/commits","review_comments_url":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1/comments","review_comment_url":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/comments{/number}","comments_url":"https://api.github.com/repos/housinghq/react-native-app-rater/issues/1/comments","statuses_url":"https://api.github.com/repos/housinghq/react-native-app-rater/statuses/a078b96b8f02f90e04b41998b5c657e45a13fdae","head":{"label":"manthan-25:rate-app","ref":"rate-app","sha":"a078b96b8f02f90e04b41998b5c657e45a13fdae","user":{"login":"manthan-25","id":47346562,"node_id":"MDQ6VXNlcjQ3MzQ2NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/47346562?v=4","gravatar_id":"","url":"https://api.github.com/users/manthan-25","html_url":"https://github.com/manthan-25","followers_url":"https://api.github.com/users/manthan-25/followers","following_url":"https://api.github.com/users/manthan-25/following{/other_user}","gists_url":"https://api.github.com/users/manthan-25/gists{/gist_id}","starred_url":"https://api.github.com/users/manthan-25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manthan-25/subscriptions","organizations_url":"https://api.github.com/users/manthan-25/orgs","repos_url":"https://api.github.com/users/manthan-25/repos","events_url":"https://api.github.com/users/manthan-25/events{/privacy}","received_events_url":"https://api.github.com/users/manthan-25/received_events","type":"User","site_admin":false},"repo":{"id":174139678,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQxMzk2Nzg=","name":"react-native-app-rater","full_name":"manthan-25/react-native-app-rater","private":false,"owner":{"login":"manthan-25","id":47346562,"node_id":"MDQ6VXNlcjQ3MzQ2NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/47346562?v=4","gravatar_id":"","url":"https://api.github.com/users/manthan-25","html_url":"https://github.com/manthan-25","followers_url":"https://api.github.com/users/manthan-25/followers","following_url":"https://api.github.com/users/manthan-25/following{/other_user}","gists_url":"https://api.github.com/users/manthan-25/gists{/gist_id}","starred_url":"https://api.github.com/users/manthan-25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manthan-25/subscriptions","organizations_url":"https://api.github.com/users/manthan-25/orgs","repos_url":"https://api.github.com/users/manthan-25/repos","events_url":"https://api.github.com/users/manthan-25/events{/privacy}","received_events_url":"https://api.github.com/users/manthan-25/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manthan-25/react-native-app-rater","description":null,"fork":true,"url":"https://api.github.com/repos/manthan-25/react-native-app-rater","forks_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/forks","keys_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/teams","hooks_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/hooks","issue_events_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/issues/events{/number}","events_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/events","assignees_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/assignees{/user}","branches_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/branches{/branch}","tags_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/tags","blobs_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/git/refs{/sha}","trees_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/statuses/{sha}","languages_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/languages","stargazers_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/stargazers","contributors_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/contributors","subscribers_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/subscribers","subscription_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/subscription","commits_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/commits{/sha}","git_commits_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/git/commits{/sha}","comments_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/comments{/number}","issue_comment_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/issues/comments{/number}","contents_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/contents/{+path}","compare_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/merges","archive_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/downloads","issues_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/issues{/number}","pulls_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/pulls{/number}","milestones_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/milestones{/number}","notifications_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/labels{/name}","releases_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/releases{/id}","deployments_url":"https://api.github.com/repos/manthan-25/react-native-app-rater/deployments","created_at":"2019-03-06T12:19:38Z","updated_at":"2019-03-06T12:19:41Z","pushed_at":"2019-03-07T09:47:03Z","git_url":"git://github.com/manthan-25/react-native-app-rater.git","ssh_url":"git@github.com:manthan-25/react-native-app-rater.git","clone_url":"https://github.com/manthan-25/react-native-app-rater.git","svn_url":"https://github.com/manthan-25/react-native-app-rater","homepage":null,"size":105,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"housinghq:master","ref":"master","sha":"45cc1b447365c6ffb248c5cc68459bdb28908116","user":{"login":"housinghq","id":21362788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzYyNzg4","avatar_url":"https://avatars1.githubusercontent.com/u/21362788?v=4","gravatar_id":"","url":"https://api.github.com/users/housinghq","html_url":"https://github.com/housinghq","followers_url":"https://api.github.com/users/housinghq/followers","following_url":"https://api.github.com/users/housinghq/following{/other_user}","gists_url":"https://api.github.com/users/housinghq/gists{/gist_id}","starred_url":"https://api.github.com/users/housinghq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/housinghq/subscriptions","organizations_url":"https://api.github.com/users/housinghq/orgs","repos_url":"https://api.github.com/users/housinghq/repos","events_url":"https://api.github.com/users/housinghq/events{/privacy}","received_events_url":"https://api.github.com/users/housinghq/received_events","type":"Organization","site_admin":false},"repo":{"id":174119342,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQxMTkzNDI=","name":"react-native-app-rater","full_name":"housinghq/react-native-app-rater","private":false,"owner":{"login":"housinghq","id":21362788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzYyNzg4","avatar_url":"https://avatars1.githubusercontent.com/u/21362788?v=4","gravatar_id":"","url":"https://api.github.com/users/housinghq","html_url":"https://github.com/housinghq","followers_url":"https://api.github.com/users/housinghq/followers","following_url":"https://api.github.com/users/housinghq/following{/other_user}","gists_url":"https://api.github.com/users/housinghq/gists{/gist_id}","starred_url":"https://api.github.com/users/housinghq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/housinghq/subscriptions","organizations_url":"https://api.github.com/users/housinghq/orgs","repos_url":"https://api.github.com/users/housinghq/repos","events_url":"https://api.github.com/users/housinghq/events{/privacy}","received_events_url":"https://api.github.com/users/housinghq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/housinghq/react-native-app-rater","description":null,"fork":false,"url":"https://api.github.com/repos/housinghq/react-native-app-rater","forks_url":"https://api.github.com/repos/housinghq/react-native-app-rater/forks","keys_url":"https://api.github.com/repos/housinghq/react-native-app-rater/keys{/key_id}","collaborators_url":"https://api.github.com/repos/housinghq/react-native-app-rater/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/housinghq/react-native-app-rater/teams","hooks_url":"https://api.github.com/repos/housinghq/react-native-app-rater/hooks","issue_events_url":"https://api.github.com/repos/housinghq/react-native-app-rater/issues/events{/number}","events_url":"https://api.github.com/repos/housinghq/react-native-app-rater/events","assignees_url":"https://api.github.com/repos/housinghq/react-native-app-rater/assignees{/user}","branches_url":"https://api.github.com/repos/housinghq/react-native-app-rater/branches{/branch}","tags_url":"https://api.github.com/repos/housinghq/react-native-app-rater/tags","blobs_url":"https://api.github.com/repos/housinghq/react-native-app-rater/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/housinghq/react-native-app-rater/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/housinghq/react-native-app-rater/git/refs{/sha}","trees_url":"https://api.github.com/repos/housinghq/react-native-app-rater/git/trees{/sha}","statuses_url":"https://api.github.com/repos/housinghq/react-native-app-rater/statuses/{sha}","languages_url":"https://api.github.com/repos/housinghq/react-native-app-rater/languages","stargazers_url":"https://api.github.com/repos/housinghq/react-native-app-rater/stargazers","contributors_url":"https://api.github.com/repos/housinghq/react-native-app-rater/contributors","subscribers_url":"https://api.github.com/repos/housinghq/react-native-app-rater/subscribers","subscription_url":"https://api.github.com/repos/housinghq/react-native-app-rater/subscription","commits_url":"https://api.github.com/repos/housinghq/react-native-app-rater/commits{/sha}","git_commits_url":"https://api.github.com/repos/housinghq/react-native-app-rater/git/commits{/sha}","comments_url":"https://api.github.com/repos/housinghq/react-native-app-rater/comments{/number}","issue_comment_url":"https://api.github.com/repos/housinghq/react-native-app-rater/issues/comments{/number}","contents_url":"https://api.github.com/repos/housinghq/react-native-app-rater/contents/{+path}","compare_url":"https://api.github.com/repos/housinghq/react-native-app-rater/compare/{base}...{head}","merges_url":"https://api.github.com/repos/housinghq/react-native-app-rater/merges","archive_url":"https://api.github.com/repos/housinghq/react-native-app-rater/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/housinghq/react-native-app-rater/downloads","issues_url":"https://api.github.com/repos/housinghq/react-native-app-rater/issues{/number}","pulls_url":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls{/number}","milestones_url":"https://api.github.com/repos/housinghq/react-native-app-rater/milestones{/number}","notifications_url":"https://api.github.com/repos/housinghq/react-native-app-rater/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/housinghq/react-native-app-rater/labels{/name}","releases_url":"https://api.github.com/repos/housinghq/react-native-app-rater/releases{/id}","deployments_url":"https://api.github.com/repos/housinghq/react-native-app-rater/deployments","created_at":"2019-03-06T10:00:43Z","updated_at":"2019-03-06T10:00:46Z","pushed_at":"2019-03-07T09:47:05Z","git_url":"git://github.com/housinghq/react-native-app-rater.git","ssh_url":"git@github.com:housinghq/react-native-app-rater.git","clone_url":"https://github.com/housinghq/react-native-app-rater.git","svn_url":"https://github.com/housinghq/react-native-app-rater","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1"},"html":{"href":"https://github.com/housinghq/react-native-app-rater/pull/1"},"issue":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/issues/1"},"comments":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/housinghq/react-native-app-rater/statuses/a078b96b8f02f90e04b41998b5c657e45a13fdae"}},"author_association":"NONE"}}
|
{
"id": 174119342,
"name": "housinghq/react-native-app-rater",
"url": "https://api.github.com/repos/housinghq/react-native-app-rater"
}
|
{
"id": 47135295,
"login": "jitendralakhmani-proptiger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47135295?",
"url": "https://api.github.com/users/jitendralakhmani-proptiger"
}
|
{
"id": 21362788,
"login": "housinghq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21362788?",
"url": "https://api.github.com/orgs/housinghq"
}
| 2019-03-07T13:56:46 |
9198960282
|
{"actor":{"display_login":"jitendralakhmani-proptiger"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/uclapi/uclapi/pulls/comments/287117259","pull_request_review_id":241428769,"id":287117259,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzExNzI1OQ==","diff_hunk":"@@ -84,3 +84,76 @@ class OccupEyeConstants():\n # Set a filter for surveys designed for staff only\r\n STAFF_SURVEY_IDS = [59]\r\n VALID_SURVEY_FILTERS = [\"all\", \"staff\", \"student\"]\r\n+\r\n+ # address mapping\r\n+\r\n+ SURVEY_LOCATIONS = {\r\n+ \"UCL Torrington 1-19 113\": {\r\n+ \"lat\": \"51.521886\", \"long\": \"-0.134415\",\r\n+ \"address\": [\"1-19 Torrington Pl\", \"Fitzrovia\", \"London\", \"WC1E 7HB\"]\r\n+ },\r\n+ \"UCL Student Centre\": {\"lat\": \"51.524916\", \"long\": \"-0.132371\",\r\n+ \"address\": [\"27-28 Gordon Square\", \"Bloomsbury\", \"London\", \"WC1H 0AH\"]},\r\n+ \"UCL SSEES Library\": {\"lat\": \"51.525342\", \"long\": \"-0.131602\",\r\n+ \"address\": [\"16 Taviton St\", \"Bloomsbury\", \"London\", \"WC1H 0BW\"]},\r\n+ \"UCL SENIT Suite\": {\"lat\": \"51.524280\", \"long\": \"-0.133026\",\r\n+ \"address\": [\"Senit Suite\", \"Kings Cross\", \"London\", \"WC1E 6BT\"]},\r\n+ \"UCL Senate House Hub\": {\"lat\": \"51.521094\", \"long\": \"-0.128735\",\r\n+ \"address\": [\"Senate House University of London\", \"Malet St\", \"London\", \"WC1E 7HU\"]},\r\n+ \"UCL Science Library\": {\"lat\": \"51.523556\", \"long\": \"-0.132588\",\r\n+ \"address\": [\"Malet Pl\", \"Bloomsbury\", \"London\", \"WC1E\"]},\r\n+ \"UCL School of Pharmacy Library\": {\"lat\": \"51.524967\", \"long\": \"-0.122872\",\r\n+ \"address\": [\"29-39 Brunswick Square\", \"Bloomsbury\", \"London\", \"WC1N 1AX\"]},\r\n+ \"UCL Main Library\": {\"lat\": \"51.524748\", \"long\": \"-0.133535\",\r\n+ \"address\": [\"Gower St\", \"Bloomsbury\", \"London\", \"WC1E 6BT\"]},\r\n+ \"UCL Language & Speech Science Library\": {\"lat\": \"51.525847\", \"long\": \"-0.122785\",\r\n+ \"address\": [\"2 Wakefield St\", \"Kings Cross\", \"London\" , \"WC1N 1PJ\"]},\r\n+ \"UCL Institute of Orthopaedics Library\": {\"lat\": \"51.631529\", \"long\": \"-0.306551\",\r\n+ \"address\": [\"Sir Herbert Seddon Teaching Centre\", \"Royal National Orthopaedic Hospital\", \"Brockley Hill, Stanmore\", \"HA7 4LP\"]},\r\n+ \"UCL Institute of Neurology, Queen Square Library\": {\"lat\": \"51.522398\", \"long\": \"-0.122973\",\r\n+ \"address\": [\"23 Queen Square\", \"London\" , \"WC1N 3BG\", \"\"]},\r\n+ \"UCL Institute of Education Library\": {\"lat\": \"51.522897\", \"long\": \"-0.127864\",\r\n+ \"address\": [\"Newsam Library and Archives\", \"20 Bedford Way\", \"London\", \"WC1H 0AL\"]},\r\n+ \"UCL Institute of Archaeology Library\": {\"lat\": \"51.524906\", \"long\": \"-0.131578\",\r\n+ \"address\": [\"5th Floor\", \"Institute of Archaeology\", \"31-34 Gordon Square\", \"WC1H 0PY\"]},\r\n+ \"UCL Great Ormond Street Institute of Child Health Library\": {\"lat\": \"51.5232287\", \"long\": \"-0.1200982\",\r\n+ \"address\": [\"UCL Great Ormond Street Institue of Child Health\", \"30 Guilford Street\", \"London\", \"WC1N 1EH\"]},\r\n+ \"UCL Eastman Dental Library\": {\"lat\": \"51.526314\", \"long\": \"-0.117660\",\r\n+ \"address\": [\"256 Gray's Inn Road\", \"King's Cross\", \"London\", \"WC1X 8LD\"]},\r\n+ \"UCL Ear Institute & Hearing Loss Library\": {\"lat\": \"51.529268\", \"long\": \"-0.119571\",\r\n+ \"address\": [\"330-336 Grays Inn Rd\", \"Kings Cross\", \"London\", \"WC1X 8EE\"]},\r\n+ \"UCL Cruciform Hub\": {\"lat\": \"51.524054\", \"long\": \"-0.135032\",\r\n+ \"address\": [\"Gower St\", \"Fitzrovia\", \"London\" , \"WC1E 6BT\"]},\r\n+ \"UCL Christopher Ingold G20\": {\"lat\": \"51.525370\", \"long\": \"-0.132171\",\r\n+ \"address\": [\"20 Gordon St\", \"Kings Cross\", \"London\", \"WC1H 0AJ\"]},\r\n+ \"UCL chadwick B04\": {\"lat\": \"51.524233\", \"long\": \"-0.134336\",\r\n+ \"address\": [\"Gower St\", \"Bloomsbury\", \"London\", \"WC1E 6DE\"]},\r\n+ \"UCL Chadwick 223\": {\"lat\": \"51.524233\", \"long\": \"-0.134336\",\r\n+ \"address\": [\"Gower St\", \"Bloomsbury\", \"London\", \"WC1E 6DE\"]},\r","path":"backend/uclapi/workspaces/occupeye/constants.py","position":49,"original_position":49,"commit_id":"e7ee79332ce51c67c32e6b9a031113edbf3fd43d","original_commit_id":"e7ee79332ce51c67c32e6b9a031113edbf3fd43d","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"continuation line under-indented for visual indent","created_at":"2019-05-23T20:17:46Z","updated_at":"2019-05-23T20:17:51Z","html_url":"https://github.com/uclapi/uclapi/pull/1313#discussion_r287117259","pull_request_url":"https://api.github.com/repos/uclapi/uclapi/pulls/1313","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/uclapi/uclapi/pulls/comments/287117259"},"html":{"href":"https://github.com/uclapi/uclapi/pull/1313#discussion_r287117259"},"pull_request":{"href":"https://api.github.com/repos/uclapi/uclapi/pulls/1313"}}},"pull_request":{"url":"https://api.github.com/repos/uclapi/uclapi/pulls/1313","id":281764975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxNzY0OTc1","html_url":"https://github.com/uclapi/uclapi/pull/1313","diff_url":"https://github.com/uclapi/uclapi/pull/1313.diff","patch_url":"https://github.com/uclapi/uclapi/pull/1313.patch","issue_url":"https://api.github.com/repos/uclapi/uclapi/issues/1313","number":1313,"state":"open","locked":false,"title":"Provides locations for workspaces surveys","user":{"login":"zipy124","id":6547350,"node_id":"MDQ6VXNlcjY1NDczNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6547350?v=4","gravatar_id":"","url":"https://api.github.com/users/zipy124","html_url":"https://github.com/zipy124","followers_url":"https://api.github.com/users/zipy124/followers","following_url":"https://api.github.com/users/zipy124/following{/other_user}","gists_url":"https://api.github.com/users/zipy124/gists{/gist_id}","starred_url":"https://api.github.com/users/zipy124/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zipy124/subscriptions","organizations_url":"https://api.github.com/users/zipy124/orgs","repos_url":"https://api.github.com/users/zipy124/repos","events_url":"https://api.github.com/users/zipy124/events{/privacy}","received_events_url":"https://api.github.com/users/zipy124/received_events","type":"User","site_admin":false},"body":"## What does this PR do?\r\nas the title says. At cache we insert into the redis some hard coded locations. For code-review we should check all the address' are in the format we want (i wasn't sure about this) and think about potentially a better way to do this. Maybe we can search google maps api with the title of the room?\r\n\r\n## ✅ Pull Request checklist\r\n\r\n- [ ] Is this code complete?\r\n- [ ] Are tests done/modified?\r\n- [ ] Are docs written for this PR? (if applicable)\r\n\r\n## 🚨 Is this a breaking change for API clients?\r\nYes/No\r\n\r\n## :squirrel: Deploy notes\r\nFor example: Need to run migrations as part of deployment\r\n\r\n## Anything else\r\ncloses #1165 ","created_at":"2019-05-23T20:07:44Z","updated_at":"2019-05-23T20:17:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04221bc487b1c4940ff55fd5fa8b5d711df81a23","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ChristopherHammond13","id":295396,"node_id":"MDQ6VXNlcjI5NTM5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/295396?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristopherHammond13","html_url":"https://github.com/ChristopherHammond13","followers_url":"https://api.github.com/users/ChristopherHammond13/followers","following_url":"https://api.github.com/users/ChristopherHammond13/following{/other_user}","gists_url":"https://api.github.com/users/ChristopherHammond13/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristopherHammond13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristopherHammond13/subscriptions","organizations_url":"https://api.github.com/users/ChristopherHammond13/orgs","repos_url":"https://api.github.com/users/ChristopherHammond13/repos","events_url":"https://api.github.com/users/ChristopherHammond13/events{/privacy}","received_events_url":"https://api.github.com/users/ChristopherHammond13/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"UCL API Team","id":2220753,"node_id":"MDQ6VGVhbTIyMjA3NTM=","slug":"ucl-api-team","description":"Building an API for UCL","privacy":"closed","url":"https://api.github.com/teams/2220753","html_url":"https://github.com/orgs/uclapi/teams/ucl-api-team","members_url":"https://api.github.com/teams/2220753/members{/member}","repositories_url":"https://api.github.com/teams/2220753/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uclapi/uclapi/pulls/1313/commits","review_comments_url":"https://api.github.com/repos/uclapi/uclapi/pulls/1313/comments","review_comment_url":"https://api.github.com/repos/uclapi/uclapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uclapi/uclapi/issues/1313/comments","statuses_url":"https://api.github.com/repos/uclapi/uclapi/statuses/e7ee79332ce51c67c32e6b9a031113edbf3fd43d","head":{"label":"uclapi:library_location","ref":"library_location","sha":"e7ee79332ce51c67c32e6b9a031113edbf3fd43d","user":{"login":"uclapi","id":21985736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg1NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/21985736?v=4","gravatar_id":"","url":"https://api.github.com/users/uclapi","html_url":"https://github.com/uclapi","followers_url":"https://api.github.com/users/uclapi/followers","following_url":"https://api.github.com/users/uclapi/following{/other_user}","gists_url":"https://api.github.com/users/uclapi/gists{/gist_id}","starred_url":"https://api.github.com/users/uclapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclapi/subscriptions","organizations_url":"https://api.github.com/users/uclapi/orgs","repos_url":"https://api.github.com/users/uclapi/repos","events_url":"https://api.github.com/users/uclapi/events{/privacy}","received_events_url":"https://api.github.com/users/uclapi/received_events","type":"Organization","site_admin":false},"repo":{"id":76891826,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg5MTgyNg==","name":"uclapi","full_name":"uclapi/uclapi","private":false,"owner":{"login":"uclapi","id":21985736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg1NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/21985736?v=4","gravatar_id":"","url":"https://api.github.com/users/uclapi","html_url":"https://github.com/uclapi","followers_url":"https://api.github.com/users/uclapi/followers","following_url":"https://api.github.com/users/uclapi/following{/other_user}","gists_url":"https://api.github.com/users/uclapi/gists{/gist_id}","starred_url":"https://api.github.com/users/uclapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclapi/subscriptions","organizations_url":"https://api.github.com/users/uclapi/orgs","repos_url":"https://api.github.com/users/uclapi/repos","events_url":"https://api.github.com/users/uclapi/events{/privacy}","received_events_url":"https://api.github.com/users/uclapi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uclapi/uclapi","description":"An API for University College London, created for and by students!","fork":false,"url":"https://api.github.com/repos/uclapi/uclapi","forks_url":"https://api.github.com/repos/uclapi/uclapi/forks","keys_url":"https://api.github.com/repos/uclapi/uclapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclapi/uclapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclapi/uclapi/teams","hooks_url":"https://api.github.com/repos/uclapi/uclapi/hooks","issue_events_url":"https://api.github.com/repos/uclapi/uclapi/issues/events{/number}","events_url":"https://api.github.com/repos/uclapi/uclapi/events","assignees_url":"https://api.github.com/repos/uclapi/uclapi/assignees{/user}","branches_url":"https://api.github.com/repos/uclapi/uclapi/branches{/branch}","tags_url":"https://api.github.com/repos/uclapi/uclapi/tags","blobs_url":"https://api.github.com/repos/uclapi/uclapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclapi/uclapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclapi/uclapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclapi/uclapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclapi/uclapi/statuses/{sha}","languages_url":"https://api.github.com/repos/uclapi/uclapi/languages","stargazers_url":"https://api.github.com/repos/uclapi/uclapi/stargazers","contributors_url":"https://api.github.com/repos/uclapi/uclapi/contributors","subscribers_url":"https://api.github.com/repos/uclapi/uclapi/subscribers","subscription_url":"https://api.github.com/repos/uclapi/uclapi/subscription","commits_url":"https://api.github.com/repos/uclapi/uclapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclapi/uclapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclapi/uclapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclapi/uclapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/uclapi/uclapi/contents/{+path}","compare_url":"https://api.github.com/repos/uclapi/uclapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclapi/uclapi/merges","archive_url":"https://api.github.com/repos/uclapi/uclapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclapi/uclapi/downloads","issues_url":"https://api.github.com/repos/uclapi/uclapi/issues{/number}","pulls_url":"https://api.github.com/repos/uclapi/uclapi/pulls{/number}","milestones_url":"https://api.github.com/repos/uclapi/uclapi/milestones{/number}","notifications_url":"https://api.github.com/repos/uclapi/uclapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclapi/uclapi/labels{/name}","releases_url":"https://api.github.com/repos/uclapi/uclapi/releases{/id}","deployments_url":"https://api.github.com/repos/uclapi/uclapi/deployments","created_at":"2016-12-19T19:41:08Z","updated_at":"2019-05-23T16:46:36Z","pushed_at":"2019-05-23T20:17:41Z","git_url":"git://github.com/uclapi/uclapi.git","ssh_url":"git@github.com:uclapi/uclapi.git","clone_url":"https://github.com/uclapi/uclapi.git","svn_url":"https://github.com/uclapi/uclapi","homepage":"https://uclapi.com","size":36540,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":31,"watchers":22,"default_branch":"master"}},"base":{"label":"uclapi:master","ref":"master","sha":"a345647b9236e06e2bbef88698fd195fd297ad10","user":{"login":"uclapi","id":21985736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg1NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/21985736?v=4","gravatar_id":"","url":"https://api.github.com/users/uclapi","html_url":"https://github.com/uclapi","followers_url":"https://api.github.com/users/uclapi/followers","following_url":"https://api.github.com/users/uclapi/following{/other_user}","gists_url":"https://api.github.com/users/uclapi/gists{/gist_id}","starred_url":"https://api.github.com/users/uclapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclapi/subscriptions","organizations_url":"https://api.github.com/users/uclapi/orgs","repos_url":"https://api.github.com/users/uclapi/repos","events_url":"https://api.github.com/users/uclapi/events{/privacy}","received_events_url":"https://api.github.com/users/uclapi/received_events","type":"Organization","site_admin":false},"repo":{"id":76891826,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg5MTgyNg==","name":"uclapi","full_name":"uclapi/uclapi","private":false,"owner":{"login":"uclapi","id":21985736,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg1NzM2","avatar_url":"https://avatars1.githubusercontent.com/u/21985736?v=4","gravatar_id":"","url":"https://api.github.com/users/uclapi","html_url":"https://github.com/uclapi","followers_url":"https://api.github.com/users/uclapi/followers","following_url":"https://api.github.com/users/uclapi/following{/other_user}","gists_url":"https://api.github.com/users/uclapi/gists{/gist_id}","starred_url":"https://api.github.com/users/uclapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclapi/subscriptions","organizations_url":"https://api.github.com/users/uclapi/orgs","repos_url":"https://api.github.com/users/uclapi/repos","events_url":"https://api.github.com/users/uclapi/events{/privacy}","received_events_url":"https://api.github.com/users/uclapi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uclapi/uclapi","description":"An API for University College London, created for and by students!","fork":false,"url":"https://api.github.com/repos/uclapi/uclapi","forks_url":"https://api.github.com/repos/uclapi/uclapi/forks","keys_url":"https://api.github.com/repos/uclapi/uclapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclapi/uclapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclapi/uclapi/teams","hooks_url":"https://api.github.com/repos/uclapi/uclapi/hooks","issue_events_url":"https://api.github.com/repos/uclapi/uclapi/issues/events{/number}","events_url":"https://api.github.com/repos/uclapi/uclapi/events","assignees_url":"https://api.github.com/repos/uclapi/uclapi/assignees{/user}","branches_url":"https://api.github.com/repos/uclapi/uclapi/branches{/branch}","tags_url":"https://api.github.com/repos/uclapi/uclapi/tags","blobs_url":"https://api.github.com/repos/uclapi/uclapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclapi/uclapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclapi/uclapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclapi/uclapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclapi/uclapi/statuses/{sha}","languages_url":"https://api.github.com/repos/uclapi/uclapi/languages","stargazers_url":"https://api.github.com/repos/uclapi/uclapi/stargazers","contributors_url":"https://api.github.com/repos/uclapi/uclapi/contributors","subscribers_url":"https://api.github.com/repos/uclapi/uclapi/subscribers","subscription_url":"https://api.github.com/repos/uclapi/uclapi/subscription","commits_url":"https://api.github.com/repos/uclapi/uclapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclapi/uclapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclapi/uclapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclapi/uclapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/uclapi/uclapi/contents/{+path}","compare_url":"https://api.github.com/repos/uclapi/uclapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclapi/uclapi/merges","archive_url":"https://api.github.com/repos/uclapi/uclapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclapi/uclapi/downloads","issues_url":"https://api.github.com/repos/uclapi/uclapi/issues{/number}","pulls_url":"https://api.github.com/repos/uclapi/uclapi/pulls{/number}","milestones_url":"https://api.github.com/repos/uclapi/uclapi/milestones{/number}","notifications_url":"https://api.github.com/repos/uclapi/uclapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclapi/uclapi/labels{/name}","releases_url":"https://api.github.com/repos/uclapi/uclapi/releases{/id}","deployments_url":"https://api.github.com/repos/uclapi/uclapi/deployments","created_at":"2016-12-19T19:41:08Z","updated_at":"2019-05-23T16:46:36Z","pushed_at":"2019-05-23T20:17:41Z","git_url":"git://github.com/uclapi/uclapi.git","ssh_url":"git@github.com:uclapi/uclapi.git","clone_url":"https://github.com/uclapi/uclapi.git","svn_url":"https://github.com/uclapi/uclapi","homepage":"https://uclapi.com","size":36540,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":31,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uclapi/uclapi/pulls/1313"},"html":{"href":"https://github.com/uclapi/uclapi/pull/1313"},"issue":{"href":"https://api.github.com/repos/uclapi/uclapi/issues/1313"},"comments":{"href":"https://api.github.com/repos/uclapi/uclapi/issues/1313/comments"},"review_comments":{"href":"https://api.github.com/repos/uclapi/uclapi/pulls/1313/comments"},"review_comment":{"href":"https://api.github.com/repos/uclapi/uclapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uclapi/uclapi/pulls/1313/commits"},"statuses":{"href":"https://api.github.com/repos/uclapi/uclapi/statuses/e7ee79332ce51c67c32e6b9a031113edbf3fd43d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 76891826,
"name": "uclapi/uclapi",
"url": "https://api.github.com/repos/uclapi/uclapi"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 21985736,
"login": "uclapi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21985736?",
"url": "https://api.github.com/orgs/uclapi"
}
| 2019-05-23T20:17:46 |
9687294185
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/aeternity/pulls/comments/314249210","pull_request_review_id":275354046,"id":314249210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDI0OTIxMA==","diff_hunk":"@@ -12,10 +12,13 @@\n locked_coins_holder_account/0,\n minimum_gas_price/1,\n name_preclaim_expiration/0,\n- name_claim_locked_fee/0,\n+ name_claim_bid_increment/0,\n+ name_claim_fee/1,\n+ name_claim_fee_base/0,\n name_claim_max_expiration/0,\n name_protection_period/0,\n- name_claim_preclaim_delta/0,\n+ name_claim_preclaim_timeout/0,","path":"apps/aecore/src/aec_governance.erl","position":11,"original_position":11,"commit_id":"84d26d0fdb4cbecdc730edf26237f100bfe22acf","original_commit_id":"84d26d0fdb4cbecdc730edf26237f100bfe22acf","user":{"login":"sennui","id":16958765,"node_id":"MDQ6VXNlcjE2OTU4NzY1","avatar_url":"https://avatars3.githubusercontent.com/u/16958765?v=4","gravatar_id":"","url":"https://api.github.com/users/sennui","html_url":"https://github.com/sennui","followers_url":"https://api.github.com/users/sennui/followers","following_url":"https://api.github.com/users/sennui/following{/other_user}","gists_url":"https://api.github.com/users/sennui/gists{/gist_id}","starred_url":"https://api.github.com/users/sennui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sennui/subscriptions","organizations_url":"https://api.github.com/users/sennui/orgs","repos_url":"https://api.github.com/users/sennui/repos","events_url":"https://api.github.com/users/sennui/events{/privacy}","received_events_url":"https://api.github.com/users/sennui/received_events","type":"User","site_admin":false},"body":"@ThomasArts I change that to correlate with name_claim_bid_timout. In both cases it is not a time range that matters but the action that happens when they expire. For such activities, I found word `timeout` more suitable. Similar to timers, which, those functions represent in some abstract form, in fact, configure.","created_at":"2019-08-15T10:10:26Z","updated_at":"2019-08-15T10:10:26Z","html_url":"https://github.com/aeternity/aeternity/pull/2599#discussion_r314249210","pull_request_url":"https://api.github.com/repos/aeternity/aeternity/pulls/2599","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aeternity/aeternity/pulls/comments/314249210"},"html":{"href":"https://github.com/aeternity/aeternity/pull/2599#discussion_r314249210"},"pull_request":{"href":"https://api.github.com/repos/aeternity/aeternity/pulls/2599"}},"in_reply_to_id":314239759},"pull_request":{"url":"https://api.github.com/repos/aeternity/aeternity/pulls/2599","id":301286281,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMjg2Mjgx","html_url":"https://github.com/aeternity/aeternity/pull/2599","diff_url":"https://github.com/aeternity/aeternity/pull/2599.diff","patch_url":"https://github.com/aeternity/aeternity/pull/2599.patch","issue_url":"https://api.github.com/repos/aeternity/aeternity/issues/2599","number":2599,"state":"open","locked":false,"title":"names bidding draft","user":{"login":"sennui","id":16958765,"node_id":"MDQ6VXNlcjE2OTU4NzY1","avatar_url":"https://avatars3.githubusercontent.com/u/16958765?v=4","gravatar_id":"","url":"https://api.github.com/users/sennui","html_url":"https://github.com/sennui","followers_url":"https://api.github.com/users/sennui/followers","following_url":"https://api.github.com/users/sennui/following{/other_user}","gists_url":"https://api.github.com/users/sennui/gists{/gist_id}","starred_url":"https://api.github.com/users/sennui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sennui/subscriptions","organizations_url":"https://api.github.com/users/sennui/orgs","repos_url":"https://api.github.com/users/sennui/repos","events_url":"https://api.github.com/users/sennui/events{/privacy}","received_events_url":"https://api.github.com/users/sennui/received_events","type":"User","site_admin":false},"body":"Depends on unmerged aebytecode in https://github.com/aeternity/aebytecode/tree/pt-166866806-claim-with-name-fee\r\n\r\nand\r\n\r\nDepends on unmerged https://github.com/aeternity/aesophia/commit/aab56b8131de74eff8e36a9408a10b9f770929a8\r\n","created_at":"2019-07-25T19:49:45Z","updated_at":"2019-08-15T10:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e4bfd311a2cad9142195a40c2692f870338ba8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":824064814,"node_id":"MDU6TGFiZWw4MjQwNjQ4MTQ=","url":"https://api.github.com/repos/aeternity/aeternity/labels/WIP","name":"WIP","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/aeternity/pulls/2599/commits","review_comments_url":"https://api.github.com/repos/aeternity/aeternity/pulls/2599/comments","review_comment_url":"https://api.github.com/repos/aeternity/aeternity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/aeternity/issues/2599/comments","statuses_url":"https://api.github.com/repos/aeternity/aeternity/statuses/84d26d0fdb4cbecdc730edf26237f100bfe22acf","head":{"label":"aeternity:pt-166866806-ns-auctions-1","ref":"pt-166866806-ns-auctions-1","sha":"84d26d0fdb4cbecdc730edf26237f100bfe22acf","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgwMjAzNg==","name":"aeternity","full_name":"aeternity/aeternity","private":false,"owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aeternity/aeternity","description":"æternity: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/aeternity","forks_url":"https://api.github.com/repos/aeternity/aeternity/forks","keys_url":"https://api.github.com/repos/aeternity/aeternity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/aeternity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/aeternity/teams","hooks_url":"https://api.github.com/repos/aeternity/aeternity/hooks","issue_events_url":"https://api.github.com/repos/aeternity/aeternity/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/aeternity/events","assignees_url":"https://api.github.com/repos/aeternity/aeternity/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/aeternity/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/aeternity/tags","blobs_url":"https://api.github.com/repos/aeternity/aeternity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/aeternity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/aeternity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/aeternity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/aeternity/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/aeternity/languages","stargazers_url":"https://api.github.com/repos/aeternity/aeternity/stargazers","contributors_url":"https://api.github.com/repos/aeternity/aeternity/contributors","subscribers_url":"https://api.github.com/repos/aeternity/aeternity/subscribers","subscription_url":"https://api.github.com/repos/aeternity/aeternity/subscription","commits_url":"https://api.github.com/repos/aeternity/aeternity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/aeternity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/aeternity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/aeternity/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/aeternity/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/aeternity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/aeternity/merges","archive_url":"https://api.github.com/repos/aeternity/aeternity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/aeternity/downloads","issues_url":"https://api.github.com/repos/aeternity/aeternity/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/aeternity/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/aeternity/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/aeternity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/aeternity/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/aeternity/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/aeternity/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2019-08-14T09:21:42Z","pushed_at":"2019-08-15T09:53:55Z","git_url":"git://github.com/aeternity/aeternity.git","ssh_url":"git@github.com:aeternity/aeternity.git","clone_url":"https://github.com/aeternity/aeternity.git","svn_url":"https://github.com/aeternity/aeternity","homepage":"http://www.aeternity.com","size":20615,"stargazers_count":818,"watchers_count":818,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":28,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":174,"open_issues":28,"watchers":818,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"eebe7a849d2ae149899433bafa382ec4e2180cc4","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgwMjAzNg==","name":"aeternity","full_name":"aeternity/aeternity","private":false,"owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aeternity/aeternity","description":"æternity: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/aeternity","forks_url":"https://api.github.com/repos/aeternity/aeternity/forks","keys_url":"https://api.github.com/repos/aeternity/aeternity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/aeternity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/aeternity/teams","hooks_url":"https://api.github.com/repos/aeternity/aeternity/hooks","issue_events_url":"https://api.github.com/repos/aeternity/aeternity/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/aeternity/events","assignees_url":"https://api.github.com/repos/aeternity/aeternity/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/aeternity/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/aeternity/tags","blobs_url":"https://api.github.com/repos/aeternity/aeternity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/aeternity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/aeternity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/aeternity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/aeternity/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/aeternity/languages","stargazers_url":"https://api.github.com/repos/aeternity/aeternity/stargazers","contributors_url":"https://api.github.com/repos/aeternity/aeternity/contributors","subscribers_url":"https://api.github.com/repos/aeternity/aeternity/subscribers","subscription_url":"https://api.github.com/repos/aeternity/aeternity/subscription","commits_url":"https://api.github.com/repos/aeternity/aeternity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/aeternity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/aeternity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/aeternity/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/aeternity/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/aeternity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/aeternity/merges","archive_url":"https://api.github.com/repos/aeternity/aeternity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/aeternity/downloads","issues_url":"https://api.github.com/repos/aeternity/aeternity/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/aeternity/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/aeternity/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/aeternity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/aeternity/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/aeternity/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/aeternity/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2019-08-14T09:21:42Z","pushed_at":"2019-08-15T09:53:55Z","git_url":"git://github.com/aeternity/aeternity.git","ssh_url":"git@github.com:aeternity/aeternity.git","clone_url":"https://github.com/aeternity/aeternity.git","svn_url":"https://github.com/aeternity/aeternity","homepage":"http://www.aeternity.com","size":20615,"stargazers_count":818,"watchers_count":818,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":28,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":174,"open_issues":28,"watchers":818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/aeternity/pulls/2599"},"html":{"href":"https://github.com/aeternity/aeternity/pull/2599"},"issue":{"href":"https://api.github.com/repos/aeternity/aeternity/issues/2599"},"comments":{"href":"https://api.github.com/repos/aeternity/aeternity/issues/2599/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/aeternity/pulls/2599/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/aeternity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/aeternity/pulls/2599/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/aeternity/statuses/84d26d0fdb4cbecdc730edf26237f100bfe22acf"}},"author_association":"MEMBER"}}
|
{
"id": 99802036,
"name": "aeternity/aeternity",
"url": "https://api.github.com/repos/aeternity/aeternity"
}
|
{
"id": 16958765,
"login": "sennui",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16958765?",
"url": "https://api.github.com/users/sennui"
}
|
{
"id": 21989234,
"login": "aeternity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21989234?",
"url": "https://api.github.com/orgs/aeternity"
}
| 2019-08-15T10:10:26 |
10216303002
|
{"actor":{"display_login":"sennui"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/filecoin-project/specs/pulls/comments/352058284","pull_request_review_id":324590445,"id":352058284,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjA1ODI4NA==","diff_hunk":"@@ -441,6 +486,8 @@ func (a *StorageMinerActorCode_I) RecoverFaults(rt Runtime, recoveringSet sector\n \n \tUpdateRelease(rt, h, st)\n \n+\t// EnsureDealCollateral","path":"src/systems/filecoin_mining/storage_mining/storage_miner_actor_code.go","position":230,"original_position":230,"commit_id":"c2555c3800c8bac472f39467f85e4bc51a6e5f09","original_commit_id":"c2555c3800c8bac472f39467f85e4bc51a6e5f09","user":{"login":"anorth","id":445306,"node_id":"MDQ6VXNlcjQ0NTMwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/445306?v=4","gravatar_id":"","url":"https://api.github.com/users/anorth","html_url":"https://github.com/anorth","followers_url":"https://api.github.com/users/anorth/followers","following_url":"https://api.github.com/users/anorth/following{/other_user}","gists_url":"https://api.github.com/users/anorth/gists{/gist_id}","starred_url":"https://api.github.com/users/anorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anorth/subscriptions","organizations_url":"https://api.github.com/users/anorth/orgs","repos_url":"https://api.github.com/users/anorth/repos","events_url":"https://api.github.com/users/anorth/events{/privacy}","received_events_url":"https://api.github.com/users/anorth/received_events","type":"User","site_admin":false},"body":"Is this a TODO?","created_at":"2019-11-29T10:00:03Z","updated_at":"2019-11-29T10:00:38Z","html_url":"https://github.com/filecoin-project/specs/pull/656#discussion_r352058284","pull_request_url":"https://api.github.com/repos/filecoin-project/specs/pulls/656","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/filecoin-project/specs/pulls/comments/352058284"},"html":{"href":"https://github.com/filecoin-project/specs/pull/656#discussion_r352058284"},"pull_request":{"href":"https://api.github.com/repos/filecoin-project/specs/pulls/656"}}},"pull_request":{"url":"https://api.github.com/repos/filecoin-project/specs/pulls/656","id":345875319,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1ODc1MzE5","html_url":"https://github.com/filecoin-project/specs/pull/656","diff_url":"https://github.com/filecoin-project/specs/pull/656.diff","patch_url":"https://github.com/filecoin-project/specs/pull/656.patch","issue_url":"https://api.github.com/repos/filecoin-project/specs/issues/656","number":656,"state":"open","locked":false,"title":"Check Pledge Collateral Requirement at PoSt Submission and Pledge Slashing","user":{"login":"zixuanzh","id":16908497,"node_id":"MDQ6VXNlcjE2OTA4NDk3","avatar_url":"https://avatars0.githubusercontent.com/u/16908497?v=4","gravatar_id":"","url":"https://api.github.com/users/zixuanzh","html_url":"https://github.com/zixuanzh","followers_url":"https://api.github.com/users/zixuanzh/followers","following_url":"https://api.github.com/users/zixuanzh/following{/other_user}","gists_url":"https://api.github.com/users/zixuanzh/gists{/gist_id}","starred_url":"https://api.github.com/users/zixuanzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zixuanzh/subscriptions","organizations_url":"https://api.github.com/users/zixuanzh/orgs","repos_url":"https://api.github.com/users/zixuanzh/repos","events_url":"https://api.github.com/users/zixuanzh/events{/privacy}","received_events_url":"https://api.github.com/users/zixuanzh/received_events","type":"User","site_admin":false},"body":"In this PR:\r\n\r\n- [x] `EnsurePledgeCollateral` is added to `SubmitSurprise`, a SurprisePoSt is only valid when the miner has sufficient balance in StoragePowerActor. In the event that a SurprisePoSt fails because of insufficient pledge collateral, miners need to add Balance to StoragePowerActor and submit SurprisePoSt again. Note that election PoSt will always go through but some block reward will be sent to LockedBalance in StoragePowerActor in the event of undercollateralization.\r\n- [x] Add slashPledgeForStorageFault, the exact amount to slash and rules in determining how much to slash under different storage faults will be added in a future PR\r\n- [x] Replace `_submitFaultReport` with `_slashCollateralForStorageFaults` that calls `_slashDealsForStorageFault` and `_slashPledgeForStorageFault` depending on the `StorageFaultType`\r\n- [x] Add `_ensurePledgeCollateral` to `WithdrawBalance` \r\n- [x] Wire collateral slashing between actors with rt.SendCatchingErrors\r\n- [x] Add PledgeCollateralSlashed to SMA (similar to DealCollateralSlashed in StorageMarketActor), we can migrate this to an actor later\r\n- [x] Move `_slashCollateralForStorageFaults` to be invoked after `_submitPowerReport` so that utilizationInfo is up-to-date when checking for affected power\r\n\r\nFuture PRs:\r\n\r\n- [ ] Align on the shape and mechanism for pledge collateral function\r\n- [ ] Decide on how much pledge collateral to slash given different storage fault types\r\n- [ ] Align and decide if we should add a condition to leader election such that Pledge Collateral must be satisfied before being eligible to win a block or add Pledge Collateral check to Block Validation to work well with ElectionPoSt\r\n- [ ] Add block reward garnishing in the event of under collateralization","created_at":"2019-11-26T18:25:03Z","updated_at":"2019-11-29T10:00:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"223c0548fb1c26100730f4ac926839a7ce6362de","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sternhenri","id":3359083,"node_id":"MDQ6VXNlcjMzNTkwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3359083?v=4","gravatar_id":"","url":"https://api.github.com/users/sternhenri","html_url":"https://github.com/sternhenri","followers_url":"https://api.github.com/users/sternhenri/followers","following_url":"https://api.github.com/users/sternhenri/following{/other_user}","gists_url":"https://api.github.com/users/sternhenri/gists{/gist_id}","starred_url":"https://api.github.com/users/sternhenri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternhenri/subscriptions","organizations_url":"https://api.github.com/users/sternhenri/orgs","repos_url":"https://api.github.com/users/sternhenri/repos","events_url":"https://api.github.com/users/sternhenri/events{/privacy}","received_events_url":"https://api.github.com/users/sternhenri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/filecoin-project/specs/pulls/656/commits","review_comments_url":"https://api.github.com/repos/filecoin-project/specs/pulls/656/comments","review_comment_url":"https://api.github.com/repos/filecoin-project/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/filecoin-project/specs/issues/656/comments","statuses_url":"https://api.github.com/repos/filecoin-project/specs/statuses/c2555c3800c8bac472f39467f85e4bc51a6e5f09","head":{"label":"filecoin-project:ensure-pledge-collateral","ref":"ensure-pledge-collateral","sha":"c2555c3800c8bac472f39467f85e4bc51a6e5f09","user":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"repo":{"id":159554854,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1NTQ4NTQ=","name":"specs","full_name":"filecoin-project/specs","private":false,"owner":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/filecoin-project/specs","description":"The Filecoin protocol specification","fork":false,"url":"https://api.github.com/repos/filecoin-project/specs","forks_url":"https://api.github.com/repos/filecoin-project/specs/forks","keys_url":"https://api.github.com/repos/filecoin-project/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filecoin-project/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filecoin-project/specs/teams","hooks_url":"https://api.github.com/repos/filecoin-project/specs/hooks","issue_events_url":"https://api.github.com/repos/filecoin-project/specs/issues/events{/number}","events_url":"https://api.github.com/repos/filecoin-project/specs/events","assignees_url":"https://api.github.com/repos/filecoin-project/specs/assignees{/user}","branches_url":"https://api.github.com/repos/filecoin-project/specs/branches{/branch}","tags_url":"https://api.github.com/repos/filecoin-project/specs/tags","blobs_url":"https://api.github.com/repos/filecoin-project/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filecoin-project/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filecoin-project/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/filecoin-project/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filecoin-project/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/filecoin-project/specs/languages","stargazers_url":"https://api.github.com/repos/filecoin-project/specs/stargazers","contributors_url":"https://api.github.com/repos/filecoin-project/specs/contributors","subscribers_url":"https://api.github.com/repos/filecoin-project/specs/subscribers","subscription_url":"https://api.github.com/repos/filecoin-project/specs/subscription","commits_url":"https://api.github.com/repos/filecoin-project/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/filecoin-project/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/filecoin-project/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/filecoin-project/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/filecoin-project/specs/contents/{+path}","compare_url":"https://api.github.com/repos/filecoin-project/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filecoin-project/specs/merges","archive_url":"https://api.github.com/repos/filecoin-project/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filecoin-project/specs/downloads","issues_url":"https://api.github.com/repos/filecoin-project/specs/issues{/number}","pulls_url":"https://api.github.com/repos/filecoin-project/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/filecoin-project/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/filecoin-project/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filecoin-project/specs/labels{/name}","releases_url":"https://api.github.com/repos/filecoin-project/specs/releases{/id}","deployments_url":"https://api.github.com/repos/filecoin-project/specs/deployments","created_at":"2018-11-28T19:36:35Z","updated_at":"2019-11-29T05:01:59Z","pushed_at":"2019-11-29T09:32:25Z","git_url":"git://github.com/filecoin-project/specs.git","ssh_url":"git@github.com:filecoin-project/specs.git","clone_url":"https://github.com/filecoin-project/specs.git","svn_url":"https://github.com/filecoin-project/specs","homepage":"","size":10748,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":249,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":31,"open_issues":249,"watchers":102,"default_branch":"master"}},"base":{"label":"filecoin-project:master","ref":"master","sha":"168ca4d6270205b9504f042442880795e3f6807e","user":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"repo":{"id":159554854,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1NTQ4NTQ=","name":"specs","full_name":"filecoin-project/specs","private":false,"owner":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/filecoin-project/specs","description":"The Filecoin protocol specification","fork":false,"url":"https://api.github.com/repos/filecoin-project/specs","forks_url":"https://api.github.com/repos/filecoin-project/specs/forks","keys_url":"https://api.github.com/repos/filecoin-project/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filecoin-project/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filecoin-project/specs/teams","hooks_url":"https://api.github.com/repos/filecoin-project/specs/hooks","issue_events_url":"https://api.github.com/repos/filecoin-project/specs/issues/events{/number}","events_url":"https://api.github.com/repos/filecoin-project/specs/events","assignees_url":"https://api.github.com/repos/filecoin-project/specs/assignees{/user}","branches_url":"https://api.github.com/repos/filecoin-project/specs/branches{/branch}","tags_url":"https://api.github.com/repos/filecoin-project/specs/tags","blobs_url":"https://api.github.com/repos/filecoin-project/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filecoin-project/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filecoin-project/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/filecoin-project/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filecoin-project/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/filecoin-project/specs/languages","stargazers_url":"https://api.github.com/repos/filecoin-project/specs/stargazers","contributors_url":"https://api.github.com/repos/filecoin-project/specs/contributors","subscribers_url":"https://api.github.com/repos/filecoin-project/specs/subscribers","subscription_url":"https://api.github.com/repos/filecoin-project/specs/subscription","commits_url":"https://api.github.com/repos/filecoin-project/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/filecoin-project/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/filecoin-project/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/filecoin-project/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/filecoin-project/specs/contents/{+path}","compare_url":"https://api.github.com/repos/filecoin-project/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filecoin-project/specs/merges","archive_url":"https://api.github.com/repos/filecoin-project/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filecoin-project/specs/downloads","issues_url":"https://api.github.com/repos/filecoin-project/specs/issues{/number}","pulls_url":"https://api.github.com/repos/filecoin-project/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/filecoin-project/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/filecoin-project/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filecoin-project/specs/labels{/name}","releases_url":"https://api.github.com/repos/filecoin-project/specs/releases{/id}","deployments_url":"https://api.github.com/repos/filecoin-project/specs/deployments","created_at":"2018-11-28T19:36:35Z","updated_at":"2019-11-29T05:01:59Z","pushed_at":"2019-11-29T09:32:25Z","git_url":"git://github.com/filecoin-project/specs.git","ssh_url":"git@github.com:filecoin-project/specs.git","clone_url":"https://github.com/filecoin-project/specs.git","svn_url":"https://github.com/filecoin-project/specs","homepage":"","size":10748,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":249,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":31,"open_issues":249,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/filecoin-project/specs/pulls/656"},"html":{"href":"https://github.com/filecoin-project/specs/pull/656"},"issue":{"href":"https://api.github.com/repos/filecoin-project/specs/issues/656"},"comments":{"href":"https://api.github.com/repos/filecoin-project/specs/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/filecoin-project/specs/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/filecoin-project/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/filecoin-project/specs/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/filecoin-project/specs/statuses/c2555c3800c8bac472f39467f85e4bc51a6e5f09"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 159554854,
"name": "filecoin-project/specs",
"url": "https://api.github.com/repos/filecoin-project/specs"
}
|
{
"id": 445306,
"login": "anorth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/445306?",
"url": "https://api.github.com/users/anorth"
}
|
{
"id": 22014611,
"login": "filecoin-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22014611?",
"url": "https://api.github.com/orgs/filecoin-project"
}
| 2019-11-29T10:00:03 |
10974820940
|
{"actor":{"display_login":"anorth"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/355106520","pull_request_review_id":328544289,"id":355106520,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTEwNjUyMA==","diff_hunk":"@@ -2319,7 +2320,7 @@ bool NodeManager::FinishAssignedTask(Worker &worker) {\n worker.ResetTaskResourceIds();\n \n const auto &spec = task.GetTaskSpecification();\n- if (spec.IsActorCreationTask() || spec.IsActorTask()) {\n+ if ((spec.IsActorCreationTask() || spec.IsActorTask()) && !spec.IsDirectCall()) {","path":"src/ray/raylet/node_manager.cc","position":15,"original_position":15,"commit_id":"7bf552dcb3f3de0745ce9309cd9c0a9967f6ad43","original_commit_id":"7bf552dcb3f3de0745ce9309cd9c0a9967f6ad43","user":{"login":"zhijunfu","id":37800433,"node_id":"MDQ6VXNlcjM3ODAwNDMz","avatar_url":"https://avatars2.githubusercontent.com/u/37800433?v=4","gravatar_id":"","url":"https://api.github.com/users/zhijunfu","html_url":"https://github.com/zhijunfu","followers_url":"https://api.github.com/users/zhijunfu/followers","following_url":"https://api.github.com/users/zhijunfu/following{/other_user}","gists_url":"https://api.github.com/users/zhijunfu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhijunfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhijunfu/subscriptions","organizations_url":"https://api.github.com/users/zhijunfu/orgs","repos_url":"https://api.github.com/users/zhijunfu/repos","events_url":"https://api.github.com/users/zhijunfu/events{/privacy}","received_events_url":"https://api.github.com/users/zhijunfu/received_events","type":"User","site_admin":false},"body":"actually direct call tasks won't be assigned by raylet, so this additional check is not necessary?","created_at":"2019-12-07T07:36:08Z","updated_at":"2019-12-07T07:51:39Z","html_url":"https://github.com/ray-project/ray/pull/6375#discussion_r355106520","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/6375","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/355106520"},"html":{"href":"https://github.com/ray-project/ray/pull/6375#discussion_r355106520"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/6375"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/6375","id":349738995,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5NzM4OTk1","html_url":"https://github.com/ray-project/ray/pull/6375","diff_url":"https://github.com/ray-project/ray/pull/6375.diff","patch_url":"https://github.com/ray-project/ray/pull/6375.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/6375","number":6375,"state":"open","locked":false,"title":"[WIP] Port actor creation to use direct calls","user":{"login":"stephanie-wang","id":2560516,"node_id":"MDQ6VXNlcjI1NjA1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-06T02:50:05Z","updated_at":"2019-12-07T07:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"422b63acfecb7cd86323c8e2f4e27607d3e00a0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/6375/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/6375/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/6375/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/7bf552dcb3f3de0745ce9309cd9c0a9967f6ad43","head":{"label":"stephanie-wang:direct-actor-creation","ref":"direct-actor-creation","sha":"7bf552dcb3f3de0745ce9309cd9c0a9967f6ad43","user":{"login":"stephanie-wang","id":2560516,"node_id":"MDQ6VXNlcjI1NjA1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"repo":{"id":77302388,"node_id":"MDEwOlJlcG9zaXRvcnk3NzMwMjM4OA==","name":"ray","full_name":"stephanie-wang/ray","private":false,"owner":{"login":"stephanie-wang","id":2560516,"node_id":"MDQ6VXNlcjI1NjA1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stephanie-wang/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/stephanie-wang/ray","forks_url":"https://api.github.com/repos/stephanie-wang/ray/forks","keys_url":"https://api.github.com/repos/stephanie-wang/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephanie-wang/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephanie-wang/ray/teams","hooks_url":"https://api.github.com/repos/stephanie-wang/ray/hooks","issue_events_url":"https://api.github.com/repos/stephanie-wang/ray/issues/events{/number}","events_url":"https://api.github.com/repos/stephanie-wang/ray/events","assignees_url":"https://api.github.com/repos/stephanie-wang/ray/assignees{/user}","branches_url":"https://api.github.com/repos/stephanie-wang/ray/branches{/branch}","tags_url":"https://api.github.com/repos/stephanie-wang/ray/tags","blobs_url":"https://api.github.com/repos/stephanie-wang/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephanie-wang/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephanie-wang/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephanie-wang/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephanie-wang/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/stephanie-wang/ray/languages","stargazers_url":"https://api.github.com/repos/stephanie-wang/ray/stargazers","contributors_url":"https://api.github.com/repos/stephanie-wang/ray/contributors","subscribers_url":"https://api.github.com/repos/stephanie-wang/ray/subscribers","subscription_url":"https://api.github.com/repos/stephanie-wang/ray/subscription","commits_url":"https://api.github.com/repos/stephanie-wang/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephanie-wang/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephanie-wang/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephanie-wang/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephanie-wang/ray/contents/{+path}","compare_url":"https://api.github.com/repos/stephanie-wang/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephanie-wang/ray/merges","archive_url":"https://api.github.com/repos/stephanie-wang/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephanie-wang/ray/downloads","issues_url":"https://api.github.com/repos/stephanie-wang/ray/issues{/number}","pulls_url":"https://api.github.com/repos/stephanie-wang/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/stephanie-wang/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/stephanie-wang/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephanie-wang/ray/labels{/name}","releases_url":"https://api.github.com/repos/stephanie-wang/ray/releases{/id}","deployments_url":"https://api.github.com/repos/stephanie-wang/ray/deployments","created_at":"2016-12-24T22:37:23Z","updated_at":"2019-10-18T17:44:58Z","pushed_at":"2019-12-06T03:51:05Z","git_url":"git://github.com/stephanie-wang/ray.git","ssh_url":"git@github.com:stephanie-wang/ray.git","clone_url":"https://github.com/stephanie-wang/ray.git","svn_url":"https://github.com/stephanie-wang/ray","homepage":"","size":38892,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"1c638a11a77c80c56b7c1fed3cac1698c0ce45d4","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","private":false,"owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ray-project/ray","description":"A fast and simple framework for building and running distributed applications. Ray is packaged with RLlib, a scalable reinforcement learning library, and Tune, a scalable hyperparameter tuning library.","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2019-12-07T06:27:30Z","pushed_at":"2019-12-07T05:41:51Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":31070,"stargazers_count":9594,"watchers_count":9594,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1351,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":925,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1351,"open_issues":925,"watchers":9594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/6375"},"html":{"href":"https://github.com/ray-project/ray/pull/6375"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/6375"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/6375/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/6375/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/6375/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/7bf552dcb3f3de0745ce9309cd9c0a9967f6ad43"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 71932349,
"name": "ray-project/ray",
"url": "https://api.github.com/repos/ray-project/ray"
}
|
{
"id": 37800433,
"login": "zhijunfu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/37800433?",
"url": "https://api.github.com/users/zhijunfu"
}
|
{
"id": 22125274,
"login": "ray-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22125274?",
"url": "https://api.github.com/orgs/ray-project"
}
| 2019-12-07T07:36:08 |
11034700880
|
{"actor":{"display_login":"zhijunfu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/352262228","pull_request_review_id":324873598,"id":352262228,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjI2MjIyOA==","diff_hunk":"@@ -0,0 +1,47 @@\n+// Components\n+import VThemeProvider from '../VThemeProvider'\n+\n+// Utilities\n+import {\n+ mount,\n+ MountOptions,\n+ Wrapper,\n+} from '@vue/test-utils'\n+\n+describe('VThemeProvider.ts', () => {\n+ type Instance = InstanceType<typeof VThemeProvider>\n+ let mountFunction: (options?: MountOptions<Instance>) => Wrapper<Instance>\n+\n+ beforeEach(() => {\n+ mountFunction = (options = {}) => {\n+ return mount(VThemeProvider, {\n+ ...options,\n+ })\n+ }\n+ })\n+\n+ it('should work match snapshot', () => {","path":"packages/vuetify/src/components/VThemeProvider/__tests__/VThemeProvider.spec.ts","position":23,"original_position":23,"commit_id":"9c389fb3d44fe6013748d0cd313d83035fba162c","original_commit_id":"9c389fb3d44fe6013748d0cd313d83035fba162c","user":{"login":"KaelWD","id":16421948,"node_id":"MDQ6VXNlcjE2NDIxOTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/16421948?v=4","gravatar_id":"","url":"https://api.github.com/users/KaelWD","html_url":"https://github.com/KaelWD","followers_url":"https://api.github.com/users/KaelWD/followers","following_url":"https://api.github.com/users/KaelWD/following{/other_user}","gists_url":"https://api.github.com/users/KaelWD/gists{/gist_id}","starred_url":"https://api.github.com/users/KaelWD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaelWD/subscriptions","organizations_url":"https://api.github.com/users/KaelWD/orgs","repos_url":"https://api.github.com/users/KaelWD/repos","events_url":"https://api.github.com/users/KaelWD/events{/privacy}","received_events_url":"https://api.github.com/users/KaelWD/received_events","type":"User","site_admin":false},"body":"Useless test","created_at":"2019-11-30T02:07:30Z","updated_at":"2019-11-30T02:07:30Z","html_url":"https://github.com/vuetifyjs/vuetify/pull/9804#discussion_r352262228","pull_request_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/352262228"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/9804#discussion_r352262228"},"pull_request":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804"}}},"pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804","id":345985448,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1OTg1NDQ4","html_url":"https://github.com/vuetifyjs/vuetify/pull/9804","diff_url":"https://github.com/vuetifyjs/vuetify/pull/9804.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/9804.patch","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/9804","number":9804,"state":"open","locked":false,"title":"feat(VThemeProvider): add new component","user":{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false},"body":"<!--\r\nMAKE SURE TO READ THE CONTRIBUTING GUIDE BEFORE CREATING A PR\r\nhttps://github.com/vuetifyjs/vuetify/blob/master/.github/CONTRIBUTING.md\r\n\r\nTesting and markup sections can be removed for documentation changes\r\n-->\r\n\r\n<!-- Provide a general summary of your changes in the Title above -->\r\n<!-- Keep the title short and descriptive, as it will be used as a commit message -->\r\n\r\n## Description\r\nExpose **ThemeProvider** as a standalone component, `v-theme-provider`.\r\n\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\nIt's an easy addition and there have been times I know I've grabbed for it.\r\n\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\njest\r\n<!--- Please describe how you tested your changes. -->\r\n<!--- Have you created new tests or updated existing ones? -->\r\n<!--- e.g. unit | visually | e2e | none -->\r\n\r\n## Markup:\r\n<!--- Paste markup for testing your change --->\r\n<details>\r\n\r\n```vue\r\n<template>\r\n <div class=\"ma-12 pa-12\">\r\n <v-theme-provider\r\n :dark=\"isDark\"\r\n :light=\"!isDark\"\r\n >\r\n <v-card :light=\"isComponentLight\">\r\n <v-card-title>Title</v-card-title>\r\n\r\n <v-card-text>Lorem ipsum</v-card-text>\r\n\r\n <v-card-actions class=\"justify-center\">\r\n <v-checkbox\r\n v-model=\"$vuetify.theme.dark\"\r\n class=\"ma-1\"\r\n label=\"Application Dark\"\r\n hide-details\r\n ></v-checkbox>\r\n <v-checkbox\r\n v-model=\"isDark\"\r\n class=\"ma-1\"\r\n label=\"Theme Provider Dark\"\r\n hide-details\r\n ></v-checkbox>\r\n <v-checkbox\r\n v-model=\"isComponentLight\"\r\n class=\"ma-1\"\r\n label=\"Component Light\"\r\n hide-details\r\n ></v-checkbox>\r\n </v-card-actions>\r\n </v-card>\r\n </v-theme-provider>\r\n </div>\r\n</template>\r\n\r\n<script>\r\n export default {\r\n data: () => ({\r\n isComponentLight: false,\r\n isDark: false,\r\n }),\r\n\r\n computed: {\r\n isRootDark () {\r\n return this.$vuetify.theme.dark\r\n },\r\n },\r\n }\r\n</script>\r\n\r\n```\r\n</details>\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] The PR title is no longer than 64 characters.\r\n- [x] The PR is submitted to the correct branch (`master` for bug fixes and documentation updates, `dev` for new features and breaking changes).\r\n- [x] My code follows the code style of this project.\r\n- [x] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)\r\n- [ ] I've added new examples to the kitchen (applies to new features and breaking changes in core library)\r\n","created_at":"2019-11-26T23:47:04Z","updated_at":"2019-11-30T02:07:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80c65a170a070a00038a571af8ebb5e4ab20462f","assignee":{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false},"assignees":[{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"Core Contributors","id":2502102,"node_id":"MDQ6VGVhbTI1MDIxMDI=","slug":"core-contributors","description":"Important community members that contribute significantly to development","privacy":"closed","url":"https://api.github.com/teams/2502102","html_url":"https://github.com/orgs/vuetifyjs/teams/core-contributors","members_url":"https://api.github.com/teams/2502102/members{/member}","repositories_url":"https://api.github.com/teams/2502102/repos","permission":"pull"}],"labels":[{"id":1310293048,"node_id":"MDU6TGFiZWwxMzEwMjkzMDQ4","url":"https://api.github.com/repos/vuetifyjs/vuetify/labels/C:%20New%20Component","name":"C: New Component","color":"26afa2","default":false,"description":"This issue would need a new component to be developed."},{"id":517773512,"node_id":"MDU6TGFiZWw1MTc3NzM1MTI=","url":"https://api.github.com/repos/vuetifyjs/vuetify/labels/T:%20feature","name":"T: feature","color":"d4c5f9","default":false,"description":"A new feature"}],"milestone":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones/44","html_url":"https://github.com/vuetifyjs/vuetify/milestone/44","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones/44/labels","id":4711934,"node_id":"MDk6TWlsZXN0b25lNDcxMTkzNA==","number":44,"title":"v2.2.0","description":"","creator":{"login":"KaelWD","id":16421948,"node_id":"MDQ6VXNlcjE2NDIxOTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/16421948?v=4","gravatar_id":"","url":"https://api.github.com/users/KaelWD","html_url":"https://github.com/KaelWD","followers_url":"https://api.github.com/users/KaelWD/followers","following_url":"https://api.github.com/users/KaelWD/following{/other_user}","gists_url":"https://api.github.com/users/KaelWD/gists{/gist_id}","starred_url":"https://api.github.com/users/KaelWD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaelWD/subscriptions","organizations_url":"https://api.github.com/users/KaelWD/orgs","repos_url":"https://api.github.com/users/KaelWD/repos","events_url":"https://api.github.com/users/KaelWD/events{/privacy}","received_events_url":"https://api.github.com/users/KaelWD/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":6,"state":"open","created_at":"2019-10-02T04:12:09Z","updated_at":"2019-11-30T01:22:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804/commits","review_comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804/comments","review_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/9804/comments","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/9c389fb3d44fe6013748d0cd313d83035fba162c","head":{"label":"vuetifyjs:feat/add-theme-provider-component","ref":"feat/add-theme-provider-component","sha":"9c389fb3d44fe6013748d0cd313d83035fba162c","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","private":false,"owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vuetifyjs/vuetify","description":"🐉 Material Component Framework for Vue","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2019-11-30T01:25:26Z","pushed_at":"2019-11-30T02:00:09Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":55406,"stargazers_count":22724,"watchers_count":22724,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3188,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1047,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3188,"open_issues":1047,"watchers":22724,"default_branch":"master"}},"base":{"label":"vuetifyjs:dev","ref":"dev","sha":"5d180dd235b8801545ec49db2a701cd14fdea051","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","private":false,"owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vuetifyjs/vuetify","description":"🐉 Material Component Framework for Vue","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2019-11-30T01:25:26Z","pushed_at":"2019-11-30T02:00:09Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":55406,"stargazers_count":22724,"watchers_count":22724,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3188,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1047,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3188,"open_issues":1047,"watchers":22724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/9804"},"issue":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/9804"},"comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/9804/comments"},"review_comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804/comments"},"review_comment":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/9804/commits"},"statuses":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/9c389fb3d44fe6013748d0cd313d83035fba162c"}},"author_association":"MEMBER"}}
|
{
"id": 67962648,
"name": "vuetifyjs/vuetify",
"url": "https://api.github.com/repos/vuetifyjs/vuetify"
}
|
{
"id": 16421948,
"login": "KaelWD",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16421948?",
"url": "https://api.github.com/users/KaelWD"
}
|
{
"id": 22138497,
"login": "vuetifyjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22138497?",
"url": "https://api.github.com/orgs/vuetifyjs"
}
| 2019-11-30T02:07:30 |
10979125224
|
{"actor":{"display_login":"KaelWD"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/occmundial/occ-atomic/pulls/comments/339749263","pull_request_review_id":308070127,"id":339749263,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTc0OTI2Mw==","diff_hunk":"@@ -0,0 +1,20 @@\n+import React from 'react';\n+import { shallow, mount } from 'enzyme';\n+import Tip from './Tip';\n+import styles from './styles';\n+import TipJSS from './index';\n+\n+const reduceClasses = (prev, curr) => Object.assign({}, prev, { [curr]: curr });\n+\n+const classes = Object.keys(styles).reduce(reduceClasses, {});\n+\n+describe(\"Flatter\", () => {\n+\n+ it('matches the snapshot', () => {\n+ const wrapper = shallow(\n+ <Tip classes={classes} />","path":"lib/Flatter/Flatter.test.js","position":15,"original_position":15,"commit_id":"c27fffbff22588bf9c93076140faa3e1c0cc9375","original_commit_id":"c27fffbff22588bf9c93076140faa3e1c0cc9375","user":{"login":"ldiaz-occ","id":26333425,"node_id":"MDQ6VXNlcjI2MzMzNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/26333425?v=4","gravatar_id":"","url":"https://api.github.com/users/ldiaz-occ","html_url":"https://github.com/ldiaz-occ","followers_url":"https://api.github.com/users/ldiaz-occ/followers","following_url":"https://api.github.com/users/ldiaz-occ/following{/other_user}","gists_url":"https://api.github.com/users/ldiaz-occ/gists{/gist_id}","starred_url":"https://api.github.com/users/ldiaz-occ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldiaz-occ/subscriptions","organizations_url":"https://api.github.com/users/ldiaz-occ/orgs","repos_url":"https://api.github.com/users/ldiaz-occ/repos","events_url":"https://api.github.com/users/ldiaz-occ/events{/privacy}","received_events_url":"https://api.github.com/users/ldiaz-occ/received_events","type":"User","site_admin":false},"body":"El test debería enviar un ejemplo de html. Si no sólo se estará testeando un div vacío","created_at":"2019-10-28T19:24:59Z","updated_at":"2019-10-28T19:27:35Z","html_url":"https://github.com/occmundial/occ-atomic/pull/29#discussion_r339749263","pull_request_url":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/occmundial/occ-atomic/pulls/comments/339749263"},"html":{"href":"https://github.com/occmundial/occ-atomic/pull/29#discussion_r339749263"},"pull_request":{"href":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29","id":333266863,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzMjY2ODYz","html_url":"https://github.com/occmundial/occ-atomic/pull/29","diff_url":"https://github.com/occmundial/occ-atomic/pull/29.diff","patch_url":"https://github.com/occmundial/occ-atomic/pull/29.patch","issue_url":"https://api.github.com/repos/occmundial/occ-atomic/issues/29","number":29,"state":"open","locked":false,"title":"Se agrega version inicial del componente Flatter.","user":{"login":"wallidhgsocc","id":40835377,"node_id":"MDQ6VXNlcjQwODM1Mzc3","avatar_url":"https://avatars3.githubusercontent.com/u/40835377?v=4","gravatar_id":"","url":"https://api.github.com/users/wallidhgsocc","html_url":"https://github.com/wallidhgsocc","followers_url":"https://api.github.com/users/wallidhgsocc/followers","following_url":"https://api.github.com/users/wallidhgsocc/following{/other_user}","gists_url":"https://api.github.com/users/wallidhgsocc/gists{/gist_id}","starred_url":"https://api.github.com/users/wallidhgsocc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallidhgsocc/subscriptions","organizations_url":"https://api.github.com/users/wallidhgsocc/orgs","repos_url":"https://api.github.com/users/wallidhgsocc/repos","events_url":"https://api.github.com/users/wallidhgsocc/events{/privacy}","received_events_url":"https://api.github.com/users/wallidhgsocc/received_events","type":"User","site_admin":false},"body":" Dado un html:\r\n- Se sanitiza\r\n- Se eliminan tags no permitidos\r\n- Se parsean tags permitidos a componentes de occ-atomic","created_at":"2019-10-28T18:42:46Z","updated_at":"2019-10-28T19:27:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32c3688fb5b6edb87d3727187babcc2457c5a44f","assignee":{"login":"wallidhgsocc","id":40835377,"node_id":"MDQ6VXNlcjQwODM1Mzc3","avatar_url":"https://avatars3.githubusercontent.com/u/40835377?v=4","gravatar_id":"","url":"https://api.github.com/users/wallidhgsocc","html_url":"https://github.com/wallidhgsocc","followers_url":"https://api.github.com/users/wallidhgsocc/followers","following_url":"https://api.github.com/users/wallidhgsocc/following{/other_user}","gists_url":"https://api.github.com/users/wallidhgsocc/gists{/gist_id}","starred_url":"https://api.github.com/users/wallidhgsocc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallidhgsocc/subscriptions","organizations_url":"https://api.github.com/users/wallidhgsocc/orgs","repos_url":"https://api.github.com/users/wallidhgsocc/repos","events_url":"https://api.github.com/users/wallidhgsocc/events{/privacy}","received_events_url":"https://api.github.com/users/wallidhgsocc/received_events","type":"User","site_admin":false},"assignees":[{"login":"wallidhgsocc","id":40835377,"node_id":"MDQ6VXNlcjQwODM1Mzc3","avatar_url":"https://avatars3.githubusercontent.com/u/40835377?v=4","gravatar_id":"","url":"https://api.github.com/users/wallidhgsocc","html_url":"https://github.com/wallidhgsocc","followers_url":"https://api.github.com/users/wallidhgsocc/followers","following_url":"https://api.github.com/users/wallidhgsocc/following{/other_user}","gists_url":"https://api.github.com/users/wallidhgsocc/gists{/gist_id}","starred_url":"https://api.github.com/users/wallidhgsocc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallidhgsocc/subscriptions","organizations_url":"https://api.github.com/users/wallidhgsocc/orgs","repos_url":"https://api.github.com/users/wallidhgsocc/repos","events_url":"https://api.github.com/users/wallidhgsocc/events{/privacy}","received_events_url":"https://api.github.com/users/wallidhgsocc/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"moisesrh","id":46204469,"node_id":"MDQ6VXNlcjQ2MjA0NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/46204469?v=4","gravatar_id":"","url":"https://api.github.com/users/moisesrh","html_url":"https://github.com/moisesrh","followers_url":"https://api.github.com/users/moisesrh/followers","following_url":"https://api.github.com/users/moisesrh/following{/other_user}","gists_url":"https://api.github.com/users/moisesrh/gists{/gist_id}","starred_url":"https://api.github.com/users/moisesrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moisesrh/subscriptions","organizations_url":"https://api.github.com/users/moisesrh/orgs","repos_url":"https://api.github.com/users/moisesrh/repos","events_url":"https://api.github.com/users/moisesrh/events{/privacy}","received_events_url":"https://api.github.com/users/moisesrh/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"E-Commerce","id":2664525,"node_id":"MDQ6VGVhbTI2NjQ1MjU=","slug":"e-commerce","description":"","privacy":"closed","url":"https://api.github.com/teams/2664525","html_url":"https://github.com/orgs/occmundial/teams/e-commerce","members_url":"https://api.github.com/teams/2664525/members{/member}","repositories_url":"https://api.github.com/teams/2664525/repos","permission":"pull"}],"labels":[{"id":1553064852,"node_id":"MDU6TGFiZWwxNTUzMDY0ODUy","url":"https://api.github.com/repos/occmundial/occ-atomic/labels/ready%20for%20review","name":"ready for review","color":"0e8a16","default":false},{"id":1515845626,"node_id":"MDU6TGFiZWwxNTE1ODQ1NjI2","url":"https://api.github.com/repos/occmundial/occ-atomic/labels/work%20in%20progress","name":"work in progress","color":"c5ea85","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29/commits","review_comments_url":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29/comments","review_comment_url":"https://api.github.com/repos/occmundial/occ-atomic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/occmundial/occ-atomic/issues/29/comments","statuses_url":"https://api.github.com/repos/occmundial/occ-atomic/statuses/c27fffbff22588bf9c93076140faa3e1c0cc9375","head":{"label":"occmundial:feat/htmlFlatter","ref":"feat/htmlFlatter","sha":"c27fffbff22588bf9c93076140faa3e1c0cc9375","user":{"login":"occmundial","id":22198811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTk4ODEx","avatar_url":"https://avatars0.githubusercontent.com/u/22198811?v=4","gravatar_id":"","url":"https://api.github.com/users/occmundial","html_url":"https://github.com/occmundial","followers_url":"https://api.github.com/users/occmundial/followers","following_url":"https://api.github.com/users/occmundial/following{/other_user}","gists_url":"https://api.github.com/users/occmundial/gists{/gist_id}","starred_url":"https://api.github.com/users/occmundial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occmundial/subscriptions","organizations_url":"https://api.github.com/users/occmundial/orgs","repos_url":"https://api.github.com/users/occmundial/repos","events_url":"https://api.github.com/users/occmundial/events{/privacy}","received_events_url":"https://api.github.com/users/occmundial/received_events","type":"Organization","site_admin":false},"repo":{"id":137137529,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzc1Mjk=","name":"occ-atomic","full_name":"occmundial/occ-atomic","private":false,"owner":{"login":"occmundial","id":22198811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTk4ODEx","avatar_url":"https://avatars0.githubusercontent.com/u/22198811?v=4","gravatar_id":"","url":"https://api.github.com/users/occmundial","html_url":"https://github.com/occmundial","followers_url":"https://api.github.com/users/occmundial/followers","following_url":"https://api.github.com/users/occmundial/following{/other_user}","gists_url":"https://api.github.com/users/occmundial/gists{/gist_id}","starred_url":"https://api.github.com/users/occmundial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occmundial/subscriptions","organizations_url":"https://api.github.com/users/occmundial/orgs","repos_url":"https://api.github.com/users/occmundial/repos","events_url":"https://api.github.com/users/occmundial/events{/privacy}","received_events_url":"https://api.github.com/users/occmundial/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/occmundial/occ-atomic","description":"Collection of shareable styled React components for OCC applications.","fork":false,"url":"https://api.github.com/repos/occmundial/occ-atomic","forks_url":"https://api.github.com/repos/occmundial/occ-atomic/forks","keys_url":"https://api.github.com/repos/occmundial/occ-atomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/occmundial/occ-atomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/occmundial/occ-atomic/teams","hooks_url":"https://api.github.com/repos/occmundial/occ-atomic/hooks","issue_events_url":"https://api.github.com/repos/occmundial/occ-atomic/issues/events{/number}","events_url":"https://api.github.com/repos/occmundial/occ-atomic/events","assignees_url":"https://api.github.com/repos/occmundial/occ-atomic/assignees{/user}","branches_url":"https://api.github.com/repos/occmundial/occ-atomic/branches{/branch}","tags_url":"https://api.github.com/repos/occmundial/occ-atomic/tags","blobs_url":"https://api.github.com/repos/occmundial/occ-atomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/occmundial/occ-atomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/occmundial/occ-atomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/occmundial/occ-atomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/occmundial/occ-atomic/statuses/{sha}","languages_url":"https://api.github.com/repos/occmundial/occ-atomic/languages","stargazers_url":"https://api.github.com/repos/occmundial/occ-atomic/stargazers","contributors_url":"https://api.github.com/repos/occmundial/occ-atomic/contributors","subscribers_url":"https://api.github.com/repos/occmundial/occ-atomic/subscribers","subscription_url":"https://api.github.com/repos/occmundial/occ-atomic/subscription","commits_url":"https://api.github.com/repos/occmundial/occ-atomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/occmundial/occ-atomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/occmundial/occ-atomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/occmundial/occ-atomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/occmundial/occ-atomic/contents/{+path}","compare_url":"https://api.github.com/repos/occmundial/occ-atomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/occmundial/occ-atomic/merges","archive_url":"https://api.github.com/repos/occmundial/occ-atomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/occmundial/occ-atomic/downloads","issues_url":"https://api.github.com/repos/occmundial/occ-atomic/issues{/number}","pulls_url":"https://api.github.com/repos/occmundial/occ-atomic/pulls{/number}","milestones_url":"https://api.github.com/repos/occmundial/occ-atomic/milestones{/number}","notifications_url":"https://api.github.com/repos/occmundial/occ-atomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/occmundial/occ-atomic/labels{/name}","releases_url":"https://api.github.com/repos/occmundial/occ-atomic/releases{/id}","deployments_url":"https://api.github.com/repos/occmundial/occ-atomic/deployments","created_at":"2018-06-12T23:17:48Z","updated_at":"2019-10-16T17:25:29Z","pushed_at":"2019-10-28T18:42:47Z","git_url":"git://github.com/occmundial/occ-atomic.git","ssh_url":"git@github.com:occmundial/occ-atomic.git","clone_url":"https://github.com/occmundial/occ-atomic.git","svn_url":"https://github.com/occmundial/occ-atomic","homepage":null,"size":6529,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"occmundial:master","ref":"master","sha":"067444343dbc2de49fbfbbc270b9da1b75e08611","user":{"login":"occmundial","id":22198811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTk4ODEx","avatar_url":"https://avatars0.githubusercontent.com/u/22198811?v=4","gravatar_id":"","url":"https://api.github.com/users/occmundial","html_url":"https://github.com/occmundial","followers_url":"https://api.github.com/users/occmundial/followers","following_url":"https://api.github.com/users/occmundial/following{/other_user}","gists_url":"https://api.github.com/users/occmundial/gists{/gist_id}","starred_url":"https://api.github.com/users/occmundial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occmundial/subscriptions","organizations_url":"https://api.github.com/users/occmundial/orgs","repos_url":"https://api.github.com/users/occmundial/repos","events_url":"https://api.github.com/users/occmundial/events{/privacy}","received_events_url":"https://api.github.com/users/occmundial/received_events","type":"Organization","site_admin":false},"repo":{"id":137137529,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzc1Mjk=","name":"occ-atomic","full_name":"occmundial/occ-atomic","private":false,"owner":{"login":"occmundial","id":22198811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTk4ODEx","avatar_url":"https://avatars0.githubusercontent.com/u/22198811?v=4","gravatar_id":"","url":"https://api.github.com/users/occmundial","html_url":"https://github.com/occmundial","followers_url":"https://api.github.com/users/occmundial/followers","following_url":"https://api.github.com/users/occmundial/following{/other_user}","gists_url":"https://api.github.com/users/occmundial/gists{/gist_id}","starred_url":"https://api.github.com/users/occmundial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occmundial/subscriptions","organizations_url":"https://api.github.com/users/occmundial/orgs","repos_url":"https://api.github.com/users/occmundial/repos","events_url":"https://api.github.com/users/occmundial/events{/privacy}","received_events_url":"https://api.github.com/users/occmundial/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/occmundial/occ-atomic","description":"Collection of shareable styled React components for OCC applications.","fork":false,"url":"https://api.github.com/repos/occmundial/occ-atomic","forks_url":"https://api.github.com/repos/occmundial/occ-atomic/forks","keys_url":"https://api.github.com/repos/occmundial/occ-atomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/occmundial/occ-atomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/occmundial/occ-atomic/teams","hooks_url":"https://api.github.com/repos/occmundial/occ-atomic/hooks","issue_events_url":"https://api.github.com/repos/occmundial/occ-atomic/issues/events{/number}","events_url":"https://api.github.com/repos/occmundial/occ-atomic/events","assignees_url":"https://api.github.com/repos/occmundial/occ-atomic/assignees{/user}","branches_url":"https://api.github.com/repos/occmundial/occ-atomic/branches{/branch}","tags_url":"https://api.github.com/repos/occmundial/occ-atomic/tags","blobs_url":"https://api.github.com/repos/occmundial/occ-atomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/occmundial/occ-atomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/occmundial/occ-atomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/occmundial/occ-atomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/occmundial/occ-atomic/statuses/{sha}","languages_url":"https://api.github.com/repos/occmundial/occ-atomic/languages","stargazers_url":"https://api.github.com/repos/occmundial/occ-atomic/stargazers","contributors_url":"https://api.github.com/repos/occmundial/occ-atomic/contributors","subscribers_url":"https://api.github.com/repos/occmundial/occ-atomic/subscribers","subscription_url":"https://api.github.com/repos/occmundial/occ-atomic/subscription","commits_url":"https://api.github.com/repos/occmundial/occ-atomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/occmundial/occ-atomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/occmundial/occ-atomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/occmundial/occ-atomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/occmundial/occ-atomic/contents/{+path}","compare_url":"https://api.github.com/repos/occmundial/occ-atomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/occmundial/occ-atomic/merges","archive_url":"https://api.github.com/repos/occmundial/occ-atomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/occmundial/occ-atomic/downloads","issues_url":"https://api.github.com/repos/occmundial/occ-atomic/issues{/number}","pulls_url":"https://api.github.com/repos/occmundial/occ-atomic/pulls{/number}","milestones_url":"https://api.github.com/repos/occmundial/occ-atomic/milestones{/number}","notifications_url":"https://api.github.com/repos/occmundial/occ-atomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/occmundial/occ-atomic/labels{/name}","releases_url":"https://api.github.com/repos/occmundial/occ-atomic/releases{/id}","deployments_url":"https://api.github.com/repos/occmundial/occ-atomic/deployments","created_at":"2018-06-12T23:17:48Z","updated_at":"2019-10-16T17:25:29Z","pushed_at":"2019-10-28T18:42:47Z","git_url":"git://github.com/occmundial/occ-atomic.git","ssh_url":"git@github.com:occmundial/occ-atomic.git","clone_url":"https://github.com/occmundial/occ-atomic.git","svn_url":"https://github.com/occmundial/occ-atomic","homepage":null,"size":6529,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29"},"html":{"href":"https://github.com/occmundial/occ-atomic/pull/29"},"issue":{"href":"https://api.github.com/repos/occmundial/occ-atomic/issues/29"},"comments":{"href":"https://api.github.com/repos/occmundial/occ-atomic/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/occmundial/occ-atomic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/occmundial/occ-atomic/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/occmundial/occ-atomic/statuses/c27fffbff22588bf9c93076140faa3e1c0cc9375"}},"author_association":"COLLABORATOR"}}
|
{
"id": 137137529,
"name": "occmundial/occ-atomic",
"url": "https://api.github.com/repos/occmundial/occ-atomic"
}
|
{
"id": 26333425,
"login": "ldiaz-occ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26333425?",
"url": "https://api.github.com/users/ldiaz-occ"
}
|
{
"id": 22198811,
"login": "occmundial",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22198811?",
"url": "https://api.github.com/orgs/occmundial"
}
| 2019-10-28T19:24:59 |
10731396452
|
{"actor":{"display_login":"ldiaz-occ"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/288527505","pull_request_review_id":243208641,"id":288527505,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODUyNzUwNQ==","diff_hunk":"@@ -0,0 +1,63 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n+\n+package mozilla.components.lib.crash.service\n+\n+import android.content.Context\n+import androidx.test.core.app.ApplicationProvider\n+import androidx.work.testing.WorkManagerTestInitHelper\n+import mozilla.components.lib.crash.Crash\n+import mozilla.components.lib.crash.GleanMetrics.CrashMetrics\n+import mozilla.components.service.glean.Glean\n+import org.junit.Assert.assertEquals\n+import org.junit.Assert.assertTrue\n+import org.junit.Test\n+import org.junit.Before\n+import org.junit.runner.RunWith\n+import org.mockito.Mockito.spy\n+import org.mockito.Mockito.verify\n+import org.mockito.Mockito.verifyNoMoreInteractions\n+import org.robolectric.RobolectricTestRunner\n+\n+@RunWith(RobolectricTestRunner::class)\n+class GleanServiceTest {","path":"components/lib/crash/src/test/java/mozilla/components/lib/crash/service/GleanServiceTest.kt","position":null,"original_position":24,"commit_id":"8f37b6e9c4c6d784291e2d46674a754f081e8715","original_commit_id":"5254d1a9d26210cef568963c03e99034ad9946f9","user":{"login":"travis79","id":7341315,"node_id":"MDQ6VXNlcjczNDEzMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7341315?v=4","gravatar_id":"","url":"https://api.github.com/users/travis79","html_url":"https://github.com/travis79","followers_url":"https://api.github.com/users/travis79/followers","following_url":"https://api.github.com/users/travis79/following{/other_user}","gists_url":"https://api.github.com/users/travis79/gists{/gist_id}","starred_url":"https://api.github.com/users/travis79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis79/subscriptions","organizations_url":"https://api.github.com/users/travis79/orgs","repos_url":"https://api.github.com/users/travis79/repos","events_url":"https://api.github.com/users/travis79/events{/privacy}","received_events_url":"https://api.github.com/users/travis79/received_events","type":"User","site_admin":false},"body":"So a simple test to show that lib-crash attempting to record before Glean is initialized doesn't crash and records no data, reasonable enough.","created_at":"2019-05-29T11:57:17Z","updated_at":"2019-05-29T11:57:17Z","html_url":"https://github.com/mozilla-mobile/android-components/pull/3099#discussion_r288527505","pull_request_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/288527505"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/3099#discussion_r288527505"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099"}},"in_reply_to_id":287278934},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099","id":281758691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxNzU4Njkx","html_url":"https://github.com/mozilla-mobile/android-components/pull/3099","diff_url":"https://github.com/mozilla-mobile/android-components/pull/3099.diff","patch_url":"https://github.com/mozilla-mobile/android-components/pull/3099.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/3099","number":3099,"state":"open","locked":false,"title":"Add a Glean CrashReporterService to lib-crash","user":{"login":"travis79","id":7341315,"node_id":"MDQ6VXNlcjczNDEzMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7341315?v=4","gravatar_id":"","url":"https://api.github.com/users/travis79","html_url":"https://github.com/travis79","followers_url":"https://api.github.com/users/travis79/followers","following_url":"https://api.github.com/users/travis79/following{/other_user}","gists_url":"https://api.github.com/users/travis79/gists{/gist_id}","starred_url":"https://api.github.com/users/travis79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis79/subscriptions","organizations_url":"https://api.github.com/users/travis79/orgs","repos_url":"https://api.github.com/users/travis79/repos","events_url":"https://api.github.com/users/travis79/events{/privacy}","received_events_url":"https://api.github.com/users/travis79/received_events","type":"User","site_admin":false},"body":"This includes two metrics defined in a metrics.yaml inside of lib-crash that instruments a count of each type (uncaught exceptions and native code crashes).\r\n\r\n### Pull Request checklist\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one\r\n- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features\r\n","created_at":"2019-05-23T19:47:42Z","updated_at":"2019-05-29T11:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e208ed4222d5055929ae76f5b62c4a56df4d42b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/3099/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/8f37b6e9c4c6d784291e2d46674a754f081e8715","head":{"label":"travis79:glean-lib-crash","ref":"glean-lib-crash","sha":"8f37b6e9c4c6d784291e2d46674a754f081e8715","user":{"login":"travis79","id":7341315,"node_id":"MDQ6VXNlcjczNDEzMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7341315?v=4","gravatar_id":"","url":"https://api.github.com/users/travis79","html_url":"https://github.com/travis79","followers_url":"https://api.github.com/users/travis79/followers","following_url":"https://api.github.com/users/travis79/following{/other_user}","gists_url":"https://api.github.com/users/travis79/gists{/gist_id}","starred_url":"https://api.github.com/users/travis79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis79/subscriptions","organizations_url":"https://api.github.com/users/travis79/orgs","repos_url":"https://api.github.com/users/travis79/repos","events_url":"https://api.github.com/users/travis79/events{/privacy}","received_events_url":"https://api.github.com/users/travis79/received_events","type":"User","site_admin":false},"repo":{"id":151725575,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MjU1NzU=","name":"android-components","full_name":"travis79/android-components","private":false,"owner":{"login":"travis79","id":7341315,"node_id":"MDQ6VXNlcjczNDEzMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7341315?v=4","gravatar_id":"","url":"https://api.github.com/users/travis79","html_url":"https://github.com/travis79","followers_url":"https://api.github.com/users/travis79/followers","following_url":"https://api.github.com/users/travis79/following{/other_user}","gists_url":"https://api.github.com/users/travis79/gists{/gist_id}","starred_url":"https://api.github.com/users/travis79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis79/subscriptions","organizations_url":"https://api.github.com/users/travis79/orgs","repos_url":"https://api.github.com/users/travis79/repos","events_url":"https://api.github.com/users/travis79/events{/privacy}","received_events_url":"https://api.github.com/users/travis79/received_events","type":"User","site_admin":false},"html_url":"https://github.com/travis79/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":true,"url":"https://api.github.com/repos/travis79/android-components","forks_url":"https://api.github.com/repos/travis79/android-components/forks","keys_url":"https://api.github.com/repos/travis79/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis79/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis79/android-components/teams","hooks_url":"https://api.github.com/repos/travis79/android-components/hooks","issue_events_url":"https://api.github.com/repos/travis79/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/travis79/android-components/events","assignees_url":"https://api.github.com/repos/travis79/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/travis79/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/travis79/android-components/tags","blobs_url":"https://api.github.com/repos/travis79/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis79/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis79/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis79/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis79/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/travis79/android-components/languages","stargazers_url":"https://api.github.com/repos/travis79/android-components/stargazers","contributors_url":"https://api.github.com/repos/travis79/android-components/contributors","subscribers_url":"https://api.github.com/repos/travis79/android-components/subscribers","subscription_url":"https://api.github.com/repos/travis79/android-components/subscription","commits_url":"https://api.github.com/repos/travis79/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis79/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis79/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis79/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis79/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/travis79/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis79/android-components/merges","archive_url":"https://api.github.com/repos/travis79/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis79/android-components/downloads","issues_url":"https://api.github.com/repos/travis79/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/travis79/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/travis79/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/travis79/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis79/android-components/labels{/name}","releases_url":"https://api.github.com/repos/travis79/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/travis79/android-components/deployments","created_at":"2018-10-05T13:34:17Z","updated_at":"2019-01-04T17:11:11Z","pushed_at":"2019-05-28T20:36:24Z","git_url":"git://github.com/travis79/android-components.git","ssh_url":"git@github.com:travis79/android-components.git","clone_url":"https://github.com/travis79/android-components.git","svn_url":"https://github.com/travis79/android-components","homepage":"https://mozilla-mobile.github.io/android-components/","size":49424,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"8d88f0628afabedf70e689d227c13548d15dc881","user":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":126199585,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxOTk1ODU=","name":"android-components","full_name":"mozilla-mobile/android-components","private":false,"owner":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-mobile/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/android-components","forks_url":"https://api.github.com/repos/mozilla-mobile/android-components/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/android-components/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/android-components/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/android-components/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/android-components/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/android-components/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/android-components/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/android-components/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/android-components/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/android-components/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/android-components/deployments","created_at":"2018-03-21T15:24:03Z","updated_at":"2019-05-28T19:37:39Z","pushed_at":"2019-05-29T10:58:38Z","git_url":"git://github.com/mozilla-mobile/android-components.git","ssh_url":"git@github.com:mozilla-mobile/android-components.git","clone_url":"https://github.com/mozilla-mobile/android-components.git","svn_url":"https://github.com/mozilla-mobile/android-components","homepage":"https://mozac.org","size":49430,"stargazers_count":805,"watchers_count":805,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":152,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":448,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":152,"open_issues":448,"watchers":805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/3099"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/3099"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/3099/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/3099/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/8f37b6e9c4c6d784291e2d46674a754f081e8715"}},"author_association":"MEMBER"}}
|
{
"id": 126199585,
"name": "mozilla-mobile/android-components",
"url": "https://api.github.com/repos/mozilla-mobile/android-components"
}
|
{
"id": 7341315,
"login": "travis79",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7341315?",
"url": "https://api.github.com/users/travis79"
}
|
{
"id": 22351667,
"login": "mozilla-mobile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22351667?",
"url": "https://api.github.com/orgs/mozilla-mobile"
}
| 2019-05-29T11:57:17 |
9718573729
|
{"actor":{"display_login":"travis79"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/comments/313129764","pull_request_review_id":273952412,"id":313129764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzEyOTc2NA==","diff_hunk":"@@ -134,15 +134,23 @@ These effects are defined by two brushes:\n In most cases we handle the usage of both of them by turning Reveal on automatically for a certain controls. However, other controls will need to be enabled through applying a style, or changing their templates directly.\n \n ### When to add Reveal\n-You can add Reveal to your custom controls--but before you do, consider the type of control and how it behaves. \n-* If your custom control is a single interactive element and doesn't have similar controls sharing it's space (such as menu items in a menu), it's likely that your custom control doesn't need Reveal. \n-* If you have a grouping of related interactive content or elements, then it's likely that that region of your app does need Reveal - this is commonly referred to as a [Commanding](https://docs.microsoft.com/windows/uwp/design/controls-and-patterns/collection-commanding) surface.\n+You can add Reveal to your custom controls--but before you do, consider the type of control and how it behaves.\n \n-For example, a button by itself shouldn't use reveal, but a set of buttons in a command bar should use Reveal.\n+Add Reveal when\n+* **Your control is in a group of other similarly-sized, interactive items**\n+Enable Reveal on all of the controls in the group. The Reveal effect will make it easier for users to see which specific control they're interacting with.\n+* **Your custom control part of a [Commanding Collection](https://docs.microsoft.com/windows/uwp/design/controls-and-patterns/collection-commanding)?**\n+Reveal is a great choice for situations like these.\n+\n+Don't add Reveal when\n+* **Your control isn't near hero content or is far away from other interactive elements**\n+Reveal is not the best choice for these scenarios.\n+\n+In general, Reveal highlight brings attention to certain areas of your app, or to pieces of interactive UI that you want most of your user's focus to be drawn to. Adding Reveal to secondary UI can cause distraction, or mislead their attention; however, adding it to primary UI or hero moments in your app is where Reveal really shines.","path":"windows-apps-src/design/style/reveal.md","position":47,"original_position":47,"commit_id":"1b90f47ffb9f6a405b7700266c34c537e896d2f4","original_commit_id":"1b90f47ffb9f6a405b7700266c34c537e896d2f4","user":{"login":"chigy","id":22958680,"node_id":"MDQ6VXNlcjIyOTU4Njgw","avatar_url":"https://avatars1.githubusercontent.com/u/22958680?v=4","gravatar_id":"","url":"https://api.github.com/users/chigy","html_url":"https://github.com/chigy","followers_url":"https://api.github.com/users/chigy/followers","following_url":"https://api.github.com/users/chigy/following{/other_user}","gists_url":"https://api.github.com/users/chigy/gists{/gist_id}","starred_url":"https://api.github.com/users/chigy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chigy/subscriptions","organizations_url":"https://api.github.com/users/chigy/orgs","repos_url":"https://api.github.com/users/chigy/repos","events_url":"https://api.github.com/users/chigy/events{/privacy}","received_events_url":"https://api.github.com/users/chigy/received_events","type":"User","site_admin":false},"body":">Adding Reveal to secondary UI can cause distraction, or mislead their attention; however, adding it to primary UI or hero moments in your app is where Reveal really shines.\r\n\r\nI do not understand what you mean by primary/secondary UI. What is hero moments?","created_at":"2019-08-12T21:09:37Z","updated_at":"2019-08-12T21:09:37Z","html_url":"https://github.com/MicrosoftDocs/windows-uwp/pull/1857#discussion_r313129764","pull_request_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/comments/313129764"},"html":{"href":"https://github.com/MicrosoftDocs/windows-uwp/pull/1857#discussion_r313129764"},"pull_request":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857"}}},"pull_request":{"url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857","id":306653749,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NjUzNzQ5","html_url":"https://github.com/MicrosoftDocs/windows-uwp/pull/1857","diff_url":"https://github.com/MicrosoftDocs/windows-uwp/pull/1857.diff","patch_url":"https://github.com/MicrosoftDocs/windows-uwp/pull/1857.patch","issue_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/issues/1857","number":1857,"state":"open","locked":false,"title":"Updates to reveal.md","user":{"login":"kikisaints","id":6964369,"node_id":"MDQ6VXNlcjY5NjQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6964369?v=4","gravatar_id":"","url":"https://api.github.com/users/kikisaints","html_url":"https://github.com/kikisaints","followers_url":"https://api.github.com/users/kikisaints/followers","following_url":"https://api.github.com/users/kikisaints/following{/other_user}","gists_url":"https://api.github.com/users/kikisaints/gists{/gist_id}","starred_url":"https://api.github.com/users/kikisaints/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikisaints/subscriptions","organizations_url":"https://api.github.com/users/kikisaints/orgs","repos_url":"https://api.github.com/users/kikisaints/repos","events_url":"https://api.github.com/users/kikisaints/events{/privacy}","received_events_url":"https://api.github.com/users/kikisaints/received_events","type":"User","site_admin":false},"body":"Reworded the \"when to add reveal\" section, updated the do's and don'ts page.","created_at":"2019-08-12T20:45:33Z","updated_at":"2019-08-12T21:09:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a247c5435cb71909e80d40e472ab5d3f9e0a545f","assignee":{"login":"mijacobs","id":16708640,"node_id":"MDQ6VXNlcjE2NzA4NjQw","avatar_url":"https://avatars0.githubusercontent.com/u/16708640?v=4","gravatar_id":"","url":"https://api.github.com/users/mijacobs","html_url":"https://github.com/mijacobs","followers_url":"https://api.github.com/users/mijacobs/followers","following_url":"https://api.github.com/users/mijacobs/following{/other_user}","gists_url":"https://api.github.com/users/mijacobs/gists{/gist_id}","starred_url":"https://api.github.com/users/mijacobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mijacobs/subscriptions","organizations_url":"https://api.github.com/users/mijacobs/orgs","repos_url":"https://api.github.com/users/mijacobs/repos","events_url":"https://api.github.com/users/mijacobs/events{/privacy}","received_events_url":"https://api.github.com/users/mijacobs/received_events","type":"User","site_admin":false},"assignees":[{"login":"mijacobs","id":16708640,"node_id":"MDQ6VXNlcjE2NzA4NjQw","avatar_url":"https://avatars0.githubusercontent.com/u/16708640?v=4","gravatar_id":"","url":"https://api.github.com/users/mijacobs","html_url":"https://github.com/mijacobs","followers_url":"https://api.github.com/users/mijacobs/followers","following_url":"https://api.github.com/users/mijacobs/following{/other_user}","gists_url":"https://api.github.com/users/mijacobs/gists{/gist_id}","starred_url":"https://api.github.com/users/mijacobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mijacobs/subscriptions","organizations_url":"https://api.github.com/users/mijacobs/orgs","repos_url":"https://api.github.com/users/mijacobs/repos","events_url":"https://api.github.com/users/mijacobs/events{/privacy}","received_events_url":"https://api.github.com/users/mijacobs/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mijacobs","id":16708640,"node_id":"MDQ6VXNlcjE2NzA4NjQw","avatar_url":"https://avatars0.githubusercontent.com/u/16708640?v=4","gravatar_id":"","url":"https://api.github.com/users/mijacobs","html_url":"https://github.com/mijacobs","followers_url":"https://api.github.com/users/mijacobs/followers","following_url":"https://api.github.com/users/mijacobs/following{/other_user}","gists_url":"https://api.github.com/users/mijacobs/gists{/gist_id}","starred_url":"https://api.github.com/users/mijacobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mijacobs/subscriptions","organizations_url":"https://api.github.com/users/mijacobs/orgs","repos_url":"https://api.github.com/users/mijacobs/repos","events_url":"https://api.github.com/users/mijacobs/events{/privacy}","received_events_url":"https://api.github.com/users/mijacobs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1417386763,"node_id":"MDU6TGFiZWwxNDE3Mzg2NzYz","url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/labels/Change%20sent%20to%20author","name":"Change sent to author","color":"d93f0b","default":false},{"id":1441990499,"node_id":"MDU6TGFiZWwxNDQxOTkwNDk5","url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/labels/assessing_(C&L)","name":"assessing_(C&L)","color":"5139db","default":false},{"id":1417386110,"node_id":"MDU6TGFiZWwxNDE3Mzg2MTEw","url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/labels/do-not-merge","name":"do-not-merge","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857/commits","review_comments_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857/comments","review_comment_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/issues/1857/comments","statuses_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/statuses/1b90f47ffb9f6a405b7700266c34c537e896d2f4","head":{"label":"kikisaints:docs","ref":"docs","sha":"1b90f47ffb9f6a405b7700266c34c537e896d2f4","user":{"login":"kikisaints","id":6964369,"node_id":"MDQ6VXNlcjY5NjQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6964369?v=4","gravatar_id":"","url":"https://api.github.com/users/kikisaints","html_url":"https://github.com/kikisaints","followers_url":"https://api.github.com/users/kikisaints/followers","following_url":"https://api.github.com/users/kikisaints/following{/other_user}","gists_url":"https://api.github.com/users/kikisaints/gists{/gist_id}","starred_url":"https://api.github.com/users/kikisaints/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikisaints/subscriptions","organizations_url":"https://api.github.com/users/kikisaints/orgs","repos_url":"https://api.github.com/users/kikisaints/repos","events_url":"https://api.github.com/users/kikisaints/events{/privacy}","received_events_url":"https://api.github.com/users/kikisaints/received_events","type":"User","site_admin":false},"repo":{"id":202005808,"node_id":"MDEwOlJlcG9zaXRvcnkyMDIwMDU4MDg=","name":"windows-uwp","full_name":"kikisaints/windows-uwp","private":false,"owner":{"login":"kikisaints","id":6964369,"node_id":"MDQ6VXNlcjY5NjQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6964369?v=4","gravatar_id":"","url":"https://api.github.com/users/kikisaints","html_url":"https://github.com/kikisaints","followers_url":"https://api.github.com/users/kikisaints/followers","following_url":"https://api.github.com/users/kikisaints/following{/other_user}","gists_url":"https://api.github.com/users/kikisaints/gists{/gist_id}","starred_url":"https://api.github.com/users/kikisaints/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikisaints/subscriptions","organizations_url":"https://api.github.com/users/kikisaints/orgs","repos_url":"https://api.github.com/users/kikisaints/repos","events_url":"https://api.github.com/users/kikisaints/events{/privacy}","received_events_url":"https://api.github.com/users/kikisaints/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kikisaints/windows-uwp","description":"Conceptual and overview content for developing Microsoft Universal Windows Platform (UWP) apps","fork":true,"url":"https://api.github.com/repos/kikisaints/windows-uwp","forks_url":"https://api.github.com/repos/kikisaints/windows-uwp/forks","keys_url":"https://api.github.com/repos/kikisaints/windows-uwp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kikisaints/windows-uwp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kikisaints/windows-uwp/teams","hooks_url":"https://api.github.com/repos/kikisaints/windows-uwp/hooks","issue_events_url":"https://api.github.com/repos/kikisaints/windows-uwp/issues/events{/number}","events_url":"https://api.github.com/repos/kikisaints/windows-uwp/events","assignees_url":"https://api.github.com/repos/kikisaints/windows-uwp/assignees{/user}","branches_url":"https://api.github.com/repos/kikisaints/windows-uwp/branches{/branch}","tags_url":"https://api.github.com/repos/kikisaints/windows-uwp/tags","blobs_url":"https://api.github.com/repos/kikisaints/windows-uwp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kikisaints/windows-uwp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kikisaints/windows-uwp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kikisaints/windows-uwp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kikisaints/windows-uwp/statuses/{sha}","languages_url":"https://api.github.com/repos/kikisaints/windows-uwp/languages","stargazers_url":"https://api.github.com/repos/kikisaints/windows-uwp/stargazers","contributors_url":"https://api.github.com/repos/kikisaints/windows-uwp/contributors","subscribers_url":"https://api.github.com/repos/kikisaints/windows-uwp/subscribers","subscription_url":"https://api.github.com/repos/kikisaints/windows-uwp/subscription","commits_url":"https://api.github.com/repos/kikisaints/windows-uwp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kikisaints/windows-uwp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kikisaints/windows-uwp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kikisaints/windows-uwp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kikisaints/windows-uwp/contents/{+path}","compare_url":"https://api.github.com/repos/kikisaints/windows-uwp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kikisaints/windows-uwp/merges","archive_url":"https://api.github.com/repos/kikisaints/windows-uwp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kikisaints/windows-uwp/downloads","issues_url":"https://api.github.com/repos/kikisaints/windows-uwp/issues{/number}","pulls_url":"https://api.github.com/repos/kikisaints/windows-uwp/pulls{/number}","milestones_url":"https://api.github.com/repos/kikisaints/windows-uwp/milestones{/number}","notifications_url":"https://api.github.com/repos/kikisaints/windows-uwp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kikisaints/windows-uwp/labels{/name}","releases_url":"https://api.github.com/repos/kikisaints/windows-uwp/releases{/id}","deployments_url":"https://api.github.com/repos/kikisaints/windows-uwp/deployments","created_at":"2019-08-12T20:41:16Z","updated_at":"2019-08-12T20:59:39Z","pushed_at":"2019-08-12T20:59:37Z","git_url":"git://github.com/kikisaints/windows-uwp.git","ssh_url":"git@github.com:kikisaints/windows-uwp.git","clone_url":"https://github.com/kikisaints/windows-uwp.git","svn_url":"https://github.com/kikisaints/windows-uwp","homepage":null,"size":642684,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"docs"}},"base":{"label":"MicrosoftDocs:docs","ref":"docs","sha":"a28a32fff9d15ecf4a9d172cd0a04f4d993f9d76","user":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"repo":{"id":78895763,"node_id":"MDEwOlJlcG9zaXRvcnk3ODg5NTc2Mw==","name":"windows-uwp","full_name":"MicrosoftDocs/windows-uwp","private":false,"owner":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MicrosoftDocs/windows-uwp","description":"Conceptual and overview content for developing Microsoft Universal Windows Platform (UWP) apps","fork":false,"url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp","forks_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/forks","keys_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/teams","hooks_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/hooks","issue_events_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/issues/events{/number}","events_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/events","assignees_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/assignees{/user}","branches_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/branches{/branch}","tags_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/tags","blobs_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/statuses/{sha}","languages_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/languages","stargazers_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/stargazers","contributors_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/contributors","subscribers_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/subscribers","subscription_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/subscription","commits_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/issues/comments{/number}","contents_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/contents/{+path}","compare_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/merges","archive_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/downloads","issues_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/issues{/number}","pulls_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls{/number}","milestones_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/milestones{/number}","notifications_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/labels{/name}","releases_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/releases{/id}","deployments_url":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/deployments","created_at":"2017-01-13T23:45:55Z","updated_at":"2019-08-12T20:11:24Z","pushed_at":"2019-08-12T20:59:37Z","git_url":"git://github.com/MicrosoftDocs/windows-uwp.git","ssh_url":"git@github.com:MicrosoftDocs/windows-uwp.git","clone_url":"https://github.com/MicrosoftDocs/windows-uwp.git","svn_url":"https://github.com/MicrosoftDocs/windows-uwp","homepage":null,"size":642684,"stargazers_count":186,"watchers_count":186,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":548,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":330,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":548,"open_issues":330,"watchers":186,"default_branch":"docs"}},"_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857"},"html":{"href":"https://github.com/MicrosoftDocs/windows-uwp/pull/1857"},"issue":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/issues/1857"},"comments":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/issues/1857/comments"},"review_comments":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857/comments"},"review_comment":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/pulls/1857/commits"},"statuses":{"href":"https://api.github.com/repos/MicrosoftDocs/windows-uwp/statuses/1b90f47ffb9f6a405b7700266c34c537e896d2f4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 78895763,
"name": "MicrosoftDocs/windows-uwp",
"url": "https://api.github.com/repos/MicrosoftDocs/windows-uwp"
}
|
{
"id": 22958680,
"login": "chigy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22958680?",
"url": "https://api.github.com/users/chigy"
}
|
{
"id": 22479449,
"login": "MicrosoftDocs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22479449?",
"url": "https://api.github.com/orgs/MicrosoftDocs"
}
| 2019-08-12T21:09:37 |
10196587972
|
{"actor":{"display_login":"chigy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/comments/303052262","pull_request_review_id":261350297,"id":303052262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzA1MjI2Mg==","diff_hunk":"@@ -238,7 +238,8 @@ Column # | Name | Type | Note\n 19 | CitationCount | long |\n 20 | EstimatedCitation | long |\n 21 | OriginalVenue | string |\n-22 | CreatedDate | DateTime |\n+22 | FamilyId | long? |","path":"academic-services/graph/reference-data-schema.md","position":25,"original_position":25,"commit_id":"52b9744ffd0fed5bb7b20da3992bf437cec427e1","original_commit_id":"52b9744ffd0fed5bb7b20da3992bf437cec427e1","user":{"login":"DarrinEide","id":22197592,"node_id":"MDQ6VXNlcjIyMTk3NTky","avatar_url":"https://avatars1.githubusercontent.com/u/22197592?v=4","gravatar_id":"","url":"https://api.github.com/users/DarrinEide","html_url":"https://github.com/DarrinEide","followers_url":"https://api.github.com/users/DarrinEide/followers","following_url":"https://api.github.com/users/DarrinEide/following{/other_user}","gists_url":"https://api.github.com/users/DarrinEide/gists{/gist_id}","starred_url":"https://api.github.com/users/DarrinEide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarrinEide/subscriptions","organizations_url":"https://api.github.com/users/DarrinEide/orgs","repos_url":"https://api.github.com/users/DarrinEide/repos","events_url":"https://api.github.com/users/DarrinEide/events{/privacy}","received_events_url":"https://api.github.com/users/DarrinEide/received_events","type":"User","site_admin":false},"body":"Should probably add a small description to the field","created_at":"2019-07-12T16:13:32Z","updated_at":"2019-07-12T16:18:18Z","html_url":"https://github.com/MicrosoftDocs/microsoft-academic-services/pull/60#discussion_r303052262","pull_request_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/comments/303052262"},"html":{"href":"https://github.com/MicrosoftDocs/microsoft-academic-services/pull/60#discussion_r303052262"},"pull_request":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60","id":296866486,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2ODY2NDg2","html_url":"https://github.com/MicrosoftDocs/microsoft-academic-services/pull/60","diff_url":"https://github.com/MicrosoftDocs/microsoft-academic-services/pull/60.diff","patch_url":"https://github.com/MicrosoftDocs/microsoft-academic-services/pull/60.patch","issue_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/60","number":60,"state":"open","locked":false,"title":"Added paper family (#59)","user":{"login":"cyhuang01","id":44510938,"node_id":"MDQ6VXNlcjQ0NTEwOTM4","avatar_url":"https://avatars2.githubusercontent.com/u/44510938?v=4","gravatar_id":"","url":"https://api.github.com/users/cyhuang01","html_url":"https://github.com/cyhuang01","followers_url":"https://api.github.com/users/cyhuang01/followers","following_url":"https://api.github.com/users/cyhuang01/following{/other_user}","gists_url":"https://api.github.com/users/cyhuang01/gists{/gist_id}","starred_url":"https://api.github.com/users/cyhuang01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyhuang01/subscriptions","organizations_url":"https://api.github.com/users/cyhuang01/orgs","repos_url":"https://api.github.com/users/cyhuang01/repos","events_url":"https://api.github.com/users/cyhuang01/events{/privacy}","received_events_url":"https://api.github.com/users/cyhuang01/received_events","type":"User","site_admin":false},"body":"* Update reference-data-schema.md\r\n\r\n* Update tutorial-azure-data-lake-hindex.md\r\n\r\n* Update reference-data-schema.md\r\n\r\n* Update tutorial-azure-search-org-patents.md\r\n\r\n* Update tutorial-azure-search-reference-parsing.md\r\n\r\n* Update reference-data-schema.md\r\n\r\n* Add files via upload\r\n\r\n* Update tutorial-azure-data-lake-hindex.md\r\n\r\n* Update tutorial-azure-data-lake-hindex.md\r\n\r\n* Update tutorial-azure-databricks-hindex.md\r\n\r\n* Update tutorial-azure-databricks-hindex.md\r\n\r\n* Update tutorial-azure-databricks-hindex.md\r\n\r\n* Update tutorial-azure-databricks-hindex.md\r\n\r\n* Update index.yml\r\n\r\n* Update TOC.yml\r\n\r\n* Update tutorial-azure-databricks-hindex.md\r\n\r\n* Update tutorial-azure-databricks-hindex.md\r\n\r\n* Update tutorial-azure-data-lake-hindex.md\r\n\r\n* Update tutorial-azure-data-lake-hindex.md\r\n\r\n* Update tutorial-azure-databricks-hindex.md\r\n\r\n* Update tutorial-azure-search-org-patents.md\r\n\r\n* Update tutorial-azure-search-reference-parsing.md","created_at":"2019-07-11T23:51:00Z","updated_at":"2019-07-12T16:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4147c28cf014ed3c36553bdc28dd061b477f7358","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60/commits","review_comments_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60/comments","review_comment_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/60/comments","statuses_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/statuses/52b9744ffd0fed5bb7b20da3992bf437cec427e1","head":{"label":"MicrosoftDocs:master","ref":"master","sha":"52b9744ffd0fed5bb7b20da3992bf437cec427e1","user":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"repo":{"id":152815386,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MTUzODY=","name":"microsoft-academic-services","full_name":"MicrosoftDocs/microsoft-academic-services","private":false,"owner":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MicrosoftDocs/microsoft-academic-services","description":null,"fork":false,"url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services","forks_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/forks","keys_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/teams","hooks_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/hooks","issue_events_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/events{/number}","events_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/events","assignees_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/assignees{/user}","branches_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/branches{/branch}","tags_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/tags","blobs_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/statuses/{sha}","languages_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/languages","stargazers_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/stargazers","contributors_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/contributors","subscribers_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/subscribers","subscription_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/subscription","commits_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/contents/{+path}","compare_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/merges","archive_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/downloads","issues_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues{/number}","pulls_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls{/number}","milestones_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/milestones{/number}","notifications_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/labels{/name}","releases_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/releases{/id}","deployments_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/deployments","created_at":"2018-10-12T22:54:14Z","updated_at":"2019-07-11T23:38:24Z","pushed_at":"2019-07-11T23:51:01Z","git_url":"git://github.com/MicrosoftDocs/microsoft-academic-services.git","ssh_url":"git@github.com:MicrosoftDocs/microsoft-academic-services.git","clone_url":"https://github.com/MicrosoftDocs/microsoft-academic-services.git","svn_url":"https://github.com/MicrosoftDocs/microsoft-academic-services","homepage":null,"size":6284,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"MicrosoftDocs:live","ref":"live","sha":"9c32fd1f7c9d04a0d86ceaca4372104ee9044839","user":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"repo":{"id":152815386,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MTUzODY=","name":"microsoft-academic-services","full_name":"MicrosoftDocs/microsoft-academic-services","private":false,"owner":{"login":"MicrosoftDocs","id":22479449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDc5NDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MicrosoftDocs/microsoft-academic-services","description":null,"fork":false,"url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services","forks_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/forks","keys_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/teams","hooks_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/hooks","issue_events_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/events{/number}","events_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/events","assignees_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/assignees{/user}","branches_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/branches{/branch}","tags_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/tags","blobs_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/statuses/{sha}","languages_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/languages","stargazers_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/stargazers","contributors_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/contributors","subscribers_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/subscribers","subscription_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/subscription","commits_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/contents/{+path}","compare_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/merges","archive_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/downloads","issues_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues{/number}","pulls_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls{/number}","milestones_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/milestones{/number}","notifications_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/labels{/name}","releases_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/releases{/id}","deployments_url":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/deployments","created_at":"2018-10-12T22:54:14Z","updated_at":"2019-07-11T23:38:24Z","pushed_at":"2019-07-11T23:51:01Z","git_url":"git://github.com/MicrosoftDocs/microsoft-academic-services.git","ssh_url":"git@github.com:MicrosoftDocs/microsoft-academic-services.git","clone_url":"https://github.com/MicrosoftDocs/microsoft-academic-services.git","svn_url":"https://github.com/MicrosoftDocs/microsoft-academic-services","homepage":null,"size":6284,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60"},"html":{"href":"https://github.com/MicrosoftDocs/microsoft-academic-services/pull/60"},"issue":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/60"},"comments":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services/statuses/52b9744ffd0fed5bb7b20da3992bf437cec427e1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 152815386,
"name": "MicrosoftDocs/microsoft-academic-services",
"url": "https://api.github.com/repos/MicrosoftDocs/microsoft-academic-services"
}
|
{
"id": 22197592,
"login": "DarrinEide",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22197592?",
"url": "https://api.github.com/users/DarrinEide"
}
|
{
"id": 22479449,
"login": "MicrosoftDocs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22479449?",
"url": "https://api.github.com/orgs/MicrosoftDocs"
}
| 2019-07-12T16:13:32 |
10001711227
|
{"actor":{"display_login":"DarrinEide"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/comments/358104101","pull_request_review_id":332403967,"id":358104101,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODEwNDEwMQ==","diff_hunk":"@@ -125,14 +125,15 @@ const displayInternRequests = (level) => (context) => {\n */\n const errorHandler = (context) => {\n \tif (context.error) {\n-\t\t// too much for logging...\n \t\tif (context.error.hook) {\n+\t\t\t// too much for logging...\n \t\t\tdelete context.error.hook;\n \t\t}\n \n-\t\t// statusCode is return by extern services / or mocks that use express res.status(myCodeNumber)\n-\t\tif (!context.error.code && !context.error.statusCode) {\n-\t\t\tcontext.error = new GeneralError(context.error.message || 'server error', context.error.stack || '');\n+\t\tif (!context.error.type || context.error.type !== 'FeathersError') {","path":"src/app.hooks.js","position":13,"original_position":13,"commit_id":"f823644e413452a5d9245b8baa9ce952e0b75040","original_commit_id":"f823644e413452a5d9245b8baa9ce952e0b75040","user":{"login":"tofixx","id":4550014,"node_id":"MDQ6VXNlcjQ1NTAwMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4550014?v=4","gravatar_id":"","url":"https://api.github.com/users/tofixx","html_url":"https://github.com/tofixx","followers_url":"https://api.github.com/users/tofixx/followers","following_url":"https://api.github.com/users/tofixx/following{/other_user}","gists_url":"https://api.github.com/users/tofixx/gists{/gist_id}","starred_url":"https://api.github.com/users/tofixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofixx/subscriptions","organizations_url":"https://api.github.com/users/tofixx/orgs","repos_url":"https://api.github.com/users/tofixx/repos","events_url":"https://api.github.com/users/tofixx/events{/privacy}","received_events_url":"https://api.github.com/users/tofixx/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\tif (!context.error.type || typeof context.error.type !== 'FeathersError') {\r\n```\r\nis there a typecheck result not working?","created_at":"2019-12-16T08:37:06Z","updated_at":"2019-12-16T08:40:00Z","html_url":"https://github.com/schul-cloud/schulcloud-server/pull/894#discussion_r358104101","pull_request_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/comments/358104101"},"html":{"href":"https://github.com/schul-cloud/schulcloud-server/pull/894#discussion_r358104101"},"pull_request":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894"}}},"pull_request":{"url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894","id":351301393,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMzAxMzkz","html_url":"https://github.com/schul-cloud/schulcloud-server/pull/894","diff_url":"https://github.com/schul-cloud/schulcloud-server/pull/894.diff","patch_url":"https://github.com/schul-cloud/schulcloud-server/pull/894.patch","issue_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/894","number":894,"state":"open","locked":false,"title":"feature/SC-2915 Improve logging for errors","user":{"login":"CeEv","id":12080057,"node_id":"MDQ6VXNlcjEyMDgwMDU3","avatar_url":"https://avatars1.githubusercontent.com/u/12080057?v=4","gravatar_id":"","url":"https://api.github.com/users/CeEv","html_url":"https://github.com/CeEv","followers_url":"https://api.github.com/users/CeEv/followers","following_url":"https://api.github.com/users/CeEv/following{/other_user}","gists_url":"https://api.github.com/users/CeEv/gists{/gist_id}","starred_url":"https://api.github.com/users/CeEv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CeEv/subscriptions","organizations_url":"https://api.github.com/users/CeEv/orgs","repos_url":"https://api.github.com/users/CeEv/repos","events_url":"https://api.github.com/users/CeEv/events{/privacy}","received_events_url":"https://api.github.com/users/CeEv/received_events","type":"User","site_admin":false},"body":"# Checkliste\r\n\r\n- Bis die komplette Checkliste abgearbeitet ist muss das PR-Label WIP gesetzt sein\r\n\r\n## Allgemein\r\n- [x] Link zum Ticket https://ticketsystem.schul-cloud.org/browse/SC-2915\r\n\r\n## Code Qualität\r\n- [x] Code mit Hinblick auf Security und Datensicherheit betrachten\r\n- [x] Linter darf keine Probleme bei veränderten Dateien aufweisen\r\n- [x] Kern-Logik ist hinter der API implementiert?\r\n\r\n## Freigabe zum Review\r\n- [x] WIP PR-Label entfernt, wenn die Checkliste abgearbeitet wurde\r\n\r\n## Mehr\r\nWeitere Informationen zur DoD [hier im Confluence](https://docs.schul-cloud.org/pages/viewpage.action?pageId=92831762)\r\n","created_at":"2019-12-10T10:03:20Z","updated_at":"2019-12-16T08:40:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07ee37560951ad7479facc67c95ef7c7f648734e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CordlessWool","id":17884035,"node_id":"MDQ6VXNlcjE3ODg0MDM1","avatar_url":"https://avatars0.githubusercontent.com/u/17884035?v=4","gravatar_id":"","url":"https://api.github.com/users/CordlessWool","html_url":"https://github.com/CordlessWool","followers_url":"https://api.github.com/users/CordlessWool/followers","following_url":"https://api.github.com/users/CordlessWool/following{/other_user}","gists_url":"https://api.github.com/users/CordlessWool/gists{/gist_id}","starred_url":"https://api.github.com/users/CordlessWool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CordlessWool/subscriptions","organizations_url":"https://api.github.com/users/CordlessWool/orgs","repos_url":"https://api.github.com/users/CordlessWool/repos","events_url":"https://api.github.com/users/CordlessWool/events{/privacy}","received_events_url":"https://api.github.com/users/CordlessWool/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894/commits","review_comments_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894/comments","review_comment_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/894/comments","statuses_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/statuses/f823644e413452a5d9245b8baa9ce952e0b75040","head":{"label":"schul-cloud:feature/SC-2915-improve-error-handling","ref":"feature/SC-2915-improve-error-handling","sha":"f823644e413452a5d9245b8baa9ce952e0b75040","user":{"login":"schul-cloud","id":22611463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjExNDYz","avatar_url":"https://avatars2.githubusercontent.com/u/22611463?v=4","gravatar_id":"","url":"https://api.github.com/users/schul-cloud","html_url":"https://github.com/schul-cloud","followers_url":"https://api.github.com/users/schul-cloud/followers","following_url":"https://api.github.com/users/schul-cloud/following{/other_user}","gists_url":"https://api.github.com/users/schul-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/schul-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schul-cloud/subscriptions","organizations_url":"https://api.github.com/users/schul-cloud/orgs","repos_url":"https://api.github.com/users/schul-cloud/repos","events_url":"https://api.github.com/users/schul-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/schul-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":71375009,"node_id":"MDEwOlJlcG9zaXRvcnk3MTM3NTAwOQ==","name":"schulcloud-server","full_name":"schul-cloud/schulcloud-server","private":false,"owner":{"login":"schul-cloud","id":22611463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjExNDYz","avatar_url":"https://avatars2.githubusercontent.com/u/22611463?v=4","gravatar_id":"","url":"https://api.github.com/users/schul-cloud","html_url":"https://github.com/schul-cloud","followers_url":"https://api.github.com/users/schul-cloud/followers","following_url":"https://api.github.com/users/schul-cloud/following{/other_user}","gists_url":"https://api.github.com/users/schul-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/schul-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schul-cloud/subscriptions","organizations_url":"https://api.github.com/users/schul-cloud/orgs","repos_url":"https://api.github.com/users/schul-cloud/repos","events_url":"https://api.github.com/users/schul-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/schul-cloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/schul-cloud/schulcloud-server","description":"Schul-Cloud Core Server","fork":false,"url":"https://api.github.com/repos/schul-cloud/schulcloud-server","forks_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/forks","keys_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/teams","hooks_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/hooks","issue_events_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/events{/number}","events_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/events","assignees_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/assignees{/user}","branches_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/branches{/branch}","tags_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/tags","blobs_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/statuses/{sha}","languages_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/languages","stargazers_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/stargazers","contributors_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/contributors","subscribers_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/subscribers","subscription_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/subscription","commits_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/contents/{+path}","compare_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/merges","archive_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/downloads","issues_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues{/number}","pulls_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls{/number}","milestones_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/milestones{/number}","notifications_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/labels{/name}","releases_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/releases{/id}","deployments_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/deployments","created_at":"2016-10-19T16:04:27Z","updated_at":"2019-12-13T17:20:16Z","pushed_at":"2019-12-16T06:08:43Z","git_url":"git://github.com/schul-cloud/schulcloud-server.git","ssh_url":"git@github.com:schul-cloud/schulcloud-server.git","clone_url":"https://github.com/schul-cloud/schulcloud-server.git","svn_url":"https://github.com/schul-cloud/schulcloud-server","homepage":"","size":19529,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":15,"open_issues":36,"watchers":42,"default_branch":"develop"}},"base":{"label":"schul-cloud:develop","ref":"develop","sha":"6d28561f2046c546d9e91cf4cfbf670731fc706c","user":{"login":"schul-cloud","id":22611463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjExNDYz","avatar_url":"https://avatars2.githubusercontent.com/u/22611463?v=4","gravatar_id":"","url":"https://api.github.com/users/schul-cloud","html_url":"https://github.com/schul-cloud","followers_url":"https://api.github.com/users/schul-cloud/followers","following_url":"https://api.github.com/users/schul-cloud/following{/other_user}","gists_url":"https://api.github.com/users/schul-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/schul-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schul-cloud/subscriptions","organizations_url":"https://api.github.com/users/schul-cloud/orgs","repos_url":"https://api.github.com/users/schul-cloud/repos","events_url":"https://api.github.com/users/schul-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/schul-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":71375009,"node_id":"MDEwOlJlcG9zaXRvcnk3MTM3NTAwOQ==","name":"schulcloud-server","full_name":"schul-cloud/schulcloud-server","private":false,"owner":{"login":"schul-cloud","id":22611463,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjExNDYz","avatar_url":"https://avatars2.githubusercontent.com/u/22611463?v=4","gravatar_id":"","url":"https://api.github.com/users/schul-cloud","html_url":"https://github.com/schul-cloud","followers_url":"https://api.github.com/users/schul-cloud/followers","following_url":"https://api.github.com/users/schul-cloud/following{/other_user}","gists_url":"https://api.github.com/users/schul-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/schul-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schul-cloud/subscriptions","organizations_url":"https://api.github.com/users/schul-cloud/orgs","repos_url":"https://api.github.com/users/schul-cloud/repos","events_url":"https://api.github.com/users/schul-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/schul-cloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/schul-cloud/schulcloud-server","description":"Schul-Cloud Core Server","fork":false,"url":"https://api.github.com/repos/schul-cloud/schulcloud-server","forks_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/forks","keys_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/teams","hooks_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/hooks","issue_events_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/events{/number}","events_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/events","assignees_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/assignees{/user}","branches_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/branches{/branch}","tags_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/tags","blobs_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/statuses/{sha}","languages_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/languages","stargazers_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/stargazers","contributors_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/contributors","subscribers_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/subscribers","subscription_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/subscription","commits_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/contents/{+path}","compare_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/merges","archive_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/downloads","issues_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues{/number}","pulls_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls{/number}","milestones_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/milestones{/number}","notifications_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/labels{/name}","releases_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/releases{/id}","deployments_url":"https://api.github.com/repos/schul-cloud/schulcloud-server/deployments","created_at":"2016-10-19T16:04:27Z","updated_at":"2019-12-13T17:20:16Z","pushed_at":"2019-12-16T06:08:43Z","git_url":"git://github.com/schul-cloud/schulcloud-server.git","ssh_url":"git@github.com:schul-cloud/schulcloud-server.git","clone_url":"https://github.com/schul-cloud/schulcloud-server.git","svn_url":"https://github.com/schul-cloud/schulcloud-server","homepage":"","size":19529,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":15,"open_issues":36,"watchers":42,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894"},"html":{"href":"https://github.com/schul-cloud/schulcloud-server/pull/894"},"issue":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/894"},"comments":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/issues/894/comments"},"review_comments":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894/comments"},"review_comment":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/pulls/894/commits"},"statuses":{"href":"https://api.github.com/repos/schul-cloud/schulcloud-server/statuses/f823644e413452a5d9245b8baa9ce952e0b75040"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 71375009,
"name": "schul-cloud/schulcloud-server",
"url": "https://api.github.com/repos/schul-cloud/schulcloud-server"
}
|
{
"id": 4550014,
"login": "tofixx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4550014?",
"url": "https://api.github.com/users/tofixx"
}
|
{
"id": 22611463,
"login": "schul-cloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22611463?",
"url": "https://api.github.com/orgs/schul-cloud"
}
| 2019-12-16T08:37:06 |
11095244013
|
{"actor":{"display_login":"tofixx"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/comments/268175690","pull_request_review_id":217764417,"id":268175690,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODE3NTY5MA==","diff_hunk":"@@ -35,6 +35,13 @@ static LinkedHashMap<String, Object> secret(String secretName, String envVar) {\n ]\n }\n \n+// Vars for Kubernetes\n+env.IDAM_API_BASE_URI = 'https://preprod-idamapi.reform.hmcts.net:3511'","path":"Jenkinsfile_CNP","position":5,"original_position":5,"commit_id":"7ad462710376787b8fba1e48b159eacd6163b1a4","original_commit_id":"7ad462710376787b8fba1e48b159eacd6163b1a4","user":{"login":"linusnorton","id":683300,"node_id":"MDQ6VXNlcjY4MzMwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/683300?v=4","gravatar_id":"","url":"https://api.github.com/users/linusnorton","html_url":"https://github.com/linusnorton","followers_url":"https://api.github.com/users/linusnorton/followers","following_url":"https://api.github.com/users/linusnorton/following{/other_user}","gists_url":"https://api.github.com/users/linusnorton/gists{/gist_id}","starred_url":"https://api.github.com/users/linusnorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linusnorton/subscriptions","organizations_url":"https://api.github.com/users/linusnorton/orgs","repos_url":"https://api.github.com/users/linusnorton/repos","events_url":"https://api.github.com/users/linusnorton/events{/privacy}","received_events_url":"https://api.github.com/users/linusnorton/received_events","type":"User","site_admin":false},"body":"Now that these vars are in here, can we remove them from output.tf?","created_at":"2019-03-22T13:50:00Z","updated_at":"2019-03-22T13:50:00Z","html_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app/pull/18#discussion_r268175690","pull_request_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/comments/268175690"},"html":{"href":"https://github.com/hmcts/rpa-native-pdf-annotator-app/pull/18#discussion_r268175690"},"pull_request":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18","id":262503919,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNTAzOTE5","html_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app/pull/18","diff_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app/pull/18.diff","patch_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app/pull/18.patch","issue_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/18","number":18,"state":"open","locked":false,"title":"Helm chart","user":{"login":"JeroenRijks","id":42030617,"node_id":"MDQ6VXNlcjQyMDMwNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/42030617?v=4","gravatar_id":"","url":"https://api.github.com/users/JeroenRijks","html_url":"https://github.com/JeroenRijks","followers_url":"https://api.github.com/users/JeroenRijks/followers","following_url":"https://api.github.com/users/JeroenRijks/following{/other_user}","gists_url":"https://api.github.com/users/JeroenRijks/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenRijks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenRijks/subscriptions","organizations_url":"https://api.github.com/users/JeroenRijks/orgs","repos_url":"https://api.github.com/users/JeroenRijks/repos","events_url":"https://api.github.com/users/JeroenRijks/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenRijks/received_events","type":"User","site_admin":false},"body":"**Before creating a pull request make sure that:**\r\n\r\n- [ ] commit messages are meaningful and follow good commit message guidelines\r\n- [ ] README and other documentation has been updated / added (if needed)\r\n- [ ] tests have been updated / new tests has been added (if needed)\r\n\r\nPlease remove this line and everything above and fill the following sections:\r\n\r\n\r\n### JIRA link (if applicable) ###\r\n\r\n\r\n\r\n### Change description ###\r\n\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[ ] No\r\n```\r\n","created_at":"2019-03-19T15:18:11Z","updated_at":"2019-03-22T13:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf5585c591597402f4fbcbe95aeee3b756968ba9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1280306102,"node_id":"MDU6TGFiZWwxMjgwMzA2MTAy","url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/labels/ns:em-npa-pr-18","name":"ns:em-npa-pr-18","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18/commits","review_comments_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18/comments","review_comment_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/18/comments","statuses_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/statuses/7ad462710376787b8fba1e48b159eacd6163b1a4","head":{"label":"hmcts:helm-with-secrets","ref":"helm-with-secrets","sha":"7ad462710376787b8fba1e48b159eacd6163b1a4","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":149774203,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk3NzQyMDM=","name":"rpa-native-pdf-annotator-app","full_name":"hmcts/rpa-native-pdf-annotator-app","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app","forks_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/forks","keys_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/teams","hooks_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/hooks","issue_events_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/events","assignees_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/tags","blobs_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/languages","stargazers_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/stargazers","contributors_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/contributors","subscribers_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/subscribers","subscription_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/subscription","commits_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/merges","archive_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/downloads","issues_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/deployments","created_at":"2018-09-21T14:24:22Z","updated_at":"2019-03-20T12:04:47Z","pushed_at":"2019-03-22T13:40:15Z","git_url":"git://github.com/hmcts/rpa-native-pdf-annotator-app.git","ssh_url":"git@github.com:hmcts/rpa-native-pdf-annotator-app.git","clone_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app.git","svn_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app","homepage":null,"size":19909,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"275139c7c43b975dbd0ac22f70fea1d2558f0d3a","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":149774203,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk3NzQyMDM=","name":"rpa-native-pdf-annotator-app","full_name":"hmcts/rpa-native-pdf-annotator-app","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app","forks_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/forks","keys_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/teams","hooks_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/hooks","issue_events_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/events","assignees_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/tags","blobs_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/languages","stargazers_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/stargazers","contributors_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/contributors","subscribers_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/subscribers","subscription_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/subscription","commits_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/merges","archive_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/downloads","issues_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/deployments","created_at":"2018-09-21T14:24:22Z","updated_at":"2019-03-20T12:04:47Z","pushed_at":"2019-03-22T13:40:15Z","git_url":"git://github.com/hmcts/rpa-native-pdf-annotator-app.git","ssh_url":"git@github.com:hmcts/rpa-native-pdf-annotator-app.git","clone_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app.git","svn_url":"https://github.com/hmcts/rpa-native-pdf-annotator-app","homepage":null,"size":19909,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18"},"html":{"href":"https://github.com/hmcts/rpa-native-pdf-annotator-app/pull/18"},"issue":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/18"},"comments":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app/statuses/7ad462710376787b8fba1e48b159eacd6163b1a4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 149774203,
"name": "hmcts/rpa-native-pdf-annotator-app",
"url": "https://api.github.com/repos/hmcts/rpa-native-pdf-annotator-app"
}
|
{
"id": 683300,
"login": "linusnorton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/683300?",
"url": "https://api.github.com/users/linusnorton"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2019-03-22T13:50:00 |
9295513983
|
{"actor":{"display_login":"linusnorton"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/comments/303448877","pull_request_review_id":261837602,"id":303448877,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzQ0ODg3Nw==","diff_hunk":"@@ -43,7 +43,7 @@\n {% endif %}\n \n {% if error %}\n- {% if settings.env != 'prod' %}\n+ {% if (settings.env != 'prod') and (settings.env != 'production') %}","path":"views/errors/error.html","position":5,"original_position":5,"commit_id":"3469c3a5994f66df2d525d2e8487e84351aa4ec9","original_commit_id":"3469c3a5994f66df2d525d2e8487e84351aa4ec9","user":{"login":"qzhou-hmcts","id":42572376,"node_id":"MDQ6VXNlcjQyNTcyMzc2","avatar_url":"https://avatars3.githubusercontent.com/u/42572376?v=4","gravatar_id":"","url":"https://api.github.com/users/qzhou-hmcts","html_url":"https://github.com/qzhou-hmcts","followers_url":"https://api.github.com/users/qzhou-hmcts/followers","following_url":"https://api.github.com/users/qzhou-hmcts/following{/other_user}","gists_url":"https://api.github.com/users/qzhou-hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/qzhou-hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzhou-hmcts/subscriptions","organizations_url":"https://api.github.com/users/qzhou-hmcts/orgs","repos_url":"https://api.github.com/users/qzhou-hmcts/repos","events_url":"https://api.github.com/users/qzhou-hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/qzhou-hmcts/received_events","type":"User","site_admin":false},"body":"😮 ","created_at":"2019-07-15T13:57:35Z","updated_at":"2019-07-15T13:57:35Z","html_url":"https://github.com/hmcts/div-respondent-frontend/pull/343#discussion_r303448877","pull_request_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/comments/303448877"},"html":{"href":"https://github.com/hmcts/div-respondent-frontend/pull/343#discussion_r303448877"},"pull_request":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343","id":297631840,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NjMxODQw","html_url":"https://github.com/hmcts/div-respondent-frontend/pull/343","diff_url":"https://github.com/hmcts/div-respondent-frontend/pull/343.diff","patch_url":"https://github.com/hmcts/div-respondent-frontend/pull/343.patch","issue_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/343","number":343,"state":"open","locked":false,"title":"Fixed Error Message on Production and Fixed Error When ClaimsCostFrom…","user":{"login":"tchow8","id":36265570,"node_id":"MDQ6VXNlcjM2MjY1NTcw","avatar_url":"https://avatars3.githubusercontent.com/u/36265570?v=4","gravatar_id":"","url":"https://api.github.com/users/tchow8","html_url":"https://github.com/tchow8","followers_url":"https://api.github.com/users/tchow8/followers","following_url":"https://api.github.com/users/tchow8/following{/other_user}","gists_url":"https://api.github.com/users/tchow8/gists{/gist_id}","starred_url":"https://api.github.com/users/tchow8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchow8/subscriptions","organizations_url":"https://api.github.com/users/tchow8/orgs","repos_url":"https://api.github.com/users/tchow8/repos","events_url":"https://api.github.com/users/tchow8/events{/privacy}","received_events_url":"https://api.github.com/users/tchow8/received_events","type":"User","site_admin":false},"body":"… is Null\r\n\r\n# Description\r\n\r\n[DIV-5316 Error In Production Bug](https://tools.hmcts.net/jira/browse/DIV-5316)\r\n\r\nThere are two bugs here.\r\n1. When claimCostsFrom is null or missing, Review-Application throws an error trying to parse it when claimsCost is YES. The fix is to default it to an empty array if not defined. This means in content, respondent will be displayed as the default claimFrom party.\r\n2. NODE_ENV on PROD and AAT is actually 'production'. This fix does mean we will no longer see the error message on AAT either (as that environment is meant to be Prod-llke anyway). Errors can still be seen locally.\r\n\r\nFixes # (issue)\r\n\r\n## Type of change\r\n\r\nPlease delete options that are not relevant.\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] This change requires a documentation update\r\n\r\n# How Has This Been Tested?\r\n\r\nPlease describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration\r\n\r\n\r\n**Test Configuration**:\r\n\r\n* Hardware:\r\n* O/S and version:\r\n* JDK:\r\n\r\n# Checklist:\r\n\r\n- [x] My code follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code\r\n- [ ] I have commented my code, particularly in hard-to-understand areas\r\n- [ ] I have made corresponding changes to the documentation\r\n- [ ] My changes generate no new warnings\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] New and existing unit tests pass locally with my changes\r\n- [ ] Any dependent changes have been merged and published in downstream modules\r\n","created_at":"2019-07-15T13:54:17Z","updated_at":"2019-07-15T13:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a890e18000a182b545248bc1b70fd0ded1174f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343/commits","review_comments_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343/comments","review_comment_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/343/comments","statuses_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/statuses/3469c3a5994f66df2d525d2e8487e84351aa4ec9","head":{"label":"hmcts:DIV-5316-ReviewApplication-Bug","ref":"DIV-5316-ReviewApplication-Bug","sha":"3469c3a5994f66df2d525d2e8487e84351aa4ec9","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":132744597,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3NDQ1OTc=","name":"div-respondent-frontend","full_name":"hmcts/div-respondent-frontend","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/div-respondent-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/div-respondent-frontend","forks_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/deployments","created_at":"2018-05-09T11:07:05Z","updated_at":"2019-07-12T10:00:01Z","pushed_at":"2019-07-15T13:56:02Z","git_url":"git://github.com/hmcts/div-respondent-frontend.git","ssh_url":"git@github.com:hmcts/div-respondent-frontend.git","clone_url":"https://github.com/hmcts/div-respondent-frontend.git","svn_url":"https://github.com/hmcts/div-respondent-frontend","homepage":null,"size":1930,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"7797d9f6d92846bff51d260925724ef1f6f88a03","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":132744597,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3NDQ1OTc=","name":"div-respondent-frontend","full_name":"hmcts/div-respondent-frontend","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/div-respondent-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/div-respondent-frontend","forks_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/div-respondent-frontend/deployments","created_at":"2018-05-09T11:07:05Z","updated_at":"2019-07-12T10:00:01Z","pushed_at":"2019-07-15T13:56:02Z","git_url":"git://github.com/hmcts/div-respondent-frontend.git","ssh_url":"git@github.com:hmcts/div-respondent-frontend.git","clone_url":"https://github.com/hmcts/div-respondent-frontend.git","svn_url":"https://github.com/hmcts/div-respondent-frontend","homepage":null,"size":1930,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343"},"html":{"href":"https://github.com/hmcts/div-respondent-frontend/pull/343"},"issue":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/343"},"comments":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/div-respondent-frontend/statuses/3469c3a5994f66df2d525d2e8487e84351aa4ec9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 132744597,
"name": "hmcts/div-respondent-frontend",
"url": "https://api.github.com/repos/hmcts/div-respondent-frontend"
}
|
{
"id": 42572376,
"login": "qzhou-hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42572376?",
"url": "https://api.github.com/users/qzhou-hmcts"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2019-07-15T13:57:35 |
10012798878
|
{"actor":{"display_login":"qzhou-hmcts"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/comments/344790360","pull_request_review_id":315003297,"id":344790360,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDc5MDM2MA==","diff_hunk":"@@ -0,0 +1,68 @@\n+package uk.gov.hmcts.reform.fpl.controllers;\n+\n+import com.fasterxml.jackson.databind.ObjectMapper;\n+import io.swagger.annotations.Api;\n+import org.springframework.beans.factory.annotation.Autowired;\n+import org.springframework.web.bind.annotation.PostMapping;\n+import org.springframework.web.bind.annotation.RequestBody;\n+import org.springframework.web.bind.annotation.RequestMapping;\n+import org.springframework.web.bind.annotation.RestController;\n+import uk.gov.hmcts.reform.ccd.client.model.AboutToStartOrSubmitCallbackResponse;\n+import uk.gov.hmcts.reform.ccd.client.model.CallbackRequest;\n+import uk.gov.hmcts.reform.ccd.client.model.CaseDetails;\n+import uk.gov.hmcts.reform.fpl.model.CaseData;\n+import uk.gov.hmcts.reform.fpl.model.CaseManagementOrder;\n+import uk.gov.hmcts.reform.fpl.model.common.dynamic.DynamicList;\n+import uk.gov.hmcts.reform.fpl.service.DraftCMOService;\n+\n+import java.util.Map;\n+\n+@Api\n+@RestController\n+@RequestMapping(\"/callback/draft-cmo\")\n+public class DraftCMOController {\n+ private final ObjectMapper mapper;\n+ private final DraftCMOService draftCMOService;\n+\n+ @Autowired\n+ public DraftCMOController(ObjectMapper mapper, DraftCMOService draftCMOService) {\n+ this.mapper = mapper;\n+ this.draftCMOService = draftCMOService;\n+ }\n+\n+ @PostMapping(\"/about-to-start\")\n+ public AboutToStartOrSubmitCallbackResponse handleAboutToStart(@RequestBody CallbackRequest callbackrequest) {\n+ CaseDetails caseDetails = callbackrequest.getCaseDetails();\n+ Map<String, Object> caseData = caseDetails.getData();\n+\n+ caseData.put(\"cmoHearingDateList\", draftCMOService.getHearingDatesDynamic(caseDetails));\n+\n+ return AboutToStartOrSubmitCallbackResponse.builder()\n+ .data(caseData)\n+ .build();\n+ }\n+\n+ @PostMapping(\"/about-to-submit\")\n+ public AboutToStartOrSubmitCallbackResponse handleAboutToSubmit(@RequestBody CallbackRequest callbackRequest) {\n+\n+ CaseDetails caseDetails = callbackRequest.getCaseDetails();\n+ CaseData caseData = mapper.convertValue(caseDetails.getData(), CaseData.class);\n+ DynamicList list = mapper.convertValue(caseDetails.getData().get(\"cmoHearingDateList\"), DynamicList.class);\n+\n+ CaseData updatedCaseData = caseData.toBuilder()\n+ .caseManagementOrder(CaseManagementOrder.builder().build())\n+ .build();","path":"service/src/main/java/uk/gov/hmcts/reform/fpl/controllers/DraftCMOController.java","position":54,"original_position":54,"commit_id":"6d4c3152f5522f9d8e06a507e9bc1defb8589651","original_commit_id":"6d4c3152f5522f9d8e06a507e9bc1defb8589651","user":{"login":"amitk2281","id":47570828,"node_id":"MDQ6VXNlcjQ3NTcwODI4","avatar_url":"https://avatars0.githubusercontent.com/u/47570828?v=4","gravatar_id":"","url":"https://api.github.com/users/amitk2281","html_url":"https://github.com/amitk2281","followers_url":"https://api.github.com/users/amitk2281/followers","following_url":"https://api.github.com/users/amitk2281/following{/other_user}","gists_url":"https://api.github.com/users/amitk2281/gists{/gist_id}","starred_url":"https://api.github.com/users/amitk2281/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitk2281/subscriptions","organizations_url":"https://api.github.com/users/amitk2281/orgs","repos_url":"https://api.github.com/users/amitk2281/repos","events_url":"https://api.github.com/users/amitk2281/events{/privacy}","received_events_url":"https://api.github.com/users/amitk2281/received_events","type":"User","site_admin":false},"body":"removed","created_at":"2019-11-11T16:18:15Z","updated_at":"2019-11-11T16:18:15Z","html_url":"https://github.com/hmcts/fpl-ccd-configuration/pull/581#discussion_r344790360","pull_request_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/comments/344790360"},"html":{"href":"https://github.com/hmcts/fpl-ccd-configuration/pull/581#discussion_r344790360"},"pull_request":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581"}},"in_reply_to_id":344750113},"pull_request":{"url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581","id":336335857,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2MzM1ODU3","html_url":"https://github.com/hmcts/fpl-ccd-configuration/pull/581","diff_url":"https://github.com/hmcts/fpl-ccd-configuration/pull/581.diff","patch_url":"https://github.com/hmcts/fpl-ccd-configuration/pull/581.patch","issue_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/581","number":581,"state":"open","locked":false,"title":"Fpla-3 Draft CMO associate hearing date","user":{"login":"amitk2281","id":47570828,"node_id":"MDQ6VXNlcjQ3NTcwODI4","avatar_url":"https://avatars0.githubusercontent.com/u/47570828?v=4","gravatar_id":"","url":"https://api.github.com/users/amitk2281","html_url":"https://github.com/amitk2281","followers_url":"https://api.github.com/users/amitk2281/followers","following_url":"https://api.github.com/users/amitk2281/following{/other_user}","gists_url":"https://api.github.com/users/amitk2281/gists{/gist_id}","starred_url":"https://api.github.com/users/amitk2281/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitk2281/subscriptions","organizations_url":"https://api.github.com/users/amitk2281/orgs","repos_url":"https://api.github.com/users/amitk2281/repos","events_url":"https://api.github.com/users/amitk2281/events{/privacy}","received_events_url":"https://api.github.com/users/amitk2281/received_events","type":"User","site_admin":false},"body":"**Before creating a pull request make sure that:**\r\n\r\n- [ ] commit messages are meaningful and follow good commit message guidelines\r\n- [ ] README and other documentation has been updated / added (if needed)\r\n- [ ] tests have been updated / new tests has been added (if needed)\r\n\r\nPlease remove this line and everything above and fill the following sections:\r\n\r\n\r\n### JIRA link (if applicable) ###\r\n\r\nhttps://tools.hmcts.net/jira/browse/FPLA-3\r\n\r\n### Change description ###\r\n\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[ ] No\r\n```\r\n","created_at":"2019-11-04T15:25:36Z","updated_at":"2019-11-11T16:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27c77ac5a4476e4d3b02b61a65a650fa8d8440f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1658856967,"node_id":"MDU6TGFiZWwxNjU4ODU2OTY3","url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/labels/ns:fpl-case-service-pr-581","name":"ns:fpl-case-service-pr-581","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581/commits","review_comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581/comments","review_comment_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/581/comments","statuses_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/statuses/6d4c3152f5522f9d8e06a507e9bc1defb8589651","head":{"label":"hmcts:FPLA-3-CMO-Hearing-Date","ref":"FPLA-3-CMO-Hearing-Date","sha":"6d4c3152f5522f9d8e06a507e9bc1defb8589651","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":150105196,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMDUxOTY=","name":"fpl-ccd-configuration","full_name":"hmcts/fpl-ccd-configuration","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/fpl-ccd-configuration","description":"Family Public Law's implementation of the CCD template","fork":false,"url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration","forks_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/forks","keys_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/teams","hooks_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/hooks","issue_events_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/events","assignees_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/tags","blobs_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/languages","stargazers_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/stargazers","contributors_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/contributors","subscribers_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/subscribers","subscription_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/subscription","commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/merges","archive_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/downloads","issues_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/deployments","created_at":"2018-09-24T13:15:51Z","updated_at":"2019-11-11T13:14:59Z","pushed_at":"2019-11-11T16:04:34Z","git_url":"git://github.com/hmcts/fpl-ccd-configuration.git","ssh_url":"git@github.com:hmcts/fpl-ccd-configuration.git","clone_url":"https://github.com/hmcts/fpl-ccd-configuration.git","svn_url":"https://github.com/hmcts/fpl-ccd-configuration","homepage":"","size":13510,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"95db57192c8874d3c32423180be34e32d617eca3","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":150105196,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMDUxOTY=","name":"fpl-ccd-configuration","full_name":"hmcts/fpl-ccd-configuration","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/fpl-ccd-configuration","description":"Family Public Law's implementation of the CCD template","fork":false,"url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration","forks_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/forks","keys_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/teams","hooks_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/hooks","issue_events_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/events","assignees_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/tags","blobs_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/languages","stargazers_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/stargazers","contributors_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/contributors","subscribers_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/subscribers","subscription_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/subscription","commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/merges","archive_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/downloads","issues_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/deployments","created_at":"2018-09-24T13:15:51Z","updated_at":"2019-11-11T13:14:59Z","pushed_at":"2019-11-11T16:04:34Z","git_url":"git://github.com/hmcts/fpl-ccd-configuration.git","ssh_url":"git@github.com:hmcts/fpl-ccd-configuration.git","clone_url":"https://github.com/hmcts/fpl-ccd-configuration.git","svn_url":"https://github.com/hmcts/fpl-ccd-configuration","homepage":"","size":13510,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581"},"html":{"href":"https://github.com/hmcts/fpl-ccd-configuration/pull/581"},"issue":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/581"},"comments":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-configuration/statuses/6d4c3152f5522f9d8e06a507e9bc1defb8589651"}},"author_association":"COLLABORATOR"}}
|
{
"id": 150105196,
"name": "hmcts/fpl-ccd-configuration",
"url": "https://api.github.com/repos/hmcts/fpl-ccd-configuration"
}
|
{
"id": 47570828,
"login": "amitk2281",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47570828?",
"url": "https://api.github.com/users/amitk2281"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2019-11-11T16:18:15 |
10835094537
|
{"actor":{"display_login":"amitk2281"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/comments/299859288","pull_request_review_id":257362673,"id":299859288,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTg1OTI4OA==","diff_hunk":"@@ -93,8 +93,9 @@ export class WorkbasketComponent implements OnInit {\n this.caseState = filter.caseState;\n this.page = filter.page;\n this.paginationMetadata = results[1];\n- // Clearing the errors is only on the assumption this is the only place we display errors on case list page\n- this.resultView.result_error ? this.alertService.warning(this.resultView.result_error) : this.alertService.clear();\n+ if (this.resultView.result_error) {","path":"src/app/workbasket/workbasket.component.ts","position":6,"original_position":6,"commit_id":"c6af1afd412b406e2f28cff65947a73be4de90ab","original_commit_id":"c6af1afd412b406e2f28cff65947a73be4de90ab","user":{"login":"smathangi","id":976999,"node_id":"MDQ6VXNlcjk3Njk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/976999?v=4","gravatar_id":"","url":"https://api.github.com/users/smathangi","html_url":"https://github.com/smathangi","followers_url":"https://api.github.com/users/smathangi/followers","following_url":"https://api.github.com/users/smathangi/following{/other_user}","gists_url":"https://api.github.com/users/smathangi/gists{/gist_id}","starred_url":"https://api.github.com/users/smathangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smathangi/subscriptions","organizations_url":"https://api.github.com/users/smathangi/orgs","repos_url":"https://api.github.com/users/smathangi/repos","events_url":"https://api.github.com/users/smathangi/events{/privacy}","received_events_url":"https://api.github.com/users/smathangi/received_events","type":"User","site_admin":false},"body":"as discussed in the slack, it's clearing the banner upon a click on apply button with changed filters.","created_at":"2019-07-03T09:22:19Z","updated_at":"2019-07-03T09:22:19Z","html_url":"https://github.com/hmcts/ccd-case-management-web/pull/732#discussion_r299859288","pull_request_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/comments/299859288"},"html":{"href":"https://github.com/hmcts/ccd-case-management-web/pull/732#discussion_r299859288"},"pull_request":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732"}},"in_reply_to_id":299469229},"pull_request":{"url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732","id":292852054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyODUyMDU0","html_url":"https://github.com/hmcts/ccd-case-management-web/pull/732","diff_url":"https://github.com/hmcts/ccd-case-management-web/pull/732.diff","patch_url":"https://github.com/hmcts/ccd-case-management-web/pull/732.patch","issue_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/732","number":732,"state":"open","locked":false,"title":"RDM-5031 - displaying thrown alert as it is instead of clearing based on search result error.","user":{"login":"smathangi","id":976999,"node_id":"MDQ6VXNlcjk3Njk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/976999?v=4","gravatar_id":"","url":"https://api.github.com/users/smathangi","html_url":"https://github.com/smathangi","followers_url":"https://api.github.com/users/smathangi/followers","following_url":"https://api.github.com/users/smathangi/following{/other_user}","gists_url":"https://api.github.com/users/smathangi/gists{/gist_id}","starred_url":"https://api.github.com/users/smathangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smathangi/subscriptions","organizations_url":"https://api.github.com/users/smathangi/orgs","repos_url":"https://api.github.com/users/smathangi/repos","events_url":"https://api.github.com/users/smathangi/events{/privacy}","received_events_url":"https://api.github.com/users/smathangi/received_events","type":"User","site_admin":false},"body":"### JIRA link (if applicable) ###\r\nhttps://tools.hmcts.net/jira/browse/RDM-5031\r\n\r\n### Change description ###\r\nAs per Andrew, this condition was added during save draft story. But it seems draft flow is working fine without this condition. \r\nhttps://tools.hmcts.net/jira/browse/RDM-2302\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[ ] No\r\n```\r\n","created_at":"2019-06-28T14:25:01Z","updated_at":"2019-07-03T09:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1cedf291f89ec4602ff2983bfdcf07384bdd324","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tzarsmango","id":296772,"node_id":"MDQ6VXNlcjI5Njc3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/296772?v=4","gravatar_id":"","url":"https://api.github.com/users/tzarsmango","html_url":"https://github.com/tzarsmango","followers_url":"https://api.github.com/users/tzarsmango/followers","following_url":"https://api.github.com/users/tzarsmango/following{/other_user}","gists_url":"https://api.github.com/users/tzarsmango/gists{/gist_id}","starred_url":"https://api.github.com/users/tzarsmango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzarsmango/subscriptions","organizations_url":"https://api.github.com/users/tzarsmango/orgs","repos_url":"https://api.github.com/users/tzarsmango/repos","events_url":"https://api.github.com/users/tzarsmango/events{/privacy}","received_events_url":"https://api.github.com/users/tzarsmango/received_events","type":"User","site_admin":false},{"login":"andrewfolga","id":5024942,"node_id":"MDQ6VXNlcjUwMjQ5NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/5024942?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewfolga","html_url":"https://github.com/andrewfolga","followers_url":"https://api.github.com/users/andrewfolga/followers","following_url":"https://api.github.com/users/andrewfolga/following{/other_user}","gists_url":"https://api.github.com/users/andrewfolga/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfolga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfolga/subscriptions","organizations_url":"https://api.github.com/users/andrewfolga/orgs","repos_url":"https://api.github.com/users/andrewfolga/repos","events_url":"https://api.github.com/users/andrewfolga/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfolga/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1427516618,"node_id":"MDU6TGFiZWwxNDI3NTE2NjE4","url":"https://api.github.com/repos/hmcts/ccd-case-management-web/labels/ns:ccd-case-management-web-pr-732","name":"ns:ccd-case-management-web-pr-732","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732/commits","review_comments_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732/comments","review_comment_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/732/comments","statuses_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/statuses/c6af1afd412b406e2f28cff65947a73be4de90ab","head":{"label":"hmcts:RDM-5031","ref":"RDM-5031","sha":"c6af1afd412b406e2f28cff65947a73be4de90ab","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":125355488,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzNTU0ODg=","name":"ccd-case-management-web","full_name":"hmcts/ccd-case-management-web","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/ccd-case-management-web","description":"Caseworker UI for HMCTS Digital Services","fork":false,"url":"https://api.github.com/repos/hmcts/ccd-case-management-web","forks_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/forks","keys_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/teams","hooks_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/hooks","issue_events_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/events","assignees_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/tags","blobs_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/languages","stargazers_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/stargazers","contributors_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/contributors","subscribers_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/subscribers","subscription_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/subscription","commits_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/merges","archive_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/downloads","issues_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/deployments","created_at":"2018-03-15T11:11:23Z","updated_at":"2019-07-02T14:42:03Z","pushed_at":"2019-07-03T01:45:13Z","git_url":"git://github.com/hmcts/ccd-case-management-web.git","ssh_url":"git@github.com:hmcts/ccd-case-management-web.git","clone_url":"https://github.com/hmcts/ccd-case-management-web.git","svn_url":"https://github.com/hmcts/ccd-case-management-web","homepage":"","size":15483,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":51,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":51,"watchers":1,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"299ce223364ff56d78217a9508e040da13c56fd1","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":125355488,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzNTU0ODg=","name":"ccd-case-management-web","full_name":"hmcts/ccd-case-management-web","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/ccd-case-management-web","description":"Caseworker UI for HMCTS Digital Services","fork":false,"url":"https://api.github.com/repos/hmcts/ccd-case-management-web","forks_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/forks","keys_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/teams","hooks_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/hooks","issue_events_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/events","assignees_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/tags","blobs_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/languages","stargazers_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/stargazers","contributors_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/contributors","subscribers_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/subscribers","subscription_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/subscription","commits_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/merges","archive_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/downloads","issues_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/ccd-case-management-web/deployments","created_at":"2018-03-15T11:11:23Z","updated_at":"2019-07-02T14:42:03Z","pushed_at":"2019-07-03T01:45:13Z","git_url":"git://github.com/hmcts/ccd-case-management-web.git","ssh_url":"git@github.com:hmcts/ccd-case-management-web.git","clone_url":"https://github.com/hmcts/ccd-case-management-web.git","svn_url":"https://github.com/hmcts/ccd-case-management-web","homepage":"","size":15483,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":51,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":51,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732"},"html":{"href":"https://github.com/hmcts/ccd-case-management-web/pull/732"},"issue":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/732"},"comments":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/issues/732/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/pulls/732/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/ccd-case-management-web/statuses/c6af1afd412b406e2f28cff65947a73be4de90ab"}},"author_association":"NONE"}}
|
{
"id": 125355488,
"name": "hmcts/ccd-case-management-web",
"url": "https://api.github.com/repos/hmcts/ccd-case-management-web"
}
|
{
"id": 976999,
"login": "smathangi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/976999?",
"url": "https://api.github.com/users/smathangi"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2019-07-03T09:22:19 |
9940525160
|
{"actor":{"display_login":"smathangi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/comments/329939417","pull_request_review_id":295447024,"id":329939417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTkzOTQxNw==","diff_hunk":"@@ -4,6 +4,7 @@ java:\n ingressHost: bulk-scan-payment-processor-{{ .Values.global.environment }}.service.core-compute-{{ .Values.global.environment }}.internal\n environment:\n PAYMENTS_QUEUE_MAX_DELIVERY_COUNT: \"5\"\n+ PAY_HUB_URL: https://ccpay-bulkscanning-api-{{ .Values.global.environment }}.service.core-compute-{{ .Values.global.environment }}.internal","path":"charts/bulk-scan-payment-processor/values.yaml","position":null,"original_position":4,"commit_id":"bb15bd86e1736774f6509bb43336c3f6e6e2e22f","original_commit_id":"354139e318ab71701157f7afb225323b3c253449","user":{"login":"mdayican","id":28691687,"node_id":"MDQ6VXNlcjI4NjkxNjg3","avatar_url":"https://avatars3.githubusercontent.com/u/28691687?v=4","gravatar_id":"","url":"https://api.github.com/users/mdayican","html_url":"https://github.com/mdayican","followers_url":"https://api.github.com/users/mdayican/followers","following_url":"https://api.github.com/users/mdayican/following{/other_user}","gists_url":"https://api.github.com/users/mdayican/gists{/gist_id}","starred_url":"https://api.github.com/users/mdayican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdayican/subscriptions","organizations_url":"https://api.github.com/users/mdayican/orgs","repos_url":"https://api.github.com/users/mdayican/repos","events_url":"https://api.github.com/users/mdayican/events{/privacy}","received_events_url":"https://api.github.com/users/mdayican/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2019-10-01T08:39:39Z","updated_at":"2019-10-01T08:39:39Z","html_url":"https://github.com/hmcts/bulk-scan-payment-processor/pull/29#discussion_r329939417","pull_request_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/comments/329939417"},"html":{"href":"https://github.com/hmcts/bulk-scan-payment-processor/pull/29#discussion_r329939417"},"pull_request":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29"}},"in_reply_to_id":329937422},"pull_request":{"url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29","id":323146676,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMTQ2Njc2","html_url":"https://github.com/hmcts/bulk-scan-payment-processor/pull/29","diff_url":"https://github.com/hmcts/bulk-scan-payment-processor/pull/29.diff","patch_url":"https://github.com/hmcts/bulk-scan-payment-processor/pull/29.patch","issue_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/29","number":29,"state":"open","locked":false,"title":"config changes for pay-hub call","user":{"login":"mdayican","id":28691687,"node_id":"MDQ6VXNlcjI4NjkxNjg3","avatar_url":"https://avatars3.githubusercontent.com/u/28691687?v=4","gravatar_id":"","url":"https://api.github.com/users/mdayican","html_url":"https://github.com/mdayican","followers_url":"https://api.github.com/users/mdayican/followers","following_url":"https://api.github.com/users/mdayican/following{/other_user}","gists_url":"https://api.github.com/users/mdayican/gists{/gist_id}","starred_url":"https://api.github.com/users/mdayican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdayican/subscriptions","organizations_url":"https://api.github.com/users/mdayican/orgs","repos_url":"https://api.github.com/users/mdayican/repos","events_url":"https://api.github.com/users/mdayican/events{/privacy}","received_events_url":"https://api.github.com/users/mdayican/received_events","type":"User","site_admin":false},"body":"\r\n### JIRA link (if applicable) ###\r\n\r\nhttps://tools.hmcts.net/jira/browse/BPS-765\r\n\r\n### Change description ###\r\n\r\nconfig changes to call payhub \r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2019-10-01T08:26:23Z","updated_at":"2019-10-01T08:39:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af4e86d9228081c1b87f5d15ec3c20cbc75cfe82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29/commits","review_comments_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29/comments","review_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/29/comments","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/statuses/bb15bd86e1736774f6509bb43336c3f6e6e2e22f","head":{"label":"hmcts:config_for_payhub","ref":"config_for_payhub","sha":"bb15bd86e1736774f6509bb43336c3f6e6e2e22f","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":208217597,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgyMTc1OTc=","name":"bulk-scan-payment-processor","full_name":"hmcts/bulk-scan-payment-processor","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/bulk-scan-payment-processor","description":"Microservice to manage bulk scan related payments","fork":false,"url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor","forks_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/forks","keys_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/teams","hooks_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/hooks","issue_events_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/events","assignees_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/tags","blobs_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/languages","stargazers_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/stargazers","contributors_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/contributors","subscribers_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/subscribers","subscription_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/subscription","commits_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/merges","archive_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/downloads","issues_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/deployments","created_at":"2019-09-13T07:35:33Z","updated_at":"2019-09-30T14:41:33Z","pushed_at":"2019-10-01T08:36:57Z","git_url":"git://github.com/hmcts/bulk-scan-payment-processor.git","ssh_url":"git@github.com:hmcts/bulk-scan-payment-processor.git","clone_url":"https://github.com/hmcts/bulk-scan-payment-processor.git","svn_url":"https://github.com/hmcts/bulk-scan-payment-processor","homepage":null,"size":6995,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"f8f444d2e2e4b0eb247c2c3c536789926abf17ba","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":208217597,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgyMTc1OTc=","name":"bulk-scan-payment-processor","full_name":"hmcts/bulk-scan-payment-processor","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/bulk-scan-payment-processor","description":"Microservice to manage bulk scan related payments","fork":false,"url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor","forks_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/forks","keys_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/teams","hooks_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/hooks","issue_events_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/events","assignees_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/tags","blobs_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/languages","stargazers_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/stargazers","contributors_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/contributors","subscribers_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/subscribers","subscription_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/subscription","commits_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/merges","archive_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/downloads","issues_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/deployments","created_at":"2019-09-13T07:35:33Z","updated_at":"2019-09-30T14:41:33Z","pushed_at":"2019-10-01T08:36:57Z","git_url":"git://github.com/hmcts/bulk-scan-payment-processor.git","ssh_url":"git@github.com:hmcts/bulk-scan-payment-processor.git","clone_url":"https://github.com/hmcts/bulk-scan-payment-processor.git","svn_url":"https://github.com/hmcts/bulk-scan-payment-processor","homepage":null,"size":6995,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29"},"html":{"href":"https://github.com/hmcts/bulk-scan-payment-processor/pull/29"},"issue":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/29"},"comments":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/bulk-scan-payment-processor/statuses/bb15bd86e1736774f6509bb43336c3f6e6e2e22f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 208217597,
"name": "hmcts/bulk-scan-payment-processor",
"url": "https://api.github.com/repos/hmcts/bulk-scan-payment-processor"
}
|
{
"id": 28691687,
"login": "mdayican",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28691687?",
"url": "https://api.github.com/users/mdayican"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2019-10-01T08:39:39 |
10531494695
|
{"actor":{"display_login":"mdayican"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/comments/290184860","pull_request_review_id":245303197,"id":290184860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDE4NDg2MA==","diff_hunk":"@@ -0,0 +1,9 @@\n+#!/bin/bash\n+set -e\n+\n+RESOURCE_GROUP_NAME=$1\n+STORAGE_ACCOUNT_NAME=$2\n+\n+# Create an azure file share for NeuVector persistent storage\n+CONNECTION_STRING=$(az storage account show-connection-string -n ${STORAGE_ACCOUNT_NAME} -g ${RESOURCE_GROUP_NAME} --query 'connectionString' -o tsv)","path":"scripts/create-azure-file-share.sh","position":8,"original_position":8,"commit_id":"00adca628bc26bb5bff7c697717d1edbc9c6e93a","original_commit_id":"00adca628bc26bb5bff7c697717d1edbc9c6e93a","user":{"login":"timja","id":21194782,"node_id":"MDQ6VXNlcjIxMTk0Nzgy","avatar_url":"https://avatars3.githubusercontent.com/u/21194782?v=4","gravatar_id":"","url":"https://api.github.com/users/timja","html_url":"https://github.com/timja","followers_url":"https://api.github.com/users/timja/followers","following_url":"https://api.github.com/users/timja/following{/other_user}","gists_url":"https://api.github.com/users/timja/gists{/gist_id}","starred_url":"https://api.github.com/users/timja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timja/subscriptions","organizations_url":"https://api.github.com/users/timja/orgs","repos_url":"https://api.github.com/users/timja/repos","events_url":"https://api.github.com/users/timja/events{/privacy}","received_events_url":"https://api.github.com/users/timja/received_events","type":"User","site_admin":false},"body":"does the connection string need to be stored anywhere? like key vault?","created_at":"2019-06-04T08:36:00Z","updated_at":"2019-06-04T08:36:00Z","html_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines/pull/34#discussion_r290184860","pull_request_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/comments/290184860"},"html":{"href":"https://github.com/hmcts/cnp-aks-rbac-pipelines/pull/34#discussion_r290184860"},"pull_request":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34","id":284862664,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0ODYyNjY0","html_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines/pull/34","diff_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines/pull/34.diff","patch_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines/pull/34.patch","issue_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/34","number":34,"state":"open","locked":false,"title":"Azure file share for NeuVector","user":{"login":"timwebster9","id":6548787,"node_id":"MDQ6VXNlcjY1NDg3ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/6548787?v=4","gravatar_id":"","url":"https://api.github.com/users/timwebster9","html_url":"https://github.com/timwebster9","followers_url":"https://api.github.com/users/timwebster9/followers","following_url":"https://api.github.com/users/timwebster9/following{/other_user}","gists_url":"https://api.github.com/users/timwebster9/gists{/gist_id}","starred_url":"https://api.github.com/users/timwebster9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timwebster9/subscriptions","organizations_url":"https://api.github.com/users/timwebster9/orgs","repos_url":"https://api.github.com/users/timwebster9/repos","events_url":"https://api.github.com/users/timwebster9/events{/privacy}","received_events_url":"https://api.github.com/users/timwebster9/received_events","type":"User","site_admin":false},"body":"### JIRA link (if applicable) ###\r\n\r\nhttps://dev.azure.com/hmcts/Platform%20Engineering/_workitems/edit/164\r\n\r\n### Change description ###\r\n\r\nAdd Azure file share for NeuVector persistent storage\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n[AB#164](https://dev.azure.com/hmcts/90472b63-dc8d-4ae6-8819-a32bd211e914/_workitems/edit/164)","created_at":"2019-06-04T08:18:05Z","updated_at":"2019-06-04T08:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce4b7d7ef371f16654b6954e75cabd1a64d1ec88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34/commits","review_comments_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34/comments","review_comment_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/34/comments","statuses_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/statuses/00adca628bc26bb5bff7c697717d1edbc9c6e93a","head":{"label":"hmcts:azure-file-share","ref":"azure-file-share","sha":"00adca628bc26bb5bff7c697717d1edbc9c6e93a","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":170840576,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA4NDA1NzY=","name":"cnp-aks-rbac-pipelines","full_name":"hmcts/cnp-aks-rbac-pipelines","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines","forks_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/forks","keys_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/teams","hooks_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/events","assignees_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/tags","blobs_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/languages","stargazers_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/subscription","commits_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/merges","archive_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/downloads","issues_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/deployments","created_at":"2019-02-15T09:46:26Z","updated_at":"2019-06-04T08:21:44Z","pushed_at":"2019-06-04T08:22:31Z","git_url":"git://github.com/hmcts/cnp-aks-rbac-pipelines.git","ssh_url":"git@github.com:hmcts/cnp-aks-rbac-pipelines.git","clone_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines.git","svn_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines","homepage":null,"size":273,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"00564f03e11ad15f119bfc77ab15dc553f90fc32","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":170840576,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA4NDA1NzY=","name":"cnp-aks-rbac-pipelines","full_name":"hmcts/cnp-aks-rbac-pipelines","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines","forks_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/forks","keys_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/teams","hooks_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/events","assignees_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/tags","blobs_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/languages","stargazers_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/subscription","commits_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/merges","archive_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/downloads","issues_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/deployments","created_at":"2019-02-15T09:46:26Z","updated_at":"2019-06-04T08:21:44Z","pushed_at":"2019-06-04T08:22:31Z","git_url":"git://github.com/hmcts/cnp-aks-rbac-pipelines.git","ssh_url":"git@github.com:hmcts/cnp-aks-rbac-pipelines.git","clone_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines.git","svn_url":"https://github.com/hmcts/cnp-aks-rbac-pipelines","homepage":null,"size":273,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34"},"html":{"href":"https://github.com/hmcts/cnp-aks-rbac-pipelines/pull/34"},"issue":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/34"},"comments":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines/statuses/00adca628bc26bb5bff7c697717d1edbc9c6e93a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 170840576,
"name": "hmcts/cnp-aks-rbac-pipelines",
"url": "https://api.github.com/repos/hmcts/cnp-aks-rbac-pipelines"
}
|
{
"id": 21194782,
"login": "timja",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21194782?",
"url": "https://api.github.com/users/timja"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2019-06-04T08:36:00 |
9753203272
|
{"actor":{"display_login":"timja"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/comments/301110586","pull_request_review_id":258923916,"id":301110586,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTExMDU4Ng==","diff_hunk":"@@ -0,0 +1,229 @@\n+package uk.gov.hmcts.reform.migration.service;\n+\n+import com.google.common.collect.ImmutableMap;\n+import org.junit.jupiter.api.Test;\n+import uk.gov.hmcts.reform.ccd.client.model.CaseDetails;\n+import uk.gov.hmcts.reform.domain.Applicant;\n+import uk.gov.hmcts.reform.domain.OldApplicant;\n+import uk.gov.hmcts.reform.domain.common.Address;\n+import uk.gov.hmcts.reform.domain.common.EmailAddress;\n+import uk.gov.hmcts.reform.domain.common.MobileNumber;\n+import uk.gov.hmcts.reform.domain.common.ApplicantParty;\n+import uk.gov.hmcts.reform.domain.common.TelephoneNumber;\n+\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+import java.util.UUID;\n+\n+import static org.assertj.core.api.Assertions.assertThat;\n+\n+class ApplicantDataMigrationServiceTest {\n+ private final String APPLICANT = \"Applicant name\";\n+ private final String EMAIL = \"email@email.com\";\n+ private final String MOBILE = \"07778987656\";\n+ private final String COUNTY = \"County\";\n+ private final String COUNTRY = \"Country\";\n+ private final String POSTCODE = \"BT17NT\";\n+ private final String POSTTOWN = \"Ballymena\";\n+ private final String ADDRESSLINE1 =\"ADDRESSLINE1\";\n+ private final String ADDRESSLINE2 = \"ADDRESSLINE2\";\n+ private final String ADDRESSLINE3 = \"ADDRESSLINE3\";\n+ private final String JOBTITLE = \"JobTitle\";\n+ private final String TELEPHONE = \"02825674837\";\n+ private final String PERSONTOCONTACT = \"Person to contact\";\n+ private final String PARTYTYPE = \"ApplicantParty type\";\n+ private final String LEADAPPLICANTINDICATOR = \"Yes\";\n+ private final String PARTYID = UUID.randomUUID().toString();\n+ private final String PBANUMBER= \"PBA123456\";\n+\n+ private final ApplicantDataMigrationService service = new ApplicantDataMigrationService();\n+\n+ @Test\n+ void whenOldStructureDoesNotExistAcceptsShouldReturnFalse() {\n+ CaseDetails caseDetails = CaseDetails.builder()\n+ .id(1111L)\n+ .data(ImmutableMap.of(\"data\", \"someData\"))\n+ .build();\n+\n+ assertThat(service.accepts().test(caseDetails)).isEqualTo(false);\n+ }\n+ @Test\n+ void whenDataIsNullAcceptsShouldReturnFalse() {\n+ CaseDetails caseDetails = CaseDetails.builder()\n+ .id(1111L)\n+ .data(null)\n+ .build();\n+\n+ assertThat(service.accepts().test(caseDetails)).isEqualTo(false);\n+ }\n+\n+ @Test\n+ void whenOldApplicantStructureIsMigratedShouldReturnNewAplicantStructure() {\n+ Map<String, Object> data = new HashMap<>();\n+\n+ OldApplicant applicant = getOldApplicant();\n+\n+ Applicant newApplicant = newApplicantBuilder();","path":"src/test/java/uk/gov/hmcts/reform/migration/service/ApplicantDataMigrationServiceTest.java","position":67,"original_position":67,"commit_id":"07d93413dab13c63cf743e0981fad1d5d8c0abb3","original_commit_id":"07d93413dab13c63cf743e0981fad1d5d8c0abb3","user":{"login":"rebeccabrennan","id":42037338,"node_id":"MDQ6VXNlcjQyMDM3MzM4","avatar_url":"https://avatars0.githubusercontent.com/u/42037338?v=4","gravatar_id":"","url":"https://api.github.com/users/rebeccabrennan","html_url":"https://github.com/rebeccabrennan","followers_url":"https://api.github.com/users/rebeccabrennan/followers","following_url":"https://api.github.com/users/rebeccabrennan/following{/other_user}","gists_url":"https://api.github.com/users/rebeccabrennan/gists{/gist_id}","starred_url":"https://api.github.com/users/rebeccabrennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebeccabrennan/subscriptions","organizations_url":"https://api.github.com/users/rebeccabrennan/orgs","repos_url":"https://api.github.com/users/rebeccabrennan/repos","events_url":"https://api.github.com/users/rebeccabrennan/events{/privacy}","received_events_url":"https://api.github.com/users/rebeccabrennan/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2019-07-08T14:03:39Z","updated_at":"2019-07-08T14:03:39Z","html_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool/pull/5#discussion_r301110586","pull_request_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/comments/301110586"},"html":{"href":"https://github.com/hmcts/fpl-ccd-data-migration-tool/pull/5#discussion_r301110586"},"pull_request":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5"}},"in_reply_to_id":300719560},"pull_request":{"url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5","id":290625414,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNjI1NDE0","html_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool/pull/5","diff_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool/pull/5.diff","patch_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool/pull/5.patch","issue_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/5","number":5,"state":"open","locked":false,"title":"Migrate applicant","user":{"login":"rebeccabrennan","id":42037338,"node_id":"MDQ6VXNlcjQyMDM3MzM4","avatar_url":"https://avatars0.githubusercontent.com/u/42037338?v=4","gravatar_id":"","url":"https://api.github.com/users/rebeccabrennan","html_url":"https://github.com/rebeccabrennan","followers_url":"https://api.github.com/users/rebeccabrennan/followers","following_url":"https://api.github.com/users/rebeccabrennan/following{/other_user}","gists_url":"https://api.github.com/users/rebeccabrennan/gists{/gist_id}","starred_url":"https://api.github.com/users/rebeccabrennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebeccabrennan/subscriptions","organizations_url":"https://api.github.com/users/rebeccabrennan/orgs","repos_url":"https://api.github.com/users/rebeccabrennan/repos","events_url":"https://api.github.com/users/rebeccabrennan/events{/privacy}","received_events_url":"https://api.github.com/users/rebeccabrennan/received_events","type":"User","site_admin":false},"body":"### JIRA link (if applicable) ###\r\nhttps://tools.hmcts.net/jira/browse/FPLA-382\r\n\r\n\r\n### Change description ###\r\nMigrating old applicant to new applicant.\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x ] No\r\n```\r\n","created_at":"2019-06-21T14:15:50Z","updated_at":"2019-07-08T14:03:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89aedb9365dbc2cf590a91466f52f5f87b46a398","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Jamesnelson117","id":4429628,"node_id":"MDQ6VXNlcjQ0Mjk2Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4429628?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamesnelson117","html_url":"https://github.com/Jamesnelson117","followers_url":"https://api.github.com/users/Jamesnelson117/followers","following_url":"https://api.github.com/users/Jamesnelson117/following{/other_user}","gists_url":"https://api.github.com/users/Jamesnelson117/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamesnelson117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamesnelson117/subscriptions","organizations_url":"https://api.github.com/users/Jamesnelson117/orgs","repos_url":"https://api.github.com/users/Jamesnelson117/repos","events_url":"https://api.github.com/users/Jamesnelson117/events{/privacy}","received_events_url":"https://api.github.com/users/Jamesnelson117/received_events","type":"User","site_admin":false},{"login":"swalker125","id":29975020,"node_id":"MDQ6VXNlcjI5OTc1MDIw","avatar_url":"https://avatars2.githubusercontent.com/u/29975020?v=4","gravatar_id":"","url":"https://api.github.com/users/swalker125","html_url":"https://github.com/swalker125","followers_url":"https://api.github.com/users/swalker125/followers","following_url":"https://api.github.com/users/swalker125/following{/other_user}","gists_url":"https://api.github.com/users/swalker125/gists{/gist_id}","starred_url":"https://api.github.com/users/swalker125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalker125/subscriptions","organizations_url":"https://api.github.com/users/swalker125/orgs","repos_url":"https://api.github.com/users/swalker125/repos","events_url":"https://api.github.com/users/swalker125/events{/privacy}","received_events_url":"https://api.github.com/users/swalker125/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5/commits","review_comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5/comments","review_comment_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/5/comments","statuses_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/statuses/07d93413dab13c63cf743e0981fad1d5d8c0abb3","head":{"label":"hmcts:migrate-applicant","ref":"migrate-applicant","sha":"07d93413dab13c63cf743e0981fad1d5d8c0abb3","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":192362452,"node_id":"MDEwOlJlcG9zaXRvcnkxOTIzNjI0NTI=","name":"fpl-ccd-data-migration-tool","full_name":"hmcts/fpl-ccd-data-migration-tool","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool","description":"CCD case migration tool used by FPL based on https://github.com/hmcts/ccd-case-migration-template","fork":false,"url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool","forks_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/forks","keys_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/teams","hooks_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/hooks","issue_events_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/events","assignees_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/tags","blobs_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/languages","stargazers_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/stargazers","contributors_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/contributors","subscribers_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/subscribers","subscription_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/subscription","commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/merges","archive_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/downloads","issues_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/deployments","created_at":"2019-06-17T14:27:20Z","updated_at":"2019-07-02T10:39:23Z","pushed_at":"2019-07-05T14:32:35Z","git_url":"git://github.com/hmcts/fpl-ccd-data-migration-tool.git","ssh_url":"git@github.com:hmcts/fpl-ccd-data-migration-tool.git","clone_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool.git","svn_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool","homepage":"","size":191,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"c3f93649f533289dfe82ca025bc72bf21ac7ca4f","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":192362452,"node_id":"MDEwOlJlcG9zaXRvcnkxOTIzNjI0NTI=","name":"fpl-ccd-data-migration-tool","full_name":"hmcts/fpl-ccd-data-migration-tool","private":false,"owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool","description":"CCD case migration tool used by FPL based on https://github.com/hmcts/ccd-case-migration-template","fork":false,"url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool","forks_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/forks","keys_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/teams","hooks_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/hooks","issue_events_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/events","assignees_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/tags","blobs_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/languages","stargazers_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/stargazers","contributors_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/contributors","subscribers_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/subscribers","subscription_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/subscription","commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/merges","archive_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/downloads","issues_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/deployments","created_at":"2019-06-17T14:27:20Z","updated_at":"2019-07-02T10:39:23Z","pushed_at":"2019-07-05T14:32:35Z","git_url":"git://github.com/hmcts/fpl-ccd-data-migration-tool.git","ssh_url":"git@github.com:hmcts/fpl-ccd-data-migration-tool.git","clone_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool.git","svn_url":"https://github.com/hmcts/fpl-ccd-data-migration-tool","homepage":"","size":191,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5"},"html":{"href":"https://github.com/hmcts/fpl-ccd-data-migration-tool/pull/5"},"issue":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/5"},"comments":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool/statuses/07d93413dab13c63cf743e0981fad1d5d8c0abb3"}},"author_association":"NONE"}}
|
{
"id": 192362452,
"name": "hmcts/fpl-ccd-data-migration-tool",
"url": "https://api.github.com/repos/hmcts/fpl-ccd-data-migration-tool"
}
|
{
"id": 42037338,
"login": "rebeccabrennan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42037338?",
"url": "https://api.github.com/users/rebeccabrennan"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2019-07-08T14:03:39 |
9967660048
|
{"actor":{"display_login":"rebeccabrennan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/327246237","pull_request_review_id":291947436,"id":327246237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzI0NjIzNw==","diff_hunk":"@@ -76,6 +76,17 @@\n \"https://www.googleapis.com/auth/userinfo.email\",\n \"https://www.googleapis.com/auth/cloud-billing\");\n \n+ // All options are defined in this document:\n+ // https://docs.google.com/document/d/1YS95Q7ViRztaCSfPK-NS6tzFPrVpp5KUo0FaWGx7VHw/edit#\n+ public static final List<String> FIRECLOUD_GET_WORKSPACE_REQUIRED_FIELDS =\n+ Arrays.asList(","path":"api/src/main/java/org/pmiops/workbench/firecloud/FireCloudServiceImpl.java","position":7,"original_position":7,"commit_id":"3463e6b081c6c204756b1dbb95539281df69af6a","original_commit_id":"3463e6b081c6c204756b1dbb95539281df69af6a","user":{"login":"ericsong","id":2770197,"node_id":"MDQ6VXNlcjI3NzAxOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2770197?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsong","html_url":"https://github.com/ericsong","followers_url":"https://api.github.com/users/ericsong/followers","following_url":"https://api.github.com/users/ericsong/following{/other_user}","gists_url":"https://api.github.com/users/ericsong/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsong/subscriptions","organizations_url":"https://api.github.com/users/ericsong/orgs","repos_url":"https://api.github.com/users/ericsong/repos","events_url":"https://api.github.com/users/ericsong/events{/privacy}","received_events_url":"https://api.github.com/users/ericsong/received_events","type":"User","site_admin":false},"body":"nit: We can use an immutable class like `ImmutableList` from Guava or `List.of()` from Java 9. Not sure what Java version we're using so may have to go with the former.","created_at":"2019-09-23T17:47:47Z","updated_at":"2019-09-23T17:47:48Z","html_url":"https://github.com/all-of-us/workbench/pull/2599#discussion_r327246237","pull_request_url":"https://api.github.com/repos/all-of-us/workbench/pulls/2599","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/327246237"},"html":{"href":"https://github.com/all-of-us/workbench/pull/2599#discussion_r327246237"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/2599"}}},"pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/2599","id":320363281,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwMzYzMjgx","html_url":"https://github.com/all-of-us/workbench/pull/2599","diff_url":"https://github.com/all-of-us/workbench/pull/2599.diff","patch_url":"https://github.com/all-of-us/workbench/pull/2599.patch","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/2599","number":2599,"state":"open","locked":false,"title":"[RW-3491][Risk=low] Parameterize get workspace","user":{"login":"blrubenstein","id":15351021,"node_id":"MDQ6VXNlcjE1MzUxMDIx","avatar_url":"https://avatars0.githubusercontent.com/u/15351021?v=4","gravatar_id":"","url":"https://api.github.com/users/blrubenstein","html_url":"https://github.com/blrubenstein","followers_url":"https://api.github.com/users/blrubenstein/followers","following_url":"https://api.github.com/users/blrubenstein/following{/other_user}","gists_url":"https://api.github.com/users/blrubenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/blrubenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrubenstein/subscriptions","organizations_url":"https://api.github.com/users/blrubenstein/orgs","repos_url":"https://api.github.com/users/blrubenstein/repos","events_url":"https://api.github.com/users/blrubenstein/events{/privacy}","received_events_url":"https://api.github.com/users/blrubenstein/received_events","type":"User","site_admin":false},"body":"This change specifies specific parameters to fetch when we call `getWorkspace` from FireCloud. This is intended to be a performance upgrade from what happens right now. From analysis of the code base, these are the only fields we need, and they are used basically everywhere.","created_at":"2019-09-23T15:49:50Z","updated_at":"2019-09-23T17:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddcc0b3356682ff34a2f92944c8ebb9b85dda456","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/workbench/pulls/2599/commits","review_comments_url":"https://api.github.com/repos/all-of-us/workbench/pulls/2599/comments","review_comment_url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/2599/comments","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/3463e6b081c6c204756b1dbb95539281df69af6a","head":{"label":"all-of-us:srubenst/get-workspace-parameterization","ref":"srubenst/get-workspace-parameterization","sha":"3463e6b081c6c204756b1dbb95539281df69af6a","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0NzE4Ng==","name":"workbench","full_name":"all-of-us/workbench","private":false,"owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/all-of-us/workbench","description":"All of Us Researcher Workbench","fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2019-09-20T21:04:42Z","pushed_at":"2019-09-23T17:30:47Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":"","size":310539,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":4,"open_issues":17,"watchers":15,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"3c31ab69392b846b05e873b90a59732aa6b7bf18","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0NzE4Ng==","name":"workbench","full_name":"all-of-us/workbench","private":false,"owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/all-of-us/workbench","description":"All of Us Researcher Workbench","fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2019-09-20T21:04:42Z","pushed_at":"2019-09-23T17:30:47Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":"","size":310539,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":4,"open_issues":17,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/2599"},"html":{"href":"https://github.com/all-of-us/workbench/pull/2599"},"issue":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/2599"},"comments":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/2599/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/2599/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/2599/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/workbench/statuses/3463e6b081c6c204756b1dbb95539281df69af6a"}},"author_association":"COLLABORATOR"}}
|
{
"id": 95247186,
"name": "all-of-us/workbench",
"url": "https://api.github.com/repos/all-of-us/workbench"
}
|
{
"id": 2770197,
"login": "ericsong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2770197?",
"url": "https://api.github.com/users/ericsong"
}
|
{
"id": 22846942,
"login": "all-of-us",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22846942?",
"url": "https://api.github.com/orgs/all-of-us"
}
| 2019-09-23T17:47:47 |
10476088203
|
{"actor":{"display_login":"ericsong"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/312016148","pull_request_review_id":272546398,"id":312016148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjAxNjE0OA==","diff_hunk":"@@ -650,3 +761,43 @@ func osdOnSDNFlag(hostnetwork bool, v cephver.CephVersion) []string {\n \n \treturn args\n }\n+\n+func makeStorageClassDeviceSetPVC(storageClassDeviceSetName, pvcStorageClassDeviceSetPVCId string, pvcIndex, setIndex int, pvcTemplate v1.PersistentVolumeClaim) (pvcs *v1.PersistentVolumeClaim) {\n+\tpvcLabels := makeStorageClassDeviceSetPVCLabel(storageClassDeviceSetName, pvcStorageClassDeviceSetPVCId, pvcIndex, setIndex)\n+\n+\t// pvc naming format <storageClassDeviceSetName>-<SetNumber>-<PVCIndex>\n+\tpvcGenerateName := pvcStorageClassDeviceSetPVCId + \"-\"\n+\n+\t// Add pvcTemplate name to pvc name. i.e <storageClassDeviceSetName>-<SetNumber>-<PVCIndex>-<pvcTemplateName>\n+\tif len(pvcTemplate.GetName()) != 0 {\n+\t\tpvcGenerateName = pvcGenerateName + pvcTemplate.GetName() + \"-\"\n+\t}\n+\n+\t// Add user provided labels to pvcTemplates\n+\tfor k, v := range pvcTemplate.GetLabels() {\n+\t\tpvcLabels[k] = v\n+\t}\n+\n+\treturn &v1.PersistentVolumeClaim{\n+\t\tObjectMeta: metav1.ObjectMeta{\n+\t\t\tGenerateName: pvcGenerateName,\n+\t\t\tLabels: pvcLabels,\n+\t\t\tAnnotations: pvcTemplate.Annotations,\n+\t\t},\n+\t\tSpec: pvcTemplate.Spec,\n+\t}\n+}\n+\n+func makeStorageClassDeviceSetPVCID(storageClassDeviceSetName string, setIndex, pvcIndex int) (pvcId, pvcLabelSelector string) {\n+\tpvcStorageClassDeviceSetPVCId := fmt.Sprintf(\"%s-%v-%v\", storageClassDeviceSetName, setIndex, pvcIndex)\n+\treturn pvcStorageClassDeviceSetPVCId, fmt.Sprintf(\"ceph.rook.io/StorageClassDeviceSetPVCId=%s\", pvcStorageClassDeviceSetPVCId)","path":"pkg/operator/ceph/cluster/osd/spec.go","position":432,"original_position":432,"commit_id":"76e272c74cf1889cdfe3cdbef04d69bb18b74239","original_commit_id":"76e272c74cf1889cdfe3cdbef04d69bb18b74239","user":{"login":"rohan47","id":11498120,"node_id":"MDQ6VXNlcjExNDk4MTIw","avatar_url":"https://avatars0.githubusercontent.com/u/11498120?v=4","gravatar_id":"","url":"https://api.github.com/users/rohan47","html_url":"https://github.com/rohan47","followers_url":"https://api.github.com/users/rohan47/followers","following_url":"https://api.github.com/users/rohan47/following{/other_user}","gists_url":"https://api.github.com/users/rohan47/gists{/gist_id}","starred_url":"https://api.github.com/users/rohan47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohan47/subscriptions","organizations_url":"https://api.github.com/users/rohan47/orgs","repos_url":"https://api.github.com/users/rohan47/repos","events_url":"https://api.github.com/users/rohan47/events{/privacy}","received_events_url":"https://api.github.com/users/rohan47/received_events","type":"User","site_admin":false},"body":"cc @ashishranjan738","created_at":"2019-08-08T12:49:06Z","updated_at":"2019-08-08T12:49:07Z","html_url":"https://github.com/rook/rook/pull/3451#discussion_r312016148","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/3451","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/312016148"},"html":{"href":"https://github.com/rook/rook/pull/3451#discussion_r312016148"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/3451"}},"in_reply_to_id":311854223},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/3451","id":297540674,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NTQwNjc0","html_url":"https://github.com/rook/rook/pull/3451","diff_url":"https://github.com/rook/rook/pull/3451.diff","patch_url":"https://github.com/rook/rook/pull/3451.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/3451","number":3451,"state":"open","locked":false,"title":"[WIP] [Prototype] OSD: Support for arbitrary PersistentVolumes as backing storage","user":{"login":"rohan47","id":11498120,"node_id":"MDQ6VXNlcjExNDk4MTIw","avatar_url":"https://avatars0.githubusercontent.com/u/11498120?v=4","gravatar_id":"","url":"https://api.github.com/users/rohan47","html_url":"https://github.com/rohan47","followers_url":"https://api.github.com/users/rohan47/followers","following_url":"https://api.github.com/users/rohan47/following{/other_user}","gists_url":"https://api.github.com/users/rohan47/gists{/gist_id}","starred_url":"https://api.github.com/users/rohan47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohan47/subscriptions","organizations_url":"https://api.github.com/users/rohan47/orgs","repos_url":"https://api.github.com/users/rohan47/repos","events_url":"https://api.github.com/users/rohan47/events{/privacy}","received_events_url":"https://api.github.com/users/rohan47/received_events","type":"User","site_admin":false},"body":"Signed-off-by: rohan47 <rohgupta@redhat.com>\r\n\r\n<!-- Please take a look at our [Contributing](https://rook.io/docs/rook/master/development-flow.html)\r\ndocumentation before submitting a Pull Request!\r\nThank you for contributing to Rook! -->\r\n\r\n**Description of your changes:**\r\nUpdated code to use PVCs to back OSDs\r\n\r\n**Following are the steps that I used to create Block PV and utilize them**\r\nEnvironment: \r\n1 Master 3 Workers with 2 disks each\r\nhttps://github.com/noahdesu/kubensis\r\n\r\n\r\n\r\nSteps:\r\n1. Followed https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/master/docs/getting-started.md to create PVs\r\n2. Created PVC to consume PV\r\ne.g.;\r\n```\r\nkind: PersistentVolumeClaim\r\napiVersion: v1\r\nmetadata:\r\n name: example-pvc\r\n namespace: rook-ceph\r\nspec:\r\n accessModes:\r\n - ReadWriteOnce\r\n volumeMode: Block\r\n resources:\r\n requests:\r\n storage: 5Gi\r\n storageClassName: fast-disks\r\n```\r\n3. Deploy cluster.yaml as per this PR\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nResolves #919 \r\n\r\n**Checklist:**\r\n\r\n- [ ] Reviewed the developer guide on [Submitting a Pull Request](https://rook.io/docs/rook/v1.0/development-flow.html#submitting-a-pull-request)\r\n- [ ] Documentation has been updated, if necessary.\r\n- [ ] Unit tests have been added, if necessary.\r\n- [ ] Integration tests have been added, if necessary.\r\n- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [ ] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [ ] Comments have been added or updated based on the standards set in [CONTRIBUTING.md](../CONTRIBUTING.md#comments)\r\n- [ ] Add the flag for skipping the CI if this PR does not require a build. See [here](/INSTALL.md#skip-ci) for more details.\r\n","created_at":"2019-07-15T09:36:40Z","updated_at":"2019-08-08T12:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"747440e44c79c5585825e607074420d179d0559a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jarrpa","id":1234462,"node_id":"MDQ6VXNlcjEyMzQ0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1234462?v=4","gravatar_id":"","url":"https://api.github.com/users/jarrpa","html_url":"https://github.com/jarrpa","followers_url":"https://api.github.com/users/jarrpa/followers","following_url":"https://api.github.com/users/jarrpa/following{/other_user}","gists_url":"https://api.github.com/users/jarrpa/gists{/gist_id}","starred_url":"https://api.github.com/users/jarrpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarrpa/subscriptions","organizations_url":"https://api.github.com/users/jarrpa/orgs","repos_url":"https://api.github.com/users/jarrpa/repos","events_url":"https://api.github.com/users/jarrpa/events{/privacy}","received_events_url":"https://api.github.com/users/jarrpa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/3451/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/3451/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/3451/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/76e272c74cf1889cdfe3cdbef04d69bb18b74239","head":{"label":"rohan47:pvc_for_osd","ref":"pvc_for_osd","sha":"76e272c74cf1889cdfe3cdbef04d69bb18b74239","user":{"login":"rohan47","id":11498120,"node_id":"MDQ6VXNlcjExNDk4MTIw","avatar_url":"https://avatars0.githubusercontent.com/u/11498120?v=4","gravatar_id":"","url":"https://api.github.com/users/rohan47","html_url":"https://github.com/rohan47","followers_url":"https://api.github.com/users/rohan47/followers","following_url":"https://api.github.com/users/rohan47/following{/other_user}","gists_url":"https://api.github.com/users/rohan47/gists{/gist_id}","starred_url":"https://api.github.com/users/rohan47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohan47/subscriptions","organizations_url":"https://api.github.com/users/rohan47/orgs","repos_url":"https://api.github.com/users/rohan47/repos","events_url":"https://api.github.com/users/rohan47/events{/privacy}","received_events_url":"https://api.github.com/users/rohan47/received_events","type":"User","site_admin":false},"repo":{"id":127197958,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxOTc5NTg=","name":"rook","full_name":"rohan47/rook","private":false,"owner":{"login":"rohan47","id":11498120,"node_id":"MDQ6VXNlcjExNDk4MTIw","avatar_url":"https://avatars0.githubusercontent.com/u/11498120?v=4","gravatar_id":"","url":"https://api.github.com/users/rohan47","html_url":"https://github.com/rohan47","followers_url":"https://api.github.com/users/rohan47/followers","following_url":"https://api.github.com/users/rohan47/following{/other_user}","gists_url":"https://api.github.com/users/rohan47/gists{/gist_id}","starred_url":"https://api.github.com/users/rohan47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohan47/subscriptions","organizations_url":"https://api.github.com/users/rohan47/orgs","repos_url":"https://api.github.com/users/rohan47/repos","events_url":"https://api.github.com/users/rohan47/events{/privacy}","received_events_url":"https://api.github.com/users/rohan47/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rohan47/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":true,"url":"https://api.github.com/repos/rohan47/rook","forks_url":"https://api.github.com/repos/rohan47/rook/forks","keys_url":"https://api.github.com/repos/rohan47/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohan47/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohan47/rook/teams","hooks_url":"https://api.github.com/repos/rohan47/rook/hooks","issue_events_url":"https://api.github.com/repos/rohan47/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rohan47/rook/events","assignees_url":"https://api.github.com/repos/rohan47/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rohan47/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rohan47/rook/tags","blobs_url":"https://api.github.com/repos/rohan47/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohan47/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohan47/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohan47/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohan47/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rohan47/rook/languages","stargazers_url":"https://api.github.com/repos/rohan47/rook/stargazers","contributors_url":"https://api.github.com/repos/rohan47/rook/contributors","subscribers_url":"https://api.github.com/repos/rohan47/rook/subscribers","subscription_url":"https://api.github.com/repos/rohan47/rook/subscription","commits_url":"https://api.github.com/repos/rohan47/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohan47/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohan47/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohan47/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohan47/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rohan47/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohan47/rook/merges","archive_url":"https://api.github.com/repos/rohan47/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohan47/rook/downloads","issues_url":"https://api.github.com/repos/rohan47/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rohan47/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rohan47/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rohan47/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohan47/rook/labels{/name}","releases_url":"https://api.github.com/repos/rohan47/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rohan47/rook/deployments","created_at":"2018-03-28T21:00:27Z","updated_at":"2019-07-11T10:29:18Z","pushed_at":"2019-08-07T20:37:36Z","git_url":"git://github.com/rohan47/rook.git","ssh_url":"git@github.com:rohan47/rook.git","clone_url":"https://github.com/rohan47/rook.git","svn_url":"https://github.com/rohan47/rook","homepage":"https://rook.io","size":11559,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"0a79c82543d6c31d68dad456cfca791b7d1d5ecb","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","private":false,"owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rook/rook","description":"Storage Orchestration for Kubernetes","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2019-08-08T12:49:03Z","pushed_at":"2019-08-08T11:05:43Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":11801,"stargazers_count":5812,"watchers_count":5812,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":976,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":355,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":976,"open_issues":355,"watchers":5812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/3451"},"html":{"href":"https://github.com/rook/rook/pull/3451"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/3451"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/3451/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/3451/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/3451/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/76e272c74cf1889cdfe3cdbef04d69bb18b74239"}},"author_association":"MEMBER"}}
|
{
"id": 62921553,
"name": "rook/rook",
"url": "https://api.github.com/repos/rook/rook"
}
|
{
"id": 11498120,
"login": "rohan47",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11498120?",
"url": "https://api.github.com/users/rohan47"
}
|
{
"id": 22860722,
"login": "rook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22860722?",
"url": "https://api.github.com/orgs/rook"
}
| 2019-08-08T12:49:06 |
10173296619
|
{"actor":{"display_login":"rohan47"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/comments/258920310","pull_request_review_id":206295620,"id":258920310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODkyMDMxMA==","diff_hunk":"@@ -0,0 +1,236 @@\n+'use strict';\n+\n+const filterSection = document.querySelector(`.main__filter`); // секция, куда нужно вставить сгенерированные фильтры\n+const cardsSection = document.querySelector(`.board__tasks`); // секция для вставки сгенерированных карточек\n+\n+const START_CARDS_COUNT = 7; // изначальное кол-во карточек\n+\n+/**\n+ * Ищем случайное число (от включительно и до включительно)\n+ * @param {number} [min=0] - минимальное кол-во задач\n+ * @param {number} [max=10] - максимальное кол-во задач\n+ * @return {number} - случайное число - (кол-во тасков у любого фультра)\n+ */\n+const getRandomNumber = (min = 0, max = 10) => {\n+ return Math.floor(min + Math.random() * (max + 1 - min));\n+};\n+\n+// Массив с данными фильтров, содержащий следующие данные, для каждого фильтра:\n+// id фильтра (строка), amount - кол-во элементов в фильтре, атрибут checked (по умолчанию false), аттрибут disabled (по умолчанию false)\n+const filters = [\n+ {\n+ id: `All`,\n+ amount: getRandomNumber(),\n+ isChecked: false,\n+ isDisabled: false\n+ },\n+ {\n+ id: `Overdue`,\n+ amount: getRandomNumber(),\n+ isChecked: false,\n+ isDisabled: true\n+ },\n+ {\n+ id: `Today`,\n+ amount: getRandomNumber(),\n+ isChecked: true\n+ },\n+ {\n+ id: `Favorites`,\n+ amount: getRandomNumber()\n+ },\n+ {\n+ id: `Repeating`,\n+ amount: getRandomNumber(),\n+ isDisabled: true\n+ },\n+ {\n+ id: `Tags`,\n+ amount: getRandomNumber(),\n+ isChecked: true\n+ },\n+ {\n+ id: `Archive`,\n+ amount: getRandomNumber()\n+ }\n+];\n+\n+/**\n+ * Отрисовываем отдельный фильтр (разметку отдельного фильтра)\n+ * @param {Array} filterData - массив обьектов, содержащий данные фильтров\n+ * @return {String} - разметку (строку с заполненными данными)\n+ */\n+const renderSingleFilter = (filterData) =>\n+ `\n+ <input\n+ type=\"radio\"\n+ id=\"filter__${filterData.id.toLowerCase()}\"\n+ class=\"filter__input visually-hidden\"\n+ name=\"filter\"\n+ ${filterData.isChecked ? `checked` : ``}\n+ ${filterData.isDisabled ? `disabled` : ``}\n+ >\n+ <label for=\"filter__${filterData.id.toLowerCase()}\" class=\"filter__label\">\n+ ${filterData.id.toLowerCase()}\n+ <span class=\"filter__${filterData.id.toLowerCase()}-count\">${filterData.amount}</span>\n+ </label>\n+ `\n+;\n+\n+/**\n+ * Вставляем разметку фильтров в нужный блок на страницу\n+ * @param {HTMLElement} filterBlock - элемент для вставки массива фильтров\n+ */\n+const insertFiltersBlock = (filterBlock) => {\n+ const renderedFilter = filters.map(renderSingleFilter).join(``); // делаем из массива строку\n+ filterBlock.insertAdjacentHTML(`afterbegin`, renderedFilter);\n+};\n+\n+/**\n+ * Отрисовываем шаблон карточки (разметку отдельной карточки)\n+ * @param {string} [textAreaValue=``] - поле ввода информации о данной карточке\n+ * @param {boolean} [hasDate=false] - имеет ли данная карточка дедлайн\n+ * @param {boolean} [hasRepeat=false] - нужно ли выполнять данную карточку несколько раз\n+ * @return {String} - разметку (строку с заполненными данными)\n+ */\n+const renderSingleCard = (textAreaValue = ``, hasDate = false, hasRepeat = false) => {\n+ return `\n+ <article class=\"card card--edit card--black\">\n+ <form class=\"card__form\" method=\"get\">\n+ <div class=\"card__inner\">\n+ <div class=\"card__control\">\n+ <button type=\"button\" class=\"card__btn card__btn--edit\">\n+ edit\n+ </button>\n+ <button type=\"button\" class=\"card__btn card__btn--archive\">\n+ archive\n+ </button>\n+ <button type=\"button\" class=\"card__btn card__btn--favorites card__btn--disabled\">\n+ favorites\n+ </button>\n+ </div>\n+\n+ <div class=\"card__color-bar\">\n+ <svg width=\"100%\" height=\"10\">\n+ <use xlink:href=\"#wave\"></use>\n+ </svg>\n+ </div>\n+\n+ <div class=\"card__textarea-wrap\">\n+ <label>\n+ <textarea class=\"card__text\" placeholder=\"Start typing your text here...\" name=\"text\">${textAreaValue}</textarea>\n+ </label>\n+ </div>\n+\n+ <div class=\"card__settings\">\n+ <div class=\"card__details\">\n+ <div class=\"card__dates\">\n+ <button class=\"card__date-deadline-toggle\" type=\"button\">\n+ date: <span class=\"card__date-status\">${hasDate ? `yes` : `no`}</span>\n+ </button>\n+\n+ <fieldset class=\"card__date-deadline\" disabled=\"\">\n+ <label class=\"card__input-deadline-wrap\">\n+ <input class=\"card__date\" type=\"text\" placeholder=\"23 September\" name=\"date\">\n+ </label>\n+ <label class=\"card__input-deadline-wrap\">\n+ <input class=\"card__time\" type=\"text\" placeholder=\"11:15 PM\" name=\"time\">\n+ </label>\n+ </fieldset>\n+\n+ <button class=\"card__repeat-toggle\" type=\"button\">\n+ repeat:<span class=\"card__repeat-status\">${hasRepeat ? `yes` : `no`}</span>\n+ </button>\n+\n+ <fieldset class=\"card__repeat-days\" disabled=\"\">\n+ <div class=\"card__repeat-days-inner\">\n+ <input class=\"visually-hidden card__repeat-day-input\" type=\"checkbox\" id=\"repeat-mo-1\" name=\"repeat\" value=\"mo\">\n+ <label class=\"card__repeat-day\" for=\"repeat-mo-1\">mo</label>\n+ <input class=\"visually-hidden card__repeat-day-input\" type=\"checkbox\" id=\"repeat-tu-1\" name=\"repeat\" value=\"tu\" checked=\"\">\n+ <label class=\"card__repeat-day\" for=\"repeat-tu-1\">tu</label>\n+ <input class=\"visually-hidden card__repeat-day-input\" type=\"checkbox\" id=\"repeat-we-1\" name=\"repeat\" value=\"we\">\n+ <label class=\"card__repeat-day\" for=\"repeat-we-1\">we</label>\n+ <input class=\"visually-hidden card__repeat-day-input\" type=\"checkbox\" id=\"repeat-th-1\" name=\"repeat\" value=\"th\">\n+ <label class=\"card__repeat-day\" for=\"repeat-th-1\">th</label>\n+ <input class=\"visually-hidden card__repeat-day-input\" type=\"checkbox\" id=\"repeat-fr-1\" name=\"repeat\" value=\"fr\" checked=\"\">\n+ <label class=\"card__repeat-day\" for=\"repeat-fr-1\">fr</label>\n+ <input class=\"visually-hidden card__repeat-day-input\" type=\"checkbox\" name=\"repeat\" value=\"sa\" id=\"repeat-sa-1\">\n+ <label class=\"card__repeat-day\" for=\"repeat-sa-1\">sa</label>\n+ <input class=\"visually-hidden card__repeat-day-input\" type=\"checkbox\" id=\"repeat-su-1\" name=\"repeat\" value=\"su\" checked=\"\">\n+ <label class=\"card__repeat-day\" for=\"repeat-su-1\">su</label>\n+ </div>\n+ </fieldset>\n+ </div>\n+\n+ <div class=\"card__hashtag\">\n+ <div class=\"card__hashtag-list\"></div>\n+\n+ <label>\n+ <input type=\"text\" class=\"card__hashtag-input\" name=\"hashtag-input\" placeholder=\"Type new hashtag here\">\n+ </label>\n+ </div>\n+ </div>\n+\n+ <label class=\"card__img-wrap card__img-wrap--empty\">\n+ <input type=\"file\" class=\"card__img-input visually-hidden\" name=\"img\">\n+ <img src=\"img/add-photo.svg\" alt=\"task picture\" class=\"card__img\">\n+ </label>\n+\n+ <div class=\"card__colors-inner\">\n+ <h3 class=\"card__colors-title\">Color</h3>\n+ <div class=\"card__colors-wrap\">\n+ <input type=\"radio\" id=\"color-black-1\" class=\"card__color-input card__color-input--black visually-hidden\" name=\"color\" value=\"black\" checked=\"\">\n+ <label for=\"color-black-1\" class=\"card__color card__color--black\">black</label>\n+ <input type=\"radio\" id=\"color-yellow-1\" class=\"card__color-input card__color-input--yellow visually-hidden\" name=\"color\" value=\"yellow\">\n+ <label for=\"color-yellow-1\" class=\"card__color card__color--yellow\">yellow</label>\n+ <input type=\"radio\" id=\"color-blue-1\" class=\"card__color-input card__color-input--blue visually-hidden\" name=\"color\" value=\"blue\">\n+ <label for=\"color-blue-1\" class=\"card__color card__color--blue\">blue</label>\n+ <input type=\"radio\" id=\"color-green-1\" class=\"card__color-input card__color-input--green visually-hidden\" name=\"color\" value=\"green\">\n+ <label for=\"color-green-1\" class=\"card__color card__color--green\">green</label>\n+ <input type=\"radio\" id=\"color-pink-1\" class=\"card__color-input card__color-input--pink visually-hidden\" name=\"color\" value=\"pink\">\n+ <label for=\"color-pink-1\" class=\"card__color card__color--pink\">pink</label>\n+ </div>\n+ </div>\n+ </div>\n+\n+ <div class=\"card__status-btns\">\n+ <button class=\"card__save\" type=\"submit\">save</button>\n+ <button class=\"card__delete\" type=\"button\">delete</button>\n+ </div>\n+ </div>\n+ </form>\n+ </article>\n+ `;\n+};\n+\n+/**\n+ * Вставляем отрисованные карточки в разметку в нужный блок на странице\n+ * @param {HTMLElement} cardsBlock - элемент, в который мы поместим все карточки\n+ * @param {number} cardsAmount - кол-во карточек, которые надо отрисовать\n+ */\n+const insertCardsBlock = (cardsBlock, cardsAmount) => {\n+ let renderedCardsArray = [];\n+ for (let i = 0; i < cardsAmount; i++) {","path":"src/main.js","position":213,"original_position":213,"commit_id":"e449d25db225a961c0fcbd25ddab4a8ca0ed9ddc","original_commit_id":"e449d25db225a961c0fcbd25ddab4a8ca0ed9ddc","user":{"login":"vartemiev","id":14345492,"node_id":"MDQ6VXNlcjE0MzQ1NDky","avatar_url":"https://avatars1.githubusercontent.com/u/14345492?v=4","gravatar_id":"","url":"https://api.github.com/users/vartemiev","html_url":"https://github.com/vartemiev","followers_url":"https://api.github.com/users/vartemiev/followers","following_url":"https://api.github.com/users/vartemiev/following{/other_user}","gists_url":"https://api.github.com/users/vartemiev/gists{/gist_id}","starred_url":"https://api.github.com/users/vartemiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vartemiev/subscriptions","organizations_url":"https://api.github.com/users/vartemiev/orgs","repos_url":"https://api.github.com/users/vartemiev/repos","events_url":"https://api.github.com/users/vartemiev/events{/privacy}","received_events_url":"https://api.github.com/users/vartemiev/received_events","type":"User","site_admin":false},"body":"По доп критерию забреют","created_at":"2019-02-21T13:13:35Z","updated_at":"2019-02-21T13:13:35Z","html_url":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8/pull/1#discussion_r258920310","pull_request_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/comments/258920310"},"html":{"href":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8/pull/1#discussion_r258920310"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1","id":254626949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NjI2OTQ5","html_url":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8/pull/1","diff_url":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8/pull/1.diff","patch_url":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8/pull/1.patch","issue_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/issues/1","number":1,"state":"open","locked":false,"title":"Начинаем програмировать","user":{"login":"Manimall","id":2580719,"node_id":"MDQ6VXNlcjI1ODA3MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2580719?v=4","gravatar_id":"","url":"https://api.github.com/users/Manimall","html_url":"https://github.com/Manimall","followers_url":"https://api.github.com/users/Manimall/followers","following_url":"https://api.github.com/users/Manimall/following{/other_user}","gists_url":"https://api.github.com/users/Manimall/gists{/gist_id}","starred_url":"https://api.github.com/users/Manimall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manimall/subscriptions","organizations_url":"https://api.github.com/users/Manimall/orgs","repos_url":"https://api.github.com/users/Manimall/repos","events_url":"https://api.github.com/users/Manimall/events{/privacy}","received_events_url":"https://api.github.com/users/Manimall/received_events","type":"User","site_admin":false},"body":"пока все не очень)\r\nнужна help\n\n---\n:mortar_board: [Начинаем програмировать](https://up.htmlacademy.ru/ecmascript/8/user/544023/tasks/2)\n\n:boom: https://htmlacademy-ecmascript.github.io/544023-taskmanager-8/1/","created_at":"2019-02-20T12:59:57Z","updated_at":"2019-02-21T13:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff723f95b5e010ee4035faa9b8c7b797dcfa3174","assignee":{"login":"vartemiev","id":14345492,"node_id":"MDQ6VXNlcjE0MzQ1NDky","avatar_url":"https://avatars1.githubusercontent.com/u/14345492?v=4","gravatar_id":"","url":"https://api.github.com/users/vartemiev","html_url":"https://github.com/vartemiev","followers_url":"https://api.github.com/users/vartemiev/followers","following_url":"https://api.github.com/users/vartemiev/following{/other_user}","gists_url":"https://api.github.com/users/vartemiev/gists{/gist_id}","starred_url":"https://api.github.com/users/vartemiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vartemiev/subscriptions","organizations_url":"https://api.github.com/users/vartemiev/orgs","repos_url":"https://api.github.com/users/vartemiev/repos","events_url":"https://api.github.com/users/vartemiev/events{/privacy}","received_events_url":"https://api.github.com/users/vartemiev/received_events","type":"User","site_admin":false},"assignees":[{"login":"vartemiev","id":14345492,"node_id":"MDQ6VXNlcjE0MzQ1NDky","avatar_url":"https://avatars1.githubusercontent.com/u/14345492?v=4","gravatar_id":"","url":"https://api.github.com/users/vartemiev","html_url":"https://github.com/vartemiev","followers_url":"https://api.github.com/users/vartemiev/followers","following_url":"https://api.github.com/users/vartemiev/following{/other_user}","gists_url":"https://api.github.com/users/vartemiev/gists{/gist_id}","starred_url":"https://api.github.com/users/vartemiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vartemiev/subscriptions","organizations_url":"https://api.github.com/users/vartemiev/orgs","repos_url":"https://api.github.com/users/vartemiev/repos","events_url":"https://api.github.com/users/vartemiev/events{/privacy}","received_events_url":"https://api.github.com/users/vartemiev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/issues/1/comments","statuses_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/statuses/e449d25db225a961c0fcbd25ddab4a8ca0ed9ddc","head":{"label":"Manimall:module1-task2","ref":"module1-task2","sha":"e449d25db225a961c0fcbd25ddab4a8ca0ed9ddc","user":{"login":"Manimall","id":2580719,"node_id":"MDQ6VXNlcjI1ODA3MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2580719?v=4","gravatar_id":"","url":"https://api.github.com/users/Manimall","html_url":"https://github.com/Manimall","followers_url":"https://api.github.com/users/Manimall/followers","following_url":"https://api.github.com/users/Manimall/following{/other_user}","gists_url":"https://api.github.com/users/Manimall/gists{/gist_id}","starred_url":"https://api.github.com/users/Manimall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manimall/subscriptions","organizations_url":"https://api.github.com/users/Manimall/orgs","repos_url":"https://api.github.com/users/Manimall/repos","events_url":"https://api.github.com/users/Manimall/events{/privacy}","received_events_url":"https://api.github.com/users/Manimall/received_events","type":"User","site_admin":false},"repo":{"id":171403179,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE0MDMxNzk=","name":"544023-taskmanager-8","full_name":"Manimall/544023-taskmanager-8","private":false,"owner":{"login":"Manimall","id":2580719,"node_id":"MDQ6VXNlcjI1ODA3MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2580719?v=4","gravatar_id":"","url":"https://api.github.com/users/Manimall","html_url":"https://github.com/Manimall","followers_url":"https://api.github.com/users/Manimall/followers","following_url":"https://api.github.com/users/Manimall/following{/other_user}","gists_url":"https://api.github.com/users/Manimall/gists{/gist_id}","starred_url":"https://api.github.com/users/Manimall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manimall/subscriptions","organizations_url":"https://api.github.com/users/Manimall/orgs","repos_url":"https://api.github.com/users/Manimall/repos","events_url":"https://api.github.com/users/Manimall/events{/privacy}","received_events_url":"https://api.github.com/users/Manimall/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Manimall/544023-taskmanager-8","description":"Макс Кравченко","fork":true,"url":"https://api.github.com/repos/Manimall/544023-taskmanager-8","forks_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/forks","keys_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/teams","hooks_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/hooks","issue_events_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/issues/events{/number}","events_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/events","assignees_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/assignees{/user}","branches_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/branches{/branch}","tags_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/tags","blobs_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/statuses/{sha}","languages_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/languages","stargazers_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/stargazers","contributors_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/contributors","subscribers_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/subscribers","subscription_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/subscription","commits_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/contents/{+path}","compare_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/merges","archive_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/downloads","issues_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/issues{/number}","pulls_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/pulls{/number}","milestones_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/milestones{/number}","notifications_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/labels{/name}","releases_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/releases{/id}","deployments_url":"https://api.github.com/repos/Manimall/544023-taskmanager-8/deployments","created_at":"2019-02-19T04:09:39Z","updated_at":"2019-02-19T04:09:42Z","pushed_at":"2019-02-21T11:51:33Z","git_url":"git://github.com/Manimall/544023-taskmanager-8.git","ssh_url":"git@github.com:Manimall/544023-taskmanager-8.git","clone_url":"https://github.com/Manimall/544023-taskmanager-8.git","svn_url":"https://github.com/Manimall/544023-taskmanager-8","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-ecmascript:master","ref":"master","sha":"0acccf0c3424f136b1c4f00efdf67a64888ef3ea","user":{"login":"htmlacademy-ecmascript","id":22890904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODkwOTA0","avatar_url":"https://avatars2.githubusercontent.com/u/22890904?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-ecmascript","html_url":"https://github.com/htmlacademy-ecmascript","followers_url":"https://api.github.com/users/htmlacademy-ecmascript/followers","following_url":"https://api.github.com/users/htmlacademy-ecmascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-ecmascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-ecmascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-ecmascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-ecmascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-ecmascript/repos","events_url":"https://api.github.com/users/htmlacademy-ecmascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-ecmascript/received_events","type":"Organization","site_admin":false},"repo":{"id":171400669,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE0MDA2Njk=","name":"544023-taskmanager-8","full_name":"htmlacademy-ecmascript/544023-taskmanager-8","private":false,"owner":{"login":"htmlacademy-ecmascript","id":22890904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODkwOTA0","avatar_url":"https://avatars2.githubusercontent.com/u/22890904?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-ecmascript","html_url":"https://github.com/htmlacademy-ecmascript","followers_url":"https://api.github.com/users/htmlacademy-ecmascript/followers","following_url":"https://api.github.com/users/htmlacademy-ecmascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-ecmascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-ecmascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-ecmascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-ecmascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-ecmascript/repos","events_url":"https://api.github.com/users/htmlacademy-ecmascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-ecmascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8","description":"Макс Кравченко","fork":false,"url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8","forks_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/forks","keys_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/teams","hooks_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/events","assignees_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/tags","blobs_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/subscription","commits_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/merges","archive_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/downloads","issues_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/deployments","created_at":"2019-02-19T03:46:18Z","updated_at":"2019-02-20T13:00:41Z","pushed_at":"2019-02-21T12:05:41Z","git_url":"git://github.com/htmlacademy-ecmascript/544023-taskmanager-8.git","ssh_url":"git@github.com:htmlacademy-ecmascript/544023-taskmanager-8.git","clone_url":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8.git","svn_url":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8","homepage":"https://github.com/Manimall/544023-taskmanager-8","size":117,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1"},"html":{"href":"https://github.com/htmlacademy-ecmascript/544023-taskmanager-8/pull/1"},"issue":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/issues/1"},"comments":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8/statuses/e449d25db225a961c0fcbd25ddab4a8ca0ed9ddc"}},"author_association":"NONE"}}
|
{
"id": 171400669,
"name": "htmlacademy-ecmascript/544023-taskmanager-8",
"url": "https://api.github.com/repos/htmlacademy-ecmascript/544023-taskmanager-8"
}
|
{
"id": 14345492,
"login": "vartemiev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14345492?",
"url": "https://api.github.com/users/vartemiev"
}
|
{
"id": 22890904,
"login": "htmlacademy-ecmascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22890904?",
"url": "https://api.github.com/orgs/htmlacademy-ecmascript"
}
| 2019-02-21T13:13:35 |
9110199808
|
{"actor":{"display_login":"vartemiev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/comments/299571980","pull_request_review_id":257005824,"id":299571980,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTU3MTk4MA==","diff_hunk":"@@ -0,0 +1,127 @@\n+/*\n+ * Copyright 2016-2019 The Reaktivity Project\n+ *\n+ * The Reaktivity Project licenses this file to you under the Apache License,\n+ * version 2.0 (the \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at:\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+scope mqtt\n+{\n+ struct MqttSubscribeInfo\n+ {\n+ uint16 packetId;\n+ }\n+\n+ struct MqttTopicFormat\n+ {\n+ string topic;\n+ uint8 options;\n+ }\n+\n+ struct MqttUnsubscribePacket\n+ {\n+ list<string> topics;\n+ list<mqtt::MqttUserProperty> userProperties;\n+ }\n+\n+ struct MqttPublishPacket\n+ {\n+ uint16 packetId;\n+ string topic;\n+ uint32 messageExpiry;\n+ mqtt::MqttResponseTopicFormat respTopicInfo;\n+ list<mqtt::MqttUserProperty> properties;\n+ string contentType;\n+ mqtt::MqttPayloadFormat payloadFormat;\n+ }\n+\n+ struct MqttResponseTopicFormat\n+ {\n+ string topic;\n+ mqtt::MqttBinary correlationInfo;\n+ }\n+\n+ enum MqttRole\n+ {\n+ SENDER,\n+ RECEIVER\n+ }\n+\n+ enum MqttPayloadFormat\n+ {\n+ BINARY,\n+ TEXT\n+ }\n+\n+ struct MqttReasonCode\n+ {\n+ uint8 reasonCode;\n+ }\n+\n+ struct MqttSubAckPacket\n+ {\n+ list<mqtt::MqttReasonCode> reasonCodes;\n+ list<mqtt::MqttUserProperty> userProperties;\n+ }\n+\n+ struct MqttBinary\n+ {\n+ uint16 length;\n+ octets[length] bytes;\n+ }\n+\n+ struct MqttUserProperty\n+ {\n+ string key;\n+ string value;\n+ }\n+\n+ struct MqttString\n+ {\n+ string value;\n+ }\n+\n+ scope control\n+ {\n+\n+ }\n+\n+ scope stream\n+ {\n+ struct MqttBeginEx extends core::stream::Extension\n+ {\n+ string clientId;\n+ mqtt::MqttSubscribeInfo subscriptionDetails;\n+ list<mqtt::MqttTopicFormat> topics;\n+ list<mqtt::MqttReasonCode> reasonCodes;\n+ list<mqtt::MqttUserProperty> properties;\n+ }\n+\n+ struct MqttDataEx extends core::stream::Extension\n+ {\n+ uint16 packetId;\n+ string topic;\n+ uint32 messageExpiry;\n+ string contentType;\n+ mqtt::MqttPayloadFormat payloadFormat;\n+ mqtt::MqttResponseTopicFormat respTopicInfo;\n+ list<mqtt::MqttUserProperty> properties;\n+ }\n+\n+ struct MqttEndEx extends core::stream::Extension\n+ {\n+ list<mqtt::MqttString> topics;\n+ list<mqtt::MqttReasonCode> reasonCodes;\n+ list<mqtt::MqttUserProperty> userProperties;\n+ }","path":"src/main/resources/META-INF/reaktivity/mqtt.idl","position":102,"original_position":125,"commit_id":"9391d06932f1e223555f534fcad5c260a9ff3415","original_commit_id":"5a960d77d0e4a82090d480bfb250faacae4f8b69","user":{"login":"jfallows","id":2099911,"node_id":"MDQ6VXNlcjIwOTk5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2099911?v=4","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false},"body":"Is `packetId` still needed on `MqttEndEx`?","created_at":"2019-07-02T16:23:50Z","updated_at":"2019-07-02T16:40:16Z","html_url":"https://github.com/reaktivity/nukleus-mqtt.spec/pull/2#discussion_r299571980","pull_request_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/comments/299571980"},"html":{"href":"https://github.com/reaktivity/nukleus-mqtt.spec/pull/2#discussion_r299571980"},"pull_request":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2"}},"in_reply_to_id":298284470},"pull_request":{"url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2","id":290777346,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNzc3MzQ2","html_url":"https://github.com/reaktivity/nukleus-mqtt.spec/pull/2","diff_url":"https://github.com/reaktivity/nukleus-mqtt.spec/pull/2.diff","patch_url":"https://github.com/reaktivity/nukleus-mqtt.spec/pull/2.patch","issue_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/issues/2","number":2,"state":"open","locked":false,"title":"Mqtt.idl","user":{"login":"amandaratio","id":28241860,"node_id":"MDQ6VXNlcjI4MjQxODYw","avatar_url":"https://avatars3.githubusercontent.com/u/28241860?v=4","gravatar_id":"","url":"https://api.github.com/users/amandaratio","html_url":"https://github.com/amandaratio","followers_url":"https://api.github.com/users/amandaratio/followers","following_url":"https://api.github.com/users/amandaratio/following{/other_user}","gists_url":"https://api.github.com/users/amandaratio/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaratio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaratio/subscriptions","organizations_url":"https://api.github.com/users/amandaratio/orgs","repos_url":"https://api.github.com/users/amandaratio/repos","events_url":"https://api.github.com/users/amandaratio/events{/privacy}","received_events_url":"https://api.github.com/users/amandaratio/received_events","type":"User","site_admin":false},"body":"1. Created `BEGIN` `DATA` and `END` with respective tests\r\n2. Added Control scripts , `RouteEx` in `Mqtt.idl` & tests\r\n3. Added `MqttFunctions` & coverage tests","created_at":"2019-06-21T23:56:43Z","updated_at":"2019-07-02T16:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bfff1aaccb952ee78cee46759ae049145bd1e99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2/commits","review_comments_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2/comments","review_comment_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/issues/2/comments","statuses_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/statuses/9391d06932f1e223555f534fcad5c260a9ff3415","head":{"label":"amandaratio:develop","ref":"develop","sha":"9391d06932f1e223555f534fcad5c260a9ff3415","user":{"login":"amandaratio","id":28241860,"node_id":"MDQ6VXNlcjI4MjQxODYw","avatar_url":"https://avatars3.githubusercontent.com/u/28241860?v=4","gravatar_id":"","url":"https://api.github.com/users/amandaratio","html_url":"https://github.com/amandaratio","followers_url":"https://api.github.com/users/amandaratio/followers","following_url":"https://api.github.com/users/amandaratio/following{/other_user}","gists_url":"https://api.github.com/users/amandaratio/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaratio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaratio/subscriptions","organizations_url":"https://api.github.com/users/amandaratio/orgs","repos_url":"https://api.github.com/users/amandaratio/repos","events_url":"https://api.github.com/users/amandaratio/events{/privacy}","received_events_url":"https://api.github.com/users/amandaratio/received_events","type":"User","site_admin":false},"repo":{"id":191418935,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE0MTg5MzU=","name":"nukleus-mqtt.spec","full_name":"amandaratio/nukleus-mqtt.spec","private":false,"owner":{"login":"amandaratio","id":28241860,"node_id":"MDQ6VXNlcjI4MjQxODYw","avatar_url":"https://avatars3.githubusercontent.com/u/28241860?v=4","gravatar_id":"","url":"https://api.github.com/users/amandaratio","html_url":"https://github.com/amandaratio","followers_url":"https://api.github.com/users/amandaratio/followers","following_url":"https://api.github.com/users/amandaratio/following{/other_user}","gists_url":"https://api.github.com/users/amandaratio/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaratio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaratio/subscriptions","organizations_url":"https://api.github.com/users/amandaratio/orgs","repos_url":"https://api.github.com/users/amandaratio/repos","events_url":"https://api.github.com/users/amandaratio/events{/privacy}","received_events_url":"https://api.github.com/users/amandaratio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amandaratio/nukleus-mqtt.spec","description":null,"fork":true,"url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec","forks_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/forks","keys_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/teams","hooks_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/hooks","issue_events_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/issues/events{/number}","events_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/events","assignees_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/assignees{/user}","branches_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/branches{/branch}","tags_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/tags","blobs_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/statuses/{sha}","languages_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/languages","stargazers_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/stargazers","contributors_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/contributors","subscribers_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/subscribers","subscription_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/subscription","commits_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/contents/{+path}","compare_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/merges","archive_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/downloads","issues_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/issues{/number}","pulls_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/pulls{/number}","milestones_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/milestones{/number}","notifications_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/labels{/name}","releases_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/releases{/id}","deployments_url":"https://api.github.com/repos/amandaratio/nukleus-mqtt.spec/deployments","created_at":"2019-06-11T17:29:17Z","updated_at":"2019-07-01T23:50:34Z","pushed_at":"2019-07-01T23:50:31Z","git_url":"git://github.com/amandaratio/nukleus-mqtt.spec.git","ssh_url":"git@github.com:amandaratio/nukleus-mqtt.spec.git","clone_url":"https://github.com/amandaratio/nukleus-mqtt.spec.git","svn_url":"https://github.com/amandaratio/nukleus-mqtt.spec","homepage":null,"size":154,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"reaktivity:develop","ref":"develop","sha":"585fe8f73cde2e65d4f37c631d0e86a58e99622b","user":{"login":"reaktivity","id":22941769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTQxNzY5","avatar_url":"https://avatars0.githubusercontent.com/u/22941769?v=4","gravatar_id":"","url":"https://api.github.com/users/reaktivity","html_url":"https://github.com/reaktivity","followers_url":"https://api.github.com/users/reaktivity/followers","following_url":"https://api.github.com/users/reaktivity/following{/other_user}","gists_url":"https://api.github.com/users/reaktivity/gists{/gist_id}","starred_url":"https://api.github.com/users/reaktivity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaktivity/subscriptions","organizations_url":"https://api.github.com/users/reaktivity/orgs","repos_url":"https://api.github.com/users/reaktivity/repos","events_url":"https://api.github.com/users/reaktivity/events{/privacy}","received_events_url":"https://api.github.com/users/reaktivity/received_events","type":"Organization","site_admin":false},"repo":{"id":191416290,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE0MTYyOTA=","name":"nukleus-mqtt.spec","full_name":"reaktivity/nukleus-mqtt.spec","private":false,"owner":{"login":"reaktivity","id":22941769,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTQxNzY5","avatar_url":"https://avatars0.githubusercontent.com/u/22941769?v=4","gravatar_id":"","url":"https://api.github.com/users/reaktivity","html_url":"https://github.com/reaktivity","followers_url":"https://api.github.com/users/reaktivity/followers","following_url":"https://api.github.com/users/reaktivity/following{/other_user}","gists_url":"https://api.github.com/users/reaktivity/gists{/gist_id}","starred_url":"https://api.github.com/users/reaktivity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaktivity/subscriptions","organizations_url":"https://api.github.com/users/reaktivity/orgs","repos_url":"https://api.github.com/users/reaktivity/repos","events_url":"https://api.github.com/users/reaktivity/events{/privacy}","received_events_url":"https://api.github.com/users/reaktivity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reaktivity/nukleus-mqtt.spec","description":null,"fork":false,"url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec","forks_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/forks","keys_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/teams","hooks_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/hooks","issue_events_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/issues/events{/number}","events_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/events","assignees_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/assignees{/user}","branches_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/branches{/branch}","tags_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/tags","blobs_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/statuses/{sha}","languages_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/languages","stargazers_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/stargazers","contributors_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/contributors","subscribers_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/subscribers","subscription_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/subscription","commits_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/contents/{+path}","compare_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/merges","archive_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/downloads","issues_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/issues{/number}","pulls_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls{/number}","milestones_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/milestones{/number}","notifications_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/labels{/name}","releases_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/releases{/id}","deployments_url":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/deployments","created_at":"2019-06-11T17:11:09Z","updated_at":"2019-06-25T05:42:14Z","pushed_at":"2019-07-01T23:50:33Z","git_url":"git://github.com/reaktivity/nukleus-mqtt.spec.git","ssh_url":"git@github.com:reaktivity/nukleus-mqtt.spec.git","clone_url":"https://github.com/reaktivity/nukleus-mqtt.spec.git","svn_url":"https://github.com/reaktivity/nukleus-mqtt.spec","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2"},"html":{"href":"https://github.com/reaktivity/nukleus-mqtt.spec/pull/2"},"issue":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/issues/2"},"comments":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/reaktivity/nukleus-mqtt.spec/statuses/9391d06932f1e223555f534fcad5c260a9ff3415"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 191416290,
"name": "reaktivity/nukleus-mqtt.spec",
"url": "https://api.github.com/repos/reaktivity/nukleus-mqtt.spec"
}
|
{
"id": 2099911,
"login": "jfallows",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2099911?",
"url": "https://api.github.com/users/jfallows"
}
|
{
"id": 22941769,
"login": "reaktivity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22941769?",
"url": "https://api.github.com/orgs/reaktivity"
}
| 2019-07-02T16:23:50 |
9935487620
|
{"actor":{"display_login":"jfallows"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/objective-solutions/taskboard/pulls/comments/264211812","pull_request_review_id":212809431,"id":264211812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDIxMTgxMg==","diff_hunk":"@@ -152,55 +118,33 @@\n notify: true\n },\n \n- isOpen: {\n- type: Boolean,\n- notify: true,\n- value: () => false\n- },\n-\n- issueBallparks: {\n- type: Array,\n- value: () => [],\n- notify: true\n- },\n-\n selected: {\n type: Number,\n value: 0\n },\n \n metadata: {\n- type: Array,\n- observer: '_updateMeta'\n- }\n- },\n+ type: Array\n+ } },","path":"cardboard/src/main/resources/static/elements/taskboard/issue-detail-tabs.html","position":124,"original_position":124,"commit_id":"0cd245c610c5d13206cdc26bd1ed72ca695388cb","original_commit_id":"0cd245c610c5d13206cdc26bd1ed72ca695388cb","user":{"login":"jhonypg","id":4572668,"node_id":"MDQ6VXNlcjQ1NzI2Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/4572668?v=4","gravatar_id":"","url":"https://api.github.com/users/jhonypg","html_url":"https://github.com/jhonypg","followers_url":"https://api.github.com/users/jhonypg/followers","following_url":"https://api.github.com/users/jhonypg/following{/other_user}","gists_url":"https://api.github.com/users/jhonypg/gists{/gist_id}","starred_url":"https://api.github.com/users/jhonypg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhonypg/subscriptions","organizations_url":"https://api.github.com/users/jhonypg/orgs","repos_url":"https://api.github.com/users/jhonypg/repos","events_url":"https://api.github.com/users/jhonypg/events{/privacy}","received_events_url":"https://api.github.com/users/jhonypg/received_events","type":"User","site_admin":false},"body":"Indentação","created_at":"2019-03-11T12:39:06Z","updated_at":"2019-03-11T12:58:47Z","html_url":"https://github.com/objective-solutions/taskboard/pull/576#discussion_r264211812","pull_request_url":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/objective-solutions/taskboard/pulls/comments/264211812"},"html":{"href":"https://github.com/objective-solutions/taskboard/pull/576#discussion_r264211812"},"pull_request":{"href":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576"}}},"pull_request":{"url":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576","id":255015114,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1MDE1MTE0","html_url":"https://github.com/objective-solutions/taskboard/pull/576","diff_url":"https://github.com/objective-solutions/taskboard/pull/576.diff","patch_url":"https://github.com/objective-solutions/taskboard/pull/576.patch","issue_url":"https://api.github.com/repos/objective-solutions/taskboard/issues/576","number":576,"state":"open","locked":false,"title":"[TOOLS-2352] - Subtask Creation in taskboard","user":{"login":"mauricio-frontend","id":4502454,"node_id":"MDQ6VXNlcjQ1MDI0NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4502454?v=4","gravatar_id":"","url":"https://api.github.com/users/mauricio-frontend","html_url":"https://github.com/mauricio-frontend","followers_url":"https://api.github.com/users/mauricio-frontend/followers","following_url":"https://api.github.com/users/mauricio-frontend/following{/other_user}","gists_url":"https://api.github.com/users/mauricio-frontend/gists{/gist_id}","starred_url":"https://api.github.com/users/mauricio-frontend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauricio-frontend/subscriptions","organizations_url":"https://api.github.com/users/mauricio-frontend/orgs","repos_url":"https://api.github.com/users/mauricio-frontend/repos","events_url":"https://api.github.com/users/mauricio-frontend/events{/privacy}","received_events_url":"https://api.github.com/users/mauricio-frontend/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-21T13:05:26Z","updated_at":"2019-03-11T12:58:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d284259e2145a2035b66d57484b1452aadff78c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576/commits","review_comments_url":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576/comments","review_comment_url":"https://api.github.com/repos/objective-solutions/taskboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/objective-solutions/taskboard/issues/576/comments","statuses_url":"https://api.github.com/repos/objective-solutions/taskboard/statuses/0cd245c610c5d13206cdc26bd1ed72ca695388cb","head":{"label":"objective-solutions:TOOLS-2352","ref":"TOOLS-2352","sha":"0cd245c610c5d13206cdc26bd1ed72ca695388cb","user":{"login":"objective-solutions","id":22942665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTQyNjY1","avatar_url":"https://avatars2.githubusercontent.com/u/22942665?v=4","gravatar_id":"","url":"https://api.github.com/users/objective-solutions","html_url":"https://github.com/objective-solutions","followers_url":"https://api.github.com/users/objective-solutions/followers","following_url":"https://api.github.com/users/objective-solutions/following{/other_user}","gists_url":"https://api.github.com/users/objective-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/objective-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objective-solutions/subscriptions","organizations_url":"https://api.github.com/users/objective-solutions/orgs","repos_url":"https://api.github.com/users/objective-solutions/repos","events_url":"https://api.github.com/users/objective-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/objective-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":71564606,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU2NDYwNg==","name":"taskboard","full_name":"objective-solutions/taskboard","private":false,"owner":{"login":"objective-solutions","id":22942665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTQyNjY1","avatar_url":"https://avatars2.githubusercontent.com/u/22942665?v=4","gravatar_id":"","url":"https://api.github.com/users/objective-solutions","html_url":"https://github.com/objective-solutions","followers_url":"https://api.github.com/users/objective-solutions/followers","following_url":"https://api.github.com/users/objective-solutions/following{/other_user}","gists_url":"https://api.github.com/users/objective-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/objective-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objective-solutions/subscriptions","organizations_url":"https://api.github.com/users/objective-solutions/orgs","repos_url":"https://api.github.com/users/objective-solutions/repos","events_url":"https://api.github.com/users/objective-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/objective-solutions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/objective-solutions/taskboard","description":"Fullstack Taskboard","fork":false,"url":"https://api.github.com/repos/objective-solutions/taskboard","forks_url":"https://api.github.com/repos/objective-solutions/taskboard/forks","keys_url":"https://api.github.com/repos/objective-solutions/taskboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objective-solutions/taskboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objective-solutions/taskboard/teams","hooks_url":"https://api.github.com/repos/objective-solutions/taskboard/hooks","issue_events_url":"https://api.github.com/repos/objective-solutions/taskboard/issues/events{/number}","events_url":"https://api.github.com/repos/objective-solutions/taskboard/events","assignees_url":"https://api.github.com/repos/objective-solutions/taskboard/assignees{/user}","branches_url":"https://api.github.com/repos/objective-solutions/taskboard/branches{/branch}","tags_url":"https://api.github.com/repos/objective-solutions/taskboard/tags","blobs_url":"https://api.github.com/repos/objective-solutions/taskboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objective-solutions/taskboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objective-solutions/taskboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/objective-solutions/taskboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objective-solutions/taskboard/statuses/{sha}","languages_url":"https://api.github.com/repos/objective-solutions/taskboard/languages","stargazers_url":"https://api.github.com/repos/objective-solutions/taskboard/stargazers","contributors_url":"https://api.github.com/repos/objective-solutions/taskboard/contributors","subscribers_url":"https://api.github.com/repos/objective-solutions/taskboard/subscribers","subscription_url":"https://api.github.com/repos/objective-solutions/taskboard/subscription","commits_url":"https://api.github.com/repos/objective-solutions/taskboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/objective-solutions/taskboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/objective-solutions/taskboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/objective-solutions/taskboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/objective-solutions/taskboard/contents/{+path}","compare_url":"https://api.github.com/repos/objective-solutions/taskboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objective-solutions/taskboard/merges","archive_url":"https://api.github.com/repos/objective-solutions/taskboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objective-solutions/taskboard/downloads","issues_url":"https://api.github.com/repos/objective-solutions/taskboard/issues{/number}","pulls_url":"https://api.github.com/repos/objective-solutions/taskboard/pulls{/number}","milestones_url":"https://api.github.com/repos/objective-solutions/taskboard/milestones{/number}","notifications_url":"https://api.github.com/repos/objective-solutions/taskboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objective-solutions/taskboard/labels{/name}","releases_url":"https://api.github.com/repos/objective-solutions/taskboard/releases{/id}","deployments_url":"https://api.github.com/repos/objective-solutions/taskboard/deployments","created_at":"2016-10-21T12:53:27Z","updated_at":"2019-02-28T18:55:08Z","pushed_at":"2019-03-08T20:24:13Z","git_url":"git://github.com/objective-solutions/taskboard.git","ssh_url":"git@github.com:objective-solutions/taskboard.git","clone_url":"https://github.com/objective-solutions/taskboard.git","svn_url":"https://github.com/objective-solutions/taskboard","homepage":null,"size":14375,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":9,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"objective-solutions:master","ref":"master","sha":"b62b6b69da4d97622df68b9c5eea964261a3b054","user":{"login":"objective-solutions","id":22942665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTQyNjY1","avatar_url":"https://avatars2.githubusercontent.com/u/22942665?v=4","gravatar_id":"","url":"https://api.github.com/users/objective-solutions","html_url":"https://github.com/objective-solutions","followers_url":"https://api.github.com/users/objective-solutions/followers","following_url":"https://api.github.com/users/objective-solutions/following{/other_user}","gists_url":"https://api.github.com/users/objective-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/objective-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objective-solutions/subscriptions","organizations_url":"https://api.github.com/users/objective-solutions/orgs","repos_url":"https://api.github.com/users/objective-solutions/repos","events_url":"https://api.github.com/users/objective-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/objective-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":71564606,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU2NDYwNg==","name":"taskboard","full_name":"objective-solutions/taskboard","private":false,"owner":{"login":"objective-solutions","id":22942665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTQyNjY1","avatar_url":"https://avatars2.githubusercontent.com/u/22942665?v=4","gravatar_id":"","url":"https://api.github.com/users/objective-solutions","html_url":"https://github.com/objective-solutions","followers_url":"https://api.github.com/users/objective-solutions/followers","following_url":"https://api.github.com/users/objective-solutions/following{/other_user}","gists_url":"https://api.github.com/users/objective-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/objective-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objective-solutions/subscriptions","organizations_url":"https://api.github.com/users/objective-solutions/orgs","repos_url":"https://api.github.com/users/objective-solutions/repos","events_url":"https://api.github.com/users/objective-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/objective-solutions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/objective-solutions/taskboard","description":"Fullstack Taskboard","fork":false,"url":"https://api.github.com/repos/objective-solutions/taskboard","forks_url":"https://api.github.com/repos/objective-solutions/taskboard/forks","keys_url":"https://api.github.com/repos/objective-solutions/taskboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objective-solutions/taskboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objective-solutions/taskboard/teams","hooks_url":"https://api.github.com/repos/objective-solutions/taskboard/hooks","issue_events_url":"https://api.github.com/repos/objective-solutions/taskboard/issues/events{/number}","events_url":"https://api.github.com/repos/objective-solutions/taskboard/events","assignees_url":"https://api.github.com/repos/objective-solutions/taskboard/assignees{/user}","branches_url":"https://api.github.com/repos/objective-solutions/taskboard/branches{/branch}","tags_url":"https://api.github.com/repos/objective-solutions/taskboard/tags","blobs_url":"https://api.github.com/repos/objective-solutions/taskboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objective-solutions/taskboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objective-solutions/taskboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/objective-solutions/taskboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objective-solutions/taskboard/statuses/{sha}","languages_url":"https://api.github.com/repos/objective-solutions/taskboard/languages","stargazers_url":"https://api.github.com/repos/objective-solutions/taskboard/stargazers","contributors_url":"https://api.github.com/repos/objective-solutions/taskboard/contributors","subscribers_url":"https://api.github.com/repos/objective-solutions/taskboard/subscribers","subscription_url":"https://api.github.com/repos/objective-solutions/taskboard/subscription","commits_url":"https://api.github.com/repos/objective-solutions/taskboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/objective-solutions/taskboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/objective-solutions/taskboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/objective-solutions/taskboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/objective-solutions/taskboard/contents/{+path}","compare_url":"https://api.github.com/repos/objective-solutions/taskboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objective-solutions/taskboard/merges","archive_url":"https://api.github.com/repos/objective-solutions/taskboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objective-solutions/taskboard/downloads","issues_url":"https://api.github.com/repos/objective-solutions/taskboard/issues{/number}","pulls_url":"https://api.github.com/repos/objective-solutions/taskboard/pulls{/number}","milestones_url":"https://api.github.com/repos/objective-solutions/taskboard/milestones{/number}","notifications_url":"https://api.github.com/repos/objective-solutions/taskboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objective-solutions/taskboard/labels{/name}","releases_url":"https://api.github.com/repos/objective-solutions/taskboard/releases{/id}","deployments_url":"https://api.github.com/repos/objective-solutions/taskboard/deployments","created_at":"2016-10-21T12:53:27Z","updated_at":"2019-02-28T18:55:08Z","pushed_at":"2019-03-08T20:24:13Z","git_url":"git://github.com/objective-solutions/taskboard.git","ssh_url":"git@github.com:objective-solutions/taskboard.git","clone_url":"https://github.com/objective-solutions/taskboard.git","svn_url":"https://github.com/objective-solutions/taskboard","homepage":null,"size":14375,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":9,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576"},"html":{"href":"https://github.com/objective-solutions/taskboard/pull/576"},"issue":{"href":"https://api.github.com/repos/objective-solutions/taskboard/issues/576"},"comments":{"href":"https://api.github.com/repos/objective-solutions/taskboard/issues/576/comments"},"review_comments":{"href":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576/comments"},"review_comment":{"href":"https://api.github.com/repos/objective-solutions/taskboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/objective-solutions/taskboard/pulls/576/commits"},"statuses":{"href":"https://api.github.com/repos/objective-solutions/taskboard/statuses/0cd245c610c5d13206cdc26bd1ed72ca695388cb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 71564606,
"name": "objective-solutions/taskboard",
"url": "https://api.github.com/repos/objective-solutions/taskboard"
}
|
{
"id": 4572668,
"login": "jhonypg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4572668?",
"url": "https://api.github.com/users/jhonypg"
}
|
{
"id": 22942665,
"login": "objective-solutions",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22942665?",
"url": "https://api.github.com/orgs/objective-solutions"
}
| 2019-03-11T12:39:06 |
9218260923
|
{"actor":{"display_login":"jhonypg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/unitystation/unitystation/pulls/comments/365603788","pull_request_review_id":341592957,"id":365603788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTYwMzc4OA==","diff_hunk":"@@ -75,7 +84,7 @@ public void Awake()\n \tprivate void OnWillDestroyServer(DestructionInfo info)\n \t{\n \t\t//release the player\n-\t\tif (occupant > 0)\n+\t\tif (occupantNetId > 0)","path":"UnityProject/Assets/Scripts/Furniture/OccupiableDirectionalSprite.cs","position":39,"original_position":39,"commit_id":"fb010c2d52d353a22c7f153b56b8bd3bdf9ac121","original_commit_id":"fb010c2d52d353a22c7f153b56b8bd3bdf9ac121","user":{"login":"JesterX666","id":32009105,"node_id":"MDQ6VXNlcjMyMDA5MTA1","avatar_url":"https://avatars2.githubusercontent.com/u/32009105?v=4","gravatar_id":"","url":"https://api.github.com/users/JesterX666","html_url":"https://github.com/JesterX666","followers_url":"https://api.github.com/users/JesterX666/followers","following_url":"https://api.github.com/users/JesterX666/following{/other_user}","gists_url":"https://api.github.com/users/JesterX666/gists{/gist_id}","starred_url":"https://api.github.com/users/JesterX666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JesterX666/subscriptions","organizations_url":"https://api.github.com/users/JesterX666/orgs","repos_url":"https://api.github.com/users/JesterX666/repos","events_url":"https://api.github.com/users/JesterX666/events{/privacy}","received_events_url":"https://api.github.com/users/JesterX666/received_events","type":"User","site_admin":false},"body":"Will be preferable to use the NetId.Empty constant instead of 0 (makes it more pretty)","created_at":"2020-01-12T19:06:58Z","updated_at":"2020-01-12T19:16:41Z","html_url":"https://github.com/unitystation/unitystation/pull/2586#discussion_r365603788","pull_request_url":"https://api.github.com/repos/unitystation/unitystation/pulls/2586","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/unitystation/unitystation/pulls/comments/365603788"},"html":{"href":"https://github.com/unitystation/unitystation/pull/2586#discussion_r365603788"},"pull_request":{"href":"https://api.github.com/repos/unitystation/unitystation/pulls/2586"}}},"pull_request":{"url":"https://api.github.com/repos/unitystation/unitystation/pulls/2586","id":361790307,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxNzkwMzA3","html_url":"https://github.com/unitystation/unitystation/pull/2586","diff_url":"https://github.com/unitystation/unitystation/pull/2586.diff","patch_url":"https://github.com/unitystation/unitystation/pull/2586.patch","issue_url":"https://api.github.com/repos/unitystation/unitystation/issues/2586","number":2586,"state":"open","locked":false,"title":"Roller Chairs","user":{"login":"chairbender","id":1329062,"node_id":"MDQ6VXNlcjEzMjkwNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1329062?v=4","gravatar_id":"","url":"https://api.github.com/users/chairbender","html_url":"https://github.com/chairbender","followers_url":"https://api.github.com/users/chairbender/followers","following_url":"https://api.github.com/users/chairbender/following{/other_user}","gists_url":"https://api.github.com/users/chairbender/gists{/gist_id}","starred_url":"https://api.github.com/users/chairbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chairbender/subscriptions","organizations_url":"https://api.github.com/users/chairbender/orgs","repos_url":"https://api.github.com/users/chairbender/repos","events_url":"https://api.github.com/users/chairbender/events{/privacy}","received_events_url":"https://api.github.com/users/chairbender/received_events","type":"User","site_admin":false},"body":"### Purpose\r\nFixes #2425 \r\nYou can even do newtonian movement while seated in space by picking up a gun or something and shooting. Doesn't work while there's gravity though.\r\n\r\nThis was half and half between me and @JesterX666 . You can give them half and put my half back into the pool so we can put it towards other bounties.\r\n\r\n### Notes:\r\nThere might be some weird edge cases, particularly when in space, but situations I thought to test seem to be working fine.\r\n\r\n### Please make sure you have followed the self checks below before submitting a PR:\r\n\r\n- Code is sufficiently commented\r\n- Code is indented with tabs and not spaces\r\n- The PR does not include any unnecessary .meta, .prefab or <b>.unity (scene) changes</b>\r\n- The PR does not bring up any new compile errors\r\n- The PR has been tested in editor\r\n- Any new files are named using PascalCase (to avoid issues on case sensitive file systems)\r\n- Any new / changed components follow the [Component Development Checklist](https://github.com/unitystation/unitystation/wiki/Component-Development-Checklist)\r\n- Any new objects / items follow the [Creating Items and Objects Guide](https://github.com/unitystation/unitystation/wiki/Creating-Items-and-Objects%3A-Now-With-Prefab-Variants) (especially concerning the use of prefab variants)\r\n- The PR has been tested in multiplayer (with 2 clients and late joiners, if applicable)\r\n- The PR has been tested with round restarts.\r\n- The PR has been tested on moving / rotating / rotated-before-joining matrices (if applicable)\r\n","created_at":"2020-01-12T03:24:50Z","updated_at":"2020-01-12T19:16:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbfcec06fa92805b62cfc6a99fe51d664b03ba0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unitystation/unitystation/pulls/2586/commits","review_comments_url":"https://api.github.com/repos/unitystation/unitystation/pulls/2586/comments","review_comment_url":"https://api.github.com/repos/unitystation/unitystation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unitystation/unitystation/issues/2586/comments","statuses_url":"https://api.github.com/repos/unitystation/unitystation/statuses/fb010c2d52d353a22c7f153b56b8bd3bdf9ac121","head":{"label":"chairbender:rollerchairs-improved","ref":"rollerchairs-improved","sha":"fb010c2d52d353a22c7f153b56b8bd3bdf9ac121","user":{"login":"chairbender","id":1329062,"node_id":"MDQ6VXNlcjEzMjkwNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1329062?v=4","gravatar_id":"","url":"https://api.github.com/users/chairbender","html_url":"https://github.com/chairbender","followers_url":"https://api.github.com/users/chairbender/followers","following_url":"https://api.github.com/users/chairbender/following{/other_user}","gists_url":"https://api.github.com/users/chairbender/gists{/gist_id}","starred_url":"https://api.github.com/users/chairbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chairbender/subscriptions","organizations_url":"https://api.github.com/users/chairbender/orgs","repos_url":"https://api.github.com/users/chairbender/repos","events_url":"https://api.github.com/users/chairbender/events{/privacy}","received_events_url":"https://api.github.com/users/chairbender/received_events","type":"User","site_admin":false},"repo":{"id":162350418,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIzNTA0MTg=","name":"unitystation","full_name":"chairbender/unitystation","private":false,"owner":{"login":"chairbender","id":1329062,"node_id":"MDQ6VXNlcjEzMjkwNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1329062?v=4","gravatar_id":"","url":"https://api.github.com/users/chairbender","html_url":"https://github.com/chairbender","followers_url":"https://api.github.com/users/chairbender/followers","following_url":"https://api.github.com/users/chairbender/following{/other_user}","gists_url":"https://api.github.com/users/chairbender/gists{/gist_id}","starred_url":"https://api.github.com/users/chairbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chairbender/subscriptions","organizations_url":"https://api.github.com/users/chairbender/orgs","repos_url":"https://api.github.com/users/chairbender/repos","events_url":"https://api.github.com/users/chairbender/events{/privacy}","received_events_url":"https://api.github.com/users/chairbender/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chairbender/unitystation","description":"The original unitystation","fork":true,"url":"https://api.github.com/repos/chairbender/unitystation","forks_url":"https://api.github.com/repos/chairbender/unitystation/forks","keys_url":"https://api.github.com/repos/chairbender/unitystation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chairbender/unitystation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chairbender/unitystation/teams","hooks_url":"https://api.github.com/repos/chairbender/unitystation/hooks","issue_events_url":"https://api.github.com/repos/chairbender/unitystation/issues/events{/number}","events_url":"https://api.github.com/repos/chairbender/unitystation/events","assignees_url":"https://api.github.com/repos/chairbender/unitystation/assignees{/user}","branches_url":"https://api.github.com/repos/chairbender/unitystation/branches{/branch}","tags_url":"https://api.github.com/repos/chairbender/unitystation/tags","blobs_url":"https://api.github.com/repos/chairbender/unitystation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chairbender/unitystation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chairbender/unitystation/git/refs{/sha}","trees_url":"https://api.github.com/repos/chairbender/unitystation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chairbender/unitystation/statuses/{sha}","languages_url":"https://api.github.com/repos/chairbender/unitystation/languages","stargazers_url":"https://api.github.com/repos/chairbender/unitystation/stargazers","contributors_url":"https://api.github.com/repos/chairbender/unitystation/contributors","subscribers_url":"https://api.github.com/repos/chairbender/unitystation/subscribers","subscription_url":"https://api.github.com/repos/chairbender/unitystation/subscription","commits_url":"https://api.github.com/repos/chairbender/unitystation/commits{/sha}","git_commits_url":"https://api.github.com/repos/chairbender/unitystation/git/commits{/sha}","comments_url":"https://api.github.com/repos/chairbender/unitystation/comments{/number}","issue_comment_url":"https://api.github.com/repos/chairbender/unitystation/issues/comments{/number}","contents_url":"https://api.github.com/repos/chairbender/unitystation/contents/{+path}","compare_url":"https://api.github.com/repos/chairbender/unitystation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chairbender/unitystation/merges","archive_url":"https://api.github.com/repos/chairbender/unitystation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chairbender/unitystation/downloads","issues_url":"https://api.github.com/repos/chairbender/unitystation/issues{/number}","pulls_url":"https://api.github.com/repos/chairbender/unitystation/pulls{/number}","milestones_url":"https://api.github.com/repos/chairbender/unitystation/milestones{/number}","notifications_url":"https://api.github.com/repos/chairbender/unitystation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chairbender/unitystation/labels{/name}","releases_url":"https://api.github.com/repos/chairbender/unitystation/releases{/id}","deployments_url":"https://api.github.com/repos/chairbender/unitystation/deployments","created_at":"2018-12-18T22:03:13Z","updated_at":"2018-12-22T02:44:09Z","pushed_at":"2020-01-12T05:48:28Z","git_url":"git://github.com/chairbender/unitystation.git","ssh_url":"git@github.com:chairbender/unitystation.git","clone_url":"https://github.com/chairbender/unitystation.git","svn_url":"https://github.com/chairbender/unitystation","homepage":"https://unitystation.org","size":587082,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"unitystation:develop","ref":"develop","sha":"cc1473ec8ac291a68dcf92540a2114074d8f5c8b","user":{"login":"unitystation","id":23096507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDk2NTA3","avatar_url":"https://avatars1.githubusercontent.com/u/23096507?v=4","gravatar_id":"","url":"https://api.github.com/users/unitystation","html_url":"https://github.com/unitystation","followers_url":"https://api.github.com/users/unitystation/followers","following_url":"https://api.github.com/users/unitystation/following{/other_user}","gists_url":"https://api.github.com/users/unitystation/gists{/gist_id}","starred_url":"https://api.github.com/users/unitystation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unitystation/subscriptions","organizations_url":"https://api.github.com/users/unitystation/orgs","repos_url":"https://api.github.com/users/unitystation/repos","events_url":"https://api.github.com/users/unitystation/events{/privacy}","received_events_url":"https://api.github.com/users/unitystation/received_events","type":"Organization","site_admin":false},"repo":{"id":72291379,"node_id":"MDEwOlJlcG9zaXRvcnk3MjI5MTM3OQ==","name":"unitystation","full_name":"unitystation/unitystation","private":false,"owner":{"login":"unitystation","id":23096507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDk2NTA3","avatar_url":"https://avatars1.githubusercontent.com/u/23096507?v=4","gravatar_id":"","url":"https://api.github.com/users/unitystation","html_url":"https://github.com/unitystation","followers_url":"https://api.github.com/users/unitystation/followers","following_url":"https://api.github.com/users/unitystation/following{/other_user}","gists_url":"https://api.github.com/users/unitystation/gists{/gist_id}","starred_url":"https://api.github.com/users/unitystation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unitystation/subscriptions","organizations_url":"https://api.github.com/users/unitystation/orgs","repos_url":"https://api.github.com/users/unitystation/repos","events_url":"https://api.github.com/users/unitystation/events{/privacy}","received_events_url":"https://api.github.com/users/unitystation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unitystation/unitystation","description":"The original unitystation","fork":false,"url":"https://api.github.com/repos/unitystation/unitystation","forks_url":"https://api.github.com/repos/unitystation/unitystation/forks","keys_url":"https://api.github.com/repos/unitystation/unitystation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unitystation/unitystation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unitystation/unitystation/teams","hooks_url":"https://api.github.com/repos/unitystation/unitystation/hooks","issue_events_url":"https://api.github.com/repos/unitystation/unitystation/issues/events{/number}","events_url":"https://api.github.com/repos/unitystation/unitystation/events","assignees_url":"https://api.github.com/repos/unitystation/unitystation/assignees{/user}","branches_url":"https://api.github.com/repos/unitystation/unitystation/branches{/branch}","tags_url":"https://api.github.com/repos/unitystation/unitystation/tags","blobs_url":"https://api.github.com/repos/unitystation/unitystation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unitystation/unitystation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unitystation/unitystation/git/refs{/sha}","trees_url":"https://api.github.com/repos/unitystation/unitystation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unitystation/unitystation/statuses/{sha}","languages_url":"https://api.github.com/repos/unitystation/unitystation/languages","stargazers_url":"https://api.github.com/repos/unitystation/unitystation/stargazers","contributors_url":"https://api.github.com/repos/unitystation/unitystation/contributors","subscribers_url":"https://api.github.com/repos/unitystation/unitystation/subscribers","subscription_url":"https://api.github.com/repos/unitystation/unitystation/subscription","commits_url":"https://api.github.com/repos/unitystation/unitystation/commits{/sha}","git_commits_url":"https://api.github.com/repos/unitystation/unitystation/git/commits{/sha}","comments_url":"https://api.github.com/repos/unitystation/unitystation/comments{/number}","issue_comment_url":"https://api.github.com/repos/unitystation/unitystation/issues/comments{/number}","contents_url":"https://api.github.com/repos/unitystation/unitystation/contents/{+path}","compare_url":"https://api.github.com/repos/unitystation/unitystation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unitystation/unitystation/merges","archive_url":"https://api.github.com/repos/unitystation/unitystation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unitystation/unitystation/downloads","issues_url":"https://api.github.com/repos/unitystation/unitystation/issues{/number}","pulls_url":"https://api.github.com/repos/unitystation/unitystation/pulls{/number}","milestones_url":"https://api.github.com/repos/unitystation/unitystation/milestones{/number}","notifications_url":"https://api.github.com/repos/unitystation/unitystation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unitystation/unitystation/labels{/name}","releases_url":"https://api.github.com/repos/unitystation/unitystation/releases{/id}","deployments_url":"https://api.github.com/repos/unitystation/unitystation/deployments","created_at":"2016-10-29T15:01:45Z","updated_at":"2020-01-12T16:27:57Z","pushed_at":"2020-01-12T16:27:53Z","git_url":"git://github.com/unitystation/unitystation.git","ssh_url":"git@github.com:unitystation/unitystation.git","clone_url":"https://github.com/unitystation/unitystation.git","svn_url":"https://github.com/unitystation/unitystation","homepage":"https://unitystation.org","size":586114,"stargazers_count":343,"watchers_count":343,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":309,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":203,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":309,"open_issues":203,"watchers":343,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/unitystation/unitystation/pulls/2586"},"html":{"href":"https://github.com/unitystation/unitystation/pull/2586"},"issue":{"href":"https://api.github.com/repos/unitystation/unitystation/issues/2586"},"comments":{"href":"https://api.github.com/repos/unitystation/unitystation/issues/2586/comments"},"review_comments":{"href":"https://api.github.com/repos/unitystation/unitystation/pulls/2586/comments"},"review_comment":{"href":"https://api.github.com/repos/unitystation/unitystation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unitystation/unitystation/pulls/2586/commits"},"statuses":{"href":"https://api.github.com/repos/unitystation/unitystation/statuses/fb010c2d52d353a22c7f153b56b8bd3bdf9ac121"}},"author_association":"MEMBER"}}
|
{
"id": 72291379,
"name": "unitystation/unitystation",
"url": "https://api.github.com/repos/unitystation/unitystation"
}
|
{
"id": 32009105,
"login": "JesterX666",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32009105?",
"url": "https://api.github.com/users/JesterX666"
}
|
{
"id": 23096507,
"login": "unitystation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23096507?",
"url": "https://api.github.com/orgs/unitystation"
}
| 2020-01-12T19:06:58 |
11256917162
|
{"actor":{"display_login":"JesterX666"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/YouClap/Playbook/pulls/comments/292437767","pull_request_review_id":248153493,"id":292437767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MjQzNzc2Nw==","diff_hunk":"@@ -0,0 +1,45 @@\n+\n+include:\n+ - remote: 'https://raw.githubusercontent.com/YouClap/Playbook/Backend/templates/gitlab-ci/master-gitlab-ci.yml'","path":"Backend/templates/gitlab-ci/example-gitlab-ci.yml","position":3,"original_position":3,"commit_id":"77a9e0e21618a197d86a57b0653c13ac3d6f9a4b","original_commit_id":"77a9e0e21618a197d86a57b0653c13ac3d6f9a4b","user":{"login":"tallnato","id":2511837,"node_id":"MDQ6VXNlcjI1MTE4Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2511837?v=4","gravatar_id":"","url":"https://api.github.com/users/tallnato","html_url":"https://github.com/tallnato","followers_url":"https://api.github.com/users/tallnato/followers","following_url":"https://api.github.com/users/tallnato/following{/other_user}","gists_url":"https://api.github.com/users/tallnato/gists{/gist_id}","starred_url":"https://api.github.com/users/tallnato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallnato/subscriptions","organizations_url":"https://api.github.com/users/tallnato/orgs","repos_url":"https://api.github.com/users/tallnato/repos","events_url":"https://api.github.com/users/tallnato/events{/privacy}","received_events_url":"https://api.github.com/users/tallnato/received_events","type":"User","site_admin":false},"body":"yes, it is waiting merge ","created_at":"2019-06-11T12:53:15Z","updated_at":"2019-06-11T12:53:15Z","html_url":"https://github.com/YouClap/Playbook/pull/5#discussion_r292437767","pull_request_url":"https://api.github.com/repos/YouClap/Playbook/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/YouClap/Playbook/pulls/comments/292437767"},"html":{"href":"https://github.com/YouClap/Playbook/pull/5#discussion_r292437767"},"pull_request":{"href":"https://api.github.com/repos/YouClap/Playbook/pulls/5"}},"in_reply_to_id":292405784},"pull_request":{"url":"https://api.github.com/repos/YouClap/Playbook/pulls/5","id":285846833,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1ODQ2ODMz","html_url":"https://github.com/YouClap/Playbook/pull/5","diff_url":"https://github.com/YouClap/Playbook/pull/5.diff","patch_url":"https://github.com/YouClap/Playbook/pull/5.patch","issue_url":"https://api.github.com/repos/YouClap/Playbook/issues/5","number":5,"state":"open","locked":false,"title":"Gitlal-CI files","user":{"login":"tallnato","id":2511837,"node_id":"MDQ6VXNlcjI1MTE4Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2511837?v=4","gravatar_id":"","url":"https://api.github.com/users/tallnato","html_url":"https://github.com/tallnato","followers_url":"https://api.github.com/users/tallnato/followers","following_url":"https://api.github.com/users/tallnato/following{/other_user}","gists_url":"https://api.github.com/users/tallnato/gists{/gist_id}","starred_url":"https://api.github.com/users/tallnato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallnato/subscriptions","organizations_url":"https://api.github.com/users/tallnato/orgs","repos_url":"https://api.github.com/users/tallnato/repos","events_url":"https://api.github.com/users/tallnato/events{/privacy}","received_events_url":"https://api.github.com/users/tallnato/received_events","type":"User","site_admin":false},"body":"* master - shared jobs and general structure\r\n* example - example file","created_at":"2019-06-06T15:07:25Z","updated_at":"2019-06-11T12:53:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6bd2f5ceb67883970afd84c9829daf0d563d492","assignee":null,"assignees":[],"requested_reviewers":[{"login":"portellaa","id":1502403,"node_id":"MDQ6VXNlcjE1MDI0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1502403?v=4","gravatar_id":"","url":"https://api.github.com/users/portellaa","html_url":"https://github.com/portellaa","followers_url":"https://api.github.com/users/portellaa/followers","following_url":"https://api.github.com/users/portellaa/following{/other_user}","gists_url":"https://api.github.com/users/portellaa/gists{/gist_id}","starred_url":"https://api.github.com/users/portellaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portellaa/subscriptions","organizations_url":"https://api.github.com/users/portellaa/orgs","repos_url":"https://api.github.com/users/portellaa/repos","events_url":"https://api.github.com/users/portellaa/events{/privacy}","received_events_url":"https://api.github.com/users/portellaa/received_events","type":"User","site_admin":false},{"login":"bmcfaria","id":5879297,"node_id":"MDQ6VXNlcjU4NzkyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5879297?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcfaria","html_url":"https://github.com/bmcfaria","followers_url":"https://api.github.com/users/bmcfaria/followers","following_url":"https://api.github.com/users/bmcfaria/following{/other_user}","gists_url":"https://api.github.com/users/bmcfaria/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfaria/subscriptions","organizations_url":"https://api.github.com/users/bmcfaria/orgs","repos_url":"https://api.github.com/users/bmcfaria/repos","events_url":"https://api.github.com/users/bmcfaria/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfaria/received_events","type":"User","site_admin":false},{"login":"hugomsilvam","id":7662201,"node_id":"MDQ6VXNlcjc2NjIyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7662201?v=4","gravatar_id":"","url":"https://api.github.com/users/hugomsilvam","html_url":"https://github.com/hugomsilvam","followers_url":"https://api.github.com/users/hugomsilvam/followers","following_url":"https://api.github.com/users/hugomsilvam/following{/other_user}","gists_url":"https://api.github.com/users/hugomsilvam/gists{/gist_id}","starred_url":"https://api.github.com/users/hugomsilvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugomsilvam/subscriptions","organizations_url":"https://api.github.com/users/hugomsilvam/orgs","repos_url":"https://api.github.com/users/hugomsilvam/repos","events_url":"https://api.github.com/users/hugomsilvam/events{/privacy}","received_events_url":"https://api.github.com/users/hugomsilvam/received_events","type":"User","site_admin":false},{"login":"xyxo45","id":38075300,"node_id":"MDQ6VXNlcjM4MDc1MzAw","avatar_url":"https://avatars1.githubusercontent.com/u/38075300?v=4","gravatar_id":"","url":"https://api.github.com/users/xyxo45","html_url":"https://github.com/xyxo45","followers_url":"https://api.github.com/users/xyxo45/followers","following_url":"https://api.github.com/users/xyxo45/following{/other_user}","gists_url":"https://api.github.com/users/xyxo45/gists{/gist_id}","starred_url":"https://api.github.com/users/xyxo45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xyxo45/subscriptions","organizations_url":"https://api.github.com/users/xyxo45/orgs","repos_url":"https://api.github.com/users/xyxo45/repos","events_url":"https://api.github.com/users/xyxo45/events{/privacy}","received_events_url":"https://api.github.com/users/xyxo45/received_events","type":"User","site_admin":false},{"login":"reinaldo89","id":38083439,"node_id":"MDQ6VXNlcjM4MDgzNDM5","avatar_url":"https://avatars2.githubusercontent.com/u/38083439?v=4","gravatar_id":"","url":"https://api.github.com/users/reinaldo89","html_url":"https://github.com/reinaldo89","followers_url":"https://api.github.com/users/reinaldo89/followers","following_url":"https://api.github.com/users/reinaldo89/following{/other_user}","gists_url":"https://api.github.com/users/reinaldo89/gists{/gist_id}","starred_url":"https://api.github.com/users/reinaldo89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinaldo89/subscriptions","organizations_url":"https://api.github.com/users/reinaldo89/orgs","repos_url":"https://api.github.com/users/reinaldo89/repos","events_url":"https://api.github.com/users/reinaldo89/events{/privacy}","received_events_url":"https://api.github.com/users/reinaldo89/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/YouClap/Playbook/pulls/5/commits","review_comments_url":"https://api.github.com/repos/YouClap/Playbook/pulls/5/comments","review_comment_url":"https://api.github.com/repos/YouClap/Playbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YouClap/Playbook/issues/5/comments","statuses_url":"https://api.github.com/repos/YouClap/Playbook/statuses/77a9e0e21618a197d86a57b0653c13ac3d6f9a4b","head":{"label":"YouClap:feature/gitlab-ci_files","ref":"feature/gitlab-ci_files","sha":"77a9e0e21618a197d86a57b0653c13ac3d6f9a4b","user":{"login":"YouClap","id":23167790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTY3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/23167790?v=4","gravatar_id":"","url":"https://api.github.com/users/YouClap","html_url":"https://github.com/YouClap","followers_url":"https://api.github.com/users/YouClap/followers","following_url":"https://api.github.com/users/YouClap/following{/other_user}","gists_url":"https://api.github.com/users/YouClap/gists{/gist_id}","starred_url":"https://api.github.com/users/YouClap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YouClap/subscriptions","organizations_url":"https://api.github.com/users/YouClap/orgs","repos_url":"https://api.github.com/users/YouClap/repos","events_url":"https://api.github.com/users/YouClap/events{/privacy}","received_events_url":"https://api.github.com/users/YouClap/received_events","type":"Organization","site_admin":false},"repo":{"id":187008601,"node_id":"MDEwOlJlcG9zaXRvcnkxODcwMDg2MDE=","name":"Playbook","full_name":"YouClap/Playbook","private":false,"owner":{"login":"YouClap","id":23167790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTY3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/23167790?v=4","gravatar_id":"","url":"https://api.github.com/users/YouClap","html_url":"https://github.com/YouClap","followers_url":"https://api.github.com/users/YouClap/followers","following_url":"https://api.github.com/users/YouClap/following{/other_user}","gists_url":"https://api.github.com/users/YouClap/gists{/gist_id}","starred_url":"https://api.github.com/users/YouClap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YouClap/subscriptions","organizations_url":"https://api.github.com/users/YouClap/orgs","repos_url":"https://api.github.com/users/YouClap/repos","events_url":"https://api.github.com/users/YouClap/events{/privacy}","received_events_url":"https://api.github.com/users/YouClap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/YouClap/Playbook","description":null,"fork":false,"url":"https://api.github.com/repos/YouClap/Playbook","forks_url":"https://api.github.com/repos/YouClap/Playbook/forks","keys_url":"https://api.github.com/repos/YouClap/Playbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YouClap/Playbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YouClap/Playbook/teams","hooks_url":"https://api.github.com/repos/YouClap/Playbook/hooks","issue_events_url":"https://api.github.com/repos/YouClap/Playbook/issues/events{/number}","events_url":"https://api.github.com/repos/YouClap/Playbook/events","assignees_url":"https://api.github.com/repos/YouClap/Playbook/assignees{/user}","branches_url":"https://api.github.com/repos/YouClap/Playbook/branches{/branch}","tags_url":"https://api.github.com/repos/YouClap/Playbook/tags","blobs_url":"https://api.github.com/repos/YouClap/Playbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YouClap/Playbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YouClap/Playbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/YouClap/Playbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YouClap/Playbook/statuses/{sha}","languages_url":"https://api.github.com/repos/YouClap/Playbook/languages","stargazers_url":"https://api.github.com/repos/YouClap/Playbook/stargazers","contributors_url":"https://api.github.com/repos/YouClap/Playbook/contributors","subscribers_url":"https://api.github.com/repos/YouClap/Playbook/subscribers","subscription_url":"https://api.github.com/repos/YouClap/Playbook/subscription","commits_url":"https://api.github.com/repos/YouClap/Playbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/YouClap/Playbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/YouClap/Playbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/YouClap/Playbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/YouClap/Playbook/contents/{+path}","compare_url":"https://api.github.com/repos/YouClap/Playbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YouClap/Playbook/merges","archive_url":"https://api.github.com/repos/YouClap/Playbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YouClap/Playbook/downloads","issues_url":"https://api.github.com/repos/YouClap/Playbook/issues{/number}","pulls_url":"https://api.github.com/repos/YouClap/Playbook/pulls{/number}","milestones_url":"https://api.github.com/repos/YouClap/Playbook/milestones{/number}","notifications_url":"https://api.github.com/repos/YouClap/Playbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YouClap/Playbook/labels{/name}","releases_url":"https://api.github.com/repos/YouClap/Playbook/releases{/id}","deployments_url":"https://api.github.com/repos/YouClap/Playbook/deployments","created_at":"2019-05-16T10:48:01Z","updated_at":"2019-06-03T14:52:55Z","pushed_at":"2019-06-07T16:35:29Z","git_url":"git://github.com/YouClap/Playbook.git","ssh_url":"git@github.com:YouClap/Playbook.git","clone_url":"https://github.com/YouClap/Playbook.git","svn_url":"https://github.com/YouClap/Playbook","homepage":null,"size":143,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"YouClap:master","ref":"master","sha":"e252762149cd58ac749b3242c15a74bad70fd14b","user":{"login":"YouClap","id":23167790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTY3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/23167790?v=4","gravatar_id":"","url":"https://api.github.com/users/YouClap","html_url":"https://github.com/YouClap","followers_url":"https://api.github.com/users/YouClap/followers","following_url":"https://api.github.com/users/YouClap/following{/other_user}","gists_url":"https://api.github.com/users/YouClap/gists{/gist_id}","starred_url":"https://api.github.com/users/YouClap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YouClap/subscriptions","organizations_url":"https://api.github.com/users/YouClap/orgs","repos_url":"https://api.github.com/users/YouClap/repos","events_url":"https://api.github.com/users/YouClap/events{/privacy}","received_events_url":"https://api.github.com/users/YouClap/received_events","type":"Organization","site_admin":false},"repo":{"id":187008601,"node_id":"MDEwOlJlcG9zaXRvcnkxODcwMDg2MDE=","name":"Playbook","full_name":"YouClap/Playbook","private":false,"owner":{"login":"YouClap","id":23167790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTY3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/23167790?v=4","gravatar_id":"","url":"https://api.github.com/users/YouClap","html_url":"https://github.com/YouClap","followers_url":"https://api.github.com/users/YouClap/followers","following_url":"https://api.github.com/users/YouClap/following{/other_user}","gists_url":"https://api.github.com/users/YouClap/gists{/gist_id}","starred_url":"https://api.github.com/users/YouClap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YouClap/subscriptions","organizations_url":"https://api.github.com/users/YouClap/orgs","repos_url":"https://api.github.com/users/YouClap/repos","events_url":"https://api.github.com/users/YouClap/events{/privacy}","received_events_url":"https://api.github.com/users/YouClap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/YouClap/Playbook","description":null,"fork":false,"url":"https://api.github.com/repos/YouClap/Playbook","forks_url":"https://api.github.com/repos/YouClap/Playbook/forks","keys_url":"https://api.github.com/repos/YouClap/Playbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YouClap/Playbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YouClap/Playbook/teams","hooks_url":"https://api.github.com/repos/YouClap/Playbook/hooks","issue_events_url":"https://api.github.com/repos/YouClap/Playbook/issues/events{/number}","events_url":"https://api.github.com/repos/YouClap/Playbook/events","assignees_url":"https://api.github.com/repos/YouClap/Playbook/assignees{/user}","branches_url":"https://api.github.com/repos/YouClap/Playbook/branches{/branch}","tags_url":"https://api.github.com/repos/YouClap/Playbook/tags","blobs_url":"https://api.github.com/repos/YouClap/Playbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YouClap/Playbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YouClap/Playbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/YouClap/Playbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YouClap/Playbook/statuses/{sha}","languages_url":"https://api.github.com/repos/YouClap/Playbook/languages","stargazers_url":"https://api.github.com/repos/YouClap/Playbook/stargazers","contributors_url":"https://api.github.com/repos/YouClap/Playbook/contributors","subscribers_url":"https://api.github.com/repos/YouClap/Playbook/subscribers","subscription_url":"https://api.github.com/repos/YouClap/Playbook/subscription","commits_url":"https://api.github.com/repos/YouClap/Playbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/YouClap/Playbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/YouClap/Playbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/YouClap/Playbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/YouClap/Playbook/contents/{+path}","compare_url":"https://api.github.com/repos/YouClap/Playbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YouClap/Playbook/merges","archive_url":"https://api.github.com/repos/YouClap/Playbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YouClap/Playbook/downloads","issues_url":"https://api.github.com/repos/YouClap/Playbook/issues{/number}","pulls_url":"https://api.github.com/repos/YouClap/Playbook/pulls{/number}","milestones_url":"https://api.github.com/repos/YouClap/Playbook/milestones{/number}","notifications_url":"https://api.github.com/repos/YouClap/Playbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YouClap/Playbook/labels{/name}","releases_url":"https://api.github.com/repos/YouClap/Playbook/releases{/id}","deployments_url":"https://api.github.com/repos/YouClap/Playbook/deployments","created_at":"2019-05-16T10:48:01Z","updated_at":"2019-06-03T14:52:55Z","pushed_at":"2019-06-07T16:35:29Z","git_url":"git://github.com/YouClap/Playbook.git","ssh_url":"git@github.com:YouClap/Playbook.git","clone_url":"https://github.com/YouClap/Playbook.git","svn_url":"https://github.com/YouClap/Playbook","homepage":null,"size":143,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YouClap/Playbook/pulls/5"},"html":{"href":"https://github.com/YouClap/Playbook/pull/5"},"issue":{"href":"https://api.github.com/repos/YouClap/Playbook/issues/5"},"comments":{"href":"https://api.github.com/repos/YouClap/Playbook/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/YouClap/Playbook/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/YouClap/Playbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YouClap/Playbook/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/YouClap/Playbook/statuses/77a9e0e21618a197d86a57b0653c13ac3d6f9a4b"}},"author_association":"MEMBER"}}
|
{
"id": 187008601,
"name": "YouClap/Playbook",
"url": "https://api.github.com/repos/YouClap/Playbook"
}
|
{
"id": 2511837,
"login": "tallnato",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2511837?",
"url": "https://api.github.com/users/tallnato"
}
|
{
"id": 23167790,
"login": "YouClap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23167790?",
"url": "https://api.github.com/orgs/YouClap"
}
| 2019-06-11T12:53:15 |
9798654801
|
{"actor":{"display_login":"tallnato"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chainer/chainerrl/pulls/comments/303494012","pull_request_review_id":261895747,"id":303494012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzQ5NDAxMg==","diff_hunk":"@@ -0,0 +1,119 @@\n+from __future__ import print_function\n+from __future__ import division\n+from __future__ import unicode_literals\n+from __future__ import absolute_import\n+from builtins import * # NOQA\n+from future import standard_library\n+standard_library.install_aliases() # NOQA\n+import argparse\n+import os\n+\n+from chainer import links as L\n+from chainer import optimizers\n+import gym\n+import gym.wrappers\n+import numpy as np\n+\n+import chainerrl\n+from chainerrl.action_value import DiscreteActionValue\n+from chainerrl import agents\n+from chainerrl import experiments\n+from chainerrl import links\n+from chainerrl import misc\n+from chainerrl import replay_buffer\n+\n+from chainerrl.wrappers import atari_wrappers\n+\n+\n+def main():\n+ parser = argparse.ArgumentParser()\n+ parser.add_argument('--env', type=str, default='BreakoutNoFrameskip-v4',\n+ help='OpenAI Atari domain to perform algorithm on.')\n+ parser.add_argument('--outdir', type=str, default='results',\n+ help='Directory path to save output files.'\n+ ' If it does not exist, it will be created.')\n+ parser.add_argument('--seed', type=int, default=0,\n+ help='Random seed [0, 2 ** 31)')\n+ parser.add_argument('--gpu', type=int, default=0,\n+ help='GPU to use, set to -1 if no GPU.')\n+ parser.add_argument('--load', type=str, default=None, required=True)\n+ parser.add_argument('--logging-level', type=int, default=20,\n+ help='Logging level. 10:DEBUG, 20:INFO etc.')\n+ parser.add_argument('--render', action='store_true', default=False,\n+ help='Render env states in a GUI window.')\n+ parser.add_argument('--monitor', action='store_true', default=False,\n+ help='Monitor env. Videos and additional information'\n+ ' are saved as output files.')\n+ parser.add_argument('--steps', type=int, default=5 * 10 ** 7,\n+ help='Total number of demo timesteps to collect')\n+ args = parser.parse_args()\n+\n+ import logging\n+ logging.basicConfig(level=args.logging_level)\n+\n+ # Set a random seed used in ChainerRL.\n+ misc.set_random_seed(args.seed, gpus=(args.gpu,))\n+\n+ args.outdir = experiments.prepare_output_dir(args, args.outdir)\n+ print('Output files are saved in {}'.format(args.outdir))\n+\n+ def make_env():\n+ env = atari_wrappers.wrap_deepmind(\n+ atari_wrappers.make_atari(args.env, max_frames=None),\n+ episode_life=False,\n+ clip_rewards=False)\n+ env.seed(int(args.seed))\n+ # Randomize actions like epsilon-greedy\n+ env = chainerrl.wrappers.RandomizeAction(env, 0.01)","path":"examples/atari/collect_demos_ale.py","position":67,"original_position":67,"commit_id":"b7a7393131529cb6d8bbcdd529f67823e0b1d62c","original_commit_id":"b7a7393131529cb6d8bbcdd529f67823e0b1d62c","user":{"login":"prabhatnagarajan","id":10005453,"node_id":"MDQ6VXNlcjEwMDA1NDUz","avatar_url":"https://avatars3.githubusercontent.com/u/10005453?v=4","gravatar_id":"","url":"https://api.github.com/users/prabhatnagarajan","html_url":"https://github.com/prabhatnagarajan","followers_url":"https://api.github.com/users/prabhatnagarajan/followers","following_url":"https://api.github.com/users/prabhatnagarajan/following{/other_user}","gists_url":"https://api.github.com/users/prabhatnagarajan/gists{/gist_id}","starred_url":"https://api.github.com/users/prabhatnagarajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabhatnagarajan/subscriptions","organizations_url":"https://api.github.com/users/prabhatnagarajan/orgs","repos_url":"https://api.github.com/users/prabhatnagarajan/repos","events_url":"https://api.github.com/users/prabhatnagarajan/events{/privacy}","received_events_url":"https://api.github.com/users/prabhatnagarajan/received_events","type":"User","site_admin":false},"body":"Yes. We wouldn't want to collect demonstrations that are identical in a deterministic env.","created_at":"2019-07-15T15:22:14Z","updated_at":"2019-07-15T15:22:14Z","html_url":"https://github.com/chainer/chainerrl/pull/468#discussion_r303494012","pull_request_url":"https://api.github.com/repos/chainer/chainerrl/pulls/468","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chainer/chainerrl/pulls/comments/303494012"},"html":{"href":"https://github.com/chainer/chainerrl/pull/468#discussion_r303494012"},"pull_request":{"href":"https://api.github.com/repos/chainer/chainerrl/pulls/468"}},"in_reply_to_id":303467229},"pull_request":{"url":"https://api.github.com/repos/chainer/chainerrl/pulls/468","id":284973745,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0OTczNzQ1","html_url":"https://github.com/chainer/chainerrl/pull/468","diff_url":"https://github.com/chainer/chainerrl/pull/468.diff","patch_url":"https://github.com/chainer/chainerrl/pull/468.patch","issue_url":"https://api.github.com/repos/chainer/chainerrl/issues/468","number":468,"state":"open","locked":false,"title":"Code to collect demonstrations from an agent.","user":{"login":"prabhatnagarajan","id":10005453,"node_id":"MDQ6VXNlcjEwMDA1NDUz","avatar_url":"https://avatars3.githubusercontent.com/u/10005453?v=4","gravatar_id":"","url":"https://api.github.com/users/prabhatnagarajan","html_url":"https://github.com/prabhatnagarajan","followers_url":"https://api.github.com/users/prabhatnagarajan/followers","following_url":"https://api.github.com/users/prabhatnagarajan/following{/other_user}","gists_url":"https://api.github.com/users/prabhatnagarajan/gists{/gist_id}","starred_url":"https://api.github.com/users/prabhatnagarajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabhatnagarajan/subscriptions","organizations_url":"https://api.github.com/users/prabhatnagarajan/orgs","repos_url":"https://api.github.com/users/prabhatnagarajan/repos","events_url":"https://api.github.com/users/prabhatnagarajan/events{/privacy}","received_events_url":"https://api.github.com/users/prabhatnagarajan/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-04T13:27:48Z","updated_at":"2019-07-15T15:22:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31787f52e093daba70456d57c6575fc1198493e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ummavi","id":6052050,"node_id":"MDQ6VXNlcjYwNTIwNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6052050?v=4","gravatar_id":"","url":"https://api.github.com/users/ummavi","html_url":"https://github.com/ummavi","followers_url":"https://api.github.com/users/ummavi/followers","following_url":"https://api.github.com/users/ummavi/following{/other_user}","gists_url":"https://api.github.com/users/ummavi/gists{/gist_id}","starred_url":"https://api.github.com/users/ummavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ummavi/subscriptions","organizations_url":"https://api.github.com/users/ummavi/orgs","repos_url":"https://api.github.com/users/ummavi/repos","events_url":"https://api.github.com/users/ummavi/events{/privacy}","received_events_url":"https://api.github.com/users/ummavi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/chainer/chainerrl/milestones/6","html_url":"https://github.com/chainer/chainerrl/milestone/6","labels_url":"https://api.github.com/repos/chainer/chainerrl/milestones/6/labels","id":4407922,"node_id":"MDk6TWlsZXN0b25lNDQwNzkyMg==","number":6,"title":"v0.8","description":"","creator":{"login":"muupan","id":815970,"node_id":"MDQ6VXNlcjgxNTk3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/815970?v=4","gravatar_id":"","url":"https://api.github.com/users/muupan","html_url":"https://github.com/muupan","followers_url":"https://api.github.com/users/muupan/followers","following_url":"https://api.github.com/users/muupan/following{/other_user}","gists_url":"https://api.github.com/users/muupan/gists{/gist_id}","starred_url":"https://api.github.com/users/muupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muupan/subscriptions","organizations_url":"https://api.github.com/users/muupan/orgs","repos_url":"https://api.github.com/users/muupan/repos","events_url":"https://api.github.com/users/muupan/events{/privacy}","received_events_url":"https://api.github.com/users/muupan/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2019-06-14T06:00:21Z","updated_at":"2019-07-09T11:11:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/chainer/chainerrl/pulls/468/commits","review_comments_url":"https://api.github.com/repos/chainer/chainerrl/pulls/468/comments","review_comment_url":"https://api.github.com/repos/chainer/chainerrl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chainer/chainerrl/issues/468/comments","statuses_url":"https://api.github.com/repos/chainer/chainerrl/statuses/b7a7393131529cb6d8bbcdd529f67823e0b1d62c","head":{"label":"prabhatnagarajan:demo_collection","ref":"demo_collection","sha":"b7a7393131529cb6d8bbcdd529f67823e0b1d62c","user":{"login":"prabhatnagarajan","id":10005453,"node_id":"MDQ6VXNlcjEwMDA1NDUz","avatar_url":"https://avatars3.githubusercontent.com/u/10005453?v=4","gravatar_id":"","url":"https://api.github.com/users/prabhatnagarajan","html_url":"https://github.com/prabhatnagarajan","followers_url":"https://api.github.com/users/prabhatnagarajan/followers","following_url":"https://api.github.com/users/prabhatnagarajan/following{/other_user}","gists_url":"https://api.github.com/users/prabhatnagarajan/gists{/gist_id}","starred_url":"https://api.github.com/users/prabhatnagarajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabhatnagarajan/subscriptions","organizations_url":"https://api.github.com/users/prabhatnagarajan/orgs","repos_url":"https://api.github.com/users/prabhatnagarajan/repos","events_url":"https://api.github.com/users/prabhatnagarajan/events{/privacy}","received_events_url":"https://api.github.com/users/prabhatnagarajan/received_events","type":"User","site_admin":false},"repo":{"id":147777923,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3Nzc5MjM=","name":"chainerrl","full_name":"prabhatnagarajan/chainerrl","private":false,"owner":{"login":"prabhatnagarajan","id":10005453,"node_id":"MDQ6VXNlcjEwMDA1NDUz","avatar_url":"https://avatars3.githubusercontent.com/u/10005453?v=4","gravatar_id":"","url":"https://api.github.com/users/prabhatnagarajan","html_url":"https://github.com/prabhatnagarajan","followers_url":"https://api.github.com/users/prabhatnagarajan/followers","following_url":"https://api.github.com/users/prabhatnagarajan/following{/other_user}","gists_url":"https://api.github.com/users/prabhatnagarajan/gists{/gist_id}","starred_url":"https://api.github.com/users/prabhatnagarajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabhatnagarajan/subscriptions","organizations_url":"https://api.github.com/users/prabhatnagarajan/orgs","repos_url":"https://api.github.com/users/prabhatnagarajan/repos","events_url":"https://api.github.com/users/prabhatnagarajan/events{/privacy}","received_events_url":"https://api.github.com/users/prabhatnagarajan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/prabhatnagarajan/chainerrl","description":"ChainerRL is a deep reinforcement learning library built on top of Chainer.","fork":true,"url":"https://api.github.com/repos/prabhatnagarajan/chainerrl","forks_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/forks","keys_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/teams","hooks_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/hooks","issue_events_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/issues/events{/number}","events_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/events","assignees_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/assignees{/user}","branches_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/branches{/branch}","tags_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/tags","blobs_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/git/refs{/sha}","trees_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/statuses/{sha}","languages_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/languages","stargazers_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/stargazers","contributors_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/contributors","subscribers_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/subscribers","subscription_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/subscription","commits_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/commits{/sha}","git_commits_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/git/commits{/sha}","comments_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/comments{/number}","issue_comment_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/issues/comments{/number}","contents_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/contents/{+path}","compare_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/merges","archive_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/downloads","issues_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/issues{/number}","pulls_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/pulls{/number}","milestones_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/milestones{/number}","notifications_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/labels{/name}","releases_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/releases{/id}","deployments_url":"https://api.github.com/repos/prabhatnagarajan/chainerrl/deployments","created_at":"2018-09-07T06:01:54Z","updated_at":"2019-07-08T12:24:08Z","pushed_at":"2019-07-09T11:49:20Z","git_url":"git://github.com/prabhatnagarajan/chainerrl.git","ssh_url":"git@github.com:prabhatnagarajan/chainerrl.git","clone_url":"https://github.com/prabhatnagarajan/chainerrl.git","svn_url":"https://github.com/prabhatnagarajan/chainerrl","homepage":"","size":10689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chainer:master","ref":"master","sha":"eb12de67a8eefa5a0359bbf4790c89dd04d735a4","user":{"login":"chainer","id":23183003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTgzMDAz","avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"repo":{"id":80394882,"node_id":"MDEwOlJlcG9zaXRvcnk4MDM5NDg4Mg==","name":"chainerrl","full_name":"chainer/chainerrl","private":false,"owner":{"login":"chainer","id":23183003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTgzMDAz","avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chainer/chainerrl","description":"ChainerRL is a deep reinforcement learning library built on top of Chainer.","fork":false,"url":"https://api.github.com/repos/chainer/chainerrl","forks_url":"https://api.github.com/repos/chainer/chainerrl/forks","keys_url":"https://api.github.com/repos/chainer/chainerrl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chainer/chainerrl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chainer/chainerrl/teams","hooks_url":"https://api.github.com/repos/chainer/chainerrl/hooks","issue_events_url":"https://api.github.com/repos/chainer/chainerrl/issues/events{/number}","events_url":"https://api.github.com/repos/chainer/chainerrl/events","assignees_url":"https://api.github.com/repos/chainer/chainerrl/assignees{/user}","branches_url":"https://api.github.com/repos/chainer/chainerrl/branches{/branch}","tags_url":"https://api.github.com/repos/chainer/chainerrl/tags","blobs_url":"https://api.github.com/repos/chainer/chainerrl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chainer/chainerrl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chainer/chainerrl/git/refs{/sha}","trees_url":"https://api.github.com/repos/chainer/chainerrl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chainer/chainerrl/statuses/{sha}","languages_url":"https://api.github.com/repos/chainer/chainerrl/languages","stargazers_url":"https://api.github.com/repos/chainer/chainerrl/stargazers","contributors_url":"https://api.github.com/repos/chainer/chainerrl/contributors","subscribers_url":"https://api.github.com/repos/chainer/chainerrl/subscribers","subscription_url":"https://api.github.com/repos/chainer/chainerrl/subscription","commits_url":"https://api.github.com/repos/chainer/chainerrl/commits{/sha}","git_commits_url":"https://api.github.com/repos/chainer/chainerrl/git/commits{/sha}","comments_url":"https://api.github.com/repos/chainer/chainerrl/comments{/number}","issue_comment_url":"https://api.github.com/repos/chainer/chainerrl/issues/comments{/number}","contents_url":"https://api.github.com/repos/chainer/chainerrl/contents/{+path}","compare_url":"https://api.github.com/repos/chainer/chainerrl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chainer/chainerrl/merges","archive_url":"https://api.github.com/repos/chainer/chainerrl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chainer/chainerrl/downloads","issues_url":"https://api.github.com/repos/chainer/chainerrl/issues{/number}","pulls_url":"https://api.github.com/repos/chainer/chainerrl/pulls{/number}","milestones_url":"https://api.github.com/repos/chainer/chainerrl/milestones{/number}","notifications_url":"https://api.github.com/repos/chainer/chainerrl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chainer/chainerrl/labels{/name}","releases_url":"https://api.github.com/repos/chainer/chainerrl/releases{/id}","deployments_url":"https://api.github.com/repos/chainer/chainerrl/deployments","created_at":"2017-01-30T04:58:15Z","updated_at":"2019-07-14T17:49:21Z","pushed_at":"2019-07-09T11:08:21Z","git_url":"git://github.com/chainer/chainerrl.git","ssh_url":"git@github.com:chainer/chainerrl.git","clone_url":"https://github.com/chainer/chainerrl.git","svn_url":"https://github.com/chainer/chainerrl","homepage":"","size":10539,"stargazers_count":686,"watchers_count":686,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":93,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":170,"open_issues":93,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chainer/chainerrl/pulls/468"},"html":{"href":"https://github.com/chainer/chainerrl/pull/468"},"issue":{"href":"https://api.github.com/repos/chainer/chainerrl/issues/468"},"comments":{"href":"https://api.github.com/repos/chainer/chainerrl/issues/468/comments"},"review_comments":{"href":"https://api.github.com/repos/chainer/chainerrl/pulls/468/comments"},"review_comment":{"href":"https://api.github.com/repos/chainer/chainerrl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chainer/chainerrl/pulls/468/commits"},"statuses":{"href":"https://api.github.com/repos/chainer/chainerrl/statuses/b7a7393131529cb6d8bbcdd529f67823e0b1d62c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 80394882,
"name": "chainer/chainerrl",
"url": "https://api.github.com/repos/chainer/chainerrl"
}
|
{
"id": 10005453,
"login": "prabhatnagarajan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10005453?",
"url": "https://api.github.com/users/prabhatnagarajan"
}
|
{
"id": 23183003,
"login": "chainer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23183003?",
"url": "https://api.github.com/orgs/chainer"
}
| 2019-07-15T15:22:14 |
10013514448
|
{"actor":{"display_login":"prabhatnagarajan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cupy/cupy/pulls/comments/311744392","pull_request_review_id":272205414,"id":311744392,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTc0NDM5Mg==","diff_hunk":"@@ -181,6 +181,74 @@ def test_external_std_axis_ddof(self, xp, dtype):\n return xp.std(a, axis=1, ddof=1)\n \n \n+@testing.parameterize(\n+ *testing.product({\n+ 'shape': [(3, 4), (30, 40, 50)],\n+ 'axis': [None, 0, 1],\n+ 'keepdims': [True, False]\n+ })\n+)\n+@testing.gpu\n+class TestNanMean(unittest.TestCase):\n+\n+ @testing.for_all_dtypes(no_float16=True)\n+ @testing.numpy_cupy_allclose(rtol=1e-6)\n+ def test_nanmean_without_nan(self, xp, dtype):\n+ a = testing.shaped_random(self.shape, xp, dtype)\n+ return xp.nanmean(a, axis=self.axis, keepdims=self.keepdims)\n+\n+ @testing.for_all_dtypes(no_float16=True)\n+ @testing.numpy_cupy_allclose(rtol=1e-6)\n+ def test_nanmean_with_nan_float(self, xp, dtype):\n+ a = testing.shaped_random(self.shape, xp, dtype)\n+\n+ if a.dtype.kind not in 'biu':\n+ a[1, :] = xp.nan\n+ a[:, 3] = xp.nan\n+\n+ return xp.nanmean(a, axis=self.axis, keepdims=self.keepdims)","path":"tests/cupy_tests/statics_tests/test_meanvar.py","position":45,"original_position":29,"commit_id":"ec85154c04274ac1558aea0f84a1237dc006b77b","original_commit_id":"f96a55e0a06c4970aa879a814abb67eb8a91ea65","user":{"login":"Piyush-555","id":34499999,"node_id":"MDQ6VXNlcjM0NDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/34499999?v=4","gravatar_id":"","url":"https://api.github.com/users/Piyush-555","html_url":"https://github.com/Piyush-555","followers_url":"https://api.github.com/users/Piyush-555/followers","following_url":"https://api.github.com/users/Piyush-555/following{/other_user}","gists_url":"https://api.github.com/users/Piyush-555/gists{/gist_id}","starred_url":"https://api.github.com/users/Piyush-555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piyush-555/subscriptions","organizations_url":"https://api.github.com/users/Piyush-555/orgs","repos_url":"https://api.github.com/users/Piyush-555/repos","events_url":"https://api.github.com/users/Piyush-555/events{/privacy}","received_events_url":"https://api.github.com/users/Piyush-555/received_events","type":"User","site_admin":false},"body":"Done. Also for `cupy.nanvar` and `cupy.nanstd` tests.","created_at":"2019-08-07T20:17:49Z","updated_at":"2019-08-07T20:17:49Z","html_url":"https://github.com/cupy/cupy/pull/2319#discussion_r311744392","pull_request_url":"https://api.github.com/repos/cupy/cupy/pulls/2319","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cupy/cupy/pulls/comments/311744392"},"html":{"href":"https://github.com/cupy/cupy/pull/2319#discussion_r311744392"},"pull_request":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2319"}},"in_reply_to_id":311336138},"pull_request":{"url":"https://api.github.com/repos/cupy/cupy/pulls/2319","id":299550119,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NTUwMTE5","html_url":"https://github.com/cupy/cupy/pull/2319","diff_url":"https://github.com/cupy/cupy/pull/2319.diff","patch_url":"https://github.com/cupy/cupy/pull/2319.patch","issue_url":"https://api.github.com/repos/cupy/cupy/issues/2319","number":2319,"state":"open","locked":false,"title":"Add `cupy.nanmean`","user":{"login":"Piyush-555","id":34499999,"node_id":"MDQ6VXNlcjM0NDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/34499999?v=4","gravatar_id":"","url":"https://api.github.com/users/Piyush-555","html_url":"https://github.com/Piyush-555","followers_url":"https://api.github.com/users/Piyush-555/followers","following_url":"https://api.github.com/users/Piyush-555/following{/other_user}","gists_url":"https://api.github.com/users/Piyush-555/gists{/gist_id}","starred_url":"https://api.github.com/users/Piyush-555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piyush-555/subscriptions","organizations_url":"https://api.github.com/users/Piyush-555/orgs","repos_url":"https://api.github.com/users/Piyush-555/repos","events_url":"https://api.github.com/users/Piyush-555/events{/privacy}","received_events_url":"https://api.github.com/users/Piyush-555/received_events","type":"User","site_admin":false},"body":"This PR partially resolves #2295","created_at":"2019-07-20T09:13:08Z","updated_at":"2019-08-07T20:17:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0d07b9e981b548100e530fe2c4541e375b817f1","assignee":{"login":"asi1024","id":5086403,"node_id":"MDQ6VXNlcjUwODY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5086403?v=4","gravatar_id":"","url":"https://api.github.com/users/asi1024","html_url":"https://github.com/asi1024","followers_url":"https://api.github.com/users/asi1024/followers","following_url":"https://api.github.com/users/asi1024/following{/other_user}","gists_url":"https://api.github.com/users/asi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/asi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi1024/subscriptions","organizations_url":"https://api.github.com/users/asi1024/orgs","repos_url":"https://api.github.com/users/asi1024/repos","events_url":"https://api.github.com/users/asi1024/events{/privacy}","received_events_url":"https://api.github.com/users/asi1024/received_events","type":"User","site_admin":false},"assignees":[{"login":"asi1024","id":5086403,"node_id":"MDQ6VXNlcjUwODY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5086403?v=4","gravatar_id":"","url":"https://api.github.com/users/asi1024","html_url":"https://github.com/asi1024","followers_url":"https://api.github.com/users/asi1024/followers","following_url":"https://api.github.com/users/asi1024/following{/other_user}","gists_url":"https://api.github.com/users/asi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/asi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi1024/subscriptions","organizations_url":"https://api.github.com/users/asi1024/orgs","repos_url":"https://api.github.com/users/asi1024/repos","events_url":"https://api.github.com/users/asi1024/events{/privacy}","received_events_url":"https://api.github.com/users/asi1024/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":545923268,"node_id":"MDU6TGFiZWw1NDU5MjMyNjg=","url":"https://api.github.com/repos/cupy/cupy/labels/cat:feature","name":"cat:feature","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cupy/cupy/pulls/2319/commits","review_comments_url":"https://api.github.com/repos/cupy/cupy/pulls/2319/comments","review_comment_url":"https://api.github.com/repos/cupy/cupy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cupy/cupy/issues/2319/comments","statuses_url":"https://api.github.com/repos/cupy/cupy/statuses/ec85154c04274ac1558aea0f84a1237dc006b77b","head":{"label":"Piyush-555:nanmean","ref":"nanmean","sha":"ec85154c04274ac1558aea0f84a1237dc006b77b","user":{"login":"Piyush-555","id":34499999,"node_id":"MDQ6VXNlcjM0NDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/34499999?v=4","gravatar_id":"","url":"https://api.github.com/users/Piyush-555","html_url":"https://github.com/Piyush-555","followers_url":"https://api.github.com/users/Piyush-555/followers","following_url":"https://api.github.com/users/Piyush-555/following{/other_user}","gists_url":"https://api.github.com/users/Piyush-555/gists{/gist_id}","starred_url":"https://api.github.com/users/Piyush-555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piyush-555/subscriptions","organizations_url":"https://api.github.com/users/Piyush-555/orgs","repos_url":"https://api.github.com/users/Piyush-555/repos","events_url":"https://api.github.com/users/Piyush-555/events{/privacy}","received_events_url":"https://api.github.com/users/Piyush-555/received_events","type":"User","site_admin":false},"repo":{"id":189351363,"node_id":"MDEwOlJlcG9zaXRvcnkxODkzNTEzNjM=","name":"cupy","full_name":"Piyush-555/cupy","private":false,"owner":{"login":"Piyush-555","id":34499999,"node_id":"MDQ6VXNlcjM0NDk5OTk5","avatar_url":"https://avatars2.githubusercontent.com/u/34499999?v=4","gravatar_id":"","url":"https://api.github.com/users/Piyush-555","html_url":"https://github.com/Piyush-555","followers_url":"https://api.github.com/users/Piyush-555/followers","following_url":"https://api.github.com/users/Piyush-555/following{/other_user}","gists_url":"https://api.github.com/users/Piyush-555/gists{/gist_id}","starred_url":"https://api.github.com/users/Piyush-555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piyush-555/subscriptions","organizations_url":"https://api.github.com/users/Piyush-555/orgs","repos_url":"https://api.github.com/users/Piyush-555/repos","events_url":"https://api.github.com/users/Piyush-555/events{/privacy}","received_events_url":"https://api.github.com/users/Piyush-555/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Piyush-555/cupy","description":"NumPy-like API accelerated with CUDA","fork":true,"url":"https://api.github.com/repos/Piyush-555/cupy","forks_url":"https://api.github.com/repos/Piyush-555/cupy/forks","keys_url":"https://api.github.com/repos/Piyush-555/cupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Piyush-555/cupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Piyush-555/cupy/teams","hooks_url":"https://api.github.com/repos/Piyush-555/cupy/hooks","issue_events_url":"https://api.github.com/repos/Piyush-555/cupy/issues/events{/number}","events_url":"https://api.github.com/repos/Piyush-555/cupy/events","assignees_url":"https://api.github.com/repos/Piyush-555/cupy/assignees{/user}","branches_url":"https://api.github.com/repos/Piyush-555/cupy/branches{/branch}","tags_url":"https://api.github.com/repos/Piyush-555/cupy/tags","blobs_url":"https://api.github.com/repos/Piyush-555/cupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Piyush-555/cupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Piyush-555/cupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Piyush-555/cupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Piyush-555/cupy/statuses/{sha}","languages_url":"https://api.github.com/repos/Piyush-555/cupy/languages","stargazers_url":"https://api.github.com/repos/Piyush-555/cupy/stargazers","contributors_url":"https://api.github.com/repos/Piyush-555/cupy/contributors","subscribers_url":"https://api.github.com/repos/Piyush-555/cupy/subscribers","subscription_url":"https://api.github.com/repos/Piyush-555/cupy/subscription","commits_url":"https://api.github.com/repos/Piyush-555/cupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Piyush-555/cupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Piyush-555/cupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Piyush-555/cupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Piyush-555/cupy/contents/{+path}","compare_url":"https://api.github.com/repos/Piyush-555/cupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Piyush-555/cupy/merges","archive_url":"https://api.github.com/repos/Piyush-555/cupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Piyush-555/cupy/downloads","issues_url":"https://api.github.com/repos/Piyush-555/cupy/issues{/number}","pulls_url":"https://api.github.com/repos/Piyush-555/cupy/pulls{/number}","milestones_url":"https://api.github.com/repos/Piyush-555/cupy/milestones{/number}","notifications_url":"https://api.github.com/repos/Piyush-555/cupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Piyush-555/cupy/labels{/name}","releases_url":"https://api.github.com/repos/Piyush-555/cupy/releases{/id}","deployments_url":"https://api.github.com/repos/Piyush-555/cupy/deployments","created_at":"2019-05-30T05:31:09Z","updated_at":"2019-07-26T05:23:53Z","pushed_at":"2019-08-07T20:16:08Z","git_url":"git://github.com/Piyush-555/cupy.git","ssh_url":"git@github.com:Piyush-555/cupy.git","clone_url":"https://github.com/Piyush-555/cupy.git","svn_url":"https://github.com/Piyush-555/cupy","homepage":"https://cupy.chainer.org","size":18261,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cupy:master","ref":"master","sha":"7d18da1918ebe4febd7eaa5896895b957e6a2ba6","user":{"login":"cupy","id":23187665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTg3NjY1","avatar_url":"https://avatars2.githubusercontent.com/u/23187665?v=4","gravatar_id":"","url":"https://api.github.com/users/cupy","html_url":"https://github.com/cupy","followers_url":"https://api.github.com/users/cupy/followers","following_url":"https://api.github.com/users/cupy/following{/other_user}","gists_url":"https://api.github.com/users/cupy/gists{/gist_id}","starred_url":"https://api.github.com/users/cupy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupy/subscriptions","organizations_url":"https://api.github.com/users/cupy/orgs","repos_url":"https://api.github.com/users/cupy/repos","events_url":"https://api.github.com/users/cupy/events{/privacy}","received_events_url":"https://api.github.com/users/cupy/received_events","type":"Organization","site_admin":false},"repo":{"id":72523920,"node_id":"MDEwOlJlcG9zaXRvcnk3MjUyMzkyMA==","name":"cupy","full_name":"cupy/cupy","private":false,"owner":{"login":"cupy","id":23187665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTg3NjY1","avatar_url":"https://avatars2.githubusercontent.com/u/23187665?v=4","gravatar_id":"","url":"https://api.github.com/users/cupy","html_url":"https://github.com/cupy","followers_url":"https://api.github.com/users/cupy/followers","following_url":"https://api.github.com/users/cupy/following{/other_user}","gists_url":"https://api.github.com/users/cupy/gists{/gist_id}","starred_url":"https://api.github.com/users/cupy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupy/subscriptions","organizations_url":"https://api.github.com/users/cupy/orgs","repos_url":"https://api.github.com/users/cupy/repos","events_url":"https://api.github.com/users/cupy/events{/privacy}","received_events_url":"https://api.github.com/users/cupy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cupy/cupy","description":"NumPy-like API accelerated with CUDA","fork":false,"url":"https://api.github.com/repos/cupy/cupy","forks_url":"https://api.github.com/repos/cupy/cupy/forks","keys_url":"https://api.github.com/repos/cupy/cupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cupy/cupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cupy/cupy/teams","hooks_url":"https://api.github.com/repos/cupy/cupy/hooks","issue_events_url":"https://api.github.com/repos/cupy/cupy/issues/events{/number}","events_url":"https://api.github.com/repos/cupy/cupy/events","assignees_url":"https://api.github.com/repos/cupy/cupy/assignees{/user}","branches_url":"https://api.github.com/repos/cupy/cupy/branches{/branch}","tags_url":"https://api.github.com/repos/cupy/cupy/tags","blobs_url":"https://api.github.com/repos/cupy/cupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cupy/cupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cupy/cupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cupy/cupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cupy/cupy/statuses/{sha}","languages_url":"https://api.github.com/repos/cupy/cupy/languages","stargazers_url":"https://api.github.com/repos/cupy/cupy/stargazers","contributors_url":"https://api.github.com/repos/cupy/cupy/contributors","subscribers_url":"https://api.github.com/repos/cupy/cupy/subscribers","subscription_url":"https://api.github.com/repos/cupy/cupy/subscription","commits_url":"https://api.github.com/repos/cupy/cupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cupy/cupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cupy/cupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cupy/cupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cupy/cupy/contents/{+path}","compare_url":"https://api.github.com/repos/cupy/cupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cupy/cupy/merges","archive_url":"https://api.github.com/repos/cupy/cupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cupy/cupy/downloads","issues_url":"https://api.github.com/repos/cupy/cupy/issues{/number}","pulls_url":"https://api.github.com/repos/cupy/cupy/pulls{/number}","milestones_url":"https://api.github.com/repos/cupy/cupy/milestones{/number}","notifications_url":"https://api.github.com/repos/cupy/cupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cupy/cupy/labels{/name}","releases_url":"https://api.github.com/repos/cupy/cupy/releases{/id}","deployments_url":"https://api.github.com/repos/cupy/cupy/deployments","created_at":"2016-11-01T09:54:45Z","updated_at":"2019-08-07T10:42:46Z","pushed_at":"2019-08-07T20:16:10Z","git_url":"git://github.com/cupy/cupy.git","ssh_url":"git@github.com:cupy/cupy.git","clone_url":"https://github.com/cupy/cupy.git","svn_url":"https://github.com/cupy/cupy","homepage":"https://cupy.chainer.org","size":18294,"stargazers_count":3319,"watchers_count":3319,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":261,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":287,"open_issues":261,"watchers":3319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2319"},"html":{"href":"https://github.com/cupy/cupy/pull/2319"},"issue":{"href":"https://api.github.com/repos/cupy/cupy/issues/2319"},"comments":{"href":"https://api.github.com/repos/cupy/cupy/issues/2319/comments"},"review_comments":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2319/comments"},"review_comment":{"href":"https://api.github.com/repos/cupy/cupy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2319/commits"},"statuses":{"href":"https://api.github.com/repos/cupy/cupy/statuses/ec85154c04274ac1558aea0f84a1237dc006b77b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 72523920,
"name": "cupy/cupy",
"url": "https://api.github.com/repos/cupy/cupy"
}
|
{
"id": 34499999,
"login": "Piyush-555",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34499999?",
"url": "https://api.github.com/users/Piyush-555"
}
|
{
"id": 23187665,
"login": "cupy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23187665?",
"url": "https://api.github.com/orgs/cupy"
}
| 2019-08-07T20:17:49 |
10168238217
|
{"actor":{"display_login":"Piyush-555"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cupy/cupy/pulls/comments/353514979","pull_request_review_id":326561130,"id":353514979,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzUxNDk3OQ==","diff_hunk":"@@ -32,6 +33,227 @@ class _compressed_sparse_matrix(sparse_data._data_matrix):\n ''',\n 'compress_getitem_complex')\n \n+ _max_reduction_kern = core.RawKernel(r'''\n+ extern \"C\" __global__\n+ void max_reduction(double* data, int* x, int* y, int length,\n+ double* z) {\n+ // Get the index of the block","path":"cupyx/scipy/sparse/compressed.py","position":18,"original_position":18,"commit_id":"516a3ad21dc0a82e77c8afad78edc28a2055da12","original_commit_id":"35bfcc73bd399fe29de155e67d91cdd75ae8f3e6","user":{"login":"emcastillo","id":15824382,"node_id":"MDQ6VXNlcjE1ODI0Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/15824382?v=4","gravatar_id":"","url":"https://api.github.com/users/emcastillo","html_url":"https://github.com/emcastillo","followers_url":"https://api.github.com/users/emcastillo/followers","following_url":"https://api.github.com/users/emcastillo/following{/other_user}","gists_url":"https://api.github.com/users/emcastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/emcastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcastillo/subscriptions","organizations_url":"https://api.github.com/users/emcastillo/orgs","repos_url":"https://api.github.com/users/emcastillo/repos","events_url":"https://api.github.com/users/emcastillo/events{/privacy}","received_events_url":"https://api.github.com/users/emcastillo/received_events","type":"User","site_admin":false},"body":"In this case `Calculate the block length` is redundant since you are calculating a variable called `block_length`, but other comments such as `// Select initial value based on the block density` are needed 🙂","created_at":"2019-12-04T01:54:05Z","updated_at":"2019-12-04T01:54:05Z","html_url":"https://github.com/cupy/cupy/pull/2711#discussion_r353514979","pull_request_url":"https://api.github.com/repos/cupy/cupy/pulls/2711","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cupy/cupy/pulls/comments/353514979"},"html":{"href":"https://github.com/cupy/cupy/pull/2711#discussion_r353514979"},"pull_request":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2711"}},"in_reply_to_id":353002600},"pull_request":{"url":"https://api.github.com/repos/cupy/cupy/pulls/2711","id":345402149,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1NDAyMTQ5","html_url":"https://github.com/cupy/cupy/pull/2711","diff_url":"https://github.com/cupy/cupy/pull/2711.diff","patch_url":"https://github.com/cupy/cupy/pull/2711.patch","issue_url":"https://api.github.com/repos/cupy/cupy/issues/2711","number":2711,"state":"open","locked":false,"title":"Added min, max, argmin, argmax to sparse csr and csc matrices","user":{"login":"dloney","id":11413731,"node_id":"MDQ6VXNlcjExNDEzNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/11413731?v=4","gravatar_id":"","url":"https://api.github.com/users/dloney","html_url":"https://github.com/dloney","followers_url":"https://api.github.com/users/dloney/followers","following_url":"https://api.github.com/users/dloney/following{/other_user}","gists_url":"https://api.github.com/users/dloney/gists{/gist_id}","starred_url":"https://api.github.com/users/dloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dloney/subscriptions","organizations_url":"https://api.github.com/users/dloney/orgs","repos_url":"https://api.github.com/users/dloney/repos","events_url":"https://api.github.com/users/dloney/events{/privacy}","received_events_url":"https://api.github.com/users/dloney/received_events","type":"User","site_admin":false},"body":"This adds min, max, argmin, and argmax functionality to cupy sparse csr and csc matrix formats. Format differences from scipy are to improve computational performance by eliminating duplicate summation and coo matrix construction time. ","created_at":"2019-11-25T20:26:52Z","updated_at":"2019-12-04T01:54:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beef2693d7dd48b71dd470dc5d92aa25cc421493","assignee":{"login":"emcastillo","id":15824382,"node_id":"MDQ6VXNlcjE1ODI0Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/15824382?v=4","gravatar_id":"","url":"https://api.github.com/users/emcastillo","html_url":"https://github.com/emcastillo","followers_url":"https://api.github.com/users/emcastillo/followers","following_url":"https://api.github.com/users/emcastillo/following{/other_user}","gists_url":"https://api.github.com/users/emcastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/emcastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcastillo/subscriptions","organizations_url":"https://api.github.com/users/emcastillo/orgs","repos_url":"https://api.github.com/users/emcastillo/repos","events_url":"https://api.github.com/users/emcastillo/events{/privacy}","received_events_url":"https://api.github.com/users/emcastillo/received_events","type":"User","site_admin":false},"assignees":[{"login":"emcastillo","id":15824382,"node_id":"MDQ6VXNlcjE1ODI0Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/15824382?v=4","gravatar_id":"","url":"https://api.github.com/users/emcastillo","html_url":"https://github.com/emcastillo","followers_url":"https://api.github.com/users/emcastillo/followers","following_url":"https://api.github.com/users/emcastillo/following{/other_user}","gists_url":"https://api.github.com/users/emcastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/emcastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emcastillo/subscriptions","organizations_url":"https://api.github.com/users/emcastillo/orgs","repos_url":"https://api.github.com/users/emcastillo/repos","events_url":"https://api.github.com/users/emcastillo/events{/privacy}","received_events_url":"https://api.github.com/users/emcastillo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cupy/cupy/pulls/2711/commits","review_comments_url":"https://api.github.com/repos/cupy/cupy/pulls/2711/comments","review_comment_url":"https://api.github.com/repos/cupy/cupy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cupy/cupy/issues/2711/comments","statuses_url":"https://api.github.com/repos/cupy/cupy/statuses/516a3ad21dc0a82e77c8afad78edc28a2055da12","head":{"label":"dloney:max_min","ref":"max_min","sha":"516a3ad21dc0a82e77c8afad78edc28a2055da12","user":{"login":"dloney","id":11413731,"node_id":"MDQ6VXNlcjExNDEzNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/11413731?v=4","gravatar_id":"","url":"https://api.github.com/users/dloney","html_url":"https://github.com/dloney","followers_url":"https://api.github.com/users/dloney/followers","following_url":"https://api.github.com/users/dloney/following{/other_user}","gists_url":"https://api.github.com/users/dloney/gists{/gist_id}","starred_url":"https://api.github.com/users/dloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dloney/subscriptions","organizations_url":"https://api.github.com/users/dloney/orgs","repos_url":"https://api.github.com/users/dloney/repos","events_url":"https://api.github.com/users/dloney/events{/privacy}","received_events_url":"https://api.github.com/users/dloney/received_events","type":"User","site_admin":false},"repo":{"id":223037488,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMwMzc0ODg=","name":"cupy","full_name":"dloney/cupy","private":false,"owner":{"login":"dloney","id":11413731,"node_id":"MDQ6VXNlcjExNDEzNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/11413731?v=4","gravatar_id":"","url":"https://api.github.com/users/dloney","html_url":"https://github.com/dloney","followers_url":"https://api.github.com/users/dloney/followers","following_url":"https://api.github.com/users/dloney/following{/other_user}","gists_url":"https://api.github.com/users/dloney/gists{/gist_id}","starred_url":"https://api.github.com/users/dloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dloney/subscriptions","organizations_url":"https://api.github.com/users/dloney/orgs","repos_url":"https://api.github.com/users/dloney/repos","events_url":"https://api.github.com/users/dloney/events{/privacy}","received_events_url":"https://api.github.com/users/dloney/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dloney/cupy","description":"NumPy-like API accelerated with CUDA","fork":true,"url":"https://api.github.com/repos/dloney/cupy","forks_url":"https://api.github.com/repos/dloney/cupy/forks","keys_url":"https://api.github.com/repos/dloney/cupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dloney/cupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dloney/cupy/teams","hooks_url":"https://api.github.com/repos/dloney/cupy/hooks","issue_events_url":"https://api.github.com/repos/dloney/cupy/issues/events{/number}","events_url":"https://api.github.com/repos/dloney/cupy/events","assignees_url":"https://api.github.com/repos/dloney/cupy/assignees{/user}","branches_url":"https://api.github.com/repos/dloney/cupy/branches{/branch}","tags_url":"https://api.github.com/repos/dloney/cupy/tags","blobs_url":"https://api.github.com/repos/dloney/cupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dloney/cupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dloney/cupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dloney/cupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dloney/cupy/statuses/{sha}","languages_url":"https://api.github.com/repos/dloney/cupy/languages","stargazers_url":"https://api.github.com/repos/dloney/cupy/stargazers","contributors_url":"https://api.github.com/repos/dloney/cupy/contributors","subscribers_url":"https://api.github.com/repos/dloney/cupy/subscribers","subscription_url":"https://api.github.com/repos/dloney/cupy/subscription","commits_url":"https://api.github.com/repos/dloney/cupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dloney/cupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dloney/cupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dloney/cupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dloney/cupy/contents/{+path}","compare_url":"https://api.github.com/repos/dloney/cupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dloney/cupy/merges","archive_url":"https://api.github.com/repos/dloney/cupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dloney/cupy/downloads","issues_url":"https://api.github.com/repos/dloney/cupy/issues{/number}","pulls_url":"https://api.github.com/repos/dloney/cupy/pulls{/number}","milestones_url":"https://api.github.com/repos/dloney/cupy/milestones{/number}","notifications_url":"https://api.github.com/repos/dloney/cupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dloney/cupy/labels{/name}","releases_url":"https://api.github.com/repos/dloney/cupy/releases{/id}","deployments_url":"https://api.github.com/repos/dloney/cupy/deployments","created_at":"2019-11-20T22:15:37Z","updated_at":"2019-11-20T22:15:39Z","pushed_at":"2019-12-03T14:18:47Z","git_url":"git://github.com/dloney/cupy.git","ssh_url":"git@github.com:dloney/cupy.git","clone_url":"https://github.com/dloney/cupy.git","svn_url":"https://github.com/dloney/cupy","homepage":"https://cupy.chainer.org","size":19447,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cupy:master","ref":"master","sha":"5ce74727a6021ac2715ff507ee87ba328c6381ff","user":{"login":"cupy","id":23187665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTg3NjY1","avatar_url":"https://avatars2.githubusercontent.com/u/23187665?v=4","gravatar_id":"","url":"https://api.github.com/users/cupy","html_url":"https://github.com/cupy","followers_url":"https://api.github.com/users/cupy/followers","following_url":"https://api.github.com/users/cupy/following{/other_user}","gists_url":"https://api.github.com/users/cupy/gists{/gist_id}","starred_url":"https://api.github.com/users/cupy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupy/subscriptions","organizations_url":"https://api.github.com/users/cupy/orgs","repos_url":"https://api.github.com/users/cupy/repos","events_url":"https://api.github.com/users/cupy/events{/privacy}","received_events_url":"https://api.github.com/users/cupy/received_events","type":"Organization","site_admin":false},"repo":{"id":72523920,"node_id":"MDEwOlJlcG9zaXRvcnk3MjUyMzkyMA==","name":"cupy","full_name":"cupy/cupy","private":false,"owner":{"login":"cupy","id":23187665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTg3NjY1","avatar_url":"https://avatars2.githubusercontent.com/u/23187665?v=4","gravatar_id":"","url":"https://api.github.com/users/cupy","html_url":"https://github.com/cupy","followers_url":"https://api.github.com/users/cupy/followers","following_url":"https://api.github.com/users/cupy/following{/other_user}","gists_url":"https://api.github.com/users/cupy/gists{/gist_id}","starred_url":"https://api.github.com/users/cupy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cupy/subscriptions","organizations_url":"https://api.github.com/users/cupy/orgs","repos_url":"https://api.github.com/users/cupy/repos","events_url":"https://api.github.com/users/cupy/events{/privacy}","received_events_url":"https://api.github.com/users/cupy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cupy/cupy","description":"NumPy-like API accelerated with CUDA","fork":false,"url":"https://api.github.com/repos/cupy/cupy","forks_url":"https://api.github.com/repos/cupy/cupy/forks","keys_url":"https://api.github.com/repos/cupy/cupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cupy/cupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cupy/cupy/teams","hooks_url":"https://api.github.com/repos/cupy/cupy/hooks","issue_events_url":"https://api.github.com/repos/cupy/cupy/issues/events{/number}","events_url":"https://api.github.com/repos/cupy/cupy/events","assignees_url":"https://api.github.com/repos/cupy/cupy/assignees{/user}","branches_url":"https://api.github.com/repos/cupy/cupy/branches{/branch}","tags_url":"https://api.github.com/repos/cupy/cupy/tags","blobs_url":"https://api.github.com/repos/cupy/cupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cupy/cupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cupy/cupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cupy/cupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cupy/cupy/statuses/{sha}","languages_url":"https://api.github.com/repos/cupy/cupy/languages","stargazers_url":"https://api.github.com/repos/cupy/cupy/stargazers","contributors_url":"https://api.github.com/repos/cupy/cupy/contributors","subscribers_url":"https://api.github.com/repos/cupy/cupy/subscribers","subscription_url":"https://api.github.com/repos/cupy/cupy/subscription","commits_url":"https://api.github.com/repos/cupy/cupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cupy/cupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cupy/cupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cupy/cupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cupy/cupy/contents/{+path}","compare_url":"https://api.github.com/repos/cupy/cupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cupy/cupy/merges","archive_url":"https://api.github.com/repos/cupy/cupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cupy/cupy/downloads","issues_url":"https://api.github.com/repos/cupy/cupy/issues{/number}","pulls_url":"https://api.github.com/repos/cupy/cupy/pulls{/number}","milestones_url":"https://api.github.com/repos/cupy/cupy/milestones{/number}","notifications_url":"https://api.github.com/repos/cupy/cupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cupy/cupy/labels{/name}","releases_url":"https://api.github.com/repos/cupy/cupy/releases{/id}","deployments_url":"https://api.github.com/repos/cupy/cupy/deployments","created_at":"2016-11-01T09:54:45Z","updated_at":"2019-12-03T20:15:52Z","pushed_at":"2019-12-03T21:56:38Z","git_url":"git://github.com/cupy/cupy.git","ssh_url":"git@github.com:cupy/cupy.git","clone_url":"https://github.com/cupy/cupy.git","svn_url":"https://github.com/cupy/cupy","homepage":"https://cupy.chainer.org","size":19770,"stargazers_count":3728,"watchers_count":3728,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":304,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":324,"open_issues":304,"watchers":3728,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2711"},"html":{"href":"https://github.com/cupy/cupy/pull/2711"},"issue":{"href":"https://api.github.com/repos/cupy/cupy/issues/2711"},"comments":{"href":"https://api.github.com/repos/cupy/cupy/issues/2711/comments"},"review_comments":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2711/comments"},"review_comment":{"href":"https://api.github.com/repos/cupy/cupy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cupy/cupy/pulls/2711/commits"},"statuses":{"href":"https://api.github.com/repos/cupy/cupy/statuses/516a3ad21dc0a82e77c8afad78edc28a2055da12"}},"author_association":"NONE"}}
|
{
"id": 72523920,
"name": "cupy/cupy",
"url": "https://api.github.com/repos/cupy/cupy"
}
|
{
"id": 15824382,
"login": "emcastillo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15824382?",
"url": "https://api.github.com/users/emcastillo"
}
|
{
"id": 23187665,
"login": "cupy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23187665?",
"url": "https://api.github.com/orgs/cupy"
}
| 2019-12-04T01:54:05 |
11005443056
|
{"actor":{"display_login":"emcastillo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nuxt/nuxt.js/pulls/comments/307998214","pull_request_review_id":267502957,"id":307998214,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzk5ODIxNA==","diff_hunk":"@@ -10,14 +10,16 @@ import TerserWebpackPlugin from 'terser-webpack-plugin'\n import WebpackBar from 'webpackbar'\n import env from 'std-env'\n \n-import { isUrl, urlJoin } from '@nuxt/utils'\n+import { createTimeHash, isUrl, urlJoin } from '@nuxt/utils'\n \n import PerfLoader from '../utils/perf-loader'\n import StyleLoader from '../utils/style-loader'\n import WarningIgnorePlugin from '../plugins/warning-ignore'\n \n import { reservedVueTags } from '../utils/reserved-tags'\n \n+const BUILD_HASH = createTimeHash()","path":"packages/webpack/src/config/base.js","position":13,"original_position":13,"commit_id":"d2232c1a8837e31c2dbfb69bcfd7c45e05c79577","original_commit_id":"a2ffb0630676254a06b4d4a18cc0160c4376d44e","user":{"login":"manniL","id":640208,"node_id":"MDQ6VXNlcjY0MDIwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/640208?v=4","gravatar_id":"","url":"https://api.github.com/users/manniL","html_url":"https://github.com/manniL","followers_url":"https://api.github.com/users/manniL/followers","following_url":"https://api.github.com/users/manniL/following{/other_user}","gists_url":"https://api.github.com/users/manniL/gists{/gist_id}","starred_url":"https://api.github.com/users/manniL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manniL/subscriptions","organizations_url":"https://api.github.com/users/manniL/orgs","repos_url":"https://api.github.com/users/manniL/repos","events_url":"https://api.github.com/users/manniL/events{/privacy}","received_events_url":"https://api.github.com/users/manniL/received_events","type":"User","site_admin":false},"body":"\r\n\r\nwon't the hash be different for server and client then?","created_at":"2019-07-28T11:59:21Z","updated_at":"2019-07-28T11:59:21Z","html_url":"https://github.com/nuxt/nuxt.js/pull/6150#discussion_r307998214","pull_request_url":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nuxt/nuxt.js/pulls/comments/307998214"},"html":{"href":"https://github.com/nuxt/nuxt.js/pull/6150#discussion_r307998214"},"pull_request":{"href":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150"}},"in_reply_to_id":307997857},"pull_request":{"url":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150","id":301821679,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxODIxNjc5","html_url":"https://github.com/nuxt/nuxt.js/pull/6150","diff_url":"https://github.com/nuxt/nuxt.js/pull/6150.diff","patch_url":"https://github.com/nuxt/nuxt.js/pull/6150.patch","issue_url":"https://api.github.com/repos/nuxt/nuxt.js/issues/6150","number":6150,"state":"open","locked":false,"title":"feat: add time-based build and generation hash for every nuxt build","user":{"login":"manniL","id":640208,"node_id":"MDQ6VXNlcjY0MDIwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/640208?v=4","gravatar_id":"","url":"https://api.github.com/users/manniL","html_url":"https://github.com/manniL","followers_url":"https://api.github.com/users/manniL/followers","following_url":"https://api.github.com/users/manniL/following{/other_user}","gists_url":"https://api.github.com/users/manniL/gists{/gist_id}","starred_url":"https://api.github.com/users/manniL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manniL/subscriptions","organizations_url":"https://api.github.com/users/manniL/orgs","repos_url":"https://api.github.com/users/manniL/repos","events_url":"https://api.github.com/users/manniL/events{/privacy}","received_events_url":"https://api.github.com/users/manniL/received_events","type":"User","site_admin":false},"body":"## TODO\r\n\r\n- [ ] Dev mode\r\n- [x] Verify it works with `nuxt generate --no-build`\r\n\r\n\r\n## Types of changes\r\n- [ ] Bug fix (a non-breaking change which fixes an issue)\r\n- [x] New feature (a non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n\r\n## Description\r\n\r\nThis PR adds two new hash variables (`process.BUILD_HASH` and `process.EXPORT_HASH`). \r\n\r\nThe build hash differs per `nuxt build` (and therefore also per `nuxt generate` *with rebuild*) and indicates changes to the code.\r\n\r\nThe export hash will change only when re-generating the Nuxt project via `nuxt generate` and **also works with** `nuxt generate --no-build`. However, it is only available from the generation process on and *might not be available* (?) in the final app itself.\r\n\r\nThe idea originated a few months ago when @hootlex suggested a build token feature. :relaxed: \t\r\n\r\nThese hashes could be used for various reasons, but especially for `export-based` caching of resources that aren't touched by webpack and have a common name otherwise. This will also be the case for the upcoming full static mode ( https://github.com/nuxt/rfcs/issues/22 ), where payloads can't be processed by webpack but caching of them would be a great benefit. \r\n\r\n## Checklist:\r\n<!--- Put an `x` in all the boxes that apply. -->\r\n<!--- If your change requires a documentation PR, please link it appropriately -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly. (PR: #)\r\n- [ ] I have added tests to cover my changes (if not applicable, please state why)\r\n- [ ] All new and existing tests are passing.\r\n\r\n","created_at":"2019-07-28T10:44:11Z","updated_at":"2019-07-28T11:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e1b668204c47e581ee9ace2683748be308f1603","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150/commits","review_comments_url":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150/comments","review_comment_url":"https://api.github.com/repos/nuxt/nuxt.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxt/nuxt.js/issues/6150/comments","statuses_url":"https://api.github.com/repos/nuxt/nuxt.js/statuses/d2232c1a8837e31c2dbfb69bcfd7c45e05c79577","head":{"label":"nuxt:feat/build-hash","ref":"feat/build-hash","sha":"d2232c1a8837e31c2dbfb69bcfd7c45e05c79577","user":{"login":"nuxt","id":23360933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzYwOTMz","avatar_url":"https://avatars2.githubusercontent.com/u/23360933?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxt","html_url":"https://github.com/nuxt","followers_url":"https://api.github.com/users/nuxt/followers","following_url":"https://api.github.com/users/nuxt/following{/other_user}","gists_url":"https://api.github.com/users/nuxt/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxt/subscriptions","organizations_url":"https://api.github.com/users/nuxt/orgs","repos_url":"https://api.github.com/users/nuxt/repos","events_url":"https://api.github.com/users/nuxt/events{/privacy}","received_events_url":"https://api.github.com/users/nuxt/received_events","type":"Organization","site_admin":false},"repo":{"id":71995937,"node_id":"MDEwOlJlcG9zaXRvcnk3MTk5NTkzNw==","name":"nuxt.js","full_name":"nuxt/nuxt.js","private":false,"owner":{"login":"nuxt","id":23360933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzYwOTMz","avatar_url":"https://avatars2.githubusercontent.com/u/23360933?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxt","html_url":"https://github.com/nuxt","followers_url":"https://api.github.com/users/nuxt/followers","following_url":"https://api.github.com/users/nuxt/following{/other_user}","gists_url":"https://api.github.com/users/nuxt/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxt/subscriptions","organizations_url":"https://api.github.com/users/nuxt/orgs","repos_url":"https://api.github.com/users/nuxt/repos","events_url":"https://api.github.com/users/nuxt/events{/privacy}","received_events_url":"https://api.github.com/users/nuxt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nuxt/nuxt.js","description":"The Vue.js Framework","fork":false,"url":"https://api.github.com/repos/nuxt/nuxt.js","forks_url":"https://api.github.com/repos/nuxt/nuxt.js/forks","keys_url":"https://api.github.com/repos/nuxt/nuxt.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxt/nuxt.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxt/nuxt.js/teams","hooks_url":"https://api.github.com/repos/nuxt/nuxt.js/hooks","issue_events_url":"https://api.github.com/repos/nuxt/nuxt.js/issues/events{/number}","events_url":"https://api.github.com/repos/nuxt/nuxt.js/events","assignees_url":"https://api.github.com/repos/nuxt/nuxt.js/assignees{/user}","branches_url":"https://api.github.com/repos/nuxt/nuxt.js/branches{/branch}","tags_url":"https://api.github.com/repos/nuxt/nuxt.js/tags","blobs_url":"https://api.github.com/repos/nuxt/nuxt.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxt/nuxt.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxt/nuxt.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxt/nuxt.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxt/nuxt.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxt/nuxt.js/languages","stargazers_url":"https://api.github.com/repos/nuxt/nuxt.js/stargazers","contributors_url":"https://api.github.com/repos/nuxt/nuxt.js/contributors","subscribers_url":"https://api.github.com/repos/nuxt/nuxt.js/subscribers","subscription_url":"https://api.github.com/repos/nuxt/nuxt.js/subscription","commits_url":"https://api.github.com/repos/nuxt/nuxt.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxt/nuxt.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxt/nuxt.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxt/nuxt.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxt/nuxt.js/contents/{+path}","compare_url":"https://api.github.com/repos/nuxt/nuxt.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxt/nuxt.js/merges","archive_url":"https://api.github.com/repos/nuxt/nuxt.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxt/nuxt.js/downloads","issues_url":"https://api.github.com/repos/nuxt/nuxt.js/issues{/number}","pulls_url":"https://api.github.com/repos/nuxt/nuxt.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxt/nuxt.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxt/nuxt.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxt/nuxt.js/labels{/name}","releases_url":"https://api.github.com/repos/nuxt/nuxt.js/releases{/id}","deployments_url":"https://api.github.com/repos/nuxt/nuxt.js/deployments","created_at":"2016-10-26T11:18:47Z","updated_at":"2019-07-28T11:57:23Z","pushed_at":"2019-07-28T11:54:52Z","git_url":"git://github.com/nuxt/nuxt.js.git","ssh_url":"git@github.com:nuxt/nuxt.js.git","clone_url":"https://github.com/nuxt/nuxt.js.git","svn_url":"https://github.com/nuxt/nuxt.js","homepage":"https://nuxtjs.org","size":20023,"stargazers_count":21441,"watchers_count":21441,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1833,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1833,"open_issues":182,"watchers":21441,"default_branch":"dev"}},"base":{"label":"nuxt:dev","ref":"dev","sha":"0cd823c30078b3f097a91052cc7dfde74f289c0d","user":{"login":"nuxt","id":23360933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzYwOTMz","avatar_url":"https://avatars2.githubusercontent.com/u/23360933?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxt","html_url":"https://github.com/nuxt","followers_url":"https://api.github.com/users/nuxt/followers","following_url":"https://api.github.com/users/nuxt/following{/other_user}","gists_url":"https://api.github.com/users/nuxt/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxt/subscriptions","organizations_url":"https://api.github.com/users/nuxt/orgs","repos_url":"https://api.github.com/users/nuxt/repos","events_url":"https://api.github.com/users/nuxt/events{/privacy}","received_events_url":"https://api.github.com/users/nuxt/received_events","type":"Organization","site_admin":false},"repo":{"id":71995937,"node_id":"MDEwOlJlcG9zaXRvcnk3MTk5NTkzNw==","name":"nuxt.js","full_name":"nuxt/nuxt.js","private":false,"owner":{"login":"nuxt","id":23360933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzYwOTMz","avatar_url":"https://avatars2.githubusercontent.com/u/23360933?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxt","html_url":"https://github.com/nuxt","followers_url":"https://api.github.com/users/nuxt/followers","following_url":"https://api.github.com/users/nuxt/following{/other_user}","gists_url":"https://api.github.com/users/nuxt/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxt/subscriptions","organizations_url":"https://api.github.com/users/nuxt/orgs","repos_url":"https://api.github.com/users/nuxt/repos","events_url":"https://api.github.com/users/nuxt/events{/privacy}","received_events_url":"https://api.github.com/users/nuxt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nuxt/nuxt.js","description":"The Vue.js Framework","fork":false,"url":"https://api.github.com/repos/nuxt/nuxt.js","forks_url":"https://api.github.com/repos/nuxt/nuxt.js/forks","keys_url":"https://api.github.com/repos/nuxt/nuxt.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxt/nuxt.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxt/nuxt.js/teams","hooks_url":"https://api.github.com/repos/nuxt/nuxt.js/hooks","issue_events_url":"https://api.github.com/repos/nuxt/nuxt.js/issues/events{/number}","events_url":"https://api.github.com/repos/nuxt/nuxt.js/events","assignees_url":"https://api.github.com/repos/nuxt/nuxt.js/assignees{/user}","branches_url":"https://api.github.com/repos/nuxt/nuxt.js/branches{/branch}","tags_url":"https://api.github.com/repos/nuxt/nuxt.js/tags","blobs_url":"https://api.github.com/repos/nuxt/nuxt.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxt/nuxt.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxt/nuxt.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxt/nuxt.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxt/nuxt.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxt/nuxt.js/languages","stargazers_url":"https://api.github.com/repos/nuxt/nuxt.js/stargazers","contributors_url":"https://api.github.com/repos/nuxt/nuxt.js/contributors","subscribers_url":"https://api.github.com/repos/nuxt/nuxt.js/subscribers","subscription_url":"https://api.github.com/repos/nuxt/nuxt.js/subscription","commits_url":"https://api.github.com/repos/nuxt/nuxt.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxt/nuxt.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxt/nuxt.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxt/nuxt.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxt/nuxt.js/contents/{+path}","compare_url":"https://api.github.com/repos/nuxt/nuxt.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxt/nuxt.js/merges","archive_url":"https://api.github.com/repos/nuxt/nuxt.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxt/nuxt.js/downloads","issues_url":"https://api.github.com/repos/nuxt/nuxt.js/issues{/number}","pulls_url":"https://api.github.com/repos/nuxt/nuxt.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxt/nuxt.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxt/nuxt.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxt/nuxt.js/labels{/name}","releases_url":"https://api.github.com/repos/nuxt/nuxt.js/releases{/id}","deployments_url":"https://api.github.com/repos/nuxt/nuxt.js/deployments","created_at":"2016-10-26T11:18:47Z","updated_at":"2019-07-28T11:57:23Z","pushed_at":"2019-07-28T11:54:52Z","git_url":"git://github.com/nuxt/nuxt.js.git","ssh_url":"git@github.com:nuxt/nuxt.js.git","clone_url":"https://github.com/nuxt/nuxt.js.git","svn_url":"https://github.com/nuxt/nuxt.js","homepage":"https://nuxtjs.org","size":20023,"stargazers_count":21441,"watchers_count":21441,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1833,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1833,"open_issues":182,"watchers":21441,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150"},"html":{"href":"https://github.com/nuxt/nuxt.js/pull/6150"},"issue":{"href":"https://api.github.com/repos/nuxt/nuxt.js/issues/6150"},"comments":{"href":"https://api.github.com/repos/nuxt/nuxt.js/issues/6150/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxt/nuxt.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxt/nuxt.js/pulls/6150/commits"},"statuses":{"href":"https://api.github.com/repos/nuxt/nuxt.js/statuses/d2232c1a8837e31c2dbfb69bcfd7c45e05c79577"}},"author_association":"MEMBER"}}
|
{
"id": 71995937,
"name": "nuxt/nuxt.js",
"url": "https://api.github.com/repos/nuxt/nuxt.js"
}
|
{
"id": 640208,
"login": "manniL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/640208?",
"url": "https://api.github.com/users/manniL"
}
|
{
"id": 23360933,
"login": "nuxt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23360933?",
"url": "https://api.github.com/orgs/nuxt"
}
| 2019-07-28T11:59:21 |
10098053931
|
{"actor":{"display_login":"manniL"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments/271769032","pull_request_review_id":222244303,"id":271769032,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTc2OTAzMg==","diff_hunk":"@@ -0,0 +1,399 @@\n+// Copyright 2017 JanusGraph Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package org.janusgraph.diskstorage.keycolumnvalue.inmemory;\n+\n+import com.google.common.base.Preconditions;\n+import org.janusgraph.diskstorage.Entry;\n+import org.janusgraph.diskstorage.EntryList;\n+import org.janusgraph.diskstorage.StaticBuffer;\n+import org.janusgraph.diskstorage.keycolumnvalue.KeySliceQuery;\n+\n+import java.io.DataOutputStream;\n+import java.io.IOException;\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+/**\n+ * \"Multi-page\" implementation of SharedEntryBuffer.\n+ * Maintains a list of pages, each containing a shared byte buffer for maxPageSize Entries. Dividing the buffer into\n+ * pages helps maintain performance in the case of very big stores. This is because when mutating, instead of re-copying\n+ * all the entries in a single byte buffer, we only locate and modify a few pages, skipping those not affected by the mutation.\n+ * <p>\n+ * Since only a limited number of stores actually get very big, the parent store switches from SinglePageEntryBuffer\n+ * to this implementation when a mutation brings the max number of entries beyond maxPageSize threshold.\n+ */\n+public class MultiPageEntryBuffer implements SharedEntryBuffer {\n+ private static int INITIAL_CAPACITY = 2;\n+\n+ //NOTE: tracking pages in a list, which internally maintains an array, creates additional overhead;\n+ // if we maintain our page list in an array directly, this will save this overhead at the cost of some more boilerplate code here\n+ // However in practice the number of multi-page buffers is usually relatively small, so at the moment it seems to be\n+ // a reasonable price for having less code\n+ private ArrayList<BufferPage> pages;\n+\n+ public MultiPageEntryBuffer(BufferPage initialPage) {\n+ this.pages = new ArrayList<>(INITIAL_CAPACITY);\n+ if (initialPage instanceof SinglePageEntryBuffer) {\n+ pages.add(new BufferPage(initialPage.getOffsetIndex(), initialPage.getRawData()));\n+ } else\n+ pages.add(initialPage);\n+ }\n+\n+ MultiPageEntryBuffer(List<BufferPage> allPages) {\n+ this.pages = new ArrayList<>(allPages);\n+ }\n+\n+ @Override\n+ public int numPages() {\n+ return pages.size();\n+ }\n+\n+ @Override\n+ public int numEntries() {\n+ if (pages == null) {\n+ return 0;\n+ }\n+\n+ int numEntries = 0;\n+\n+ for (BufferPage p : pages) {\n+ numEntries += p.numEntries();\n+ }\n+ return numEntries;\n+ }\n+\n+ @Override\n+ public int byteSize() {\n+ if (pages == null) {\n+ return 0;\n+ }\n+\n+ int byteSize = 0;\n+ for (BufferPage p : pages) {\n+ byteSize += p.byteSize() + 16;\n+ }\n+ return byteSize;\n+ }\n+\n+ @Override\n+ public boolean isEmpty() {\n+ return pages.isEmpty();\n+ }\n+\n+ private int getPageIndex(StaticBuffer column) {\n+ //binary search for correct page on column name\n+ int low = 0;\n+ int high = pages.size() - 1;\n+\n+ while (low <= high) {\n+ int mid = (low + high) >>> 1;\n+\n+ BufferPage midPage = pages.get(mid);\n+\n+ int idx = midPage.getIndex(column);\n+\n+ if (idx >= 0) {\n+ return mid; //key found in this page\n+ }\n+\n+ //key not found, idx contains nearest index, negated\n+ idx = (-idx - 1);\n+\n+ if (idx <= 0) //key is smaller than the first key in this page - search previous pages\n+ {\n+ high = mid - 1;\n+ } else if (idx >= midPage.numEntries()) //key is bigger than the last in this page - search following pages\n+ {\n+ low = mid + 1;\n+ } else //key was not found in this page, but the nearest key found is in this page\n+ {\n+ return mid;\n+ }\n+ }\n+ return -(low + 1); //key not found in any of the pages, and is outside the range of current pages - return the nearest page\n+ }\n+\n+ @Override\n+ public EntryList getSlice(KeySliceQuery query) {\n+ if (pages == null || pages.size() == 0) {\n+ return EntryList.EMPTY_LIST;\n+ }\n+\n+ int startPageIdx = getPageIndex(query.getSliceStart());\n+ if (startPageIdx < 0) {\n+ startPageIdx = (-startPageIdx - 1);\n+ }\n+\n+ int endPageLimit = getPageIndex(query.getSliceEnd());\n+ if (endPageLimit < 0) {\n+ endPageLimit = (-endPageLimit - 1);\n+ } else {\n+ endPageLimit++; //we want \"insertion point\" like in case when it wasn't found\n+ }\n+\n+ if (startPageIdx < endPageLimit) {\n+ int startIndex = pages.get(startPageIdx).getIndex(query.getSliceStart());\n+ if (startIndex < 0) {\n+ startIndex = (-startIndex - 1);\n+ }\n+\n+ int endIndex = pages.get(endPageLimit - 1).getIndex(query.getSliceEnd());\n+ if (endIndex < 0) {\n+ endIndex = (-endIndex - 1);\n+ }\n+\n+ MemoryEntryList result = new MemoryEntryList(0);\n+ for (int i = startPageIdx; i < endPageLimit; i++) {\n+ if (query.hasLimit() && result.size() >= query.getLimit()) {\n+ break;\n+ }\n+\n+ BufferPage page = pages.get(i);\n+ int start = (i == startPageIdx) ? startIndex : 0;\n+ int end = (i == endPageLimit - 1) ? endIndex : page.numEntries();\n+ for (int j = start; j < end; j++) {\n+ if (query.hasLimit() && result.size() >= query.getLimit()) {\n+ break;\n+ }\n+\n+ //using getNoCopy here means the old page buffer will not be collected until the last of the Entries it used to hold is collected\n+ //however, since all Entries we return are managed by a single transaction and not presented to user code, this should not be a problem\n+ result.add(page.getNoCopy(j));\n+ }\n+ }\n+\n+ return result;\n+ } else {\n+ return EntryList.EMPTY_LIST;\n+ }\n+ }\n+\n+ @Override\n+ public void mutate(Entry[] add, Entry[] del, int maxPageSize) {","path":"janusgraph-core/src/main/java/org/janusgraph/diskstorage/keycolumnvalue/inmemory/MultiPageEntryBuffer.java","position":184,"original_position":184,"commit_id":"38736e189a02692021868564d642bc84b1a017da","original_commit_id":"38736e189a02692021868564d642bc84b1a017da","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid really long methods.](https://app.codacy.com/app/JanusGraph/janusgraph/pullRequest?prid=3231392)","created_at":"2019-04-03T14:25:21Z","updated_at":"2019-04-03T14:25:22Z","html_url":"https://github.com/JanusGraph/janusgraph/pull/1483#discussion_r271769032","pull_request_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments/271769032"},"html":{"href":"https://github.com/JanusGraph/janusgraph/pull/1483#discussion_r271769032"},"pull_request":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483"}}},"pull_request":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483","id":259203026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MjAzMDI2","html_url":"https://github.com/JanusGraph/janusgraph/pull/1483","diff_url":"https://github.com/JanusGraph/janusgraph/pull/1483.diff","patch_url":"https://github.com/JanusGraph/janusgraph/pull/1483.patch","issue_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1483","number":1483,"state":"open","locked":false,"title":"issue #1482 initial contribution of production in-memory backend","user":{"login":"dk-github","id":5904858,"node_id":"MDQ6VXNlcjU5MDQ4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5904858?v=4","gravatar_id":"","url":"https://api.github.com/users/dk-github","html_url":"https://github.com/dk-github","followers_url":"https://api.github.com/users/dk-github/followers","following_url":"https://api.github.com/users/dk-github/following{/other_user}","gists_url":"https://api.github.com/users/dk-github/gists{/gist_id}","starred_url":"https://api.github.com/users/dk-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dk-github/subscriptions","organizations_url":"https://api.github.com/users/dk-github/orgs","repos_url":"https://api.github.com/users/dk-github/repos","events_url":"https://api.github.com/users/dk-github/events{/privacy}","received_events_url":"https://api.github.com/users/dk-github/received_events","type":"User","site_admin":false},"body":"We would like to contribute an improved implementation of in-memory backend for JanusGraph.\r\n\r\nPlease see issue #1482 for rationale and some comparative analysis vs existing \"test-only\" in-memory backend.\r\n\r\n**_NOTE_**: This PR currently suggests adding the new backend rather than modifying the existing one, as it seemed cleaner and easier to compare performance within one codebase branch.\r\nHowever, having read recent discussions about adding more backends into main repository vs maintenance costs, I am starting to think that actually modifying the existing in-memory backend could be a better idea.\r\nThis is because:\r\n\r\n- the modifications are fairly straightforward and do not change the general structure of existing backend\r\n- don’t add too much extra code or any external dependencies\r\n- don’t require any additional documentation or setup instructions, at least initially\r\n- all existing (and a few extra) integrity tests pass and using it in place of current version is unlikely to create any issues for current (test-only) uses\r\n- the same backend will simply be fit for production use, no new backends to maintain\r\n\r\nThoughts?","created_at":"2019-03-07T17:26:06Z","updated_at":"2019-04-03T14:25:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34fd243499433910b5caf72bab88f5d9dac55aa5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"twilmes","id":4722637,"node_id":"MDQ6VXNlcjQ3MjI2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/4722637?v=4","gravatar_id":"","url":"https://api.github.com/users/twilmes","html_url":"https://github.com/twilmes","followers_url":"https://api.github.com/users/twilmes/followers","following_url":"https://api.github.com/users/twilmes/following{/other_user}","gists_url":"https://api.github.com/users/twilmes/gists{/gist_id}","starred_url":"https://api.github.com/users/twilmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilmes/subscriptions","organizations_url":"https://api.github.com/users/twilmes/orgs","repos_url":"https://api.github.com/users/twilmes/repos","events_url":"https://api.github.com/users/twilmes/events{/privacy}","received_events_url":"https://api.github.com/users/twilmes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":507215572,"node_id":"MDU6TGFiZWw1MDcyMTU1NzI=","url":"https://api.github.com/repos/JanusGraph/janusgraph/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483/commits","review_comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483/comments","review_comment_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1483/comments","statuses_url":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/38736e189a02692021868564d642bc84b1a017da","head":{"label":"dk-github:issue1482-compact-inmemory-backend","ref":"issue1482-compact-inmemory-backend","sha":"38736e189a02692021868564d642bc84b1a017da","user":{"login":"dk-github","id":5904858,"node_id":"MDQ6VXNlcjU5MDQ4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5904858?v=4","gravatar_id":"","url":"https://api.github.com/users/dk-github","html_url":"https://github.com/dk-github","followers_url":"https://api.github.com/users/dk-github/followers","following_url":"https://api.github.com/users/dk-github/following{/other_user}","gists_url":"https://api.github.com/users/dk-github/gists{/gist_id}","starred_url":"https://api.github.com/users/dk-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dk-github/subscriptions","organizations_url":"https://api.github.com/users/dk-github/orgs","repos_url":"https://api.github.com/users/dk-github/repos","events_url":"https://api.github.com/users/dk-github/events{/privacy}","received_events_url":"https://api.github.com/users/dk-github/received_events","type":"User","site_admin":false},"repo":{"id":159246140,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyNDYxNDA=","name":"janusgraph","full_name":"dk-github/janusgraph","private":false,"owner":{"login":"dk-github","id":5904858,"node_id":"MDQ6VXNlcjU5MDQ4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5904858?v=4","gravatar_id":"","url":"https://api.github.com/users/dk-github","html_url":"https://github.com/dk-github","followers_url":"https://api.github.com/users/dk-github/followers","following_url":"https://api.github.com/users/dk-github/following{/other_user}","gists_url":"https://api.github.com/users/dk-github/gists{/gist_id}","starred_url":"https://api.github.com/users/dk-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dk-github/subscriptions","organizations_url":"https://api.github.com/users/dk-github/orgs","repos_url":"https://api.github.com/users/dk-github/repos","events_url":"https://api.github.com/users/dk-github/events{/privacy}","received_events_url":"https://api.github.com/users/dk-github/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dk-github/janusgraph","description":"JanusGraph: an open-source, distributed graph database","fork":true,"url":"https://api.github.com/repos/dk-github/janusgraph","forks_url":"https://api.github.com/repos/dk-github/janusgraph/forks","keys_url":"https://api.github.com/repos/dk-github/janusgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dk-github/janusgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dk-github/janusgraph/teams","hooks_url":"https://api.github.com/repos/dk-github/janusgraph/hooks","issue_events_url":"https://api.github.com/repos/dk-github/janusgraph/issues/events{/number}","events_url":"https://api.github.com/repos/dk-github/janusgraph/events","assignees_url":"https://api.github.com/repos/dk-github/janusgraph/assignees{/user}","branches_url":"https://api.github.com/repos/dk-github/janusgraph/branches{/branch}","tags_url":"https://api.github.com/repos/dk-github/janusgraph/tags","blobs_url":"https://api.github.com/repos/dk-github/janusgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dk-github/janusgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dk-github/janusgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dk-github/janusgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dk-github/janusgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/dk-github/janusgraph/languages","stargazers_url":"https://api.github.com/repos/dk-github/janusgraph/stargazers","contributors_url":"https://api.github.com/repos/dk-github/janusgraph/contributors","subscribers_url":"https://api.github.com/repos/dk-github/janusgraph/subscribers","subscription_url":"https://api.github.com/repos/dk-github/janusgraph/subscription","commits_url":"https://api.github.com/repos/dk-github/janusgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dk-github/janusgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dk-github/janusgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dk-github/janusgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dk-github/janusgraph/contents/{+path}","compare_url":"https://api.github.com/repos/dk-github/janusgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dk-github/janusgraph/merges","archive_url":"https://api.github.com/repos/dk-github/janusgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dk-github/janusgraph/downloads","issues_url":"https://api.github.com/repos/dk-github/janusgraph/issues{/number}","pulls_url":"https://api.github.com/repos/dk-github/janusgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/dk-github/janusgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/dk-github/janusgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dk-github/janusgraph/labels{/name}","releases_url":"https://api.github.com/repos/dk-github/janusgraph/releases{/id}","deployments_url":"https://api.github.com/repos/dk-github/janusgraph/deployments","created_at":"2018-11-26T23:21:44Z","updated_at":"2019-03-05T15:09:26Z","pushed_at":"2019-04-03T11:54:10Z","git_url":"git://github.com/dk-github/janusgraph.git","ssh_url":"git@github.com:dk-github/janusgraph.git","clone_url":"https://github.com/dk-github/janusgraph.git","svn_url":"https://github.com/dk-github/janusgraph","homepage":"http://janusgraph.org","size":51376,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JanusGraph:master","ref":"master","sha":"a451b10495ecc0d83faaca7e16756f83425c8c14","user":{"login":"JanusGraph","id":23411090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDExMDkw","avatar_url":"https://avatars1.githubusercontent.com/u/23411090?v=4","gravatar_id":"","url":"https://api.github.com/users/JanusGraph","html_url":"https://github.com/JanusGraph","followers_url":"https://api.github.com/users/JanusGraph/followers","following_url":"https://api.github.com/users/JanusGraph/following{/other_user}","gists_url":"https://api.github.com/users/JanusGraph/gists{/gist_id}","starred_url":"https://api.github.com/users/JanusGraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanusGraph/subscriptions","organizations_url":"https://api.github.com/users/JanusGraph/orgs","repos_url":"https://api.github.com/users/JanusGraph/repos","events_url":"https://api.github.com/users/JanusGraph/events{/privacy}","received_events_url":"https://api.github.com/users/JanusGraph/received_events","type":"Organization","site_admin":false},"repo":{"id":77385607,"node_id":"MDEwOlJlcG9zaXRvcnk3NzM4NTYwNw==","name":"janusgraph","full_name":"JanusGraph/janusgraph","private":false,"owner":{"login":"JanusGraph","id":23411090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDExMDkw","avatar_url":"https://avatars1.githubusercontent.com/u/23411090?v=4","gravatar_id":"","url":"https://api.github.com/users/JanusGraph","html_url":"https://github.com/JanusGraph","followers_url":"https://api.github.com/users/JanusGraph/followers","following_url":"https://api.github.com/users/JanusGraph/following{/other_user}","gists_url":"https://api.github.com/users/JanusGraph/gists{/gist_id}","starred_url":"https://api.github.com/users/JanusGraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanusGraph/subscriptions","organizations_url":"https://api.github.com/users/JanusGraph/orgs","repos_url":"https://api.github.com/users/JanusGraph/repos","events_url":"https://api.github.com/users/JanusGraph/events{/privacy}","received_events_url":"https://api.github.com/users/JanusGraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JanusGraph/janusgraph","description":"JanusGraph: an open-source, distributed graph database","fork":false,"url":"https://api.github.com/repos/JanusGraph/janusgraph","forks_url":"https://api.github.com/repos/JanusGraph/janusgraph/forks","keys_url":"https://api.github.com/repos/JanusGraph/janusgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JanusGraph/janusgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JanusGraph/janusgraph/teams","hooks_url":"https://api.github.com/repos/JanusGraph/janusgraph/hooks","issue_events_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/events{/number}","events_url":"https://api.github.com/repos/JanusGraph/janusgraph/events","assignees_url":"https://api.github.com/repos/JanusGraph/janusgraph/assignees{/user}","branches_url":"https://api.github.com/repos/JanusGraph/janusgraph/branches{/branch}","tags_url":"https://api.github.com/repos/JanusGraph/janusgraph/tags","blobs_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/JanusGraph/janusgraph/languages","stargazers_url":"https://api.github.com/repos/JanusGraph/janusgraph/stargazers","contributors_url":"https://api.github.com/repos/JanusGraph/janusgraph/contributors","subscribers_url":"https://api.github.com/repos/JanusGraph/janusgraph/subscribers","subscription_url":"https://api.github.com/repos/JanusGraph/janusgraph/subscription","commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/JanusGraph/janusgraph/contents/{+path}","compare_url":"https://api.github.com/repos/JanusGraph/janusgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JanusGraph/janusgraph/merges","archive_url":"https://api.github.com/repos/JanusGraph/janusgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JanusGraph/janusgraph/downloads","issues_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues{/number}","pulls_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/JanusGraph/janusgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/JanusGraph/janusgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JanusGraph/janusgraph/labels{/name}","releases_url":"https://api.github.com/repos/JanusGraph/janusgraph/releases{/id}","deployments_url":"https://api.github.com/repos/JanusGraph/janusgraph/deployments","created_at":"2016-12-26T13:26:29Z","updated_at":"2019-04-03T13:16:22Z","pushed_at":"2019-04-03T11:57:59Z","git_url":"git://github.com/JanusGraph/janusgraph.git","ssh_url":"git@github.com:JanusGraph/janusgraph.git","clone_url":"https://github.com/JanusGraph/janusgraph.git","svn_url":"https://github.com/JanusGraph/janusgraph","homepage":"https://janusgraph.org","size":51601,"stargazers_count":2258,"watchers_count":2258,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":566,"mirror_url":null,"archived":false,"open_issues_count":352,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":566,"open_issues":352,"watchers":2258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483"},"html":{"href":"https://github.com/JanusGraph/janusgraph/pull/1483"},"issue":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1483"},"comments":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1483/comments"},"review_comments":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483/comments"},"review_comment":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1483/commits"},"statuses":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/38736e189a02692021868564d642bc84b1a017da"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 77385607,
"name": "JanusGraph/janusgraph",
"url": "https://api.github.com/repos/JanusGraph/janusgraph"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 23411090,
"login": "JanusGraph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23411090?",
"url": "https://api.github.com/orgs/JanusGraph"
}
| 2019-04-03T14:25:21 |
9370922554
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments/308282734","pull_request_review_id":267848091,"id":308282734,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODI4MjczNA==","diff_hunk":"@@ -144,11 +140,40 @@ private Query buildNumericQuery(final String field, final String value, Class<?>\n }\n } else {\n if (isMatchAll(value)) {\n- return DoublePoint.newRangeQuery(field, Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY);\n+ query = DoublePoint.newRangeQuery(field, Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY);\n } else {\n- return DoublePoint.newExactQuery(field, Double.parseDouble(value));\n+ query = DoublePoint.newExactQuery(field, Double.parseDouble(value));\n }\n }\n+ return query;\n+ }\n+\n+ private Class<?> getKeyDataType(final String field) {\n+ KeyInformation keyInformation = storeRetriever.get(field);\n+ if (keyInformation == null) {\n+ log.warn(String.format(\"Could not find key information for: %s\", field));\n+ return null;\n+ }\n+ return keyInformation.getDataType();\n+ }\n+\n+ private Date parseDate(String value) {\n+ try {\n+ return StdDateFormat.instance.parse(value);\n+ } catch (java.text.ParseException e) {\n+ throw new RuntimeException(e);","path":"janusgraph-lucene/src/main/java/org/janusgraph/diskstorage/lucene/NumericTranslationQueryParser.java","position":165,"original_position":165,"commit_id":"23d0eb667cbd1ec023f7d2aa4e85cf6b5a7087cc","original_commit_id":"23d0eb667cbd1ec023f7d2aa4e85cf6b5a7087cc","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid throwing raw exception types.](https://app.codacy.com/app/JanusGraph/janusgraph/pullRequest?prid=3673927)","created_at":"2019-07-29T15:06:43Z","updated_at":"2019-07-29T15:06:43Z","html_url":"https://github.com/JanusGraph/janusgraph/pull/1615#discussion_r308282734","pull_request_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments/308282734"},"html":{"href":"https://github.com/JanusGraph/janusgraph/pull/1615#discussion_r308282734"},"pull_request":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615"}}},"pull_request":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615","id":284947558,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0OTQ3NTU4","html_url":"https://github.com/JanusGraph/janusgraph/pull/1615","diff_url":"https://github.com/JanusGraph/janusgraph/pull/1615.diff","patch_url":"https://github.com/JanusGraph/janusgraph/pull/1615.patch","issue_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1615","number":1615,"state":"open","locked":false,"title":"Add support for raw lucene date range queries","user":{"login":"mad","id":56705,"node_id":"MDQ6VXNlcjU2NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/56705?v=4","gravatar_id":"","url":"https://api.github.com/users/mad","html_url":"https://github.com/mad","followers_url":"https://api.github.com/users/mad/followers","following_url":"https://api.github.com/users/mad/following{/other_user}","gists_url":"https://api.github.com/users/mad/gists{/gist_id}","starred_url":"https://api.github.com/users/mad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mad/subscriptions","organizations_url":"https://api.github.com/users/mad/orgs","repos_url":"https://api.github.com/users/mad/repos","events_url":"https://api.github.com/users/mad/events{/privacy}","received_events_url":"https://api.github.com/users/mad/received_events","type":"User","site_admin":false},"body":"fix for #1614\r\n\r\n-----\r\n\r\nThank you for contributing to JanusGraph!\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there an issue associated with this PR? Is it referenced in the commit message?\r\n- [ ] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [ ] Have you written and/or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)?\r\n- [ ] If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?\r\n- [ ] If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n- [ ] If this PR is a documentation-only change, have you added a `[skip ci]`\r\n tag to the first line of your commit message to avoid spending CPU cycles in\r\n Travis CI when no code, tests, or build configuration are modified?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.\r\n\r\n","created_at":"2019-06-04T12:20:19Z","updated_at":"2019-07-29T15:06:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e21140ba3484c022cbdef0b7209b598b87e264e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"analytically","id":254434,"node_id":"MDQ6VXNlcjI1NDQzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/254434?v=4","gravatar_id":"","url":"https://api.github.com/users/analytically","html_url":"https://github.com/analytically","followers_url":"https://api.github.com/users/analytically/followers","following_url":"https://api.github.com/users/analytically/following{/other_user}","gists_url":"https://api.github.com/users/analytically/gists{/gist_id}","starred_url":"https://api.github.com/users/analytically/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analytically/subscriptions","organizations_url":"https://api.github.com/users/analytically/orgs","repos_url":"https://api.github.com/users/analytically/repos","events_url":"https://api.github.com/users/analytically/events{/privacy}","received_events_url":"https://api.github.com/users/analytically/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":507215572,"node_id":"MDU6TGFiZWw1MDcyMTU1NzI=","url":"https://api.github.com/repos/JanusGraph/janusgraph/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/milestones/13","html_url":"https://github.com/JanusGraph/janusgraph/milestone/13","labels_url":"https://api.github.com/repos/JanusGraph/janusgraph/milestones/13/labels","id":4372241,"node_id":"MDk6TWlsZXN0b25lNDM3MjI0MQ==","number":13,"title":"Release v0.5.0","description":"","creator":{"login":"chupman","id":138927,"node_id":"MDQ6VXNlcjEzODkyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/138927?v=4","gravatar_id":"","url":"https://api.github.com/users/chupman","html_url":"https://github.com/chupman","followers_url":"https://api.github.com/users/chupman/followers","following_url":"https://api.github.com/users/chupman/following{/other_user}","gists_url":"https://api.github.com/users/chupman/gists{/gist_id}","starred_url":"https://api.github.com/users/chupman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chupman/subscriptions","organizations_url":"https://api.github.com/users/chupman/orgs","repos_url":"https://api.github.com/users/chupman/repos","events_url":"https://api.github.com/users/chupman/events{/privacy}","received_events_url":"https://api.github.com/users/chupman/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":14,"state":"open","created_at":"2019-06-03T21:02:59Z","updated_at":"2019-07-29T07:08:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615/commits","review_comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615/comments","review_comment_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1615/comments","statuses_url":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/23d0eb667cbd1ec023f7d2aa4e85cf6b5a7087cc","head":{"label":"mad:add-support-raw-lucene-range-date","ref":"add-support-raw-lucene-range-date","sha":"23d0eb667cbd1ec023f7d2aa4e85cf6b5a7087cc","user":{"login":"mad","id":56705,"node_id":"MDQ6VXNlcjU2NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/56705?v=4","gravatar_id":"","url":"https://api.github.com/users/mad","html_url":"https://github.com/mad","followers_url":"https://api.github.com/users/mad/followers","following_url":"https://api.github.com/users/mad/following{/other_user}","gists_url":"https://api.github.com/users/mad/gists{/gist_id}","starred_url":"https://api.github.com/users/mad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mad/subscriptions","organizations_url":"https://api.github.com/users/mad/orgs","repos_url":"https://api.github.com/users/mad/repos","events_url":"https://api.github.com/users/mad/events{/privacy}","received_events_url":"https://api.github.com/users/mad/received_events","type":"User","site_admin":false},"repo":{"id":167352512,"node_id":"MDEwOlJlcG9zaXRvcnkxNjczNTI1MTI=","name":"janusgraph","full_name":"mad/janusgraph","private":false,"owner":{"login":"mad","id":56705,"node_id":"MDQ6VXNlcjU2NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/56705?v=4","gravatar_id":"","url":"https://api.github.com/users/mad","html_url":"https://github.com/mad","followers_url":"https://api.github.com/users/mad/followers","following_url":"https://api.github.com/users/mad/following{/other_user}","gists_url":"https://api.github.com/users/mad/gists{/gist_id}","starred_url":"https://api.github.com/users/mad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mad/subscriptions","organizations_url":"https://api.github.com/users/mad/orgs","repos_url":"https://api.github.com/users/mad/repos","events_url":"https://api.github.com/users/mad/events{/privacy}","received_events_url":"https://api.github.com/users/mad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mad/janusgraph","description":"JanusGraph: an open-source, distributed graph database","fork":true,"url":"https://api.github.com/repos/mad/janusgraph","forks_url":"https://api.github.com/repos/mad/janusgraph/forks","keys_url":"https://api.github.com/repos/mad/janusgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mad/janusgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mad/janusgraph/teams","hooks_url":"https://api.github.com/repos/mad/janusgraph/hooks","issue_events_url":"https://api.github.com/repos/mad/janusgraph/issues/events{/number}","events_url":"https://api.github.com/repos/mad/janusgraph/events","assignees_url":"https://api.github.com/repos/mad/janusgraph/assignees{/user}","branches_url":"https://api.github.com/repos/mad/janusgraph/branches{/branch}","tags_url":"https://api.github.com/repos/mad/janusgraph/tags","blobs_url":"https://api.github.com/repos/mad/janusgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mad/janusgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mad/janusgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/mad/janusgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mad/janusgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/mad/janusgraph/languages","stargazers_url":"https://api.github.com/repos/mad/janusgraph/stargazers","contributors_url":"https://api.github.com/repos/mad/janusgraph/contributors","subscribers_url":"https://api.github.com/repos/mad/janusgraph/subscribers","subscription_url":"https://api.github.com/repos/mad/janusgraph/subscription","commits_url":"https://api.github.com/repos/mad/janusgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/mad/janusgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/mad/janusgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/mad/janusgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/mad/janusgraph/contents/{+path}","compare_url":"https://api.github.com/repos/mad/janusgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mad/janusgraph/merges","archive_url":"https://api.github.com/repos/mad/janusgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mad/janusgraph/downloads","issues_url":"https://api.github.com/repos/mad/janusgraph/issues{/number}","pulls_url":"https://api.github.com/repos/mad/janusgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/mad/janusgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/mad/janusgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mad/janusgraph/labels{/name}","releases_url":"https://api.github.com/repos/mad/janusgraph/releases{/id}","deployments_url":"https://api.github.com/repos/mad/janusgraph/deployments","created_at":"2019-01-24T10:55:39Z","updated_at":"2019-01-24T10:55:45Z","pushed_at":"2019-07-29T14:42:01Z","git_url":"git://github.com/mad/janusgraph.git","ssh_url":"git@github.com:mad/janusgraph.git","clone_url":"https://github.com/mad/janusgraph.git","svn_url":"https://github.com/mad/janusgraph","homepage":"http://janusgraph.org","size":52182,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JanusGraph:master","ref":"master","sha":"56d9aeed73486fa8831fb18dbe79f2442994ebd4","user":{"login":"JanusGraph","id":23411090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDExMDkw","avatar_url":"https://avatars1.githubusercontent.com/u/23411090?v=4","gravatar_id":"","url":"https://api.github.com/users/JanusGraph","html_url":"https://github.com/JanusGraph","followers_url":"https://api.github.com/users/JanusGraph/followers","following_url":"https://api.github.com/users/JanusGraph/following{/other_user}","gists_url":"https://api.github.com/users/JanusGraph/gists{/gist_id}","starred_url":"https://api.github.com/users/JanusGraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanusGraph/subscriptions","organizations_url":"https://api.github.com/users/JanusGraph/orgs","repos_url":"https://api.github.com/users/JanusGraph/repos","events_url":"https://api.github.com/users/JanusGraph/events{/privacy}","received_events_url":"https://api.github.com/users/JanusGraph/received_events","type":"Organization","site_admin":false},"repo":{"id":77385607,"node_id":"MDEwOlJlcG9zaXRvcnk3NzM4NTYwNw==","name":"janusgraph","full_name":"JanusGraph/janusgraph","private":false,"owner":{"login":"JanusGraph","id":23411090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDExMDkw","avatar_url":"https://avatars1.githubusercontent.com/u/23411090?v=4","gravatar_id":"","url":"https://api.github.com/users/JanusGraph","html_url":"https://github.com/JanusGraph","followers_url":"https://api.github.com/users/JanusGraph/followers","following_url":"https://api.github.com/users/JanusGraph/following{/other_user}","gists_url":"https://api.github.com/users/JanusGraph/gists{/gist_id}","starred_url":"https://api.github.com/users/JanusGraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanusGraph/subscriptions","organizations_url":"https://api.github.com/users/JanusGraph/orgs","repos_url":"https://api.github.com/users/JanusGraph/repos","events_url":"https://api.github.com/users/JanusGraph/events{/privacy}","received_events_url":"https://api.github.com/users/JanusGraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JanusGraph/janusgraph","description":"JanusGraph: an open-source, distributed graph database","fork":false,"url":"https://api.github.com/repos/JanusGraph/janusgraph","forks_url":"https://api.github.com/repos/JanusGraph/janusgraph/forks","keys_url":"https://api.github.com/repos/JanusGraph/janusgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JanusGraph/janusgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JanusGraph/janusgraph/teams","hooks_url":"https://api.github.com/repos/JanusGraph/janusgraph/hooks","issue_events_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/events{/number}","events_url":"https://api.github.com/repos/JanusGraph/janusgraph/events","assignees_url":"https://api.github.com/repos/JanusGraph/janusgraph/assignees{/user}","branches_url":"https://api.github.com/repos/JanusGraph/janusgraph/branches{/branch}","tags_url":"https://api.github.com/repos/JanusGraph/janusgraph/tags","blobs_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/JanusGraph/janusgraph/languages","stargazers_url":"https://api.github.com/repos/JanusGraph/janusgraph/stargazers","contributors_url":"https://api.github.com/repos/JanusGraph/janusgraph/contributors","subscribers_url":"https://api.github.com/repos/JanusGraph/janusgraph/subscribers","subscription_url":"https://api.github.com/repos/JanusGraph/janusgraph/subscription","commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/JanusGraph/janusgraph/contents/{+path}","compare_url":"https://api.github.com/repos/JanusGraph/janusgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JanusGraph/janusgraph/merges","archive_url":"https://api.github.com/repos/JanusGraph/janusgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JanusGraph/janusgraph/downloads","issues_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues{/number}","pulls_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/JanusGraph/janusgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/JanusGraph/janusgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JanusGraph/janusgraph/labels{/name}","releases_url":"https://api.github.com/repos/JanusGraph/janusgraph/releases{/id}","deployments_url":"https://api.github.com/repos/JanusGraph/janusgraph/deployments","created_at":"2016-12-26T13:26:29Z","updated_at":"2019-07-29T07:07:59Z","pushed_at":"2019-07-29T14:48:44Z","git_url":"git://github.com/JanusGraph/janusgraph.git","ssh_url":"git@github.com:JanusGraph/janusgraph.git","clone_url":"https://github.com/JanusGraph/janusgraph.git","svn_url":"https://github.com/JanusGraph/janusgraph","homepage":"https://janusgraph.org","size":52159,"stargazers_count":2576,"watchers_count":2576,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":624,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":390,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":624,"open_issues":390,"watchers":2576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615"},"html":{"href":"https://github.com/JanusGraph/janusgraph/pull/1615"},"issue":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1615"},"comments":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/issues/1615/comments"},"review_comments":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615/comments"},"review_comment":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/1615/commits"},"statuses":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/23d0eb667cbd1ec023f7d2aa4e85cf6b5a7087cc"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 77385607,
"name": "JanusGraph/janusgraph",
"url": "https://api.github.com/repos/JanusGraph/janusgraph"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 23411090,
"login": "JanusGraph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23411090?",
"url": "https://api.github.com/orgs/JanusGraph"
}
| 2019-07-29T15:06:43 |
10104194843
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/261062029","pull_request_review_id":208908752,"id":261062029,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MTA2MjAyOQ==","diff_hunk":"@@ -53,6 +70,44 @@ def full_name(self):\n \"\"\"\n return self._full_name\n \n+ @property\n+ def param_attr(self):\n+ return self._helper.param_attr\n+\n+ @property\n+ def bias_attr(self):\n+ return self._helper.bias_attr\n+\n+ def create_parameter(self,\n+ attr,\n+ shape,\n+ dtype,\n+ is_bias=False,\n+ default_initializer=None):\n+ return self._helper.create_parameter(attr, shape, dtype, is_bias,\n+ default_initializer)\n+\n+ def get_parameter(self, name):\n+ return self._helper.get_parameter(name)\n+\n+ def create_variable_for_type_inference(self, dtype, stop_gradient=False):\n+ return self._helper.create_variable_for_type_inference(dtype,\n+ stop_gradient)\n+\n+ def create_variable(self, *args, **kwargs):","path":"python/paddle/fluid/imperative/layers.py","position":71,"original_position":71,"commit_id":"8ce71e54d2e178751448e93e34b2b4a4606389fe","original_commit_id":"8ce71e54d2e178751448e93e34b2b4a4606389fe","user":{"login":"panyx0718","id":2887803,"node_id":"MDQ6VXNlcjI4ODc4MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2887803?v=4","gravatar_id":"","url":"https://api.github.com/users/panyx0718","html_url":"https://github.com/panyx0718","followers_url":"https://api.github.com/users/panyx0718/followers","following_url":"https://api.github.com/users/panyx0718/following{/other_user}","gists_url":"https://api.github.com/users/panyx0718/gists{/gist_id}","starred_url":"https://api.github.com/users/panyx0718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panyx0718/subscriptions","organizations_url":"https://api.github.com/users/panyx0718/orgs","repos_url":"https://api.github.com/users/panyx0718/repos","events_url":"https://api.github.com/users/panyx0718/events{/privacy}","received_events_url":"https://api.github.com/users/panyx0718/received_events","type":"User","site_admin":false},"body":"no args and kwargs.","created_at":"2019-02-28T06:36:31Z","updated_at":"2019-02-28T06:37:03Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/15938#discussion_r261062029","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/261062029"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/15938#discussion_r261062029"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938","id":256243712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MjQzNzEy","html_url":"https://github.com/PaddlePaddle/Paddle/pull/15938","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/15938.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/15938.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/15938","number":15938,"state":"open","locked":false,"title":"test=develop, reconstruct layer helper to fit imperative usage","user":{"login":"JiabinYang","id":22361972,"node_id":"MDQ6VXNlcjIyMzYxOTcy","avatar_url":"https://avatars2.githubusercontent.com/u/22361972?v=4","gravatar_id":"","url":"https://api.github.com/users/JiabinYang","html_url":"https://github.com/JiabinYang","followers_url":"https://api.github.com/users/JiabinYang/followers","following_url":"https://api.github.com/users/JiabinYang/following{/other_user}","gists_url":"https://api.github.com/users/JiabinYang/gists{/gist_id}","starred_url":"https://api.github.com/users/JiabinYang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiabinYang/subscriptions","organizations_url":"https://api.github.com/users/JiabinYang/orgs","repos_url":"https://api.github.com/users/JiabinYang/repos","events_url":"https://api.github.com/users/JiabinYang/events{/privacy}","received_events_url":"https://api.github.com/users/JiabinYang/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-26T11:23:08Z","updated_at":"2019-02-28T06:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e50d0ac1d8a4422b1282fd552c09cf5ad9a82e9a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/15938/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/8ce71e54d2e178751448e93e34b2b4a4606389fe","head":{"label":"JiabinYang:feature/layerHeper_refine","ref":"feature/layerHeper_refine","sha":"8ce71e54d2e178751448e93e34b2b4a4606389fe","user":{"login":"JiabinYang","id":22361972,"node_id":"MDQ6VXNlcjIyMzYxOTcy","avatar_url":"https://avatars2.githubusercontent.com/u/22361972?v=4","gravatar_id":"","url":"https://api.github.com/users/JiabinYang","html_url":"https://github.com/JiabinYang","followers_url":"https://api.github.com/users/JiabinYang/followers","following_url":"https://api.github.com/users/JiabinYang/following{/other_user}","gists_url":"https://api.github.com/users/JiabinYang/gists{/gist_id}","starred_url":"https://api.github.com/users/JiabinYang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiabinYang/subscriptions","organizations_url":"https://api.github.com/users/JiabinYang/orgs","repos_url":"https://api.github.com/users/JiabinYang/repos","events_url":"https://api.github.com/users/JiabinYang/events{/privacy}","received_events_url":"https://api.github.com/users/JiabinYang/received_events","type":"User","site_admin":false},"repo":{"id":148290300,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyOTAzMDA=","name":"Paddle","full_name":"JiabinYang/Paddle","private":false,"owner":{"login":"JiabinYang","id":22361972,"node_id":"MDQ6VXNlcjIyMzYxOTcy","avatar_url":"https://avatars2.githubusercontent.com/u/22361972?v=4","gravatar_id":"","url":"https://api.github.com/users/JiabinYang","html_url":"https://github.com/JiabinYang","followers_url":"https://api.github.com/users/JiabinYang/followers","following_url":"https://api.github.com/users/JiabinYang/following{/other_user}","gists_url":"https://api.github.com/users/JiabinYang/gists{/gist_id}","starred_url":"https://api.github.com/users/JiabinYang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiabinYang/subscriptions","organizations_url":"https://api.github.com/users/JiabinYang/orgs","repos_url":"https://api.github.com/users/JiabinYang/repos","events_url":"https://api.github.com/users/JiabinYang/events{/privacy}","received_events_url":"https://api.github.com/users/JiabinYang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JiabinYang/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/JiabinYang/Paddle","forks_url":"https://api.github.com/repos/JiabinYang/Paddle/forks","keys_url":"https://api.github.com/repos/JiabinYang/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiabinYang/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiabinYang/Paddle/teams","hooks_url":"https://api.github.com/repos/JiabinYang/Paddle/hooks","issue_events_url":"https://api.github.com/repos/JiabinYang/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/JiabinYang/Paddle/events","assignees_url":"https://api.github.com/repos/JiabinYang/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/JiabinYang/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/JiabinYang/Paddle/tags","blobs_url":"https://api.github.com/repos/JiabinYang/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiabinYang/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiabinYang/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiabinYang/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiabinYang/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/JiabinYang/Paddle/languages","stargazers_url":"https://api.github.com/repos/JiabinYang/Paddle/stargazers","contributors_url":"https://api.github.com/repos/JiabinYang/Paddle/contributors","subscribers_url":"https://api.github.com/repos/JiabinYang/Paddle/subscribers","subscription_url":"https://api.github.com/repos/JiabinYang/Paddle/subscription","commits_url":"https://api.github.com/repos/JiabinYang/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiabinYang/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiabinYang/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiabinYang/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiabinYang/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/JiabinYang/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiabinYang/Paddle/merges","archive_url":"https://api.github.com/repos/JiabinYang/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiabinYang/Paddle/downloads","issues_url":"https://api.github.com/repos/JiabinYang/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/JiabinYang/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/JiabinYang/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/JiabinYang/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiabinYang/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/JiabinYang/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/JiabinYang/Paddle/deployments","created_at":"2018-09-11T09:06:53Z","updated_at":"2019-02-14T12:04:39Z","pushed_at":"2019-02-28T02:20:54Z","git_url":"git://github.com/JiabinYang/Paddle.git","ssh_url":"git@github.com:JiabinYang/Paddle.git","clone_url":"https://github.com/JiabinYang/Paddle.git","svn_url":"https://github.com/JiabinYang/Paddle","homepage":"http://www.paddlepaddle.org/","size":149032,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"effec866004b2a06b12367e2bbcdcd8fcc7d15aa","user":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"node_id":"MDEwOlJlcG9zaXRvcnk2NTcxMTUyMg==","name":"Paddle","full_name":"PaddlePaddle/Paddle","private":false,"owner":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning （PaddlePaddle核心框架，高性能单机、分布式训练和跨平台部署）","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2019-02-28T06:06:02Z","pushed_at":"2019-02-28T06:24:17Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"git@github.com:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":149750,"stargazers_count":8183,"watchers_count":8183,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2223,"mirror_url":null,"archived":false,"open_issues_count":766,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2223,"open_issues":766,"watchers":8183,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/15938"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/15938"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/15938/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/15938/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/8ce71e54d2e178751448e93e34b2b4a4606389fe"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 65711522,
"name": "PaddlePaddle/Paddle",
"url": "https://api.github.com/repos/PaddlePaddle/Paddle"
}
|
{
"id": 2887803,
"login": "panyx0718",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2887803?",
"url": "https://api.github.com/users/panyx0718"
}
|
{
"id": 23534030,
"login": "PaddlePaddle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534030?",
"url": "https://api.github.com/orgs/PaddlePaddle"
}
| 2019-02-28T06:36:31 |
9152295400
|
{"actor":{"display_login":"panyx0718"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/comments/275897460","pull_request_review_id":227322645,"id":275897460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTg5NzQ2MA==","diff_hunk":"@@ -0,0 +1,54 @@\n+using UnityEngine;\n+\n+namespace Fps\n+{\n+ public class DefaultConnectState : DefaultState\n+ {\n+ public DefaultConnectState(UIManager manager, ConnectionStateMachine owner) : base(manager, owner)\n+ {\n+ }\n+\n+ public override void StartState()\n+ {\n+ DefaultConnectScreenManager.ConnectButton.enabled = false;\n+ DefaultConnectScreenManager.ConnectButton.onClick.AddListener(Connect);\n+ Connect();\n+ }\n+\n+ public override void Tick()\n+ {\n+ if (Owner.ClientConnector == null)\n+ {\n+ DefaultConnectScreenManager.ConnectButton.enabled = true;\n+ Animator.SetTrigger(\"FailedToConnect\");","path":"workers/unity/Assets/Fps/Scripts/GameLogic/StateMachine/Default/DefaultConnectState.cs","position":23,"original_position":23,"commit_id":"a268bee479fc2b10504ac1ed6cc1572b50e1756e","original_commit_id":"a268bee479fc2b10504ac1ed6cc1572b50e1756e","user":{"login":"jessicafalk","id":31853332,"node_id":"MDQ6VXNlcjMxODUzMzMy","avatar_url":"https://avatars3.githubusercontent.com/u/31853332?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicafalk","html_url":"https://github.com/jessicafalk","followers_url":"https://api.github.com/users/jessicafalk/followers","following_url":"https://api.github.com/users/jessicafalk/following{/other_user}","gists_url":"https://api.github.com/users/jessicafalk/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicafalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicafalk/subscriptions","organizations_url":"https://api.github.com/users/jessicafalk/orgs","repos_url":"https://api.github.com/users/jessicafalk/repos","events_url":"https://api.github.com/users/jessicafalk/events{/privacy}","received_events_url":"https://api.github.com/users/jessicafalk/received_events","type":"User","site_admin":false},"body":"it does... but I'm not refactoring the animator in this PR. This needs to be part of a separate PR","created_at":"2019-04-16T16:55:26Z","updated_at":"2019-04-16T16:55:26Z","html_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/158#discussion_r275897460","pull_request_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/comments/275897460"},"html":{"href":"https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/158#discussion_r275897460"},"pull_request":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158"}},"in_reply_to_id":275818691},"pull_request":{"url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158","id":269620941,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5NjIwOTQx","html_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/158","diff_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/158.diff","patch_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/158.patch","issue_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/158","number":158,"state":"open","locked":false,"title":"Session-based gameplay","user":{"login":"jessicafalk","id":31853332,"node_id":"MDQ6VXNlcjMxODUzMzMy","avatar_url":"https://avatars3.githubusercontent.com/u/31853332?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicafalk","html_url":"https://github.com/jessicafalk","followers_url":"https://api.github.com/users/jessicafalk/followers","following_url":"https://api.github.com/users/jessicafalk/following{/other_user}","gists_url":"https://api.github.com/users/jessicafalk/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicafalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicafalk/subscriptions","organizations_url":"https://api.github.com/users/jessicafalk/orgs","repos_url":"https://api.github.com/users/jessicafalk/repos","events_url":"https://api.github.com/users/jessicafalk/events{/privacy}","received_events_url":"https://api.github.com/users/jessicafalk/received_events","type":"User","site_admin":false},"body":"#### Description\r\nAdded session-based gameplay. It is hidden behind a feature flag.\r\nRead in commit order and skip prefabs, .. etc.\r\n\r\nStill need to:\r\n\r\n- [ ] thoroughly test both standard and session flow\r\n- [ ] Test iOS\r\n- [ ] Test Android\r\n\r\n#### Tests\r\nran it multiple times locally and in cloud on Windows\r\n\r\n#### Documentation\r\ncoming soon\r\n","created_at":"2019-04-11T15:20:25Z","updated_at":"2019-04-16T16:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9439547048662d3a0212730f245fafe4b473ac14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158/commits","review_comments_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158/comments","review_comment_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/158/comments","statuses_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/statuses/a268bee479fc2b10504ac1ed6cc1572b50e1756e","head":{"label":"spatialos:feature/sessions-rework","ref":"feature/sessions-rework","sha":"a268bee479fc2b10504ac1ed6cc1572b50e1756e","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":152123385,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMjMzODU=","name":"gdk-for-unity-fps-starter-project","full_name":"spatialos/gdk-for-unity-fps-starter-project","private":false,"owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project","description":"SpatialOS GDK for Unity FPS Starter Project","fork":false,"url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project","forks_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/forks","keys_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/teams","hooks_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/hooks","issue_events_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/events","assignees_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/tags","blobs_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/languages","stargazers_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/stargazers","contributors_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/contributors","subscribers_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/subscribers","subscription_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/subscription","commits_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/merges","archive_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/downloads","issues_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/deployments","created_at":"2018-10-08T17:59:47Z","updated_at":"2019-04-15T14:50:38Z","pushed_at":"2019-04-16T12:54:24Z","git_url":"git://github.com/spatialos/gdk-for-unity-fps-starter-project.git","ssh_url":"git@github.com:spatialos/gdk-for-unity-fps-starter-project.git","clone_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project.git","svn_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project","homepage":"https://gdk.improbable.io/spatialos-gdk-unity","size":407763,"stargazers_count":56,"watchers_count":56,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":6,"watchers":56,"default_branch":"master"}},"base":{"label":"spatialos:develop","ref":"develop","sha":"4af1187ad5e9b9f3ecc0ec4bbd7e67ed751d4bc5","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":152123385,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMjMzODU=","name":"gdk-for-unity-fps-starter-project","full_name":"spatialos/gdk-for-unity-fps-starter-project","private":false,"owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project","description":"SpatialOS GDK for Unity FPS Starter Project","fork":false,"url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project","forks_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/forks","keys_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/teams","hooks_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/hooks","issue_events_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/events","assignees_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/tags","blobs_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/languages","stargazers_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/stargazers","contributors_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/contributors","subscribers_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/subscribers","subscription_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/subscription","commits_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/merges","archive_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/downloads","issues_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/deployments","created_at":"2018-10-08T17:59:47Z","updated_at":"2019-04-15T14:50:38Z","pushed_at":"2019-04-16T12:54:24Z","git_url":"git://github.com/spatialos/gdk-for-unity-fps-starter-project.git","ssh_url":"git@github.com:spatialos/gdk-for-unity-fps-starter-project.git","clone_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project.git","svn_url":"https://github.com/spatialos/gdk-for-unity-fps-starter-project","homepage":"https://gdk.improbable.io/spatialos-gdk-unity","size":407763,"stargazers_count":56,"watchers_count":56,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":6,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158"},"html":{"href":"https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/158"},"issue":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/158"},"comments":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project/statuses/a268bee479fc2b10504ac1ed6cc1572b50e1756e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 152123385,
"name": "spatialos/gdk-for-unity-fps-starter-project",
"url": "https://api.github.com/repos/spatialos/gdk-for-unity-fps-starter-project"
}
|
{
"id": 31853332,
"login": "jessicafalk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31853332?",
"url": "https://api.github.com/users/jessicafalk"
}
|
{
"id": 23554165,
"login": "spatialos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23554165?",
"url": "https://api.github.com/orgs/spatialos"
}
| 2019-04-16T16:55:26 |
9454911192
|
{"actor":{"display_login":"jessicafalk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nrwl/nx/pulls/comments/306015977","pull_request_review_id":265035383,"id":306015977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjAxNTk3Nw==","diff_hunk":"@@ -38,9 +38,14 @@ export class WorkspaceResults {\n this.commandResults = commandResults;\n }\n } catch (e) {\n+ /**","path":"packages/workspace/src/command-line/workspace-results.ts","position":13,"original_position":13,"commit_id":"0d3fcdaf8aefbc80784d9b3aa05dec68a2fee3a6","original_commit_id":"b6e5f2f0b6f8d9b11aa3be62eda5211300a25f22","user":{"login":"vsavkin","id":35996,"node_id":"MDQ6VXNlcjM1OTk2","avatar_url":"https://avatars0.githubusercontent.com/u/35996?v=4","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"body":"we can remove the logging","created_at":"2019-07-22T20:23:39Z","updated_at":"2019-07-22T20:23:39Z","html_url":"https://github.com/nrwl/nx/pull/1596#discussion_r306015977","pull_request_url":"https://api.github.com/repos/nrwl/nx/pulls/1596","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nrwl/nx/pulls/comments/306015977"},"html":{"href":"https://github.com/nrwl/nx/pull/1596#discussion_r306015977"},"pull_request":{"href":"https://api.github.com/repos/nrwl/nx/pulls/1596"}},"in_reply_to_id":305150467},"pull_request":{"url":"https://api.github.com/repos/nrwl/nx/pulls/1596","id":299125973,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5MTI1OTcz","html_url":"https://github.com/nrwl/nx/pull/1596","diff_url":"https://github.com/nrwl/nx/pull/1596.diff","patch_url":"https://github.com/nrwl/nx/pull/1596.patch","issue_url":"https://api.github.com/repos/nrwl/nx/issues/1596","number":1596,"state":"open","locked":false,"title":"chore: improved logging design and consistency","user":{"login":"JamesHenry","id":900523,"node_id":"MDQ6VXNlcjkwMDUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/900523?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesHenry","html_url":"https://github.com/JamesHenry","followers_url":"https://api.github.com/users/JamesHenry/followers","following_url":"https://api.github.com/users/JamesHenry/following{/other_user}","gists_url":"https://api.github.com/users/JamesHenry/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesHenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesHenry/subscriptions","organizations_url":"https://api.github.com/users/JamesHenry/orgs","repos_url":"https://api.github.com/users/JamesHenry/repos","events_url":"https://api.github.com/users/JamesHenry/events{/privacy}","received_events_url":"https://api.github.com/users/JamesHenry/received_events","type":"User","site_admin":false},"body":"Examples:\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2019-07-18T23:11:09Z","updated_at":"2019-07-22T20:23:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13a9173e4e8154aee87a33d1ad9c9b3b4c017cba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nrwl/nx/pulls/1596/commits","review_comments_url":"https://api.github.com/repos/nrwl/nx/pulls/1596/comments","review_comment_url":"https://api.github.com/repos/nrwl/nx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nrwl/nx/issues/1596/comments","statuses_url":"https://api.github.com/repos/nrwl/nx/statuses/0d3fcdaf8aefbc80784d9b3aa05dec68a2fee3a6","head":{"label":"JamesHenry:cli-output","ref":"cli-output","sha":"0d3fcdaf8aefbc80784d9b3aa05dec68a2fee3a6","user":{"login":"JamesHenry","id":900523,"node_id":"MDQ6VXNlcjkwMDUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/900523?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesHenry","html_url":"https://github.com/JamesHenry","followers_url":"https://api.github.com/users/JamesHenry/followers","following_url":"https://api.github.com/users/JamesHenry/following{/other_user}","gists_url":"https://api.github.com/users/JamesHenry/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesHenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesHenry/subscriptions","organizations_url":"https://api.github.com/users/JamesHenry/orgs","repos_url":"https://api.github.com/users/JamesHenry/repos","events_url":"https://api.github.com/users/JamesHenry/events{/privacy}","received_events_url":"https://api.github.com/users/JamesHenry/received_events","type":"User","site_admin":false},"repo":{"id":129535177,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk1MzUxNzc=","name":"nx","full_name":"JamesHenry/nx","private":false,"owner":{"login":"JamesHenry","id":900523,"node_id":"MDQ6VXNlcjkwMDUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/900523?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesHenry","html_url":"https://github.com/JamesHenry","followers_url":"https://api.github.com/users/JamesHenry/followers","following_url":"https://api.github.com/users/JamesHenry/following{/other_user}","gists_url":"https://api.github.com/users/JamesHenry/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesHenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesHenry/subscriptions","organizations_url":"https://api.github.com/users/JamesHenry/orgs","repos_url":"https://api.github.com/users/JamesHenry/repos","events_url":"https://api.github.com/users/JamesHenry/events{/privacy}","received_events_url":"https://api.github.com/users/JamesHenry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JamesHenry/nx","description":"Nrwl Extensions for Angular","fork":true,"url":"https://api.github.com/repos/JamesHenry/nx","forks_url":"https://api.github.com/repos/JamesHenry/nx/forks","keys_url":"https://api.github.com/repos/JamesHenry/nx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JamesHenry/nx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JamesHenry/nx/teams","hooks_url":"https://api.github.com/repos/JamesHenry/nx/hooks","issue_events_url":"https://api.github.com/repos/JamesHenry/nx/issues/events{/number}","events_url":"https://api.github.com/repos/JamesHenry/nx/events","assignees_url":"https://api.github.com/repos/JamesHenry/nx/assignees{/user}","branches_url":"https://api.github.com/repos/JamesHenry/nx/branches{/branch}","tags_url":"https://api.github.com/repos/JamesHenry/nx/tags","blobs_url":"https://api.github.com/repos/JamesHenry/nx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JamesHenry/nx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JamesHenry/nx/git/refs{/sha}","trees_url":"https://api.github.com/repos/JamesHenry/nx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JamesHenry/nx/statuses/{sha}","languages_url":"https://api.github.com/repos/JamesHenry/nx/languages","stargazers_url":"https://api.github.com/repos/JamesHenry/nx/stargazers","contributors_url":"https://api.github.com/repos/JamesHenry/nx/contributors","subscribers_url":"https://api.github.com/repos/JamesHenry/nx/subscribers","subscription_url":"https://api.github.com/repos/JamesHenry/nx/subscription","commits_url":"https://api.github.com/repos/JamesHenry/nx/commits{/sha}","git_commits_url":"https://api.github.com/repos/JamesHenry/nx/git/commits{/sha}","comments_url":"https://api.github.com/repos/JamesHenry/nx/comments{/number}","issue_comment_url":"https://api.github.com/repos/JamesHenry/nx/issues/comments{/number}","contents_url":"https://api.github.com/repos/JamesHenry/nx/contents/{+path}","compare_url":"https://api.github.com/repos/JamesHenry/nx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JamesHenry/nx/merges","archive_url":"https://api.github.com/repos/JamesHenry/nx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JamesHenry/nx/downloads","issues_url":"https://api.github.com/repos/JamesHenry/nx/issues{/number}","pulls_url":"https://api.github.com/repos/JamesHenry/nx/pulls{/number}","milestones_url":"https://api.github.com/repos/JamesHenry/nx/milestones{/number}","notifications_url":"https://api.github.com/repos/JamesHenry/nx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JamesHenry/nx/labels{/name}","releases_url":"https://api.github.com/repos/JamesHenry/nx/releases{/id}","deployments_url":"https://api.github.com/repos/JamesHenry/nx/deployments","created_at":"2018-04-14T16:35:38Z","updated_at":"2019-07-15T15:13:18Z","pushed_at":"2019-07-22T17:58:16Z","git_url":"git://github.com/JamesHenry/nx.git","ssh_url":"git@github.com:JamesHenry/nx.git","clone_url":"https://github.com/JamesHenry/nx.git","svn_url":"https://github.com/JamesHenry/nx","homepage":"http://nrwl.io/nx","size":9055,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nrwl:master","ref":"master","sha":"2c81cc02edde656d95c2076ec999e71ee2980047","user":{"login":"nrwl","id":23692104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjkyMTA0","avatar_url":"https://avatars3.githubusercontent.com/u/23692104?v=4","gravatar_id":"","url":"https://api.github.com/users/nrwl","html_url":"https://github.com/nrwl","followers_url":"https://api.github.com/users/nrwl/followers","following_url":"https://api.github.com/users/nrwl/following{/other_user}","gists_url":"https://api.github.com/users/nrwl/gists{/gist_id}","starred_url":"https://api.github.com/users/nrwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrwl/subscriptions","organizations_url":"https://api.github.com/users/nrwl/orgs","repos_url":"https://api.github.com/users/nrwl/repos","events_url":"https://api.github.com/users/nrwl/events{/privacy}","received_events_url":"https://api.github.com/users/nrwl/received_events","type":"Organization","site_admin":false},"repo":{"id":100061716,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwNjE3MTY=","name":"nx","full_name":"nrwl/nx","private":false,"owner":{"login":"nrwl","id":23692104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjkyMTA0","avatar_url":"https://avatars3.githubusercontent.com/u/23692104?v=4","gravatar_id":"","url":"https://api.github.com/users/nrwl","html_url":"https://github.com/nrwl","followers_url":"https://api.github.com/users/nrwl/followers","following_url":"https://api.github.com/users/nrwl/following{/other_user}","gists_url":"https://api.github.com/users/nrwl/gists{/gist_id}","starred_url":"https://api.github.com/users/nrwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrwl/subscriptions","organizations_url":"https://api.github.com/users/nrwl/orgs","repos_url":"https://api.github.com/users/nrwl/repos","events_url":"https://api.github.com/users/nrwl/events{/privacy}","received_events_url":"https://api.github.com/users/nrwl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nrwl/nx","description":"Extensible Dev Tools for Monorepos","fork":false,"url":"https://api.github.com/repos/nrwl/nx","forks_url":"https://api.github.com/repos/nrwl/nx/forks","keys_url":"https://api.github.com/repos/nrwl/nx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrwl/nx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrwl/nx/teams","hooks_url":"https://api.github.com/repos/nrwl/nx/hooks","issue_events_url":"https://api.github.com/repos/nrwl/nx/issues/events{/number}","events_url":"https://api.github.com/repos/nrwl/nx/events","assignees_url":"https://api.github.com/repos/nrwl/nx/assignees{/user}","branches_url":"https://api.github.com/repos/nrwl/nx/branches{/branch}","tags_url":"https://api.github.com/repos/nrwl/nx/tags","blobs_url":"https://api.github.com/repos/nrwl/nx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrwl/nx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrwl/nx/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrwl/nx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrwl/nx/statuses/{sha}","languages_url":"https://api.github.com/repos/nrwl/nx/languages","stargazers_url":"https://api.github.com/repos/nrwl/nx/stargazers","contributors_url":"https://api.github.com/repos/nrwl/nx/contributors","subscribers_url":"https://api.github.com/repos/nrwl/nx/subscribers","subscription_url":"https://api.github.com/repos/nrwl/nx/subscription","commits_url":"https://api.github.com/repos/nrwl/nx/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrwl/nx/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrwl/nx/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrwl/nx/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrwl/nx/contents/{+path}","compare_url":"https://api.github.com/repos/nrwl/nx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrwl/nx/merges","archive_url":"https://api.github.com/repos/nrwl/nx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrwl/nx/downloads","issues_url":"https://api.github.com/repos/nrwl/nx/issues{/number}","pulls_url":"https://api.github.com/repos/nrwl/nx/pulls{/number}","milestones_url":"https://api.github.com/repos/nrwl/nx/milestones{/number}","notifications_url":"https://api.github.com/repos/nrwl/nx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrwl/nx/labels{/name}","releases_url":"https://api.github.com/repos/nrwl/nx/releases{/id}","deployments_url":"https://api.github.com/repos/nrwl/nx/deployments","created_at":"2017-08-11T18:50:23Z","updated_at":"2019-07-22T18:01:57Z","pushed_at":"2019-07-22T17:58:18Z","git_url":"git://github.com/nrwl/nx.git","ssh_url":"git@github.com:nrwl/nx.git","clone_url":"https://github.com/nrwl/nx.git","svn_url":"https://github.com/nrwl/nx","homepage":"https://nx.dev","size":9047,"stargazers_count":1571,"watchers_count":1571,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":201,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":244,"open_issues":201,"watchers":1571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nrwl/nx/pulls/1596"},"html":{"href":"https://github.com/nrwl/nx/pull/1596"},"issue":{"href":"https://api.github.com/repos/nrwl/nx/issues/1596"},"comments":{"href":"https://api.github.com/repos/nrwl/nx/issues/1596/comments"},"review_comments":{"href":"https://api.github.com/repos/nrwl/nx/pulls/1596/comments"},"review_comment":{"href":"https://api.github.com/repos/nrwl/nx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nrwl/nx/pulls/1596/commits"},"statuses":{"href":"https://api.github.com/repos/nrwl/nx/statuses/0d3fcdaf8aefbc80784d9b3aa05dec68a2fee3a6"}},"author_association":"MEMBER"}}
|
{
"id": 100061716,
"name": "nrwl/nx",
"url": "https://api.github.com/repos/nrwl/nx"
}
|
{
"id": 35996,
"login": "vsavkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35996?",
"url": "https://api.github.com/users/vsavkin"
}
|
{
"id": 23692104,
"login": "nrwl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23692104?",
"url": "https://api.github.com/orgs/nrwl"
}
| 2019-07-22T20:23:39 |
10061060923
|
{"actor":{"display_login":"vsavkin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wagtail/wagtail/pulls/comments/271215677","pull_request_review_id":221551438,"id":271215677,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTIxNTY3Nw==","diff_hunk":"@@ -42,35 +42,6 @@ def nested_form_data(data):\n return {'-'.join(key): value for key, value in _nested_form_data(data)}\n \n \n-def streamfield(items):","path":"wagtail/tests/utils/form_data.py","position":4,"original_position":4,"commit_id":"cb312f3ab8c877c30e1cf8c5b3cac1a615c28d02","original_commit_id":"cb312f3ab8c877c30e1cf8c5b3cac1a615c28d02","user":{"login":"BertrandBordage","id":1119169,"node_id":"MDQ6VXNlcjExMTkxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1119169?v=4","gravatar_id":"","url":"https://api.github.com/users/BertrandBordage","html_url":"https://github.com/BertrandBordage","followers_url":"https://api.github.com/users/BertrandBordage/followers","following_url":"https://api.github.com/users/BertrandBordage/following{/other_user}","gists_url":"https://api.github.com/users/BertrandBordage/gists{/gist_id}","starred_url":"https://api.github.com/users/BertrandBordage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertrandBordage/subscriptions","organizations_url":"https://api.github.com/users/BertrandBordage/orgs","repos_url":"https://api.github.com/users/BertrandBordage/repos","events_url":"https://api.github.com/users/BertrandBordage/events{/privacy}","received_events_url":"https://api.github.com/users/BertrandBordage/received_events","type":"User","site_admin":false},"body":"OK, I revert that.","created_at":"2019-04-02T09:41:35Z","updated_at":"2019-04-02T09:41:35Z","html_url":"https://github.com/wagtail/wagtail/pull/4942#discussion_r271215677","pull_request_url":"https://api.github.com/repos/wagtail/wagtail/pulls/4942","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/comments/271215677"},"html":{"href":"https://github.com/wagtail/wagtail/pull/4942#discussion_r271215677"},"pull_request":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/4942"}},"in_reply_to_id":269078974},"pull_request":{"url":"https://api.github.com/repos/wagtail/wagtail/pulls/4942","id":236041867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDQxODY3","html_url":"https://github.com/wagtail/wagtail/pull/4942","diff_url":"https://github.com/wagtail/wagtail/pull/4942.diff","patch_url":"https://github.com/wagtail/wagtail/pull/4942.patch","issue_url":"https://api.github.com/repos/wagtail/wagtail/issues/4942","number":4942,"state":"open","locked":false,"title":"Implements the new StreamField based on react-streamfield.","user":{"login":"BertrandBordage","id":1119169,"node_id":"MDQ6VXNlcjExMTkxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1119169?v=4","gravatar_id":"","url":"https://api.github.com/users/BertrandBordage","html_url":"https://github.com/BertrandBordage","followers_url":"https://api.github.com/users/BertrandBordage/followers","following_url":"https://api.github.com/users/BertrandBordage/following{/other_user}","gists_url":"https://api.github.com/users/BertrandBordage/gists{/gist_id}","starred_url":"https://api.github.com/users/BertrandBordage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertrandBordage/subscriptions","organizations_url":"https://api.github.com/users/BertrandBordage/orgs","repos_url":"https://api.github.com/users/BertrandBordage/repos","events_url":"https://api.github.com/users/BertrandBordage/events{/privacy}","received_events_url":"https://api.github.com/users/BertrandBordage/received_events","type":"User","site_admin":false},"body":"This pull request is the final version of the first and main goal of [the first Wagtail crowdfunding campaign](https://kickstarter.com/projects/noripyt/wagtails-first-hatch).\r\n\r\nMain features:\r\n- Brand new fancy design\r\n- Straightforward structure\r\n- Drag and drop to move around the blocks\r\n- Blocks use as much width as possible, for a better nesting\r\n- Duplication of blocks\r\n- Blocks can be made collapsible for complex data structures\r\n- Smaller add panels, perfect when using more than a dozen blocks\r\n- Better performance by several orders of magnitude (up to 1000× faster for loading the edit page!)\r\n- New support for `min_num` and `max_num` in `ListBlock`\r\n- Django formsets are no longer used to handle the form data. Previously, we had to convert from the database JSON to formsets, then parse hundreds/thousands of fields with formsets to convert data to JSON. Now, a single hidden JSON input stores on the page the data that will be stored to the database, with almost no need for conversion (Draftail is an exception).\r\n- Far better responsiveness\r\n\r\nYou can already test it by using [wagtail-react-streamfield](https://github.com/noripyt/wagtail-react-streamfield), a library that patches your existing Wagtail during the execution (a.k.a. monkey patching) to add this pull request.\r\n\r\nAs you can see, this pull request is fairly small given the amount of work required by it. This is because almost all the magic is happening in [react-streamfield](https://github.com/noripyt/react-streamfield), a JavaScript library I developed for the occasion. As of now, I spent a total of 179 hours on the campaign work (excluding preparation of the campaign), in addition to 120 hours spent benevolently on Wagtail since January.\r\n\r\n**So yes, things got a little out of hand** and took much longer than I planned. But I still hang on and am still planning to finish everything I promised I will do.\r\n\r\nFor the integration, I had to update Babel, React and related librairies because react-streamfield relies on the latest JavaScript syntaxes and technologies.\r\n\r\nIt’s fully working, but I’m still struggling with some last tests (after updating/adding/removing dozens of them). The remaining tests rely on the old template rendering of the StreamField and are tricky to update, I still have to spend 10-30 minutes on each test.\r\n\r\nHere is what it looks like:\r\n\r\n\r\nThe InlinePanel PR will follow, it’s enough to review for now ;)\r\n\r\n@thibaudcolas My proposition of paying you to review this work is still up! If you don’t have time, please let us know so someone else can do it.","created_at":"2018-12-05T04:21:09Z","updated_at":"2019-04-02T09:41:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b511cb31efcf64d9c04e9934d2062277040f17e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":382310816,"node_id":"MDU6TGFiZWwzODIzMTA4MTY=","url":"https://api.github.com/repos/wagtail/wagtail/labels/component:Frontend","name":"component:Frontend","color":"c2e0c6","default":false},{"id":191826078,"node_id":"MDU6TGFiZWwxOTE4MjYwNzg=","url":"https://api.github.com/repos/wagtail/wagtail/labels/component:Streamfield","name":"component:Streamfield","color":"8777ED","default":false},{"id":78418440,"node_id":"MDU6TGFiZWw3ODQxODQ0MA==","url":"https://api.github.com/repos/wagtail/wagtail/labels/type:Enhancement","name":"type:Enhancement","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/wagtail/wagtail/milestones/60","html_url":"https://github.com/wagtail/wagtail/milestone/60","labels_url":"https://api.github.com/repos/wagtail/wagtail/milestones/60/labels","id":3876853,"node_id":"MDk6TWlsZXN0b25lMzg3Njg1Mw==","number":60,"title":"2.5","description":"","creator":{"login":"gasman","id":85097,"node_id":"MDQ6VXNlcjg1MDk3","avatar_url":"https://avatars2.githubusercontent.com/u/85097?v=4","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":17,"state":"open","created_at":"2018-12-06T13:47:16Z","updated_at":"2019-03-21T20:41:15Z","due_on":"2019-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wagtail/wagtail/pulls/4942/commits","review_comments_url":"https://api.github.com/repos/wagtail/wagtail/pulls/4942/comments","review_comment_url":"https://api.github.com/repos/wagtail/wagtail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wagtail/wagtail/issues/4942/comments","statuses_url":"https://api.github.com/repos/wagtail/wagtail/statuses/cb312f3ab8c877c30e1cf8c5b3cac1a615c28d02","head":{"label":"BertrandBordage:new-streamfield","ref":"new-streamfield","sha":"cb312f3ab8c877c30e1cf8c5b3cac1a615c28d02","user":{"login":"BertrandBordage","id":1119169,"node_id":"MDQ6VXNlcjExMTkxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1119169?v=4","gravatar_id":"","url":"https://api.github.com/users/BertrandBordage","html_url":"https://github.com/BertrandBordage","followers_url":"https://api.github.com/users/BertrandBordage/followers","following_url":"https://api.github.com/users/BertrandBordage/following{/other_user}","gists_url":"https://api.github.com/users/BertrandBordage/gists{/gist_id}","starred_url":"https://api.github.com/users/BertrandBordage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertrandBordage/subscriptions","organizations_url":"https://api.github.com/users/BertrandBordage/orgs","repos_url":"https://api.github.com/users/BertrandBordage/repos","events_url":"https://api.github.com/users/BertrandBordage/events{/privacy}","received_events_url":"https://api.github.com/users/BertrandBordage/received_events","type":"User","site_admin":false},"repo":{"id":68384292,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM4NDI5Mg==","name":"wagtail","full_name":"BertrandBordage/wagtail","private":false,"owner":{"login":"BertrandBordage","id":1119169,"node_id":"MDQ6VXNlcjExMTkxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1119169?v=4","gravatar_id":"","url":"https://api.github.com/users/BertrandBordage","html_url":"https://github.com/BertrandBordage","followers_url":"https://api.github.com/users/BertrandBordage/followers","following_url":"https://api.github.com/users/BertrandBordage/following{/other_user}","gists_url":"https://api.github.com/users/BertrandBordage/gists{/gist_id}","starred_url":"https://api.github.com/users/BertrandBordage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertrandBordage/subscriptions","organizations_url":"https://api.github.com/users/BertrandBordage/orgs","repos_url":"https://api.github.com/users/BertrandBordage/repos","events_url":"https://api.github.com/users/BertrandBordage/events{/privacy}","received_events_url":"https://api.github.com/users/BertrandBordage/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BertrandBordage/wagtail","description":"A Django content management system focused on flexibility and user experience","fork":true,"url":"https://api.github.com/repos/BertrandBordage/wagtail","forks_url":"https://api.github.com/repos/BertrandBordage/wagtail/forks","keys_url":"https://api.github.com/repos/BertrandBordage/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BertrandBordage/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BertrandBordage/wagtail/teams","hooks_url":"https://api.github.com/repos/BertrandBordage/wagtail/hooks","issue_events_url":"https://api.github.com/repos/BertrandBordage/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/BertrandBordage/wagtail/events","assignees_url":"https://api.github.com/repos/BertrandBordage/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/BertrandBordage/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/BertrandBordage/wagtail/tags","blobs_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BertrandBordage/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/BertrandBordage/wagtail/languages","stargazers_url":"https://api.github.com/repos/BertrandBordage/wagtail/stargazers","contributors_url":"https://api.github.com/repos/BertrandBordage/wagtail/contributors","subscribers_url":"https://api.github.com/repos/BertrandBordage/wagtail/subscribers","subscription_url":"https://api.github.com/repos/BertrandBordage/wagtail/subscription","commits_url":"https://api.github.com/repos/BertrandBordage/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/BertrandBordage/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/BertrandBordage/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/BertrandBordage/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/BertrandBordage/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/BertrandBordage/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BertrandBordage/wagtail/merges","archive_url":"https://api.github.com/repos/BertrandBordage/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BertrandBordage/wagtail/downloads","issues_url":"https://api.github.com/repos/BertrandBordage/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/BertrandBordage/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/BertrandBordage/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/BertrandBordage/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BertrandBordage/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/BertrandBordage/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/BertrandBordage/wagtail/deployments","created_at":"2016-09-16T13:57:44Z","updated_at":"2019-01-26T15:39:54Z","pushed_at":"2019-03-11T01:56:56Z","git_url":"git://github.com/BertrandBordage/wagtail.git","ssh_url":"git@github.com:BertrandBordage/wagtail.git","clone_url":"https://github.com/BertrandBordage/wagtail.git","svn_url":"https://github.com/BertrandBordage/wagtail","homepage":"wagtail.io","size":80235,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wagtail:master","ref":"master","sha":"8afbc6c3eccef9eb0f09ed56c54cd36779451882","user":{"login":"wagtail","id":23708009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzA4MDA5","avatar_url":"https://avatars3.githubusercontent.com/u/23708009?v=4","gravatar_id":"","url":"https://api.github.com/users/wagtail","html_url":"https://github.com/wagtail","followers_url":"https://api.github.com/users/wagtail/followers","following_url":"https://api.github.com/users/wagtail/following{/other_user}","gists_url":"https://api.github.com/users/wagtail/gists{/gist_id}","starred_url":"https://api.github.com/users/wagtail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagtail/subscriptions","organizations_url":"https://api.github.com/users/wagtail/orgs","repos_url":"https://api.github.com/users/wagtail/repos","events_url":"https://api.github.com/users/wagtail/events{/privacy}","received_events_url":"https://api.github.com/users/wagtail/received_events","type":"Organization","site_admin":false},"repo":{"id":16479108,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ3OTEwOA==","name":"wagtail","full_name":"wagtail/wagtail","private":false,"owner":{"login":"wagtail","id":23708009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzA4MDA5","avatar_url":"https://avatars3.githubusercontent.com/u/23708009?v=4","gravatar_id":"","url":"https://api.github.com/users/wagtail","html_url":"https://github.com/wagtail","followers_url":"https://api.github.com/users/wagtail/followers","following_url":"https://api.github.com/users/wagtail/following{/other_user}","gists_url":"https://api.github.com/users/wagtail/gists{/gist_id}","starred_url":"https://api.github.com/users/wagtail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagtail/subscriptions","organizations_url":"https://api.github.com/users/wagtail/orgs","repos_url":"https://api.github.com/users/wagtail/repos","events_url":"https://api.github.com/users/wagtail/events{/privacy}","received_events_url":"https://api.github.com/users/wagtail/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wagtail/wagtail","description":"A Django content management system focused on flexibility and user experience","fork":false,"url":"https://api.github.com/repos/wagtail/wagtail","forks_url":"https://api.github.com/repos/wagtail/wagtail/forks","keys_url":"https://api.github.com/repos/wagtail/wagtail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wagtail/wagtail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wagtail/wagtail/teams","hooks_url":"https://api.github.com/repos/wagtail/wagtail/hooks","issue_events_url":"https://api.github.com/repos/wagtail/wagtail/issues/events{/number}","events_url":"https://api.github.com/repos/wagtail/wagtail/events","assignees_url":"https://api.github.com/repos/wagtail/wagtail/assignees{/user}","branches_url":"https://api.github.com/repos/wagtail/wagtail/branches{/branch}","tags_url":"https://api.github.com/repos/wagtail/wagtail/tags","blobs_url":"https://api.github.com/repos/wagtail/wagtail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wagtail/wagtail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wagtail/wagtail/git/refs{/sha}","trees_url":"https://api.github.com/repos/wagtail/wagtail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wagtail/wagtail/statuses/{sha}","languages_url":"https://api.github.com/repos/wagtail/wagtail/languages","stargazers_url":"https://api.github.com/repos/wagtail/wagtail/stargazers","contributors_url":"https://api.github.com/repos/wagtail/wagtail/contributors","subscribers_url":"https://api.github.com/repos/wagtail/wagtail/subscribers","subscription_url":"https://api.github.com/repos/wagtail/wagtail/subscription","commits_url":"https://api.github.com/repos/wagtail/wagtail/commits{/sha}","git_commits_url":"https://api.github.com/repos/wagtail/wagtail/git/commits{/sha}","comments_url":"https://api.github.com/repos/wagtail/wagtail/comments{/number}","issue_comment_url":"https://api.github.com/repos/wagtail/wagtail/issues/comments{/number}","contents_url":"https://api.github.com/repos/wagtail/wagtail/contents/{+path}","compare_url":"https://api.github.com/repos/wagtail/wagtail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wagtail/wagtail/merges","archive_url":"https://api.github.com/repos/wagtail/wagtail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wagtail/wagtail/downloads","issues_url":"https://api.github.com/repos/wagtail/wagtail/issues{/number}","pulls_url":"https://api.github.com/repos/wagtail/wagtail/pulls{/number}","milestones_url":"https://api.github.com/repos/wagtail/wagtail/milestones{/number}","notifications_url":"https://api.github.com/repos/wagtail/wagtail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wagtail/wagtail/labels{/name}","releases_url":"https://api.github.com/repos/wagtail/wagtail/releases{/id}","deployments_url":"https://api.github.com/repos/wagtail/wagtail/deployments","created_at":"2014-02-03T12:41:59Z","updated_at":"2019-04-02T06:19:06Z","pushed_at":"2019-04-01T19:28:44Z","git_url":"git://github.com/wagtail/wagtail.git","ssh_url":"git@github.com:wagtail/wagtail.git","clone_url":"https://github.com/wagtail/wagtail.git","svn_url":"https://github.com/wagtail/wagtail","homepage":"https://wagtail.io","size":80625,"stargazers_count":6962,"watchers_count":6962,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1522,"mirror_url":null,"archived":false,"open_issues_count":714,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1522,"open_issues":714,"watchers":6962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/4942"},"html":{"href":"https://github.com/wagtail/wagtail/pull/4942"},"issue":{"href":"https://api.github.com/repos/wagtail/wagtail/issues/4942"},"comments":{"href":"https://api.github.com/repos/wagtail/wagtail/issues/4942/comments"},"review_comments":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/4942/comments"},"review_comment":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wagtail/wagtail/pulls/4942/commits"},"statuses":{"href":"https://api.github.com/repos/wagtail/wagtail/statuses/cb312f3ab8c877c30e1cf8c5b3cac1a615c28d02"}},"author_association":"MEMBER"}}
|
{
"id": 16479108,
"name": "wagtail/wagtail",
"url": "https://api.github.com/repos/wagtail/wagtail"
}
|
{
"id": 1119169,
"login": "BertrandBordage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1119169?",
"url": "https://api.github.com/users/BertrandBordage"
}
|
{
"id": 23708009,
"login": "wagtail",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23708009?",
"url": "https://api.github.com/orgs/wagtail"
}
| 2019-04-02T09:41:35 |
9360557547
|
{"actor":{"display_login":"BertrandBordage"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/comments/307954798","pull_request_review_id":267457657,"id":307954798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzk1NDc5OA==","diff_hunk":"@@ -64,20 +64,20 @@ If you are using [OpenResty](http://openresty.org/), the default location would\n ## Support\n \n #### Community Support\n-For generic questions, see the Wiki pages with Frequently Asked Questions at: ","path":"README.md","position":4,"original_position":4,"commit_id":"e9d3c65259fa5bfc82e37498e9a676389dc1d768","original_commit_id":"e9d3c65259fa5bfc82e37498e9a676389dc1d768","user":{"login":"zandbelt","id":2339879,"node_id":"MDQ6VXNlcjIzMzk4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/2339879?v=4","gravatar_id":"","url":"https://api.github.com/users/zandbelt","html_url":"https://github.com/zandbelt","followers_url":"https://api.github.com/users/zandbelt/followers","following_url":"https://api.github.com/users/zandbelt/following{/other_user}","gists_url":"https://api.github.com/users/zandbelt/gists{/gist_id}","starred_url":"https://api.github.com/users/zandbelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zandbelt/subscriptions","organizations_url":"https://api.github.com/users/zandbelt/orgs","repos_url":"https://api.github.com/users/zandbelt/repos","events_url":"https://api.github.com/users/zandbelt/events{/privacy}","received_events_url":"https://api.github.com/users/zandbelt/received_events","type":"User","site_admin":false},"body":"I deliberately want the link on a new line","created_at":"2019-07-27T06:09:19Z","updated_at":"2019-07-27T06:09:19Z","html_url":"https://github.com/zmartzone/lua-resty-openidc/pull/276#discussion_r307954798","pull_request_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/comments/307954798"},"html":{"href":"https://github.com/zmartzone/lua-resty-openidc/pull/276#discussion_r307954798"},"pull_request":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276","id":301736682,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNzM2Njgy","html_url":"https://github.com/zmartzone/lua-resty-openidc/pull/276","diff_url":"https://github.com/zmartzone/lua-resty-openidc/pull/276.diff","patch_url":"https://github.com/zmartzone/lua-resty-openidc/pull/276.patch","issue_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/issues/276","number":276,"state":"open","locked":false,"title":"doc: doc style.","user":{"login":"membphis","id":6814606,"node_id":"MDQ6VXNlcjY4MTQ2MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/6814606?v=4","gravatar_id":"","url":"https://api.github.com/users/membphis","html_url":"https://github.com/membphis","followers_url":"https://api.github.com/users/membphis/followers","following_url":"https://api.github.com/users/membphis/following{/other_user}","gists_url":"https://api.github.com/users/membphis/gists{/gist_id}","starred_url":"https://api.github.com/users/membphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/membphis/subscriptions","organizations_url":"https://api.github.com/users/membphis/orgs","repos_url":"https://api.github.com/users/membphis/repos","events_url":"https://api.github.com/users/membphis/events{/privacy}","received_events_url":"https://api.github.com/users/membphis/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-27T06:02:15Z","updated_at":"2019-07-27T06:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d057a9cd3d890aaa5a15444fe0051473d9d17e02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276/commits","review_comments_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276/comments","review_comment_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/issues/276/comments","statuses_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/statuses/e9d3c65259fa5bfc82e37498e9a676389dc1d768","head":{"label":"iresty:doc-style","ref":"doc-style","sha":"e9d3c65259fa5bfc82e37498e9a676389dc1d768","user":{"login":"iresty","id":13067587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDY3NTg3","avatar_url":"https://avatars3.githubusercontent.com/u/13067587?v=4","gravatar_id":"","url":"https://api.github.com/users/iresty","html_url":"https://github.com/iresty","followers_url":"https://api.github.com/users/iresty/followers","following_url":"https://api.github.com/users/iresty/following{/other_user}","gists_url":"https://api.github.com/users/iresty/gists{/gist_id}","starred_url":"https://api.github.com/users/iresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iresty/subscriptions","organizations_url":"https://api.github.com/users/iresty/orgs","repos_url":"https://api.github.com/users/iresty/repos","events_url":"https://api.github.com/users/iresty/events{/privacy}","received_events_url":"https://api.github.com/users/iresty/received_events","type":"Organization","site_admin":false},"repo":{"id":198770933,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg3NzA5MzM=","name":"lua-resty-openidc","full_name":"iresty/lua-resty-openidc","private":false,"owner":{"login":"iresty","id":13067587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDY3NTg3","avatar_url":"https://avatars3.githubusercontent.com/u/13067587?v=4","gravatar_id":"","url":"https://api.github.com/users/iresty","html_url":"https://github.com/iresty","followers_url":"https://api.github.com/users/iresty/followers","following_url":"https://api.github.com/users/iresty/following{/other_user}","gists_url":"https://api.github.com/users/iresty/gists{/gist_id}","starred_url":"https://api.github.com/users/iresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iresty/subscriptions","organizations_url":"https://api.github.com/users/iresty/orgs","repos_url":"https://api.github.com/users/iresty/repos","events_url":"https://api.github.com/users/iresty/events{/privacy}","received_events_url":"https://api.github.com/users/iresty/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iresty/lua-resty-openidc","description":"Lua implementation to make NGINX operate as an OpenID Connect RP or OAuth 2.0 RS using the Lua extension scripting features (http://wiki.nginx.org/HttpLuaModule) which are for instance part of OpenResty (http://openresty.org/)","fork":true,"url":"https://api.github.com/repos/iresty/lua-resty-openidc","forks_url":"https://api.github.com/repos/iresty/lua-resty-openidc/forks","keys_url":"https://api.github.com/repos/iresty/lua-resty-openidc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iresty/lua-resty-openidc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iresty/lua-resty-openidc/teams","hooks_url":"https://api.github.com/repos/iresty/lua-resty-openidc/hooks","issue_events_url":"https://api.github.com/repos/iresty/lua-resty-openidc/issues/events{/number}","events_url":"https://api.github.com/repos/iresty/lua-resty-openidc/events","assignees_url":"https://api.github.com/repos/iresty/lua-resty-openidc/assignees{/user}","branches_url":"https://api.github.com/repos/iresty/lua-resty-openidc/branches{/branch}","tags_url":"https://api.github.com/repos/iresty/lua-resty-openidc/tags","blobs_url":"https://api.github.com/repos/iresty/lua-resty-openidc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iresty/lua-resty-openidc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iresty/lua-resty-openidc/git/refs{/sha}","trees_url":"https://api.github.com/repos/iresty/lua-resty-openidc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iresty/lua-resty-openidc/statuses/{sha}","languages_url":"https://api.github.com/repos/iresty/lua-resty-openidc/languages","stargazers_url":"https://api.github.com/repos/iresty/lua-resty-openidc/stargazers","contributors_url":"https://api.github.com/repos/iresty/lua-resty-openidc/contributors","subscribers_url":"https://api.github.com/repos/iresty/lua-resty-openidc/subscribers","subscription_url":"https://api.github.com/repos/iresty/lua-resty-openidc/subscription","commits_url":"https://api.github.com/repos/iresty/lua-resty-openidc/commits{/sha}","git_commits_url":"https://api.github.com/repos/iresty/lua-resty-openidc/git/commits{/sha}","comments_url":"https://api.github.com/repos/iresty/lua-resty-openidc/comments{/number}","issue_comment_url":"https://api.github.com/repos/iresty/lua-resty-openidc/issues/comments{/number}","contents_url":"https://api.github.com/repos/iresty/lua-resty-openidc/contents/{+path}","compare_url":"https://api.github.com/repos/iresty/lua-resty-openidc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iresty/lua-resty-openidc/merges","archive_url":"https://api.github.com/repos/iresty/lua-resty-openidc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iresty/lua-resty-openidc/downloads","issues_url":"https://api.github.com/repos/iresty/lua-resty-openidc/issues{/number}","pulls_url":"https://api.github.com/repos/iresty/lua-resty-openidc/pulls{/number}","milestones_url":"https://api.github.com/repos/iresty/lua-resty-openidc/milestones{/number}","notifications_url":"https://api.github.com/repos/iresty/lua-resty-openidc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iresty/lua-resty-openidc/labels{/name}","releases_url":"https://api.github.com/repos/iresty/lua-resty-openidc/releases{/id}","deployments_url":"https://api.github.com/repos/iresty/lua-resty-openidc/deployments","created_at":"2019-07-25T06:27:20Z","updated_at":"2019-07-25T06:27:23Z","pushed_at":"2019-07-27T06:01:32Z","git_url":"git://github.com/iresty/lua-resty-openidc.git","ssh_url":"git@github.com:iresty/lua-resty-openidc.git","clone_url":"https://github.com/iresty/lua-resty-openidc.git","svn_url":"https://github.com/iresty/lua-resty-openidc","homepage":"","size":622,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zmartzone:master","ref":"master","sha":"4ff64540ece124a64f66c5f5c5ed6b2dd8a58483","user":{"login":"zmartzone","id":23737653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzM3NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/23737653?v=4","gravatar_id":"","url":"https://api.github.com/users/zmartzone","html_url":"https://github.com/zmartzone","followers_url":"https://api.github.com/users/zmartzone/followers","following_url":"https://api.github.com/users/zmartzone/following{/other_user}","gists_url":"https://api.github.com/users/zmartzone/gists{/gist_id}","starred_url":"https://api.github.com/users/zmartzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmartzone/subscriptions","organizations_url":"https://api.github.com/users/zmartzone/orgs","repos_url":"https://api.github.com/users/zmartzone/repos","events_url":"https://api.github.com/users/zmartzone/events{/privacy}","received_events_url":"https://api.github.com/users/zmartzone/received_events","type":"Organization","site_admin":false},"repo":{"id":39087159,"node_id":"MDEwOlJlcG9zaXRvcnkzOTA4NzE1OQ==","name":"lua-resty-openidc","full_name":"zmartzone/lua-resty-openidc","private":false,"owner":{"login":"zmartzone","id":23737653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzM3NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/23737653?v=4","gravatar_id":"","url":"https://api.github.com/users/zmartzone","html_url":"https://github.com/zmartzone","followers_url":"https://api.github.com/users/zmartzone/followers","following_url":"https://api.github.com/users/zmartzone/following{/other_user}","gists_url":"https://api.github.com/users/zmartzone/gists{/gist_id}","starred_url":"https://api.github.com/users/zmartzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmartzone/subscriptions","organizations_url":"https://api.github.com/users/zmartzone/orgs","repos_url":"https://api.github.com/users/zmartzone/repos","events_url":"https://api.github.com/users/zmartzone/events{/privacy}","received_events_url":"https://api.github.com/users/zmartzone/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zmartzone/lua-resty-openidc","description":"Lua implementation to make NGINX operate as an OpenID Connect RP or OAuth 2.0 RS using the Lua extension scripting features (http://wiki.nginx.org/HttpLuaModule) which are for instance part of OpenResty (http://openresty.org/)","fork":false,"url":"https://api.github.com/repos/zmartzone/lua-resty-openidc","forks_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/forks","keys_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/teams","hooks_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/hooks","issue_events_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/issues/events{/number}","events_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/events","assignees_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/assignees{/user}","branches_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/branches{/branch}","tags_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/tags","blobs_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/statuses/{sha}","languages_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/languages","stargazers_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/stargazers","contributors_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/contributors","subscribers_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/subscribers","subscription_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/subscription","commits_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/contents/{+path}","compare_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/merges","archive_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/downloads","issues_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/issues{/number}","pulls_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls{/number}","milestones_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/milestones{/number}","notifications_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/labels{/name}","releases_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/releases{/id}","deployments_url":"https://api.github.com/repos/zmartzone/lua-resty-openidc/deployments","created_at":"2015-07-14T16:37:02Z","updated_at":"2019-07-25T06:27:17Z","pushed_at":"2019-07-27T06:02:16Z","git_url":"git://github.com/zmartzone/lua-resty-openidc.git","ssh_url":"git@github.com:zmartzone/lua-resty-openidc.git","clone_url":"https://github.com/zmartzone/lua-resty-openidc.git","svn_url":"https://github.com/zmartzone/lua-resty-openidc","homepage":"","size":622,"stargazers_count":401,"watchers_count":401,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":120,"open_issues":12,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276"},"html":{"href":"https://github.com/zmartzone/lua-resty-openidc/pull/276"},"issue":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/issues/276"},"comments":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/zmartzone/lua-resty-openidc/statuses/e9d3c65259fa5bfc82e37498e9a676389dc1d768"}},"author_association":"NONE"}}
|
{
"id": 39087159,
"name": "zmartzone/lua-resty-openidc",
"url": "https://api.github.com/repos/zmartzone/lua-resty-openidc"
}
|
{
"id": 2339879,
"login": "zandbelt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2339879?",
"url": "https://api.github.com/users/zandbelt"
}
|
{
"id": 23737653,
"login": "zmartzone",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23737653?",
"url": "https://api.github.com/orgs/zmartzone"
}
| 2019-07-27T06:09:19 |
10095166266
|
{"actor":{"display_login":"zandbelt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/comments/354344802","pull_request_review_id":327590525,"id":354344802,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDM0NDgwMg==","diff_hunk":"@@ -0,0 +1,17 @@\n+package org.jboss.eap.qe.microprofile.tooling.server.logwatch;\n+\n+import java.util.regex.Pattern;\n+\n+/**\n+ * Interface describing log watcher which checks log for a pattern.\n+ */\n+public interface LogWatcher {\n+\n+ /**\n+ * Perform search in log or its excerpt and find if a line matches the pattern.\n+ * @param pattern a pattern which will be the log line matched against\n+ * @return true if log line matching pattern was found in log, false otherwise\n+ */\n+ boolean wasLineWithPatternLogged(final Pattern pattern);","path":"tooling-server-configuration/src/main/java/org/jboss/eap/qe/microprofile/tooling/server/logwatch/LogWatcher.java","position":null,"original_position":15,"commit_id":"a576ef7966c3636c3201459c0ea322a0952b56c4","original_commit_id":"4ad2dc03e93ee96f5df3150967c8844fca6e412f","user":{"login":"istraka","id":5773523,"node_id":"MDQ6VXNlcjU3NzM1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5773523?v=4","gravatar_id":"","url":"https://api.github.com/users/istraka","html_url":"https://github.com/istraka","followers_url":"https://api.github.com/users/istraka/followers","following_url":"https://api.github.com/users/istraka/following{/other_user}","gists_url":"https://api.github.com/users/istraka/gists{/gist_id}","starred_url":"https://api.github.com/users/istraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istraka/subscriptions","organizations_url":"https://api.github.com/users/istraka/orgs","repos_url":"https://api.github.com/users/istraka/repos","events_url":"https://api.github.com/users/istraka/events{/privacy}","received_events_url":"https://api.github.com/users/istraka/received_events","type":"User","site_admin":false},"body":"I see. Good point with a sub string. I just wanted to get rid of `Pattern.compile`. Something like `String::matches` that would save some typing. But I am OK with what we have now,","created_at":"2019-12-05T14:30:43Z","updated_at":"2019-12-05T14:30:43Z","html_url":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite/pull/74#discussion_r354344802","pull_request_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/comments/354344802"},"html":{"href":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite/pull/74#discussion_r354344802"},"pull_request":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74"}},"in_reply_to_id":354272794},"pull_request":{"url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74","id":349400581,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5NDAwNTgx","html_url":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite/pull/74","diff_url":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite/pull/74.diff","patch_url":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite/pull/74.patch","issue_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/issues/74","number":74,"state":"open","locked":false,"title":"Added solution for watching logs using management model","user":{"login":"honza-kasik","id":10008273,"node_id":"MDQ6VXNlcjEwMDA4Mjcz","avatar_url":"https://avatars3.githubusercontent.com/u/10008273?v=4","gravatar_id":"","url":"https://api.github.com/users/honza-kasik","html_url":"https://github.com/honza-kasik","followers_url":"https://api.github.com/users/honza-kasik/followers","following_url":"https://api.github.com/users/honza-kasik/following{/other_user}","gists_url":"https://api.github.com/users/honza-kasik/gists{/gist_id}","starred_url":"https://api.github.com/users/honza-kasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honza-kasik/subscriptions","organizations_url":"https://api.github.com/users/honza-kasik/orgs","repos_url":"https://api.github.com/users/honza-kasik/repos","events_url":"https://api.github.com/users/honza-kasik/events{/privacy}","received_events_url":"https://api.github.com/users/honza-kasik/received_events","type":"User","site_admin":false},"body":"Added solution for watching logs using management model. Do you like this feature?\r\n\r\nPlease make sure your PR meets the following requirements:\r\n- [x] Pull Request contains description for the changes\r\n- [x] Pull Request does not include fixes for multiple issues / topics\r\n- [x] Code compiles and tests are passing\r\n- [x] Code is self-descriptive and/or documented","created_at":"2019-12-05T11:48:55Z","updated_at":"2019-12-05T14:30:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2376801edf50604a2d6877521ada614b82765eb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rsvoboda","id":925259,"node_id":"MDQ6VXNlcjkyNTI1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/925259?v=4","gravatar_id":"","url":"https://api.github.com/users/rsvoboda","html_url":"https://github.com/rsvoboda","followers_url":"https://api.github.com/users/rsvoboda/followers","following_url":"https://api.github.com/users/rsvoboda/following{/other_user}","gists_url":"https://api.github.com/users/rsvoboda/gists{/gist_id}","starred_url":"https://api.github.com/users/rsvoboda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsvoboda/subscriptions","organizations_url":"https://api.github.com/users/rsvoboda/orgs","repos_url":"https://api.github.com/users/rsvoboda/repos","events_url":"https://api.github.com/users/rsvoboda/events{/privacy}","received_events_url":"https://api.github.com/users/rsvoboda/received_events","type":"User","site_admin":false},{"login":"mnovak1","id":1370387,"node_id":"MDQ6VXNlcjEzNzAzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1370387?v=4","gravatar_id":"","url":"https://api.github.com/users/mnovak1","html_url":"https://github.com/mnovak1","followers_url":"https://api.github.com/users/mnovak1/followers","following_url":"https://api.github.com/users/mnovak1/following{/other_user}","gists_url":"https://api.github.com/users/mnovak1/gists{/gist_id}","starred_url":"https://api.github.com/users/mnovak1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnovak1/subscriptions","organizations_url":"https://api.github.com/users/mnovak1/orgs","repos_url":"https://api.github.com/users/mnovak1/repos","events_url":"https://api.github.com/users/mnovak1/events{/privacy}","received_events_url":"https://api.github.com/users/mnovak1/received_events","type":"User","site_admin":false},{"login":"istraka","id":5773523,"node_id":"MDQ6VXNlcjU3NzM1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5773523?v=4","gravatar_id":"","url":"https://api.github.com/users/istraka","html_url":"https://github.com/istraka","followers_url":"https://api.github.com/users/istraka/followers","following_url":"https://api.github.com/users/istraka/following{/other_user}","gists_url":"https://api.github.com/users/istraka/gists{/gist_id}","starred_url":"https://api.github.com/users/istraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istraka/subscriptions","organizations_url":"https://api.github.com/users/istraka/orgs","repos_url":"https://api.github.com/users/istraka/repos","events_url":"https://api.github.com/users/istraka/events{/privacy}","received_events_url":"https://api.github.com/users/istraka/received_events","type":"User","site_admin":false},{"login":"zhantemirov","id":18175164,"node_id":"MDQ6VXNlcjE4MTc1MTY0","avatar_url":"https://avatars0.githubusercontent.com/u/18175164?v=4","gravatar_id":"","url":"https://api.github.com/users/zhantemirov","html_url":"https://github.com/zhantemirov","followers_url":"https://api.github.com/users/zhantemirov/followers","following_url":"https://api.github.com/users/zhantemirov/following{/other_user}","gists_url":"https://api.github.com/users/zhantemirov/gists{/gist_id}","starred_url":"https://api.github.com/users/zhantemirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhantemirov/subscriptions","organizations_url":"https://api.github.com/users/zhantemirov/orgs","repos_url":"https://api.github.com/users/zhantemirov/repos","events_url":"https://api.github.com/users/zhantemirov/events{/privacy}","received_events_url":"https://api.github.com/users/zhantemirov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74/commits","review_comments_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74/comments","review_comment_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/issues/74/comments","statuses_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/statuses/a576ef7966c3636c3201459c0ea322a0952b56c4","head":{"label":"honza-kasik:log-watcher","ref":"log-watcher","sha":"a576ef7966c3636c3201459c0ea322a0952b56c4","user":{"login":"honza-kasik","id":10008273,"node_id":"MDQ6VXNlcjEwMDA4Mjcz","avatar_url":"https://avatars3.githubusercontent.com/u/10008273?v=4","gravatar_id":"","url":"https://api.github.com/users/honza-kasik","html_url":"https://github.com/honza-kasik","followers_url":"https://api.github.com/users/honza-kasik/followers","following_url":"https://api.github.com/users/honza-kasik/following{/other_user}","gists_url":"https://api.github.com/users/honza-kasik/gists{/gist_id}","starred_url":"https://api.github.com/users/honza-kasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honza-kasik/subscriptions","organizations_url":"https://api.github.com/users/honza-kasik/orgs","repos_url":"https://api.github.com/users/honza-kasik/repos","events_url":"https://api.github.com/users/honza-kasik/events{/privacy}","received_events_url":"https://api.github.com/users/honza-kasik/received_events","type":"User","site_admin":false},"repo":{"id":215282039,"node_id":"MDEwOlJlcG9zaXRvcnkyMTUyODIwMzk=","name":"eap-microprofile-test-suite","full_name":"honza-kasik/eap-microprofile-test-suite","private":false,"owner":{"login":"honza-kasik","id":10008273,"node_id":"MDQ6VXNlcjEwMDA4Mjcz","avatar_url":"https://avatars3.githubusercontent.com/u/10008273?v=4","gravatar_id":"","url":"https://api.github.com/users/honza-kasik","html_url":"https://github.com/honza-kasik","followers_url":"https://api.github.com/users/honza-kasik/followers","following_url":"https://api.github.com/users/honza-kasik/following{/other_user}","gists_url":"https://api.github.com/users/honza-kasik/gists{/gist_id}","starred_url":"https://api.github.com/users/honza-kasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honza-kasik/subscriptions","organizations_url":"https://api.github.com/users/honza-kasik/orgs","repos_url":"https://api.github.com/users/honza-kasik/repos","events_url":"https://api.github.com/users/honza-kasik/events{/privacy}","received_events_url":"https://api.github.com/users/honza-kasik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/honza-kasik/eap-microprofile-test-suite","description":" a small standalone test suite for MicroProfile on WF/EAP","fork":true,"url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite","forks_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/forks","keys_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/teams","hooks_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/hooks","issue_events_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/events","assignees_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/tags","blobs_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/languages","stargazers_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/stargazers","contributors_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/contributors","subscribers_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/subscribers","subscription_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/subscription","commits_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/merges","archive_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/downloads","issues_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/labels{/name}","releases_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/releases{/id}","deployments_url":"https://api.github.com/repos/honza-kasik/eap-microprofile-test-suite/deployments","created_at":"2019-10-15T11:30:23Z","updated_at":"2019-10-15T11:30:24Z","pushed_at":"2019-12-05T13:04:29Z","git_url":"git://github.com/honza-kasik/eap-microprofile-test-suite.git","ssh_url":"git@github.com:honza-kasik/eap-microprofile-test-suite.git","clone_url":"https://github.com/honza-kasik/eap-microprofile-test-suite.git","svn_url":"https://github.com/honza-kasik/eap-microprofile-test-suite","homepage":null,"size":149,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jboss-eap-qe:master","ref":"master","sha":"b66dba9ad2cf0d20f6f0e52955aa2fc5031aa6d5","user":{"login":"jboss-eap-qe","id":24289683,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjg5Njgz","avatar_url":"https://avatars0.githubusercontent.com/u/24289683?v=4","gravatar_id":"","url":"https://api.github.com/users/jboss-eap-qe","html_url":"https://github.com/jboss-eap-qe","followers_url":"https://api.github.com/users/jboss-eap-qe/followers","following_url":"https://api.github.com/users/jboss-eap-qe/following{/other_user}","gists_url":"https://api.github.com/users/jboss-eap-qe/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-eap-qe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-eap-qe/subscriptions","organizations_url":"https://api.github.com/users/jboss-eap-qe/orgs","repos_url":"https://api.github.com/users/jboss-eap-qe/repos","events_url":"https://api.github.com/users/jboss-eap-qe/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-eap-qe/received_events","type":"Organization","site_admin":false},"repo":{"id":211875699,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE4NzU2OTk=","name":"eap-microprofile-test-suite","full_name":"jboss-eap-qe/eap-microprofile-test-suite","private":false,"owner":{"login":"jboss-eap-qe","id":24289683,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjg5Njgz","avatar_url":"https://avatars0.githubusercontent.com/u/24289683?v=4","gravatar_id":"","url":"https://api.github.com/users/jboss-eap-qe","html_url":"https://github.com/jboss-eap-qe","followers_url":"https://api.github.com/users/jboss-eap-qe/followers","following_url":"https://api.github.com/users/jboss-eap-qe/following{/other_user}","gists_url":"https://api.github.com/users/jboss-eap-qe/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-eap-qe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-eap-qe/subscriptions","organizations_url":"https://api.github.com/users/jboss-eap-qe/orgs","repos_url":"https://api.github.com/users/jboss-eap-qe/repos","events_url":"https://api.github.com/users/jboss-eap-qe/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-eap-qe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite","description":" a small standalone test suite for MicroProfile on WF/EAP","fork":false,"url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite","forks_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/forks","keys_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/teams","hooks_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/hooks","issue_events_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/events","assignees_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/tags","blobs_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/languages","stargazers_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/stargazers","contributors_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/contributors","subscribers_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/subscribers","subscription_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/subscription","commits_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/merges","archive_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/downloads","issues_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/labels{/name}","releases_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/releases{/id}","deployments_url":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/deployments","created_at":"2019-09-30T14:12:01Z","updated_at":"2019-12-05T14:22:32Z","pushed_at":"2019-12-05T14:24:34Z","git_url":"git://github.com/jboss-eap-qe/eap-microprofile-test-suite.git","ssh_url":"git@github.com:jboss-eap-qe/eap-microprofile-test-suite.git","clone_url":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite.git","svn_url":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74"},"html":{"href":"https://github.com/jboss-eap-qe/eap-microprofile-test-suite/pull/74"},"issue":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/issues/74"},"comments":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite/statuses/a576ef7966c3636c3201459c0ea322a0952b56c4"}},"author_association":"MEMBER"}}
|
{
"id": 211875699,
"name": "jboss-eap-qe/eap-microprofile-test-suite",
"url": "https://api.github.com/repos/jboss-eap-qe/eap-microprofile-test-suite"
}
|
{
"id": 5773523,
"login": "istraka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5773523?",
"url": "https://api.github.com/users/istraka"
}
|
{
"id": 24289683,
"login": "jboss-eap-qe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24289683?",
"url": "https://api.github.com/orgs/jboss-eap-qe"
}
| 2019-12-05T14:30:43 |
11020372231
|
{"actor":{"display_login":"istraka"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/comments/254583270","pull_request_review_id":200963617,"id":254583270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDU4MzI3MA==","diff_hunk":"@@ -1,59 +1,164 @@\n <ion-header>\n- <ion-navbar hideBackButton=\"true\">\n- <ion-title margin-left>\n- Test review\n- </ion-title>\n- <ion-buttons start>\n- <button ion-button (click)=\"navCtrl.pop()\" padding-horizontal>\n- <ion-icon name=\"arrow-back\" padding-right></ion-icon>\n- <span>Test</span>\n- </button>\n- </ion-buttons>\n- </ion-navbar>\n+ <ion-navbar hideBackButton=\"true\">\n+ <ion-title margin-left>\n+ Test review\n+ </ion-title>\n+ <ion-buttons start>\n+ <button ion-button (click)=\"navCtrl.pop()\" padding-horizontal>\n+ <ion-icon name=\"arrow-back\" padding-right></ion-icon>\n+ <span>Test</span>\n+ </button>\n+ </ion-buttons>\n+ </ion-navbar>\n </ion-header>\n \n \n <ion-content padding>\n- <ng-container *ngFor=\"let test of visit.tests\" no-padding>\n- <ng-container *ngFor=\"let vehicle of test.vehicles\" no-padding>\n- <ion-card>\n- <ion-item detail-none class=\"ion-item-title\">\n- <ion-img item-start class=\"vehicle-type-icon\" padding-right\n- src=\"./assets/imgs/{{getVehicleTypeIconToShow(vehicle)}}-icon.svg\" width=\"50\"></ion-img>\n- <h2>{{ vehicle.vrm }} ({{vehicle.techRecord[0].vehicleType}})</h2>\n- <p>{{ vehicle.vin }}</p>\n- </ion-item>\n- <ion-item\n- detail-none padding-left\n- class=\"bottom-divider\">\n- <h3 class=\"odometer-reading\">Odometer reading</h3>\n- <h3 item-end\n- class=\"odometer-reading-status\">\n- {{getOdometerStringToBeDisplayed(vehicle)}}\n- </h3>\n- </ion-item>\n- </ion-card>\n- <ion-card>\n+ <ng-container *ngFor=\"let test of visit.tests\" no-padding>\n+ <ng-container *ngFor=\"let vehicle of test.vehicles\" no-padding>\n+ <ion-card>\n+ <ion-item class=\"ion-item-title\">\n+ <ion-img item-start class=\"vehicle-type-icon\"\n+ src=\"./assets/imgs/{{getVehicleTypeIconToShow(vehicle)}}-icon.svg\" width=\"50\"></ion-img>\n+ <h2 padding-left>{{ vehicle.vrm }} ({{vehicle.techRecord[0].vehicleType}})</h2>\n+ <p padding-left>{{ vehicle.vin }}</p>\n+ </ion-item>\n+ <ion-item padding-left\n+ class=\"bottom-divider\">\n+ <h3 class=\"odometer-reading\">Odometer reading</h3>\n+ <h3 item-end\n+ class=\"odometer-reading-status\">\n+ {{getOdometerStringToBeDisplayed(vehicle)}}\n+ </h3>\n+ </ion-item>\n+ </ion-card>\n \n- <ion-item *ngFor=\"let testType of vehicle.testTypes\" no-padding>\n- <ion-grid no-padding>\n- <ion-row padding-left>\n- <ion-col col-8>\n- <p text-wrap class=\"item-text-color\">{{ commonFunctions.capitalizeString(testType.name) }}</p>\n- </ion-col>\n- <ion-col col-4 text-right>\n- <p text-uppercase\n- class=\"test-result\"\n- ion-text\n- [color]=\"commonFunctions.getTestResultColor(testType.testResult)\">\n- {{ testType.testResult }}\n- </p>\n- </ion-col>\n- </ion-row>\n- </ion-grid>\n- </ion-item>\n- </ion-card>\n+ <div class=\"section-divider\"></div>\n+\n+ <div *ngFor=\"let testType of vehicle.testTypes\">\n+ <ion-card no-padding>\n+ <ion-item no-padding>\n+ <ion-grid no-padding>\n+ <ion-row padding-left>\n+ <ion-col col-8>\n+ <p text-wrap\n+ class=\"item-text-color\">{{ testType.testTypeName }}</p>\n+ </ion-col>\n+ <ion-col col-4 text-right>\n+ <p text-uppercase\n+ class=\"test-result\"\n+ ion-text\n+ [color]=\"commonFunctions.getTestResultColor(testType.testResult)\">\n+ {{ testType.testResult }}\n+ </p>\n+ </ion-col>\n+ </ion-row>\n+ </ion-grid>\n+ </ion-item>\n+ <ion-item no-padding\n+ class=\"bottom-divider\"\n+ *ngIf=\"testType.numberOfSeatbeltsFitted && testType.testResult !== 'abandoned'\">\n+ <div margin-left class=\"test-field\">\n+ <h3>Seatbelt installation check</h3>\n+ <h3 class=\"test-field-value\">{{testType.seatbeltInstallationCheckDate ? 'Yes' : 'No'}}</h3>\n+ </div>\n+ <div margin-left class=\"test-field\">\n+ <h3>Number of seatbelts fitted</h3>\n+ <h3 class=\"test-field-value\">{{testType.numberOfSeatbeltsFitted}}</h3>\n+ </div>\n+ <div margin-left class=\"test-field\">\n+ <h3>Most recent seatbelt check</h3>\n+ <h3 class=\"test-field-value\">{{testType.lastSeatbeltInstallationCheckDate | date: 'd MMM yy'}}</h3>\n+ </div>\n+ </ion-item>\n+ <ion-item no-padding\n+ class=\"bottom-divider\"\n+ *ngIf=\"testType.certificateNumber && testType.testResult !== 'abandoned'\">","path":"src/pages/testing/test-creation/test-review/test-review.html","position":125,"original_position":125,"commit_id":"4b18c79e7410a3721753ae8a4c129b5a4e35b84f","original_commit_id":"4b18c79e7410a3721753ae8a4c129b5a4e35b84f","user":{"login":"vladddragomir","id":45453274,"node_id":"MDQ6VXNlcjQ1NDUzMjc0","avatar_url":"https://avatars2.githubusercontent.com/u/45453274?v=4","gravatar_id":"","url":"https://api.github.com/users/vladddragomir","html_url":"https://github.com/vladddragomir","followers_url":"https://api.github.com/users/vladddragomir/followers","following_url":"https://api.github.com/users/vladddragomir/following{/other_user}","gists_url":"https://api.github.com/users/vladddragomir/gists{/gist_id}","starred_url":"https://api.github.com/users/vladddragomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladddragomir/subscriptions","organizations_url":"https://api.github.com/users/vladddragomir/orgs","repos_url":"https://api.github.com/users/vladddragomir/repos","events_url":"https://api.github.com/users/vladddragomir/events{/privacy}","received_events_url":"https://api.github.com/users/vladddragomir/received_events","type":"User","site_admin":false},"body":"done","created_at":"2019-02-07T08:29:27Z","updated_at":"2019-02-07T08:29:27Z","html_url":"https://github.com/dvsa/cvs-app-mobile/pull/75#discussion_r254583270","pull_request_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/comments/254583270"},"html":{"href":"https://github.com/dvsa/cvs-app-mobile/pull/75#discussion_r254583270"},"pull_request":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75"}},"in_reply_to_id":254312955},"pull_request":{"url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75","id":250682541,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwNjgyNTQx","html_url":"https://github.com/dvsa/cvs-app-mobile/pull/75","diff_url":"https://github.com/dvsa/cvs-app-mobile/pull/75.diff","patch_url":"https://github.com/dvsa/cvs-app-mobile/pull/75.patch","issue_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/75","number":75,"state":"open","locked":false,"title":"CVSB-495","user":{"login":"vladddragomir","id":45453274,"node_id":"MDQ6VXNlcjQ1NDUzMjc0","avatar_url":"https://avatars2.githubusercontent.com/u/45453274?v=4","gravatar_id":"","url":"https://api.github.com/users/vladddragomir","html_url":"https://github.com/vladddragomir","followers_url":"https://api.github.com/users/vladddragomir/followers","following_url":"https://api.github.com/users/vladddragomir/following{/other_user}","gists_url":"https://api.github.com/users/vladddragomir/gists{/gist_id}","starred_url":"https://api.github.com/users/vladddragomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladddragomir/subscriptions","organizations_url":"https://api.github.com/users/vladddragomir/orgs","repos_url":"https://api.github.com/users/vladddragomir/repos","events_url":"https://api.github.com/users/vladddragomir/events{/privacy}","received_events_url":"https://api.github.com/users/vladddragomir/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-06T09:26:55Z","updated_at":"2019-02-07T08:29:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04bb6444b4202a401451d0b02feabae979fec518","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tartino","id":24921182,"node_id":"MDQ6VXNlcjI0OTIxMTgy","avatar_url":"https://avatars2.githubusercontent.com/u/24921182?v=4","gravatar_id":"","url":"https://api.github.com/users/tartino","html_url":"https://github.com/tartino","followers_url":"https://api.github.com/users/tartino/followers","following_url":"https://api.github.com/users/tartino/following{/other_user}","gists_url":"https://api.github.com/users/tartino/gists{/gist_id}","starred_url":"https://api.github.com/users/tartino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tartino/subscriptions","organizations_url":"https://api.github.com/users/tartino/orgs","repos_url":"https://api.github.com/users/tartino/repos","events_url":"https://api.github.com/users/tartino/events{/privacy}","received_events_url":"https://api.github.com/users/tartino/received_events","type":"User","site_admin":false},{"login":"adpetrescu","id":32935853,"node_id":"MDQ6VXNlcjMyOTM1ODUz","avatar_url":"https://avatars2.githubusercontent.com/u/32935853?v=4","gravatar_id":"","url":"https://api.github.com/users/adpetrescu","html_url":"https://github.com/adpetrescu","followers_url":"https://api.github.com/users/adpetrescu/followers","following_url":"https://api.github.com/users/adpetrescu/following{/other_user}","gists_url":"https://api.github.com/users/adpetrescu/gists{/gist_id}","starred_url":"https://api.github.com/users/adpetrescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adpetrescu/subscriptions","organizations_url":"https://api.github.com/users/adpetrescu/orgs","repos_url":"https://api.github.com/users/adpetrescu/repos","events_url":"https://api.github.com/users/adpetrescu/events{/privacy}","received_events_url":"https://api.github.com/users/adpetrescu/received_events","type":"User","site_admin":false},{"login":"mgherceanu","id":44018518,"node_id":"MDQ6VXNlcjQ0MDE4NTE4","avatar_url":"https://avatars0.githubusercontent.com/u/44018518?v=4","gravatar_id":"","url":"https://api.github.com/users/mgherceanu","html_url":"https://github.com/mgherceanu","followers_url":"https://api.github.com/users/mgherceanu/followers","following_url":"https://api.github.com/users/mgherceanu/following{/other_user}","gists_url":"https://api.github.com/users/mgherceanu/gists{/gist_id}","starred_url":"https://api.github.com/users/mgherceanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgherceanu/subscriptions","organizations_url":"https://api.github.com/users/mgherceanu/orgs","repos_url":"https://api.github.com/users/mgherceanu/repos","events_url":"https://api.github.com/users/mgherceanu/events{/privacy}","received_events_url":"https://api.github.com/users/mgherceanu/received_events","type":"User","site_admin":false},{"login":"acozianu","id":44023301,"node_id":"MDQ6VXNlcjQ0MDIzMzAx","avatar_url":"https://avatars1.githubusercontent.com/u/44023301?v=4","gravatar_id":"","url":"https://api.github.com/users/acozianu","html_url":"https://github.com/acozianu","followers_url":"https://api.github.com/users/acozianu/followers","following_url":"https://api.github.com/users/acozianu/following{/other_user}","gists_url":"https://api.github.com/users/acozianu/gists{/gist_id}","starred_url":"https://api.github.com/users/acozianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acozianu/subscriptions","organizations_url":"https://api.github.com/users/acozianu/orgs","repos_url":"https://api.github.com/users/acozianu/repos","events_url":"https://api.github.com/users/acozianu/events{/privacy}","received_events_url":"https://api.github.com/users/acozianu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75/commits","review_comments_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75/comments","review_comment_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/75/comments","statuses_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/statuses/4b18c79e7410a3721753ae8a4c129b5a4e35b84f","head":{"label":"dvsa:feature/CVSB-495","ref":"feature/CVSB-495","sha":"4b18c79e7410a3721753ae8a4c129b5a4e35b84f","user":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":117571546,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1NzE1NDY=","name":"cvs-app-mobile","full_name":"dvsa/cvs-app-mobile","private":false,"owner":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dvsa/cvs-app-mobile","description":null,"fork":false,"url":"https://api.github.com/repos/dvsa/cvs-app-mobile","forks_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/forks","keys_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/teams","hooks_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/hooks","issue_events_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/events","assignees_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/tags","blobs_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/languages","stargazers_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/stargazers","contributors_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/contributors","subscribers_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/subscribers","subscription_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/subscription","commits_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/merges","archive_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/downloads","issues_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/deployments","created_at":"2018-01-15T16:54:12Z","updated_at":"2019-02-06T10:59:00Z","pushed_at":"2019-02-06T15:51:29Z","git_url":"git://github.com/dvsa/cvs-app-mobile.git","ssh_url":"git@github.com:dvsa/cvs-app-mobile.git","clone_url":"https://github.com/dvsa/cvs-app-mobile.git","svn_url":"https://github.com/dvsa/cvs-app-mobile","homepage":null,"size":2921,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"dvsa:develop","ref":"develop","sha":"05f870840708a8009998448c0a8783ed8b7ecbef","user":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":117571546,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1NzE1NDY=","name":"cvs-app-mobile","full_name":"dvsa/cvs-app-mobile","private":false,"owner":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dvsa/cvs-app-mobile","description":null,"fork":false,"url":"https://api.github.com/repos/dvsa/cvs-app-mobile","forks_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/forks","keys_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/teams","hooks_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/hooks","issue_events_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/events","assignees_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/tags","blobs_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/languages","stargazers_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/stargazers","contributors_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/contributors","subscribers_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/subscribers","subscription_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/subscription","commits_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/merges","archive_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/downloads","issues_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/cvs-app-mobile/deployments","created_at":"2018-01-15T16:54:12Z","updated_at":"2019-02-06T10:59:00Z","pushed_at":"2019-02-06T15:51:29Z","git_url":"git://github.com/dvsa/cvs-app-mobile.git","ssh_url":"git@github.com:dvsa/cvs-app-mobile.git","clone_url":"https://github.com/dvsa/cvs-app-mobile.git","svn_url":"https://github.com/dvsa/cvs-app-mobile","homepage":null,"size":2921,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75"},"html":{"href":"https://github.com/dvsa/cvs-app-mobile/pull/75"},"issue":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/75"},"comments":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/dvsa/cvs-app-mobile/statuses/4b18c79e7410a3721753ae8a4c129b5a4e35b84f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 117571546,
"name": "dvsa/cvs-app-mobile",
"url": "https://api.github.com/repos/dvsa/cvs-app-mobile"
}
|
{
"id": 45453274,
"login": "vladddragomir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45453274?",
"url": "https://api.github.com/users/vladddragomir"
}
|
{
"id": 24296376,
"login": "dvsa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24296376?",
"url": "https://api.github.com/orgs/dvsa"
}
| 2019-02-07T08:29:27 |
9023743211
|
{"actor":{"display_login":"vladddragomir"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/comments/275782052","pull_request_review_id":227175057,"id":275782052,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTc4MjA1Mg==","diff_hunk":"@@ -0,0 +1,52 @@\n+body, html {\n+ width: 100%;\n+ height: 100%;\n+ position: relative;\n+ display: flex;\n+ flex-direction: column;\n+}\n+\n+body {\n+ min-height: 100%;\n+ display: flex;\n+ flex-direction: column;\n+ align-items: stretch;\n+ background-color: $white;\n+\n+ &.app {\n+ background: $dm-primary-light-grey;\n+ }\n+\n+ &.home {\n+ @include media-breakpoint-up(md) {\n+ height: 40px;\n+ background-repeat: no-repeat;\n+ background-image: url(\"/images/dm-deco-green-medium.svg\"), url(\"/images/dm-deco-green-large.svg\"), url(\"/images/dm-deco-gray-large.svg\"), url(\"/images/dm-deco-green-large.svg\"), url(\"/images/dm-deco-green-medium.svg\"), url(\"/images/dm-deco-violet-tiny.svg\");","path":"web/static/css/layout/_layout.scss","position":24,"original_position":24,"commit_id":"36f7d5762dd6b50b22c1e89c073be2080b2a4cee","original_commit_id":"36f7d5762dd6b50b22c1e89c073be2080b2a4cee","user":{"login":"ebert[bot]","id":23344435,"node_id":"MDM6Qm90MjMzNDQ0MzU=","avatar_url":"https://avatars3.githubusercontent.com/in/597?v=4","gravatar_id":"","url":"https://api.github.com/users/ebert%5Bbot%5D","html_url":"https://github.com/apps/ebert","followers_url":"https://api.github.com/users/ebert%5Bbot%5D/followers","following_url":"https://api.github.com/users/ebert%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/ebert%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/ebert%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebert%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/ebert%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/ebert%5Bbot%5D/repos","events_url":"https://api.github.com/users/ebert%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/ebert%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Prefer single quoted strings\n\n[Read more about it here.](https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#stringquotes)","created_at":"2019-04-16T12:57:50Z","updated_at":"2019-04-16T12:57:50Z","html_url":"https://github.com/StartupsPoleEmploi/avril/pull/63#discussion_r275782052","pull_request_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/comments/275782052"},"html":{"href":"https://github.com/StartupsPoleEmploi/avril/pull/63#discussion_r275782052"},"pull_request":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63","id":270896984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwODk2OTg0","html_url":"https://github.com/StartupsPoleEmploi/avril/pull/63","diff_url":"https://github.com/StartupsPoleEmploi/avril/pull/63.diff","patch_url":"https://github.com/StartupsPoleEmploi/avril/pull/63.patch","issue_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/63","number":63,"state":"open","locked":false,"title":"User profile","user":{"login":"nresni","id":504562,"node_id":"MDQ6VXNlcjUwNDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/504562?v=4","gravatar_id":"","url":"https://api.github.com/users/nresni","html_url":"https://github.com/nresni","followers_url":"https://api.github.com/users/nresni/followers","following_url":"https://api.github.com/users/nresni/following{/other_user}","gists_url":"https://api.github.com/users/nresni/gists{/gist_id}","starred_url":"https://api.github.com/users/nresni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nresni/subscriptions","organizations_url":"https://api.github.com/users/nresni/orgs","repos_url":"https://api.github.com/users/nresni/repos","events_url":"https://api.github.com/users/nresni/events{/privacy}","received_events_url":"https://api.github.com/users/nresni/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-16T12:55:36Z","updated_at":"2019-04-16T12:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e265df1371e0811977667a48272aa9dde86e904d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63/commits","review_comments_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63/comments","review_comment_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/63/comments","statuses_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/statuses/36f7d5762dd6b50b22c1e89c073be2080b2a4cee","head":{"label":"StartupsPoleEmploi:user-profile","ref":"user-profile","sha":"36f7d5762dd6b50b22c1e89c073be2080b2a4cee","user":{"login":"StartupsPoleEmploi","id":24388500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg4NTAw","avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"repo":{"id":122945984,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5NDU5ODQ=","name":"avril","full_name":"StartupsPoleEmploi/avril","private":false,"owner":{"login":"StartupsPoleEmploi","id":24388500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg4NTAw","avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/StartupsPoleEmploi/avril","description":"Startup Avril","fork":false,"url":"https://api.github.com/repos/StartupsPoleEmploi/avril","forks_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/forks","keys_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/teams","hooks_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/hooks","issue_events_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/events{/number}","events_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/events","assignees_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/assignees{/user}","branches_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/branches{/branch}","tags_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/tags","blobs_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/refs{/sha}","trees_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/statuses/{sha}","languages_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/languages","stargazers_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/stargazers","contributors_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/contributors","subscribers_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/subscribers","subscription_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/subscription","commits_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/commits{/sha}","git_commits_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/commits{/sha}","comments_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/comments{/number}","issue_comment_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/comments{/number}","contents_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/contents/{+path}","compare_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/merges","archive_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/downloads","issues_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues{/number}","pulls_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls{/number}","milestones_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/milestones{/number}","notifications_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/labels{/name}","releases_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/releases{/id}","deployments_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/deployments","created_at":"2018-02-26T09:29:34Z","updated_at":"2019-04-09T16:14:38Z","pushed_at":"2019-04-16T12:55:36Z","git_url":"git://github.com/StartupsPoleEmploi/avril.git","ssh_url":"git@github.com:StartupsPoleEmploi/avril.git","clone_url":"https://github.com/StartupsPoleEmploi/avril.git","svn_url":"https://github.com/StartupsPoleEmploi/avril","homepage":"https://avril.pole-emploi.fr","size":20279,"stargazers_count":3,"watchers_count":3,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"StartupsPoleEmploi:master","ref":"master","sha":"83ba4b676db319dfbae7d0b5950b986c2fb2e04e","user":{"login":"StartupsPoleEmploi","id":24388500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg4NTAw","avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"repo":{"id":122945984,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5NDU5ODQ=","name":"avril","full_name":"StartupsPoleEmploi/avril","private":false,"owner":{"login":"StartupsPoleEmploi","id":24388500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mzg4NTAw","avatar_url":"https://avatars0.githubusercontent.com/u/24388500?v=4","gravatar_id":"","url":"https://api.github.com/users/StartupsPoleEmploi","html_url":"https://github.com/StartupsPoleEmploi","followers_url":"https://api.github.com/users/StartupsPoleEmploi/followers","following_url":"https://api.github.com/users/StartupsPoleEmploi/following{/other_user}","gists_url":"https://api.github.com/users/StartupsPoleEmploi/gists{/gist_id}","starred_url":"https://api.github.com/users/StartupsPoleEmploi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StartupsPoleEmploi/subscriptions","organizations_url":"https://api.github.com/users/StartupsPoleEmploi/orgs","repos_url":"https://api.github.com/users/StartupsPoleEmploi/repos","events_url":"https://api.github.com/users/StartupsPoleEmploi/events{/privacy}","received_events_url":"https://api.github.com/users/StartupsPoleEmploi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/StartupsPoleEmploi/avril","description":"Startup Avril","fork":false,"url":"https://api.github.com/repos/StartupsPoleEmploi/avril","forks_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/forks","keys_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/teams","hooks_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/hooks","issue_events_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/events{/number}","events_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/events","assignees_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/assignees{/user}","branches_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/branches{/branch}","tags_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/tags","blobs_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/refs{/sha}","trees_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/statuses/{sha}","languages_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/languages","stargazers_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/stargazers","contributors_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/contributors","subscribers_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/subscribers","subscription_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/subscription","commits_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/commits{/sha}","git_commits_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/git/commits{/sha}","comments_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/comments{/number}","issue_comment_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/comments{/number}","contents_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/contents/{+path}","compare_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/merges","archive_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/downloads","issues_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues{/number}","pulls_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls{/number}","milestones_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/milestones{/number}","notifications_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/labels{/name}","releases_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/releases{/id}","deployments_url":"https://api.github.com/repos/StartupsPoleEmploi/avril/deployments","created_at":"2018-02-26T09:29:34Z","updated_at":"2019-04-09T16:14:38Z","pushed_at":"2019-04-16T12:55:36Z","git_url":"git://github.com/StartupsPoleEmploi/avril.git","ssh_url":"git@github.com:StartupsPoleEmploi/avril.git","clone_url":"https://github.com/StartupsPoleEmploi/avril.git","svn_url":"https://github.com/StartupsPoleEmploi/avril","homepage":"https://avril.pole-emploi.fr","size":20279,"stargazers_count":3,"watchers_count":3,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63"},"html":{"href":"https://github.com/StartupsPoleEmploi/avril/pull/63"},"issue":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/63"},"comments":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/StartupsPoleEmploi/avril/statuses/36f7d5762dd6b50b22c1e89c073be2080b2a4cee"}},"author_association":"COLLABORATOR"}}
|
{
"id": 122945984,
"name": "StartupsPoleEmploi/avril",
"url": "https://api.github.com/repos/StartupsPoleEmploi/avril"
}
|
{
"id": 23344435,
"login": "ebert[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23344435?",
"url": "https://api.github.com/users/ebert[bot]"
}
|
{
"id": 24388500,
"login": "StartupsPoleEmploi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24388500?",
"url": "https://api.github.com/orgs/StartupsPoleEmploi"
}
| 2019-04-16T12:57:50 |
9452991371
|
{"actor":{"display_login":"ebert"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments/268871164","pull_request_review_id":218608486,"id":268871164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODg3MTE2NA==","diff_hunk":"@@ -55,6 +55,11 @@ BEGIN\n BEGIN\r\n END\r\n \r\n+\tIDD_NETWORK_CFG, DIALOG\r","path":"resource/Cxbx.rc","position":4,"original_position":4,"commit_id":"20aa13b44e839bcc5d33545bd370e29fda8d95aa","original_commit_id":"20aa13b44e839bcc5d33545bd370e29fda8d95aa","user":{"login":"LukeUsher","id":740003,"node_id":"MDQ6VXNlcjc0MDAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/740003?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeUsher","html_url":"https://github.com/LukeUsher","followers_url":"https://api.github.com/users/LukeUsher/followers","following_url":"https://api.github.com/users/LukeUsher/following{/other_user}","gists_url":"https://api.github.com/users/LukeUsher/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeUsher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeUsher/subscriptions","organizations_url":"https://api.github.com/users/LukeUsher/orgs","repos_url":"https://api.github.com/users/LukeUsher/repos","events_url":"https://api.github.com/users/LukeUsher/events{/privacy}","received_events_url":"https://api.github.com/users/LukeUsher/received_events","type":"User","site_admin":false},"body":"This was edited with Visual Studio, so no idea","created_at":"2019-03-25T22:03:32Z","updated_at":"2019-03-25T22:03:33Z","html_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1572#discussion_r268871164","pull_request_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments/268871164"},"html":{"href":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1572#discussion_r268871164"},"pull_request":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572"}},"in_reply_to_id":268865764},"pull_request":{"url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572","id":264260538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0MjYwNTM4","html_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1572","diff_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1572.diff","patch_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1572.patch","issue_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1572","number":1572,"state":"open","locked":false,"title":"Introduce Network Support (System Link/Lan)","user":{"login":"LukeUsher","id":740003,"node_id":"MDQ6VXNlcjc0MDAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/740003?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeUsher","html_url":"https://github.com/LukeUsher","followers_url":"https://api.github.com/users/LukeUsher/followers","following_url":"https://api.github.com/users/LukeUsher/following{/other_user}","gists_url":"https://api.github.com/users/LukeUsher/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeUsher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeUsher/subscriptions","organizations_url":"https://api.github.com/users/LukeUsher/orgs","repos_url":"https://api.github.com/users/LukeUsher/repos","events_url":"https://api.github.com/users/LukeUsher/events{/privacy}","received_events_url":"https://api.github.com/users/LukeUsher/received_events","type":"User","site_admin":false},"body":"This PR builds upon the existing NVNet network hardware emulation to allow System Link/Lan play.\r\n\r\nNotes:\r\n* LAN Play/System Link works across Real hardware, Cxbx-R, and XQEMU: Players from all three can join in matches together, provided they are on the same local network.\r\n * Playing with Real Hardware & XQEMU requires keys dumped from a real xbox. A python script for dumping keys with xboxpy is provided by JayFoxRox [Here](https://github.com/JayFoxRox/xbox-tools/blob/master/python-scripts/dump-keys.py)\r\n* MAC address based networking is functional (System Link will work), but TCP/IP networking is still broken: so no internet access or FTP servers in Cxbx-R just yet.\r\n* Due to limitations with PCAP drivers, LAN play will only work over Ethernet, Wifi is currently unsupported.\r\n\r\nSpecial thanks to mborgerson (who reverse engineered the NVNet hardware and implemented it within XQEMU), JayFoxRox (for the key dumping script, general tips/support and testing), and the rest of the XQEMU team for helping to make this possible.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2019-03-25T19:38:38Z","updated_at":"2019-03-25T22:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4502db0f7c8f6b13d0940488a1522a74d5ff68f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572/commits","review_comments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572/comments","review_comment_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1572/comments","statuses_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/statuses/20aa13b44e839bcc5d33545bd370e29fda8d95aa","head":{"label":"LukeUsher:nvnet-revisited","ref":"nvnet-revisited","sha":"20aa13b44e839bcc5d33545bd370e29fda8d95aa","user":{"login":"LukeUsher","id":740003,"node_id":"MDQ6VXNlcjc0MDAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/740003?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeUsher","html_url":"https://github.com/LukeUsher","followers_url":"https://api.github.com/users/LukeUsher/followers","following_url":"https://api.github.com/users/LukeUsher/following{/other_user}","gists_url":"https://api.github.com/users/LukeUsher/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeUsher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeUsher/subscriptions","organizations_url":"https://api.github.com/users/LukeUsher/orgs","repos_url":"https://api.github.com/users/LukeUsher/repos","events_url":"https://api.github.com/users/LukeUsher/events{/privacy}","received_events_url":"https://api.github.com/users/LukeUsher/received_events","type":"User","site_admin":false},"repo":{"id":76664745,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY2NDc0NQ==","name":"Cxbx-Reloaded","full_name":"LukeUsher/Cxbx-Reloaded","private":false,"owner":{"login":"LukeUsher","id":740003,"node_id":"MDQ6VXNlcjc0MDAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/740003?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeUsher","html_url":"https://github.com/LukeUsher","followers_url":"https://api.github.com/users/LukeUsher/followers","following_url":"https://api.github.com/users/LukeUsher/following{/other_user}","gists_url":"https://api.github.com/users/LukeUsher/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeUsher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeUsher/subscriptions","organizations_url":"https://api.github.com/users/LukeUsher/orgs","repos_url":"https://api.github.com/users/LukeUsher/repos","events_url":"https://api.github.com/users/LukeUsher/events{/privacy}","received_events_url":"https://api.github.com/users/LukeUsher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LukeUsher/Cxbx-Reloaded","description":"Xbox (Original) Emulator","fork":true,"url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded","forks_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/forks","keys_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/teams","hooks_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/hooks","issue_events_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/issues/events{/number}","events_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/events","assignees_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/assignees{/user}","branches_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/branches{/branch}","tags_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/tags","blobs_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/git/refs{/sha}","trees_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/statuses/{sha}","languages_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/languages","stargazers_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/stargazers","contributors_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/contributors","subscribers_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/subscribers","subscription_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/subscription","commits_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/commits{/sha}","git_commits_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/git/commits{/sha}","comments_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/comments{/number}","issue_comment_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/issues/comments{/number}","contents_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/contents/{+path}","compare_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/merges","archive_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/downloads","issues_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/issues{/number}","pulls_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/pulls{/number}","milestones_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/milestones{/number}","notifications_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/labels{/name}","releases_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/releases{/id}","deployments_url":"https://api.github.com/repos/LukeUsher/Cxbx-Reloaded/deployments","created_at":"2016-12-16T15:37:36Z","updated_at":"2019-03-04T20:52:51Z","pushed_at":"2019-03-25T19:21:27Z","git_url":"git://github.com/LukeUsher/Cxbx-Reloaded.git","ssh_url":"git@github.com:LukeUsher/Cxbx-Reloaded.git","clone_url":"https://github.com/LukeUsher/Cxbx-Reloaded.git","svn_url":"https://github.com/LukeUsher/Cxbx-Reloaded","homepage":"","size":71411,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2,"open_issues":3,"watchers":15,"default_branch":"develop"}},"base":{"label":"Cxbx-Reloaded:develop","ref":"develop","sha":"528ec0c926d2f4720c8d1e3e539a914b73c7d277","user":{"login":"Cxbx-Reloaded","id":24608560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjA4NTYw","avatar_url":"https://avatars1.githubusercontent.com/u/24608560?v=4","gravatar_id":"","url":"https://api.github.com/users/Cxbx-Reloaded","html_url":"https://github.com/Cxbx-Reloaded","followers_url":"https://api.github.com/users/Cxbx-Reloaded/followers","following_url":"https://api.github.com/users/Cxbx-Reloaded/following{/other_user}","gists_url":"https://api.github.com/users/Cxbx-Reloaded/gists{/gist_id}","starred_url":"https://api.github.com/users/Cxbx-Reloaded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cxbx-Reloaded/subscriptions","organizations_url":"https://api.github.com/users/Cxbx-Reloaded/orgs","repos_url":"https://api.github.com/users/Cxbx-Reloaded/repos","events_url":"https://api.github.com/users/Cxbx-Reloaded/events{/privacy}","received_events_url":"https://api.github.com/users/Cxbx-Reloaded/received_events","type":"Organization","site_admin":false},"repo":{"id":55772388,"node_id":"MDEwOlJlcG9zaXRvcnk1NTc3MjM4OA==","name":"Cxbx-Reloaded","full_name":"Cxbx-Reloaded/Cxbx-Reloaded","private":false,"owner":{"login":"Cxbx-Reloaded","id":24608560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjA4NTYw","avatar_url":"https://avatars1.githubusercontent.com/u/24608560?v=4","gravatar_id":"","url":"https://api.github.com/users/Cxbx-Reloaded","html_url":"https://github.com/Cxbx-Reloaded","followers_url":"https://api.github.com/users/Cxbx-Reloaded/followers","following_url":"https://api.github.com/users/Cxbx-Reloaded/following{/other_user}","gists_url":"https://api.github.com/users/Cxbx-Reloaded/gists{/gist_id}","starred_url":"https://api.github.com/users/Cxbx-Reloaded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cxbx-Reloaded/subscriptions","organizations_url":"https://api.github.com/users/Cxbx-Reloaded/orgs","repos_url":"https://api.github.com/users/Cxbx-Reloaded/repos","events_url":"https://api.github.com/users/Cxbx-Reloaded/events{/privacy}","received_events_url":"https://api.github.com/users/Cxbx-Reloaded/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded","description":"Xbox (Original) Emulator","fork":false,"url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded","forks_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/forks","keys_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/teams","hooks_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/hooks","issue_events_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/events{/number}","events_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/events","assignees_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/assignees{/user}","branches_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/branches{/branch}","tags_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/tags","blobs_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/statuses/{sha}","languages_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/languages","stargazers_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/stargazers","contributors_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/contributors","subscribers_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/subscribers","subscription_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/subscription","commits_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/contents/{+path}","compare_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/merges","archive_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/downloads","issues_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues{/number}","pulls_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls{/number}","milestones_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/milestones{/number}","notifications_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/labels{/name}","releases_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/releases{/id}","deployments_url":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/deployments","created_at":"2016-04-08T10:56:52Z","updated_at":"2019-03-24T19:14:52Z","pushed_at":"2019-03-25T19:38:39Z","git_url":"git://github.com/Cxbx-Reloaded/Cxbx-Reloaded.git","ssh_url":"git@github.com:Cxbx-Reloaded/Cxbx-Reloaded.git","clone_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded.git","svn_url":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded","homepage":"","size":68578,"stargazers_count":865,"watchers_count":865,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":136,"open_issues":154,"watchers":865,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572"},"html":{"href":"https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1572"},"issue":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1572"},"comments":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/issues/1572/comments"},"review_comments":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572/comments"},"review_comment":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/pulls/1572/commits"},"statuses":{"href":"https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded/statuses/20aa13b44e839bcc5d33545bd370e29fda8d95aa"}},"author_association":"MEMBER"}}
|
{
"id": 55772388,
"name": "Cxbx-Reloaded/Cxbx-Reloaded",
"url": "https://api.github.com/repos/Cxbx-Reloaded/Cxbx-Reloaded"
}
|
{
"id": 740003,
"login": "LukeUsher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/740003?",
"url": "https://api.github.com/users/LukeUsher"
}
|
{
"id": 24608560,
"login": "Cxbx-Reloaded",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24608560?",
"url": "https://api.github.com/orgs/Cxbx-Reloaded"
}
| 2019-03-25T22:03:32 |
9311668570
|
{"actor":{"display_login":"LukeUsher"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments/363388502","pull_request_review_id":338770169,"id":363388502,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzM4ODUwMg==","diff_hunk":"@@ -0,0 +1,47 @@\n+#pragma once\n+\n+#include <string>\n+#include <unordered_map>\n+\n+#include <arbor/morph/embed_pwlin1d.hpp>\n+#include <arbor/morph/primitives.hpp>\n+#include <arbor/morph/label_dict.hpp>\n+#include <arbor/util/either.hpp>\n+\n+namespace arb {\n+\n+using concrete_embedding = embed_pwlin1d;\n+\n+struct mprovider {","path":"arbor/include/arbor/morph/mprovider.hpp","position":15,"original_position":15,"commit_id":"044479268b735b71e66ef1a34d4287c505d436d0","original_commit_id":"044479268b735b71e66ef1a34d4287c505d436d0","user":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"body":"> Does this boil down to a workaround of `thingify` inside the constructor, using the partially constructed `provider` for one of its arguments?\r\n> \r\n> If so, can we have private member functions that perform the `try_lookup` guff and are only called in the constructor? That way the `region()` and `locset()` public members can do a simple const-friendly lookup.\r\n\r\nThey can't be 'really' const, because they need to be able to update the concrete maps during initialization (short of moving to e.g. option (2) above).","created_at":"2020-01-06T17:08:22Z","updated_at":"2020-01-06T17:08:22Z","html_url":"https://github.com/arbor-sim/arbor/pull/918#discussion_r363388502","pull_request_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/918","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments/363388502"},"html":{"href":"https://github.com/arbor-sim/arbor/pull/918#discussion_r363388502"},"pull_request":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/918"}},"in_reply_to_id":363309308},"pull_request":{"url":"https://api.github.com/repos/arbor-sim/arbor/pulls/918","id":350857392,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwODU3Mzky","html_url":"https://github.com/arbor-sim/arbor/pull/918","diff_url":"https://github.com/arbor-sim/arbor/pull/918.diff","patch_url":"https://github.com/arbor-sim/arbor/pull/918.patch","issue_url":"https://api.github.com/repos/arbor-sim/arbor/issues/918","number":918,"state":"open","locked":false,"title":"Replace em_morphology middle layer API.","user":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"body":"* Consolidate embedding-dependent morphology data in new class `embed_pwlin1d`, which provides sample location lookup, handles branch and radius queries, and performs piecewise-constant integration over a branch by length, branch surface area, or inverse cross-sectional area.\r\n* Extend region and locset expressions to represent named regions/locsets.\r\n* Rearrange morphology-related functionality so that morphology-independent functions are provided via `morph/primitives.hpp` and topological functionality via `morph/morphology.hpp` and `morphology` methods.\r\n* Provide new class `mprovider` which gathers a morphology, its embedding, and a concrete label dictionary.\r\n* Populate mprovider concrete region/locset maps at initialization time, throwing exceptions if there are unresolved references or circular dependencies.\r\n* Gather and unify morphology-related exceptions in `morphexcept.hpp/cpp`, unifying error text and providing programmatically readable associated data, akin to `arbexcept.hpp/cpp`.\r\n* Simplify cable_cell painting/placing interfaces.\r\n* Add generic representation of piecewise-specified data with `pw_elements` classes.\r\n* Add representation of rational-polynomial interpolatated elements over the unit interval; sufficient for embedding integration services, but the implemented algorithm is subject to singularities if data can be represented by a lower-order denominator than requested.\r\n* Move `sum` from `algorithms` to `util`.\r\n* Make `util::either` public.\r\n* Add unit tests for existing morphology primitive operations.\r\n* Add unit tests for new functionality/APIs.","created_at":"2019-12-09T18:21:04Z","updated_at":"2020-01-06T17:08:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7685de284750f0075bb2de768f4c01b1a39472fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/918/commits","review_comments_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/918/comments","review_comment_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arbor-sim/arbor/issues/918/comments","statuses_url":"https://api.github.com/repos/arbor-sim/arbor/statuses/044479268b735b71e66ef1a34d4287c505d436d0","head":{"label":"halfflat:feature/em-morph-split-squashed","ref":"feature/em-morph-split-squashed","sha":"044479268b735b71e66ef1a34d4287c505d436d0","user":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"repo":{"id":70549033,"node_id":"MDEwOlJlcG9zaXRvcnk3MDU0OTAzMw==","name":"arbor","full_name":"halfflat/arbor","private":false,"owner":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/halfflat/arbor","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":true,"url":"https://api.github.com/repos/halfflat/arbor","forks_url":"https://api.github.com/repos/halfflat/arbor/forks","keys_url":"https://api.github.com/repos/halfflat/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halfflat/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halfflat/arbor/teams","hooks_url":"https://api.github.com/repos/halfflat/arbor/hooks","issue_events_url":"https://api.github.com/repos/halfflat/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/halfflat/arbor/events","assignees_url":"https://api.github.com/repos/halfflat/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/halfflat/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/halfflat/arbor/tags","blobs_url":"https://api.github.com/repos/halfflat/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halfflat/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halfflat/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/halfflat/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halfflat/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/halfflat/arbor/languages","stargazers_url":"https://api.github.com/repos/halfflat/arbor/stargazers","contributors_url":"https://api.github.com/repos/halfflat/arbor/contributors","subscribers_url":"https://api.github.com/repos/halfflat/arbor/subscribers","subscription_url":"https://api.github.com/repos/halfflat/arbor/subscription","commits_url":"https://api.github.com/repos/halfflat/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/halfflat/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/halfflat/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/halfflat/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/halfflat/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/halfflat/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halfflat/arbor/merges","archive_url":"https://api.github.com/repos/halfflat/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halfflat/arbor/downloads","issues_url":"https://api.github.com/repos/halfflat/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/halfflat/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/halfflat/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/halfflat/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halfflat/arbor/labels{/name}","releases_url":"https://api.github.com/repos/halfflat/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/halfflat/arbor/deployments","created_at":"2016-10-11T02:43:08Z","updated_at":"2019-12-24T18:17:08Z","pushed_at":"2020-01-06T11:10:28Z","git_url":"git://github.com/halfflat/arbor.git","ssh_url":"git@github.com:halfflat/arbor.git","clone_url":"https://github.com/halfflat/arbor.git","svn_url":"https://github.com/halfflat/arbor","homepage":"https://github.com/arbor-sim/arbor","size":5120,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arbor-sim:master","ref":"master","sha":"3cae324e1b1c497be5bed9522e4b9b2f3b71d724","user":{"login":"arbor-sim","id":24656287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU2Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/24656287?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor-sim","html_url":"https://github.com/arbor-sim","followers_url":"https://api.github.com/users/arbor-sim/followers","following_url":"https://api.github.com/users/arbor-sim/following{/other_user}","gists_url":"https://api.github.com/users/arbor-sim/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor-sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor-sim/subscriptions","organizations_url":"https://api.github.com/users/arbor-sim/orgs","repos_url":"https://api.github.com/users/arbor-sim/repos","events_url":"https://api.github.com/users/arbor-sim/events{/privacy}","received_events_url":"https://api.github.com/users/arbor-sim/received_events","type":"Organization","site_admin":false},"repo":{"id":69863074,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg2MzA3NA==","name":"arbor","full_name":"arbor-sim/arbor","private":false,"owner":{"login":"arbor-sim","id":24656287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU2Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/24656287?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor-sim","html_url":"https://github.com/arbor-sim","followers_url":"https://api.github.com/users/arbor-sim/followers","following_url":"https://api.github.com/users/arbor-sim/following{/other_user}","gists_url":"https://api.github.com/users/arbor-sim/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor-sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor-sim/subscriptions","organizations_url":"https://api.github.com/users/arbor-sim/orgs","repos_url":"https://api.github.com/users/arbor-sim/repos","events_url":"https://api.github.com/users/arbor-sim/events{/privacy}","received_events_url":"https://api.github.com/users/arbor-sim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arbor-sim/arbor","description":"The Arbor multi-compartment neural network simulation library.","fork":false,"url":"https://api.github.com/repos/arbor-sim/arbor","forks_url":"https://api.github.com/repos/arbor-sim/arbor/forks","keys_url":"https://api.github.com/repos/arbor-sim/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arbor-sim/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arbor-sim/arbor/teams","hooks_url":"https://api.github.com/repos/arbor-sim/arbor/hooks","issue_events_url":"https://api.github.com/repos/arbor-sim/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/arbor-sim/arbor/events","assignees_url":"https://api.github.com/repos/arbor-sim/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/arbor-sim/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/arbor-sim/arbor/tags","blobs_url":"https://api.github.com/repos/arbor-sim/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arbor-sim/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arbor-sim/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/arbor-sim/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arbor-sim/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/arbor-sim/arbor/languages","stargazers_url":"https://api.github.com/repos/arbor-sim/arbor/stargazers","contributors_url":"https://api.github.com/repos/arbor-sim/arbor/contributors","subscribers_url":"https://api.github.com/repos/arbor-sim/arbor/subscribers","subscription_url":"https://api.github.com/repos/arbor-sim/arbor/subscription","commits_url":"https://api.github.com/repos/arbor-sim/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/arbor-sim/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/arbor-sim/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/arbor-sim/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/arbor-sim/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/arbor-sim/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arbor-sim/arbor/merges","archive_url":"https://api.github.com/repos/arbor-sim/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arbor-sim/arbor/downloads","issues_url":"https://api.github.com/repos/arbor-sim/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/arbor-sim/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/arbor-sim/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/arbor-sim/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arbor-sim/arbor/labels{/name}","releases_url":"https://api.github.com/repos/arbor-sim/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/arbor-sim/arbor/deployments","created_at":"2016-10-03T11:03:22Z","updated_at":"2019-12-20T21:02:41Z","pushed_at":"2020-01-06T14:54:45Z","git_url":"git://github.com/arbor-sim/arbor.git","ssh_url":"git@github.com:arbor-sim/arbor.git","clone_url":"https://github.com/arbor-sim/arbor.git","svn_url":"https://github.com/arbor-sim/arbor","homepage":"","size":5062,"stargazers_count":41,"watchers_count":41,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":114,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":114,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/918"},"html":{"href":"https://github.com/arbor-sim/arbor/pull/918"},"issue":{"href":"https://api.github.com/repos/arbor-sim/arbor/issues/918"},"comments":{"href":"https://api.github.com/repos/arbor-sim/arbor/issues/918/comments"},"review_comments":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/918/comments"},"review_comment":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/918/commits"},"statuses":{"href":"https://api.github.com/repos/arbor-sim/arbor/statuses/044479268b735b71e66ef1a34d4287c505d436d0"}},"author_association":"COLLABORATOR"}}
|
{
"id": 69863074,
"name": "arbor-sim/arbor",
"url": "https://api.github.com/repos/arbor-sim/arbor"
}
|
{
"id": 556816,
"login": "halfflat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/556816?",
"url": "https://api.github.com/users/halfflat"
}
|
{
"id": 24656287,
"login": "arbor-sim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24656287?",
"url": "https://api.github.com/orgs/arbor-sim"
}
| 2020-01-06T17:08:22 |
11212247793
|
{"actor":{"display_login":"halfflat"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments/314651472","pull_request_review_id":275860752,"id":314651472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDY1MTQ3Mg==","diff_hunk":"@@ -56,8 +63,8 @@ double estimate_cost(const sym_matrix& A, unsigned p) {\n };\n \n for (unsigned i = 0; i<A.nrow(); ++i) {\n- if (i==p || A[i].index(p)==msparse::row_npos) continue;\n- row_reduce(p, A[i], A[p], count_fill);\n+ if (i==p.row || A[i].index(p.col)==msparse::row_npos) continue;\n+ row_reduce(p.col, A[i], A[p.row], count_fill);","path":"modcc/symge.cpp","position":35,"original_position":35,"commit_id":"45206ee79b943a11dcfc5774f4659f90aaacb286","original_commit_id":"45206ee79b943a11dcfc5774f4659f90aaacb286","user":{"login":"noraabiakar","id":18661075,"node_id":"MDQ6VXNlcjE4NjYxMDc1","avatar_url":"https://avatars1.githubusercontent.com/u/18661075?v=4","gravatar_id":"","url":"https://api.github.com/users/noraabiakar","html_url":"https://github.com/noraabiakar","followers_url":"https://api.github.com/users/noraabiakar/followers","following_url":"https://api.github.com/users/noraabiakar/following{/other_user}","gists_url":"https://api.github.com/users/noraabiakar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraabiakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraabiakar/subscriptions","organizations_url":"https://api.github.com/users/noraabiakar/orgs","repos_url":"https://api.github.com/users/noraabiakar/repos","events_url":"https://api.github.com/users/noraabiakar/events{/privacy}","received_events_url":"https://api.github.com/users/noraabiakar/received_events","type":"User","site_admin":false},"body":"Thanks :)","created_at":"2019-08-16T09:40:09Z","updated_at":"2019-08-16T09:40:10Z","html_url":"https://github.com/arbor-sim/arbor/pull/840#discussion_r314651472","pull_request_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/840","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments/314651472"},"html":{"href":"https://github.com/arbor-sim/arbor/pull/840#discussion_r314651472"},"pull_request":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/840"}},"in_reply_to_id":314619864},"pull_request":{"url":"https://api.github.com/repos/arbor-sim/arbor/pulls/840","id":307690203,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NjkwMjAz","html_url":"https://github.com/arbor-sim/arbor/pull/840","diff_url":"https://github.com/arbor-sim/arbor/pull/840.diff","patch_url":"https://github.com/arbor-sim/arbor/pull/840.patch","issue_url":"https://api.github.com/repos/arbor-sim/arbor/issues/840","number":840,"state":"open","locked":false,"title":"modcc: parse and process `LINEAR` blocks","user":{"login":"noraabiakar","id":18661075,"node_id":"MDQ6VXNlcjE4NjYxMDc1","avatar_url":"https://avatars1.githubusercontent.com/u/18661075?v=4","gravatar_id":"","url":"https://api.github.com/users/noraabiakar","html_url":"https://github.com/noraabiakar","followers_url":"https://api.github.com/users/noraabiakar/followers","following_url":"https://api.github.com/users/noraabiakar/following{/other_user}","gists_url":"https://api.github.com/users/noraabiakar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraabiakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraabiakar/subscriptions","organizations_url":"https://api.github.com/users/noraabiakar/orgs","repos_url":"https://api.github.com/users/noraabiakar/repos","events_url":"https://api.github.com/users/noraabiakar/events{/privacy}","received_events_url":"https://api.github.com/users/noraabiakar/received_events","type":"User","site_admin":false},"body":"Add support for parsing and processing `LINEAR` blocks: \r\n\r\nChanges: \r\n* `SOLVE` expressions can be called from inside an `INITIAL` block, but only if they are solving a linear system\r\n* Tilde expressions can now be either linear expressions or reaction expressions\r\n* Linear expressions need to be rewritten before being sent to the solver, this is done using `LinearRewriter`\r\n* The linear system is setup in `LinearSolverVisitor` fills the lhs and rhs of the symbolic matrix \r\n* The matrix is recued using `gj_reduce`, which now works on non-diagonal matrices. \r\n\r\nFixes #839 ","created_at":"2019-08-15T12:37:03Z","updated_at":"2019-08-16T09:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07d9c7c5c52cbe58660f68853ac260a67af48774","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/840/commits","review_comments_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/840/comments","review_comment_url":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arbor-sim/arbor/issues/840/comments","statuses_url":"https://api.github.com/repos/arbor-sim/arbor/statuses/45206ee79b943a11dcfc5774f4659f90aaacb286","head":{"label":"noraabiakar:modcc-linear-rebase","ref":"modcc-linear-rebase","sha":"45206ee79b943a11dcfc5774f4659f90aaacb286","user":{"login":"noraabiakar","id":18661075,"node_id":"MDQ6VXNlcjE4NjYxMDc1","avatar_url":"https://avatars1.githubusercontent.com/u/18661075?v=4","gravatar_id":"","url":"https://api.github.com/users/noraabiakar","html_url":"https://github.com/noraabiakar","followers_url":"https://api.github.com/users/noraabiakar/followers","following_url":"https://api.github.com/users/noraabiakar/following{/other_user}","gists_url":"https://api.github.com/users/noraabiakar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraabiakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraabiakar/subscriptions","organizations_url":"https://api.github.com/users/noraabiakar/orgs","repos_url":"https://api.github.com/users/noraabiakar/repos","events_url":"https://api.github.com/users/noraabiakar/events{/privacy}","received_events_url":"https://api.github.com/users/noraabiakar/received_events","type":"User","site_admin":false},"repo":{"id":128177287,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxNzcyODc=","name":"arbor","full_name":"noraabiakar/arbor","private":false,"owner":{"login":"noraabiakar","id":18661075,"node_id":"MDQ6VXNlcjE4NjYxMDc1","avatar_url":"https://avatars1.githubusercontent.com/u/18661075?v=4","gravatar_id":"","url":"https://api.github.com/users/noraabiakar","html_url":"https://github.com/noraabiakar","followers_url":"https://api.github.com/users/noraabiakar/followers","following_url":"https://api.github.com/users/noraabiakar/following{/other_user}","gists_url":"https://api.github.com/users/noraabiakar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraabiakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraabiakar/subscriptions","organizations_url":"https://api.github.com/users/noraabiakar/orgs","repos_url":"https://api.github.com/users/noraabiakar/repos","events_url":"https://api.github.com/users/noraabiakar/events{/privacy}","received_events_url":"https://api.github.com/users/noraabiakar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/noraabiakar/arbor","description":"The Arbor multi-compartment neural network simulation library.","fork":true,"url":"https://api.github.com/repos/noraabiakar/arbor","forks_url":"https://api.github.com/repos/noraabiakar/arbor/forks","keys_url":"https://api.github.com/repos/noraabiakar/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noraabiakar/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noraabiakar/arbor/teams","hooks_url":"https://api.github.com/repos/noraabiakar/arbor/hooks","issue_events_url":"https://api.github.com/repos/noraabiakar/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/noraabiakar/arbor/events","assignees_url":"https://api.github.com/repos/noraabiakar/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/noraabiakar/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/noraabiakar/arbor/tags","blobs_url":"https://api.github.com/repos/noraabiakar/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noraabiakar/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noraabiakar/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/noraabiakar/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noraabiakar/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/noraabiakar/arbor/languages","stargazers_url":"https://api.github.com/repos/noraabiakar/arbor/stargazers","contributors_url":"https://api.github.com/repos/noraabiakar/arbor/contributors","subscribers_url":"https://api.github.com/repos/noraabiakar/arbor/subscribers","subscription_url":"https://api.github.com/repos/noraabiakar/arbor/subscription","commits_url":"https://api.github.com/repos/noraabiakar/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/noraabiakar/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/noraabiakar/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/noraabiakar/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/noraabiakar/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/noraabiakar/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noraabiakar/arbor/merges","archive_url":"https://api.github.com/repos/noraabiakar/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noraabiakar/arbor/downloads","issues_url":"https://api.github.com/repos/noraabiakar/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/noraabiakar/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/noraabiakar/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/noraabiakar/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noraabiakar/arbor/labels{/name}","releases_url":"https://api.github.com/repos/noraabiakar/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/noraabiakar/arbor/deployments","created_at":"2018-04-05T08:13:39Z","updated_at":"2019-04-05T08:12:08Z","pushed_at":"2019-08-15T11:50:58Z","git_url":"git://github.com/noraabiakar/arbor.git","ssh_url":"git@github.com:noraabiakar/arbor.git","clone_url":"https://github.com/noraabiakar/arbor.git","svn_url":"https://github.com/noraabiakar/arbor","homepage":"","size":5573,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arbor-sim:master","ref":"master","sha":"fdd9e7eee2ff3446871540768d582fa53ebf0ee3","user":{"login":"arbor-sim","id":24656287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU2Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/24656287?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor-sim","html_url":"https://github.com/arbor-sim","followers_url":"https://api.github.com/users/arbor-sim/followers","following_url":"https://api.github.com/users/arbor-sim/following{/other_user}","gists_url":"https://api.github.com/users/arbor-sim/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor-sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor-sim/subscriptions","organizations_url":"https://api.github.com/users/arbor-sim/orgs","repos_url":"https://api.github.com/users/arbor-sim/repos","events_url":"https://api.github.com/users/arbor-sim/events{/privacy}","received_events_url":"https://api.github.com/users/arbor-sim/received_events","type":"Organization","site_admin":false},"repo":{"id":69863074,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg2MzA3NA==","name":"arbor","full_name":"arbor-sim/arbor","private":false,"owner":{"login":"arbor-sim","id":24656287,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjU2Mjg3","avatar_url":"https://avatars2.githubusercontent.com/u/24656287?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor-sim","html_url":"https://github.com/arbor-sim","followers_url":"https://api.github.com/users/arbor-sim/followers","following_url":"https://api.github.com/users/arbor-sim/following{/other_user}","gists_url":"https://api.github.com/users/arbor-sim/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor-sim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor-sim/subscriptions","organizations_url":"https://api.github.com/users/arbor-sim/orgs","repos_url":"https://api.github.com/users/arbor-sim/repos","events_url":"https://api.github.com/users/arbor-sim/events{/privacy}","received_events_url":"https://api.github.com/users/arbor-sim/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arbor-sim/arbor","description":"The Arbor multi-compartment neural network simulation library.","fork":false,"url":"https://api.github.com/repos/arbor-sim/arbor","forks_url":"https://api.github.com/repos/arbor-sim/arbor/forks","keys_url":"https://api.github.com/repos/arbor-sim/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arbor-sim/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arbor-sim/arbor/teams","hooks_url":"https://api.github.com/repos/arbor-sim/arbor/hooks","issue_events_url":"https://api.github.com/repos/arbor-sim/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/arbor-sim/arbor/events","assignees_url":"https://api.github.com/repos/arbor-sim/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/arbor-sim/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/arbor-sim/arbor/tags","blobs_url":"https://api.github.com/repos/arbor-sim/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arbor-sim/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arbor-sim/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/arbor-sim/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arbor-sim/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/arbor-sim/arbor/languages","stargazers_url":"https://api.github.com/repos/arbor-sim/arbor/stargazers","contributors_url":"https://api.github.com/repos/arbor-sim/arbor/contributors","subscribers_url":"https://api.github.com/repos/arbor-sim/arbor/subscribers","subscription_url":"https://api.github.com/repos/arbor-sim/arbor/subscription","commits_url":"https://api.github.com/repos/arbor-sim/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/arbor-sim/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/arbor-sim/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/arbor-sim/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/arbor-sim/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/arbor-sim/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arbor-sim/arbor/merges","archive_url":"https://api.github.com/repos/arbor-sim/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arbor-sim/arbor/downloads","issues_url":"https://api.github.com/repos/arbor-sim/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/arbor-sim/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/arbor-sim/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/arbor-sim/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arbor-sim/arbor/labels{/name}","releases_url":"https://api.github.com/repos/arbor-sim/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/arbor-sim/arbor/deployments","created_at":"2016-10-03T11:03:22Z","updated_at":"2019-08-16T08:12:08Z","pushed_at":"2019-08-16T08:12:05Z","git_url":"git://github.com/arbor-sim/arbor.git","ssh_url":"git@github.com:arbor-sim/arbor.git","clone_url":"https://github.com/arbor-sim/arbor.git","svn_url":"https://github.com/arbor-sim/arbor","homepage":"","size":4720,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":108,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":108,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/840"},"html":{"href":"https://github.com/arbor-sim/arbor/pull/840"},"issue":{"href":"https://api.github.com/repos/arbor-sim/arbor/issues/840"},"comments":{"href":"https://api.github.com/repos/arbor-sim/arbor/issues/840/comments"},"review_comments":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/840/comments"},"review_comment":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arbor-sim/arbor/pulls/840/commits"},"statuses":{"href":"https://api.github.com/repos/arbor-sim/arbor/statuses/45206ee79b943a11dcfc5774f4659f90aaacb286"}},"author_association":"COLLABORATOR"}}
|
{
"id": 69863074,
"name": "arbor-sim/arbor",
"url": "https://api.github.com/repos/arbor-sim/arbor"
}
|
{
"id": 18661075,
"login": "noraabiakar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18661075?",
"url": "https://api.github.com/users/noraabiakar"
}
|
{
"id": 24656287,
"login": "arbor-sim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24656287?",
"url": "https://api.github.com/orgs/arbor-sim"
}
| 2019-08-16T09:40:09 |
10223431812
|
{"actor":{"display_login":"noraabiakar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/comments/287290344","pull_request_review_id":241648886,"id":287290344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzI5MDM0NA==","diff_hunk":"@@ -66,151 +66,105 @@ public AmnesiaRecoveryService(CustomFeignClient customFeignClient,\n ContributionAuthorization contributionAuth = interruptedReplicate.getContributionAuthorization();\n RecoveryAction recoveryAction = interruptedReplicate.getRecoveryAction();\n String chainTaskId = contributionAuth.getChainTaskId();\n+ boolean isResultAvailable = isResultAvailable(chainTaskId);\n \n- log.info(\"recovering interrupted task [chainTaskId:{}, recoveryAction:{}]\",\n+ log.info(\"Recovering interrupted task [chainTaskId:{}, recoveryAction:{}]\",\n chainTaskId, recoveryAction);\n \n- boolean shouldSubscribe = false;\n- boolean shouldKeepResultFolder = true;\n-\n- switch (interruptedReplicate.getRecoveryAction()) {\n- case WAIT:\n- shouldSubscribe = true; // just subscribe and wait\n- break;\n-\n- case CONTRIBUTE:\n- shouldSubscribe = recoverReplicateByContributing(contributionAuth);\n- shouldKeepResultFolder = shouldSubscribe;\n- break;\n-\n- case ABORT_CONSENSUS_REACHED:\n- taskExecutorService.abortConsensusReached(chainTaskId);\n- break;\n-\n- case ABORT_CONTRIBUTION_TIMEOUT:\n- taskExecutorService.abortContributionTimeout(chainTaskId);\n- break;\n-\n- case REVEAL:\n- shouldSubscribe = recoverReplicateByRevealing(contributionAuth);\n- shouldKeepResultFolder = shouldSubscribe;\n- break;\n-\n- case UPLOAD_RESULT:\n- shouldSubscribe = recoverReplicateByUploadingResult(contributionAuth);\n- shouldKeepResultFolder = shouldSubscribe;\n- break;\n-\n- case COMPLETE:\n- taskExecutorService.completeTask(chainTaskId);\n- break;\n+ if (!isResultAvailable && recoveryAction != RecoveryAction.CONTRIBUTE) {\n+ log.error(\"Could not recover task, result not found [chainTaskId:{}, RecoveryAction:{}]\",\n+ chainTaskId, recoveryAction);\n+ continue;\n }\n \n- if (shouldSubscribe) {\n- subscriptionService.subscribeToTopic(chainTaskId);\n- }\n+ Optional<AvailableReplicateModel> oReplicateModel =\n+ replicateService.retrieveAvailableReplicateModelFromContribAuth(contributionAuth);\n \n- if (shouldKeepResultFolder) {\n- recoveredChainTaskIds.add(chainTaskId);\n+ if (!oReplicateModel.isPresent()) {\n+ log.error(\"Could not recover task, no replicateModel retrieved [chainTaskId:{}, RecoveryAction:{}]\",\n+ chainTaskId, recoveryAction);\n+ continue;\n }\n+\n+ AvailableReplicateModel replicateModel = oReplicateModel.get();\n+ recoverReplicate(interruptedReplicate, replicateModel);\n+ recoveredChainTaskIds.add(chainTaskId);\n }\n \n return recoveredChainTaskIds;\n }\n \n- public boolean recoverReplicateByContributing(ContributionAuthorization contributionAuth) {\n- String chainTaskId = contributionAuth.getChainTaskId();\n-\n- Optional<AvailableReplicateModel> oReplicateModel =\n- replicateService.retrieveAvailableReplicateModelFromContribAuth(contributionAuth);\n+ public void recoverReplicate(InterruptedReplicateModel interruptedReplicate,\n+ AvailableReplicateModel replicateModel) {\n \n- if (!oReplicateModel.isPresent()) {\n- log.info(\"could not retrieve replicateModel from contributionAuth to recover task \"\n- + \"[chainTaskId:{}, RecoveryAction:CONTRIBUTE]\", chainTaskId);\n- return false;\n- }\n+ ContributionAuthorization contributionAuth = interruptedReplicate.getContributionAuthorization();\n+ String chainTaskId = contributionAuth.getChainTaskId();\n \n- AvailableReplicateModel replicateModel = oReplicateModel.get();\n+ switch (interruptedReplicate.getRecoveryAction()) {\n+ case WAIT:\n+ subscriptionService.subscribeToTopic(chainTaskId);\n+ resultService.saveResultInfo(chainTaskId, replicateModel);","path":"src/main/java/com/iexec/worker/amnesia/AmnesiaRecoveryService.java","position":101,"original_position":101,"commit_id":"4a179a67c830f9d511788ecd3477e0b30de4b6f2","original_commit_id":"4a179a67c830f9d511788ecd3477e0b30de4b6f2","user":{"login":"jeremyjams","id":33313130,"node_id":"MDQ6VXNlcjMzMzEzMTMw","avatar_url":"https://avatars0.githubusercontent.com/u/33313130?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyjams","html_url":"https://github.com/jeremyjams","followers_url":"https://api.github.com/users/jeremyjams/followers","following_url":"https://api.github.com/users/jeremyjams/following{/other_user}","gists_url":"https://api.github.com/users/jeremyjams/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyjams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyjams/subscriptions","organizations_url":"https://api.github.com/users/jeremyjams/orgs","repos_url":"https://api.github.com/users/jeremyjams/repos","events_url":"https://api.github.com/users/jeremyjams/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyjams/received_events","type":"User","site_admin":false},"body":"Just wondering, couldn't we `resultService.saveResultInfo(chainTaskId, replicateModel);` once for all at the beginning of the `recoverReplicate(..)` method (so we don't miss any case)?","created_at":"2019-05-24T09:46:23Z","updated_at":"2019-05-24T09:46:32Z","html_url":"https://github.com/iExecBlockchainComputing/iexec-worker/pull/189#discussion_r287290344","pull_request_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/comments/287290344"},"html":{"href":"https://github.com/iExecBlockchainComputing/iexec-worker/pull/189#discussion_r287290344"},"pull_request":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189","id":281251401,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxMjUxNDAx","html_url":"https://github.com/iExecBlockchainComputing/iexec-worker/pull/189","diff_url":"https://github.com/iExecBlockchainComputing/iexec-worker/pull/189.diff","patch_url":"https://github.com/iExecBlockchainComputing/iexec-worker/pull/189.patch","issue_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/189","number":189,"state":"open","locked":false,"title":"Fix issue #188","user":{"login":"zied-guesmi","id":26070035,"node_id":"MDQ6VXNlcjI2MDcwMDM1","avatar_url":"https://avatars3.githubusercontent.com/u/26070035?v=4","gravatar_id":"","url":"https://api.github.com/users/zied-guesmi","html_url":"https://github.com/zied-guesmi","followers_url":"https://api.github.com/users/zied-guesmi/followers","following_url":"https://api.github.com/users/zied-guesmi/following{/other_user}","gists_url":"https://api.github.com/users/zied-guesmi/gists{/gist_id}","starred_url":"https://api.github.com/users/zied-guesmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zied-guesmi/subscriptions","organizations_url":"https://api.github.com/users/zied-guesmi/orgs","repos_url":"https://api.github.com/users/zied-guesmi/repos","events_url":"https://api.github.com/users/zied-guesmi/events{/privacy}","received_events_url":"https://api.github.com/users/zied-guesmi/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-22T15:35:30Z","updated_at":"2019-05-24T09:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"939319bc05e9827020162baf3acac8d351f7494c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189/commits","review_comments_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189/comments","review_comment_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/189/comments","statuses_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/statuses/4a179a67c830f9d511788ecd3477e0b30de4b6f2","head":{"label":"iExecBlockchainComputing:patch","ref":"patch","sha":"4a179a67c830f9d511788ecd3477e0b30de4b6f2","user":{"login":"iExecBlockchainComputing","id":24774404,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Nzc0NDA0","avatar_url":"https://avatars0.githubusercontent.com/u/24774404?v=4","gravatar_id":"","url":"https://api.github.com/users/iExecBlockchainComputing","html_url":"https://github.com/iExecBlockchainComputing","followers_url":"https://api.github.com/users/iExecBlockchainComputing/followers","following_url":"https://api.github.com/users/iExecBlockchainComputing/following{/other_user}","gists_url":"https://api.github.com/users/iExecBlockchainComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/iExecBlockchainComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExecBlockchainComputing/subscriptions","organizations_url":"https://api.github.com/users/iExecBlockchainComputing/orgs","repos_url":"https://api.github.com/users/iExecBlockchainComputing/repos","events_url":"https://api.github.com/users/iExecBlockchainComputing/events{/privacy}","received_events_url":"https://api.github.com/users/iExecBlockchainComputing/received_events","type":"Organization","site_admin":false},"repo":{"id":150099750,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwOTk3NTA=","name":"iexec-worker","full_name":"iExecBlockchainComputing/iexec-worker","private":false,"owner":{"login":"iExecBlockchainComputing","id":24774404,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Nzc0NDA0","avatar_url":"https://avatars0.githubusercontent.com/u/24774404?v=4","gravatar_id":"","url":"https://api.github.com/users/iExecBlockchainComputing","html_url":"https://github.com/iExecBlockchainComputing","followers_url":"https://api.github.com/users/iExecBlockchainComputing/followers","following_url":"https://api.github.com/users/iExecBlockchainComputing/following{/other_user}","gists_url":"https://api.github.com/users/iExecBlockchainComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/iExecBlockchainComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExecBlockchainComputing/subscriptions","organizations_url":"https://api.github.com/users/iExecBlockchainComputing/orgs","repos_url":"https://api.github.com/users/iExecBlockchainComputing/repos","events_url":"https://api.github.com/users/iExecBlockchainComputing/events{/privacy}","received_events_url":"https://api.github.com/users/iExecBlockchainComputing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iExecBlockchainComputing/iexec-worker","description":"See below how to become an iexec-worker","fork":false,"url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker","forks_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/forks","keys_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/teams","hooks_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/hooks","issue_events_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/events{/number}","events_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/events","assignees_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/assignees{/user}","branches_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/branches{/branch}","tags_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/tags","blobs_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/languages","stargazers_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/stargazers","contributors_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/contributors","subscribers_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/subscribers","subscription_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/subscription","commits_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/contents/{+path}","compare_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/merges","archive_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/downloads","issues_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues{/number}","pulls_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/labels{/name}","releases_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/releases{/id}","deployments_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/deployments","created_at":"2018-09-24T12:34:26Z","updated_at":"2019-05-22T12:22:21Z","pushed_at":"2019-05-24T08:20:29Z","git_url":"git://github.com/iExecBlockchainComputing/iexec-worker.git","ssh_url":"git@github.com:iExecBlockchainComputing/iexec-worker.git","clone_url":"https://github.com/iExecBlockchainComputing/iexec-worker.git","svn_url":"https://github.com/iExecBlockchainComputing/iexec-worker","homepage":"https://docs.iex.ec/","size":818,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":1,"open_issues":14,"watchers":17,"default_branch":"master"}},"base":{"label":"iExecBlockchainComputing:master","ref":"master","sha":"38476b094247bec0ead437e4377417a69e86a9ab","user":{"login":"iExecBlockchainComputing","id":24774404,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Nzc0NDA0","avatar_url":"https://avatars0.githubusercontent.com/u/24774404?v=4","gravatar_id":"","url":"https://api.github.com/users/iExecBlockchainComputing","html_url":"https://github.com/iExecBlockchainComputing","followers_url":"https://api.github.com/users/iExecBlockchainComputing/followers","following_url":"https://api.github.com/users/iExecBlockchainComputing/following{/other_user}","gists_url":"https://api.github.com/users/iExecBlockchainComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/iExecBlockchainComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExecBlockchainComputing/subscriptions","organizations_url":"https://api.github.com/users/iExecBlockchainComputing/orgs","repos_url":"https://api.github.com/users/iExecBlockchainComputing/repos","events_url":"https://api.github.com/users/iExecBlockchainComputing/events{/privacy}","received_events_url":"https://api.github.com/users/iExecBlockchainComputing/received_events","type":"Organization","site_admin":false},"repo":{"id":150099750,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwOTk3NTA=","name":"iexec-worker","full_name":"iExecBlockchainComputing/iexec-worker","private":false,"owner":{"login":"iExecBlockchainComputing","id":24774404,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Nzc0NDA0","avatar_url":"https://avatars0.githubusercontent.com/u/24774404?v=4","gravatar_id":"","url":"https://api.github.com/users/iExecBlockchainComputing","html_url":"https://github.com/iExecBlockchainComputing","followers_url":"https://api.github.com/users/iExecBlockchainComputing/followers","following_url":"https://api.github.com/users/iExecBlockchainComputing/following{/other_user}","gists_url":"https://api.github.com/users/iExecBlockchainComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/iExecBlockchainComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iExecBlockchainComputing/subscriptions","organizations_url":"https://api.github.com/users/iExecBlockchainComputing/orgs","repos_url":"https://api.github.com/users/iExecBlockchainComputing/repos","events_url":"https://api.github.com/users/iExecBlockchainComputing/events{/privacy}","received_events_url":"https://api.github.com/users/iExecBlockchainComputing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iExecBlockchainComputing/iexec-worker","description":"See below how to become an iexec-worker","fork":false,"url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker","forks_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/forks","keys_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/teams","hooks_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/hooks","issue_events_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/events{/number}","events_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/events","assignees_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/assignees{/user}","branches_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/branches{/branch}","tags_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/tags","blobs_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/languages","stargazers_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/stargazers","contributors_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/contributors","subscribers_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/subscribers","subscription_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/subscription","commits_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/contents/{+path}","compare_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/merges","archive_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/downloads","issues_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues{/number}","pulls_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/labels{/name}","releases_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/releases{/id}","deployments_url":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/deployments","created_at":"2018-09-24T12:34:26Z","updated_at":"2019-05-22T12:22:21Z","pushed_at":"2019-05-24T08:20:29Z","git_url":"git://github.com/iExecBlockchainComputing/iexec-worker.git","ssh_url":"git@github.com:iExecBlockchainComputing/iexec-worker.git","clone_url":"https://github.com/iExecBlockchainComputing/iexec-worker.git","svn_url":"https://github.com/iExecBlockchainComputing/iexec-worker","homepage":"https://docs.iex.ec/","size":818,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":1,"open_issues":14,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189"},"html":{"href":"https://github.com/iExecBlockchainComputing/iexec-worker/pull/189"},"issue":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/189"},"comments":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/iExecBlockchainComputing/iexec-worker/statuses/4a179a67c830f9d511788ecd3477e0b30de4b6f2"}},"author_association":"MEMBER"}}
|
{
"id": 150099750,
"name": "iExecBlockchainComputing/iexec-worker",
"url": "https://api.github.com/repos/iExecBlockchainComputing/iexec-worker"
}
|
{
"id": 33313130,
"login": "jeremyjams",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33313130?",
"url": "https://api.github.com/users/jeremyjams"
}
|
{
"id": 24774404,
"login": "iExecBlockchainComputing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24774404?",
"url": "https://api.github.com/orgs/iExecBlockchainComputing"
}
| 2019-05-24T09:46:23 |
9690907698
|
{"actor":{"display_login":"jeremyjams"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x-api/pulls/comments/357427908","pull_request_review_id":331595061,"id":357427908,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzQyNzkwOA==","diff_hunk":"@@ -70,11 +79,15 @@ export function errorHandler(\n if (res.headersSent) {\n return next(err);\n }\n- if ((err as any).isAPIError || (err as any).statusCode) {\n- const { statusCode, errorBody } = generateError(err);\n- res.status(statusCode).send(errorBody);\n- return;\n- } else {\n- return next(err);\n+\n+ const { statusCode, errorBody } = generateError(err);\n+ res.status(statusCode).send(errorBody);\n+\n+ // If the error is an internal error, log it with the stack!\n+ // All other error responses are logged as part of request logging\n+ if (statusCode === HttpStatus.INTERNAL_SERVER_ERROR) {\n+ // hack (xianny): typeorm errors contain the SQL query which breaks the docker char limit and subsequently breaks log parsing\n+ logger.error({ ...err, query: undefined});","path":"src/middleware/error_handling.ts","position":54,"original_position":54,"commit_id":"f4998145efa92557910f9db70c18343fa4ce3b87","original_commit_id":"f4998145efa92557910f9db70c18343fa4ce3b87","user":{"login":"fragosti","id":3066135,"node_id":"MDQ6VXNlcjMwNjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3066135?v=4","gravatar_id":"","url":"https://api.github.com/users/fragosti","html_url":"https://github.com/fragosti","followers_url":"https://api.github.com/users/fragosti/followers","following_url":"https://api.github.com/users/fragosti/following{/other_user}","gists_url":"https://api.github.com/users/fragosti/gists{/gist_id}","starred_url":"https://api.github.com/users/fragosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragosti/subscriptions","organizations_url":"https://api.github.com/users/fragosti/orgs","repos_url":"https://api.github.com/users/fragosti/repos","events_url":"https://api.github.com/users/fragosti/events{/privacy}","received_events_url":"https://api.github.com/users/fragosti/received_events","type":"User","site_admin":false},"body":"This is fine. Might be good to link the actual issue which I believe is a `fluentd` issue.","created_at":"2019-12-12T23:50:38Z","updated_at":"2019-12-12T23:50:41Z","html_url":"https://github.com/0xProject/0x-api/pull/36#discussion_r357427908","pull_request_url":"https://api.github.com/repos/0xProject/0x-api/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-api/pulls/comments/357427908"},"html":{"href":"https://github.com/0xProject/0x-api/pull/36#discussion_r357427908"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x-api/pulls/36"}},"in_reply_to_id":357387886},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x-api/pulls/36","id":352075206,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMDc1MjA2","html_url":"https://github.com/0xProject/0x-api/pull/36","diff_url":"https://github.com/0xProject/0x-api/pull/36.diff","patch_url":"https://github.com/0xProject/0x-api/pull/36.patch","issue_url":"https://api.github.com/repos/0xProject/0x-api/issues/36","number":36,"state":"open","locked":false,"title":"improve runtime error handling","user":{"login":"xianny","id":8582774,"node_id":"MDQ6VXNlcjg1ODI3NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8582774?v=4","gravatar_id":"","url":"https://api.github.com/users/xianny","html_url":"https://github.com/xianny","followers_url":"https://api.github.com/users/xianny/followers","following_url":"https://api.github.com/users/xianny/following{/other_user}","gists_url":"https://api.github.com/users/xianny/gists{/gist_id}","starred_url":"https://api.github.com/users/xianny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xianny/subscriptions","organizations_url":"https://api.github.com/users/xianny/orgs","repos_url":"https://api.github.com/users/xianny/repos","events_url":"https://api.github.com/users/xianny/events{/privacy}","received_events_url":"https://api.github.com/users/xianny/received_events","type":"User","site_admin":false},"body":"Resolves #35\r\n\r\nBefore:\r\n\r\n<img width=\"1416\" alt=\"Screen Shot 2019-12-11 at 11 20 06 AM\" src=\"https://user-images.githubusercontent.com/8582774/70751671-d089c600-1ce5-11ea-80d5-800088b9d737.png\">\r\n\r\nAfter:\r\n<img width=\"888\" alt=\"Screen Shot 2019-12-11 at 11 19 55 AM\" src=\"https://user-images.githubusercontent.com/8582774/70751680-d8e20100-1ce5-11ea-8312-c1dbf84fe3aa.png\">\r\n\r\n\r\nTested a bit on Kovan and staging, but not exhaustively.","created_at":"2019-12-11T19:23:21Z","updated_at":"2019-12-12T23:50:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03bfddb9950d5a90e43383bb7ed40fffae39d716","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x-api/pulls/36/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x-api/pulls/36/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x-api/issues/36/comments","statuses_url":"https://api.github.com/repos/0xProject/0x-api/statuses/f4998145efa92557910f9db70c18343fa4ce3b87","head":{"label":"0xProject:fix/runtime-error-logging","ref":"fix/runtime-error-logging","sha":"f4998145efa92557910f9db70c18343fa4ce3b87","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":216912978,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY5MTI5Nzg=","name":"0x-api","full_name":"0xProject/0x-api","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-api","description":null,"fork":false,"url":"https://api.github.com/repos/0xProject/0x-api","forks_url":"https://api.github.com/repos/0xProject/0x-api/forks","keys_url":"https://api.github.com/repos/0xProject/0x-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-api/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-api/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-api/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-api/events","assignees_url":"https://api.github.com/repos/0xProject/0x-api/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-api/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-api/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-api/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-api/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-api/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-api/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-api/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-api/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-api/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-api/merges","archive_url":"https://api.github.com/repos/0xProject/0x-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-api/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-api/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-api/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-api/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-api/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-api/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-api/deployments","created_at":"2019-10-22T21:29:01Z","updated_at":"2019-12-12T01:09:51Z","pushed_at":"2019-12-12T23:15:30Z","git_url":"git://github.com/0xProject/0x-api.git","ssh_url":"git@github.com:0xProject/0x-api.git","clone_url":"https://github.com/0xProject/0x-api.git","svn_url":"https://github.com/0xProject/0x-api","homepage":null,"size":413,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"0xProject:master","ref":"master","sha":"d120b6e72d30ef6b646709c2dd8a2862b8d6b0b9","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":216912978,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY5MTI5Nzg=","name":"0x-api","full_name":"0xProject/0x-api","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-api","description":null,"fork":false,"url":"https://api.github.com/repos/0xProject/0x-api","forks_url":"https://api.github.com/repos/0xProject/0x-api/forks","keys_url":"https://api.github.com/repos/0xProject/0x-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-api/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-api/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-api/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-api/events","assignees_url":"https://api.github.com/repos/0xProject/0x-api/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-api/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-api/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-api/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-api/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-api/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-api/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-api/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-api/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-api/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-api/merges","archive_url":"https://api.github.com/repos/0xProject/0x-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-api/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-api/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-api/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-api/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-api/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-api/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-api/deployments","created_at":"2019-10-22T21:29:01Z","updated_at":"2019-12-12T01:09:51Z","pushed_at":"2019-12-12T23:15:30Z","git_url":"git://github.com/0xProject/0x-api.git","ssh_url":"git@github.com:0xProject/0x-api.git","clone_url":"https://github.com/0xProject/0x-api.git","svn_url":"https://github.com/0xProject/0x-api","homepage":null,"size":413,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-api/pulls/36"},"html":{"href":"https://github.com/0xProject/0x-api/pull/36"},"issue":{"href":"https://api.github.com/repos/0xProject/0x-api/issues/36"},"comments":{"href":"https://api.github.com/repos/0xProject/0x-api/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x-api/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x-api/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x-api/statuses/f4998145efa92557910f9db70c18343fa4ce3b87"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 216912978,
"name": "0xProject/0x-api",
"url": "https://api.github.com/repos/0xProject/0x-api"
}
|
{
"id": 3066135,
"login": "fragosti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3066135?",
"url": "https://api.github.com/users/fragosti"
}
|
{
"id": 24832717,
"login": "0xProject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24832717?",
"url": "https://api.github.com/orgs/0xProject"
}
| 2019-12-12T23:50:38 |
11078633403
|
{"actor":{"display_login":"fragosti"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/santiment/sanbase2/pulls/comments/328621114","pull_request_review_id":293732505,"id":328621114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODYyMTExNA==","diff_hunk":"@@ -77,9 +77,9 @@ defmodule Sanbase.Clickhouse.Github do\n {:ok, list({String.t(), non_neg_integer()})} | {:error, String.t()}\n def total_dev_activity([], _from, _to), do: {:ok, []}\n \n- def total_dev_activity(organizations, from, to) when length(organizations) > 10 do\n+ def total_dev_activity(organizations, from, to) when length(organizations) > 20 do\n total_dev_activity =\n- Enum.chunk_every(organizations, 10)\n+ Enum.chunk_every(organizations, 20)\n |> Sanbase.Parallel.map(&total_dev_activity(&1, from, to),\n timeout: 25_000,\n max_concurrency: 8,","path":"lib/sanbase/clickhouse/github.ex","position":11,"original_position":11,"commit_id":"3b6edbd66cd957e2574a65e3380fbf489b8791df","original_commit_id":"3b6edbd66cd957e2574a65e3380fbf489b8791df","user":{"login":"IvanIvanoff","id":6518376,"node_id":"MDQ6VXNlcjY1MTgzNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6518376?v=4","gravatar_id":"","url":"https://api.github.com/users/IvanIvanoff","html_url":"https://github.com/IvanIvanoff","followers_url":"https://api.github.com/users/IvanIvanoff/followers","following_url":"https://api.github.com/users/IvanIvanoff/following{/other_user}","gists_url":"https://api.github.com/users/IvanIvanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanIvanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanIvanoff/subscriptions","organizations_url":"https://api.github.com/users/IvanIvanoff/orgs","repos_url":"https://api.github.com/users/IvanIvanoff/repos","events_url":"https://api.github.com/users/IvanIvanoff/events{/privacy}","received_events_url":"https://api.github.com/users/IvanIvanoff/received_events","type":"User","site_admin":false},"body":"Also, the concurrency is for how many concurrent batches of 20 orgs are queried - it's not about running concurrenly a query for every organization in this lists of length 20","created_at":"2019-09-26T13:45:10Z","updated_at":"2019-09-26T13:45:11Z","html_url":"https://github.com/santiment/sanbase2/pull/1505#discussion_r328621114","pull_request_url":"https://api.github.com/repos/santiment/sanbase2/pulls/1505","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/santiment/sanbase2/pulls/comments/328621114"},"html":{"href":"https://github.com/santiment/sanbase2/pull/1505#discussion_r328621114"},"pull_request":{"href":"https://api.github.com/repos/santiment/sanbase2/pulls/1505"}},"in_reply_to_id":328618416},"pull_request":{"url":"https://api.github.com/repos/santiment/sanbase2/pulls/1505","id":321635435,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxNjM1NDM1","html_url":"https://github.com/santiment/sanbase2/pull/1505","diff_url":"https://github.com/santiment/sanbase2/pull/1505.diff","patch_url":"https://github.com/santiment/sanbase2/pull/1505.patch","issue_url":"https://api.github.com/repos/santiment/sanbase2/issues/1505","number":1505,"state":"open","locked":false,"title":"Simplify the average dev activity dataloader","user":{"login":"IvanIvanoff","id":6518376,"node_id":"MDQ6VXNlcjY1MTgzNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6518376?v=4","gravatar_id":"","url":"https://api.github.com/users/IvanIvanoff","html_url":"https://github.com/IvanIvanoff","followers_url":"https://api.github.com/users/IvanIvanoff/followers","following_url":"https://api.github.com/users/IvanIvanoff/following{/other_user}","gists_url":"https://api.github.com/users/IvanIvanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanIvanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanIvanoff/subscriptions","organizations_url":"https://api.github.com/users/IvanIvanoff/orgs","repos_url":"https://api.github.com/users/IvanIvanoff/repos","events_url":"https://api.github.com/users/IvanIvanoff/events{/privacy}","received_events_url":"https://api.github.com/users/IvanIvanoff/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n<!-- (What does this pull request do in general terms?) -->\r\n\r\n[//]: # (#### Related PRs)\r\n<!-- (List of related PR in correct order) -->\r\n\r\n[//]: # (#### Additional deploy notes)\r\n<!-- (Notes regarding deployment the contained body of work.) -->\r\n\r\n[//]: # (#### Screenshots)\r\n<!-- (if appropriate) -->\r\n","created_at":"2019-09-26T09:54:36Z","updated_at":"2019-09-26T13:45:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76f44e9f8fb20790c0affeff1ca95dfd5a2a9184","assignee":null,"assignees":[],"requested_reviewers":[{"login":"valo","id":47639,"node_id":"MDQ6VXNlcjQ3NjM5","avatar_url":"https://avatars2.githubusercontent.com/u/47639?v=4","gravatar_id":"","url":"https://api.github.com/users/valo","html_url":"https://github.com/valo","followers_url":"https://api.github.com/users/valo/followers","following_url":"https://api.github.com/users/valo/following{/other_user}","gists_url":"https://api.github.com/users/valo/gists{/gist_id}","starred_url":"https://api.github.com/users/valo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valo/subscriptions","organizations_url":"https://api.github.com/users/valo/orgs","repos_url":"https://api.github.com/users/valo/repos","events_url":"https://api.github.com/users/valo/events{/privacy}","received_events_url":"https://api.github.com/users/valo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/santiment/sanbase2/pulls/1505/commits","review_comments_url":"https://api.github.com/repos/santiment/sanbase2/pulls/1505/comments","review_comment_url":"https://api.github.com/repos/santiment/sanbase2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/santiment/sanbase2/issues/1505/comments","statuses_url":"https://api.github.com/repos/santiment/sanbase2/statuses/3b6edbd66cd957e2574a65e3380fbf489b8791df","head":{"label":"santiment:simplify-average-dev-activity","ref":"simplify-average-dev-activity","sha":"3b6edbd66cd957e2574a65e3380fbf489b8791df","user":{"login":"santiment","id":24846876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQ2ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/24846876?v=4","gravatar_id":"","url":"https://api.github.com/users/santiment","html_url":"https://github.com/santiment","followers_url":"https://api.github.com/users/santiment/followers","following_url":"https://api.github.com/users/santiment/following{/other_user}","gists_url":"https://api.github.com/users/santiment/gists{/gist_id}","starred_url":"https://api.github.com/users/santiment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiment/subscriptions","organizations_url":"https://api.github.com/users/santiment/orgs","repos_url":"https://api.github.com/users/santiment/repos","events_url":"https://api.github.com/users/santiment/events{/privacy}","received_events_url":"https://api.github.com/users/santiment/received_events","type":"Organization","site_admin":false},"repo":{"id":106712767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY3MTI3Njc=","name":"sanbase2","full_name":"santiment/sanbase2","private":false,"owner":{"login":"santiment","id":24846876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQ2ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/24846876?v=4","gravatar_id":"","url":"https://api.github.com/users/santiment","html_url":"https://github.com/santiment","followers_url":"https://api.github.com/users/santiment/followers","following_url":"https://api.github.com/users/santiment/following{/other_user}","gists_url":"https://api.github.com/users/santiment/gists{/gist_id}","starred_url":"https://api.github.com/users/santiment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiment/subscriptions","organizations_url":"https://api.github.com/users/santiment/orgs","repos_url":"https://api.github.com/users/santiment/repos","events_url":"https://api.github.com/users/santiment/events{/privacy}","received_events_url":"https://api.github.com/users/santiment/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/santiment/sanbase2","description":"The source code of the Sanbase application in Santiment LLC","fork":false,"url":"https://api.github.com/repos/santiment/sanbase2","forks_url":"https://api.github.com/repos/santiment/sanbase2/forks","keys_url":"https://api.github.com/repos/santiment/sanbase2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/santiment/sanbase2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/santiment/sanbase2/teams","hooks_url":"https://api.github.com/repos/santiment/sanbase2/hooks","issue_events_url":"https://api.github.com/repos/santiment/sanbase2/issues/events{/number}","events_url":"https://api.github.com/repos/santiment/sanbase2/events","assignees_url":"https://api.github.com/repos/santiment/sanbase2/assignees{/user}","branches_url":"https://api.github.com/repos/santiment/sanbase2/branches{/branch}","tags_url":"https://api.github.com/repos/santiment/sanbase2/tags","blobs_url":"https://api.github.com/repos/santiment/sanbase2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/santiment/sanbase2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/santiment/sanbase2/git/refs{/sha}","trees_url":"https://api.github.com/repos/santiment/sanbase2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/santiment/sanbase2/statuses/{sha}","languages_url":"https://api.github.com/repos/santiment/sanbase2/languages","stargazers_url":"https://api.github.com/repos/santiment/sanbase2/stargazers","contributors_url":"https://api.github.com/repos/santiment/sanbase2/contributors","subscribers_url":"https://api.github.com/repos/santiment/sanbase2/subscribers","subscription_url":"https://api.github.com/repos/santiment/sanbase2/subscription","commits_url":"https://api.github.com/repos/santiment/sanbase2/commits{/sha}","git_commits_url":"https://api.github.com/repos/santiment/sanbase2/git/commits{/sha}","comments_url":"https://api.github.com/repos/santiment/sanbase2/comments{/number}","issue_comment_url":"https://api.github.com/repos/santiment/sanbase2/issues/comments{/number}","contents_url":"https://api.github.com/repos/santiment/sanbase2/contents/{+path}","compare_url":"https://api.github.com/repos/santiment/sanbase2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/santiment/sanbase2/merges","archive_url":"https://api.github.com/repos/santiment/sanbase2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/santiment/sanbase2/downloads","issues_url":"https://api.github.com/repos/santiment/sanbase2/issues{/number}","pulls_url":"https://api.github.com/repos/santiment/sanbase2/pulls{/number}","milestones_url":"https://api.github.com/repos/santiment/sanbase2/milestones{/number}","notifications_url":"https://api.github.com/repos/santiment/sanbase2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/santiment/sanbase2/labels{/name}","releases_url":"https://api.github.com/repos/santiment/sanbase2/releases{/id}","deployments_url":"https://api.github.com/repos/santiment/sanbase2/deployments","created_at":"2017-10-12T15:42:11Z","updated_at":"2019-09-26T11:24:39Z","pushed_at":"2019-09-26T13:16:40Z","git_url":"git://github.com/santiment/sanbase2.git","ssh_url":"git@github.com:santiment/sanbase2.git","clone_url":"https://github.com/santiment/sanbase2.git","svn_url":"https://github.com/santiment/sanbase2","homepage":"https://app.santiment.net","size":18220,"stargazers_count":42,"watchers_count":42,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":7,"watchers":42,"default_branch":"master"}},"base":{"label":"santiment:master","ref":"master","sha":"9fb3ecff26f4fcff454a5eafaf060c5c681f9b03","user":{"login":"santiment","id":24846876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQ2ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/24846876?v=4","gravatar_id":"","url":"https://api.github.com/users/santiment","html_url":"https://github.com/santiment","followers_url":"https://api.github.com/users/santiment/followers","following_url":"https://api.github.com/users/santiment/following{/other_user}","gists_url":"https://api.github.com/users/santiment/gists{/gist_id}","starred_url":"https://api.github.com/users/santiment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiment/subscriptions","organizations_url":"https://api.github.com/users/santiment/orgs","repos_url":"https://api.github.com/users/santiment/repos","events_url":"https://api.github.com/users/santiment/events{/privacy}","received_events_url":"https://api.github.com/users/santiment/received_events","type":"Organization","site_admin":false},"repo":{"id":106712767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY3MTI3Njc=","name":"sanbase2","full_name":"santiment/sanbase2","private":false,"owner":{"login":"santiment","id":24846876,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQ2ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/24846876?v=4","gravatar_id":"","url":"https://api.github.com/users/santiment","html_url":"https://github.com/santiment","followers_url":"https://api.github.com/users/santiment/followers","following_url":"https://api.github.com/users/santiment/following{/other_user}","gists_url":"https://api.github.com/users/santiment/gists{/gist_id}","starred_url":"https://api.github.com/users/santiment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiment/subscriptions","organizations_url":"https://api.github.com/users/santiment/orgs","repos_url":"https://api.github.com/users/santiment/repos","events_url":"https://api.github.com/users/santiment/events{/privacy}","received_events_url":"https://api.github.com/users/santiment/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/santiment/sanbase2","description":"The source code of the Sanbase application in Santiment LLC","fork":false,"url":"https://api.github.com/repos/santiment/sanbase2","forks_url":"https://api.github.com/repos/santiment/sanbase2/forks","keys_url":"https://api.github.com/repos/santiment/sanbase2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/santiment/sanbase2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/santiment/sanbase2/teams","hooks_url":"https://api.github.com/repos/santiment/sanbase2/hooks","issue_events_url":"https://api.github.com/repos/santiment/sanbase2/issues/events{/number}","events_url":"https://api.github.com/repos/santiment/sanbase2/events","assignees_url":"https://api.github.com/repos/santiment/sanbase2/assignees{/user}","branches_url":"https://api.github.com/repos/santiment/sanbase2/branches{/branch}","tags_url":"https://api.github.com/repos/santiment/sanbase2/tags","blobs_url":"https://api.github.com/repos/santiment/sanbase2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/santiment/sanbase2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/santiment/sanbase2/git/refs{/sha}","trees_url":"https://api.github.com/repos/santiment/sanbase2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/santiment/sanbase2/statuses/{sha}","languages_url":"https://api.github.com/repos/santiment/sanbase2/languages","stargazers_url":"https://api.github.com/repos/santiment/sanbase2/stargazers","contributors_url":"https://api.github.com/repos/santiment/sanbase2/contributors","subscribers_url":"https://api.github.com/repos/santiment/sanbase2/subscribers","subscription_url":"https://api.github.com/repos/santiment/sanbase2/subscription","commits_url":"https://api.github.com/repos/santiment/sanbase2/commits{/sha}","git_commits_url":"https://api.github.com/repos/santiment/sanbase2/git/commits{/sha}","comments_url":"https://api.github.com/repos/santiment/sanbase2/comments{/number}","issue_comment_url":"https://api.github.com/repos/santiment/sanbase2/issues/comments{/number}","contents_url":"https://api.github.com/repos/santiment/sanbase2/contents/{+path}","compare_url":"https://api.github.com/repos/santiment/sanbase2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/santiment/sanbase2/merges","archive_url":"https://api.github.com/repos/santiment/sanbase2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/santiment/sanbase2/downloads","issues_url":"https://api.github.com/repos/santiment/sanbase2/issues{/number}","pulls_url":"https://api.github.com/repos/santiment/sanbase2/pulls{/number}","milestones_url":"https://api.github.com/repos/santiment/sanbase2/milestones{/number}","notifications_url":"https://api.github.com/repos/santiment/sanbase2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/santiment/sanbase2/labels{/name}","releases_url":"https://api.github.com/repos/santiment/sanbase2/releases{/id}","deployments_url":"https://api.github.com/repos/santiment/sanbase2/deployments","created_at":"2017-10-12T15:42:11Z","updated_at":"2019-09-26T11:24:39Z","pushed_at":"2019-09-26T13:16:40Z","git_url":"git://github.com/santiment/sanbase2.git","ssh_url":"git@github.com:santiment/sanbase2.git","clone_url":"https://github.com/santiment/sanbase2.git","svn_url":"https://github.com/santiment/sanbase2","homepage":"https://app.santiment.net","size":18220,"stargazers_count":42,"watchers_count":42,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":7,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/santiment/sanbase2/pulls/1505"},"html":{"href":"https://github.com/santiment/sanbase2/pull/1505"},"issue":{"href":"https://api.github.com/repos/santiment/sanbase2/issues/1505"},"comments":{"href":"https://api.github.com/repos/santiment/sanbase2/issues/1505/comments"},"review_comments":{"href":"https://api.github.com/repos/santiment/sanbase2/pulls/1505/comments"},"review_comment":{"href":"https://api.github.com/repos/santiment/sanbase2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/santiment/sanbase2/pulls/1505/commits"},"statuses":{"href":"https://api.github.com/repos/santiment/sanbase2/statuses/3b6edbd66cd957e2574a65e3380fbf489b8791df"}},"author_association":"MEMBER"}}
|
{
"id": 106712767,
"name": "santiment/sanbase2",
"url": "https://api.github.com/repos/santiment/sanbase2"
}
|
{
"id": 6518376,
"login": "IvanIvanoff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6518376?",
"url": "https://api.github.com/users/IvanIvanoff"
}
|
{
"id": 24846876,
"login": "santiment",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24846876?",
"url": "https://api.github.com/orgs/santiment"
}
| 2019-09-26T13:45:10 |
10501912834
|
{"actor":{"display_login":"IvanIvanoff"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/luckyframework/website/pulls/comments/314052359","pull_request_review_id":275106912,"id":314052359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDA1MjM1OQ==","diff_hunk":"@@ -0,0 +1,41 @@\n+class Lucky016Release < BasePost\n+ title \"Lucky 0.17 has been released!\"\n+ slug \"lucky-0_17-release\"\n+\n+ def published_at\n+ Time.utc(year: 2019, month: 8, day: 16)\n+ end\n+\n+ def summary\n+ <<-TEXT\n+ Lucky v0.17 is a huge release with many enhancements to Avram, Lucky's\n+ database library for Postgres.\n+ TEXT\n+ end\n+\n+ def content\n+ <<-MD\n+ Lucky v0.17.0 is now out and has support for the newest Crystal (v0.30.0)!\n+\n+ ### What's new?\n+\n+ You can see a [full list of\n+ changes](https://github.com/luckyframework/lucky/blob/master/CHANGELOG.md#changes-in-v017),\n+ but here are some highlights.\n+\n+ [Avram](https://github.com/luckyframework/avram) has seen the most changes\n+ and improvements.\n+\n+ * Can now use any column as the primary key. Can also use Int64, UUID or any custom type you implement.\n+ * Added ability to customize default columns (primary key, timestamps, etc.).\n+ * Lots of improvements to how we save and query records.\n+","path":"src/posts/lucky_0.17.cr","position":32,"original_position":32,"commit_id":"bf613156d2dee369dddd5212d907c36b9895c779","original_commit_id":"bf613156d2dee369dddd5212d907c36b9895c779","user":{"login":"jwoertink","id":2391,"node_id":"MDQ6VXNlcjIzOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2391?v=4","gravatar_id":"","url":"https://api.github.com/users/jwoertink","html_url":"https://github.com/jwoertink","followers_url":"https://api.github.com/users/jwoertink/followers","following_url":"https://api.github.com/users/jwoertink/following{/other_user}","gists_url":"https://api.github.com/users/jwoertink/gists{/gist_id}","starred_url":"https://api.github.com/users/jwoertink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwoertink/subscriptions","organizations_url":"https://api.github.com/users/jwoertink/orgs","repos_url":"https://api.github.com/users/jwoertink/repos","events_url":"https://api.github.com/users/jwoertink/events{/privacy}","received_events_url":"https://api.github.com/users/jwoertink/received_events","type":"User","site_admin":false},"body":"Maybe instead of bullet points, each one is a sub heading, then an example could be added?\r\n\r\n```\r\n### Better Primary key support\r\n\r\nWe have added a `primary_key` method which allows you to name the primary key anything you want, as well as define the type as any [supported type](link). You can even customize the primary key type with whatever you implement.\r\n\r\nblock_of_code snippet\r\n\r\n\r\n### JSON and Array support\r\n\r\n### Multi DB support\r\n\r\nNeed to use more than 1 database with your app? We got you covered..\r\n\r\n### Polymorphic associations\r\n\r\n### New Db tasks\r\n\r\nmigration status, verify connection, rollback_to....\r\n```\r\n","created_at":"2019-08-14T19:48:28Z","updated_at":"2019-08-14T19:48:33Z","html_url":"https://github.com/luckyframework/website/pull/108#discussion_r314052359","pull_request_url":"https://api.github.com/repos/luckyframework/website/pulls/108","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/luckyframework/website/pulls/comments/314052359"},"html":{"href":"https://github.com/luckyframework/website/pull/108#discussion_r314052359"},"pull_request":{"href":"https://api.github.com/repos/luckyframework/website/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/luckyframework/website/pulls/108","id":307468291,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NDY4Mjkx","html_url":"https://github.com/luckyframework/website/pull/108","diff_url":"https://github.com/luckyframework/website/pull/108.diff","patch_url":"https://github.com/luckyframework/website/pull/108.patch","issue_url":"https://api.github.com/repos/luckyframework/website/issues/108","number":108,"state":"open","locked":false,"title":"Lucky 0.17","user":{"login":"paulcsmith","id":22394,"node_id":"MDQ6VXNlcjIyMzk0","avatar_url":"https://avatars0.githubusercontent.com/u/22394?v=4","gravatar_id":"","url":"https://api.github.com/users/paulcsmith","html_url":"https://github.com/paulcsmith","followers_url":"https://api.github.com/users/paulcsmith/followers","following_url":"https://api.github.com/users/paulcsmith/following{/other_user}","gists_url":"https://api.github.com/users/paulcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcsmith/subscriptions","organizations_url":"https://api.github.com/users/paulcsmith/orgs","repos_url":"https://api.github.com/users/paulcsmith/repos","events_url":"https://api.github.com/users/paulcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/paulcsmith/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-14T19:34:53Z","updated_at":"2019-08-14T19:48:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb778c48d5a9ff36cb216fcc22e5c107a32bff78","assignee":null,"assignees":[],"requested_reviewers":[{"login":"edwardloveall","id":49549,"node_id":"MDQ6VXNlcjQ5NTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/49549?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardloveall","html_url":"https://github.com/edwardloveall","followers_url":"https://api.github.com/users/edwardloveall/followers","following_url":"https://api.github.com/users/edwardloveall/following{/other_user}","gists_url":"https://api.github.com/users/edwardloveall/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardloveall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardloveall/subscriptions","organizations_url":"https://api.github.com/users/edwardloveall/orgs","repos_url":"https://api.github.com/users/edwardloveall/repos","events_url":"https://api.github.com/users/edwardloveall/events{/privacy}","received_events_url":"https://api.github.com/users/edwardloveall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/luckyframework/website/pulls/108/commits","review_comments_url":"https://api.github.com/repos/luckyframework/website/pulls/108/comments","review_comment_url":"https://api.github.com/repos/luckyframework/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luckyframework/website/issues/108/comments","statuses_url":"https://api.github.com/repos/luckyframework/website/statuses/bf613156d2dee369dddd5212d907c36b9895c779","head":{"label":"luckyframework:pcs/lucky-0-17","ref":"pcs/lucky-0-17","sha":"bf613156d2dee369dddd5212d907c36b9895c779","user":{"login":"luckyframework","id":24882045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgyMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/24882045?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyframework","html_url":"https://github.com/luckyframework","followers_url":"https://api.github.com/users/luckyframework/followers","following_url":"https://api.github.com/users/luckyframework/following{/other_user}","gists_url":"https://api.github.com/users/luckyframework/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyframework/subscriptions","organizations_url":"https://api.github.com/users/luckyframework/orgs","repos_url":"https://api.github.com/users/luckyframework/repos","events_url":"https://api.github.com/users/luckyframework/events{/privacy}","received_events_url":"https://api.github.com/users/luckyframework/received_events","type":"Organization","site_admin":false},"repo":{"id":182570375,"node_id":"MDEwOlJlcG9zaXRvcnkxODI1NzAzNzU=","name":"website","full_name":"luckyframework/website","private":false,"owner":{"login":"luckyframework","id":24882045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgyMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/24882045?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyframework","html_url":"https://github.com/luckyframework","followers_url":"https://api.github.com/users/luckyframework/followers","following_url":"https://api.github.com/users/luckyframework/following{/other_user}","gists_url":"https://api.github.com/users/luckyframework/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyframework/subscriptions","organizations_url":"https://api.github.com/users/luckyframework/orgs","repos_url":"https://api.github.com/users/luckyframework/repos","events_url":"https://api.github.com/users/luckyframework/events{/privacy}","received_events_url":"https://api.github.com/users/luckyframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/luckyframework/website","description":"The Lucky website","fork":false,"url":"https://api.github.com/repos/luckyframework/website","forks_url":"https://api.github.com/repos/luckyframework/website/forks","keys_url":"https://api.github.com/repos/luckyframework/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckyframework/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckyframework/website/teams","hooks_url":"https://api.github.com/repos/luckyframework/website/hooks","issue_events_url":"https://api.github.com/repos/luckyframework/website/issues/events{/number}","events_url":"https://api.github.com/repos/luckyframework/website/events","assignees_url":"https://api.github.com/repos/luckyframework/website/assignees{/user}","branches_url":"https://api.github.com/repos/luckyframework/website/branches{/branch}","tags_url":"https://api.github.com/repos/luckyframework/website/tags","blobs_url":"https://api.github.com/repos/luckyframework/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckyframework/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckyframework/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckyframework/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckyframework/website/statuses/{sha}","languages_url":"https://api.github.com/repos/luckyframework/website/languages","stargazers_url":"https://api.github.com/repos/luckyframework/website/stargazers","contributors_url":"https://api.github.com/repos/luckyframework/website/contributors","subscribers_url":"https://api.github.com/repos/luckyframework/website/subscribers","subscription_url":"https://api.github.com/repos/luckyframework/website/subscription","commits_url":"https://api.github.com/repos/luckyframework/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckyframework/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckyframework/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckyframework/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/luckyframework/website/contents/{+path}","compare_url":"https://api.github.com/repos/luckyframework/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckyframework/website/merges","archive_url":"https://api.github.com/repos/luckyframework/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckyframework/website/downloads","issues_url":"https://api.github.com/repos/luckyframework/website/issues{/number}","pulls_url":"https://api.github.com/repos/luckyframework/website/pulls{/number}","milestones_url":"https://api.github.com/repos/luckyframework/website/milestones{/number}","notifications_url":"https://api.github.com/repos/luckyframework/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckyframework/website/labels{/name}","releases_url":"https://api.github.com/repos/luckyframework/website/releases{/id}","deployments_url":"https://api.github.com/repos/luckyframework/website/deployments","created_at":"2019-04-21T18:47:48Z","updated_at":"2019-08-14T19:34:51Z","pushed_at":"2019-08-14T19:37:58Z","git_url":"git://github.com/luckyframework/website.git","ssh_url":"git@github.com:luckyframework/website.git","clone_url":"https://github.com/luckyframework/website.git","svn_url":"https://github.com/luckyframework/website","homepage":"https://luckyframework.org","size":671,"stargazers_count":4,"watchers_count":4,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":3,"open_issues":14,"watchers":4,"default_branch":"master"}},"base":{"label":"luckyframework:master","ref":"master","sha":"69abcd9157d9fc2c89072baf30c9616e6c75df98","user":{"login":"luckyframework","id":24882045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgyMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/24882045?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyframework","html_url":"https://github.com/luckyframework","followers_url":"https://api.github.com/users/luckyframework/followers","following_url":"https://api.github.com/users/luckyframework/following{/other_user}","gists_url":"https://api.github.com/users/luckyframework/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyframework/subscriptions","organizations_url":"https://api.github.com/users/luckyframework/orgs","repos_url":"https://api.github.com/users/luckyframework/repos","events_url":"https://api.github.com/users/luckyframework/events{/privacy}","received_events_url":"https://api.github.com/users/luckyframework/received_events","type":"Organization","site_admin":false},"repo":{"id":182570375,"node_id":"MDEwOlJlcG9zaXRvcnkxODI1NzAzNzU=","name":"website","full_name":"luckyframework/website","private":false,"owner":{"login":"luckyframework","id":24882045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgyMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/24882045?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyframework","html_url":"https://github.com/luckyframework","followers_url":"https://api.github.com/users/luckyframework/followers","following_url":"https://api.github.com/users/luckyframework/following{/other_user}","gists_url":"https://api.github.com/users/luckyframework/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyframework/subscriptions","organizations_url":"https://api.github.com/users/luckyframework/orgs","repos_url":"https://api.github.com/users/luckyframework/repos","events_url":"https://api.github.com/users/luckyframework/events{/privacy}","received_events_url":"https://api.github.com/users/luckyframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/luckyframework/website","description":"The Lucky website","fork":false,"url":"https://api.github.com/repos/luckyframework/website","forks_url":"https://api.github.com/repos/luckyframework/website/forks","keys_url":"https://api.github.com/repos/luckyframework/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckyframework/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckyframework/website/teams","hooks_url":"https://api.github.com/repos/luckyframework/website/hooks","issue_events_url":"https://api.github.com/repos/luckyframework/website/issues/events{/number}","events_url":"https://api.github.com/repos/luckyframework/website/events","assignees_url":"https://api.github.com/repos/luckyframework/website/assignees{/user}","branches_url":"https://api.github.com/repos/luckyframework/website/branches{/branch}","tags_url":"https://api.github.com/repos/luckyframework/website/tags","blobs_url":"https://api.github.com/repos/luckyframework/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckyframework/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckyframework/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckyframework/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckyframework/website/statuses/{sha}","languages_url":"https://api.github.com/repos/luckyframework/website/languages","stargazers_url":"https://api.github.com/repos/luckyframework/website/stargazers","contributors_url":"https://api.github.com/repos/luckyframework/website/contributors","subscribers_url":"https://api.github.com/repos/luckyframework/website/subscribers","subscription_url":"https://api.github.com/repos/luckyframework/website/subscription","commits_url":"https://api.github.com/repos/luckyframework/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckyframework/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckyframework/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckyframework/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/luckyframework/website/contents/{+path}","compare_url":"https://api.github.com/repos/luckyframework/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckyframework/website/merges","archive_url":"https://api.github.com/repos/luckyframework/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckyframework/website/downloads","issues_url":"https://api.github.com/repos/luckyframework/website/issues{/number}","pulls_url":"https://api.github.com/repos/luckyframework/website/pulls{/number}","milestones_url":"https://api.github.com/repos/luckyframework/website/milestones{/number}","notifications_url":"https://api.github.com/repos/luckyframework/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckyframework/website/labels{/name}","releases_url":"https://api.github.com/repos/luckyframework/website/releases{/id}","deployments_url":"https://api.github.com/repos/luckyframework/website/deployments","created_at":"2019-04-21T18:47:48Z","updated_at":"2019-08-14T19:34:51Z","pushed_at":"2019-08-14T19:37:58Z","git_url":"git://github.com/luckyframework/website.git","ssh_url":"git@github.com:luckyframework/website.git","clone_url":"https://github.com/luckyframework/website.git","svn_url":"https://github.com/luckyframework/website","homepage":"https://luckyframework.org","size":671,"stargazers_count":4,"watchers_count":4,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":3,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luckyframework/website/pulls/108"},"html":{"href":"https://github.com/luckyframework/website/pull/108"},"issue":{"href":"https://api.github.com/repos/luckyframework/website/issues/108"},"comments":{"href":"https://api.github.com/repos/luckyframework/website/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/luckyframework/website/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/luckyframework/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luckyframework/website/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/luckyframework/website/statuses/bf613156d2dee369dddd5212d907c36b9895c779"}},"author_association":"MEMBER"}}
|
{
"id": 182570375,
"name": "luckyframework/website",
"url": "https://api.github.com/repos/luckyframework/website"
}
|
{
"id": 2391,
"login": "jwoertink",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2391?",
"url": "https://api.github.com/users/jwoertink"
}
|
{
"id": 24882045,
"login": "luckyframework",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24882045?",
"url": "https://api.github.com/orgs/luckyframework"
}
| 2019-08-14T19:48:28 |
10212576812
|
{"actor":{"display_login":"jwoertink"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ECP-copa/Cabana/pulls/comments/266989148","pull_request_review_id":216284077,"id":266989148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Njk4OTE0OA==","diff_hunk":"@@ -20,6 +20,67 @@\n \n namespace Cabana\n {\n+//---------------------------------------------------------------------------//\n+// Verlet List Memory Layout Tag.\n+//---------------------------------------------------------------------------//\n+// CSR Layout\n+struct VerletLayoutCSR {};","path":"core/src/Cabana_VerletList.hpp","position":8,"original_position":8,"commit_id":"3f25eba671aae01a89edcbd6c2da593c151193d2","original_commit_id":"3f25eba671aae01a89edcbd6c2da593c151193d2","user":{"login":"streeve","id":6740307,"node_id":"MDQ6VXNlcjY3NDAzMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6740307?v=4","gravatar_id":"","url":"https://api.github.com/users/streeve","html_url":"https://github.com/streeve","followers_url":"https://api.github.com/users/streeve/followers","following_url":"https://api.github.com/users/streeve/following{/other_user}","gists_url":"https://api.github.com/users/streeve/gists{/gist_id}","starred_url":"https://api.github.com/users/streeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streeve/subscriptions","organizations_url":"https://api.github.com/users/streeve/orgs","repos_url":"https://api.github.com/users/streeve/repos","events_url":"https://api.github.com/users/streeve/events{/privacy}","received_events_url":"https://api.github.com/users/streeve/received_events","type":"User","site_admin":false},"body":"Compressed sparse row?","created_at":"2019-03-19T16:45:25Z","updated_at":"2019-03-19T16:45:26Z","html_url":"https://github.com/ECP-copa/Cabana/pull/83#discussion_r266989148","pull_request_url":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ECP-copa/Cabana/pulls/comments/266989148"},"html":{"href":"https://github.com/ECP-copa/Cabana/pull/83#discussion_r266989148"},"pull_request":{"href":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83"}},"in_reply_to_id":265151674},"pull_request":{"url":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83","id":260487280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNDg3Mjgw","html_url":"https://github.com/ECP-copa/Cabana/pull/83","diff_url":"https://github.com/ECP-copa/Cabana/pull/83.diff","patch_url":"https://github.com/ECP-copa/Cabana/pull/83.patch","issue_url":"https://api.github.com/repos/ECP-copa/Cabana/issues/83","number":83,"state":"open","locked":false,"title":"WIP: Verlet List Update","user":{"login":"sslattery","id":755901,"node_id":"MDQ6VXNlcjc1NTkwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/755901?v=4","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"body":"* Adds 2D Verlet list storage in addition to the existing CSR storage. These are created by a new layout template parameter on the Verlet list. Closes #71 \r\n* Allows for the reuse of a `LinkedCellList` when constructing the Verlet list. This should save a lot of time for those cases where a `LinkedCellList` is constructed and used elsewhere. Closes #75 ","created_at":"2019-03-12T18:32:20Z","updated_at":"2019-03-19T16:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a86b734bf844aeb62edd4850241979439cca11d7","assignee":{"login":"sslattery","id":755901,"node_id":"MDQ6VXNlcjc1NTkwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/755901?v=4","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"assignees":[{"login":"sslattery","id":755901,"node_id":"MDQ6VXNlcjc1NTkwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/755901?v=4","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"streeve","id":6740307,"node_id":"MDQ6VXNlcjY3NDAzMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6740307?v=4","gravatar_id":"","url":"https://api.github.com/users/streeve","html_url":"https://github.com/streeve","followers_url":"https://api.github.com/users/streeve/followers","following_url":"https://api.github.com/users/streeve/following{/other_user}","gists_url":"https://api.github.com/users/streeve/gists{/gist_id}","starred_url":"https://api.github.com/users/streeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streeve/subscriptions","organizations_url":"https://api.github.com/users/streeve/orgs","repos_url":"https://api.github.com/users/streeve/repos","events_url":"https://api.github.com/users/streeve/events{/privacy}","received_events_url":"https://api.github.com/users/streeve/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1067839537,"node_id":"MDU6TGFiZWwxMDY3ODM5NTM3","url":"https://api.github.com/repos/ECP-copa/Cabana/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83/commits","review_comments_url":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83/comments","review_comment_url":"https://api.github.com/repos/ECP-copa/Cabana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ECP-copa/Cabana/issues/83/comments","statuses_url":"https://api.github.com/repos/ECP-copa/Cabana/statuses/3f25eba671aae01a89edcbd6c2da593c151193d2","head":{"label":"sslattery:verlet_list_2d","ref":"verlet_list_2d","sha":"3f25eba671aae01a89edcbd6c2da593c151193d2","user":{"login":"sslattery","id":755901,"node_id":"MDQ6VXNlcjc1NTkwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/755901?v=4","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"repo":{"id":150167095,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxNjcwOTU=","name":"Cabana","full_name":"sslattery/Cabana","private":false,"owner":{"login":"sslattery","id":755901,"node_id":"MDQ6VXNlcjc1NTkwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/755901?v=4","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sslattery/Cabana","description":"CoPA Cabana","fork":true,"url":"https://api.github.com/repos/sslattery/Cabana","forks_url":"https://api.github.com/repos/sslattery/Cabana/forks","keys_url":"https://api.github.com/repos/sslattery/Cabana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sslattery/Cabana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sslattery/Cabana/teams","hooks_url":"https://api.github.com/repos/sslattery/Cabana/hooks","issue_events_url":"https://api.github.com/repos/sslattery/Cabana/issues/events{/number}","events_url":"https://api.github.com/repos/sslattery/Cabana/events","assignees_url":"https://api.github.com/repos/sslattery/Cabana/assignees{/user}","branches_url":"https://api.github.com/repos/sslattery/Cabana/branches{/branch}","tags_url":"https://api.github.com/repos/sslattery/Cabana/tags","blobs_url":"https://api.github.com/repos/sslattery/Cabana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sslattery/Cabana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sslattery/Cabana/git/refs{/sha}","trees_url":"https://api.github.com/repos/sslattery/Cabana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sslattery/Cabana/statuses/{sha}","languages_url":"https://api.github.com/repos/sslattery/Cabana/languages","stargazers_url":"https://api.github.com/repos/sslattery/Cabana/stargazers","contributors_url":"https://api.github.com/repos/sslattery/Cabana/contributors","subscribers_url":"https://api.github.com/repos/sslattery/Cabana/subscribers","subscription_url":"https://api.github.com/repos/sslattery/Cabana/subscription","commits_url":"https://api.github.com/repos/sslattery/Cabana/commits{/sha}","git_commits_url":"https://api.github.com/repos/sslattery/Cabana/git/commits{/sha}","comments_url":"https://api.github.com/repos/sslattery/Cabana/comments{/number}","issue_comment_url":"https://api.github.com/repos/sslattery/Cabana/issues/comments{/number}","contents_url":"https://api.github.com/repos/sslattery/Cabana/contents/{+path}","compare_url":"https://api.github.com/repos/sslattery/Cabana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sslattery/Cabana/merges","archive_url":"https://api.github.com/repos/sslattery/Cabana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sslattery/Cabana/downloads","issues_url":"https://api.github.com/repos/sslattery/Cabana/issues{/number}","pulls_url":"https://api.github.com/repos/sslattery/Cabana/pulls{/number}","milestones_url":"https://api.github.com/repos/sslattery/Cabana/milestones{/number}","notifications_url":"https://api.github.com/repos/sslattery/Cabana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sslattery/Cabana/labels{/name}","releases_url":"https://api.github.com/repos/sslattery/Cabana/releases{/id}","deployments_url":"https://api.github.com/repos/sslattery/Cabana/deployments","created_at":"2018-09-24T20:53:11Z","updated_at":"2018-09-24T20:53:14Z","pushed_at":"2019-03-18T17:14:58Z","git_url":"git://github.com/sslattery/Cabana.git","ssh_url":"git@github.com:sslattery/Cabana.git","clone_url":"https://github.com/sslattery/Cabana.git","svn_url":"https://github.com/sslattery/Cabana","homepage":null,"size":1064,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ECP-copa:master","ref":"master","sha":"d1cbe48ff864a64c6396fdf1ed6bf751c12a1bf9","user":{"login":"ECP-copa","id":24921631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTIxNjMx","avatar_url":"https://avatars3.githubusercontent.com/u/24921631?v=4","gravatar_id":"","url":"https://api.github.com/users/ECP-copa","html_url":"https://github.com/ECP-copa","followers_url":"https://api.github.com/users/ECP-copa/followers","following_url":"https://api.github.com/users/ECP-copa/following{/other_user}","gists_url":"https://api.github.com/users/ECP-copa/gists{/gist_id}","starred_url":"https://api.github.com/users/ECP-copa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ECP-copa/subscriptions","organizations_url":"https://api.github.com/users/ECP-copa/orgs","repos_url":"https://api.github.com/users/ECP-copa/repos","events_url":"https://api.github.com/users/ECP-copa/events{/privacy}","received_events_url":"https://api.github.com/users/ECP-copa/received_events","type":"Organization","site_admin":false},"repo":{"id":150150681,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxNTA2ODE=","name":"Cabana","full_name":"ECP-copa/Cabana","private":false,"owner":{"login":"ECP-copa","id":24921631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTIxNjMx","avatar_url":"https://avatars3.githubusercontent.com/u/24921631?v=4","gravatar_id":"","url":"https://api.github.com/users/ECP-copa","html_url":"https://github.com/ECP-copa","followers_url":"https://api.github.com/users/ECP-copa/followers","following_url":"https://api.github.com/users/ECP-copa/following{/other_user}","gists_url":"https://api.github.com/users/ECP-copa/gists{/gist_id}","starred_url":"https://api.github.com/users/ECP-copa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ECP-copa/subscriptions","organizations_url":"https://api.github.com/users/ECP-copa/orgs","repos_url":"https://api.github.com/users/ECP-copa/repos","events_url":"https://api.github.com/users/ECP-copa/events{/privacy}","received_events_url":"https://api.github.com/users/ECP-copa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ECP-copa/Cabana","description":"CoPA Cabana","fork":false,"url":"https://api.github.com/repos/ECP-copa/Cabana","forks_url":"https://api.github.com/repos/ECP-copa/Cabana/forks","keys_url":"https://api.github.com/repos/ECP-copa/Cabana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ECP-copa/Cabana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ECP-copa/Cabana/teams","hooks_url":"https://api.github.com/repos/ECP-copa/Cabana/hooks","issue_events_url":"https://api.github.com/repos/ECP-copa/Cabana/issues/events{/number}","events_url":"https://api.github.com/repos/ECP-copa/Cabana/events","assignees_url":"https://api.github.com/repos/ECP-copa/Cabana/assignees{/user}","branches_url":"https://api.github.com/repos/ECP-copa/Cabana/branches{/branch}","tags_url":"https://api.github.com/repos/ECP-copa/Cabana/tags","blobs_url":"https://api.github.com/repos/ECP-copa/Cabana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ECP-copa/Cabana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ECP-copa/Cabana/git/refs{/sha}","trees_url":"https://api.github.com/repos/ECP-copa/Cabana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ECP-copa/Cabana/statuses/{sha}","languages_url":"https://api.github.com/repos/ECP-copa/Cabana/languages","stargazers_url":"https://api.github.com/repos/ECP-copa/Cabana/stargazers","contributors_url":"https://api.github.com/repos/ECP-copa/Cabana/contributors","subscribers_url":"https://api.github.com/repos/ECP-copa/Cabana/subscribers","subscription_url":"https://api.github.com/repos/ECP-copa/Cabana/subscription","commits_url":"https://api.github.com/repos/ECP-copa/Cabana/commits{/sha}","git_commits_url":"https://api.github.com/repos/ECP-copa/Cabana/git/commits{/sha}","comments_url":"https://api.github.com/repos/ECP-copa/Cabana/comments{/number}","issue_comment_url":"https://api.github.com/repos/ECP-copa/Cabana/issues/comments{/number}","contents_url":"https://api.github.com/repos/ECP-copa/Cabana/contents/{+path}","compare_url":"https://api.github.com/repos/ECP-copa/Cabana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ECP-copa/Cabana/merges","archive_url":"https://api.github.com/repos/ECP-copa/Cabana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ECP-copa/Cabana/downloads","issues_url":"https://api.github.com/repos/ECP-copa/Cabana/issues{/number}","pulls_url":"https://api.github.com/repos/ECP-copa/Cabana/pulls{/number}","milestones_url":"https://api.github.com/repos/ECP-copa/Cabana/milestones{/number}","notifications_url":"https://api.github.com/repos/ECP-copa/Cabana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ECP-copa/Cabana/labels{/name}","releases_url":"https://api.github.com/repos/ECP-copa/Cabana/releases{/id}","deployments_url":"https://api.github.com/repos/ECP-copa/Cabana/deployments","created_at":"2018-09-24T18:36:45Z","updated_at":"2019-03-18T16:20:55Z","pushed_at":"2019-03-19T15:35:23Z","git_url":"git://github.com/ECP-copa/Cabana.git","ssh_url":"git@github.com:ECP-copa/Cabana.git","clone_url":"https://github.com/ECP-copa/Cabana.git","svn_url":"https://github.com/ECP-copa/Cabana","homepage":null,"size":7270,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":10,"open_issues":23,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83"},"html":{"href":"https://github.com/ECP-copa/Cabana/pull/83"},"issue":{"href":"https://api.github.com/repos/ECP-copa/Cabana/issues/83"},"comments":{"href":"https://api.github.com/repos/ECP-copa/Cabana/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/ECP-copa/Cabana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ECP-copa/Cabana/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/ECP-copa/Cabana/statuses/3f25eba671aae01a89edcbd6c2da593c151193d2"}},"author_association":"COLLABORATOR"}}
|
{
"id": 150150681,
"name": "ECP-copa/Cabana",
"url": "https://api.github.com/repos/ECP-copa/Cabana"
}
|
{
"id": 6740307,
"login": "streeve",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6740307?",
"url": "https://api.github.com/users/streeve"
}
|
{
"id": 24921631,
"login": "ECP-copa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24921631?",
"url": "https://api.github.com/orgs/ECP-copa"
}
| 2019-03-19T16:45:25 |
9273134694
|
{"actor":{"display_login":"streeve"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gnosis/dex-react/pulls/comments/343016546","pull_request_review_id":312324657,"id":343016546,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzAxNjU0Ng==","diff_hunk":"@@ -0,0 +1,108 @@\n+/* eslint-disable @typescript-eslint/no-unused-vars */\n+import BN from 'bn.js'\n+import assert from 'assert'\n+\n+import { DepositApiMock, BalancesByUserAndToken } from './DepositApiMock'\n+import { ExchangeApi, Order, PlaceOrderParams, Erc20Api } from 'types'\n+import { FEE_DENOMINATOR } from 'const'\n+\n+export interface OrdersByUser {\n+ [userAddress: string]: Order[]\n+}\n+\n+/**\n+ * Basic implementation of Stable Coin Converter API\n+ */\n+export class ExchangeApiMock extends DepositApiMock implements ExchangeApi {\n+ private registeredTokens: string[]\n+ private tokenAddressToId: { [address in string]: number } // reverse mapping of registeredTokens for faster access\n+ private maxTokens: number\n+ private orders: OrdersByUser\n+\n+ public constructor(\n+ balanceStates: BalancesByUserAndToken,\n+ erc20Api: Erc20Api,\n+ registeredTokens: string[] = [],\n+ maxTokens: number = 10000,\n+ ordersByUser: OrdersByUser = {},\n+ ) {\n+ super(balanceStates, erc20Api)\n+ this.registeredTokens = registeredTokens\n+ this.tokenAddressToId = registeredTokens.reduce((obj, address, index) => {\n+ obj[address] = index\n+ return obj\n+ }, {})\n+ this.maxTokens = maxTokens\n+ this.orders = ordersByUser\n+ }\n+\n+ public async getOrders(userAddress: string): Promise<Order[]> {\n+ this._initOrders(userAddress)\n+ return this.orders[userAddress]\n+ }\n+\n+ public async getNumTokens(): Promise<number> {\n+ return this.registeredTokens.length\n+ }\n+\n+ /**\n+ * Fee is 1/fee_denominator.\n+ * i.e. 1/1000 = 0.1%\n+ */\n+ public async getFeeDenominator(): Promise<number> {\n+ return FEE_DENOMINATOR\n+ }\n+\n+ public async getTokenAddressById(tokenId: number): Promise<string> {\n+ assert(typeof this.registeredTokens[tokenId] === 'string', 'Must have ID to get Address')\n+ return this.registeredTokens[tokenId]\n+ }\n+\n+ public async getTokenIdByAddress(tokenAddress: string): Promise<number> {\n+ assert(typeof this.tokenAddressToId[tokenAddress] === 'number', 'Must have Address to get ID')\n+ return this.tokenAddressToId[tokenAddress]\n+ }\n+\n+ public async getCurrentPrice(_tokenId: number): Promise<BN> {","path":"src/api/exchange/ExchangeApiMock.ts","position":66,"original_position":66,"commit_id":"201c20d630952859345098ccdee64fe3cbc366e4","original_commit_id":"201c20d630952859345098ccdee64fe3cbc366e4","user":{"login":"anxolin","id":2352112,"node_id":"MDQ6VXNlcjIzNTIxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2352112?v=4","gravatar_id":"","url":"https://api.github.com/users/anxolin","html_url":"https://github.com/anxolin","followers_url":"https://api.github.com/users/anxolin/followers","following_url":"https://api.github.com/users/anxolin/following{/other_user}","gists_url":"https://api.github.com/users/anxolin/gists{/gist_id}","starred_url":"https://api.github.com/users/anxolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anxolin/subscriptions","organizations_url":"https://api.github.com/users/anxolin/orgs","repos_url":"https://api.github.com/users/anxolin/repos","events_url":"https://api.github.com/users/anxolin/events{/privacy}","received_events_url":"https://api.github.com/users/anxolin/received_events","type":"User","site_admin":false},"body":"Maybe we should remove this?\r\nIt's there an equivalent in the contract?","created_at":"2019-11-06T10:20:03Z","updated_at":"2019-11-06T10:28:23Z","html_url":"https://github.com/gnosis/dex-react/pull/36#discussion_r343016546","pull_request_url":"https://api.github.com/repos/gnosis/dex-react/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/comments/343016546"},"html":{"href":"https://github.com/gnosis/dex-react/pull/36#discussion_r343016546"},"pull_request":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/gnosis/dex-react/pulls/36","id":317386975,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3Mzg2OTc1","html_url":"https://github.com/gnosis/dex-react/pull/36","diff_url":"https://github.com/gnosis/dex-react/pull/36.diff","patch_url":"https://github.com/gnosis/dex-react/pull/36.patch","issue_url":"https://api.github.com/repos/gnosis/dex-react/issues/36","number":36,"state":"open","locked":false,"title":"30/stable coin api part2","user":{"login":"anxolin","id":2352112,"node_id":"MDQ6VXNlcjIzNTIxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2352112?v=4","gravatar_id":"","url":"https://api.github.com/users/anxolin","html_url":"https://github.com/anxolin","followers_url":"https://api.github.com/users/anxolin/followers","following_url":"https://api.github.com/users/anxolin/following{/other_user}","gists_url":"https://api.github.com/users/anxolin/gists{/gist_id}","starred_url":"https://api.github.com/users/anxolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anxolin/subscriptions","organizations_url":"https://api.github.com/users/anxolin/orgs","repos_url":"https://api.github.com/users/anxolin/repos","events_url":"https://api.github.com/users/anxolin/events{/privacy}","received_events_url":"https://api.github.com/users/anxolin/received_events","type":"User","site_admin":false},"body":"> Do not review yet :) \r\n>\r\n> It's work in progress branch!\r\n\r\n\r\n* [] Addresses the EchangeAPI for #30 \r\n\r\n**Context**\r\nThis is the second of two PRs that will add an interface for interacting with the contract.\r\nThe idea is to: \r\n1. Create an interface in Typescript defining the method signatures\r\n2. Provide a simple, \"in memory\", pure JS implementation. This is for making development simpler. We will be able to start the app using this mock implementation.\r\n3. Add tests for this implementation\r\n\r\n> See first PR: https://github.com/gnosis/dex-react/pull/31\r\n\r\n**Scope of the PR**\r\nThis second one defines the API for the deposit methods (`DepositApi`). \r\nIt's provides a similar interface as `StablecoinConverter`.\r\n\r\nIt also includes the tests, and some utils/constants/helpers that were required in order to do these tests.\r\n\r\n**Main components**\r\n* `ExchangeApi`: The typescript interface. Also as part of this interface it was required to define: `Order` and `AddOrderParams`\r\n* `ExchangeApiMock`: Basic implementation of this API\r\n*Tests*:\r\nThe following test are being done:\r\nTODO: Add picture once all test are defined\r\n\r\n**How to test?**\r\nJust execute:\r\n```bash\r\nyarn test\r\n```","created_at":"2019-09-13T15:53:38Z","updated_at":"2019-11-06T10:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90c61e8fa51ac35167e6c238915b66398fd58649","assignee":{"login":"alfetopito","id":43217,"node_id":"MDQ6VXNlcjQzMjE3","avatar_url":"https://avatars1.githubusercontent.com/u/43217?v=4","gravatar_id":"","url":"https://api.github.com/users/alfetopito","html_url":"https://github.com/alfetopito","followers_url":"https://api.github.com/users/alfetopito/followers","following_url":"https://api.github.com/users/alfetopito/following{/other_user}","gists_url":"https://api.github.com/users/alfetopito/gists{/gist_id}","starred_url":"https://api.github.com/users/alfetopito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfetopito/subscriptions","organizations_url":"https://api.github.com/users/alfetopito/orgs","repos_url":"https://api.github.com/users/alfetopito/repos","events_url":"https://api.github.com/users/alfetopito/events{/privacy}","received_events_url":"https://api.github.com/users/alfetopito/received_events","type":"User","site_admin":false},"assignees":[{"login":"alfetopito","id":43217,"node_id":"MDQ6VXNlcjQzMjE3","avatar_url":"https://avatars1.githubusercontent.com/u/43217?v=4","gravatar_id":"","url":"https://api.github.com/users/alfetopito","html_url":"https://github.com/alfetopito","followers_url":"https://api.github.com/users/alfetopito/followers","following_url":"https://api.github.com/users/alfetopito/following{/other_user}","gists_url":"https://api.github.com/users/alfetopito/gists{/gist_id}","starred_url":"https://api.github.com/users/alfetopito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfetopito/subscriptions","organizations_url":"https://api.github.com/users/alfetopito/orgs","repos_url":"https://api.github.com/users/alfetopito/repos","events_url":"https://api.github.com/users/alfetopito/events{/privacy}","received_events_url":"https://api.github.com/users/alfetopito/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Velenir","id":5121491,"node_id":"MDQ6VXNlcjUxMjE0OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5121491?v=4","gravatar_id":"","url":"https://api.github.com/users/Velenir","html_url":"https://github.com/Velenir","followers_url":"https://api.github.com/users/Velenir/followers","following_url":"https://api.github.com/users/Velenir/following{/other_user}","gists_url":"https://api.github.com/users/Velenir/gists{/gist_id}","starred_url":"https://api.github.com/users/Velenir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Velenir/subscriptions","organizations_url":"https://api.github.com/users/Velenir/orgs","repos_url":"https://api.github.com/users/Velenir/repos","events_url":"https://api.github.com/users/Velenir/events{/privacy}","received_events_url":"https://api.github.com/users/Velenir/received_events","type":"User","site_admin":false},{"login":"W3stside","id":21335563,"node_id":"MDQ6VXNlcjIxMzM1NTYz","avatar_url":"https://avatars3.githubusercontent.com/u/21335563?v=4","gravatar_id":"","url":"https://api.github.com/users/W3stside","html_url":"https://github.com/W3stside","followers_url":"https://api.github.com/users/W3stside/followers","following_url":"https://api.github.com/users/W3stside/following{/other_user}","gists_url":"https://api.github.com/users/W3stside/gists{/gist_id}","starred_url":"https://api.github.com/users/W3stside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/W3stside/subscriptions","organizations_url":"https://api.github.com/users/W3stside/orgs","repos_url":"https://api.github.com/users/W3stside/repos","events_url":"https://api.github.com/users/W3stside/events{/privacy}","received_events_url":"https://api.github.com/users/W3stside/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/gnosis/dex-react/milestones/4","html_url":"https://github.com/gnosis/dex-react/milestone/4","labels_url":"https://api.github.com/repos/gnosis/dex-react/milestones/4/labels","id":4795448,"node_id":"MDk6TWlsZXN0b25lNDc5NTQ0OA==","number":4,"title":"Sprint 4","description":"Gnosis internal [planning](https://docs.google.com/spreadsheets/d/1-_2WOLpe2bIJt48anqtSgbvW7_WsQhGJKdytPo7n5q0/edit?usp=sharing)\r\n\r\nGOAL:\r\n* Finish web3/smart contract\r\n* Telegram bot\r\n* Deploy to Rinkeby\r\n* Improve responsiveness of the app\r\n* Small minor optimization: bundle size, pooling\r\n","creator":{"login":"anxolin","id":2352112,"node_id":"MDQ6VXNlcjIzNTIxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2352112?v=4","gravatar_id":"","url":"https://api.github.com/users/anxolin","html_url":"https://github.com/anxolin","followers_url":"https://api.github.com/users/anxolin/followers","following_url":"https://api.github.com/users/anxolin/following{/other_user}","gists_url":"https://api.github.com/users/anxolin/gists{/gist_id}","starred_url":"https://api.github.com/users/anxolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anxolin/subscriptions","organizations_url":"https://api.github.com/users/anxolin/orgs","repos_url":"https://api.github.com/users/anxolin/repos","events_url":"https://api.github.com/users/anxolin/events{/privacy}","received_events_url":"https://api.github.com/users/anxolin/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":6,"state":"open","created_at":"2019-10-29T15:24:23Z","updated_at":"2019-11-06T00:21:40Z","due_on":"2019-11-12T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gnosis/dex-react/pulls/36/commits","review_comments_url":"https://api.github.com/repos/gnosis/dex-react/pulls/36/comments","review_comment_url":"https://api.github.com/repos/gnosis/dex-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnosis/dex-react/issues/36/comments","statuses_url":"https://api.github.com/repos/gnosis/dex-react/statuses/201c20d630952859345098ccdee64fe3cbc366e4","head":{"label":"gnosis:30/stable-coin-api__part2","ref":"30/stable-coin-api__part2","sha":"201c20d630952859345098ccdee64fe3cbc366e4","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":200027889,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAwMjc4ODk=","name":"dex-react","full_name":"gnosis/dex-react","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/dex-react","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/dex-react","forks_url":"https://api.github.com/repos/gnosis/dex-react/forks","keys_url":"https://api.github.com/repos/gnosis/dex-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-react/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-react/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-react/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-react/events","assignees_url":"https://api.github.com/repos/gnosis/dex-react/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-react/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-react/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-react/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-react/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-react/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-react/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-react/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-react/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-react/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-react/merges","archive_url":"https://api.github.com/repos/gnosis/dex-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-react/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-react/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-react/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-react/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-react/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-react/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-react/deployments","created_at":"2019-08-01T10:14:22Z","updated_at":"2019-11-05T15:18:13Z","pushed_at":"2019-11-06T09:53:31Z","git_url":"git://github.com/gnosis/dex-react.git","ssh_url":"git@github.com:gnosis/dex-react.git","clone_url":"https://github.com/gnosis/dex-react.git","svn_url":"https://github.com/gnosis/dex-react","homepage":null,"size":1252,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":null,"forks":0,"open_issues":41,"watchers":1,"default_branch":"develop"}},"base":{"label":"gnosis:develop","ref":"develop","sha":"3dd33d607b212cc4d99b609821bf768fa59a2c03","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":200027889,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAwMjc4ODk=","name":"dex-react","full_name":"gnosis/dex-react","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/dex-react","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/dex-react","forks_url":"https://api.github.com/repos/gnosis/dex-react/forks","keys_url":"https://api.github.com/repos/gnosis/dex-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-react/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-react/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-react/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-react/events","assignees_url":"https://api.github.com/repos/gnosis/dex-react/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-react/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-react/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-react/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-react/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-react/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-react/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-react/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-react/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-react/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-react/merges","archive_url":"https://api.github.com/repos/gnosis/dex-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-react/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-react/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-react/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-react/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-react/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-react/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-react/deployments","created_at":"2019-08-01T10:14:22Z","updated_at":"2019-11-05T15:18:13Z","pushed_at":"2019-11-06T09:53:31Z","git_url":"git://github.com/gnosis/dex-react.git","ssh_url":"git@github.com:gnosis/dex-react.git","clone_url":"https://github.com/gnosis/dex-react.git","svn_url":"https://github.com/gnosis/dex-react","homepage":null,"size":1252,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":null,"forks":0,"open_issues":41,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/36"},"html":{"href":"https://github.com/gnosis/dex-react/pull/36"},"issue":{"href":"https://api.github.com/repos/gnosis/dex-react/issues/36"},"comments":{"href":"https://api.github.com/repos/gnosis/dex-react/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnosis/dex-react/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/gnosis/dex-react/statuses/201c20d630952859345098ccdee64fe3cbc366e4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 200027889,
"name": "gnosis/dex-react",
"url": "https://api.github.com/repos/gnosis/dex-react"
}
|
{
"id": 2352112,
"login": "anxolin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2352112?",
"url": "https://api.github.com/users/anxolin"
}
|
{
"id": 24954468,
"login": "gnosis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24954468?",
"url": "https://api.github.com/orgs/gnosis"
}
| 2019-11-06T10:20:03 |
10798655149
|
{"actor":{"display_login":"anxolin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gnosis/dex-js/pulls/comments/353802320","pull_request_review_id":326922168,"id":353802320,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzgwMjMyMA==","diff_hunk":"@@ -10,6 +10,7 @@\n \"moduleResolution\": \"node\",\n \"allowJs\": false,\n \"checkJs\": false,\n+ \"declaration\": true,","path":"tsconfig.json","position":4,"original_position":4,"commit_id":"3299f940eb2170d7a1f41ab7a1e8c492cc565b1d","original_commit_id":"3299f940eb2170d7a1f41ab7a1e8c492cc565b1d","user":{"login":"anxolin","id":2352112,"node_id":"MDQ6VXNlcjIzNTIxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2352112?v=4","gravatar_id":"","url":"https://api.github.com/users/anxolin","html_url":"https://github.com/anxolin","followers_url":"https://api.github.com/users/anxolin/followers","following_url":"https://api.github.com/users/anxolin/following{/other_user}","gists_url":"https://api.github.com/users/anxolin/gists{/gist_id}","starred_url":"https://api.github.com/users/anxolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anxolin/subscriptions","organizations_url":"https://api.github.com/users/anxolin/orgs","repos_url":"https://api.github.com/users/anxolin/repos","events_url":"https://api.github.com/users/anxolin/events{/privacy}","received_events_url":"https://api.github.com/users/anxolin/received_events","type":"User","site_admin":false},"body":"done \r\n\r\n\r\n","created_at":"2019-12-04T15:14:53Z","updated_at":"2019-12-04T15:14:54Z","html_url":"https://github.com/gnosis/dex-js/pull/17#discussion_r353802320","pull_request_url":"https://api.github.com/repos/gnosis/dex-js/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-js/pulls/comments/353802320"},"html":{"href":"https://github.com/gnosis/dex-js/pull/17#discussion_r353802320"},"pull_request":{"href":"https://api.github.com/repos/gnosis/dex-js/pulls/17"}},"in_reply_to_id":353699180},"pull_request":{"url":"https://api.github.com/repos/gnosis/dex-js/pulls/17","id":348363058,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MzYzMDU4","html_url":"https://github.com/gnosis/dex-js/pull/17","diff_url":"https://github.com/gnosis/dex-js/pull/17.diff","patch_url":"https://github.com/gnosis/dex-js/pull/17.patch","issue_url":"https://api.github.com/repos/gnosis/dex-js/issues/17","number":17,"state":"open","locked":false,"title":"Publish definitions","user":{"login":"anxolin","id":2352112,"node_id":"MDQ6VXNlcjIzNTIxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2352112?v=4","gravatar_id":"","url":"https://api.github.com/users/anxolin","html_url":"https://github.com/anxolin","followers_url":"https://api.github.com/users/anxolin/followers","following_url":"https://api.github.com/users/anxolin/following{/other_user}","gists_url":"https://api.github.com/users/anxolin/gists{/gist_id}","starred_url":"https://api.github.com/users/anxolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anxolin/subscriptions","organizations_url":"https://api.github.com/users/anxolin/orgs","repos_url":"https://api.github.com/users/anxolin/repos","events_url":"https://api.github.com/users/anxolin/events{/privacy}","received_events_url":"https://api.github.com/users/anxolin/received_events","type":"User","site_admin":false},"body":"* Generate typescrypt definitions so it can be used by third parties with typescrypt too\r\n* Point to the declaration in package.json","created_at":"2019-12-03T14:32:13Z","updated_at":"2019-12-04T15:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"302c1685be3ee67539fa0f7fe3e31bd6106fa1db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"W3stside","id":21335563,"node_id":"MDQ6VXNlcjIxMzM1NTYz","avatar_url":"https://avatars3.githubusercontent.com/u/21335563?v=4","gravatar_id":"","url":"https://api.github.com/users/W3stside","html_url":"https://github.com/W3stside","followers_url":"https://api.github.com/users/W3stside/followers","following_url":"https://api.github.com/users/W3stside/following{/other_user}","gists_url":"https://api.github.com/users/W3stside/gists{/gist_id}","starred_url":"https://api.github.com/users/W3stside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/W3stside/subscriptions","organizations_url":"https://api.github.com/users/W3stside/orgs","repos_url":"https://api.github.com/users/W3stside/repos","events_url":"https://api.github.com/users/W3stside/events{/privacy}","received_events_url":"https://api.github.com/users/W3stside/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnosis/dex-js/pulls/17/commits","review_comments_url":"https://api.github.com/repos/gnosis/dex-js/pulls/17/comments","review_comment_url":"https://api.github.com/repos/gnosis/dex-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnosis/dex-js/issues/17/comments","statuses_url":"https://api.github.com/repos/gnosis/dex-js/statuses/3299f940eb2170d7a1f41ab7a1e8c492cc565b1d","head":{"label":"gnosis:publish-definitions","ref":"publish-definitions","sha":"3299f940eb2170d7a1f41ab7a1e8c492cc565b1d","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":224244068,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQyNDQwNjg=","name":"dex-js","full_name":"gnosis/dex-js","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/dex-js","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/dex-js","forks_url":"https://api.github.com/repos/gnosis/dex-js/forks","keys_url":"https://api.github.com/repos/gnosis/dex-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-js/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-js/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-js/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-js/events","assignees_url":"https://api.github.com/repos/gnosis/dex-js/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-js/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-js/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-js/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-js/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-js/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-js/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-js/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-js/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-js/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-js/merges","archive_url":"https://api.github.com/repos/gnosis/dex-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-js/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-js/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-js/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-js/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-js/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-js/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-js/deployments","created_at":"2019-11-26T17:02:40Z","updated_at":"2019-12-03T17:51:48Z","pushed_at":"2019-12-03T17:59:52Z","git_url":"git://github.com/gnosis/dex-js.git","ssh_url":"git@github.com:gnosis/dex-js.git","clone_url":"https://github.com/gnosis/dex-js.git","svn_url":"https://github.com/gnosis/dex-js","homepage":null,"size":904,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"gnosis:master","ref":"master","sha":"cce76087801d9109967e1b1eb4772be6e826cde5","user":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":224244068,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQyNDQwNjg=","name":"dex-js","full_name":"gnosis/dex-js","private":false,"owner":{"login":"gnosis","id":24954468,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU0NDY4","avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnosis/dex-js","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/dex-js","forks_url":"https://api.github.com/repos/gnosis/dex-js/forks","keys_url":"https://api.github.com/repos/gnosis/dex-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/dex-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/dex-js/teams","hooks_url":"https://api.github.com/repos/gnosis/dex-js/hooks","issue_events_url":"https://api.github.com/repos/gnosis/dex-js/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/dex-js/events","assignees_url":"https://api.github.com/repos/gnosis/dex-js/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/dex-js/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/dex-js/tags","blobs_url":"https://api.github.com/repos/gnosis/dex-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/dex-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/dex-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/dex-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/dex-js/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/dex-js/languages","stargazers_url":"https://api.github.com/repos/gnosis/dex-js/stargazers","contributors_url":"https://api.github.com/repos/gnosis/dex-js/contributors","subscribers_url":"https://api.github.com/repos/gnosis/dex-js/subscribers","subscription_url":"https://api.github.com/repos/gnosis/dex-js/subscription","commits_url":"https://api.github.com/repos/gnosis/dex-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/dex-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/dex-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/dex-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/dex-js/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/dex-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/dex-js/merges","archive_url":"https://api.github.com/repos/gnosis/dex-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/dex-js/downloads","issues_url":"https://api.github.com/repos/gnosis/dex-js/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/dex-js/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/dex-js/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/dex-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/dex-js/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/dex-js/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/dex-js/deployments","created_at":"2019-11-26T17:02:40Z","updated_at":"2019-12-03T17:51:48Z","pushed_at":"2019-12-03T17:59:52Z","git_url":"git://github.com/gnosis/dex-js.git","ssh_url":"git@github.com:gnosis/dex-js.git","clone_url":"https://github.com/gnosis/dex-js.git","svn_url":"https://github.com/gnosis/dex-js","homepage":null,"size":904,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnosis/dex-js/pulls/17"},"html":{"href":"https://github.com/gnosis/dex-js/pull/17"},"issue":{"href":"https://api.github.com/repos/gnosis/dex-js/issues/17"},"comments":{"href":"https://api.github.com/repos/gnosis/dex-js/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/gnosis/dex-js/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/gnosis/dex-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnosis/dex-js/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/gnosis/dex-js/statuses/3299f940eb2170d7a1f41ab7a1e8c492cc565b1d"}},"author_association":"COLLABORATOR"}}
|
{
"id": 224244068,
"name": "gnosis/dex-js",
"url": "https://api.github.com/repos/gnosis/dex-js"
}
|
{
"id": 2352112,
"login": "anxolin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2352112?",
"url": "https://api.github.com/users/anxolin"
}
|
{
"id": 24954468,
"login": "gnosis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24954468?",
"url": "https://api.github.com/orgs/gnosis"
}
| 2019-12-04T15:14:53 |
11010822078
|
{"actor":{"display_login":"anxolin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/health-connector/enroll/pulls/comments/272341438","pull_request_review_id":222969376,"id":272341438,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MjM0MTQzOA==","diff_hunk":"@@ -220,14 +223,14 @@\n \n describe \"family_index\",dbclean: :after_each do\n before :all do\n- org = FactoryGirl.create(:organization)\n- @broker_agency_profile1 = FactoryGirl.create(:broker_agency_profile, organization: org,aasm_state:'active')\n- broker_role = FactoryGirl.create(:broker_role, broker_agency_profile_id: @broker_agency_profile1.id, aasm_state:'active')\n+ org = FactoryBot.create(:organization)\n+ @broker_agency_profile1 = FactoryBot.create(:broker_agency_profile, organization: org,aasm_state:'active')","path":"spec/controllers/broker_agencies/profiles_controller_spec.rb","position":160,"original_position":160,"commit_id":"9d15d44190706bf7513f4879cd4ad0fa51a092d5","original_commit_id":"9d15d44190706bf7513f4879cd4ad0fa51a092d5","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Layout/SpaceAfterColon: Space missing after colon.","created_at":"2019-04-04T19:51:30Z","updated_at":"2019-04-04T19:51:35Z","html_url":"https://github.com/health-connector/enroll/pull/1658#discussion_r272341438","pull_request_url":"https://api.github.com/repos/health-connector/enroll/pulls/1658","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/health-connector/enroll/pulls/comments/272341438"},"html":{"href":"https://github.com/health-connector/enroll/pull/1658#discussion_r272341438"},"pull_request":{"href":"https://api.github.com/repos/health-connector/enroll/pulls/1658"}}},"pull_request":{"url":"https://api.github.com/repos/health-connector/enroll/pulls/1658","id":267493026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3NDkzMDI2","html_url":"https://github.com/health-connector/enroll/pull/1658","diff_url":"https://github.com/health-connector/enroll/pull/1658.diff","patch_url":"https://github.com/health-connector/enroll/pull/1658.patch","issue_url":"https://api.github.com/repos/health-connector/enroll/issues/1658","number":1658,"state":"open","locked":false,"title":"Ivl new model rails 5","user":{"login":"billy-ran-away","id":378135,"node_id":"MDQ6VXNlcjM3ODEzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/378135?v=4","gravatar_id":"","url":"https://api.github.com/users/billy-ran-away","html_url":"https://github.com/billy-ran-away","followers_url":"https://api.github.com/users/billy-ran-away/followers","following_url":"https://api.github.com/users/billy-ran-away/following{/other_user}","gists_url":"https://api.github.com/users/billy-ran-away/gists{/gist_id}","starred_url":"https://api.github.com/users/billy-ran-away/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billy-ran-away/subscriptions","organizations_url":"https://api.github.com/users/billy-ran-away/orgs","repos_url":"https://api.github.com/users/billy-ran-away/repos","events_url":"https://api.github.com/users/billy-ran-away/events{/privacy}","received_events_url":"https://api.github.com/users/billy-ran-away/received_events","type":"User","site_admin":false},"body":"### Master Redmine ticket\r\n* (Required!)\r\n\r\n### Child Redmine ticket(s)\r\n* ()\r\n* ()\r\n\r\n### Local build result\r\n\r\n```\r\nbundle exec rake parallel:spec[4]\r\nbundle exec cucumber\r\n```\r\n\r\n### Latest rebase/merge tag\r\n*\r\n\r\n---\r\n\r\n### Data ticket(s) Followup\r\n* (redmine links here - optional)\r\n\r\n### Related Pull Requests\r\n* (github links here - optional)\r\n\r\n---\r\n\r\n### TODOs / Notes\r\n#### Peer Review\r\n* (For code review)\r\n\r\n#### Functional Testing\r\n* (For testing locally)\r\n\r\n#### Deployment\r\n* (for release manager and/or build manager)\r\n","created_at":"2019-04-04T15:09:25Z","updated_at":"2019-04-04T19:51:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/health-connector/enroll/pulls/1658/commits","review_comments_url":"https://api.github.com/repos/health-connector/enroll/pulls/1658/comments","review_comment_url":"https://api.github.com/repos/health-connector/enroll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/health-connector/enroll/issues/1658/comments","statuses_url":"https://api.github.com/repos/health-connector/enroll/statuses/9d15d44190706bf7513f4879cd4ad0fa51a092d5","head":{"label":"health-connector:ivl_new_model_rails_5","ref":"ivl_new_model_rails_5","sha":"9d15d44190706bf7513f4879cd4ad0fa51a092d5","user":{"login":"health-connector","id":25070367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDcwMzY3","avatar_url":"https://avatars0.githubusercontent.com/u/25070367?v=4","gravatar_id":"","url":"https://api.github.com/users/health-connector","html_url":"https://github.com/health-connector","followers_url":"https://api.github.com/users/health-connector/followers","following_url":"https://api.github.com/users/health-connector/following{/other_user}","gists_url":"https://api.github.com/users/health-connector/gists{/gist_id}","starred_url":"https://api.github.com/users/health-connector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/health-connector/subscriptions","organizations_url":"https://api.github.com/users/health-connector/orgs","repos_url":"https://api.github.com/users/health-connector/repos","events_url":"https://api.github.com/users/health-connector/events{/privacy}","received_events_url":"https://api.github.com/users/health-connector/received_events","type":"Organization","site_admin":false},"repo":{"id":86743454,"node_id":"MDEwOlJlcG9zaXRvcnk4Njc0MzQ1NA==","name":"enroll","full_name":"health-connector/enroll","private":false,"owner":{"login":"health-connector","id":25070367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDcwMzY3","avatar_url":"https://avatars0.githubusercontent.com/u/25070367?v=4","gravatar_id":"","url":"https://api.github.com/users/health-connector","html_url":"https://github.com/health-connector","followers_url":"https://api.github.com/users/health-connector/followers","following_url":"https://api.github.com/users/health-connector/following{/other_user}","gists_url":"https://api.github.com/users/health-connector/gists{/gist_id}","starred_url":"https://api.github.com/users/health-connector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/health-connector/subscriptions","organizations_url":"https://api.github.com/users/health-connector/orgs","repos_url":"https://api.github.com/users/health-connector/repos","events_url":"https://api.github.com/users/health-connector/events{/privacy}","received_events_url":"https://api.github.com/users/health-connector/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/health-connector/enroll","description":"An ACA-compliant enrollment system for individual and SHOP markets, built on Ruby on Rails, with a Mongo database","fork":true,"url":"https://api.github.com/repos/health-connector/enroll","forks_url":"https://api.github.com/repos/health-connector/enroll/forks","keys_url":"https://api.github.com/repos/health-connector/enroll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/health-connector/enroll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/health-connector/enroll/teams","hooks_url":"https://api.github.com/repos/health-connector/enroll/hooks","issue_events_url":"https://api.github.com/repos/health-connector/enroll/issues/events{/number}","events_url":"https://api.github.com/repos/health-connector/enroll/events","assignees_url":"https://api.github.com/repos/health-connector/enroll/assignees{/user}","branches_url":"https://api.github.com/repos/health-connector/enroll/branches{/branch}","tags_url":"https://api.github.com/repos/health-connector/enroll/tags","blobs_url":"https://api.github.com/repos/health-connector/enroll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/health-connector/enroll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/health-connector/enroll/git/refs{/sha}","trees_url":"https://api.github.com/repos/health-connector/enroll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/health-connector/enroll/statuses/{sha}","languages_url":"https://api.github.com/repos/health-connector/enroll/languages","stargazers_url":"https://api.github.com/repos/health-connector/enroll/stargazers","contributors_url":"https://api.github.com/repos/health-connector/enroll/contributors","subscribers_url":"https://api.github.com/repos/health-connector/enroll/subscribers","subscription_url":"https://api.github.com/repos/health-connector/enroll/subscription","commits_url":"https://api.github.com/repos/health-connector/enroll/commits{/sha}","git_commits_url":"https://api.github.com/repos/health-connector/enroll/git/commits{/sha}","comments_url":"https://api.github.com/repos/health-connector/enroll/comments{/number}","issue_comment_url":"https://api.github.com/repos/health-connector/enroll/issues/comments{/number}","contents_url":"https://api.github.com/repos/health-connector/enroll/contents/{+path}","compare_url":"https://api.github.com/repos/health-connector/enroll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/health-connector/enroll/merges","archive_url":"https://api.github.com/repos/health-connector/enroll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/health-connector/enroll/downloads","issues_url":"https://api.github.com/repos/health-connector/enroll/issues{/number}","pulls_url":"https://api.github.com/repos/health-connector/enroll/pulls{/number}","milestones_url":"https://api.github.com/repos/health-connector/enroll/milestones{/number}","notifications_url":"https://api.github.com/repos/health-connector/enroll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/health-connector/enroll/labels{/name}","releases_url":"https://api.github.com/repos/health-connector/enroll/releases{/id}","deployments_url":"https://api.github.com/repos/health-connector/enroll/deployments","created_at":"2017-03-30T20:00:23Z","updated_at":"2019-04-01T18:09:17Z","pushed_at":"2019-04-04T19:25:49Z","git_url":"git://github.com/health-connector/enroll.git","ssh_url":"git@github.com:health-connector/enroll.git","clone_url":"https://github.com/health-connector/enroll.git","svn_url":"https://github.com/health-connector/enroll","homepage":"","size":116293,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":143,"license":null,"forks":3,"open_issues":143,"watchers":5,"default_branch":"master"}},"base":{"label":"health-connector:master","ref":"master","sha":"f244f98bc199108641f4abaf5684bf87ea08e5ed","user":{"login":"health-connector","id":25070367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDcwMzY3","avatar_url":"https://avatars0.githubusercontent.com/u/25070367?v=4","gravatar_id":"","url":"https://api.github.com/users/health-connector","html_url":"https://github.com/health-connector","followers_url":"https://api.github.com/users/health-connector/followers","following_url":"https://api.github.com/users/health-connector/following{/other_user}","gists_url":"https://api.github.com/users/health-connector/gists{/gist_id}","starred_url":"https://api.github.com/users/health-connector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/health-connector/subscriptions","organizations_url":"https://api.github.com/users/health-connector/orgs","repos_url":"https://api.github.com/users/health-connector/repos","events_url":"https://api.github.com/users/health-connector/events{/privacy}","received_events_url":"https://api.github.com/users/health-connector/received_events","type":"Organization","site_admin":false},"repo":{"id":86743454,"node_id":"MDEwOlJlcG9zaXRvcnk4Njc0MzQ1NA==","name":"enroll","full_name":"health-connector/enroll","private":false,"owner":{"login":"health-connector","id":25070367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDcwMzY3","avatar_url":"https://avatars0.githubusercontent.com/u/25070367?v=4","gravatar_id":"","url":"https://api.github.com/users/health-connector","html_url":"https://github.com/health-connector","followers_url":"https://api.github.com/users/health-connector/followers","following_url":"https://api.github.com/users/health-connector/following{/other_user}","gists_url":"https://api.github.com/users/health-connector/gists{/gist_id}","starred_url":"https://api.github.com/users/health-connector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/health-connector/subscriptions","organizations_url":"https://api.github.com/users/health-connector/orgs","repos_url":"https://api.github.com/users/health-connector/repos","events_url":"https://api.github.com/users/health-connector/events{/privacy}","received_events_url":"https://api.github.com/users/health-connector/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/health-connector/enroll","description":"An ACA-compliant enrollment system for individual and SHOP markets, built on Ruby on Rails, with a Mongo database","fork":true,"url":"https://api.github.com/repos/health-connector/enroll","forks_url":"https://api.github.com/repos/health-connector/enroll/forks","keys_url":"https://api.github.com/repos/health-connector/enroll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/health-connector/enroll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/health-connector/enroll/teams","hooks_url":"https://api.github.com/repos/health-connector/enroll/hooks","issue_events_url":"https://api.github.com/repos/health-connector/enroll/issues/events{/number}","events_url":"https://api.github.com/repos/health-connector/enroll/events","assignees_url":"https://api.github.com/repos/health-connector/enroll/assignees{/user}","branches_url":"https://api.github.com/repos/health-connector/enroll/branches{/branch}","tags_url":"https://api.github.com/repos/health-connector/enroll/tags","blobs_url":"https://api.github.com/repos/health-connector/enroll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/health-connector/enroll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/health-connector/enroll/git/refs{/sha}","trees_url":"https://api.github.com/repos/health-connector/enroll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/health-connector/enroll/statuses/{sha}","languages_url":"https://api.github.com/repos/health-connector/enroll/languages","stargazers_url":"https://api.github.com/repos/health-connector/enroll/stargazers","contributors_url":"https://api.github.com/repos/health-connector/enroll/contributors","subscribers_url":"https://api.github.com/repos/health-connector/enroll/subscribers","subscription_url":"https://api.github.com/repos/health-connector/enroll/subscription","commits_url":"https://api.github.com/repos/health-connector/enroll/commits{/sha}","git_commits_url":"https://api.github.com/repos/health-connector/enroll/git/commits{/sha}","comments_url":"https://api.github.com/repos/health-connector/enroll/comments{/number}","issue_comment_url":"https://api.github.com/repos/health-connector/enroll/issues/comments{/number}","contents_url":"https://api.github.com/repos/health-connector/enroll/contents/{+path}","compare_url":"https://api.github.com/repos/health-connector/enroll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/health-connector/enroll/merges","archive_url":"https://api.github.com/repos/health-connector/enroll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/health-connector/enroll/downloads","issues_url":"https://api.github.com/repos/health-connector/enroll/issues{/number}","pulls_url":"https://api.github.com/repos/health-connector/enroll/pulls{/number}","milestones_url":"https://api.github.com/repos/health-connector/enroll/milestones{/number}","notifications_url":"https://api.github.com/repos/health-connector/enroll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/health-connector/enroll/labels{/name}","releases_url":"https://api.github.com/repos/health-connector/enroll/releases{/id}","deployments_url":"https://api.github.com/repos/health-connector/enroll/deployments","created_at":"2017-03-30T20:00:23Z","updated_at":"2019-04-01T18:09:17Z","pushed_at":"2019-04-04T19:25:49Z","git_url":"git://github.com/health-connector/enroll.git","ssh_url":"git@github.com:health-connector/enroll.git","clone_url":"https://github.com/health-connector/enroll.git","svn_url":"https://github.com/health-connector/enroll","homepage":"","size":116293,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":143,"license":null,"forks":3,"open_issues":143,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/health-connector/enroll/pulls/1658"},"html":{"href":"https://github.com/health-connector/enroll/pull/1658"},"issue":{"href":"https://api.github.com/repos/health-connector/enroll/issues/1658"},"comments":{"href":"https://api.github.com/repos/health-connector/enroll/issues/1658/comments"},"review_comments":{"href":"https://api.github.com/repos/health-connector/enroll/pulls/1658/comments"},"review_comment":{"href":"https://api.github.com/repos/health-connector/enroll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/health-connector/enroll/pulls/1658/commits"},"statuses":{"href":"https://api.github.com/repos/health-connector/enroll/statuses/9d15d44190706bf7513f4879cd4ad0fa51a092d5"}},"author_association":"NONE"}}
|
{
"id": 86743454,
"name": "health-connector/enroll",
"url": "https://api.github.com/repos/health-connector/enroll"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 25070367,
"login": "health-connector",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25070367?",
"url": "https://api.github.com/orgs/health-connector"
}
| 2019-04-04T19:51:30 |
9381523093
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dirigeants/klasa/pulls/comments/288264236","pull_request_review_id":242873772,"id":288264236,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODI2NDIzNg==","diff_hunk":"@@ -0,0 +1,314 @@\n+This guide will explain anything and everything that there is to know about settings in Klasa, and will try to explain it in the most simplest terms as possible. You can navigate the guide using the table of contents below.\n+\n+# Table of Contents\n+\n+- {@scrollto Schema}\n+ - {@scrollto Folders}\n+ - {@scrollto Adding a Folder}\n+ - {@scrollto Adding a Piece}\n+ - {@scrollto Naming Conflicts}\n+ - {@scrollto Pieces}\n+ - {@scrollto Types}\n+ - {@scrollto Custom Types} \n+ - {@scrollto Options}\n+ - {@scrollto Default Option}\n+ - {@scrollto Filter Option}\n+ - {@scrollto Resolve Option}\n+- {@scrollto Settings}\n+ - {@scrollto Getting a Value}\n+ - {@scrollto Updating or Resetting a Value}\n+- {@scrollto Gateway}\n+ - {@scrollto Custom Gateway}\n+\n+## Schema\n+\n+Schemas are the blueprints of how you want your settings setup. They are yours and Klasa's guide for ensuring that any operation done on settings is done correctly.\n+\n+## Folders\n+\n+### Adding a Folder\n+\n+When working with schemas, it's very easy for yours to become unorganized or hard to manage. This is where folders come in. You can use Folders to group similar keys together to make it much easier to manage and read. Below is an example of how to add a folder to a schema.\n+\n+```javascript\n+const { Client } = require('klasa');\n+\n+Client.defaultGuildSchema\n+\t// Let's add a moderation folder\n+\t.add('moderation', modFolder => {\n+\t\t// Moderation Role\n+\t\tmodFolder.add('role', 'role');\n+\t\t// Moderation channel\n+\t\tmodFolder.add('channel', 'textchannel');\n+\t});\n+```\n+\n+To use both of these newly created keys, you would update `moderation.role` and `moderation.channel` with a role and channel, respectively.\n+\n+You can also add a folder inside of another folder, allowing you to finely tune your Schema exactly to your likings.\n+\n+### Adding a Piece\n+\n+The function for adding a piece takes three arguments.\n+\n+- A name for the key\n+- A type for the key\n+- Options object for the key\n+\n+Below is an example of adding a piece. You can find further explanation of Pieces in the next section.\n+\n+```javascript\n+const { Client } = require('klasa');\n+\n+Client.defaultGuildSchema\n+\t// Most of the options are defaulted to what they are here,\n+\t// but for example purposes we'll leave them.\n+\t.add('musicChannel', 'textchannel',\n+\t\t{ array: false, default: null });\n+```\n+\n+<!-- Added extra line on options object to remove scrollbar -->\n+\n+Alternatively, if you wanted multiple channels for music you could set the key as an array instead.\n+\n+```javascript\n+const { Client } = require('klasa');\n+\n+Client.defaultGuildSchema\n+\t.add('musicChannel', 'textchannel', { array: true, default: [] });\n+```\n+\n+Now this key would be an array, and you could add multiple channels to it.\n+\n+### Naming Conflicts\n+\n+Whenever adding keys that have the same name, the Schema will automatically edit the requested key with the new properties you want. This allows you to edit core keys to your liking. Possible issues can crop when using this though, such as editing a prefix key to be a channel instead of the string it should be. Caution should be used when editing core keys.\n+\n+The add function will automatically edit for you when the key is found. You can also get the key directly from the SchemaFolder it is on and call .edit() on it manually.\n+\n+## Pieces\n+\n+Pieces are the individual keys that you will be setting when using Settings. Each key can have multiple different options, and core keys can be overwritten to your liking.\n+\n+### Types\n+\n+By default, there are several built-in types that the developer can use, and with the possibility to add custom types via {@link Serializer}s as explained below. The built-in types are:\n+\n+| Name | Type | Description |\n+| ------------------- | ------------------------------------------------- | ---------------------------------------------------------------------------------------- |\n+| **any** | Anything, no type restriction | Resolves anything, even objects. The usage of this type will make a key unconfigurable |\n+| **boolean** | A {@link Boolean} resolvable | Resolves a boolean primitive value |\n+| **categorychannel** | A {@link external:CategoryChannel} instance or id | Resolves a CategoryChannel |\n+| **channel** | A {@link external:Channel} instance or id | Resolves a channel. Be careful with using this, as it accepts any type of channel |\n+| **command** | A {@link Command} instance or name | Resolves a Command |\n+| **float** | A floating point number | Resolves a [float](https://en.wikipedia.org/wiki/Double-precision_floating-point_format) |\n+| **guild** | A {@link KlasaGuild} instance or id | Resolves a KlasaGuild (which extends Guild) |\n+| **integer** | An integer number | Resolves an [integer](https://en.wikipedia.org/wiki/Integer) number |\n+| **language** | A {@link Language} instance or name | Resolves a language |\n+| **number** | A number | Resolves a [float](https://en.wikipedia.org/wiki/Double-precision_floating-point_format) |\n+| **role** | A {@link external:Role} instance or id | Resolves a Role |\n+| **string** | A {@link external:StringResolvable} | Resolves a string |\n+| **textchannel** | A {@link external:TextChannel} instance or id | Resolves a TextChannel |\n+| **url** | A URL resolvable | Resolves a URL with Node.js' URL parser |\n+| **user** | A {@link KlasaUser} instance or id | Resolves a KlasaUser (which extends User) |\n+| **voicechannel** | A {@link external:VoiceChannel} instance or id | Resolves a VoiceChannel |\n+\n+### Custom Types\n+\n+To add new types, you make a class, extending {@link Serializer}. The following serializer is a template for this:\n+\n+```javascript\n+const { Serializer } = require('klasa');\n+\n+// Extend Serializer to create your own. These are loaded from the Serializers folder.\n+module.exports = class extends Serializer {\n+\n+\tconstructor(...args) {\n+\t\t// If you want aliases for this, you can set them here.\n+\t\tsuper(...args, { aliases: [] });\n+\t}\n+\n+\t// This function is used to tell Settings what this data is actually representing\n+\tdeserialize(data) {\n+\t\t// Assuming data is stored in milliseconds\n+\t\t// We can turn this date, given from your database, into a readable date.\n+\t\t// new Date Object with our specified data\n+\t\treturn new Date(data);\n+\t}\n+\n+\t// This function is used to tell Settings what this data should be stored as\n+\tserialize(value) {\n+\t\t// Convert Date Object back into milliseconds so it can be stored by the database.\n+\t\t// Value here is our Date Object from deserialized.\n+\t\treturn value.getTime();\n+\t}\n+\n+\t// This function is used to tell Settings what we should display the deserialized data as.\n+\tstringify(value) {\n+\t\t// Value here is our Date Object from deserialized\n+\t\treturn value.toDateString();\n+\t}\n+\n+};\n+```\n+\n+**All serializers must resolve values into primitives or storable plain objects, otherwise, the provider may have issues with storing the value.**\n+\n+## Options\n+\n+Below is a list of all schema piece options that can be configured when adding or modifying pieces. You can find the full documentation at {@link SchemaPieceOptions}.\n+\n+{@typedef SchemaPieceOptions}\n+\n+### Default option\n+\n+*The default option is optional, but, what is its default value?*\n+\n+The default option is one of the last options to default, **array** defaults to `false`, **max** and **min** defaults to `null`, **configurable** defaults to either `true` or `false`, the latter if **type** is `any`; and **type** is always obligatory.\n+\n+- If **array** is true, default will be an empty array: `[]`.\n+- If **type** is boolean, default will be `false`.\n+- In any other case, it will be `null`.\n+\n+### Filter option\n+\n+The filter option serves to blacklist certain values. It's output is not used, but any thrown error will be handled by SettingsGateway's internals and displayed to the caller (for example in the conf command, it would display the message to the user). It also must be synchronous.\n+\n+Internally, we use this option to avoid users from disabling guarded commands (check {@link Command#guard}):\n+\n+```javascript\n+const filter = (client, command, entry, language) => {\n+\tif (command.guarded) throw language.get('COMMAND_CONF_GUARDED', command.name);\n+};\n+\n+```\n+\n+In this case, `client` is the {@link KlasaClient} instance, `command` the resolved command (the output from the command's SchemaType), `piece` is a {@link SchemaPiece} instance, and guild is a {@link Guild} instance, which may be null.\n+\n+### Resolve option\n+\n+The resolve option allows you specify whether or not you want your primitive values turned back into their full objects (where possible, ex: Turning User ID => User Object). When using the resolve method, this option will determine whether or not you get back a primitive or not. This option is true by default, and will automatically resolve every single object in array where possible.\n+\n+An example: You have a roles array that gives certain roles permissions to use more commands. You want to check if a user has any of the roles in the array.\n+\n+```javascript\n+const { Client } = require('klasa');\n+\n+// Resolve is default by true, here for example purposes\n+Client.defaultGuildSchema.add('roles', 'role', { array: true, resolve: true });\n+\n+// Assuming you're running this command in a guild, can also be awaited and destructured.\n+// Using this function you can expect 1 of 2 outcomes\n+// 1. You will get a resolved role back from the output which you can use just like any other role object.\n+// 2. You will get null back which indicates, for whatever reason, that the key could not be converted back to a role object.\n+// Since our key is an array, this will resolve all roles inside that array.\n+message.guild.settings.resolve('roles').then(resolved => console.log(resolved));\n+```\n+\n+The above code is functionally equivalent to this:\n+\n+```javascript\n+const { Client } = require('klasa');\n+\n+Client.defaultGuildSchema.add('roles', 'role', { array: true });\n+\n+// Array of Role Objects\n+const roles = message.guild.settings.get('roles').map(role => message.guild.roles.get(role));\n+```\n+\n+> Note: Any key that cannot be resolved to its full object will be set to null to ensure falsy checks work as intended.\n+\n+## Settings\n+\n+They are maps that mirror the schemas with the values, they are always filled with all the elements from it, using schema's default values if no value is available in the database, this allows safety as the keys will always exist if they are defined in the schemas. The two most basic actions are:\n+\n+### Getting a Value\n+\n+Using {@link Settings#get}, we give it a path:\n+\n+```javascript\n+// Get the prefix from the guild\n+message.guild.settings.get('prefix');\n+```\n+\n+When using nested groups, we separate the groups names by dot:\n+\n+```javascript\n+// Get the value from the administrator key from the roles group\n+message.guild.settings.get('roles.administrator');\n+```\n+\n+You can use the pluck method to get multiple keys at once. It will return an object keyed by the paths you gave it.\n+\n+```javascript\n+const { prefix, 'roles.administrator': adminRole } = message.guild.settings.pluck('prefix', 'roles.administrator');","path":"guides/Getting Started/Settings.md","position":244,"original_position":244,"commit_id":"0611425f14d69721a81bd0f813e8ca5146a2d2e5","original_commit_id":"0611425f14d69721a81bd0f813e8ca5146a2d2e5","user":{"login":"Skillz4Killz","id":23035000,"node_id":"MDQ6VXNlcjIzMDM1MDAw","avatar_url":"https://avatars3.githubusercontent.com/u/23035000?v=4","gravatar_id":"","url":"https://api.github.com/users/Skillz4Killz","html_url":"https://github.com/Skillz4Killz","followers_url":"https://api.github.com/users/Skillz4Killz/followers","following_url":"https://api.github.com/users/Skillz4Killz/following{/other_user}","gists_url":"https://api.github.com/users/Skillz4Killz/gists{/gist_id}","starred_url":"https://api.github.com/users/Skillz4Killz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skillz4Killz/subscriptions","organizations_url":"https://api.github.com/users/Skillz4Killz/orgs","repos_url":"https://api.github.com/users/Skillz4Killz/repos","events_url":"https://api.github.com/users/Skillz4Killz/events{/privacy}","received_events_url":"https://api.github.com/users/Skillz4Killz/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nconst [prefix, adminRole] = message.guild.settings.pluck('prefix', 'roles.administrator');\r\n```","created_at":"2019-05-28T19:24:22Z","updated_at":"2019-05-28T19:29:21Z","html_url":"https://github.com/dirigeants/klasa/pull/698#discussion_r288264236","pull_request_url":"https://api.github.com/repos/dirigeants/klasa/pulls/698","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/comments/288264236"},"html":{"href":"https://github.com/dirigeants/klasa/pull/698#discussion_r288264236"},"pull_request":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/698"}}},"pull_request":{"url":"https://api.github.com/repos/dirigeants/klasa/pulls/698","id":280536769,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwNTM2NzY5","html_url":"https://github.com/dirigeants/klasa/pull/698","diff_url":"https://github.com/dirigeants/klasa/pull/698.diff","patch_url":"https://github.com/dirigeants/klasa/pull/698.patch","issue_url":"https://api.github.com/repos/dirigeants/klasa/issues/698","number":698,"state":"open","locked":false,"title":"Settings Guides","user":{"login":"UnseenFaith","id":1832323,"node_id":"MDQ6VXNlcjE4MzIzMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1832323?v=4","gravatar_id":"","url":"https://api.github.com/users/UnseenFaith","html_url":"https://github.com/UnseenFaith","followers_url":"https://api.github.com/users/UnseenFaith/followers","following_url":"https://api.github.com/users/UnseenFaith/following{/other_user}","gists_url":"https://api.github.com/users/UnseenFaith/gists{/gist_id}","starred_url":"https://api.github.com/users/UnseenFaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnseenFaith/subscriptions","organizations_url":"https://api.github.com/users/UnseenFaith/orgs","repos_url":"https://api.github.com/users/UnseenFaith/repos","events_url":"https://api.github.com/users/UnseenFaith/events{/privacy}","received_events_url":"https://api.github.com/users/UnseenFaith/received_events","type":"User","site_admin":false},"body":"### Description of the PR\r\nMy Guides from the old branch. Don't merge until Kyra makes decision on pluck vs resolve interface.\r\n\r\n### Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)\r\n\r\n- New(ish) guides for upcoming Settings update.\r\n\r\n### Semver Classification\r\n\r\n- [x] This PR only includes documentation or non-code changes.\r\n- [ ] This PR fixes a bug and does not change the (intended) framework interface.\r\n- [ ] This PR adds methods or properties to the framework interface.\r\n- [ ] This PR removes or renames methods or properties in the framework interface.\r\n","created_at":"2019-05-20T20:48:37Z","updated_at":"2019-05-28T19:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07fe525fc13d60e6427c0b53ceae2a4b088b2a21","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kyranet","id":24852502,"node_id":"MDQ6VXNlcjI0ODUyNTAy","avatar_url":"https://avatars0.githubusercontent.com/u/24852502?v=4","gravatar_id":"","url":"https://api.github.com/users/kyranet","html_url":"https://github.com/kyranet","followers_url":"https://api.github.com/users/kyranet/followers","following_url":"https://api.github.com/users/kyranet/following{/other_user}","gists_url":"https://api.github.com/users/kyranet/gists{/gist_id}","starred_url":"https://api.github.com/users/kyranet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyranet/subscriptions","organizations_url":"https://api.github.com/users/kyranet/orgs","repos_url":"https://api.github.com/users/kyranet/repos","events_url":"https://api.github.com/users/kyranet/events{/privacy}","received_events_url":"https://api.github.com/users/kyranet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":681910215,"node_id":"MDU6TGFiZWw2ODE5MTAyMTU=","url":"https://api.github.com/repos/dirigeants/klasa/labels/Meta:%20Documentation","name":"Meta: Documentation","color":"ffff00","default":false},{"id":923510285,"node_id":"MDU6TGFiZWw5MjM1MTAyODU=","url":"https://api.github.com/repos/dirigeants/klasa/labels/Mod:%20SettingsGateway","name":"Mod: SettingsGateway","color":"2af9c9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dirigeants/klasa/pulls/698/commits","review_comments_url":"https://api.github.com/repos/dirigeants/klasa/pulls/698/comments","review_comment_url":"https://api.github.com/repos/dirigeants/klasa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dirigeants/klasa/issues/698/comments","statuses_url":"https://api.github.com/repos/dirigeants/klasa/statuses/0611425f14d69721a81bd0f813e8ca5146a2d2e5","head":{"label":"UnseenFaith:settings","ref":"settings","sha":"0611425f14d69721a81bd0f813e8ca5146a2d2e5","user":{"login":"UnseenFaith","id":1832323,"node_id":"MDQ6VXNlcjE4MzIzMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1832323?v=4","gravatar_id":"","url":"https://api.github.com/users/UnseenFaith","html_url":"https://github.com/UnseenFaith","followers_url":"https://api.github.com/users/UnseenFaith/followers","following_url":"https://api.github.com/users/UnseenFaith/following{/other_user}","gists_url":"https://api.github.com/users/UnseenFaith/gists{/gist_id}","starred_url":"https://api.github.com/users/UnseenFaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnseenFaith/subscriptions","organizations_url":"https://api.github.com/users/UnseenFaith/orgs","repos_url":"https://api.github.com/users/UnseenFaith/repos","events_url":"https://api.github.com/users/UnseenFaith/events{/privacy}","received_events_url":"https://api.github.com/users/UnseenFaith/received_events","type":"User","site_admin":false},"repo":{"id":97362922,"node_id":"MDEwOlJlcG9zaXRvcnk5NzM2MjkyMg==","name":"klasa","full_name":"UnseenFaith/klasa","private":false,"owner":{"login":"UnseenFaith","id":1832323,"node_id":"MDQ6VXNlcjE4MzIzMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1832323?v=4","gravatar_id":"","url":"https://api.github.com/users/UnseenFaith","html_url":"https://github.com/UnseenFaith","followers_url":"https://api.github.com/users/UnseenFaith/followers","following_url":"https://api.github.com/users/UnseenFaith/following{/other_user}","gists_url":"https://api.github.com/users/UnseenFaith/gists{/gist_id}","starred_url":"https://api.github.com/users/UnseenFaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnseenFaith/subscriptions","organizations_url":"https://api.github.com/users/UnseenFaith/orgs","repos_url":"https://api.github.com/users/UnseenFaith/repos","events_url":"https://api.github.com/users/UnseenFaith/events{/privacy}","received_events_url":"https://api.github.com/users/UnseenFaith/received_events","type":"User","site_admin":false},"html_url":"https://github.com/UnseenFaith/klasa","description":"A class remix on the Komada Bot Framework","fork":true,"url":"https://api.github.com/repos/UnseenFaith/klasa","forks_url":"https://api.github.com/repos/UnseenFaith/klasa/forks","keys_url":"https://api.github.com/repos/UnseenFaith/klasa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UnseenFaith/klasa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UnseenFaith/klasa/teams","hooks_url":"https://api.github.com/repos/UnseenFaith/klasa/hooks","issue_events_url":"https://api.github.com/repos/UnseenFaith/klasa/issues/events{/number}","events_url":"https://api.github.com/repos/UnseenFaith/klasa/events","assignees_url":"https://api.github.com/repos/UnseenFaith/klasa/assignees{/user}","branches_url":"https://api.github.com/repos/UnseenFaith/klasa/branches{/branch}","tags_url":"https://api.github.com/repos/UnseenFaith/klasa/tags","blobs_url":"https://api.github.com/repos/UnseenFaith/klasa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UnseenFaith/klasa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UnseenFaith/klasa/git/refs{/sha}","trees_url":"https://api.github.com/repos/UnseenFaith/klasa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UnseenFaith/klasa/statuses/{sha}","languages_url":"https://api.github.com/repos/UnseenFaith/klasa/languages","stargazers_url":"https://api.github.com/repos/UnseenFaith/klasa/stargazers","contributors_url":"https://api.github.com/repos/UnseenFaith/klasa/contributors","subscribers_url":"https://api.github.com/repos/UnseenFaith/klasa/subscribers","subscription_url":"https://api.github.com/repos/UnseenFaith/klasa/subscription","commits_url":"https://api.github.com/repos/UnseenFaith/klasa/commits{/sha}","git_commits_url":"https://api.github.com/repos/UnseenFaith/klasa/git/commits{/sha}","comments_url":"https://api.github.com/repos/UnseenFaith/klasa/comments{/number}","issue_comment_url":"https://api.github.com/repos/UnseenFaith/klasa/issues/comments{/number}","contents_url":"https://api.github.com/repos/UnseenFaith/klasa/contents/{+path}","compare_url":"https://api.github.com/repos/UnseenFaith/klasa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UnseenFaith/klasa/merges","archive_url":"https://api.github.com/repos/UnseenFaith/klasa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UnseenFaith/klasa/downloads","issues_url":"https://api.github.com/repos/UnseenFaith/klasa/issues{/number}","pulls_url":"https://api.github.com/repos/UnseenFaith/klasa/pulls{/number}","milestones_url":"https://api.github.com/repos/UnseenFaith/klasa/milestones{/number}","notifications_url":"https://api.github.com/repos/UnseenFaith/klasa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UnseenFaith/klasa/labels{/name}","releases_url":"https://api.github.com/repos/UnseenFaith/klasa/releases{/id}","deployments_url":"https://api.github.com/repos/UnseenFaith/klasa/deployments","created_at":"2017-07-16T05:48:55Z","updated_at":"2018-11-10T21:51:20Z","pushed_at":"2019-05-23T01:26:18Z","git_url":"git://github.com/UnseenFaith/klasa.git","ssh_url":"git@github.com:UnseenFaith/klasa.git","clone_url":"https://github.com/UnseenFaith/klasa.git","svn_url":"https://github.com/UnseenFaith/klasa","homepage":null,"size":5101,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dirigeants:settings","ref":"settings","sha":"7909587ef927470417879e2b5f3788cd56088850","user":{"login":"dirigeants","id":25160727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTYwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/25160727?v=4","gravatar_id":"","url":"https://api.github.com/users/dirigeants","html_url":"https://github.com/dirigeants","followers_url":"https://api.github.com/users/dirigeants/followers","following_url":"https://api.github.com/users/dirigeants/following{/other_user}","gists_url":"https://api.github.com/users/dirigeants/gists{/gist_id}","starred_url":"https://api.github.com/users/dirigeants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirigeants/subscriptions","organizations_url":"https://api.github.com/users/dirigeants/orgs","repos_url":"https://api.github.com/users/dirigeants/repos","events_url":"https://api.github.com/users/dirigeants/events{/privacy}","received_events_url":"https://api.github.com/users/dirigeants/received_events","type":"Organization","site_admin":false},"repo":{"id":97268750,"node_id":"MDEwOlJlcG9zaXRvcnk5NzI2ODc1MA==","name":"klasa","full_name":"dirigeants/klasa","private":false,"owner":{"login":"dirigeants","id":25160727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTYwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/25160727?v=4","gravatar_id":"","url":"https://api.github.com/users/dirigeants","html_url":"https://github.com/dirigeants","followers_url":"https://api.github.com/users/dirigeants/followers","following_url":"https://api.github.com/users/dirigeants/following{/other_user}","gists_url":"https://api.github.com/users/dirigeants/gists{/gist_id}","starred_url":"https://api.github.com/users/dirigeants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirigeants/subscriptions","organizations_url":"https://api.github.com/users/dirigeants/orgs","repos_url":"https://api.github.com/users/dirigeants/repos","events_url":"https://api.github.com/users/dirigeants/events{/privacy}","received_events_url":"https://api.github.com/users/dirigeants/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dirigeants/klasa","description":"A class remix of the Komada Bot Framework","fork":false,"url":"https://api.github.com/repos/dirigeants/klasa","forks_url":"https://api.github.com/repos/dirigeants/klasa/forks","keys_url":"https://api.github.com/repos/dirigeants/klasa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirigeants/klasa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirigeants/klasa/teams","hooks_url":"https://api.github.com/repos/dirigeants/klasa/hooks","issue_events_url":"https://api.github.com/repos/dirigeants/klasa/issues/events{/number}","events_url":"https://api.github.com/repos/dirigeants/klasa/events","assignees_url":"https://api.github.com/repos/dirigeants/klasa/assignees{/user}","branches_url":"https://api.github.com/repos/dirigeants/klasa/branches{/branch}","tags_url":"https://api.github.com/repos/dirigeants/klasa/tags","blobs_url":"https://api.github.com/repos/dirigeants/klasa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirigeants/klasa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirigeants/klasa/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirigeants/klasa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirigeants/klasa/statuses/{sha}","languages_url":"https://api.github.com/repos/dirigeants/klasa/languages","stargazers_url":"https://api.github.com/repos/dirigeants/klasa/stargazers","contributors_url":"https://api.github.com/repos/dirigeants/klasa/contributors","subscribers_url":"https://api.github.com/repos/dirigeants/klasa/subscribers","subscription_url":"https://api.github.com/repos/dirigeants/klasa/subscription","commits_url":"https://api.github.com/repos/dirigeants/klasa/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirigeants/klasa/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirigeants/klasa/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirigeants/klasa/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirigeants/klasa/contents/{+path}","compare_url":"https://api.github.com/repos/dirigeants/klasa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirigeants/klasa/merges","archive_url":"https://api.github.com/repos/dirigeants/klasa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirigeants/klasa/downloads","issues_url":"https://api.github.com/repos/dirigeants/klasa/issues{/number}","pulls_url":"https://api.github.com/repos/dirigeants/klasa/pulls{/number}","milestones_url":"https://api.github.com/repos/dirigeants/klasa/milestones{/number}","notifications_url":"https://api.github.com/repos/dirigeants/klasa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirigeants/klasa/labels{/name}","releases_url":"https://api.github.com/repos/dirigeants/klasa/releases{/id}","deployments_url":"https://api.github.com/repos/dirigeants/klasa/deployments","created_at":"2017-07-14T20:01:50Z","updated_at":"2019-05-26T22:01:41Z","pushed_at":"2019-05-28T19:20:46Z","git_url":"git://github.com/dirigeants/klasa.git","ssh_url":"git@github.com:dirigeants/klasa.git","clone_url":"https://github.com/dirigeants/klasa.git","svn_url":"https://github.com/dirigeants/klasa","homepage":"https://klasa.js.org","size":10324,"stargazers_count":139,"watchers_count":139,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":73,"open_issues":11,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/698"},"html":{"href":"https://github.com/dirigeants/klasa/pull/698"},"issue":{"href":"https://api.github.com/repos/dirigeants/klasa/issues/698"},"comments":{"href":"https://api.github.com/repos/dirigeants/klasa/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/dirigeants/klasa/statuses/0611425f14d69721a81bd0f813e8ca5146a2d2e5"}},"author_association":"MEMBER"}}
|
{
"id": 97268750,
"name": "dirigeants/klasa",
"url": "https://api.github.com/repos/dirigeants/klasa"
}
|
{
"id": 23035000,
"login": "Skillz4Killz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23035000?",
"url": "https://api.github.com/users/Skillz4Killz"
}
|
{
"id": 25160727,
"login": "dirigeants",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25160727?",
"url": "https://api.github.com/orgs/dirigeants"
}
| 2019-05-28T19:24:22 |
9713561024
|
{"actor":{"display_login":"Skillz4Killz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kiwicom/margarita/pulls/comments/265150101","pull_request_review_id":213980732,"id":265150101,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTE1MDEwMQ==","diff_hunk":"@@ -67,6 +67,10 @@ const GithubLink = styled.div`\n }\n `;\n \n+const LinkWithHeight = styled.div`\n+ height: 42px;","path":"apps/landingPage/components/Header.js","position":41,"original_position":41,"commit_id":"020eb4ae87bd7bd80bf7278f2f68e1935b4276f8","original_commit_id":"b0ae5329c1a1aad311b8b75ead248071ca2ef953","user":{"login":"KarinaDavtyan","id":25099820,"node_id":"MDQ6VXNlcjI1MDk5ODIw","avatar_url":"https://avatars1.githubusercontent.com/u/25099820?v=4","gravatar_id":"","url":"https://api.github.com/users/KarinaDavtyan","html_url":"https://github.com/KarinaDavtyan","followers_url":"https://api.github.com/users/KarinaDavtyan/followers","following_url":"https://api.github.com/users/KarinaDavtyan/following{/other_user}","gists_url":"https://api.github.com/users/KarinaDavtyan/gists{/gist_id}","starred_url":"https://api.github.com/users/KarinaDavtyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarinaDavtyan/subscriptions","organizations_url":"https://api.github.com/users/KarinaDavtyan/orgs","repos_url":"https://api.github.com/users/KarinaDavtyan/repos","events_url":"https://api.github.com/users/KarinaDavtyan/events{/privacy}","received_events_url":"https://api.github.com/users/KarinaDavtyan/received_events","type":"User","site_admin":false},"body":"Alright, keeping 42px for now then\r\n","created_at":"2019-03-13T14:20:44Z","updated_at":"2019-03-13T14:20:44Z","html_url":"https://github.com/kiwicom/margarita/pull/510#discussion_r265150101","pull_request_url":"https://api.github.com/repos/kiwicom/margarita/pulls/510","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiwicom/margarita/pulls/comments/265150101"},"html":{"href":"https://github.com/kiwicom/margarita/pull/510#discussion_r265150101"},"pull_request":{"href":"https://api.github.com/repos/kiwicom/margarita/pulls/510"}},"in_reply_to_id":263832226},"pull_request":{"url":"https://api.github.com/repos/kiwicom/margarita/pulls/510","id":259515276,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NTE1Mjc2","html_url":"https://github.com/kiwicom/margarita/pull/510","diff_url":"https://github.com/kiwicom/margarita/pull/510.diff","patch_url":"https://github.com/kiwicom/margarita/pull/510.patch","issue_url":"https://api.github.com/repos/kiwicom/margarita/issues/510","number":510,"state":"open","locked":false,"title":"Improve headline responsiveness on big tablet","user":{"login":"KarinaDavtyan","id":25099820,"node_id":"MDQ6VXNlcjI1MDk5ODIw","avatar_url":"https://avatars1.githubusercontent.com/u/25099820?v=4","gravatar_id":"","url":"https://api.github.com/users/KarinaDavtyan","html_url":"https://github.com/KarinaDavtyan","followers_url":"https://api.github.com/users/KarinaDavtyan/followers","following_url":"https://api.github.com/users/KarinaDavtyan/following{/other_user}","gists_url":"https://api.github.com/users/KarinaDavtyan/gists{/gist_id}","starred_url":"https://api.github.com/users/KarinaDavtyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarinaDavtyan/subscriptions","organizations_url":"https://api.github.com/users/KarinaDavtyan/orgs","repos_url":"https://api.github.com/users/KarinaDavtyan/repos","events_url":"https://api.github.com/users/KarinaDavtyan/events{/privacy}","received_events_url":"https://api.github.com/users/KarinaDavtyan/received_events","type":"User","site_admin":false},"body":"+ fix horizontal scroll\r\n+ wrap buttons in the *Orbit's* `Stack`\r\n+ improve responsiveness on *big tablet* size\r\n\r\n#### Before\r\n<img width=\"814\" alt=\"screenshot 2019-03-07 at 17 48 10\" src=\"https://user-images.githubusercontent.com/25099820/54038170-2b731780-41c0-11e9-8099-9453e6de8c02.png\">\r\n\r\n#### After\r\n<img width=\"887\" alt=\"screenshot 2019-03-08 at 16 31 03\" src=\"https://user-images.githubusercontent.com/25099820/54038201-3e85e780-41c0-11e9-9415-73aea0f17b7e.png\">\r\n\r\n","created_at":"2019-03-08T15:38:57Z","updated_at":"2019-03-13T14:20:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48b7ed6550842f3c370a51b63d35591d5a7ef173","assignee":null,"assignees":[],"requested_reviewers":[{"login":"RobinCsl","id":22741774,"node_id":"MDQ6VXNlcjIyNzQxNzc0","avatar_url":"https://avatars3.githubusercontent.com/u/22741774?v=4","gravatar_id":"","url":"https://api.github.com/users/RobinCsl","html_url":"https://github.com/RobinCsl","followers_url":"https://api.github.com/users/RobinCsl/followers","following_url":"https://api.github.com/users/RobinCsl/following{/other_user}","gists_url":"https://api.github.com/users/RobinCsl/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinCsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinCsl/subscriptions","organizations_url":"https://api.github.com/users/RobinCsl/orgs","repos_url":"https://api.github.com/users/RobinCsl/repos","events_url":"https://api.github.com/users/RobinCsl/events{/privacy}","received_events_url":"https://api.github.com/users/RobinCsl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiwicom/margarita/pulls/510/commits","review_comments_url":"https://api.github.com/repos/kiwicom/margarita/pulls/510/comments","review_comment_url":"https://api.github.com/repos/kiwicom/margarita/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiwicom/margarita/issues/510/comments","statuses_url":"https://api.github.com/repos/kiwicom/margarita/statuses/020eb4ae87bd7bd80bf7278f2f68e1935b4276f8","head":{"label":"kiwicom:fix/landing-page-horizontal-scroll","ref":"fix/landing-page-horizontal-scroll","sha":"020eb4ae87bd7bd80bf7278f2f68e1935b4276f8","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":159488635,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0ODg2MzU=","name":"margarita","full_name":"kiwicom/margarita","private":false,"owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiwicom/margarita","description":"Mobile and Web application implementing Kiwi.com Tequila API ","fork":false,"url":"https://api.github.com/repos/kiwicom/margarita","forks_url":"https://api.github.com/repos/kiwicom/margarita/forks","keys_url":"https://api.github.com/repos/kiwicom/margarita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/margarita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/margarita/teams","hooks_url":"https://api.github.com/repos/kiwicom/margarita/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/margarita/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/margarita/events","assignees_url":"https://api.github.com/repos/kiwicom/margarita/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/margarita/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/margarita/tags","blobs_url":"https://api.github.com/repos/kiwicom/margarita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/margarita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/margarita/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/margarita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/margarita/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/margarita/languages","stargazers_url":"https://api.github.com/repos/kiwicom/margarita/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/margarita/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/margarita/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/margarita/subscription","commits_url":"https://api.github.com/repos/kiwicom/margarita/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/margarita/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/margarita/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/margarita/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/margarita/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/margarita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/margarita/merges","archive_url":"https://api.github.com/repos/kiwicom/margarita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/margarita/downloads","issues_url":"https://api.github.com/repos/kiwicom/margarita/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/margarita/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/margarita/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/margarita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/margarita/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/margarita/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/margarita/deployments","created_at":"2018-11-28T11:04:52Z","updated_at":"2019-03-13T12:00:52Z","pushed_at":"2019-03-13T13:56:47Z","git_url":"git://github.com/kiwicom/margarita.git","ssh_url":"git@github.com:kiwicom/margarita.git","clone_url":"https://github.com/kiwicom/margarita.git","svn_url":"https://github.com/kiwicom/margarita","homepage":"","size":17931,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":45,"watchers":29,"default_branch":"master"}},"base":{"label":"kiwicom:master","ref":"master","sha":"dfb1ab7ed0656132e884e2ea1e86eee6f6662952","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":159488635,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0ODg2MzU=","name":"margarita","full_name":"kiwicom/margarita","private":false,"owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiwicom/margarita","description":"Mobile and Web application implementing Kiwi.com Tequila API ","fork":false,"url":"https://api.github.com/repos/kiwicom/margarita","forks_url":"https://api.github.com/repos/kiwicom/margarita/forks","keys_url":"https://api.github.com/repos/kiwicom/margarita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/margarita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/margarita/teams","hooks_url":"https://api.github.com/repos/kiwicom/margarita/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/margarita/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/margarita/events","assignees_url":"https://api.github.com/repos/kiwicom/margarita/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/margarita/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/margarita/tags","blobs_url":"https://api.github.com/repos/kiwicom/margarita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/margarita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/margarita/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/margarita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/margarita/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/margarita/languages","stargazers_url":"https://api.github.com/repos/kiwicom/margarita/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/margarita/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/margarita/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/margarita/subscription","commits_url":"https://api.github.com/repos/kiwicom/margarita/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/margarita/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/margarita/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/margarita/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/margarita/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/margarita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/margarita/merges","archive_url":"https://api.github.com/repos/kiwicom/margarita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/margarita/downloads","issues_url":"https://api.github.com/repos/kiwicom/margarita/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/margarita/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/margarita/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/margarita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/margarita/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/margarita/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/margarita/deployments","created_at":"2018-11-28T11:04:52Z","updated_at":"2019-03-13T12:00:52Z","pushed_at":"2019-03-13T13:56:47Z","git_url":"git://github.com/kiwicom/margarita.git","ssh_url":"git@github.com:kiwicom/margarita.git","clone_url":"https://github.com/kiwicom/margarita.git","svn_url":"https://github.com/kiwicom/margarita","homepage":"","size":17931,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":45,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiwicom/margarita/pulls/510"},"html":{"href":"https://github.com/kiwicom/margarita/pull/510"},"issue":{"href":"https://api.github.com/repos/kiwicom/margarita/issues/510"},"comments":{"href":"https://api.github.com/repos/kiwicom/margarita/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/kiwicom/margarita/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/kiwicom/margarita/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiwicom/margarita/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/kiwicom/margarita/statuses/020eb4ae87bd7bd80bf7278f2f68e1935b4276f8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 159488635,
"name": "kiwicom/margarita",
"url": "https://api.github.com/repos/kiwicom/margarita"
}
|
{
"id": 25099820,
"login": "KarinaDavtyan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25099820?",
"url": "https://api.github.com/users/KarinaDavtyan"
}
|
{
"id": 25227300,
"login": "kiwicom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25227300?",
"url": "https://api.github.com/orgs/kiwicom"
}
| 2019-03-13T14:20:44 |
9235242395
|
{"actor":{"display_login":"KarinaDavtyan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/next-step/java-racingcar/pulls/comments/340441090","pull_request_review_id":308977271,"id":340441090,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDQ0MTA5MA==","diff_hunk":"@@ -33,31 +34,36 @@ public int calculate(int number) {\n \n private int branchMethod(int number) {\n switch (inputs[number]) {\n- case \"+\" : return add(number);\n- case \"-\" : return subtract(number);\n- case \"*\" : return multiply(number);\n- case \"/\" : return divide(number);\n- default: return isNumber(number);\n+ case \"+\":\n+ return add(number);\n+ case \"-\":\n+ return subtract(number);\n+ case \"*\":\n+ return multiply(number);\n+ case \"/\":\n+ return divide(number);\n+ default:\n+ return numberCheck(number);\n }","path":"src/main/java/step1/StringCalculator.java","position":45,"original_position":45,"commit_id":"5e4d1fb3fb4b78b8bad618e3e09456724c152048","original_commit_id":"5e4d1fb3fb4b78b8bad618e3e09456724c152048","user":{"login":"liquidjoo","id":7530347,"node_id":"MDQ6VXNlcjc1MzAzNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7530347?v=4","gravatar_id":"","url":"https://api.github.com/users/liquidjoo","html_url":"https://github.com/liquidjoo","followers_url":"https://api.github.com/users/liquidjoo/followers","following_url":"https://api.github.com/users/liquidjoo/following{/other_user}","gists_url":"https://api.github.com/users/liquidjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidjoo/subscriptions","organizations_url":"https://api.github.com/users/liquidjoo/orgs","repos_url":"https://api.github.com/users/liquidjoo/repos","events_url":"https://api.github.com/users/liquidjoo/events{/privacy}","received_events_url":"https://api.github.com/users/liquidjoo/received_events","type":"User","site_admin":false},"body":"회사 내의 서비스에선 Enum을 쓰고는 있었지만 연산에 대한 구현 자체가 메소드로 인자를 받는 람다 형식으로는 처음 써본 것 같아요!! 감사합니다~ :)","created_at":"2019-10-30T05:59:14Z","updated_at":"2019-10-30T05:59:14Z","html_url":"https://github.com/next-step/java-racingcar/pull/451#discussion_r340441090","pull_request_url":"https://api.github.com/repos/next-step/java-racingcar/pulls/451","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/next-step/java-racingcar/pulls/comments/340441090"},"html":{"href":"https://github.com/next-step/java-racingcar/pull/451#discussion_r340441090"},"pull_request":{"href":"https://api.github.com/repos/next-step/java-racingcar/pulls/451"}},"in_reply_to_id":340131295},"pull_request":{"url":"https://api.github.com/repos/next-step/java-racingcar/pulls/451","id":333191159,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzMTkxMTU5","html_url":"https://github.com/next-step/java-racingcar/pull/451","diff_url":"https://github.com/next-step/java-racingcar/pull/451.diff","patch_url":"https://github.com/next-step/java-racingcar/pull/451.patch","issue_url":"https://api.github.com/repos/next-step/java-racingcar/issues/451","number":451,"state":"closed","locked":false,"title":"Step3 - 자동차 경주(우승자)","user":{"login":"liquidjoo","id":7530347,"node_id":"MDQ6VXNlcjc1MzAzNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7530347?v=4","gravatar_id":"","url":"https://api.github.com/users/liquidjoo","html_url":"https://github.com/liquidjoo","followers_url":"https://api.github.com/users/liquidjoo/followers","following_url":"https://api.github.com/users/liquidjoo/following{/other_user}","gists_url":"https://api.github.com/users/liquidjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidjoo/subscriptions","organizations_url":"https://api.github.com/users/liquidjoo/orgs","repos_url":"https://api.github.com/users/liquidjoo/repos","events_url":"https://api.github.com/users/liquidjoo/events{/privacy}","received_events_url":"https://api.github.com/users/liquidjoo/received_events","type":"User","site_admin":false},"body":"안녕하세요~ 박재성 리뷰어님 \r\n매번 고생이 많으십니다~\r\n이번엔 기존에 step1 부터 피드백을 주셨던 것 부터해서 다시 정리해서 올립니다!\r\n알려주신데로 intellij 에서 지원하는 자동 포맷도 잘쓰고 있습니다!!\r\n\r\n하나 질문이 있습니다!\r\n현재 step3 과제 중에서 제가 포지션(레이싱거리) 값을 객체의 get/set을 통해 바꾸고있는데요.\r\n처음에 강의를 들을때 get/set을 안쓰고도 할 수 있다라고 말씀을 해주신게 기억이나서~ 혹시 어떤 방식으로 구현을 할 수가 있나요? 제 생각에는 get,set밖에 떠오르지 않아서요!!\r\n리뷰 요청 드립니다~ 감사합니다!!\r\n","created_at":"2019-10-28T15:55:07Z","updated_at":"2019-10-30T05:59:14Z","closed_at":"2019-10-29T15:56:43Z","merged_at":"2019-10-29T15:56:43Z","merge_commit_sha":"9877d9a3018cf64ec301140f1bdbb26230564f14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/next-step/java-racingcar/pulls/451/commits","review_comments_url":"https://api.github.com/repos/next-step/java-racingcar/pulls/451/comments","review_comment_url":"https://api.github.com/repos/next-step/java-racingcar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/next-step/java-racingcar/issues/451/comments","statuses_url":"https://api.github.com/repos/next-step/java-racingcar/statuses/5e4d1fb3fb4b78b8bad618e3e09456724c152048","head":{"label":"liquidjoo:step3","ref":"step3","sha":"5e4d1fb3fb4b78b8bad618e3e09456724c152048","user":{"login":"liquidjoo","id":7530347,"node_id":"MDQ6VXNlcjc1MzAzNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7530347?v=4","gravatar_id":"","url":"https://api.github.com/users/liquidjoo","html_url":"https://github.com/liquidjoo","followers_url":"https://api.github.com/users/liquidjoo/followers","following_url":"https://api.github.com/users/liquidjoo/following{/other_user}","gists_url":"https://api.github.com/users/liquidjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidjoo/subscriptions","organizations_url":"https://api.github.com/users/liquidjoo/orgs","repos_url":"https://api.github.com/users/liquidjoo/repos","events_url":"https://api.github.com/users/liquidjoo/events{/privacy}","received_events_url":"https://api.github.com/users/liquidjoo/received_events","type":"User","site_admin":false},"repo":{"id":217289265,"node_id":"MDEwOlJlcG9zaXRvcnkyMTcyODkyNjU=","name":"java-racingcar","full_name":"liquidjoo/java-racingcar","private":false,"owner":{"login":"liquidjoo","id":7530347,"node_id":"MDQ6VXNlcjc1MzAzNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7530347?v=4","gravatar_id":"","url":"https://api.github.com/users/liquidjoo","html_url":"https://github.com/liquidjoo","followers_url":"https://api.github.com/users/liquidjoo/followers","following_url":"https://api.github.com/users/liquidjoo/following{/other_user}","gists_url":"https://api.github.com/users/liquidjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidjoo/subscriptions","organizations_url":"https://api.github.com/users/liquidjoo/orgs","repos_url":"https://api.github.com/users/liquidjoo/repos","events_url":"https://api.github.com/users/liquidjoo/events{/privacy}","received_events_url":"https://api.github.com/users/liquidjoo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/liquidjoo/java-racingcar","description":"자동차 경주용 게임을 관리하는 저장소","fork":true,"url":"https://api.github.com/repos/liquidjoo/java-racingcar","forks_url":"https://api.github.com/repos/liquidjoo/java-racingcar/forks","keys_url":"https://api.github.com/repos/liquidjoo/java-racingcar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liquidjoo/java-racingcar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liquidjoo/java-racingcar/teams","hooks_url":"https://api.github.com/repos/liquidjoo/java-racingcar/hooks","issue_events_url":"https://api.github.com/repos/liquidjoo/java-racingcar/issues/events{/number}","events_url":"https://api.github.com/repos/liquidjoo/java-racingcar/events","assignees_url":"https://api.github.com/repos/liquidjoo/java-racingcar/assignees{/user}","branches_url":"https://api.github.com/repos/liquidjoo/java-racingcar/branches{/branch}","tags_url":"https://api.github.com/repos/liquidjoo/java-racingcar/tags","blobs_url":"https://api.github.com/repos/liquidjoo/java-racingcar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liquidjoo/java-racingcar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liquidjoo/java-racingcar/git/refs{/sha}","trees_url":"https://api.github.com/repos/liquidjoo/java-racingcar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liquidjoo/java-racingcar/statuses/{sha}","languages_url":"https://api.github.com/repos/liquidjoo/java-racingcar/languages","stargazers_url":"https://api.github.com/repos/liquidjoo/java-racingcar/stargazers","contributors_url":"https://api.github.com/repos/liquidjoo/java-racingcar/contributors","subscribers_url":"https://api.github.com/repos/liquidjoo/java-racingcar/subscribers","subscription_url":"https://api.github.com/repos/liquidjoo/java-racingcar/subscription","commits_url":"https://api.github.com/repos/liquidjoo/java-racingcar/commits{/sha}","git_commits_url":"https://api.github.com/repos/liquidjoo/java-racingcar/git/commits{/sha}","comments_url":"https://api.github.com/repos/liquidjoo/java-racingcar/comments{/number}","issue_comment_url":"https://api.github.com/repos/liquidjoo/java-racingcar/issues/comments{/number}","contents_url":"https://api.github.com/repos/liquidjoo/java-racingcar/contents/{+path}","compare_url":"https://api.github.com/repos/liquidjoo/java-racingcar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liquidjoo/java-racingcar/merges","archive_url":"https://api.github.com/repos/liquidjoo/java-racingcar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liquidjoo/java-racingcar/downloads","issues_url":"https://api.github.com/repos/liquidjoo/java-racingcar/issues{/number}","pulls_url":"https://api.github.com/repos/liquidjoo/java-racingcar/pulls{/number}","milestones_url":"https://api.github.com/repos/liquidjoo/java-racingcar/milestones{/number}","notifications_url":"https://api.github.com/repos/liquidjoo/java-racingcar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liquidjoo/java-racingcar/labels{/name}","releases_url":"https://api.github.com/repos/liquidjoo/java-racingcar/releases{/id}","deployments_url":"https://api.github.com/repos/liquidjoo/java-racingcar/deployments","created_at":"2019-10-24T12:05:14Z","updated_at":"2019-10-24T12:05:15Z","pushed_at":"2019-10-28T15:49:12Z","git_url":"git://github.com/liquidjoo/java-racingcar.git","ssh_url":"git@github.com:liquidjoo/java-racingcar.git","clone_url":"https://github.com/liquidjoo/java-racingcar.git","svn_url":"https://github.com/liquidjoo/java-racingcar","homepage":null,"size":1768,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"next-step:liquidjoo","ref":"liquidjoo","sha":"c90fe0b2407db3e58b82444ab746685b1af81200","user":{"login":"next-step","id":25274995,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjc0OTk1","avatar_url":"https://avatars0.githubusercontent.com/u/25274995?v=4","gravatar_id":"","url":"https://api.github.com/users/next-step","html_url":"https://github.com/next-step","followers_url":"https://api.github.com/users/next-step/followers","following_url":"https://api.github.com/users/next-step/following{/other_user}","gists_url":"https://api.github.com/users/next-step/gists{/gist_id}","starred_url":"https://api.github.com/users/next-step/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/next-step/subscriptions","organizations_url":"https://api.github.com/users/next-step/orgs","repos_url":"https://api.github.com/users/next-step/repos","events_url":"https://api.github.com/users/next-step/events{/privacy}","received_events_url":"https://api.github.com/users/next-step/received_events","type":"Organization","site_admin":false},"repo":{"id":152044195,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwNDQxOTU=","name":"java-racingcar","full_name":"next-step/java-racingcar","private":false,"owner":{"login":"next-step","id":25274995,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjc0OTk1","avatar_url":"https://avatars0.githubusercontent.com/u/25274995?v=4","gravatar_id":"","url":"https://api.github.com/users/next-step","html_url":"https://github.com/next-step","followers_url":"https://api.github.com/users/next-step/followers","following_url":"https://api.github.com/users/next-step/following{/other_user}","gists_url":"https://api.github.com/users/next-step/gists{/gist_id}","starred_url":"https://api.github.com/users/next-step/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/next-step/subscriptions","organizations_url":"https://api.github.com/users/next-step/orgs","repos_url":"https://api.github.com/users/next-step/repos","events_url":"https://api.github.com/users/next-step/events{/privacy}","received_events_url":"https://api.github.com/users/next-step/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/next-step/java-racingcar","description":"자동차 경주용 게임을 관리하는 저장소","fork":false,"url":"https://api.github.com/repos/next-step/java-racingcar","forks_url":"https://api.github.com/repos/next-step/java-racingcar/forks","keys_url":"https://api.github.com/repos/next-step/java-racingcar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/next-step/java-racingcar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/next-step/java-racingcar/teams","hooks_url":"https://api.github.com/repos/next-step/java-racingcar/hooks","issue_events_url":"https://api.github.com/repos/next-step/java-racingcar/issues/events{/number}","events_url":"https://api.github.com/repos/next-step/java-racingcar/events","assignees_url":"https://api.github.com/repos/next-step/java-racingcar/assignees{/user}","branches_url":"https://api.github.com/repos/next-step/java-racingcar/branches{/branch}","tags_url":"https://api.github.com/repos/next-step/java-racingcar/tags","blobs_url":"https://api.github.com/repos/next-step/java-racingcar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/next-step/java-racingcar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/next-step/java-racingcar/git/refs{/sha}","trees_url":"https://api.github.com/repos/next-step/java-racingcar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/next-step/java-racingcar/statuses/{sha}","languages_url":"https://api.github.com/repos/next-step/java-racingcar/languages","stargazers_url":"https://api.github.com/repos/next-step/java-racingcar/stargazers","contributors_url":"https://api.github.com/repos/next-step/java-racingcar/contributors","subscribers_url":"https://api.github.com/repos/next-step/java-racingcar/subscribers","subscription_url":"https://api.github.com/repos/next-step/java-racingcar/subscription","commits_url":"https://api.github.com/repos/next-step/java-racingcar/commits{/sha}","git_commits_url":"https://api.github.com/repos/next-step/java-racingcar/git/commits{/sha}","comments_url":"https://api.github.com/repos/next-step/java-racingcar/comments{/number}","issue_comment_url":"https://api.github.com/repos/next-step/java-racingcar/issues/comments{/number}","contents_url":"https://api.github.com/repos/next-step/java-racingcar/contents/{+path}","compare_url":"https://api.github.com/repos/next-step/java-racingcar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/next-step/java-racingcar/merges","archive_url":"https://api.github.com/repos/next-step/java-racingcar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/next-step/java-racingcar/downloads","issues_url":"https://api.github.com/repos/next-step/java-racingcar/issues{/number}","pulls_url":"https://api.github.com/repos/next-step/java-racingcar/pulls{/number}","milestones_url":"https://api.github.com/repos/next-step/java-racingcar/milestones{/number}","notifications_url":"https://api.github.com/repos/next-step/java-racingcar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/next-step/java-racingcar/labels{/name}","releases_url":"https://api.github.com/repos/next-step/java-racingcar/releases{/id}","deployments_url":"https://api.github.com/repos/next-step/java-racingcar/deployments","created_at":"2018-10-08T08:24:32Z","updated_at":"2019-10-29T11:08:39Z","pushed_at":"2019-10-30T05:40:34Z","git_url":"git://github.com/next-step/java-racingcar.git","ssh_url":"git@github.com:next-step/java-racingcar.git","clone_url":"https://github.com/next-step/java-racingcar.git","svn_url":"https://github.com/next-step/java-racingcar","homepage":null,"size":1972,"stargazers_count":22,"watchers_count":22,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":null,"forks":110,"open_issues":9,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/next-step/java-racingcar/pulls/451"},"html":{"href":"https://github.com/next-step/java-racingcar/pull/451"},"issue":{"href":"https://api.github.com/repos/next-step/java-racingcar/issues/451"},"comments":{"href":"https://api.github.com/repos/next-step/java-racingcar/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/next-step/java-racingcar/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/next-step/java-racingcar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/next-step/java-racingcar/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/next-step/java-racingcar/statuses/5e4d1fb3fb4b78b8bad618e3e09456724c152048"}},"author_association":"NONE"}}
|
{
"id": 152044195,
"name": "next-step/java-racingcar",
"url": "https://api.github.com/repos/next-step/java-racingcar"
}
|
{
"id": 7530347,
"login": "liquidjoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7530347?",
"url": "https://api.github.com/users/liquidjoo"
}
|
{
"id": 25274995,
"login": "next-step",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25274995?",
"url": "https://api.github.com/orgs/next-step"
}
| 2019-10-30T05:59:14 |
10744371499
|
{"actor":{"display_login":"liquidjoo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments/283949076","pull_request_review_id":237436975,"id":283949076,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4Mzk0OTA3Ng==","diff_hunk":"@@ -14,7 +14,7 @@ service Transcoder {\n \n // Called by the transcoder to register to an orchestrator. The orchestrator\n // notifies registered transcoders of segments as they come in.\n- rpc RegisterTranscoder(RegisterRequest) returns (stream NotifySegment);\n+ rpc RegisterTranscoder(stream RegisterRequest) returns (stream NotifySegment);","path":"net/lp_rpc.proto","position":5,"original_position":5,"commit_id":"a13b54a4bd337afa02272088d483247179187503","original_commit_id":"a13b54a4bd337afa02272088d483247179187503","user":{"login":"j0sh","id":292510,"node_id":"MDQ6VXNlcjI5MjUxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/292510?v=4","gravatar_id":"","url":"https://api.github.com/users/j0sh","html_url":"https://github.com/j0sh","followers_url":"https://api.github.com/users/j0sh/followers","following_url":"https://api.github.com/users/j0sh/following{/other_user}","gists_url":"https://api.github.com/users/j0sh/gists{/gist_id}","starred_url":"https://api.github.com/users/j0sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0sh/subscriptions","organizations_url":"https://api.github.com/users/j0sh/orgs","repos_url":"https://api.github.com/users/j0sh/repos","events_url":"https://api.github.com/users/j0sh/events{/privacy}","received_events_url":"https://api.github.com/users/j0sh/received_events","type":"User","site_admin":false},"body":"Curious, what's the advantage of making the RegisterTranscoder request a stream, rather than just having an explicit UnregisterTranscoder RPC call?","created_at":"2019-05-14T18:51:32Z","updated_at":"2019-05-14T18:51:32Z","html_url":"https://github.com/livepeer/go-livepeer/pull/861#discussion_r283949076","pull_request_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments/283949076"},"html":{"href":"https://github.com/livepeer/go-livepeer/pull/861#discussion_r283949076"},"pull_request":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861","id":278803970,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4ODAzOTcw","html_url":"https://github.com/livepeer/go-livepeer/pull/861","diff_url":"https://github.com/livepeer/go-livepeer/pull/861.diff","patch_url":"https://github.com/livepeer/go-livepeer/pull/861.patch","issue_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/861","number":861,"state":"open","locked":false,"title":"Graceful shutdown of transcoder","user":{"login":"darkdarkdragon","id":2035357,"node_id":"MDQ6VXNlcjIwMzUzNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2035357?v=4","gravatar_id":"","url":"https://api.github.com/users/darkdarkdragon","html_url":"https://github.com/darkdarkdragon","followers_url":"https://api.github.com/users/darkdarkdragon/followers","following_url":"https://api.github.com/users/darkdarkdragon/following{/other_user}","gists_url":"https://api.github.com/users/darkdarkdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdarkdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdarkdragon/subscriptions","organizations_url":"https://api.github.com/users/darkdarkdragon/orgs","repos_url":"https://api.github.com/users/darkdarkdragon/repos","events_url":"https://api.github.com/users/darkdarkdragon/events{/privacy}","received_events_url":"https://api.github.com/users/darkdarkdragon/received_events","type":"User","site_admin":false},"body":"**What does this pull request do? Explain your changes. (required)**\r\nOn transcoder's shutdown, wait for currently transcoded segments to finish transcoding.\r\nNotify orchestrator about shutdown, so it doesn't send any more tasks.\r\n\r\n**Specific updates (required)**\r\nSlightly changes `Transcoder` interface to allow monitoring of connection state.\r\n\r\n**How did you test each of these updates (required)**\r\nManually\r\n\r\n**Does this pull request close any open issues?**\r\nfixes #847\r\n\r\n\r\n**Checklist:**\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] README and other documentation updated\r\n- [x] Node runs in OSX and devenv\r\n- [x] All tests in `./test.sh` pass","created_at":"2019-05-14T18:39:30Z","updated_at":"2019-05-14T18:51:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48276d2386db1da4f087931dc505ec7553c0cd86","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861/commits","review_comments_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861/comments","review_comment_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/861/comments","statuses_url":"https://api.github.com/repos/livepeer/go-livepeer/statuses/a13b54a4bd337afa02272088d483247179187503","head":{"label":"livepeer:it/transcodershutdown","ref":"it/transcodershutdown","sha":"a13b54a4bd337afa02272088d483247179187503","user":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"repo":{"id":94728962,"node_id":"MDEwOlJlcG9zaXRvcnk5NDcyODk2Mg==","name":"go-livepeer","full_name":"livepeer/go-livepeer","private":false,"owner":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/livepeer/go-livepeer","description":"Official Go implementation of the Livepeer protocol","fork":false,"url":"https://api.github.com/repos/livepeer/go-livepeer","forks_url":"https://api.github.com/repos/livepeer/go-livepeer/forks","keys_url":"https://api.github.com/repos/livepeer/go-livepeer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livepeer/go-livepeer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livepeer/go-livepeer/teams","hooks_url":"https://api.github.com/repos/livepeer/go-livepeer/hooks","issue_events_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/events{/number}","events_url":"https://api.github.com/repos/livepeer/go-livepeer/events","assignees_url":"https://api.github.com/repos/livepeer/go-livepeer/assignees{/user}","branches_url":"https://api.github.com/repos/livepeer/go-livepeer/branches{/branch}","tags_url":"https://api.github.com/repos/livepeer/go-livepeer/tags","blobs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livepeer/go-livepeer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/refs{/sha}","trees_url":"https://api.github.com/repos/livepeer/go-livepeer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livepeer/go-livepeer/statuses/{sha}","languages_url":"https://api.github.com/repos/livepeer/go-livepeer/languages","stargazers_url":"https://api.github.com/repos/livepeer/go-livepeer/stargazers","contributors_url":"https://api.github.com/repos/livepeer/go-livepeer/contributors","subscribers_url":"https://api.github.com/repos/livepeer/go-livepeer/subscribers","subscription_url":"https://api.github.com/repos/livepeer/go-livepeer/subscription","commits_url":"https://api.github.com/repos/livepeer/go-livepeer/commits{/sha}","git_commits_url":"https://api.github.com/repos/livepeer/go-livepeer/git/commits{/sha}","comments_url":"https://api.github.com/repos/livepeer/go-livepeer/comments{/number}","issue_comment_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/comments{/number}","contents_url":"https://api.github.com/repos/livepeer/go-livepeer/contents/{+path}","compare_url":"https://api.github.com/repos/livepeer/go-livepeer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livepeer/go-livepeer/merges","archive_url":"https://api.github.com/repos/livepeer/go-livepeer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livepeer/go-livepeer/downloads","issues_url":"https://api.github.com/repos/livepeer/go-livepeer/issues{/number}","pulls_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls{/number}","milestones_url":"https://api.github.com/repos/livepeer/go-livepeer/milestones{/number}","notifications_url":"https://api.github.com/repos/livepeer/go-livepeer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livepeer/go-livepeer/labels{/name}","releases_url":"https://api.github.com/repos/livepeer/go-livepeer/releases{/id}","deployments_url":"https://api.github.com/repos/livepeer/go-livepeer/deployments","created_at":"2017-06-19T02:36:09Z","updated_at":"2019-05-14T15:35:05Z","pushed_at":"2019-05-14T18:41:37Z","git_url":"git://github.com/livepeer/go-livepeer.git","ssh_url":"git@github.com:livepeer/go-livepeer.git","clone_url":"https://github.com/livepeer/go-livepeer.git","svn_url":"https://github.com/livepeer/go-livepeer","homepage":"http://livepeer.org","size":100830,"stargazers_count":210,"watchers_count":210,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":56,"open_issues":123,"watchers":210,"default_branch":"master"}},"base":{"label":"livepeer:master","ref":"master","sha":"21ca3d163aedec8e3d7ee8958e16d5cf81ebef08","user":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"repo":{"id":94728962,"node_id":"MDEwOlJlcG9zaXRvcnk5NDcyODk2Mg==","name":"go-livepeer","full_name":"livepeer/go-livepeer","private":false,"owner":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/livepeer/go-livepeer","description":"Official Go implementation of the Livepeer protocol","fork":false,"url":"https://api.github.com/repos/livepeer/go-livepeer","forks_url":"https://api.github.com/repos/livepeer/go-livepeer/forks","keys_url":"https://api.github.com/repos/livepeer/go-livepeer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livepeer/go-livepeer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livepeer/go-livepeer/teams","hooks_url":"https://api.github.com/repos/livepeer/go-livepeer/hooks","issue_events_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/events{/number}","events_url":"https://api.github.com/repos/livepeer/go-livepeer/events","assignees_url":"https://api.github.com/repos/livepeer/go-livepeer/assignees{/user}","branches_url":"https://api.github.com/repos/livepeer/go-livepeer/branches{/branch}","tags_url":"https://api.github.com/repos/livepeer/go-livepeer/tags","blobs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livepeer/go-livepeer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/refs{/sha}","trees_url":"https://api.github.com/repos/livepeer/go-livepeer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livepeer/go-livepeer/statuses/{sha}","languages_url":"https://api.github.com/repos/livepeer/go-livepeer/languages","stargazers_url":"https://api.github.com/repos/livepeer/go-livepeer/stargazers","contributors_url":"https://api.github.com/repos/livepeer/go-livepeer/contributors","subscribers_url":"https://api.github.com/repos/livepeer/go-livepeer/subscribers","subscription_url":"https://api.github.com/repos/livepeer/go-livepeer/subscription","commits_url":"https://api.github.com/repos/livepeer/go-livepeer/commits{/sha}","git_commits_url":"https://api.github.com/repos/livepeer/go-livepeer/git/commits{/sha}","comments_url":"https://api.github.com/repos/livepeer/go-livepeer/comments{/number}","issue_comment_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/comments{/number}","contents_url":"https://api.github.com/repos/livepeer/go-livepeer/contents/{+path}","compare_url":"https://api.github.com/repos/livepeer/go-livepeer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livepeer/go-livepeer/merges","archive_url":"https://api.github.com/repos/livepeer/go-livepeer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livepeer/go-livepeer/downloads","issues_url":"https://api.github.com/repos/livepeer/go-livepeer/issues{/number}","pulls_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls{/number}","milestones_url":"https://api.github.com/repos/livepeer/go-livepeer/milestones{/number}","notifications_url":"https://api.github.com/repos/livepeer/go-livepeer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livepeer/go-livepeer/labels{/name}","releases_url":"https://api.github.com/repos/livepeer/go-livepeer/releases{/id}","deployments_url":"https://api.github.com/repos/livepeer/go-livepeer/deployments","created_at":"2017-06-19T02:36:09Z","updated_at":"2019-05-14T15:35:05Z","pushed_at":"2019-05-14T18:41:37Z","git_url":"git://github.com/livepeer/go-livepeer.git","ssh_url":"git@github.com:livepeer/go-livepeer.git","clone_url":"https://github.com/livepeer/go-livepeer.git","svn_url":"https://github.com/livepeer/go-livepeer","homepage":"http://livepeer.org","size":100830,"stargazers_count":210,"watchers_count":210,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":56,"open_issues":123,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861"},"html":{"href":"https://github.com/livepeer/go-livepeer/pull/861"},"issue":{"href":"https://api.github.com/repos/livepeer/go-livepeer/issues/861"},"comments":{"href":"https://api.github.com/repos/livepeer/go-livepeer/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/livepeer/go-livepeer/statuses/a13b54a4bd337afa02272088d483247179187503"}},"author_association":"COLLABORATOR"}}
|
{
"id": 94728962,
"name": "livepeer/go-livepeer",
"url": "https://api.github.com/repos/livepeer/go-livepeer"
}
|
{
"id": 292510,
"login": "j0sh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/292510?",
"url": "https://api.github.com/users/j0sh"
}
|
{
"id": 25355022,
"login": "livepeer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25355022?",
"url": "https://api.github.com/orgs/livepeer"
}
| 2019-05-14T18:51:32 |
9625135881
|
{"actor":{"display_login":"j0sh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/comments/307516448","pull_request_review_id":266904442,"id":307516448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzUxNjQ0OA==","diff_hunk":"@@ -0,0 +1,58 @@\n+---\n+layout: review\n+title: \"d-SNE: Domain Adaptation Using Stochastic Neighborhood Embedding\"\n+tags: deep-learning domain-adaptation\n+author: \"Pierre-Marc Jodoin\"\n+cite:\n+ authors: \"Xiang Xu, Xiong Zhou, Ragav Venkatesan, Gurumurthy Swaminathan, Orchid Majumder\"\n+ title: \"d-SNE: Domain Adaptation Using Stochastic Neighborhood Embedding\"\n+ venue: \"CVPR 2019\"\n+pdf: \"https://arxiv.org/pdf/1905.12775.pdf\"\n+---\n+\n+\n+\n+\n+# Introduction\n+\n+The authors propose a simple domain adaptation method which corresponds to a *latent-space transformation* approach (c.f.Fig.2)\n+\n+\n+\n+# Methods\n+\n+The idea is very straight forward. Considering $$\\Phi(.)$$ a neural network projecting an input signal $$x_i$$ to a latent space, they assume that a source and a target input signal $$x_i^s$$ and $$x_i^t$$ associated to the same class should have a smaller latent distance than if they had been into different classes. In their case, the distance is a simple L2\n+\n+\n+\n+They proposed a simple loss which maximizes the pair-wise distance between classes while minimizing the pair-wise distance within the classes:","path":"article/_posts/2019-07-24-dsne.md","position":28,"original_position":28,"commit_id":"afabc6a3a126a2c74cbdd18a1fecf1d4af274cfc","original_commit_id":"afabc6a3a126a2c74cbdd18a1fecf1d4af274cfc","user":{"login":"djoerch","id":3168589,"node_id":"MDQ6VXNlcjMxNjg1ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/3168589?v=4","gravatar_id":"","url":"https://api.github.com/users/djoerch","html_url":"https://github.com/djoerch","followers_url":"https://api.github.com/users/djoerch/followers","following_url":"https://api.github.com/users/djoerch/following{/other_user}","gists_url":"https://api.github.com/users/djoerch/gists{/gist_id}","starred_url":"https://api.github.com/users/djoerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djoerch/subscriptions","organizations_url":"https://api.github.com/users/djoerch/orgs","repos_url":"https://api.github.com/users/djoerch/repos","events_url":"https://api.github.com/users/djoerch/events{/privacy}","received_events_url":"https://api.github.com/users/djoerch/received_events","type":"User","site_admin":false},"body":"They propose ...","created_at":"2019-07-25T21:52:21Z","updated_at":"2019-07-25T21:58:47Z","html_url":"https://github.com/vitalab/vitalab.github.io/pull/407#discussion_r307516448","pull_request_url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/comments/307516448"},"html":{"href":"https://github.com/vitalab/vitalab.github.io/pull/407#discussion_r307516448"},"pull_request":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407","id":301203378,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMjAzMzc4","html_url":"https://github.com/vitalab/vitalab.github.io/pull/407","diff_url":"https://github.com/vitalab/vitalab.github.io/pull/407.diff","patch_url":"https://github.com/vitalab/vitalab.github.io/pull/407.patch","issue_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/407","number":407,"state":"open","locked":false,"title":"Domain adaptation paper","user":{"login":"jodoin","id":1280603,"node_id":"MDQ6VXNlcjEyODA2MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1280603?v=4","gravatar_id":"","url":"https://api.github.com/users/jodoin","html_url":"https://github.com/jodoin","followers_url":"https://api.github.com/users/jodoin/followers","following_url":"https://api.github.com/users/jodoin/following{/other_user}","gists_url":"https://api.github.com/users/jodoin/gists{/gist_id}","starred_url":"https://api.github.com/users/jodoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodoin/subscriptions","organizations_url":"https://api.github.com/users/jodoin/orgs","repos_url":"https://api.github.com/users/jodoin/repos","events_url":"https://api.github.com/users/jodoin/events{/privacy}","received_events_url":"https://api.github.com/users/jodoin/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-25T15:41:55Z","updated_at":"2019-07-25T21:58:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"874188f234bb1bd50369eaea445bda8901bdf6b5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nathanpainchaud","id":23144457,"node_id":"MDQ6VXNlcjIzMTQ0NDU3","avatar_url":"https://avatars2.githubusercontent.com/u/23144457?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanpainchaud","html_url":"https://github.com/nathanpainchaud","followers_url":"https://api.github.com/users/nathanpainchaud/followers","following_url":"https://api.github.com/users/nathanpainchaud/following{/other_user}","gists_url":"https://api.github.com/users/nathanpainchaud/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanpainchaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanpainchaud/subscriptions","organizations_url":"https://api.github.com/users/nathanpainchaud/orgs","repos_url":"https://api.github.com/users/nathanpainchaud/repos","events_url":"https://api.github.com/users/nathanpainchaud/events{/privacy}","received_events_url":"https://api.github.com/users/nathanpainchaud/received_events","type":"User","site_admin":false},{"login":"CharlesAuthier","id":25693364,"node_id":"MDQ6VXNlcjI1NjkzMzY0","avatar_url":"https://avatars2.githubusercontent.com/u/25693364?v=4","gravatar_id":"","url":"https://api.github.com/users/CharlesAuthier","html_url":"https://github.com/CharlesAuthier","followers_url":"https://api.github.com/users/CharlesAuthier/followers","following_url":"https://api.github.com/users/CharlesAuthier/following{/other_user}","gists_url":"https://api.github.com/users/CharlesAuthier/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlesAuthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlesAuthier/subscriptions","organizations_url":"https://api.github.com/users/CharlesAuthier/orgs","repos_url":"https://api.github.com/users/CharlesAuthier/repos","events_url":"https://api.github.com/users/CharlesAuthier/events{/privacy}","received_events_url":"https://api.github.com/users/CharlesAuthier/received_events","type":"User","site_admin":false},{"login":"yskan","id":46831339,"node_id":"MDQ6VXNlcjQ2ODMxMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/46831339?v=4","gravatar_id":"","url":"https://api.github.com/users/yskan","html_url":"https://github.com/yskan","followers_url":"https://api.github.com/users/yskan/followers","following_url":"https://api.github.com/users/yskan/following{/other_user}","gists_url":"https://api.github.com/users/yskan/gists{/gist_id}","starred_url":"https://api.github.com/users/yskan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yskan/subscriptions","organizations_url":"https://api.github.com/users/yskan/orgs","repos_url":"https://api.github.com/users/yskan/repos","events_url":"https://api.github.com/users/yskan/events{/privacy}","received_events_url":"https://api.github.com/users/yskan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407/commits","review_comments_url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407/comments","review_comment_url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/407/comments","statuses_url":"https://api.github.com/repos/vitalab/vitalab.github.io/statuses/afabc6a3a126a2c74cbdd18a1fecf1d4af274cfc","head":{"label":"vitalab:dsne","ref":"dsne","sha":"afabc6a3a126a2c74cbdd18a1fecf1d4af274cfc","user":{"login":"vitalab","id":25389130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg5MTMw","avatar_url":"https://avatars3.githubusercontent.com/u/25389130?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalab","html_url":"https://github.com/vitalab","followers_url":"https://api.github.com/users/vitalab/followers","following_url":"https://api.github.com/users/vitalab/following{/other_user}","gists_url":"https://api.github.com/users/vitalab/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalab/subscriptions","organizations_url":"https://api.github.com/users/vitalab/orgs","repos_url":"https://api.github.com/users/vitalab/repos","events_url":"https://api.github.com/users/vitalab/events{/privacy}","received_events_url":"https://api.github.com/users/vitalab/received_events","type":"Organization","site_admin":false},"repo":{"id":80221265,"node_id":"MDEwOlJlcG9zaXRvcnk4MDIyMTI2NQ==","name":"vitalab.github.io","full_name":"vitalab/vitalab.github.io","private":false,"owner":{"login":"vitalab","id":25389130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg5MTMw","avatar_url":"https://avatars3.githubusercontent.com/u/25389130?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalab","html_url":"https://github.com/vitalab","followers_url":"https://api.github.com/users/vitalab/followers","following_url":"https://api.github.com/users/vitalab/following{/other_user}","gists_url":"https://api.github.com/users/vitalab/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalab/subscriptions","organizations_url":"https://api.github.com/users/vitalab/orgs","repos_url":"https://api.github.com/users/vitalab/repos","events_url":"https://api.github.com/users/vitalab/events{/privacy}","received_events_url":"https://api.github.com/users/vitalab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vitalab/vitalab.github.io","description":"Literature repo of the Vitalab :","fork":false,"url":"https://api.github.com/repos/vitalab/vitalab.github.io","forks_url":"https://api.github.com/repos/vitalab/vitalab.github.io/forks","keys_url":"https://api.github.com/repos/vitalab/vitalab.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitalab/vitalab.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitalab/vitalab.github.io/teams","hooks_url":"https://api.github.com/repos/vitalab/vitalab.github.io/hooks","issue_events_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/vitalab/vitalab.github.io/events","assignees_url":"https://api.github.com/repos/vitalab/vitalab.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/vitalab/vitalab.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/vitalab/vitalab.github.io/tags","blobs_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitalab/vitalab.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/vitalab/vitalab.github.io/languages","stargazers_url":"https://api.github.com/repos/vitalab/vitalab.github.io/stargazers","contributors_url":"https://api.github.com/repos/vitalab/vitalab.github.io/contributors","subscribers_url":"https://api.github.com/repos/vitalab/vitalab.github.io/subscribers","subscription_url":"https://api.github.com/repos/vitalab/vitalab.github.io/subscription","commits_url":"https://api.github.com/repos/vitalab/vitalab.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitalab/vitalab.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitalab/vitalab.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/vitalab/vitalab.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitalab/vitalab.github.io/merges","archive_url":"https://api.github.com/repos/vitalab/vitalab.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitalab/vitalab.github.io/downloads","issues_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/vitalab/vitalab.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/vitalab/vitalab.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitalab/vitalab.github.io/labels{/name}","releases_url":"https://api.github.com/repos/vitalab/vitalab.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/vitalab/vitalab.github.io/deployments","created_at":"2017-01-27T15:54:31Z","updated_at":"2019-07-25T14:11:33Z","pushed_at":"2019-07-25T21:44:51Z","git_url":"git://github.com/vitalab/vitalab.github.io.git","ssh_url":"git@github.com:vitalab/vitalab.github.io.git","clone_url":"https://github.com/vitalab/vitalab.github.io.git","svn_url":"https://github.com/vitalab/vitalab.github.io","homepage":"https://vitalab.github.io/","size":286092,"stargazers_count":24,"watchers_count":24,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":null,"forks":9,"open_issues":10,"watchers":24,"default_branch":"master"}},"base":{"label":"vitalab:master","ref":"master","sha":"e7391ee512739ac1519971390312679e13ff44f8","user":{"login":"vitalab","id":25389130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg5MTMw","avatar_url":"https://avatars3.githubusercontent.com/u/25389130?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalab","html_url":"https://github.com/vitalab","followers_url":"https://api.github.com/users/vitalab/followers","following_url":"https://api.github.com/users/vitalab/following{/other_user}","gists_url":"https://api.github.com/users/vitalab/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalab/subscriptions","organizations_url":"https://api.github.com/users/vitalab/orgs","repos_url":"https://api.github.com/users/vitalab/repos","events_url":"https://api.github.com/users/vitalab/events{/privacy}","received_events_url":"https://api.github.com/users/vitalab/received_events","type":"Organization","site_admin":false},"repo":{"id":80221265,"node_id":"MDEwOlJlcG9zaXRvcnk4MDIyMTI2NQ==","name":"vitalab.github.io","full_name":"vitalab/vitalab.github.io","private":false,"owner":{"login":"vitalab","id":25389130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg5MTMw","avatar_url":"https://avatars3.githubusercontent.com/u/25389130?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalab","html_url":"https://github.com/vitalab","followers_url":"https://api.github.com/users/vitalab/followers","following_url":"https://api.github.com/users/vitalab/following{/other_user}","gists_url":"https://api.github.com/users/vitalab/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalab/subscriptions","organizations_url":"https://api.github.com/users/vitalab/orgs","repos_url":"https://api.github.com/users/vitalab/repos","events_url":"https://api.github.com/users/vitalab/events{/privacy}","received_events_url":"https://api.github.com/users/vitalab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vitalab/vitalab.github.io","description":"Literature repo of the Vitalab :","fork":false,"url":"https://api.github.com/repos/vitalab/vitalab.github.io","forks_url":"https://api.github.com/repos/vitalab/vitalab.github.io/forks","keys_url":"https://api.github.com/repos/vitalab/vitalab.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitalab/vitalab.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitalab/vitalab.github.io/teams","hooks_url":"https://api.github.com/repos/vitalab/vitalab.github.io/hooks","issue_events_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/vitalab/vitalab.github.io/events","assignees_url":"https://api.github.com/repos/vitalab/vitalab.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/vitalab/vitalab.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/vitalab/vitalab.github.io/tags","blobs_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitalab/vitalab.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/vitalab/vitalab.github.io/languages","stargazers_url":"https://api.github.com/repos/vitalab/vitalab.github.io/stargazers","contributors_url":"https://api.github.com/repos/vitalab/vitalab.github.io/contributors","subscribers_url":"https://api.github.com/repos/vitalab/vitalab.github.io/subscribers","subscription_url":"https://api.github.com/repos/vitalab/vitalab.github.io/subscription","commits_url":"https://api.github.com/repos/vitalab/vitalab.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitalab/vitalab.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitalab/vitalab.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitalab/vitalab.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/vitalab/vitalab.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitalab/vitalab.github.io/merges","archive_url":"https://api.github.com/repos/vitalab/vitalab.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitalab/vitalab.github.io/downloads","issues_url":"https://api.github.com/repos/vitalab/vitalab.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/vitalab/vitalab.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/vitalab/vitalab.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitalab/vitalab.github.io/labels{/name}","releases_url":"https://api.github.com/repos/vitalab/vitalab.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/vitalab/vitalab.github.io/deployments","created_at":"2017-01-27T15:54:31Z","updated_at":"2019-07-25T14:11:33Z","pushed_at":"2019-07-25T21:44:51Z","git_url":"git://github.com/vitalab/vitalab.github.io.git","ssh_url":"git@github.com:vitalab/vitalab.github.io.git","clone_url":"https://github.com/vitalab/vitalab.github.io.git","svn_url":"https://github.com/vitalab/vitalab.github.io","homepage":"https://vitalab.github.io/","size":286092,"stargazers_count":24,"watchers_count":24,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":null,"forks":9,"open_issues":10,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407"},"html":{"href":"https://github.com/vitalab/vitalab.github.io/pull/407"},"issue":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/407"},"comments":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/vitalab/vitalab.github.io/statuses/afabc6a3a126a2c74cbdd18a1fecf1d4af274cfc"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 80221265,
"name": "vitalab/vitalab.github.io",
"url": "https://api.github.com/repos/vitalab/vitalab.github.io"
}
|
{
"id": 3168589,
"login": "djoerch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3168589?",
"url": "https://api.github.com/users/djoerch"
}
|
{
"id": 25389130,
"login": "vitalab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25389130?",
"url": "https://api.github.com/orgs/vitalab"
}
| 2019-07-25T21:52:21 |
10086836861
|
{"actor":{"display_login":"djoerch"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/comments/313883905","pull_request_review_id":274898477,"id":313883905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzg4MzkwNQ==","diff_hunk":"@@ -0,0 +1 @@\n+/home/agrare/src/manageiq/manageiq","path":"spec/manageiq","position":1,"original_position":1,"commit_id":"61c151f60026b8eddac197514ec25db818a8898d","original_commit_id":"61c151f60026b8eddac197514ec25db818a8898d","user":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"Ugh yeah, the .gitignore for this repo is all wrong","created_at":"2019-08-14T13:49:33Z","updated_at":"2019-08-14T13:49:33Z","html_url":"https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/11#discussion_r313883905","pull_request_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/comments/313883905"},"html":{"href":"https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/11#discussion_r313883905"},"pull_request":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11"}},"in_reply_to_id":313883641},"pull_request":{"url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11","id":307024747,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3MDI0NzQ3","html_url":"https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/11","diff_url":"https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/11.diff","patch_url":"https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/11.patch","issue_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/issues/11","number":11,"state":"open","locked":false,"title":"Filter out any password from the manifest","user":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"Mitigate issues where someone could upload a manifest with the intention\nof collecting passwords from the database by stripping out any of the\n\"password\" fields defined in Vmdb::SettingsWalker","created_at":"2019-08-13T18:27:34Z","updated_at":"2019-08-14T13:49:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7da0e0cf826b62ad8928e5214da2952bd33edc1a","assignee":{"login":"Fryguy","id":52120,"node_id":"MDQ6VXNlcjUyMTIw","avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fryguy","id":52120,"node_id":"MDQ6VXNlcjUyMTIw","avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1443688554,"node_id":"MDU6TGFiZWwxNDQzNjg4NTU0","url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":1465642390,"node_id":"MDU6TGFiZWwxNDY1NjQyMzkw","url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/labels/ivanchuk/yes","name":"ivanchuk/yes","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11/commits","review_comments_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11/comments","review_comment_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/issues/11/comments","statuses_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/statuses/61c151f60026b8eddac197514ec25db818a8898d","head":{"label":"agrare:filter_out_password_fields_from_manifest","ref":"filter_out_password_fields_from_manifest","sha":"61c151f60026b8eddac197514ec25db818a8898d","user":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"repo":{"id":201041796,"node_id":"MDEwOlJlcG9zaXRvcnkyMDEwNDE3OTY=","name":"cfme-migration_analytics","full_name":"agrare/cfme-migration_analytics","private":false,"owner":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"html_url":"https://github.com/agrare/cfme-migration_analytics","description":"Red Hat Migration Analytics plugin for CloudForms.","fork":true,"url":"https://api.github.com/repos/agrare/cfme-migration_analytics","forks_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/forks","keys_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/teams","hooks_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/hooks","issue_events_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/issues/events{/number}","events_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/events","assignees_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/assignees{/user}","branches_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/branches{/branch}","tags_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/tags","blobs_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/statuses/{sha}","languages_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/languages","stargazers_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/stargazers","contributors_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/contributors","subscribers_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/subscribers","subscription_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/subscription","commits_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/contents/{+path}","compare_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/merges","archive_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/downloads","issues_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/issues{/number}","pulls_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/pulls{/number}","milestones_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/milestones{/number}","notifications_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/labels{/name}","releases_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/releases{/id}","deployments_url":"https://api.github.com/repos/agrare/cfme-migration_analytics/deployments","created_at":"2019-08-07T12:01:59Z","updated_at":"2019-08-07T12:02:02Z","pushed_at":"2019-08-14T13:43:32Z","git_url":"git://github.com/agrare/cfme-migration_analytics.git","ssh_url":"git@github.com:agrare/cfme-migration_analytics.git","clone_url":"https://github.com/agrare/cfme-migration_analytics.git","svn_url":"https://github.com/agrare/cfme-migration_analytics","homepage":"","size":356,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHatCloudForms:master","ref":"master","sha":"e76f03d9030d870f85a76f5fb231ff5fd802238a","user":{"login":"RedHatCloudForms","id":25435898,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDM1ODk4","avatar_url":"https://avatars0.githubusercontent.com/u/25435898?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatCloudForms","html_url":"https://github.com/RedHatCloudForms","followers_url":"https://api.github.com/users/RedHatCloudForms/followers","following_url":"https://api.github.com/users/RedHatCloudForms/following{/other_user}","gists_url":"https://api.github.com/users/RedHatCloudForms/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatCloudForms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatCloudForms/subscriptions","organizations_url":"https://api.github.com/users/RedHatCloudForms/orgs","repos_url":"https://api.github.com/users/RedHatCloudForms/repos","events_url":"https://api.github.com/users/RedHatCloudForms/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatCloudForms/received_events","type":"Organization","site_admin":false},"repo":{"id":196073619,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYwNzM2MTk=","name":"cfme-migration_analytics","full_name":"RedHatCloudForms/cfme-migration_analytics","private":false,"owner":{"login":"RedHatCloudForms","id":25435898,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDM1ODk4","avatar_url":"https://avatars0.githubusercontent.com/u/25435898?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatCloudForms","html_url":"https://github.com/RedHatCloudForms","followers_url":"https://api.github.com/users/RedHatCloudForms/followers","following_url":"https://api.github.com/users/RedHatCloudForms/following{/other_user}","gists_url":"https://api.github.com/users/RedHatCloudForms/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatCloudForms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatCloudForms/subscriptions","organizations_url":"https://api.github.com/users/RedHatCloudForms/orgs","repos_url":"https://api.github.com/users/RedHatCloudForms/repos","events_url":"https://api.github.com/users/RedHatCloudForms/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatCloudForms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RedHatCloudForms/cfme-migration_analytics","description":"Red Hat Migration Analytics plugin for CloudForms.","fork":false,"url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics","forks_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/forks","keys_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/teams","hooks_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/hooks","issue_events_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/events","assignees_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/tags","blobs_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/languages","stargazers_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/stargazers","contributors_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/contributors","subscribers_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/subscribers","subscription_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/subscription","commits_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/merges","archive_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/downloads","issues_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/labels{/name}","releases_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/deployments","created_at":"2019-07-09T19:48:07Z","updated_at":"2019-08-13T20:09:08Z","pushed_at":"2019-08-14T13:43:33Z","git_url":"git://github.com/RedHatCloudForms/cfme-migration_analytics.git","ssh_url":"git@github.com:RedHatCloudForms/cfme-migration_analytics.git","clone_url":"https://github.com/RedHatCloudForms/cfme-migration_analytics.git","svn_url":"https://github.com/RedHatCloudForms/cfme-migration_analytics","homepage":"","size":360,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11"},"html":{"href":"https://github.com/RedHatCloudForms/cfme-migration_analytics/pull/11"},"issue":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/issues/11"},"comments":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics/statuses/61c151f60026b8eddac197514ec25db818a8898d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 196073619,
"name": "RedHatCloudForms/cfme-migration_analytics",
"url": "https://api.github.com/repos/RedHatCloudForms/cfme-migration_analytics"
}
|
{
"id": 12851112,
"login": "agrare",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12851112?",
"url": "https://api.github.com/users/agrare"
}
|
{
"id": 25435898,
"login": "RedHatCloudForms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25435898?",
"url": "https://api.github.com/orgs/RedHatCloudForms"
}
| 2019-08-14T13:49:33 |
10209942109
|
{"actor":{"display_login":"agrare"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/spack/spack/pulls/comments/336748197","pull_request_review_id":304225327,"id":336748197,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjc0ODE5Nw==","diff_hunk":"@@ -169,3 +169,22 @@ def test_target_container_semantic(cpu_flag, target_name):\n def test_arch_spec_container_semantic(item, architecture_str):\n architecture = spack.spec.ArchSpec(architecture_str)\n assert item in architecture\n+\n+\n+@pytest.mark.parametrize('compiler,real_version,target_str,expected_flags', [\n+ (spack.spec.CompilerSpec('gcc@9.2.0'), None, 'haswell',\n+ '-march=haswell -mtune=haswell'),\n+ # Check that custom string versions are accepted\n+ (spack.spec.CompilerSpec('gcc@foo'), '9.2.0', 'icelake',\n+ '-march=icelake-client -mtune=icelake-client'),\n+])","path":"lib/spack/spack/test/architecture.py","position":12,"original_position":12,"commit_id":"669cc4397f3ba9038bdbdda47d3b9ff7fe18dc63","original_commit_id":"669cc4397f3ba9038bdbdda47d3b9ff7fe18dc63","user":{"login":"tgamblin","id":299842,"node_id":"MDQ6VXNlcjI5OTg0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/299842?v=4","gravatar_id":"","url":"https://api.github.com/users/tgamblin","html_url":"https://github.com/tgamblin","followers_url":"https://api.github.com/users/tgamblin/followers","following_url":"https://api.github.com/users/tgamblin/following{/other_user}","gists_url":"https://api.github.com/users/tgamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgamblin/subscriptions","organizations_url":"https://api.github.com/users/tgamblin/orgs","repos_url":"https://api.github.com/users/tgamblin/repos","events_url":"https://api.github.com/users/tgamblin/events{/privacy}","received_events_url":"https://api.github.com/users/tgamblin/received_events","type":"User","site_admin":false},"body":"add one with a version and a suffix to make sure that works (e.g., `gcc@4.4.9-special`)","created_at":"2019-10-19T18:20:44Z","updated_at":"2019-10-19T18:20:55Z","html_url":"https://github.com/spack/spack/pull/13222#discussion_r336748197","pull_request_url":"https://api.github.com/repos/spack/spack/pulls/13222","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/comments/336748197"},"html":{"href":"https://github.com/spack/spack/pull/13222#discussion_r336748197"},"pull_request":{"href":"https://api.github.com/repos/spack/spack/pulls/13222"}}},"pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/13222","id":328393338,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4MzkzMzM4","html_url":"https://github.com/spack/spack/pull/13222","diff_url":"https://github.com/spack/spack/pull/13222.diff","patch_url":"https://github.com/spack/spack/pull/13222.patch","issue_url":"https://api.github.com/repos/spack/spack/issues/13222","number":13222,"state":"open","locked":false,"title":"Fix custom compiler versions with microarchitectures","user":{"login":"alalazo","id":4199709,"node_id":"MDQ6VXNlcjQxOTk3MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4199709?v=4","gravatar_id":"","url":"https://api.github.com/users/alalazo","html_url":"https://github.com/alalazo","followers_url":"https://api.github.com/users/alalazo/followers","following_url":"https://api.github.com/users/alalazo/following{/other_user}","gists_url":"https://api.github.com/users/alalazo/gists{/gist_id}","starred_url":"https://api.github.com/users/alalazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalazo/subscriptions","organizations_url":"https://api.github.com/users/alalazo/orgs","repos_url":"https://api.github.com/users/alalazo/repos","events_url":"https://api.github.com/users/alalazo/events{/privacy}","received_events_url":"https://api.github.com/users/alalazo/received_events","type":"User","site_admin":false},"body":"closes #13194 \r\n\r\nCustom string versions for compilers were raising a ValueError on conversion to int. This commit fixes the behavior by trying to detect the underlying compiler version when in presence of a custom string version.","created_at":"2019-10-15T17:56:39Z","updated_at":"2019-10-19T18:20:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"261183951e1805335c1434f155fc1709c8137bce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"scheibelp","id":1659704,"node_id":"MDQ6VXNlcjE2NTk3MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1659704?v=4","gravatar_id":"","url":"https://api.github.com/users/scheibelp","html_url":"https://github.com/scheibelp","followers_url":"https://api.github.com/users/scheibelp/followers","following_url":"https://api.github.com/users/scheibelp/following{/other_user}","gists_url":"https://api.github.com/users/scheibelp/gists{/gist_id}","starred_url":"https://api.github.com/users/scheibelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheibelp/subscriptions","organizations_url":"https://api.github.com/users/scheibelp/orgs","repos_url":"https://api.github.com/users/scheibelp/repos","events_url":"https://api.github.com/users/scheibelp/events{/privacy}","received_events_url":"https://api.github.com/users/scheibelp/received_events","type":"User","site_admin":false},{"login":"becker33","id":13971568,"node_id":"MDQ6VXNlcjEzOTcxNTY4","avatar_url":"https://avatars0.githubusercontent.com/u/13971568?v=4","gravatar_id":"","url":"https://api.github.com/users/becker33","html_url":"https://github.com/becker33","followers_url":"https://api.github.com/users/becker33/followers","following_url":"https://api.github.com/users/becker33/following{/other_user}","gists_url":"https://api.github.com/users/becker33/gists{/gist_id}","starred_url":"https://api.github.com/users/becker33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becker33/subscriptions","organizations_url":"https://api.github.com/users/becker33/orgs","repos_url":"https://api.github.com/users/becker33/repos","events_url":"https://api.github.com/users/becker33/events{/privacy}","received_events_url":"https://api.github.com/users/becker33/received_events","type":"User","site_admin":false},{"login":"tldahlgren","id":35777542,"node_id":"MDQ6VXNlcjM1Nzc3NTQy","avatar_url":"https://avatars2.githubusercontent.com/u/35777542?v=4","gravatar_id":"","url":"https://api.github.com/users/tldahlgren","html_url":"https://github.com/tldahlgren","followers_url":"https://api.github.com/users/tldahlgren/followers","following_url":"https://api.github.com/users/tldahlgren/following{/other_user}","gists_url":"https://api.github.com/users/tldahlgren/gists{/gist_id}","starred_url":"https://api.github.com/users/tldahlgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tldahlgren/subscriptions","organizations_url":"https://api.github.com/users/tldahlgren/orgs","repos_url":"https://api.github.com/users/tldahlgren/repos","events_url":"https://api.github.com/users/tldahlgren/events{/privacy}","received_events_url":"https://api.github.com/users/tldahlgren/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1566617052,"node_id":"MDU6TGFiZWwxNTY2NjE3MDUy","url":"https://api.github.com/repos/spack/spack/labels/bugfix","name":"bugfix","color":"c4aaef","default":false},{"id":446615268,"node_id":"MDU6TGFiZWw0NDY2MTUyNjg=","url":"https://api.github.com/repos/spack/spack/labels/compilers","name":"compilers","color":"f9d0c4","default":false},{"id":1574436554,"node_id":"MDU6TGFiZWwxNTc0NDM2NTU0","url":"https://api.github.com/repos/spack/spack/labels/microarchitectures","name":"microarchitectures","color":"011970","default":false},{"id":446623896,"node_id":"MDU6TGFiZWw0NDY2MjM4OTY=","url":"https://api.github.com/repos/spack/spack/labels/platform-support","name":"platform-support","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spack/spack/pulls/13222/commits","review_comments_url":"https://api.github.com/repos/spack/spack/pulls/13222/comments","review_comment_url":"https://api.github.com/repos/spack/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spack/spack/issues/13222/comments","statuses_url":"https://api.github.com/repos/spack/spack/statuses/669cc4397f3ba9038bdbdda47d3b9ff7fe18dc63","head":{"label":"alalazo:fixes/custom_compiler_version","ref":"fixes/custom_compiler_version","sha":"669cc4397f3ba9038bdbdda47d3b9ff7fe18dc63","user":{"login":"alalazo","id":4199709,"node_id":"MDQ6VXNlcjQxOTk3MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4199709?v=4","gravatar_id":"","url":"https://api.github.com/users/alalazo","html_url":"https://github.com/alalazo","followers_url":"https://api.github.com/users/alalazo/followers","following_url":"https://api.github.com/users/alalazo/following{/other_user}","gists_url":"https://api.github.com/users/alalazo/gists{/gist_id}","starred_url":"https://api.github.com/users/alalazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalazo/subscriptions","organizations_url":"https://api.github.com/users/alalazo/orgs","repos_url":"https://api.github.com/users/alalazo/repos","events_url":"https://api.github.com/users/alalazo/events{/privacy}","received_events_url":"https://api.github.com/users/alalazo/received_events","type":"User","site_admin":false},"repo":{"id":42234183,"node_id":"MDEwOlJlcG9zaXRvcnk0MjIzNDE4Mw==","name":"spack","full_name":"alalazo/spack","private":false,"owner":{"login":"alalazo","id":4199709,"node_id":"MDQ6VXNlcjQxOTk3MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4199709?v=4","gravatar_id":"","url":"https://api.github.com/users/alalazo","html_url":"https://github.com/alalazo","followers_url":"https://api.github.com/users/alalazo/followers","following_url":"https://api.github.com/users/alalazo/following{/other_user}","gists_url":"https://api.github.com/users/alalazo/gists{/gist_id}","starred_url":"https://api.github.com/users/alalazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalazo/subscriptions","organizations_url":"https://api.github.com/users/alalazo/orgs","repos_url":"https://api.github.com/users/alalazo/repos","events_url":"https://api.github.com/users/alalazo/events{/privacy}","received_events_url":"https://api.github.com/users/alalazo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alalazo/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/alalazo/spack","forks_url":"https://api.github.com/repos/alalazo/spack/forks","keys_url":"https://api.github.com/repos/alalazo/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alalazo/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alalazo/spack/teams","hooks_url":"https://api.github.com/repos/alalazo/spack/hooks","issue_events_url":"https://api.github.com/repos/alalazo/spack/issues/events{/number}","events_url":"https://api.github.com/repos/alalazo/spack/events","assignees_url":"https://api.github.com/repos/alalazo/spack/assignees{/user}","branches_url":"https://api.github.com/repos/alalazo/spack/branches{/branch}","tags_url":"https://api.github.com/repos/alalazo/spack/tags","blobs_url":"https://api.github.com/repos/alalazo/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alalazo/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alalazo/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/alalazo/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alalazo/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/alalazo/spack/languages","stargazers_url":"https://api.github.com/repos/alalazo/spack/stargazers","contributors_url":"https://api.github.com/repos/alalazo/spack/contributors","subscribers_url":"https://api.github.com/repos/alalazo/spack/subscribers","subscription_url":"https://api.github.com/repos/alalazo/spack/subscription","commits_url":"https://api.github.com/repos/alalazo/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/alalazo/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/alalazo/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/alalazo/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/alalazo/spack/contents/{+path}","compare_url":"https://api.github.com/repos/alalazo/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alalazo/spack/merges","archive_url":"https://api.github.com/repos/alalazo/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alalazo/spack/downloads","issues_url":"https://api.github.com/repos/alalazo/spack/issues{/number}","pulls_url":"https://api.github.com/repos/alalazo/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/alalazo/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/alalazo/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alalazo/spack/labels{/name}","releases_url":"https://api.github.com/repos/alalazo/spack/releases{/id}","deployments_url":"https://api.github.com/repos/alalazo/spack/deployments","created_at":"2015-09-10T09:07:46Z","updated_at":"2016-01-12T06:39:06Z","pushed_at":"2019-10-18T11:32:06Z","git_url":"git://github.com/alalazo/spack.git","ssh_url":"git@github.com:alalazo/spack.git","clone_url":"https://github.com/alalazo/spack.git","svn_url":"https://github.com/alalazo/spack","homepage":"http://scalability-llnl.github.io/spack","size":64644,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"spack:develop","ref":"develop","sha":"41e7e5693e86dba94ed4237a3962c311887aa5a8","user":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczMDg2NQ==","name":"spack","full_name":"spack/spack","private":false,"owner":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spack/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/spack/spack","forks_url":"https://api.github.com/repos/spack/spack/forks","keys_url":"https://api.github.com/repos/spack/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spack/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spack/spack/teams","hooks_url":"https://api.github.com/repos/spack/spack/hooks","issue_events_url":"https://api.github.com/repos/spack/spack/issues/events{/number}","events_url":"https://api.github.com/repos/spack/spack/events","assignees_url":"https://api.github.com/repos/spack/spack/assignees{/user}","branches_url":"https://api.github.com/repos/spack/spack/branches{/branch}","tags_url":"https://api.github.com/repos/spack/spack/tags","blobs_url":"https://api.github.com/repos/spack/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spack/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spack/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/spack/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spack/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/spack/spack/languages","stargazers_url":"https://api.github.com/repos/spack/spack/stargazers","contributors_url":"https://api.github.com/repos/spack/spack/contributors","subscribers_url":"https://api.github.com/repos/spack/spack/subscribers","subscription_url":"https://api.github.com/repos/spack/spack/subscription","commits_url":"https://api.github.com/repos/spack/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/spack/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/spack/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/spack/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/spack/spack/contents/{+path}","compare_url":"https://api.github.com/repos/spack/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spack/spack/merges","archive_url":"https://api.github.com/repos/spack/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spack/spack/downloads","issues_url":"https://api.github.com/repos/spack/spack/issues{/number}","pulls_url":"https://api.github.com/repos/spack/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/spack/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/spack/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spack/spack/labels{/name}","releases_url":"https://api.github.com/repos/spack/spack/releases{/id}","deployments_url":"https://api.github.com/repos/spack/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2019-10-19T17:18:34Z","pushed_at":"2019-10-19T17:18:32Z","git_url":"git://github.com/spack/spack.git","ssh_url":"git@github.com:spack/spack.git","clone_url":"https://github.com/spack/spack.git","svn_url":"https://github.com/spack/spack","homepage":"https://spack.io","size":66731,"stargazers_count":1247,"watchers_count":1247,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":781,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1388,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":781,"open_issues":1388,"watchers":1247,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/13222"},"html":{"href":"https://github.com/spack/spack/pull/13222"},"issue":{"href":"https://api.github.com/repos/spack/spack/issues/13222"},"comments":{"href":"https://api.github.com/repos/spack/spack/issues/13222/comments"},"review_comments":{"href":"https://api.github.com/repos/spack/spack/pulls/13222/comments"},"review_comment":{"href":"https://api.github.com/repos/spack/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spack/spack/pulls/13222/commits"},"statuses":{"href":"https://api.github.com/repos/spack/spack/statuses/669cc4397f3ba9038bdbdda47d3b9ff7fe18dc63"}},"author_association":"MEMBER"}}
|
{
"id": 15730865,
"name": "spack/spack",
"url": "https://api.github.com/repos/spack/spack"
}
|
{
"id": 299842,
"login": "tgamblin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/299842?",
"url": "https://api.github.com/users/tgamblin"
}
|
{
"id": 25539161,
"login": "spack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25539161?",
"url": "https://api.github.com/orgs/spack"
}
| 2019-10-19T18:20:44 |
10668265756
|
{"actor":{"display_login":"tgamblin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/spack/spack/pulls/comments/365558765","pull_request_review_id":341554687,"id":365558765,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTU1ODc2NQ==","diff_hunk":"@@ -109,3 +100,63 @@ def test_rst_update(tmpdir):\n assert update_file.exists()\n with update_file.open() as f:\n assert f.read() == 'empty\\n'\n+\n+\n+def test_update_with_header(tmpdir):\n+ update_file = tmpdir.join('output')\n+\n+ # not yet created when commands is run\n+ commands('--update', str(update_file))\n+ assert update_file.exists()\n+ with update_file.open() as f:\n+ assert f.read()\n+ fake_header = 'this is a header!\\n\\n'\n+\n+ filename = tmpdir.join('header.txt')\n+ with filename.open('w') as f:\n+ f.write(fake_header)\n+\n+ # created, newer than commands, but older than header\n+ commands('--update', str(update_file), '--header', str(filename))\n+\n+ # newer than commands and header\n+ commands('--update', str(update_file), '--header', str(filename))\n+\n+\n+def test_no_pipe_error():\n+ \"\"\"Make sure we don't see any pipe errors when piping output.\"\"\"\n+\n+ proc = subprocess.Popen(\n+ ['spack', 'commands', '--format=rst'],\n+ stdout=subprocess.PIPE, stderr=subprocess.PIPE)\n+\n+ # Call close() on stdout to cause a broken pipe\n+ proc.stdout.close()\n+ returncode = proc.wait()\n+ stderr = proc.stderr.read().decode('utf-8')\n+\n+ assert 'Broken pipe' not in stderr","path":"lib/spack/spack/test/cmd/commands.py","position":99,"original_position":94,"commit_id":"2911a6b81f4a05daf202cc7989ee638f0246114f","original_commit_id":"2401fd15d43cc9228b3b511c9ad33fe0a4c1bc9a","user":{"login":"adamjstewart","id":12021217,"node_id":"MDQ6VXNlcjEyMDIxMjE3","avatar_url":"https://avatars2.githubusercontent.com/u/12021217?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"Oddly enough the tests fail for both Python 2 and 3 when run locally, and pass for both Python 2 and 3 when run through Travis...","created_at":"2020-01-12T05:28:40Z","updated_at":"2020-01-12T05:28:40Z","html_url":"https://github.com/spack/spack/pull/14393#discussion_r365558765","pull_request_url":"https://api.github.com/repos/spack/spack/pulls/14393","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/comments/365558765"},"html":{"href":"https://github.com/spack/spack/pull/14393#discussion_r365558765"},"pull_request":{"href":"https://api.github.com/repos/spack/spack/pulls/14393"}},"in_reply_to_id":365549836},"pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/14393","id":359429773,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5NDI5Nzcz","html_url":"https://github.com/spack/spack/pull/14393","diff_url":"https://github.com/spack/spack/pull/14393.diff","patch_url":"https://github.com/spack/spack/pull/14393.patch","issue_url":"https://api.github.com/repos/spack/spack/issues/14393","number":14393,"state":"open","locked":false,"title":"Use `spack commands --format=bash` to generate shell completion","user":{"login":"tgamblin","id":299842,"node_id":"MDQ6VXNlcjI5OTg0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/299842?v=4","gravatar_id":"","url":"https://api.github.com/users/tgamblin","html_url":"https://github.com/tgamblin","followers_url":"https://api.github.com/users/tgamblin/followers","following_url":"https://api.github.com/users/tgamblin/following{/other_user}","gists_url":"https://api.github.com/users/tgamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgamblin/subscriptions","organizations_url":"https://api.github.com/users/tgamblin/orgs","repos_url":"https://api.github.com/users/tgamblin/repos","events_url":"https://api.github.com/users/tgamblin/events{/privacy}","received_events_url":"https://api.github.com/users/tgamblin/received_events","type":"User","site_admin":false},"body":"This PR adds a `--format=bash` option to `spack commands` to auto-generate the Bash programmable tab completion script. It can be extended to work for other shells.\r\n\r\nProgress:\r\n\r\n- [x] Fix bug in superclass initialization in `ArgparseWriter`\r\n- [x] Refactor `ArgparseWriter` (see below)\r\n- [x] Ensure that output of old `--format` options remains the same\r\n- [x] Add `BashCompletionWriter`\r\n- [x] Standardize positional argument names\r\n- [x] Tests for `spack commands --format=bash` coverage\r\n- [x] Tests to make sure `spack-completion.bash` stays up-to-date\r\n\r\nThings I would like to save for future PRs:\r\n\r\n- Speed up `spack-completion.bash` by caching subroutine calls\r\n- Tests for `spack-completion.bash` coverage?\r\n- Docs?\r\n\r\nThis PR also necessitates a significant refactoring of `ArgparseWriter`. Previously, `ArgparseWriter` was mostly a single `_write` method which handled everything from extracting the information we care about from the parser to formatting the output. Now, `_write` only handles recursion, while the information extraction is split into a separate `parse` method, and the formatting is handled by `format`. This allows subclasses to completely redefine how the format will appear without overriding all of `_write`.","created_at":"2020-01-06T07:41:20Z","updated_at":"2020-01-12T05:28:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1751fcda8e22dc30e4923b6cb4f200d0a068d6d0","assignee":{"login":"adamjstewart","id":12021217,"node_id":"MDQ6VXNlcjEyMDIxMjE3","avatar_url":"https://avatars2.githubusercontent.com/u/12021217?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"assignees":[{"login":"adamjstewart","id":12021217,"node_id":"MDQ6VXNlcjEyMDIxMjE3","avatar_url":"https://avatars2.githubusercontent.com/u/12021217?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":471995122,"node_id":"MDU6TGFiZWw0NzE5OTUxMjI=","url":"https://api.github.com/repos/spack/spack/labels/commands","name":"commands","color":"006b75","default":false,"description":null},{"id":456121338,"node_id":"MDU6TGFiZWw0NTYxMjEzMzg=","url":"https://api.github.com/repos/spack/spack/labels/refactoring","name":"refactoring","color":"f28f2a","default":false,"description":null},{"id":475435626,"node_id":"MDU6TGFiZWw0NzU0MzU2MjY=","url":"https://api.github.com/repos/spack/spack/labels/shell-support","name":"shell-support","color":"006b75","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/spack/spack/pulls/14393/commits","review_comments_url":"https://api.github.com/repos/spack/spack/pulls/14393/comments","review_comment_url":"https://api.github.com/repos/spack/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spack/spack/issues/14393/comments","statuses_url":"https://api.github.com/repos/spack/spack/statuses/2911a6b81f4a05daf202cc7989ee638f0246114f","head":{"label":"spack:features/autogenerate-completion","ref":"features/autogenerate-completion","sha":"2911a6b81f4a05daf202cc7989ee638f0246114f","user":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczMDg2NQ==","name":"spack","full_name":"spack/spack","private":false,"owner":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spack/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/spack/spack","forks_url":"https://api.github.com/repos/spack/spack/forks","keys_url":"https://api.github.com/repos/spack/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spack/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spack/spack/teams","hooks_url":"https://api.github.com/repos/spack/spack/hooks","issue_events_url":"https://api.github.com/repos/spack/spack/issues/events{/number}","events_url":"https://api.github.com/repos/spack/spack/events","assignees_url":"https://api.github.com/repos/spack/spack/assignees{/user}","branches_url":"https://api.github.com/repos/spack/spack/branches{/branch}","tags_url":"https://api.github.com/repos/spack/spack/tags","blobs_url":"https://api.github.com/repos/spack/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spack/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spack/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/spack/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spack/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/spack/spack/languages","stargazers_url":"https://api.github.com/repos/spack/spack/stargazers","contributors_url":"https://api.github.com/repos/spack/spack/contributors","subscribers_url":"https://api.github.com/repos/spack/spack/subscribers","subscription_url":"https://api.github.com/repos/spack/spack/subscription","commits_url":"https://api.github.com/repos/spack/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/spack/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/spack/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/spack/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/spack/spack/contents/{+path}","compare_url":"https://api.github.com/repos/spack/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spack/spack/merges","archive_url":"https://api.github.com/repos/spack/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spack/spack/downloads","issues_url":"https://api.github.com/repos/spack/spack/issues{/number}","pulls_url":"https://api.github.com/repos/spack/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/spack/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/spack/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spack/spack/labels{/name}","releases_url":"https://api.github.com/repos/spack/spack/releases{/id}","deployments_url":"https://api.github.com/repos/spack/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2020-01-11T22:13:07Z","pushed_at":"2020-01-12T05:19:01Z","git_url":"git://github.com/spack/spack.git","ssh_url":"git@github.com:spack/spack.git","clone_url":"https://github.com/spack/spack.git","svn_url":"https://github.com/spack/spack","homepage":"https://spack.io","size":71473,"stargazers_count":1375,"watchers_count":1375,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":842,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1311,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":842,"open_issues":1311,"watchers":1375,"default_branch":"develop"}},"base":{"label":"spack:develop","ref":"develop","sha":"257e71d87a8f0eacc8d5fbf88c1aabab8f26c52c","user":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczMDg2NQ==","name":"spack","full_name":"spack/spack","private":false,"owner":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spack/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/spack/spack","forks_url":"https://api.github.com/repos/spack/spack/forks","keys_url":"https://api.github.com/repos/spack/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spack/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spack/spack/teams","hooks_url":"https://api.github.com/repos/spack/spack/hooks","issue_events_url":"https://api.github.com/repos/spack/spack/issues/events{/number}","events_url":"https://api.github.com/repos/spack/spack/events","assignees_url":"https://api.github.com/repos/spack/spack/assignees{/user}","branches_url":"https://api.github.com/repos/spack/spack/branches{/branch}","tags_url":"https://api.github.com/repos/spack/spack/tags","blobs_url":"https://api.github.com/repos/spack/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spack/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spack/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/spack/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spack/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/spack/spack/languages","stargazers_url":"https://api.github.com/repos/spack/spack/stargazers","contributors_url":"https://api.github.com/repos/spack/spack/contributors","subscribers_url":"https://api.github.com/repos/spack/spack/subscribers","subscription_url":"https://api.github.com/repos/spack/spack/subscription","commits_url":"https://api.github.com/repos/spack/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/spack/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/spack/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/spack/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/spack/spack/contents/{+path}","compare_url":"https://api.github.com/repos/spack/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spack/spack/merges","archive_url":"https://api.github.com/repos/spack/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spack/spack/downloads","issues_url":"https://api.github.com/repos/spack/spack/issues{/number}","pulls_url":"https://api.github.com/repos/spack/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/spack/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/spack/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spack/spack/labels{/name}","releases_url":"https://api.github.com/repos/spack/spack/releases{/id}","deployments_url":"https://api.github.com/repos/spack/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2020-01-11T22:13:07Z","pushed_at":"2020-01-12T05:19:01Z","git_url":"git://github.com/spack/spack.git","ssh_url":"git@github.com:spack/spack.git","clone_url":"https://github.com/spack/spack.git","svn_url":"https://github.com/spack/spack","homepage":"https://spack.io","size":71473,"stargazers_count":1375,"watchers_count":1375,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":842,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1311,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":842,"open_issues":1311,"watchers":1375,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/14393"},"html":{"href":"https://github.com/spack/spack/pull/14393"},"issue":{"href":"https://api.github.com/repos/spack/spack/issues/14393"},"comments":{"href":"https://api.github.com/repos/spack/spack/issues/14393/comments"},"review_comments":{"href":"https://api.github.com/repos/spack/spack/pulls/14393/comments"},"review_comment":{"href":"https://api.github.com/repos/spack/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spack/spack/pulls/14393/commits"},"statuses":{"href":"https://api.github.com/repos/spack/spack/statuses/2911a6b81f4a05daf202cc7989ee638f0246114f"}},"author_association":"MEMBER"}}
|
{
"id": 15730865,
"name": "spack/spack",
"url": "https://api.github.com/repos/spack/spack"
}
|
{
"id": 12021217,
"login": "adamjstewart",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12021217?",
"url": "https://api.github.com/users/adamjstewart"
}
|
{
"id": 25539161,
"login": "spack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25539161?",
"url": "https://api.github.com/orgs/spack"
}
| 2020-01-12T05:28:40 |
11255025368
|
{"actor":{"display_login":"adamjstewart"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega/pulls/comments/314770391","pull_request_review_id":276013440,"id":314770391,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDc3MDM5MQ==","diff_hunk":"@@ -0,0 +1,225 @@\n+/**\n+ * Copyright (c) Dell Inc., or its subsidiaries. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ */\n+package io.pravega.common.io.filesystem;\n+\n+import java.io.FileNotFoundException;\n+import java.io.IOException;\n+import java.nio.file.FileSystems;\n+import java.nio.file.InvalidPathException;\n+import java.nio.file.Path;\n+import java.nio.file.Paths;\n+import java.nio.file.StandardWatchEventKinds;\n+import java.nio.file.WatchEvent;\n+import java.nio.file.WatchKey;\n+import java.nio.file.WatchService;\n+import java.util.Optional;\n+import java.util.concurrent.atomic.AtomicInteger;\n+import java.util.function.Consumer;\n+\n+import com.google.common.annotations.VisibleForTesting;\n+import lombok.NonNull;\n+import lombok.extern.slf4j.Slf4j;\n+\n+/**\n+ * Watches for modifications to the specified file and performs the specified action (in the form of a callback) upon\n+ * modification detection.\n+ *\n+ * This implementation uses NIO and event-based Java WatchService to watch for any modifications to the specified file.\n+ *\n+ * Note that:\n+ *\n+ * - The specified actions may trigger slightly later than when the file is actually modified.\n+ *\n+ * - If there are multiple file modifications in quick succession, only the last one may trigger the specified action.\n+ *\n+ * - The callback twice under rare circumstances when a file is modified. The Java {@link WatchService} raises two\n+ * events per modification: one for the content and second for the modification time. While there is a de-duplication\n+ * logic in this class to ensure that only a single event is handled and notified to the callback, it may not work\n+ * at times. If the calling code needs to be notified exactly once at all times, it should consider using\n+ * {@link FileModificationPollingMonitor} instead.\n+ *\n+ * - This class won't work for files that is under a symbolic link (pointing to a directory). This is because the\n+ * Java {@link WatchService} does not raise events for modifications of such files. Consider using\n+ * {@link FileModificationPollingMonitor} instead.\n+ *\n+ */\n+@Slf4j\n+public class FileModificationEventWatcher extends Thread implements FileModificationMonitor {\n+\n+ private static final AtomicInteger THREAD_NUM = new AtomicInteger();\n+\n+ /**\n+ * The path of file to watch.\n+ */\n+ private final Path pathOfFileToWatch;\n+\n+ /**\n+ * The action to perform when the specified file changes.\n+ */\n+ private final Consumer<WatchEvent<?>> callback;\n+\n+ private final UncaughtExceptionHandler uncaughtExceptionalHandler = (t, e) -> logException(e);\n+\n+ private boolean loopContinuously;\n+\n+ /**\n+ * Creates a new instance.\n+ *\n+ * @param fileToWatch the file to watch\n+ * @param callback the callback to invoke when a modification to the {@code fileToWatch} is detected\n+ * @throws NullPointerException if either {@code fileToWatch} or {@code callback} is null\n+ * @throws InvalidPathException if {@code fileToWatch} is invalid\n+ * @throws FileNotFoundException when a file at specified path {@code fileToWatch} does not exist\n+ */\n+ public FileModificationEventWatcher(@NonNull String fileToWatch, @NonNull Consumer<WatchEvent<?>> callback)\n+ throws FileNotFoundException {\n+ this(Paths.get(fileToWatch), callback, true);\n+ }\n+\n+ /**\n+ * Creates a new instance.\n+ *\n+ * @param fileToWatch path of the file to watch\n+ * @param callback the callback to invoke when a modification to the {@code fileToWatch} is detected\n+ * @param loopContinuously whether to keep the thread look for file modification after one iteration. This option\n+ * is useful for testing only.\n+ * @throws InvalidPathException if {@code fileToWatch} is invalid\n+ * @throws FileNotFoundException when a file at specified path {@code fileToWatch} does not exist\n+ * @throws NullPointerException if either {@code fileToWatch} or {@code callback} is null\n+ */\n+ @VisibleForTesting\n+ FileModificationEventWatcher(Path fileToWatch, Consumer<WatchEvent<?>> callback,\n+ boolean loopContinuously)\n+ throws FileNotFoundException {\n+ super();\n+ this.validateInput(fileToWatch, callback);\n+\n+ this.pathOfFileToWatch = fileToWatch;\n+ this.callback = callback;\n+ setUncaughtExceptionHandler(uncaughtExceptionalHandler);\n+\n+ // Set the name for this object/thread for identification purposes.\n+ this.setName(\"file-update-watcher-\" + THREAD_NUM.incrementAndGet());\n+ this.loopContinuously = loopContinuously;\n+ }\n+\n+ @VisibleForTesting\n+ String nameOfFileToWatch() {\n+ Path fileName = this.pathOfFileToWatch.getFileName();\n+ if (fileName != null) {\n+ return fileName.toString();\n+ } else {\n+ throw new RuntimeException(\"File name is null\");\n+ }\n+ }\n+\n+ @VisibleForTesting\n+ Path directoryOfFileToWatch() {\n+ assert this.pathOfFileToWatch != null;\n+ return this.pathOfFileToWatch.getParent();\n+ }\n+\n+ @Override\n+ @SuppressWarnings(\"SleepWhileInLoop\")\n+ public void run() {\n+ WatchKey watchKey = null;\n+ WatchService watchService = null;\n+ try {\n+ watchService = FileSystems.getDefault().newWatchService();\n+ log.debug(\"Done creating watch service for watching file at path: {}\", this.pathOfFileToWatch);\n+\n+ String fileName = nameOfFileToWatch();\n+ Path directoryPath = directoryOfFileToWatch();\n+ log.debug(\"Directory being watched is {}\", directoryPath);\n+\n+ assert directoryPath != null;\n+ directoryPath.register(watchService, StandardWatchEventKinds.ENTRY_MODIFY,\n+ StandardWatchEventKinds.ENTRY_CREATE);\n+ log.debug(\"Done setting up watch for modify entries for file at path: {}\", this.pathOfFileToWatch);\n+\n+ while (true) {\n+ watchKey = watchService.take();\n+ log.info(\"Retrieved and removed watch key for watching file at path: {}\", this.pathOfFileToWatch);\n+\n+ // Each file modification/create usually results in the WatcherService reporting the WatchEvent twice,\n+ // as the file is updated twice: once for the content and once for the file modification time.\n+ // These events occur in quick succession. We wait for 200 ms., here so that the events get\n+ // de-duplicated - in other words only single event is processed.\n+ //\n+ // See https://stackoverflow.com/questions/16777869/java-7-watchservice-ignoring-multiple-occurrences-\n+ // of-the-same-event for a discussion on this topic.\n+ //\n+ // If the two events are not raised within this duration, the callback will be invoked twice, which we\n+ // assume is not a problem for applications of this object. In case the applications do care about\n+ // being notified only once for each modification, they should use the FileModificationPollingMonitor\n+ // instead.\n+ Thread.sleep(200);\n+\n+ if (watchKey != null) {\n+ Optional<WatchEvent<?>> modificationDetectionEvent = watchKey.pollEvents()\n+ .stream()\n+ .filter( // we only care about changes to the specified file.\n+ event -> event.context().toString().contains(fileName))\n+ .findAny(); // we only care to know whether the","path":"common/src/main/java/io/pravega/common/io/filesystem/FileModificationEventWatcher.java","position":170,"original_position":170,"commit_id":"0fab3a1ea3c4512f9e325e924eddf6d4bf6c822b","original_commit_id":"0fab3a1ea3c4512f9e325e924eddf6d4bf6c822b","user":{"login":"andreipaduroiu","id":14354377,"node_id":"MDQ6VXNlcjE0MzU0Mzc3","avatar_url":"https://avatars2.githubusercontent.com/u/14354377?v=4","gravatar_id":"","url":"https://api.github.com/users/andreipaduroiu","html_url":"https://github.com/andreipaduroiu","followers_url":"https://api.github.com/users/andreipaduroiu/followers","following_url":"https://api.github.com/users/andreipaduroiu/following{/other_user}","gists_url":"https://api.github.com/users/andreipaduroiu/gists{/gist_id}","starred_url":"https://api.github.com/users/andreipaduroiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreipaduroiu/subscriptions","organizations_url":"https://api.github.com/users/andreipaduroiu/orgs","repos_url":"https://api.github.com/users/andreipaduroiu/repos","events_url":"https://api.github.com/users/andreipaduroiu/events{/privacy}","received_events_url":"https://api.github.com/users/andreipaduroiu/received_events","type":"User","site_admin":false},"body":"Incomplete comment.","created_at":"2019-08-16T15:25:01Z","updated_at":"2019-08-16T15:57:07Z","html_url":"https://github.com/pravega/pravega/pull/3966#discussion_r314770391","pull_request_url":"https://api.github.com/repos/pravega/pravega/pulls/3966","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments/314770391"},"html":{"href":"https://github.com/pravega/pravega/pull/3966#discussion_r314770391"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3966"}}},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/3966","id":292414737,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyNDE0NzM3","html_url":"https://github.com/pravega/pravega/pull/3966","diff_url":"https://github.com/pravega/pravega/pull/3966.diff","patch_url":"https://github.com/pravega/pravega/pull/3966.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/3966","number":3966,"state":"open","locked":false,"title":"Issue 3652: Segment store TLS reload upon certificate refresh","user":{"login":"ravisharda","id":16592107,"node_id":"MDQ6VXNlcjE2NTkyMTA3","avatar_url":"https://avatars2.githubusercontent.com/u/16592107?v=4","gravatar_id":"","url":"https://api.github.com/users/ravisharda","html_url":"https://github.com/ravisharda","followers_url":"https://api.github.com/users/ravisharda/followers","following_url":"https://api.github.com/users/ravisharda/following{/other_user}","gists_url":"https://api.github.com/users/ravisharda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisharda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisharda/subscriptions","organizations_url":"https://api.github.com/users/ravisharda/orgs","repos_url":"https://api.github.com/users/ravisharda/repos","events_url":"https://api.github.com/users/ravisharda/events{/privacy}","received_events_url":"https://api.github.com/users/ravisharda/received_events","type":"User","site_admin":false},"body":"**Change log description** \r\nReload TLS when segment store TLS material is refreshed. \r\n\r\n**Purpose of the change** \r\nResolves #3652 \r\n\r\n**What the code does** \r\n1. Introduces a new configuration flag in Segment Store that determines whether to reload TLS when the TLS certificate changes. \r\n2. The flag is off by default. If the flag is on: \r\n 1. Watches for change in Segment Store TLS certificate. \r\n We use an event-based WatchService to watch for file modification events. That mechanism doesn't work when the file being watched is a symbolic link. Certificate management tools such as Cert Manager distribute cert as a symbolic link, so in such cases, we use a polling-based file modification monitor.\r\n 2. Upon detecting that the certificate has changed, flushes and closes all existing channels on the server. \r\n That allows the client to retry, which in turn initiates the creation of a new channel that uses a newly created SSL Context using the new certificate and key. \r\n 3. Create a new SSL Context for each channel. \r\n3. The above is implemented both for distributed mode and standalone mode cluster. \r\n It is supported in standalone mode to make it easier to debug and test the feature. The flag is intentionally left out of the `standalone-config.properties` file, but is a hidden flag and may be added by developers if needed. \r\n\r\n**How to verify it** \r\nAll tests should pass. More on this later.\r\n","created_at":"2019-06-27T12:38:01Z","updated_at":"2019-08-16T15:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3417eb8ab3f2f6bf93df5ac8f742f4c4d5e155b","assignee":{"login":"tkaitchuck","id":4756752,"node_id":"MDQ6VXNlcjQ3NTY3NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"assignees":[{"login":"tkaitchuck","id":4756752,"node_id":"MDQ6VXNlcjQ3NTY3NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},{"login":"andreipaduroiu","id":14354377,"node_id":"MDQ6VXNlcjE0MzU0Mzc3","avatar_url":"https://avatars2.githubusercontent.com/u/14354377?v=4","gravatar_id":"","url":"https://api.github.com/users/andreipaduroiu","html_url":"https://github.com/andreipaduroiu","followers_url":"https://api.github.com/users/andreipaduroiu/followers","following_url":"https://api.github.com/users/andreipaduroiu/following{/other_user}","gists_url":"https://api.github.com/users/andreipaduroiu/gists{/gist_id}","starred_url":"https://api.github.com/users/andreipaduroiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreipaduroiu/subscriptions","organizations_url":"https://api.github.com/users/andreipaduroiu/orgs","repos_url":"https://api.github.com/users/andreipaduroiu/repos","events_url":"https://api.github.com/users/andreipaduroiu/events{/privacy}","received_events_url":"https://api.github.com/users/andreipaduroiu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tkaitchuck","id":4756752,"node_id":"MDQ6VXNlcjQ3NTY3NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/3966/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/3966/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/3966/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/0fab3a1ea3c4512f9e325e924eddf6d4bf6c822b","head":{"label":"ravisharda:issue-3652-tls-material-reload","ref":"issue-3652-tls-material-reload","sha":"0fab3a1ea3c4512f9e325e924eddf6d4bf6c822b","user":{"login":"ravisharda","id":16592107,"node_id":"MDQ6VXNlcjE2NTkyMTA3","avatar_url":"https://avatars2.githubusercontent.com/u/16592107?v=4","gravatar_id":"","url":"https://api.github.com/users/ravisharda","html_url":"https://github.com/ravisharda","followers_url":"https://api.github.com/users/ravisharda/followers","following_url":"https://api.github.com/users/ravisharda/following{/other_user}","gists_url":"https://api.github.com/users/ravisharda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisharda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisharda/subscriptions","organizations_url":"https://api.github.com/users/ravisharda/orgs","repos_url":"https://api.github.com/users/ravisharda/repos","events_url":"https://api.github.com/users/ravisharda/events{/privacy}","received_events_url":"https://api.github.com/users/ravisharda/received_events","type":"User","site_admin":false},"repo":{"id":163744248,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM3NDQyNDg=","name":"pravega","full_name":"ravisharda/pravega","private":false,"owner":{"login":"ravisharda","id":16592107,"node_id":"MDQ6VXNlcjE2NTkyMTA3","avatar_url":"https://avatars2.githubusercontent.com/u/16592107?v=4","gravatar_id":"","url":"https://api.github.com/users/ravisharda","html_url":"https://github.com/ravisharda","followers_url":"https://api.github.com/users/ravisharda/followers","following_url":"https://api.github.com/users/ravisharda/following{/other_user}","gists_url":"https://api.github.com/users/ravisharda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisharda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisharda/subscriptions","organizations_url":"https://api.github.com/users/ravisharda/orgs","repos_url":"https://api.github.com/users/ravisharda/repos","events_url":"https://api.github.com/users/ravisharda/events{/privacy}","received_events_url":"https://api.github.com/users/ravisharda/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ravisharda/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/ravisharda/pravega","forks_url":"https://api.github.com/repos/ravisharda/pravega/forks","keys_url":"https://api.github.com/repos/ravisharda/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravisharda/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravisharda/pravega/teams","hooks_url":"https://api.github.com/repos/ravisharda/pravega/hooks","issue_events_url":"https://api.github.com/repos/ravisharda/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/ravisharda/pravega/events","assignees_url":"https://api.github.com/repos/ravisharda/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/ravisharda/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/ravisharda/pravega/tags","blobs_url":"https://api.github.com/repos/ravisharda/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravisharda/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravisharda/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravisharda/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravisharda/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/ravisharda/pravega/languages","stargazers_url":"https://api.github.com/repos/ravisharda/pravega/stargazers","contributors_url":"https://api.github.com/repos/ravisharda/pravega/contributors","subscribers_url":"https://api.github.com/repos/ravisharda/pravega/subscribers","subscription_url":"https://api.github.com/repos/ravisharda/pravega/subscription","commits_url":"https://api.github.com/repos/ravisharda/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravisharda/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravisharda/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravisharda/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravisharda/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/ravisharda/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravisharda/pravega/merges","archive_url":"https://api.github.com/repos/ravisharda/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravisharda/pravega/downloads","issues_url":"https://api.github.com/repos/ravisharda/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/ravisharda/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/ravisharda/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/ravisharda/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravisharda/pravega/labels{/name}","releases_url":"https://api.github.com/repos/ravisharda/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/ravisharda/pravega/deployments","created_at":"2019-01-01T14:51:58Z","updated_at":"2019-07-08T10:56:41Z","pushed_at":"2019-08-16T07:45:37Z","git_url":"git://github.com/ravisharda/pravega.git","ssh_url":"git@github.com:ravisharda/pravega.git","clone_url":"https://github.com/ravisharda/pravega.git","svn_url":"https://github.com/ravisharda/pravega","homepage":"http://pravega.io","size":30272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"91f7b7ac8f7265f2baefa1f320a78e9e76febc8c","user":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"node_id":"MDEwOlJlcG9zaXRvcnk2MzA5NjgyMg==","name":"pravega","full_name":"pravega/pravega","private":false,"owner":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2019-08-16T15:18:55Z","pushed_at":"2019-08-16T14:46:05Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":31120,"stargazers_count":781,"watchers_count":781,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":357,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":178,"open_issues":357,"watchers":781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3966"},"html":{"href":"https://github.com/pravega/pravega/pull/3966"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/3966"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/3966/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3966/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3966/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/0fab3a1ea3c4512f9e325e924eddf6d4bf6c822b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 63096822,
"name": "pravega/pravega",
"url": "https://api.github.com/repos/pravega/pravega"
}
|
{
"id": 14354377,
"login": "andreipaduroiu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14354377?",
"url": "https://api.github.com/users/andreipaduroiu"
}
|
{
"id": 25698199,
"login": "pravega",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25698199?",
"url": "https://api.github.com/orgs/pravega"
}
| 2019-08-16T15:25:01 |
10225769341
|
{"actor":{"display_login":"andreipaduroiu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/prettier/prettier/pulls/comments/306335098","pull_request_review_id":265429164,"id":306335098,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjMzNTA5OA==","diff_hunk":"@@ -446,13 +446,17 @@ function formatFiles(context) {\n let changedCache = null;\n if (context.argv[\"only-changed\"]) {\n const cacheDir = findCacheDir({ name: \"prettier\", create: true });","path":"src/cli/util.js","position":3,"original_position":3,"commit_id":"5c2f25b0e5acf4a1b3d575e1af160a7d1f356adf","original_commit_id":"5c2f25b0e5acf4a1b3d575e1af160a7d1f356adf","user":{"login":"g-harel","id":9319710,"node_id":"MDQ6VXNlcjkzMTk3MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9319710?v=4","gravatar_id":"","url":"https://api.github.com/users/g-harel","html_url":"https://github.com/g-harel","followers_url":"https://api.github.com/users/g-harel/followers","following_url":"https://api.github.com/users/g-harel/following{/other_user}","gists_url":"https://api.github.com/users/g-harel/gists{/gist_id}","starred_url":"https://api.github.com/users/g-harel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-harel/subscriptions","organizations_url":"https://api.github.com/users/g-harel/orgs","repos_url":"https://api.github.com/users/g-harel/repos","events_url":"https://api.github.com/users/g-harel/events{/privacy}","received_events_url":"https://api.github.com/users/g-harel/received_events","type":"User","site_admin":false},"body":"If I'm reading this correctly, this would write the cache to a unique temporary directory every time it runs. This would defeat the purpose of the writing the cache since it will not be ready the next time it runs.","created_at":"2019-07-23T14:00:50Z","updated_at":"2019-07-23T14:00:50Z","html_url":"https://github.com/prettier/prettier/pull/6327#discussion_r306335098","pull_request_url":"https://api.github.com/repos/prettier/prettier/pulls/6327","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prettier/prettier/pulls/comments/306335098"},"html":{"href":"https://github.com/prettier/prettier/pull/6327#discussion_r306335098"},"pull_request":{"href":"https://api.github.com/repos/prettier/prettier/pulls/6327"}},"in_reply_to_id":306229182},"pull_request":{"url":"https://api.github.com/repos/prettier/prettier/pulls/6327","id":300089247,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMDg5MjQ3","html_url":"https://github.com/prettier/prettier/pull/6327","diff_url":"https://github.com/prettier/prettier/pull/6327.diff","patch_url":"https://github.com/prettier/prettier/pull/6327.patch","issue_url":"https://api.github.com/repos/prettier/prettier/issues/6327","number":6327,"state":"open","locked":false,"title":"Handle missing cache directory for changedCache","user":{"login":"g-harel","id":9319710,"node_id":"MDQ6VXNlcjkzMTk3MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9319710?v=4","gravatar_id":"","url":"https://api.github.com/users/g-harel","html_url":"https://github.com/g-harel","followers_url":"https://api.github.com/users/g-harel/followers","following_url":"https://api.github.com/users/g-harel/following{/other_user}","gists_url":"https://api.github.com/users/g-harel/gists{/gist_id}","starred_url":"https://api.github.com/users/g-harel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-harel/subscriptions","organizations_url":"https://api.github.com/users/g-harel/orgs","repos_url":"https://api.github.com/users/g-harel/repos","events_url":"https://api.github.com/users/g-harel/events{/privacy}","received_events_url":"https://api.github.com/users/g-harel/received_events","type":"User","site_admin":false},"body":"<!-- Please provide a brief summary of your changes: -->\r\n\r\nSmall patch to check that the cache directory was found before initializing the `changedCache`.\r\n\r\nhttps://github.com/prettier/prettier/pull/5910#discussion_r305870825\r\n\r\n<!-- Please ensure you’ve done all of these things (if applicable). -->\r\n<!-- You can replace the `[ ]` with `[x]` to mark each task as done. -->\r\n\r\n- [ ] I’ve added tests to confirm my change works.\r\n- [x] (If changing the API or CLI) I’ve documented the changes I’ve made (in the `docs/` directory)\r\n- [x] (If the change is user-facing) I’ve added my changes to the `CHANGELOG.unreleased.md` file following the template.\r\n- [x] I’ve read the [contributing guidelines](https://github.com/prettier/prettier/blob/master/CONTRIBUTING.md).\r\n\r\n**✨[Try the playground for this PR](https://prettier.io/playground-redirect)✨**\r\n","created_at":"2019-07-23T00:50:13Z","updated_at":"2019-07-23T14:00:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4f9366d54edb3a0d549df6ad92135f82c8cfc00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prettier/prettier/pulls/6327/commits","review_comments_url":"https://api.github.com/repos/prettier/prettier/pulls/6327/comments","review_comment_url":"https://api.github.com/repos/prettier/prettier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prettier/prettier/issues/6327/comments","statuses_url":"https://api.github.com/repos/prettier/prettier/statuses/5c2f25b0e5acf4a1b3d575e1af160a7d1f356adf","head":{"label":"g-harel:only-changed-undefined","ref":"only-changed-undefined","sha":"5c2f25b0e5acf4a1b3d575e1af160a7d1f356adf","user":{"login":"g-harel","id":9319710,"node_id":"MDQ6VXNlcjkzMTk3MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9319710?v=4","gravatar_id":"","url":"https://api.github.com/users/g-harel","html_url":"https://github.com/g-harel","followers_url":"https://api.github.com/users/g-harel/followers","following_url":"https://api.github.com/users/g-harel/following{/other_user}","gists_url":"https://api.github.com/users/g-harel/gists{/gist_id}","starred_url":"https://api.github.com/users/g-harel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-harel/subscriptions","organizations_url":"https://api.github.com/users/g-harel/orgs","repos_url":"https://api.github.com/users/g-harel/repos","events_url":"https://api.github.com/users/g-harel/events{/privacy}","received_events_url":"https://api.github.com/users/g-harel/received_events","type":"User","site_admin":false},"repo":{"id":172125632,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIxMjU2MzI=","name":"prettier","full_name":"g-harel/prettier","private":false,"owner":{"login":"g-harel","id":9319710,"node_id":"MDQ6VXNlcjkzMTk3MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9319710?v=4","gravatar_id":"","url":"https://api.github.com/users/g-harel","html_url":"https://github.com/g-harel","followers_url":"https://api.github.com/users/g-harel/followers","following_url":"https://api.github.com/users/g-harel/following{/other_user}","gists_url":"https://api.github.com/users/g-harel/gists{/gist_id}","starred_url":"https://api.github.com/users/g-harel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-harel/subscriptions","organizations_url":"https://api.github.com/users/g-harel/orgs","repos_url":"https://api.github.com/users/g-harel/repos","events_url":"https://api.github.com/users/g-harel/events{/privacy}","received_events_url":"https://api.github.com/users/g-harel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/g-harel/prettier","description":"Prettier is an opinionated code formatter.","fork":true,"url":"https://api.github.com/repos/g-harel/prettier","forks_url":"https://api.github.com/repos/g-harel/prettier/forks","keys_url":"https://api.github.com/repos/g-harel/prettier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/g-harel/prettier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/g-harel/prettier/teams","hooks_url":"https://api.github.com/repos/g-harel/prettier/hooks","issue_events_url":"https://api.github.com/repos/g-harel/prettier/issues/events{/number}","events_url":"https://api.github.com/repos/g-harel/prettier/events","assignees_url":"https://api.github.com/repos/g-harel/prettier/assignees{/user}","branches_url":"https://api.github.com/repos/g-harel/prettier/branches{/branch}","tags_url":"https://api.github.com/repos/g-harel/prettier/tags","blobs_url":"https://api.github.com/repos/g-harel/prettier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/g-harel/prettier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/g-harel/prettier/git/refs{/sha}","trees_url":"https://api.github.com/repos/g-harel/prettier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/g-harel/prettier/statuses/{sha}","languages_url":"https://api.github.com/repos/g-harel/prettier/languages","stargazers_url":"https://api.github.com/repos/g-harel/prettier/stargazers","contributors_url":"https://api.github.com/repos/g-harel/prettier/contributors","subscribers_url":"https://api.github.com/repos/g-harel/prettier/subscribers","subscription_url":"https://api.github.com/repos/g-harel/prettier/subscription","commits_url":"https://api.github.com/repos/g-harel/prettier/commits{/sha}","git_commits_url":"https://api.github.com/repos/g-harel/prettier/git/commits{/sha}","comments_url":"https://api.github.com/repos/g-harel/prettier/comments{/number}","issue_comment_url":"https://api.github.com/repos/g-harel/prettier/issues/comments{/number}","contents_url":"https://api.github.com/repos/g-harel/prettier/contents/{+path}","compare_url":"https://api.github.com/repos/g-harel/prettier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/g-harel/prettier/merges","archive_url":"https://api.github.com/repos/g-harel/prettier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/g-harel/prettier/downloads","issues_url":"https://api.github.com/repos/g-harel/prettier/issues{/number}","pulls_url":"https://api.github.com/repos/g-harel/prettier/pulls{/number}","milestones_url":"https://api.github.com/repos/g-harel/prettier/milestones{/number}","notifications_url":"https://api.github.com/repos/g-harel/prettier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/g-harel/prettier/labels{/name}","releases_url":"https://api.github.com/repos/g-harel/prettier/releases{/id}","deployments_url":"https://api.github.com/repos/g-harel/prettier/deployments","created_at":"2019-02-22T19:47:15Z","updated_at":"2019-07-23T00:24:07Z","pushed_at":"2019-07-23T00:47:55Z","git_url":"git://github.com/g-harel/prettier.git","ssh_url":"git@github.com:g-harel/prettier.git","clone_url":"https://github.com/g-harel/prettier.git","svn_url":"https://github.com/g-harel/prettier","homepage":"https://prettier.io","size":29959,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prettier:master","ref":"master","sha":"6fae09b67ec6f7b27259a5c133a6961d05a4161b","user":{"login":"prettier","id":25822731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODIyNzMx","avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"repo":{"id":75104123,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEwNDEyMw==","name":"prettier","full_name":"prettier/prettier","private":false,"owner":{"login":"prettier","id":25822731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODIyNzMx","avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prettier/prettier","description":"Prettier is an opinionated code formatter.","fork":false,"url":"https://api.github.com/repos/prettier/prettier","forks_url":"https://api.github.com/repos/prettier/prettier/forks","keys_url":"https://api.github.com/repos/prettier/prettier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prettier/prettier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prettier/prettier/teams","hooks_url":"https://api.github.com/repos/prettier/prettier/hooks","issue_events_url":"https://api.github.com/repos/prettier/prettier/issues/events{/number}","events_url":"https://api.github.com/repos/prettier/prettier/events","assignees_url":"https://api.github.com/repos/prettier/prettier/assignees{/user}","branches_url":"https://api.github.com/repos/prettier/prettier/branches{/branch}","tags_url":"https://api.github.com/repos/prettier/prettier/tags","blobs_url":"https://api.github.com/repos/prettier/prettier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prettier/prettier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prettier/prettier/git/refs{/sha}","trees_url":"https://api.github.com/repos/prettier/prettier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prettier/prettier/statuses/{sha}","languages_url":"https://api.github.com/repos/prettier/prettier/languages","stargazers_url":"https://api.github.com/repos/prettier/prettier/stargazers","contributors_url":"https://api.github.com/repos/prettier/prettier/contributors","subscribers_url":"https://api.github.com/repos/prettier/prettier/subscribers","subscription_url":"https://api.github.com/repos/prettier/prettier/subscription","commits_url":"https://api.github.com/repos/prettier/prettier/commits{/sha}","git_commits_url":"https://api.github.com/repos/prettier/prettier/git/commits{/sha}","comments_url":"https://api.github.com/repos/prettier/prettier/comments{/number}","issue_comment_url":"https://api.github.com/repos/prettier/prettier/issues/comments{/number}","contents_url":"https://api.github.com/repos/prettier/prettier/contents/{+path}","compare_url":"https://api.github.com/repos/prettier/prettier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prettier/prettier/merges","archive_url":"https://api.github.com/repos/prettier/prettier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prettier/prettier/downloads","issues_url":"https://api.github.com/repos/prettier/prettier/issues{/number}","pulls_url":"https://api.github.com/repos/prettier/prettier/pulls{/number}","milestones_url":"https://api.github.com/repos/prettier/prettier/milestones{/number}","notifications_url":"https://api.github.com/repos/prettier/prettier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prettier/prettier/labels{/name}","releases_url":"https://api.github.com/repos/prettier/prettier/releases{/id}","deployments_url":"https://api.github.com/repos/prettier/prettier/deployments","created_at":"2016-11-29T17:13:37Z","updated_at":"2019-07-23T13:51:19Z","pushed_at":"2019-07-23T00:50:14Z","git_url":"git://github.com/prettier/prettier.git","ssh_url":"git@github.com:prettier/prettier.git","clone_url":"https://github.com/prettier/prettier.git","svn_url":"https://github.com/prettier/prettier","homepage":"https://prettier.io","size":29892,"stargazers_count":32852,"watchers_count":32852,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1835,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":666,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1835,"open_issues":666,"watchers":32852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prettier/prettier/pulls/6327"},"html":{"href":"https://github.com/prettier/prettier/pull/6327"},"issue":{"href":"https://api.github.com/repos/prettier/prettier/issues/6327"},"comments":{"href":"https://api.github.com/repos/prettier/prettier/issues/6327/comments"},"review_comments":{"href":"https://api.github.com/repos/prettier/prettier/pulls/6327/comments"},"review_comment":{"href":"https://api.github.com/repos/prettier/prettier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prettier/prettier/pulls/6327/commits"},"statuses":{"href":"https://api.github.com/repos/prettier/prettier/statuses/5c2f25b0e5acf4a1b3d575e1af160a7d1f356adf"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 75104123,
"name": "prettier/prettier",
"url": "https://api.github.com/repos/prettier/prettier"
}
|
{
"id": 9319710,
"login": "g-harel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9319710?",
"url": "https://api.github.com/users/g-harel"
}
|
{
"id": 25822731,
"login": "prettier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25822731?",
"url": "https://api.github.com/orgs/prettier"
}
| 2019-07-23T14:00:50 |
10066806107
|
{"actor":{"display_login":"g-harel"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/VSChina/magic-modules/pulls/comments/313195085","pull_request_review_id":274030531,"id":313195085,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzE5NTA4NQ==","diff_hunk":"@@ -11,13 +11,37 @@ def get_example_properties_to_check(example_name, object)\n params = param_props.map{|p| p.name.underscore}.to_set\n \n example = get_example_by_names(example_name)\n- example.properties\n+ example_props = example.properties\n .reject do |pn, pv|\n params.include?(pn) || pn == 'location'\n end\n .transform_values do |v|\n v.is_a?(String) && !v.match(/\\$\\{.+\\}/).nil? ? :AttrSet : v\n end\n+ flatten_example_properties_to_check(example_props, true)\n+ end\n+\n+ def flatten_example_properties_to_check(properties, is_nested)","path":"provider/azure/terraform/example/helpers.rb","position":15,"original_position":15,"commit_id":"d2c33a78740115fdba0eb578f5b2d8e701d1e502","original_commit_id":"d2c33a78740115fdba0eb578f5b2d8e701d1e502","user":{"login":"houkms","id":52267283,"node_id":"MDQ6VXNlcjUyMjY3Mjgz","avatar_url":"https://avatars3.githubusercontent.com/u/52267283?v=4","gravatar_id":"","url":"https://api.github.com/users/houkms","html_url":"https://github.com/houkms","followers_url":"https://api.github.com/users/houkms/followers","following_url":"https://api.github.com/users/houkms/following{/other_user}","gists_url":"https://api.github.com/users/houkms/gists{/gist_id}","starred_url":"https://api.github.com/users/houkms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houkms/subscriptions","organizations_url":"https://api.github.com/users/houkms/orgs","repos_url":"https://api.github.com/users/houkms/repos","events_url":"https://api.github.com/users/houkms/events{/privacy}","received_events_url":"https://api.github.com/users/houkms/received_events","type":"User","site_admin":false},"body":"Yes, and it's changed to be `has_nested_item`","created_at":"2019-08-13T01:57:39Z","updated_at":"2019-08-13T01:57:39Z","html_url":"https://github.com/VSChina/magic-modules/pull/13#discussion_r313195085","pull_request_url":"https://api.github.com/repos/VSChina/magic-modules/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/VSChina/magic-modules/pulls/comments/313195085"},"html":{"href":"https://github.com/VSChina/magic-modules/pull/13#discussion_r313195085"},"pull_request":{"href":"https://api.github.com/repos/VSChina/magic-modules/pulls/13"}},"in_reply_to_id":313092833},"pull_request":{"url":"https://api.github.com/repos/VSChina/magic-modules/pulls/13","id":304542151,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0NTQyMTUx","html_url":"https://github.com/VSChina/magic-modules/pull/13","diff_url":"https://github.com/VSChina/magic-modules/pull/13.diff","patch_url":"https://github.com/VSChina/magic-modules/pull/13.patch","issue_url":"https://api.github.com/repos/VSChina/magic-modules/issues/13","number":13,"state":"open","locked":false,"title":"Fix some minor issues in Go codes templates","user":{"login":"houkms","id":52267283,"node_id":"MDQ6VXNlcjUyMjY3Mjgz","avatar_url":"https://avatars3.githubusercontent.com/u/52267283?v=4","gravatar_id":"","url":"https://api.github.com/users/houkms","html_url":"https://github.com/houkms","followers_url":"https://api.github.com/users/houkms/followers","following_url":"https://api.github.com/users/houkms/following{/other_user}","gists_url":"https://api.github.com/users/houkms/gists{/gist_id}","starred_url":"https://api.github.com/users/houkms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houkms/subscriptions","organizations_url":"https://api.github.com/users/houkms/orgs","repos_url":"https://api.github.com/users/houkms/repos","events_url":"https://api.github.com/users/houkms/events{/privacy}","received_events_url":"https://api.github.com/users/houkms/received_events","type":"User","site_admin":false},"body":"Fix some minor issues in Go codes templates.\r\n","created_at":"2019-08-06T04:24:15Z","updated_at":"2019-08-13T01:57:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"681a59b1538855ce67815586b651c619c571ecc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VSChina/magic-modules/pulls/13/commits","review_comments_url":"https://api.github.com/repos/VSChina/magic-modules/pulls/13/comments","review_comment_url":"https://api.github.com/repos/VSChina/magic-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VSChina/magic-modules/issues/13/comments","statuses_url":"https://api.github.com/repos/VSChina/magic-modules/statuses/d2c33a78740115fdba0eb578f5b2d8e701d1e502","head":{"label":"houkms:houk-fixtemplates","ref":"houk-fixtemplates","sha":"d2c33a78740115fdba0eb578f5b2d8e701d1e502","user":{"login":"houkms","id":52267283,"node_id":"MDQ6VXNlcjUyMjY3Mjgz","avatar_url":"https://avatars3.githubusercontent.com/u/52267283?v=4","gravatar_id":"","url":"https://api.github.com/users/houkms","html_url":"https://github.com/houkms","followers_url":"https://api.github.com/users/houkms/followers","following_url":"https://api.github.com/users/houkms/following{/other_user}","gists_url":"https://api.github.com/users/houkms/gists{/gist_id}","starred_url":"https://api.github.com/users/houkms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houkms/subscriptions","organizations_url":"https://api.github.com/users/houkms/orgs","repos_url":"https://api.github.com/users/houkms/repos","events_url":"https://api.github.com/users/houkms/events{/privacy}","received_events_url":"https://api.github.com/users/houkms/received_events","type":"User","site_admin":false},"repo":{"id":194012433,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQwMTI0MzM=","name":"magic-modules","full_name":"houkms/magic-modules","private":false,"owner":{"login":"houkms","id":52267283,"node_id":"MDQ6VXNlcjUyMjY3Mjgz","avatar_url":"https://avatars3.githubusercontent.com/u/52267283?v=4","gravatar_id":"","url":"https://api.github.com/users/houkms","html_url":"https://github.com/houkms","followers_url":"https://api.github.com/users/houkms/followers","following_url":"https://api.github.com/users/houkms/following{/other_user}","gists_url":"https://api.github.com/users/houkms/gists{/gist_id}","starred_url":"https://api.github.com/users/houkms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houkms/subscriptions","organizations_url":"https://api.github.com/users/houkms/orgs","repos_url":"https://api.github.com/users/houkms/repos","events_url":"https://api.github.com/users/houkms/events{/privacy}","received_events_url":"https://api.github.com/users/houkms/received_events","type":"User","site_admin":false},"html_url":"https://github.com/houkms/magic-modules","description":"Magic Modules: Automagically generate Google Cloud Platform support for OSS","fork":true,"url":"https://api.github.com/repos/houkms/magic-modules","forks_url":"https://api.github.com/repos/houkms/magic-modules/forks","keys_url":"https://api.github.com/repos/houkms/magic-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/houkms/magic-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/houkms/magic-modules/teams","hooks_url":"https://api.github.com/repos/houkms/magic-modules/hooks","issue_events_url":"https://api.github.com/repos/houkms/magic-modules/issues/events{/number}","events_url":"https://api.github.com/repos/houkms/magic-modules/events","assignees_url":"https://api.github.com/repos/houkms/magic-modules/assignees{/user}","branches_url":"https://api.github.com/repos/houkms/magic-modules/branches{/branch}","tags_url":"https://api.github.com/repos/houkms/magic-modules/tags","blobs_url":"https://api.github.com/repos/houkms/magic-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/houkms/magic-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/houkms/magic-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/houkms/magic-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/houkms/magic-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/houkms/magic-modules/languages","stargazers_url":"https://api.github.com/repos/houkms/magic-modules/stargazers","contributors_url":"https://api.github.com/repos/houkms/magic-modules/contributors","subscribers_url":"https://api.github.com/repos/houkms/magic-modules/subscribers","subscription_url":"https://api.github.com/repos/houkms/magic-modules/subscription","commits_url":"https://api.github.com/repos/houkms/magic-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/houkms/magic-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/houkms/magic-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/houkms/magic-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/houkms/magic-modules/contents/{+path}","compare_url":"https://api.github.com/repos/houkms/magic-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/houkms/magic-modules/merges","archive_url":"https://api.github.com/repos/houkms/magic-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/houkms/magic-modules/downloads","issues_url":"https://api.github.com/repos/houkms/magic-modules/issues{/number}","pulls_url":"https://api.github.com/repos/houkms/magic-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/houkms/magic-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/houkms/magic-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/houkms/magic-modules/labels{/name}","releases_url":"https://api.github.com/repos/houkms/magic-modules/releases{/id}","deployments_url":"https://api.github.com/repos/houkms/magic-modules/deployments","created_at":"2019-06-27T02:57:37Z","updated_at":"2019-06-27T02:57:41Z","pushed_at":"2019-08-12T16:48:05Z","git_url":"git://github.com/houkms/magic-modules.git","ssh_url":"git@github.com:houkms/magic-modules.git","clone_url":"https://github.com/houkms/magic-modules.git","svn_url":"https://github.com/houkms/magic-modules","homepage":"","size":11936,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VSChina:azure_backend","ref":"azure_backend","sha":"cff643d601d5e7f6e7e47233f61122d642767943","user":{"login":"VSChina","id":25995662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTk1NjYy","avatar_url":"https://avatars3.githubusercontent.com/u/25995662?v=4","gravatar_id":"","url":"https://api.github.com/users/VSChina","html_url":"https://github.com/VSChina","followers_url":"https://api.github.com/users/VSChina/followers","following_url":"https://api.github.com/users/VSChina/following{/other_user}","gists_url":"https://api.github.com/users/VSChina/gists{/gist_id}","starred_url":"https://api.github.com/users/VSChina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSChina/subscriptions","organizations_url":"https://api.github.com/users/VSChina/orgs","repos_url":"https://api.github.com/users/VSChina/repos","events_url":"https://api.github.com/users/VSChina/events{/privacy}","received_events_url":"https://api.github.com/users/VSChina/received_events","type":"Organization","site_admin":false},"repo":{"id":160884960,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4ODQ5NjA=","name":"magic-modules","full_name":"VSChina/magic-modules","private":false,"owner":{"login":"VSChina","id":25995662,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTk1NjYy","avatar_url":"https://avatars3.githubusercontent.com/u/25995662?v=4","gravatar_id":"","url":"https://api.github.com/users/VSChina","html_url":"https://github.com/VSChina","followers_url":"https://api.github.com/users/VSChina/followers","following_url":"https://api.github.com/users/VSChina/following{/other_user}","gists_url":"https://api.github.com/users/VSChina/gists{/gist_id}","starred_url":"https://api.github.com/users/VSChina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSChina/subscriptions","organizations_url":"https://api.github.com/users/VSChina/orgs","repos_url":"https://api.github.com/users/VSChina/repos","events_url":"https://api.github.com/users/VSChina/events{/privacy}","received_events_url":"https://api.github.com/users/VSChina/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VSChina/magic-modules","description":"Magic Modules: Automagically generate Google Cloud Platform support for OSS","fork":true,"url":"https://api.github.com/repos/VSChina/magic-modules","forks_url":"https://api.github.com/repos/VSChina/magic-modules/forks","keys_url":"https://api.github.com/repos/VSChina/magic-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSChina/magic-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSChina/magic-modules/teams","hooks_url":"https://api.github.com/repos/VSChina/magic-modules/hooks","issue_events_url":"https://api.github.com/repos/VSChina/magic-modules/issues/events{/number}","events_url":"https://api.github.com/repos/VSChina/magic-modules/events","assignees_url":"https://api.github.com/repos/VSChina/magic-modules/assignees{/user}","branches_url":"https://api.github.com/repos/VSChina/magic-modules/branches{/branch}","tags_url":"https://api.github.com/repos/VSChina/magic-modules/tags","blobs_url":"https://api.github.com/repos/VSChina/magic-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSChina/magic-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSChina/magic-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSChina/magic-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSChina/magic-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/VSChina/magic-modules/languages","stargazers_url":"https://api.github.com/repos/VSChina/magic-modules/stargazers","contributors_url":"https://api.github.com/repos/VSChina/magic-modules/contributors","subscribers_url":"https://api.github.com/repos/VSChina/magic-modules/subscribers","subscription_url":"https://api.github.com/repos/VSChina/magic-modules/subscription","commits_url":"https://api.github.com/repos/VSChina/magic-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSChina/magic-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSChina/magic-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSChina/magic-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSChina/magic-modules/contents/{+path}","compare_url":"https://api.github.com/repos/VSChina/magic-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSChina/magic-modules/merges","archive_url":"https://api.github.com/repos/VSChina/magic-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSChina/magic-modules/downloads","issues_url":"https://api.github.com/repos/VSChina/magic-modules/issues{/number}","pulls_url":"https://api.github.com/repos/VSChina/magic-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/VSChina/magic-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/VSChina/magic-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSChina/magic-modules/labels{/name}","releases_url":"https://api.github.com/repos/VSChina/magic-modules/releases{/id}","deployments_url":"https://api.github.com/repos/VSChina/magic-modules/deployments","created_at":"2018-12-07T23:16:26Z","updated_at":"2019-07-22T21:13:30Z","pushed_at":"2019-08-13T01:24:08Z","git_url":"git://github.com/VSChina/magic-modules.git","ssh_url":"git@github.com:VSChina/magic-modules.git","clone_url":"https://github.com/VSChina/magic-modules.git","svn_url":"https://github.com/VSChina/magic-modules","homepage":"","size":11952,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VSChina/magic-modules/pulls/13"},"html":{"href":"https://github.com/VSChina/magic-modules/pull/13"},"issue":{"href":"https://api.github.com/repos/VSChina/magic-modules/issues/13"},"comments":{"href":"https://api.github.com/repos/VSChina/magic-modules/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/VSChina/magic-modules/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/VSChina/magic-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VSChina/magic-modules/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/VSChina/magic-modules/statuses/d2c33a78740115fdba0eb578f5b2d8e701d1e502"}},"author_association":"NONE"}}
|
{
"id": 160884960,
"name": "VSChina/magic-modules",
"url": "https://api.github.com/repos/VSChina/magic-modules"
}
|
{
"id": 52267283,
"login": "houkms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52267283?",
"url": "https://api.github.com/users/houkms"
}
|
{
"id": 25995662,
"login": "VSChina",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25995662?",
"url": "https://api.github.com/orgs/VSChina"
}
| 2019-08-13T01:57:39 |
10197759792
|
{"actor":{"display_login":"houkms"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/comments/269620292","pull_request_review_id":219535536,"id":269620292,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTYyMDI5Mg==","diff_hunk":"@@ -0,0 +1,21 @@\n+window.app.modal = function(modalId) {","path":"static/js/app/modal.js","position":1,"original_position":1,"commit_id":"0e044936f13a85047c13f0b193b8f348e5035899","original_commit_id":"0e044936f13a85047c13f0b193b8f348e5035899","user":{"login":"hatched","id":532033,"node_id":"MDQ6VXNlcjUzMjAzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/532033?v=4","gravatar_id":"","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"body":"doc block, what is `modalId`?","created_at":"2019-03-27T15:22:35Z","updated_at":"2019-03-27T15:34:06Z","html_url":"https://github.com/canonical-websites/jaas.ai/pull/25#discussion_r269620292","pull_request_url":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/comments/269620292"},"html":{"href":"https://github.com/canonical-websites/jaas.ai/pull/25#discussion_r269620292"},"pull_request":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25","id":254331663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MzMxNjYz","html_url":"https://github.com/canonical-websites/jaas.ai/pull/25","diff_url":"https://github.com/canonical-websites/jaas.ai/pull/25.diff","patch_url":"https://github.com/canonical-websites/jaas.ai/pull/25.patch","issue_url":"https://api.github.com/repos/canonical-websites/jaas.ai/issues/25","number":25,"state":"open","locked":false,"title":"Lead generation modal for Spicule","user":{"login":"barrymcgee","id":505570,"node_id":"MDQ6VXNlcjUwNTU3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/505570?v=4","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"body":"## Done\r\n\r\nAdded lead generation form for Spicule\r\n\r\n## QA\r\n\r\n- Run feature branch\r\n- Run `./run serve`\r\n- View http://0.0.0.0:8029/experts/spicule\r\n- Click 'Get in touch'\r\n\r\n## Notes\r\n\r\n- This form still needs to be connected to Marketo so remains blocked.","created_at":"2019-02-19T16:54:39Z","updated_at":"2019-03-27T15:34:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a7b1a841978156a64d7da6597528c62eac7f681","assignee":{"login":"spencerbygraves","id":9105999,"node_id":"MDQ6VXNlcjkxMDU5OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/9105999?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerbygraves","html_url":"https://github.com/spencerbygraves","followers_url":"https://api.github.com/users/spencerbygraves/followers","following_url":"https://api.github.com/users/spencerbygraves/following{/other_user}","gists_url":"https://api.github.com/users/spencerbygraves/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerbygraves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerbygraves/subscriptions","organizations_url":"https://api.github.com/users/spencerbygraves/orgs","repos_url":"https://api.github.com/users/spencerbygraves/repos","events_url":"https://api.github.com/users/spencerbygraves/events{/privacy}","received_events_url":"https://api.github.com/users/spencerbygraves/received_events","type":"User","site_admin":false},"assignees":[{"login":"spencerbygraves","id":9105999,"node_id":"MDQ6VXNlcjkxMDU5OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/9105999?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerbygraves","html_url":"https://github.com/spencerbygraves","followers_url":"https://api.github.com/users/spencerbygraves/followers","following_url":"https://api.github.com/users/spencerbygraves/following{/other_user}","gists_url":"https://api.github.com/users/spencerbygraves/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerbygraves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerbygraves/subscriptions","organizations_url":"https://api.github.com/users/spencerbygraves/orgs","repos_url":"https://api.github.com/users/spencerbygraves/repos","events_url":"https://api.github.com/users/spencerbygraves/events{/privacy}","received_events_url":"https://api.github.com/users/spencerbygraves/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"clagom","id":1953388,"node_id":"MDQ6VXNlcjE5NTMzODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1953388?v=4","gravatar_id":"","url":"https://api.github.com/users/clagom","html_url":"https://github.com/clagom","followers_url":"https://api.github.com/users/clagom/followers","following_url":"https://api.github.com/users/clagom/following{/other_user}","gists_url":"https://api.github.com/users/clagom/gists{/gist_id}","starred_url":"https://api.github.com/users/clagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clagom/subscriptions","organizations_url":"https://api.github.com/users/clagom/orgs","repos_url":"https://api.github.com/users/clagom/repos","events_url":"https://api.github.com/users/clagom/events{/privacy}","received_events_url":"https://api.github.com/users/clagom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1026185389,"node_id":"MDU6TGFiZWwxMDI2MTg1Mzg5","url":"https://api.github.com/repos/canonical-websites/jaas.ai/labels/Review:%20Code%20needed","name":"Review: Code needed","color":"cdcdcd","default":false},{"id":1026185392,"node_id":"MDU6TGFiZWwxMDI2MTg1Mzky","url":"https://api.github.com/repos/canonical-websites/jaas.ai/labels/Review:%20Design%20+1","name":"Review: Design +1","color":"38b44a","default":false},{"id":1026185379,"node_id":"MDU6TGFiZWwxMDI2MTg1Mzc5","url":"https://api.github.com/repos/canonical-websites/jaas.ai/labels/Review:%20QA%20needed","name":"Review: QA needed","color":"cdcdcd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25/commits","review_comments_url":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25/comments","review_comment_url":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical-websites/jaas.ai/issues/25/comments","statuses_url":"https://api.github.com/repos/canonical-websites/jaas.ai/statuses/0e044936f13a85047c13f0b193b8f348e5035899","head":{"label":"barrymcgee:lead-gen-modal-forms","ref":"lead-gen-modal-forms","sha":"0e044936f13a85047c13f0b193b8f348e5035899","user":{"login":"barrymcgee","id":505570,"node_id":"MDQ6VXNlcjUwNTU3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/505570?v=4","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"repo":{"id":144001174,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwMDExNzQ=","name":"jaas.ai","full_name":"barrymcgee/jaas.ai","private":false,"owner":{"login":"barrymcgee","id":505570,"node_id":"MDQ6VXNlcjUwNTU3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/505570?v=4","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/barrymcgee/jaas.ai","description":null,"fork":true,"url":"https://api.github.com/repos/barrymcgee/jaas.ai","forks_url":"https://api.github.com/repos/barrymcgee/jaas.ai/forks","keys_url":"https://api.github.com/repos/barrymcgee/jaas.ai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barrymcgee/jaas.ai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barrymcgee/jaas.ai/teams","hooks_url":"https://api.github.com/repos/barrymcgee/jaas.ai/hooks","issue_events_url":"https://api.github.com/repos/barrymcgee/jaas.ai/issues/events{/number}","events_url":"https://api.github.com/repos/barrymcgee/jaas.ai/events","assignees_url":"https://api.github.com/repos/barrymcgee/jaas.ai/assignees{/user}","branches_url":"https://api.github.com/repos/barrymcgee/jaas.ai/branches{/branch}","tags_url":"https://api.github.com/repos/barrymcgee/jaas.ai/tags","blobs_url":"https://api.github.com/repos/barrymcgee/jaas.ai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barrymcgee/jaas.ai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barrymcgee/jaas.ai/git/refs{/sha}","trees_url":"https://api.github.com/repos/barrymcgee/jaas.ai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barrymcgee/jaas.ai/statuses/{sha}","languages_url":"https://api.github.com/repos/barrymcgee/jaas.ai/languages","stargazers_url":"https://api.github.com/repos/barrymcgee/jaas.ai/stargazers","contributors_url":"https://api.github.com/repos/barrymcgee/jaas.ai/contributors","subscribers_url":"https://api.github.com/repos/barrymcgee/jaas.ai/subscribers","subscription_url":"https://api.github.com/repos/barrymcgee/jaas.ai/subscription","commits_url":"https://api.github.com/repos/barrymcgee/jaas.ai/commits{/sha}","git_commits_url":"https://api.github.com/repos/barrymcgee/jaas.ai/git/commits{/sha}","comments_url":"https://api.github.com/repos/barrymcgee/jaas.ai/comments{/number}","issue_comment_url":"https://api.github.com/repos/barrymcgee/jaas.ai/issues/comments{/number}","contents_url":"https://api.github.com/repos/barrymcgee/jaas.ai/contents/{+path}","compare_url":"https://api.github.com/repos/barrymcgee/jaas.ai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barrymcgee/jaas.ai/merges","archive_url":"https://api.github.com/repos/barrymcgee/jaas.ai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barrymcgee/jaas.ai/downloads","issues_url":"https://api.github.com/repos/barrymcgee/jaas.ai/issues{/number}","pulls_url":"https://api.github.com/repos/barrymcgee/jaas.ai/pulls{/number}","milestones_url":"https://api.github.com/repos/barrymcgee/jaas.ai/milestones{/number}","notifications_url":"https://api.github.com/repos/barrymcgee/jaas.ai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barrymcgee/jaas.ai/labels{/name}","releases_url":"https://api.github.com/repos/barrymcgee/jaas.ai/releases{/id}","deployments_url":"https://api.github.com/repos/barrymcgee/jaas.ai/deployments","created_at":"2018-08-08T10:59:58Z","updated_at":"2019-03-25T16:47:07Z","pushed_at":"2019-03-27T14:31:37Z","git_url":"git://github.com/barrymcgee/jaas.ai.git","ssh_url":"git@github.com:barrymcgee/jaas.ai.git","clone_url":"https://github.com/barrymcgee/jaas.ai.git","svn_url":"https://github.com/barrymcgee/jaas.ai","homepage":null,"size":5406,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"canonical-websites:master","ref":"master","sha":"3d769a010efe9fd8bbdb1c37b7ee93ca0bca09fc","user":{"login":"canonical-websites","id":26072773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"repo":{"id":143756215,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NTYyMTU=","name":"jaas.ai","full_name":"canonical-websites/jaas.ai","private":false,"owner":{"login":"canonical-websites","id":26072773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/canonical-websites/jaas.ai","description":"Juju as a service","fork":false,"url":"https://api.github.com/repos/canonical-websites/jaas.ai","forks_url":"https://api.github.com/repos/canonical-websites/jaas.ai/forks","keys_url":"https://api.github.com/repos/canonical-websites/jaas.ai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-websites/jaas.ai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-websites/jaas.ai/teams","hooks_url":"https://api.github.com/repos/canonical-websites/jaas.ai/hooks","issue_events_url":"https://api.github.com/repos/canonical-websites/jaas.ai/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-websites/jaas.ai/events","assignees_url":"https://api.github.com/repos/canonical-websites/jaas.ai/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-websites/jaas.ai/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-websites/jaas.ai/tags","blobs_url":"https://api.github.com/repos/canonical-websites/jaas.ai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-websites/jaas.ai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-websites/jaas.ai/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-websites/jaas.ai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-websites/jaas.ai/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-websites/jaas.ai/languages","stargazers_url":"https://api.github.com/repos/canonical-websites/jaas.ai/stargazers","contributors_url":"https://api.github.com/repos/canonical-websites/jaas.ai/contributors","subscribers_url":"https://api.github.com/repos/canonical-websites/jaas.ai/subscribers","subscription_url":"https://api.github.com/repos/canonical-websites/jaas.ai/subscription","commits_url":"https://api.github.com/repos/canonical-websites/jaas.ai/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-websites/jaas.ai/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-websites/jaas.ai/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-websites/jaas.ai/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-websites/jaas.ai/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-websites/jaas.ai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-websites/jaas.ai/merges","archive_url":"https://api.github.com/repos/canonical-websites/jaas.ai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-websites/jaas.ai/downloads","issues_url":"https://api.github.com/repos/canonical-websites/jaas.ai/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-websites/jaas.ai/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-websites/jaas.ai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-websites/jaas.ai/labels{/name}","releases_url":"https://api.github.com/repos/canonical-websites/jaas.ai/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-websites/jaas.ai/deployments","created_at":"2018-08-06T16:40:45Z","updated_at":"2019-03-26T15:30:39Z","pushed_at":"2019-03-27T14:31:38Z","git_url":"git://github.com/canonical-websites/jaas.ai.git","ssh_url":"git@github.com:canonical-websites/jaas.ai.git","clone_url":"https://github.com/canonical-websites/jaas.ai.git","svn_url":"https://github.com/canonical-websites/jaas.ai","homepage":"https://jaas.ai/","size":5342,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":8,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25"},"html":{"href":"https://github.com/canonical-websites/jaas.ai/pull/25"},"issue":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/issues/25"},"comments":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/canonical-websites/jaas.ai/statuses/0e044936f13a85047c13f0b193b8f348e5035899"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 143756215,
"name": "canonical-websites/jaas.ai",
"url": "https://api.github.com/repos/canonical-websites/jaas.ai"
}
|
{
"id": 532033,
"login": "hatched",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/532033?",
"url": "https://api.github.com/users/hatched"
}
|
{
"id": 26072773,
"login": "canonical-websites",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26072773?",
"url": "https://api.github.com/orgs/canonical-websites"
}
| 2019-03-27T15:22:35 |
9325705365
|
{"actor":{"display_login":"hatched"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/comments/279254502","pull_request_review_id":231537124,"id":279254502,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTI1NDUwMg==","diff_hunk":"@@ -0,0 +1,46 @@\n+**To migrate data from STH-Comet to QuantumLeap**\n+\n+Fiware GE STH-Comet support NGSIv1 while QuantumLeap support NGSIv2. As NGSIv1 is being deprecated from Fiware Orion so using QuantumLeap will be preferred.\n+If we need to store data that was previously in STH-Comet to QuantumLeap we will have to follow the following steps:\n+\n+1. Exporting Data from MongoDB\n+2. Adding Data into CrateDB\n+\n+Migration-0.0.1-SNAPSHOT.jar file can be used to perform above task automatically. \n+\n+Jar file have dependency over ```application.properties``` , ```convert_json.py``` and ```dependency-jars``` to present at the same location as that of jar.\n+\n+To run the jar user will have to configure following parameters in application.properties file:","path":"docs/manuals/user/dataMigrationFromSth-cometToQL/README.md","position":13,"original_position":13,"commit_id":"7f58b625814ab18b7e6a9e1ff934351eedc5e543","original_commit_id":"7f58b625814ab18b7e6a9e1ff934351eedc5e543","user":{"login":"taliaga","id":4542117,"node_id":"MDQ6VXNlcjQ1NDIxMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4542117?v=4","gravatar_id":"","url":"https://api.github.com/users/taliaga","html_url":"https://github.com/taliaga","followers_url":"https://api.github.com/users/taliaga/followers","following_url":"https://api.github.com/users/taliaga/following{/other_user}","gists_url":"https://api.github.com/users/taliaga/gists{/gist_id}","starred_url":"https://api.github.com/users/taliaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taliaga/subscriptions","organizations_url":"https://api.github.com/users/taliaga/orgs","repos_url":"https://api.github.com/users/taliaga/repos","events_url":"https://api.github.com/users/taliaga/events{/privacy}","received_events_url":"https://api.github.com/users/taliaga/received_events","type":"User","site_admin":false},"body":"The docs so far implies some prior-knowledge about what the `application.properties` file is. Some people might not even work with Java :). You don't need to explain everything here, but I'd suggest adding something like: \"this tool is based on language X framework Y, and these are the links to the info you need to know in order to use this tool\"","created_at":"2019-04-29T07:14:30Z","updated_at":"2019-04-29T07:24:47Z","html_url":"https://github.com/smartsdk/ngsi-timeseries-api/pull/181#discussion_r279254502","pull_request_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/comments/279254502"},"html":{"href":"https://github.com/smartsdk/ngsi-timeseries-api/pull/181#discussion_r279254502"},"pull_request":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181","id":273869920,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczODY5OTIw","html_url":"https://github.com/smartsdk/ngsi-timeseries-api/pull/181","diff_url":"https://github.com/smartsdk/ngsi-timeseries-api/pull/181.diff","patch_url":"https://github.com/smartsdk/ngsi-timeseries-api/pull/181.patch","issue_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/issues/181","number":181,"state":"open","locked":false,"title":"Solution for #180","user":{"login":"pooja1pathak","id":33315652,"node_id":"MDQ6VXNlcjMzMzE1NjUy","avatar_url":"https://avatars0.githubusercontent.com/u/33315652?v=4","gravatar_id":"","url":"https://api.github.com/users/pooja1pathak","html_url":"https://github.com/pooja1pathak","followers_url":"https://api.github.com/users/pooja1pathak/followers","following_url":"https://api.github.com/users/pooja1pathak/following{/other_user}","gists_url":"https://api.github.com/users/pooja1pathak/gists{/gist_id}","starred_url":"https://api.github.com/users/pooja1pathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pooja1pathak/subscriptions","organizations_url":"https://api.github.com/users/pooja1pathak/orgs","repos_url":"https://api.github.com/users/pooja1pathak/repos","events_url":"https://api.github.com/users/pooja1pathak/events{/privacy}","received_events_url":"https://api.github.com/users/pooja1pathak/received_events","type":"User","site_admin":false},"body":"Added code, jar file, dependencies to automate data migration from STH-Comet to QuantumLeap","created_at":"2019-04-26T11:57:21Z","updated_at":"2019-04-29T07:24:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf5af79c202ad7c9b06d02fe931039fe645c3c79","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181/commits","review_comments_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181/comments","review_comment_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/issues/181/comments","statuses_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/statuses/7f58b625814ab18b7e6a9e1ff934351eedc5e543","head":{"label":"pooja1pathak:master","ref":"master","sha":"7f58b625814ab18b7e6a9e1ff934351eedc5e543","user":{"login":"pooja1pathak","id":33315652,"node_id":"MDQ6VXNlcjMzMzE1NjUy","avatar_url":"https://avatars0.githubusercontent.com/u/33315652?v=4","gravatar_id":"","url":"https://api.github.com/users/pooja1pathak","html_url":"https://github.com/pooja1pathak","followers_url":"https://api.github.com/users/pooja1pathak/followers","following_url":"https://api.github.com/users/pooja1pathak/following{/other_user}","gists_url":"https://api.github.com/users/pooja1pathak/gists{/gist_id}","starred_url":"https://api.github.com/users/pooja1pathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pooja1pathak/subscriptions","organizations_url":"https://api.github.com/users/pooja1pathak/orgs","repos_url":"https://api.github.com/users/pooja1pathak/repos","events_url":"https://api.github.com/users/pooja1pathak/events{/privacy}","received_events_url":"https://api.github.com/users/pooja1pathak/received_events","type":"User","site_admin":false},"repo":{"id":180548992,"node_id":"MDEwOlJlcG9zaXRvcnkxODA1NDg5OTI=","name":"ngsi-timeseries-api","full_name":"pooja1pathak/ngsi-timeseries-api","private":false,"owner":{"login":"pooja1pathak","id":33315652,"node_id":"MDQ6VXNlcjMzMzE1NjUy","avatar_url":"https://avatars0.githubusercontent.com/u/33315652?v=4","gravatar_id":"","url":"https://api.github.com/users/pooja1pathak","html_url":"https://github.com/pooja1pathak","followers_url":"https://api.github.com/users/pooja1pathak/followers","following_url":"https://api.github.com/users/pooja1pathak/following{/other_user}","gists_url":"https://api.github.com/users/pooja1pathak/gists{/gist_id}","starred_url":"https://api.github.com/users/pooja1pathak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pooja1pathak/subscriptions","organizations_url":"https://api.github.com/users/pooja1pathak/orgs","repos_url":"https://api.github.com/users/pooja1pathak/repos","events_url":"https://api.github.com/users/pooja1pathak/events{/privacy}","received_events_url":"https://api.github.com/users/pooja1pathak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pooja1pathak/ngsi-timeseries-api","description":"QuantumLeap: a FIWARE Generic Enabler to support the usage of NGSIv2 data in time-series databases","fork":true,"url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api","forks_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/forks","keys_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/teams","hooks_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/hooks","issue_events_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/issues/events{/number}","events_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/events","assignees_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/assignees{/user}","branches_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/branches{/branch}","tags_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/tags","blobs_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/statuses/{sha}","languages_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/languages","stargazers_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/stargazers","contributors_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/contributors","subscribers_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/subscribers","subscription_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/subscription","commits_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/contents/{+path}","compare_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/merges","archive_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/downloads","issues_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/issues{/number}","pulls_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/pulls{/number}","milestones_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/milestones{/number}","notifications_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/labels{/name}","releases_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/releases{/id}","deployments_url":"https://api.github.com/repos/pooja1pathak/ngsi-timeseries-api/deployments","created_at":"2019-04-10T09:31:36Z","updated_at":"2019-04-26T11:53:57Z","pushed_at":"2019-04-26T11:53:55Z","git_url":"git://github.com/pooja1pathak/ngsi-timeseries-api.git","ssh_url":"git@github.com:pooja1pathak/ngsi-timeseries-api.git","clone_url":"https://github.com/pooja1pathak/ngsi-timeseries-api.git","svn_url":"https://github.com/pooja1pathak/ngsi-timeseries-api","homepage":"https://quantumleap.rtfd.io/","size":22135,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartsdk:master","ref":"master","sha":"f004386e566eb855f5bb4e5b4df1023c1def2a5e","user":{"login":"smartsdk","id":26279498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Mjc5NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/26279498?v=4","gravatar_id":"","url":"https://api.github.com/users/smartsdk","html_url":"https://github.com/smartsdk","followers_url":"https://api.github.com/users/smartsdk/followers","following_url":"https://api.github.com/users/smartsdk/following{/other_user}","gists_url":"https://api.github.com/users/smartsdk/gists{/gist_id}","starred_url":"https://api.github.com/users/smartsdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartsdk/subscriptions","organizations_url":"https://api.github.com/users/smartsdk/orgs","repos_url":"https://api.github.com/users/smartsdk/repos","events_url":"https://api.github.com/users/smartsdk/events{/privacy}","received_events_url":"https://api.github.com/users/smartsdk/received_events","type":"Organization","site_admin":false},"repo":{"id":84980837,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk4MDgzNw==","name":"ngsi-timeseries-api","full_name":"smartsdk/ngsi-timeseries-api","private":false,"owner":{"login":"smartsdk","id":26279498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Mjc5NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/26279498?v=4","gravatar_id":"","url":"https://api.github.com/users/smartsdk","html_url":"https://github.com/smartsdk","followers_url":"https://api.github.com/users/smartsdk/followers","following_url":"https://api.github.com/users/smartsdk/following{/other_user}","gists_url":"https://api.github.com/users/smartsdk/gists{/gist_id}","starred_url":"https://api.github.com/users/smartsdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartsdk/subscriptions","organizations_url":"https://api.github.com/users/smartsdk/orgs","repos_url":"https://api.github.com/users/smartsdk/repos","events_url":"https://api.github.com/users/smartsdk/events{/privacy}","received_events_url":"https://api.github.com/users/smartsdk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smartsdk/ngsi-timeseries-api","description":"QuantumLeap: a FIWARE Generic Enabler to support the usage of NGSIv2 data in time-series databases","fork":false,"url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api","forks_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/forks","keys_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/teams","hooks_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/hooks","issue_events_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/issues/events{/number}","events_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/events","assignees_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/assignees{/user}","branches_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/branches{/branch}","tags_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/tags","blobs_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/statuses/{sha}","languages_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/languages","stargazers_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/stargazers","contributors_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/contributors","subscribers_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/subscribers","subscription_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/subscription","commits_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/contents/{+path}","compare_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/merges","archive_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/downloads","issues_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/issues{/number}","pulls_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls{/number}","milestones_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/milestones{/number}","notifications_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/labels{/name}","releases_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/releases{/id}","deployments_url":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/deployments","created_at":"2017-03-14T17:57:45Z","updated_at":"2019-03-18T05:28:12Z","pushed_at":"2019-04-26T11:57:22Z","git_url":"git://github.com/smartsdk/ngsi-timeseries-api.git","ssh_url":"git@github.com:smartsdk/ngsi-timeseries-api.git","clone_url":"https://github.com/smartsdk/ngsi-timeseries-api.git","svn_url":"https://github.com/smartsdk/ngsi-timeseries-api","homepage":"https://quantumleap.rtfd.io/","size":10650,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":45,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181"},"html":{"href":"https://github.com/smartsdk/ngsi-timeseries-api/pull/181"},"issue":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/issues/181"},"comments":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/smartsdk/ngsi-timeseries-api/statuses/7f58b625814ab18b7e6a9e1ff934351eedc5e543"}},"author_association":"NONE"}}
|
{
"id": 84980837,
"name": "smartsdk/ngsi-timeseries-api",
"url": "https://api.github.com/repos/smartsdk/ngsi-timeseries-api"
}
|
{
"id": 4542117,
"login": "taliaga",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4542117?",
"url": "https://api.github.com/users/taliaga"
}
|
{
"id": 26279498,
"login": "smartsdk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26279498?",
"url": "https://api.github.com/orgs/smartsdk"
}
| 2019-04-29T07:14:30 |
9528111903
|
{"actor":{"display_login":"taliaga"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/comments/337873737","pull_request_review_id":305664131,"id":337873737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzg3MzczNw==","diff_hunk":"@@ -231,16 +238,23 @@ private void updateUserInShadowDb(String processId,MigrationUser migrationUser,\n propertiesMap.put(JsonKey.ORG_EXT_ID, migrationUser.getOrgExternalId());\n propertiesMap.put(JsonKey.UPDATED_ON, new Timestamp(System.currentTimeMillis()));\n propertiesMap.put(JsonKey.USER_STATUS,getInputStatus(migrationUser.getInputStatus()));\n- if(!isOrgExternalIdValid(migrationUser)) {\n- propertiesMap.put(JsonKey.CLAIM_STATUS, ClaimStatus.ORGEXTERNALIDMISMATCH.getValue());\n+ if (shadowUser.getClaimStatus() != ClaimStatus.CLAIMED.getValue() && shadowUser.getClaimStatus() != ClaimStatus.REJECTED.getValue() && shadowUser.getClaimStatus() != ClaimStatus.FAILED.getValue()) {\n+ if (!isOrgExternalIdValid(migrationUser)) {\n+ propertiesMap.put(JsonKey.CLAIM_STATUS, ClaimStatus.ORGEXTERNALIDMISMATCH.getValue());\n+ } else {\n+ propertiesMap.put(JsonKey.CLAIM_STATUS, ClaimStatus.UNCLAIMED.getValue());\n+ }\n }\n Map<String,Object>compositeKeysMap=new HashMap<>();\n compositeKeysMap.put(JsonKey.CHANNEL, migrationUser.getChannel());\n compositeKeysMap.put(JsonKey.USER_EXT_ID,migrationUser.getUserExternalId());\n Response response = cassandraOperation.updateRecord(JsonKey.SUNBIRD, JsonKey.SHADOW_USER, propertiesMap,compositeKeysMap);\n ProjectLogger.log(\"ShadowUserMigrationScheduler:updateUserInShadowDb: record status in cassandra \".concat(response+ \"\"), LoggerEnum.INFO.name());\n propertiesMap.clear();\n- new ShadowUserProcessor().processClaimedUser(getUpdatedShadowUser(compositeKeysMap));\n+ ShadowUser newShadowUser=getUpdatedShadowUser(compositeKeysMap);","path":"actors/common/src/main/java/org/sunbird/common/quartz/scheduler/ShadowUserMigrationScheduler.java","position":35,"original_position":34,"commit_id":"72660be5db33585c14e971dc4300c73ad078d855","original_commit_id":"b2b2b33afde32c253f7d64c1733c00e24027ebda","user":{"login":"manzarul","id":3481269,"node_id":"MDQ6VXNlcjM0ODEyNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/3481269?v=4","gravatar_id":"","url":"https://api.github.com/users/manzarul","html_url":"https://github.com/manzarul","followers_url":"https://api.github.com/users/manzarul/followers","following_url":"https://api.github.com/users/manzarul/following{/other_user}","gists_url":"https://api.github.com/users/manzarul/gists{/gist_id}","starred_url":"https://api.github.com/users/manzarul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manzarul/subscriptions","organizations_url":"https://api.github.com/users/manzarul/orgs","repos_url":"https://api.github.com/users/manzarul/repos","events_url":"https://api.github.com/users/manzarul/events{/privacy}","received_events_url":"https://api.github.com/users/manzarul/received_events","type":"User","site_admin":false},"body":"@anmol2302 do we still need to fetch data from db.","created_at":"2019-10-23T06:49:18Z","updated_at":"2019-10-23T06:49:18Z","html_url":"https://github.com/project-sunbird/sunbird-lms-mw/pull/795#discussion_r337873737","pull_request_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/comments/337873737"},"html":{"href":"https://github.com/project-sunbird/sunbird-lms-mw/pull/795#discussion_r337873737"},"pull_request":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795"}},"in_reply_to_id":337452374},"pull_request":{"url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795","id":330881444,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwODgxNDQ0","html_url":"https://github.com/project-sunbird/sunbird-lms-mw/pull/795","diff_url":"https://github.com/project-sunbird/sunbird-lms-mw/pull/795.diff","patch_url":"https://github.com/project-sunbird/sunbird-lms-mw/pull/795.patch","issue_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/issues/795","number":795,"state":"open","locked":false,"title":"Sc 1387","user":{"login":"anmol2302","id":26930855,"node_id":"MDQ6VXNlcjI2OTMwODU1","avatar_url":"https://avatars3.githubusercontent.com/u/26930855?v=4","gravatar_id":"","url":"https://api.github.com/users/anmol2302","html_url":"https://github.com/anmol2302","followers_url":"https://api.github.com/users/anmol2302/followers","following_url":"https://api.github.com/users/anmol2302/following{/other_user}","gists_url":"https://api.github.com/users/anmol2302/gists{/gist_id}","starred_url":"https://api.github.com/users/anmol2302/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmol2302/subscriptions","organizations_url":"https://api.github.com/users/anmol2302/orgs","repos_url":"https://api.github.com/users/anmol2302/repos","events_url":"https://api.github.com/users/anmol2302/events{/privacy}","received_events_url":"https://api.github.com/users/anmol2302/received_events","type":"User","site_admin":false},"body":"1: WILL Allow Admin to Update the user details (name, status, ext org id) when user will be validated\r\n2: User Provide wrong org ext id after correct entry status will be changed\r\n3: Once user status will be validated then no wrong entry can change the claimStatus of the user.\r\n4: If same user found with multiple channels will make user MULTIMATCH. if the user claimStatus is not VALIDATED","created_at":"2019-10-22T09:05:37Z","updated_at":"2019-10-23T06:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f540782c97da9b56daff58d09880f002955d31f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795/commits","review_comments_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795/comments","review_comment_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/issues/795/comments","statuses_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/statuses/72660be5db33585c14e971dc4300c73ad078d855","head":{"label":"anmol2302:SC-1387","ref":"SC-1387","sha":"72660be5db33585c14e971dc4300c73ad078d855","user":{"login":"anmol2302","id":26930855,"node_id":"MDQ6VXNlcjI2OTMwODU1","avatar_url":"https://avatars3.githubusercontent.com/u/26930855?v=4","gravatar_id":"","url":"https://api.github.com/users/anmol2302","html_url":"https://github.com/anmol2302","followers_url":"https://api.github.com/users/anmol2302/followers","following_url":"https://api.github.com/users/anmol2302/following{/other_user}","gists_url":"https://api.github.com/users/anmol2302/gists{/gist_id}","starred_url":"https://api.github.com/users/anmol2302/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmol2302/subscriptions","organizations_url":"https://api.github.com/users/anmol2302/orgs","repos_url":"https://api.github.com/users/anmol2302/repos","events_url":"https://api.github.com/users/anmol2302/events{/privacy}","received_events_url":"https://api.github.com/users/anmol2302/received_events","type":"User","site_admin":false},"repo":{"id":196201322,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYyMDEzMjI=","name":"sunbird-lms-mw","full_name":"anmol2302/sunbird-lms-mw","private":false,"owner":{"login":"anmol2302","id":26930855,"node_id":"MDQ6VXNlcjI2OTMwODU1","avatar_url":"https://avatars3.githubusercontent.com/u/26930855?v=4","gravatar_id":"","url":"https://api.github.com/users/anmol2302","html_url":"https://github.com/anmol2302","followers_url":"https://api.github.com/users/anmol2302/followers","following_url":"https://api.github.com/users/anmol2302/following{/other_user}","gists_url":"https://api.github.com/users/anmol2302/gists{/gist_id}","starred_url":"https://api.github.com/users/anmol2302/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmol2302/subscriptions","organizations_url":"https://api.github.com/users/anmol2302/orgs","repos_url":"https://api.github.com/users/anmol2302/repos","events_url":"https://api.github.com/users/anmol2302/events{/privacy}","received_events_url":"https://api.github.com/users/anmol2302/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anmol2302/sunbird-lms-mw","description":"Middleware components of Sunbird learning management system","fork":true,"url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw","forks_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/forks","keys_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/teams","hooks_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/hooks","issue_events_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/issues/events{/number}","events_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/events","assignees_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/assignees{/user}","branches_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/branches{/branch}","tags_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/tags","blobs_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/git/refs{/sha}","trees_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/statuses/{sha}","languages_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/languages","stargazers_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/stargazers","contributors_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/contributors","subscribers_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/subscribers","subscription_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/subscription","commits_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/commits{/sha}","git_commits_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/git/commits{/sha}","comments_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/comments{/number}","issue_comment_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/issues/comments{/number}","contents_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/contents/{+path}","compare_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/merges","archive_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/downloads","issues_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/issues{/number}","pulls_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/pulls{/number}","milestones_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/milestones{/number}","notifications_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/labels{/name}","releases_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/releases{/id}","deployments_url":"https://api.github.com/repos/anmol2302/sunbird-lms-mw/deployments","created_at":"2019-07-10T12:28:48Z","updated_at":"2019-07-10T12:28:52Z","pushed_at":"2019-10-23T06:26:32Z","git_url":"git://github.com/anmol2302/sunbird-lms-mw.git","ssh_url":"git@github.com:anmol2302/sunbird-lms-mw.git","clone_url":"https://github.com/anmol2302/sunbird-lms-mw.git","svn_url":"https://github.com/anmol2302/sunbird-lms-mw","homepage":null,"size":14810,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"project-sunbird:release-2.5.0","ref":"release-2.5.0","sha":"42273469c2cc09f053e1a2aa9504c7ec7ff94d96","user":{"login":"project-sunbird","id":26705730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzA1NzMw","avatar_url":"https://avatars1.githubusercontent.com/u/26705730?v=4","gravatar_id":"","url":"https://api.github.com/users/project-sunbird","html_url":"https://github.com/project-sunbird","followers_url":"https://api.github.com/users/project-sunbird/followers","following_url":"https://api.github.com/users/project-sunbird/following{/other_user}","gists_url":"https://api.github.com/users/project-sunbird/gists{/gist_id}","starred_url":"https://api.github.com/users/project-sunbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-sunbird/subscriptions","organizations_url":"https://api.github.com/users/project-sunbird/orgs","repos_url":"https://api.github.com/users/project-sunbird/repos","events_url":"https://api.github.com/users/project-sunbird/events{/privacy}","received_events_url":"https://api.github.com/users/project-sunbird/received_events","type":"Organization","site_admin":false},"repo":{"id":96122408,"node_id":"MDEwOlJlcG9zaXRvcnk5NjEyMjQwOA==","name":"sunbird-lms-mw","full_name":"project-sunbird/sunbird-lms-mw","private":false,"owner":{"login":"project-sunbird","id":26705730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzA1NzMw","avatar_url":"https://avatars1.githubusercontent.com/u/26705730?v=4","gravatar_id":"","url":"https://api.github.com/users/project-sunbird","html_url":"https://github.com/project-sunbird","followers_url":"https://api.github.com/users/project-sunbird/followers","following_url":"https://api.github.com/users/project-sunbird/following{/other_user}","gists_url":"https://api.github.com/users/project-sunbird/gists{/gist_id}","starred_url":"https://api.github.com/users/project-sunbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-sunbird/subscriptions","organizations_url":"https://api.github.com/users/project-sunbird/orgs","repos_url":"https://api.github.com/users/project-sunbird/repos","events_url":"https://api.github.com/users/project-sunbird/events{/privacy}","received_events_url":"https://api.github.com/users/project-sunbird/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/project-sunbird/sunbird-lms-mw","description":"Middleware components of Sunbird learning management system","fork":false,"url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw","forks_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/forks","keys_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/teams","hooks_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/hooks","issue_events_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/issues/events{/number}","events_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/events","assignees_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/assignees{/user}","branches_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/branches{/branch}","tags_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/tags","blobs_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/git/refs{/sha}","trees_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/statuses/{sha}","languages_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/languages","stargazers_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/stargazers","contributors_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/contributors","subscribers_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/subscribers","subscription_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/subscription","commits_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/commits{/sha}","git_commits_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/git/commits{/sha}","comments_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/comments{/number}","issue_comment_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/issues/comments{/number}","contents_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/contents/{+path}","compare_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/merges","archive_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/downloads","issues_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/issues{/number}","pulls_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls{/number}","milestones_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/milestones{/number}","notifications_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/labels{/name}","releases_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/releases{/id}","deployments_url":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/deployments","created_at":"2017-07-03T14:57:51Z","updated_at":"2019-10-01T18:32:38Z","pushed_at":"2019-10-23T06:26:33Z","git_url":"git://github.com/project-sunbird/sunbird-lms-mw.git","ssh_url":"git@github.com:project-sunbird/sunbird-lms-mw.git","clone_url":"https://github.com/project-sunbird/sunbird-lms-mw.git","svn_url":"https://github.com/project-sunbird/sunbird-lms-mw","homepage":null,"size":14800,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795"},"html":{"href":"https://github.com/project-sunbird/sunbird-lms-mw/pull/795"},"issue":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/issues/795"},"comments":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/issues/795/comments"},"review_comments":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795/comments"},"review_comment":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/pulls/795/commits"},"statuses":{"href":"https://api.github.com/repos/project-sunbird/sunbird-lms-mw/statuses/72660be5db33585c14e971dc4300c73ad078d855"}},"author_association":"COLLABORATOR"}}
|
{
"id": 96122408,
"name": "project-sunbird/sunbird-lms-mw",
"url": "https://api.github.com/repos/project-sunbird/sunbird-lms-mw"
}
|
{
"id": 3481269,
"login": "manzarul",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3481269?",
"url": "https://api.github.com/users/manzarul"
}
|
{
"id": 26705730,
"login": "project-sunbird",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26705730?",
"url": "https://api.github.com/orgs/project-sunbird"
}
| 2019-10-23T06:49:18 |
10692537016
|
{"actor":{"display_login":"manzarul"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/transhumandesign/kag-base/pulls/comments/273324130","pull_request_review_id":224191365,"id":273324130,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzMyNDEzMA==","diff_hunk":"@@ -98,22 +98,31 @@ void ShowEmotesMenu(CPlayer@ player)\n \t\tConfigFile@ cfg = openEmoteBindingsConfig();\n \n \t\tarray<u8> emoteBinds = {\n-\t\t\tread_emote(cfg, \"emote_1\", Emotes::attn),\n-\t\t\tread_emote(cfg, \"emote_2\", Emotes::smile),\n-\t\t\tread_emote(cfg, \"emote_3\", Emotes::frown),\n-\t\t\tread_emote(cfg, \"emote_4\", Emotes::mad),\n-\t\t\tread_emote(cfg, \"emote_5\", Emotes::laugh),\n-\t\t\tread_emote(cfg, \"emote_6\", Emotes::wat),\n-\t\t\tread_emote(cfg, \"emote_7\", Emotes::troll),\n-\t\t\tread_emote(cfg, \"emote_8\", Emotes::disappoint),\n-\t\t\tread_emote(cfg, \"emote_9\", Emotes::ladder)\n+ read_emote(cfg, \"emote_1\", Emotes::attn),","path":"Rules/CommonScripts/EmoteBinderMenu.as","position":22,"original_position":22,"commit_id":"9dbe0b14cbe8643be040c112b464b7cbf1fb2478","original_commit_id":"9dbe0b14cbe8643be040c112b464b7cbf1fb2478","user":{"login":"1bardesign","id":24538638,"node_id":"MDQ6VXNlcjI0NTM4NjM4","avatar_url":"https://avatars0.githubusercontent.com/u/24538638?v=4","gravatar_id":"","url":"https://api.github.com/users/1bardesign","html_url":"https://github.com/1bardesign","followers_url":"https://api.github.com/users/1bardesign/followers","following_url":"https://api.github.com/users/1bardesign/following{/other_user}","gists_url":"https://api.github.com/users/1bardesign/gists{/gist_id}","starred_url":"https://api.github.com/users/1bardesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1bardesign/subscriptions","organizations_url":"https://api.github.com/users/1bardesign/orgs","repos_url":"https://api.github.com/users/1bardesign/repos","events_url":"https://api.github.com/users/1bardesign/events{/privacy}","received_events_url":"https://api.github.com/users/1bardesign/received_events","type":"User","site_admin":false},"body":"how come this is indented with spaces when the rest of the file is not?","created_at":"2019-04-09T04:51:26Z","updated_at":"2019-04-09T04:52:17Z","html_url":"https://github.com/transhumandesign/kag-base/pull/494#discussion_r273324130","pull_request_url":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/transhumandesign/kag-base/pulls/comments/273324130"},"html":{"href":"https://github.com/transhumandesign/kag-base/pull/494#discussion_r273324130"},"pull_request":{"href":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494","id":267497122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3NDk3MTIy","html_url":"https://github.com/transhumandesign/kag-base/pull/494","diff_url":"https://github.com/transhumandesign/kag-base/pull/494.diff","patch_url":"https://github.com/transhumandesign/kag-base/pull/494.patch","issue_url":"https://api.github.com/repos/transhumandesign/kag-base/issues/494","number":494,"state":"open","locked":false,"title":"Add numpad emote hotkey bindings","user":{"login":"Stolij","id":22031260,"node_id":"MDQ6VXNlcjIyMDMxMjYw","avatar_url":"https://avatars1.githubusercontent.com/u/22031260?v=4","gravatar_id":"","url":"https://api.github.com/users/Stolij","html_url":"https://github.com/Stolij","followers_url":"https://api.github.com/users/Stolij/followers","following_url":"https://api.github.com/users/Stolij/following{/other_user}","gists_url":"https://api.github.com/users/Stolij/gists{/gist_id}","starred_url":"https://api.github.com/users/Stolij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stolij/subscriptions","organizations_url":"https://api.github.com/users/Stolij/orgs","repos_url":"https://api.github.com/users/Stolij/repos","events_url":"https://api.github.com/users/Stolij/events{/privacy}","received_events_url":"https://api.github.com/users/Stolij/received_events","type":"User","site_admin":false},"body":"## Status\r\n\r\n**READY**: this PR is (to the best of your knowledge) ready to be incorporated into the game.\r\n\r\n## Description\r\nThis pull request's main goal is to add numpad keybindings to EmoteHotkeys.as. It allows people who have a numpad to utilize it to access more emote hotkeys.\r\n\r\n## Steps to Test or Reproduce\r\nTo use the extended EmoteHotkeys, just press any key on your numpad (between 1-9)\r\n\r\n### Files modified\r\nEmoteHotkeys.as\r\nEmoteBinderMenu.as\r\n\r\nEmoteBindings.cfg\r\n\r\n### Used branch\r\nThe branch I created is called 'more-emote-hotkeys'\r\n","created_at":"2019-04-04T15:18:44Z","updated_at":"2019-04-09T04:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a829037c88201efcd2ab11d63f2c08a8fdc74646","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494/commits","review_comments_url":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494/comments","review_comment_url":"https://api.github.com/repos/transhumandesign/kag-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transhumandesign/kag-base/issues/494/comments","statuses_url":"https://api.github.com/repos/transhumandesign/kag-base/statuses/9dbe0b14cbe8643be040c112b464b7cbf1fb2478","head":{"label":"Stolij:more-emote-hotkeys","ref":"more-emote-hotkeys","sha":"9dbe0b14cbe8643be040c112b464b7cbf1fb2478","user":{"login":"Stolij","id":22031260,"node_id":"MDQ6VXNlcjIyMDMxMjYw","avatar_url":"https://avatars1.githubusercontent.com/u/22031260?v=4","gravatar_id":"","url":"https://api.github.com/users/Stolij","html_url":"https://github.com/Stolij","followers_url":"https://api.github.com/users/Stolij/followers","following_url":"https://api.github.com/users/Stolij/following{/other_user}","gists_url":"https://api.github.com/users/Stolij/gists{/gist_id}","starred_url":"https://api.github.com/users/Stolij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stolij/subscriptions","organizations_url":"https://api.github.com/users/Stolij/orgs","repos_url":"https://api.github.com/users/Stolij/repos","events_url":"https://api.github.com/users/Stolij/events{/privacy}","received_events_url":"https://api.github.com/users/Stolij/received_events","type":"User","site_admin":false},"repo":{"id":179511950,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk1MTE5NTA=","name":"kag-base","full_name":"Stolij/kag-base","private":false,"owner":{"login":"Stolij","id":22031260,"node_id":"MDQ6VXNlcjIyMDMxMjYw","avatar_url":"https://avatars1.githubusercontent.com/u/22031260?v=4","gravatar_id":"","url":"https://api.github.com/users/Stolij","html_url":"https://github.com/Stolij","followers_url":"https://api.github.com/users/Stolij/followers","following_url":"https://api.github.com/users/Stolij/following{/other_user}","gists_url":"https://api.github.com/users/Stolij/gists{/gist_id}","starred_url":"https://api.github.com/users/Stolij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stolij/subscriptions","organizations_url":"https://api.github.com/users/Stolij/orgs","repos_url":"https://api.github.com/users/Stolij/repos","events_url":"https://api.github.com/users/Stolij/events{/privacy}","received_events_url":"https://api.github.com/users/Stolij/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Stolij/kag-base","description":"King Arthur's Gold base folder.","fork":true,"url":"https://api.github.com/repos/Stolij/kag-base","forks_url":"https://api.github.com/repos/Stolij/kag-base/forks","keys_url":"https://api.github.com/repos/Stolij/kag-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stolij/kag-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stolij/kag-base/teams","hooks_url":"https://api.github.com/repos/Stolij/kag-base/hooks","issue_events_url":"https://api.github.com/repos/Stolij/kag-base/issues/events{/number}","events_url":"https://api.github.com/repos/Stolij/kag-base/events","assignees_url":"https://api.github.com/repos/Stolij/kag-base/assignees{/user}","branches_url":"https://api.github.com/repos/Stolij/kag-base/branches{/branch}","tags_url":"https://api.github.com/repos/Stolij/kag-base/tags","blobs_url":"https://api.github.com/repos/Stolij/kag-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stolij/kag-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stolij/kag-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stolij/kag-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stolij/kag-base/statuses/{sha}","languages_url":"https://api.github.com/repos/Stolij/kag-base/languages","stargazers_url":"https://api.github.com/repos/Stolij/kag-base/stargazers","contributors_url":"https://api.github.com/repos/Stolij/kag-base/contributors","subscribers_url":"https://api.github.com/repos/Stolij/kag-base/subscribers","subscription_url":"https://api.github.com/repos/Stolij/kag-base/subscription","commits_url":"https://api.github.com/repos/Stolij/kag-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stolij/kag-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stolij/kag-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stolij/kag-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stolij/kag-base/contents/{+path}","compare_url":"https://api.github.com/repos/Stolij/kag-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stolij/kag-base/merges","archive_url":"https://api.github.com/repos/Stolij/kag-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stolij/kag-base/downloads","issues_url":"https://api.github.com/repos/Stolij/kag-base/issues{/number}","pulls_url":"https://api.github.com/repos/Stolij/kag-base/pulls{/number}","milestones_url":"https://api.github.com/repos/Stolij/kag-base/milestones{/number}","notifications_url":"https://api.github.com/repos/Stolij/kag-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stolij/kag-base/labels{/name}","releases_url":"https://api.github.com/repos/Stolij/kag-base/releases{/id}","deployments_url":"https://api.github.com/repos/Stolij/kag-base/deployments","created_at":"2019-04-04T14:17:00Z","updated_at":"2019-04-04T14:17:06Z","pushed_at":"2019-04-04T15:08:19Z","git_url":"git://github.com/Stolij/kag-base.git","ssh_url":"git@github.com:Stolij/kag-base.git","clone_url":"https://github.com/Stolij/kag-base.git","svn_url":"https://github.com/Stolij/kag-base","homepage":null,"size":63258,"stargazers_count":0,"watchers_count":0,"language":"AngelScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"transhumandesign:master","ref":"master","sha":"7e017b4cdd38726dd888132983e9f63c982e6bf1","user":{"login":"transhumandesign","id":26709580,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzA5NTgw","avatar_url":"https://avatars0.githubusercontent.com/u/26709580?v=4","gravatar_id":"","url":"https://api.github.com/users/transhumandesign","html_url":"https://github.com/transhumandesign","followers_url":"https://api.github.com/users/transhumandesign/followers","following_url":"https://api.github.com/users/transhumandesign/following{/other_user}","gists_url":"https://api.github.com/users/transhumandesign/gists{/gist_id}","starred_url":"https://api.github.com/users/transhumandesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transhumandesign/subscriptions","organizations_url":"https://api.github.com/users/transhumandesign/orgs","repos_url":"https://api.github.com/users/transhumandesign/repos","events_url":"https://api.github.com/users/transhumandesign/events{/privacy}","received_events_url":"https://api.github.com/users/transhumandesign/received_events","type":"Organization","site_admin":false},"repo":{"id":86322619,"node_id":"MDEwOlJlcG9zaXRvcnk4NjMyMjYxOQ==","name":"kag-base","full_name":"transhumandesign/kag-base","private":false,"owner":{"login":"transhumandesign","id":26709580,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NzA5NTgw","avatar_url":"https://avatars0.githubusercontent.com/u/26709580?v=4","gravatar_id":"","url":"https://api.github.com/users/transhumandesign","html_url":"https://github.com/transhumandesign","followers_url":"https://api.github.com/users/transhumandesign/followers","following_url":"https://api.github.com/users/transhumandesign/following{/other_user}","gists_url":"https://api.github.com/users/transhumandesign/gists{/gist_id}","starred_url":"https://api.github.com/users/transhumandesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transhumandesign/subscriptions","organizations_url":"https://api.github.com/users/transhumandesign/orgs","repos_url":"https://api.github.com/users/transhumandesign/repos","events_url":"https://api.github.com/users/transhumandesign/events{/privacy}","received_events_url":"https://api.github.com/users/transhumandesign/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transhumandesign/kag-base","description":"King Arthur's Gold base folder.","fork":false,"url":"https://api.github.com/repos/transhumandesign/kag-base","forks_url":"https://api.github.com/repos/transhumandesign/kag-base/forks","keys_url":"https://api.github.com/repos/transhumandesign/kag-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transhumandesign/kag-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transhumandesign/kag-base/teams","hooks_url":"https://api.github.com/repos/transhumandesign/kag-base/hooks","issue_events_url":"https://api.github.com/repos/transhumandesign/kag-base/issues/events{/number}","events_url":"https://api.github.com/repos/transhumandesign/kag-base/events","assignees_url":"https://api.github.com/repos/transhumandesign/kag-base/assignees{/user}","branches_url":"https://api.github.com/repos/transhumandesign/kag-base/branches{/branch}","tags_url":"https://api.github.com/repos/transhumandesign/kag-base/tags","blobs_url":"https://api.github.com/repos/transhumandesign/kag-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transhumandesign/kag-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transhumandesign/kag-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/transhumandesign/kag-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transhumandesign/kag-base/statuses/{sha}","languages_url":"https://api.github.com/repos/transhumandesign/kag-base/languages","stargazers_url":"https://api.github.com/repos/transhumandesign/kag-base/stargazers","contributors_url":"https://api.github.com/repos/transhumandesign/kag-base/contributors","subscribers_url":"https://api.github.com/repos/transhumandesign/kag-base/subscribers","subscription_url":"https://api.github.com/repos/transhumandesign/kag-base/subscription","commits_url":"https://api.github.com/repos/transhumandesign/kag-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/transhumandesign/kag-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/transhumandesign/kag-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/transhumandesign/kag-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/transhumandesign/kag-base/contents/{+path}","compare_url":"https://api.github.com/repos/transhumandesign/kag-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transhumandesign/kag-base/merges","archive_url":"https://api.github.com/repos/transhumandesign/kag-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transhumandesign/kag-base/downloads","issues_url":"https://api.github.com/repos/transhumandesign/kag-base/issues{/number}","pulls_url":"https://api.github.com/repos/transhumandesign/kag-base/pulls{/number}","milestones_url":"https://api.github.com/repos/transhumandesign/kag-base/milestones{/number}","notifications_url":"https://api.github.com/repos/transhumandesign/kag-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transhumandesign/kag-base/labels{/name}","releases_url":"https://api.github.com/repos/transhumandesign/kag-base/releases{/id}","deployments_url":"https://api.github.com/repos/transhumandesign/kag-base/deployments","created_at":"2017-03-27T10:32:27Z","updated_at":"2019-04-07T05:25:13Z","pushed_at":"2019-04-06T15:32:56Z","git_url":"git://github.com/transhumandesign/kag-base.git","ssh_url":"git@github.com:transhumandesign/kag-base.git","clone_url":"https://github.com/transhumandesign/kag-base.git","svn_url":"https://github.com/transhumandesign/kag-base","homepage":null,"size":63269,"stargazers_count":97,"watchers_count":97,"language":"AngelScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":107,"license":null,"forks":66,"open_issues":107,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494"},"html":{"href":"https://github.com/transhumandesign/kag-base/pull/494"},"issue":{"href":"https://api.github.com/repos/transhumandesign/kag-base/issues/494"},"comments":{"href":"https://api.github.com/repos/transhumandesign/kag-base/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/transhumandesign/kag-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transhumandesign/kag-base/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/transhumandesign/kag-base/statuses/9dbe0b14cbe8643be040c112b464b7cbf1fb2478"}},"author_association":"NONE"}}
|
{
"id": 86322619,
"name": "transhumandesign/kag-base",
"url": "https://api.github.com/repos/transhumandesign/kag-base"
}
|
{
"id": 24538638,
"login": "1bardesign",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24538638?",
"url": "https://api.github.com/users/1bardesign"
}
|
{
"id": 26709580,
"login": "transhumandesign",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26709580?",
"url": "https://api.github.com/orgs/transhumandesign"
}
| 2019-04-09T04:51:26 |
9404177860
|
{"actor":{"display_login":"1bardesign"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/comments/255341459","pull_request_review_id":201907346,"id":255341459,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTM0MTQ1OQ==","diff_hunk":"@@ -0,0 +1,62 @@\n+const _ = require('lodash')\n+\n+module.exports = {\n+ executeAsTransaction: function (pool, queries) {\n+ // @brief Runs a chain of queries in the order provided\n+ // in a transaction.\n+ // @param {Pool} pool - node-pg pool object\n+ // @param {Array} queries - Array of query objects to chain in a transaction.\n+ // Objects must be the query string\n+ // OR\n+ // of the form {text: <query string>, values: <parameters>}\n+ if (queries.length === 0) {\n+ return Promise.resolve()\n+ }\n+\n+ if (queries.length === 1) {\n+ return pool.query(queries[0])\n+ }\n+\n+ console.log('[TRANSACTION] Connecting to client')","path":"server/src/adapters/postgres/pg-transaction.js","position":20,"original_position":20,"commit_id":"c88e357b687d0ff01ac62e23eb29632b0b622a88","original_commit_id":"c88e357b687d0ff01ac62e23eb29632b0b622a88","user":{"login":"hammady","id":855847,"node_id":"MDQ6VXNlcjg1NTg0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/855847?v=4","gravatar_id":"","url":"https://api.github.com/users/hammady","html_url":"https://github.com/hammady","followers_url":"https://api.github.com/users/hammady/followers","following_url":"https://api.github.com/users/hammady/following{/other_user}","gists_url":"https://api.github.com/users/hammady/gists{/gist_id}","starred_url":"https://api.github.com/users/hammady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammady/subscriptions","organizations_url":"https://api.github.com/users/hammady/orgs","repos_url":"https://api.github.com/users/hammady/repos","events_url":"https://api.github.com/users/hammady/events{/privacy}","received_events_url":"https://api.github.com/users/hammady/received_events","type":"User","site_admin":false},"body":"I'm concerned about too many console logs that will fill up the logs. Can we control its level?","created_at":"2019-02-10T15:09:23Z","updated_at":"2019-02-10T15:12:36Z","html_url":"https://github.com/rayyanqcri/rayyan-store/pull/32#discussion_r255341459","pull_request_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/comments/255341459"},"html":{"href":"https://github.com/rayyanqcri/rayyan-store/pull/32#discussion_r255341459"},"pull_request":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32","id":251732508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNzMyNTA4","html_url":"https://github.com/rayyanqcri/rayyan-store/pull/32","diff_url":"https://github.com/rayyanqcri/rayyan-store/pull/32.diff","patch_url":"https://github.com/rayyanqcri/rayyan-store/pull/32.patch","issue_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/issues/32","number":32,"state":"open","locked":false,"title":"Add transactions to rayyan-store endpoints","user":{"login":"fabubaker","id":9405286,"node_id":"MDQ6VXNlcjk0MDUyODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9405286?v=4","gravatar_id":"","url":"https://api.github.com/users/fabubaker","html_url":"https://github.com/fabubaker","followers_url":"https://api.github.com/users/fabubaker/followers","following_url":"https://api.github.com/users/fabubaker/following{/other_user}","gists_url":"https://api.github.com/users/fabubaker/gists{/gist_id}","starred_url":"https://api.github.com/users/fabubaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabubaker/subscriptions","organizations_url":"https://api.github.com/users/fabubaker/orgs","repos_url":"https://api.github.com/users/fabubaker/repos","events_url":"https://api.github.com/users/fabubaker/events{/privacy}","received_events_url":"https://api.github.com/users/fabubaker/received_events","type":"User","site_admin":false},"body":"* `executeAsTransaction(pool, queries)` has been implemented in a separate module to help run queries in a transaction. It returns the results of the last query in the transaction.\r\n\r\n* `deleteByFileId` & `insertDedup` have been modified to use the new transaction interface.\r\n\r\nFixes #21 ","created_at":"2019-02-10T11:26:51Z","updated_at":"2019-02-10T15:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9938de5c550db9d8ea3d352f96d1197d7e4d71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32/commits","review_comments_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32/comments","review_comment_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/issues/32/comments","statuses_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/statuses/c88e357b687d0ff01ac62e23eb29632b0b622a88","head":{"label":"fabubaker:issue-21-transactions","ref":"issue-21-transactions","sha":"c88e357b687d0ff01ac62e23eb29632b0b622a88","user":{"login":"fabubaker","id":9405286,"node_id":"MDQ6VXNlcjk0MDUyODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9405286?v=4","gravatar_id":"","url":"https://api.github.com/users/fabubaker","html_url":"https://github.com/fabubaker","followers_url":"https://api.github.com/users/fabubaker/followers","following_url":"https://api.github.com/users/fabubaker/following{/other_user}","gists_url":"https://api.github.com/users/fabubaker/gists{/gist_id}","starred_url":"https://api.github.com/users/fabubaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabubaker/subscriptions","organizations_url":"https://api.github.com/users/fabubaker/orgs","repos_url":"https://api.github.com/users/fabubaker/repos","events_url":"https://api.github.com/users/fabubaker/events{/privacy}","received_events_url":"https://api.github.com/users/fabubaker/received_events","type":"User","site_admin":false},"repo":{"id":148688940,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2ODg5NDA=","name":"rayyan-store","full_name":"fabubaker/rayyan-store","private":false,"owner":{"login":"fabubaker","id":9405286,"node_id":"MDQ6VXNlcjk0MDUyODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9405286?v=4","gravatar_id":"","url":"https://api.github.com/users/fabubaker","html_url":"https://github.com/fabubaker","followers_url":"https://api.github.com/users/fabubaker/followers","following_url":"https://api.github.com/users/fabubaker/following{/other_user}","gists_url":"https://api.github.com/users/fabubaker/gists{/gist_id}","starred_url":"https://api.github.com/users/fabubaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabubaker/subscriptions","organizations_url":"https://api.github.com/users/fabubaker/orgs","repos_url":"https://api.github.com/users/fabubaker/repos","events_url":"https://api.github.com/users/fabubaker/events{/privacy}","received_events_url":"https://api.github.com/users/fabubaker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fabubaker/rayyan-store","description":"A microservice for handling the storage of Rayyan articles with endpoints to import, export, query and customize","fork":true,"url":"https://api.github.com/repos/fabubaker/rayyan-store","forks_url":"https://api.github.com/repos/fabubaker/rayyan-store/forks","keys_url":"https://api.github.com/repos/fabubaker/rayyan-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabubaker/rayyan-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabubaker/rayyan-store/teams","hooks_url":"https://api.github.com/repos/fabubaker/rayyan-store/hooks","issue_events_url":"https://api.github.com/repos/fabubaker/rayyan-store/issues/events{/number}","events_url":"https://api.github.com/repos/fabubaker/rayyan-store/events","assignees_url":"https://api.github.com/repos/fabubaker/rayyan-store/assignees{/user}","branches_url":"https://api.github.com/repos/fabubaker/rayyan-store/branches{/branch}","tags_url":"https://api.github.com/repos/fabubaker/rayyan-store/tags","blobs_url":"https://api.github.com/repos/fabubaker/rayyan-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabubaker/rayyan-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabubaker/rayyan-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabubaker/rayyan-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabubaker/rayyan-store/statuses/{sha}","languages_url":"https://api.github.com/repos/fabubaker/rayyan-store/languages","stargazers_url":"https://api.github.com/repos/fabubaker/rayyan-store/stargazers","contributors_url":"https://api.github.com/repos/fabubaker/rayyan-store/contributors","subscribers_url":"https://api.github.com/repos/fabubaker/rayyan-store/subscribers","subscription_url":"https://api.github.com/repos/fabubaker/rayyan-store/subscription","commits_url":"https://api.github.com/repos/fabubaker/rayyan-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabubaker/rayyan-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabubaker/rayyan-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabubaker/rayyan-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabubaker/rayyan-store/contents/{+path}","compare_url":"https://api.github.com/repos/fabubaker/rayyan-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabubaker/rayyan-store/merges","archive_url":"https://api.github.com/repos/fabubaker/rayyan-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabubaker/rayyan-store/downloads","issues_url":"https://api.github.com/repos/fabubaker/rayyan-store/issues{/number}","pulls_url":"https://api.github.com/repos/fabubaker/rayyan-store/pulls{/number}","milestones_url":"https://api.github.com/repos/fabubaker/rayyan-store/milestones{/number}","notifications_url":"https://api.github.com/repos/fabubaker/rayyan-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabubaker/rayyan-store/labels{/name}","releases_url":"https://api.github.com/repos/fabubaker/rayyan-store/releases{/id}","deployments_url":"https://api.github.com/repos/fabubaker/rayyan-store/deployments","created_at":"2018-09-13T19:41:57Z","updated_at":"2019-02-06T19:40:16Z","pushed_at":"2019-02-10T13:09:09Z","git_url":"git://github.com/fabubaker/rayyan-store.git","ssh_url":"git@github.com:fabubaker/rayyan-store.git","clone_url":"https://github.com/fabubaker/rayyan-store.git","svn_url":"https://github.com/fabubaker/rayyan-store","homepage":null,"size":1886,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rayyanqcri:master","ref":"master","sha":"0665878cce0395c4ffb5a89eb13f9bc052b12750","user":{"login":"rayyanqcri","id":26848725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ4NzI1","avatar_url":"https://avatars0.githubusercontent.com/u/26848725?v=4","gravatar_id":"","url":"https://api.github.com/users/rayyanqcri","html_url":"https://github.com/rayyanqcri","followers_url":"https://api.github.com/users/rayyanqcri/followers","following_url":"https://api.github.com/users/rayyanqcri/following{/other_user}","gists_url":"https://api.github.com/users/rayyanqcri/gists{/gist_id}","starred_url":"https://api.github.com/users/rayyanqcri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayyanqcri/subscriptions","organizations_url":"https://api.github.com/users/rayyanqcri/orgs","repos_url":"https://api.github.com/users/rayyanqcri/repos","events_url":"https://api.github.com/users/rayyanqcri/events{/privacy}","received_events_url":"https://api.github.com/users/rayyanqcri/received_events","type":"Organization","site_admin":false},"repo":{"id":126301287,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYzMDEyODc=","name":"rayyan-store","full_name":"rayyanqcri/rayyan-store","private":false,"owner":{"login":"rayyanqcri","id":26848725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQ4NzI1","avatar_url":"https://avatars0.githubusercontent.com/u/26848725?v=4","gravatar_id":"","url":"https://api.github.com/users/rayyanqcri","html_url":"https://github.com/rayyanqcri","followers_url":"https://api.github.com/users/rayyanqcri/followers","following_url":"https://api.github.com/users/rayyanqcri/following{/other_user}","gists_url":"https://api.github.com/users/rayyanqcri/gists{/gist_id}","starred_url":"https://api.github.com/users/rayyanqcri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayyanqcri/subscriptions","organizations_url":"https://api.github.com/users/rayyanqcri/orgs","repos_url":"https://api.github.com/users/rayyanqcri/repos","events_url":"https://api.github.com/users/rayyanqcri/events{/privacy}","received_events_url":"https://api.github.com/users/rayyanqcri/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rayyanqcri/rayyan-store","description":"A microservice for handling the storage of Rayyan articles with endpoints to import, export, query and customize","fork":false,"url":"https://api.github.com/repos/rayyanqcri/rayyan-store","forks_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/forks","keys_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/teams","hooks_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/hooks","issue_events_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/issues/events{/number}","events_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/events","assignees_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/assignees{/user}","branches_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/branches{/branch}","tags_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/tags","blobs_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/statuses/{sha}","languages_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/languages","stargazers_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/stargazers","contributors_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/contributors","subscribers_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/subscribers","subscription_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/subscription","commits_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/contents/{+path}","compare_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/merges","archive_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/downloads","issues_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/issues{/number}","pulls_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls{/number}","milestones_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/milestones{/number}","notifications_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/labels{/name}","releases_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/releases{/id}","deployments_url":"https://api.github.com/repos/rayyanqcri/rayyan-store/deployments","created_at":"2018-03-22T08:09:07Z","updated_at":"2019-02-07T05:51:38Z","pushed_at":"2019-02-10T13:09:10Z","git_url":"git://github.com/rayyanqcri/rayyan-store.git","ssh_url":"git@github.com:rayyanqcri/rayyan-store.git","clone_url":"https://github.com/rayyanqcri/rayyan-store.git","svn_url":"https://github.com/rayyanqcri/rayyan-store","homepage":null,"size":1870,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32"},"html":{"href":"https://github.com/rayyanqcri/rayyan-store/pull/32"},"issue":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/issues/32"},"comments":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/rayyanqcri/rayyan-store/statuses/c88e357b687d0ff01ac62e23eb29632b0b622a88"}},"author_association":"MEMBER"}}
|
{
"id": 126301287,
"name": "rayyanqcri/rayyan-store",
"url": "https://api.github.com/repos/rayyanqcri/rayyan-store"
}
|
{
"id": 855847,
"login": "hammady",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/855847?",
"url": "https://api.github.com/users/hammady"
}
|
{
"id": 26848725,
"login": "rayyanqcri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26848725?",
"url": "https://api.github.com/orgs/rayyanqcri"
}
| 2019-02-10T15:09:23 |
9040294865
|
{"actor":{"display_login":"hammady"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/284406361","pull_request_review_id":238013970,"id":284406361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDQwNjM2MQ==","diff_hunk":"@@ -0,0 +1,74 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+#include \"tests/Unit/TestingFramework.hpp\"\n+\n+#include <cstddef>\n+#include <random>\n+\n+#include \"DataStructures/ComplexDataVector.hpp\"\n+#include \"DataStructures/DataVector.hpp\"\n+#include \"DataStructures/ModalVector.hpp\"\n+#include \"DataStructures/VectorAlgebra.hpp\"\n+#include \"Utilities/Gsl.hpp\"\n+#include \"Utilities/TypeTraits.hpp\"\n+#include \"tests/Unit/TestHelpers.hpp\"\n+#include \"tests/Utilities/MakeWithRandomValues.hpp\"\n+\n+template <typename RhsVectorType, typename LhsVectorType>\n+void test_outer() {\n+ MAKE_GENERATOR(gen);\n+ UniformCustomDistribution<size_t> size_distribution{5, 10};\n+ UniformCustomDistribution<\n+ tt::get_fundamental_type_t<get_vector_element_type_t<LhsVectorType>>>\n+ lhs_distribution{-2.0, 2.0};\n+ UniformCustomDistribution<\n+ tt::get_fundamental_type_t<get_vector_element_type_t<RhsVectorType>>>\n+ rhs_distribution{-2.0, 2.0};\n+ const LhsVectorType lhs = make_with_random_values<LhsVectorType>(\n+ make_not_null(&gen), make_not_null(&lhs_distribution),\n+ size_distribution(gen));\n+ const RhsVectorType rhs = make_with_random_values<RhsVectorType>(\n+ make_not_null(&gen), make_not_null(&rhs_distribution),\n+ size_distribution(gen));\n+ const auto outer_product = outer(lhs, rhs);\n+ size_t product_index = 0;\n+ for (const auto& b : rhs) {\n+ for (const auto& a : lhs) {\n+ // Iterable approx consistently works for all contained types","path":"tests/Unit/DataStructures/Test_VectorAlgebra.cpp","position":null,"original_position":38,"commit_id":"315c0492fc29c63b7dd207b6e64fbc91b348010e","original_commit_id":"71e35e2354d75a16a0303c16c6ffc40676507695","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"Ah, okay. Well I think basically what you just said would be fine:\r\n```cpp\r\n// Because CHECK(approx(a) == b) doesn't work for complex types, while CHECK_ITERABLE_APPROX does\r\n```\r\nI can see that making someone's life easier in the future :) ","created_at":"2019-05-15T19:04:06Z","updated_at":"2019-05-15T19:04:07Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/1522#discussion_r284406361","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/284406361"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1522#discussion_r284406361"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522"}},"in_reply_to_id":283596483},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522","id":278354517,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MzU0NTE3","html_url":"https://github.com/sxs-collaboration/spectre/pull/1522","diff_url":"https://github.com/sxs-collaboration/spectre/pull/1522.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/1522.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1522","number":1522,"state":"open","locked":false,"title":"Expand spin weighted utilities","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nSeveral small changes to utilities related to Vectors and `SpinWeighted` which help in simplifying spin-weighted spherical harmonics and CCE evolution code.\r\n\r\n### Types of changes:\r\n\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`.\r\n For instructions on how to perform the CI checks locally refer to the [Dev\r\n guide on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run\r\n `make doc` to generate the documentation locally into `BUILD_DIR/docs/html`.\r\n Then open `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n [code review guide](https://spectre-code.org/code_review_guide.html).\r\n","created_at":"2019-05-13T16:48:32Z","updated_at":"2019-05-15T19:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f3c394d4be38e56deb97dc005784af11c979b03","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1522/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/315c0492fc29c63b7dd207b6e64fbc91b348010e","head":{"label":"moxcodes:expand_spinweighted_utilities","ref":"expand_spinweighted_utilities","sha":"315c0492fc29c63b7dd207b6e64fbc91b348010e","user":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"repo":{"id":147872565,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4NzI1NjU=","name":"spectre","full_name":"moxcodes/spectre","private":false,"owner":{"login":"moxcodes","id":32072858,"node_id":"MDQ6VXNlcjMyMDcyODU4","avatar_url":"https://avatars0.githubusercontent.com/u/32072858?v=4","gravatar_id":"","url":"https://api.github.com/users/moxcodes","html_url":"https://github.com/moxcodes","followers_url":"https://api.github.com/users/moxcodes/followers","following_url":"https://api.github.com/users/moxcodes/following{/other_user}","gists_url":"https://api.github.com/users/moxcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/moxcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxcodes/subscriptions","organizations_url":"https://api.github.com/users/moxcodes/orgs","repos_url":"https://api.github.com/users/moxcodes/repos","events_url":"https://api.github.com/users/moxcodes/events{/privacy}","received_events_url":"https://api.github.com/users/moxcodes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moxcodes/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":true,"url":"https://api.github.com/repos/moxcodes/spectre","forks_url":"https://api.github.com/repos/moxcodes/spectre/forks","keys_url":"https://api.github.com/repos/moxcodes/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moxcodes/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moxcodes/spectre/teams","hooks_url":"https://api.github.com/repos/moxcodes/spectre/hooks","issue_events_url":"https://api.github.com/repos/moxcodes/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/moxcodes/spectre/events","assignees_url":"https://api.github.com/repos/moxcodes/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/moxcodes/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/moxcodes/spectre/tags","blobs_url":"https://api.github.com/repos/moxcodes/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moxcodes/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moxcodes/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/moxcodes/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moxcodes/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/moxcodes/spectre/languages","stargazers_url":"https://api.github.com/repos/moxcodes/spectre/stargazers","contributors_url":"https://api.github.com/repos/moxcodes/spectre/contributors","subscribers_url":"https://api.github.com/repos/moxcodes/spectre/subscribers","subscription_url":"https://api.github.com/repos/moxcodes/spectre/subscription","commits_url":"https://api.github.com/repos/moxcodes/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/moxcodes/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/moxcodes/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/moxcodes/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/moxcodes/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/moxcodes/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moxcodes/spectre/merges","archive_url":"https://api.github.com/repos/moxcodes/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moxcodes/spectre/downloads","issues_url":"https://api.github.com/repos/moxcodes/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/moxcodes/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/moxcodes/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/moxcodes/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moxcodes/spectre/labels{/name}","releases_url":"https://api.github.com/repos/moxcodes/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/moxcodes/spectre/deployments","created_at":"2018-09-07T20:39:07Z","updated_at":"2018-11-13T03:23:54Z","pushed_at":"2019-05-15T15:02:02Z","git_url":"git://github.com/moxcodes/spectre.git","ssh_url":"git@github.com:moxcodes/spectre.git","clone_url":"https://github.com/moxcodes/spectre.git","svn_url":"https://github.com/moxcodes/spectre","homepage":"","size":15329,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"d32284e5936d66e7c00ef240767a23b992749e90","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","private":false,"owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2019-05-15T17:37:05Z","pushed_at":"2019-05-15T17:36:57Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"https://spectre-code.org/","size":17903,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":223,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":37,"open_issues":223,"watchers":46,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1522"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1522"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1522/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1522/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/315c0492fc29c63b7dd207b6e64fbc91b348010e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 87570510,
"name": "sxs-collaboration/spectre",
"url": "https://api.github.com/repos/sxs-collaboration/spectre"
}
|
{
"id": 13531030,
"login": "nilsdeppe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13531030?",
"url": "https://api.github.com/users/nilsdeppe"
}
|
{
"id": 26882595,
"login": "sxs-collaboration",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26882595?",
"url": "https://api.github.com/orgs/sxs-collaboration"
}
| 2019-05-15T19:04:06 |
9633605314
|
{"actor":{"display_login":"nilsdeppe"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/comments/352310943","pull_request_review_id":324913769,"id":352310943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjMxMDk0Mw==","diff_hunk":"@@ -3,8 +3,35 @@\n \"runtime\": \"org.freedesktop.Platform\",\n \"runtime-version\": \"19.08\",\n \"sdk\": \"org.freedesktop.Sdk\",\n- \"separate-locales\": false,\n+ \"cleanup\": [\n+ \"/include\",\n+ \"/lib/pkgconfig\",\n+ \"/share/pkgconfig\",","path":"org.mozilla.Firefox.BaseApp.json","position":8,"original_position":8,"commit_id":"259c3c072d08c48e728ac64b2ce359faa5f1e21b","original_commit_id":"259c3c072d08c48e728ac64b2ce359faa5f1e21b","user":{"login":"TingPing","id":798838,"node_id":"MDQ6VXNlcjc5ODgzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/798838?v=4","gravatar_id":"","url":"https://api.github.com/users/TingPing","html_url":"https://github.com/TingPing","followers_url":"https://api.github.com/users/TingPing/followers","following_url":"https://api.github.com/users/TingPing/following{/other_user}","gists_url":"https://api.github.com/users/TingPing/gists{/gist_id}","starred_url":"https://api.github.com/users/TingPing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TingPing/subscriptions","organizations_url":"https://api.github.com/users/TingPing/orgs","repos_url":"https://api.github.com/users/TingPing/repos","events_url":"https://api.github.com/users/TingPing/events{/privacy}","received_events_url":"https://api.github.com/users/TingPing/received_events","type":"User","site_admin":false},"body":"How do you expect Firefox to build without these","created_at":"2019-11-30T23:57:58Z","updated_at":"2019-11-30T23:57:58Z","html_url":"https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/5#discussion_r352310943","pull_request_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/comments/352310943"},"html":{"href":"https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/5#discussion_r352310943"},"pull_request":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5","id":347227300,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MjI3MzAw","html_url":"https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/5","diff_url":"https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/5.diff","patch_url":"https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/5.patch","issue_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/issues/5","number":5,"state":"open","locked":false,"title":"Add gtk2 and libnotify","user":{"login":"Erick555","id":37542552,"node_id":"MDQ6VXNlcjM3NTQyNTUy","avatar_url":"https://avatars2.githubusercontent.com/u/37542552?v=4","gravatar_id":"","url":"https://api.github.com/users/Erick555","html_url":"https://github.com/Erick555","followers_url":"https://api.github.com/users/Erick555/followers","following_url":"https://api.github.com/users/Erick555/following{/other_user}","gists_url":"https://api.github.com/users/Erick555/gists{/gist_id}","starred_url":"https://api.github.com/users/Erick555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Erick555/subscriptions","organizations_url":"https://api.github.com/users/Erick555/orgs","repos_url":"https://api.github.com/users/Erick555/repos","events_url":"https://api.github.com/users/Erick555/events{/privacy}","received_events_url":"https://api.github.com/users/Erick555/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/flathub/org.mozilla.Firefox.BaseApp/issues/4\r\nFixes https://github.com/flathub/org.mozilla.Firefox.BaseApp/issues/3","created_at":"2019-11-30T14:07:28Z","updated_at":"2019-11-30T23:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25f55a5bf8a348d898bf2c518b6abeadce2ce99c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5/commits","review_comments_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5/comments","review_comment_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/issues/5/comments","statuses_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/statuses/259c3c072d08c48e728ac64b2ce359faa5f1e21b","head":{"label":"Erick555:patch-1","ref":"patch-1","sha":"259c3c072d08c48e728ac64b2ce359faa5f1e21b","user":{"login":"Erick555","id":37542552,"node_id":"MDQ6VXNlcjM3NTQyNTUy","avatar_url":"https://avatars2.githubusercontent.com/u/37542552?v=4","gravatar_id":"","url":"https://api.github.com/users/Erick555","html_url":"https://github.com/Erick555","followers_url":"https://api.github.com/users/Erick555/followers","following_url":"https://api.github.com/users/Erick555/following{/other_user}","gists_url":"https://api.github.com/users/Erick555/gists{/gist_id}","starred_url":"https://api.github.com/users/Erick555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Erick555/subscriptions","organizations_url":"https://api.github.com/users/Erick555/orgs","repos_url":"https://api.github.com/users/Erick555/repos","events_url":"https://api.github.com/users/Erick555/events{/privacy}","received_events_url":"https://api.github.com/users/Erick555/received_events","type":"User","site_admin":false},"repo":{"id":225019826,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUwMTk4MjY=","name":"org.mozilla.Firefox.BaseApp","full_name":"Erick555/org.mozilla.Firefox.BaseApp","private":false,"owner":{"login":"Erick555","id":37542552,"node_id":"MDQ6VXNlcjM3NTQyNTUy","avatar_url":"https://avatars2.githubusercontent.com/u/37542552?v=4","gravatar_id":"","url":"https://api.github.com/users/Erick555","html_url":"https://github.com/Erick555","followers_url":"https://api.github.com/users/Erick555/followers","following_url":"https://api.github.com/users/Erick555/following{/other_user}","gists_url":"https://api.github.com/users/Erick555/gists{/gist_id}","starred_url":"https://api.github.com/users/Erick555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Erick555/subscriptions","organizations_url":"https://api.github.com/users/Erick555/orgs","repos_url":"https://api.github.com/users/Erick555/repos","events_url":"https://api.github.com/users/Erick555/events{/privacy}","received_events_url":"https://api.github.com/users/Erick555/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Erick555/org.mozilla.Firefox.BaseApp","description":null,"fork":true,"url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp","forks_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/forks","keys_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/teams","hooks_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/hooks","issue_events_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/issues/events{/number}","events_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/events","assignees_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/assignees{/user}","branches_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/branches{/branch}","tags_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/tags","blobs_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/statuses/{sha}","languages_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/languages","stargazers_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/stargazers","contributors_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/contributors","subscribers_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/subscribers","subscription_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/subscription","commits_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/contents/{+path}","compare_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/merges","archive_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/downloads","issues_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/issues{/number}","pulls_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/pulls{/number}","milestones_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/milestones{/number}","notifications_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/labels{/name}","releases_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/releases{/id}","deployments_url":"https://api.github.com/repos/Erick555/org.mozilla.Firefox.BaseApp/deployments","created_at":"2019-11-30T13:53:41Z","updated_at":"2019-11-30T13:53:43Z","pushed_at":"2019-11-30T14:24:01Z","git_url":"git://github.com/Erick555/org.mozilla.Firefox.BaseApp.git","ssh_url":"git@github.com:Erick555/org.mozilla.Firefox.BaseApp.git","clone_url":"https://github.com/Erick555/org.mozilla.Firefox.BaseApp.git","svn_url":"https://github.com/Erick555/org.mozilla.Firefox.BaseApp","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flathub:master","ref":"master","sha":"27aefecf842a272e856968bba91dd583ff5583e8","user":{"login":"flathub","id":27268838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjY4ODM4","avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"repo":{"id":224898262,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ4OTgyNjI=","name":"org.mozilla.Firefox.BaseApp","full_name":"flathub/org.mozilla.Firefox.BaseApp","private":false,"owner":{"login":"flathub","id":27268838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjY4ODM4","avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flathub/org.mozilla.Firefox.BaseApp","description":null,"fork":false,"url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp","forks_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/forks","keys_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/teams","hooks_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/hooks","issue_events_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/issues/events{/number}","events_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/events","assignees_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/assignees{/user}","branches_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/branches{/branch}","tags_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/tags","blobs_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/statuses/{sha}","languages_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/languages","stargazers_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/stargazers","contributors_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/contributors","subscribers_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/subscribers","subscription_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/subscription","commits_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/contents/{+path}","compare_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/merges","archive_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/downloads","issues_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/issues{/number}","pulls_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls{/number}","milestones_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/milestones{/number}","notifications_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/labels{/name}","releases_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/releases{/id}","deployments_url":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/deployments","created_at":"2019-11-29T17:39:05Z","updated_at":"2019-11-29T20:52:58Z","pushed_at":"2019-11-30T14:24:03Z","git_url":"git://github.com/flathub/org.mozilla.Firefox.BaseApp.git","ssh_url":"git@github.com:flathub/org.mozilla.Firefox.BaseApp.git","clone_url":"https://github.com/flathub/org.mozilla.Firefox.BaseApp.git","svn_url":"https://github.com/flathub/org.mozilla.Firefox.BaseApp","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5"},"html":{"href":"https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/5"},"issue":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/issues/5"},"comments":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp/statuses/259c3c072d08c48e728ac64b2ce359faa5f1e21b"}},"author_association":"NONE"}}
|
{
"id": 224898262,
"name": "flathub/org.mozilla.Firefox.BaseApp",
"url": "https://api.github.com/repos/flathub/org.mozilla.Firefox.BaseApp"
}
|
{
"id": 798838,
"login": "TingPing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/798838?",
"url": "https://api.github.com/users/TingPing"
}
|
{
"id": 27268838,
"login": "flathub",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27268838?",
"url": "https://api.github.com/orgs/flathub"
}
| 2019-11-30T23:57:58 |
10981670745
|
{"actor":{"display_login":"TingPing"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments/307555969","pull_request_review_id":266952391,"id":307555969,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzU1NTk2OQ==","diff_hunk":"@@ -70,5 +70,13 @@ func createDevice(dc common.DeviceConfig) error {\n \tdevice.Id = id\n \tcache.Devices().Add(*device)\n \n+\terr = common.Driver.AddDevice(device.Name, device.Protocols, device.AdminState)","path":"internal/provision/devices.go","position":4,"original_position":4,"commit_id":"f3b2aab8def0b62902c6cb15d2815de0767cae83","original_commit_id":"f3b2aab8def0b62902c6cb15d2815de0767cae83","user":{"login":"cloudxxx8","id":11695863,"node_id":"MDQ6VXNlcjExNjk1ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/11695863?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudxxx8","html_url":"https://github.com/cloudxxx8","followers_url":"https://api.github.com/users/cloudxxx8/followers","following_url":"https://api.github.com/users/cloudxxx8/following{/other_user}","gists_url":"https://api.github.com/users/cloudxxx8/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudxxx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudxxx8/subscriptions","organizations_url":"https://api.github.com/users/cloudxxx8/orgs","repos_url":"https://api.github.com/users/cloudxxx8/repos","events_url":"https://api.github.com/users/cloudxxx8/events{/privacy}","received_events_url":"https://api.github.com/users/cloudxxx8/received_events","type":"User","site_admin":false},"body":"@tonyespy you are right. this is a historical issue.\r\nif you remember, we didn't support Add Device callback from metadata, only update adminState callback supported. At that time, I had to add the pre-defined and existing Devices to cache in provision package. Now, we can remove it.\r\n\r\nCould you please merge this one first and I will remove them in issue #317?\r\nThanks","created_at":"2019-07-26T01:09:58Z","updated_at":"2019-07-26T01:09:58Z","html_url":"https://github.com/edgexfoundry/device-sdk-go/pull/334#discussion_r307555969","pull_request_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments/307555969"},"html":{"href":"https://github.com/edgexfoundry/device-sdk-go/pull/334#discussion_r307555969"},"pull_request":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334"}},"in_reply_to_id":307508353},"pull_request":{"url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334","id":299547931,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NTQ3OTMx","html_url":"https://github.com/edgexfoundry/device-sdk-go/pull/334","diff_url":"https://github.com/edgexfoundry/device-sdk-go/pull/334.diff","patch_url":"https://github.com/edgexfoundry/device-sdk-go/pull/334.patch","issue_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/334","number":334,"state":"open","locked":false,"title":"Add CUD callbacks into ProtocolDriver","user":{"login":"cloudxxx8","id":11695863,"node_id":"MDQ6VXNlcjExNjk1ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/11695863?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudxxx8","html_url":"https://github.com/cloudxxx8","followers_url":"https://api.github.com/users/cloudxxx8/followers","following_url":"https://api.github.com/users/cloudxxx8/following{/other_user}","gists_url":"https://api.github.com/users/cloudxxx8/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudxxx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudxxx8/subscriptions","organizations_url":"https://api.github.com/users/cloudxxx8/orgs","repos_url":"https://api.github.com/users/cloudxxx8/repos","events_url":"https://api.github.com/users/cloudxxx8/events{/privacy}","received_events_url":"https://api.github.com/users/cloudxxx8/received_events","type":"User","site_admin":false},"body":"Add the following callbacks into ProtocolDriver interface:\r\nAddDevice, UpdateDevice, and RemoveDevice\r\nModify device-simple to fit the interface change\r\nModify DriverMock to fit the interface change\r\nInvoke the driver callbacks when Device Service callback and Provision\r\nis executed\r\n\r\nfix https://github.com/edgexfoundry/device-sdk-go/issues/276\r\n\r\nSigned-off-by: Cloud Tsai <cloudxxx8@gmail.com>","created_at":"2019-07-20T08:34:30Z","updated_at":"2019-07-26T01:09:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"986a09199f8f6616f6612d5ac84e5d4dbd32bf74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334/commits","review_comments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334/comments","review_comment_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/334/comments","statuses_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/statuses/f3b2aab8def0b62902c6cb15d2815de0767cae83","head":{"label":"IOTechSystems:issue-276","ref":"issue-276","sha":"f3b2aab8def0b62902c6cb15d2815de0767cae83","user":{"login":"IOTechSystems","id":31407855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDA3ODU1","avatar_url":"https://avatars3.githubusercontent.com/u/31407855?v=4","gravatar_id":"","url":"https://api.github.com/users/IOTechSystems","html_url":"https://github.com/IOTechSystems","followers_url":"https://api.github.com/users/IOTechSystems/followers","following_url":"https://api.github.com/users/IOTechSystems/following{/other_user}","gists_url":"https://api.github.com/users/IOTechSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/IOTechSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOTechSystems/subscriptions","organizations_url":"https://api.github.com/users/IOTechSystems/orgs","repos_url":"https://api.github.com/users/IOTechSystems/repos","events_url":"https://api.github.com/users/IOTechSystems/events{/privacy}","received_events_url":"https://api.github.com/users/IOTechSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":143713164,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MTMxNjQ=","name":"device-sdk-go","full_name":"IOTechSystems/device-sdk-go","private":false,"owner":{"login":"IOTechSystems","id":31407855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDA3ODU1","avatar_url":"https://avatars3.githubusercontent.com/u/31407855?v=4","gravatar_id":"","url":"https://api.github.com/users/IOTechSystems","html_url":"https://github.com/IOTechSystems","followers_url":"https://api.github.com/users/IOTechSystems/followers","following_url":"https://api.github.com/users/IOTechSystems/following{/other_user}","gists_url":"https://api.github.com/users/IOTechSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/IOTechSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOTechSystems/subscriptions","organizations_url":"https://api.github.com/users/IOTechSystems/orgs","repos_url":"https://api.github.com/users/IOTechSystems/repos","events_url":"https://api.github.com/users/IOTechSystems/events{/privacy}","received_events_url":"https://api.github.com/users/IOTechSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IOTechSystems/device-sdk-go","description":null,"fork":true,"url":"https://api.github.com/repos/IOTechSystems/device-sdk-go","forks_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/forks","keys_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/teams","hooks_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/events","assignees_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/tags","blobs_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/languages","stargazers_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/subscription","commits_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/merges","archive_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/downloads","issues_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/deployments","created_at":"2018-08-06T10:30:06Z","updated_at":"2019-07-22T15:08:05Z","pushed_at":"2019-07-22T15:17:04Z","git_url":"git://github.com/IOTechSystems/device-sdk-go.git","ssh_url":"git@github.com:IOTechSystems/device-sdk-go.git","clone_url":"https://github.com/IOTechSystems/device-sdk-go.git","svn_url":"https://github.com/IOTechSystems/device-sdk-go","homepage":null,"size":737,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"edgexfoundry:master","ref":"master","sha":"1a0a5d328b1ed62c625bd80742283536095111bc","user":{"login":"edgexfoundry","id":27781926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzgxOTI2","avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":142326038,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMjYwMzg=","name":"device-sdk-go","full_name":"edgexfoundry/device-sdk-go","private":false,"owner":{"login":"edgexfoundry","id":27781926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzgxOTI2","avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edgexfoundry/device-sdk-go","description":null,"fork":false,"url":"https://api.github.com/repos/edgexfoundry/device-sdk-go","forks_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/forks","keys_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/teams","hooks_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/events","assignees_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/tags","blobs_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/languages","stargazers_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/subscription","commits_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/merges","archive_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/downloads","issues_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/deployments","created_at":"2018-07-25T16:27:16Z","updated_at":"2019-07-23T09:39:19Z","pushed_at":"2019-07-22T19:45:44Z","git_url":"git://github.com/edgexfoundry/device-sdk-go.git","ssh_url":"git@github.com:edgexfoundry/device-sdk-go.git","clone_url":"https://github.com/edgexfoundry/device-sdk-go.git","svn_url":"https://github.com/edgexfoundry/device-sdk-go","homepage":null,"size":722,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":31,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334"},"html":{"href":"https://github.com/edgexfoundry/device-sdk-go/pull/334"},"issue":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/334"},"comments":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/statuses/f3b2aab8def0b62902c6cb15d2815de0767cae83"}},"author_association":"MEMBER"}}
|
{
"id": 142326038,
"name": "edgexfoundry/device-sdk-go",
"url": "https://api.github.com/repos/edgexfoundry/device-sdk-go"
}
|
{
"id": 11695863,
"login": "cloudxxx8",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11695863?",
"url": "https://api.github.com/users/cloudxxx8"
}
|
{
"id": 27781926,
"login": "edgexfoundry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27781926?",
"url": "https://api.github.com/orgs/edgexfoundry"
}
| 2019-07-26T01:09:58 |
10087530939
|
{"actor":{"display_login":"cloudxxx8"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/comments/362952961","pull_request_review_id":338264105,"id":362952961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2Mjk1Mjk2MQ==","diff_hunk":"@@ -1,3 +1,5 @@\n FROM open-liberty\n \n-ADD --chown=1001:0 target/inventory.tar.gz /opt/ol\n+COPY src/main/liberty/config /config/","path":"finish/inventory/Dockerfile","position":4,"original_position":4,"commit_id":"a955571b2870d836499dbf04ee7b3b7fd22a3a58","original_commit_id":"a955571b2870d836499dbf04ee7b3b7fd22a3a58","user":{"login":"evelinec","id":33134427,"node_id":"MDQ6VXNlcjMzMTM0NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/33134427?v=4","gravatar_id":"","url":"https://api.github.com/users/evelinec","html_url":"https://github.com/evelinec","followers_url":"https://api.github.com/users/evelinec/followers","following_url":"https://api.github.com/users/evelinec/following{/other_user}","gists_url":"https://api.github.com/users/evelinec/gists{/gist_id}","starred_url":"https://api.github.com/users/evelinec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evelinec/subscriptions","organizations_url":"https://api.github.com/users/evelinec/orgs","repos_url":"https://api.github.com/users/evelinec/repos","events_url":"https://api.github.com/users/evelinec/events{/privacy}","received_events_url":"https://api.github.com/users/evelinec/received_events","type":"User","site_admin":false},"body":"May need to use `COPY --chown=1001:0`?","created_at":"2020-01-03T20:36:13Z","updated_at":"2020-01-03T20:40:32Z","html_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health/pull/72#discussion_r362952961","pull_request_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/comments/362952961"},"html":{"href":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health/pull/72#discussion_r362952961"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72","id":357328388,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3MzI4Mzg4","html_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health/pull/72","diff_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health/pull/72.diff","patch_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health/pull/72.patch","issue_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/72","number":72,"state":"open","locked":false,"title":"Dev mode","user":{"login":"NimG98","id":46586499,"node_id":"MDQ6VXNlcjQ2NTg2NDk5","avatar_url":"https://avatars1.githubusercontent.com/u/46586499?v=4","gravatar_id":"","url":"https://api.github.com/users/NimG98","html_url":"https://github.com/NimG98","followers_url":"https://api.github.com/users/NimG98/followers","following_url":"https://api.github.com/users/NimG98/following{/other_user}","gists_url":"https://api.github.com/users/NimG98/gists{/gist_id}","starred_url":"https://api.github.com/users/NimG98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NimG98/subscriptions","organizations_url":"https://api.github.com/users/NimG98/orgs","repos_url":"https://api.github.com/users/NimG98/repos","events_url":"https://api.github.com/users/NimG98/events{/privacy}","received_events_url":"https://api.github.com/users/NimG98/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-27T21:06:10Z","updated_at":"2020-01-03T20:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3dfdfe661618e8c98224aa795e874106f6e4d0a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/72/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/statuses/a955571b2870d836499dbf04ee7b3b7fd22a3a58","head":{"label":"OpenLiberty:dev-mode","ref":"dev-mode","sha":"a955571b2870d836499dbf04ee7b3b7fd22a3a58","user":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":151475165,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE0NzUxNjU=","name":"guide-kubernetes-microprofile-health","full_name":"OpenLiberty/guide-kubernetes-microprofile-health","private":false,"owner":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health","description":"A guide on how to check the health of microservices on Kubernetes by setting up readiness probes to inspect MicroProfile Health Check endpoints: https://openliberty.io/guides/kubernetes-microprofile-health.html","fork":false,"url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health","forks_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/forks","keys_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/events","assignees_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/merges","archive_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/deployments","created_at":"2018-10-03T20:19:40Z","updated_at":"2019-10-18T15:46:44Z","pushed_at":"2019-12-31T19:37:41Z","git_url":"git://github.com/OpenLiberty/guide-kubernetes-microprofile-health.git","ssh_url":"git@github.com:OpenLiberty/guide-kubernetes-microprofile-health.git","clone_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health.git","svn_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health","homepage":"","size":188,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"OpenLiberty:qa","ref":"qa","sha":"63b69de8e27955858dc2d8879b3ecc32728a56fc","user":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":151475165,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE0NzUxNjU=","name":"guide-kubernetes-microprofile-health","full_name":"OpenLiberty/guide-kubernetes-microprofile-health","private":false,"owner":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health","description":"A guide on how to check the health of microservices on Kubernetes by setting up readiness probes to inspect MicroProfile Health Check endpoints: https://openliberty.io/guides/kubernetes-microprofile-health.html","fork":false,"url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health","forks_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/forks","keys_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/events","assignees_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/merges","archive_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/deployments","created_at":"2018-10-03T20:19:40Z","updated_at":"2019-10-18T15:46:44Z","pushed_at":"2019-12-31T19:37:41Z","git_url":"git://github.com/OpenLiberty/guide-kubernetes-microprofile-health.git","ssh_url":"git@github.com:OpenLiberty/guide-kubernetes-microprofile-health.git","clone_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health.git","svn_url":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health","homepage":"","size":188,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72"},"html":{"href":"https://github.com/OpenLiberty/guide-kubernetes-microprofile-health/pull/72"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/72"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health/statuses/a955571b2870d836499dbf04ee7b3b7fd22a3a58"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 151475165,
"name": "OpenLiberty/guide-kubernetes-microprofile-health",
"url": "https://api.github.com/repos/OpenLiberty/guide-kubernetes-microprofile-health"
}
|
{
"id": 33134427,
"login": "evelinec",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33134427?",
"url": "https://api.github.com/users/evelinec"
}
|
{
"id": 28316667,
"login": "OpenLiberty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28316667?",
"url": "https://api.github.com/orgs/OpenLiberty"
}
| 2020-01-03T20:36:13 |
11200092320
|
{"actor":{"display_login":"evelinec"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/comments/274962265","pull_request_review_id":226153715,"id":274962265,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NDk2MjI2NQ==","diff_hunk":"@@ -78,39 +78,53 @@ pipeline {\n stage('Build & Deploy (Production)') {\n agent { label 'linux-slave' }\n when { branch \"master\" }\n- steps {\n- script {\n- GIT_SHORT_SHA = sh ( script: \"git rev-parse --short HEAD\", returnStdout: true ).trim()\n- PKG_VERSION = sh ( script: \"node -pe \\\"require('./package.json').version\\\"\", returnStdout: true ).trim()\n+ environment {\n+ GIT_SHORT_SHA = sh ( script: \"git rev-parse --short HEAD\", returnStdout: true ).trim()\n+ PKG_VERSION = sh ( script: \"node -pe \\\"require('./package.json').version\\\"\", returnStdout: true ).trim()\n \n- BUILD_VERSION = PKG_VERSION\n- CHANNEL = \"stable\"\n- SERVICE_NAME = \"fdc3\"\n- MANIFEST_NAME = \"app.json\"\n+ BUILD_VERSION = \"PKG_VERSION\"\n+ CHANNEL = \"stable\"\n+ SERVICE_NAME = \"fdc3\"\n+ MANIFEST_NAME = \"app.json\"\n \n- S3_LOC = env.DSERVICE_S3_ROOT + SERVICE_NAME + \"/\" + BUILD_VERSION\n- DOCS_CHANNEL_LOC = env.DSERVICE_S3_ROOT_DOCS + SERVICE_NAME + \"/\" + CHANNEL\n- DOCS_VERSIONED_LOC = env.DSERVICE_S3_ROOT_DOCS + SERVICE_NAME + \"/\" + BUILD_VERSION\n- MANIFEST_LOC = env.DSERVICE_S3_ROOT + SERVICE_NAME + \"/\" + MANIFEST_NAME\n- }\n- sh \"npm i --ignore-scripts\"\n- sh \"SERVICE_VERSION=${BUILD_VERSION} npm run build\"\n- sh \"echo ${GIT_SHORT_SHA} > ./dist/SHA.txt\"\n- sh \"npm run zip\"\n- sh \"npm run docs\"\n- sh \"aws s3 cp ./res/provider ${S3_LOC}/ --recursive\"\n- sh \"aws s3 cp ./dist/provider ${S3_LOC}/ --recursive\"\n- sh \"aws s3 cp ./dist/client/openfin-\" + SERVICE_NAME + \".js ${S3_LOC}/\"\n-\n- sh \"aws s3 cp ./dist/docs ${DOCS_CHANNEL_LOC} --recursive\"\n- sh \"aws s3 cp ./dist/docs ${DOCS_VERSIONED_LOC} --recursive\"\n- sh \"aws s3 cp ./dist/provider/app.json ${MANIFEST_LOC}\"\n+ S3_LOC = \"env.DSERVICE_S3_ROOT\" + \"SERVICE_NAME\" + \"/\" + \"BUILD_VERSION\"\n+ DOCS_CHANNEL_LOC = \"env.DSERVICE_S3_ROOT_DOCS\" + \"SERVICE_NAME\" + \"/\" + \"CHANNEL\"\n+ DOCS_VERSIONED_LOC = \"env.DSERVICE_S3_ROOT_DOCS\" + \"SERVICE_NAME\" + \"/\" + \"BUILD_VERSION\"\n+ MANIFEST_LOC = \"env.DSERVICE_S3_ROOT\" + \"SERVICE_NAME\" + \"/\" + \"MANIFEST_NAME\"","path":"Jenkinsfile","position":50,"original_position":50,"commit_id":"5b4f82fa0103c31c29ae8dd7a6a9c0eb9e4ac078","original_commit_id":"5b4f82fa0103c31c29ae8dd7a6a9c0eb9e4ac078","user":{"login":"MichaelMCoates","id":19475484,"node_id":"MDQ6VXNlcjE5NDc1NDg0","avatar_url":"https://avatars3.githubusercontent.com/u/19475484?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelMCoates","html_url":"https://github.com/MichaelMCoates","followers_url":"https://api.github.com/users/MichaelMCoates/followers","following_url":"https://api.github.com/users/MichaelMCoates/following{/other_user}","gists_url":"https://api.github.com/users/MichaelMCoates/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelMCoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelMCoates/subscriptions","organizations_url":"https://api.github.com/users/MichaelMCoates/orgs","repos_url":"https://api.github.com/users/MichaelMCoates/repos","events_url":"https://api.github.com/users/MichaelMCoates/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelMCoates/received_events","type":"User","site_admin":false},"body":"Ahhhh strange, I thought I had that working properly beforehand. Changing over to the string interpolation","created_at":"2019-04-12T15:41:10Z","updated_at":"2019-04-12T15:41:10Z","html_url":"https://github.com/HadoukenIO/fdc3-service/pull/55#discussion_r274962265","pull_request_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/comments/274962265"},"html":{"href":"https://github.com/HadoukenIO/fdc3-service/pull/55#discussion_r274962265"},"pull_request":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55"}},"in_reply_to_id":274470414},"pull_request":{"url":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55","id":269605746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5NjA1NzQ2","html_url":"https://github.com/HadoukenIO/fdc3-service/pull/55","diff_url":"https://github.com/HadoukenIO/fdc3-service/pull/55.diff","patch_url":"https://github.com/HadoukenIO/fdc3-service/pull/55.patch","issue_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/issues/55","number":55,"state":"open","locked":false,"title":"[SERVICE-436] Change production pipeline to require user interaction to deploy to NPM.","user":{"login":"MichaelMCoates","id":19475484,"node_id":"MDQ6VXNlcjE5NDc1NDg0","avatar_url":"https://avatars3.githubusercontent.com/u/19475484?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelMCoates","html_url":"https://github.com/MichaelMCoates","followers_url":"https://api.github.com/users/MichaelMCoates/followers","following_url":"https://api.github.com/users/MichaelMCoates/following{/other_user}","gists_url":"https://api.github.com/users/MichaelMCoates/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelMCoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelMCoates/subscriptions","organizations_url":"https://api.github.com/users/MichaelMCoates/orgs","repos_url":"https://api.github.com/users/MichaelMCoates/repos","events_url":"https://api.github.com/users/MichaelMCoates/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelMCoates/received_events","type":"User","site_admin":false},"body":"Split the production pipeline into two stages - one that deploys to CDN and one that deploys to NPM. In the NPM stage, we take in a user input to choose whether or not we deploy. ","created_at":"2019-04-11T14:44:55Z","updated_at":"2019-04-12T15:41:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aec9727241bf0169ac5bae5022f9bdf13d869d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1003500578,"node_id":"MDU6TGFiZWwxMDAzNTAwNTc4","url":"https://api.github.com/repos/HadoukenIO/fdc3-service/labels/cla-present","name":"cla-present","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55/commits","review_comments_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55/comments","review_comment_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/issues/55/comments","statuses_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/statuses/5b4f82fa0103c31c29ae8dd7a6a9c0eb9e4ac078","head":{"label":"MichaelMCoates:dev/coates/SERVICE-436","ref":"dev/coates/SERVICE-436","sha":"5b4f82fa0103c31c29ae8dd7a6a9c0eb9e4ac078","user":{"login":"MichaelMCoates","id":19475484,"node_id":"MDQ6VXNlcjE5NDc1NDg0","avatar_url":"https://avatars3.githubusercontent.com/u/19475484?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelMCoates","html_url":"https://github.com/MichaelMCoates","followers_url":"https://api.github.com/users/MichaelMCoates/followers","following_url":"https://api.github.com/users/MichaelMCoates/following{/other_user}","gists_url":"https://api.github.com/users/MichaelMCoates/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelMCoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelMCoates/subscriptions","organizations_url":"https://api.github.com/users/MichaelMCoates/orgs","repos_url":"https://api.github.com/users/MichaelMCoates/repos","events_url":"https://api.github.com/users/MichaelMCoates/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelMCoates/received_events","type":"User","site_admin":false},"repo":{"id":178937342,"node_id":"MDEwOlJlcG9zaXRvcnkxNzg5MzczNDI=","name":"fdc3-service","full_name":"MichaelMCoates/fdc3-service","private":false,"owner":{"login":"MichaelMCoates","id":19475484,"node_id":"MDQ6VXNlcjE5NDc1NDg0","avatar_url":"https://avatars3.githubusercontent.com/u/19475484?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelMCoates","html_url":"https://github.com/MichaelMCoates","followers_url":"https://api.github.com/users/MichaelMCoates/followers","following_url":"https://api.github.com/users/MichaelMCoates/following{/other_user}","gists_url":"https://api.github.com/users/MichaelMCoates/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelMCoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelMCoates/subscriptions","organizations_url":"https://api.github.com/users/MichaelMCoates/orgs","repos_url":"https://api.github.com/users/MichaelMCoates/repos","events_url":"https://api.github.com/users/MichaelMCoates/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelMCoates/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MichaelMCoates/fdc3-service","description":"FDC3 Service for OpenFin","fork":true,"url":"https://api.github.com/repos/MichaelMCoates/fdc3-service","forks_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/forks","keys_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/teams","hooks_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/hooks","issue_events_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/issues/events{/number}","events_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/events","assignees_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/assignees{/user}","branches_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/branches{/branch}","tags_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/tags","blobs_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/statuses/{sha}","languages_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/languages","stargazers_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/stargazers","contributors_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/contributors","subscribers_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/subscribers","subscription_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/subscription","commits_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/contents/{+path}","compare_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/merges","archive_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/downloads","issues_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/issues{/number}","pulls_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/pulls{/number}","milestones_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/milestones{/number}","notifications_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/labels{/name}","releases_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/releases{/id}","deployments_url":"https://api.github.com/repos/MichaelMCoates/fdc3-service/deployments","created_at":"2019-04-01T19:57:04Z","updated_at":"2019-04-01T19:57:06Z","pushed_at":"2019-04-11T14:51:31Z","git_url":"git://github.com/MichaelMCoates/fdc3-service.git","ssh_url":"git@github.com:MichaelMCoates/fdc3-service.git","clone_url":"https://github.com/MichaelMCoates/fdc3-service.git","svn_url":"https://github.com/MichaelMCoates/fdc3-service","homepage":null,"size":759,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HadoukenIO:develop","ref":"develop","sha":"fa104db40d9d42f3f7737971089cc9d412a9fca8","user":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"repo":{"id":142158037,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxNTgwMzc=","name":"fdc3-service","full_name":"HadoukenIO/fdc3-service","private":false,"owner":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HadoukenIO/fdc3-service","description":"FDC3 Service for OpenFin","fork":false,"url":"https://api.github.com/repos/HadoukenIO/fdc3-service","forks_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/forks","keys_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/teams","hooks_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/hooks","issue_events_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/issues/events{/number}","events_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/events","assignees_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/assignees{/user}","branches_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/branches{/branch}","tags_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/tags","blobs_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/statuses/{sha}","languages_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/languages","stargazers_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/stargazers","contributors_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/contributors","subscribers_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/subscribers","subscription_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/subscription","commits_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/contents/{+path}","compare_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/merges","archive_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/downloads","issues_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/issues{/number}","pulls_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls{/number}","milestones_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/milestones{/number}","notifications_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/labels{/name}","releases_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/releases{/id}","deployments_url":"https://api.github.com/repos/HadoukenIO/fdc3-service/deployments","created_at":"2018-07-24T12:52:21Z","updated_at":"2019-04-12T12:34:21Z","pushed_at":"2019-04-12T12:57:09Z","git_url":"git://github.com/HadoukenIO/fdc3-service.git","ssh_url":"git@github.com:HadoukenIO/fdc3-service.git","clone_url":"https://github.com/HadoukenIO/fdc3-service.git","svn_url":"https://github.com/HadoukenIO/fdc3-service","homepage":null,"size":755,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":5,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55"},"html":{"href":"https://github.com/HadoukenIO/fdc3-service/pull/55"},"issue":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/issues/55"},"comments":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/HadoukenIO/fdc3-service/statuses/5b4f82fa0103c31c29ae8dd7a6a9c0eb9e4ac078"}},"author_association":"COLLABORATOR"}}
|
{
"id": 142158037,
"name": "HadoukenIO/fdc3-service",
"url": "https://api.github.com/repos/HadoukenIO/fdc3-service"
}
|
{
"id": 19475484,
"login": "MichaelMCoates",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19475484?",
"url": "https://api.github.com/users/MichaelMCoates"
}
|
{
"id": 28318664,
"login": "HadoukenIO",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28318664?",
"url": "https://api.github.com/orgs/HadoukenIO"
}
| 2019-04-12T15:41:10 |
9433159117
|
{"actor":{"display_login":"MichaelMCoates"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/comments/320795812","pull_request_review_id":283663763,"id":320795812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDc5NTgxMg==","diff_hunk":"@@ -2,11 +2,14 @@ import {addSpawnListeners, createApp, createWindow} from 'openfin-service-toolin\n \n import * as ofnotes from '../client/index';\n import {NotificationOptions, NotificationActionEvent, NotificationClosedEvent, NotificationCreatedEvent, create, addEventListener, clear, getAll} from '../client/index';\n+import {Events} from '../client/internal';\n \n addSpawnListeners();\n \n+const receivedEvents: Events[] = [];\n+\n // Mount createWindow and createApp on the window to be used by puppeteer","path":"src/demo/app.ts","position":10,"original_position":10,"commit_id":"ce3b32000bd01eed47edfefdea618f4cbdd02145","original_commit_id":"9bc742c24181d5ac45054f1792523b6eaabd38dd","user":{"login":"bryangaleOF","id":47325366,"node_id":"MDQ6VXNlcjQ3MzI1MzY2","avatar_url":"https://avatars1.githubusercontent.com/u/47325366?v=4","gravatar_id":"","url":"https://api.github.com/users/bryangaleOF","html_url":"https://github.com/bryangaleOF","followers_url":"https://api.github.com/users/bryangaleOF/followers","following_url":"https://api.github.com/users/bryangaleOF/following{/other_user}","gists_url":"https://api.github.com/users/bryangaleOF/gists{/gist_id}","starred_url":"https://api.github.com/users/bryangaleOF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryangaleOF/subscriptions","organizations_url":"https://api.github.com/users/bryangaleOF/orgs","repos_url":"https://api.github.com/users/bryangaleOF/repos","events_url":"https://api.github.com/users/bryangaleOF/events{/privacy}","received_events_url":"https://api.github.com/users/bryangaleOF/received_events","type":"User","site_admin":false},"body":"✅","created_at":"2019-09-04T14:36:03Z","updated_at":"2019-09-04T14:36:03Z","html_url":"https://github.com/HadoukenIO/notifications-service/pull/110#discussion_r320795812","pull_request_url":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/comments/320795812"},"html":{"href":"https://github.com/HadoukenIO/notifications-service/pull/110#discussion_r320795812"},"pull_request":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110"}},"in_reply_to_id":320711640},"pull_request":{"url":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110","id":313239666,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzMjM5NjY2","html_url":"https://github.com/HadoukenIO/notifications-service/pull/110","diff_url":"https://github.com/HadoukenIO/notifications-service/pull/110.diff","patch_url":"https://github.com/HadoukenIO/notifications-service/pull/110.patch","issue_url":"https://api.github.com/repos/HadoukenIO/notifications-service/issues/110","number":110,"state":"open","locked":false,"title":"[SERVICE-526][Partial] Testing back-fill: Create Notification unit tests (EventPump, fixes and organisation)","user":{"login":"bryangaleOF","id":47325366,"node_id":"MDQ6VXNlcjQ3MzI1MzY2","avatar_url":"https://avatars1.githubusercontent.com/u/47325366?v=4","gravatar_id":"","url":"https://api.github.com/users/bryangaleOF","html_url":"https://github.com/bryangaleOF","followers_url":"https://api.github.com/users/bryangaleOF/followers","following_url":"https://api.github.com/users/bryangaleOF/following{/other_user}","gists_url":"https://api.github.com/users/bryangaleOF/gists{/gist_id}","starred_url":"https://api.github.com/users/bryangaleOF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryangaleOF/subscriptions","organizations_url":"https://api.github.com/users/bryangaleOF/orgs","repos_url":"https://api.github.com/users/bryangaleOF/repos","events_url":"https://api.github.com/users/bryangaleOF/events{/privacy}","received_events_url":"https://api.github.com/users/bryangaleOF/received_events","type":"User","site_admin":false},"body":"This PR:\r\n- Adds unit testing around EventPump, and more tests around ClientRegistry\r\n- Fixes a bug in ClientRegistry, and adds integration tests that catches this bug (no events received of any type if a `notification-action` listener is not registered)\r\n- Organises unit test files to closely mirror the modules they're testing\r\n- Standardizes on using `test(` everywhere, rather than `it(`\r\n- Moves towards an approach where everything is mocked by default, and we need to go out of or way to get the 'real' version of something for testing. See use of `jest.mock` in `mocks.ts`, and use of `jest.unmock` and `jest.requireActual` to override mocking","created_at":"2019-09-02T12:11:48Z","updated_at":"2019-09-04T14:36:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13f5b39bb4f07547bbd8092bca6d514dfa65c952","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":940329502,"node_id":"MDU6TGFiZWw5NDAzMjk1MDI=","url":"https://api.github.com/repos/HadoukenIO/notifications-service/labels/cla-present","name":"cla-present","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110/commits","review_comments_url":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110/comments","review_comment_url":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HadoukenIO/notifications-service/issues/110/comments","statuses_url":"https://api.github.com/repos/HadoukenIO/notifications-service/statuses/ce3b32000bd01eed47edfefdea618f4cbdd02145","head":{"label":"bryangaleOF:dev/bryan/SERVICE-526-2-eventpump-tests","ref":"dev/bryan/SERVICE-526-2-eventpump-tests","sha":"ce3b32000bd01eed47edfefdea618f4cbdd02145","user":{"login":"bryangaleOF","id":47325366,"node_id":"MDQ6VXNlcjQ3MzI1MzY2","avatar_url":"https://avatars1.githubusercontent.com/u/47325366?v=4","gravatar_id":"","url":"https://api.github.com/users/bryangaleOF","html_url":"https://github.com/bryangaleOF","followers_url":"https://api.github.com/users/bryangaleOF/followers","following_url":"https://api.github.com/users/bryangaleOF/following{/other_user}","gists_url":"https://api.github.com/users/bryangaleOF/gists{/gist_id}","starred_url":"https://api.github.com/users/bryangaleOF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryangaleOF/subscriptions","organizations_url":"https://api.github.com/users/bryangaleOF/orgs","repos_url":"https://api.github.com/users/bryangaleOF/repos","events_url":"https://api.github.com/users/bryangaleOF/events{/privacy}","received_events_url":"https://api.github.com/users/bryangaleOF/received_events","type":"User","site_admin":false},"repo":{"id":173733188,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MzMxODg=","name":"notifications-service","full_name":"bryangaleOF/notifications-service","private":false,"owner":{"login":"bryangaleOF","id":47325366,"node_id":"MDQ6VXNlcjQ3MzI1MzY2","avatar_url":"https://avatars1.githubusercontent.com/u/47325366?v=4","gravatar_id":"","url":"https://api.github.com/users/bryangaleOF","html_url":"https://github.com/bryangaleOF","followers_url":"https://api.github.com/users/bryangaleOF/followers","following_url":"https://api.github.com/users/bryangaleOF/following{/other_user}","gists_url":"https://api.github.com/users/bryangaleOF/gists{/gist_id}","starred_url":"https://api.github.com/users/bryangaleOF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryangaleOF/subscriptions","organizations_url":"https://api.github.com/users/bryangaleOF/orgs","repos_url":"https://api.github.com/users/bryangaleOF/repos","events_url":"https://api.github.com/users/bryangaleOF/events{/privacy}","received_events_url":"https://api.github.com/users/bryangaleOF/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bryangaleOF/notifications-service","description":"Notifications Desktop Service","fork":true,"url":"https://api.github.com/repos/bryangaleOF/notifications-service","forks_url":"https://api.github.com/repos/bryangaleOF/notifications-service/forks","keys_url":"https://api.github.com/repos/bryangaleOF/notifications-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryangaleOF/notifications-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryangaleOF/notifications-service/teams","hooks_url":"https://api.github.com/repos/bryangaleOF/notifications-service/hooks","issue_events_url":"https://api.github.com/repos/bryangaleOF/notifications-service/issues/events{/number}","events_url":"https://api.github.com/repos/bryangaleOF/notifications-service/events","assignees_url":"https://api.github.com/repos/bryangaleOF/notifications-service/assignees{/user}","branches_url":"https://api.github.com/repos/bryangaleOF/notifications-service/branches{/branch}","tags_url":"https://api.github.com/repos/bryangaleOF/notifications-service/tags","blobs_url":"https://api.github.com/repos/bryangaleOF/notifications-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryangaleOF/notifications-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryangaleOF/notifications-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryangaleOF/notifications-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryangaleOF/notifications-service/statuses/{sha}","languages_url":"https://api.github.com/repos/bryangaleOF/notifications-service/languages","stargazers_url":"https://api.github.com/repos/bryangaleOF/notifications-service/stargazers","contributors_url":"https://api.github.com/repos/bryangaleOF/notifications-service/contributors","subscribers_url":"https://api.github.com/repos/bryangaleOF/notifications-service/subscribers","subscription_url":"https://api.github.com/repos/bryangaleOF/notifications-service/subscription","commits_url":"https://api.github.com/repos/bryangaleOF/notifications-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryangaleOF/notifications-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryangaleOF/notifications-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryangaleOF/notifications-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryangaleOF/notifications-service/contents/{+path}","compare_url":"https://api.github.com/repos/bryangaleOF/notifications-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryangaleOF/notifications-service/merges","archive_url":"https://api.github.com/repos/bryangaleOF/notifications-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryangaleOF/notifications-service/downloads","issues_url":"https://api.github.com/repos/bryangaleOF/notifications-service/issues{/number}","pulls_url":"https://api.github.com/repos/bryangaleOF/notifications-service/pulls{/number}","milestones_url":"https://api.github.com/repos/bryangaleOF/notifications-service/milestones{/number}","notifications_url":"https://api.github.com/repos/bryangaleOF/notifications-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryangaleOF/notifications-service/labels{/name}","releases_url":"https://api.github.com/repos/bryangaleOF/notifications-service/releases{/id}","deployments_url":"https://api.github.com/repos/bryangaleOF/notifications-service/deployments","created_at":"2019-03-04T11:35:18Z","updated_at":"2019-03-04T11:35:21Z","pushed_at":"2019-09-04T14:15:51Z","git_url":"git://github.com/bryangaleOF/notifications-service.git","ssh_url":"git@github.com:bryangaleOF/notifications-service.git","clone_url":"https://github.com/bryangaleOF/notifications-service.git","svn_url":"https://github.com/bryangaleOF/notifications-service","homepage":"","size":7087,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HadoukenIO:develop","ref":"develop","sha":"dcc2d70ac4c9fc8d6e60fb856d43617e1a5ddefb","user":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"repo":{"id":131767654,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3Njc2NTQ=","name":"notifications-service","full_name":"HadoukenIO/notifications-service","private":false,"owner":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HadoukenIO/notifications-service","description":"Notifications Desktop Service","fork":false,"url":"https://api.github.com/repos/HadoukenIO/notifications-service","forks_url":"https://api.github.com/repos/HadoukenIO/notifications-service/forks","keys_url":"https://api.github.com/repos/HadoukenIO/notifications-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HadoukenIO/notifications-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HadoukenIO/notifications-service/teams","hooks_url":"https://api.github.com/repos/HadoukenIO/notifications-service/hooks","issue_events_url":"https://api.github.com/repos/HadoukenIO/notifications-service/issues/events{/number}","events_url":"https://api.github.com/repos/HadoukenIO/notifications-service/events","assignees_url":"https://api.github.com/repos/HadoukenIO/notifications-service/assignees{/user}","branches_url":"https://api.github.com/repos/HadoukenIO/notifications-service/branches{/branch}","tags_url":"https://api.github.com/repos/HadoukenIO/notifications-service/tags","blobs_url":"https://api.github.com/repos/HadoukenIO/notifications-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HadoukenIO/notifications-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HadoukenIO/notifications-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/HadoukenIO/notifications-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HadoukenIO/notifications-service/statuses/{sha}","languages_url":"https://api.github.com/repos/HadoukenIO/notifications-service/languages","stargazers_url":"https://api.github.com/repos/HadoukenIO/notifications-service/stargazers","contributors_url":"https://api.github.com/repos/HadoukenIO/notifications-service/contributors","subscribers_url":"https://api.github.com/repos/HadoukenIO/notifications-service/subscribers","subscription_url":"https://api.github.com/repos/HadoukenIO/notifications-service/subscription","commits_url":"https://api.github.com/repos/HadoukenIO/notifications-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/HadoukenIO/notifications-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/HadoukenIO/notifications-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/HadoukenIO/notifications-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/HadoukenIO/notifications-service/contents/{+path}","compare_url":"https://api.github.com/repos/HadoukenIO/notifications-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HadoukenIO/notifications-service/merges","archive_url":"https://api.github.com/repos/HadoukenIO/notifications-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HadoukenIO/notifications-service/downloads","issues_url":"https://api.github.com/repos/HadoukenIO/notifications-service/issues{/number}","pulls_url":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls{/number}","milestones_url":"https://api.github.com/repos/HadoukenIO/notifications-service/milestones{/number}","notifications_url":"https://api.github.com/repos/HadoukenIO/notifications-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HadoukenIO/notifications-service/labels{/name}","releases_url":"https://api.github.com/repos/HadoukenIO/notifications-service/releases{/id}","deployments_url":"https://api.github.com/repos/HadoukenIO/notifications-service/deployments","created_at":"2018-05-01T22:01:51Z","updated_at":"2019-09-04T11:23:52Z","pushed_at":"2019-09-04T14:15:53Z","git_url":"git://github.com/HadoukenIO/notifications-service.git","ssh_url":"git@github.com:HadoukenIO/notifications-service.git","clone_url":"https://github.com/HadoukenIO/notifications-service.git","svn_url":"https://github.com/HadoukenIO/notifications-service","homepage":"","size":8795,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":6,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110"},"html":{"href":"https://github.com/HadoukenIO/notifications-service/pull/110"},"issue":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/issues/110"},"comments":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/HadoukenIO/notifications-service/statuses/ce3b32000bd01eed47edfefdea618f4cbdd02145"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 131767654,
"name": "HadoukenIO/notifications-service",
"url": "https://api.github.com/repos/HadoukenIO/notifications-service"
}
|
{
"id": 47325366,
"login": "bryangaleOF",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47325366?",
"url": "https://api.github.com/users/bryangaleOF"
}
|
{
"id": 28318664,
"login": "HadoukenIO",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28318664?",
"url": "https://api.github.com/orgs/HadoukenIO"
}
| 2019-09-04T14:36:03 |
10346054249
|
{"actor":{"display_login":"bryangaleOF"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/comments/361450314","pull_request_review_id":336514626,"id":361450314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTQ1MDMxNA==","diff_hunk":"@@ -7,6 +7,218 @@\n <link rel=\"stylesheet\" href=\"./styles/main.css\">\n </head>\n <body>\n- <h1>Catalog</h1>\n+ <header class=\"header\">\n+ <a href=\"#\">\n+ <img class=\"header__logo\" src=\"images/logo.png\" alt=\"moyo logo\">\n+ </a>\n+ <nav class=\"header__nav nav\">","path":"src/index.html","position":9,"original_position":9,"commit_id":"19de7c53f5ce5d14c96694bea1425ae38a33c87a","original_commit_id":"19de7c53f5ce5d14c96694bea1425ae38a33c87a","user":{"login":"danheim","id":36257947,"node_id":"MDQ6VXNlcjM2MjU3OTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/36257947?v=4","gravatar_id":"","url":"https://api.github.com/users/danheim","html_url":"https://github.com/danheim","followers_url":"https://api.github.com/users/danheim/followers","following_url":"https://api.github.com/users/danheim/following{/other_user}","gists_url":"https://api.github.com/users/danheim/gists{/gist_id}","starred_url":"https://api.github.com/users/danheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danheim/subscriptions","organizations_url":"https://api.github.com/users/danheim/orgs","repos_url":"https://api.github.com/users/danheim/repos","events_url":"https://api.github.com/users/danheim/events{/privacy}","received_events_url":"https://api.github.com/users/danheim/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n <nav class=\"nav\">\r\n```\r\njust `nav`","created_at":"2019-12-26T12:57:35Z","updated_at":"2019-12-26T12:59:45Z","html_url":"https://github.com/mate-academy/layout_catalog/pull/266#discussion_r361450314","pull_request_url":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/comments/361450314"},"html":{"href":"https://github.com/mate-academy/layout_catalog/pull/266#discussion_r361450314"},"pull_request":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266","id":356827228,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2ODI3MjI4","html_url":"https://github.com/mate-academy/layout_catalog/pull/266","diff_url":"https://github.com/mate-academy/layout_catalog/pull/266.diff","patch_url":"https://github.com/mate-academy/layout_catalog/pull/266.patch","issue_url":"https://api.github.com/repos/mate-academy/layout_catalog/issues/266","number":266,"state":"open","locked":false,"title":"Bohdan Prymyak Catalog","user":{"login":"Arimazz","id":54505974,"node_id":"MDQ6VXNlcjU0NTA1OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/54505974?v=4","gravatar_id":"","url":"https://api.github.com/users/Arimazz","html_url":"https://github.com/Arimazz","followers_url":"https://api.github.com/users/Arimazz/followers","following_url":"https://api.github.com/users/Arimazz/following{/other_user}","gists_url":"https://api.github.com/users/Arimazz/gists{/gist_id}","starred_url":"https://api.github.com/users/Arimazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arimazz/subscriptions","organizations_url":"https://api.github.com/users/Arimazz/orgs","repos_url":"https://api.github.com/users/Arimazz/repos","events_url":"https://api.github.com/users/Arimazz/events{/privacy}","received_events_url":"https://api.github.com/users/Arimazz/received_events","type":"User","site_admin":false},"body":"https://arimazz.github.io/layout_catalog/\r\nhttps://arimazz.github.io/layout_catalog/report/html_report/","created_at":"2019-12-25T17:58:36Z","updated_at":"2019-12-26T12:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db93aac7ba4c6bb15e085c7fd6eb274593867958","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266/commits","review_comments_url":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266/comments","review_comment_url":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mate-academy/layout_catalog/issues/266/comments","statuses_url":"https://api.github.com/repos/mate-academy/layout_catalog/statuses/19de7c53f5ce5d14c96694bea1425ae38a33c87a","head":{"label":"Arimazz:develop","ref":"develop","sha":"19de7c53f5ce5d14c96694bea1425ae38a33c87a","user":{"login":"Arimazz","id":54505974,"node_id":"MDQ6VXNlcjU0NTA1OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/54505974?v=4","gravatar_id":"","url":"https://api.github.com/users/Arimazz","html_url":"https://github.com/Arimazz","followers_url":"https://api.github.com/users/Arimazz/followers","following_url":"https://api.github.com/users/Arimazz/following{/other_user}","gists_url":"https://api.github.com/users/Arimazz/gists{/gist_id}","starred_url":"https://api.github.com/users/Arimazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arimazz/subscriptions","organizations_url":"https://api.github.com/users/Arimazz/orgs","repos_url":"https://api.github.com/users/Arimazz/repos","events_url":"https://api.github.com/users/Arimazz/events{/privacy}","received_events_url":"https://api.github.com/users/Arimazz/received_events","type":"User","site_admin":false},"repo":{"id":229757059,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk3NTcwNTk=","name":"layout_catalog","full_name":"Arimazz/layout_catalog","private":false,"owner":{"login":"Arimazz","id":54505974,"node_id":"MDQ6VXNlcjU0NTA1OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/54505974?v=4","gravatar_id":"","url":"https://api.github.com/users/Arimazz","html_url":"https://github.com/Arimazz","followers_url":"https://api.github.com/users/Arimazz/followers","following_url":"https://api.github.com/users/Arimazz/following{/other_user}","gists_url":"https://api.github.com/users/Arimazz/gists{/gist_id}","starred_url":"https://api.github.com/users/Arimazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arimazz/subscriptions","organizations_url":"https://api.github.com/users/Arimazz/orgs","repos_url":"https://api.github.com/users/Arimazz/repos","events_url":"https://api.github.com/users/Arimazz/events{/privacy}","received_events_url":"https://api.github.com/users/Arimazz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Arimazz/layout_catalog","description":null,"fork":true,"url":"https://api.github.com/repos/Arimazz/layout_catalog","forks_url":"https://api.github.com/repos/Arimazz/layout_catalog/forks","keys_url":"https://api.github.com/repos/Arimazz/layout_catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arimazz/layout_catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arimazz/layout_catalog/teams","hooks_url":"https://api.github.com/repos/Arimazz/layout_catalog/hooks","issue_events_url":"https://api.github.com/repos/Arimazz/layout_catalog/issues/events{/number}","events_url":"https://api.github.com/repos/Arimazz/layout_catalog/events","assignees_url":"https://api.github.com/repos/Arimazz/layout_catalog/assignees{/user}","branches_url":"https://api.github.com/repos/Arimazz/layout_catalog/branches{/branch}","tags_url":"https://api.github.com/repos/Arimazz/layout_catalog/tags","blobs_url":"https://api.github.com/repos/Arimazz/layout_catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arimazz/layout_catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arimazz/layout_catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arimazz/layout_catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arimazz/layout_catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/Arimazz/layout_catalog/languages","stargazers_url":"https://api.github.com/repos/Arimazz/layout_catalog/stargazers","contributors_url":"https://api.github.com/repos/Arimazz/layout_catalog/contributors","subscribers_url":"https://api.github.com/repos/Arimazz/layout_catalog/subscribers","subscription_url":"https://api.github.com/repos/Arimazz/layout_catalog/subscription","commits_url":"https://api.github.com/repos/Arimazz/layout_catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arimazz/layout_catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arimazz/layout_catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arimazz/layout_catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/Arimazz/layout_catalog/contents/{+path}","compare_url":"https://api.github.com/repos/Arimazz/layout_catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arimazz/layout_catalog/merges","archive_url":"https://api.github.com/repos/Arimazz/layout_catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arimazz/layout_catalog/downloads","issues_url":"https://api.github.com/repos/Arimazz/layout_catalog/issues{/number}","pulls_url":"https://api.github.com/repos/Arimazz/layout_catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/Arimazz/layout_catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/Arimazz/layout_catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arimazz/layout_catalog/labels{/name}","releases_url":"https://api.github.com/repos/Arimazz/layout_catalog/releases{/id}","deployments_url":"https://api.github.com/repos/Arimazz/layout_catalog/deployments","created_at":"2019-12-23T13:22:06Z","updated_at":"2019-12-23T13:22:08Z","pushed_at":"2019-12-26T12:26:25Z","git_url":"git://github.com/Arimazz/layout_catalog.git","ssh_url":"git@github.com:Arimazz/layout_catalog.git","clone_url":"https://github.com/Arimazz/layout_catalog.git","svn_url":"https://github.com/Arimazz/layout_catalog","homepage":null,"size":2918,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mate-academy:master","ref":"master","sha":"7e5bb2aa54191dc5f839bde28cdd50a3d059e638","user":{"login":"mate-academy","id":28379899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Mzc5ODk5","avatar_url":"https://avatars1.githubusercontent.com/u/28379899?v=4","gravatar_id":"","url":"https://api.github.com/users/mate-academy","html_url":"https://github.com/mate-academy","followers_url":"https://api.github.com/users/mate-academy/followers","following_url":"https://api.github.com/users/mate-academy/following{/other_user}","gists_url":"https://api.github.com/users/mate-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/mate-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mate-academy/subscriptions","organizations_url":"https://api.github.com/users/mate-academy/orgs","repos_url":"https://api.github.com/users/mate-academy/repos","events_url":"https://api.github.com/users/mate-academy/events{/privacy}","received_events_url":"https://api.github.com/users/mate-academy/received_events","type":"Organization","site_admin":false},"repo":{"id":183250751,"node_id":"MDEwOlJlcG9zaXRvcnkxODMyNTA3NTE=","name":"layout_catalog","full_name":"mate-academy/layout_catalog","private":false,"owner":{"login":"mate-academy","id":28379899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Mzc5ODk5","avatar_url":"https://avatars1.githubusercontent.com/u/28379899?v=4","gravatar_id":"","url":"https://api.github.com/users/mate-academy","html_url":"https://github.com/mate-academy","followers_url":"https://api.github.com/users/mate-academy/followers","following_url":"https://api.github.com/users/mate-academy/following{/other_user}","gists_url":"https://api.github.com/users/mate-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/mate-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mate-academy/subscriptions","organizations_url":"https://api.github.com/users/mate-academy/orgs","repos_url":"https://api.github.com/users/mate-academy/repos","events_url":"https://api.github.com/users/mate-academy/events{/privacy}","received_events_url":"https://api.github.com/users/mate-academy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mate-academy/layout_catalog","description":null,"fork":false,"url":"https://api.github.com/repos/mate-academy/layout_catalog","forks_url":"https://api.github.com/repos/mate-academy/layout_catalog/forks","keys_url":"https://api.github.com/repos/mate-academy/layout_catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mate-academy/layout_catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mate-academy/layout_catalog/teams","hooks_url":"https://api.github.com/repos/mate-academy/layout_catalog/hooks","issue_events_url":"https://api.github.com/repos/mate-academy/layout_catalog/issues/events{/number}","events_url":"https://api.github.com/repos/mate-academy/layout_catalog/events","assignees_url":"https://api.github.com/repos/mate-academy/layout_catalog/assignees{/user}","branches_url":"https://api.github.com/repos/mate-academy/layout_catalog/branches{/branch}","tags_url":"https://api.github.com/repos/mate-academy/layout_catalog/tags","blobs_url":"https://api.github.com/repos/mate-academy/layout_catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mate-academy/layout_catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mate-academy/layout_catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mate-academy/layout_catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mate-academy/layout_catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/mate-academy/layout_catalog/languages","stargazers_url":"https://api.github.com/repos/mate-academy/layout_catalog/stargazers","contributors_url":"https://api.github.com/repos/mate-academy/layout_catalog/contributors","subscribers_url":"https://api.github.com/repos/mate-academy/layout_catalog/subscribers","subscription_url":"https://api.github.com/repos/mate-academy/layout_catalog/subscription","commits_url":"https://api.github.com/repos/mate-academy/layout_catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mate-academy/layout_catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mate-academy/layout_catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mate-academy/layout_catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mate-academy/layout_catalog/contents/{+path}","compare_url":"https://api.github.com/repos/mate-academy/layout_catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mate-academy/layout_catalog/merges","archive_url":"https://api.github.com/repos/mate-academy/layout_catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mate-academy/layout_catalog/downloads","issues_url":"https://api.github.com/repos/mate-academy/layout_catalog/issues{/number}","pulls_url":"https://api.github.com/repos/mate-academy/layout_catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/mate-academy/layout_catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/mate-academy/layout_catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mate-academy/layout_catalog/labels{/name}","releases_url":"https://api.github.com/repos/mate-academy/layout_catalog/releases{/id}","deployments_url":"https://api.github.com/repos/mate-academy/layout_catalog/deployments","created_at":"2019-04-24T14:54:15Z","updated_at":"2019-12-16T14:59:41Z","pushed_at":"2019-12-26T12:36:03Z","git_url":"git://github.com/mate-academy/layout_catalog.git","ssh_url":"git@github.com:mate-academy/layout_catalog.git","clone_url":"https://github.com/mate-academy/layout_catalog.git","svn_url":"https://github.com/mate-academy/layout_catalog","homepage":null,"size":449,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":260,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":220,"open_issues":260,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266"},"html":{"href":"https://github.com/mate-academy/layout_catalog/pull/266"},"issue":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/issues/266"},"comments":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/mate-academy/layout_catalog/statuses/19de7c53f5ce5d14c96694bea1425ae38a33c87a"}},"author_association":"NONE"}}
|
{
"id": 183250751,
"name": "mate-academy/layout_catalog",
"url": "https://api.github.com/repos/mate-academy/layout_catalog"
}
|
{
"id": 36257947,
"login": "danheim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36257947?",
"url": "https://api.github.com/users/danheim"
}
|
{
"id": 28379899,
"login": "mate-academy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28379899?",
"url": "https://api.github.com/orgs/mate-academy"
}
| 2019-12-26T12:57:35 |
11161240756
|
{"actor":{"display_login":"danheim"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mate-academy/jv-storage/pulls/comments/318439707","pull_request_review_id":280649178,"id":318439707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxODQzOTcwNw==","diff_hunk":"@@ -2,15 +2,45 @@\n \n import core.basesyntax.Storage;\n \n+import java.util.Arrays;\n+\n public class StorageImpl<K, V> implements Storage<K,V> {\n \n+ private Object[] keys = new Object[16];\n+ private Object[] values = new Object[16];\n+ int topArray = -1;","path":"src/main/java/core/basesyntax/impl/StorageImpl.java","position":10,"original_position":10,"commit_id":"485c59dc79da4b01b1a4f009b299790d323e06d4","original_commit_id":"485c59dc79da4b01b1a4f009b299790d323e06d4","user":{"login":"Sofasmile","id":36365171,"node_id":"MDQ6VXNlcjM2MzY1MTcx","avatar_url":"https://avatars2.githubusercontent.com/u/36365171?v=4","gravatar_id":"","url":"https://api.github.com/users/Sofasmile","html_url":"https://github.com/Sofasmile","followers_url":"https://api.github.com/users/Sofasmile/followers","following_url":"https://api.github.com/users/Sofasmile/following{/other_user}","gists_url":"https://api.github.com/users/Sofasmile/gists{/gist_id}","starred_url":"https://api.github.com/users/Sofasmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sofasmile/subscriptions","organizations_url":"https://api.github.com/users/Sofasmile/orgs","repos_url":"https://api.github.com/users/Sofasmile/repos","events_url":"https://api.github.com/users/Sofasmile/events{/privacy}","received_events_url":"https://api.github.com/users/Sofasmile/received_events","type":"User","site_admin":false},"body":"add access modifier","created_at":"2019-08-28T07:56:00Z","updated_at":"2019-08-28T07:58:10Z","html_url":"https://github.com/mate-academy/jv-storage/pull/7#discussion_r318439707","pull_request_url":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mate-academy/jv-storage/pulls/comments/318439707"},"html":{"href":"https://github.com/mate-academy/jv-storage/pull/7#discussion_r318439707"},"pull_request":{"href":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7","id":311425177,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExNDI1MTc3","html_url":"https://github.com/mate-academy/jv-storage/pull/7","diff_url":"https://github.com/mate-academy/jv-storage/pull/7.diff","patch_url":"https://github.com/mate-academy/jv-storage/pull/7.patch","issue_url":"https://api.github.com/repos/mate-academy/jv-storage/issues/7","number":7,"state":"open","locked":false,"title":"hw-6-2","user":{"login":"kenu21","id":15524026,"node_id":"MDQ6VXNlcjE1NTI0MDI2","avatar_url":"https://avatars2.githubusercontent.com/u/15524026?v=4","gravatar_id":"","url":"https://api.github.com/users/kenu21","html_url":"https://github.com/kenu21","followers_url":"https://api.github.com/users/kenu21/followers","following_url":"https://api.github.com/users/kenu21/following{/other_user}","gists_url":"https://api.github.com/users/kenu21/gists{/gist_id}","starred_url":"https://api.github.com/users/kenu21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenu21/subscriptions","organizations_url":"https://api.github.com/users/kenu21/orgs","repos_url":"https://api.github.com/users/kenu21/repos","events_url":"https://api.github.com/users/kenu21/events{/privacy}","received_events_url":"https://api.github.com/users/kenu21/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-27T14:52:56Z","updated_at":"2019-08-28T07:58:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c66e86ab627d59103bf134b2ae8cf6494ec043f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7/commits","review_comments_url":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7/comments","review_comment_url":"https://api.github.com/repos/mate-academy/jv-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mate-academy/jv-storage/issues/7/comments","statuses_url":"https://api.github.com/repos/mate-academy/jv-storage/statuses/485c59dc79da4b01b1a4f009b299790d323e06d4","head":{"label":"kenu21:hw-6-2","ref":"hw-6-2","sha":"485c59dc79da4b01b1a4f009b299790d323e06d4","user":{"login":"kenu21","id":15524026,"node_id":"MDQ6VXNlcjE1NTI0MDI2","avatar_url":"https://avatars2.githubusercontent.com/u/15524026?v=4","gravatar_id":"","url":"https://api.github.com/users/kenu21","html_url":"https://github.com/kenu21","followers_url":"https://api.github.com/users/kenu21/followers","following_url":"https://api.github.com/users/kenu21/following{/other_user}","gists_url":"https://api.github.com/users/kenu21/gists{/gist_id}","starred_url":"https://api.github.com/users/kenu21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenu21/subscriptions","organizations_url":"https://api.github.com/users/kenu21/orgs","repos_url":"https://api.github.com/users/kenu21/repos","events_url":"https://api.github.com/users/kenu21/events{/privacy}","received_events_url":"https://api.github.com/users/kenu21/received_events","type":"User","site_admin":false},"repo":{"id":204692782,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ2OTI3ODI=","name":"jv-storage","full_name":"kenu21/jv-storage","private":false,"owner":{"login":"kenu21","id":15524026,"node_id":"MDQ6VXNlcjE1NTI0MDI2","avatar_url":"https://avatars2.githubusercontent.com/u/15524026?v=4","gravatar_id":"","url":"https://api.github.com/users/kenu21","html_url":"https://github.com/kenu21","followers_url":"https://api.github.com/users/kenu21/followers","following_url":"https://api.github.com/users/kenu21/following{/other_user}","gists_url":"https://api.github.com/users/kenu21/gists{/gist_id}","starred_url":"https://api.github.com/users/kenu21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenu21/subscriptions","organizations_url":"https://api.github.com/users/kenu21/orgs","repos_url":"https://api.github.com/users/kenu21/repos","events_url":"https://api.github.com/users/kenu21/events{/privacy}","received_events_url":"https://api.github.com/users/kenu21/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kenu21/jv-storage","description":null,"fork":true,"url":"https://api.github.com/repos/kenu21/jv-storage","forks_url":"https://api.github.com/repos/kenu21/jv-storage/forks","keys_url":"https://api.github.com/repos/kenu21/jv-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenu21/jv-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenu21/jv-storage/teams","hooks_url":"https://api.github.com/repos/kenu21/jv-storage/hooks","issue_events_url":"https://api.github.com/repos/kenu21/jv-storage/issues/events{/number}","events_url":"https://api.github.com/repos/kenu21/jv-storage/events","assignees_url":"https://api.github.com/repos/kenu21/jv-storage/assignees{/user}","branches_url":"https://api.github.com/repos/kenu21/jv-storage/branches{/branch}","tags_url":"https://api.github.com/repos/kenu21/jv-storage/tags","blobs_url":"https://api.github.com/repos/kenu21/jv-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenu21/jv-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenu21/jv-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenu21/jv-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenu21/jv-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/kenu21/jv-storage/languages","stargazers_url":"https://api.github.com/repos/kenu21/jv-storage/stargazers","contributors_url":"https://api.github.com/repos/kenu21/jv-storage/contributors","subscribers_url":"https://api.github.com/repos/kenu21/jv-storage/subscribers","subscription_url":"https://api.github.com/repos/kenu21/jv-storage/subscription","commits_url":"https://api.github.com/repos/kenu21/jv-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenu21/jv-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenu21/jv-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenu21/jv-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenu21/jv-storage/contents/{+path}","compare_url":"https://api.github.com/repos/kenu21/jv-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenu21/jv-storage/merges","archive_url":"https://api.github.com/repos/kenu21/jv-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenu21/jv-storage/downloads","issues_url":"https://api.github.com/repos/kenu21/jv-storage/issues{/number}","pulls_url":"https://api.github.com/repos/kenu21/jv-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/kenu21/jv-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/kenu21/jv-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenu21/jv-storage/labels{/name}","releases_url":"https://api.github.com/repos/kenu21/jv-storage/releases{/id}","deployments_url":"https://api.github.com/repos/kenu21/jv-storage/deployments","created_at":"2019-08-27T11:54:52Z","updated_at":"2019-08-27T11:54:54Z","pushed_at":"2019-08-27T14:52:36Z","git_url":"git://github.com/kenu21/jv-storage.git","ssh_url":"git@github.com:kenu21/jv-storage.git","clone_url":"https://github.com/kenu21/jv-storage.git","svn_url":"https://github.com/kenu21/jv-storage","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mate-academy:master","ref":"master","sha":"930b7e857579b087e93809a4deb54181b096306c","user":{"login":"mate-academy","id":28379899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Mzc5ODk5","avatar_url":"https://avatars1.githubusercontent.com/u/28379899?v=4","gravatar_id":"","url":"https://api.github.com/users/mate-academy","html_url":"https://github.com/mate-academy","followers_url":"https://api.github.com/users/mate-academy/followers","following_url":"https://api.github.com/users/mate-academy/following{/other_user}","gists_url":"https://api.github.com/users/mate-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/mate-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mate-academy/subscriptions","organizations_url":"https://api.github.com/users/mate-academy/orgs","repos_url":"https://api.github.com/users/mate-academy/repos","events_url":"https://api.github.com/users/mate-academy/events{/privacy}","received_events_url":"https://api.github.com/users/mate-academy/received_events","type":"Organization","site_admin":false},"repo":{"id":203386600,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMzODY2MDA=","name":"jv-storage","full_name":"mate-academy/jv-storage","private":false,"owner":{"login":"mate-academy","id":28379899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Mzc5ODk5","avatar_url":"https://avatars1.githubusercontent.com/u/28379899?v=4","gravatar_id":"","url":"https://api.github.com/users/mate-academy","html_url":"https://github.com/mate-academy","followers_url":"https://api.github.com/users/mate-academy/followers","following_url":"https://api.github.com/users/mate-academy/following{/other_user}","gists_url":"https://api.github.com/users/mate-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/mate-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mate-academy/subscriptions","organizations_url":"https://api.github.com/users/mate-academy/orgs","repos_url":"https://api.github.com/users/mate-academy/repos","events_url":"https://api.github.com/users/mate-academy/events{/privacy}","received_events_url":"https://api.github.com/users/mate-academy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mate-academy/jv-storage","description":null,"fork":false,"url":"https://api.github.com/repos/mate-academy/jv-storage","forks_url":"https://api.github.com/repos/mate-academy/jv-storage/forks","keys_url":"https://api.github.com/repos/mate-academy/jv-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mate-academy/jv-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mate-academy/jv-storage/teams","hooks_url":"https://api.github.com/repos/mate-academy/jv-storage/hooks","issue_events_url":"https://api.github.com/repos/mate-academy/jv-storage/issues/events{/number}","events_url":"https://api.github.com/repos/mate-academy/jv-storage/events","assignees_url":"https://api.github.com/repos/mate-academy/jv-storage/assignees{/user}","branches_url":"https://api.github.com/repos/mate-academy/jv-storage/branches{/branch}","tags_url":"https://api.github.com/repos/mate-academy/jv-storage/tags","blobs_url":"https://api.github.com/repos/mate-academy/jv-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mate-academy/jv-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mate-academy/jv-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/mate-academy/jv-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mate-academy/jv-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/mate-academy/jv-storage/languages","stargazers_url":"https://api.github.com/repos/mate-academy/jv-storage/stargazers","contributors_url":"https://api.github.com/repos/mate-academy/jv-storage/contributors","subscribers_url":"https://api.github.com/repos/mate-academy/jv-storage/subscribers","subscription_url":"https://api.github.com/repos/mate-academy/jv-storage/subscription","commits_url":"https://api.github.com/repos/mate-academy/jv-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/mate-academy/jv-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/mate-academy/jv-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/mate-academy/jv-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/mate-academy/jv-storage/contents/{+path}","compare_url":"https://api.github.com/repos/mate-academy/jv-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mate-academy/jv-storage/merges","archive_url":"https://api.github.com/repos/mate-academy/jv-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mate-academy/jv-storage/downloads","issues_url":"https://api.github.com/repos/mate-academy/jv-storage/issues{/number}","pulls_url":"https://api.github.com/repos/mate-academy/jv-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/mate-academy/jv-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/mate-academy/jv-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mate-academy/jv-storage/labels{/name}","releases_url":"https://api.github.com/repos/mate-academy/jv-storage/releases{/id}","deployments_url":"https://api.github.com/repos/mate-academy/jv-storage/deployments","created_at":"2019-08-20T13:53:10Z","updated_at":"2019-08-27T06:41:02Z","pushed_at":"2019-08-28T05:06:51Z","git_url":"git://github.com/mate-academy/jv-storage.git","ssh_url":"git@github.com:mate-academy/jv-storage.git","clone_url":"https://github.com/mate-academy/jv-storage.git","svn_url":"https://github.com/mate-academy/jv-storage","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":22,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7"},"html":{"href":"https://github.com/mate-academy/jv-storage/pull/7"},"issue":{"href":"https://api.github.com/repos/mate-academy/jv-storage/issues/7"},"comments":{"href":"https://api.github.com/repos/mate-academy/jv-storage/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/mate-academy/jv-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mate-academy/jv-storage/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/mate-academy/jv-storage/statuses/485c59dc79da4b01b1a4f009b299790d323e06d4"}},"author_association":"NONE"}}
|
{
"id": 203386600,
"name": "mate-academy/jv-storage",
"url": "https://api.github.com/repos/mate-academy/jv-storage"
}
|
{
"id": 36365171,
"login": "Sofasmile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36365171?",
"url": "https://api.github.com/users/Sofasmile"
}
|
{
"id": 28379899,
"login": "mate-academy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28379899?",
"url": "https://api.github.com/orgs/mate-academy"
}
| 2019-08-28T10:56:00 |
10298271556
|
{"actor":{"display_login":"Sofasmile"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/comments/344674457","pull_request_review_id":314848050,"id":344674457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDY3NDQ1Nw==","diff_hunk":"@@ -28,7 +28,9 @@\n * @return {number}\n */\n function numJewelsInStones(jewels, stones) {\n- // write code here\n+ return jewels.length === 0 ? 0\n+ : [...stones].filter(item => jewels.match(/[a-zA-Z]/g)","path":"src/numJewelsInStones.js","position":6,"original_position":6,"commit_id":"7a081cfd1b644e907c29164054618c372b455d47","original_commit_id":"7a081cfd1b644e907c29164054618c372b455d47","user":{"login":"banduraweb","id":54276744,"node_id":"MDQ6VXNlcjU0Mjc2NzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/54276744?v=4","gravatar_id":"","url":"https://api.github.com/users/banduraweb","html_url":"https://github.com/banduraweb","followers_url":"https://api.github.com/users/banduraweb/followers","following_url":"https://api.github.com/users/banduraweb/following{/other_user}","gists_url":"https://api.github.com/users/banduraweb/gists{/gist_id}","starred_url":"https://api.github.com/users/banduraweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banduraweb/subscriptions","organizations_url":"https://api.github.com/users/banduraweb/orgs","repos_url":"https://api.github.com/users/banduraweb/repos","events_url":"https://api.github.com/users/banduraweb/events{/privacy}","received_events_url":"https://api.github.com/users/banduraweb/received_events","type":"User","site_admin":false},"body":"stones string \r\n Input: jewels = \"aA\", stones = \"aAAbbbb\"","created_at":"2019-11-11T11:46:24Z","updated_at":"2019-11-11T11:46:25Z","html_url":"https://github.com/mate-academy/js_task-jewels-and-stones/pull/80#discussion_r344674457","pull_request_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/comments/344674457"},"html":{"href":"https://github.com/mate-academy/js_task-jewels-and-stones/pull/80#discussion_r344674457"},"pull_request":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80"}},"in_reply_to_id":344656559},"pull_request":{"url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80","id":339354577,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5MzU0NTc3","html_url":"https://github.com/mate-academy/js_task-jewels-and-stones/pull/80","diff_url":"https://github.com/mate-academy/js_task-jewels-and-stones/pull/80.diff","patch_url":"https://github.com/mate-academy/js_task-jewels-and-stones/pull/80.patch","issue_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/issues/80","number":80,"state":"open","locked":false,"title":"Solution","user":{"login":"banduraweb","id":54276744,"node_id":"MDQ6VXNlcjU0Mjc2NzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/54276744?v=4","gravatar_id":"","url":"https://api.github.com/users/banduraweb","html_url":"https://github.com/banduraweb","followers_url":"https://api.github.com/users/banduraweb/followers","following_url":"https://api.github.com/users/banduraweb/following{/other_user}","gists_url":"https://api.github.com/users/banduraweb/gists{/gist_id}","starred_url":"https://api.github.com/users/banduraweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banduraweb/subscriptions","organizations_url":"https://api.github.com/users/banduraweb/orgs","repos_url":"https://api.github.com/users/banduraweb/repos","events_url":"https://api.github.com/users/banduraweb/events{/privacy}","received_events_url":"https://api.github.com/users/banduraweb/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-11T10:21:25Z","updated_at":"2019-11-11T11:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"418ea82b5a4fd63a41eeb6b7c826b5522ee06e8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80/commits","review_comments_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80/comments","review_comment_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/issues/80/comments","statuses_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/statuses/7a081cfd1b644e907c29164054618c372b455d47","head":{"label":"banduraweb:fe_oct19_andriy_bandura","ref":"fe_oct19_andriy_bandura","sha":"7a081cfd1b644e907c29164054618c372b455d47","user":{"login":"banduraweb","id":54276744,"node_id":"MDQ6VXNlcjU0Mjc2NzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/54276744?v=4","gravatar_id":"","url":"https://api.github.com/users/banduraweb","html_url":"https://github.com/banduraweb","followers_url":"https://api.github.com/users/banduraweb/followers","following_url":"https://api.github.com/users/banduraweb/following{/other_user}","gists_url":"https://api.github.com/users/banduraweb/gists{/gist_id}","starred_url":"https://api.github.com/users/banduraweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banduraweb/subscriptions","organizations_url":"https://api.github.com/users/banduraweb/orgs","repos_url":"https://api.github.com/users/banduraweb/repos","events_url":"https://api.github.com/users/banduraweb/events{/privacy}","received_events_url":"https://api.github.com/users/banduraweb/received_events","type":"User","site_admin":false},"repo":{"id":220946221,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA5NDYyMjE=","name":"js_task-jewels-and-stones","full_name":"banduraweb/js_task-jewels-and-stones","private":false,"owner":{"login":"banduraweb","id":54276744,"node_id":"MDQ6VXNlcjU0Mjc2NzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/54276744?v=4","gravatar_id":"","url":"https://api.github.com/users/banduraweb","html_url":"https://github.com/banduraweb","followers_url":"https://api.github.com/users/banduraweb/followers","following_url":"https://api.github.com/users/banduraweb/following{/other_user}","gists_url":"https://api.github.com/users/banduraweb/gists{/gist_id}","starred_url":"https://api.github.com/users/banduraweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banduraweb/subscriptions","organizations_url":"https://api.github.com/users/banduraweb/orgs","repos_url":"https://api.github.com/users/banduraweb/repos","events_url":"https://api.github.com/users/banduraweb/events{/privacy}","received_events_url":"https://api.github.com/users/banduraweb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/banduraweb/js_task-jewels-and-stones","description":null,"fork":true,"url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones","forks_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/forks","keys_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/keys{/key_id}","collaborators_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/teams","hooks_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/hooks","issue_events_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/issues/events{/number}","events_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/events","assignees_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/assignees{/user}","branches_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/branches{/branch}","tags_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/tags","blobs_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/git/refs{/sha}","trees_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/git/trees{/sha}","statuses_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/statuses/{sha}","languages_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/languages","stargazers_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/stargazers","contributors_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/contributors","subscribers_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/subscribers","subscription_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/subscription","commits_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/commits{/sha}","git_commits_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/git/commits{/sha}","comments_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/comments{/number}","issue_comment_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/issues/comments{/number}","contents_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/contents/{+path}","compare_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/compare/{base}...{head}","merges_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/merges","archive_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/downloads","issues_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/issues{/number}","pulls_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/pulls{/number}","milestones_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/milestones{/number}","notifications_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/labels{/name}","releases_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/releases{/id}","deployments_url":"https://api.github.com/repos/banduraweb/js_task-jewels-and-stones/deployments","created_at":"2019-11-11T09:32:25Z","updated_at":"2019-11-11T09:32:27Z","pushed_at":"2019-11-11T10:21:12Z","git_url":"git://github.com/banduraweb/js_task-jewels-and-stones.git","ssh_url":"git@github.com:banduraweb/js_task-jewels-and-stones.git","clone_url":"https://github.com/banduraweb/js_task-jewels-and-stones.git","svn_url":"https://github.com/banduraweb/js_task-jewels-and-stones","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mate-academy:master","ref":"master","sha":"527f7f43f4198a0efc736af591fe51f6939a6f42","user":{"login":"mate-academy","id":28379899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Mzc5ODk5","avatar_url":"https://avatars1.githubusercontent.com/u/28379899?v=4","gravatar_id":"","url":"https://api.github.com/users/mate-academy","html_url":"https://github.com/mate-academy","followers_url":"https://api.github.com/users/mate-academy/followers","following_url":"https://api.github.com/users/mate-academy/following{/other_user}","gists_url":"https://api.github.com/users/mate-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/mate-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mate-academy/subscriptions","organizations_url":"https://api.github.com/users/mate-academy/orgs","repos_url":"https://api.github.com/users/mate-academy/repos","events_url":"https://api.github.com/users/mate-academy/events{/privacy}","received_events_url":"https://api.github.com/users/mate-academy/received_events","type":"Organization","site_admin":false},"repo":{"id":191558681,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE1NTg2ODE=","name":"js_task-jewels-and-stones","full_name":"mate-academy/js_task-jewels-and-stones","private":false,"owner":{"login":"mate-academy","id":28379899,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Mzc5ODk5","avatar_url":"https://avatars1.githubusercontent.com/u/28379899?v=4","gravatar_id":"","url":"https://api.github.com/users/mate-academy","html_url":"https://github.com/mate-academy","followers_url":"https://api.github.com/users/mate-academy/followers","following_url":"https://api.github.com/users/mate-academy/following{/other_user}","gists_url":"https://api.github.com/users/mate-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/mate-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mate-academy/subscriptions","organizations_url":"https://api.github.com/users/mate-academy/orgs","repos_url":"https://api.github.com/users/mate-academy/repos","events_url":"https://api.github.com/users/mate-academy/events{/privacy}","received_events_url":"https://api.github.com/users/mate-academy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mate-academy/js_task-jewels-and-stones","description":null,"fork":false,"url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones","forks_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/forks","keys_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/teams","hooks_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/hooks","issue_events_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/issues/events{/number}","events_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/events","assignees_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/assignees{/user}","branches_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/branches{/branch}","tags_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/tags","blobs_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/git/refs{/sha}","trees_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/statuses/{sha}","languages_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/languages","stargazers_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/stargazers","contributors_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/contributors","subscribers_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/subscribers","subscription_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/subscription","commits_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/commits{/sha}","git_commits_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/git/commits{/sha}","comments_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/comments{/number}","issue_comment_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/issues/comments{/number}","contents_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/contents/{+path}","compare_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/merges","archive_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/downloads","issues_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/issues{/number}","pulls_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls{/number}","milestones_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/milestones{/number}","notifications_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/labels{/name}","releases_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/releases{/id}","deployments_url":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/deployments","created_at":"2019-06-12T11:35:46Z","updated_at":"2019-06-12T18:09:31Z","pushed_at":"2019-11-11T10:21:26Z","git_url":"git://github.com/mate-academy/js_task-jewels-and-stones.git","ssh_url":"git@github.com:mate-academy/js_task-jewels-and-stones.git","clone_url":"https://github.com/mate-academy/js_task-jewels-and-stones.git","svn_url":"https://github.com/mate-academy/js_task-jewels-and-stones","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":78,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":85,"open_issues":78,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80"},"html":{"href":"https://github.com/mate-academy/js_task-jewels-and-stones/pull/80"},"issue":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/issues/80"},"comments":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/mate-academy/js_task-jewels-and-stones/statuses/7a081cfd1b644e907c29164054618c372b455d47"}},"author_association":"NONE"}}
|
{
"id": 191558681,
"name": "mate-academy/js_task-jewels-and-stones",
"url": "https://api.github.com/repos/mate-academy/js_task-jewels-and-stones"
}
|
{
"id": 54276744,
"login": "banduraweb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54276744?",
"url": "https://api.github.com/users/banduraweb"
}
|
{
"id": 28379899,
"login": "mate-academy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28379899?",
"url": "https://api.github.com/orgs/mate-academy"
}
| 2019-11-11T11:46:24 |
10832940098
|
{"actor":{"display_login":"banduraweb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/305497047","pull_request_review_id":264395328,"id":305497047,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTQ5NzA0Nw==","diff_hunk":"@@ -637,6 +646,17 @@ export class SearchInWorkspaceResultTreeWidget extends TreeWidget {\n </React.Fragment>;\n }\n \n+ /**\n+ * Get the editor widget by the node.\n+ * @param {SearchInWorkspaceResultLineNode} node - the node representing a match in the search results.\n+ * @returns The editor widget to which the text replace will be done.\n+ */\n+ protected async doGetWidget(node: SearchInWorkspaceResultLineNode): Promise<EditorWidget> {\n+ const fileUri = new URI(node.fileUri);\n+ const editorWidget = await this.editorManager.getOrCreateByUri(fileUri);","path":"packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx","position":64,"original_position":64,"commit_id":"bcdbe2783343d2e74822317c9e6e899c6856e816","original_commit_id":"bcdbe2783343d2e74822317c9e6e899c6856e816","user":{"login":"marechal-p","id":14182238,"node_id":"MDQ6VXNlcjE0MTgyMjM4","avatar_url":"https://avatars0.githubusercontent.com/u/14182238?v=4","gravatar_id":"","url":"https://api.github.com/users/marechal-p","html_url":"https://github.com/marechal-p","followers_url":"https://api.github.com/users/marechal-p/followers","following_url":"https://api.github.com/users/marechal-p/following{/other_user}","gists_url":"https://api.github.com/users/marechal-p/gists{/gist_id}","starred_url":"https://api.github.com/users/marechal-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marechal-p/subscriptions","organizations_url":"https://api.github.com/users/marechal-p/orgs","repos_url":"https://api.github.com/users/marechal-p/repos","events_url":"https://api.github.com/users/marechal-p/events{/privacy}","received_events_url":"https://api.github.com/users/marechal-p/received_events","type":"User","site_admin":false},"body":"I added a bunch of code inside this function and displayed all the editors tracked by the editor manager, it happens that editors are leaking indeed. Good thing is that we only leak one of the same URI, since `getOrCreate` won't spawn duplicates.\r\n\r\nI don't know how you should go about disposing them, I also find weird that we have to instantiate `EditorWidget` in order to change a file and save it?\r\n\r\n@akosyakov ?","created_at":"2019-07-19T19:34:49Z","updated_at":"2019-07-19T19:34:49Z","html_url":"https://github.com/theia-ide/theia/pull/5600#discussion_r305497047","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/5600","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/305497047"},"html":{"href":"https://github.com/theia-ide/theia/pull/5600#discussion_r305497047"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/5600"}},"in_reply_to_id":304750834},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/5600","id":292568911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyNTY4OTEx","html_url":"https://github.com/theia-ide/theia/pull/5600","diff_url":"https://github.com/theia-ide/theia/pull/5600.diff","patch_url":"https://github.com/theia-ide/theia/pull/5600.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/5600","number":5600,"state":"open","locked":false,"title":"Fixed #5454, #5452: modified \"replace-all\" to save changes without opening editors","user":{"login":"fangnx","id":25921074,"node_id":"MDQ6VXNlcjI1OTIxMDc0","avatar_url":"https://avatars3.githubusercontent.com/u/25921074?v=4","gravatar_id":"","url":"https://api.github.com/users/fangnx","html_url":"https://github.com/fangnx","followers_url":"https://api.github.com/users/fangnx/followers","following_url":"https://api.github.com/users/fangnx/following{/other_user}","gists_url":"https://api.github.com/users/fangnx/gists{/gist_id}","starred_url":"https://api.github.com/users/fangnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fangnx/subscriptions","organizations_url":"https://api.github.com/users/fangnx/orgs","repos_url":"https://api.github.com/users/fangnx/repos","events_url":"https://api.github.com/users/fangnx/events{/privacy}","received_events_url":"https://api.github.com/users/fangnx/received_events","type":"User","site_admin":false},"body":"Fixed #5454, #5452.\r\n\r\n- In `search-in-workspace` widget, doing the \"replace-all\" used to open all the editor files in dirty state.\r\n- With this patch, \"replace-all\" will do all the text replacement, and simply save the changes in the editors without opening them.\r\n","created_at":"2019-06-27T19:18:31Z","updated_at":"2019-07-19T19:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06a1ab4e9ac6e2b2c1e5192e0d7aed6d64da08c2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jbicker","id":28291421,"node_id":"MDQ6VXNlcjI4MjkxNDIx","avatar_url":"https://avatars2.githubusercontent.com/u/28291421?v=4","gravatar_id":"","url":"https://api.github.com/users/jbicker","html_url":"https://github.com/jbicker","followers_url":"https://api.github.com/users/jbicker/followers","following_url":"https://api.github.com/users/jbicker/following{/other_user}","gists_url":"https://api.github.com/users/jbicker/gists{/gist_id}","starred_url":"https://api.github.com/users/jbicker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbicker/subscriptions","organizations_url":"https://api.github.com/users/jbicker/orgs","repos_url":"https://api.github.com/users/jbicker/repos","events_url":"https://api.github.com/users/jbicker/events{/privacy}","received_events_url":"https://api.github.com/users/jbicker/received_events","type":"User","site_admin":false},{"login":"vince-fugnitto","id":40359487,"node_id":"MDQ6VXNlcjQwMzU5NDg3","avatar_url":"https://avatars2.githubusercontent.com/u/40359487?v=4","gravatar_id":"","url":"https://api.github.com/users/vince-fugnitto","html_url":"https://github.com/vince-fugnitto","followers_url":"https://api.github.com/users/vince-fugnitto/followers","following_url":"https://api.github.com/users/vince-fugnitto/following{/other_user}","gists_url":"https://api.github.com/users/vince-fugnitto/gists{/gist_id}","starred_url":"https://api.github.com/users/vince-fugnitto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vince-fugnitto/subscriptions","organizations_url":"https://api.github.com/users/vince-fugnitto/orgs","repos_url":"https://api.github.com/users/vince-fugnitto/repos","events_url":"https://api.github.com/users/vince-fugnitto/events{/privacy}","received_events_url":"https://api.github.com/users/vince-fugnitto/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":547099388,"node_id":"MDU6TGFiZWw1NDcwOTkzODg=","url":"https://api.github.com/repos/theia-ide/theia/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":914850223,"node_id":"MDU6TGFiZWw5MTQ4NTAyMjM=","url":"https://api.github.com/repos/theia-ide/theia/labels/search%20in%20workspace","name":"search in workspace","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/5600/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/5600/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/5600/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/bcdbe2783343d2e74822317c9e6e899c6856e816","head":{"label":"fangnx:fnx-fix-5454","ref":"fnx-fix-5454","sha":"bcdbe2783343d2e74822317c9e6e899c6856e816","user":{"login":"fangnx","id":25921074,"node_id":"MDQ6VXNlcjI1OTIxMDc0","avatar_url":"https://avatars3.githubusercontent.com/u/25921074?v=4","gravatar_id":"","url":"https://api.github.com/users/fangnx","html_url":"https://github.com/fangnx","followers_url":"https://api.github.com/users/fangnx/followers","following_url":"https://api.github.com/users/fangnx/following{/other_user}","gists_url":"https://api.github.com/users/fangnx/gists{/gist_id}","starred_url":"https://api.github.com/users/fangnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fangnx/subscriptions","organizations_url":"https://api.github.com/users/fangnx/orgs","repos_url":"https://api.github.com/users/fangnx/repos","events_url":"https://api.github.com/users/fangnx/events{/privacy}","received_events_url":"https://api.github.com/users/fangnx/received_events","type":"User","site_admin":false},"repo":{"id":185244465,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyNDQ0NjU=","name":"theia","full_name":"fangnx/theia","private":false,"owner":{"login":"fangnx","id":25921074,"node_id":"MDQ6VXNlcjI1OTIxMDc0","avatar_url":"https://avatars3.githubusercontent.com/u/25921074?v=4","gravatar_id":"","url":"https://api.github.com/users/fangnx","html_url":"https://github.com/fangnx","followers_url":"https://api.github.com/users/fangnx/followers","following_url":"https://api.github.com/users/fangnx/following{/other_user}","gists_url":"https://api.github.com/users/fangnx/gists{/gist_id}","starred_url":"https://api.github.com/users/fangnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fangnx/subscriptions","organizations_url":"https://api.github.com/users/fangnx/orgs","repos_url":"https://api.github.com/users/fangnx/repos","events_url":"https://api.github.com/users/fangnx/events{/privacy}","received_events_url":"https://api.github.com/users/fangnx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fangnx/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":true,"url":"https://api.github.com/repos/fangnx/theia","forks_url":"https://api.github.com/repos/fangnx/theia/forks","keys_url":"https://api.github.com/repos/fangnx/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fangnx/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fangnx/theia/teams","hooks_url":"https://api.github.com/repos/fangnx/theia/hooks","issue_events_url":"https://api.github.com/repos/fangnx/theia/issues/events{/number}","events_url":"https://api.github.com/repos/fangnx/theia/events","assignees_url":"https://api.github.com/repos/fangnx/theia/assignees{/user}","branches_url":"https://api.github.com/repos/fangnx/theia/branches{/branch}","tags_url":"https://api.github.com/repos/fangnx/theia/tags","blobs_url":"https://api.github.com/repos/fangnx/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fangnx/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fangnx/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/fangnx/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fangnx/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/fangnx/theia/languages","stargazers_url":"https://api.github.com/repos/fangnx/theia/stargazers","contributors_url":"https://api.github.com/repos/fangnx/theia/contributors","subscribers_url":"https://api.github.com/repos/fangnx/theia/subscribers","subscription_url":"https://api.github.com/repos/fangnx/theia/subscription","commits_url":"https://api.github.com/repos/fangnx/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/fangnx/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/fangnx/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/fangnx/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/fangnx/theia/contents/{+path}","compare_url":"https://api.github.com/repos/fangnx/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fangnx/theia/merges","archive_url":"https://api.github.com/repos/fangnx/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fangnx/theia/downloads","issues_url":"https://api.github.com/repos/fangnx/theia/issues{/number}","pulls_url":"https://api.github.com/repos/fangnx/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/fangnx/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/fangnx/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fangnx/theia/labels{/name}","releases_url":"https://api.github.com/repos/fangnx/theia/releases{/id}","deployments_url":"https://api.github.com/repos/fangnx/theia/deployments","created_at":"2019-05-06T17:47:40Z","updated_at":"2019-07-18T13:51:23Z","pushed_at":"2019-07-18T20:35:53Z","git_url":"git://github.com/fangnx/theia.git","ssh_url":"git@github.com:fangnx/theia.git","clone_url":"https://github.com/fangnx/theia.git","svn_url":"https://github.com/fangnx/theia","homepage":"http://theia-ide.org","size":123913,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"da653c2692ad65c865ca5ba96b865b270cc916ff","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","private":false,"owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2019-07-19T17:37:46Z","pushed_at":"2019-07-19T18:32:53Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":124504,"stargazers_count":4746,"watchers_count":4746,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":601,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1102,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":601,"open_issues":1102,"watchers":4746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/5600"},"html":{"href":"https://github.com/theia-ide/theia/pull/5600"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/5600"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/5600/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/5600/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/5600/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/bcdbe2783343d2e74822317c9e6e899c6856e816"}},"author_association":"COLLABORATOR"}}
|
{
"id": 83050680,
"name": "theia-ide/theia",
"url": "https://api.github.com/repos/theia-ide/theia"
}
|
{
"id": 14182238,
"login": "marechal-p",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14182238?",
"url": "https://api.github.com/users/marechal-p"
}
|
{
"id": 28530323,
"login": "theia-ide",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28530323?",
"url": "https://api.github.com/orgs/theia-ide"
}
| 2019-07-19T19:34:49 |
10048140150
|
{"actor":{"display_login":"marechal-p"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/359821940","pull_request_review_id":334581190,"id":359821940,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTgyMTk0MA==","diff_hunk":"@@ -26,12 +26,13 @@ import (\n \n // Options describes the configuration properties for TLS Connections.\n type Options struct {\n-\tEnabled bool\n-\tCAPath string\n-\tCertPath string\n-\tKeyPath string\n-\tServerName string // only for client-side TLS config\n-\tClientCAPath string // only for server-side TLS config for client auth\n+\tEnabled bool\n+\tCAPath string\n+\tCertPath string\n+\tKeyPath string\n+\tServerName string // only for client-side TLS config\n+\tClientCAPath string // only for server-side TLS config for client auth\n+\tSkipHostVerify bool","path":"pkg/config/tlscfg/options.go","position":16,"original_position":16,"commit_id":"0eaf54cef5932f3f6ade618b28cc7760b6de02f8","original_commit_id":"0eaf54cef5932f3f6ade618b28cc7760b6de02f8","user":{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"On line 50 add `InsecureSkipVerify: p.SkipHostVerify,`","created_at":"2019-12-19T11:50:57Z","updated_at":"2019-12-19T11:51:41Z","html_url":"https://github.com/jaegertracing/jaeger/pull/1838#discussion_r359821940","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/359821940"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/1838#discussion_r359821940"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838"}}},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838","id":325129320,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1MTI5MzIw","html_url":"https://github.com/jaegertracing/jaeger/pull/1838","diff_url":"https://github.com/jaegertracing/jaeger/pull/1838.diff","patch_url":"https://github.com/jaegertracing/jaeger/pull/1838.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/1838","number":1838,"state":"open","locked":false,"title":"Add common TLS configuration","user":{"login":"backjo","id":2441427,"node_id":"MDQ6VXNlcjI0NDE0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2441427?v=4","gravatar_id":"","url":"https://api.github.com/users/backjo","html_url":"https://github.com/backjo","followers_url":"https://api.github.com/users/backjo/followers","following_url":"https://api.github.com/users/backjo/following{/other_user}","gists_url":"https://api.github.com/users/backjo/gists{/gist_id}","starred_url":"https://api.github.com/users/backjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backjo/subscriptions","organizations_url":"https://api.github.com/users/backjo/orgs","repos_url":"https://api.github.com/users/backjo/repos","events_url":"https://api.github.com/users/backjo/events{/privacy}","received_events_url":"https://api.github.com/users/backjo/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Jonah Back <jonah@jonahback.com>\r\n\r\nCloses #1837 \r\n<!--\r\nWe appreciate your contribution to the Jaeger project! 👋🎉\r\n\r\nBefore creating a pull request, please make sure:\r\n- Your PR is solving one problem\r\n- You have read the guide for contributing\r\n - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md\r\n- You signed all your commits (otherwise we won't be able to merge the PR)\r\n - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work\r\n- You added unit tests for the new functionality\r\n- You mention in the PR description which issue it is addressing, e.g. \"Resolves #123\"\r\n-->\r\n\r\n## Which problem is this PR solving?\r\n- Makes TLS configuration standard across various storage systems\r\n\r\n## Short description of the changes\r\n- Moves TLS configurations into the tls package\r\n- Refactors cassandra/kafka/elasticsearch backends to use the common configuration\r\n","created_at":"2019-10-07T05:04:54Z","updated_at":"2019-12-19T11:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad3d511c0b733f6fb633df5069373cabb3ee6e64","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},{"login":"black-adder","id":791791,"node_id":"MDQ6VXNlcjc5MTc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},{"login":"vprithvi","id":833009,"node_id":"MDQ6VXNlcjgzMzAwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/833009?v=4","gravatar_id":"","url":"https://api.github.com/users/vprithvi","html_url":"https://github.com/vprithvi","followers_url":"https://api.github.com/users/vprithvi/followers","following_url":"https://api.github.com/users/vprithvi/following{/other_user}","gists_url":"https://api.github.com/users/vprithvi/gists{/gist_id}","starred_url":"https://api.github.com/users/vprithvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vprithvi/subscriptions","organizations_url":"https://api.github.com/users/vprithvi/orgs","repos_url":"https://api.github.com/users/vprithvi/repos","events_url":"https://api.github.com/users/vprithvi/events{/privacy}","received_events_url":"https://api.github.com/users/vprithvi/received_events","type":"User","site_admin":false},{"login":"tiffon","id":2304337,"node_id":"MDQ6VXNlcjIzMDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/1838/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/0eaf54cef5932f3f6ade618b28cc7760b6de02f8","head":{"label":"backjo:commonTlsConfig","ref":"commonTlsConfig","sha":"0eaf54cef5932f3f6ade618b28cc7760b6de02f8","user":{"login":"backjo","id":2441427,"node_id":"MDQ6VXNlcjI0NDE0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2441427?v=4","gravatar_id":"","url":"https://api.github.com/users/backjo","html_url":"https://github.com/backjo","followers_url":"https://api.github.com/users/backjo/followers","following_url":"https://api.github.com/users/backjo/following{/other_user}","gists_url":"https://api.github.com/users/backjo/gists{/gist_id}","starred_url":"https://api.github.com/users/backjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backjo/subscriptions","organizations_url":"https://api.github.com/users/backjo/orgs","repos_url":"https://api.github.com/users/backjo/repos","events_url":"https://api.github.com/users/backjo/events{/privacy}","received_events_url":"https://api.github.com/users/backjo/received_events","type":"User","site_admin":false},"repo":{"id":202602649,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI2MDI2NDk=","name":"jaeger","full_name":"backjo/jaeger","private":false,"owner":{"login":"backjo","id":2441427,"node_id":"MDQ6VXNlcjI0NDE0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/2441427?v=4","gravatar_id":"","url":"https://api.github.com/users/backjo","html_url":"https://github.com/backjo","followers_url":"https://api.github.com/users/backjo/followers","following_url":"https://api.github.com/users/backjo/following{/other_user}","gists_url":"https://api.github.com/users/backjo/gists{/gist_id}","starred_url":"https://api.github.com/users/backjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backjo/subscriptions","organizations_url":"https://api.github.com/users/backjo/orgs","repos_url":"https://api.github.com/users/backjo/repos","events_url":"https://api.github.com/users/backjo/events{/privacy}","received_events_url":"https://api.github.com/users/backjo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/backjo/jaeger","description":"CNCF Jaeger, a Distributed Tracing Platform","fork":true,"url":"https://api.github.com/repos/backjo/jaeger","forks_url":"https://api.github.com/repos/backjo/jaeger/forks","keys_url":"https://api.github.com/repos/backjo/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/backjo/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/backjo/jaeger/teams","hooks_url":"https://api.github.com/repos/backjo/jaeger/hooks","issue_events_url":"https://api.github.com/repos/backjo/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/backjo/jaeger/events","assignees_url":"https://api.github.com/repos/backjo/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/backjo/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/backjo/jaeger/tags","blobs_url":"https://api.github.com/repos/backjo/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/backjo/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/backjo/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/backjo/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/backjo/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/backjo/jaeger/languages","stargazers_url":"https://api.github.com/repos/backjo/jaeger/stargazers","contributors_url":"https://api.github.com/repos/backjo/jaeger/contributors","subscribers_url":"https://api.github.com/repos/backjo/jaeger/subscribers","subscription_url":"https://api.github.com/repos/backjo/jaeger/subscription","commits_url":"https://api.github.com/repos/backjo/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/backjo/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/backjo/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/backjo/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/backjo/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/backjo/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/backjo/jaeger/merges","archive_url":"https://api.github.com/repos/backjo/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/backjo/jaeger/downloads","issues_url":"https://api.github.com/repos/backjo/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/backjo/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/backjo/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/backjo/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/backjo/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/backjo/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/backjo/jaeger/deployments","created_at":"2019-08-15T19:51:22Z","updated_at":"2019-08-15T19:51:25Z","pushed_at":"2019-12-19T03:06:08Z","git_url":"git://github.com/backjo/jaeger.git","ssh_url":"git@github.com:backjo/jaeger.git","clone_url":"https://github.com/backjo/jaeger.git","svn_url":"https://github.com/backjo/jaeger","homepage":"https://jaegertracing.io/","size":18510,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"46d7f177942ce11e43ab010e14ff465a0766fda7","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56342508,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM0MjUwOA==","name":"jaeger","full_name":"jaegertracing/jaeger","private":false,"owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jaegertracing/jaeger","description":"CNCF Jaeger, a Distributed Tracing Platform","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger","forks_url":"https://api.github.com/repos/jaegertracing/jaeger/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger/deployments","created_at":"2016-04-15T18:49:02Z","updated_at":"2019-12-19T10:47:33Z","pushed_at":"2019-12-19T09:27:28Z","git_url":"git://github.com/jaegertracing/jaeger.git","ssh_url":"git@github.com:jaegertracing/jaeger.git","clone_url":"https://github.com/jaegertracing/jaeger.git","svn_url":"https://github.com/jaegertracing/jaeger","homepage":"https://jaegertracing.io/","size":18450,"stargazers_count":9838,"watchers_count":9838,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1054,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":328,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1054,"open_issues":328,"watchers":9838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/1838"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/1838"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/1838/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1838/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger/statuses/0eaf54cef5932f3f6ade618b28cc7760b6de02f8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 56342508,
"name": "jaegertracing/jaeger",
"url": "https://api.github.com/repos/jaegertracing/jaeger"
}
|
{
"id": 5618424,
"login": "pavolloffay",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5618424?",
"url": "https://api.github.com/users/pavolloffay"
}
|
{
"id": 28545596,
"login": "jaegertracing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28545596?",
"url": "https://api.github.com/orgs/jaegertracing"
}
| 2019-12-19T11:50:57 |
11125374349
|
{"actor":{"display_login":"pavolloffay"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/comments/277620021","pull_request_review_id":229478518,"id":277620021,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzYyMDAyMQ==","diff_hunk":"@@ -0,0 +1,24 @@\n+\"\"\"empty message","path":"migrations/versions/2019_04_18_add_topic_short_title.py","position":null,"original_position":1,"commit_id":"17708d40964799bdece78473063d77f850ae91c0","original_commit_id":"9656d637dfcdc6056929f1358a0eb4cf2ffb851b","user":{"login":"frankieroberto","id":30665,"node_id":"MDQ6VXNlcjMwNjY1","avatar_url":"https://avatars0.githubusercontent.com/u/30665?v=4","gravatar_id":"","url":"https://api.github.com/users/frankieroberto","html_url":"https://github.com/frankieroberto","followers_url":"https://api.github.com/users/frankieroberto/followers","following_url":"https://api.github.com/users/frankieroberto/following{/other_user}","gists_url":"https://api.github.com/users/frankieroberto/gists{/gist_id}","starred_url":"https://api.github.com/users/frankieroberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankieroberto/subscriptions","organizations_url":"https://api.github.com/users/frankieroberto/orgs","repos_url":"https://api.github.com/users/frankieroberto/repos","events_url":"https://api.github.com/users/frankieroberto/events{/privacy}","received_events_url":"https://api.github.com/users/frankieroberto/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2019-04-23T10:52:07Z","updated_at":"2019-04-23T10:52:07Z","html_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher/pull/1062#discussion_r277620021","pull_request_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/comments/277620021"},"html":{"href":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher/pull/1062#discussion_r277620021"},"pull_request":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062"}},"in_reply_to_id":277601462},"pull_request":{"url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062","id":271720242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNzIwMjQy","html_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher/pull/1062","diff_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher/pull/1062.diff","patch_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher/pull/1062.patch","issue_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/1062","number":1062,"state":"open","locked":false,"title":"Add topic short titles","user":{"login":"frankieroberto","id":30665,"node_id":"MDQ6VXNlcjMwNjY1","avatar_url":"https://avatars0.githubusercontent.com/u/30665?v=4","gravatar_id":"","url":"https://api.github.com/users/frankieroberto","html_url":"https://github.com/frankieroberto","followers_url":"https://api.github.com/users/frankieroberto/followers","following_url":"https://api.github.com/users/frankieroberto/following{/other_user}","gists_url":"https://api.github.com/users/frankieroberto/gists{/gist_id}","starred_url":"https://api.github.com/users/frankieroberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankieroberto/subscriptions","organizations_url":"https://api.github.com/users/frankieroberto/orgs","repos_url":"https://api.github.com/users/frankieroberto/repos","events_url":"https://api.github.com/users/frankieroberto/events{/privacy}","received_events_url":"https://api.github.com/users/frankieroberto/received_events","type":"User","site_admin":false},"body":"This adds the ability to have short titles for topics, which are then used on the homepage instead of the longer title.\r\n\r\nSee https://trello.com/c/nTXRy9hU/1508-add-short-title-for-topics","created_at":"2019-04-18T14:50:23Z","updated_at":"2019-04-23T10:52:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5f3748bab3a033948e693db120ed9300fe2a09f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062/commits","review_comments_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062/comments","review_comment_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/1062/comments","statuses_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/statuses/17708d40964799bdece78473063d77f850ae91c0","head":{"label":"racedisparityaudit:add_topic_short_title","ref":"add_topic_short_title","sha":"17708d40964799bdece78473063d77f850ae91c0","user":{"login":"racedisparityaudit","id":28758522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzU4NTIy","avatar_url":"https://avatars1.githubusercontent.com/u/28758522?v=4","gravatar_id":"","url":"https://api.github.com/users/racedisparityaudit","html_url":"https://github.com/racedisparityaudit","followers_url":"https://api.github.com/users/racedisparityaudit/followers","following_url":"https://api.github.com/users/racedisparityaudit/following{/other_user}","gists_url":"https://api.github.com/users/racedisparityaudit/gists{/gist_id}","starred_url":"https://api.github.com/users/racedisparityaudit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racedisparityaudit/subscriptions","organizations_url":"https://api.github.com/users/racedisparityaudit/orgs","repos_url":"https://api.github.com/users/racedisparityaudit/repos","events_url":"https://api.github.com/users/racedisparityaudit/events{/privacy}","received_events_url":"https://api.github.com/users/racedisparityaudit/received_events","type":"Organization","site_admin":false},"repo":{"id":88068354,"node_id":"MDEwOlJlcG9zaXRvcnk4ODA2ODM1NA==","name":"ethnicity-facts-and-figures-publisher","full_name":"racedisparityaudit/ethnicity-facts-and-figures-publisher","private":false,"owner":{"login":"racedisparityaudit","id":28758522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzU4NTIy","avatar_url":"https://avatars1.githubusercontent.com/u/28758522?v=4","gravatar_id":"","url":"https://api.github.com/users/racedisparityaudit","html_url":"https://github.com/racedisparityaudit","followers_url":"https://api.github.com/users/racedisparityaudit/followers","following_url":"https://api.github.com/users/racedisparityaudit/following{/other_user}","gists_url":"https://api.github.com/users/racedisparityaudit/gists{/gist_id}","starred_url":"https://api.github.com/users/racedisparityaudit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racedisparityaudit/subscriptions","organizations_url":"https://api.github.com/users/racedisparityaudit/orgs","repos_url":"https://api.github.com/users/racedisparityaudit/repos","events_url":"https://api.github.com/users/racedisparityaudit/events{/privacy}","received_events_url":"https://api.github.com/users/racedisparityaudit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher","description":"The Publisher for the Ethnicity facts and figures website","fork":false,"url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher","forks_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/forks","keys_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/teams","hooks_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/hooks","issue_events_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/events","assignees_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/tags","blobs_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/languages","stargazers_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/stargazers","contributors_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/contributors","subscribers_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/subscribers","subscription_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/subscription","commits_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/merges","archive_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/downloads","issues_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/labels{/name}","releases_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/deployments","created_at":"2017-04-12T15:35:02Z","updated_at":"2019-04-23T09:59:13Z","pushed_at":"2019-04-23T10:52:07Z","git_url":"git://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher.git","ssh_url":"git@github.com:racedisparityaudit/ethnicity-facts-and-figures-publisher.git","clone_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher.git","svn_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher","homepage":"https://www.ethnicity-facts-figures.service.gov.uk/","size":16336,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"racedisparityaudit:master","ref":"master","sha":"5198eede41e87daacdf085a4a89e9a556ff1d8c0","user":{"login":"racedisparityaudit","id":28758522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzU4NTIy","avatar_url":"https://avatars1.githubusercontent.com/u/28758522?v=4","gravatar_id":"","url":"https://api.github.com/users/racedisparityaudit","html_url":"https://github.com/racedisparityaudit","followers_url":"https://api.github.com/users/racedisparityaudit/followers","following_url":"https://api.github.com/users/racedisparityaudit/following{/other_user}","gists_url":"https://api.github.com/users/racedisparityaudit/gists{/gist_id}","starred_url":"https://api.github.com/users/racedisparityaudit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racedisparityaudit/subscriptions","organizations_url":"https://api.github.com/users/racedisparityaudit/orgs","repos_url":"https://api.github.com/users/racedisparityaudit/repos","events_url":"https://api.github.com/users/racedisparityaudit/events{/privacy}","received_events_url":"https://api.github.com/users/racedisparityaudit/received_events","type":"Organization","site_admin":false},"repo":{"id":88068354,"node_id":"MDEwOlJlcG9zaXRvcnk4ODA2ODM1NA==","name":"ethnicity-facts-and-figures-publisher","full_name":"racedisparityaudit/ethnicity-facts-and-figures-publisher","private":false,"owner":{"login":"racedisparityaudit","id":28758522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzU4NTIy","avatar_url":"https://avatars1.githubusercontent.com/u/28758522?v=4","gravatar_id":"","url":"https://api.github.com/users/racedisparityaudit","html_url":"https://github.com/racedisparityaudit","followers_url":"https://api.github.com/users/racedisparityaudit/followers","following_url":"https://api.github.com/users/racedisparityaudit/following{/other_user}","gists_url":"https://api.github.com/users/racedisparityaudit/gists{/gist_id}","starred_url":"https://api.github.com/users/racedisparityaudit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racedisparityaudit/subscriptions","organizations_url":"https://api.github.com/users/racedisparityaudit/orgs","repos_url":"https://api.github.com/users/racedisparityaudit/repos","events_url":"https://api.github.com/users/racedisparityaudit/events{/privacy}","received_events_url":"https://api.github.com/users/racedisparityaudit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher","description":"The Publisher for the Ethnicity facts and figures website","fork":false,"url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher","forks_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/forks","keys_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/teams","hooks_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/hooks","issue_events_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/events","assignees_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/tags","blobs_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/languages","stargazers_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/stargazers","contributors_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/contributors","subscribers_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/subscribers","subscription_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/subscription","commits_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/merges","archive_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/downloads","issues_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/labels{/name}","releases_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/deployments","created_at":"2017-04-12T15:35:02Z","updated_at":"2019-04-23T09:59:13Z","pushed_at":"2019-04-23T10:52:07Z","git_url":"git://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher.git","ssh_url":"git@github.com:racedisparityaudit/ethnicity-facts-and-figures-publisher.git","clone_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher.git","svn_url":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher","homepage":"https://www.ethnicity-facts-figures.service.gov.uk/","size":16336,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062"},"html":{"href":"https://github.com/racedisparityaudit/ethnicity-facts-and-figures-publisher/pull/1062"},"issue":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/1062"},"comments":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/issues/1062/comments"},"review_comments":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062/comments"},"review_comment":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/pulls/1062/commits"},"statuses":{"href":"https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher/statuses/17708d40964799bdece78473063d77f850ae91c0"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 88068354,
"name": "racedisparityaudit/ethnicity-facts-and-figures-publisher",
"url": "https://api.github.com/repos/racedisparityaudit/ethnicity-facts-and-figures-publisher"
}
|
{
"id": 30665,
"login": "frankieroberto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30665?",
"url": "https://api.github.com/users/frankieroberto"
}
|
{
"id": 28758522,
"login": "racedisparityaudit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28758522?",
"url": "https://api.github.com/orgs/racedisparityaudit"
}
| 2019-04-23T10:52:07 |
9492845287
|
{"actor":{"display_login":"frankieroberto"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/brave-intl/publishers/pulls/comments/271974092","pull_request_review_id":222504702,"id":271974092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTk3NDA5Mg==","diff_hunk":"@@ -0,0 +1,33 @@\n+# For users in the process of 2fa removal\n+\n+class TwoFactorAuthenticationRemovalJob < ApplicationJob\n+ queue_as :low\n+\n+ def perform\n+ two_factor_authentication_removals = TwoFactorAuthenticationRemoval.all\n+ two_factor_authentication_removals.each do |two_factor_authentication_removal|\n+ publisher = Publisher.find(two_factor_authentication_removal.publisher_id)\n+ # First 2 weeks of the job, send reminder e-mails\n+ if !two_factor_authentication_removal.two_factor_authentication_removal_time_completed?\n+ MailerServices::TwoFactorAuthenticationRemovalReminderEmailer.new(publisher: publisher).perform\n+\n+ # 14th day of the job\n+ elsif two_factor_authentication_removal.two_factor_authentication_removal_time_completed? && !two_factor_authentication_removal.removal_completed?\n+ # Delete 2fa registrations, channels, and disconnect wallet\n+ publisher.totp_registration.destroy if publisher.totp_registration.present?\n+ publisher.u2f_registrations.destroy_all if !publisher.u2f_registrations.empty?\n+ publisher.channels.destroy_all if !publisher.channels.empty?","path":"app/jobs/two_factor_authentication_removal_job.rb","position":19,"original_position":19,"commit_id":"2426c3a05aabb636dec3e30d5dbd1706f630b8aa","original_commit_id":"50693fdf55ddad1cf317a6ccefdbfdc0d0c42982","user":{"login":"yachtcaptain23","id":8647607,"node_id":"MDQ6VXNlcjg2NDc2MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/8647607?v=4","gravatar_id":"","url":"https://api.github.com/users/yachtcaptain23","html_url":"https://github.com/yachtcaptain23","followers_url":"https://api.github.com/users/yachtcaptain23/followers","following_url":"https://api.github.com/users/yachtcaptain23/following{/other_user}","gists_url":"https://api.github.com/users/yachtcaptain23/gists{/gist_id}","starred_url":"https://api.github.com/users/yachtcaptain23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yachtcaptain23/subscriptions","organizations_url":"https://api.github.com/users/yachtcaptain23/orgs","repos_url":"https://api.github.com/users/yachtcaptain23/repos","events_url":"https://api.github.com/users/yachtcaptain23/events{/privacy}","received_events_url":"https://api.github.com/users/yachtcaptain23/received_events","type":"User","site_admin":false},"body":"Users need to still be paid. Please don't destroy, but you can remove the `publisher_id` on the `channels` table.","created_at":"2019-04-03T23:46:37Z","updated_at":"2019-04-03T23:46:37Z","html_url":"https://github.com/brave-intl/publishers/pull/1732#discussion_r271974092","pull_request_url":"https://api.github.com/repos/brave-intl/publishers/pulls/1732","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/brave-intl/publishers/pulls/comments/271974092"},"html":{"href":"https://github.com/brave-intl/publishers/pull/1732#discussion_r271974092"},"pull_request":{"href":"https://api.github.com/repos/brave-intl/publishers/pulls/1732"}}},"pull_request":{"url":"https://api.github.com/repos/brave-intl/publishers/pulls/1732","id":262705449,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNzA1NDQ5","html_url":"https://github.com/brave-intl/publishers/pull/1732","diff_url":"https://github.com/brave-intl/publishers/pull/1732.diff","patch_url":"https://github.com/brave-intl/publishers/pull/1732.patch","issue_url":"https://api.github.com/repos/brave-intl/publishers/issues/1732","number":1732,"state":"open","locked":false,"title":"2FA Removal Feature 🏷 ","user":{"login":"dlipeles","id":4713771,"node_id":"MDQ6VXNlcjQ3MTM3NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4713771?v=4","gravatar_id":"","url":"https://api.github.com/users/dlipeles","html_url":"https://github.com/dlipeles","followers_url":"https://api.github.com/users/dlipeles/followers","following_url":"https://api.github.com/users/dlipeles/following{/other_user}","gists_url":"https://api.github.com/users/dlipeles/gists{/gist_id}","starred_url":"https://api.github.com/users/dlipeles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlipeles/subscriptions","organizations_url":"https://api.github.com/users/dlipeles/orgs","repos_url":"https://api.github.com/users/dlipeles/repos","events_url":"https://api.github.com/users/dlipeles/events{/privacy}","received_events_url":"https://api.github.com/users/dlipeles/received_events","type":"User","site_admin":false},"body":"### 2FA Removal Feature 🔐 \r\n\r\n\r\n#### Features \r\nThis pull request fulfills the `2fa Removal Spec` for publishers who have lost their second factor authenticator, but wish to regain access to their account. \r\n\r\n* Options - Provides an alternative to creating a new account and transferring channels.\r\n* Secure Flow - Enforces a waiting period & requires re-verification of channels/wallet.\r\n* Self Service - Publishers can initiate the removal at their convenience.\r\n\r\n#### Notes\r\n* Admins can see the progress of a 2fa removal from the publisher page.\r\n* There is a `2 week waiting period` before 2fa removal , then a `4 week lockout` on payments for the publisher's security.\r\n* Admins can preempt a 2fa removal or lockout from the admin dashboard.\r\n\r\n#### How To Test\r\n\r\n#### Setup\r\n* Set the `TWO_FACTOR_AUTHENTICATION_REMOVAL_WAITING_PERIOD` to `300` seconds and `LOCKED_STATUS_WAITING_PERIOD` to `300` seconds. \r\n* Set the cron job in sidekiq to every minute `* * * * *`.\r\n* Create a publisher with `2fa enabled`, `channels`, and a `wallet`.\r\n* Request the 2fa removal from the landing page, confirm the e-mail. \r\n\r\n#### In Action\r\n* Log in as an `Admin` to see progress on the job. \r\n* You should see the following sequence: \r\n1. `2fa job registered` \r\n2. `Reminder e-mails sent`\r\n3. `Publisher 2fa removed`, `Publisher channels removed`, `Publisher wallet disconnected`, `Publisher state becomes LOCKED`\r\n4. `2fa job completed`, `Publisher state becomes ACTIVE`","created_at":"2019-03-20T03:20:51Z","updated_at":"2019-04-03T23:46:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98b9ee6bf03d8a0dca5ab3d692ae3be0155cfd74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave-intl/publishers/pulls/1732/commits","review_comments_url":"https://api.github.com/repos/brave-intl/publishers/pulls/1732/comments","review_comment_url":"https://api.github.com/repos/brave-intl/publishers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave-intl/publishers/issues/1732/comments","statuses_url":"https://api.github.com/repos/brave-intl/publishers/statuses/2426c3a05aabb636dec3e30d5dbd1706f630b8aa","head":{"label":"brave-intl:2fa-removal-foundation","ref":"2fa-removal-foundation","sha":"2426c3a05aabb636dec3e30d5dbd1706f630b8aa","user":{"login":"brave-intl","id":28767864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY3ODY0","avatar_url":"https://avatars2.githubusercontent.com/u/28767864?v=4","gravatar_id":"","url":"https://api.github.com/users/brave-intl","html_url":"https://github.com/brave-intl","followers_url":"https://api.github.com/users/brave-intl/followers","following_url":"https://api.github.com/users/brave-intl/following{/other_user}","gists_url":"https://api.github.com/users/brave-intl/gists{/gist_id}","starred_url":"https://api.github.com/users/brave-intl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave-intl/subscriptions","organizations_url":"https://api.github.com/users/brave-intl/orgs","repos_url":"https://api.github.com/users/brave-intl/repos","events_url":"https://api.github.com/users/brave-intl/events{/privacy}","received_events_url":"https://api.github.com/users/brave-intl/received_events","type":"Organization","site_admin":false},"repo":{"id":69634519,"node_id":"MDEwOlJlcG9zaXRvcnk2OTYzNDUxOQ==","name":"publishers","full_name":"brave-intl/publishers","private":false,"owner":{"login":"brave-intl","id":28767864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY3ODY0","avatar_url":"https://avatars2.githubusercontent.com/u/28767864?v=4","gravatar_id":"","url":"https://api.github.com/users/brave-intl","html_url":"https://github.com/brave-intl","followers_url":"https://api.github.com/users/brave-intl/followers","following_url":"https://api.github.com/users/brave-intl/following{/other_user}","gists_url":"https://api.github.com/users/brave-intl/gists{/gist_id}","starred_url":"https://api.github.com/users/brave-intl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave-intl/subscriptions","organizations_url":"https://api.github.com/users/brave-intl/orgs","repos_url":"https://api.github.com/users/brave-intl/repos","events_url":"https://api.github.com/users/brave-intl/events{/privacy}","received_events_url":"https://api.github.com/users/brave-intl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave-intl/publishers","description":"Publisher interface for Brave Payments","fork":false,"url":"https://api.github.com/repos/brave-intl/publishers","forks_url":"https://api.github.com/repos/brave-intl/publishers/forks","keys_url":"https://api.github.com/repos/brave-intl/publishers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave-intl/publishers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave-intl/publishers/teams","hooks_url":"https://api.github.com/repos/brave-intl/publishers/hooks","issue_events_url":"https://api.github.com/repos/brave-intl/publishers/issues/events{/number}","events_url":"https://api.github.com/repos/brave-intl/publishers/events","assignees_url":"https://api.github.com/repos/brave-intl/publishers/assignees{/user}","branches_url":"https://api.github.com/repos/brave-intl/publishers/branches{/branch}","tags_url":"https://api.github.com/repos/brave-intl/publishers/tags","blobs_url":"https://api.github.com/repos/brave-intl/publishers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave-intl/publishers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave-intl/publishers/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave-intl/publishers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave-intl/publishers/statuses/{sha}","languages_url":"https://api.github.com/repos/brave-intl/publishers/languages","stargazers_url":"https://api.github.com/repos/brave-intl/publishers/stargazers","contributors_url":"https://api.github.com/repos/brave-intl/publishers/contributors","subscribers_url":"https://api.github.com/repos/brave-intl/publishers/subscribers","subscription_url":"https://api.github.com/repos/brave-intl/publishers/subscription","commits_url":"https://api.github.com/repos/brave-intl/publishers/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave-intl/publishers/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave-intl/publishers/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave-intl/publishers/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave-intl/publishers/contents/{+path}","compare_url":"https://api.github.com/repos/brave-intl/publishers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave-intl/publishers/merges","archive_url":"https://api.github.com/repos/brave-intl/publishers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave-intl/publishers/downloads","issues_url":"https://api.github.com/repos/brave-intl/publishers/issues{/number}","pulls_url":"https://api.github.com/repos/brave-intl/publishers/pulls{/number}","milestones_url":"https://api.github.com/repos/brave-intl/publishers/milestones{/number}","notifications_url":"https://api.github.com/repos/brave-intl/publishers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave-intl/publishers/labels{/name}","releases_url":"https://api.github.com/repos/brave-intl/publishers/releases{/id}","deployments_url":"https://api.github.com/repos/brave-intl/publishers/deployments","created_at":"2016-09-30T04:47:29Z","updated_at":"2019-04-01T23:48:45Z","pushed_at":"2019-04-03T23:38:50Z","git_url":"git://github.com/brave-intl/publishers.git","ssh_url":"git@github.com:brave-intl/publishers.git","clone_url":"https://github.com/brave-intl/publishers.git","svn_url":"https://github.com/brave-intl/publishers","homepage":"https://publishers.basicattentiontoken.org","size":19253,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":113,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":20,"open_issues":113,"watchers":29,"default_branch":"staging"}},"base":{"label":"brave-intl:staging","ref":"staging","sha":"c49a3df5fd925139ce9ae15a37cf39ca25bad570","user":{"login":"brave-intl","id":28767864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY3ODY0","avatar_url":"https://avatars2.githubusercontent.com/u/28767864?v=4","gravatar_id":"","url":"https://api.github.com/users/brave-intl","html_url":"https://github.com/brave-intl","followers_url":"https://api.github.com/users/brave-intl/followers","following_url":"https://api.github.com/users/brave-intl/following{/other_user}","gists_url":"https://api.github.com/users/brave-intl/gists{/gist_id}","starred_url":"https://api.github.com/users/brave-intl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave-intl/subscriptions","organizations_url":"https://api.github.com/users/brave-intl/orgs","repos_url":"https://api.github.com/users/brave-intl/repos","events_url":"https://api.github.com/users/brave-intl/events{/privacy}","received_events_url":"https://api.github.com/users/brave-intl/received_events","type":"Organization","site_admin":false},"repo":{"id":69634519,"node_id":"MDEwOlJlcG9zaXRvcnk2OTYzNDUxOQ==","name":"publishers","full_name":"brave-intl/publishers","private":false,"owner":{"login":"brave-intl","id":28767864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY3ODY0","avatar_url":"https://avatars2.githubusercontent.com/u/28767864?v=4","gravatar_id":"","url":"https://api.github.com/users/brave-intl","html_url":"https://github.com/brave-intl","followers_url":"https://api.github.com/users/brave-intl/followers","following_url":"https://api.github.com/users/brave-intl/following{/other_user}","gists_url":"https://api.github.com/users/brave-intl/gists{/gist_id}","starred_url":"https://api.github.com/users/brave-intl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave-intl/subscriptions","organizations_url":"https://api.github.com/users/brave-intl/orgs","repos_url":"https://api.github.com/users/brave-intl/repos","events_url":"https://api.github.com/users/brave-intl/events{/privacy}","received_events_url":"https://api.github.com/users/brave-intl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave-intl/publishers","description":"Publisher interface for Brave Payments","fork":false,"url":"https://api.github.com/repos/brave-intl/publishers","forks_url":"https://api.github.com/repos/brave-intl/publishers/forks","keys_url":"https://api.github.com/repos/brave-intl/publishers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave-intl/publishers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave-intl/publishers/teams","hooks_url":"https://api.github.com/repos/brave-intl/publishers/hooks","issue_events_url":"https://api.github.com/repos/brave-intl/publishers/issues/events{/number}","events_url":"https://api.github.com/repos/brave-intl/publishers/events","assignees_url":"https://api.github.com/repos/brave-intl/publishers/assignees{/user}","branches_url":"https://api.github.com/repos/brave-intl/publishers/branches{/branch}","tags_url":"https://api.github.com/repos/brave-intl/publishers/tags","blobs_url":"https://api.github.com/repos/brave-intl/publishers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave-intl/publishers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave-intl/publishers/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave-intl/publishers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave-intl/publishers/statuses/{sha}","languages_url":"https://api.github.com/repos/brave-intl/publishers/languages","stargazers_url":"https://api.github.com/repos/brave-intl/publishers/stargazers","contributors_url":"https://api.github.com/repos/brave-intl/publishers/contributors","subscribers_url":"https://api.github.com/repos/brave-intl/publishers/subscribers","subscription_url":"https://api.github.com/repos/brave-intl/publishers/subscription","commits_url":"https://api.github.com/repos/brave-intl/publishers/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave-intl/publishers/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave-intl/publishers/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave-intl/publishers/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave-intl/publishers/contents/{+path}","compare_url":"https://api.github.com/repos/brave-intl/publishers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave-intl/publishers/merges","archive_url":"https://api.github.com/repos/brave-intl/publishers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave-intl/publishers/downloads","issues_url":"https://api.github.com/repos/brave-intl/publishers/issues{/number}","pulls_url":"https://api.github.com/repos/brave-intl/publishers/pulls{/number}","milestones_url":"https://api.github.com/repos/brave-intl/publishers/milestones{/number}","notifications_url":"https://api.github.com/repos/brave-intl/publishers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave-intl/publishers/labels{/name}","releases_url":"https://api.github.com/repos/brave-intl/publishers/releases{/id}","deployments_url":"https://api.github.com/repos/brave-intl/publishers/deployments","created_at":"2016-09-30T04:47:29Z","updated_at":"2019-04-01T23:48:45Z","pushed_at":"2019-04-03T23:38:50Z","git_url":"git://github.com/brave-intl/publishers.git","ssh_url":"git@github.com:brave-intl/publishers.git","clone_url":"https://github.com/brave-intl/publishers.git","svn_url":"https://github.com/brave-intl/publishers","homepage":"https://publishers.basicattentiontoken.org","size":19253,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":113,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":20,"open_issues":113,"watchers":29,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/brave-intl/publishers/pulls/1732"},"html":{"href":"https://github.com/brave-intl/publishers/pull/1732"},"issue":{"href":"https://api.github.com/repos/brave-intl/publishers/issues/1732"},"comments":{"href":"https://api.github.com/repos/brave-intl/publishers/issues/1732/comments"},"review_comments":{"href":"https://api.github.com/repos/brave-intl/publishers/pulls/1732/comments"},"review_comment":{"href":"https://api.github.com/repos/brave-intl/publishers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave-intl/publishers/pulls/1732/commits"},"statuses":{"href":"https://api.github.com/repos/brave-intl/publishers/statuses/2426c3a05aabb636dec3e30d5dbd1706f630b8aa"}},"author_association":"COLLABORATOR"}}
|
{
"id": 69634519,
"name": "brave-intl/publishers",
"url": "https://api.github.com/repos/brave-intl/publishers"
}
|
{
"id": 8647607,
"login": "yachtcaptain23",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8647607?",
"url": "https://api.github.com/users/yachtcaptain23"
}
|
{
"id": 28767864,
"login": "brave-intl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28767864?",
"url": "https://api.github.com/orgs/brave-intl"
}
| 2019-04-03T23:46:37 |
9374533894
|
{"actor":{"display_login":"yachtcaptain23"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments/358399228","pull_request_review_id":332782011,"id":358399228,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODM5OTIyOA==","diff_hunk":"@@ -84,21 +86,32 @@ Status PathReuseDecider::Process(Frame* const frame,\n reference_line_info->set_path_reusable(false);\n ADEBUG << \"reusable_path_counter[\" << reusable_path_counter_\n << \"] total_path_counter[\" << total_path_counter_ << \"]\";\n+ ADEBUG << \"Stop reusing path when optimization failed on change lane path\";\n return Status::OK();\n }\n \n- bool path_reusable = false;\n- if (!frame->current_frame_planned_trajectory().is_replan() &&\n- CheckPathReusable(frame, reference_line_info) &&\n- TrimHistoryPath(frame, reference_line_info)) {\n- ADEBUG << \"reuse path\";\n- path_reusable = true;\n- ++reusable_path_counter_; // count reusable path\n+ // stop reusing current path:\n+ // 1. replan path\n+ // 2. collision\n+ // 3. failed to trim previous path\n+ // 4. speed optimization failed on previous path\n+ // const auto history_trajectory_type = FrameHistory::Instance()\n+ // ->Latest()\n+ // ->reference_line_info()\n+ // .front()\n+ // .trajectory_type();\n+ if (path_reusable_) {\n+ if (!frame->current_frame_planned_trajectory().is_replan() &&\n+ CheckPathReusable(frame, reference_line_info) &&","path":"modules/planning/tasks/deciders/path_reuse_decider/path_reuse_decider.cc","position":43,"original_position":43,"commit_id":"eaa4f955c4955d1c630ebc9c6fb5487c1964230e","original_commit_id":"eaa4f955c4955d1c630ebc9c6fb5487c1964230e","user":{"login":"Capri2014","id":4761061,"node_id":"MDQ6VXNlcjQ3NjEwNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4761061?v=4","gravatar_id":"","url":"https://api.github.com/users/Capri2014","html_url":"https://github.com/Capri2014","followers_url":"https://api.github.com/users/Capri2014/followers","following_url":"https://api.github.com/users/Capri2014/following{/other_user}","gists_url":"https://api.github.com/users/Capri2014/gists{/gist_id}","starred_url":"https://api.github.com/users/Capri2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Capri2014/subscriptions","organizations_url":"https://api.github.com/users/Capri2014/orgs","repos_url":"https://api.github.com/users/Capri2014/repos","events_url":"https://api.github.com/users/Capri2014/events{/privacy}","received_events_url":"https://api.github.com/users/Capri2014/received_events","type":"User","site_admin":false},"body":"replace the name `CheckPathReusable` to avoid confusion, it look like we are expecting false here, util I saw in implementation that you are just returning the `IsCollisionFree` results. ","created_at":"2019-12-16T18:41:54Z","updated_at":"2019-12-16T18:42:08Z","html_url":"https://github.com/ApolloAuto/apollo/pull/10523#discussion_r358399228","pull_request_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments/358399228"},"html":{"href":"https://github.com/ApolloAuto/apollo/pull/10523#discussion_r358399228"},"pull_request":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523"}}},"pull_request":{"url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523","id":353702444,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzNzAyNDQ0","html_url":"https://github.com/ApolloAuto/apollo/pull/10523","diff_url":"https://github.com/ApolloAuto/apollo/pull/10523.diff","patch_url":"https://github.com/ApolloAuto/apollo/pull/10523.patch","issue_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/10523","number":10523,"state":"open","locked":false,"title":"Planning: updated path_reuse logic","user":{"login":"sjiang2018","id":41413582,"node_id":"MDQ6VXNlcjQxNDEzNTgy","avatar_url":"https://avatars3.githubusercontent.com/u/41413582?v=4","gravatar_id":"","url":"https://api.github.com/users/sjiang2018","html_url":"https://github.com/sjiang2018","followers_url":"https://api.github.com/users/sjiang2018/followers","following_url":"https://api.github.com/users/sjiang2018/following{/other_user}","gists_url":"https://api.github.com/users/sjiang2018/gists{/gist_id}","starred_url":"https://api.github.com/users/sjiang2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjiang2018/subscriptions","organizations_url":"https://api.github.com/users/sjiang2018/orgs","repos_url":"https://api.github.com/users/sjiang2018/repos","events_url":"https://api.github.com/users/sjiang2018/events{/privacy}","received_events_url":"https://api.github.com/users/sjiang2018/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-16T18:33:19Z","updated_at":"2019-12-16T18:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e08c55b6e15fa6b8327110420168aa122d0c5a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yifeijiang","id":13139627,"node_id":"MDQ6VXNlcjEzMTM5NjI3","avatar_url":"https://avatars3.githubusercontent.com/u/13139627?v=4","gravatar_id":"","url":"https://api.github.com/users/yifeijiang","html_url":"https://github.com/yifeijiang","followers_url":"https://api.github.com/users/yifeijiang/followers","following_url":"https://api.github.com/users/yifeijiang/following{/other_user}","gists_url":"https://api.github.com/users/yifeijiang/gists{/gist_id}","starred_url":"https://api.github.com/users/yifeijiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifeijiang/subscriptions","organizations_url":"https://api.github.com/users/yifeijiang/orgs","repos_url":"https://api.github.com/users/yifeijiang/repos","events_url":"https://api.github.com/users/yifeijiang/events{/privacy}","received_events_url":"https://api.github.com/users/yifeijiang/received_events","type":"User","site_admin":false},{"login":"JasonXu12","id":18713054,"node_id":"MDQ6VXNlcjE4NzEzMDU0","avatar_url":"https://avatars0.githubusercontent.com/u/18713054?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonXu12","html_url":"https://github.com/JasonXu12","followers_url":"https://api.github.com/users/JasonXu12/followers","following_url":"https://api.github.com/users/JasonXu12/following{/other_user}","gists_url":"https://api.github.com/users/JasonXu12/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonXu12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonXu12/subscriptions","organizations_url":"https://api.github.com/users/JasonXu12/orgs","repos_url":"https://api.github.com/users/JasonXu12/repos","events_url":"https://api.github.com/users/JasonXu12/events{/privacy}","received_events_url":"https://api.github.com/users/JasonXu12/received_events","type":"User","site_admin":false},{"login":"jmtao","id":29128228,"node_id":"MDQ6VXNlcjI5MTI4MjI4","avatar_url":"https://avatars0.githubusercontent.com/u/29128228?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtao","html_url":"https://github.com/jmtao","followers_url":"https://api.github.com/users/jmtao/followers","following_url":"https://api.github.com/users/jmtao/following{/other_user}","gists_url":"https://api.github.com/users/jmtao/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtao/subscriptions","organizations_url":"https://api.github.com/users/jmtao/orgs","repos_url":"https://api.github.com/users/jmtao/repos","events_url":"https://api.github.com/users/jmtao/events{/privacy}","received_events_url":"https://api.github.com/users/jmtao/received_events","type":"User","site_admin":false},{"login":"JasonZhou404","id":32111357,"node_id":"MDQ6VXNlcjMyMTExMzU3","avatar_url":"https://avatars0.githubusercontent.com/u/32111357?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonZhou404","html_url":"https://github.com/JasonZhou404","followers_url":"https://api.github.com/users/JasonZhou404/followers","following_url":"https://api.github.com/users/JasonZhou404/following{/other_user}","gists_url":"https://api.github.com/users/JasonZhou404/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonZhou404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonZhou404/subscriptions","organizations_url":"https://api.github.com/users/JasonZhou404/orgs","repos_url":"https://api.github.com/users/JasonZhou404/repos","events_url":"https://api.github.com/users/JasonZhou404/events{/privacy}","received_events_url":"https://api.github.com/users/JasonZhou404/received_events","type":"User","site_admin":false},{"login":"panjiacheng","id":43769418,"node_id":"MDQ6VXNlcjQzNzY5NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/43769418?v=4","gravatar_id":"","url":"https://api.github.com/users/panjiacheng","html_url":"https://github.com/panjiacheng","followers_url":"https://api.github.com/users/panjiacheng/followers","following_url":"https://api.github.com/users/panjiacheng/following{/other_user}","gists_url":"https://api.github.com/users/panjiacheng/gists{/gist_id}","starred_url":"https://api.github.com/users/panjiacheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panjiacheng/subscriptions","organizations_url":"https://api.github.com/users/panjiacheng/orgs","repos_url":"https://api.github.com/users/panjiacheng/repos","events_url":"https://api.github.com/users/panjiacheng/events{/privacy}","received_events_url":"https://api.github.com/users/panjiacheng/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523/commits","review_comments_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523/comments","review_comment_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/10523/comments","statuses_url":"https://api.github.com/repos/ApolloAuto/apollo/statuses/eaa4f955c4955d1c630ebc9c6fb5487c1964230e","head":{"label":"sjiang2018:path_reuse_WIP","ref":"path_reuse_WIP","sha":"eaa4f955c4955d1c630ebc9c6fb5487c1964230e","user":{"login":"sjiang2018","id":41413582,"node_id":"MDQ6VXNlcjQxNDEzNTgy","avatar_url":"https://avatars3.githubusercontent.com/u/41413582?v=4","gravatar_id":"","url":"https://api.github.com/users/sjiang2018","html_url":"https://github.com/sjiang2018","followers_url":"https://api.github.com/users/sjiang2018/followers","following_url":"https://api.github.com/users/sjiang2018/following{/other_user}","gists_url":"https://api.github.com/users/sjiang2018/gists{/gist_id}","starred_url":"https://api.github.com/users/sjiang2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjiang2018/subscriptions","organizations_url":"https://api.github.com/users/sjiang2018/orgs","repos_url":"https://api.github.com/users/sjiang2018/repos","events_url":"https://api.github.com/users/sjiang2018/events{/privacy}","received_events_url":"https://api.github.com/users/sjiang2018/received_events","type":"User","site_admin":false},"repo":{"id":163898939,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM4OTg5Mzk=","name":"apollo","full_name":"sjiang2018/apollo","private":false,"owner":{"login":"sjiang2018","id":41413582,"node_id":"MDQ6VXNlcjQxNDEzNTgy","avatar_url":"https://avatars3.githubusercontent.com/u/41413582?v=4","gravatar_id":"","url":"https://api.github.com/users/sjiang2018","html_url":"https://github.com/sjiang2018","followers_url":"https://api.github.com/users/sjiang2018/followers","following_url":"https://api.github.com/users/sjiang2018/following{/other_user}","gists_url":"https://api.github.com/users/sjiang2018/gists{/gist_id}","starred_url":"https://api.github.com/users/sjiang2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjiang2018/subscriptions","organizations_url":"https://api.github.com/users/sjiang2018/orgs","repos_url":"https://api.github.com/users/sjiang2018/repos","events_url":"https://api.github.com/users/sjiang2018/events{/privacy}","received_events_url":"https://api.github.com/users/sjiang2018/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sjiang2018/apollo","description":"An open autonomous driving platform","fork":true,"url":"https://api.github.com/repos/sjiang2018/apollo","forks_url":"https://api.github.com/repos/sjiang2018/apollo/forks","keys_url":"https://api.github.com/repos/sjiang2018/apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjiang2018/apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjiang2018/apollo/teams","hooks_url":"https://api.github.com/repos/sjiang2018/apollo/hooks","issue_events_url":"https://api.github.com/repos/sjiang2018/apollo/issues/events{/number}","events_url":"https://api.github.com/repos/sjiang2018/apollo/events","assignees_url":"https://api.github.com/repos/sjiang2018/apollo/assignees{/user}","branches_url":"https://api.github.com/repos/sjiang2018/apollo/branches{/branch}","tags_url":"https://api.github.com/repos/sjiang2018/apollo/tags","blobs_url":"https://api.github.com/repos/sjiang2018/apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjiang2018/apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjiang2018/apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjiang2018/apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjiang2018/apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/sjiang2018/apollo/languages","stargazers_url":"https://api.github.com/repos/sjiang2018/apollo/stargazers","contributors_url":"https://api.github.com/repos/sjiang2018/apollo/contributors","subscribers_url":"https://api.github.com/repos/sjiang2018/apollo/subscribers","subscription_url":"https://api.github.com/repos/sjiang2018/apollo/subscription","commits_url":"https://api.github.com/repos/sjiang2018/apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjiang2018/apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjiang2018/apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjiang2018/apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjiang2018/apollo/contents/{+path}","compare_url":"https://api.github.com/repos/sjiang2018/apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjiang2018/apollo/merges","archive_url":"https://api.github.com/repos/sjiang2018/apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjiang2018/apollo/downloads","issues_url":"https://api.github.com/repos/sjiang2018/apollo/issues{/number}","pulls_url":"https://api.github.com/repos/sjiang2018/apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/sjiang2018/apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/sjiang2018/apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjiang2018/apollo/labels{/name}","releases_url":"https://api.github.com/repos/sjiang2018/apollo/releases{/id}","deployments_url":"https://api.github.com/repos/sjiang2018/apollo/deployments","created_at":"2019-01-02T23:09:57Z","updated_at":"2019-12-13T22:54:01Z","pushed_at":"2019-12-16T18:32:07Z","git_url":"git://github.com/sjiang2018/apollo.git","ssh_url":"git@github.com:sjiang2018/apollo.git","clone_url":"https://github.com/sjiang2018/apollo.git","svn_url":"https://github.com/sjiang2018/apollo","homepage":null,"size":1811510,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ApolloAuto:master","ref":"master","sha":"3577ad4b719ea7b21cffb0d93c9355d77dedf135","user":{"login":"ApolloAuto","id":28768304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY4MzA0","avatar_url":"https://avatars1.githubusercontent.com/u/28768304?v=4","gravatar_id":"","url":"https://api.github.com/users/ApolloAuto","html_url":"https://github.com/ApolloAuto","followers_url":"https://api.github.com/users/ApolloAuto/followers","following_url":"https://api.github.com/users/ApolloAuto/following{/other_user}","gists_url":"https://api.github.com/users/ApolloAuto/gists{/gist_id}","starred_url":"https://api.github.com/users/ApolloAuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApolloAuto/subscriptions","organizations_url":"https://api.github.com/users/ApolloAuto/orgs","repos_url":"https://api.github.com/users/ApolloAuto/repos","events_url":"https://api.github.com/users/ApolloAuto/events{/privacy}","received_events_url":"https://api.github.com/users/ApolloAuto/received_events","type":"Organization","site_admin":false},"repo":{"id":96246170,"node_id":"MDEwOlJlcG9zaXRvcnk5NjI0NjE3MA==","name":"apollo","full_name":"ApolloAuto/apollo","private":false,"owner":{"login":"ApolloAuto","id":28768304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzY4MzA0","avatar_url":"https://avatars1.githubusercontent.com/u/28768304?v=4","gravatar_id":"","url":"https://api.github.com/users/ApolloAuto","html_url":"https://github.com/ApolloAuto","followers_url":"https://api.github.com/users/ApolloAuto/followers","following_url":"https://api.github.com/users/ApolloAuto/following{/other_user}","gists_url":"https://api.github.com/users/ApolloAuto/gists{/gist_id}","starred_url":"https://api.github.com/users/ApolloAuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApolloAuto/subscriptions","organizations_url":"https://api.github.com/users/ApolloAuto/orgs","repos_url":"https://api.github.com/users/ApolloAuto/repos","events_url":"https://api.github.com/users/ApolloAuto/events{/privacy}","received_events_url":"https://api.github.com/users/ApolloAuto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ApolloAuto/apollo","description":"An open autonomous driving platform","fork":false,"url":"https://api.github.com/repos/ApolloAuto/apollo","forks_url":"https://api.github.com/repos/ApolloAuto/apollo/forks","keys_url":"https://api.github.com/repos/ApolloAuto/apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ApolloAuto/apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ApolloAuto/apollo/teams","hooks_url":"https://api.github.com/repos/ApolloAuto/apollo/hooks","issue_events_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/events{/number}","events_url":"https://api.github.com/repos/ApolloAuto/apollo/events","assignees_url":"https://api.github.com/repos/ApolloAuto/apollo/assignees{/user}","branches_url":"https://api.github.com/repos/ApolloAuto/apollo/branches{/branch}","tags_url":"https://api.github.com/repos/ApolloAuto/apollo/tags","blobs_url":"https://api.github.com/repos/ApolloAuto/apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ApolloAuto/apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ApolloAuto/apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ApolloAuto/apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ApolloAuto/apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/ApolloAuto/apollo/languages","stargazers_url":"https://api.github.com/repos/ApolloAuto/apollo/stargazers","contributors_url":"https://api.github.com/repos/ApolloAuto/apollo/contributors","subscribers_url":"https://api.github.com/repos/ApolloAuto/apollo/subscribers","subscription_url":"https://api.github.com/repos/ApolloAuto/apollo/subscription","commits_url":"https://api.github.com/repos/ApolloAuto/apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ApolloAuto/apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ApolloAuto/apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ApolloAuto/apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ApolloAuto/apollo/contents/{+path}","compare_url":"https://api.github.com/repos/ApolloAuto/apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ApolloAuto/apollo/merges","archive_url":"https://api.github.com/repos/ApolloAuto/apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ApolloAuto/apollo/downloads","issues_url":"https://api.github.com/repos/ApolloAuto/apollo/issues{/number}","pulls_url":"https://api.github.com/repos/ApolloAuto/apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/ApolloAuto/apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/ApolloAuto/apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ApolloAuto/apollo/labels{/name}","releases_url":"https://api.github.com/repos/ApolloAuto/apollo/releases{/id}","deployments_url":"https://api.github.com/repos/ApolloAuto/apollo/deployments","created_at":"2017-07-04T19:03:31Z","updated_at":"2019-12-16T18:34:01Z","pushed_at":"2019-12-16T18:33:56Z","git_url":"git://github.com/ApolloAuto/apollo.git","ssh_url":"git@github.com:ApolloAuto/apollo.git","clone_url":"https://github.com/ApolloAuto/apollo.git","svn_url":"https://github.com/ApolloAuto/apollo","homepage":null,"size":1828890,"stargazers_count":15523,"watchers_count":15523,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5387,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":519,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5387,"open_issues":519,"watchers":15523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523"},"html":{"href":"https://github.com/ApolloAuto/apollo/pull/10523"},"issue":{"href":"https://api.github.com/repos/ApolloAuto/apollo/issues/10523"},"comments":{"href":"https://api.github.com/repos/ApolloAuto/apollo/issues/10523/comments"},"review_comments":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523/comments"},"review_comment":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ApolloAuto/apollo/pulls/10523/commits"},"statuses":{"href":"https://api.github.com/repos/ApolloAuto/apollo/statuses/eaa4f955c4955d1c630ebc9c6fb5487c1964230e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 96246170,
"name": "ApolloAuto/apollo",
"url": "https://api.github.com/repos/ApolloAuto/apollo"
}
|
{
"id": 4761061,
"login": "Capri2014",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4761061?",
"url": "https://api.github.com/users/Capri2014"
}
|
{
"id": 28768304,
"login": "ApolloAuto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28768304?",
"url": "https://api.github.com/orgs/ApolloAuto"
}
| 2019-12-16T18:41:54 |
11100216480
|
{"actor":{"display_login":"Capri2014"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tenzir/vast/pulls/comments/364634605","pull_request_review_id":340384141,"id":364634605,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDYzNDYwNQ==","diff_hunk":"@@ -29,17 +29,19 @@ namespace {\n \n template <class T>\n size_t extract_max_size(const T& x, size_t default_value = 1024) {\n- if (auto a = extract_attribute(x, \"max_size\"))\n- if (auto max_size = to<size_t>(*a))\n- return *max_size;\n+ if (auto a = find_attribute(x, \"max_size\"))\n+ if (auto value = a->value)\n+ if (auto max_size = to<size_t>(*value))\n+ return *max_size;\n return default_value;\n }\n \n template <class T>\n optional<base> parse_base(const T& x) {\n- if (auto a = extract_attribute(x, \"base\")) {\n- if (auto b = to<base>(*a))\n- return *b;\n+ if (auto a = find_attribute(x, \"base\")) {","path":"libvast/src/value_index_factory.cpp","position":40,"original_position":19,"commit_id":"060a0fdc288cb899cde7816165d81b2d0b8e1c24","original_commit_id":"29c5fcb5a652a20cb832593f4221763308108f3c","user":{"login":"tobim","id":858790,"node_id":"MDQ6VXNlcjg1ODc5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/858790?v=4","gravatar_id":"","url":"https://api.github.com/users/tobim","html_url":"https://github.com/tobim","followers_url":"https://api.github.com/users/tobim/followers","following_url":"https://api.github.com/users/tobim/following{/other_user}","gists_url":"https://api.github.com/users/tobim/gists{/gist_id}","starred_url":"https://api.github.com/users/tobim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobim/subscriptions","organizations_url":"https://api.github.com/users/tobim/orgs","repos_url":"https://api.github.com/users/tobim/repos","events_url":"https://api.github.com/users/tobim/events{/privacy}","received_events_url":"https://api.github.com/users/tobim/received_events","type":"User","site_admin":false},"body":"Regarding the naming of the function: I would prefer not to do any parsing / input validation this late, meaning we should validate `load_schema()` and use an assert here instead.\r\n\r\nThen we can rename this function to `extract_base` to synchronize with `extract_max_size`, and drop the `optional` from the return type.\r\n\r\nThis should probably be done in another PR :-).\r\n","created_at":"2020-01-09T09:28:52Z","updated_at":"2020-01-09T09:47:11Z","html_url":"https://github.com/tenzir/vast/pull/632#discussion_r364634605","pull_request_url":"https://api.github.com/repos/tenzir/vast/pulls/632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tenzir/vast/pulls/comments/364634605"},"html":{"href":"https://github.com/tenzir/vast/pull/632#discussion_r364634605"},"pull_request":{"href":"https://api.github.com/repos/tenzir/vast/pulls/632"}}},"pull_request":{"url":"https://api.github.com/repos/tenzir/vast/pulls/632","id":335636393,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1NjM2Mzkz","html_url":"https://github.com/tenzir/vast/pull/632","diff_url":"https://github.com/tenzir/vast/pull/632.diff","patch_url":"https://github.com/tenzir/vast/pull/632.patch","issue_url":"https://api.github.com/repos/tenzir/vast/issues/632","number":632,"state":"open","locked":false,"title":"Add optimized implementation for string indexes","user":{"login":"mavam","id":53797,"node_id":"MDQ6VXNlcjUzNzk3","avatar_url":"https://avatars0.githubusercontent.com/u/53797?v=4","gravatar_id":"","url":"https://api.github.com/users/mavam","html_url":"https://github.com/mavam","followers_url":"https://api.github.com/users/mavam/followers","following_url":"https://api.github.com/users/mavam/following{/other_user}","gists_url":"https://api.github.com/users/mavam/gists{/gist_id}","starred_url":"https://api.github.com/users/mavam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavam/subscriptions","organizations_url":"https://api.github.com/users/mavam/orgs","repos_url":"https://api.github.com/users/mavam/repos","events_url":"https://api.github.com/users/mavam/events{/privacy}","received_events_url":"https://api.github.com/users/mavam/received_events","type":"User","site_admin":false},"body":"The new index is meant for opaque identifiers that can only be retrieved via equality lookups. If a string type contains the `#index=hash` attribute, the index factory chooses this new hash-based implementation.","created_at":"2019-11-01T22:05:51Z","updated_at":"2020-01-09T09:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c10e32f9fd143a472f7d3850c4e28f76beb8d83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":10662845,"node_id":"MDU6TGFiZWwxMDY2Mjg0NQ==","url":"https://api.github.com/repos/tenzir/vast/labels/feature%20:gift:","name":"feature :gift:","color":"419cd8","default":false,"description":"New functionality"},{"id":12105903,"node_id":"MDU6TGFiZWwxMjEwNTkwMw==","url":"https://api.github.com/repos/tenzir/vast/labels/performance%20:rocket:","name":"performance :rocket:","color":"142d87","default":false,"description":"Improvements or regressions of performance"}],"milestone":null,"commits_url":"https://api.github.com/repos/tenzir/vast/pulls/632/commits","review_comments_url":"https://api.github.com/repos/tenzir/vast/pulls/632/comments","review_comment_url":"https://api.github.com/repos/tenzir/vast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tenzir/vast/issues/632/comments","statuses_url":"https://api.github.com/repos/tenzir/vast/statuses/060a0fdc288cb899cde7816165d81b2d0b8e1c24","head":{"label":"tenzir:story/ch4493","ref":"story/ch4493","sha":"060a0fdc288cb899cde7816165d81b2d0b8e1c24","user":{"login":"tenzir","id":29048253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDQ4MjUz","avatar_url":"https://avatars1.githubusercontent.com/u/29048253?v=4","gravatar_id":"","url":"https://api.github.com/users/tenzir","html_url":"https://github.com/tenzir","followers_url":"https://api.github.com/users/tenzir/followers","following_url":"https://api.github.com/users/tenzir/following{/other_user}","gists_url":"https://api.github.com/users/tenzir/gists{/gist_id}","starred_url":"https://api.github.com/users/tenzir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenzir/subscriptions","organizations_url":"https://api.github.com/users/tenzir/orgs","repos_url":"https://api.github.com/users/tenzir/repos","events_url":"https://api.github.com/users/tenzir/events{/privacy}","received_events_url":"https://api.github.com/users/tenzir/received_events","type":"Organization","site_admin":false},"repo":{"id":932314,"node_id":"MDEwOlJlcG9zaXRvcnk5MzIzMTQ=","name":"vast","full_name":"tenzir/vast","private":false,"owner":{"login":"tenzir","id":29048253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDQ4MjUz","avatar_url":"https://avatars1.githubusercontent.com/u/29048253?v=4","gravatar_id":"","url":"https://api.github.com/users/tenzir","html_url":"https://github.com/tenzir","followers_url":"https://api.github.com/users/tenzir/followers","following_url":"https://api.github.com/users/tenzir/following{/other_user}","gists_url":"https://api.github.com/users/tenzir/gists{/gist_id}","starred_url":"https://api.github.com/users/tenzir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenzir/subscriptions","organizations_url":"https://api.github.com/users/tenzir/orgs","repos_url":"https://api.github.com/users/tenzir/repos","events_url":"https://api.github.com/users/tenzir/events{/privacy}","received_events_url":"https://api.github.com/users/tenzir/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tenzir/vast","description":":crystal_ball: Visibility Across Space and Time","fork":false,"url":"https://api.github.com/repos/tenzir/vast","forks_url":"https://api.github.com/repos/tenzir/vast/forks","keys_url":"https://api.github.com/repos/tenzir/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tenzir/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tenzir/vast/teams","hooks_url":"https://api.github.com/repos/tenzir/vast/hooks","issue_events_url":"https://api.github.com/repos/tenzir/vast/issues/events{/number}","events_url":"https://api.github.com/repos/tenzir/vast/events","assignees_url":"https://api.github.com/repos/tenzir/vast/assignees{/user}","branches_url":"https://api.github.com/repos/tenzir/vast/branches{/branch}","tags_url":"https://api.github.com/repos/tenzir/vast/tags","blobs_url":"https://api.github.com/repos/tenzir/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tenzir/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tenzir/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/tenzir/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tenzir/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/tenzir/vast/languages","stargazers_url":"https://api.github.com/repos/tenzir/vast/stargazers","contributors_url":"https://api.github.com/repos/tenzir/vast/contributors","subscribers_url":"https://api.github.com/repos/tenzir/vast/subscribers","subscription_url":"https://api.github.com/repos/tenzir/vast/subscription","commits_url":"https://api.github.com/repos/tenzir/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/tenzir/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/tenzir/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/tenzir/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/tenzir/vast/contents/{+path}","compare_url":"https://api.github.com/repos/tenzir/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tenzir/vast/merges","archive_url":"https://api.github.com/repos/tenzir/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tenzir/vast/downloads","issues_url":"https://api.github.com/repos/tenzir/vast/issues{/number}","pulls_url":"https://api.github.com/repos/tenzir/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/tenzir/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/tenzir/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tenzir/vast/labels{/name}","releases_url":"https://api.github.com/repos/tenzir/vast/releases{/id}","deployments_url":"https://api.github.com/repos/tenzir/vast/deployments","created_at":"2010-09-23T01:19:19Z","updated_at":"2020-01-08T20:12:23Z","pushed_at":"2020-01-09T08:42:48Z","git_url":"git://github.com/tenzir/vast.git","ssh_url":"git@github.com:tenzir/vast.git","clone_url":"https://github.com/tenzir/vast.git","svn_url":"https://github.com/tenzir/vast","homepage":"http://vast.io","size":17307,"stargazers_count":143,"watchers_count":143,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":31,"open_issues":5,"watchers":143,"default_branch":"master"}},"base":{"label":"tenzir:master","ref":"master","sha":"35eedf0643031364b9b194d79cd37a991046736d","user":{"login":"tenzir","id":29048253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDQ4MjUz","avatar_url":"https://avatars1.githubusercontent.com/u/29048253?v=4","gravatar_id":"","url":"https://api.github.com/users/tenzir","html_url":"https://github.com/tenzir","followers_url":"https://api.github.com/users/tenzir/followers","following_url":"https://api.github.com/users/tenzir/following{/other_user}","gists_url":"https://api.github.com/users/tenzir/gists{/gist_id}","starred_url":"https://api.github.com/users/tenzir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenzir/subscriptions","organizations_url":"https://api.github.com/users/tenzir/orgs","repos_url":"https://api.github.com/users/tenzir/repos","events_url":"https://api.github.com/users/tenzir/events{/privacy}","received_events_url":"https://api.github.com/users/tenzir/received_events","type":"Organization","site_admin":false},"repo":{"id":932314,"node_id":"MDEwOlJlcG9zaXRvcnk5MzIzMTQ=","name":"vast","full_name":"tenzir/vast","private":false,"owner":{"login":"tenzir","id":29048253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDQ4MjUz","avatar_url":"https://avatars1.githubusercontent.com/u/29048253?v=4","gravatar_id":"","url":"https://api.github.com/users/tenzir","html_url":"https://github.com/tenzir","followers_url":"https://api.github.com/users/tenzir/followers","following_url":"https://api.github.com/users/tenzir/following{/other_user}","gists_url":"https://api.github.com/users/tenzir/gists{/gist_id}","starred_url":"https://api.github.com/users/tenzir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenzir/subscriptions","organizations_url":"https://api.github.com/users/tenzir/orgs","repos_url":"https://api.github.com/users/tenzir/repos","events_url":"https://api.github.com/users/tenzir/events{/privacy}","received_events_url":"https://api.github.com/users/tenzir/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tenzir/vast","description":":crystal_ball: Visibility Across Space and Time","fork":false,"url":"https://api.github.com/repos/tenzir/vast","forks_url":"https://api.github.com/repos/tenzir/vast/forks","keys_url":"https://api.github.com/repos/tenzir/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tenzir/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tenzir/vast/teams","hooks_url":"https://api.github.com/repos/tenzir/vast/hooks","issue_events_url":"https://api.github.com/repos/tenzir/vast/issues/events{/number}","events_url":"https://api.github.com/repos/tenzir/vast/events","assignees_url":"https://api.github.com/repos/tenzir/vast/assignees{/user}","branches_url":"https://api.github.com/repos/tenzir/vast/branches{/branch}","tags_url":"https://api.github.com/repos/tenzir/vast/tags","blobs_url":"https://api.github.com/repos/tenzir/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tenzir/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tenzir/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/tenzir/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tenzir/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/tenzir/vast/languages","stargazers_url":"https://api.github.com/repos/tenzir/vast/stargazers","contributors_url":"https://api.github.com/repos/tenzir/vast/contributors","subscribers_url":"https://api.github.com/repos/tenzir/vast/subscribers","subscription_url":"https://api.github.com/repos/tenzir/vast/subscription","commits_url":"https://api.github.com/repos/tenzir/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/tenzir/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/tenzir/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/tenzir/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/tenzir/vast/contents/{+path}","compare_url":"https://api.github.com/repos/tenzir/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tenzir/vast/merges","archive_url":"https://api.github.com/repos/tenzir/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tenzir/vast/downloads","issues_url":"https://api.github.com/repos/tenzir/vast/issues{/number}","pulls_url":"https://api.github.com/repos/tenzir/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/tenzir/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/tenzir/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tenzir/vast/labels{/name}","releases_url":"https://api.github.com/repos/tenzir/vast/releases{/id}","deployments_url":"https://api.github.com/repos/tenzir/vast/deployments","created_at":"2010-09-23T01:19:19Z","updated_at":"2020-01-08T20:12:23Z","pushed_at":"2020-01-09T08:42:48Z","git_url":"git://github.com/tenzir/vast.git","ssh_url":"git@github.com:tenzir/vast.git","clone_url":"https://github.com/tenzir/vast.git","svn_url":"https://github.com/tenzir/vast","homepage":"http://vast.io","size":17307,"stargazers_count":143,"watchers_count":143,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":31,"open_issues":5,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tenzir/vast/pulls/632"},"html":{"href":"https://github.com/tenzir/vast/pull/632"},"issue":{"href":"https://api.github.com/repos/tenzir/vast/issues/632"},"comments":{"href":"https://api.github.com/repos/tenzir/vast/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/tenzir/vast/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/tenzir/vast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tenzir/vast/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/tenzir/vast/statuses/060a0fdc288cb899cde7816165d81b2d0b8e1c24"}},"author_association":"MEMBER"}}
|
{
"id": 932314,
"name": "tenzir/vast",
"url": "https://api.github.com/repos/tenzir/vast"
}
|
{
"id": 858790,
"login": "tobim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/858790?",
"url": "https://api.github.com/users/tobim"
}
|
{
"id": 29048253,
"login": "tenzir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29048253?",
"url": "https://api.github.com/orgs/tenzir"
}
| 2020-01-09T09:28:52 |
11236102035
|
{"actor":{"display_login":"tobim"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/263794165","pull_request_review_id":212303973,"id":263794165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Mzc5NDE2NQ==","diff_hunk":"@@ -303,7 +303,11 @@ func route53ResolverEndpointRefresh(conn *route53resolver.Route53Resolver, epId\n \t\t\treturn nil, \"\", err\n \t\t}\n \n-\t\treturn resp.ResolverEndpoint, aws.StringValue(resp.ResolverEndpoint.Status), nil\n+\t\tstatus := aws.StringValue(resp.ResolverEndpoint.Status)\n+\t\tif status == route53resolver.ResolverEndpointStatusActionNeeded {\n+\t\t\treturn nil, status, errors.New(aws.StringValue(resp.ResolverEndpoint.StatusMessage))","path":"aws/resource_aws_route53_resolver_endpoint.go","position":95,"original_position":95,"commit_id":"5a701a249ed819ffd5e4cc55e373bca4ba9b9809","original_commit_id":"5a701a249ed819ffd5e4cc55e373bca4ba9b9809","user":{"login":"ewbankkit","id":2404182,"node_id":"MDQ6VXNlcjI0MDQxODI=","avatar_url":"https://avatars3.githubusercontent.com/u/2404182?v=4","gravatar_id":"","url":"https://api.github.com/users/ewbankkit","html_url":"https://github.com/ewbankkit","followers_url":"https://api.github.com/users/ewbankkit/followers","following_url":"https://api.github.com/users/ewbankkit/following{/other_user}","gists_url":"https://api.github.com/users/ewbankkit/gists{/gist_id}","starred_url":"https://api.github.com/users/ewbankkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewbankkit/subscriptions","organizations_url":"https://api.github.com/users/ewbankkit/orgs","repos_url":"https://api.github.com/users/ewbankkit/repos","events_url":"https://api.github.com/users/ewbankkit/events{/privacy}","received_events_url":"https://api.github.com/users/ewbankkit/received_events","type":"User","site_admin":false},"body":"OK, I'll just return the status and log any `StatusMessage` at `INFO` - I think a status message is returned for all statuses so I don't want `WARN` or `ERROR`.","created_at":"2019-03-08T14:26:49Z","updated_at":"2019-03-08T14:26:49Z","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/7799#discussion_r263794165","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/263794165"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/7799#discussion_r263794165"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799"}},"in_reply_to_id":263563222},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799","id":257770377,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NzcwMzc3","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/7799","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/7799.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/7799.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/7799","number":7799,"state":"open","locked":false,"title":"Add Route 53 Resolver rule and rule association resources","user":{"login":"ewbankkit","id":2404182,"node_id":"MDQ6VXNlcjI0MDQxODI=","avatar_url":"https://avatars3.githubusercontent.com/u/2404182?v=4","gravatar_id":"","url":"https://api.github.com/users/ewbankkit","html_url":"https://github.com/ewbankkit","followers_url":"https://api.github.com/users/ewbankkit/followers","following_url":"https://api.github.com/users/ewbankkit/following{/other_user}","gists_url":"https://api.github.com/users/ewbankkit/gists{/gist_id}","starred_url":"https://api.github.com/users/ewbankkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewbankkit/subscriptions","organizations_url":"https://api.github.com/users/ewbankkit/orgs","repos_url":"https://api.github.com/users/ewbankkit/repos","events_url":"https://api.github.com/users/ewbankkit/events{/privacy}","received_events_url":"https://api.github.com/users/ewbankkit/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/terraform-providers/terraform-provider-aws/issues/6550.\r\nCompletes the work started in https://github.com/terraform-providers/terraform-provider-aws/pull/6571.\r\nFinishes the tasks in https://github.com/terraform-providers/terraform-provider-aws/issues/6525.\r\n\r\nAcceptance tests:\r\n\r\n```console\r\n$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsRoute53ResolverRule_'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsRoute53ResolverRule_ -timeout 120m\r\n=== RUN TestAccAwsRoute53ResolverRule_basic\r\n=== PAUSE TestAccAwsRoute53ResolverRule_basic\r\n=== RUN TestAccAwsRoute53ResolverRule_tags\r\n=== PAUSE TestAccAwsRoute53ResolverRule_tags\r\n=== RUN TestAccAwsRoute53ResolverRule_updateName\r\n=== PAUSE TestAccAwsRoute53ResolverRule_updateName\r\n=== RUN TestAccAwsRoute53ResolverRule_forward\r\n=== PAUSE TestAccAwsRoute53ResolverRule_forward\r\n=== CONT TestAccAwsRoute53ResolverRule_basic\r\n=== CONT TestAccAwsRoute53ResolverRule_forward\r\n=== CONT TestAccAwsRoute53ResolverRule_updateName\r\n=== CONT TestAccAwsRoute53ResolverRule_tags\r\n--- PASS: TestAccAwsRoute53ResolverRule_basic (36.81s)\r\n--- PASS: TestAccAwsRoute53ResolverRule_updateName (55.63s)\r\n--- PASS: TestAccAwsRoute53ResolverRule_tags (55.91s)\r\n--- PASS: TestAccAwsRoute53ResolverRule_forward (342.25s)\r\nPASS\r\nok \tgithub.com/terraform-providers/terraform-provider-aws/aws\t342.274s\r\n$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsRoute53ResolverRuleAssociation_'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsRoute53ResolverRuleAssociation_ -timeout 120m\r\n=== RUN TestAccAwsRoute53ResolverRuleAssociation_basic\r\n=== PAUSE TestAccAwsRoute53ResolverRuleAssociation_basic\r\n=== CONT TestAccAwsRoute53ResolverRuleAssociation_basic\r\n--- PASS: TestAccAwsRoute53ResolverRuleAssociation_basic (230.61s)\r\nPASS\r\nok \tgithub.com/terraform-providers/terraform-provider-aws/aws\t230.625s\r\n$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsRoute53ResolverEndpoint_'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsRoute53ResolverEndpoint_ -timeout 120m\r\n=== RUN TestAccAwsRoute53ResolverEndpoint_basicInbound\r\n=== PAUSE TestAccAwsRoute53ResolverEndpoint_basicInbound\r\n=== RUN TestAccAwsRoute53ResolverEndpoint_updateOutbound\r\n=== PAUSE TestAccAwsRoute53ResolverEndpoint_updateOutbound\r\n=== CONT TestAccAwsRoute53ResolverEndpoint_basicInbound\r\n=== CONT TestAccAwsRoute53ResolverEndpoint_updateOutbound\r\n--- PASS: TestAccAwsRoute53ResolverEndpoint_basicInbound (101.06s)\r\n--- PASS: TestAccAwsRoute53ResolverEndpoint_updateOutbound (550.46s)\r\nPASS\r\nok \tgithub.com/terraform-providers/terraform-provider-aws/aws\t550.480s\r\n```\r\n","created_at":"2019-03-03T21:46:35Z","updated_at":"2019-03-08T14:26:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe3529be79c6d51eca0f49ffdd53b51134b41b19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620316276,"node_id":"MDU6TGFiZWw2MjAzMTYyNzY=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/documentation","name":"documentation","color":"fef2c0","default":false},{"id":625892945,"node_id":"MDU6TGFiZWw2MjU4OTI5NDU=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/new-resource","name":"new-resource","color":"d4c5f9","default":false},{"id":819351775,"node_id":"MDU6TGFiZWw4MTkzNTE3NzU=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/provider","name":"provider","color":"bfd4f2","default":false},{"id":1134889996,"node_id":"MDU6TGFiZWwxMTM0ODg5OTk2","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/route53resolver","name":"service/route53resolver","color":"bfd4f2","default":false},{"id":737832202,"node_id":"MDU6TGFiZWw3Mzc4MzIyMDI=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/size/XXL","name":"size/XXL","color":"ffffff","default":false},{"id":784095310,"node_id":"MDU6TGFiZWw3ODQwOTUzMTA=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/tests","name":"tests","color":"DDDDDD","default":false}],"milestone":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones/71","html_url":"https://github.com/terraform-providers/terraform-provider-aws/milestone/71","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones/71/labels","id":4097552,"node_id":"MDk6TWlsZXN0b25lNDA5NzU1Mg==","number":71,"title":"v2.3.0","description":"","creator":{"login":"bflad","id":189114,"node_id":"MDQ6VXNlcjE4OTExNA==","avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2019-02-28T19:00:27Z","updated_at":"2019-03-08T12:47:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/7799/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/5a701a249ed819ffd5e4cc55e373bca4ba9b9809","head":{"label":"ewbankkit:issue-6550","ref":"issue-6550","sha":"5a701a249ed819ffd5e4cc55e373bca4ba9b9809","user":{"login":"ewbankkit","id":2404182,"node_id":"MDQ6VXNlcjI0MDQxODI=","avatar_url":"https://avatars3.githubusercontent.com/u/2404182?v=4","gravatar_id":"","url":"https://api.github.com/users/ewbankkit","html_url":"https://github.com/ewbankkit","followers_url":"https://api.github.com/users/ewbankkit/followers","following_url":"https://api.github.com/users/ewbankkit/following{/other_user}","gists_url":"https://api.github.com/users/ewbankkit/gists{/gist_id}","starred_url":"https://api.github.com/users/ewbankkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewbankkit/subscriptions","organizations_url":"https://api.github.com/users/ewbankkit/orgs","repos_url":"https://api.github.com/users/ewbankkit/repos","events_url":"https://api.github.com/users/ewbankkit/events{/privacy}","received_events_url":"https://api.github.com/users/ewbankkit/received_events","type":"User","site_admin":false},"repo":{"id":98536216,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUzNjIxNg==","name":"terraform-provider-aws","full_name":"ewbankkit/terraform-provider-aws","private":false,"owner":{"login":"ewbankkit","id":2404182,"node_id":"MDQ6VXNlcjI0MDQxODI=","avatar_url":"https://avatars3.githubusercontent.com/u/2404182?v=4","gravatar_id":"","url":"https://api.github.com/users/ewbankkit","html_url":"https://github.com/ewbankkit","followers_url":"https://api.github.com/users/ewbankkit/followers","following_url":"https://api.github.com/users/ewbankkit/following{/other_user}","gists_url":"https://api.github.com/users/ewbankkit/gists{/gist_id}","starred_url":"https://api.github.com/users/ewbankkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewbankkit/subscriptions","organizations_url":"https://api.github.com/users/ewbankkit/orgs","repos_url":"https://api.github.com/users/ewbankkit/repos","events_url":"https://api.github.com/users/ewbankkit/events{/privacy}","received_events_url":"https://api.github.com/users/ewbankkit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ewbankkit/terraform-provider-aws","description":"Terraform aws provider","fork":true,"url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws","forks_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/ewbankkit/terraform-provider-aws/deployments","created_at":"2017-07-27T13:00:42Z","updated_at":"2019-03-07T23:03:43Z","pushed_at":"2019-03-07T23:06:26Z","git_url":"git://github.com/ewbankkit/terraform-provider-aws.git","ssh_url":"git@github.com:ewbankkit/terraform-provider-aws.git","clone_url":"https://github.com/ewbankkit/terraform-provider-aws.git","svn_url":"https://github.com/ewbankkit/terraform-provider-aws","homepage":"","size":69323,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"ee668875199124d21109d976b940ee7d8e00454e","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NDYxNQ==","name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","private":false,"owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2019-03-08T10:05:21Z","pushed_at":"2019-03-08T11:15:57Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":72218,"stargazers_count":2251,"watchers_count":2251,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1929,"mirror_url":null,"archived":false,"open_issues_count":2283,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1929,"open_issues":2283,"watchers":2251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/7799"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/7799"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/7799/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/7799/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/5a701a249ed819ffd5e4cc55e373bca4ba9b9809"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 93444615,
"name": "terraform-providers/terraform-provider-aws",
"url": "https://api.github.com/repos/terraform-providers/terraform-provider-aws"
}
|
{
"id": 2404182,
"login": "ewbankkit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2404182?",
"url": "https://api.github.com/users/ewbankkit"
}
|
{
"id": 29154831,
"login": "terraform-providers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29154831?",
"url": "https://api.github.com/orgs/terraform-providers"
}
| 2019-03-08T14:26:49 |
9206688052
|
{"actor":{"display_login":"ewbankkit"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/286495728","pull_request_review_id":240636206,"id":286495728,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NjQ5NTcyOA==","diff_hunk":"@@ -0,0 +1,266 @@\n+package azurerm\n+\n+import (\n+\t\"fmt\"\n+\t\"github.com/hashicorp/terraform/helper/schema\"\n+\t\"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils\"\n+)\n+\n+func dataSourceArmRedisCache() *schema.Resource {\n+\treturn &schema.Resource{\n+\t\tRead: dataSourceArmRedisCacheRead,\n+\t\tSchema: map[string]*schema.Schema{\n+\t\t\t\"name\": {\n+\t\t\t\tType: schema.TypeString,\n+\t\t\t\tRequired: true,\n+\t\t\t},\n+\n+\t\t\t\"location\": locationForDataSourceSchema(),\n+\n+\t\t\t\"resource_group_name\": resourceGroupNameForDataSourceSchema(),\n+\n+\t\t\t\"zones\": singleZonesSchema(),\n+\n+\t\t\t\"capacity\": {\n+\t\t\t\tType: schema.TypeInt,\n+\t\t\t\tComputed: true,\n+\t\t\t},\n+\n+\t\t\t\"family\": {\n+\t\t\t\tType: schema.TypeString,\n+\t\t\t\tComputed: true,\n+\t\t\t},\n+\n+\t\t\t\"sku_name\": {\n+\t\t\t\tType: schema.TypeString,\n+\t\t\t\tComputed: true,\n+\t\t\t},\n+\n+\t\t\t\"minimum_tls_version\": {\n+\t\t\t\tType: schema.TypeString,\n+\t\t\t\tOptional: true,\n+\t\t\t},\n+\n+\t\t\t\"shard_count\": {\n+\t\t\t\tType: schema.TypeInt,\n+\t\t\t\tOptional: true,\n+\t\t\t},\n+\n+\t\t\t\"enable_non_ssl_port\": {\n+\t\t\t\tType: schema.TypeBool,\n+\t\t\t\tOptional: true,\n+\t\t\t},\n+\n+\t\t\t\"subnet_id\": {\n+\t\t\t\tType: schema.TypeString,\n+\t\t\t\tOptional: true,\n+\t\t\t\tComputed: true,\n+\t\t\t},\n+\n+\t\t\t\"private_static_ip_address\": {\n+\t\t\t\tType: schema.TypeString,\n+\t\t\t\tOptional: true,\n+\t\t\t\tComputed: true,\n+\t\t\t},\n+\n+\t\t\t\"redis_configuration\": {\n+\t\t\t\tType: schema.TypeList,\n+\t\t\t\tOptional: true,\n+\t\t\t\tComputed: true,\n+\t\t\t\tMaxItems: 1,\n+\t\t\t\tElem: &schema.Resource{\n+\t\t\t\t\tSchema: map[string]*schema.Schema{\n+\t\t\t\t\t\t\"maxclients\": {\n+\t\t\t\t\t\t\tType: schema.TypeInt,\n+\t\t\t\t\t\t\tComputed: true,\n+\t\t\t\t\t\t},\n+\n+\t\t\t\t\t\t\"maxmemory_delta\": {\n+\t\t\t\t\t\t\tType: schema.TypeInt,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\tComputed: true,\n+\t\t\t\t\t\t},\n+\n+\t\t\t\t\t\t\"maxmemory_reserved\": {\n+\t\t\t\t\t\t\tType: schema.TypeInt,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\tComputed: true,\n+\t\t\t\t\t\t},\n+\n+\t\t\t\t\t\t\"maxmemory_policy\": {\n+\t\t\t\t\t\t\tType: schema.TypeString,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\tDefault: \"volatile-lru\",","path":"azurerm/data_source_redis_cache.go","position":93,"original_position":93,"commit_id":"2c59d6efd97dd056dd43e3d7414d64ba59cc2a07","original_commit_id":"2c59d6efd97dd056dd43e3d7414d64ba59cc2a07","user":{"login":"tombuildsstuff","id":666005,"node_id":"MDQ6VXNlcjY2NjAwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/666005?v=4","gravatar_id":"","url":"https://api.github.com/users/tombuildsstuff","html_url":"https://github.com/tombuildsstuff","followers_url":"https://api.github.com/users/tombuildsstuff/followers","following_url":"https://api.github.com/users/tombuildsstuff/following{/other_user}","gists_url":"https://api.github.com/users/tombuildsstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuildsstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuildsstuff/subscriptions","organizations_url":"https://api.github.com/users/tombuildsstuff/orgs","repos_url":"https://api.github.com/users/tombuildsstuff/repos","events_url":"https://api.github.com/users/tombuildsstuff/events{/privacy}","received_events_url":"https://api.github.com/users/tombuildsstuff/received_events","type":"User","site_admin":false},"body":"since this is readonly, can we remove this?","created_at":"2019-05-22T13:41:45Z","updated_at":"2019-05-22T13:48:38Z","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/3481#discussion_r286495728","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/286495728"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/3481#discussion_r286495728"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481","id":280775159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwNzc1MTU5","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/3481","diff_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/3481.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/3481.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/3481","number":3481,"state":"open","locked":false,"title":"Add redis_cache datasource","user":{"login":"sjones-sot","id":11830746,"node_id":"MDQ6VXNlcjExODMwNzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/11830746?v=4","gravatar_id":"","url":"https://api.github.com/users/sjones-sot","html_url":"https://github.com/sjones-sot","followers_url":"https://api.github.com/users/sjones-sot/followers","following_url":"https://api.github.com/users/sjones-sot/following{/other_user}","gists_url":"https://api.github.com/users/sjones-sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sjones-sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjones-sot/subscriptions","organizations_url":"https://api.github.com/users/sjones-sot/orgs","repos_url":"https://api.github.com/users/sjones-sot/repos","events_url":"https://api.github.com/users/sjones-sot/events{/privacy}","received_events_url":"https://api.github.com/users/sjones-sot/received_events","type":"User","site_admin":false},"body":"Fixes #3432 \r\n","created_at":"2019-05-21T13:08:05Z","updated_at":"2019-05-22T13:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58b09fdfa85d98c8552866538a874bed13f53137","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620326920,"node_id":"MDU6TGFiZWw2MjAzMjY5MjA=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/documentation","name":"documentation","color":"fef2c0","default":false},{"id":640744194,"node_id":"MDU6TGFiZWw2NDA3NDQxOTQ=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/new-data-source","name":"new-data-source","color":"d4c5f9","default":false},{"id":844476264,"node_id":"MDU6TGFiZWw4NDQ0NzYyNjQ=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/service/redis","name":"service/redis","color":"77bb77","default":false},{"id":737912017,"node_id":"MDU6TGFiZWw3Mzc5MTIwMTc=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/size/XL","name":"size/XL","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/3481/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/2c59d6efd97dd056dd43e3d7414d64ba59cc2a07","head":{"label":"sjones-sot:issue-3432","ref":"issue-3432","sha":"2c59d6efd97dd056dd43e3d7414d64ba59cc2a07","user":{"login":"sjones-sot","id":11830746,"node_id":"MDQ6VXNlcjExODMwNzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/11830746?v=4","gravatar_id":"","url":"https://api.github.com/users/sjones-sot","html_url":"https://github.com/sjones-sot","followers_url":"https://api.github.com/users/sjones-sot/followers","following_url":"https://api.github.com/users/sjones-sot/following{/other_user}","gists_url":"https://api.github.com/users/sjones-sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sjones-sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjones-sot/subscriptions","organizations_url":"https://api.github.com/users/sjones-sot/orgs","repos_url":"https://api.github.com/users/sjones-sot/repos","events_url":"https://api.github.com/users/sjones-sot/events{/privacy}","received_events_url":"https://api.github.com/users/sjones-sot/received_events","type":"User","site_admin":false},"repo":{"id":132237467,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIyMzc0Njc=","name":"terraform-provider-azurerm","full_name":"sjones-sot/terraform-provider-azurerm","private":false,"owner":{"login":"sjones-sot","id":11830746,"node_id":"MDQ6VXNlcjExODMwNzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/11830746?v=4","gravatar_id":"","url":"https://api.github.com/users/sjones-sot","html_url":"https://github.com/sjones-sot","followers_url":"https://api.github.com/users/sjones-sot/followers","following_url":"https://api.github.com/users/sjones-sot/following{/other_user}","gists_url":"https://api.github.com/users/sjones-sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sjones-sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjones-sot/subscriptions","organizations_url":"https://api.github.com/users/sjones-sot/orgs","repos_url":"https://api.github.com/users/sjones-sot/repos","events_url":"https://api.github.com/users/sjones-sot/events{/privacy}","received_events_url":"https://api.github.com/users/sjones-sot/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sjones-sot/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":true,"url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/sjones-sot/terraform-provider-azurerm/deployments","created_at":"2018-05-05T10:24:23Z","updated_at":"2019-05-17T13:48:49Z","pushed_at":"2019-05-22T13:30:26Z","git_url":"git://github.com/sjones-sot/terraform-provider-azurerm.git","ssh_url":"git@github.com:sjones-sot/terraform-provider-azurerm.git","clone_url":"https://github.com/sjones-sot/terraform-provider-azurerm.git","svn_url":"https://github.com/sjones-sot/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":36125,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"de3ffa3cd68f24645f8a0f66d744f12d6e563b43","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446042,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA0Mg==","name":"terraform-provider-azurerm","full_name":"terraform-providers/terraform-provider-azurerm","private":false,"owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-providers/terraform-provider-azurerm","description":"Terraform provider for Azure Resource Manager","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2019-05-22T12:43:57Z","pushed_at":"2019-05-22T13:32:42Z","git_url":"git://github.com/terraform-providers/terraform-provider-azurerm.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-azurerm.git","clone_url":"https://github.com/terraform-providers/terraform-provider-azurerm.git","svn_url":"https://github.com/terraform-providers/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":36585,"stargazers_count":864,"watchers_count":864,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":798,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":444,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":798,"open_issues":444,"watchers":864,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/3481"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/3481"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/3481/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/3481/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/2c59d6efd97dd056dd43e3d7414d64ba59cc2a07"}},"author_association":"NONE"}}
|
{
"id": 93446042,
"name": "terraform-providers/terraform-provider-azurerm",
"url": "https://api.github.com/repos/terraform-providers/terraform-provider-azurerm"
}
|
{
"id": 666005,
"login": "tombuildsstuff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/666005?",
"url": "https://api.github.com/users/tombuildsstuff"
}
|
{
"id": 29154831,
"login": "terraform-providers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29154831?",
"url": "https://api.github.com/orgs/terraform-providers"
}
| 2019-05-22T13:41:45 |
9676122907
|
{"actor":{"display_login":"tombuildsstuff"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/322632234","pull_request_review_id":286007876,"id":322632234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjYzMjIzNA==","diff_hunk":"@@ -0,0 +1,27 @@\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+ xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+ <modelVersion>4.0.0</modelVersion>\n+\n+ <parent>\n+ <groupId>com.yahoo.vespa</groupId>\n+ <artifactId>parent</artifactId>\n+ <version>7-SNAPSHOT</version>\n+ <relativePath>../../parent/pom.xml</relativePath>\n+ </parent>\n+ \n+ <groupId>ai.vespa.cloud</groupId>","path":"archetypes/application-java/pom.xml","position":null,"original_position":12,"commit_id":"14044fffb9dc9b4babec5df986212c9c087ff2f2","original_commit_id":"900d3e6b9fd009318b375b61090aaed0eac94125","user":{"login":"oyving","id":14175,"node_id":"MDQ6VXNlcjE0MTc1","avatar_url":"https://avatars3.githubusercontent.com/u/14175?v=4","gravatar_id":"","url":"https://api.github.com/users/oyving","html_url":"https://github.com/oyving","followers_url":"https://api.github.com/users/oyving/followers","following_url":"https://api.github.com/users/oyving/following{/other_user}","gists_url":"https://api.github.com/users/oyving/gists{/gist_id}","starred_url":"https://api.github.com/users/oyving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyving/subscriptions","organizations_url":"https://api.github.com/users/oyving/orgs","repos_url":"https://api.github.com/users/oyving/repos","events_url":"https://api.github.com/users/oyving/events{/privacy}","received_events_url":"https://api.github.com/users/oyving/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2019-09-10T09:09:36Z","updated_at":"2019-09-10T09:09:37Z","html_url":"https://github.com/vespa-engine/vespa/pull/10579#discussion_r322632234","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/322632234"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/10579#discussion_r322632234"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579"}},"in_reply_to_id":322603369},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579","id":315865221,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1ODY1MjIx","html_url":"https://github.com/vespa-engine/vespa/pull/10579","diff_url":"https://github.com/vespa-engine/vespa/pull/10579.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/10579.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/10579","number":10579,"state":"open","locked":false,"title":"Add Maven archetype to generate applications","user":{"login":"oyving","id":14175,"node_id":"MDQ6VXNlcjE0MTc1","avatar_url":"https://avatars3.githubusercontent.com/u/14175?v=4","gravatar_id":"","url":"https://api.github.com/users/oyving","html_url":"https://github.com/oyving","followers_url":"https://api.github.com/users/oyving/followers","following_url":"https://api.github.com/users/oyving/following{/other_user}","gists_url":"https://api.github.com/users/oyving/gists{/gist_id}","starred_url":"https://api.github.com/users/oyving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyving/subscriptions","organizations_url":"https://api.github.com/users/oyving/orgs","repos_url":"https://api.github.com/users/oyving/repos","events_url":"https://api.github.com/users/oyving/events{/privacy}","received_events_url":"https://api.github.com/users/oyving/received_events","type":"User","site_admin":false},"body":"@aressem - Did I add a new module in the right way?\r\n@tokle - Did I create an archetype that looks sane?","created_at":"2019-09-10T08:00:30Z","updated_at":"2019-09-10T09:09:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2050172a66d4bf9ffd2cbc5022fbee685ddf01c7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aressem","id":18211145,"node_id":"MDQ6VXNlcjE4MjExMTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/18211145?v=4","gravatar_id":"","url":"https://api.github.com/users/aressem","html_url":"https://github.com/aressem","followers_url":"https://api.github.com/users/aressem/followers","following_url":"https://api.github.com/users/aressem/following{/other_user}","gists_url":"https://api.github.com/users/aressem/gists{/gist_id}","starred_url":"https://api.github.com/users/aressem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aressem/subscriptions","organizations_url":"https://api.github.com/users/aressem/orgs","repos_url":"https://api.github.com/users/aressem/repos","events_url":"https://api.github.com/users/aressem/events{/privacy}","received_events_url":"https://api.github.com/users/aressem/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/10579/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/14044fffb9dc9b4babec5df986212c9c087ff2f2","head":{"label":"vespa-engine:ogronnesby/add-archetype-java","ref":"ogronnesby/add-archetype-java","sha":"14044fffb9dc9b4babec5df986212c9c087ff2f2","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","private":false,"owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa is an engine for low-latency computation over large data sets.","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2019-09-10T09:03:43Z","pushed_at":"2019-09-10T09:09:16Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"https://vespa.ai","size":99511,"stargazers_count":2934,"watchers_count":2934,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":344,"open_issues":81,"watchers":2934,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"06824d29bdc753a00e9bcfe809344b5823f04203","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","private":false,"owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa is an engine for low-latency computation over large data sets.","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2019-09-10T09:03:43Z","pushed_at":"2019-09-10T09:09:16Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"https://vespa.ai","size":99511,"stargazers_count":2934,"watchers_count":2934,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":344,"open_issues":81,"watchers":2934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/10579"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/10579"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/10579/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/10579/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/14044fffb9dc9b4babec5df986212c9c087ff2f2"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 60377070,
"name": "vespa-engine/vespa",
"url": "https://api.github.com/repos/vespa-engine/vespa"
}
|
{
"id": 14175,
"login": "oyving",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14175?",
"url": "https://api.github.com/users/oyving"
}
|
{
"id": 29299694,
"login": "vespa-engine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29299694?",
"url": "https://api.github.com/orgs/vespa-engine"
}
| 2019-09-10T09:09:36 |
10383197456
|
{"actor":{"display_login":"oyving"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments/310076952","pull_request_review_id":270105756,"id":310076952,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDA3Njk1Mg==","diff_hunk":"@@ -0,0 +1,225 @@\n+var Color = require('color')\n+\n+function changeContrast (colorString, factor) {\n+ // TODO make the black check code work\n+ const color = Color(colorString).hex() === '#000000' ? Color('#010101') : Color(colorString)\n+ if (color.isDark()) {\n+ console.log('dark')\n+ return color.lighten(factor).rgb().string()\n+ } else if (color.isLight()) {\n+ console.log('light')\n+ return color.darken(factor).rgb().string()\n+ }\n+}\n+\n+function invertColor (colorString) {\n+ const color = Color(colorString)\n+ return color.negate().rgb().string()\n+}\n+\n+function changeSaturation (colorString, factor) {\n+ const color = Color(colorString)\n+ if (factor < 0) {\n+ return color.desaturate(factor *= -1).rgb().string()\n+ } else if (factor > 0) {\n+ return color.saturate(factor).rgb().string()\n+ } else {\n+ return color.rgb().string()\n+ }\n+}\n+\n+function undefinedGuard (value, func) {\n+ if (typeof value === 'undefined') return undefined\n+ else return func(value)\n+}\n+\n+export function ThemeDataBuilder (theme) {\n+ // todo resolve all strings to be dependent on vars of the highLevelObject\n+ // Its ok when highLevelObject is missing some properties\n+ // and the returned object misses some values as result,\n+ // because it gets merged with the default theme later anyway\n+ /// Don't use color directly here\n+ console.log(theme.textNavBar, changeContrast(theme.textNavBar, 0.3))","path":"src/renderer/ThemeBackend.js","position":42,"original_position":42,"commit_id":"c93cb580f0f51637d79b8f6f10f767b8e34cba12","original_commit_id":"c93cb580f0f51637d79b8f6f10f767b8e34cba12","user":{"login":"Jikstra","id":34889164,"node_id":"MDQ6VXNlcjM0ODg5MTY0","avatar_url":"https://avatars0.githubusercontent.com/u/34889164?v=4","gravatar_id":"","url":"https://api.github.com/users/Jikstra","html_url":"https://github.com/Jikstra","followers_url":"https://api.github.com/users/Jikstra/followers","following_url":"https://api.github.com/users/Jikstra/following{/other_user}","gists_url":"https://api.github.com/users/Jikstra/gists{/gist_id}","starred_url":"https://api.github.com/users/Jikstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jikstra/subscriptions","organizations_url":"https://api.github.com/users/Jikstra/orgs","repos_url":"https://api.github.com/users/Jikstra/repos","events_url":"https://api.github.com/users/Jikstra/events{/privacy}","received_events_url":"https://api.github.com/users/Jikstra/received_events","type":"User","site_admin":false},"body":"log.debug","created_at":"2019-08-02T10:36:56Z","updated_at":"2019-08-02T10:53:55Z","html_url":"https://github.com/deltachat/deltachat-desktop/pull/911#discussion_r310076952","pull_request_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments/310076952"},"html":{"href":"https://github.com/deltachat/deltachat-desktop/pull/911#discussion_r310076952"},"pull_request":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911"}}},"pull_request":{"url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911","id":301346450,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMzQ2NDUw","html_url":"https://github.com/deltachat/deltachat-desktop/pull/911","diff_url":"https://github.com/deltachat/deltachat-desktop/pull/911.diff","patch_url":"https://github.com/deltachat/deltachat-desktop/pull/911.patch","issue_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/911","number":911,"state":"open","locked":false,"title":"[WIP] Theming efforts","user":{"login":"Simon-Laux","id":18725968,"node_id":"MDQ6VXNlcjE4NzI1OTY4","avatar_url":"https://avatars2.githubusercontent.com/u/18725968?v=4","gravatar_id":"","url":"https://api.github.com/users/Simon-Laux","html_url":"https://github.com/Simon-Laux","followers_url":"https://api.github.com/users/Simon-Laux/followers","following_url":"https://api.github.com/users/Simon-Laux/following{/other_user}","gists_url":"https://api.github.com/users/Simon-Laux/gists{/gist_id}","starred_url":"https://api.github.com/users/Simon-Laux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simon-Laux/subscriptions","organizations_url":"https://api.github.com/users/Simon-Laux/orgs","repos_url":"https://api.github.com/users/Simon-Laux/repos","events_url":"https://api.github.com/users/Simon-Laux/events{/privacy}","received_events_url":"https://api.github.com/users/Simon-Laux/received_events","type":"User","site_admin":false},"body":"The goal of this pr/sprint is to \r\n\r\n- [x] 1. Centralize all component color vars (no general non-telling var anymore)\r\n- [ ] 2. Create an abstraction layer with vars that have meaningfull names and convert from them to the component colors.\r\n- [ ] 3. Create some sample themes to test if we did it right\r\n\r\n- [x] If #863 is getting merged we need to change the deltaFocusBlue variable name","created_at":"2019-07-25T23:39:42Z","updated_at":"2019-08-02T10:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"547546b89f7124665caee90472bdd5e534a5f8c3","assignee":{"login":"Simon-Laux","id":18725968,"node_id":"MDQ6VXNlcjE4NzI1OTY4","avatar_url":"https://avatars2.githubusercontent.com/u/18725968?v=4","gravatar_id":"","url":"https://api.github.com/users/Simon-Laux","html_url":"https://github.com/Simon-Laux","followers_url":"https://api.github.com/users/Simon-Laux/followers","following_url":"https://api.github.com/users/Simon-Laux/following{/other_user}","gists_url":"https://api.github.com/users/Simon-Laux/gists{/gist_id}","starred_url":"https://api.github.com/users/Simon-Laux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simon-Laux/subscriptions","organizations_url":"https://api.github.com/users/Simon-Laux/orgs","repos_url":"https://api.github.com/users/Simon-Laux/repos","events_url":"https://api.github.com/users/Simon-Laux/events{/privacy}","received_events_url":"https://api.github.com/users/Simon-Laux/received_events","type":"User","site_admin":false},"assignees":[{"login":"Simon-Laux","id":18725968,"node_id":"MDQ6VXNlcjE4NzI1OTY4","avatar_url":"https://avatars2.githubusercontent.com/u/18725968?v=4","gravatar_id":"","url":"https://api.github.com/users/Simon-Laux","html_url":"https://github.com/Simon-Laux","followers_url":"https://api.github.com/users/Simon-Laux/followers","following_url":"https://api.github.com/users/Simon-Laux/following{/other_user}","gists_url":"https://api.github.com/users/Simon-Laux/gists{/gist_id}","starred_url":"https://api.github.com/users/Simon-Laux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Simon-Laux/subscriptions","organizations_url":"https://api.github.com/users/Simon-Laux/orgs","repos_url":"https://api.github.com/users/Simon-Laux/repos","events_url":"https://api.github.com/users/Simon-Laux/events{/privacy}","received_events_url":"https://api.github.com/users/Simon-Laux/received_events","type":"User","site_admin":false},{"login":"MIntrovrt","id":36997087,"node_id":"MDQ6VXNlcjM2OTk3MDg3","avatar_url":"https://avatars2.githubusercontent.com/u/36997087?v=4","gravatar_id":"","url":"https://api.github.com/users/MIntrovrt","html_url":"https://github.com/MIntrovrt","followers_url":"https://api.github.com/users/MIntrovrt/followers","following_url":"https://api.github.com/users/MIntrovrt/following{/other_user}","gists_url":"https://api.github.com/users/MIntrovrt/gists{/gist_id}","starred_url":"https://api.github.com/users/MIntrovrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIntrovrt/subscriptions","organizations_url":"https://api.github.com/users/MIntrovrt/orgs","repos_url":"https://api.github.com/users/MIntrovrt/repos","events_url":"https://api.github.com/users/MIntrovrt/events{/privacy}","received_events_url":"https://api.github.com/users/MIntrovrt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911/commits","review_comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911/comments","review_comment_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/911/comments","statuses_url":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/c93cb580f0f51637d79b8f6f10f767b8e34cba12","head":{"label":"deltachat:theming_efforts","ref":"theming_efforts","sha":"c93cb580f0f51637d79b8f6f10f767b8e34cba12","user":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"repo":{"id":145452984,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0NTI5ODQ=","name":"deltachat-desktop","full_name":"deltachat/deltachat-desktop","private":false,"owner":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/deltachat/deltachat-desktop","description":"Email-based instant messaging for Desktop.","fork":false,"url":"https://api.github.com/repos/deltachat/deltachat-desktop","forks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/forks","keys_url":"https://api.github.com/repos/deltachat/deltachat-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deltachat/deltachat-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deltachat/deltachat-desktop/teams","hooks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/hooks","issue_events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/events","assignees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/deltachat/deltachat-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/tags","blobs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/deltachat/deltachat-desktop/languages","stargazers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/stargazers","contributors_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contributors","subscribers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscribers","subscription_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscription","commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/deltachat/deltachat-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deltachat/deltachat-desktop/merges","archive_url":"https://api.github.com/repos/deltachat/deltachat-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deltachat/deltachat-desktop/downloads","issues_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/deltachat/deltachat-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/deltachat/deltachat-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deltachat/deltachat-desktop/labels{/name}","releases_url":"https://api.github.com/repos/deltachat/deltachat-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/deployments","created_at":"2018-08-20T18:02:34Z","updated_at":"2019-08-01T23:47:13Z","pushed_at":"2019-08-02T03:44:57Z","git_url":"git://github.com/deltachat/deltachat-desktop.git","ssh_url":"git@github.com:deltachat/deltachat-desktop.git","clone_url":"https://github.com/deltachat/deltachat-desktop.git","svn_url":"https://github.com/deltachat/deltachat-desktop","homepage":"","size":12341,"stargazers_count":207,"watchers_count":207,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":60,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":29,"open_issues":60,"watchers":207,"default_branch":"master"}},"base":{"label":"deltachat:master","ref":"master","sha":"db8567d270a3cccbe1a34ff14088edac729af0fc","user":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"repo":{"id":145452984,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0NTI5ODQ=","name":"deltachat-desktop","full_name":"deltachat/deltachat-desktop","private":false,"owner":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/deltachat/deltachat-desktop","description":"Email-based instant messaging for Desktop.","fork":false,"url":"https://api.github.com/repos/deltachat/deltachat-desktop","forks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/forks","keys_url":"https://api.github.com/repos/deltachat/deltachat-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deltachat/deltachat-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deltachat/deltachat-desktop/teams","hooks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/hooks","issue_events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/events","assignees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/deltachat/deltachat-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/tags","blobs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/deltachat/deltachat-desktop/languages","stargazers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/stargazers","contributors_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contributors","subscribers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscribers","subscription_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscription","commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/deltachat/deltachat-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deltachat/deltachat-desktop/merges","archive_url":"https://api.github.com/repos/deltachat/deltachat-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deltachat/deltachat-desktop/downloads","issues_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/deltachat/deltachat-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/deltachat/deltachat-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deltachat/deltachat-desktop/labels{/name}","releases_url":"https://api.github.com/repos/deltachat/deltachat-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/deployments","created_at":"2018-08-20T18:02:34Z","updated_at":"2019-08-01T23:47:13Z","pushed_at":"2019-08-02T03:44:57Z","git_url":"git://github.com/deltachat/deltachat-desktop.git","ssh_url":"git@github.com:deltachat/deltachat-desktop.git","clone_url":"https://github.com/deltachat/deltachat-desktop.git","svn_url":"https://github.com/deltachat/deltachat-desktop","homepage":"","size":12341,"stargazers_count":207,"watchers_count":207,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":60,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":29,"open_issues":60,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911"},"html":{"href":"https://github.com/deltachat/deltachat-desktop/pull/911"},"issue":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/911"},"comments":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/c93cb580f0f51637d79b8f6f10f767b8e34cba12"}},"author_association":"MEMBER"}}
|
{
"id": 145452984,
"name": "deltachat/deltachat-desktop",
"url": "https://api.github.com/repos/deltachat/deltachat-desktop"
}
|
{
"id": 34889164,
"login": "Jikstra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34889164?",
"url": "https://api.github.com/users/Jikstra"
}
|
{
"id": 29453316,
"login": "deltachat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29453316?",
"url": "https://api.github.com/orgs/deltachat"
}
| 2019-08-02T10:36:56 |
10135710465
|
{"actor":{"display_login":"Jikstra"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/comments/366467058","pull_request_review_id":342695394,"id":366467058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjQ2NzA1OA==","diff_hunk":"@@ -79,7 +75,7 @@ interface IntentionSyntax : IntentionUtilitySyntax {\n text: String = \"\",\n kClass: Class<K> = KtElement::class.java as Class<K>,\n isApplicableTo: (element: K, caretOffset: Int) -> Boolean = Noop.boolean2False,\n- applyTo: (element: K, editor: Editor?) -> Unit = Noop.effect2,\n+ applyTo: KtPsiFactory.(element: K, editor: Editor) -> Unit = Noop.effect3,","path":"idea-plugin/src/main/kotlin/arrow/meta/ide/dsl/editor/intention/IntentionSyntax.kt","position":40,"original_position":40,"commit_id":"d35ff861bf25fd28737e40157de9a80b6faefe3e","original_commit_id":"d35ff861bf25fd28737e40157de9a80b6faefe3e","user":{"login":"jansorg","id":11473063,"node_id":"MDQ6VXNlcjExNDczMDYz","avatar_url":"https://avatars2.githubusercontent.com/u/11473063?v=4","gravatar_id":"","url":"https://api.github.com/users/jansorg","html_url":"https://github.com/jansorg","followers_url":"https://api.github.com/users/jansorg/followers","following_url":"https://api.github.com/users/jansorg/following{/other_user}","gists_url":"https://api.github.com/users/jansorg/gists{/gist_id}","starred_url":"https://api.github.com/users/jansorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansorg/subscriptions","organizations_url":"https://api.github.com/users/jansorg/orgs","repos_url":"https://api.github.com/users/jansorg/repos","events_url":"https://api.github.com/users/jansorg/events{/privacy}","received_events_url":"https://api.github.com/users/jansorg/received_events","type":"User","site_admin":false},"body":"I don't fully understand the need for a `KtPsiFactory` as receiver here. \r\n\r\nThis is always called with a new instance (via `it.project?.ktPsiFactory?` below) and it might be unused by the callers of this method `IntentionSyntax.ktIntention`.\r\nCan't callers of `IntentionSyntax.ktIntention` just create their own instance when needed? \r\n\r\nIf it's required and necessary to pass as a receiver, then you might want to cache the instance. For example, with a key attached to the project (which is a UserDataHolder). Something like this:\r\n```\r\nval KEY = Key.create<KtPsiFactory>(\"arrow.ktpsifactory\")\r\nKEY.set(project, KtPsiFactory(project))\r\n// later\r\nval ktPsiFactory = KEY.get(project)\r\n```","created_at":"2020-01-14T17:16:08Z","updated_at":"2020-01-14T17:18:35Z","html_url":"https://github.com/arrow-kt/arrow-meta/pull/388#discussion_r366467058","pull_request_url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/comments/366467058"},"html":{"href":"https://github.com/arrow-kt/arrow-meta/pull/388#discussion_r366467058"},"pull_request":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388"}}},"pull_request":{"url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388","id":358741188,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU4NzQxMTg4","html_url":"https://github.com/arrow-kt/arrow-meta/pull/388","diff_url":"https://github.com/arrow-kt/arrow-meta/pull/388.diff","patch_url":"https://github.com/arrow-kt/arrow-meta/pull/388.patch","issue_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/388","number":388,"state":"open","locked":false,"title":"Deprecations and Improvements on Intentions","user":{"login":"i-walker","id":46971368,"node_id":"MDQ6VXNlcjQ2OTcxMzY4","avatar_url":"https://avatars0.githubusercontent.com/u/46971368?v=4","gravatar_id":"","url":"https://api.github.com/users/i-walker","html_url":"https://github.com/i-walker","followers_url":"https://api.github.com/users/i-walker/followers","following_url":"https://api.github.com/users/i-walker/following{/other_user}","gists_url":"https://api.github.com/users/i-walker/gists{/gist_id}","starred_url":"https://api.github.com/users/i-walker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i-walker/subscriptions","organizations_url":"https://api.github.com/users/i-walker/orgs","repos_url":"https://api.github.com/users/i-walker/repos","events_url":"https://api.github.com/users/i-walker/events{/privacy}","received_events_url":"https://api.github.com/users/i-walker/received_events","type":"User","site_admin":false},"body":"- The Java API's on registering Intentions with MetaData is deprecated and will be deleted\r\nFurthermore, we can still achieve the same things with Intentions without Metadata, by having `KtPsiFactory` as a receiver in `applyTo`. This allows us to do the same things as we do with `Inspections`\r\n\r\n- FileTemplate Syntax should be deleted as it does not add any advantages over the IntelliJ platform. Going through the internals it is easier setting up a FileTemplate and the reference rather than the lifting it to Meta. That is exactly due to how those Templates are registered and referenced in the internals. The actual registration looks a bit like this `FileTemplateManager.getInstance(project).addTemplate(name=\"MyFileTemplate\", extension=\"kt\")`, but the FileTemplates are written in `.tf` files, which allow users to intercept variables of the project and ide to craft the template in the resource folder. Thereby, there is little value rather than using the XML API `<internalFileTemplate name=\"MyADT\"/>` and writting:\r\n```\r\n//resources/fileTemplates/internal/MyADT.kt.tf\r\n#if (${PACKAGE_NAME} && ${PACKAGE_NAME} != \"\")package ${PACKAGE_NAME}\r\n\r\n#end\r\n#parse(\"File Header.java\")\r\nsealed class ${NAME} {\r\n // add your leaves\r\n}\r\n```\r\nOne possible improvement is to hijack the extension, which has all variables that exist in a `.tf` file like `PACKAGE_NAME` or `NAME` for improved ergonomics and autocomplete.","created_at":"2020-01-02T17:55:15Z","updated_at":"2020-01-14T17:18:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfefd90083e7c1eeb7752969322222e33c080352","assignee":null,"assignees":[],"requested_reviewers":[{"login":"franciscodr","id":1200151,"node_id":"MDQ6VXNlcjEyMDAxNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1200151?v=4","gravatar_id":"","url":"https://api.github.com/users/franciscodr","html_url":"https://github.com/franciscodr","followers_url":"https://api.github.com/users/franciscodr/followers","following_url":"https://api.github.com/users/franciscodr/following{/other_user}","gists_url":"https://api.github.com/users/franciscodr/gists{/gist_id}","starred_url":"https://api.github.com/users/franciscodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franciscodr/subscriptions","organizations_url":"https://api.github.com/users/franciscodr/orgs","repos_url":"https://api.github.com/users/franciscodr/repos","events_url":"https://api.github.com/users/franciscodr/events{/privacy}","received_events_url":"https://api.github.com/users/franciscodr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388/commits","review_comments_url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388/comments","review_comment_url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/388/comments","statuses_url":"https://api.github.com/repos/arrow-kt/arrow-meta/statuses/d35ff861bf25fd28737e40157de9a80b6faefe3e","head":{"label":"arrow-kt:is-intention","ref":"is-intention","sha":"d35ff861bf25fd28737e40157de9a80b6faefe3e","user":{"login":"arrow-kt","id":29458023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDU4MDIz","avatar_url":"https://avatars1.githubusercontent.com/u/29458023?v=4","gravatar_id":"","url":"https://api.github.com/users/arrow-kt","html_url":"https://github.com/arrow-kt","followers_url":"https://api.github.com/users/arrow-kt/followers","following_url":"https://api.github.com/users/arrow-kt/following{/other_user}","gists_url":"https://api.github.com/users/arrow-kt/gists{/gist_id}","starred_url":"https://api.github.com/users/arrow-kt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrow-kt/subscriptions","organizations_url":"https://api.github.com/users/arrow-kt/orgs","repos_url":"https://api.github.com/users/arrow-kt/repos","events_url":"https://api.github.com/users/arrow-kt/events{/privacy}","received_events_url":"https://api.github.com/users/arrow-kt/received_events","type":"Organization","site_admin":false},"repo":{"id":217378939,"node_id":"MDEwOlJlcG9zaXRvcnkyMTczNzg5Mzk=","name":"arrow-meta","full_name":"arrow-kt/arrow-meta","private":false,"owner":{"login":"arrow-kt","id":29458023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDU4MDIz","avatar_url":"https://avatars1.githubusercontent.com/u/29458023?v=4","gravatar_id":"","url":"https://api.github.com/users/arrow-kt","html_url":"https://github.com/arrow-kt","followers_url":"https://api.github.com/users/arrow-kt/followers","following_url":"https://api.github.com/users/arrow-kt/following{/other_user}","gists_url":"https://api.github.com/users/arrow-kt/gists{/gist_id}","starred_url":"https://api.github.com/users/arrow-kt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrow-kt/subscriptions","organizations_url":"https://api.github.com/users/arrow-kt/orgs","repos_url":"https://api.github.com/users/arrow-kt/repos","events_url":"https://api.github.com/users/arrow-kt/events{/privacy}","received_events_url":"https://api.github.com/users/arrow-kt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arrow-kt/arrow-meta","description":"Functional companion to Kotlin's Compiler","fork":false,"url":"https://api.github.com/repos/arrow-kt/arrow-meta","forks_url":"https://api.github.com/repos/arrow-kt/arrow-meta/forks","keys_url":"https://api.github.com/repos/arrow-kt/arrow-meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arrow-kt/arrow-meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arrow-kt/arrow-meta/teams","hooks_url":"https://api.github.com/repos/arrow-kt/arrow-meta/hooks","issue_events_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/events{/number}","events_url":"https://api.github.com/repos/arrow-kt/arrow-meta/events","assignees_url":"https://api.github.com/repos/arrow-kt/arrow-meta/assignees{/user}","branches_url":"https://api.github.com/repos/arrow-kt/arrow-meta/branches{/branch}","tags_url":"https://api.github.com/repos/arrow-kt/arrow-meta/tags","blobs_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arrow-kt/arrow-meta/statuses/{sha}","languages_url":"https://api.github.com/repos/arrow-kt/arrow-meta/languages","stargazers_url":"https://api.github.com/repos/arrow-kt/arrow-meta/stargazers","contributors_url":"https://api.github.com/repos/arrow-kt/arrow-meta/contributors","subscribers_url":"https://api.github.com/repos/arrow-kt/arrow-meta/subscribers","subscription_url":"https://api.github.com/repos/arrow-kt/arrow-meta/subscription","commits_url":"https://api.github.com/repos/arrow-kt/arrow-meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/arrow-kt/arrow-meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/arrow-kt/arrow-meta/contents/{+path}","compare_url":"https://api.github.com/repos/arrow-kt/arrow-meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arrow-kt/arrow-meta/merges","archive_url":"https://api.github.com/repos/arrow-kt/arrow-meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arrow-kt/arrow-meta/downloads","issues_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues{/number}","pulls_url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls{/number}","milestones_url":"https://api.github.com/repos/arrow-kt/arrow-meta/milestones{/number}","notifications_url":"https://api.github.com/repos/arrow-kt/arrow-meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arrow-kt/arrow-meta/labels{/name}","releases_url":"https://api.github.com/repos/arrow-kt/arrow-meta/releases{/id}","deployments_url":"https://api.github.com/repos/arrow-kt/arrow-meta/deployments","created_at":"2019-10-24T19:28:44Z","updated_at":"2020-01-14T10:45:52Z","pushed_at":"2020-01-14T12:52:10Z","git_url":"git://github.com/arrow-kt/arrow-meta.git","ssh_url":"git@github.com:arrow-kt/arrow-meta.git","clone_url":"https://github.com/arrow-kt/arrow-meta.git","svn_url":"https://github.com/arrow-kt/arrow-meta","homepage":"https://meta.arrow-kt.io","size":19087,"stargazers_count":118,"watchers_count":118,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":66,"watchers":118,"default_branch":"master"}},"base":{"label":"arrow-kt:master","ref":"master","sha":"980915e860aadb325491349e2cf8fd66ed0ed3bc","user":{"login":"arrow-kt","id":29458023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDU4MDIz","avatar_url":"https://avatars1.githubusercontent.com/u/29458023?v=4","gravatar_id":"","url":"https://api.github.com/users/arrow-kt","html_url":"https://github.com/arrow-kt","followers_url":"https://api.github.com/users/arrow-kt/followers","following_url":"https://api.github.com/users/arrow-kt/following{/other_user}","gists_url":"https://api.github.com/users/arrow-kt/gists{/gist_id}","starred_url":"https://api.github.com/users/arrow-kt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrow-kt/subscriptions","organizations_url":"https://api.github.com/users/arrow-kt/orgs","repos_url":"https://api.github.com/users/arrow-kt/repos","events_url":"https://api.github.com/users/arrow-kt/events{/privacy}","received_events_url":"https://api.github.com/users/arrow-kt/received_events","type":"Organization","site_admin":false},"repo":{"id":217378939,"node_id":"MDEwOlJlcG9zaXRvcnkyMTczNzg5Mzk=","name":"arrow-meta","full_name":"arrow-kt/arrow-meta","private":false,"owner":{"login":"arrow-kt","id":29458023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDU4MDIz","avatar_url":"https://avatars1.githubusercontent.com/u/29458023?v=4","gravatar_id":"","url":"https://api.github.com/users/arrow-kt","html_url":"https://github.com/arrow-kt","followers_url":"https://api.github.com/users/arrow-kt/followers","following_url":"https://api.github.com/users/arrow-kt/following{/other_user}","gists_url":"https://api.github.com/users/arrow-kt/gists{/gist_id}","starred_url":"https://api.github.com/users/arrow-kt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrow-kt/subscriptions","organizations_url":"https://api.github.com/users/arrow-kt/orgs","repos_url":"https://api.github.com/users/arrow-kt/repos","events_url":"https://api.github.com/users/arrow-kt/events{/privacy}","received_events_url":"https://api.github.com/users/arrow-kt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arrow-kt/arrow-meta","description":"Functional companion to Kotlin's Compiler","fork":false,"url":"https://api.github.com/repos/arrow-kt/arrow-meta","forks_url":"https://api.github.com/repos/arrow-kt/arrow-meta/forks","keys_url":"https://api.github.com/repos/arrow-kt/arrow-meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arrow-kt/arrow-meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arrow-kt/arrow-meta/teams","hooks_url":"https://api.github.com/repos/arrow-kt/arrow-meta/hooks","issue_events_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/events{/number}","events_url":"https://api.github.com/repos/arrow-kt/arrow-meta/events","assignees_url":"https://api.github.com/repos/arrow-kt/arrow-meta/assignees{/user}","branches_url":"https://api.github.com/repos/arrow-kt/arrow-meta/branches{/branch}","tags_url":"https://api.github.com/repos/arrow-kt/arrow-meta/tags","blobs_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arrow-kt/arrow-meta/statuses/{sha}","languages_url":"https://api.github.com/repos/arrow-kt/arrow-meta/languages","stargazers_url":"https://api.github.com/repos/arrow-kt/arrow-meta/stargazers","contributors_url":"https://api.github.com/repos/arrow-kt/arrow-meta/contributors","subscribers_url":"https://api.github.com/repos/arrow-kt/arrow-meta/subscribers","subscription_url":"https://api.github.com/repos/arrow-kt/arrow-meta/subscription","commits_url":"https://api.github.com/repos/arrow-kt/arrow-meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/arrow-kt/arrow-meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/arrow-kt/arrow-meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/arrow-kt/arrow-meta/contents/{+path}","compare_url":"https://api.github.com/repos/arrow-kt/arrow-meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arrow-kt/arrow-meta/merges","archive_url":"https://api.github.com/repos/arrow-kt/arrow-meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arrow-kt/arrow-meta/downloads","issues_url":"https://api.github.com/repos/arrow-kt/arrow-meta/issues{/number}","pulls_url":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls{/number}","milestones_url":"https://api.github.com/repos/arrow-kt/arrow-meta/milestones{/number}","notifications_url":"https://api.github.com/repos/arrow-kt/arrow-meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arrow-kt/arrow-meta/labels{/name}","releases_url":"https://api.github.com/repos/arrow-kt/arrow-meta/releases{/id}","deployments_url":"https://api.github.com/repos/arrow-kt/arrow-meta/deployments","created_at":"2019-10-24T19:28:44Z","updated_at":"2020-01-14T10:45:52Z","pushed_at":"2020-01-14T12:52:10Z","git_url":"git://github.com/arrow-kt/arrow-meta.git","ssh_url":"git@github.com:arrow-kt/arrow-meta.git","clone_url":"https://github.com/arrow-kt/arrow-meta.git","svn_url":"https://github.com/arrow-kt/arrow-meta","homepage":"https://meta.arrow-kt.io","size":19087,"stargazers_count":118,"watchers_count":118,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":66,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388"},"html":{"href":"https://github.com/arrow-kt/arrow-meta/pull/388"},"issue":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/388"},"comments":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/arrow-kt/arrow-meta/statuses/d35ff861bf25fd28737e40157de9a80b6faefe3e"}},"author_association":"MEMBER"}}
|
{
"id": 217378939,
"name": "arrow-kt/arrow-meta",
"url": "https://api.github.com/repos/arrow-kt/arrow-meta"
}
|
{
"id": 11473063,
"login": "jansorg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11473063?",
"url": "https://api.github.com/users/jansorg"
}
|
{
"id": 29458023,
"login": "arrow-kt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29458023?",
"url": "https://api.github.com/orgs/arrow-kt"
}
| 2020-01-14T17:16:08 |
11273843552
|
{"actor":{"display_login":"jansorg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/comments/275408938","pull_request_review_id":226707814,"id":275408938,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTQwODkzOA==","diff_hunk":"@@ -0,0 +1,36 @@\n+# Contribution from the Crick HPC team\n+# uploaded by J. Sassmannshausen\n+\n+easyblock = 'Tarball'\n+\n+name = 'Trim_Galore'\n+version = '0.6.0'\n+\n+homepage = 'https://www.bioinformatics.babraham.ac.uk/projects/trim_galore/'\n+description = \"\"\"Trim Galore! is a wrapper script to automate quality and \n+adapter trimming as well as quality control, with some added functionality \n+to remove biased methylation positions for RRBS sequence files (for directional, \n+non-directional (or paired-end) sequencing).\"\"\"\n+\n+toolchain = {'name': 'dummy', 'version': 'dummy'}\n+\n+source_urls = ['https://github.com/FelixKrueger/TrimGalore/archive/']\n+sources = [{\n+ 'filename': '39e1ad7.tar.gz',\n+}]\n+\n+checksums = ['aad008ff2e9605079655013bd91615ca2272048b151b2fe7ee197d18b1b87908']\n+\n+dependencies = [\n+ ('FastQC', '0.11.8-Java-1.8'),\n+ ('cutadapt', '1.18-foss-2018b-Python-2.7.15')","path":"easybuild/easyconfigs/t/Trim_Galore/Trim_Galore-0.6.0.eb","position":26,"original_position":26,"commit_id":"87ae352a1e6be5a0c62f28f00fb7bc8fb5c2cd5a","original_commit_id":"fa00ab15f3053f7ef8a0f844f4e2689de0938f70","user":{"login":"sassy-crick","id":43338785,"node_id":"MDQ6VXNlcjQzMzM4Nzg1","avatar_url":"https://avatars2.githubusercontent.com/u/43338785?v=4","gravatar_id":"","url":"https://api.github.com/users/sassy-crick","html_url":"https://github.com/sassy-crick","followers_url":"https://api.github.com/users/sassy-crick/followers","following_url":"https://api.github.com/users/sassy-crick/following{/other_user}","gists_url":"https://api.github.com/users/sassy-crick/gists{/gist_id}","starred_url":"https://api.github.com/users/sassy-crick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassy-crick/subscriptions","organizations_url":"https://api.github.com/users/sassy-crick/orgs","repos_url":"https://api.github.com/users/sassy-crick/repos","events_url":"https://api.github.com/users/sassy-crick/events{/privacy}","received_events_url":"https://api.github.com/users/sassy-crick/received_events","type":"User","site_admin":false},"body":"@akesandgren \r\nThe same issue regarding Perl was also mentioned here:\r\nhttps://github.com/easybuilders/easybuild-easyconfigs/pull/8019\r\nHow shall we proceed regarding Perl in Trim_Galore?\r\nAs I said, I have no opinion here at all.\r\n","created_at":"2019-04-15T15:09:51Z","updated_at":"2019-04-15T15:09:51Z","html_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/7815#discussion_r275408938","pull_request_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/comments/275408938"},"html":{"href":"https://github.com/easybuilders/easybuild-easyconfigs/pull/7815#discussion_r275408938"},"pull_request":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815"}},"in_reply_to_id":263505490},"pull_request":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815","id":258670875,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4NjcwODc1","html_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/7815","diff_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/7815.diff","patch_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/7815.patch","issue_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/7815","number":7815,"state":"open","locked":false,"title":"{bio}[dummy/dummy] Trim_Galore v0.6.0","user":{"login":"sassy-crick","id":43338785,"node_id":"MDQ6VXNlcjQzMzM4Nzg1","avatar_url":"https://avatars2.githubusercontent.com/u/43338785?v=4","gravatar_id":"","url":"https://api.github.com/users/sassy-crick","html_url":"https://github.com/sassy-crick","followers_url":"https://api.github.com/users/sassy-crick/followers","following_url":"https://api.github.com/users/sassy-crick/following{/other_user}","gists_url":"https://api.github.com/users/sassy-crick/gists{/gist_id}","starred_url":"https://api.github.com/users/sassy-crick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassy-crick/subscriptions","organizations_url":"https://api.github.com/users/sassy-crick/orgs","repos_url":"https://api.github.com/users/sassy-crick/repos","events_url":"https://api.github.com/users/sassy-crick/events{/privacy}","received_events_url":"https://api.github.com/users/sassy-crick/received_events","type":"User","site_admin":false},"body":"(created using `eb --new-pr`)\n","created_at":"2019-03-06T10:55:32Z","updated_at":"2019-04-15T15:09:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62233a2afc9cf4d623eacb95870b3544585b7e7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":735127098,"node_id":"MDU6TGFiZWw3MzUxMjcwOTg=","url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/labels/update","name":"update","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/milestones/28","html_url":"https://github.com/easybuilders/easybuild-easyconfigs/milestone/28","labels_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/milestones/28/labels","id":1538619,"node_id":"MDk6TWlsZXN0b25lMTUzODYxOQ==","number":28,"title":"3.x","description":"","creator":{"login":"boegel","id":620876,"node_id":"MDQ6VXNlcjYyMDg3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":320,"closed_issues":484,"state":"open","created_at":"2016-01-23T13:53:53Z","updated_at":"2019-04-15T04:45:57Z","due_on":"2019-08-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815/commits","review_comments_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815/comments","review_comment_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/7815/comments","statuses_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/statuses/87ae352a1e6be5a0c62f28f00fb7bc8fb5c2cd5a","head":{"label":"sassy-crick:20190306105525_new_pr_TrimGalore060","ref":"20190306105525_new_pr_TrimGalore060","sha":"87ae352a1e6be5a0c62f28f00fb7bc8fb5c2cd5a","user":{"login":"sassy-crick","id":43338785,"node_id":"MDQ6VXNlcjQzMzM4Nzg1","avatar_url":"https://avatars2.githubusercontent.com/u/43338785?v=4","gravatar_id":"","url":"https://api.github.com/users/sassy-crick","html_url":"https://github.com/sassy-crick","followers_url":"https://api.github.com/users/sassy-crick/followers","following_url":"https://api.github.com/users/sassy-crick/following{/other_user}","gists_url":"https://api.github.com/users/sassy-crick/gists{/gist_id}","starred_url":"https://api.github.com/users/sassy-crick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassy-crick/subscriptions","organizations_url":"https://api.github.com/users/sassy-crick/orgs","repos_url":"https://api.github.com/users/sassy-crick/repos","events_url":"https://api.github.com/users/sassy-crick/events{/privacy}","received_events_url":"https://api.github.com/users/sassy-crick/received_events","type":"User","site_admin":false},"repo":{"id":166844503,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY4NDQ1MDM=","name":"easybuild-easyconfigs","full_name":"sassy-crick/easybuild-easyconfigs","private":false,"owner":{"login":"sassy-crick","id":43338785,"node_id":"MDQ6VXNlcjQzMzM4Nzg1","avatar_url":"https://avatars2.githubusercontent.com/u/43338785?v=4","gravatar_id":"","url":"https://api.github.com/users/sassy-crick","html_url":"https://github.com/sassy-crick","followers_url":"https://api.github.com/users/sassy-crick/followers","following_url":"https://api.github.com/users/sassy-crick/following{/other_user}","gists_url":"https://api.github.com/users/sassy-crick/gists{/gist_id}","starred_url":"https://api.github.com/users/sassy-crick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sassy-crick/subscriptions","organizations_url":"https://api.github.com/users/sassy-crick/orgs","repos_url":"https://api.github.com/users/sassy-crick/repos","events_url":"https://api.github.com/users/sassy-crick/events{/privacy}","received_events_url":"https://api.github.com/users/sassy-crick/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sassy-crick/easybuild-easyconfigs","description":"A collection of easyconfig files that describe which software to build using which build options with EasyBuild.","fork":true,"url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs","forks_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/forks","keys_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/teams","hooks_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/hooks","issue_events_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/issues/events{/number}","events_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/events","assignees_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/assignees{/user}","branches_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/branches{/branch}","tags_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/tags","blobs_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/statuses/{sha}","languages_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/languages","stargazers_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/stargazers","contributors_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/contributors","subscribers_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/subscribers","subscription_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/subscription","commits_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/contents/{+path}","compare_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/merges","archive_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/downloads","issues_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/issues{/number}","pulls_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/pulls{/number}","milestones_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/milestones{/number}","notifications_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/labels{/name}","releases_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/releases{/id}","deployments_url":"https://api.github.com/repos/sassy-crick/easybuild-easyconfigs/deployments","created_at":"2019-01-21T16:22:23Z","updated_at":"2019-01-21T16:22:39Z","pushed_at":"2019-04-15T14:50:13Z","git_url":"git://github.com/sassy-crick/easybuild-easyconfigs.git","ssh_url":"git@github.com:sassy-crick/easybuild-easyconfigs.git","clone_url":"https://github.com/sassy-crick/easybuild-easyconfigs.git","svn_url":"https://github.com/sassy-crick/easybuild-easyconfigs","homepage":"http://easybuilders.github.io/easybuild/","size":38817,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"easybuilders:develop","ref":"develop","sha":"060af91c7ca8b13f1491aabff814e2623194b7cb","user":{"login":"easybuilders","id":29568382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY4Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/29568382?v=4","gravatar_id":"","url":"https://api.github.com/users/easybuilders","html_url":"https://github.com/easybuilders","followers_url":"https://api.github.com/users/easybuilders/followers","following_url":"https://api.github.com/users/easybuilders/following{/other_user}","gists_url":"https://api.github.com/users/easybuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/easybuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easybuilders/subscriptions","organizations_url":"https://api.github.com/users/easybuilders/orgs","repos_url":"https://api.github.com/users/easybuilders/repos","events_url":"https://api.github.com/users/easybuilders/events{/privacy}","received_events_url":"https://api.github.com/users/easybuilders/received_events","type":"Organization","site_admin":false},"repo":{"id":6228403,"node_id":"MDEwOlJlcG9zaXRvcnk2MjI4NDAz","name":"easybuild-easyconfigs","full_name":"easybuilders/easybuild-easyconfigs","private":false,"owner":{"login":"easybuilders","id":29568382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY4Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/29568382?v=4","gravatar_id":"","url":"https://api.github.com/users/easybuilders","html_url":"https://github.com/easybuilders","followers_url":"https://api.github.com/users/easybuilders/followers","following_url":"https://api.github.com/users/easybuilders/following{/other_user}","gists_url":"https://api.github.com/users/easybuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/easybuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easybuilders/subscriptions","organizations_url":"https://api.github.com/users/easybuilders/orgs","repos_url":"https://api.github.com/users/easybuilders/repos","events_url":"https://api.github.com/users/easybuilders/events{/privacy}","received_events_url":"https://api.github.com/users/easybuilders/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/easybuilders/easybuild-easyconfigs","description":"A collection of easyconfig files that describe which software to build using which build options with EasyBuild.","fork":false,"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs","forks_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/forks","keys_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/teams","hooks_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/hooks","issue_events_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/events{/number}","events_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/events","assignees_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/assignees{/user}","branches_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/branches{/branch}","tags_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/tags","blobs_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/git/refs{/sha}","trees_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/statuses/{sha}","languages_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/languages","stargazers_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/stargazers","contributors_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/contributors","subscribers_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/subscribers","subscription_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/subscription","commits_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/commits{/sha}","git_commits_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/git/commits{/sha}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/comments{/number}","issue_comment_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/comments{/number}","contents_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/contents/{+path}","compare_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/merges","archive_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/downloads","issues_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues{/number}","pulls_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls{/number}","milestones_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/milestones{/number}","notifications_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/labels{/name}","releases_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/releases{/id}","deployments_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/deployments","created_at":"2012-10-15T14:32:53Z","updated_at":"2019-04-12T11:18:59Z","pushed_at":"2019-04-15T12:47:17Z","git_url":"git://github.com/easybuilders/easybuild-easyconfigs.git","ssh_url":"git@github.com:easybuilders/easybuild-easyconfigs.git","clone_url":"https://github.com/easybuilders/easybuild-easyconfigs.git","svn_url":"https://github.com/easybuilders/easybuild-easyconfigs","homepage":"http://easybuilders.github.io/easybuild/","size":39049,"stargazers_count":144,"watchers_count":144,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":368,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":656,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":368,"open_issues":656,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815"},"html":{"href":"https://github.com/easybuilders/easybuild-easyconfigs/pull/7815"},"issue":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/7815"},"comments":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/7815/comments"},"review_comments":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815/comments"},"review_comment":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/7815/commits"},"statuses":{"href":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/statuses/87ae352a1e6be5a0c62f28f00fb7bc8fb5c2cd5a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6228403,
"name": "easybuilders/easybuild-easyconfigs",
"url": "https://api.github.com/repos/easybuilders/easybuild-easyconfigs"
}
|
{
"id": 43338785,
"login": "sassy-crick",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43338785?",
"url": "https://api.github.com/users/sassy-crick"
}
|
{
"id": 29568382,
"login": "easybuilders",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29568382?",
"url": "https://api.github.com/orgs/easybuilders"
}
| 2019-04-15T15:09:51 |
9445888487
|
{"actor":{"display_login":"sassy-crick"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/comments/365885004","pull_request_review_id":341931478,"id":365885004,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTg4NTAwNA==","diff_hunk":"@@ -105,37 +128,41 @@ hgg_lesions_df <- hgg_lesions_df %>%\n #### Filter metadata -----------------------------------------------------------\n \n # Filter metadata for `High-grade glioma` and samples that should be classified\n-# as High-grade glioma based on defining lesions and are stranded RNA-seq\n-# samples.\n+# as High-grade glioma based on defining lesions\n hgg_metadata_df <- metadata %>%\n dplyr::filter(\n disease_type_new == \"High-grade glioma\" |\n sample_id %in% hgg_lesions_df$sample_id,\n- experimental_strategy == \"RNA-Seq\",\n- RNA_library == \"stranded\"\n+ sample_type == \"Tumor\",","path":"analyses/molecular-subtyping-HGG/02-HGG-molecular-subtyping-subset-files.R","position":93,"original_position":80,"commit_id":"693a36ca1571e1a986d38e99e5c8755b7b2af09c","original_commit_id":"e80d74e4d156e8c0de47b4f3a1ab418f2b19bd2e","user":{"login":"cansavvy","id":23458084,"node_id":"MDQ6VXNlcjIzNDU4MDg0","avatar_url":"https://avatars3.githubusercontent.com/u/23458084?v=4","gravatar_id":"","url":"https://api.github.com/users/cansavvy","html_url":"https://github.com/cansavvy","followers_url":"https://api.github.com/users/cansavvy/followers","following_url":"https://api.github.com/users/cansavvy/following{/other_user}","gists_url":"https://api.github.com/users/cansavvy/gists{/gist_id}","starred_url":"https://api.github.com/users/cansavvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cansavvy/subscriptions","organizations_url":"https://api.github.com/users/cansavvy/orgs","repos_url":"https://api.github.com/users/cansavvy/repos","events_url":"https://api.github.com/users/cansavvy/events{/privacy}","received_events_url":"https://api.github.com/users/cansavvy/received_events","type":"User","site_admin":false},"body":"This filter is what gets rid of cell line derived samples? ","created_at":"2020-01-13T16:03:14Z","updated_at":"2020-01-13T16:03:46Z","html_url":"https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/426#discussion_r365885004","pull_request_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/comments/365885004"},"html":{"href":"https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/426#discussion_r365885004"},"pull_request":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426","id":361683855,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxNjgzODU1","html_url":"https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/426","diff_url":"https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/426.diff","patch_url":"https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/426.patch","issue_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/issues/426","number":426,"state":"open","locked":false,"title":"PR 5 of n - Molecular Subtyping - HGG (Revise Subset Files)","user":{"login":"jaclyn-taroni","id":19534205,"node_id":"MDQ6VXNlcjE5NTM0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/19534205?v=4","gravatar_id":"","url":"https://api.github.com/users/jaclyn-taroni","html_url":"https://github.com/jaclyn-taroni","followers_url":"https://api.github.com/users/jaclyn-taroni/followers","following_url":"https://api.github.com/users/jaclyn-taroni/following{/other_user}","gists_url":"https://api.github.com/users/jaclyn-taroni/gists{/gist_id}","starred_url":"https://api.github.com/users/jaclyn-taroni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaclyn-taroni/subscriptions","organizations_url":"https://api.github.com/users/jaclyn-taroni/orgs","repos_url":"https://api.github.com/users/jaclyn-taroni/repos","events_url":"https://api.github.com/users/jaclyn-taroni/events{/privacy}","received_events_url":"https://api.github.com/users/jaclyn-taroni/received_events","type":"User","site_admin":false},"body":"<!--Hi there, thanks for your contribution! Please take a moment to fill out this template to facilitate the review of your pull request.-->\r\n\r\nBreaking out the changes from #420 \r\n\r\n### Purpose/implementation Section\r\n\r\nHere we are: \r\n* Making some changes to fix duplicates in the HGG defining lesions file.\r\n* Swapping in the CNVkit file because we're using the GISTIC file here. This is consistent with what was done for the ATRT module.\r\n* No longer subsetting the `pbta-histologies.tsv` file because the full file is available for testing in CI.\r\n* Subsetting the SNV file.\r\n* Making sure we're removing derived cell lines throughout.\r\n\r\n#### What GitHub issue does your pull request address?\r\n\r\n#249 \r\n\r\n### Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.\r\n\r\n\r\n\r\n#### Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?\r\n\r\nNo\r\n\r\n#### Reproducibility Checklist\r\n\r\n<!-- Check all those that apply or remove this section if it is not applicable.-->\r\n\r\n- [x] The dependencies required to run the code in this pull request have been added to the project Dockerfile.\r\n- [x] This analysis has been added to continuous integration.\r\n\r\n#### Documentation Checklist\r\n\r\n<!-- Please review https://github.com/AlexsLemonade/OpenPBTA-analysis#documenting-your-analysis -->\r\n\r\n- [ ] This analysis module has a `README` and it is up to date.\r\n- [x] This analysis is recorded in the table in `analyses/README.md` and the entry is up to date.\r\n- [x] The analytical code is documented and contains comments.\r\n\r\n<!-- IF YOUR PULL REQUEST IS A DATA RELEASE, PLEASE REMOVE THE [HTML COMMENT TAG](https://html.com/tags/comment-tag/) FROM THE SECTION BELOW AND COMPLETE THE CHECKLIST-->\r\n\r\n<!-- \r\n### Data Release Checklist\r\n- [ ] Is the table in doc/data-file-descriptions.md up to date?\r\n- [ ] Is doc/data-format.md up to date?\r\n- [ ] Is doc/release-notes.md up to date?\r\n- [ ] Is download-data.sh up to date?\r\n-->\r\n","created_at":"2020-01-11T02:13:33Z","updated_at":"2020-01-13T16:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3e42c9aceb4c4cbb43288fd3b3267d2ae262339","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1665431753,"node_id":"MDU6TGFiZWwxNjY1NDMxNzUz","url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/labels/molecular%20subtyping","name":"molecular subtyping","color":"e87a27","default":false,"description":"Related to molecular subtyping of tumors"}],"milestone":null,"commits_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426/commits","review_comments_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426/comments","review_comment_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/issues/426/comments","statuses_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/statuses/693a36ca1571e1a986d38e99e5c8755b7b2af09c","head":{"label":"jaclyn-taroni:revise-hgg-subset","ref":"revise-hgg-subset","sha":"693a36ca1571e1a986d38e99e5c8755b7b2af09c","user":{"login":"jaclyn-taroni","id":19534205,"node_id":"MDQ6VXNlcjE5NTM0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/19534205?v=4","gravatar_id":"","url":"https://api.github.com/users/jaclyn-taroni","html_url":"https://github.com/jaclyn-taroni","followers_url":"https://api.github.com/users/jaclyn-taroni/followers","following_url":"https://api.github.com/users/jaclyn-taroni/following{/other_user}","gists_url":"https://api.github.com/users/jaclyn-taroni/gists{/gist_id}","starred_url":"https://api.github.com/users/jaclyn-taroni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaclyn-taroni/subscriptions","organizations_url":"https://api.github.com/users/jaclyn-taroni/orgs","repos_url":"https://api.github.com/users/jaclyn-taroni/repos","events_url":"https://api.github.com/users/jaclyn-taroni/events{/privacy}","received_events_url":"https://api.github.com/users/jaclyn-taroni/received_events","type":"User","site_admin":false},"repo":{"id":201312755,"node_id":"MDEwOlJlcG9zaXRvcnkyMDEzMTI3NTU=","name":"OpenPBTA-analysis","full_name":"jaclyn-taroni/OpenPBTA-analysis","private":false,"owner":{"login":"jaclyn-taroni","id":19534205,"node_id":"MDQ6VXNlcjE5NTM0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/19534205?v=4","gravatar_id":"","url":"https://api.github.com/users/jaclyn-taroni","html_url":"https://github.com/jaclyn-taroni","followers_url":"https://api.github.com/users/jaclyn-taroni/followers","following_url":"https://api.github.com/users/jaclyn-taroni/following{/other_user}","gists_url":"https://api.github.com/users/jaclyn-taroni/gists{/gist_id}","starred_url":"https://api.github.com/users/jaclyn-taroni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaclyn-taroni/subscriptions","organizations_url":"https://api.github.com/users/jaclyn-taroni/orgs","repos_url":"https://api.github.com/users/jaclyn-taroni/repos","events_url":"https://api.github.com/users/jaclyn-taroni/events{/privacy}","received_events_url":"https://api.github.com/users/jaclyn-taroni/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jaclyn-taroni/OpenPBTA-analysis","description":"The analysis repository for the Open Pediatric Brain Tumor Atlas Project","fork":true,"url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis","forks_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/forks","keys_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/teams","hooks_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/hooks","issue_events_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/events","assignees_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/tags","blobs_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/languages","stargazers_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/stargazers","contributors_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/contributors","subscribers_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/subscribers","subscription_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/subscription","commits_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/merges","archive_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/downloads","issues_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/labels{/name}","releases_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/jaclyn-taroni/OpenPBTA-analysis/deployments","created_at":"2019-08-08T18:11:49Z","updated_at":"2020-01-11T01:33:32Z","pushed_at":"2020-01-13T16:01:36Z","git_url":"git://github.com/jaclyn-taroni/OpenPBTA-analysis.git","ssh_url":"git@github.com:jaclyn-taroni/OpenPBTA-analysis.git","clone_url":"https://github.com/jaclyn-taroni/OpenPBTA-analysis.git","svn_url":"https://github.com/jaclyn-taroni/OpenPBTA-analysis","homepage":null,"size":1129253,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AlexsLemonade:master","ref":"master","sha":"02d45fe4d54bf7c319099e0f94251ccf2bb77ec3","user":{"login":"AlexsLemonade","id":29661525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYxNTI1","avatar_url":"https://avatars1.githubusercontent.com/u/29661525?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexsLemonade","html_url":"https://github.com/AlexsLemonade","followers_url":"https://api.github.com/users/AlexsLemonade/followers","following_url":"https://api.github.com/users/AlexsLemonade/following{/other_user}","gists_url":"https://api.github.com/users/AlexsLemonade/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexsLemonade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexsLemonade/subscriptions","organizations_url":"https://api.github.com/users/AlexsLemonade/orgs","repos_url":"https://api.github.com/users/AlexsLemonade/repos","events_url":"https://api.github.com/users/AlexsLemonade/events{/privacy}","received_events_url":"https://api.github.com/users/AlexsLemonade/received_events","type":"Organization","site_admin":false},"repo":{"id":192607622,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI2MDc2MjI=","name":"OpenPBTA-analysis","full_name":"AlexsLemonade/OpenPBTA-analysis","private":false,"owner":{"login":"AlexsLemonade","id":29661525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYxNTI1","avatar_url":"https://avatars1.githubusercontent.com/u/29661525?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexsLemonade","html_url":"https://github.com/AlexsLemonade","followers_url":"https://api.github.com/users/AlexsLemonade/followers","following_url":"https://api.github.com/users/AlexsLemonade/following{/other_user}","gists_url":"https://api.github.com/users/AlexsLemonade/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexsLemonade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexsLemonade/subscriptions","organizations_url":"https://api.github.com/users/AlexsLemonade/orgs","repos_url":"https://api.github.com/users/AlexsLemonade/repos","events_url":"https://api.github.com/users/AlexsLemonade/events{/privacy}","received_events_url":"https://api.github.com/users/AlexsLemonade/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AlexsLemonade/OpenPBTA-analysis","description":"The analysis repository for the Open Pediatric Brain Tumor Atlas Project","fork":false,"url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis","forks_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/forks","keys_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/teams","hooks_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/hooks","issue_events_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/events","assignees_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/tags","blobs_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/languages","stargazers_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/stargazers","contributors_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/contributors","subscribers_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/subscribers","subscription_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/subscription","commits_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/merges","archive_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/downloads","issues_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/labels{/name}","releases_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/deployments","created_at":"2019-06-18T20:23:45Z","updated_at":"2020-01-10T18:15:48Z","pushed_at":"2020-01-13T16:01:45Z","git_url":"git://github.com/AlexsLemonade/OpenPBTA-analysis.git","ssh_url":"git@github.com:AlexsLemonade/OpenPBTA-analysis.git","clone_url":"https://github.com/AlexsLemonade/OpenPBTA-analysis.git","svn_url":"https://github.com/AlexsLemonade/OpenPBTA-analysis","homepage":null,"size":1052241,"stargazers_count":33,"watchers_count":33,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":57,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":57,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426"},"html":{"href":"https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/426"},"issue":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/issues/426"},"comments":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis/statuses/693a36ca1571e1a986d38e99e5c8755b7b2af09c"}},"author_association":"MEMBER"}}
|
{
"id": 192607622,
"name": "AlexsLemonade/OpenPBTA-analysis",
"url": "https://api.github.com/repos/AlexsLemonade/OpenPBTA-analysis"
}
|
{
"id": 23458084,
"login": "cansavvy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23458084?",
"url": "https://api.github.com/users/cansavvy"
}
|
{
"id": 29661525,
"login": "AlexsLemonade",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29661525?",
"url": "https://api.github.com/orgs/AlexsLemonade"
}
| 2020-01-13T16:03:14 |
11263253027
|
{"actor":{"display_login":"cansavvy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/codeuniversity/al-cis/pulls/comments/255840256","pull_request_review_id":202527515,"id":255840256,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTg0MDI1Ng==","diff_hunk":"@@ -0,0 +1,5 @@\n+grpcio==1.18.0\n+grpcio-tools==1.18.0","path":"prod-requirements.txt","position":null,"original_position":2,"commit_id":"5e523308a7101eebd9b39827d54cc8f29b2702cf","original_commit_id":"1aa071f2737ff0047239f86df0ee0d623e0ec850","user":{"login":"alexmorten","id":5254676,"node_id":"MDQ6VXNlcjUyNTQ2NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5254676?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmorten","html_url":"https://github.com/alexmorten","followers_url":"https://api.github.com/users/alexmorten/followers","following_url":"https://api.github.com/users/alexmorten/following{/other_user}","gists_url":"https://api.github.com/users/alexmorten/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmorten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmorten/subscriptions","organizations_url":"https://api.github.com/users/alexmorten/orgs","repos_url":"https://api.github.com/users/alexmorten/repos","events_url":"https://api.github.com/users/alexmorten/events{/privacy}","received_events_url":"https://api.github.com/users/alexmorten/received_events","type":"User","site_admin":false},"body":"It doesn't shrink the image size dramatically, but it's a start 😅","created_at":"2019-02-12T08:10:12Z","updated_at":"2019-02-12T08:10:12Z","html_url":"https://github.com/codeuniversity/al-cis/pull/1#discussion_r255840256","pull_request_url":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/codeuniversity/al-cis/pulls/comments/255840256"},"html":{"href":"https://github.com/codeuniversity/al-cis/pull/1#discussion_r255840256"},"pull_request":{"href":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1"}},"in_reply_to_id":255714076},"pull_request":{"url":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1","id":250868860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwODY4ODYw","html_url":"https://github.com/codeuniversity/al-cis/pull/1","diff_url":"https://github.com/codeuniversity/al-cis/pull/1.diff","patch_url":"https://github.com/codeuniversity/al-cis/pull/1.patch","issue_url":"https://api.github.com/repos/codeuniversity/al-cis/issues/1","number":1,"state":"open","locked":false,"title":"fix format","user":{"login":"selmaillig","id":30112484,"node_id":"MDQ6VXNlcjMwMTEyNDg0","avatar_url":"https://avatars2.githubusercontent.com/u/30112484?v=4","gravatar_id":"","url":"https://api.github.com/users/selmaillig","html_url":"https://github.com/selmaillig","followers_url":"https://api.github.com/users/selmaillig/followers","following_url":"https://api.github.com/users/selmaillig/following{/other_user}","gists_url":"https://api.github.com/users/selmaillig/gists{/gist_id}","starred_url":"https://api.github.com/users/selmaillig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selmaillig/subscriptions","organizations_url":"https://api.github.com/users/selmaillig/orgs","repos_url":"https://api.github.com/users/selmaillig/repos","events_url":"https://api.github.com/users/selmaillig/events{/privacy}","received_events_url":"https://api.github.com/users/selmaillig/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-06T18:56:00Z","updated_at":"2019-02-12T08:10:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e68ee58dfa4430564416389100076be21127a001","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1/commits","review_comments_url":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1/comments","review_comment_url":"https://api.github.com/repos/codeuniversity/al-cis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codeuniversity/al-cis/issues/1/comments","statuses_url":"https://api.github.com/repos/codeuniversity/al-cis/statuses/5e523308a7101eebd9b39827d54cc8f29b2702cf","head":{"label":"codeuniversity:fix-linting","ref":"fix-linting","sha":"5e523308a7101eebd9b39827d54cc8f29b2702cf","user":{"login":"codeuniversity","id":29784497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Nzg0NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/29784497?v=4","gravatar_id":"","url":"https://api.github.com/users/codeuniversity","html_url":"https://github.com/codeuniversity","followers_url":"https://api.github.com/users/codeuniversity/followers","following_url":"https://api.github.com/users/codeuniversity/following{/other_user}","gists_url":"https://api.github.com/users/codeuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/codeuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeuniversity/subscriptions","organizations_url":"https://api.github.com/users/codeuniversity/orgs","repos_url":"https://api.github.com/users/codeuniversity/repos","events_url":"https://api.github.com/users/codeuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/codeuniversity/received_events","type":"Organization","site_admin":false},"repo":{"id":169068712,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNjg3MTI=","name":"al-cis","full_name":"codeuniversity/al-cis","private":false,"owner":{"login":"codeuniversity","id":29784497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Nzg0NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/29784497?v=4","gravatar_id":"","url":"https://api.github.com/users/codeuniversity","html_url":"https://github.com/codeuniversity","followers_url":"https://api.github.com/users/codeuniversity/followers","following_url":"https://api.github.com/users/codeuniversity/following{/other_user}","gists_url":"https://api.github.com/users/codeuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/codeuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeuniversity/subscriptions","organizations_url":"https://api.github.com/users/codeuniversity/orgs","repos_url":"https://api.github.com/users/codeuniversity/repos","events_url":"https://api.github.com/users/codeuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/codeuniversity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codeuniversity/al-cis","description":null,"fork":false,"url":"https://api.github.com/repos/codeuniversity/al-cis","forks_url":"https://api.github.com/repos/codeuniversity/al-cis/forks","keys_url":"https://api.github.com/repos/codeuniversity/al-cis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeuniversity/al-cis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeuniversity/al-cis/teams","hooks_url":"https://api.github.com/repos/codeuniversity/al-cis/hooks","issue_events_url":"https://api.github.com/repos/codeuniversity/al-cis/issues/events{/number}","events_url":"https://api.github.com/repos/codeuniversity/al-cis/events","assignees_url":"https://api.github.com/repos/codeuniversity/al-cis/assignees{/user}","branches_url":"https://api.github.com/repos/codeuniversity/al-cis/branches{/branch}","tags_url":"https://api.github.com/repos/codeuniversity/al-cis/tags","blobs_url":"https://api.github.com/repos/codeuniversity/al-cis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeuniversity/al-cis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeuniversity/al-cis/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeuniversity/al-cis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeuniversity/al-cis/statuses/{sha}","languages_url":"https://api.github.com/repos/codeuniversity/al-cis/languages","stargazers_url":"https://api.github.com/repos/codeuniversity/al-cis/stargazers","contributors_url":"https://api.github.com/repos/codeuniversity/al-cis/contributors","subscribers_url":"https://api.github.com/repos/codeuniversity/al-cis/subscribers","subscription_url":"https://api.github.com/repos/codeuniversity/al-cis/subscription","commits_url":"https://api.github.com/repos/codeuniversity/al-cis/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeuniversity/al-cis/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeuniversity/al-cis/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeuniversity/al-cis/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeuniversity/al-cis/contents/{+path}","compare_url":"https://api.github.com/repos/codeuniversity/al-cis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeuniversity/al-cis/merges","archive_url":"https://api.github.com/repos/codeuniversity/al-cis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeuniversity/al-cis/downloads","issues_url":"https://api.github.com/repos/codeuniversity/al-cis/issues{/number}","pulls_url":"https://api.github.com/repos/codeuniversity/al-cis/pulls{/number}","milestones_url":"https://api.github.com/repos/codeuniversity/al-cis/milestones{/number}","notifications_url":"https://api.github.com/repos/codeuniversity/al-cis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeuniversity/al-cis/labels{/name}","releases_url":"https://api.github.com/repos/codeuniversity/al-cis/releases{/id}","deployments_url":"https://api.github.com/repos/codeuniversity/al-cis/deployments","created_at":"2019-02-04T11:29:40Z","updated_at":"2019-02-10T21:22:50Z","pushed_at":"2019-02-12T08:08:12Z","git_url":"git://github.com/codeuniversity/al-cis.git","ssh_url":"git@github.com:codeuniversity/al-cis.git","clone_url":"https://github.com/codeuniversity/al-cis.git","svn_url":"https://github.com/codeuniversity/al-cis","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"codeuniversity:master","ref":"master","sha":"b021d40dd4ef0f6ddcd305ec58c49f3234fa460c","user":{"login":"codeuniversity","id":29784497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Nzg0NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/29784497?v=4","gravatar_id":"","url":"https://api.github.com/users/codeuniversity","html_url":"https://github.com/codeuniversity","followers_url":"https://api.github.com/users/codeuniversity/followers","following_url":"https://api.github.com/users/codeuniversity/following{/other_user}","gists_url":"https://api.github.com/users/codeuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/codeuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeuniversity/subscriptions","organizations_url":"https://api.github.com/users/codeuniversity/orgs","repos_url":"https://api.github.com/users/codeuniversity/repos","events_url":"https://api.github.com/users/codeuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/codeuniversity/received_events","type":"Organization","site_admin":false},"repo":{"id":169068712,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNjg3MTI=","name":"al-cis","full_name":"codeuniversity/al-cis","private":false,"owner":{"login":"codeuniversity","id":29784497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Nzg0NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/29784497?v=4","gravatar_id":"","url":"https://api.github.com/users/codeuniversity","html_url":"https://github.com/codeuniversity","followers_url":"https://api.github.com/users/codeuniversity/followers","following_url":"https://api.github.com/users/codeuniversity/following{/other_user}","gists_url":"https://api.github.com/users/codeuniversity/gists{/gist_id}","starred_url":"https://api.github.com/users/codeuniversity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeuniversity/subscriptions","organizations_url":"https://api.github.com/users/codeuniversity/orgs","repos_url":"https://api.github.com/users/codeuniversity/repos","events_url":"https://api.github.com/users/codeuniversity/events{/privacy}","received_events_url":"https://api.github.com/users/codeuniversity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codeuniversity/al-cis","description":null,"fork":false,"url":"https://api.github.com/repos/codeuniversity/al-cis","forks_url":"https://api.github.com/repos/codeuniversity/al-cis/forks","keys_url":"https://api.github.com/repos/codeuniversity/al-cis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeuniversity/al-cis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeuniversity/al-cis/teams","hooks_url":"https://api.github.com/repos/codeuniversity/al-cis/hooks","issue_events_url":"https://api.github.com/repos/codeuniversity/al-cis/issues/events{/number}","events_url":"https://api.github.com/repos/codeuniversity/al-cis/events","assignees_url":"https://api.github.com/repos/codeuniversity/al-cis/assignees{/user}","branches_url":"https://api.github.com/repos/codeuniversity/al-cis/branches{/branch}","tags_url":"https://api.github.com/repos/codeuniversity/al-cis/tags","blobs_url":"https://api.github.com/repos/codeuniversity/al-cis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeuniversity/al-cis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeuniversity/al-cis/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeuniversity/al-cis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeuniversity/al-cis/statuses/{sha}","languages_url":"https://api.github.com/repos/codeuniversity/al-cis/languages","stargazers_url":"https://api.github.com/repos/codeuniversity/al-cis/stargazers","contributors_url":"https://api.github.com/repos/codeuniversity/al-cis/contributors","subscribers_url":"https://api.github.com/repos/codeuniversity/al-cis/subscribers","subscription_url":"https://api.github.com/repos/codeuniversity/al-cis/subscription","commits_url":"https://api.github.com/repos/codeuniversity/al-cis/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeuniversity/al-cis/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeuniversity/al-cis/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeuniversity/al-cis/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeuniversity/al-cis/contents/{+path}","compare_url":"https://api.github.com/repos/codeuniversity/al-cis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeuniversity/al-cis/merges","archive_url":"https://api.github.com/repos/codeuniversity/al-cis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeuniversity/al-cis/downloads","issues_url":"https://api.github.com/repos/codeuniversity/al-cis/issues{/number}","pulls_url":"https://api.github.com/repos/codeuniversity/al-cis/pulls{/number}","milestones_url":"https://api.github.com/repos/codeuniversity/al-cis/milestones{/number}","notifications_url":"https://api.github.com/repos/codeuniversity/al-cis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeuniversity/al-cis/labels{/name}","releases_url":"https://api.github.com/repos/codeuniversity/al-cis/releases{/id}","deployments_url":"https://api.github.com/repos/codeuniversity/al-cis/deployments","created_at":"2019-02-04T11:29:40Z","updated_at":"2019-02-10T21:22:50Z","pushed_at":"2019-02-12T08:08:12Z","git_url":"git://github.com/codeuniversity/al-cis.git","ssh_url":"git@github.com:codeuniversity/al-cis.git","clone_url":"https://github.com/codeuniversity/al-cis.git","svn_url":"https://github.com/codeuniversity/al-cis","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1"},"html":{"href":"https://github.com/codeuniversity/al-cis/pull/1"},"issue":{"href":"https://api.github.com/repos/codeuniversity/al-cis/issues/1"},"comments":{"href":"https://api.github.com/repos/codeuniversity/al-cis/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/codeuniversity/al-cis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codeuniversity/al-cis/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/codeuniversity/al-cis/statuses/5e523308a7101eebd9b39827d54cc8f29b2702cf"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 169068712,
"name": "codeuniversity/al-cis",
"url": "https://api.github.com/repos/codeuniversity/al-cis"
}
|
{
"id": 5254676,
"login": "alexmorten",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5254676?",
"url": "https://api.github.com/users/alexmorten"
}
|
{
"id": 29784497,
"login": "codeuniversity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29784497?",
"url": "https://api.github.com/orgs/codeuniversity"
}
| 2019-02-12T08:10:12 |
9050267558
|
{"actor":{"display_login":"alexmorten"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/comments/304909138","pull_request_review_id":263636573,"id":304909138,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNDkwOTEzOA==","diff_hunk":"@@ -0,0 +1,18 @@\n+import React from 'react';\n+import { storiesOf } from '@storybook/react';\n+import { object } from '@storybook/addon-knobs';\n+import Dropdown from '.';\n+\n+const dropdownStories = storiesOf('Components|Dropdown', module);\n+\n+// eslint-disable-next-line import/prefer-default-export\n+export const dropdownOptions = [","path":"src/components/Dropdown/index.stories.js","position":9,"original_position":9,"commit_id":"9efa7ac7a936d00f488421da7c1c3802216f6d64","original_commit_id":"9efa7ac7a936d00f488421da7c1c3802216f6d64","user":{"login":"JulienKode","id":7658664,"node_id":"MDQ6VXNlcjc2NTg2NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7658664?v=4","gravatar_id":"","url":"https://api.github.com/users/JulienKode","html_url":"https://github.com/JulienKode","followers_url":"https://api.github.com/users/JulienKode/followers","following_url":"https://api.github.com/users/JulienKode/following{/other_user}","gists_url":"https://api.github.com/users/JulienKode/gists{/gist_id}","starred_url":"https://api.github.com/users/JulienKode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulienKode/subscriptions","organizations_url":"https://api.github.com/users/JulienKode/orgs","repos_url":"https://api.github.com/users/JulienKode/repos","events_url":"https://api.github.com/users/JulienKode/events{/privacy}","received_events_url":"https://api.github.com/users/JulienKode/received_events","type":"User","site_admin":false},"body":"Should we move this variable to a mock file ? ","created_at":"2019-07-18T13:13:28Z","updated_at":"2019-07-18T13:15:43Z","html_url":"https://github.com/EurosportDigital/web-toolkit/pull/252#discussion_r304909138","pull_request_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/comments/304909138"},"html":{"href":"https://github.com/EurosportDigital/web-toolkit/pull/252#discussion_r304909138"},"pull_request":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252"}}},"pull_request":{"url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252","id":298055096,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4MDU1MDk2","html_url":"https://github.com/EurosportDigital/web-toolkit/pull/252","diff_url":"https://github.com/EurosportDigital/web-toolkit/pull/252.diff","patch_url":"https://github.com/EurosportDigital/web-toolkit/pull/252.patch","issue_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/252","number":252,"state":"open","locked":false,"title":"Ewl 824 create dropdown menu","user":{"login":"degouville","id":6653988,"node_id":"MDQ6VXNlcjY2NTM5ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/6653988?v=4","gravatar_id":"","url":"https://api.github.com/users/degouville","html_url":"https://github.com/degouville","followers_url":"https://api.github.com/users/degouville/followers","following_url":"https://api.github.com/users/degouville/following{/other_user}","gists_url":"https://api.github.com/users/degouville/gists{/gist_id}","starred_url":"https://api.github.com/users/degouville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degouville/subscriptions","organizations_url":"https://api.github.com/users/degouville/orgs","repos_url":"https://api.github.com/users/degouville/repos","events_url":"https://api.github.com/users/degouville/events{/privacy}","received_events_url":"https://api.github.com/users/degouville/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-16T13:59:10Z","updated_at":"2019-07-18T13:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a09485741f6c9676829ee1534b027363035e1a2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"saad-kh","id":6632035,"node_id":"MDQ6VXNlcjY2MzIwMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6632035?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-kh","html_url":"https://github.com/saad-kh","followers_url":"https://api.github.com/users/saad-kh/followers","following_url":"https://api.github.com/users/saad-kh/following{/other_user}","gists_url":"https://api.github.com/users/saad-kh/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-kh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-kh/subscriptions","organizations_url":"https://api.github.com/users/saad-kh/orgs","repos_url":"https://api.github.com/users/saad-kh/repos","events_url":"https://api.github.com/users/saad-kh/events{/privacy}","received_events_url":"https://api.github.com/users/saad-kh/received_events","type":"User","site_admin":false},{"login":"davidgarry","id":10500507,"node_id":"MDQ6VXNlcjEwNTAwNTA3","avatar_url":"https://avatars0.githubusercontent.com/u/10500507?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgarry","html_url":"https://github.com/davidgarry","followers_url":"https://api.github.com/users/davidgarry/followers","following_url":"https://api.github.com/users/davidgarry/following{/other_user}","gists_url":"https://api.github.com/users/davidgarry/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgarry/subscriptions","organizations_url":"https://api.github.com/users/davidgarry/orgs","repos_url":"https://api.github.com/users/davidgarry/repos","events_url":"https://api.github.com/users/davidgarry/events{/privacy}","received_events_url":"https://api.github.com/users/davidgarry/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252/commits","review_comments_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252/comments","review_comment_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/252/comments","statuses_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/statuses/9efa7ac7a936d00f488421da7c1c3802216f6d64","head":{"label":"EurosportDigital:EWL-824-create-dropdown-menu","ref":"EWL-824-create-dropdown-menu","sha":"9efa7ac7a936d00f488421da7c1c3802216f6d64","user":{"login":"EurosportDigital","id":29923854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTIzODU0","avatar_url":"https://avatars1.githubusercontent.com/u/29923854?v=4","gravatar_id":"","url":"https://api.github.com/users/EurosportDigital","html_url":"https://github.com/EurosportDigital","followers_url":"https://api.github.com/users/EurosportDigital/followers","following_url":"https://api.github.com/users/EurosportDigital/following{/other_user}","gists_url":"https://api.github.com/users/EurosportDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/EurosportDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EurosportDigital/subscriptions","organizations_url":"https://api.github.com/users/EurosportDigital/orgs","repos_url":"https://api.github.com/users/EurosportDigital/repos","events_url":"https://api.github.com/users/EurosportDigital/events{/privacy}","received_events_url":"https://api.github.com/users/EurosportDigital/received_events","type":"Organization","site_admin":false},"repo":{"id":153429805,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0Mjk4MDU=","name":"web-toolkit","full_name":"EurosportDigital/web-toolkit","private":false,"owner":{"login":"EurosportDigital","id":29923854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTIzODU0","avatar_url":"https://avatars1.githubusercontent.com/u/29923854?v=4","gravatar_id":"","url":"https://api.github.com/users/EurosportDigital","html_url":"https://github.com/EurosportDigital","followers_url":"https://api.github.com/users/EurosportDigital/followers","following_url":"https://api.github.com/users/EurosportDigital/following{/other_user}","gists_url":"https://api.github.com/users/EurosportDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/EurosportDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EurosportDigital/subscriptions","organizations_url":"https://api.github.com/users/EurosportDigital/orgs","repos_url":"https://api.github.com/users/EurosportDigital/repos","events_url":"https://api.github.com/users/EurosportDigital/events{/privacy}","received_events_url":"https://api.github.com/users/EurosportDigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EurosportDigital/web-toolkit","description":"Eurosport Web Toolkit","fork":false,"url":"https://api.github.com/repos/EurosportDigital/web-toolkit","forks_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/forks","keys_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/teams","hooks_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/hooks","issue_events_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/events","assignees_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/tags","blobs_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/languages","stargazers_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/stargazers","contributors_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/contributors","subscribers_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/subscribers","subscription_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/subscription","commits_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/merges","archive_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/downloads","issues_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/deployments","created_at":"2018-10-17T09:21:22Z","updated_at":"2019-07-18T09:45:48Z","pushed_at":"2019-07-18T12:31:24Z","git_url":"git://github.com/EurosportDigital/web-toolkit.git","ssh_url":"git@github.com:EurosportDigital/web-toolkit.git","clone_url":"https://github.com/EurosportDigital/web-toolkit.git","svn_url":"https://github.com/EurosportDigital/web-toolkit","homepage":"https://es-web-toolkit.netlify.com","size":2508,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":null,"forks":2,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"EurosportDigital:master","ref":"master","sha":"52f479b3baa1d4b57bcf9612f7330758de4cd200","user":{"login":"EurosportDigital","id":29923854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTIzODU0","avatar_url":"https://avatars1.githubusercontent.com/u/29923854?v=4","gravatar_id":"","url":"https://api.github.com/users/EurosportDigital","html_url":"https://github.com/EurosportDigital","followers_url":"https://api.github.com/users/EurosportDigital/followers","following_url":"https://api.github.com/users/EurosportDigital/following{/other_user}","gists_url":"https://api.github.com/users/EurosportDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/EurosportDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EurosportDigital/subscriptions","organizations_url":"https://api.github.com/users/EurosportDigital/orgs","repos_url":"https://api.github.com/users/EurosportDigital/repos","events_url":"https://api.github.com/users/EurosportDigital/events{/privacy}","received_events_url":"https://api.github.com/users/EurosportDigital/received_events","type":"Organization","site_admin":false},"repo":{"id":153429805,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0Mjk4MDU=","name":"web-toolkit","full_name":"EurosportDigital/web-toolkit","private":false,"owner":{"login":"EurosportDigital","id":29923854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTIzODU0","avatar_url":"https://avatars1.githubusercontent.com/u/29923854?v=4","gravatar_id":"","url":"https://api.github.com/users/EurosportDigital","html_url":"https://github.com/EurosportDigital","followers_url":"https://api.github.com/users/EurosportDigital/followers","following_url":"https://api.github.com/users/EurosportDigital/following{/other_user}","gists_url":"https://api.github.com/users/EurosportDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/EurosportDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EurosportDigital/subscriptions","organizations_url":"https://api.github.com/users/EurosportDigital/orgs","repos_url":"https://api.github.com/users/EurosportDigital/repos","events_url":"https://api.github.com/users/EurosportDigital/events{/privacy}","received_events_url":"https://api.github.com/users/EurosportDigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EurosportDigital/web-toolkit","description":"Eurosport Web Toolkit","fork":false,"url":"https://api.github.com/repos/EurosportDigital/web-toolkit","forks_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/forks","keys_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/teams","hooks_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/hooks","issue_events_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/events","assignees_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/tags","blobs_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/languages","stargazers_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/stargazers","contributors_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/contributors","subscribers_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/subscribers","subscription_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/subscription","commits_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/merges","archive_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/downloads","issues_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/EurosportDigital/web-toolkit/deployments","created_at":"2018-10-17T09:21:22Z","updated_at":"2019-07-18T09:45:48Z","pushed_at":"2019-07-18T12:31:24Z","git_url":"git://github.com/EurosportDigital/web-toolkit.git","ssh_url":"git@github.com:EurosportDigital/web-toolkit.git","clone_url":"https://github.com/EurosportDigital/web-toolkit.git","svn_url":"https://github.com/EurosportDigital/web-toolkit","homepage":"https://es-web-toolkit.netlify.com","size":2508,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":null,"forks":2,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252"},"html":{"href":"https://github.com/EurosportDigital/web-toolkit/pull/252"},"issue":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/252"},"comments":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/EurosportDigital/web-toolkit/statuses/9efa7ac7a936d00f488421da7c1c3802216f6d64"}},"author_association":"NONE"}}
|
{
"id": 153429805,
"name": "EurosportDigital/web-toolkit",
"url": "https://api.github.com/repos/EurosportDigital/web-toolkit"
}
|
{
"id": 7658664,
"login": "JulienKode",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7658664?",
"url": "https://api.github.com/users/JulienKode"
}
|
{
"id": 29923854,
"login": "EurosportDigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29923854?",
"url": "https://api.github.com/orgs/EurosportDigital"
}
| 2019-07-18T13:13:28 |
10037476758
|
{"actor":{"display_login":"JulienKode"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gitpoint/git-point/pulls/comments/336053262","pull_request_review_id":303319526,"id":336053262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjA1MzI2Mg==","diff_hunk":"@@ -143,7 +143,7 @@ class Commit extends Component {\n {!!commit.author && (\n <View style={styles.header}>\n <Text>\n- <FieldTitle>{t('Author: ', locale)}</FieldTitle>\n+ <FieldTitle>{`${t('Author', locale)}: `}</FieldTitle>","path":"src/repository/screens/commit.screen.js","position":5,"original_position":5,"commit_id":"32769b34f0c6ae54030e63dfd0cdb21193d1f8a4","original_commit_id":"32769b34f0c6ae54030e63dfd0cdb21193d1f8a4","user":{"login":"nersoh","id":1930729,"node_id":"MDQ6VXNlcjE5MzA3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1930729?v=4","gravatar_id":"","url":"https://api.github.com/users/nersoh","html_url":"https://github.com/nersoh","followers_url":"https://api.github.com/users/nersoh/followers","following_url":"https://api.github.com/users/nersoh/following{/other_user}","gists_url":"https://api.github.com/users/nersoh/gists{/gist_id}","starred_url":"https://api.github.com/users/nersoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nersoh/subscriptions","organizations_url":"https://api.github.com/users/nersoh/orgs","repos_url":"https://api.github.com/users/nersoh/repos","events_url":"https://api.github.com/users/nersoh/events{/privacy}","received_events_url":"https://api.github.com/users/nersoh/received_events","type":"User","site_admin":false},"body":"Currently, for example, it looks for `'Author: '` (including colon and space) instead of 'Author' , so it doesn't return the correct translation.","created_at":"2019-10-17T14:52:04Z","updated_at":"2019-10-17T14:52:05Z","html_url":"https://github.com/gitpoint/git-point/pull/896#discussion_r336053262","pull_request_url":"https://api.github.com/repos/gitpoint/git-point/pulls/896","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/comments/336053262"},"html":{"href":"https://github.com/gitpoint/git-point/pull/896#discussion_r336053262"},"pull_request":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/896"}},"in_reply_to_id":336043864},"pull_request":{"url":"https://api.github.com/repos/gitpoint/git-point/pulls/896","id":329196806,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MTk2ODA2","html_url":"https://github.com/gitpoint/git-point/pull/896","diff_url":"https://github.com/gitpoint/git-point/pull/896.diff","patch_url":"https://github.com/gitpoint/git-point/pull/896.patch","issue_url":"https://api.github.com/repos/gitpoint/git-point/issues/896","number":896,"state":"open","locked":false,"title":"fix: Update locale text for pt-Br and commit screen keys","user":{"login":"nersoh","id":1930729,"node_id":"MDQ6VXNlcjE5MzA3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1930729?v=4","gravatar_id":"","url":"https://api.github.com/users/nersoh","html_url":"https://github.com/nersoh","followers_url":"https://api.github.com/users/nersoh/followers","following_url":"https://api.github.com/users/nersoh/following{/other_user}","gists_url":"https://api.github.com/users/nersoh/gists{/gist_id}","starred_url":"https://api.github.com/users/nersoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nersoh/subscriptions","organizations_url":"https://api.github.com/users/nersoh/orgs","repos_url":"https://api.github.com/users/nersoh/repos","events_url":"https://api.github.com/users/nersoh/events{/privacy}","received_events_url":"https://api.github.com/users/nersoh/received_events","type":"User","site_admin":false},"body":"<!--\r\n Bonjour!\r\n\r\n We can't express how grateful we are that you're working on making GitPoint\r\n better! We're thrilled to take a look at the changes you've made and merge\r\n them in as soon as possible. Please fill out this template to make the\r\n reviewal process as quick and smooth as possible. In addition, please make\r\n sure you remember to add yourself to the contributors list with the following\r\n command:\r\n\r\n $ yarn contributors:add\r\n\r\n Make sure the title of your PR follows our commit style guidelines (see other\r\n open PR's for reference if you're confused):\r\n\r\n https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines\r\n\r\n Thanks again for your hard work!\r\n-->\r\n\r\n| Question | Response |\r\n| ---------------- | ----------- |\r\n| Version? | |\r\n| Devices tested? | |\r\n| Bug fix? | yes |\r\n| New feature? | no |\r\n| Includes tests? | no |\r\n| All Tests pass? | yes |\r\n| Related ticket? | |\r\n\r\n---\r\n\r\n\r\n<!--\r\n Replace the images in the table below with screenshots of your changes before\r\n and after. If this is not applicable (i.e. absolutely NO visual changes), feel\r\n free to delete this section.\r\n-->\r\n\r\n## Description\r\nSome translation keys for **ptBr** updated. Also translation keys on commit screen were mismatched, so they're fixed as well.\r\n<!--\r\n What changes did you make?\r\n-->\r\n\r\n\r\n<!-- DO NOT MODIFY BELOW THIS LINE -->\r\n<!-- ----------------------------- -->\r\n<!-- GITPOINT_PR -->\r\n","created_at":"2019-10-17T10:59:42Z","updated_at":"2019-10-17T14:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b30e352da2fea6fd043e6981f9b54ec09d3c780d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gitpoint/git-point/pulls/896/commits","review_comments_url":"https://api.github.com/repos/gitpoint/git-point/pulls/896/comments","review_comment_url":"https://api.github.com/repos/gitpoint/git-point/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitpoint/git-point/issues/896/comments","statuses_url":"https://api.github.com/repos/gitpoint/git-point/statuses/32769b34f0c6ae54030e63dfd0cdb21193d1f8a4","head":{"label":"nersoh:fix/translation","ref":"fix/translation","sha":"32769b34f0c6ae54030e63dfd0cdb21193d1f8a4","user":{"login":"nersoh","id":1930729,"node_id":"MDQ6VXNlcjE5MzA3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1930729?v=4","gravatar_id":"","url":"https://api.github.com/users/nersoh","html_url":"https://github.com/nersoh","followers_url":"https://api.github.com/users/nersoh/followers","following_url":"https://api.github.com/users/nersoh/following{/other_user}","gists_url":"https://api.github.com/users/nersoh/gists{/gist_id}","starred_url":"https://api.github.com/users/nersoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nersoh/subscriptions","organizations_url":"https://api.github.com/users/nersoh/orgs","repos_url":"https://api.github.com/users/nersoh/repos","events_url":"https://api.github.com/users/nersoh/events{/privacy}","received_events_url":"https://api.github.com/users/nersoh/received_events","type":"User","site_admin":false},"repo":{"id":102913482,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MTM0ODI=","name":"git-point","full_name":"nersoh/git-point","private":false,"owner":{"login":"nersoh","id":1930729,"node_id":"MDQ6VXNlcjE5MzA3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1930729?v=4","gravatar_id":"","url":"https://api.github.com/users/nersoh","html_url":"https://github.com/nersoh","followers_url":"https://api.github.com/users/nersoh/followers","following_url":"https://api.github.com/users/nersoh/following{/other_user}","gists_url":"https://api.github.com/users/nersoh/gists{/gist_id}","starred_url":"https://api.github.com/users/nersoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nersoh/subscriptions","organizations_url":"https://api.github.com/users/nersoh/orgs","repos_url":"https://api.github.com/users/nersoh/repos","events_url":"https://api.github.com/users/nersoh/events{/privacy}","received_events_url":"https://api.github.com/users/nersoh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nersoh/git-point","description":"GitHub in your pocket :iphone:","fork":true,"url":"https://api.github.com/repos/nersoh/git-point","forks_url":"https://api.github.com/repos/nersoh/git-point/forks","keys_url":"https://api.github.com/repos/nersoh/git-point/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nersoh/git-point/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nersoh/git-point/teams","hooks_url":"https://api.github.com/repos/nersoh/git-point/hooks","issue_events_url":"https://api.github.com/repos/nersoh/git-point/issues/events{/number}","events_url":"https://api.github.com/repos/nersoh/git-point/events","assignees_url":"https://api.github.com/repos/nersoh/git-point/assignees{/user}","branches_url":"https://api.github.com/repos/nersoh/git-point/branches{/branch}","tags_url":"https://api.github.com/repos/nersoh/git-point/tags","blobs_url":"https://api.github.com/repos/nersoh/git-point/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nersoh/git-point/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nersoh/git-point/git/refs{/sha}","trees_url":"https://api.github.com/repos/nersoh/git-point/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nersoh/git-point/statuses/{sha}","languages_url":"https://api.github.com/repos/nersoh/git-point/languages","stargazers_url":"https://api.github.com/repos/nersoh/git-point/stargazers","contributors_url":"https://api.github.com/repos/nersoh/git-point/contributors","subscribers_url":"https://api.github.com/repos/nersoh/git-point/subscribers","subscription_url":"https://api.github.com/repos/nersoh/git-point/subscription","commits_url":"https://api.github.com/repos/nersoh/git-point/commits{/sha}","git_commits_url":"https://api.github.com/repos/nersoh/git-point/git/commits{/sha}","comments_url":"https://api.github.com/repos/nersoh/git-point/comments{/number}","issue_comment_url":"https://api.github.com/repos/nersoh/git-point/issues/comments{/number}","contents_url":"https://api.github.com/repos/nersoh/git-point/contents/{+path}","compare_url":"https://api.github.com/repos/nersoh/git-point/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nersoh/git-point/merges","archive_url":"https://api.github.com/repos/nersoh/git-point/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nersoh/git-point/downloads","issues_url":"https://api.github.com/repos/nersoh/git-point/issues{/number}","pulls_url":"https://api.github.com/repos/nersoh/git-point/pulls{/number}","milestones_url":"https://api.github.com/repos/nersoh/git-point/milestones{/number}","notifications_url":"https://api.github.com/repos/nersoh/git-point/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nersoh/git-point/labels{/name}","releases_url":"https://api.github.com/repos/nersoh/git-point/releases{/id}","deployments_url":"https://api.github.com/repos/nersoh/git-point/deployments","created_at":"2017-09-08T23:51:41Z","updated_at":"2019-10-11T21:25:20Z","pushed_at":"2019-10-17T10:54:08Z","git_url":"git://github.com/nersoh/git-point.git","ssh_url":"git@github.com:nersoh/git-point.git","clone_url":"https://github.com/nersoh/git-point.git","svn_url":"https://github.com/nersoh/git-point","homepage":"https://gitpoint.co/","size":5771,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitpoint:master","ref":"master","sha":"5ba80f5180e86523ec56d59a90eb494fea51e2dd","user":{"login":"gitpoint","id":30082377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDgyMzc3","avatar_url":"https://avatars0.githubusercontent.com/u/30082377?v=4","gravatar_id":"","url":"https://api.github.com/users/gitpoint","html_url":"https://github.com/gitpoint","followers_url":"https://api.github.com/users/gitpoint/followers","following_url":"https://api.github.com/users/gitpoint/following{/other_user}","gists_url":"https://api.github.com/users/gitpoint/gists{/gist_id}","starred_url":"https://api.github.com/users/gitpoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitpoint/subscriptions","organizations_url":"https://api.github.com/users/gitpoint/orgs","repos_url":"https://api.github.com/users/gitpoint/repos","events_url":"https://api.github.com/users/gitpoint/events{/privacy}","received_events_url":"https://api.github.com/users/gitpoint/received_events","type":"Organization","site_admin":false},"repo":{"id":86202845,"node_id":"MDEwOlJlcG9zaXRvcnk4NjIwMjg0NQ==","name":"git-point","full_name":"gitpoint/git-point","private":false,"owner":{"login":"gitpoint","id":30082377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDgyMzc3","avatar_url":"https://avatars0.githubusercontent.com/u/30082377?v=4","gravatar_id":"","url":"https://api.github.com/users/gitpoint","html_url":"https://github.com/gitpoint","followers_url":"https://api.github.com/users/gitpoint/followers","following_url":"https://api.github.com/users/gitpoint/following{/other_user}","gists_url":"https://api.github.com/users/gitpoint/gists{/gist_id}","starred_url":"https://api.github.com/users/gitpoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitpoint/subscriptions","organizations_url":"https://api.github.com/users/gitpoint/orgs","repos_url":"https://api.github.com/users/gitpoint/repos","events_url":"https://api.github.com/users/gitpoint/events{/privacy}","received_events_url":"https://api.github.com/users/gitpoint/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gitpoint/git-point","description":"GitHub in your pocket :iphone:","fork":false,"url":"https://api.github.com/repos/gitpoint/git-point","forks_url":"https://api.github.com/repos/gitpoint/git-point/forks","keys_url":"https://api.github.com/repos/gitpoint/git-point/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitpoint/git-point/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitpoint/git-point/teams","hooks_url":"https://api.github.com/repos/gitpoint/git-point/hooks","issue_events_url":"https://api.github.com/repos/gitpoint/git-point/issues/events{/number}","events_url":"https://api.github.com/repos/gitpoint/git-point/events","assignees_url":"https://api.github.com/repos/gitpoint/git-point/assignees{/user}","branches_url":"https://api.github.com/repos/gitpoint/git-point/branches{/branch}","tags_url":"https://api.github.com/repos/gitpoint/git-point/tags","blobs_url":"https://api.github.com/repos/gitpoint/git-point/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitpoint/git-point/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitpoint/git-point/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitpoint/git-point/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitpoint/git-point/statuses/{sha}","languages_url":"https://api.github.com/repos/gitpoint/git-point/languages","stargazers_url":"https://api.github.com/repos/gitpoint/git-point/stargazers","contributors_url":"https://api.github.com/repos/gitpoint/git-point/contributors","subscribers_url":"https://api.github.com/repos/gitpoint/git-point/subscribers","subscription_url":"https://api.github.com/repos/gitpoint/git-point/subscription","commits_url":"https://api.github.com/repos/gitpoint/git-point/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitpoint/git-point/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitpoint/git-point/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitpoint/git-point/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitpoint/git-point/contents/{+path}","compare_url":"https://api.github.com/repos/gitpoint/git-point/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitpoint/git-point/merges","archive_url":"https://api.github.com/repos/gitpoint/git-point/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitpoint/git-point/downloads","issues_url":"https://api.github.com/repos/gitpoint/git-point/issues{/number}","pulls_url":"https://api.github.com/repos/gitpoint/git-point/pulls{/number}","milestones_url":"https://api.github.com/repos/gitpoint/git-point/milestones{/number}","notifications_url":"https://api.github.com/repos/gitpoint/git-point/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitpoint/git-point/labels{/name}","releases_url":"https://api.github.com/repos/gitpoint/git-point/releases{/id}","deployments_url":"https://api.github.com/repos/gitpoint/git-point/deployments","created_at":"2017-03-26T02:45:46Z","updated_at":"2019-10-17T14:21:07Z","pushed_at":"2019-10-17T14:21:04Z","git_url":"git://github.com/gitpoint/git-point.git","ssh_url":"git@github.com:gitpoint/git-point.git","clone_url":"https://github.com/gitpoint/git-point.git","svn_url":"https://github.com/gitpoint/git-point","homepage":"https://gitpoint.co/","size":5711,"stargazers_count":4282,"watchers_count":4282,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":612,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":612,"open_issues":117,"watchers":4282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/896"},"html":{"href":"https://github.com/gitpoint/git-point/pull/896"},"issue":{"href":"https://api.github.com/repos/gitpoint/git-point/issues/896"},"comments":{"href":"https://api.github.com/repos/gitpoint/git-point/issues/896/comments"},"review_comments":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/896/comments"},"review_comment":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/896/commits"},"statuses":{"href":"https://api.github.com/repos/gitpoint/git-point/statuses/32769b34f0c6ae54030e63dfd0cdb21193d1f8a4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 86202845,
"name": "gitpoint/git-point",
"url": "https://api.github.com/repos/gitpoint/git-point"
}
|
{
"id": 1930729,
"login": "nersoh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1930729?",
"url": "https://api.github.com/users/nersoh"
}
|
{
"id": 30082377,
"login": "gitpoint",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30082377?",
"url": "https://api.github.com/orgs/gitpoint"
}
| 2019-10-17T14:52:04 |
10653698548
|
{"actor":{"display_login":"nersoh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pluswerk/docker-global/pulls/comments/343048641","pull_request_review_id":312365907,"id":343048641,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzA0ODY0MQ==","diff_hunk":"@@ -0,0 +1,42 @@\n+<?php\r\n+\r\n+require_once(\"DataProcessor.php\");\r\n+\r\n+$containerDataProcessor = new DataProcessor();\r\n+$data = $containerDataProcessor->process();\r\n+\r\n+$tbodyData = '';\r\n+foreach ($data as $dataEntry) {\r\n+ if (count($dataEntry['domains']) < 1) {\r\n+ $tbodyData .= '<tr><td>' . $dataEntry['name'] . '</td><td>' . $dataEntry['domains'][0] . '</td></tr>';\r","path":"dashboard/index.php","position":11,"original_position":11,"commit_id":"33dbc6165d7c5f25c28b7047644fb15384fef9a8","original_commit_id":"33dbc6165d7c5f25c28b7047644fb15384fef9a8","user":{"login":"ChrisB9","id":7099583,"node_id":"MDQ6VXNlcjcwOTk1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/7099583?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisB9","html_url":"https://github.com/ChrisB9","followers_url":"https://api.github.com/users/ChrisB9/followers","following_url":"https://api.github.com/users/ChrisB9/following{/other_user}","gists_url":"https://api.github.com/users/ChrisB9/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisB9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisB9/subscriptions","organizations_url":"https://api.github.com/users/ChrisB9/orgs","repos_url":"https://api.github.com/users/ChrisB9/repos","events_url":"https://api.github.com/users/ChrisB9/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisB9/received_events","type":"User","site_admin":false},"body":"if count is smaller than 1, then index 0 is not given\r\n+ plus, you dont need to check this, as a foreach already gives you all necessary information about emptiness","created_at":"2019-11-06T11:37:34Z","updated_at":"2019-11-06T11:39:22Z","html_url":"https://github.com/pluswerk/docker-global/pull/26#discussion_r343048641","pull_request_url":"https://api.github.com/repos/pluswerk/docker-global/pulls/26","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pluswerk/docker-global/pulls/comments/343048641"},"html":{"href":"https://github.com/pluswerk/docker-global/pull/26#discussion_r343048641"},"pull_request":{"href":"https://api.github.com/repos/pluswerk/docker-global/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/pluswerk/docker-global/pulls/26","id":336238330,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2MjM4MzMw","html_url":"https://github.com/pluswerk/docker-global/pull/26","diff_url":"https://github.com/pluswerk/docker-global/pull/26.diff","patch_url":"https://github.com/pluswerk/docker-global/pull/26.patch","issue_url":"https://api.github.com/repos/pluswerk/docker-global/issues/26","number":26,"state":"open","locked":false,"title":"[FEATURE] add lightweight docker dashboard v0.1","user":{"login":"DenisCherean","id":20017674,"node_id":"MDQ6VXNlcjIwMDE3Njc0","avatar_url":"https://avatars3.githubusercontent.com/u/20017674?v=4","gravatar_id":"","url":"https://api.github.com/users/DenisCherean","html_url":"https://github.com/DenisCherean","followers_url":"https://api.github.com/users/DenisCherean/followers","following_url":"https://api.github.com/users/DenisCherean/following{/other_user}","gists_url":"https://api.github.com/users/DenisCherean/gists{/gist_id}","starred_url":"https://api.github.com/users/DenisCherean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenisCherean/subscriptions","organizations_url":"https://api.github.com/users/DenisCherean/orgs","repos_url":"https://api.github.com/users/DenisCherean/repos","events_url":"https://api.github.com/users/DenisCherean/events{/privacy}","received_events_url":"https://api.github.com/users/DenisCherean/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-04T11:55:14Z","updated_at":"2019-11-06T11:39:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e6c476266412daeebe057673205c46488e11de0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pluswerk/docker-global/pulls/26/commits","review_comments_url":"https://api.github.com/repos/pluswerk/docker-global/pulls/26/comments","review_comment_url":"https://api.github.com/repos/pluswerk/docker-global/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pluswerk/docker-global/issues/26/comments","statuses_url":"https://api.github.com/repos/pluswerk/docker-global/statuses/33dbc6165d7c5f25c28b7047644fb15384fef9a8","head":{"label":"DenisCherean:master","ref":"master","sha":"33dbc6165d7c5f25c28b7047644fb15384fef9a8","user":{"login":"DenisCherean","id":20017674,"node_id":"MDQ6VXNlcjIwMDE3Njc0","avatar_url":"https://avatars3.githubusercontent.com/u/20017674?v=4","gravatar_id":"","url":"https://api.github.com/users/DenisCherean","html_url":"https://github.com/DenisCherean","followers_url":"https://api.github.com/users/DenisCherean/followers","following_url":"https://api.github.com/users/DenisCherean/following{/other_user}","gists_url":"https://api.github.com/users/DenisCherean/gists{/gist_id}","starred_url":"https://api.github.com/users/DenisCherean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenisCherean/subscriptions","organizations_url":"https://api.github.com/users/DenisCherean/orgs","repos_url":"https://api.github.com/users/DenisCherean/repos","events_url":"https://api.github.com/users/DenisCherean/events{/privacy}","received_events_url":"https://api.github.com/users/DenisCherean/received_events","type":"User","site_admin":false},"repo":{"id":212543608,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI1NDM2MDg=","name":"docker-global","full_name":"DenisCherean/docker-global","private":false,"owner":{"login":"DenisCherean","id":20017674,"node_id":"MDQ6VXNlcjIwMDE3Njc0","avatar_url":"https://avatars3.githubusercontent.com/u/20017674?v=4","gravatar_id":"","url":"https://api.github.com/users/DenisCherean","html_url":"https://github.com/DenisCherean","followers_url":"https://api.github.com/users/DenisCherean/followers","following_url":"https://api.github.com/users/DenisCherean/following{/other_user}","gists_url":"https://api.github.com/users/DenisCherean/gists{/gist_id}","starred_url":"https://api.github.com/users/DenisCherean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenisCherean/subscriptions","organizations_url":"https://api.github.com/users/DenisCherean/orgs","repos_url":"https://api.github.com/users/DenisCherean/repos","events_url":"https://api.github.com/users/DenisCherean/events{/privacy}","received_events_url":"https://api.github.com/users/DenisCherean/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DenisCherean/docker-global","description":"A Docker Setup, for web development with for many Projects","fork":true,"url":"https://api.github.com/repos/DenisCherean/docker-global","forks_url":"https://api.github.com/repos/DenisCherean/docker-global/forks","keys_url":"https://api.github.com/repos/DenisCherean/docker-global/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DenisCherean/docker-global/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DenisCherean/docker-global/teams","hooks_url":"https://api.github.com/repos/DenisCherean/docker-global/hooks","issue_events_url":"https://api.github.com/repos/DenisCherean/docker-global/issues/events{/number}","events_url":"https://api.github.com/repos/DenisCherean/docker-global/events","assignees_url":"https://api.github.com/repos/DenisCherean/docker-global/assignees{/user}","branches_url":"https://api.github.com/repos/DenisCherean/docker-global/branches{/branch}","tags_url":"https://api.github.com/repos/DenisCherean/docker-global/tags","blobs_url":"https://api.github.com/repos/DenisCherean/docker-global/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DenisCherean/docker-global/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DenisCherean/docker-global/git/refs{/sha}","trees_url":"https://api.github.com/repos/DenisCherean/docker-global/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DenisCherean/docker-global/statuses/{sha}","languages_url":"https://api.github.com/repos/DenisCherean/docker-global/languages","stargazers_url":"https://api.github.com/repos/DenisCherean/docker-global/stargazers","contributors_url":"https://api.github.com/repos/DenisCherean/docker-global/contributors","subscribers_url":"https://api.github.com/repos/DenisCherean/docker-global/subscribers","subscription_url":"https://api.github.com/repos/DenisCherean/docker-global/subscription","commits_url":"https://api.github.com/repos/DenisCherean/docker-global/commits{/sha}","git_commits_url":"https://api.github.com/repos/DenisCherean/docker-global/git/commits{/sha}","comments_url":"https://api.github.com/repos/DenisCherean/docker-global/comments{/number}","issue_comment_url":"https://api.github.com/repos/DenisCherean/docker-global/issues/comments{/number}","contents_url":"https://api.github.com/repos/DenisCherean/docker-global/contents/{+path}","compare_url":"https://api.github.com/repos/DenisCherean/docker-global/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DenisCherean/docker-global/merges","archive_url":"https://api.github.com/repos/DenisCherean/docker-global/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DenisCherean/docker-global/downloads","issues_url":"https://api.github.com/repos/DenisCherean/docker-global/issues{/number}","pulls_url":"https://api.github.com/repos/DenisCherean/docker-global/pulls{/number}","milestones_url":"https://api.github.com/repos/DenisCherean/docker-global/milestones{/number}","notifications_url":"https://api.github.com/repos/DenisCherean/docker-global/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DenisCherean/docker-global/labels{/name}","releases_url":"https://api.github.com/repos/DenisCherean/docker-global/releases{/id}","deployments_url":"https://api.github.com/repos/DenisCherean/docker-global/deployments","created_at":"2019-10-03T09:38:07Z","updated_at":"2019-11-06T09:51:07Z","pushed_at":"2019-11-06T09:51:04Z","git_url":"git://github.com/DenisCherean/docker-global.git","ssh_url":"git@github.com:DenisCherean/docker-global.git","clone_url":"https://github.com/DenisCherean/docker-global.git","svn_url":"https://github.com/DenisCherean/docker-global","homepage":null,"size":64,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pluswerk:master","ref":"master","sha":"4af3fd9042e6b63b331b045408e9314dc2b6a610","user":{"login":"pluswerk","id":30108233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTA4MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/30108233?v=4","gravatar_id":"","url":"https://api.github.com/users/pluswerk","html_url":"https://github.com/pluswerk","followers_url":"https://api.github.com/users/pluswerk/followers","following_url":"https://api.github.com/users/pluswerk/following{/other_user}","gists_url":"https://api.github.com/users/pluswerk/gists{/gist_id}","starred_url":"https://api.github.com/users/pluswerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluswerk/subscriptions","organizations_url":"https://api.github.com/users/pluswerk/orgs","repos_url":"https://api.github.com/users/pluswerk/repos","events_url":"https://api.github.com/users/pluswerk/events{/privacy}","received_events_url":"https://api.github.com/users/pluswerk/received_events","type":"Organization","site_admin":false},"repo":{"id":157842462,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4NDI0NjI=","name":"docker-global","full_name":"pluswerk/docker-global","private":false,"owner":{"login":"pluswerk","id":30108233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTA4MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/30108233?v=4","gravatar_id":"","url":"https://api.github.com/users/pluswerk","html_url":"https://github.com/pluswerk","followers_url":"https://api.github.com/users/pluswerk/followers","following_url":"https://api.github.com/users/pluswerk/following{/other_user}","gists_url":"https://api.github.com/users/pluswerk/gists{/gist_id}","starred_url":"https://api.github.com/users/pluswerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluswerk/subscriptions","organizations_url":"https://api.github.com/users/pluswerk/orgs","repos_url":"https://api.github.com/users/pluswerk/repos","events_url":"https://api.github.com/users/pluswerk/events{/privacy}","received_events_url":"https://api.github.com/users/pluswerk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pluswerk/docker-global","description":"A Docker Setup, for web development with for many Projects","fork":false,"url":"https://api.github.com/repos/pluswerk/docker-global","forks_url":"https://api.github.com/repos/pluswerk/docker-global/forks","keys_url":"https://api.github.com/repos/pluswerk/docker-global/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluswerk/docker-global/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluswerk/docker-global/teams","hooks_url":"https://api.github.com/repos/pluswerk/docker-global/hooks","issue_events_url":"https://api.github.com/repos/pluswerk/docker-global/issues/events{/number}","events_url":"https://api.github.com/repos/pluswerk/docker-global/events","assignees_url":"https://api.github.com/repos/pluswerk/docker-global/assignees{/user}","branches_url":"https://api.github.com/repos/pluswerk/docker-global/branches{/branch}","tags_url":"https://api.github.com/repos/pluswerk/docker-global/tags","blobs_url":"https://api.github.com/repos/pluswerk/docker-global/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluswerk/docker-global/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluswerk/docker-global/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluswerk/docker-global/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluswerk/docker-global/statuses/{sha}","languages_url":"https://api.github.com/repos/pluswerk/docker-global/languages","stargazers_url":"https://api.github.com/repos/pluswerk/docker-global/stargazers","contributors_url":"https://api.github.com/repos/pluswerk/docker-global/contributors","subscribers_url":"https://api.github.com/repos/pluswerk/docker-global/subscribers","subscription_url":"https://api.github.com/repos/pluswerk/docker-global/subscription","commits_url":"https://api.github.com/repos/pluswerk/docker-global/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluswerk/docker-global/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluswerk/docker-global/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluswerk/docker-global/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluswerk/docker-global/contents/{+path}","compare_url":"https://api.github.com/repos/pluswerk/docker-global/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluswerk/docker-global/merges","archive_url":"https://api.github.com/repos/pluswerk/docker-global/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluswerk/docker-global/downloads","issues_url":"https://api.github.com/repos/pluswerk/docker-global/issues{/number}","pulls_url":"https://api.github.com/repos/pluswerk/docker-global/pulls{/number}","milestones_url":"https://api.github.com/repos/pluswerk/docker-global/milestones{/number}","notifications_url":"https://api.github.com/repos/pluswerk/docker-global/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluswerk/docker-global/labels{/name}","releases_url":"https://api.github.com/repos/pluswerk/docker-global/releases{/id}","deployments_url":"https://api.github.com/repos/pluswerk/docker-global/deployments","created_at":"2018-11-16T09:15:58Z","updated_at":"2019-08-09T07:52:04Z","pushed_at":"2019-11-06T09:51:07Z","git_url":"git://github.com/pluswerk/docker-global.git","ssh_url":"git@github.com:pluswerk/docker-global.git","clone_url":"https://github.com/pluswerk/docker-global.git","svn_url":"https://github.com/pluswerk/docker-global","homepage":null,"size":60,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pluswerk/docker-global/pulls/26"},"html":{"href":"https://github.com/pluswerk/docker-global/pull/26"},"issue":{"href":"https://api.github.com/repos/pluswerk/docker-global/issues/26"},"comments":{"href":"https://api.github.com/repos/pluswerk/docker-global/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/pluswerk/docker-global/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/pluswerk/docker-global/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pluswerk/docker-global/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/pluswerk/docker-global/statuses/33dbc6165d7c5f25c28b7047644fb15384fef9a8"}},"author_association":"NONE"}}
|
{
"id": 157842462,
"name": "pluswerk/docker-global",
"url": "https://api.github.com/repos/pluswerk/docker-global"
}
|
{
"id": 7099583,
"login": "ChrisB9",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7099583?",
"url": "https://api.github.com/users/ChrisB9"
}
|
{
"id": 30108233,
"login": "pluswerk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30108233?",
"url": "https://api.github.com/orgs/pluswerk"
}
| 2019-11-06T11:37:34 |
10799207304
|
{"actor":{"display_login":"ChrisB9"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/comments/353258582","pull_request_review_id":326242979,"id":353258582,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzI1ODU4Mg==","diff_hunk":"@@ -39,7 +39,7 @@\n import java.util.stream.Collectors;\n \n import static com.github.tomakehurst.wiremock.client.WireMock.*;\n-import static org.assertj.core.api.Java6Assertions.assertThat;","path":"micrometer-core/src/test/java/io/micrometer/core/instrument/binder/httpcomponents/MicrometerHttpRequestExecutorTest.java","position":4,"original_position":4,"commit_id":"04cd54d2edb4e9a7f17d7508db4ff41791eb7a1c","original_commit_id":"04cd54d2edb4e9a7f17d7508db4ff41791eb7a1c","user":{"login":"izeye","id":1059363,"node_id":"MDQ6VXNlcjEwNTkzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1059363?v=4","gravatar_id":"","url":"https://api.github.com/users/izeye","html_url":"https://github.com/izeye","followers_url":"https://api.github.com/users/izeye/followers","following_url":"https://api.github.com/users/izeye/following{/other_user}","gists_url":"https://api.github.com/users/izeye/gists{/gist_id}","starred_url":"https://api.github.com/users/izeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izeye/subscriptions","organizations_url":"https://api.github.com/users/izeye/orgs","repos_url":"https://api.github.com/users/izeye/repos","events_url":"https://api.github.com/users/izeye/events{/privacy}","received_events_url":"https://api.github.com/users/izeye/received_events","type":"User","site_admin":false},"body":"@shakuzen Not that I know of. I created https://github.com/micrometer-metrics/micrometer/pull/1731.","created_at":"2019-12-03T15:47:48Z","updated_at":"2019-12-03T15:47:48Z","html_url":"https://github.com/micrometer-metrics/micrometer/pull/1729#discussion_r353258582","pull_request_url":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/comments/353258582"},"html":{"href":"https://github.com/micrometer-metrics/micrometer/pull/1729#discussion_r353258582"},"pull_request":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729"}},"in_reply_to_id":353007060},"pull_request":{"url":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729","id":348109478,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MTA5NDc4","html_url":"https://github.com/micrometer-metrics/micrometer/pull/1729","diff_url":"https://github.com/micrometer-metrics/micrometer/pull/1729.diff","patch_url":"https://github.com/micrometer-metrics/micrometer/pull/1729.patch","issue_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/1729","number":1729,"state":"closed","locked":false,"title":"Clean up compile warnings in 1.3.x branch","user":{"login":"izeye","id":1059363,"node_id":"MDQ6VXNlcjEwNTkzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1059363?v=4","gravatar_id":"","url":"https://api.github.com/users/izeye","html_url":"https://github.com/izeye","followers_url":"https://api.github.com/users/izeye/followers","following_url":"https://api.github.com/users/izeye/following{/other_user}","gists_url":"https://api.github.com/users/izeye/gists{/gist_id}","starred_url":"https://api.github.com/users/izeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izeye/subscriptions","organizations_url":"https://api.github.com/users/izeye/orgs","repos_url":"https://api.github.com/users/izeye/repos","events_url":"https://api.github.com/users/izeye/events{/privacy}","received_events_url":"https://api.github.com/users/izeye/received_events","type":"User","site_admin":false},"body":"This PR cleans up compile warnings in the 1.3.x branch.","created_at":"2019-12-03T04:16:08Z","updated_at":"2019-12-03T15:47:48Z","closed_at":"2019-12-03T06:47:03Z","merged_at":"2019-12-03T06:47:03Z","merge_commit_sha":"003dc29517002a538f9bf24e325706fb5177f489","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1069457862,"node_id":"MDU6TGFiZWwxMDY5NDU3ODYy","url":"https://api.github.com/repos/micrometer-metrics/micrometer/labels/polish","name":"polish","color":"beff7a","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/micrometer-metrics/micrometer/milestones/56","html_url":"https://github.com/micrometer-metrics/micrometer/milestone/56","labels_url":"https://api.github.com/repos/micrometer-metrics/micrometer/milestones/56/labels","id":4812152,"node_id":"MDk6TWlsZXN0b25lNDgxMjE1Mg==","number":56,"title":"1.3.2","description":"Includes changes from 1.1.9","creator":{"login":"shakuzen","id":8924140,"node_id":"MDQ6VXNlcjg5MjQxNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/8924140?v=4","gravatar_id":"","url":"https://api.github.com/users/shakuzen","html_url":"https://github.com/shakuzen","followers_url":"https://api.github.com/users/shakuzen/followers","following_url":"https://api.github.com/users/shakuzen/following{/other_user}","gists_url":"https://api.github.com/users/shakuzen/gists{/gist_id}","starred_url":"https://api.github.com/users/shakuzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakuzen/subscriptions","organizations_url":"https://api.github.com/users/shakuzen/orgs","repos_url":"https://api.github.com/users/shakuzen/repos","events_url":"https://api.github.com/users/shakuzen/events{/privacy}","received_events_url":"https://api.github.com/users/shakuzen/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2019-11-04T14:08:58Z","updated_at":"2019-12-03T06:47:03Z","due_on":"2019-12-03T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729/commits","review_comments_url":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729/comments","review_comment_url":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/1729/comments","statuses_url":"https://api.github.com/repos/micrometer-metrics/micrometer/statuses/04cd54d2edb4e9a7f17d7508db4ff41791eb7a1c","head":{"label":"izeye:clean-up-compile-warnings-1.3.x","ref":"clean-up-compile-warnings-1.3.x","sha":"04cd54d2edb4e9a7f17d7508db4ff41791eb7a1c","user":{"login":"izeye","id":1059363,"node_id":"MDQ6VXNlcjEwNTkzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1059363?v=4","gravatar_id":"","url":"https://api.github.com/users/izeye","html_url":"https://github.com/izeye","followers_url":"https://api.github.com/users/izeye/followers","following_url":"https://api.github.com/users/izeye/following{/other_user}","gists_url":"https://api.github.com/users/izeye/gists{/gist_id}","starred_url":"https://api.github.com/users/izeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izeye/subscriptions","organizations_url":"https://api.github.com/users/izeye/orgs","repos_url":"https://api.github.com/users/izeye/repos","events_url":"https://api.github.com/users/izeye/events{/privacy}","received_events_url":"https://api.github.com/users/izeye/received_events","type":"User","site_admin":false},"repo":{"id":111177506,"node_id":"MDEwOlJlcG9zaXRvcnkxMTExNzc1MDY=","name":"micrometer","full_name":"izeye/micrometer","private":false,"owner":{"login":"izeye","id":1059363,"node_id":"MDQ6VXNlcjEwNTkzNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1059363?v=4","gravatar_id":"","url":"https://api.github.com/users/izeye","html_url":"https://github.com/izeye","followers_url":"https://api.github.com/users/izeye/followers","following_url":"https://api.github.com/users/izeye/following{/other_user}","gists_url":"https://api.github.com/users/izeye/gists{/gist_id}","starred_url":"https://api.github.com/users/izeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izeye/subscriptions","organizations_url":"https://api.github.com/users/izeye/orgs","repos_url":"https://api.github.com/users/izeye/repos","events_url":"https://api.github.com/users/izeye/events{/privacy}","received_events_url":"https://api.github.com/users/izeye/received_events","type":"User","site_admin":false},"html_url":"https://github.com/izeye/micrometer","description":"An application metrics facade for the most popular monitoring tools.","fork":true,"url":"https://api.github.com/repos/izeye/micrometer","forks_url":"https://api.github.com/repos/izeye/micrometer/forks","keys_url":"https://api.github.com/repos/izeye/micrometer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/izeye/micrometer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/izeye/micrometer/teams","hooks_url":"https://api.github.com/repos/izeye/micrometer/hooks","issue_events_url":"https://api.github.com/repos/izeye/micrometer/issues/events{/number}","events_url":"https://api.github.com/repos/izeye/micrometer/events","assignees_url":"https://api.github.com/repos/izeye/micrometer/assignees{/user}","branches_url":"https://api.github.com/repos/izeye/micrometer/branches{/branch}","tags_url":"https://api.github.com/repos/izeye/micrometer/tags","blobs_url":"https://api.github.com/repos/izeye/micrometer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/izeye/micrometer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/izeye/micrometer/git/refs{/sha}","trees_url":"https://api.github.com/repos/izeye/micrometer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/izeye/micrometer/statuses/{sha}","languages_url":"https://api.github.com/repos/izeye/micrometer/languages","stargazers_url":"https://api.github.com/repos/izeye/micrometer/stargazers","contributors_url":"https://api.github.com/repos/izeye/micrometer/contributors","subscribers_url":"https://api.github.com/repos/izeye/micrometer/subscribers","subscription_url":"https://api.github.com/repos/izeye/micrometer/subscription","commits_url":"https://api.github.com/repos/izeye/micrometer/commits{/sha}","git_commits_url":"https://api.github.com/repos/izeye/micrometer/git/commits{/sha}","comments_url":"https://api.github.com/repos/izeye/micrometer/comments{/number}","issue_comment_url":"https://api.github.com/repos/izeye/micrometer/issues/comments{/number}","contents_url":"https://api.github.com/repos/izeye/micrometer/contents/{+path}","compare_url":"https://api.github.com/repos/izeye/micrometer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/izeye/micrometer/merges","archive_url":"https://api.github.com/repos/izeye/micrometer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/izeye/micrometer/downloads","issues_url":"https://api.github.com/repos/izeye/micrometer/issues{/number}","pulls_url":"https://api.github.com/repos/izeye/micrometer/pulls{/number}","milestones_url":"https://api.github.com/repos/izeye/micrometer/milestones{/number}","notifications_url":"https://api.github.com/repos/izeye/micrometer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/izeye/micrometer/labels{/name}","releases_url":"https://api.github.com/repos/izeye/micrometer/releases{/id}","deployments_url":"https://api.github.com/repos/izeye/micrometer/deployments","created_at":"2017-11-18T04:50:41Z","updated_at":"2018-12-16T00:06:26Z","pushed_at":"2019-12-03T15:46:11Z","git_url":"git://github.com/izeye/micrometer.git","ssh_url":"git@github.com:izeye/micrometer.git","clone_url":"https://github.com/izeye/micrometer.git","svn_url":"https://github.com/izeye/micrometer","homepage":"http://micrometer.io","size":17495,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micrometer-metrics:1.3.x","ref":"1.3.x","sha":"346bfd4aa8246843c8692942feebdd14355c62af","user":{"login":"micrometer-metrics","id":30124485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/30124485?v=4","gravatar_id":"","url":"https://api.github.com/users/micrometer-metrics","html_url":"https://github.com/micrometer-metrics","followers_url":"https://api.github.com/users/micrometer-metrics/followers","following_url":"https://api.github.com/users/micrometer-metrics/following{/other_user}","gists_url":"https://api.github.com/users/micrometer-metrics/gists{/gist_id}","starred_url":"https://api.github.com/users/micrometer-metrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micrometer-metrics/subscriptions","organizations_url":"https://api.github.com/users/micrometer-metrics/orgs","repos_url":"https://api.github.com/users/micrometer-metrics/repos","events_url":"https://api.github.com/users/micrometer-metrics/events{/privacy}","received_events_url":"https://api.github.com/users/micrometer-metrics/received_events","type":"Organization","site_admin":false},"repo":{"id":87859908,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzg1OTkwOA==","name":"micrometer","full_name":"micrometer-metrics/micrometer","private":false,"owner":{"login":"micrometer-metrics","id":30124485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI0NDg1","avatar_url":"https://avatars0.githubusercontent.com/u/30124485?v=4","gravatar_id":"","url":"https://api.github.com/users/micrometer-metrics","html_url":"https://github.com/micrometer-metrics","followers_url":"https://api.github.com/users/micrometer-metrics/followers","following_url":"https://api.github.com/users/micrometer-metrics/following{/other_user}","gists_url":"https://api.github.com/users/micrometer-metrics/gists{/gist_id}","starred_url":"https://api.github.com/users/micrometer-metrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micrometer-metrics/subscriptions","organizations_url":"https://api.github.com/users/micrometer-metrics/orgs","repos_url":"https://api.github.com/users/micrometer-metrics/repos","events_url":"https://api.github.com/users/micrometer-metrics/events{/privacy}","received_events_url":"https://api.github.com/users/micrometer-metrics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/micrometer-metrics/micrometer","description":"An application metrics facade for the most popular monitoring tools. Think SLF4J, but for metrics.","fork":false,"url":"https://api.github.com/repos/micrometer-metrics/micrometer","forks_url":"https://api.github.com/repos/micrometer-metrics/micrometer/forks","keys_url":"https://api.github.com/repos/micrometer-metrics/micrometer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micrometer-metrics/micrometer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micrometer-metrics/micrometer/teams","hooks_url":"https://api.github.com/repos/micrometer-metrics/micrometer/hooks","issue_events_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/events{/number}","events_url":"https://api.github.com/repos/micrometer-metrics/micrometer/events","assignees_url":"https://api.github.com/repos/micrometer-metrics/micrometer/assignees{/user}","branches_url":"https://api.github.com/repos/micrometer-metrics/micrometer/branches{/branch}","tags_url":"https://api.github.com/repos/micrometer-metrics/micrometer/tags","blobs_url":"https://api.github.com/repos/micrometer-metrics/micrometer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micrometer-metrics/micrometer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micrometer-metrics/micrometer/git/refs{/sha}","trees_url":"https://api.github.com/repos/micrometer-metrics/micrometer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micrometer-metrics/micrometer/statuses/{sha}","languages_url":"https://api.github.com/repos/micrometer-metrics/micrometer/languages","stargazers_url":"https://api.github.com/repos/micrometer-metrics/micrometer/stargazers","contributors_url":"https://api.github.com/repos/micrometer-metrics/micrometer/contributors","subscribers_url":"https://api.github.com/repos/micrometer-metrics/micrometer/subscribers","subscription_url":"https://api.github.com/repos/micrometer-metrics/micrometer/subscription","commits_url":"https://api.github.com/repos/micrometer-metrics/micrometer/commits{/sha}","git_commits_url":"https://api.github.com/repos/micrometer-metrics/micrometer/git/commits{/sha}","comments_url":"https://api.github.com/repos/micrometer-metrics/micrometer/comments{/number}","issue_comment_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/comments{/number}","contents_url":"https://api.github.com/repos/micrometer-metrics/micrometer/contents/{+path}","compare_url":"https://api.github.com/repos/micrometer-metrics/micrometer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micrometer-metrics/micrometer/merges","archive_url":"https://api.github.com/repos/micrometer-metrics/micrometer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micrometer-metrics/micrometer/downloads","issues_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues{/number}","pulls_url":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls{/number}","milestones_url":"https://api.github.com/repos/micrometer-metrics/micrometer/milestones{/number}","notifications_url":"https://api.github.com/repos/micrometer-metrics/micrometer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micrometer-metrics/micrometer/labels{/name}","releases_url":"https://api.github.com/repos/micrometer-metrics/micrometer/releases{/id}","deployments_url":"https://api.github.com/repos/micrometer-metrics/micrometer/deployments","created_at":"2017-04-10T21:36:51Z","updated_at":"2019-12-03T08:52:54Z","pushed_at":"2019-12-03T15:47:06Z","git_url":"git://github.com/micrometer-metrics/micrometer.git","ssh_url":"git@github.com:micrometer-metrics/micrometer.git","clone_url":"https://github.com/micrometer-metrics/micrometer.git","svn_url":"https://github.com/micrometer-metrics/micrometer","homepage":"https://micrometer.io","size":17611,"stargazers_count":2010,"watchers_count":2010,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":441,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":237,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":441,"open_issues":237,"watchers":2010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729"},"html":{"href":"https://github.com/micrometer-metrics/micrometer/pull/1729"},"issue":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/1729"},"comments":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/1729/comments"},"review_comments":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729/comments"},"review_comment":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/pulls/1729/commits"},"statuses":{"href":"https://api.github.com/repos/micrometer-metrics/micrometer/statuses/04cd54d2edb4e9a7f17d7508db4ff41791eb7a1c"}},"author_association":"COLLABORATOR"}}
|
{
"id": 87859908,
"name": "micrometer-metrics/micrometer",
"url": "https://api.github.com/repos/micrometer-metrics/micrometer"
}
|
{
"id": 1059363,
"login": "izeye",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1059363?",
"url": "https://api.github.com/users/izeye"
}
|
{
"id": 30124485,
"login": "micrometer-metrics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30124485?",
"url": "https://api.github.com/orgs/micrometer-metrics"
}
| 2019-12-03T15:47:48 |
11000992875
|
{"actor":{"display_login":"izeye"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/comments/290503858","pull_request_review_id":245711858,"id":290503858,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDUwMzg1OA==","diff_hunk":"@@ -1324,16 +1329,24 @@ Wasm::Wasm(absl::string_view vm, absl::string_view id, absl::string_view initial\n }\n \n void Wasm::registerCallbacks() {\n-#define _REGISTER(_fn) \\\n+#define _REGISTER_ABI(_fn, _abi) \\\n wasm_vm_->registerCallback( \\\n- \"envoy\", #_fn, &_fn##Handler, \\\n- &ConvertFunctionWordToUint32<decltype(_fn##Handler), \\\n- _fn##Handler>::convertFunctionWordToUint32);\n+ \"envoy\", #_fn, &_fn##_abi##Handler, \\\n+ &ConvertFunctionWordToUint32<decltype(_fn##_abi##Handler), \\\n+ _fn##_abi##Handler>::convertFunctionWordToUint32)\n+#define _REGISTER(_fn) _REGISTER_ABI(_fn, )\n+\n if (is_emscripten_) {\n+ if (emscripten_abi_major_version_ > 0 || emscripten_abi_minor_version_ > 1) {","path":"source/extensions/common/wasm/wasm.cc","position":39,"original_position":39,"commit_id":"2a4d529c6fa0519c52121aff9bc03bf43e9bd269","original_commit_id":"2a4d529c6fa0519c52121aff9bc03bf43e9bd269","user":{"login":"jplevyak","id":281504,"node_id":"MDQ6VXNlcjI4MTUwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/281504?v=4","gravatar_id":"","url":"https://api.github.com/users/jplevyak","html_url":"https://github.com/jplevyak","followers_url":"https://api.github.com/users/jplevyak/followers","following_url":"https://api.github.com/users/jplevyak/following{/other_user}","gists_url":"https://api.github.com/users/jplevyak/gists{/gist_id}","starred_url":"https://api.github.com/users/jplevyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jplevyak/subscriptions","organizations_url":"https://api.github.com/users/jplevyak/orgs","repos_url":"https://api.github.com/users/jplevyak/repos","events_url":"https://api.github.com/users/jplevyak/events{/privacy}","received_events_url":"https://api.github.com/users/jplevyak/received_events","type":"User","site_admin":false},"body":"I'm OK with it this way.","created_at":"2019-06-04T21:25:27Z","updated_at":"2019-06-04T21:25:28Z","html_url":"https://github.com/envoyproxy/envoy-wasm/pull/29#discussion_r290503858","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/comments/290503858"},"html":{"href":"https://github.com/envoyproxy/envoy-wasm/pull/29#discussion_r290503858"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29"}},"in_reply_to_id":290416893},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29","id":283889523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzODg5NTIz","html_url":"https://github.com/envoyproxy/envoy-wasm/pull/29","diff_url":"https://github.com/envoyproxy/envoy-wasm/pull/29.diff","patch_url":"https://github.com/envoyproxy/envoy-wasm/pull/29.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/issues/29","number":29,"state":"open","locked":false,"title":"wasm: use values extracted from Emscripten metadata.","user":{"login":"PiotrSikora","id":190297,"node_id":"MDQ6VXNlcjE5MDI5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/190297?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false},"body":"This allows us to use more recent versions of Emscripten.\r\n\r\nFixes envoyproxy/envoy-wasm#32.\r\n\r\nSigned-off-by: Piotr Sikora <piotrsikora@google.com>","created_at":"2019-05-31T04:03:50Z","updated_at":"2019-06-04T21:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c64311e83fd200a78b98029ba198189818201051","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/issues/29/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/statuses/2a4d529c6fa0519c52121aff9bc03bf43e9bd269","head":{"label":"PiotrSikora:wasm-emscripten_metadata","ref":"wasm-emscripten_metadata","sha":"2a4d529c6fa0519c52121aff9bc03bf43e9bd269","user":{"login":"PiotrSikora","id":190297,"node_id":"MDQ6VXNlcjE5MDI5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/190297?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false},"repo":{"id":186988247,"node_id":"MDEwOlJlcG9zaXRvcnkxODY5ODgyNDc=","name":"envoy-wasm","full_name":"PiotrSikora/envoy-wasm","private":false,"owner":{"login":"PiotrSikora","id":190297,"node_id":"MDQ6VXNlcjE5MDI5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/190297?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PiotrSikora/envoy-wasm","description":"Playground for Envoy WASM filter","fork":true,"url":"https://api.github.com/repos/PiotrSikora/envoy-wasm","forks_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/forks","keys_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/teams","hooks_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/hooks","issue_events_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/issues/events{/number}","events_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/events","assignees_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/assignees{/user}","branches_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/branches{/branch}","tags_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/tags","blobs_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/statuses/{sha}","languages_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/languages","stargazers_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/stargazers","contributors_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/contributors","subscribers_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/subscribers","subscription_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/subscription","commits_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/contents/{+path}","compare_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/merges","archive_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/downloads","issues_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/issues{/number}","pulls_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/pulls{/number}","milestones_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/milestones{/number}","notifications_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/labels{/name}","releases_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/releases{/id}","deployments_url":"https://api.github.com/repos/PiotrSikora/envoy-wasm/deployments","created_at":"2019-05-16T08:43:34Z","updated_at":"2019-05-17T20:43:11Z","pushed_at":"2019-06-04T04:40:00Z","git_url":"git://github.com/PiotrSikora/envoy-wasm.git","ssh_url":"git@github.com:PiotrSikora/envoy-wasm.git","clone_url":"https://github.com/PiotrSikora/envoy-wasm.git","svn_url":"https://github.com/PiotrSikora/envoy-wasm","homepage":null,"size":57080,"stargazers_count":0,"watchers_count":0,"language":"WebAssembly","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"81b3ee8bf4ff343e376ed290c07a95b708af707c","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":185880979,"node_id":"MDEwOlJlcG9zaXRvcnkxODU4ODA5Nzk=","name":"envoy-wasm","full_name":"envoyproxy/envoy-wasm","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy-wasm","description":"Playground for Envoy WASM filter","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy-wasm","forks_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy-wasm/deployments","created_at":"2019-05-09T22:37:07Z","updated_at":"2019-06-03T06:50:22Z","pushed_at":"2019-06-04T04:42:43Z","git_url":"git://github.com/envoyproxy/envoy-wasm.git","ssh_url":"git@github.com:envoyproxy/envoy-wasm.git","clone_url":"https://github.com/envoyproxy/envoy-wasm.git","svn_url":"https://github.com/envoyproxy/envoy-wasm","homepage":null,"size":57054,"stargazers_count":21,"watchers_count":21,"language":"WebAssembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":22,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29"},"html":{"href":"https://github.com/envoyproxy/envoy-wasm/pull/29"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/issues/29"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy-wasm/statuses/2a4d529c6fa0519c52121aff9bc03bf43e9bd269"}},"author_association":"MEMBER"}}
|
{
"id": 185880979,
"name": "envoyproxy/envoy-wasm",
"url": "https://api.github.com/repos/envoyproxy/envoy-wasm"
}
|
{
"id": 281504,
"login": "jplevyak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/281504?",
"url": "https://api.github.com/users/jplevyak"
}
|
{
"id": 30125649,
"login": "envoyproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30125649?",
"url": "https://api.github.com/orgs/envoyproxy"
}
| 2019-06-04T21:25:27 |
9758688490
|
{"actor":{"display_login":"jplevyak"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/289431731","pull_request_review_id":244363004,"id":289431731,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4OTQzMTczMQ==","diff_hunk":"@@ -0,0 +1,59 @@\n+#pragma once\n+\n+#include <string>\n+\n+#include \"envoy/stream_info/filter_state.h\"\n+\n+#include \"absl/types/optional.h\"\n+\n+namespace Envoy {\n+namespace Router {\n+\n+/**\n+ * Configuration for debugging router behavior. The router tries to look up an instance of this\n+ * class by its `key`, in FilterState (via StreamInfo). If it's not present, debugging features are\n+ * not enabled.\n+ *\n+ * There is currently no public API for populating this configuration -- neither globally nor\n+ * per-request -- users desiring to use the router debugging features should create and install\n+ * their own custom StreamDecoderFilter to set DebugConfig as desired before the router consumes\n+ * it.\n+ *\n+ * This is intended to be temporary, and should be replaced by some proper configuration (e.g. in\n+ * router.proto) when we get unified matchers. See https://github.com/envoyproxy/envoy/issues/5569.\n+ *\n+ * TODO(mergeconflict): Keep this promise.\n+ */\n+struct DebugConfig : public StreamInfo::FilterState::Object {\n+ /**\n+ * @return the string key for finding DebugConfig, if present, in FilterState.\n+ */\n+ static const std::string& key();\n+\n+ /**\n+ * Append cluster information as a response header if `append_cluster_` is true. The router will\n+ * use `cluster_header_` as the header name, if specified, or \"x-envoy-cluster\" by default.\n+ */\n+ bool append_cluster_{};\n+ absl::optional<std::string> cluster_header_;\n+\n+ /**\n+ * Append upstream host name and address as response headers, if `append_host_` is true. The\n+ * router will use `hostname_header_` and `host_address_header_` as the header names, if\n+ * specified, or \"x-envoy-upstream-hostname\" and \"x-envoy-upstream-host-address\" by default.\n+ */\n+ bool append_upstream_host_{};\n+ absl::optional<std::string> hostname_header_;\n+ absl::optional<std::string> host_address_header_;\n+\n+ /**\n+ * Do not forward the associated request to the upstream cluster, if `do_not_forward_` is true.\n+ * If the router would have forwarded it (assuming all other preconditions are met), it will\n+ * instead respond with a 204 \"no content.\" Any debug headers specified above (or others\n+ * introduced by other filters) will be appended to this empty response.\n+ */\n+ bool do_not_forward_{};","path":"source/common/router/debug_config.h","position":55,"original_position":55,"commit_id":"4f3343304a876c0cccfc6decc032684b4548de2b","original_commit_id":"4f3343304a876c0cccfc6decc032684b4548de2b","user":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"Do you think that we should set some other header when not forwarded? The thing I would be concerned about is differentiating a normal 204 with a not forwarded 204?","created_at":"2019-05-31T15:10:34Z","updated_at":"2019-05-31T15:13:55Z","html_url":"https://github.com/envoyproxy/envoy/pull/6893#discussion_r289431731","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/289431731"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/6893#discussion_r289431731"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893","id":277843207,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3ODQzMjA3","html_url":"https://github.com/envoyproxy/envoy/pull/6893","diff_url":"https://github.com/envoyproxy/envoy/pull/6893.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/6893.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/6893","number":6893,"state":"open","locked":false,"title":"router: implement append_cluster, append_upstream_host, and do_not_forward","user":{"login":"mergeconflict","id":921312,"node_id":"MDQ6VXNlcjkyMTMxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/921312?v=4","gravatar_id":"","url":"https://api.github.com/users/mergeconflict","html_url":"https://github.com/mergeconflict","followers_url":"https://api.github.com/users/mergeconflict/followers","following_url":"https://api.github.com/users/mergeconflict/following{/other_user}","gists_url":"https://api.github.com/users/mergeconflict/gists{/gist_id}","starred_url":"https://api.github.com/users/mergeconflict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mergeconflict/subscriptions","organizations_url":"https://api.github.com/users/mergeconflict/orgs","repos_url":"https://api.github.com/users/mergeconflict/repos","events_url":"https://api.github.com/users/mergeconflict/events{/privacy}","received_events_url":"https://api.github.com/users/mergeconflict/received_events","type":"User","site_admin":false},"body":"Description: Implement three new router behaviors, append_cluster, append_upstream_host and do_not_forward. These are enabled via the new StreamDebugInfo class, although no API is provided to set them.\r\nRisk Level: low/medium (changes to router)\r\nTesting: added unit tests for behaviors separately and combined.\r\nDocs Changes: n/a\r\nRelease Notes: n/a (I think...)\r\nFixes: #6453\r\n\r\nSigned-off-by: Dan Rosen <mergeconflict@google.com>\r\n","created_at":"2019-05-10T17:02:08Z","updated_at":"2019-05-31T15:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43aa967b9a14836101843d327c53ffd110c5d58b","assignee":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/6893/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/4f3343304a876c0cccfc6decc032684b4548de2b","head":{"label":"mergeconflict:router-debugging","ref":"router-debugging","sha":"4f3343304a876c0cccfc6decc032684b4548de2b","user":{"login":"mergeconflict","id":921312,"node_id":"MDQ6VXNlcjkyMTMxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/921312?v=4","gravatar_id":"","url":"https://api.github.com/users/mergeconflict","html_url":"https://github.com/mergeconflict","followers_url":"https://api.github.com/users/mergeconflict/followers","following_url":"https://api.github.com/users/mergeconflict/following{/other_user}","gists_url":"https://api.github.com/users/mergeconflict/gists{/gist_id}","starred_url":"https://api.github.com/users/mergeconflict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mergeconflict/subscriptions","organizations_url":"https://api.github.com/users/mergeconflict/orgs","repos_url":"https://api.github.com/users/mergeconflict/repos","events_url":"https://api.github.com/users/mergeconflict/events{/privacy}","received_events_url":"https://api.github.com/users/mergeconflict/received_events","type":"User","site_admin":false},"repo":{"id":161085763,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEwODU3NjM=","name":"envoy","full_name":"mergeconflict/envoy","private":false,"owner":{"login":"mergeconflict","id":921312,"node_id":"MDQ6VXNlcjkyMTMxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/921312?v=4","gravatar_id":"","url":"https://api.github.com/users/mergeconflict","html_url":"https://github.com/mergeconflict","followers_url":"https://api.github.com/users/mergeconflict/followers","following_url":"https://api.github.com/users/mergeconflict/following{/other_user}","gists_url":"https://api.github.com/users/mergeconflict/gists{/gist_id}","starred_url":"https://api.github.com/users/mergeconflict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mergeconflict/subscriptions","organizations_url":"https://api.github.com/users/mergeconflict/orgs","repos_url":"https://api.github.com/users/mergeconflict/repos","events_url":"https://api.github.com/users/mergeconflict/events{/privacy}","received_events_url":"https://api.github.com/users/mergeconflict/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mergeconflict/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/mergeconflict/envoy","forks_url":"https://api.github.com/repos/mergeconflict/envoy/forks","keys_url":"https://api.github.com/repos/mergeconflict/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mergeconflict/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mergeconflict/envoy/teams","hooks_url":"https://api.github.com/repos/mergeconflict/envoy/hooks","issue_events_url":"https://api.github.com/repos/mergeconflict/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/mergeconflict/envoy/events","assignees_url":"https://api.github.com/repos/mergeconflict/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/mergeconflict/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/mergeconflict/envoy/tags","blobs_url":"https://api.github.com/repos/mergeconflict/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mergeconflict/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mergeconflict/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mergeconflict/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mergeconflict/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/mergeconflict/envoy/languages","stargazers_url":"https://api.github.com/repos/mergeconflict/envoy/stargazers","contributors_url":"https://api.github.com/repos/mergeconflict/envoy/contributors","subscribers_url":"https://api.github.com/repos/mergeconflict/envoy/subscribers","subscription_url":"https://api.github.com/repos/mergeconflict/envoy/subscription","commits_url":"https://api.github.com/repos/mergeconflict/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mergeconflict/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mergeconflict/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mergeconflict/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mergeconflict/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/mergeconflict/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mergeconflict/envoy/merges","archive_url":"https://api.github.com/repos/mergeconflict/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mergeconflict/envoy/downloads","issues_url":"https://api.github.com/repos/mergeconflict/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/mergeconflict/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/mergeconflict/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/mergeconflict/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mergeconflict/envoy/labels{/name}","releases_url":"https://api.github.com/repos/mergeconflict/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/mergeconflict/envoy/deployments","created_at":"2018-12-09T22:06:35Z","updated_at":"2019-05-29T19:35:57Z","pushed_at":"2019-05-29T19:51:48Z","git_url":"git://github.com/mergeconflict/envoy.git","ssh_url":"git@github.com:mergeconflict/envoy.git","clone_url":"https://github.com/mergeconflict/envoy.git","svn_url":"https://github.com/mergeconflict/envoy","homepage":"https://www.envoyproxy.io","size":33990,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"c0797dc5c58905ec64e1ff68c0d740e35e97bccb","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"Cloud-native high-performance edge/middle/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2019-05-31T14:58:22Z","pushed_at":"2019-05-31T14:19:45Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":34223,"stargazers_count":9791,"watchers_count":9791,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1488,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":499,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1488,"open_issues":499,"watchers":9791,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/6893"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/6893"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/6893/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6893/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/4f3343304a876c0cccfc6decc032684b4548de2b"}},"author_association":"MEMBER"}}
|
{
"id": 65214191,
"name": "envoyproxy/envoy",
"url": "https://api.github.com/repos/envoyproxy/envoy"
}
|
{
"id": 6305260,
"login": "mattklein123",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6305260?",
"url": "https://api.github.com/users/mattklein123"
}
|
{
"id": 30125649,
"login": "envoyproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30125649?",
"url": "https://api.github.com/orgs/envoyproxy"
}
| 2019-05-31T15:10:34 |
9735570983
|
{"actor":{"display_login":"mattklein123"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.