idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
|---|---|---|---|---|---|
3,836,952 | 113,283,078 |
2022-08-15 10:31:45.563
|
EVM on WASM: Run time for large/long transaction on EVM
|
Goal: find number of WASM instructions needed to run the largest EVM transaction.
Things to figure out and do in this issue:
- [x] How large is the "the largest" EVM transaction. Can we find this by looking at Ethereum history?
- [x] How much gas was spent on said transaction?
- [x] Write a contract that burns this amount of gas doing whatever.
- [x] How many WASM ticks are needed to run that transaction with the EVM interpreter we integrate with `kernel_next`?
Beware:
- Running the contract is only part of the transaction. After the transaction succeeds, the result needs to be written to permanent storage.
- Price (in WASM ticks and EVM gas) of storage interaction.
| 3 |
3,836,952 | 113,210,136 |
2022-08-12 15:54:20.021
|
SCORU: Wasm: Tezt test using test kernel (computation only)
|
Goal: There is a tezt test that uses the L2 client to
- Originate a Wasm SCORU
- Load the test kernel (computation only)
- Evaluate at least 2 `kernel_main` invocations.
| 1 |
3,836,952 | 113,210,135 |
2022-08-12 15:54:15.537
|
SCORU: Wasm: Tezt test using test kernel (computation and input)
|
Goal: There is a tezt test that uses the L2 client to
- Originate a Wasm SCORU
- Load the test kernel (input feature enabled)
- Evaluate at least 2 `kernel_main` invocations.
| 1 |
3,836,952 | 113,210,047 |
2022-08-12 15:51:53.141
|
EVM on WASM: EVM precompiled contract
|
Write one precompiled contract for the EVM interpreter: the identity function. The contract should write the _call data_ to the _return data_. Also, have the contract write a message to the evm- _and_ the kernel- log.
Test:
- Have the EVM interpreter call a contract that calls the build in contract
| 3 |
3,836,952 | 113,209,443 |
2022-08-12 15:37:12.575
|
EVM on WASM: common trait for encapsulating EVM interpreter
|
Encapsulate SputnikVM and Geth in each their struct. Each struct should implement one common trait/interface that allows for
- calling contracts
- providing precompiles
- interfacing with storage and transactions.
- intercepting `LOGx` instruction execution so that logs are not just part of the transaction, but also written to kernel log.
| 1 |
3,836,952 | 113,206,519 |
2022-08-12 15:19:59.581
|
EVM on WASM: Integrate with Geth
|
Goal is to integrate with an EVM interpreter so we can check and see if it is useful for our purpose. This issue is about checking geth.
Requirements:
- supports most recent version of EVM instruction set (if it doesn't, then something is very wrong); and,
- supports _precompiles_ in a way where we can define additional precompiles ourselves (not just the standard nine precompiles); and,
- doesn't require features from Rust `std` that we don't already use.
- capture execution of `LOGx` instructions.
Tests:
- some test contracts that return successfully
- some test contracts that fail - toplevel `REVERT` or using the standard invalid instruction.
| 5 |
3,836,952 | 113,200,456 |
2022-08-12 14:55:00.044
|
EVM on WASM: Integrate with SputnikVM
|
Goal is to integrate with an EVM interpreter so we can check and see if it is useful for our purpose. This issue is about using SputnikVM.
Requirements:
- supports most recent version of EVM instruction set; and,
- supports _precompiles_; and,
- doesn't require features from Rust `std` that we don't already use.
- capture execution of `LOGx` instructions.
Alternatives:
- original: https://github.com/ETCDEVTeam/sputnikvm (probably out of date)
- used by polkadot: https://github.com/rust-blockchain/evm/ (fork still with active maintenance)
- any other version of SputnikVM you can find
Test:
- run contracts with both old/original and new EVM instructions
- some test contract calls must succeed.
- add some test contract calls, with contracts that fail.
| 3 |
3,836,952 | 113,193,382 |
2022-08-12 14:25:54.649
|
EVM on WASM: EVM kernel crate
|
Add a new sub-project to the trili/kernel gitlab project. It should
- have name `evm_kernel`; and,
- contain a `Cargo.toml`, and a `lib.rs` file; and,
- have a `kernel_next` function (defined using the `kernel_entry` macro); and,
- a "cache" type.
| 1 |
3,836,952 | 113,123,525 |
2022-08-11 09:58:00.836
|
Add integration test for inputs
|
Goal: There is a above the Protocol level test that loads a [Test kernel] that that has input feature flag enabled and feeds at least 10 inputs.
For similar tests, see `src/proto_alpha/lib_protocol/test/integration/test_sc_rollup_wasm.ml`, especially `should_boot_computation_kernel` (above Protocol).
Somewhat related:
https://gitlab.com/tezos/tezos/-/merge_requests/6208
| 1 |
3,836,952 | 112,048,779 |
2022-07-22 14:51:49.931
|
lib_scoru_wasm: disallow exceptions in entry-point functions
|
See also [team meeting notes](https://www.notion.so/trilitech/Meeting-Notes-a744673f343b4e328bf5bf14536c614d#6bbf9ac486ad452c9e5353c85cf3bac2)
Remove the mention of exceptions from `lib_scoru_wasm` `Make` signature. Add `try_with` or similar to catch exceptions and put the machine in a stuck state instead.
The machine is stuck whenever there is an error state in state tree accessible from `get_info`. A stuck PVM should not advance (meaningfully) but will increment the tick counter (only).
Optional: add another case to `Protocol.Sc_rollup_wasm.status` and propagate.
## Context
The top-interface exposed in `lib_scoru_wasm` (e.g. `Make`) is called from the Protocol, where Ocaml exceptions are avoided by conventions. We must therefore catch and wrap Ocaml exceptions either in `Sc_rollup_wasm` or in `lib_scoru_wasm` (or both, defensively).
We nonetheless need to deal with:
- Non-recoverable errors caused by bugs in PVM
- User errors such as posting a syntactically invalid kernel
In the PMV 1 milestone we're not implementing a fallback mechanism, just putting the machine in a stuck state - though we should try to be future-compatible with error recovery.
Note that internally in `lib_scoru_wasm` we can still use exceptions or error return values - but they should not propagate to the top-level.
| 1 |
3,836,952 | 111,904,378 |
2022-07-20 08:53:18.967
|
[DAL]: Remove the functor for the cryptographic primitive
|
The functor exposed by the cryptographic primitives add a lot of complexity. Since the parameters have no type and are only constants, the functor can be replaced with an explicit state that encapsulates those constants.
This is handled in !5907
\spent 2d
| 10 |
3,836,952 | 111,514,659 |
2022-07-12 13:51:30.562
|
Make 1-module assumption explicit and test that it works with host functions
|
The following discussion from !5744 should be addressed:
- [ ] @hans.hoglund started a [discussion](https://gitlab.com/tezos/tezos/-/merge_requests/5744#note_1014886493): (+3 comments)
> If we ever add support for >1 modules we'll need to be careful to look up the blocks in the correct module instance.
>
> The current state is OK, but perhaps worth adding a warning somewhere.
| 1 |
3,836,952 | 111,463,618 |
2022-07-11 15:13:59.178
|
[DAL]: Allow the build of a safe trusted setup into the code base
|
Currently, an unsafe trusted setup is build using parameter constants. To make it safer, the trusted setup should be computed from a file (whose size is more than `100` MB). This raises several integration questions.
| 10 |
3,836,952 | 111,452,870 |
2022-07-11 12:09:19.799
|
WASM: intricated typechecking during parsing and evaluation
|
During parsing and evaluation, some form of validation / typechecking is done which makes the parser / evaluator convoluted and non tickifiable without tricks. The testsuite rely on these tests at this specific stage of the parsing / evaluation routine, therefore it cannot happen later. Especially, some modules in the testsuite are syntactically invalid since the test is supposed to fail during the parsing.
- Decode: local variables https://gitlab.com/tezos/tezos/-/merge_requests/5610#note_1008186757
- Decode: no free variables in functions
- Eval: checking type equality at call site when importing module
| 5 |
3,836,952 | 111,354,919 |
2022-07-08 09:00:24.441
|
SCORU/WASM: Ensure "unsafe" functions are never used inside the PVM
|
The interpreter can rely on unsafe or unstable functions that are only used in the executable part, for the testsuite or debugging.
- `Lazy_map.loaded_bindings` and `Lazy_vector.loaded_bindings` can be one of these functions (see discussion https://gitlab.com/tezos/tezos/-/merge_requests/5552#note_1017555842).
- Other functions like this include `Lazy_vector.{to_string,pp}` and `Lazy_map.{to_string,pp}` and any function whose docstring says "witness to internal mutation"
- `Valid` assumes the AST is always fully loaded.
- `Encode` assumes the AST is always fully loaded.
- `Free` loads vectors entirely, hence would produce huge proofs if used in the PVM. It should only be part of `Valid` and never used in the PVM, except for one specific part that is used in the parser (#3387)
- Various AST printing functions relies on `loaded_bindings`, and are only used by the final binary to produce debug traces.
- Pretty printing of lazy containers exposes internals and should bnot be used by the PVM
We need a way to ensure these functions are never called in the PVM, either by linting, tests and/or packagin. One possible suggestion can be found in https://gitlab.com/tezos/tezos/-/merge_requests/5552#note_1017690451
| 5 |
3,836,952 | 111,253,699 |
2022-07-06 12:31:56.226
|
SCORU: Wasm: Show that proof size is bounded
|
Goal: We have enough confidence that tick size bounds are not exceeded by Wasm PVM to enable the feature in mainnet.
Needs to be supported by "pen-and-paper" reasoning or better (fuzz-testing alone is not enouggh).
- [ ] `Decode.find_vec'` and `Decode.find_single'`, see discussion https://gitlab.com/tezos/tezos/-/merge_requests/5552#note_1013344663
| 5 |
3,836,952 | 111,183,937 |
2022-07-05 11:42:42.880
|
SCORU: Increase the message size limit
|
This is a change that is necessary for the WASM PVM to be supplied with so-called string chunks, targeted to be of 4,096 bytes. The size limit is itself set to 4,096 bytes, which prevents a user to supply additional information with these chunks (e.g., a signature).
| 1 |
3,836,952 | 109,663,096 |
2022-06-06 17:21:31.968
|
SCORU: Wasm: Add kernel loading logic to PVM
|
## Goal
Extend the Wasm rollup state with `/parse_state/input`, which stores a Merkelized list, or `Chunked_byte_vector` and a field `booter`, storing a `Public_key_hash.t`.
During origination, the originator sends the `booter` and an optional initial boot sector chunk.
When the machine is in preboot, incoming inbox messages are parsed as `{ next_boot_sector_chunk : string, signature : Signature.t }`. The signature is checked and the chunk is appended to the boot sector.
Whenever `next_boot_sector_chunk` is empty, the boot state is moved from `Loading` to `Parsing`, then proceeds with the normal boot process.
## Alternative
Put this logic in the SCORU protocol https://hackmd.io/ugX9U_CPTXOeB3Tk7ZPgFA?view.
Believed to be more involved due to storage.
## Context
During work on https://gitlab.com/tezos/tezos/-/milestones/86#tab-issues it has become clear that realistic kernels are not going to be smaller than ~2MB, which is in conflict with the (block-driven) size limits imposed in https://gitlab.com/tezos/tezos/-/issues/3054.
This could be worked around with self-upgradable kernels, but this is out of scope for https://gitlab.com/tezos/tezos/-/milestones/83#tab-issues, hence we lack the capability to test realistically sized kernels. We here work around this by adding "append boot sector" logic in the Wasm rollup itself.
On finishing https://gitlab.com/tezos/tezos/-/milestones/83#tab-issues this logic can be moved from L1 to Kernel code if desired.
### Data structure
We need lazy append. That is (append M N) where proof size is O(log M*N), and better than O(N).
Merkle list might be tricky, because consuming from the front means rewriting the entire KV structure for that list within the tree. Morally you need a reverse-linked merkle list.
You can't use Irmin move opeerations, as with the set/get pattern, indeed you risk not recognizing the shallow move in set and rewriting the entire structure. The easiest solution is probably an indexed map of pages, boxed with an offset for the parser state.
| 0 |
3,836,952 | 109,644,533 |
2022-06-06 11:55:49.434
|
SCORU: Wasm PVM: Handle the right number of inputs per commitment
|
Goal: The Wasm PVM handles the right number of inputs per commitment.
A commitment period is split into L parts, each corresponding to an inbox level with a non-zero amount of messages.
For each part of the commitment period, `kernel_next` may be called up to N (tbd) times.
After which, the PVM defaults to consecutively reading inputs from L1 until reading an input from a subsequent inbox level. The loop continues after that.
This means each section of the commitment period, has a phase to process the previously accumulated and a phase to gather inputs for the next loop.
| 3 |
3,836,952 | 109,443,263 |
2022-06-01 12:38:59.185
|
Wasm PVM: Test for booting/computing and checking size
|
Goal: Add tests on top of `Sc_rollup_wasm` that
- Boots and computes the VM using a predefined boot sector and input.
- Runs the VM to some point, providing input.
- Generates proofs and check that they fit within the size limit
| 3 |
3,836,952 | 109,313,844 |
2022-05-30 12:39:53.486
|
Wasm PVM: Remove duplication in input proofs
|
The following discussion from !5416 should be addressed:
- [ ] @hans.hoglund started a [discussion](https://gitlab.com/tezos/tezos/-/merge_requests/5416#note_964475159):
> ```suggestion:-4+0
> (* TODO:
> The tree proof contains enough information to derive given and requested.
> Get rid of the duplication by writing the projection functions and
> removing the [given] and [requested] fields.
> *)
> ```
This should improve the size of input proofs by a factor of ~2.
| 1 |
4,456,656 | 86,814,622 |
2019-12-17 20:29:25.751
|
Pajamas: New UX architecture
|
## Problem
<!-- What’s the problem? Why is it worth solving? -->
### GitLab is a Gardener
The great George RR Martin once said...
> “I think there are two types of writers, the **architects** and the **gardeners**. The architects plan everything ahead of time, like an architect building a house. They know how many rooms are going to be in the house, what kind of roof they're going to have, where the wires are going to run, what kind of plumbing there's going to be. They have the whole thing designed and blueprinted out before they even nail the first board up. The gardeners dig a hole, drop in a seed and water it. They kind of know what seed it is, they know if planted a fantasy seed or mystery seed or whatever. But as the plant comes up and they water it, they don't know how many branches it's going to have, they find out as it grows. And I'm much more a gardener than an architect.”
* **Gardener** - Bottom-up, experimental, opportunistic, looking for emerging structures
* **Architect** - Top-down, regimented, tightly-controlled, looking to balance the high level with the lower level from the start
I think this mindset can be applied to any creative field (such as design), however, I don't think you necessarily need to be either a `Gardener` or an `Architect`.
**IMO... GitLab is culturally over-indexing on the `Gardener` side of things.**
### The challenge with being a Gardener
Based on my onboarding experience and use of Pajamas, this Gardener mindset has led to a number of pain points...
* The onboarding experience is scary
* Design documentation and resources (from my perspective) are quite diffuse across GitLab
* It's hard to quickly understand what GitLab as a product is - and how it fits together
...There is an opportunity to restructure the experience and content of our Pajamas Design System to ease the onboarding experience and architect content in a more noob-friendly way.
## Solution
<!-- What’s the solution? Why is it like that? What are the benefits?) -->
Let's introduce just the right amount of `Architect` into our design system...
I have taken a stab at re-architecting the general experience ([see Pajamas Design System - Architecture Mural](https://app.mural.co/t/gitlab2474/m/gitlab2474/1576610115252/7ba61a8eaf98c494b8d603439d37011757c86b8c?wid=0-1576610284030&outline=open)) - trying to balance a bottom-up *and* top-down approach to a design system. This is WIP and a first iteration of course... I will need input from a broader audience to take into account everything that's important.
See...
* [Pajamas: Actionable Principles Update](https://gitlab.com/gitlab-org/gitlab-design/issues/797)
* [Pajamas: Define Conceptual Object Model](https://gitlab.com/gitlab-org/gitlab-design/issues/789)
With a more balanced approach to PJ's UX architecture, I believe we can...
* Make onboarding easier through clarity & purpose
* Simplify the information architecture of http://design.gitlab.com/
* Provide greater context for our lovely components
This is very abstract atm... but I will follow up with how this new type of architectural thinking can benefit the new table and sorting components I am working on.
I would love some feedback! Let me know what you think.
/cc @gitlab-com/gitlab-ux
| 5 |
4,456,656 | 27,992,532 |
2019-12-05 18:45:56.647
|
Dogfooding > Set up tracing in Jaeger
|
* Set up [Jaeger](https://www.jaegertracing.io/) and configure your application using one of the client libraries.
* Navigate to your project’s `Settings > Operations` and provide the Jaeger URL.
* Click Save changes for the changes to take effect.
* You can now visit `Operations > Tracing` in your project’s sidebar and GitLab will redirect you to the configured Jaeger URL.
| 2 |
4,456,656 | 27,904,886 |
2019-12-03 19:05:18.322
|
Update Foundation > Iconography docs with more details about counters
|
Per https://gitlab.com/gitlab-org/gitlab-design/issues/693#note_253421586, adding documentation to specifically address counters (negative space in an icon).
/cc @pedroms
| 1 |
4,456,656 | 27,514,850 |
2019-11-24 23:11:59.272
|
Highlight selected heading in markdown
|
If you link someone to an anchor link that is at the bottom of the page, scroll doesn't go all the way there.
e.g. the following link for Sourcegraph, but has the 'Localization' heading at top of screen https://gitlab.com/help/user/profile/preferences.md#sourcegraph
Would be great if we could highlight/outline/underline or somehow indicate that the sourcegraph heading is the target. i.e.
| 1 |
4,456,656 | 27,187,612 |
2019-11-18 19:00:32.372
|
Explore the possibility for a more compressed view of tables
|
When we were discussing how to utilize our existing table design to display logs, our engineering team suggested it would be better to have a view of the tables with minimal padding around the content so that users can view a maximal amount of content display onscreen (https://gitlab.com/gitlab-org/gitlab/issues/5696#note_244598777).
Should we consider a more condensed table view? Or, should we allow users to swap back and forth between our normal view and a more condensed view?
| 2 |
4,456,656 | 26,988,714 |
2019-11-12 16:54:59.374
|
Set up monitoring for design.gitlab.com
|
This project has been moved to running off of a Kubernetes cluster using Auto Devops and internal Operations tools. Right now it is using the out-of-the-box monitoring configuration. This is insufficient for production troubleshooting, as we discovered when troubleshooting this ingress issue: https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8319
This issue is to discuss setting up additional monitoring and metrics to increase visibility into the deployed instances.
The ingress issue that we have been seeing centers around the number of incoming connections, so as a first step, it would be nice to have some metrics for the NGINX Ingress controller's incoming and backend connections and their latency.
| 2 |
4,456,656 | 24,551,977 |
2019-09-06 21:23:49.194
|
Specify positioning and sizing guidelines for modals
|
### Problem
Modals across the product vary in size. Besides this, modals are missing some guidelines regarding positioning and sizing which could be useful in cases like the modal used for querying, listing, and filtering projects in https://gitlab.com/gitlab-org/gitlab-ce/issues/65285#note_213633672.
| Modal 1 | Modal 2 | Modal 3 |
| ------ | ------ | ------ |
|  |  |  |
### Proposal
Let's add some **positioning** and **sizing** guidelines for modals.
Possible additions:
1. Specify space on top and bottom
1. Specify height growth strategy if needed
1. Specify max-height
1. Specify listing guidelines and paginating through elements
1. Specify filtering options (filter box)
| 2 |
4,456,656 | 24,063,726 |
2019-08-22 17:32:59.424
|
Remove banner from sorting component
|
We've implemented a first-pass of the sorting component. We weren't able to finish styling the component because we are waiting on other components to be completed (https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/274, https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/281).
Our plan is to add a "this component does not yet conform to the correct styling" banner to the vue component on design.gitlab.com. This issue is to remove that banner, when all of the resulting style issues have been resolved.
| 1 |
4,456,656 | 23,844,795 |
2019-08-16 14:31:58.020
|
Create, Build, and Style > Drawers
|
This issue is to complete the ~"pajamas::create", ~"pajamas::build", ~"pajamas::style" portion of ~"component::filters" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI.
This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product.
Related epics:
* [Components of Pajamas Design System:
* [Pajamas component:
Related issues:
* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355)
## Checklist
* [x] Usage documentation is included in Pajamas
* [x] Component is built and styled in gitlab-ui according to specs
* [x] Add the design specs to Pajamas https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2719
* [x] [Create Drawer structure in Figma](https://www.figma.com/file/2XRq1MnIG69iti76Mh9HpJ/branch/DlBySFafHmSJEzgJv2v2Sa/Pajamas-visual-examples?node-id=3487%3A15479)
* [x] Add the structure diagram to Pajamas ([Figma branch](https://www.figma.com/file/2XRq1MnIG69iti76Mh9HpJ/branch/DlBySFafHmSJEzgJv2v2Sa/Pajamas-visual-examples?node-id=3487%3A15479)) [MR](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2737)
* [x] Remove the banner on vue tab that warns of incorrect styling ([MR](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2677))
* [x] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc
| 5 |
4,456,656 | 23,754,265 |
2019-08-13 20:22:53.355
|
Follow-up from "WIP: Resolve "Review illustration documentation" - Add link to icon naming
|
The following discussion from !1506 should be addressed:
- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1506#note_202920888): (+3 comments)
> Is it possible to link `icon naming` to a section that describes how to name icons?
Dependent on https://gitlab.com/gitlab-org/gitlab-design/issues/554
| 1 |
4,456,656 | 23,520,285 |
2019-08-05 19:59:51.418
|
Update radio styling to be consistent
|
The padding around the radios should be consistent. Inline is correct.
| 1 |
4,456,656 | 23,261,727 |
2019-07-29 12:06:30.217
|
Define default delay for popovers
|
### Problem
> At the moment, we don't specify a global delay for any of our popovers - each popover instance specifies its own delay (if any).
### Further information
> Looking through the source, I was able to find two places where we manually specify a popover delay - both are `200ms`. For example: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/user_popovers.js#L98. This is the popover that shows when a user's name is hovered.
### Proposal
After https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/235#note_195974856 has been concluded, we should look into improving this for popovers as well.
| 1 |
4,456,656 | 23,171,745 |
2019-07-25 21:00:54.198
|
UX Merge Request Coach
|
How can we incorporate UX MR coaches into the current process, especially for repos like Pajamas and gitlab-ui? [See Merge Request Coach page](https://about.gitlab.com/job-families/expert/merge-request-coach/)
The following discussion from https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/26512 should be addressed:
- [ ] @rverissimo started a [discussion](https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/26512#note_195850582): (+2 comments)
> I'm not totally sure if this is applicable to designers, but I decided to keep it as it shows in the engineering page. Could you please review and give feedback?
| 2 |
4,456,656 | 22,911,881 |
2019-07-17 08:44:15.357
|
Follow-up from "Update contents/components/tables.md"
|
The following discussion from !1444 should be addressed:
- [ ] @matejlatin started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1444#note_192402923): (+4 comments)
> Should we also suggest using the lining tabular figures when the tables are numbers-heavy?
>
> 
>
> I know that the SF font supports them as an OpenType feature, not sure about Segoe UI though :thinking:
| 1 |
4,456,656 | 22,480,486 |
2019-07-03 12:25:03.237
|
Add 10 Usability Heuristics for User Interface Design to the Usability menu for the design documentation
|
### Problem
With https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1448#note_187568144 we'll be adding error prevention to the usability menu, one of the 10 usability heuristics from NNgroup: https://www.nngroup.com/articles/ten-usability-heuristics/
We already have a few others as well.
### Proposal
This issue is to discover which other heuristics we can add and what duplicate content we might already have existing in other places.
| 2 |
4,456,656 | 22,213,429 |
2019-06-25 07:02:00.919
|
Add compact empty state region component variant
|
### Problem
Following the discussion in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14349#note_184643601 and the need in https://gitlab.com/gitlab-org/gitlab-ce/issues/57086#note_181276839, a new component variant is about to be introduced in https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/592 for **compact empty state**.
### Proposal
Let's add some design documentation about this new component variant in Pajamas.
| 2 |
4,456,656 | 22,140,807 |
2019-06-21 18:20:39.305
|
Add docs on colors for text, icons, and text+icons
|
Write guidelines on the logic for applying [color](https://design.gitlab.com/foundations/colors) to text and icons (when alone or paired with text) defined in https://gitlab.com/gitlab-org/gitlab-design/issues/259
| 2 |
4,456,656 | 22,092,756 |
2019-06-20 12:24:02.975
|
Delete old review apps host
|
Once AutoDevops is enabled (https://gitlab.com/gitlab-org/design.gitlab.com/issues/96) and all MRs are rebased, we should go and delete the old host?
The following discussion from !1216 should be addressed:
- [ ] @leipert started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1216#note_182856734):
> Once Auto-Devops is enabled and MRs are rebased we probably should go and delete the current host we have set up for review apps.
| 1 |
4,456,656 | 21,966,445 |
2019-06-17 10:14:40.434
|
Create nice error pages for design.gitlab.com
|
With https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1437 we are going to have a nice nginx container for auto-devops. Ths container could serve custom 40x and 50x error pages. Let's create them!
The following discussion from !1437 should be addressed:
- [ ] @leipert started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1437#note_181880339): (+1 comment)
> @DylanGriffith I am not too familiar with AutoDevOps (shame on me). The built nginx image is run at the end, right? Because if so, we could create a follow-up issue to also provide a nice 40x error template (additionally to the 40x one)
| 2 |
4,456,656 | 21,649,019 |
2019-06-06 17:41:34.399
|
Add badges demo and update component status
|
Adding this as a reminder to add the demo for the ~"component::badges" after the ~"pajamas::style" has been completed.
Also update the status page with the component status: https://design.gitlab.com/components/status
| 1 |
4,456,656 | 21,535,127 |
2019-06-03 17:02:02.999
|
Add paginated list component
|
### Problem
Following the need in https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/1183 to facilitate paginated lists with less than 20 items which derived from the discussion in https://gitlab.com/gitlab-org/gitlab-ee/issues/10059, a new component is about to be introduced in https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/350 for **paginated lists**.
### Proposal
Let's add some design documentation about this new component in Pajamas.
This could be added as a) separate component for now or b) variation of the [lists](https://design.gitlab.com/components/lists) component while this could easily become the basis of a [data tables](https://design.gitlab.com/components/data-tables) component in the near future.
| 3 |
4,456,656 | 20,942,690 |
2019-05-15 20:34:44.615
|
Create, Build, and Style > Tree
|
This issue is to complete the ~"pajamas::create", ~"pajamas::build", ~"pajamas::style" portion of ~"component::tree" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI.
This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product.
Related epics:
* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973)
* [Pajamas component: Tree](https://gitlab.com/groups/gitlab-org/-/epics/1124)
Related issues:
* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355)
## Checklist
* [x] Usage documentation is included in Pajamas
* [x] Design specs are included in Pajamas
* [x] Component is built and styled in gitlab-ui according to specs
* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas
* [ ] All demos and todos are complete
* [ ] Status is changed to `Built` in Pajamas
* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc
### Checklist for UI/sketch updates
Make sure these are completed before closing the issue, with a link to the
relevant commit or issue, if applicable. Get familiar with the [Sketch UI Kit
documentation](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md)
which has information on updating files, structure, fonts, and symbols.
1. [x] **Author**: Create a Sketch file in your progress folder with the
changes required for this issue. Try to use existing symbols, layer styles,
and text styles.
1. [x] **Author**: Ask another Product Designer to review your personal Sketch file, linking them to your latest commit so they know where to find it. If they have the capacity, they should assign themselves to this issue. If not, try pinging another person.
1. [x] **Reviewer**: Review and approve author's changes in their personal
Sketch file, according to the [workflow](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md#sketch-workflow).
1. [x] **Author**: Add your changes to the GitLab Sketch UI Kit (pattern
library and/or instance sheet), following this [step-by-step process](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md#when-changes-are-approved).
1. [x] **Author**: Ask the reviewer to review your changes to the Sketch UI
Kit files.
1. [x] **Reviewer**: Review and approve author's changes to the Sketch UI Kit
files, according to the [workflow](https://gitlab.com/gitlab-org/gitlab-design/blob/master/doc/sketch-ui-kit.md#sketch-workflow).
1. [x] **Author**: [Create an issue in the Design
System](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/issues/new)
to update the design **specs** and **documentation**. Mark it as related to
this issue.
1. [x] **Author**: Add a read only (FYI) agenda item to the next [UX weekly
call](https://docs.google.com/document/d/189WZO7uTlZCznzae2gqLqFn55koNl3-pHvU-eVnvG9c/edit?usp=sharing)
to inform everyone of these changes, linking to this issue.
| 3 |
4,456,656 | 20,942,600 |
2019-05-15 20:29:50.917
|
Create, Build, and Style > Banners
|
This issue is to complete the ~"pajamas::create", ~"pajamas::build", ~"pajamas::style" portion of ~"component::banners" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI.
This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product.
Related epics:
* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973)
* [Pajamas component: Banners](https://gitlab.com/groups/gitlab-org/-/epics/1136)
Related issues:
* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355)
## Checklist
* [x] Usage documentation is included in Pajamas
* [x] Design specs are included in Pajamas
* [x] Component is built and styled in gitlab-ui according to specs
* [x] Banner on vue tab that warns of incorrect styling is removed from Pajamas
* [x] All demos and todos are complete
* [ ] Status is changed to `Built` in Pajamas
* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc
| 5 |
4,456,656 | 20,942,021 |
2019-05-15 20:02:12.503
|
Create, Build, and Style > Lists
|
This issue is to complete the ~"pajamas::create", ~"pajamas::build", ~"pajamas::style" portion of ~"component::lists" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI.
This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product.
Related epics:
* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973)
* [Pajamas component: Lists](https://gitlab.com/groups/gitlab-org/-/epics/1084)
Related issues:
* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355)
## Checklist
* [ ] Usage documentation is included in Pajamas
* [ ] Design specs are included in Pajamas
* [ ] Component is built and styled in gitlab-ui according to specs
* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas
* [ ] All demos and todos are complete
* [ ] Status is changed to `Built` in Pajamas
* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc
| 3 |
4,456,656 | 20,941,416 |
2019-05-15 19:35:09.982
|
Create, Build, and Style > Forms
|
This issue is to complete the ~"pajamas::create", ~"pajamas::build", ~"pajamas::style" portion of ~"component::forms" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI.
This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product.
Related epics:
* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973)
* [Pajamas component: Forms](https://gitlab.com/groups/gitlab-org/-/epics/1021)
Related issues:
* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355)
## Checklist
* [ ] Usage documentation is included in Pajamas
* [ ] Design specs are included in Pajamas
* [ ] Component is built and styled in gitlab-ui according to specs
* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas
* [ ] All demos and todos are complete
* [ ] Status is changed to `Built` in Pajamas
* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc
| 3 |
4,456,656 | 20,941,377 |
2019-05-15 19:32:24.884
|
Create, Build, and Style > Dropdowns
|
This issue is to complete the ~"pajamas::create", ~"pajamas::build", ~"pajamas::style" portion of ~"component::dropdowns" as part of FY20-Q2 OKR to Improve the quality and consistency of our UI.
This includes a single-source-of-truth component that is implemented in Vue and thoroughly documented on design.gitlab.com. This does not include implementing the component throughout the product.
Related epics:
* [Components of Pajamas Design System](https://gitlab.com/groups/gitlab-org/-/epics/973)
* [Pajamas component: Dropdowns](https://gitlab.com/groups/gitlab-org/-/epics/1018)
Related issues:
* [FY20-Q2 UX OKR: Improve the quality and consistency of our UI](https://gitlab.com/gitlab-com/www-gitlab-com/issues/4355)
## Checklist
* [ ] Usage documentation is included in Pajamas
* [x] Design specs are included in Pajamas
* [x] Component is built and styled in gitlab-ui according to specs
* [ ] Banner on vue tab that warns of incorrect styling is removed from Pajamas
* [ ] All demos and todos are complete
* [ ] Status is changed to `Built` in Pajamas
* [ ] Add a reference and link to the completed component in the [Engineer Week in Review](https://docs.google.com/document/d/1Oglq0-rLbPFRNbqCDfHT0-Y3NkVEiHj6UukfYijHyUs/edit) doc
| 3 |
4,456,656 | 19,773,326 |
2019-04-05 14:28:08.315
|
Allow linking to component usage and code documentation
|
### Problem
Following the pending changes in #101, it would nice to be able to link to component usage (_Design_) and code (_Vue Component_) documentation.
### Proposal
For example, the Button component could use (`/components/buttons/usage`) for usage documentation and (`/components/buttons/code`) for code documentation.
| 3 |
4,456,656 | 19,668,721 |
2019-04-02 23:48:49.586
|
Missing examples for color priority 4
|
Currently docs on colors say Priorities got from 1-4, then we only describe 3 of them. I assume 4 is `$color-50` and `$color-950`
Should we have priorities and/or usage examples for -400, -600, and the other unused ones?
| 1 |
4,456,656 | 17,894,891 |
2019-02-01 18:59:46.223
|
Homepage > Pajamas logo > Animation
|
Ensure the animation used on the homepage of design.gitlab.com is following our motion guidelines and/or update motion guidelines as needed.
---
The following discussion from !216 should be addressed:
- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/216#note_134646588): (+5 comments)
> Do these animations match our motion guidelines? Or do we need to add to our motion guidelines?
| 1 |
4,456,656 | 17,386,874 |
2019-01-16 11:20:18.283
|
Include a fallback for help links in empty state call to action design specifications
|
### Problem
Previously added empty states contained duplicate primary call to action buttons (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22745, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21975) but empty states are still being added with duplicate primary call to action buttons (see https://gitlab.com/gitlab-org/gitlab-ee/issues/9233, https://gitlab.com/gitlab-org/gitlab-ee/issues/9230).
### Proposal
Include a fallback for help links in empty state [call to action](https://design.gitlab.com/regions/empty-states#call-to-action) design specifications (see [helping users](https://design.gitlab.com/usability/helping-users)).
`CURRENT`
> - The call to action button in the empty state should be a primary button.
> - There is only one primary button since there can only be one primary button per form. If there is a need for more than one button, the other should be a secondary button.
`PROPOSED`
> - The call to action button in the empty state should be a primary button.
> - There is only one primary button since there can only be one primary button per form. If there is a need for more than one button, the other should be a secondary button.
> - If there is no need for a primary button or the primary button has already been added in the near components (see [tabs](/components/tabs)), there can be one or more help links within the description text (see [helping users](/usability/helping-users))
| 1 |
4,456,656 | 17,383,740 |
2019-01-16 09:41:40.636
|
Linking directly to (not component) markdown pages gives 404
|
### Problem
GET requests fail for all `/regions` pages. Try open the following URLs in a new tab:
- https://design.gitlab.com/regions/empty-states
- https://design.gitlab.com/regions/filters
- https://design.gitlab.com/regions/navigation
- https://design.gitlab.com/regions/search
| 1 |
4,456,656 | 86,814,665 |
2018-12-14 13:38:33.739
|
Discuss: How modals should work on mobile
|
Coming from: https://gitlab.com/gitlab-org/gitlab-design/issues/187
We should discuss further, how we should support modals on mobile, especially larger modals.
| 1 |
4,456,656 | 16,628,364 |
2018-12-13 10:59:57.196
|
Component: Add accessibility guidelines for invisible labels to forms documentation
|
As outlined in the [W3 guidelines](https://www.w3.org/WAI/tutorials/forms/labels/#hiding-label-text):
>A label for a form control helps everyone better understand its purpose. In some cases, the purpose may be clear enough from the context when the content is rendered visually. The label can be hidden visually, though it still needs to be provided within the code to support other forms of presentation and interaction, such as for screen reader and speech input users.
```
<label for="search" class="visuallyhidden">Search: </label>
<input type="text" name="search" id="search">
<button type="submit">Search</button>
```
| 1 |
4,456,656 | 54,043,461 |
2018-12-04 22:14:57.628
|
Empty state: design and layout
|
Stemming from a conversation on slack about empty states:
We need to reconsider the layout of empty states and how they refactor on smaller screens. Today the design documentation states:
#### Description
* If the description needs to wrap on desktop, align it to the left.
* If the title needs to wrap on desktop, align both the title and description to the left.
* If the title and description do not wrap on desktop, center them horizontally.
This is causing some compromises to the design of empty states. Instead, we should consider a layout that doesn't need to mix center-aligned and left-aligned titles and body copy.
@tauriedavis proposed this layout:
Which eliminates the need to have empty states who's headlining are center-aligned and left-aligned.
| 2 |
4,456,656 | 16,238,292 |
2018-11-30 10:50:16.537
|
Check for broken links
|
(Shamelessly copied from https://gitlab.com/gitlab-org/gitlab-ce/issues/51696)
### Problem to solve
Check for broken links, both **internal and external**
### Further details
- 404s are bad UX; we should check the docs to assure we don't have them
- The recent change to use the `#` led to broken links, as noted by the community on [Twitter](https://twitter.com/Citizen_Drain/status/1064886792657281024) and [LinkedIn](https://www.linkedin.com/feed/update/urn:li:activity:6473126444728872960/?commentUrn=urn%3Ali%3Acomment%3A(activity%3A6472126819968524288%2C6473126423233077248))
- There were some broken links that went unnoticed: https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/165
### Proposal
Implement a broken link checker, preferably in a job (not allowed to fail) that runs with the entire pipeline. As inspiration, checkout how GitLab Docs implemented their external link checker: https://gitlab.com/gitlab-com/gitlab-docs/merge_requests/360
### What does success look like, and how can we measure that?
:thinking: green pipelines == 100% success :stuck\_out\_tongue\_winking\_eye:
### Links / references
- Community noticing broken URLs on [Twitter](https://twitter.com/Citizen_Drain/status/1064886792657281024) and [LinkedIn](https://www.linkedin.com/feed/update/urn:li:activity:6473126444728872960/?commentUrn=urn%3Ali%3Acomment%3A(activity%3A6472126819968524288%2C6473126423233077248))
| 2 |
4,456,656 | 15,902,616 |
2018-11-16 14:37:00.439
|
Dropdowns have no accessibility and behavior documentation defined for small viewports
|
### Problem
Dropdowns have no accessibility and behavior documentation defined for small viewports
### Further information
| Current situation | visually improved situation | Actually accessible behaviour situation |
| --- | --- | --- |
|  |  |  |
Last mockup is based upon https://developer.apple.com/design/human-interface-guidelines/ios/controls/pickers/
Examples are based on designs from https://gitlab.com/gitlab-org/gitlab-ee/issues/2122
### Proposal
- Create documentation detailing accessibility and behavior for dropdowns
- Create pattern library assets supporting the documentation
#### What does success look like, and how can we measure that?
- Documentation is created detailing accessibility and behavior for dropdowns
- Pattern library is updated with assets supporting the documentation
| 3 |
4,456,656 | 15,646,520 |
2018-11-07 23:51:02.749
|
Mixed usage of automatic saving for radio buttons might create a brittle user experience
|
### Problem
Mixed usage of automatic saving for radio buttons might create a brittle user experience — as if anything can happen without warning
### Origin
*Follow-up from "adding radio buttons documentation" at https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/106#note_115355022*
The question was: Should or should users not expect radio buttons to yield immediate results?
### Further information
I made the case for them not to be (which is backed up by [nngroup](https://www.nngroup.com/articles/checkboxes-vs-radio-buttons/)), but @tauriedavis suggested otherwise (which is backed up by [existing UI in GitLab](https://gitlab.com/gitlab-org/design.gitlab.com/uploads/1eba37a0e276c02fd9c8bd96588df112/Screen_Shot_2018-11-07_at_11.50.46_AM.png)).
https://design.gitlab.com/foundations/saving-and-feedback comes into play here as it states we are anticipating saving by default as it has a positive impact on the perceived speed of the application. This is great but there is a potential discrepancies:
Documented safety measures only account for potential data loss. There is no documentation on how we handle feedback to the user that we will not auto-save data that might have a financial, security, or privacy impact before the user actually interacts with the element.
### Illustrating situations
When using radio buttons as an action
```mermaid
graph LR
A[User clicks element]
C[System performs action and saving is implied]
A --> C
```
<br>
Radio button usage done as documented
```mermaid
graph LR
A[User clicks element]
B[System saves state]
C[System gives feedback]
D[System performs action]
A --> B
B --> C
B --> D
```
<br>
Same situation but now handles sensitive information...
```mermaid
graph LR
Z[user sees element]
X[user is unsure if information <br> is saved immediately yes or no <br> when using the element]
A[User clicks element]
B[?]
Z --> X
X --> A
A --> B
```
### Quoted information from sources
from https://www.nngroup.com/articles/checkboxes-vs-radio-buttons
> Use checkboxes and radio buttons only to change settings, not as action buttons that make something happen. Also, the changed settings should not take effect until the user clicks the command button (labeled "OK" for example, or "Proceed to XXX" where "XXX" is the next step in a process).
> Conversely, violating the standards makes the user interface feel brittle — as if anything can happen without warning. Say, for example, that you assume you can click on a radio button without any immediate impact, and can thus consider your choices after making a selection but before hitting "OK." In such a case, it's jarring when a website violates this standard and unexpectedly moves you to the next page once you enter a selection. Worse, it makes you fear what may happen as you work with forms elsewhere on the site.
https://design.gitlab.com/foundations/saving-and-feedback
> Never apply to whole forms (example: adding a personal access token needs a name, expiration date, and access scope; it doesn’t make sense to auto-save the token name field individually). The auto-save method should ideally be only used for data that affects the user editing it. Auto-saving shouldn’t be applied to data that might have financial, security, or privacy impacts, example: changing password or changing the confidentiality of an issue.
> Instant feedback simply means that we show the expected result of a successfully saved change even before that change has actually been saved—we anticipate that the change will be saved successfully so we show it in the UI immediately. This has a positive impact on the perceived speed of the application. An example of a case when a successful result is expected is changing the assignee on an issue.
### How does success look like?
We prevent the user interface from feeling brittle when using radio buttons — as if anything can happen without warning
### Links/Mentions
@tauriedavis @matejlatin @pedroms (From prior discussion/involvement)
cc: @gitlab\-com/gitlab\-ux
| 3 |
4,456,656 | 14,702,839 |
2018-10-04 21:31:10.364
|
Follow-up from "Resolve "Component: Add Toast documentation""
|
The following discussion from !41 should be addressed:
- [ ] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/design.gitlab.com/merge_requests/41#note_105879603): (+4 comments)
> Why does the dismiss icon act different if there are 1 vs. 2 lines?
- [ ] @dimitrieh
>I feel we should just do away with dismiss actions.
>
>The text button next to an icon button feels out of place/inconsistent. A group of buttons should either be all text or all icons.
>
>Also taken from [material design guide lines](https://material.io/design/components/snackbars.html#usage):
>
>> Snackbars inform users of a process that an app has performed or will perform. They appear temporarily, towards the bottom of the screen. They shouldn’t interrupt the user experience, and they don’t require user input to disappear.
>>
>> Frequency
>> Only one snackbar may be displayed at a time.
>>
>> Actions
>> A snackbar can contain a single action. Because they disappear automatically, the action shouldn’t be “Dismiss” or “Cancel.”
| 1 |
4,456,656 | 11,902,702 |
2018-06-11 06:25:10.492
|
Use HTTPS protocol for design.gitlab.com
|
While the description of https://gitlab.com/gitlab-org/design.gitlab.com has a link to `http://design.gitlab.com`, it should be `https://design.gitlab.com`.
| 1 |
4,456,656 | 11,796,707 |
2018-06-07 15:01:42.441
|
Add the Law of Proximity Gestalt principle to the Layout > Spacing page
|
Based on this [discussion on Slack](https://gitlab.slack.com/files/UA7DGQSAZ/FB3HHAJJ3/image.png) we concluded that we should add the [Law of Proximity](https://en.wikipedia.org/wiki/Principles_of_grouping#Proximity) Gestalt principle somewhere in our Design System.
>"objects or shapes that are close to one another appear to form groups". Even if the shapes, sizes, and objects are radically different, they will appear as a group if they are close.
*In [this particular case](https://gitlab.com/gitlab-org/gitlab-ce/commits/issue_44230): A button that navigates to another page, a search box and a 'Subscribe to RSS' button, three things that are completely unrelated seem like they are because of their placement on the page. This makes our interfaces unintuitive and harder to adopt.*
Atm, our interfaces seem cluttered sometimes and one of the common issues is that we group together things that aren't related. We'll add this principle that is commonly used in graphic and UI design to guide us and prevent this from happening in the future.
| 1 |
4,456,656 | 10,626,557 |
2018-05-02 15:08:14.564
|
Write guidelines for text colours in Typography section
|
I recently noticed that the quotes text colour is way too light on white background and hard to read (gitlab-org/gitlab-design#147). I think we should write down the guidelines for text colours: what is the default text colour, what is the lightest shade allowed to use on the white background. These guidelines should be aligned with the [accessibility standards](https://webaim.org/resources/contrastchecker/).
| 1 |
4,456,656 | 9,584,616 |
2018-03-06 12:19:40.871
|
Written content of the DS should follow the documentation writing guidelines
|
When people are contributing written content to the DS, we should have some guidelines in place so the writing is consistent.
@rebecca suggested we use https://docs.gitlab.com/ee/development/documentation/styleguide.html
Maybe we can put a link for that in https://gitlab-org.gitlab.io/design.gitlab.com/getting-started/contributing/
| 1 |
4,456,656 | 9,478,103 |
2018-02-27 19:03:17.965
|
Design Pattern Library - Component: Links
|
Add a new component for links.
This should include documentation related to styles and usage of anchors as well as documentation regarding truncation of links.
Transfer/update existing information regarding anchors: https://docs.gitlab.com/ee/development/ux_guide/components.html#anchor-links
Related: https://gitlab.com/gitlab-org/gitlab-design/issues/122
- Buttons vs links: https://gitlab.com/gitlab-org/gitlab-ce/issues/21287#note_17099288
- https://gitlab.com/gitlab-org/gitlab-ce/issues/21287#note_16963426
| 3 |
4,456,656 | 34,692,858 |
2017-09-29 15:43:54.784
|
Design for Tabs within tabs (contextual tabs)
|
### Overview
We can several places in GitLab where we have top-level tabs for categories but we need further context within and thus we use tabs under the content of top-level tab. One such example is on `/dashboard/projects` page which looks like this;
Tabs inside tabs is very common UX pattern and it is generally preferred to have slightly different design for _sub-tabs_ than the one you have to main tabs.
#### See the discussions around this design in following threads on StackExchange.
* [Is there evidence to suggest that designing tabs within tabs creates a bad user experience?](https://ux.stackexchange.com/questions/5136/is-there-evidence-to-suggest-that-designing-tabs-within-tabs-creates-a-bad-user)
* [Elegant, simple and obvious sub-tabs?](https://ux.stackexchange.com/questions/16281/elegant-simple-and-obvious-sub-tabs)
#### Proposal
Let's discuss possible alternative designs (or reasoning behind current design) :smiley:
I think [Bootstrap Pills](https://getbootstrap.com/docs/3.3/components/#nav-pills) are ideal choice when we want to have nested tabs but I'll leave our options open. :slight_smile:
Although I've put together a quick mock up on CodePen which uses Pills under Tabs, check it out [here](https://codepen.io/kushalpandya/pen/zEzEbP).
| 5 |
4,456,656 | 88,587,801 |
2021-06-11 16:13:20.077
|
Progress bar > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the progress bar component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,587,800 |
2021-06-11 16:13:19.872
|
Popover > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the popover component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,587,799 |
2021-06-11 16:13:19.670
|
Path > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the path component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,587,798 |
2021-06-11 16:13:19.473
|
Pagination > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the pagination component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,587,797 |
2021-06-11 16:13:18.503
|
Modal > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the modal component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,766 |
2021-06-10 22:36:03.504
|
List > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the list component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,765 |
2021-06-10 22:36:03.309
|
Label > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the label component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,764 |
2021-06-10 22:36:03.120
|
Infinite Scroll > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the infinite scroll component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,763 |
2021-06-10 22:36:02.903
|
Form > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the form component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,762 |
2021-06-10 22:36:02.703
|
Filter > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the filter component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,761 |
2021-06-10 22:36:02.510
|
File Uploader > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the file uploader component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,760 |
2021-06-10 22:36:02.312
|
Dropdown > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
- Update the dropdown component usage tab to be in alignment with the template changes.
- Update the content to align with the [results of the accessibility audit](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1534) where we need to specify the _type_ of dropdown and it's purpose to make the use cases semantically different.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,759 |
2021-06-10 22:36:02.113
|
Drawer > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the drawer component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,758 |
2021-06-10 22:36:01.888
|
Date picker > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the date picker component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,757 |
2021-06-10 22:36:01.682
|
Checkbox > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the checkbox component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,756 |
2021-06-10 22:36:01.330
|
Card > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the card component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,753 |
2021-06-10 22:36:00.767
|
Breadcrumb > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the breadcrumb component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,752 |
2021-06-10 22:35:59.836
|
Banner > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the banner component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,544,748 |
2021-06-10 22:35:58.172
|
Accordion > Update docs to utilize new template
|
## Background
As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages.
## Resources
See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure.
## Proposal
Update the accordion component usage tab to be in alignment with the changes.
This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
| 1 |
4,456,656 | 88,530,002 |
2021-06-10 15:13:52.856
|
Remove Helm 3 upgrade CI config
|
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2411, we introduced a temporary config to upgrade review apps and production environment from Helm 2 to 3. We need to keep this config for a while to make sure all existing review apps can be migrated to Helm 3 by running the `review:helm-2to3:migrate` manual job. Once we are confident that all review apps have been migrated or shut down, we can clean up the CI config by reverting https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2411 altogether.
/cc @hfyngvason
| 1 |
4,456,656 | 88,430,693 |
2021-06-09 05:43:02.007
|
Design: Mini pipeline graph component
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
The mini pipeline graph appears in multiple places in the product, but it's actually not one single component but multiple instances with varying functionality. It leads to a lot of inconsistency since the updates to one instance don't propagate to the rest of the instances. Having a single mini pipeline graph component will ensure consistency of experience across the product and make it easier to implement further improvements.
| Mini pipeline graph in MR widget |
| ------ |
|  |
#### Audit of current component instances
:link: [Audit: Mini Pipeline Graph Components](https://gitlab.com/gitlab-org/gitlab/-/issues/332948)
The goal of this issue is to document the mini pipeline graph component and its behavior with minor updates that improve the visual consistency and usability. Any big updates will be addressed as a follow-up.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
:art: [View working file in Figma →](https://www.figma.com/file/s7EYyAa9fs0nVrkT5s8mEg/Mini-pipeline-graph-component?node-id=1%3A70)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: Move your working file to the shared Figma project:
1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [x] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [-] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template
to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
| 3 |
4,456,656 | 88,238,523 |
2021-06-04 21:02:46.860
|
Icon component names and export components as SVG
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
On the "Icons" page, I've corrected all layer and component names to have the same name as the label next to the icon (such as renaming from "chevron-double-left-lg" to "chevron-double-lg-left". This will also affect the export name. Along side this, I've ensured that all icon components will export as a .svg file.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/JBXlrIpgRBr9kIp0I3lSR6/GitLab-Component-Library-Community?node-id=16%3A127)
### Checklist
Make sure the following are completed before closing the issue:
1. [ ] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [ ] **Assignee**: Update the link to the working file in the issue
description.
1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: Move your working file to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template
to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
| 3 |
4,456,656 | 88,218,996 |
2021-06-04 13:06:52.884
|
Review navigation specs
|
The following discussion from !2386 should be addressed:
- [ ] @tomquirk started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2386#note_592680887): (+1 comment)
> **suggestion (non-blocking)**: I guess we should have a spec or to that tests the `isExpanded` state. Not critical though :shrug:
---
Let's drop the snapshot tests in favor of more relevant specs that won't fail every time we update the navbar.
| 1 |
4,456,656 | 88,166,153 |
2021-06-03 14:39:38.731
|
Styles leaking into component examples
|
When trying to implement `gl-markdown` wrapper on content pages, the component examples inherited some markdown styles.
| 3 |
4,456,656 | 87,943,540 |
2021-05-31 03:12:25.114
|
Update presentation of when to use and not to use a selection component
|
With the update to the toggle documentation https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2356 we have opted to remove the table to make a decision between form components in favour of sections `Usage` and `Do not use a toggle when`.
Components that should be updated:
- [ ] Single checkboxes https://design.gitlab.com/components/checkbox
- [ ] Single-select dropdown https://design.gitlab.com/components/dropdown
- [ ] Radio buttons https://design.gitlab.com/components/radio-button
- [ ] Segmented control https://design.gitlab.com/components/segmented-control
- [ ] Multiple checkboxes https://design.gitlab.com/components/checkbox
- [ ] Multi-select dropdown https://design.gitlab.com/components/dropdown
| 3 |
4,456,656 | 87,830,111 |
2021-05-27 16:59:39.407
|
Getting Started > Structure > Audit and update language
|
As our system grows, we're adding more complex elements such as object that include conceptual models and layouts in addition to regions.
We want to ensure that definitions for each of these are clear to ensure that it is understandable where to add new elements that are larger than individual components.
## Proposal
Audit the [Getting Started > Structure](https://design.gitlab.com/get-started/structure) page for clarity. The end result should be a general understanding of what makes something a component vs. a region vs. an object.
| 2 |
4,456,656 | 87,309,332 |
2021-05-18 20:21:55.583
|
Figma > Markdown type assets
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](ADD LINK TO FIGMA FILE/FRAME)
### Checklist
Make sure the following are completed before closing the issue:
1. [ ] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [ ] **Assignee**: Update the link to the working file in the issue
description.
1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: Move your working file to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 3 |
4,456,656 | 87,205,658 |
2021-05-17 14:14:00.042
|
Figma update: add description to Toggle like input field
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
This is updated Toggle with the description below labels as a result of [previous issue](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=425%3A140)
| Old | New |
| --- | --- |
|  ||
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file-sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/05EuMYkJptunHUcVHPcSA8/Untitled?node-id=1%3A375)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: Move your working file to the shared Figma project:
1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. ~~[ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.~~
1. ~~[ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file]~~(https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. ~~[ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.~~
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 3 |
4,456,656 | 87,036,969 |
2021-05-13 14:07:18.818
|
Pajamas nav > Reconsider parent item function
|
## Purpose
In the Pajamas navigation a parent item both expands the subnav and takes a user to the first page of the subnav with the same click. Given that we don't make use of section overview pages this behavior feels a bit odd and misleading. While it's not difficult to determine where you landed, I don't think it's the most intuitive. It can also create a delay when you only wanted to access a page within that category, but have to wait for the first page to load before navigating where you wanted.
I'd like to propose that the parent item only expands/collapses the subnav list and does not have it's own destination.
| 1 |
4,456,656 | 87,036,283 |
2021-05-13 13:55:45.918
|
Consider dropping the use of details/summary in the navbar
|
The following discussion from !2371 should be addressed:
- [ ] @jeldergl started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2371#note_574973550): (+3 comments)
> The use of `details` and `summary` here feels out of place semantically. I need to test this in a screen reader, but I'm wondering what the reason is for using it?
The navbar currently leverages `<details>` and `<summary>` elements to render collapsible menu items. This might not be a valid use-case for those elements, let's consider dropping them in favor of simple `v-if`s in the Vue components.
## Implementation plan
- [x] Drop the use of summary elements in favor uls and v-ifs.
- [x] Do not automatically select the first child item when clicking on a parent.
- [x] Keep the behavior where only one menu section can be expanded at a time.
- [x] Improve navbar's accessibility by leveraing `role` and `aria-` attributes.
| 2 |
4,456,656 | 86,539,036 |
2021-05-05 16:47:04.114
|
Adjust navigation items under Data Visualization
|
Here is the current nav under data visualization in Pajamas:
From discussion on https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2361#note_568114665, it sounds like the order of pages is because the nav items are automatically placed in alphabetical order. In this section, that leaves us with a surprising result - the Overview item is third and the more detailed pages (Charts, Color) are first.
Should we consider re-ordering the pages in this section based on content rather than alphabetizing?
If so, perhaps the order could be:
- Overview
- Color
- Charts
- Single stat
| 1 |
4,456,656 | 86,503,119 |
2021-05-05 09:18:26.731
|
Document a conceptual object model for Jobs
|
## Problem
Jobs are the main building block of a pipeline. Understanding the essence of Jobs and the concepts associated with them can help us create a better experience around Jobs in GitLab UI. Currently, Jobs are not documented as an object in GitLab. It's difficult to find information around all the concepts associated with jobs and how they're represented in the UI.
## Proposal
Document Jobs using the Conceptual Object Model.
This model allows for proper separation of concerns: concepts (meaning) and user interface (representation). In other words, a conceptual model is only focused on the concepts and how they relate to each other, not how it’s technically implemented or used in the UI. A conceptual model defines the objects and actions, and enumerates the attributes for every object. The language of the conceptual model diagram is meant to be as simple and accessible as possible to everyone, even if they are not familiar with these kinds of diagrams (for more information, see [Object Modeling for Designers](https://medium.com/@hpadkisson/object-modeling-for-designers-an-introduction-7871bdcf8baf).
Here's an example of how we document the [Merge Request as an object in GitLab.](https://design.gitlab.com/objects/merge-request)
#### Next steps
- [x] Document the concepts associated with Jobs
- [x] Map the concepts associated with Jobs
- [x] Document the layouts for the representations of Jobs in GitLab
- [x] Review the Figma file
- [x] Merge to the Conceptual object model file in Figma
- [x] Map the primary Job page layout
- [x] Merge the semantic layout to the Layouts file
- [x] Work on a documentation MR ([MR in review](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2713))
## Working Figma files
* [Job object model](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/branch/bMpqqGQtDoPqty4sAFPUsy/Conceptual-model?node-id=5423%3A453)
* [Job semantic layout](https://www.figma.com/file/shVF8UZwrQtkNfMDjcrsyH/branch/PZruVNvWVcpdNwm69cXgeJ/Semantic-layouts?node-id=4636%3A208)
| 3 |
4,456,656 | 86,477,742 |
2021-05-04 20:35:08.417
|
Themes > Adding missing color palettes
|
Within Pajamas, Figma, and GitLab-UI we define a series of color palettes for each of our available themes. However, we are missing all of the options that are currently available in the product:
Ensure there is continuity between the options in the product and the palettes in Pajamas.
| 2 |
4,456,656 | 86,245,699 |
2021-04-29 20:09:27.201
|
A11y action > Increase input placeholder contrast
|
## Purpose
Placeholder text within a text input should have sufficient contrast (at least a 4.5:1 ratio).
## Solution
Use `$gray-500` for `placeholder` text.
This should be updated both in Figma and GitLab UI.
Source: https://gitlab.com/gitlab-org/gitlab-design/-/issues/1475#note_550956831
| 1 |
4,456,656 | 86,201,104 |
2021-04-29 09:11:31.477
|
add description to Toggle like input field
|
### Problem
I have a need to use a long description to explain what does this toggle is about instead of short help text like "disabled by admin". If I use the help text, it looks like this:
Those live example copies need to be refined. But the length and format illustrate the problem we will face. Long copy and copy with "learn more". I think we should discuss this because in English the copy might be short, but in another language, a two-line description might be common when we face German or another lengthy language.
| Live Example | Component |
| --- | --- |
| | |
**This has two problems:**
1. The description is far from the label it belongs to and closer to the label of the next item. This creates more cognition load for a user to figure out, this description belongs to which one?
1. It is too long and visually looks unbalanced
### Solution
| vertical1 - Live Example | vertical1 - Component |
| --- | --- |
|  |  |
<details><summary>Other explorations</summary>
| vertical2 - Live Example | vertical2 - Component |
| --- | --- |
|||
| horizontal Live Example | horizontal - component |
| ------------ | --------- |
|   |  |
| | |
</details>
cc: @gitlab-com/gitlab-ux/designers
| 3 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.