idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
|---|---|---|---|---|---|
4,456,656 | 86,162,773 |
2021-04-28 18:54:54.496
|
A11y action > Update audit issues to include severity rating
|
# Proposal
We have a number of [accessibility audit issues](https://gitlab.com/groups/gitlab-org/-/epics/5387) open. We should include a severity rating for each finding.
# Background
> One thing I haven’t included in the audits I’ve done so far is the level of severity. I’ll try to do that from now on.
>
> This is the same I’ve used before:
>
> - **Critical:** prevents some or all users from performing critical tasks with no workaround.
> - **High:** prevents some users from performing critical tasks, or where a workaround may exist.
> - **Medium:** prevents some users from performing non-critical tasks, or where the user experience is seriously degraded for users with certain assistive technologies.
> - **Low:** the user experience is degraded for users with certain disabilities or using certain assistive technologies.
>
>This is the rating Deque proposes:
>
>- **Critical:** This issue results in blocked content for individuals with disabilities. Until a solution is implemented content will be completely inaccessible, making the organization highly vulnerable to legal action.
>- **Serious:** This issue results in serious barriers for individuals with disabilities. Until a solution is implemented, some content will be inaccessible, or significant a work-around is required, making the organization vulnerable to legal action. Users with disabilities may experience significant frustration when attempting to access content.
>- **Moderate:** This issue results in some barriers for individuals with disabilities but would not prevent them from accessing fundamental elements or content. Users with disabilities may experience moderate frustration when encountering this issue.
>- **Minor:** This is an issue that may inconvenience a user but would not cause significant frustration in accessing content or accomplishing tasks.
Source:
https://gitlab.com/gitlab-org/gitlab-design/-/issues/1473#note_545158557, https://gitlab.com/gitlab-org/gitlab-design/-/issues/1473#note_545159441
~accessibility ~"Category:FE/UX Foundations"
| 1 |
4,456,656 | 86,162,768 |
2021-04-28 18:54:53.881
|
A11y action > Add content to Forms > Placeholders
|
# Proposal
Add documentation to ` Forms > Placeholders` that describes the following:
> the intended use of placeholder text is for extra, non-essential information
# Background
>the intended use of placeholder text is for extra, non-essential information.
>
>>I like this little nugget and I think it’d be worth adding something similar in an update to https://design.gitlab.com/components/form#placeholders.
Source: https://gitlab.com/gitlab-org/gitlab-design/-/issues/1470#note_538076572
~accessibility ~"Category:FE/UX Foundations"
| 1 |
4,456,656 | 86,162,754 |
2021-04-28 18:54:51.567
|
A11y action > Inclusive design presentation
|
# Proposal
Create a presentation that addresses inclusive design and showcase it to the UX Department in order to increase awareness of biases.
@jeldergl is currently working on a presentation that would be a good fit to satisfy this.
# Background
>Some training on how to recognize bias in design would be helpful. In other words, evaluating design against our own bias and examine if we’re meeting the needs of more than just those like us — whatever that us may be.
Source: https://gitlab.com/gitlab-org/gitlab-design/-/issues/1463#note_499957432
~accessibility ~"Category:FE/UX Foundations
| 4 |
4,456,656 | 85,846,218 |
2021-04-23 20:42:01.871
|
Dig into whether or not the status table is accurate
|
As per discussion with Taurie: There is some concern that the [component status table](https://design.gitlab.com/components/status) isn't totally up-to-date.
The goal for this issue would be to go through the [existing status table](https://design.gitlab.com/components/status) and dig into the `in progress` items to see if they can actually be moved to complete.
| 3 |
4,456,656 | 85,755,120 |
2021-04-22 15:10:38.328
|
Extend guidelines on labels
|
Discussion
---
[Labels](https://docs.gitlab.com/ee/user/project/labels.html) in GitLab have historically been tightly coupled with Issues, Epics, and Merge Requests ~"group::project management". There are other use cases (Compliance Frameworks or Topics) in GitLab where users are creating elements to categorize objects that would benefit from using [label](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-label--default) the component.
> Scoped labels are a sub-type of labels, and their usage is determined by the user. A scoped label is differentiated from a regular label by the contrasting colors on the left and right sides of the label. - [Pajamas](https://design.gitlab.com/components/label/#usage)
Pajamas merely states that there is only a differentiation in the UI, but there is a unique feature tied to [exclusivity](https://docs.gitlab.com/ee/user/project/labels.html#scoped-labels) in scoped labels for project management. Compliance Frameworks are currently using scoped labels just for visual flair, although it is not possible to apply more than one Compliance Framework to a project today.
When considering the `scoped label` attribute, should this UI element always have exclusivity as a corresponding feature?
| 1 |
4,456,656 | 85,687,189 |
2021-04-21 17:40:35.935
|
Brand > Combine brand basic and resources
|
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2345, `@ameliabauerly` mentioned that we could combine the Brand basics and Resources content into one page. We could add those links to the bottom of the Brand > Basics page and not need an entirely separate page for them.
| 1 |
4,456,656 | 85,687,107 |
2021-04-21 17:38:54.431
|
Brand personality / Design principles table
|
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2345, we are removing outdated brand pages that are no longer shown in the sidebar. This includes the following table:
Should we include this somewhere within our brand docs or possibly use it to better define our design principles?
| 2 |
4,456,656 | 85,592,955 |
2021-04-20 19:58:52.988
|
Collapse sidebar after navigation on mobile devices
|
The following discussion from !2301 should be addressed:
- [ ] @oregand started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2301#note_556227195): (+3 comments)
> @pgascouvaillancourt
>
> Great work on this, it looks super and feels great to use! I have left a selection of comments for you to check at your own time but your overall approach looks good to me here given the constraints you're working against with the keys && file boostrapping :smile:
>
> I was going to ask if we had supporting specs but see we don't have them in this repo yet :joy:
>
> One ~UX suggestion, we might want to auto close the sidebar on navigation from the search when we're on mobile but that's a non-blocking suggestion!
>
>
> 
---
On mobile devices, the navigation sidebar can be expanded and overlaps the primary content. From there, clicking any link properly triggers navigation through `vue-router`, but the sidebar remains expanded, hiding the content that's being accessed.
Let's improve the ~UX by automatically collapsing the sidebar whenever navigation occurs.
| 2 |
4,456,656 | 85,279,391 |
2021-04-15 23:56:05.764
|
Figma component > Table (updates to sorting and additional states)
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
## Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
This is a follow up issue to [Figma component > Add Tables](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/721). The table currently is still missing responsive states and is not leveraging some of Figma's newer layout features.
### Summary of overall table updates:
- All cell content is now `top` aligned by default
- The sorting arrow has been moved closer to the right of the header label, in order to make it clear which header label they belong to
- On hover and on focus states have been to header cells if the configuration is set to sortable
- A new 'compressed` table option has been added (https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/449)
- A new row state has been added (https://gitlab.com/gitlab-org/gitlab-ui/-/issues/884)
- A new `<caption>` component has been added (https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1726)
- A top border has been added to the header row in order to better visual understand where the table starts and ends on a page
### Summary of Figma specific updates:
Since the first version of the Figma Table component that has been added to our component library, Figma has introduced many new features specific to [Auto Layout](https://help.figma.com/hc/en-us/articles/360040451373-Create-dynamic-designs-with-auto-layout) that make creating tables more flexible. This update will make it easier for designers to create responsive tables in Figma that are easier to customize and lower the need to detach from parent components.
**Sorting interaction spec:**
### Rationale for current updates
| Overall component usage (last 90 days) | Variants being used (last 90 days) |
| ------ | ------ |
|  |  |
| **Insights:**<br>In the first version of the table component a lot of time was put into creating the multi-line variant which shows no usage. | **Insights:**<br>The checkbox variant is the second most used. This newer update makes it easier to turn on/off the selectable state for entire rows. |
Note: Thank you @jeldergl for pulling these metrics from Figma.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/Wli6qiEaC8rnXfeQiukJHw/Component-library?node-id=425%3A11)
### References
- https://getbootstrap.com/docs/5.0/content/tables/
- https://mdbootstrap.com/docs/b4/jquery/tables/sort/
- https://material.angular.io/components/table/overview#sorting
- https://material.io/components/data-tables#anatomy
### Demo walkthrough
- :tv: https://youtu.be/7tEa-qT_MfY
---
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template
to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
| 2 |
4,456,656 | 84,821,078 |
2021-04-07 20:17:15.813
|
FY22-Q2 Foundations KR2: Create a maintained backlog of Pajamas issues that enables product designers and engineers to easily find issues and contribute => 79%
|
[FY22-Q2 UX Department: Foundations SubTeam OKR](https://gitlab.com/groups/gitlab-org/-/epics/5726)
Objective: Ensure Engineering is able to iteratively contribute to and utilize Pajamas for stage work deliverables
**KR2: Create a maintained backlog of Pajamas issues that enables product designers and engineers to easily find issues and contribute**
- [x] Ensure all issues within the Pajamas repo have a workflow label. See our [workflow label board](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/boards/1835632) 336/336 => 100%
- [ ] Ensure all issues within the Pajamas repo have a weight. See [issues without weights](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues?scope=all&state=opened&weight=None) 197/336 => 18%
533/672 => 79%
| 13 |
4,456,656 | 82,133,985 |
2021-04-01 16:22:35.504
|
Figma > Form > Add form_input_group
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
`form_input_group` was introduced in GitLab UI (https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2115) which includes a form input that is grouped together with another element, such as a label or button.
This component is being used on the `new fork` page, see https://gitlab.com/gitlab-org/gitlab/-/merge_requests/53544
We don't currently have this component within our UI Kit and the styling in GitLab UI does not match our visual language.
The purpose of this issue is to get the component within Figma, and then to open up the needed issues in GitLab UI to correct the styling.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/cdUPbjyDRc326Rk6KGyxKw/Component-library) (Branch is archived after merge)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: ~~Ask a [FE/UX Foundations designer][foundations-team]~~ Assigned to Figma trainee
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: Move your working file to the shared Figma project:
1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [x] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 3 |
4,456,656 | 81,860,969 |
2021-03-29 16:11:53.212
|
Include GitLab UI utilities
|
The following discussion from !2300 should be addressed:
- [ ] @markrian started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2300#note_540028499): (+2 comments)
> **question (non-blocking)**: A quick grep suggests we don't use GitLab UI's utility classes in this repo. Should we?
| 1 |
4,456,656 | 81,418,386 |
2021-03-22 14:45:44.188
|
Badge > Linked badges > Make examples in Pajamas the SSoT
|
## Problem
Embedded badge examples in Pajamas are different from GitLab UI. Having a SSoT will help accurately complete the badge accessibility audit https://gitlab.com/groups/gitlab-org/-/epics/5664.
| **Pajamas** | **GitLab UI** |
| ------ | ------ |
|  |  |
## Solution
Ensure badge examples align with the [badge design specs](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=425%3A3) and that action badges dont underline text on hover.
| 2 |
4,456,656 | 81,248,852 |
2021-03-19 03:53:26.938
|
Update guidelines around left menu items
|
- [x] Guidelines around what the menu items in the left sidebar
- https://design.gitlab.com/regions/navigation#contextual-navigation
- What should be a primary level item vs secondary
- Updated: https://design.gitlab.com/regions/navigation#left-sidebar
- ⛔️ Should "Labels" be allowed to jump between a submenu item to parent level? https://gitlab.com/gitlab-org/gitlab/-/issues/21147#note_525491995
- We are putting Labels into `Project information` https://gitlab.com/gitlab-org/gitlab/-/issues/329905
- [x] Landing pages should be the first sub menu item
- https://design.gitlab.com/regions/navigation#product-landing-pages
## Draft outline
### Parent item
### Submenu items
- Items in the submenu should help support navigation to the parent JTBD and supporting JTBD
- High level features of the category
| 3 |
4,456,656 | 81,245,967 |
2021-03-19 03:15:30.567
|
Update documentation for global navigation
|
## Proposal
Relates to this page https://design.gitlab.com/regions/navigation#global-navigation
- [ ] Update documentation for the consolidated projects/group/more menu
- [ ] Add example of the menus mentioned
~"Category:Navigation & Settings"
| 2 |
4,456,656 | 80,557,737 |
2021-03-09 13:55:08.340
|
Update the dropdown component with variants and add missing variants
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
@lvanc and I noticed that there are some cases are missing in our current dropdown component while adding the filter component. https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/720
We can add this to the existing component as variants or/and instances.
And switch to the variants style structure and make the component more flexible.
| Icon + Text | Text + Help text | User profile |
| ------ | ------ | ------ |
| |  |  |
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/2OhkWPJsIE6FSbaTugAVPw/Component-library?node-id=425%3A14)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: Move your working file to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 2 |
4,456,656 | 80,543,959 |
2021-03-09 10:32:29.713
|
Update segmented control visual style
|
### Description
create consistent button styles
| Before | New |
| ------ | --- |
|  |  |
#### Visual Design Changes
- Selected states: remove shadows, used a border to indicate selection
- Hover status: a light grey background $gray-50
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/7FLQ3LnDhj3vI7QnGAkTjn/Component-library)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [-] **Assignee**: Move your working file to the shared Figma project: (File automatically archived since it was a branch.)
1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [-] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [x] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 3 |
4,456,656 | 80,101,565 |
2021-03-02 15:01:16.599
|
Update Figma text input to use variants
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
Figma introduce variants, it is time to update the text input field
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/OU6DPkNlneFHnXwcUILWfl/WIP-Update-input-text-field?node-id=1%3A2)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: Move your working file to the shared Figma project:
1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [x] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [x] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [-] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [-] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 4 |
4,456,656 | 79,233,372 |
2021-02-17 03:19:08.833
|
Document tree updates in Pajamas [Tree🌲]
|
Document any changes to the tree component here to be merged into [Pajamas](https://design.gitlab.com/product-foundations/interaction#drag-and-drop}https://design.gitlab.com/components/tree).
#### 📌 Merge requests
* ....
#### ✨ Overall change highlights
* ...
| 3 |
4,456,656 | 86,894,837 |
2021-02-12 17:07:47.583
|
Introduce search to Pajamas
|
As part of our [Pajamas engagement survey](https://gitlab.com/gitlab-org/gitlab-design/-/issues/1394), we heard that people would like to be able to search through Pajamas to find exactly the information they need.
How do we go about introducing search to Pajamas?
| 3 |
4,456,656 | 78,823,017 |
2021-02-10 15:30:54.588
|
Document drag and drop updates in Pajamas [Drag & drop🤏]
|
Document any changes to drag & drop here to be merged into [Pajamas](https://design.gitlab.com/product-foundations/interaction#drag-and-drop).
#### :pushpin: Merge requests
- https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1941
- ....
#### :sparkles: Overall change highlights
- ...
| 3 |
4,456,656 | 78,444,893 |
2021-02-04 16:49:34.972
|
Create live figma embed for form-group submit button behavior
|
Based on my confusion of some documentation, I thought it would be worthwhile to add some visual clarity to what we're explaining, specifically for behaviors.
| 2 |
4,456,656 | 78,193,008 |
2021-02-01 10:22:17.161
|
Update Figma tooltip component with Variant
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross-reference everything that has been completed. -->
I worked a lot recently with a tooltip. I found that the current component is not very easy to use because:
1. I need to detach it every time because the container doesn't auto grow with the text
1. After detach, I need to resize it and not very easy to keep the spacing manually
1. I need to hide/show arrows in the layers instead of using a variant
So I updated the tooltip component structure with variants, now it can auto grow, two lines just need to hit enter and use different arrow position can be chosen from variants manual on the right-hand side. Please see the picture below :point_down: or watch this [`video intro`](https://www.loom.com/share/bd509b045e8e41f5ae4eb29fc22fb32f).
| Current component | Updated component by using variants |
| --- | --- |
|  | |
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/nmpl8tphpsmcDlMYfiviOS/Tooltip-component-update-Pajama-805?node-id=1%3A2)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: Move your working file to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 2 |
4,456,656 | 77,550,425 |
2021-01-20 14:23:00.232
|
chore: Point gitlab-ui status links to Storybook
| null | 2 |
4,456,656 | 77,176,298 |
2021-01-13 16:46:21.198
|
Guideline to open help links in new tab or not
|
In the [helping users](https://design.gitlab.com/usability/helping-users) section of the pajamas, we make use of two kinds of text links. While it's clear what the text should be, there's no guideline whether that link should open in a new tab or not.
We do however have some general guidelines about [external links](https://design.gitlab.com/product-foundations/interaction/#links-to-external-resources).
## More details
I personally am in favor of the new tab functionality, and this makes sense for GitLab.com where we now redirect all help links to the external site https://docs.gitlab.com.
For self-managed instances however, the help links still point to the `/help` page of the instance.
## Accessibility issues
Best practice for accessibility by default is to use native browser behavior and open in the same window.
Once `target="_blank"` is used it disables all other browser options, so it’s best to let the user choose.
## Resources
- https://css-tricks.com/use-target_blank/
- Docs guidelines on links https://docs.gitlab.com/ee/development/documentation/#linking-to-help
| 1 |
4,456,656 | 76,702,013 |
2021-01-04 14:19:33.381
|
Form: multi-column/row of grouped options in forms
|
### Background
This is an issue created based on [another issue](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues). Before we document something we agree on, we want to explore different solution options.
### Problem
In some areas, the user needs to set up complicated settings, such as variable sets with some details fine-tuning. Each variables settings is a group, and users need to see them together to have a better overview or comparing different variable groups.
The design needs to be flexible for desktop and mobile, easy to read and identify the groups.
| Example 1 | Example 2 |
| --------- | --------- |
|  |  |
### Solution
| Option 1 - Row grouping | Option 2 - Column grouping | Option 3 -??? |
| --------- | --------- | -------- |
|  |  | |
| | | |
| 3 |
4,456,656 | 76,385,293 |
2020-12-22 13:01:27.956
|
Examples are sometimes loaded from an incorrect component
|
In https://design.gitlab.com/components/accordion/code, the examples are loaded from `GlAccordionItem` instead if `GlAccordion`.
| 1 |
4,456,656 | 73,936,334 |
2020-11-05 19:45:18.779
|
Content section > Determine how to dedupe documentation with doc styleguide
|
# Problem
There are currently multiple places where we have content guidelines including:
* Pajamas: [Punctuation](https://design.gitlab.com/content/punctuation), [Terminology](https://design.gitlab.com/content/terminology), [Voice and tone](https://design.gitlab.com/content/voice-tone)
* Docs: [Styleguide](https://docs.gitlab.com/ee/development/documentation/styleguide.html)
* Handbook: [Styleguide](https://about.gitlab.com/handbook/style-guide/), [Markdown](https://about.gitlab.com/handbook/markdown-guide/)
There is repeated content in all of these sections, making it difficult to know when to go where for what.
We've started trying to harmonize this content between the different areas, which is resulting in content that is not DRY. For example, see https://gitlab.com/gitlab-org/gitlab/-/merge_requests/26326 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2148.
Tech writing has started to look at both styleguides and align them here: https://gitlab.com/gitlab-org/gitlab-docs/-/issues/636. However, we need to determine the IA in order to ensure that we are not continuing to duplicate content over time.
# Solution
Determine how to dedupe content docs in all various locations. This could include:
- Moving all content docs to one area
- Pros: Everything is in one place, you always know where to go to find what you need. Content isn't duplicated.
- Cons: There are separate use cases for docs and product, so the documentation in this section could be expansive. Good IA would be needed so its easy to find details.
- Keeping documentation docs and product docs separate, with clear cross-linking as needed.
- Pros: Separation of concerns could make it easier to find detailed docs as needed
- Cons: A lot of content overlaps, so it may be difficult to fully dedupe and could mean lots of cross linking and jumping back and forth between sections.
| 8 |
4,456,656 | 73,807,957 |
2020-11-03 14:54:40.845
|
Move calendar icon in date picker
|
Per @cam.x’s great suggestion in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/726#note_432971319, consider moving the calendar icon to the left of the date picker input.
**Benefits**
- Aligns with how the search input is handled.
- Provides more room on the right to use the clear × option.
/cc @gitlab-com/gitlab-ux/ux-foundations
| 2 |
4,456,656 | 72,858,125 |
2020-10-16 23:12:12.730
|
Add lock-solid to GitLab UI Kit for Figma
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
When switching between  and  there is not enough visual distinction to quickly identify if something is locked or unlocked.
:new: icon 
🤚Blocking Merge Request 
https://gitlab.com/gitlab-org/gitlab-svgs/-/merge_requests/632
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/nLyPs9zeRPQUAAmKckfLjM/Icon-lock-solid?node-id=125%3A35)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: Move your working file to the shared Figma project:
1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [x] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 1 |
4,456,656 | 72,834,541 |
2020-10-16 12:41:20.757
|
UX Foundations > Pajamas OKR exploration
|
During a recent conference, Design Systems & DesignOps, one of the self-work times was dedicated to thinking through what OKRs could look like for your design system. We were given about 40 minutes total to complete a list and then discuss in a small group. These were a few that came to mind, and I found it very helpful to think through objectives specific to the system itself.
Feel free to add your own, and perhaps we can have further exploration on a few of these. All of the below ramp up to a larger objective of making the product more beautiful, performant and accessible for users, while providing clear _foundational_ answers to common questions so that designers can focus on designing and not on rehashing what should be “boring” decisions. A reoccurring phrase from the workshop was “align the easy thing to do with the right thing to do,” which I think aligns with our goal of building foundational things for the team to build on.
| 1 |
4,456,656 | 72,338,921 |
2020-10-07 16:28:24.133
|
Dropdown component - Standardising on how to clear selection
|
## Problem
- From this discussion: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43050#note_422606858
- There doesn't seem to be a standard way to clear the selection from a dropdown
- For example, in Value Stream Management, the following approach was used...
## Proposal
Standardise on a solution for clearing the selection from a dropdown:
1. Document approach
1. Add functionality at the component-level
There are a few ways of going about it...
### When dropdown is open, the Action area for "clear selection"
| Single selection | Multi selection |
| ------ | ------ |
|  |  |
### after dropdown closes, the action to "clear selection"
| Single selection | Multi selection |
| ------ | ------ |
|| |
<details><summary>Original proposal</summary>
<p>
| Dropdown open clear button | Dropdown closed clear button | Top-level selection clears |
| ------ | ------ | ------ |
|  |  |  |
</p>
</details>
@gitlab-com/gitlab-ux/designers
| 3 |
4,456,656 | 72,079,844 |
2020-10-02 13:45:12.687
|
Mini progress/gauge indicator
|
# Problem
- Current use case: We need to visualise the progress of adoption of individual GitLab stages side-by-side
- General challenge: visualising progress as a percentage or within some target bounds
# Solution
- [Figma file →](https://www.figma.com/file/M04p4bPdJSRLJJxZ8DhgmA/Mini-gauge?node-id=785%3A161)
- Create a mini gauge chart that can fit within tables or metric boxes
- Need to be able to look good side-by-side
# MVC iterations
1. Implement mini gauge variant with icon (no bounds)
1. Implement mini gauge variant with metric (no bounds)
1. Implement mini gauge variant with target bounds
| 3 |
4,456,656 | 71,028,980 |
2020-09-11 13:48:52.161
|
WIP: Add complex List Item components to Pajamas
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
Currently, in Pajamas, the "List" component(s) that are defined speak mostly to the Markdown list and don't include complex list items as seen throughout the product. To address this, I suggest we make 2 large scale changes:
1. Move the current list descriptions to the `Typography` section of Pajamas.
1. Update the List components to include complex list items as displayed throughout the product (see examples below).
##### Examples
| Issue list view |
|---|
||
| Package list view |
|---|
||
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](ADD LINK TO FIGMA FILE/FRAME)
### Checklist
Make sure the following are completed before closing the issue:
1. [ ] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [ ] **Assignee**: Update the link to the working file in the issue
description.
1. [ ] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: Move your working file to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 13 |
4,456,656 | 70,889,051 |
2020-09-08 16:55:49.679
|
UI Kit > Add inline code and code blocks
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
Based on the UI changes in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/26731, adding styles/components to the component library for:
* [x] Inline code
* [x] Code blocks
### Out of scope
* Appearance of code when not using the default theme preference.
* Dark UI.
* Other inline text elements (See https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/680)
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/omuzKJD8RKLPpqv24CUUyS/Component-Inline-code-and-code-blocks?node-id=1%3A70)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: Move your working file to the shared Figma project:
1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [x] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 1 |
4,456,656 | 70,886,070 |
2020-09-08 15:55:39.441
|
Make responsive segmented control
|
### Problem
Currently our [segmented control component](https://design.gitlab.com/components/segmented-control) isn't very responsive on small screens when the component has many options (see below screenshot).
We don't have a current design for how to fix this.
### Proposal
Some possible solutions:
- [Vertical variation for button groups](https://bootstrap-vue.org/docs/components/button-group#vertical-variation)
- Wrapping the component
- Making the last button a dropdown with the extra options inside of it.
- 
| 3 |
4,456,656 | 70,830,391 |
2020-09-07 14:39:08.013
|
KR: Communicate component lifecycle improvements to the UX department => 0%, TBD
|
Related to [Clarify the Pajamas component lifecycle process](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/1)
Key result: Communicate component lifecycle improvements to the UX department (slack, UX weekly announcement).
| 1 |
4,456,656 | 70,830,214 |
2020-09-07 14:36:36.911
|
KR: Improve the component checklist by adding links/references to the necessary steps to complete the lifecycle, and move it to the Pajamas project. => 0%, TBD
|
Related to [Clarify the Pajamas component lifecycle process](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/1)
Key Result: Improve the component checklist by adding links/references to the necessary steps to complete the lifecycle, and move it to the Pajamas project.
| 1 |
4,456,656 | 70,744,870 |
2020-09-04 16:23:21.236
|
Skeleton loader for Releases
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file.
- For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
In https://gitlab.com/gitlab-org/gitlab/-/issues/201959/ we will introduce an update to the ~"component:skeleton-loader" of the Releases page. This issue adds a variation of the gilab-ui component so that users can be able to see a loading state that always represent Releases in a recognizable way.
- The component variation should be called: `release-card-skeleton-basic`.
- I propose adding the UI to the Product Pages figma file.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View branched working file of Component Library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/EIhkW34nsNcpDXLKQNte4w/Component-library?node-id=2844%3A3)
[(Old) View working file in Figma →](https://www.figma.com/file/9Uee1fu4GrNrEhCHRTi2nK/Release-page-skeleton-load-gitlab-201959?node-id=1%3A2)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [-] **Assignee**: Move your working file to the shared Figma project (file was a branch, so archived by the maintainer using the branch feature).
1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [-] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [-] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 2 |
4,456,656 | 70,208,931 |
2020-08-24 11:09:35.005
|
Make mermaid diagrams work in Pajamas
|
This is a Follow-up from "Draft: docs(contribute): Move component lifecycle up" https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2053/
Currently, Pajamas does not render mermaid diagrams in markdown pages.
Mermaid diagrams render as *code blocks* in markdown files. This is a useful tool for generation of diagrams and flowcharts from text, instead of using static images in the design docs pages.
See https://docs.gitlab.com/ee/user/markdown.html#mermaid
| 5 |
4,456,656 | 70,023,441 |
2020-08-19 16:12:01.391
|
Pajamas pages break if a Vue component doesn't exist in component_documentation.js
|
Recently, the dropdowns page was broken due to `GlNewDropdown` no longer existing under [`component_documentation.js`](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1637/diffs#d836144972fdb1c81b2724a1b894dec15e0973f4_62_62), which Pajamas pulls from when checking if a vue component conforms to the design system [`followsDesignSystem`](components/componentinfo.vue).
MR that fixed the broken page: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2050
| 1 |
4,456,656 | 69,979,688 |
2020-08-18 21:31:07.000
|
UI Kit > Create inline text element components
|
## Problem
Several inline text elements need to be added to the component library in Figma. We need to determine where they best fit since they can cross over between UI and markdown.
## Solution
* Audit the product to find inline elements that can’t be created with styles alone (the ones in the image above have backgrounds).
* Create components for each inline variant.
* Determine the best location in the component library and publish the additions.
/cc @tauriedavis
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. -->
[View working file in Figma →](https://www.figma.com/file/YJWAkSuSBsEaIWMbYftE5x/Component-Inline-text-components?node-id=1%3A70)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Add the changes or additions to the target file. For
example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [x] **Assignee**: Move your working file to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, create a merge request in this repository
with the [component-guideline template][component-guideline-template]
to create or update the component’s documentation page.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI][new-gitlab-ui-issue] to build or update the component code. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[new-gitlab-ui-issue]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new
| 2 |
4,456,656 | 69,807,043 |
2020-08-13 14:30:26.698
|
Allow linking to component usage for all region components.
|
### Problem
We cannot directly navigate to the Vue component usage section in all region components like [Empty State](https://design.gitlab.com/regions/empty-states/) by visiting `https://design.gitlab.com/regions/empty-states/code` as the url returns 404.
| 2 |
4,456,656 | 69,284,313 |
2020-07-31 08:16:37.509
|
Document established onboarding & educational patterns: nudge
|
Document the findings and learnings from the [suggest a pipeline experiment](https://gitlab.com/groups/gitlab-org/growth/-/epics/14). Based on these learnings, establish a pattern for onboarding and educational purposes, so that other designers can reuse it.
By the time I'll start working on documenting these we'll have run numerous variations of this experiment: different initial nudges, different copy.
Include details about:
* reference the FOGG behaviour model
* components that can be used
* variations of initial nudges and recommendations on when they should be used
* recommendations on the number of steps
* recommendations for writing copy and providing context (why the nudge is shown, what value will the user get from it)
* should only be done to benefit the user
| 5 |
4,456,656 | 68,821,525 |
2020-07-21 18:21:52.775
|
Update empty state documentation to include details about existing controls
|
As part of discussion on https://gitlab.com/gitlab-org/gitlab/-/issues/229636#note_382613266 and https://gitlab.com/gitlab-org/gitlab/-/issues/229350, we realized that we could use a little clarification in our empty state documentation.
When we have an empty state, should the page controls still appear, but be disabled? Or, should they be completely hidden?
We currently have both situations in our empty states. Should we clarify when the controls appear, and why?
| 2 |
4,456,656 | 62,159,621 |
2020-07-16 22:33:44.649
|
Dropdowns > Audit Figma and GitLab UI component
|
Review dropdowns in Figma and GitLab UI to ensure parity
If issues are found, create issues and mark them as blockers to this issue.
- [ ] All variations exist in Figma and GitLab UI
- [ ] Styling in Figma matches GitLab UI
- [ ] All related issues are closed
- [ ] Status table in Pajamas is updated and accurate
| 3 |
4,456,656 | 52,422,757 |
2020-06-30 18:28:03.741
|
GitLab UI examples > Add knob options
|
On the vue tab for components, you should be able to interact with gitlab ui knobs
| 5 |
4,456,656 | 52,354,157 |
2020-06-30 16:30:31.126
|
feat(skeletonloader): Extend usage of Skeleton loader vs. Spinner usage
|
Clarify when to use spinner vs. skeleton loader in different scenarios.
From thread https://gitlab.com/gitlab-org/gitlab/-/merge_requests/35265#note_368474339
| 2 |
4,456,656 | 50,091,551 |
2020-06-25 18:41:59.075
|
Audit principles page
|
We have a lot of content on our principles page, including some guidelines. There is note that states our current principles may not follow the guidelines. We need to audit this page and determine what changes, if any, need to occur to the principles and/or guidelines
| 3 |
4,456,656 | 42,999,400 |
2020-06-12 07:57:22.736
|
Mobile layout has double padding on left/right
|
From https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1963#note_359198356
`content` adds left/right padding which was getting doubled, so narrow screens have extra padding
We can probably move the `.content.limited` rule to `.limited` to fix this
| 1 |
4,456,656 | 35,473,730 |
2020-06-05 10:38:08.164
|
Pajamas UI Kit > Gauge chart
|
<!-- Start by making a copy of the component template to your own drafts.
In Figma:
1. Duplicate the component template https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/Component?node-id=0%3A1
2. Open the duplicate, then use the dropdown next to the file name to select “Move to Project…”
and select your Drafts as the new location.
3. Update the template with your component name and start designing ;)
-->
### Description
Gauge chart visualization is useful for monitoring the status of a metric in real time, and to quickly convey the status of the metric in relation to the ranges or a threshold set by the user. A gauge chart is a single metric chart.
#### Example use case
An SRE viewing metrics in the Metrics dashboard when investigating an incident. A gauge chart instantly communicates to the user the status of the metric, even when viewed at a small size. At a glance the user understands whether the value is falling within an acceptable range.
#### Requirements
- The chart should clearly communicate the current value and show where that value falls within the ranges set by the user (2 or 3 ranges can be set).
- Users can set alerts on the metric, so we need to make sure that when the alert is firing it's immediately visible
- The value ranges don't have to coincide with the alert threshold. The user should be able to set an alert for any value regardless of what range it falls into
- The chart should be readable even at a very small size. It's not uncommon for our users to have multiple gauge charts crammed into a small dashboard area to form a "speedometer" of sort. Check out [one of the GitLab dashboards ](https://dashboards.gitlab.com/d/sv_pUrImz/ci-autoscaled-machines-metrics?orgId=1&refresh=5m&from=now-30d&to=now&var-dc=All&var-runner_group=All&var-cpu_mode=nice)for an example. Currently, GitLab Metrics charts aren't resizeable, but they will be in the future.
#### States/ variants
- [x] Alert set
- [x] Alert firing
- [x] Low range, mid range, high range
- [x] Large (expanded chart view)
- [x] Small (50%)
### Additional details
We will be building the chart using the [Gauge e-charts component.](https://echarts.apache.org/examples/en/editor.html?c=gauge)
Notes for the docs:
- Leave a note in the component description that states that the header is mandatory but the size should vary depending on page content/hierarchy.
<!--Add a short description of the component. If it’s helpful, add a checklist of variations
and states to the description so that a reviewer can be sure to cross reference everything
that has been completed.-->
<!--Use the Figma share feature and make sure that “anyone with the link” can view. Then,
specifically invite the reviewer with “edit” permissions selected. Anyone can duplicate the
file to their own drafts and edit from there, but the reviewer can directly edit and
collaborate on the file. This will help maintain the integrity of the initial draft.-->
### WIP Proposal
| Medium range | With an alert | With a firing alert |
| ------ | ------ | ------ |
| |  |  |
### Figma component
[View component in Figma →](https://www.figma.com/file/rxA1gTpS6L7wMhAs9rZnaU/Gauge-chart?node-id=0%3A1)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Create component in your own draft file in Figma using the
[component template](https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/%5BComponent%5D),
including all variations and states.
1. [x] **Assignee**: Update the link to the Figma file in the issue description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer](https://about.gitlab.com/company/team/?department=fe-ux-foundations-team)
to review your component (ensure they have edit permissions in Figma).
1. [ ] **Reviewer**: Review and approve assignee’s addition. Ensure that design
includes all variations/states.
1. [ ] **Reviewer**: Assign to a [Figma maintainer](https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com) for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s addition.
1. [ ] **Maintainer**: Add the design to the **Pajamas UI Kit** file, ~~and view
the component in the Assets panel to ensure it aligns with what’s outlined in the
[document and asset library structure](https://gitlab.com/gitlab-org/gitlab-design/-/blob/master/CONTRIBUTING-Figma.md#document-and-asset-library-structure) documentation.~~ (Not applicable for the chart.)
1. [-] **Maintainer**: Publish the library changes along with a clear commit message.
1. [ ] **Assignee**: Move the draft file to the **Component archive** Figma project. If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it's a new
pattern or a significant change, add an agenda item to the next UX weekly call
to inform everyone.
1. [ ] **Assignee**: Create a merge request in this repository with the [component-guideline template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md)
to create or update the component's documentation page. Link it here as a related
merge request. Use `View design in Pajamas UI Kit →` for the link text. This replaces
any link to Sketch Measure specs. Anyone with the link should be able to view the file.
1. [x] **Assignee**: [Create an issue in GitLab UI](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new)
to build or update the component. Mark the new issue as related to this one.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
| 3 |
4,456,656 | 34,251,371 |
2020-05-07 08:20:26.831
|
feat(filters): Research scroll behavior for filters
|
In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1343 @matejlatin highlighted filters issue with scrollbar on OS X:
pretty acceptable in Linux & Windows with other scroll type:
We need to research the proper way of handling a lot of scrollable content in filters.
| 3 |
4,456,656 | 33,963,045 |
2020-04-29 17:12:08.465
|
Add additional chart information to to PJs
|
### Description
PJs doesn't include all chart options available from within gitlab-ui.
#### Examples
https://design.gitlab.com/components/charts#types only mentions column charts, line charts, and area charts.
In addition to these, we also have:
* Scatter chart
* https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/charts-discrete-scatter-chart--default
* Heatmap
* https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/charts-heatmap--default
Column charts also support a click interaction - I don't actually think that this is explicitly mentioned in gitlab-ui either.
#### Additional information
This was raised in discussion over here https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541#note_333095362
| 4 |
4,456,656 | 33,865,614 |
2020-04-27 16:12:27.424
|
PJs component page template: re-evaluate content based on JTBDs
|
## Overview
Let's re-evaluate the content (and structure) of the PJs component page template to improve the utility and usability for GitLab designers, devs and PMs. This is related to the broader PJs information architecture challenges mentioned in gitlab-org/gitlab-design#798.
The best way to prioritise, manage and refine the content on the page is by using Jobs to be done.
## Problem
The main pain points I found with component page templates today:
- **Text-heavy** - PJs is much more text-heavy than most other design systems. Much of the text content could be replaced with images and demos. The large amount of content makes it hard to scan and find the information I'm looking for.
- **Usage guidance vs implementation guidance** - Content on implementation guidance ([as discussed here](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/536)) is left in the usage guidelines - adding to the text-heaviness. This also reduces the clarity on the usage guidance in general.
- **Burying the lead** - The current structure is setting pages up in a way where the demo is at the bottom of the page behind a bunch of text which may or may not be relevant for your use case. A new structure is required which front loads the demo and dives into details later. Following similar ideas to the [Minto Principle](https://medium.com/lessons-from-mckinsey/the-pyramid-principle-f0885dd3c5c7).
- **Additional content** - We also have a lot of other content that could be interesting to include in a design system as stated in [this comment](https://gitlab.com/gitlab-org/gitlab-design/-/issues/1111) - this doesn't need to be shown on the page, but could at least be linked, so we see the thought and rationale that has gone into designing the component
- **Variation** - There a lot of inconsistency in how component usage guidelines are written.
## Idea
> “If a picture is worth a thousand words, a prototype is worth a thousand meetings” - **David Kelley, IDEO**
Some general principles for laying out these pages:
- **JTBD & role-informed** - We should differentiate sections and prioritise what content goes on the page based on what our primary personas are trying to achieve
- **Demo-heavy** - We should front-load our component pages with visual content and demos for a quicker understanding
- **Show me > tell me** - We should strip away as much text as possible in favour of demos and programmatically embedding rules, styles and interactions
- **On-page nav** - We should have on-page navigation for quicker access to particular sections
- **Standardise component usage sub-sections** - We should standardise on component usage sub-sections to improve consistency and clarity (e.g.[IBM carbon](https://www.carbondesignsystem.com/components/date-picker/usage#content) standardized on component variations, content guidelines & interactions/functionality). This also makes it easier to spot whether any functionality or styles are missing.
I think [IBM Carbon](https://www.carbondesignsystem.com/) and [Salesforce Lightning](https://www.lightningdesignsystem.com/) are both great examples of prioritising which JTBD they want to satisfy for designers & devs without being too text-heavy.
## Jobs to be done
Create a ranked list of JTBD to prioritise content on the page:
| Title | Situation | Motivation | Desired outcome | Persona |
| ------ | ------ | ------ | ------ | ------ |
| **General usage guidance** | When I am unfamiliar with a component, | I want a quick and high-level overview of the what the component looks like, how it works and its most popular use cases, | so that I know whether or not I should use it. | All |
| **Design tool component** | When using a component, | I want a representation of that component in Figma/Sketch | so that I can quickly work with it in my designs | Designer |
| **Detailed usage guidance** | When using a component, | I want to understand details of variations, style, functionality and accessibility | so that I use the component in the way it was designed | Designer |
| **Component usage in the product** | When using a component, | I want to where else in the product it is being used, how much it is being used and for what use cases, | so that I | All |
| **Design decisions** | When using a component, | I want to understand how research, discussions & usage helped decide on a specific design, tenet or guideline | so that I understand why the component was designed in that way | Designer |
| **Component gaps** | When using a component, | I want to understand whether this current iteration of the component has the variations, style, additional functionality and accessibility required for my use case | so that I know whether we should update it or not | Designer |
| **Component pipeline** | When using a component, | I want to see if there are any new components or updates in the pipeline | so that I can utilise the component or collaborate with the person who is working on it | Designer |
| **Component development guidance** | When building components, | I want to understand what patterns should be embedded into the component programmatically | so that the component works in the way it was designed. | Developer |
| **design.gitlab, GitLab-ui & figma/sketch sync** | When using a component, | I want to be sure that the component variations, style, additional functionality and accessibility in design.gitlab reflect what is shown in gitlab-ui and figma/sketch | so that I have an accurate representation of what's available and continuity of understanding with other roles in my team | All |
| **Add/edit component** | When reviewing PJs and I see missing/incorrect component content | I would like to add/edit content | so that I contribute to refining our design system | Designer |
| **Integrating component** | When I am integrating a component in our [component lifecycle](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/blob/master/doc/component-lifecycle.md) | I want to ... | so that ... | Developers |
## Process
1. **Gather** - Use this issue to collate what the primary the JTBD for designers, devs, PMs, technical writers, researchers
1. **Prioritise** - Prioritise the JTBD to prioritise the content in PJs
1. **Create template** - Create a new content template based on our prioritisation
1. **Create vision mockup** - Create a new vision mockup of what PJs component pages could be
## Additional ideas
- On page table of contents
- Additional tabs
- Changing structure of pages to front-load demos and visual content at top of page
- First step would be changing component template file: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/pages/components/template.md
## Proposal
- Determine a new structure that allows users to easily find the content they are looking for. The end result of this issue should be working page templates and consistent sections and language.
| 8 |
4,456,656 | 33,393,960 |
2020-04-16 17:28:55.972
|
Add contrast info to neutral color palette
|
The following discussion from !1787 should be addressed:
- [x] @pedroms started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1787#note_322602636): (+2 comments)
> @jeldergl should we also add the `Passing level and contrast ratio` information to the neutral palette?
| 1 |
4,456,656 | 33,058,352 |
2020-04-08 17:00:57.725
|
Communicating code coverage of each component
|
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1804, the status of components that already live inside the GitLab product were moved to `Integrated`.
I'm curious to hear what would be helpful on the status page. A lot of questions I get are related to why a component in production does not match Pajamas. Even if a component already lives in the product, that does not mean they are fully integrated or used in every instance. How should we be communicating the code coverage of each component? Should that live inside the status page? How can we feasible track this over time?
| 5 |
4,456,656 | 32,794,334 |
2020-04-02 16:59:02.898
|
Add more clarity around bold 600 decision
|
Its not clear from looking at pajamas what font weight we use for bold text. You have to inspect the text or find the variable in GitLab UI.
We should include the variable name and it's value on the typography page. We can also include explanatory text that explains why we use 600 over 700
> It’s because some system fonts have a semi-bold, which would be mapped to 600, and that weight was preferred. For system fonts without a semi-bold it would be mapped to the 700 weight, which is why it could look extra bold in other OSs.
| 1 |
4,456,656 | 32,537,602 |
2020-03-27 12:47:48.959
|
Add accessibility guidelines and specs for the filters
|
gitlab-org/gitlab-services/design.gitlab.com!1744 adds the usage guidelines, next we need to think how to properly build the filter components so that they're accessible. Let's add those guidelines and specs to the Pajamas after that.
| 3 |
4,456,656 | 35,324,648 |
2020-03-19 18:51:00.547
|
Figma region > Empty states
|
<!-- Start by making a copy of the component template to your own drafts.
In Figma:
1. Duplicate the component template https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/Component?node-id=0%3A1
2. Open the duplicate, then use the dropdown next to the file name to select “Move to Project…”
and select your Drafts as the new location.
3. Update the template with your component name and start designing ;)
-->
<!--Add a short description of the component. If it’s helpful, add a checklist of variations
and states to the description so that a reviewer can be sure to cross reference everything
that has been completed.-->
<!--Use the Figma share feature and make sure that “anyone with the link” can view. Then,
specifically invite the reviewer with “edit” permissions selected. Anyone can duplicate the
file to their own drafts and edit from there, but the reviewer can directly edit and
collaborate on the file. This will help maintain the integrity of the initial draft.-->
[View component in Figma →](https://www.figma.com/file/Bp0HvnbtcLcoLYHXbrWwzc/Empty-states?node-id=0%3A1)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Create component in your own draft file in Figma using the
[component template](https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/%5BComponent%5D),
including all variations and states.
1. [x] **Assignee**: Update the link to the Figma file in the issue description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer](https://about.gitlab.com/company/team/?department=fe-ux-foundations-team)
to review your component (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s addition. Ensure that component
includes all variations/states and, if applicable, matches existing Sketch specs and
is responsive.
1. [x] **Reviewer**: Assign to a [Figma maintainer](https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com) for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s addition.
1. [ ] **Maintainer**: Add the component to the **Pajamas UI Kit** file, and view
the component in the Assets panel to ensure it aligns with what’s outlined in the
[document and asset library structure](https://gitlab.com/gitlab-org/gitlab-design/-/blob/master/CONTRIBUTING-Figma.md#document-and-asset-library-structure) documentation.
1. [ ] **Maintainer**: Publish the library changes along with a clear commit message.
1. [x] **Assignee**: Move the draft file to the **Component archive** Figma project. If you're a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it's a new
pattern or a significant change, add an agenda item to the next UX weekly call
to inform everyone.
1. [ ] **Assignee**: Create a merge request in this repository with the [component-guideline template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/master/.gitlab/merge_request_templates/component-guideline.md)
to create or update the component's documentation page. Link it here as a related
merge request. Use `View design in Pajamas UI Kit →` for the link text. This replaces
any link to Sketch Measure specs. Anyone with the link should be able to view the file.
1. [ ] **Assignee**: [Create an issue in GitLab UI](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new)
to build or update the component. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
---
## Empty state examples
* https://www.carbondesignsystem.com/patterns/empty-states-pattern/
* https://stackoverflow.design/product/components/empty-states/
* https://www.lightningdesignsystem.com/guidelines/empty-state/#site-main-content
| 3 |
4,456,656 | 86,304,066 |
2020-03-18 04:24:58.393
|
Form help and error text should not be separate
|
## Problem
For our form elements, help text and error text are currently defined as two separate text items. This could be confusing as error text could be partially duplicative of the help text. Depending on how the help text is tied to the input for accessibility, this could also add confusion, or cause some info to be missed. Because the help text remains gray, it visually feels disconnected with an input in error state.
## Solution
Help text is a single, dynamic text block with the potential for multiple states.
* By default it is instructional and in a neutral palette
* When an error occurs the help text becomes more explanatory so that a user knows how to correct the error. The danger palette is used.
In this case there is inly one help text block for instruction and error prevention.
| **Before** | **After** |
| ------ | ------ |
|  |  |
/cc @uhlexsis @tauriedavis @pedroms
| 1 |
4,456,656 | 31,850,907 |
2020-03-10 23:50:22.128
|
Combine contents of "Vue component" and "Design" tabs into a single page
|
There is often duplicated content between the tabs. For example: "Alerts allow the application to pass along relevant system information to the user without impeding their journey. Alerts are system generated and may or may not be derived by a user’s action." is the same in the following two places:
Instead of a tab, we can add a "Component" section to the design tab (and then remove the tabs altogether)
| 8 |
4,456,656 | 31,691,849 |
2020-03-06 19:42:44.993
|
GitLab UI components demos: Reduce style inconsistencies between Storybook and design.gitlab.com
|
# What problems are we trying to solve here?
## 1. `.md` styles leaking into GitLab UI components demos
`design.gitlab.com` has a set of typography CSS rules being applied on several common HTML elements in the `.md` scope: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/5f1e9246192f9f04dcd50cefa55985d63c0f88ce/assets/stylesheets/framework/_typography.scss#L35-81
This has been causing issues with components demos as they are being displayed into the same scope, resulting in some components inheriting unexpected CSS rules, an example is the `GlBanner` component: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1620#note_245401786
This has led us to explicitly setting more and more CSS rules in components stylesheets, solely to override `.md` styles. We have tried to circumvent this specific issue by [wrapping components in a custom element](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1737) where GitLab UI styles would be injected in the Shadow DOM. While this solution was promising as it stopped all CSS leak issues, some components like tooltips and popovers aren't Shadow DOM-ready and aren't able to render when they don't have access to the global `document`. More generally, this approach brought us back to problem `#2`.
## 2. Styling elements in the global scope
To prevent GitLab UI's styles from conflicting with `design.gitlab.com`'s styles, we have scoped its styles to the `.app-styles` class: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/5f1e9246192f9f04dcd50cefa55985d63c0f88ce/assets/stylesheets/app.scss#L33-36
This lets us apply components styles locally, without affecting the rest of the website.
This is a sensible approach but we've reached its limits as some components are appending elements to the `body` in the global scope. Since those elements are escaping the `.app-styles` scope, they can't be styled properly, unless we can come up with specific workarounds. For example, we've been able to preserve styles for the `GlModal` component by adding the `.app-styles` class to its wrapper element: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/5f1e9246192f9f04dcd50cefa55985d63c0f88ce/layouts/default.vue#L103-114
There are other cases, like the `GlToast` component, where there is no obvious workaround that we can apply, resulting in a broken looking element in the demo:
Overall, we should try to make it as easy as possible to include components demos in `design.gitlab.com`. Having to come up with workarounds makes for a poor developer experience.
# How can we address these issues?
## 1. Prevent `.md` styles from leaking too deep in the DOM
To prevent `.md` styles from affecting too many of their children, let's make sure that the CSS rules only apply to direct children in `.md`. This will prevent the CSS from leaking into component demos, reducing the need for explicitly setting CSS rules in GitLab UI to override Pajamas' styles.
This approach has a downside: Markdown elements can be nested. For example: `> ### A title in a blockquote`. By applying styles on direct children only, those nested elements will not be styled properly. Since Pajamas doesn't seem to contain any nested Markdown element at the moment, this fix should be acceptable considering its benefits outweigh its disadvantages.
MR: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1753
## 2. Apply GitLab UI styles globally
TBD
MR: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/1740
| 3 |
4,456,656 | 30,733,784 |
2020-02-13 21:33:01.456
|
Remove radios vue banner and set status to Built
|
1. In Pajamas docs, remove the banner on vue tab that warns of incorrect styling
1. In Pajamas docs, set the status to `Built`
| 1 |
4,456,656 | 53,985,995 |
2020-01-23 22:52:10.589
|
Figma component > Add Card
|
<!-- Start by making a copy of the component template to your own drafts.
In Figma:
1. Duplicate the component template https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/Component?node-id=0%3A1
2. Open the duplicate, then use the dropdown next to the file name to select “Move to Project…”
and select your Drafts as the new location.
3. Update the template with your component name and start designing ;)
-->
<!--Add a short description of the component. If it’s helpful, add a checklist of variations
and states to the description so that a reviewer can be sure to cross reference everything
that has been completed.-->
<!--Use the Figma share feature and make sure that “anyone with the link” can view. Then,
specifically invite the reviewer with “edit” permissions selected. Anyone can duplicate the
file to their own drafts and edit from there, but the reviewer can directly edit and
collaborate on the file. This will help maintain the integrity of the initial draft.-->
[View component in Figma →](https://www.figma.com/file/RbS6MpYuRWGvcdxRlUGxAD/Cards?node-id=1%3A496)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Create component in your own draft file in Figma using the
[component template](https://www.figma.com/file/OmvFfWkqEsdGhXAND133ou/%5BComponent%5D),
including all variations and states.
1. [ ] **Assignee**: Ask another Figma Pilot Designer to review your component (make sure they have edit permissions).
1. [ ] **Reviewer**: Review and approve assignee’s addition. Ensure that component
matches Sketch specs, includes all current variations and states, and (if applicable)
is responsive.
1. [ ] **Assignee**: Add the component to the **Globals - beta** file, and view
the component in the Assets panel to ensure it aligns with what’s outlined in the
[Figma structure for library](https://gitlab.com/gitlab-org/gitlab-design/issues/791) issue.
1. [ ] **Assignee**: Publish the library changes along with a clear commit message.
1. [ ] **Assignee**: Update component link in the issue.
1. [ ] **Assignee**: Move your draft file to the **Component archive** Figma project.
| 3 |
4,456,656 | 29,712,647 |
2020-01-17 18:48:44.957
|
Fix fonts size of help text in radios/checkboxes
|
The following discussion from !1651 should be addressed:
- [ ] @pedroms started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/merge_requests/1651#note_271309985): (+4 comments)
> @jboyson unsure if related to this MR, the help text paragraph `p` has an odd font-size:
>
> 
| 1 |
4,456,656 | 105,457,393 |
2022-03-24 21:00:12.515
|
Figma: Change GitLab logo in file thumbnails
|
Update the logo in file thumbnails (cover slides) starting with publicly shared files in the Pajamas UI kit and then the other cover template.
| 1 |
4,456,656 | 105,236,024 |
2022-03-21 21:27:21.078
|
UI Kit > Add GitLab tier badge variant
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
Following https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1242 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2728#note_862246994 we should add a GitLab tier badge variant to GitLab UI.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/H45tzHETZOwB7kJh3YqKj0/Component-library?node-id=19947%3A350E)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 104,621,769 |
2022-03-11 14:40:50.808
|
Discussion: Add guidelines for alternate visual treatment for links
|
## Problem
We have the visual treatment for links identified in the GitLab UI, but do not have a dedicated section under Pajamas guidelines to specify them. Today, we treat `copy blue with an underline` as a standard and desired state for links, but from recent feedback on Verify features, we were able to surface a need for multiple visual treatments for the same.
There are pages in the product that list resources, and for their contextual identification it is vital to retain links to associated resources. Example- a pipeline can be best identified in the presence of the commit name/number, branch name, merge request details and triggerer information. Not every user would make use of all of these link, but the personas interacting with these pages are varied and through research we have learn that removing any of these information can prove to be disruptive to a huge number of users.
Presence of many different links as a group, with each demanding user's attention can turn out to be very visually disorienting. To combat this discomfort, we should consider providing different visual treatments to those links. For example - the link that belongs to the resources that is primary to the page can have a blue color, while for the other links we can go for a subdued visual affordance, ma be dark gray with an underline?
We are already doing this on a few pages, such as issues, where we do not give a blue color to link, and at other pages where many different links in a single line have different treatments. To ensure that we provide our users with a coherent experience across platforms, we should document primary and alternate treatments for links and the circumstances under which they should be used.
### Use cases
I'm listing use-cases from Verify since I'm more versed in those.
#### Pipeline Execution: Pipeline index page
| Image | Resources linked |
|------------|-------------|
|  | Commit, Merge request, Branch, Pipeline |
#### Release: Environment list view
| Image | Resources linked |
|-------|------------------|
| | Commit, Branch, Deployment |
#### Another example of what to avoid:
Links with no affordance inline with plain text. Here, they should have at least an underline, and probably different color too.
| What's a link? | Links |
|-------|------|
|||
-----------
### Few consideration highlighted by @jeldergl in a [slack thread](https://gitlab.slack.com/archives/C010NAWPRV4/p1646921391954459):
> 1. Ensure these are understood as links in context.
> 1. See what can be done to make the gray links look more like a link.
> 1. Be extremely clear when documenting the use case while referencing all of the factors.
> 1. Ensure that what’s decided on and documented here can be abstracted out enough to address similar parts of the UI without creating loopholes.
------------
### Resources
- [WCAG Success Criteria 1.4.1 Use of Color](https://www.w3.org/TR/WCAG21/#use-of-color)
- https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-link--default-link
- https://gitlab.com/groups/gitlab-org/-/epics/6414
- [UI type scale link style in Pajamas UI Kit](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=542%3A334)
- [Documentation markdown link style in Figma](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=1%3A97)
- [Compact markdown link style in Figma](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=5%3A44)
- [Link styles (ideal state) in MR widget instances](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=38193%3A30482)
_Also view linked issues_
@gitlab-com/gitlab-ux/designers
| 5 |
4,456,656 | 104,591,009 |
2022-03-11 05:08:17.551
|
Data visualization - Update mini pipeline graph dropdown tooltips to include trigger job instance
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
In https://gitlab.com/gitlab-org/gitlab/-/issues/340194 we're adding a special tooltip text to the trigger jobs tooltips to indicate they they're trigger jobs. This needs to be updated in the Data vis Figma file.
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working file in Figma →](https://www.figma.com/file/17NxNEMa7i28Is8sMetO2H/branch/pheBqF0DOICBa5DAqE4hID/Data-Visualization)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [-] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [-] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [-] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [-] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [-] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [-] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 104,500,464 |
2022-03-09 17:53:17.318
|
ViewComponents > Determine process and documentation
|
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82118 is our first MR that migrates a component helper to a ViewComponent. This could help with HAML/HTML components, but needs more exploration.
Docs: https://viewcomponent.org/
This issue is to help serve as discussion around View Components, how we might utilize and document them, and where that documentation should live.
| 4 |
4,456,656 | 104,478,590 |
2022-03-09 14:09:34.699
|
Define standards for edit icon
|
### Description
We do not consistently use the same icon to represent editing an object. This is based on this [slack thread](https://gitlab.slack.com/archives/CLW71KM96/p1646833267140679).
- [x] Audit edit icons (search for the pencil, pencil-square icon in the codebase)
| pencil | pencil-square |
| ------ | ------ |
|  |  |
- [x] Come up with a recommendation
| pencil - use for edit |
| ------ |
|  |
- [x] Update that icon to include `edit` definition in Figma
- [ ] Add this in Pajamas documentation - most likely [table actions](https://design.gitlab.com/components/table#additional-actions) - [MR](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2901)
- [ ] Replace pencil-square with pencil in GitLab UI - [MR](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/89897)
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Component Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 2 |
4,456,656 | 103,976,000 |
2022-03-02 16:32:20.303
|
Popover > Unbox header
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
As part of an effort to "unbox" the GitLab UI (:arrow_forward: [watch a video with more context](https://www.youtube.com/watch?v=MxpZuWQH-kk)), the popover component could have a simple update to remove the border between the header and body content and padding. See a similar effort for [unboxing the modal](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1221).
**How does this benefit the UI and support unboxing?**
- The popover has hierarchy established with different font weights, the dividing border just reenforces the hierarchy that already exists.
- Similar to the results in the modal, this also allows us to remove the extra padding needed when there are two separate sections, effectively reducing popover height.
- Removing the border between the header and content allows for a more natural reading flow between header and content without the visual break that makes them feel less connected.
### Result
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/a9sU9h6eO7waDKgaltWEzX/Component-library?node-id=425%3A131)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template
to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
| 1 |
4,456,656 | 103,845,979 |
2022-02-28 16:42:53.121
|
Dropdown > Update styles
|
## Background
Dropdowns (trigger button that opens a panel of options) in GitLab historically used a check icon to identify a selection. Awhile ago it was proposed to update to using literal checkbox and radio `<input>`s to better represent the selection (single/multi-select). After more learning around what constitutes options within a dropdown, it' seems's clear that using literal form elements is _not_ ideal and doesn't reflect the semantics for options within a [listbox](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role) or [combobox](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/combobox_role).
**Current**
## Proposal
Update the design of options within a dropdown panel to represent a selection without using literal form elements. This can be based on the previous design and should include the following states:
- Rest
- Hover (`:hover`)
- Focus (`:focus`)
- Active/pressed (`:active`)
- Selected
Since multi-select is a function of the component and context, and not an individual option (that uses `role="option"`), the design of an option can be the same for single and multi-select.
**Proposed design**:
- Include a tip pointing to the referring trigger.
- Ensure the panel uses the correct [shadow](https://design.gitlab.com/layout/layers#shadows).
- Use a small :mag: icon in the search input to help with alignment and feel more in scale with the text (might consider this elsewhere in the future too).
- Selected item has rounded rectangle container.
- Border radius increased on panel to keep in proportion to border radius of elements within.
- Left aligned header.
- Option for panel action (to clear all, unassign, etc.).
### Concepts
There's a matrix of options:
- Edge-to-edge option vs. inset rounded rectangle. Space is the primary consideration, but more space could benefit distinguishing options at the cost of a bit more scrolling. The inset rounded rectangle would also be closer to how flyouts are handled in the left navigation.
- Gray vs. blue selected item background. While gray keeps the UI more subdued, the use of blue aligns with our prescribed use to indicate a current or active state and also provides more differentiation with hover states.
- Checkmark vs. border selection indicator. Space is also a consideration here, but what type of indicator makes identifying a selection quick, clear, while not impeding readability is most important.
<details><summary>👁🗨 View initial concepts</summary>
| | **Blue highlight** | **Gray highlight** |
| ------ | ------ | ------ |
| **Edge-to-edge checkmark ✓** |  |  |
| **Inset rectangle checkmark ✓** |  |  |
| **Edge-to-edge border ⎮** |  |  |
</details>
<details><summary>🎛 View more examples for comparison</summary>
| | **Blue highlight** | **Gray highlight** |
| ------ | ------ | ------ |
| **Edge-to-edge checkmark ✓** |  |  |
| **Inset rectangle checkmark ✓** |  |  |
| **Edge-to-edge border ⎮** |  |  |
</details>
---
**Additional considerations**:
1. Tip pointing to trigger element
1. Unbox the header (shadow on scroll)
1. Reduce header text size
1. Universal action placement (for actions like "Unassign" or "Remove all," etc.)
1. Smaller search icon in search input
1. Better left edge alignment
1. Smaller label color swatch that also matches the label shape
1. Increased outer border radius for inset rectangle option for accurate border radius scaling
| 5 |
4,456,656 | 102,864,498 |
2022-02-22 13:51:18.609
|
fix(Toggle): Allows Figma component 'Label' text override persistence between 'top' and 'left' variants.
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
Currently text overrides to the label don't persist between Top and Left configurations.
This update changes layer names to allow overrides to persist.
| Before | After |
| ------ | ------ |
|  |  |
| Before | After |
| ------ | ------ |
|  |  |
#### Bonus
This branch also updates the `toggle-disabled` variants to use `$gray-200`.
| Before | After |
| ------ | ------ |
|  |  |
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working file in Figma →](https://www.figma.com/file/XizLfOwUBqVhE3X0PAbKb8/?node-id=425%3A140)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [-] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [-] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [-] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [-] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template
to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
| 1 |
4,456,656 | 102,772,320 |
2022-02-21 08:01:46.106
|
Update Figma file permissions to "Anyone with link can view"
|
## Problem
Figma links in the Pajamas component docs are set to `Anyone at GitLab can view` permissions. It means that those outside of GitLab can't view the Figma files that we link to from the Pajamas docs.
It was discovered in [this MR thread.](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2719#note_838072427)
## Proposal
Update the Figma file permissions to be `Anyone with a link can view`.
| 1 |
4,456,656 | 102,039,893 |
2022-02-08 08:08:35.935
|
Provide guidelines for the usage of Drawers for consistent presentation of in-product Help information
|
### Description
Among other things, Drawers are used to present in-product contextual help information in GitLab. We need to provide guidelines for the usage of Drawers for Help information specifically to ensure consistent experience and a certain standard for the formatting and presentation of help info.
#### Questions to consider
* What are the nuances of using a Drawer for Help information? How can we standardize the design of Help drawers in GitLab?
* What kind of content does / does not belong in the drawer?
* What is the order of types of content?
* Where does the content reside for best updating? Right now, it is hardcoded in the product.
* Requirement for TW to be involved in the Help window content creation (this type of content shouldn't extensively duplicate what is already available (potentially - need to think about this one); should not consist of mostly links; should answer very specific targeted questions, should follow our CTRT design guidelines). For example - the types of content in the CI/CD example are concept, task, tip, reference. Great content and the order is helpful.
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [ ] When applicable, [create a new Pajamas issue using the "Figma update" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the "Component"][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 3 |
4,456,656 | 102,039,696 |
2022-02-08 08:02:35.219
|
Clarify drawer usage guidelines
|
### Description
This issue is to clarify several questions about the [Drawer component](https://design.gitlab.com/components/drawer/) usage guidelines as surfaced in [this audit. ](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/376#note_750204850)
#### Questions to answer
* Should we allow the drawer size to be changed?
* Should the drawer have white or gray background? We have both instances in the product.
* If drawer has a scrollbar, should the width be increased or the usable content area decreased? [Context](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/73955)
* Do drawers have a "collapsed but still slightly visible" state? (like our right/left sidebars currently do). Or are they fully visible / fully hidden?
* Can drawers be on the left? Should our sidebars be flipped in RTL layouts (these are more broadly very broken)
* Can drawers be stacked (and overlap slightly)? Or there can be only one at a time. [Context](https://gitlab.com/gitlab-org/gitlab/-/issues/338718#note_752946251)
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [-] When applicable, [create a new Pajamas issue using the "Figma update" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [x] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the "Component"][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [x] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 2 |
4,456,656 | 102,008,238 |
2022-02-07 16:00:31.584
|
Pajamas UI Kit > Form component updates
|
## Purpose
Make updates to the way form components are constructed in the UI kit to reduce the number of component variants. [View the inspiration →](https://www.youtube.com/watch?v=9w0sOpsS90s)
Figma branch [#1235-form-exploration-JE →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ubxFCR4pADM7ZfMJ7ZvyOU/Component-library?node-id=3050%3A0)
| 3 |
4,456,656 | 101,895,697 |
2022-02-04 15:29:10.292
|
Add New Popover with Close Button Variant to Pajamas
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
As per https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2630, we are introducing a close option to our popover component. We need to add it to Figma.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/mSByfa79OJuwmTqQXudJhB/Component-library?node-id=425%3A131)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [x] **Maintainer**: Review and approve assignee’s changes.
1. [x] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template
to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one.
1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
| 1 |
4,456,656 | 101,844,299 |
2022-02-03 19:07:37.244
|
Add browser settings to keyboard audit
|
## Purpose
In https://gitlab.com/gitlab-org/gitlab/-/issues/349787#note_828606021 browser settings were brought up that enable all focusable items to receive focus. This MR adds a note about it to https://design.gitlab.com/accessibility-audits/keyboard-only.
| 1 |
4,456,656 | 101,690,996 |
2022-02-01 23:11:50.007
|
Alert > Allow fluid layout to determine width
|
## Purpose
In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79235 it was determined that we should remove the max-width for alert content when the user's layout preference is set to fluid. This issue will update the documentation to remove that requirement.
| 1 |
4,456,656 | 101,399,064 |
2022-01-27 15:41:24.022
|
Feature idea: Pattern builder
| null | 3 |
4,456,656 | 101,274,857 |
2022-01-26 10:06:27.089
|
Popover > Document close button usage
|
### Description
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
As per https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2630, we are introducing a close option to our popover component. We need to document its usage.
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [x] When applicable, [create a new Pajamas issue using the "Figma update" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [x] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the "Component"][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 1 |
4,456,656 | 101,227,845 |
2022-01-25 15:12:14.168
|
Empty search results vs empty filter results empty state text guidance
|
### Description
We added some documentation around empty search results recently in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1210. When I used them for https://gitlab.com/gitlab-org/gitlab/-/issues/339525/designs/Deleted-many-items.png#note_820337312, they didn't quite fit since there were filters applied. There are cases when something is searched within a search input field that will result in no matches, as well as when something is filtered within the filter component that can also result in no matches. We should decide whether or not we want to provide different messaging for those.
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
### Audit of empty state cases
| Summary |
| ------ |
| Whether we use a search component to filter down results, or the filter component, we do not consistently provide messages as to why there were no matches. |
👉 When using the filter component, `7/17` instances use something similar to the following text:
**Sorry, your filter produced no results**
To widen your search, change or remove filters above
👉 When using the search component, `only 3/10` instances use something similar to the following text:
**Sorry, no projects matched your search**
<details><summary>Full audit table</summary>
| Search input field | Filters |
| ------ | ------ |
| Projects  | Issues  |
| Groups  | Members  |
| Explore topics  | Requirements  |
| Milestones  | Merge requests  |
| Projects sub-menu  | Pipelines  |
| Global search  | Global search with filters  |
|Labels  | Test cases  |
|Commits  | Vulnerability report  |
|Branches  | Policies  |
|Tags  | Incidents  |
|cell | Package registry  |
|cell | Container registry  |
|cell | Value stream analytics  |
|cell | Code review  |
|cell | Issue analytics  |
|cell | Merge Request Analytics  |
|cell | To-Do List  |
</details>
### Proposal
#### Search
If a page uses the [search component](https://design.gitlab.com/components/search), use the following text for empty states:
**No results found**
Edit your search and try again.
#### Filter
If a page uses the [filter component](https://design.gitlab.com/components/filter), use the following text for empty states:
**No results found**
Edit your filters and try again.
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed. https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2751
1. [ ] When applicable, [create a new Pajamas issue using the "Figma update" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the "Component"][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 1 |
4,456,656 | 101,219,535 |
2022-01-25 14:04:42.470
|
Update Pajamas with information about the new iconography
|
### Description
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
Updates to https://design.gitlab.com/product-foundations/iconography based on the work done https://about.gitlab.com/blog/2021/12/17/hey-icons-lighten-up/
As a designer trying to onboard I had to rely on external sources (and my memory) to read this section of the design system.
Related to #1202.
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [ ] When applicable, [create a new Pajamas issue using the "Figma update" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the "Component"][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 3 |
4,456,656 | 100,940,753 |
2022-01-19 21:57:24.167
|
UI kit > Update checkbox and radio components
|
## Purpose
- Update components to make better use of variants.
- Add indeterminate (checkboxes only and disabled states.
### Reference
There's an [existing Figma branch](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/zuwBQHtdwn2KALwuKRuvvB/Component-library), but it's a bit far behind the main and there are some other approaches to explore so a new branch is preferred.
Here's an example of what's there though:
| **Checkbox** | **Radio** |
| ------ | ------ |
|  |  |
| 2 |
4,456,656 | 100,450,014 |
2022-01-11 18:37:05.300
|
Text guidance for blank state
|
We don't have consistent text in our blank state pages in the UI. We need to create guidance and apply it.
Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/339525/designs/Deleted-many-items.png#note_807219530
If you look at the following examples, the most effective ones have a call to action.
Should there be different text, based on the type of page? For example, does it make sense to have a call to action on a search or filter page that shows no results?
## Current guidance
I found this info in Pajamas:
* https://design.gitlab.com/regions/empty-states
* https://design.gitlab.com/regions/empty-states#blank-content
And there is an empty state template: https://gitlab.com/gitlab-org/gitlab/-/issues/new?issuable_template=Empty%20state
It does define different types of blank state pages:
- Blank page with a call to action
- Configuration required
- Higher tier required
- Empty search results
We should recommend text for each.
## Examples of empty state pages
The following are just random examples from the UI.
### Package Registry
https://gitlab.com/sselhorn/test-project/-/packages
### Pipelines
https://gitlab.com/gitlab-org/gitlab/-/pipelines?page=1&scope=finished&username=gdoyle
### Merge requests
https://gitlab.com/dashboard/merge_requests?scope=all&state=opened&assignee_username=hmjang1
### Issues
https://gitlab.com/gitlab-org/gitlab/-/issues?search=adkfhasidhf&sort=created_date&state=opened
### Container Registry
### Infrastructure Registry
### Monitor > Metrics
### Monitor > Tracing
### Monitor > Incidents
### Security & Compliance > Security Dashboard
### Commit search
https://gitlab.com/gitlab-org/gitlab/-/commits/master?search=gdgdfg
### Repository > Locked files
### Issues > Milestones
https://gitlab.com/sselhorn/test-project/-/milestones
### Issues > Requirements
### CI/CD > Schedules
### CI/CD > Test cases
### Deployments > Feature flags
### Infrastructure > Serverless platform
| 2 |
4,456,656 | 99,922,200 |
2021-12-30 13:57:34.199
|
Pajamas UI Kit > Add optional prop to form label
|
## Purpose
Form labels can have "(optional)" appended to them. It uses a different text style and would be useful to include as an option in Figma similar to how it is in GitLab UI. The text remains editable.
Toggling the optional property in GitLab UI:
[View the branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/QfyaK2zgr2FFlwtDKrdHQy/Component-library?node-id=425%3A10)
Here's a quick video demo:
**Note**: This implementation doesn't account for text wrapping. If the label happened to be too long then you can either consider a shorter label, or detach the instance to format it in a design comp.
| 1 |
4,456,656 | 99,190,879 |
2021-12-16 18:50:23.448
|
Single stat documentation
|
### Description
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] When applicable, [create a new Pajamas issue using the "Figma update" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the "Component"][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 3 |
4,456,656 | 98,955,954 |
2021-12-13 15:58:05.512
|
Migrate component examples and docs to embedded GitLab UI stories
|
With https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1175 closed, we now have a way to embed GitLab UI stories in design.gitlab.com: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/embed-gitlab-ui-stories.md.
The [initial implementation](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2447) migrated alerts and banners to use this new approach, but several other pages are still using legacy examples and implementation tabs. Let's migrate remaining pages, the only pre-requisite being that the corresponding GitLab UI component(s) must have been migrated to the Component Story Format (https://gitlab.com/groups/gitlab-org/-/epics/5651).
## Migration steps
* [ ] In the `.md` file:
* [ ] Migrate the `vueComponents` property to `stories` in the frontmatter.
* [ ] Migrate `[[Example:*]]` tags to `[[Story:*]]` tags.
```patch
diff --git a/contents/components/accordion.md b/contents/components/accordion.md
index 62da0f1..19fcdb2 100644
--- a/contents/components/accordion.md
+++ b/contents/components/accordion.md
@@ -1,8 +1,8 @@
---
name: Accordion
description: An accordion is used to show and hide content.
-vueComponents:
- - GlAccordion
+stories:
+ - base-accordion--default
related:
- modal
- tree
@@ -11,7 +11,7 @@ related:
## Examples
-[[Example:accordion-basic]]
+[[Story:base-accordion--default]]
[View in Pajamas UI Kit →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Pajamas-UI-Kit?node-id=425%3A0)
```
* [ ] Remove the associated examples from the `examples/` directory.
## Migration status
| Component | Can be migrated | Migrated |
| --------------------------------------------------------------------------- | ------------------ | ------------------ |
| [accordion](https://design.gitlab.com/components/accordion) | :white_check_mark: | :white_check_mark: |
| [alert](https://design.gitlab.com/components/alert) | :white_check_mark: | :white_check_mark: |
| [avatar](https://design.gitlab.com/components/avatar) | :white_check_mark: | :white_check_mark: |
| [badge](https://design.gitlab.com/components/badge) | :white_check_mark: | :white_check_mark: |
| [banner](https://design.gitlab.com/components/banner) | :white_check_mark: | :white_check_mark: |
| [breadcrumb](https://design.gitlab.com/components/breadcrumb) | :white_check_mark: | :white_check_mark: |
| [broadcast-message](https://design.gitlab.com/components/broadcast-message) | :white_check_mark: | :white_check_mark: |
| [button](https://design.gitlab.com/components/button) | :white_check_mark: | |
| [card](https://design.gitlab.com/components/card) | :white_check_mark: | :white_check_mark: |
| [checkbox](https://design.gitlab.com/components/checkbox) | :white_check_mark: | :white_check_mark: |
| [color-picker](https://design.gitlab.com/components/color-picker) | | |
| [date-picker](https://design.gitlab.com/components/date-picker) | | |
| [drawer](https://design.gitlab.com/components/drawer) | | |
| [dropdown](https://design.gitlab.com/components/dropdown) | | |
| [file-uploader](https://design.gitlab.com/components/file-uploader) | | |
| [filter](https://design.gitlab.com/components/filter) | | |
| [form](https://design.gitlab.com/components/form) | | |
| [infinite-scroll](https://design.gitlab.com/components/infinite-scroll) | | |
| [label](https://design.gitlab.com/components/label) | :white_check_mark: | :white_check_mark: |
| [list](https://design.gitlab.com/components/list) | | |
| [modal](https://design.gitlab.com/components/modal) | :white_check_mark: | |
| [pagination](https://design.gitlab.com/components/pagination) | :white_check_mark: | |
| [path](https://design.gitlab.com/components/path) | :white_check_mark: | :white_check_mark: |
| [popover](https://design.gitlab.com/components/popover) | | :white_check_mark: |
| [progress-bar](https://design.gitlab.com/components/progress-bar) | :white_check_mark: | :white_check_mark: |
| [radio-button](https://design.gitlab.com/components/radio-button) | :white_check_mark: | |
| [search](https://design.gitlab.com/components/search) | | |
| [segmented-control](https://design.gitlab.com/components/segmented-control) | :white_check_mark: | |
| [skeleton-loader](https://design.gitlab.com/components/skeleton-loader) | :white_check_mark: | |
| [socks](https://design.gitlab.com/components/socks) | | |
| [sorting](https://design.gitlab.com/components/sorting) | :white_check_mark: | |
| [spinner](https://design.gitlab.com/components/spinner) | :white_check_mark: | |
| [table](https://design.gitlab.com/components/table) | | :white_check_mark: |
| [tabs](https://design.gitlab.com/components/tabs) | | |
| [toast](https://design.gitlab.com/components/toast) | | |
| [toggle](https://design.gitlab.com/components/toggle) | :white_check_mark: | :white_check_mark: |
| [token](https://design.gitlab.com/components/token) | :white_check_mark: | :white_check_mark: |
| [tooltip](https://design.gitlab.com/components/tooltip) | :white_check_mark: | |
| [tree](https://design.gitlab.com/components/tree) | | |
| [empty-states](https://design.gitlab.com/regions/empty-states) | :white_check_mark: | :white_check_mark: |
| 3 |
4,456,656 | 98,849,054 |
2021-12-10 18:27:17.578
|
UI kit > Update components to light icons
|
## Purpose
With https://gitlab.com/gitlab-org/gitlab-svgs/-/issues/178 getting implemented in https://gitlab.com/gitlab-org/gitlab-svgs/-/merge_requests/739 we can update the icons in the Pajamas UI Kit.
The new icons will be maintained in a separate file from the component library for easier maintenance and sharing.
**Steps**
1. [x] Ensure all icons that weren't updated in the recent effort, but are still part of the library, are included in the new icon file. For example, pipeline, issue type, and brand icons.
1. [x] Publish the new icon library and add it to our community page.
1. [x] Replace the icons in the component library with the ones from the new icon library.
1. [x] Deprecate the old icons by removing them from the component library and placing into a separate file that will be archived.
1. [x] Publish an updated version of the component library.
1. [x] Mention the breaking change in the UX Weekly with directions on using the new library.
1. [x] Create a new MR to update the iconography guidelines in Pajamas.
| 2 |
4,456,656 | 98,765,575 |
2021-12-09 16:42:44.763
|
Illustration > Add more grid information
|
## Purpose
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2636 the product illustration guidelines were updated. Based on some feedback there could be more helpful guides specifically around the grid.
> A link to some resource would be helpful, or at least some examples of illustrations within this grid so it's easier to see what are the focal points and how elements should align to it. https://design.gitlab.com/product-foundations/illustration#focal-point-grid
>
> This grid is specific to illustration, so I wouldn't assume all Product Designers know how to use it if they haven't had experience with graphic design or illustration.
| 1 |
4,456,656 | 98,752,241 |
2021-12-09 13:29:08.659
|
UI kit > Define & validate shadow style specs
|
## Problem
The current layer shadow style/specs in the UI kit ([modal example](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=4263%3A22)) don't align with what's in [Pajamas](https://design.gitlab.com/layout/layers#large). This issue is to determine the correct specs and where updates are needed.
[View branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/k1Qah0jN5geit4umN5uCYI/Component-library)
| **UI kit** (Note that both are combined into one shadow) | **Pajamas** |
| ------ | ------ |
|  | ```box-shadow: 0px 0px 4px rgba(0, 0, 0, 0.16), 0px 4px 12px rgba(0, 0, 0, 0.16);``` |
## Solution
Consolidated list of styles based on components in production and in the UI kit
## Shadow styles
### Small shadow - {+new+}
| GitLab-ui | GitLab UI kit | Components | CSS |
| ------ | ------ | ------ | ------ |
| $gl-shadow-sm | Small $gl-shadow-sm | Card | `box-shadow: 0px 1px 2px rgba(0, 0, 0, 0.1);` |
### Medium shadow - {+new+}
| GitLab-ui | GitLab UI kit | Components | CSS |
| ------ | ------ | ------ | ------ |
| $gl-shadow-md | Medium $gl-shadow-md | Date picker, Dropdown, Menus, Flyout Nav, Card `on_drag` | `box-shadow: 0px 2px 8px rgba(0, 0, 0, 0.16), 0px 0px 2px rgba(0, 0, 0, 0.16);` |
### Large shadow
| GitLab-ui | GitLab UI kit | Components | CSS |
| ------ | ------ | ------ | ------ |
| $gl-shadow-lg | Large $gl-shadow-lg | Modal, Drawer | `box-shadow: 0px 4px 12px rgba(0, 0, 0, 0.16), 0px 0px 4px rgba(0, 0, 0, 0.16);` |
## Changes for this issue
### UI Kit
- [x] Add missing shadow layer styles (sm & md)
- [x] Update the shadow-sm to be more appropriate for the card on boards.
### Pajamas
- [ ] Update documentation to reflect new styles
- [ ] Update images to follow `visual example` patterns
## GitLab UI
### In https://gitlab.com/gitlab-org/gitlab-ui/-/issues/615
1. Document new shadow styles and audit existing styles
1. Add new shadow styles as utility classes
1. Update instances to use the new GitLab UI utility classes
```
Out of scope but worth mentioning;
* gl-shadow-focus: focus states
This will remain unchanged in Gitlab-UI
```
| 1 |
4,456,656 | 98,706,269 |
2021-12-08 20:56:53.115
|
Bug: 404 when opening a component page directly to the /contribute tab
|
To recreate:
Click this link: https://design.gitlab.com/components/table/contribute
| 3 |
4,456,656 | 98,703,259 |
2021-12-08 19:21:00.631
|
Follow-up from "feat(Illustration): Update docs with new guides"
|
The following discussion from !2636 should be addressed:
- [x] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2636#note_757943934): (+4 comments)
> **non-blocking:** The figma frame has a purple background which is a bit odd. Can that be updated to be like the one above where it's on the toggle? :thinking:
| 1 |
4,456,656 | 98,620,537 |
2021-12-07 17:46:35.492
|
Inline note layout broken
|
## Problem
Recently we updated the look of the inline todo, but the change has also been applied to the inline note, which has different design constraints.
| **Todo** | **Note** |
| ------ | ------ |
|  |  |
## Solution
Use a different layout for an inline note. Ideally the note content could have normal vertical flow to support longer content.
| 2 |
4,456,656 | 98,611,089 |
2021-12-07 14:51:50.639
|
chore: Organize img folder
| null | 1 |
4,456,656 | 97,030,215 |
2021-11-09 17:17:24.992
|
Update todo note style
|
## Purpose
Update the todo styles to be more streamlined.
- Take up less vertical space and overall reduce visual weight.
- Allow the "Create an issue" link to stand out.
- Use a simple document (note) icon to insinuate that this is a note.
| **Before** | **After** |
| ------ | ------ |
|  |  |
[View in Figma →](https://www.figma.com/file/0enu1LVbrKOuhTjLsbRsb0/%231182-todo-update?node-id=0%3A1)
| 1 |
4,456,656 | 96,281,477 |
2021-10-27 20:23:12.555
|
Live example SSoT
|
From a Foundations Open Office Hours agenda:
>Correct me if I’m wrong, but we still have to update Pajamas examples to match GitLab UI stories, right? As I’ve been working through the accessibility audits, my assumption is that any change to the component in GitLab UI will mean that updates have to happen in Pajamas too. Any ideas on being able to have one live example SSoT?
Generally at the moment I think just about everything could be affected since one version exists in Storybook in either example or CSF format, and there'd be an example in Pajamas.
Recent example since I was working on auditing breadcrumbs. The separator isn't the same…
| **GLUI** | **PJs** |
| ------ | ------ |
|  |  |
Tabs was even more confusing because there are both stories and examples in GitLab UI, and then examples in Pajamas. I've worked on aligning them, but changes had to be made in all three places.
Another hypothetical example might be where we update the markup in a modal CSF, but then have to update in Pajamas example to match.
| 3 |
4,456,656 | 96,127,181 |
2021-10-26 02:55:24.941
|
Illustration > Update docs with new guides
|
After https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1087 there should be sweeping changes to the [Illustration](https://design.gitlab.com/product-foundations/illustration) documentation to outline the new process and guidelines.
## Process
* [x] Update https://design.gitlab.com/product-foundations/illustration.
* [x] Ensure that related issue templates and project docs are current.
* [x] Communicate changes to the UX team.
| 3 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.