idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
|---|---|---|---|---|---|
4,456,656 | 118,001,916 |
2022-11-02 11:44:44.689
|
Move gl- utils to GitLab UI
|
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3113, we have added a few `gl-` CSS utils to support a cleanup initiative. We should eventually move those and any additional utils to GitLab UI.
| 1 |
4,456,656 | 117,950,973 |
2022-11-01 15:36:42.132
|
Cleanup error page layout
|
The following discussions from !3050 should be addressed:
- [x] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3050#note_1136458211):
> **nitpick(non-blocking):** We are repeating the `typography gl--flex-center gl-flex-direction-column gl-h-100vh` wrapper both here and in the `page-not-found` component. Perhaps we could de-duplicate this.
- [x] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3050#note_1136458215):
> **thought(non-blocking):** We seem to be repeating a lot of code from the default layout here. I wonder if we could conditionally render the footer instead of creating a new layout, it would make things a bit easier to maintain.
- [x] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3050#note_1136458218):
> **nitpick(non-blocking):** This might not be relevant in this layout since the homepage uses the default layout anyways.
| 2 |
4,456,656 | 117,759,458 |
2022-10-28 14:26:52.192
|
Tint neutral palette based on brand
|
## Purpose
In the latest brand updates the brand palette includes neutrals that are slightly more cool (blue) in tone. The current Pajamas neutral palette is completely desaturated and feels more generic than it could. There have been previous efforts to explore introducing both a cool and warm set of neutrals to compliment the current ones, however it became clear that this would be to try and account for the current theme approach (warm neutrals with red theme for example), and add unnecessary complexity to an already minimally used feature.
Having a neutral palette that skews more towards the temperature of the brand palette will provide more continuity between digital properties and subtly allow us to infuse more of the brand into Pajamas and the product. Given our use of blue for primary actions and links, a more cool palette also helps elements to feel more harmonious.
## Proposal
Update the neutral palette to align with the grays in the brand palette.
| | **Palette** |
| ------ | ------ |
| Brand |  |
| Current neutral |  |
| Proposed neutral |  |
**[ View working file in Figma →](https://www.figma.com/file/tjSjgnxomkqPg8BEhPdNFJ/%231452-tine-neutral-palette-%40jeldergl?node-id=0%3A1)**
**[ View UI kit branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/XRCIH8ZdaAbyBpkJzgxdKG/%F0%9F%93%99-Component-library)**
**[🎨 View palette in Huetone→](https://huetone.ardov.me/?palette=N4IgdghgtgpiBcIDiAZABAORgVwC4CcIAbAZxABoQALbGM%2BAbVElgRCz0KIpAGMB7Iv3z0GIAMQAzAKwyZPKQAZJyxQoAmAIy1aFmyfv0KAnKbMKAHADZr1hVYeOF0mC5fOATNK8eFAFkUAgIUAZkUwsIUARkkYmJAAXQBfcmZoOEQOAmI0AUEeASERBDEpfQhJdQUYXhqYSQ1edSa4SnFDSV4QhQg-CBCIC0tjC1GqtoB2EImPCaG2qw8rKJtnEOko6XmJPxC-Dz9t8RCTjxCjuJgDxJS01kQAIUIwcb5BYVEJSW%2BfjSj1RTqbptdT-QHAiQQDwQKIQKw9aGw%2BGTPwTKITCAKCao9GYtp%2BaT7PyvcQEokkjyaDwWc4KSnU2ltdFREIeKI3BKUXD8MB0EogKJqSjSIUCxSijzinhhUUBUUi0VWKWUCbKkAWNXGTUim5AA)**
**Other thoughts…**
Yes, this is subjective and nuanced. When exploring navigation updates both in the product, and Pajamas, designers have noted that the current neutrals are just too flat. We have an opportunity to better align the recent brand work and the product, and this is a very subtle, but effective way to do so.
A cool neutral palette could also benefit dark UI and ironically (ignoring the terms) prevent it from feeling too cold or bland. [From this article](https://compilezero.medium.com/dark-mode-ui-design-the-definitive-guide-part-1-color-53dcfaea5129):
> …you could also use accented neutrals instead of a pure-grey palette, which I personally recommend using due to 2 main reasons,
>
> _Pure greys are not found naturally, and so its a good option to have some tint on those neutrals to give it a more natural vibe._
>
> _Tinted neutrals, could help give the UI an overall emphasized tone and emotion to look forward to._
**Resources**
- https://designerup.co/blog/practical-guide-to-perfect-ui-color-palettes/
- https://compilezero.medium.com/dark-mode-ui-design-the-definitive-guide-part-1-color-53dcfaea5129
- https://graphicdesign.stackexchange.com/questions/119887/dark-ui-design-why-tint-the-dark-gray-colors-with-a-different-primary-color
- https://atmos.style/blog/lch-color-space
- https://stripe.com/blog/accessible-color-systems
| 2 |
4,456,656 | 117,214,787 |
2022-10-20 06:03:01.410
|
Pajamas Migration Day: December 2, 2022
|
As part of our ongoing [component migration push](https://gitlab-org.gitlab.io/frontend/epic-burndown-charts/fy23-q1/), we are hosting another Pajamas Migration Day!
- **When:** December 2, 2022
- **Who:** Everyone! FE, BE, Designers, Product, etc. Everyone is encouraged to contribute.
- **Where:** Your very own home or work space, but also join the `#pajamas_migration_day` slack channel to hang out and chat with fellow contributors!
- **Why:** We want to encourage a day of migrating legacy components / css to use Pajamas!
- **Bonus:** If you contribute three merge requests on Pajamas Migration Day, you can expense a meal for up to $25 USD! Please use the ~"Pajamas Migration Day" and ~"FY23::Q4" labels on your MRs to be eligible. In Expensify, use the `Meals Company Provided (Non-Client related)` category.
**Need help?** Ping any member of the [Foundations team](https://about.gitlab.com/company/team/?department=manage-foundations-team) for support or help throughout the day. We are here to assist!
## How to contribute
**If you are working on building your coding skills, check out these issues:**
- [HAML: Buttons](https://gitlab.com/groups/gitlab-org/-/issues/?sort=created_date&state=opened&label_name%5B%5D=Pajamas%20Migration%20Day&label_name%5B%5D=workflow%3A%3Aready%20for%20development&label_name%5B%5D=component%3Abutton&label_name%5B%5D=haml%20migration&first_page_size=20)
- [HAML: Cards](https://gitlab.com/groups/gitlab-org/-/issues/?sort=created_date&state=opened&label_name%5B%5D=Pajamas%20Migration%20Day&label_name%5B%5D=workflow%3A%3Aready%20for%20development&label_name%5B%5D=component%3Acard&label_name%5B%5D=haml%20migration&first_page_size=20)
**If you are confident in your coding skills, check out these issues:**
- [Dropdown migrations](https://gitlab.com/groups/gitlab-org/-/issues/?sort=created_date&state=opened&label_name%5B%5D=OKR&label_name%5B%5D=component%3Adropdown&assignee_id=None&first_page_size=20)
- [Remove select2 implementations](https://gitlab.com/groups/gitlab-org/-/epics/8738)
- [Extract Page Specific CSS Files](https://gitlab.com/groups/gitlab-org/-/epics/3694)
**Tip:** There does not need to be a specific issue open to contribute! Starting with MRs that migrate legacy code is a great way to contribute to the effort. If there are no issues to pick up, treat the day like a scavenger hunt!
**Reminder:** Please add the ~"Pajamas Migration Day" and ~"FY23::Q4" labels to your MRs, as well as the specific component label that relates to your change (for example: ~"component:alert")
| 0 |
4,456,656 | 117,042,973 |
2022-10-17 15:01:53.774
|
Add Mermaid diagram capabilities
|
In a recent Foundations Open Office Hours meeting we discussed the need to add decision trees, and part of the discussion was what format these should take: Figma embed, SVG, Mermaid, etc. Mermaid would be ideal to keep it in the source and manage changes.
| 3 |
4,456,656 | 116,787,230 |
2022-10-12 23:05:06.327
|
Update Pajamas navigation as a result of #1378
|
## Purpose
Update the Pajamas navigation (and related pages) based on conclusions and direction from the results of #1378.
## Scope
- Update the navigation structure.
- Update the navigation semantics to ensure accessibility.
- Update navigation design.
## Direction
[📐 Prototype →](https://codepen.io/lostsatellites/full/rNvbrao)
| 3 |
4,456,656 | 116,774,125 |
2022-10-12 18:24:03.009
|
Dropdown > Update docs to align with latest approach
|
## Purpose
As a next iteration we've discussed moving the listbox to a low-level component. What that means is that it isn't something to be used on it's own as an actual dropdown variant, but instead it's consumed by both the disclosure (optional) and combobox (required).
Likewise, it's been determined that the menu variant isn't something we'll proceed with for now since the disclosure can fir the use cases we have today in the product.
## Changes
- Place necessary listbox content within the [combobox](https://design.gitlab.com/components/dropdown-combobox) page.
- Deprecate the [listbox](https://design.gitlab.com/components/dropdown-listbox) page.
- From the [disclosure](https://design.gitlab.com/components/dropdown-disclosure) page, link to the new listbox section under combobox as the SSoT.
- Deprecate the [menu](https://design.gitlab.com/components/dropdown-menu) page.
- Consider adding decision trees in the _when to use_ section(s) to help determine what to use.
The above changes would leave us with only the disclosure and combobox dropdown variants. To avoid the use of a menu-like option, we could consider adding a line about what `role= menu` is and why we don't use it in both places.
| 1 |
4,456,656 | 116,569,759 |
2022-10-10 10:17:17.158
|
Disable Google Analytics (and therefore remove Cookie Banner) for design.gitlab.com
|
The cookie banner breaks stuff, see for example:
- https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1436
- https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/commit/15be27162585b06eb2d390cf0191890100a5622c
If we do not ship Google Analytics, we need no Cookie Banner, because we are not using Cookies otherwise.
Given that noone seems to have looked at Analytics in a while (at least when I asked), we should consider removing it and making our lives easier.
| 1 |
4,456,656 | 116,409,347 |
2022-10-06 14:10:38.220
|
Figma > New Illustration for scheduled actions
|
## Description
There's no illustration available in the library for any scheduled activity in the platform. We use and old and very specific illustration for [scheduled pipelines](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/pipeline_schedules but there's a need for something more generic that can be re-used in other contexts as well.
There's a need to add an empty state to the `Scheduled pipeline` page for which this illustration will come in handy.
| Current empty state for pipeline schedule page |
|-------|
|  |
<!--
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Concept
A simple illustration using the latest [illustration guides](https://design.gitlab.com/product-foundations/illustration/) that can universal represent the concept of "schedules," "scheduling," "scheduled," and similar forms.
### Figma file
TBD
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[❖ View working file in Figma →](https://www.figma.com/file/1ui9w228X0S5WxaD0SRdIA/branch/k2RyJnTszVzFWLKr9UsvZO/Illustration-library?node-id=441%3A2008)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug.
1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge".
1. [-] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [ ] Update the link to the working file under the **Figma link** section below.
1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [ ] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [ ] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [ ] From the dropdown to the right of the file name, select "Request review".
1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] Make sure all layers are correctly named and organized.
1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [ ] Ensure component descriptions and external documentation links are clear and accurate.
1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [ ] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
<!-- Do not delete below this line -->
/labels ~Figma ~"Pajamas UI Kit" ~"pajamas::design"
| 2 |
4,456,656 | 116,091,745 |
2022-09-30 18:49:41.164
|
Discovery > Look into possibilities of displaying ViewComponents in Pajamas
|
Now that we have [ViewComponents](https://gitlab.com/groups/gitlab-org/-/epics/8113), it would be great to get those displayed in Pajamas alongside the Vue components.
As a first iteration, the `Implementation` tab could change to `Vue` and we could introduce a new tab per component called `View`.
One potential hurdle is that it needs to properly deployed to a Rails application, so we need to determine if this is possible or what options we have.
---
@thutterer
> Prototype at https://gitlab.com/gitlab-org/frontend/playground/lookbook-app
| 3 |
4,456,656 | 116,025,904 |
2022-09-29 16:29:00.603
|
Typography: Update Figma to use new default fonts
|
## Description
Update all Pajamas UI Kit assets in Figma to use the shipped version of Inter, which includes variable features.
## Scope
All [Pajamas UI Kit](https://www.figma.com/files/project/3802635) files:
- Component library
- Product icons (labels only)
- Product pages
- Data visualization
- Type scale - Documentation markdown
- Type scale - Compact markdown
Other:
- Templates
- Cover slide
### Out of scope
- Updating existing design files
## Related
The [Type Fundamentals](https://design.gitlab.com/product-foundations/type-fundamentals) page in Pajamas would eventually need to be updated with the latest font stack info.
### Figma test
- [Component library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/HIA8tpxKnRBR7bFP901AsS/%F0%9F%93%99-Component-library?node-id=440%3A0)
### Figma branches
- [Component library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/WM9pPOVoiGnI17U0PSD2os/%F0%9F%93%99-Component-library?node-id=3050%3A0)
- Product icons (labels only)
- Product pages
- Data visualization
- [Type scale - Documentation markdown →](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/nTHaYuIrt7fMmSBrowA9uz/Type-scale---Documentation-Markdown?node-id=3%3A54)
- [Type scale - Compact markdown →](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/branch/9LMZJBsTtQqMGPbrH8Q07Q/Type-scale---Compact-Markdown?node-id=3%3A54)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug.
1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge".
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] Make sure all layers are correctly named and organized.
1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [ ] Ensure component descriptions and external documentation links are clear and accurate.
1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Merge the branch or add the changes or additions to the
target file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
<!-- Do not delete below this line -->
| 3 |
4,456,656 | 113,900,144 |
2022-08-26 07:30:21.301
|
Add structure image for filter
|
[View working file in Figma (branch) →](https://www.figma.com/file/2XRq1MnIG69iti76Mh9HpJ/branch/X3R2AZyGx5IEAd2IqrMdTj/Pajamas-visual-examples?node-id=9981%3A21053)
| 1 |
4,456,656 | 113,719,597 |
2022-08-23 18:36:18.708
|
Introduce option to put selected items at top of dropdown
|
## Problem to solve
Without a dropdown pattern that shows the selected items at the top, I can't see what those selections are without a lot of scrolling in the dropdown. The truncation in the button suggests that there are more items, but how do I know what these are? Example from https://gitlab.com/gitlab-org/gitlab/-/issues/345430/designs/Runner_tag_field_states.png#note_1074738137:
<img src="/uploads/411cf209d509257ec56bdc8b8214ee2a/Screen_Shot_2022-08-23_at_2.08.30_PM.png" width="40%">
I'd have to scroll down through potentially hundreds of items to see what the `+2 more` refers to (and/or to unselect them). Sometimes the dropdown doesn't even show the complete list, which makes it impossible to find it unless I know what I'm looking for and can use the search to find it (and unselect it, for example).
## Proposal
| 5 items | 6+ items creates a scrollable area |
| ------ | ------ |
|  |  |
In order to prevent the selection from moving around within the input, which could be a frustrating and disorienting experience, the selection should move _after_ the dropdown is closed so it's shown when it's re-opened. This is different than how it currently works in the Assignees dropdown.
Example:
As far as I can tell, this type of dropdown isn't available in [Pajamas](https://design.gitlab.com/components/dropdown-listbox), [gitlab-ui](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-dropdown--default), or the Figma library as a variant (only as an [instance](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=12053%3A6)).
| 5 |
4,456,656 | 113,627,776 |
2022-08-22 12:25:32.913
|
Typography scale(s) exploration
|
Update typography scale(s) and make use of them in GitLab UI & the product.
- Can we unify some of the scales?
- Build a new scale with variables so it can be optimised to different usecases
- Presenting type scales in GitLab UI and Pajamas
- Product integration
- Use base font size of 1rem (16px)
- Change font-sizes to rem (a11y)
Current scale: [GitLab UI](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/scss-typescale--default)
Figma WIP: [Component library →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/8eZJjsriZhPMHL7t1PoVJH/%F0%9F%93%99-Component-library?node-id=440%3A0&t=mKm3NIjPzREZn3q7-0)
| 3 |
4,456,656 | 113,627,623 |
2022-08-22 12:23:03.045
|
Inter typeface exploration
|
### Goal
Make Inter the new default font in GitLab UI & the product.
#### Steps
- Explore the use of Inter
- Variable font
- How we can roll this out
- Possible performance impacts
- Language support (i18n)
- Fallbacks
### Inter
### Figma Test
[View branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/HIA8tpxKnRBR7bFP901AsS/%F0%9F%93%99-Component-library?node-id=440%3A0)
### Product Test
| Inter | system-ui in Mac OS (SF Pro) |
| ------ | ------ |
|  |  |
| 2 |
4,456,656 | 113,520,415 |
2022-08-19 10:44:19.333
|
Revisit the terminology for the filter component parts and guidelines
| null | 2 |
4,456,656 | 113,461,996 |
2022-08-18 11:33:17.107
|
Typography exploration
|
Meta issue to explore options regarding typography.
So far @jeldergl & I discussed to explore:
- Switching to Inter
- Make use of variable font
- Tweaking/Improving/Streamlining our Typo scales
- Product integration plan/roadmap
- Considering an open source monospace typeface to pair with Inter
| 5 |
4,456,656 | 113,287,316 |
2022-08-15 12:26:14.124
|
Define pattern for adding items to a list
|
### Background
Based on [the discussion](https://gitlab.com/gitlab-org/gitlab/-/issues/368138#note_1037362165) with @mle, the improvement could be a community improvement.
So far, we only know that this Region exists in "Settings" and "Security Policy" if anyone knows where else we are using it, feel free to add.
cc: @gitlab-com/gitlab-ux/designers, Any suggestions or you notice the change won't work in certain area?
### Change Proposal
| 3 |
4,456,656 | 112,728,442 |
2022-08-03 13:35:05.333
|
Typography > Note smallest recommended font size
|
## Purpose
Some instances of type are showing up that are smaller than the 12px allowed by the current type scales (UI type scale). 12px is a good minimum size and should be used in limited capacity for short meta-like copy and actions. There is no minimum mentioned in Pajamas (although it's implied by the type scale styles), and it'd be helpful to document.
There is subjectivity when it comes to font size and preference, but that's all the more reason to set a baseline and guidance. For example, browsers handle antialiasing differently and rendering "quality" will vary. GitLab makes use of system fonts, and some, like Helvetica, have tighter spacing and less character definition so that text is harder to read at small sizes. One user will not have the same eyesight as the next, so setting a minimum can also help remove subjectivity and preference for what should be the minimum size.
If content is worth displaying, then it should be worth displaying legibly.
### Considerations
- On mobile, if the font size of an input is not at least 16px, then input will be scaled up (at least in Safari).
- Typeface, font weight, color, line-height, measure, and style can all impact legibility.
- While WCAG doesn't prescribe a minimum font size, it does address contrast for type
- Pixels are referenced as the unit in this issue, but in code relative units should be used so that a user can scale the type in browser (using pixels prevents this). If a browser's default size is 16px (1rem), then 12px = 0.75rem.
- Screen resolution will impact legibility.
| **Helvetica, Firefox** | **Helvetica, Firefox, standard resolution** | **San Francisco, Firefox** |
| ------ | ------ | ------ |
|  |  |  |
### Resources & reference
- Explore different type sizes and fonts in [CodePen](https://codepen.io/lostsatellites/pen/BarrNoE).
- https://stephaniewalter.design/blog/what-minimum-font-size-for-a-high-density-data-web-app-do-you-suggest/
- https://css-tricks.com/accessible-font-sizing-explained/
| 1 |
4,456,656 | 112,626,672 |
2022-08-01 22:30:42.059
|
GitLab UI stories don't load
|
GitLab UI stories seem to be unable to load in some cases. Loading a page that contains stories directly seems to result in the viewers remaining blank.
Stories generally load properly when navigating to a page with stories from within the app although that doesn't seem to be consistently reproducible.
/cc @jeldergl @danmh
| 2 |
4,456,656 | 112,625,838 |
2022-08-01 21:55:19.462
|
FY23 Q3 Foundations KR3: Identify opportunities to increase product designer efficiency in Figma. For example, component structure, libraries, internal plugins, etc
|
## Purpose
See [epic description](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/12).
## Steps
- [ ] Conduct a survey or host a synchronous brainstorming session to explore potential opportunities and workflows that would increase product designer efficiency in Figma.
- [ ] Identify top 2–3 items that would be the most helpful at this point in time.
- [ ] Create a roadmap for each item.
---
## Retrospection
### Good
* Some ideas were uncovered during the IA work.
### Bad
* The IA effort took too long and I didn't get to this.
### Try
* Breaking down even smaller.
| 5 |
4,456,656 | 111,819,368 |
2022-07-18 23:54:47.955
|
Rename foundations-color-palette component to color-palette
|
The following discussion from !2970 should be addressed:
- [ ] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2970#note_1025851626): (+1 comment)
> **note:** I forgot to give this component a more generic name during the initial implementation. Given that it works in both pages that render color palettes, we can probably rename this to simply `color-palette`. I will do that in a follow-up.
| 1 |
4,456,656 | 110,979,806 |
2022-06-30 17:37:30.725
|
Abstract color palettes out into a reusable Vue component
|
The following discussion from !2910 should be addressed:
- [ ] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2910#note_1010952473): (+2 comments)
> **thought:** There's a lot of duplicated code in this file. Now that we can use Vue components inside Markdown, we should probably think of a way to abstract the color palettes into a reusable component to clean this up a bit.
| 2 |
4,456,656 | 110,887,730 |
2022-06-29 10:12:21.990
|
Figma > Icon fill issues
|
## Description
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
Settings icon is behaving like its styled with strokes, rather than fills. This causes some bugs where we rely on fills for overrides — icon dropdown button shown.
I tried to fix it, but I couldn’t work out how to do it without expanding the strokes — which would be destructive. The usual boolean group tricks don’t seem to be working here.
@nickleonard :
> I've noticed `check` does this as well;
<!--
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[❖ View working file in Figma →](https://www.figma.com/file/pEkDaidkvHeHVdnmYp6stC/Icon-fix-test?node-id=2%3A2)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [ ] Update the link to the working file under the **Figma link** section below.
1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [ ] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [ ] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [ ] From the dropdown to the right of the file name, select "Request review".
1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] Make sure all layers are correctly named and organized.
1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [ ] Ensure component descriptions and external documentation links are clear and accurate.
1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [ ] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 110,504,223 |
2022-06-21 19:32:54.884
|
FY23 Q3 Foundations KR2: Gap analysis that determines what areas of Pajamas are missing or needing further refinement, and what the potential impact is
|
## Purpose
See [epic description](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/12).
## Steps
- [ ] Conduct an internal survey to better understand what perceived gaps are.
- [ ] Triage open issues to determine what topics and items are most commonly discussed.
- [ ] Create sub-epics or new issues to organize by theme.
- [ ] Identify gaps in Pajamas design language. These are the areas that need clarified in order for anyone to have confidence and continuity when building an experience using the design system. For example, I know what component A does, but do I know how to use it with component B, or in a scenario where multiple components exist?
- [ ] Make proposals to close gaps.
---
## Retrospection
### Good
* Some ideas were uncovered during the IA work.
### Bad
* The IA effort took too long and I didn't get to this.
### Try
* Breaking down even smaller.
| 3 |
4,456,656 | 110,504,217 |
2022-06-21 19:32:37.166
|
Pajamas > Definitions
|
- Evaluate existing definitions found at https://design.gitlab.com/get-started/structure with a primary focus on: Foundations, Components, Regions, and Objects.
- Update definitions and create new ones for sections considered in the [IA exercise](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1378).
[Working file in Figma →](https://www.figma.com/file/qYQOk3DhrswWIsRnoUTJ6J/%231378-Pajamas-IA-JE?node-id=0%3A1)
| 3 |
4,456,656 | 110,504,207 |
2022-06-21 19:32:21.456
|
FY23 Q3 Foundations KR1: Updated Pajamas IA that takes into account new and updated definitions and organization
|
## Purpose
See [epic description](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/12).
## Steps
- [x] Evaluate existing IA to determine opportunities for improvement.
- [x] Evaluate existing definitions found at https://design.gitlab.com/get-started/structure with a primary focus on: Foundations, Components, Regions, and Objects.
- [x] Propose definition updates and work through internal discussion.
- [x] Test updated definitions internally to make sure categories and meaning are clear.
- [x] Update IA and structure by incorporating definitions and other content organization changes.
## Before / after
<details><summary>Definitions</summary>
### Definitions
| | **Before** | **After** |
| ------ | ------ | ------ |
| **Foundations** | Foundations represent perceptual patterns. These are less tangible aspects of the design system. Together they create a certain aesthetic for the product. For example, colors, typography, and icons. | Foundational items communicate the opinionated way in which basic visual design attributes, elements, and concepts come together to create a distinct GitLab personality that’s expressed in the UI. For example, color, typography, and iconography. |
| **Components** | A small design primitive. Components build upon the design foundations (typography, spacing, motion, colors, iconography, etc.) and are the reusable building blocks of the interface. For example, buttons, tabs, and input fields. | A component is a UI element that serves a singular purpose or function. Two or more simple components can combine to form a composite component that still has a single function. For example, an avatar, button, or combobox. |
| **Regions** | Regions are areas formed by combining multiple components, creating a layout section that can be reused across various pages. For example, the comments and activity feed in issues or merge requests. | _Deprecated_ |
| **Patterns** | _N/A_ | A pattern combines components and/or content elements into a repeatable, consistent group that has a shared purpose, content association, or both. For example, filtering, forms, or navigation. |
| **Page templates** | _N/A_ | A template prescribes layout and behavior for a page or common content layout. For example, an issuable, settings, or search results. |
| **Objects** | Objects capture and organize data as a single source of truth around specific tasks and user interactions. Objects are described in terms of attributes (what they contain), functions (what they do), and relationships (what they interact with). When documented as a conceptual model, objects help understand how the product works and fits together on a system level, detached from the constraints of the user interface. An effective object model tightly aligns our user's mental model with the product's data model. For example, issue, group, and merge request. | An object is a conceptual building block or concept that defines how we think about something independent of its visual representation or interaction model. For example, a job, merge request, or repository. |
</details>
<details><summary>Information Architecture (IA)</summary>
### IA
| **Before** | **After** |
| ------ | ------ |
|  |  |
|  |  |
</details>
[ Working file in Figma →](https://www.figma.com/file/qYQOk3DhrswWIsRnoUTJ6J/%231378-Pajamas-IA-JE?node-id=0%3A1)
---
## Retrospection
### Good
* The IA and navigation are being updated and there were some good insights learned.
### Bad
* This effort took so long that the other KRs didn't get worked on.
### Try
* Breaking down even smaller.
| 8 |
4,456,656 | 110,282,801 |
2022-06-17 09:44:52.650
|
Pajamas UI Kit > Form component: Update disabled state update (a11y)
|
## Description
Disabled state of form items does currently not pass ~accessibility in terms of minimum contrast.\
This updates the disabled state of the component to pass ~accessibility
### Proposal
- Change background color from `#fafafa` -> `$gray-10` (`#f5f5f5`)
- Update Label from `$gray-400` to `$gray-500` for passing contrast (5.28:1)
| Before | After |
| ------ | ------ |
|  |  |
|  |  |
### Figma file
[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/9wDCmYQtWqbclCzhE6k2TJ/Component-library?node-id=49840%3A75722)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Make sure all layers are correctly named and organized.
1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [x] Ensure component descriptions and external documentation links are clear and accurate.
1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 110,124,885 |
2022-06-14 23:01:49.627
|
Draft: Pajamas scaffolding, structure, and ops
|
## Purpose
Pajamas provides foundational styles and element, component guidelines, abstracted objects, and UX content, but it's less clear on how to assemble all of these disparate parts. It's these middle guiding layers of the design system that need built out to provide more visual design direction and UI consistency when it comes to implementation.
At the same time, Pajamas needs a common vernacular with agreed upon definitions and categorization. For example, terms like "patterns," "organisms," and "regions" mean different things to everyone and time spent aligning on meaning stifles additions and system maturity. A large part of the initial effort will be to refine the GitLab design language and provide the consistent groundwork that efforts like "unboxing" and "beautification" — and future ones like them — need to stand on. Pajamas is not just _what_, but _how_, and this is what it means to have a design language and not just a design system.
## Phases
1. **Pajamas scaffolding** (%"15.2")
- Definitions
- Website / design system IA and content mapping
- Gap analysis:
- Gaps in Pajamas design language
- Gaps between Pajamas and product
2. **Pajamas structure** (TBD)
- Website updates: Implement IA changes
- SSoT: What would it take to make the Pajamas site the go-to?
3. **PajamasOps** (TBD)
- Storybook: Playground, features, robust layouts, accessibility testing
- Figma: Internal plugins, designer efficiency
- Triage and contributions
- Prioritization
## Outcomes
- Consistency in design execution and user experience
- Shared design language
- More informed decisions and contribution
- Pajamas → Product planning and prioritization
## Considerations
- Pajamas documentation should be prescriptive when necessary, and guiding when not. The aim is not to have a draconian system, but one that provides meaningful constraints to foster collaboration, provide clear and informed guidance, and inspire new possibilities.
- Refining the design language gives space for efforts like tokenizing and theming to have a meaningful place.
- Gap analysis helps to define not only what areas need building out, but also the size and impact of gaps between Pajamas and the product. For example, typography is foundational, but not consumed by the product.
## Resources and reference
- [IBM Design Language](https://www.ibm.com/design/language/)
- [Visual Design Language: The Building Blocks Of Design](https://www.smashingmagazine.com/2020/03/visual-design-language-building-blocks/)
| 5 |
4,456,656 | 110,053,010 |
2022-06-13 21:07:54.979
|
Illustration > Add XS grid size
|
## Purpose
A new extra small (XS) grid is being added to provide a size that illustration elements can be created at when they're used alongside other UI or to comprise part of a larger design.
For example, in https://gitlab.com/gitlab-org/gitlab-svgs/-/merge_requests/794 a "bidirectional-xs" illustration is being added to connect two logos. Because of our third-party trademark policy we didn't want to add this to one of the logos or combine them. The 72px grid here would've been too large in relation to the logos and placed emphasis in the wrong place.
36px was chosen instead of 32px (and base 8) in order to follow the illustration pattern where each size increases at 2x.
| 1 |
4,456,656 | 109,899,028 |
2022-06-10 08:01:19.741
|
Color > Adjust $gray-10 from #fafafa to #f5f5f5
|
## Description
This is a follow-up to https://gitlab.com/gitlab-org/gitlab/-/merge_requests/87817 & https://gitlab.com/gitlab-org/gitlab/-/merge_requests/89533.
This is a proposal to adjust the `$gray-10` we have defined in the Pajamas Design System to a bit darker nuance.
FYI: In the product we use a `$gray-normal` which is actally using the same HEX value as this proposed darker nuance.
In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2868 we will update `$gray-10` for GitLab UI.
### Proposal
Let's add the following gray's to GitLab UI:
| $gray10 before | $gray10 after |
| ------ | ------ |
| `#fafafa` | `#f5f5f5` |
### Figma file
[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/eLtdBEfc42kw2eshsyILwK/Component-library)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] Make sure all layers are correctly named and organized.
1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [ ] Ensure component descriptions and external documentation links are clear and accurate.
1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [ ] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 109,573,190 |
2022-06-03 17:12:59.765
|
Navigation > Document naming conventions
|
In the `Menu menu discussion` meeting, it was said that we should document naming conventions for navigation. This issue is to investigate what conventions we may be able to create and then document those in Pajamas.
| 2 |
4,456,656 | 109,572,586 |
2022-06-03 17:06:26.462
|
Navigation > Cross link nav docs
|
In the `Menu menu discussion` meeting, it was said that there are multiple navigation docs that exist outside of Pajamas. We should cross link to these pages so it's easy to find/access. We should also consider consolidating where it makes sense.
On the navigation page, we currently cross link to https://about.gitlab.com/handbook/engineering/ux/navigation/
| 1 |
4,456,656 | 109,510,113 |
2022-06-02 13:44:38.428
|
Helping users > Update content guideline formatting
|
Follow up from https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2857#note_957102484:
>1. Make the "GitLab repository `/doc` directory" a link to that directory.
>1. Format the Content Guidelines as a list. I noticed it follows the same "when… do this" type of pattern from other sections and might be easier to parse each consideration as a separate bullet.
| 1 |
4,456,656 | 109,465,890 |
2022-06-01 19:58:04.689
|
Dropdowns > Add validation notes
|
Per this thread https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1242#note_967906969, we should document that certain dropdowns can have validation, namely the listbox and combobox.
| 1 |
4,456,656 | 109,401,960 |
2022-05-31 18:45:35.428
|
Clarify in Pajamas whether a successful save should be an alert or a toast
|
### Problem to solve
We use an info alert on the user settings page to confirm a change, but elsewhere (e.g. the Vulnerability Report), after a successful bulk action, we use a toast notification to confirm the change has been made.
On the [alerts](https://design.gitlab.com/components/alert/#when-to-use) page, Pajamas says:
> Reaffirm to the user that a prior action, likely in a different location or context, has been successful.
"When to use" on the [toast](https://design.gitlab.com/components/toast/#when-to-use) page, on the other hand, says:
> Provide a contextual message based on a user's action in the same view the action took place.
### Proposal
With all the types of alerts we can have in one area at one time (error, warning, etc) in some places, especially the security tab of the pipeline page (see designs in https://gitlab.com/gitlab-org/gitlab/-/issues/352880#note_961677263), we should use toast notifications to confirm a saved change.
Either way, we should update the Pajamas docs accordingly (toast, alert, and [Instant Feedback](https://design.gitlab.com/product-foundations/saving-and-feedback#instant-feedback)) to be more clear which is the suggested pattern.
| 3 |
4,456,656 | 109,024,003 |
2022-05-24 09:10:30.482
|
Update the sticky component text color to match the background color
|
## Description
Update the sticky component text color to match the background color. :sparkles:
| Before | After|
| ------ | ------ |
|  |  |
<!-- Add a short description of your contribution. Consider adding
a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. -->
<!--
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[❖ View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/wnc5x3SEy35JfUMIbtrupv/Component-library?node-id=1663%3A0)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Make sure all layers are correctly named and organized.
1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [x] Ensure component descriptions and external documentation links are clear and accurate.
1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 108,985,322 |
2022-05-23 15:14:02.446
|
UI Kit > Fix label variant switch
|
## Description
Updated label component to make use of new component properties and added missing states to it.
| Before | After |
| ------ | ------ |
|  |  |
### Figma file
[❖ View working file in Figma →](https://www.figma.com/file/tWdQ8eIy7Br3Uk3qSIWOkf/)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Make sure all layers are correctly named and organized.
1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [x] Ensure component descriptions and external documentation links are clear and accurate.
1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Merge the branch or add the changes or additions to the
target file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 108,779,154 |
2022-05-19 03:11:36.579
|
UI kit > Refactor banner
|
## Description
Refactoring the banner component in Figma in light of recent app updates.
| **Before** | **After** |
| ------ | ------ |
|  |  |
|  |  |
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/jHZaeQQxK6D21f9lrjfj3c/Component-library?node-id=425%3A4)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Make sure all layers are correctly named and organized.
1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [x] Ensure component descriptions and external documentation links are clear and accurate.
1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 108,778,498 |
2022-05-19 02:41:04.304
|
UI kit > Refactor popover
|
## Description
Refactoring the popover component in Figma in light of recent app updates.
| **Before** | **After** |
| ------ | ------ |
|  |  |
|  |  |
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/UrBmc6IhZN2zWQCz3HoitL/Component-library)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Make sure all layers are correctly named and organized.
1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [x] Ensure component descriptions and external documentation links are clear and accurate.
1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 108,700,135 |
2022-05-17 18:53:48.379
|
Pajamas Migration Day: June 10, 2022
|
As part of our ongoing [component migration push](https://gitlab-org.gitlab.io/frontend/epic-burndown-charts/fy23-q1/), we are hosting another Pajamas Migration Day!
- **When:** June 10, 2022
- **Who:** Everyone! FE, BE, Designers, Product, etc. Everyone is encouraged to contribute.
- **Where:** Your very own home or work space, but also join the `#pajamas_migration_day` slack channel to hang out and chat with fellow contributors!
- **Why:** We want to encourage a day of migrating legacy components / css to use Pajamas!
- **Bonus:** If you contribute three merge requests on Pajamas Migration Day, you can expense a meal for up to $25 USD! Please use the ~"Pajamas Migration Day" label on your MRs to be eligible. In Expensify, use the `Meals Company Provided (Non-Client related)` category.
**Need help?** Ping any member of the [Foundations team](https://about.gitlab.com/company/team/?department=ecosystem-foundations-team) for support or help throughout the day. We are here to assist!
## How to contribute
- ~~[Migrate a few angle icons to chevrons →](https://gitlab.com/groups/gitlab-org/-/epics/8087)~~ All assigned
- Or if you like buttons more than chevrons :see_no_evil: - you can pick one of the [Haml/Ruby button to Pajamas::ButtonComponent migrations](https://gitlab.com/groups/gitlab-org/-/epics/8153)
- ~~There are also a couple of ["banners" to migrate to `Pajamas::BannerComponent`](https://gitlab.com/groups/gitlab-org/-/epics/8076) ViewComponent.~~ All assigned
- Treat migration day like a scavenger hunt! Review the product and find components/legacy CSS and update it to align with Pajamas!
- Pick up any issue that that is [ready for development](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=created_date&state=opened&label_name%5B%5D=pajamas%3A%3Aintegrate&label_name%5B%5D=OKR&assignee_id=None&first_page_size=20).
There does not need to be a specific issue open to contribute! Starting with MRs that migrate legacy code is a great way to contribute to the effort.
**Reminder:** Please add the ~"Pajamas Migration Day" label to your MRs, as well as the specific component label that relates to your change (for example: ~"component:alert")
| 1 |
4,456,656 | 108,699,933 |
2022-05-17 18:47:40.487
|
Consistent dast_environment_deploy job failure in main branch
|
Our pipelines are reliably failing in the `dast_environment_deploy` job with the following error message:
> Error: release dast-default failed, and has been uninstalled due to atomic being set: Ingress.extensions "dast-default-auto-deploy" is invalid: annotations.kubernetes.io/ingress.class: Invalid value: "nginx": can not be set when the class field is also set
Not sure who to ping regarding this issue. It looks like the [Jobs/DAST-Default-Branch-Deploy.gitlab-ci.yml](https://gitlab.com/gitlab-org/gitlab-foss/blob/master/lib/gitlab/ci/templates/Jobs/DAST-Default-Branch-Deploy.gitlab-ci.yml) template was updated recently, perhaps this is related?
https://gitlab.com/gitlab-org/gitlab/-/commit/a91bd39f2c
/cc @hfyngvason @jeldergl
| 1 |
4,456,656 | 108,680,374 |
2022-05-17 12:38:53.806
|
Dropdown > Reconsider component naming
|
## Purpose
Discuss renaming the current **listbox** component while simplifying the dropdown variants.
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2832 the dropdown component naming was discussed, specifically in regards to the listbox. A `listbox` itself can be part of a disclosure or a `combobox`, but at the moment we're identifying it as its own component that includes the trigger button to reveal it.
It's possible we could reduce the number of documented dropdown variants by treating the listbox as a base component used in composite components.
For example:
- **Disclosure widget**:
- Button that opens panel of links or a mix of links and actions (buttons).
- Button that opens a `listbox` containing options (`role="option"`).
- **Combobox**:
- Text input that opens a `listbox` containing options (`role="option"`).
- **Menu**:
- Button that opens a panel of JavaScript app-like actions.
### Comments from the original MR
>This definition makes me wonder whether `GlListbox` is correctly named, since it implements the button *and* listbox … Maybe whether or not this matters depends on whether we'd ever want to implement a "bare" listbox that's always visible and not just in a popup.
>We could name it`GlCollapsibleListbox` as it is named in [the specs example](https://www.w3.org/TR/wai-aria-practices-1.1/examples/listbox/listbox-collapsible.html).
| 2 |
4,456,656 | 108,306,864 |
2022-05-10 12:19:36.328
|
Improve disabled & focus states of Checkboxes/Radios
|
The current disabled state is quite inconsistant with other form elements and has a weak contrast.
In addition we should update the component to also allow other states as focus & disabled in instances.
Feature branch: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/DGZF5tMtAdIHpX0oKK7fLn/Component-library?node-id=425%3A10
| Before | After |
| ------ | ------ |
|  |  |
| 1 |
4,456,656 | 108,072,847 |
2022-05-05 11:28:18.294
|
Figma > File uploader: Align file uploader with updates from Gitlab UI
|
## Description
The file uploader dashed outline has a weak contrast. Also the indication when dropping files could be improved.
### Proposal
| State | Before | After |
| ------ | ------ | ------ |
| Default |  |  |
| Drag |  |  |
| Focus |  |  |
### Figma file
[❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/laimESW8ZnHkoAdexjX2UB/%F0%9F%93%99-Component-library?t=BEXsPzdk4w9xJ71g-0)
## Checklist
Make sure the following are completed before closing the issue:
### Assignee tasks:
<details><summary>Getting started:</summary>
1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug.
1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge".
1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`.
1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] Update the link to the working file under the **Figma link** section below.
1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. For Component library changes, move your file to the [**Component archive**][component-archive] project.
1. For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
</details>
<details><summary>Prior to review:</summary>
The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma:
1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page.
1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links.
1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages.
1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants.
1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order.
1. [x] **Comments**: Make sure all comments and discussion are resolved.
If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference.
</details>
<details><summary>Requesting a review:</summary>
Ask a [Foundations designer][foundations-team] to review your design.
1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma.
1. [x] From the dropdown to the right of the file name, select "Request review".
1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column.
1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history.
Once your file is in review, you should see a yellow "In review" badge to the right of the file name.
</details>
<details><summary>Post review:</summary>
Once the Reviewer or Maintainer has approved your update, consider the following tasks:
1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [x] 🎉 Congrats, you made it! You can now close this issue.
</details>
### Reviewer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Make sure all layers are correctly named and organized.
1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties.
1. [x] Ensure component descriptions and external documentation links are clear and accurate.
1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue.
1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma).
1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma).
</details>
### Maintainer tasks:
<details><summary>See tasks:</summary>
1. [x] Review and approve assignee’s changes.
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] Merge the branch or add the changes or additions to the
target file.
1. [x] Ensure that all styles and components now belong to the target file.
1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message.
</details>
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
<!-- Do not delete below this line -->
| 1 |
4,456,656 | 107,923,187 |
2022-05-03 12:57:25.153
|
List > Deprecate list as a component
|
In https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1198#note_930969297 it was proposed and validated that **List** should not be a component for these reasons:
>We don't create components of other semantic markup elements, like headings, etc., and I don't think we need to here.
As an outcome of this issue, we'll deprecate the current [List](https://design.gitlab.com/components/list) page in Pajamas and determine if any of the content from that page should be repurposed elsewhere.
We should also determine if the ~"component:list" label should be updated with a deprecation notice or removed. The assumption is removal since there was never a component built in GitLab UI to begin with.
| 2 |
4,456,656 | 107,914,223 |
2022-05-03 09:59:53.771
|
Create structure diagram for the Form component
|
### Description
Create structure diagram for the Form component.
### Checklist
Make sure the following are completed before closing the issue:
1. [ ] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Component Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 1 |
4,456,656 | 107,905,924 |
2022-05-03 07:52:07.390
|
Add guidelines for hiding the UI on empty states
|
@dmoraBerlin and I have been chatting on Slack about the work we're doing on the empty group page: https://gitlab.com/gitlab-org/gitlab/-/issues/267014 This issue has been open for a while and now we've aligned on showing the main two options that make most sense in an empty group and hiding the UI that is usually on a group page. Daniel then warned me about Taurie's comment on another issue that could be related: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/78012#note_923457878
## Proposal
Let's add some guidance to the empty state guidelines, establish that it's ok to hide the UI in some occasions but that it needs to be carefully thought through as there are cases when showing the UI, even if there's seemingly nothing to show still makes sense and offers more value to the user and hence produces a better user experience.
| 2 |
4,456,656 | 107,880,281 |
2022-05-02 15:40:10.198
|
Content Security Policy (CSP) blocks iFrames on design.gitlab.com
|
## Problem to solve
User on LinkedIn reported
>>>
FYI, I noticed that the CSP blocks some iFrames on multiple pages.
>>>
Created this issue following the contribution guide in https://design.gitlab.com/get-started/contribute
## Resources
- LinkedIn comment: https://www.linkedin.com/feed/update/urn:li:activity:6925139998321053697?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A6925139998321053697%2C6926915289175490563%29
| 1 |
4,456,656 | 107,880,056 |
2022-05-02 15:34:13.247
|
Figma: add icon to component library
|
As Figma now supports Emojis in Filenames to be set as Tab Icon, I'd vote
that we set one for the Pajamas Component library.
This can be very helpful to easier identify the tab of the component library!
### Proposal
Add the orange book emoji 📙\
Other Emoji proposals are welcome, too
| Before | After |
| ------ | ------ |
|  |  |
### What's needed
Change Filename from `Component library` to `📙 Component library`, that's it! :rocket:
| 1 |
4,456,656 | 107,853,598 |
2022-05-02 08:14:58.025
|
Alert component: make icon optional
|
As in https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2784 (and https://gitlab.com/gitlab-org/gitlab/-/merge_requests/86006 for the HAML version) we introduced the option to hide the icon, this issue will cover the Figma part to show/hide it.
| with Icon | without Icon |
| ------ | ------ |
|  |  |
### Figma
I created a branch with the needed changes to make the icon optional:
https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/jChRnVS9BonCCiQNlXaFPj/Component-library?node-id=425%3A1
| 1 |
4,456,656 | 107,372,004 |
2022-04-28 09:50:30.636
|
Figma pages list improvements
|
Let's improve the Figma pages list to add some visual hiearchy.
| Before | After |
| ------ | ------ |
|  |  |
Branch: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/nrjAlk336791WXFtpC88w0/Component-library?node-id=3050%3A0
| 1 |
4,456,656 | 107,361,787 |
2022-04-28 07:43:09.236
|
Dropdown > Consider consistent widths for the dropdown panel and inputs
|
## Problem
<!-- Add a short description of the documentation addition or update. Remember to say why, not just what. -->
Currently we use inconsistent widths for the dropdown inputs and the dropdown panels. The problems I see:
- Often times the panel width doesn't match the dropdown button or input width
- The dropdown buttons and inputs are sometimes too long for the content
| The dropdown could match the input in width. | The dropdown could match the dropdown button in width. |
| ------ | ------ |
| |  |
| Example in the "new MR" page with matching input and dropdown panel width |
| ------ |
|  |
## Proposal
I wonder if having set input field widths like `sm` `md` `lg` and `xl` would cover most cases in the product. If we already have fixed sizes for the dropdown button, input, and the dropdown panels, can we make the sizes match so the panel width can be same as the input in most cases?
The width of the dropdown button or input will be selected based on the average expected input string length, and the dropdown width should match the button/input width, except when the input is shorter than the dropdown panel min width.
It'd make the input much more consistent visually.
### Checklist
Make sure the following are completed before closing the issue:
1. [ ] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting.
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Component Lifecycle][component-lifecycle]
-->
[gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
| 2 |
4,456,656 | 107,333,098 |
2022-04-27 21:31:33.210
|
Update homepage banner
|
## Purpose
Update the Pajamas homepage to incorporate elements from the brand update and to remove elements from the background image that could become out of date (also, this will scale better than the current image that gets squished).
[View Figma working file →](https://www.figma.com/file/5ymbd6NElkEPD027vK570d/%231326-Pajamas-banner-JE?node-id=4%3A20)
| **Before** | **After** |
| ------ | ------ |
|  |  |
| 1 |
4,456,656 | 107,241,908 |
2022-04-26 19:34:21.883
|
VPAT > Introduce VPAT 2.4 WCAG template
|
## Purpose
GitLab currently uses the [VPAT 2.4 508 template](https://www.itic.org/dotAsset/7d1524dc-e602-47be-8276-ce32bdd58d6c.doc) that uses WCAG 2.0 Level AA Success Criteria as a reference. This doesn't satisfy the needs of those wanting to know where GitLab stands with WCAG 2.1, which is the latest release (WCAG 2.2 is still in draft). For that, there's a separate [VPAT 2.4 WCAG](https://www.itic.org/dotAsset/7edcd54d-c6a6-4649-8375-4a0f0c68eff2.doc) template that we can introduce. For a list of all VPAT templates, visit https://www.itic.org/policy/accessibility/vpat.
### Process
- Update navigation in Pajamas to create a "GitLab Accessibility Conformance Report" dropdown that reveals two options:
- VPAT 2.4 508
- VPAT 2.4 WCAG
- Update the current "GitLab Accessibility Conformance Report" page title to "VPAT 2.4 508"
- Add a new "VPAT 2.4 WCAG" page
- Copy the WCAG 2.0 2.0 data from the VPAT 2.4 508 page into this page
- Complete an evaluation that adds conformance findings for the [success criteria added in WCAG 2.1](https://www.w3.org/WAI/standards-guidelines/wcag/new-in-21/)
- Clarify VPAT and WCAG level on the [Statement of Compliance](https://design.gitlab.com/accessibility/a11y) page
| 3 |
4,456,656 | 106,528,622 |
2022-04-12 13:29:27.580
|
Migrate to embedded stories in components/tooltip.md
|
Migrate away from legacy examples to embedded stories in `components/tooltip.md`
- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter.
- [ ] Migrated `<example-display>` components to `<story-viewer>`.
- [ ] Removed the associated examples from the examples/ directory.
| 1 |
4,456,656 | 106,528,619 |
2022-04-12 13:29:25.809
|
Migrate to embedded stories in components/sorting.md
|
Migrate away from legacy examples to embedded stories in `components/sorting.md`
- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter.
- [ ] Migrated `<example-display>` components to `<story-viewer>`.
- [ ] Removed the associated examples from the examples/ directory.
| 1 |
4,456,656 | 106,528,613 |
2022-04-12 13:29:22.922
|
Migrate to embedded stories in components/infinite-scroll.md
|
Migrate away from legacy examples to embedded stories in `components/infinite-scroll.md`
- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter.
- [ ] Migrated `<example-display>` components to `<story-viewer>`.
- [ ] Removed the associated examples from the examples/ directory.
| 2 |
4,456,656 | 106,528,611 |
2022-04-12 13:29:21.088
|
Migrate to embedded stories in components/spinner.md
|
Migrate away from legacy examples to embedded stories in `components/spinner.md`
- [ ] Migrated the `vueComponents` property to `stories` in the frontmatter.
- [ ] Migrated `<example-display>` components to `<story-viewer>`.
- [ ] Removed the associated examples from the examples/ directory.
| 1 |
4,456,656 | 106,190,995 |
2022-04-06 16:34:16.384
|
Illustration library > Update Figma assets to align with brand
|
Update the [Illustration library](https://www.figma.com/file/1ui9w228X0S5WxaD0SRdIA/Illustration-library?node-id=0%3A1) in Figma to align with updates in https://gitlab.com/groups/gitlab-com/marketing/corporate_marketing/-/epics/201 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1288.
Updates will have to happen to:
- Styles
- Grid
- Components
- Other?
[View working file in Figma →](https://www.figma.com/file/1ui9w228X0S5WxaD0SRdIA/branch/tMPk4cKFcvn2A0GAp0M932/Illustration-library?node-id=0%3A1)
Updates to tanuki avatars and specific illustrations in the library will happen based on the results of https://gitlab.com/groups/gitlab-org/-/epics/7847 and will be handled on an individual basis.
| 8 |
4,456,656 | 106,190,897 |
2022-04-06 16:33:52.339
|
Illustration guidelines > Update to align with brand
|
Update https://design.gitlab.com/product-foundations/illustration to align with updates in https://gitlab.com/groups/gitlab-com/marketing/corporate_marketing/-/epics/201.
Adaptations may have to be made to account for:
- Grid (dimensions)
- Figma
- Color
- Light/dark UI
– etc.
| 3 |
4,456,656 | 106,036,928 |
2022-04-04 14:03:13.058
|
Text input > Move or remove character counter add-on
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1283, the proposal is to move the character counter outside of the textarea bounds. Given that a similar character counter exists as an add-on in the text input, this issue is to help determine if the character counter should be moved outside of the input bounds and treated as help text (which it is), or to remove it altogether if it's unused.
**Note**: The character counter add-on doesn't currently exist in GitLab UI.
### Proposal
Two options:
1. Remove the character counter from the text input altogether if there are no use cases to support it.
- Benefits:
- No need to have a build effort in GitLab UI.
- Removing unneeded/unused options.
1. Move the character-counter outside of the input bounds and treat as help text.
- Benefits:
- More room for content within the input bounds.
- Better UX by providing more helpful feedback than just a single number.
- More consistency with textarea proposal and use of help text.
- Simplification of component both in the UI kit, and in code.
- More accessible by providing meaningful feedback outside of the input bounds.
| Option A | Option B* |
| ------ | ------ |
|  |  |
\* Option B could either use a {#/#} pattern or more natural text. Also explored in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1283#proposal.
**Questions**
- Is there anywhere in the product that currently uses a character counter on a text input?
- Is there a current use case for the character counter that some form of help text wouldn't satisfy?
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ubxFCR4pADM7ZfMJ7ZvyOU/Component-library?node-id=49840%3A75722)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [ ] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [ ] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 105,911,042 |
2022-04-01 20:29:38.942
|
Dropdowns > Determine Pajamas IA to support new variants
|
## Purpose
In order to support the new "dropdown" components from the work in https://gitlab.com/groups/gitlab-org/-/epics/1059, we should consider how we might update the Pajamas navigation to help make it clear that there's more than one type of what is considered a dropdown. For example, a listbox, menu, or disclosure widget, etc.
## Proposal
Use "Dropdown" as a component category and have individual pages underneath for each type of implementation.
| 1 |
4,456,656 | 105,906,122 |
2022-04-01 18:27:07.360
|
Textarea > Update character counter UX and placement
|
<!--
Start by choosing one of the following based on the nature of your contribution:
- For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching.
- For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design.
- For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts.
To move a duplicate file:
Open the duplicate, then use the dropdown next to the file name to select
“Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.”
-->
### Description
Reconsider the placement of the character counter text and reconsider how the information can be more clearly conveyed. The current counter shows one number, but doesn't provide any comparison.
As uncovered in https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2738#note_896569524, the current placement of the counter collides with both text within the textarea and the scrollbar.
### Proposal
- Move the character counter outside of the textarea bounding box.
- Left align the character counter. This follows other form practices where labels and controls are left aligned and help with scanability.
- Use either a text explanation of what's happening with the counter, or two values so that the limit is always visible.
- The character counter is basically help text, so it seems to make sense to treat it as such. Additional help text and any validation messages would be below the character counter.
- Remove text highlight (adds a lot of development complexity).
- Only change the color for text when the count has been exceeded. The blue conflicts with text that is linked.
| **Current** | **Option A with {#}/{#}** | **Option B with text** |
| ------ | ------ | ------ |
|  |  |  |
#### Accessibility considerations
- Visible feedback should also be available/announced for screen reader users. For example, after a pause in typing the limit status is announced via an `aria-live="polite"` region.
- The placement of the counter could be out of view with screen magnification turned on, but form validation should help with any error remediation.
### Figma file
<!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. -->
[View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ubxFCR4pADM7ZfMJ7ZvyOU/Component-library?node-id=49840%3A75722)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] **Assignee**: Design in your working file. When applicable, follow our
[structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team].
1. [x] **Assignee**: Update the link to the working file in the issue
description.
1. [x] **Assignee**: Ask a [Foundations designer][foundations-team]
to review your design (ensure they have edit permissions in Figma).
1. [x] **Reviewer**: Review and approve assignee’s design. Specific design
questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility.
1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer]
for final review (make sure they have edit permissions in Figma).
1. [ ] **Maintainer**: Review and approve assignee’s changes.
1. [ ] **Maintainer**: Merge the branch or add the changes or additions to the
target file.
1. [ ] Ensure that all styles and components now belong to the target file.
1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure].
1. [ ] **Maintainer**: When applicable, [publish][publishing] any library
changes along with a clear commit message.
1. [ ] **Assignee**: If work was not done in a branch (a merged branch will automatically be archived), move your working file
to the shared Figma project:
1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project.
1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project.
1. [ ] If you’re a community contributor, please consider [transfering ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments.
1. [ ] **Assignee** (or Maintainer, for community contributions): If it’s a new
pattern or a significant change, add an agenda item to the next UX weekly call to inform the team.
1. [ ] **Assignee**: When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] **Assignee**: When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling.
1. [ ] **Assignee**: 🎉 Congrats, you made it! You can now close this issue.
[annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations
[building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components
[foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team
[figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com
[publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes
[structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure
[component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md
[component-archive]: https://www.figma.com/files/project/5472112/Component-archive
[misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive
[gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
[issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
| 1 |
4,456,656 | 105,744,407 |
2022-03-30 10:56:41.008
|
Badge > 12px and 16px icon Figma variants behave the same way
|
# Issue
Following on from the changes in #1280+
Badges with 16px icons retain their icon overrides when changing variation.
Badges with 12px icons do not retain their icon overrides when changing variation.
| Behaviour (16px) | Behaviour (12px) |
| ------ | ------ |
|  |  |
# Proposal
Make 12px and 16px icon Figma variants behave the same way.
As discussed in the Figma branch for #1280 there are some tradeoffs to be aware of:
- Lose a 'sensible' default
### [Figma branch for review :eyes:](https://www.figma.com/file/xIqrqxGgcl50I8akiQzfmG/%231281-badge-12px-and-16px-icon-override-parity?node-id=19947%3A350)
<details><summary>Full conversation:</summary>
Hey Jeremy Elder Nadia Sotnikova
here's a little bug fix for the 12px icon variants to fix
- Colour persistence when changing icon
- Icon persistence when changing variant
This makes the 12px icon behaviour the same as the 16px icon behaviour.
However, it does come with some tradeoffs
- Lose the 'sensible default' icon for each status
wdyt?
Changes:
- base components: Rename icon symbol layers
- base components: Relink icons to icon library
- variant components: Update to use naming from base component
- variant components: use the same icon to allow icon change persistence
---
Dan MH "Lose the 'sensible default' icon for each status" might be a dealbreaker for me. These have specific icon/color relationships that should exist out of the box.
---
Jeremy Elder I respect and understand that.
I found this unexpected behaviour when trying to add a badge to the Single Stat - https://www.figma.com/file/17NxNEMa7i28Is8sMetO2H/Data-Visualization?node-id=383%3A72
It is a pretty high friction process in its current form. And the defaults aren't sensible here.
To clarify — my expectation was for these to follow the same persistence rules as 16px icons.
The good news is, I'm 90% sure there is an alternative way we can set these up:
- Icon swaps use the right colour
- Variant (colour) swaps change the icon to the icon defined in the variant.
---
Dan MH would you be good with me updating this branch to the latest? It'll include the new tier badge.
---
Jeremy Elder I'd prefer to do it so I can remember what the changes were see_no_evil emoji
But only if we think we will proceed with any of these updates?
Otherwise we can just delete the branch
---
>But only if we think we will proceed with any of these updates?
I think it's a valid proposal if you're 90% sure it can be done!
Applied changes from main, so it may have reset the icons here.
---
To confirm the desired/proposed behaviour:
- 12px icon badges come bundled with an icon
- Icon changes maintain the correct colour to match the badge pill
- Changing the colour variant changes the icon to the bundled icon
If I'm tying myself in knots trying to explain I can jump on a quick sync at some point
Ok thats all done, and I think it is an improvement as is. :)
However, for many of my use cases the 'sensible defaults' hinder rather than help — so it would be nice to consider changing this behaviour to match the 16px icons in the future!
---
Dan MH after some consideration, I don't know that it's helpful to be as prescriptive here.
I had to circle back and through about the ability for you to extend these for your use case, but then that indeed would mean overriding this use case, but this use case is prescriptive and not universal, which isn't what we're going for here. Follow?
So… I'm up for reworking these to use generic defaults that can be updated at the time of use.
What could be helpful, would be adding out instances of the different color/icon/size associations commonly found. Thoughts?
---
Thanks for the continued discussion here Jeremy Elder .
Honestly I do see both sides of it.
My workaround was going to be to create extension of these (and other) symbols that match Optimizes use case and maintain them in an Optimize library.
I don't know what is best for the system and its users. Happy to follow your lead here.
I do think merging as-is would be an improvement, perhaps we could open this conversation wider for the last bit?
---
Dan MH Figma is having a tough go at spelling out what the changes are that I'm approving, could you unpack it a little further in the review description when you have a moment?
---
Jeremy Elder I've documented it in this issue https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1280
I wasn't expecting this much discussion, otherwise I would have created it sooner :D
</details>
| 1 |
5,261,717 | 30,087,182 |
2020-01-29 23:19:58.696
|
Error reporting to VSCode OutputChannel
|
### Problem to solve
In my experience today, there was very little information about what was working or not. The side pane simply stayed blank and did not show anything apart from the default text ("there is no XYZ assigned to you" etc.). Which makes it very hard to understand at what point something goes wrong or what might be the cause (connection to GitLab? authentication? extension not configured correctly?).
### Proposal
Creating and logging to an OutputChannel (see https://code.visualstudio.com/api/references/vscode-api#window.createOutputChannel) instead of logging to console would probably make it easier for the user to understand what is happening (and what not).
### Further details
#### In scope
- bubble exceptions to the top-level client code (e.g. `extension.js`) and then log them to the output channel
- make sure that exceptions are not silenced (by empty try/catch blocks)
- **stretch**: separate exceptions from normal program flow - a lot of code in `git_service.js` and `gitlab_service.js` is using exceptions as a part of normal program flow (e.g. command returning empty result & command throwing exception is treated the same)
- making sure that the OutputChannel is shown during automated integratin tests (it will help understanding what's wrong)
#### Out of scope
-
### Links / references
- https://code.visualstudio.com/api/references/vscode-api#window.createOutputChannel
| 3 |
5,261,717 | 26,478,886 |
2019-10-30 10:34:50.917
|
Insert Snippets in to current file in VS Code
|
## Problem to Solve
Snippets inside of a user account must be copy/pasted out of GitLab and into a file when they need to be used in another place. This is error prone and time consuming to context switch and find the appropriate Snippet and then paste the contents in to the file you're working on.
## Proposal
Create a command for `Insert Snippet` that talks to the GitLab Snippets API to retrieve a list of Snippets and then choose which file to insert.
- If a user selects insert snippet from the command palette, display a list of single file project scoped snippets in the modal
- If a user selects a snippet from the list insert it's content to the editor at the cursor position
<!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION -->
*This page may contain information related to upcoming products, features and functionality.
It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes.
Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.*
<!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION -->
| 3 |
5,261,717 | 21,291,743 |
2019-05-25 13:57:04.945
|
API calls fail when the GitLab instance is on a custom path, but the git remote isn't
|
## Summary
The API calls are not working when the `gitlab.instanceUrl` setting contains a custom path, but the `git remote` URL doesn't.
Example:
```
"gitlab.instanceUrl": "http://aom-int/gitlab",
```
and `git remote`:
```
git@aom-int:depoortere/testmaven.git
```
The parsing logic expects that if the `instanceUrl` contains a custom path, the `git remote` will too. From the example above: `http://aom-int/gitlab` `instanceUrl` should have `git@aom-int:gitlab/depoortere/testmaven.git` `git remote`.
### Details
The original issue with GitLab on a custom path is this: https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/42
And the initial fix was implemented in https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/merge_requests/11.
[The implementation](https://gitlab.com/gitlab-org/gitlab-vscode-extension/blob/56dab86117c109443a9422b85b58605fa5b774f1/src/git/git_remote_parser.ts#L30) assumes that if your GitLab instance is on a custom path (e.g. `/gitlab`) then the `git remote` URL contains the same path (i.e. in above scenario the remote should be `git@aom-int:gitlab/depoortere/testmaven.git`. I'm not sure whether that's a reasonable assumption or not, but it doesn't hold true in above scenario.
A workaround might be to use `https://` remote URL instead of the `git@..`. I assume that the `https://` version would have `/gitlab` in the remote path.
The code for parsing remotes is in [`git_remote_parser.ts`](https://gitlab.com/gitlab-org/gitlab-vscode-extension/blob/56dab86117c109443a9422b85b58605fa5b774f1/src/git/git_remote_parser.ts#L10-38). I'm open to suggestions about how to change it. I also include a failing test with above scenario:
<details>
<summary>Failing test case</summary>
```diff
diff --git a/src/git/git_remote_parser.test.ts b/src/git/git_remote_parser.test.ts
index 33cba5a..c3c4586 100644
--- a/src/git/git_remote_parser.test.ts
+++ b/src/git/git_remote_parser.test.ts
@@ -81,4 +81,14 @@ describe('git_remote_parser', () => {
project: 'gitlab-vscode-extension',
});
});
+
+ it('should support host aliases with a custom path', () => {
+ expect(
+ parseGitRemote('git@aom-int:depoortere/testmaven.git', 'https://aom-int/gitlab'),
+ ).toEqual({
+ host: 'aom-int',
+ namespace: 'depoortere',
+ project: 'testmaven',
+ });
+ });
});
```
</details>
<details>
<summary>Original issue description</summary>
Say my GITLAB instance URL is https://xyz.com/gitlab (Exposed via Nginx)
In this case, the parsing by the extension is done incorrectly and fails to retrieve any information.
The parsed array gives this (removing /gitlab from the path):
["http:", "xyz.com", "my-group/subgroup1", "project"]
And thus the extension does not work. I tried concatenating the extra "/gitlab" and still it does not work.
Meanwhile, what ports does this extension need/use? I only have https port of my instance exposed - have not exposed the SSH or git port.
</details>
| 1 |
5,261,717 | 16,800,932 |
2018-12-19 22:42:26.196
|
Matching access token URL with GitLab instance URL is too strict
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label:
- https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
If you are facing issues around configuring Token from your GitLab.com account, see the list of already addressed Token related issues:
https://gitlab.com/gitlab-org/gitlab-vscode-extension/issues?scope=all&utf8=%E2%9C%93&state=closed&label_name[]=token-issue
--->
### Summary
The GitLab instance URL configured in `gitlab.instanceUrl` and the URL you specify when adding a new access token needs to match perfectly. If one contains slash at the end, the token is not used.
<details>
<summary>Original description</summary>
Connection issues with self-hosted GitLab instance URL name.
e.g. correct connection when `https://my.gitlabinstance.io/group-name/project1` as opposed to `https://my.gitlabinstance.io/group-name/project1/`
There are no instructions that mention to put it exactly like this...
</details>
### Steps to reproduce
1. open workspace with project on `gitlab.com`
1. remove your token with `GitLab: Remove your Personal Access Token` command
1. add the same token but specify `https://gitlab.com/` as the instance URL (notice the `/` at the end)
1. now the extension can't authenticate your requests and you see an error
### What is the current *bug* behavior?
The extension cant match the token for `https://gitlab.com/` with the configured instance `https://gitlab.com` (without the slash)
### What is the expected *correct* behavior?
The extension should be able to recognise that those two URLs are for the same GitLab instance and use the token
### Relevant logs and/or screenshots
### Possible fixes
A naive solution would be to remove trialling slashes. A more complete solution could be parsing the URLs and deciding what parts need to match (most likely hostname, and port, maybe protocol).
| 1 |
5,261,717 | 14,680,257 |
2018-10-04 10:53:18.349
|
Auto update "For Current Branch" tab in sidebar
|
To improve the current behavior "For Current Branch" tab should auto update itself.
Also refreshing the panels should clear issue and MR cache. Related with this one https://gitlab.com/fatihacet/gitlab-vscode-extension/issues/21
## Problem
Rith now the sidebar with "For Current Branch" information needs to be manually refreshed and it will likely show outdated information.
Additionally, the status bar refreshes every 30s, but at the start of the VS Code, the first refresh happens before the extension can access the git repository and the user always sees roughly 25s of "initializing status bar":
## Proposal
Both the "For Current Branch" sidebar panel and the status bar are using the same information (pipeline, MR, and issue). I suggest that they'll get automatically updated together. The update is going to be triggered by the following events:
- Repository has been initialized (fixes the initial 25s of delay)
- Branch has been changed
- 30 seconds have passed since the last update (only this is now partially implemented)
| 2 |
5,261,717 | 10,763,880 |
2018-05-10 14:47:44.457
|
Merge requests fail where branch contains a # symbol
|
### Summary
When we call `GitLab: Crete new merge request on current branch` command, branch with `#` doesn't get escaped causing incorrect branch name
### Steps to reproduce
1. Create `test-#-hash` branch and push a commit to the remote.
1. Run `GitLab: Crete new merge request on current branch` command
### What is the current *bug* behavior?
The branch name appears unescaped in the URL:
```
http://127.0.0.1:3000/root/empty-test-2/-/merge_requests/new?merge_request%5Bsource_branch%5D=test-#-hash
```
The `#-hash` gets treated as the browser ID fragment.
### What is the expected *correct* behavior?
The `#` is encoded and we open the MR with the following URL:
```
http://127.0.0.1:3000/root/empty-test-2/-/merge_requests/new?merge_request[source_branch]=test-%23-hash
```
### Relevant logs and/or screenshots
### Possible fixes
Probably calling `encodeURIComponent(branchName);` is enough to fix the issue.
| 1 |
5,261,717 | 117,140,277 |
2022-10-19 01:39:45.849
|
Add OAuth support for VSCodium
|
When I click the `Connect to GitLab.com with OAuth` button I get a redirect error screen on GitLab's Web UI:
This is probably due to it being on VSCodium... so the redirect url includes: `vscodium` instead of `vscode`:
```
https://gitlab.com/oauth/authorize?client_id=...&redirect_uri=vscodium%3A%2F%2Fgitlab.gitlab-workflow%2Fauthentication&response_type=code&state=...&scope=api+read_user&code_challenge=...&code_challenge_method=S256
```
we likely need to add it as valid redirects
| 1 |
5,261,717 | 116,769,263 |
2022-10-12 17:23:38.888
|
Don't log the whole token
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label:
- https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Checklist
<!-- Please test the latest versions, that will remove the possibility that you see a bug that is fixed in a newer version. -->
- [ ] I'm using the latest version of the extension ([see the latest version in the right column of this page](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow))
- Extension version: _Put your extension version here_
- [ ] I'm using the latest VS Code version ([find the latest version here](https://github.com/microsoft/vscode/releases))
- VS Code version: _Put your VS Code version here_
- [ ] I'm using a supported version of GitLab ([see README for the supported version](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/README.md#minimum-supported-version))
- GitLab version: _Put your GitLab version here, or say "happens on `gitlab.com`"_
### Summary
When user enables debug logging, we log the whole token in the extension output every time the OAuth token is refreshed (~2h). Ideally we would like not to log the whole access token.
https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/77a1cbc0f7d85dbab917d8c06203663bbc87b525/src/gitlab/token_exchange_service.ts#L111
### Steps to reproduce
<!-- How one can reproduce the issue - this is very important -->
### What is the current _bug_ behavior?
<!-- What actually happens -->
### What is the expected _correct_ behavior?
<!-- What you should see instead -->
### Relevant logs and/or screenshots
<!-- Logs can be found by running `GitLab: Show extension logs` command (using `cmd+shift+p`). Please enable `"gitlab.debug": true` in your `settings.json`. Debug mode will improve error stack traces and adds debug log messages. -->
### Possible fixes
<!-- If you can, link to the line of code that might be responsible for the problem -->
| 3 |
5,261,717 | 112,169,745 |
2022-07-25 17:22:56.460
|
Custom Query error with `avatar_url` in Vulnerabilty Reports
|
## Problem to Solve
When using a custom query to look at vulnerability reports, there is an issue with `avatar_url` being expected in the response:
**Error Message:**
```
[error]: Cannot read properties of undefined (reading 'avatar_url')
TypeError: Cannot read properties of undefined (reading 'avatar_url')
at /Users/phikai/.vscode-insiders/extensions/gitlab.gitlab-workflow-3.47.2/out/extension.js:298:239
at Array.map (<anonymous>)
at Js.getIssuables (/Users/phikai/.vscode-insiders/extensions/gitlab.gitlab-workflow-3.47.2/out/extension.js:327:3252)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async bd.getProjectIssues (/Users/phikai/.vscode-insiders/extensions/gitlab.gitlab-workflow-3.47.2/out/extension.js:344:2214)
at async bd.getChildren (/Users/phikai/.vscode-insiders/extensions/gitlab.gitlab-workflow-3.47.2/out/extension.js:344:2963)
at async v.fetchChildrenNodes (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:106:19736)
at async v.getChildren (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:106:15955)
```
**Custom Query:**
```
"gitlab.customQueries": [
{
"name": "Vulnerability Reports",
"type": "vulnerabilities",
"scope": "all",
"noItemText": "No Vulns.",
"state": "opened"
}
]
```
This was tested against the `gitlab-org/gitlab` project.
| 1 |
5,261,717 | 109,854,568 |
2022-06-09 13:27:08.070
|
Update development documentation
|
### Problem to solve
The development documentation hasn't been updated in about a year. We plan to add more team members as maintainers soon. That means we need the development documentation up to date.
### Proposal
Review the following documents:
- [x] CONTRIBUTING.md
- [x] docs/developer/architecture.md
- [x] docs/developer/ci-variables.md
- [x] docs/developer/coding-guidelines.md
- [x] docs/developer/commits.md
- [x] docs/developer/developer-process.md
- [x] docs/developer/maintainer.md
- [x] docs/developer/release-process.md
- [x] docs/developer/security-releases.md
- [x] docs/developer/testing-strategy.md
- [x] docs/developer/writing-tests.md
### Links / references
| 1 |
5,261,717 | 108,685,441 |
2022-05-17 13:51:27.785
|
PAT no longer available after restart
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label:
- https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Checklist
<!-- Please test the latest versions, that will remove the possibility that you see a bug that is fixed in a newer version. -->
- [x] I'm using the latest version of the extension ([see the latest version in the right column of this page](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow))
- Extension version: v3.44.1
- [x] I'm using the latest VS Code version ([find the latest version here](https://github.com/microsoft/vscode/releases))
- VS Code version: 1.67.1
- [x] I'm using a supported version of GitLab ([see README for the supported version](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/README.md#minimum-supported-version))
- GitLab version: 14.9.1
### Summary
Initial installation of the plugin works well after the PAT and URL are set up.
After shutdown of VSCode and restart the PAT seems to be unavailable.
I'm not sure how to debug any further.
### Steps to reproduce
1. Start with a linux desktop environment. In this case Archlinux with SwayWM.
2. Launch VSCode, install the plugin, and configure it with a URL and PAT.
3. Observe all works well.
4. Exit VSCode and re-launch.
5. Observe that the extension no longer is authenticated
6. Attempt to provide the URL and a new PAT, but it never succeeds.
### What is the current _bug_ behavior?
Plugin no longer works.
### What is the expected _correct_ behavior?
1. That the PAT is retained for next launch
2. That the plugin continues to work after re-launch
### Relevant logs and/or screenshots
```
[error]: Account for instance REDACTED and user REDACTED is missing token in secret storage. Try to remove the account and add it again.
```
### Possible fixes
<!-- If you can, link to the line of code that might be responsible for the problem -->
| 2 |
5,261,717 | 108,130,012 |
2022-05-06 07:58:14.149
|
MR Review comments are not rendering Markdown
|
### Checklist
<!-- Please test the latest versions, that will remove the possibility that you see a bug that is fixed in a newer version. -->
- [x] I'm using the latest version of the extension ([see the latest version in the right column of this page](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow))
- Extension version: `3.43.1`
- [x] I'm using the latest VS Code version ([find the latest version here](https://github.com/microsoft/vscode/releases))
- VS Code version: `1.67.0-insider`
- [x] I'm using a supported version of GitLab ([see README for the supported version](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/README.md#minimum-supported-version))
- GitLab version: "happens on `gitlab.com`"
### Summary
Markdown in MR comments stopped rendering in the newer version of VS Code
GitLab Workflow depended on a "bug" in VS Code. VS Code rendered plain text comment body as markdown ([Comment.body rendered as Markdown, even for plain strings · Issue #140967 · microsoft/vscode](https://github.com/microsoft/vscode/issues/140967)). They fixed it in February 2022 and since then we show plain text MR comments.
### Steps to reproduce
1. See any MR comment with Markdown syntax.
### What is the current _bug_ behavior?
Markdown is shown as plain string.
### What is the expected _correct_ behavior?
Markdown should be rendered.
### Relevant logs and/or screenshots
<!-- Logs can be found by running `GitLab: Show extension logs` command (using `cmd+shift+p`) -->
### Possible fixes
Use `vscode.MarkdownString` rather than `string` for the MR body.
| 1 |
5,261,717 | 107,015,529 |
2022-04-22 08:08:31.388
|
Advanced search is broken + minor errors in issuable search
|
### Summary
The extension has a rudimentary search feature (it shows you input box and then it opens the web search results for you).
There are 3 commands:
- `GitLab: Search Project Issues (Supports Filters)`
- `GitLab: Search Project Merge Requests (Supports Filters)`
- `GitLab: Project Advanced Search (Issues, MR's, Commits, Comments...)`
The advanced project search doesn't work. The remaining searches are sometimes throwing errors (no user-facing defects though).
### Steps to reproduce
1. Open GitLab project in VS Code
2. run the `GitLab: Project Advanced Search (Issues, MR's, Commits, Comments...)`
3. type in any query that would normally return results
4. see that the search results are empty
### What is the current _bug_ behavior?
The extension creates URL with `project_id=undefined` in it and the search results are empty.
### What is the expected _correct_ behavior?
The extension creates correct URL and there are search results.
### Relevant logs and/or screenshots
### Possible fixes
We use `project.id` in `search_input.js`, we should use `project.restId`. Best solution is to migrate this small file to TS, which would discover such an issue.
| 1 |
5,261,717 | 106,325,001 |
2022-04-08 11:38:31.872
|
Implement OAuth token refreshing
|
### Problem to solve
When we generate an access token using the OAuth flow (https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/560), the token will expire (by default in 2 hours).
### Proposal
Ask for a new token using the `refresh_token` https://docs.gitlab.com/ee/api/oauth2.html#authorization-code-with-proof-key-for-code-exchange-pkce.
### Further details
We'll need to keep track of when the original token has been generated and refresh it when the extension want's to use it after its expiration time.
### Links / references
| 2 |
5,261,717 | 106,324,564 |
2022-04-08 11:27:06.847
|
Implement OAuth flow for `gitlab.com`
|
### Problem to solve
Users have to [log in with generated personal access token](https://gitlab.com/gitlab-org/gitlab-vscode-extension#setup).
### Proposal
Allow OAuth authorization so user's can log in to `gitlab.com` without generating token.
### Further details
https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/221#note_885722819
### Links / references
| 2 |
5,261,717 | 106,032,596 |
2022-04-04 13:05:49.059
|
Project-centric data model - change extension model to reflect Git and GitLab models
|
### Problem to solve
There are many edge cases when the extension's internal state can't reflect how entities (git remotes and GitLab projects) relate to each other. This is caused by the incremental nature of the current model design.
1. We started with workspace centric approach, where the whole extension operated on an opened folder. This implementation couldn't support multiple repositories.
1. We refactored the extension to use repositories instead of workspaces (https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/345). This was a large improvement, but the model still struggles to reflect some scenarios. It especially struggles with multiple remotes and repositories that don't contain GitLab projects.
The way how repository-centred approach doesn't exactly reflect the Git repository + GitLab project entities is a cause of small bugs and misunderstandings. Currently, we [mix repository and project-related methods](https://gitlab.com/gitlab-org/gitlab-vscode-extension/blob/d92a0cb3cfa47d5cc7dcf074edd21a6220bb8870/src/git/wrapped_repository.ts#L71).
### Proposal
In hindsight, the solution is clear: Use the GitLabProject-centric approach. As the extension starts or configuration changes, we'll loop over all remote URLs in all repositories and find out which ones correspond to GitLab projects. Then, if there's more than one GitLab project per repository, we'll let the user choose which one they want to use.
### Benefits
- Simpler logic, many places in the codebase are now concerned about how to obtain GitLabProject from a repository. There is often an implicit expectation that the project is present.
- Simpler mental model - a few entities will reflect the whole application state, clear separation between the GitLab project model and the local repository model
- Easy support for [multiple accounts](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/298), which will become more important once we implement [OAuth login](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/221)
### Further details
Here are a few issues that we implemented to work around the repository-centric model:
- [Helping users set the correct remote name](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/459)
- [Unable to Validate CI config for mirrored repository](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/505)
- [Extension ignores expired token and fails in the wrong place](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/487)
### Proposed model
I'll put this in a diagram a bit later:
```ts
interface Repository {
remotes: Remote[]
// all local repository git methods will be here
}
interface Remote {
name: string;
urlEntries: UrlEntry[];
}
interface UrlEntry {
type: 'fetch' | 'push' | 'both';
url: string;
}
/* This pointer allows us to work with remote URLs (because they represent GitLab Project),
* but also keep track of what local repository contains this remote URL.
*/
interface RemoteUrlPointer {
repository: Repository;
remote: Remote;
urlEntry: UrlEntry;
}
interface Account {
instanceUrl: string;
token: string;
}
/* Represents a GitLab project that we can infer from remote URL and instance URL */
interface ParsedProject {
remoteUrl: string;
instanceUrl: string;
projectName: string;
namespace: string;
}
/* In a case when there is more than one GitLab project in a repository,
* the user will create this setting to indicate which project should be used.
* This will be a persistent setting stored in the global storage.
*
* There can be more than one GitLab project for a repository if there are multiple
* remotes like:
*
* - git@gitlab.com:gitlab-org/gitlab-vscode-extension.git
* - git@gitlab.com:gitlab-org/security/gitlab-vscode-extension.git
*
* Or when there are multiple accounts on the same GitLab instance.
*/
interface SelectedProject {
pointer: RemoteUrlPointer;
account: Account;
projectName: string;
namespace: string;
}
/* This represents a GitLab project that the rest of the extension will work with
* this entity only exists at runtime, and the `GitLabProject` is always populated by querying a GitLab API
*/
interface InitializedProject {
project: GitLabProject;
pointer: RemoteUrlPointer;
account: Account;
// all GitLab project methods are going to be either here or accessed through here
}
```
### Links / references
| 3 |
5,261,717 | 105,059,947 |
2022-03-18 10:01:54.691
|
Failed to fetch jobs for pipeline (for current branch) - project_id in the requested url is 'undefined'
|
### Checklist
- [x] I'm using the latest version of the extension ([see the latest version in the right column of this page](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow))
- Extension version: v3.41.2 (v3.39.0 also has the same issue)
- [x] I'm using the latest VS Code version ([find the latest version here](https://github.com/microsoft/vscode/releases))
- VS Code version: 1.65.2
- [x] I'm using a supported version of GitLab ([see README for the supported version](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/README.md#minimum-supported-version))
- GitLab version: 13.5.4-ee
### Summary
<!-- Summarize the bug encountered concisely -->
### Steps to reproduce
1. Install this extension
2. Setup gitlab.instanceUrl and personal access token
3. Open an VSCode workspace hosted by gitlab 13.5.4-ee
4. Click the gitlab icon in the sidebar, the pipeline result `FORCURRENT BRANCH` does not show fully: it shows the overall status but details are not displayed
### What is the current _bug_ behavior?
Can't see details of pipeline (see picture below)
### What is the expected _correct_ behavior?
Show details of pipeline correctly
### Relevant logs and/or screenshots
Logs from `GitLab: Show extension logs`
```
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async An.clearAndSetIntervalAndRefresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7866)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async An.clearAndSetIntervalAndRefresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7866)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7745)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async gl.refreshSidebar (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:317:2934)",
"\tat async c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:317:1540",
"\tat async r._executeContributedCommand (c:\\Apps\\VS Code\\resources\\app\\out\\vs\\workbench\\services\\extensions\\node\\extensionHostProcess.js:95:31072)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8015)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8015)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8015)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8015)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8015)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8015)"
]
}
[error]: {
"userMessage": "Failed to fetch jobs for pipeline.",
"errorMessage": "Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"stack": [
"Error: Fetching jobs for pipeline from https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs failed",
"\tat ps (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:444)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)",
"\tat async pa.fetch (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:265:1606)",
"\tat async zv (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:7053)",
"\tat async Function.getState (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8530)",
"\tat async An.refresh (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8142)",
"\tat async Timeout._onTimeout (c:\\Apps\\VS Code\\data\\extensions\\gitlab.gitlab-workflow-3.41.2\\out\\extension.js:316:8015)"
]
}
```
(Note: I use a portable VS Code to re-produce this issue without any other extensions installed, but the issue also exists in a normal user setup of VS Code)
### Possible fixes
The problem might be caused by failure when get project id: in the log, you can see `undefined` in the request url, where it should be a project id:
`https://gitlab.ourcompany.com/api/v4/projects/undefined/pipelines/397251/jobs`
I try to replace regex `\{\w+\.project_id\}` with my project id `438` in `C:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.2`, then it works (see the picture below):
| 1 |
5,261,717 | 104,749,501 |
2022-03-14 08:17:12.947
|
Fail to access merge request and pipeline result - Field 'url' doesn't exist on type 'Note'
|
### Checklist
<!-- Please test the latest versions, that will remove the possibility that you see a bug that is fixed in a newer version. -->
- [x] I'm using the latest version of the extension ([see the latest version in the right column of this page](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow))
- Extension version: v3.41.1
- [x] I'm using the latest VS Code version ([find the latest version here](https://github.com/microsoft/vscode/releases))
- VS Code version: 1.65.2 (user setup)
- [x] I'm using a supported version of GitLab ([see README for the supported version](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/README.md#minimum-supported-version))
- GitLab version: 13.5.4-ee
### Summary
### Steps to reproduce
1. Install this extension
2. Setup gitlab.instanceUrl and personal access token
3. Open an VSCode workspace hosted by gitlab EE
4. Click the gitlab icon in the sidebar, it shows list of the merge requests
(But here, the pipeline result FORCURRENT BRANCH does not show fully)
5. Click any MR in the ISSUES AND MERGE REQUESTS, an error message displays:
```
The extension failed to preload discussions on the MR diff.
It's possible that you've encountered
https://gitlab.com/gitlab-org/gitlab/-/issues/298827.
```
(I tried to find a solution from above URL but not found)
6. Click 'Overview' of a MR, another error message displays:
```
Field 'url' doesn't exist on type 'Note': {"response":{"errors":[{"message":"Field 'url' doesn't exist on type 'Note'","locations":[{"line":35,"column":5}],"path":["fragment noteDetails","url"],"extensions":{"code":"undefinedField","typeName":"Note","fieldName":"url"}}],"status":200,"headers":{}},"request":{"query":"\n \n \n \n \n fragment position on Note {\n position {\n diffRefs {\n baseSha\n headSha\n startSha\n }\n filePath\n positionType\n newLine\n oldLine\n newPath\n oldPath\n positionType\n }\n }\n\n fragment noteDetails on Note {\n id\n createdAt\n system\n author {\n avatarUrl\n name\n username\n webUrl\n }\n body\n bodyHtml\n url\n userPermissions {\n resolveNote\n adminNote\n createNote\n }\n ...position\n }\n\n fragment discussionDetails on Discussion {\n replyId\n createdAt\n resolved\n resolvable\n notes {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...noteDetails\n }\n }\n }\n\n fragment discussions on DiscussionConnection {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...discussionDetails\n }\n }\n\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\n project(fullPath: $projectPath) {\n id\n mergeRequest(iid: $iid) {\n discussions(after: $afterCursor) {\n ...discussions\n }\n }\n }\n }\n","variables":{"projectPath":"dev/ProjectName","iid":"729"}}}
```
### What is the current _bug_ behavior?
Can't open the merge request
### What is the expected _correct_ behavior?
It should open the MR correctly
<!-- What you should see instead -->
### Relevant logs and/or screenshots
log from 'GitLab: Show extension logs'
```
[error]: {
"userMessage": "The extension failed to preload discussions on the MR diff.\n It's possible that you've encountered\n https://gitlab.com/gitlab-org/gitlab/-/issues/298827.",
"errorMessage": "Field 'url' doesn't exist on type 'Note': {\"response\":{\"errors\":[{\"message\":\"Field 'url' doesn't exist on type 'Note'\",\"locations\":[{\"line\":35,\"column\":5}],\"path\":[\"fragment noteDetails\",\"url\"],\"extensions\":{\"code\":\"undefinedField\",\"typeName\":\"Note\",\"fieldName\":\"url\"}}],\"status\":200,\"headers\":{}},\"request\":{\"query\":\"\\n \\n \\n \\n \\n fragment position on Note {\\n position {\\n diffRefs {\\n baseSha\\n headSha\\n startSha\\n }\\n filePath\\n positionType\\n newLine\\n oldLine\\n newPath\\n oldPath\\n positionType\\n }\\n }\\n\\n fragment noteDetails on Note {\\n id\\n createdAt\\n system\\n author {\\n avatarUrl\\n name\\n username\\n webUrl\\n }\\n body\\n bodyHtml\\n url\\n userPermissions {\\n resolveNote\\n adminNote\\n createNote\\n }\\n ...position\\n }\\n\\n fragment discussionDetails on Discussion {\\n replyId\\n createdAt\\n resolved\\n resolvable\\n notes {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...noteDetails\\n }\\n }\\n }\\n\\n fragment discussions on DiscussionConnection {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...discussionDetails\\n }\\n }\\n\\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\\n project(fullPath: $projectPath) {\\n id\\n mergeRequest(iid: $iid) {\\n discussions(after: $afterCursor) {\\n ...discussions\\n }\\n }\\n }\\n }\\n\",\"variables\":{\"projectPath\":\"dev/ProjectName\",\"iid\":\"731\"}}}",
"stack": [
"Error: Field 'url' doesn't exist on type 'Note': {\"response\":{\"errors\":[{\"message\":\"Field 'url' doesn't exist on type 'Note'\",\"locations\":[{\"line\":35,\"column\":5}],\"path\":[\"fragment noteDetails\",\"url\"],\"extensions\":{\"code\":\"undefinedField\",\"typeName\":\"Note\",\"fieldName\":\"url\"}}],\"status\":200,\"headers\":{}},\"request\":{\"query\":\"\\n \\n \\n \\n \\n fragment position on Note {\\n position {\\n diffRefs {\\n baseSha\\n headSha\\n startSha\\n }\\n filePath\\n positionType\\n newLine\\n oldLine\\n newPath\\n oldPath\\n positionType\\n }\\n }\\n\\n fragment noteDetails on Note {\\n id\\n createdAt\\n system\\n author {\\n avatarUrl\\n name\\n username\\n webUrl\\n }\\n body\\n bodyHtml\\n url\\n userPermissions {\\n resolveNote\\n adminNote\\n createNote\\n }\\n ...position\\n }\\n\\n fragment discussionDetails on Discussion {\\n replyId\\n createdAt\\n resolved\\n resolvable\\n notes {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...noteDetails\\n }\\n }\\n }\\n\\n fragment discussions on DiscussionConnection {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...discussionDetails\\n }\\n }\\n\\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\\n project(fullPath: $projectPath) {\\n id\\n mergeRequest(iid: $iid) {\\n discussions(after: $afterCursor) {\\n ...discussions\\n }\\n }\\n }\\n }\\n\",\"variables\":{\"projectPath\":\"dev/ProjectName\",\"iid\":\"731\"}}}",
"\tat c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:15173",
"\tat o (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:10042)",
"\tat Object.next (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:9346)",
"\tat p (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:8906)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)"
]
}
[error]: Field 'url' doesn't exist on type 'Note': {"response":{"errors":[{"message":"Field 'url' doesn't exist on type 'Note'","locations":[{"line":35,"column":5}],"path":["fragment noteDetails","url"],"extensions":{"code":"undefinedField","typeName":"Note","fieldName":"url"}}],"status":200,"headers":{}},"request":{"query":"\n \n \n \n \n fragment position on Note {\n position {\n diffRefs {\n baseSha\n headSha\n startSha\n }\n filePath\n positionType\n newLine\n oldLine\n newPath\n oldPath\n positionType\n }\n }\n\n fragment noteDetails on Note {\n id\n createdAt\n system\n author {\n avatarUrl\n name\n username\n webUrl\n }\n body\n bodyHtml\n url\n userPermissions {\n resolveNote\n adminNote\n createNote\n }\n ...position\n }\n\n fragment discussionDetails on Discussion {\n replyId\n createdAt\n resolved\n resolvable\n notes {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...noteDetails\n }\n }\n }\n\n fragment discussions on DiscussionConnection {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...discussionDetails\n }\n }\n\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\n project(fullPath: $projectPath) {\n id\n mergeRequest(iid: $iid) {\n discussions(after: $afterCursor) {\n ...discussions\n }\n }\n }\n }\n","variables":{"projectPath":"dev/ProjectName","iid":"731"}}}
Error: Field 'url' doesn't exist on type 'Note': {"response":{"errors":[{"message":"Field 'url' doesn't exist on type 'Note'","locations":[{"line":35,"column":5}],"path":["fragment noteDetails","url"],"extensions":{"code":"undefinedField","typeName":"Note","fieldName":"url"}}],"status":200,"headers":{}},"request":{"query":"\n \n \n \n \n fragment position on Note {\n position {\n diffRefs {\n baseSha\n headSha\n startSha\n }\n filePath\n positionType\n newLine\n oldLine\n newPath\n oldPath\n positionType\n }\n }\n\n fragment noteDetails on Note {\n id\n createdAt\n system\n author {\n avatarUrl\n name\n username\n webUrl\n }\n body\n bodyHtml\n url\n userPermissions {\n resolveNote\n adminNote\n createNote\n }\n ...position\n }\n\n fragment discussionDetails on Discussion {\n replyId\n createdAt\n resolved\n resolvable\n notes {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...noteDetails\n }\n }\n }\n\n fragment discussions on DiscussionConnection {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...discussionDetails\n }\n }\n\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\n project(fullPath: $projectPath) {\n id\n mergeRequest(iid: $iid) {\n discussions(after: $afterCursor) {\n ...discussions\n }\n }\n }\n }\n","variables":{"projectPath":"dev/ProjectName","iid":"731"}}}
at c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:15173
at o (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:10042)
at Object.next (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:9346)
at p (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:8906)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
[error]: {
"userMessage": "The extension failed to preload discussions on the MR diff.\n It's possible that you've encountered\n https://gitlab.com/gitlab-org/gitlab/-/issues/298827.",
"errorMessage": "Field 'url' doesn't exist on type 'Note': {\"response\":{\"errors\":[{\"message\":\"Field 'url' doesn't exist on type 'Note'\",\"locations\":[{\"line\":35,\"column\":5}],\"path\":[\"fragment noteDetails\",\"url\"],\"extensions\":{\"code\":\"undefinedField\",\"typeName\":\"Note\",\"fieldName\":\"url\"}}],\"status\":200,\"headers\":{}},\"request\":{\"query\":\"\\n \\n \\n \\n \\n fragment position on Note {\\n position {\\n diffRefs {\\n baseSha\\n headSha\\n startSha\\n }\\n filePath\\n positionType\\n newLine\\n oldLine\\n newPath\\n oldPath\\n positionType\\n }\\n }\\n\\n fragment noteDetails on Note {\\n id\\n createdAt\\n system\\n author {\\n avatarUrl\\n name\\n username\\n webUrl\\n }\\n body\\n bodyHtml\\n url\\n userPermissions {\\n resolveNote\\n adminNote\\n createNote\\n }\\n ...position\\n }\\n\\n fragment discussionDetails on Discussion {\\n replyId\\n createdAt\\n resolved\\n resolvable\\n notes {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...noteDetails\\n }\\n }\\n }\\n\\n fragment discussions on DiscussionConnection {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...discussionDetails\\n }\\n }\\n\\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\\n project(fullPath: $projectPath) {\\n id\\n mergeRequest(iid: $iid) {\\n discussions(after: $afterCursor) {\\n ...discussions\\n }\\n }\\n }\\n }\\n\",\"variables\":{\"projectPath\":\"dev/ProjectName\",\"iid\":\"730\"}}}",
"stack": [
"Error: Field 'url' doesn't exist on type 'Note': {\"response\":{\"errors\":[{\"message\":\"Field 'url' doesn't exist on type 'Note'\",\"locations\":[{\"line\":35,\"column\":5}],\"path\":[\"fragment noteDetails\",\"url\"],\"extensions\":{\"code\":\"undefinedField\",\"typeName\":\"Note\",\"fieldName\":\"url\"}}],\"status\":200,\"headers\":{}},\"request\":{\"query\":\"\\n \\n \\n \\n \\n fragment position on Note {\\n position {\\n diffRefs {\\n baseSha\\n headSha\\n startSha\\n }\\n filePath\\n positionType\\n newLine\\n oldLine\\n newPath\\n oldPath\\n positionType\\n }\\n }\\n\\n fragment noteDetails on Note {\\n id\\n createdAt\\n system\\n author {\\n avatarUrl\\n name\\n username\\n webUrl\\n }\\n body\\n bodyHtml\\n url\\n userPermissions {\\n resolveNote\\n adminNote\\n createNote\\n }\\n ...position\\n }\\n\\n fragment discussionDetails on Discussion {\\n replyId\\n createdAt\\n resolved\\n resolvable\\n notes {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...noteDetails\\n }\\n }\\n }\\n\\n fragment discussions on DiscussionConnection {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...discussionDetails\\n }\\n }\\n\\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\\n project(fullPath: $projectPath) {\\n id\\n mergeRequest(iid: $iid) {\\n discussions(after: $afterCursor) {\\n ...discussions\\n }\\n }\\n }\\n }\\n\",\"variables\":{\"projectPath\":\"dev/ProjectName\",\"iid\":\"730\"}}}",
"\tat c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:15173",
"\tat o (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:10042)",
"\tat Object.next (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:9346)",
"\tat p (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:8906)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)"
]
}
[error]: Field 'url' doesn't exist on type 'Note': {"response":{"errors":[{"message":"Field 'url' doesn't exist on type 'Note'","locations":[{"line":35,"column":5}],"path":["fragment noteDetails","url"],"extensions":{"code":"undefinedField","typeName":"Note","fieldName":"url"}}],"status":200,"headers":{}},"request":{"query":"\n \n \n \n \n fragment position on Note {\n position {\n diffRefs {\n baseSha\n headSha\n startSha\n }\n filePath\n positionType\n newLine\n oldLine\n newPath\n oldPath\n positionType\n }\n }\n\n fragment noteDetails on Note {\n id\n createdAt\n system\n author {\n avatarUrl\n name\n username\n webUrl\n }\n body\n bodyHtml\n url\n userPermissions {\n resolveNote\n adminNote\n createNote\n }\n ...position\n }\n\n fragment discussionDetails on Discussion {\n replyId\n createdAt\n resolved\n resolvable\n notes {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...noteDetails\n }\n }\n }\n\n fragment discussions on DiscussionConnection {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...discussionDetails\n }\n }\n\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\n project(fullPath: $projectPath) {\n id\n mergeRequest(iid: $iid) {\n discussions(after: $afterCursor) {\n ...discussions\n }\n }\n }\n }\n","variables":{"projectPath":"dev/ProjectName","iid":"730"}}}
Error: Field 'url' doesn't exist on type 'Note': {"response":{"errors":[{"message":"Field 'url' doesn't exist on type 'Note'","locations":[{"line":35,"column":5}],"path":["fragment noteDetails","url"],"extensions":{"code":"undefinedField","typeName":"Note","fieldName":"url"}}],"status":200,"headers":{}},"request":{"query":"\n \n \n \n \n fragment position on Note {\n position {\n diffRefs {\n baseSha\n headSha\n startSha\n }\n filePath\n positionType\n newLine\n oldLine\n newPath\n oldPath\n positionType\n }\n }\n\n fragment noteDetails on Note {\n id\n createdAt\n system\n author {\n avatarUrl\n name\n username\n webUrl\n }\n body\n bodyHtml\n url\n userPermissions {\n resolveNote\n adminNote\n createNote\n }\n ...position\n }\n\n fragment discussionDetails on Discussion {\n replyId\n createdAt\n resolved\n resolvable\n notes {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...noteDetails\n }\n }\n }\n\n fragment discussions on DiscussionConnection {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...discussionDetails\n }\n }\n\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\n project(fullPath: $projectPath) {\n id\n mergeRequest(iid: $iid) {\n discussions(after: $afterCursor) {\n ...discussions\n }\n }\n }\n }\n","variables":{"projectPath":"dev/ProjectName","iid":"730"}}}
at c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:15173
at o (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:10042)
at Object.next (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:9346)
at p (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:8906)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
[error]: {
"userMessage": "The extension failed to preload discussions on the MR diff.\n It's possible that you've encountered\n https://gitlab.com/gitlab-org/gitlab/-/issues/298827.",
"errorMessage": "Field 'url' doesn't exist on type 'Note': {\"response\":{\"errors\":[{\"message\":\"Field 'url' doesn't exist on type 'Note'\",\"locations\":[{\"line\":35,\"column\":5}],\"path\":[\"fragment noteDetails\",\"url\"],\"extensions\":{\"code\":\"undefinedField\",\"typeName\":\"Note\",\"fieldName\":\"url\"}}],\"status\":200,\"headers\":{}},\"request\":{\"query\":\"\\n \\n \\n \\n \\n fragment position on Note {\\n position {\\n diffRefs {\\n baseSha\\n headSha\\n startSha\\n }\\n filePath\\n positionType\\n newLine\\n oldLine\\n newPath\\n oldPath\\n positionType\\n }\\n }\\n\\n fragment noteDetails on Note {\\n id\\n createdAt\\n system\\n author {\\n avatarUrl\\n name\\n username\\n webUrl\\n }\\n body\\n bodyHtml\\n url\\n userPermissions {\\n resolveNote\\n adminNote\\n createNote\\n }\\n ...position\\n }\\n\\n fragment discussionDetails on Discussion {\\n replyId\\n createdAt\\n resolved\\n resolvable\\n notes {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...noteDetails\\n }\\n }\\n }\\n\\n fragment discussions on DiscussionConnection {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...discussionDetails\\n }\\n }\\n\\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\\n project(fullPath: $projectPath) {\\n id\\n mergeRequest(iid: $iid) {\\n discussions(after: $afterCursor) {\\n ...discussions\\n }\\n }\\n }\\n }\\n\",\"variables\":{\"projectPath\":\"dev/ProjectName\",\"iid\":\"729\"}}}",
"stack": [
"Error: Field 'url' doesn't exist on type 'Note': {\"response\":{\"errors\":[{\"message\":\"Field 'url' doesn't exist on type 'Note'\",\"locations\":[{\"line\":35,\"column\":5}],\"path\":[\"fragment noteDetails\",\"url\"],\"extensions\":{\"code\":\"undefinedField\",\"typeName\":\"Note\",\"fieldName\":\"url\"}}],\"status\":200,\"headers\":{}},\"request\":{\"query\":\"\\n \\n \\n \\n \\n fragment position on Note {\\n position {\\n diffRefs {\\n baseSha\\n headSha\\n startSha\\n }\\n filePath\\n positionType\\n newLine\\n oldLine\\n newPath\\n oldPath\\n positionType\\n }\\n }\\n\\n fragment noteDetails on Note {\\n id\\n createdAt\\n system\\n author {\\n avatarUrl\\n name\\n username\\n webUrl\\n }\\n body\\n bodyHtml\\n url\\n userPermissions {\\n resolveNote\\n adminNote\\n createNote\\n }\\n ...position\\n }\\n\\n fragment discussionDetails on Discussion {\\n replyId\\n createdAt\\n resolved\\n resolvable\\n notes {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...noteDetails\\n }\\n }\\n }\\n\\n fragment discussions on DiscussionConnection {\\n pageInfo {\\n hasNextPage\\n endCursor\\n }\\n nodes {\\n ...discussionDetails\\n }\\n }\\n\\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\\n project(fullPath: $projectPath) {\\n id\\n mergeRequest(iid: $iid) {\\n discussions(after: $afterCursor) {\\n ...discussions\\n }\\n }\\n }\\n }\\n\",\"variables\":{\"projectPath\":\"dev/ProjectName\",\"iid\":\"729\"}}}",
"\tat c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:15173",
"\tat o (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:10042)",
"\tat Object.next (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:9346)",
"\tat p (c:\\Users\\username\\.vscode\\extensions\\gitlab.gitlab-workflow-3.41.1\\out\\extension.js:31:8906)",
"\tat runMicrotasks (<anonymous>)",
"\tat processTicksAndRejections (internal/process/task_queues.js:93:5)"
]
}
[error]: Field 'url' doesn't exist on type 'Note': {"response":{"errors":[{"message":"Field 'url' doesn't exist on type 'Note'","locations":[{"line":35,"column":5}],"path":["fragment noteDetails","url"],"extensions":{"code":"undefinedField","typeName":"Note","fieldName":"url"}}],"status":200,"headers":{}},"request":{"query":"\n \n \n \n \n fragment position on Note {\n position {\n diffRefs {\n baseSha\n headSha\n startSha\n }\n filePath\n positionType\n newLine\n oldLine\n newPath\n oldPath\n positionType\n }\n }\n\n fragment noteDetails on Note {\n id\n createdAt\n system\n author {\n avatarUrl\n name\n username\n webUrl\n }\n body\n bodyHtml\n url\n userPermissions {\n resolveNote\n adminNote\n createNote\n }\n ...position\n }\n\n fragment discussionDetails on Discussion {\n replyId\n createdAt\n resolved\n resolvable\n notes {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...noteDetails\n }\n }\n }\n\n fragment discussions on DiscussionConnection {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...discussionDetails\n }\n }\n\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\n project(fullPath: $projectPath) {\n id\n mergeRequest(iid: $iid) {\n discussions(after: $afterCursor) {\n ...discussions\n }\n }\n }\n }\n","variables":{"projectPath":"dev/ProjectName","iid":"729"}}}
Error: Field 'url' doesn't exist on type 'Note': {"response":{"errors":[{"message":"Field 'url' doesn't exist on type 'Note'","locations":[{"line":35,"column":5}],"path":["fragment noteDetails","url"],"extensions":{"code":"undefinedField","typeName":"Note","fieldName":"url"}}],"status":200,"headers":{}},"request":{"query":"\n \n \n \n \n fragment position on Note {\n position {\n diffRefs {\n baseSha\n headSha\n startSha\n }\n filePath\n positionType\n newLine\n oldLine\n newPath\n oldPath\n positionType\n }\n }\n\n fragment noteDetails on Note {\n id\n createdAt\n system\n author {\n avatarUrl\n name\n username\n webUrl\n }\n body\n bodyHtml\n url\n userPermissions {\n resolveNote\n adminNote\n createNote\n }\n ...position\n }\n\n fragment discussionDetails on Discussion {\n replyId\n createdAt\n resolved\n resolvable\n notes {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...noteDetails\n }\n }\n }\n\n fragment discussions on DiscussionConnection {\n pageInfo {\n hasNextPage\n endCursor\n }\n nodes {\n ...discussionDetails\n }\n }\n\n query GetMrDiscussions($projectPath: ID!, $iid: String!, $afterCursor: String) {\n project(fullPath: $projectPath) {\n id\n mergeRequest(iid: $iid) {\n discussions(after: $afterCursor) {\n ...discussions\n }\n }\n }\n }\n","variables":{"projectPath":"dev/ProjectName","iid":"729"}}}
at c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:15173
at o (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:10042)
at Object.next (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:9346)
at p (c:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1\out\extension.js:31:8906)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
```
<!-- Logs can be found by running `GitLab: Show extension logs` command (using `cmd+shift+p`) -->
### Possible fixes
It seems that the extension failed to parse the project id correctly. I try to open `C:\Users\username\.vscode\extensions\gitlab.gitlab-workflow-3.41.1` and replace regex `\$\{\w+\.project_id\}` with my project id `438`, then I can see the pipeline result correctly, but the merge requests still can't be opened.
<!-- If you can, link to the line of code that might be responsible for the problem -->
| 1 |
5,261,717 | 103,967,604 |
2022-03-02 12:28:05.948
|
Fix /merge quick action by submitting head SHA with the new note
|
### Summary
The `/merge` quick action in any MR comment causes the API to fail. Original issue: https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/352
### Steps to reproduce
Try to send a comment on an open MR that contains the `/merge` quick action.
### What is the current _bug_ behavior?
GitLab API fails with 500 error.
### What is the expected _correct_ behavior?
The MR gets merged.
### Relevant logs and/or screenshots
<!-- Logs can be found by running `GitLab: Show extension logs` command (using `cmd+shift+p`) -->
### Possible fixes
We need to submit the `CreateNoteInput.mergeRequestDiffHeadSha` parameter to the GraphQL `createNote` mutation. This parameter should contain the MR HEAD SHA and it is used for optimistic locking.
Maybe we'll need to add a condition and only submit the parameter if the GitLab version is 14.9 or higher. I'm not 100% sure how GraphQL handles input parameters that are not defined (because the `mergeRequestDiffHeadSha` parameter won't be defined on older versions)
| 1 |
5,261,717 | 103,884,289 |
2022-03-01 10:51:05.632
|
POC - OAuth GitLab login in addition to token login
|
### Problem to solve
The current way of generating Personal Access token and adding it to the extension is relatively complicated and prone to errors. More information is in the original issue https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/221
### Proposal
In the proof of concept we would test the OAuth login locally:
1. Create an [instance-wide OAuth application](https://docs.gitlab.com/ee/integration/oauth_provider.html#instance-wide-applications) in the local GDK
1. Create a page that GitLab redirects to when user gives the OAuth permission
- Try localhost server triggered by the extension (this is how JetBrains GitHub plugin does it)
- If that doesn't work, we can try to use GitLab Pages (that's similar to how the VS Code GitHub extension does it)
1. Implement the OAuth flow in the extension
### Further details
This is going to be proof-of-concept with throwaway code. The output is going to be:
- POC code in the extension
- Documentation on how to set up the OAuth application in the GitLab instance.
- It would be good to think how could this OAuth flow be adjusted for alternative VS Code deployments (Gitpod or `vscode.dev`) but that might be out of scope for this quick spike.
### Links / references
| 2 |
5,261,717 | 101,152,837 |
2022-01-24 14:19:44.538
|
Reintroduce minimal GitLab version warning
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "feature" label:
- https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues?label_name%5B%5D=feature
and verify the issue you're about to submit isn't a duplicate.
--->
### Problem to solve
There are currently two version-related checks that could cut down on our triage/support time:
* [The README note](https://gitlab.com/gitlab-org/gitlab-vscode-extension#minimum-supported-version) - I have doubts that many people would install the extension, read this part of readme and double-check their GitLab instance version.
* [The Bug.md issue template](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/.gitlab/issue_templates/Bug.md) - From my experience maybe 20% of bug reports use that template, the rest is people clicking "New Issue" and describing their problem in the description.
* I sometimes follow up and ask the issue creator to double-check their version but not always
The checks that we have in place are (IMO) not successful at letting people know they are using an unsupported GitLab version (unless they use the two features specified in [feat: remove minimal version requirement in favour of per-feature checking](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/merge_requests/342)).
### Proposal
Reintroduce the minimal version check that we removed in https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/merge_requests/342
Set the minimum supported version to 13.0
### Further details
<!-- Include examples, use cases, benefits, goals, or any other details that will help us understand the problem better. -->
### Links / references
| 1 |
5,261,717 | 100,379,393 |
2022-01-10 17:33:00.840
|
No pipeline nor MR found for current branch
|
### Summary
I have been using the extension smoothly for many month but a few days ago it stopped properly linking the remote branch MRs and Pipelines. When I am on master/main it still works, but as soon as I switch to any other branch it stops showing the latest MR and pipeline status in the bottom bar. In the extension sidebar is stills shows the project merge requests though... I have uninstall and re-install, but this did not fix the issue.
### Steps to reproduce
See above
### Relevant logs and/or screenshots
Nothing particularly suspicious in the logs:
```
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
[info]: Found https://gitlab.com in the PAT list and git remotes, using it as the instanceUrl
```
| 1 |
5,261,717 | 98,682,076 |
2021-12-08 16:32:01.060
|
Validate personal access token right after the user added it
|
### Problem to solve
Users can add a personal access token that is invalid or expired, or they make a typo when entering the instance URL.
The extension will save this potentially incorrect pair (instance URL, token) and the user will find about the invalid token later when they try to use some of the extension functionality
### Proposal
Validate the token instantly after the user adds it. We can do that by calling `instanceUrl/api/v4/version` API endpoint.
### Further details
Thanks @pslaughter for suggesting this ~"type::feature"
### Links / references
| 1 |
5,261,717 | 98,158,818 |
2021-11-30 09:19:39.223
|
Remote repositories not showing all files
|
### Checklist
<!-- Please test the latest versions, that will remove the possibility that you see a bug that is fixed in a newer version. -->
- [x] I'm using the latest version of the extension ([see the latest version in the right column of this page](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow))
- Extension version: 3.38.1
- [x] I'm using the latest VS Code version ([find the latest version here](https://github.com/microsoft/vscode/releases))
- VS Code version: Latest insiders
- [x] I'm using a supported version of GitLab ([see README for the supported version](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/README.md#minimum-supported-version))
- GitLab version: happens on `gitlab.com`
### Summary
The extension loads a maximum of 20 files in the folder, if the folder has got more files/folders than that, the remote repository won't show them.
| local repository | remote repository |
| ------ | ------ |
|  |  |
### Steps to reproduce
Open https://gitlab.com/gitlab-org/gitlab-vscode-extension as a remote repository, then open the `src/` folder.
### What is the current *bug* behavior?
The `src` folder has only 20 files.
### What is the expected *correct* behavior?
The `src` folder shows all the files
### Possible fixes
We need to make sure we load all pages if the REST API result is paginated
| 1 |
5,261,717 | 97,260,473 |
2021-11-12 19:20:44.596
|
Feature Request: Pipeline view does not show stages containing manually triggered jobs
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "feature" label:
- https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues?label_name%5B%5D=feature
and verify the issue you're about to submit isn't a duplicate.
---> There is no issue with a "feature" label as of submission time
### Problem to solve
As a developer using this feature to monitor pipelines for the projects I work on, some of the pipelines contain stages containing [manual jobs](https://docs.gitlab.com/ee/ci/jobs/job_control.html#create-a-job-that-must-be-run-manually). In the pipeline view for the extension, I do not see these stages nor can I manually trigger any of these jobs despite the stage containing these manual jobs also containing non-manual jobs. Being able to view and trigger these jobs would allow for me to do more pipeline management from within VS code without having to use the web API.
### Proposal
Extend the pipeline view to include viewing manual jobs and the ability to trigger them.
### Further details
### Links / references
| 2 |
5,261,717 | 96,370,440 |
2021-10-29 04:45:32.256
|
Extension ignores expired token and fails in the wrong place
|
Original title: (*Open Active File on GitLab fails with Cannot read property 'webUrl' of null*)
### Checklist
- [x] I'm using the latest version of the extension 3.34.0 ([see the latest version in the right column of this page](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow))
- Extension version: *Put your extension version here*
- [x] I'm using the latest VS Code version ([find the latest version here](https://github.com/microsoft/vscode/releases))
- VS Code version:
Version: 1.61.2
Commit: 6cba118ac49a1b88332f312a8f67186f7f3c1643
Date: 2021-10-19T15:49:28.381Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0
- [x] I'm using a supported version of GitLab ([see README for the supported version](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/README.md#minimum-supported-version))
- GitLab version: 14.4.0-ee
### Summary
When I use the "Open Active File on GitLab" fails with Cannot read property 'webUrl' of null
### Steps to reproduce
Use an expired token to set up the extension.
Open any file and execute the "Open Active File on GitLab" command.
### What is the current *bug* behavior?
Nothing happens. No error, no browser window opened.
Before I updated it used to give this error:
```
Cannot read property 'webUrl' of null
TypeError: Cannot read property 'webUrl' of null
at getActiveFile (/Users/myusername/.vscode/extensions/gitlab.gitlab-workflow-3.33.0/out/src/openers.js:91:39)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async openActiveFile (/Users/myusername/.vscode/extensions/gitlab.gitlab-workflow-3.33.0/out/src/openers.js:103:33)
at async /Users/myusername/.vscode/extensions/gitlab.gitlab-workflow-3.33.0/out/src/extension.js:36:9
at async _executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:110871)
```
### What is the expected *correct* behavior?
It should open a browser window with the file I selected.
### Relevant logs and/or screenshots
It looks like my logs are empty.
| 1 |
5,261,717 | 96,137,280 |
2021-10-26 07:16:33.326
|
Validate that instance URL starts with protocol
|
### Problem to solve
Currently, users can add GitLab instance URLs that do not start with the protocol. This can happen in both the `gitlab.instanceUrl` setting and the instance URL specified when adding token.
This sometimes makes extension setup more confusing (e.g. #481).
### Proposal
When the user adds a token, validate that the instance URL starts with a protocol (either `http://` or `https://`).
When the extension notices a `gitlab.instanceUrl` setting, it warns user if the setting doesn't start with a protocol.
### Further details
This would work well with https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/515
### Links / references
| 1 |
5,261,717 | 95,823,326 |
2021-10-20 20:52:38.144
|
request: support vscode browser based extension (vscode.dev)
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "feature" label:
- https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues?label_name%5B%5D=feature
and verify the issue you're about to submit isn't a duplicate.
--->
### Problem to solve
<!-- What problem do we solve? Try to define the who/what/why of the opportunity as a user story. For example, "As a (who), I want (what), so I can (why/value)." -->
As a developer I want to open my web browser to https://vscode.dev/gitlab.mycorp.com/mygroup/myproject/-/merge_requests/3 and to be able to see the code/MR, so I can use vscode just by clicking a link
### Proposal
<!-- How are we going to solve the problem? -->
potentially make the extension support web extensions, at least partially
https://code.visualstudio.com/api/extension-guides/web-extensions#update-existing-extensions-to-web-extensions
### Further details
<!-- Include examples, use cases, benefits, goals, or any other details that will help us understand the problem better. -->
If I have a lot of projects and merge requests get created, I'd rather be able to click a link to open an editor than open the editor, clone the repo, etc
[remote-fs-url-format.md](docs/user/remote-fs-url-format.md) is cool, but can't seem to open up a merge request or use the plugin from that view
`code --folder-uri 'gitlab-remote://gitlab.mycorp.com/myproject?project=35595&ref=master'`
### Links / references
| 2 |
5,261,717 | 95,722,138 |
2021-10-19 20:29:04.103
|
Pipeline status term mismatch: Succeeded
|
## :speech_balloon: Term mismatch
The VSCode extension uses the term **Succeeded** for pipelines and jobs that finished without errors or warnings (green check mark) in the sidebar. The extension also uses **Passed** for pipelines in the bottom status bar. Meanwhile, the GitLab platform just uses the term **Passed** (except for [MWPS](https://docs.gitlab.com/ee/user/project/merge_requests/merge_when_pipeline_succeeds.html#merge-when-pipeline-succeeds)).
| Current (extension) | [Reference](https://gitlab.com/KevSlashNull/empty-brackets-in-extension/-/pipelines/391382511) (in GitLab) | Expected (extension) |
| --- | --- | --- |
|  |  |  |
| Status bar term |
| --- |
|  |
## :bulb: Proposal
Use the term **Passed** in the extension to be consistent with the UI text in the GitLab platform.
| 1 |
5,261,717 | 95,016,920 |
2021-10-07 08:24:27.920
|
flaky test: Pipeline actions - creates new pipeline
|
The test failed on master https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/jobs/1657306279, rerun fixed the pipeline.
Failed assertion: https://gitlab.com/gitlab-org/gitlab-vscode-extension/blob/400425fb1819824b3455f8fce3c1ccb96f6bbe68/test/integration/pipeline_actions.test.js#L51
I assume that the new refreshing logic introduced in #60 refreshes more than once and the `calledOnce` assumption fails.
| 1 |
5,261,717 | 92,911,576 |
2021-09-01 07:22:25.832
|
Helping users set the correct remote name
|
### Problem to solve
Currently, when user has got multiple remotes in the same repository (e.g. `origin` and `upstream`) the GitLab Workflow extension silently selects the (alphabetically) first one (`origin` in this example).
Users can select remote to be used by setting the `gitlab.remoteName` (https://gitlab.com/gitlab-org/gitlab-vscode-extension#extension-settings). But that is not obvious to the user.
### Proposal
When we detect multiple remotes in the repository, we'll ask user which one they want to use and store it into the workspace settings (`gitlab.remoteName`)
### Further details
<!-- Include examples, use cases, benefits, goals, or any other details that will help us understand the problem better. -->
### Links / references
- more context https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/433#note_662047082
| 2 |
5,261,717 | 92,803,258 |
2021-08-30 14:31:02.178
|
Can't access Issue detail from self-hosted gitlab (`Cannot read property 'full' of undefined`)
|
### Checklist
- [X] I'm using the latest version of the extension
- Extension version: *v3.29.1*
- [X] I'm using the latest VS Code version
- VS Code version: *1.51.1*
- [X] I'm using a supported version of GitLab
- GitLab version: *14.2.1*
### Summary
I can see the list of issues associated with the current branch 
But when I click on one of those issue they just display "Fetching issuable details and discussions. This may take a while."
This bug is similar to (#297) but the error message is different.
### Steps to reproduce
- open VS Code
- go to the GitLab Workflow tab
- click on on of the issues associated with the current branch
### What is the current *bug* behavior?
It opens a tab with only "Fetching issuable details and discussions. This may take a while."
### What is the expected *correct* behavior?
To see the same thing that if I access the issue through "Issues created by me"
### Relevant logs and/or screenshots
The logs gives:
```
Cannot read property 'full' of undefined
TypeError: Cannot read property 'full' of undefined
at getProjectPath (/home/pouxa/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/gitlab/gitlab_new_service.js:67:58)
at GitLabNewService.getDiscussions (/home/pouxa/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/gitlab/gitlab_new_service.js:235:29)
at GitLabNewService.getDiscussionsAndLabelEvents (/home/pouxa/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/gitlab/gitlab_new_service.js:290:18)
at initPanelIfActive (/home/pouxa/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/webview_controller.js:32:57)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async WebviewController.create (/home/pouxa/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/webview_controller.js:143:9)
at async WebviewController.open (/home/pouxa/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/webview_controller.js:130:26)
at async /home/pouxa/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/extension.js:35:9
at async _executeContributedCommand (/opt/visual-studio-code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:85:109243)
at async _executeContributedCommand (/opt/visual-studio-code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:85:109243)
```
| 1 |
5,261,717 | 92,518,812 |
2021-08-24 17:29:35.766
|
Optimize packaged extension
|
[esbuild](https://github.com/evanw/esbuild) is an extremely fast JavaScript/TypeScript bundler. On my (admittedly powerful) PC, esbuild can bundle (and minify) this extension in ~40ms.
The main advantage is a reduction in the number and size of files loaded by VSCode. Currently, the packaged extension contains ~3500 files:
* `node_modules/` - ~2900 files
* `out/` - ~400 files
* `src/` - ~200 files - **these should be added to .vscodeignore**, since source files are not needed at runtime
* Miscellaneous other - 25 files
Using esbuild can reduce the total file count to ~30 by bundling each entry point into a single file, thus eliminating `node_modules` and `out`. AFAIK, there are two entry points: main and webview.
Removing `src` reduces the extension size by 2.2MB. Bundling the main entry point and eliminating `node_modules` and `out` reduces the extension size by 9MB. This is size of the files, after unpacking the extension from the .vsix/ZIP. This does not include the webview, because I'm not sure how to use esbuild with Vue.
I am interested in submitting an MR.
| 2 |
5,261,717 | 92,093,995 |
2021-08-17 08:50:09.893
|
Spike: Debug custom SSL Certificate issues
|
### Summary
The extension has issues connecting to instances that use a self-signed SSL certificate (not signed by a root authority included in `node`) (Epic: https://gitlab.com/groups/gitlab-org/-/epics/6244). The goal of this spike is to create a local environment where the server uses self-signed certificate. In this environment, we are going to test setting up the `gitlab.ca`, `gitlab.cert`, `gitlab.certKey`, and `gitlab.ingnoreCertificateErrors`.
### Output of this spike:
1. Documentation about the current support of self-signed certificates in the README - this will help users to set up their extension. If the extension doesn't support self-signed certificates, we'll document that.
1. Triage of existing issues in https://gitlab.com/groups/gitlab-org/-/epics/6244
1. If `cross-fetch` (our library for making HTTPS requests) doesn't support self-signed SSL, this spike will document possible alternatives
| 2 |
5,261,717 | 90,519,846 |
2021-07-19 20:01:53.257
|
Markdown renderer in Gitlab Workflow VSCode extension allows arbitrary HTML attributes on whitelisted elements
|
**[HackerOne report #1261073](https://hackerone.com/reports/1261073)** by `arw9234` on 2021-07-14, assigned to GitLab Team:
[Report](#report) | [Attachments](#attachments) | [How To Reproduce](#how-to-reproduce)
## Report
##### Summary
I'm not sure whether something like this would be accepted without a larger impact, but I figured I should report it nonetheless.
The Gitlab VSCode extension renders gitlab flavored markdown in a few places, mostly just in issues and merge requests. When doing so, it sends the markdown to be rendered to the connected Gitlab instance where it is processed server-side. However, the extension then [mutates the resulting HTML with regexes](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/src/webview_controller.ts#L104) before incorporating it into the document using the following function:
```ts
private createMessageHandler = (
panel: vscode.WebviewPanel,
issuable: RestIssuable,
repositoryRoot: string,
) => async (message: any) => {
const instanceUrl = await getInstanceUrl(repositoryRoot);
if (message.command === 'renderMarkdown') {
let rendered = await gitLabService.renderMarkdown(message.markdown, repositoryRoot); // <--- clean HTML from server
rendered = (rendered || '')
.replace(/ src=".*" alt/gim, ' alt') // <--- dangerous alteration of HTML with regexes
.replace(/" data-src/gim, '" src')
.replace(/ href="\//gim, ` href="${instanceUrl}/`);
// ...
}
```
The above code attempts to remove/alter specific attributes within the resulting HTML. In particular, the `/ src=".*" alt/gim` regex tries to remove `src` attributes followed by an `alt` attribute, but could be made to break out of quoted attributes or change the nesting order of elements. For example, the following HTML:
```html
<div color=" src=" title="" alt=" someattr='somevalue'"></div>
```
Will pass through Gitlab's markdown renderer relatively unchanged (`color`, `title`, and `alt` are [whitelisted on all elements](https://github.com/gjtorikian/html-pipeline/blob/v2.12.3/lib/html/pipeline/sanitization_filter.rb#L59), and `<div>` is a whitelisted element), but the ` src=" title="" alt` sequence would then be matched and replaced by ` alt` with the above regex, resulting in:
```html
<div color=" alt=" someattr="somevalue" "=""></div>
```
Where the `someattr` attribute has broken out of the `alt` attribute and became part of the DOM. This allows for arbitrary HTML attributes to be added to any element whitelisted by the sanitization filter.
This is limited, however, in that the affected frame is [using a nonce-based CSP](https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/src/webview/public/index.html#L5) that restricts inline event handlers and `javascript:` URIs. If it were possible to inject arbitrary HTML elements as well, it could be possible to inject `<iframe>`/,`<object>` tags since the `object-src` directive is missing from the CSP. This would most likely require gitlab's GFM renderer to emit unescaped angle bracket characters in a quoted attribute, which it does not seem very keen on doing, but I will keep looking into it.
##### Steps to reproduce
You can reproduce this yourself as follows:
1. [Install Visual Studio Code](https://code.visualstudio.com/download) and the [Gitlab Workflow extension](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow)
2. Create a personal access token and add it to the extension to link it to your gitlab account. Instructions can be found [here](https://marketplace.visualstudio.com/items?itemName=GitLab.gitlab-workflow#setup)
3. In a new or existing project, create an issue with the following markdown in the description:
```html
<div color=" src=" title="" alt=" style='display: block; position: absolute; width: 100vw; height: 100vh; left: 0; top: 0; z-index: 999999; background-color: black;' onmouseover='throw /this will raise a CSP violation/'">
<h1>arbitrary style attr injected</h1>
</div>
```
4. Assign the issue to the same user whose access token you used to set up the extension
5. Clone the repository locally in vscode
6. If prompted, grant trust to the repository - vscode disables all extensions if you deny trust to the repo
7. Click the gitlab icon in the left-hand menu
8. On the left-hand side, expand `ISSUES AND MERGE REQUESTS > Issues assigned to me`
9. Open the newly created issue
10. The editor window will be filled with a black menu with the text 'arbitrary style attr injected', indicating the `style` attribute was injected into the DOM. You can also open `Help > Toggle Developer Tools` to see the source code for the page and to see CSP violations printed to the console
##### Impact
An attacker can submit a malicious issue/merge request to a project that could contain arbitrary HTML attributes on whitelisted elements when opened in vscode. The impact of this is limited with inline event handlers blocked by the CSP, but this could still allow restyling of the page, injecting hrefs with arbitrary protocols on anchor elements (`javascript:` uris obviously won't be executed, but other protocols could be used, such as custom protocols registered by other applications), and injecting other potentially dangerous attributes.
##### Examples
See the attached OVA.
##### What is the current *bug* behavior?
The markdown renderer in the GitLab Workflow VSCode extension uses a poorly designed regex to alter attributes on HTML elements which can be induced to change the structure of the HTML returned from the server.
##### What is the expected *correct* behavior?
The markdown renderer should either:
- not change the HTML returned from the server, or
- parse the HTML and update the relevant attributes using `setAttribute(...)`/`removeAttribute(...)`/similar before inserting it into the DOM
so that the structure of the document is not changed
##### Relevant logs and/or screenshots
Below is a screenshot of what the window should look like after opening the issue:
Below is a screenshot showing the CSP violations printed to the console due to the `onmouseover` handler:
##### Output of checks
Not applicable to GitLab.com
###### Results of GitLab environment info
N/A
Best regards,
[@]arw9234
#### Impact
An attacker can submit a malicious issue/merge request to a project that could contain arbitrary HTML attributes on whitelisted elements when opened in vscode, allowing for restyling of the page, injecting hrefs with arbitrary protocols on anchor elements, and injecting other potentially dangerous attributes. A CSP bypass or ability to inject `<object>` tags could potentially increase impact.
## Attachments
**Warning:** Attachments received through HackerOne, please exercise caution!
* [VSCode_Extension_Attr_Injection_2.png](https://h1.sec.gitlab.net/a/efea9d95-9bee-47d6-bef5-e6552bc64a39/VSCode_Extension_Attr_Injection_2.png)
* [VSCode_Extension_Attr_Injection_1.png](https://h1.sec.gitlab.net/a/f4a66084-5a26-4967-8048-7b2043d49d7d/VSCode_Extension_Attr_Injection_1.png)
## How To Reproduce
Please add [reproducibility information] to this section:
1.
1.
1.
[reproducibility information]: https://about.gitlab.com/handbook/engineering/security/#reproducibility-on-security-issues
| 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.