idproject
int64
7.76k
28.8M
issuekey
int64
675k
128M
created
stringlengths
19
32
title
stringlengths
4
226
description
stringlengths
2
154k
storypoints
float64
0
300
4,456,656
95,823,882
2021-10-20 21:08:59.181
Figma > Update Figma for GitLab guide
With Figma updates and new features and workflows to leverage, it's time to update the [**Figma for GitLab**](https://www.figma.com/file/73OcYdBfOaK2xlChC3tbNX/Figma-for-GitLab?node-id=0%3A1) deck. [View the WIP branch →](url)
2
4,456,656
95,815,719
2021-10-20 17:49:21.832
Update Figma issue template
This is related to the effort in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1130, and ensuring that the issue template also contains accurate, up-to-date information about Figma and our process.
1
4,456,656
95,803,680
2021-10-20 14:43:53.580
Update contribution resources to account for Objects
Update contributor guidelines, MR templates, component lifecycle, and others… 1. [x] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2726 and https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2744 — Update [MR template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md) to be generic for any kind of documentation update, including objects, and update its links. 1. [x] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2727 — Expand on [object overview](https://design.gitlab.com/objects/overview) page, moving generic content out from the individual object pages. 1. [x] [Figma branch (merged)](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/branch/5tlA0Ov1H7coIxFqihWytc/Conceptual-model?node-id=5823%3A553) — Add example page and legend to conceptual model file with stickies explaining components (object and lines). Add legend component to each object page in Figma. 1. [x] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2769 — Embed [conceptual model example page](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/?node-id=5823%3A553) in the [objects overview page](https://design.gitlab.com/objects/overview/).
1
4,456,656
95,803,660
2021-10-20 14:43:23.983
Review and polish Figma conceptual model file for Objects
[🖼 Main Figma file](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/Conceptual-model) - [x] Convert file cover to standard Pajamas cover - [x] Add objects “folder” page - [x] Add icons to help identify pages - [x] Add Pajamas link at the top of each published object - [x] [Create variants for object and line components](https://www.figma.com/file/J68bePHXIN5OPWqaFFY9ri/branch/qCgSr8rBqgrm0TCTuwCo4T/Conceptual-model)
2
4,456,656
95,367,381
2021-10-13 14:55:21.703
Breadcrumb > Update example to use the GitLab UI story
Use the GitLab UI story as the SSoT for the embedded example.
1
4,456,656
95,286,769
2021-10-12 14:04:31.834
Badge > Update accessibility guides
## Purpose I created a quick Codepen test https://codepen.io/lostsatellites/pen/WNEezQd to validate how a badge is announced in context. Because it's a piece of metadata it likely won't make sense on its own, so these additional considerations take that into account.
1
4,456,656
95,123,649
2021-10-08 17:15:30.673
Add skip link to Pajamas site
## Purpose The Pajamas website doesn't have a skip link to jump keyboard users to the main content area. This adds one so that as the first focusable item a keyboard user can have focus moved to `main`. This will also aid in being able to access in-page rendered examples quicker instead of tabbing through all of the navigation. The pattern outlined in https://css-tricks.com/a-deep-dive-on-skipping-to-content/ will be the starting point.
1
4,456,656
95,106,896
2021-10-08 12:16:48.525
Create an Object issue template
## 🧩 Problem We've started documenting objects in Pajamas (see the [MR object](https://design.gitlab.com/objects/merge-request)). Currently we don't have any contribution guidelines for documenting objects. For someone unfamiliar with the purpose and process of object modeling it can be intimidating and difficult to get started. The conceptual object model becomes more useful as more objects and layouts are documented since it helps communicate the relationships between different objects. The more objects and layouts we document (even if the model is imperfect at first), the more we'll be able to use it. For example, it can help identify important object relationships and ensure we don't overlook them in our design work. ## 💡 Proposal We don't need to create a perfect set of guidelines and templates to start benefiting from the documented model. The objective is to create an MVC set of guidelines and resources to get more product designers interested in contributing. This issue will focus on adding an Object issue template to guide designers as they document the conceptual model and the layouts for the object.
2
4,456,656
94,525,527
2021-09-29 10:36:14.286
Date picker - make month/year look more interactive
# Problem - The date picker has a dropdown for the month and year and nobody knows about it! - Related to #601. From this thread: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/601#note_689319507 # Proposal - Use a similar pattern to the sidebar - with a tertiary button that goes to `gray-50` on-hover to show interaction... ![Screenshot_2021-09-29_at_18.09.](/uploads/2b519167e5160104db6465cb57a7268f/Screenshot_2021-09-29_at_18.09..gif) # Other ideas ![Screenshot_2021-09-29_at_11.57._2x](/uploads/597d379e81300df7b0db0159f688a232/Screenshot_2021-09-29_at_11.57._2x.png)
1
4,456,656
94,403,493
2021-09-27 19:34:29.155
Triage Build job failure
## Purpose I've noticed that the **Build** job is failing for pipelines in the Pajamas project. This issue is to determine a fix.
1
4,456,656
94,391,827
2021-09-27 15:44:40.016
UI Kit > Migrate Drawer component from Sketch to Figma
<!-- Start by choosing one of the following based on the nature of your contribution: - For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file. - For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design. - For community contributions, create a new file in your drafts. To move a duplicate file: Open the duplicate, then use the dropdown next to the file name to select “Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.” --> ### Description <!-- Add a short description of your contribution. Consider adding a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. --> In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/376#note_683270630 it was identified that the Drawer component design specs exist in Sketch, but need to be added as a component in Figma. ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. --> [View working file in Figma →](https://www.figma.com/file/5etp1G6sZS5O57yXQ4mxeY/Migrate-Drawer-component-from-Sketch-to-Figma?node-id=1%3A70) ### Checklist Make sure the following are completed before closing the issue: 1. [x] **Assignee**: Design in your working file. When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. 1. [x] **Assignee**: Update the link to the working file in the issue description. 1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). 1. [x] **Reviewer**: Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] **Maintainer**: Review and approve assignee’s changes. 1. [x] **Maintainer**: Add the changes or additions to the target file. For example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] **Maintainer**: When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] **Assignee**: Move your working file to the shared Figma project: 1. [x] For Component Library changes, move your file to the [**Component archive**][component-archive] project. 1. [-] For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. [-] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. 1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [-] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. 1. [-] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. 1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation [new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
2
4,456,656
94,158,909
2021-09-23 03:54:01.459
Follow-up from "feat(Drawer): Update content to utilize new template"
The following discussion from !2546 should be addressed: - [x] @tauriedavis started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2546#note_684885183): (+1 comment) > - If supplemental content isn't suited for small areas or is part of a flow, consider loading a new page, revealing content with an [accordion](/components/accordion), or using a [modal](/components/modal) instead. > >> I'm hesitant to add modal here as an option for when supplemental content isn't suited for small areas. I wonder if there is additional info to add here about where a modal should be used in place of a drawer (such as the line below this one).
1
4,456,656
93,885,645
2021-09-17 20:36:40.957
Update Pajamas UI Kit contribution guidelines
## Purpose As new features have been released in Figma, so too we've started using them and changed up a few workflows. The [**Pajamas UI Kit contribution and updating guidelines**](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components) document could use a thorough review along with updates. /cc @mle @lvanc @nadia_sotnikova @cam.x @tauriedavis
2
4,456,656
93,667,422
2021-09-14 19:01:09.978
Pajamas UI Kit > Text input add-on component variable
## Purpose Recently the [text input base](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=43905%3A45856) was updated to include prefix and suffix options while the add-ons remained unchanged. This issue addresses making the add-ons easier to change and update in a similar way. ![CleanShot_2021-09-14_at_13.40.09_2x](/uploads/42ee6804da0c816a098adda02d456ca1/CleanShot_2021-09-14_at_13.40.09_2x.png) ## Scope Create a branch of the component library **❖ _Base Add-on** component with the following variants: - Character count - Clear button ([clear](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~clear) icon) to clear entered content - Show button ([eye](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~eye) icon) for password visibility - Hide button ([eye-slash](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~eye-slash)) for obscuring password - Calendar button ([calendar](https://gitlab-org.gitlab.io/gitlab-svgs/?q=~calendar) icon) for date picker The character count can be present with the buttons, but only one button can be visible at a time. **Additional changes:** - The add-ons in the **❖ _Base Field** component will be replaced with the **❖ _Base Add-on** component. - Currently the add-ons are set to true/false for the **Text input** component and will need to be changed to a dropdown to choose the type of add-on. The **Text area** component can remain as true/false as long as the character count is the only option. - All component variants will need to be updated to look the same as they do today, only they will have the correct add-on chosen by default. This applies to everything in **Forms**, as well as **Datepicker** and **Dropdown**. ### Design file Figma: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/5BKoo354GwPXInx3EsPDFa/Component-library?node-id=425%3A10 `1120-working-branch-veethikaa`
3
4,456,656
93,648,529
2021-09-14 14:32:11.383
Component template: Component structure image
This issue is to discuss adding multiple structure images and what state the component should be in for the structure image. Based on https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2520#note_671632056. Two main questions: 1. What state of the component should be the structure image? For example: | Beginning | All possible elements (Base component) | | ------ | ------ | | ![Screen_Shot_2021-09-14_at_10.35.12_AM](/uploads/5440df806d6010c37e7b7c6e7976faa7/Screen_Shot_2021-09-14_at_10.35.12_AM.png) | ![Screen_Shot_2021-09-14_at_10.35.18_AM](/uploads/b6745b7566efb4ffa2cd2548ee6d173d/Screen_Shot_2021-09-14_at_10.35.18_AM.png) | Which should be the structure image? My assumption is to use the base component so we can describe each possible visible element. 2. Should we include multiple structure images if there are different variants? For example: | Single file uploader | Multi file uploader | | ------ | ------ | | ![Screen_Shot_2021-09-14_at_10.35.18_AM](/uploads/9e2089c97144d8f97abcf4d75babf39d/Screen_Shot_2021-09-14_at_10.35.18_AM.png) | ![Screen_Shot_2021-09-14_at_10.37.34_AM](/uploads/1d2c201ce6b8bbadb557d5ec17d76a97/Screen_Shot_2021-09-14_at_10.37.34_AM.png) | Again, my assumption is we include both, with unique lists for each. Thoughts?
1
4,456,656
93,328,872
2021-09-08 13:06:31.718
Frontmatter description doesn't render unless there are tabs
Currently, we are rendering `description:` at the top of the page, but **only** if the pages contains tabs. This description should always render, regardless of whether there are tabs or not. A lot of pages don't contain tabs, so we'll never be able to utilize the `description:` unless there is a vueComponent associated with that component. For example, we are creating an overview page that utilizes the `description:` item: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1105. We are also updating the docs pages to utilize a new doc template, which utilizes the `description:` item, so if the components without a Vue component get updated to the new template, those updates will be blocked until this is resolved.
2
4,456,656
93,192,659
2021-09-06 13:21:58.605
Pajamas UI Kit > Update top nav Figma component
<!-- Start by choosing one of the following based on the nature of your contribution: - For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file. - For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design. - For community contributions, create a new file in your drafts. To move a duplicate file: Open the duplicate, then use the dropdown next to the file name to select “Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.” --> ### Description <!-- Add a short description of your contribution. Consider adding a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. --> ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. --> [View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/PVS2W2D3IioRPYvwdGmlvb/Component-library?node-id=7580%3A42) `update-consolidated-top-nav` ### Screenshots Variants | Before | After | | ------ | ------ | | ![image](/uploads/a2738a09139da89e5dfb5ce2cf8ffce1/image.png) | ![image](/uploads/e9021003b00b8126befa25ecb22406f0/image.png) | Project menu | Before | After | | ------ | ------ | | ![image](/uploads/030f4016545153634918e672594d63c6/image.png) | ![image](/uploads/3d54c313974e08fb9c699c0d07aae6a3/image.png) | ### Checklist Make sure the following are completed before closing the issue: 1. [x] **Assignee**: Design in your working file. When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. 1. [x] **Assignee**: Update the link to the working file in the issue description. 1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). 1. [x] **Reviewer**: Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] **Maintainer**: Review and approve assignee’s changes. 1. [x] **Maintainer**: Add the changes or additions to the target file. For example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] **Maintainer**: When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] **Assignee**: Move your working file to the shared Figma project: 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. 1. [x] **Assignee** (or Maintainer, for community contributions): If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [x] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. 1. [ ] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. 1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation [new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
3
4,456,656
92,292,719
2021-08-19 19:30:37.860
Avatar > Reverse stack order
## Problem The current stacked order of avatars places the last item at the very bottom. Since this can be an interactive badge I think the order should be reversed. Also, the stacking order infers who was added when. If someone was added later, it makes sense that their avatar is set on top of the one before. ## Solution Continue to order the avatars from left to right, but as they're ordered from left to right, they should stack from bottom to top. This allows the badge (if present) to be the most visible item and have the largest click target when interactive. When DOM order and z-index is considered I believe this is a more natural presentation too. | **Before** | **After** | | ------ | ------ | | ![image](/uploads/e60fd6ae73743e07cb44ce1cba703e73/image.png) | ![image](/uploads/ef0058de0952bbb0b830ae674ce611f5/image.png) | [View proposal in Figma →](https://www.figma.com/file/hO6UAuOrF5Ca8ltX4rZUb9/Avatar-stack-order?node-id=2%3A844) (Note: this was a separate file and not a branch because it's only changing instances and not a component or styles.)
1
4,456,656
92,063,977
2021-08-16 19:17:26.917
Focus ring: Explore increasing contrast
## Purpose As a result of the audit in the parent epic, the focus ring visual styles should be reviewed to consider the following: - Increase focus ring contrast to at least 3:1 (currently 1.97:1). - While I believe that there is no current failure because for [SC 2.4.7](https://www.w3.org/TR/WCAG21/#focus-visible) there is a visible focus ring, and for [SC 1.4.11](https://www.w3.org/TR/WCAG21/#non-text-contrast) the button text and/or icon has sufficient contrast, there are potential updates per the [WCAG 2.2 Working Draft](https://www.w3.org/TR/WCAG22/) that we could aim to satisfy now. - [Success Criterion 2.4.11 Focus Appearance (Minimum)](https://www.w3.org/TR/WCAG22/#focus-appearance-minimum) **Watch recordings of the audit** (internal) [▶︎ Visual scan](https://drive.google.com/file/d/1qCB9-KfC1p-D7ao0QiwzQQMehERZZvUS/view?usp=sharing) **Current contrast:** ![CleanShot_2021-08-16_at_14.45.10_2x](/uploads/97f299ffbc64bbb4b225e4d52978abfd/CleanShot_2021-08-16_at_14.45.10_2x.png) (Contrast with opacity checked with [contrast-ratio.com](https://contrast-ratio.com/#rgb%2831%20117%20203%20%2F%2048%25%29-on-white). ## Resources - https://www.sarasoueidan.com/blog/focus-indicators/ - https://www.w3.org/WAI/WCAG22/Understanding/focus-appearance-minimum.html
2
4,456,656
91,809,050
2021-08-11 12:09:41.126
Elevate contribution to a tab
How can we increase and invite contribution to Pajamas in a "boring solution" kind of way? Inspired by the **Discussion** tab in https://designsystem.gov.au/components/buttons/discussion/ (thanks @mle for tweeting about this site, it's awesome) I'm exploring a **Contribute** tab. What would go in there? - A bit of a text preamble with a link to the **Getting started > Contribute** page. - We already have links in the footer to related issues and merge requests. It'd be worth repeating here when either are available. - Occasional links to research efforts, polls, questionnaires, hackathons, etc. It'd be great to have some passive, evergreen items like that where someone could provide feedback. What does this solve? - Reenforcing that "everyone can contribute," while creating more visibility on how. - What I especially liked about the Australian Government Design System example is how I felt invited into the conversation. It wasn't just one-way information. It also felt very transparent to reference discussion happening behind the scenes that you might normally not be privy to. ![CleanShot_2021-08-11_at_06.58.24_2x](/uploads/37a795f289176828260a08d1747814db/CleanShot_2021-08-11_at_06.58.24_2x.png)
2
4,456,656
91,748,971
2021-08-10 13:29:02.265
feat(markdown): Underline links in body content
## Purpose At the moment, links in the markdown content are not underlined and have low contrast next to static text. This makes it more difficult to discern a link from surrounding text. ## Solution A boring solution is simply to leverage the default `text-decoration: underline` for links within markdown. This is also proposed as an update to markdown in GitLab UI https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1084, but this solution covers the gap until that is updated and Pajamas is using the markdown styles in documentation.
1
4,456,656
91,501,194
2021-08-05 13:01:45.577
Pajamas > Add Google Analytics
## Purpose It'd be great to have a high-level understanding of most accessed content in Pajamas and the path users take to get there. ## Solution In https://gitlab.com/gitlab-com/marketing/inbound-marketing/seo/-/issues/129 we were given the ability to add Google Analytics to Pajamas.
3
4,456,656
91,275,541
2021-08-02 13:27:31.147
FY22-Q3 KR3: Illustrate empty states for Access Tokens and Admin/Applications using new styles and assets
Use the new style library and assets to create illustrations for the following empty states: - [x] https://gitlab.com/gitlab-org/gitlab-svgs/-/issues/196 - [x] https://gitlab.com/gitlab-org/gitlab-svgs/-/issues/195
2
4,456,656
91,275,453
2021-08-02 13:26:01.826
FY22-Q3 KR2: Create new illustration asset and style library
Create a new Figma file and build a foundation of styles and assets in alignment with brand illustrations that can be used to update documentation and support a redesign of product illustration. Light and dark UI will be considered to determine if there's an efficient way to create illustrations that can also adapt to UI preference. * [x] Create a new Figma file with library styles that consider light and dark UI ~~(with mapping between the two)~~. * [x] Start creating reusable assets as components based on the audit in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1086 and the resources created by the brand team. ~~Initial focus specifically on assets that will support https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1088.~~ * [x] ~~Create a POC to test CSS vars and classes within the illustrations that update based on light/dark UI settings.~~ Create a POC to test browser support for SVG with transparency and gauge the result on light/dark UI.
5
4,456,656
91,275,385
2021-08-02 13:25:00.072
FY22-Q3 KR1: Audit current empty state illustrations
Audit all empty state illustrations to determine what elements are repeatable and where there are opportunities to empower designers to create their own unique empty state illustrations that are based on a library of reusable assets. * [x] Audit all empty states in https://gitlab-org.gitlab.io/gitlab-svgs/illustrations (can also be referenced from Figma in https://www.figma.com/file/0DhXXlTakscLiHZLKuiJ6C/Illustration-library). * [x] Create a list of repeating themes, sizes, and elements that could be leveraged to create an illustration library. --- ## Proposed state * Use a common grid to layout the illustration — one for large and one for medium (no small identified as empty states in the current illustration library). * Have a consistent focal-point. Leverage the grid and some keylines to help with object placement. * Use a consistent color palette for the focal-point element(s). * Establish guides on when to create a more custom illustration, and when to leverage something that's multi-purpose or more generic. For example, a more custom illustration could be created with a combination of new and existing assets for a new feature or one that isn't enabled, while an empty data state or configuration needed could always use the same asset. ### Repeating themes - New feature - Upgrade - Not configured - No data ## Sizes - Large - Medium - Small (new) ## Elements * Ellipses to contain icons or graphics. * Dashed connectors to establish relationships. * Shapes to represent placeholder content. * Small reusable illustrations. For example, to consistently represent no data or needs configuration. * More TBD after starting to build this out.
3
4,456,656
91,023,231
2021-07-28 13:20:24.385
GFM Typescale > Audio > design
## Task Create Figma specs for the GitLab Flavored Markdown audio component. See parent epic for detailed information about this component. ## [Figma branch (Audio)](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=1097%3A10) ![Documentation](/uploads/0bda3b5a88fa7e256a5523fcc954ae7e/Documentation.png)
1
4,456,656
90,925,147
2021-07-27 14:17:18.646
GFM Typescale > Inline diff > design
Create Figma specs for the GitLab Flavored Markdown inline diff component. See parent epic for detailed information about this component. Figma files: - [Documentation markdown - Inline diff](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=988%3A10) - [Compact markdown - Inline diff](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=893%3A4)
1
4,456,656
90,843,308
2021-07-26 12:10:31.807
GFM Typescale > Code block > design
Create Figma specs for the GitLab Flavored Markdown code block component. See parent epic for detailed information about this component. Figma assets: - [Documentation markdown - Code block](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=985%3A10) - [Compact markdown - Code block](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=890%3A8)
1
4,456,656
90,842,445
2021-07-26 12:00:08.892
GFM Typescale > Image > design
Create Figma specs for the GitLab Flavored Markdown image component. See parent epic for detailed information about this component. - :pencil2: [Figma branch - Documentation markdown](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/gI2szSJVfByu9N0Etzucr0/Type-scale---Documentation-Markdown?node-id=974%3A10) - :pencil2: Figma branch - Compact markdown - TBD
1
4,456,656
90,744,464
2021-07-23 17:18:14.582
Fix sidebar collapse when section has a collapsable sub-section
The following discussion from !2469 should be addressed: - [ ] @jeldergl started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2469#note_633217411): (+1 comment) > @tauriedavis something seems to be broken with this extra nested level. It's always open and looks active by default, even when navigating to other pages. Closing it closes the parent too. I haven't been able to dig into this further, but it makes me wonder if something with the JS has to get updated. > > ![CleanShot_2021-07-22_at_08.06.31](/uploads/88b404ed7ab0554f1e081159b338ab41/CleanShot_2021-07-22_at_08.06.31.gif)
2
4,456,656
90,737,033
2021-07-23 14:29:02.431
GFM Typescale > Blockquote > design
Create Figma specs for the GitLab Flavored Markdown blockquote component. See parent epic for detailed information about this component. ### Proposal | Compact (current) | Compact (New) | | ------ | ------ | | ![Screen_Shot_2022-04-25_at_09.13.25](/uploads/21ff653feded81ff89bb895ab230b107/Screen_Shot_2022-04-25_at_09.13.25.png) | ![Blockquote-compact-md](/uploads/0b2321770d18641b42fc914459cafd8b/Blockquote-compact-md.png) | | Documentation (current) | Documentation (New) | | ------ | ------ | | ![Screen_Shot_2022-04-25_at_09.12.21](/uploads/bf3713fb90309cd3905cdb6b2ee36040/Screen_Shot_2022-04-25_at_09.12.21.png) | ![Blockquote-doc-md](/uploads/9d8293214f4d4f2eba1c03ff10190ed9/Blockquote-doc-md.png) | **Summary of changes:** - Left border: `4px` `$gray-100` - Text: `$gray-700` - See reasons for color updates: https://gitlab.com/gitlab-org/gitlab/-/issues/231405/ ### Design source - :pencil2: [Figma - Documentation markdown](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/eMkpaCMX6MS4JsZhgRB23O/Type-scale---Documentation-Markdown?node-id=1843%3A373) - :pencil2: [Figma - Compact markdown](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/branch/ygOLNsF7gZZlJKrrOzaGlu/Type-scale---Compact-Markdown?node-id=1657%3A170) - :pencil2: [Figma - Component library](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=33967%3A28794)
1
4,456,656
90,701,620
2021-07-22 22:08:24.242
GFM Typescale > Table > design
Create Figma specs for the GitLab Flavored Markdown table component. See parent epic for detailed information about this component. - :pencil2: [Figma branch - Documentation markdown](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/branch/vO1Ef5cah3JWGlJKq9XvGw/Type-scale---Documentation-Markdown?node-id=1174%3A11) - :pencil2: [Figma branch - Compact markdown](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/branch/F0ml9uXBQGWz0Jg5YVjY90/Type-scale---Compact-Markdown?node-id=1554%3A78) ### Summary of changes - Removed all vertical borders - Removed thicker border between header and body row - Changed cell text color from `$gray-900` :arrow_right: `$gray-700` - Changed vertical text alignment from `middle` :arrow_right: `top` - All inner cell content for both header and body cells has a consistent padding of `8px` L/R and `12px` T/B - Added alternating rows by default
1
4,456,656
90,700,782
2021-07-22 21:21:39.168
FY22-Q3 Foundations KR1.5: Identify whether there are additional empty state types that need to be added
- [x] After reviewing the [four empty state types](https://gitlab.com/groups/gitlab-org/-/epics/6413), identify whether there are additional empty state types that need to be added - [x] If yes, identify problem statements to test during the validation phase
2
4,456,656
90,700,687
2021-07-22 21:15:56.257
FY22-Q3 Foundations KR1.4: Review "empty search results" empty state
Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `empty search results` empty state. Empty search results: Display empty search results. - [x] Find 2-3 existing examples of the `empty search results` empty state in the product - [x] Determine if this type of empty state is a valid use case for the empty state region - [x] Identify areas of possible improvement by writing problem statements to test during problem validation
1
4,456,656
90,700,665
2021-07-22 21:14:11.770
FY22-Q3 Foundations KR1.3: Review "error state" empty state
Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `error state` empty state. Error state: Convey an error state, which will depend on the nature of the error and should be used judiciously. An example of this would be a server response error, that is, 404 or 500. - [x] Find 2-3 existing examples of the `error state` empty state in the product - [x] Determine if this type of empty state is a valid use case for the empty state region - [x] Identify areas of possible improvement by writing problem statements to test during problem validation # Outcome We will want to remove this from empty state guidelines, as it is not a valid use case. Errors are separate and can be handled with anything from an alert to 404 to form validation
1
4,456,656
90,700,627
2021-07-22 21:12:33.624
FY22-Q3 Foundations KR1.2: Review "blank content" empty state
Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `blank content` empty state. Blank content: Act as a placeholder for regions in the app left blank intentionally. - [x] Find 2-3 existing examples of the `blank content` empty state in the product - [x] Determine if this type of empty state is a valid use case for the empty state region - [x] Identify areas of possible improvement by writing problem statements to test during problem validation
1
4,456,656
90,700,580
2021-07-22 21:10:07.979
FY22-Q3 Foundations KR1.1: Review "unused feature" empty state
Within our empty state documentation, we've identified [four types of empty states](https://design.gitlab.com/regions/empty-states#when-to-use-an-empty-state). In this issue, we will review the `unused feature` empty state. Unused feature: Make users aware that a feature is not configured for use. - [x] Find 2-3 existing examples of the `unused feature` empty state in the product - [x] Determine if this type of empty state is a valid use case for the empty state region - [x] Identify areas of possible improvement by writing problem statements to test during problem validation Proposals: * Update category name to `Configuration required`.
1
4,456,656
90,700,472
2021-07-22 21:03:18.123
FY22-Q3 Foundations KR2: Perform problem validation where necessary to understand existing limitations, creating recommendations and performing solution validation to confirm assumptions
[FY22-Q3 UX Department: Foundations SubTeam OKR](https://gitlab.com/groups/gitlab-org/-/epics/6412) Objective: Improve learnability of features by researching and providing recommendations for improved empty states with a focus on user on-boarding **KR3: Perform problem validation where necessary to understand existing limitations, creating recommendations and performing solution validation to confirm assumptions** - [ ] Using the problem statements from the [first KR](https://gitlab.com/groups/gitlab-org/-/epics/6413), perform problem validation to address assumptions - [ ] Generate recommendations based on research - [ ] Perform solution validation as needed Ally: https://app.ally.io/objectives/1453437?time_period_id=135090
3
4,456,656
90,700,269
2021-07-22 20:56:10.949
FY22-Q3 Foundations KR3: Update empty state usage guidelines/design specs using what we've learned from research
[FY22-Q3 UX Department: Foundations SubTeam OKR](https://gitlab.com/groups/gitlab-org/-/epics/6412) Objective: Improve learnability of features by researching and providing recommendations for improved empty states with a focus on user on-boarding **KR3: Update empty state usage guidelines/design specs using what we've learned from research** - [x] Update [empty state guidelines](https://design.gitlab.com/regions/empty-states) in Pajamas - [ ] ~~Update design specs in the [Figma UI Kit](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Pajamas-UI-Kit)~~ - [x] Review [existing empty state issues](https://gitlab.com/groups/gitlab-org/-/epics?scope=all&search=empty+state&state=opened) and close any that are no longer relevant Ally: https://app.ally.io/objectives/1453438?time_period_id=135090
3
4,456,656
90,690,258
2021-07-22 15:57:42.088
Button > Explore documentation hierarchy
## Purpose When working through some Pajamas research related to https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, I noticed that the concept of button categories and variants was confusing for users. I still mull it over from time to time too. I’m wondering if perhaps we could reconsider the hierarchy of information here to simplify it? | **Current** | **Proposed** | | ------ | ------ | | **Category:**<br>- Primary<br>- Secondary<br>- Tertiary<br><br>**Variants:**<br>- Confirm<br>- Default<br>- Dashed<br>- Danger<br>- Link | **Variants:**<br>- Confirm<br>&nbsp; - Primary<br>&nbsp; - Secondary<br>&nbsp; - Tertiary<br>- Default<br>&nbsp; - _Same pattern as Confirm_<br>- … | This would focus on the variants, and then the options for each variant. I think doing away with the category content as-is would be helpful. We can still identify primary, secondary, and tertiary actions, but secondary to variant. We could always take naming further, but a change like this doesn't require component changes as far as I can tell, just how it's presented.
3
4,456,656
90,680,025
2021-07-22 12:50:23.019
GFM Typescale > Code span > design
Create Figma specs for the GitLab Flavored Markdown code span component. See parent epic for detailed information about this component. - [Documentation markdown - Code span](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=909%3A10) - [Compact markdown - Code span](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=862%3A4)
1
4,456,656
90,567,168
2021-07-20 15:06:53.560
Add Pajamas Playground to documentation
### Problem While the Pajamas documentation provides extensive examples and code snippets for our components, there is currently no easy way to try our design system without installing GDK or creating a GitPod instance. ### Proposal This issue proposes adding a Pajamas Playground to our documentation (potentially as a simple iframe), to remedy this gap and enable designers & developers to: - Quickly try component code directly in the browser - Test different component props and combinations - Easily collaborate and generate code snippets for other developers **Question for the Foundations Team**: Do you see this as something useful and worth integrating into the docs? You can see a working proof of concept at https://dfosco.gitlab.io/pajamas-playground ![image](/uploads/34e863f638e349383893a28330476fe3/image.png) ### Possible Next steps The proof of concept above is a very rough prototype, and it can likely break very easily. Possible next steps to integrate this as an official part of our tooling include: - Embed playground in a dedicated page of Pajamas docs - Update code to dynamically import the latest version of _every_ Pajamas component (including new ones) - Add sharing button to append current code to URL -- see [example on Auth0 docs](https://auth0-cosmos.vercel.app/#/playground) - General cleanup of the code to meet team standards and reliability
2
4,456,656
90,357,136
2021-07-15 20:55:24.985
Pajamas > Move contributing content
## Problem - Recently the **Component lifecycle** content was updated, but it still remains the last item in the menu and could be elevated for more visibility. - Under the **Contribute** menu heading there is a **Get started** page, but there is already a **Get started** navigation heading above. ## Solution - Move the **Component lifecycle** page under the top **Get started** menu heading. - Move the **Get started** page under the top **Get started** menu heading and rename the page to "Contribute." - Remove the **Contribute** menu heading. - Update any Pajamas links to point to the new pages. ![CleanShot_2021-07-15_at_15.51.59_2x](/uploads/e9501d2bc4269ee76a96fe9ac64cb55b/CleanShot_2021-07-15_at_15.51.59_2x.png)
2
4,456,656
90,289,738
2021-07-14 19:19:57.566
Regions > Add merge request reports
## Purpose Add [merge request reports](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=38197%3A204050) to the **Regions** section of Pajamas. The initial content will come from the [Figma file](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=38197%3A204050). This is in preparation of the implementation phase for the MR widgets and having the SSoT in Pajamas.
2
4,456,656
90,287,401
2021-07-14 18:11:48.454
Follow-up from "feat(Color): Add color theme notes"
The following discussion from !2460 should be addressed: - [ ] @jeldergl started a [discussion](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2460#note_625218336): (+6 comments) > Note: these changes (and others like it) were brought about by the lint job that runs during a commit. --- The changes in question was the removal of indentation for HTML within a markdown file. The indentation helps with nesting and understanding the code. Removing it makes the markup harder to read and understand.
1
4,456,656
89,872,209
2021-07-07 03:12:00.014
Update Sidebar navigation component
<!-- Start by choosing one of the following based on the nature of your contribution: - For changes to an existing file, duplicate the general template (https://www.figma.com/file/v7I3e2CqmRagoi5jSzjROQ/Title-group-project-1337) to the UX Foundations Figma project (https://www.figma.com/files/project/8421515/UX-Foundation). Update the file name and cover details (this new file is considered the “working file”). Make changes in the working file to detached instances of a component, or copy/paste from designs in the original (target) file. - For additions, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. For example, a file making a change to the component library would belong in the UX Foundations project. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design. - For community contributions, create a new file in your drafts. To move a duplicate file: Open the duplicate, then use the dropdown next to the file name to select “Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.” --> ### Description <!-- Add a short description of your contribution. Consider adding a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. --> Updating the `Sidebar` component to match the direction of the navigation changes from %"14.0" - Using the gray-900 color instead of having theme color influence the sidebar https://gitlab.com/gitlab-org/gitlab/-/issues/330467 - Using the name `Infrastructure` instead of `Kubernetes` in instances to reflect https://gitlab.com/gitlab-org/gitlab/-/issues/334011 ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view. --> [View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/3wLvv6JyQvhy07Jxkvc630/Component-library?node-id=3050%3A0) `update-sidebar-component` branch ### Screenshots Variants | Before | After | | ------ | ------ | | ![image](/uploads/09701547d6b8b03ee1a32f4273042fd0/image.png) | ![image](/uploads/a0aed7fd48aa4851924daf691ad99c0b/image.png) | Instances | Before | After | | ------ | ------ | | ![image](/uploads/92de4216179a6d4983d028044a68bed7/image.png) | ![image](/uploads/8ea902918574292a8a156b2d984e558d/image.png) | ### Checklist Make sure the following are completed before closing the issue: 1. [x] **Assignee**: Design in your working file. When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [FE/UX Foundations designer][foundations-team]. 1. [x] **Assignee**: Update the link to the working file in the issue description. 1. [x] **Assignee**: Ask a [FE/UX Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). 1. [x] **Reviewer**: Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] **Reviewer**: Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] **Maintainer**: Review and approve assignee’s changes. 1. [x] **Maintainer**: Add the changes or additions to the target file. For example, you’d copy a final chart design from the working file and paste into the related location in the Data Visualization file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] **Maintainer**: When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] **Assignee**: Move your working file to the shared Figma project: 1. [ ] For Component Library changes, move your file to the [**Component archive**][component-archive] project. 1. [ ] For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. [ ] If you’re a community contributor, we ask that you [transfer ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. 1. [-] **Assignee** (or Maintainer, for community contributions): If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [-] **Assignee**: When applicable, [create an MR in this repository][new-gitlab-ui-mr] and apply the "component-guideline" template to create or update the component’s documentation page. If you do not have capacity, [create an issue in this repository using the "Component documentation" issue template][pajamas-component-documentation-template]. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. 1. [x] **Assignee**: When applicable, [create an issue in GitLab UI using the "Component" issue template][gitlab-ui-component-template] to build or update the component code. Bring the issue to your team planning session for prioritization and scheduling. Mark the new issue as related to this one. 1. [x] **Assignee**: 🎉 Congrats, you made it! You can now close this issue. [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-guideline-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/.gitlab/merge_request_templates/component-guideline.md [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation [new-gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new
2
4,456,656
89,563,039
2021-06-30 19:40:55.756
Update component markdown template
### Description Update the [example component documentation page template](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/pages/components/template.md) after https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2414 has been merged to reflect template updates. ### Checklist Make sure the following are completed before closing the issue: 1. [x] Assign the correct component label to this issue. 1. [x] Create an MR with the additions or updates needed. 1. [-] When applicable, [create a new Pajamas issue using the "Figma update" issue template][pajamas-figma-update-template] to update the component in Figma. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. 1. [-] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a new GitLab UI issue using the "Component"][gitlab-ui-component-template] issue template. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. 1. [x] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. 1. [x] 🎉 Congrats, you made it! You can now close this issue. <!-- ### Resources * [Compontent Lifecycle][component-lifecycle] --> [gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new [component-lifecycle]: https://design.gitlab.com/contribute/lifecycle [pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
1
4,456,656
89,489,145
2021-06-29 15:26:55.709
Add bot warning for workflow label and weight
## Purpose In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/850 the UX Foundations team is working on adding workflow labels and weights to each issue. When a new issue is created there's no way for the author to know that a workflow label and weight should be added. The proposal is to have a bot notify the author to add the workflow label or weight, or to automatically add a label. --- Message: ``` Hi @[AUTHOR], Please add a [workflow label](https://about.gitlab.com/handbook/product-development-flow/) and [weight](https://about.gitlab.com/handbook/engineering/ux/ux-designer/#ux-weight-definitions) to your issue. This helps to categorize and locate issues in the future. Thanks for your help! :heart: --- You are welcome to help [improve this comment](LINK). ```
2
4,456,656
89,486,695
2021-06-29 14:47:29.804
Evaluate VPAT against GitLab v14.0
## Purpose In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2434 we're updating the VPAT version to note that no material changes happened between 13.5 (date of current report) and 14.0. [More context](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1031) This effort evaluates 14.0 against the current VPAT report, makes any updates, and updates the version and report date in the VPAT.
2
4,456,656
89,416,050
2021-06-28 14:55:53.428
Pajamas competitor analysis
This issue is to discuss the possibility for doing competitor analysis for Pajamas. I think it will be valuable to do a lightweight version of the UX competitor analysis to gain insight into how we can continue to improve Pajamas, by taking a look at some other design systems. I think we have the opportunity to do something from scratch, I have heard from multiple designers that the current competitor analysis in UX is too in depth, perhaps we look at developing our own from scratch that's much simpler. - [ ] Determine whether doing a competitor analysis is useful - [ ] Determine how a formal competitor analysis will be structured
1
4,456,656
88,894,335
2021-06-17 16:53:34.548
Where should research insights live that impacts Pajamas?
## Purpose In a recent 1:1 I brought up the idea of using the wiki feature in the Pajamas project to house research insights and more conversational reasoning behind decisions that impact components. From each component page we could link to the relevant section of the wiki. This brought up the need to address a few questions at a higher level before solutioning: - Where should research live and how should it be incorporated into Pajamas (if at all)? - Is there still an insights repo that could be linked to? Currently, in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/2414 as part of the component page template update a new "Reference" section is being added with the intent to add links and commentary. The component page documentation should be direct, and we don't want to add to the overhead by having research links throughout that might be private or change. So where could we have a SSoT and how should we reference it?
1
4,456,656
88,587,817
2021-06-11 16:13:24.805
Tree > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the tree component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,816
2021-06-11 16:13:24.359
Tooltip > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the tooltip component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,815
2021-06-11 16:13:24.058
Token > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the token component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,814
2021-06-11 16:13:23.841
Toggle > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the toggle component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,813
2021-06-11 16:13:23.597
Toast > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the toast component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,811
2021-06-11 16:13:22.914
Tabs > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the tabs component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,809
2021-06-11 16:13:21.965
Table > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the table component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,808
2021-06-11 16:13:21.753
Spinner > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the spinner component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,807
2021-06-11 16:13:21.385
Sorting > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the sorting component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,806
2021-06-11 16:13:21.189
Socks > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the socks component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,805
2021-06-11 16:13:20.977
Skeleton loader > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the skeleton loader component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,804
2021-06-11 16:13:20.775
Segmented control > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the segmented control component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,803
2021-06-11 16:13:20.495
Search > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the search component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
88,587,802
2021-06-11 16:13:20.292
Radio button > Update docs to utilize new template
## Background As part of https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/541, we worked on a new page template for the `Usage` tab of component pages. ## Resources See the [parent epic](https://gitlab.com/groups/gitlab-org/gitlab-services/-/epics/5) for the new template, as well as a few examples of components that have already been migrated to the new structure. ## Proposal Update the radio button component usage tab to be in alignment with the changes. This may involve rewording content in addition to restructuring sections. After pushing up your MR, assign it to another Foundations design member for review.
1
4,456,656
127,230,475
2023-04-26 19:42:12.971
UI kit > Clarify heading breakpoints
## Description The breakpoint prefixes for heading styles can be perceived as available size options to be chosen from based on preference rather than sizes that need to be applied at a breakpoint. ## Solution Make the size more verbose and clear by adding "breakpoint" and clarifying the range. [![Figmacon.svg](/uploads/010a2eef1c97a94289ff4ff4991b2aa1/Figmacon.svg) View in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/HHCrSCelPUHKKK0d1QViMT/%F0%9F%93%99-Component-library?t=tGJp4jMMw0kkjMQM-11) **Example**: | **Before** | **After** | | ------ | ------ | | `UI/h1/sm` | `UI/h1/≤md breakpoint` | | `UI/h1/xl` | `UI/h1/≥xl breakpoint` | | ![CleanShot_2023-04-27_at_10.16.36_2x](/uploads/9637733e5911a47c4eb65933652a4cb4/CleanShot_2023-04-27_at_10.16.36_2x.png) | ![CleanShot_2023-04-27_at_10.16.58_2x](/uploads/e2fb00375a46dfc51e2ab4e9a2952e5c/CleanShot_2023-04-27_at_10.16.58_2x.png) | ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [-] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [-] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [-] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [-] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [-] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [-] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [-] Make sure all layers are correctly named and organized. 1. [-] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [-] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
126,941,915
2023-04-19 20:09:02.337
Labels and linking
## Purpose >>In this context, the text “Code owners” isn't explicit that it navigates to the code owners file, because it's also used as a label for the list of code owners of the current file. > > @pedroms I think this is a great point and something we should evaluate — should a label be allowed to link? And how does visual label relate to `label` (which wouldn't necessarily make sense in this context)? At the moment this text only visually appears as a label, and nothing about it, other than the preceding ':' indicates as much, which is why I'm inclined to proceed. Per the discussion in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117251#note_1353052885, this issue is to discuss the following: - Should text that _appears_ as a label (although isn't actually a `label`) be allowed to link? - If yes, what link variant is most appropriate? For example, the "Code owners" text in the following screenshot. ![CleanShot_2023-04-19_at_15.11.48_2x](/uploads/dadb264ad9c9ed05fe91fca0e7abd923/CleanShot_2023-04-19_at_15.11.48_2x.png) ## Next steps - Document a decision in Pajamas.
1
4,456,656
126,288,606
2023-04-05 14:22:54.150
Figma > Dropdown - decrease min-width
## Description Decrease the min-width of the dropdown by 8px (16rem → 15.5rem) so that it fits within the new sidebar navigation. This would have minimal, if any, impact on existing instances and may even slightly improve some where all option text is short. | **Before** | **After** | | ------ | ------ | | ![image](/uploads/dac60d1b393a00b17f0ecb914bc1af77/image.png) | ![image](/uploads/b2b73f4a7607d2cf69e2c0074bf2fbe1/image.png) | - [x] Update component and instances in Figma - [x] Create an issue to update in GitLab UI ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/n1QvO2JdlHIUUJUGsalyr0/%F0%9F%93%99-Component-library?t=EdntYrUvmvg1Uk3C-11) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [-] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [-] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [-] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
2
4,456,656
126,156,810
2023-04-03 09:25:19.835
Design tokens > Create page
Create a placeholder page in Pajamas to point people towards when design tokens come up in conversation. This also provides a space for MRs to add a lightweight definition and document where we are starting and why.
1
4,456,656
126,018,906
2023-03-30 21:43:35.918
Add new design-focused section to Pajamas
## Purpose Create a new section in the Pajamas website to house DesignOps content and make the UI kit documentation more visible and structured. ### Proposed structure --- <small>**DesignOps**</small> - Component lifecycle - Pajamas UI Kit - _Sections from the current md file…_ - Release notes --- The content in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md to this section to break it out into sub pages, make it available in Pajamas search, and have better formatting for visuals.
2
4,456,656
124,789,766
2023-03-06 11:31:28.589
Link > Finalise design specs
Issue to track efforts to finalise the design specs for links # Proposed link styles The following documents the intention, rather than the prescription for the actual CSS to be used. Class names placeholder to make it easier to read. There are certainly better ways to achieve the same thing. [Play with the styles in context in this codepen](https://codepen.io/danmh/pen/rNZGKbm). ```scss // Inline links assumed the default a { color: $blue-700; text-decoration: underline; text-decoration-color: rgba($blue-700, .72); // allows underline tone to match background text-underline-offset: 2px; // we should make this a relative value, // as it breaks when the browser font size is changed transition: background-color 100ms linear, color 100ms linear, border 100ms linear, text-decoration-color 100ms linear; // builds on existing link transition styles, adds text-decoration-color &:hover { color: $blue-800; text-decoration: underline !important; // allows other link types to have underline on hover // even if they have text-decoration: none for the rest state text-decoration-color: currentColor; } &:focus-visible { color: $blue-800; text-decoration: underline !important; text-decoration-color: currentColor; outline: 2px solid #428fdc; // existing focus styles outline-offset: 2px; // existing focus styles } &:active { color: $blue-900; text-decoration: underline; text-decoration-color: currentColor; transition: none; // makes the click or press feel snappy } } a.ui-link { text-decoration: none; // no underline in rest state } a.meta-link { text-decoration: none; &.meta-link-dark { color: $grey-900; &:hover {color: $grey-950;} &:active {color: $black;} } &.meta-link-subdued { color: $grey-700; &:hover {color: $grey-800;} &:active {color: $grey-900;} } } a.mention { padding: 0 2px; // these are no change from existing styles background-color: $blue-100; border-radius: 4px; text-decoration: none; &.mention-current { background-color: $orange-100; } } ``` ## Rational Why blue-700 Why opacity Why underline at all etc etc ### Next - [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1551+ ### Unblocks - [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/880+ - [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1217+ - [ ] https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1084+ - [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1536+ - [ ] https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1554+ ### Related to - https://gitlab.com/gitlab-org/gitlab/-/issues/336819+
2
4,456,656
124,619,714
2023-03-02 12:03:45.318
Add structure visual and list. for link
### Description <!-- Add a short description of the documentation addition or update. Remember to say why, not just what. --> Add link structure diagram Related to: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1444+ ### Checklist Make sure the following are completed before closing the issue: 1. [x] Assign the correct component label to this issue. 1. [x] Create an MR with the additions or updates needed. 1. [~] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [~] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. 1. [~] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. 1. [ ] 🎉 Congrats, you made it! You can now close this issue. <!-- ### Resources * [Component Lifecycle][component-lifecycle] --> [gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new [component-lifecycle]: https://design.gitlab.com/get-started/lifecycle [pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
1
4,456,656
124,074,239
2023-02-21 18:18:30.834
Breadcrumb component updates
# Breadcrumb The breadcrumb is a component that is less isolated than other components because it’s navigation based on the page it’s within, and is bound by the layout and behavior constructs of that page along with other content and functionality. Updates to the breadcrumb can’t happen without considering the impact to its own UX, and to the UX of the page in which it’s placed. For that reason, there are two parallel categories of considerations that have to be addressed: component-specific, and the relationship with other elements. ## Component-specific <details><summary>View details</summary> - Responsive - Wrapping and truncation - Truncation based on width or character count? Both? - Where truncation occurs in the string? - At wider views, should we allow larger strings to be expanded, potentially creating an unwieldy string in primary real estate? - States - Interactive states, such as hover and focus - Current page state - Design spec updates (border, separator, states, etc.) - Semantics and [accessibility updates](https://gitlab.com/groups/gitlab-org/-/epics/6879) for current implementation - Migration **Deliverables:** - [Updated design specs](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1533) - Updated Pajamas documentation - Component updates in GitLab UI - Component migration </details> ## Relationship with other elements <details><summary>View details</summary> - **[Navigation](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/2141) — specifically the sidebar show/hide icon placement and behavior (priority)** - DOM order with other elements, like alerts, banners, and broadcast messages - Within [headers](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3263) - Sticky behavior - Page actions - Fluid and fixed width layout settings **Deliverables:** - **Navigation + breadcrumb requirements and specs (priority)** - Identify and document potential patterns that use a breadcrumb - Updated Pajamas documentation </details> ## Resources - [A collection of 40+ breadcrumb components from various design systems](https://arc.net/e/F3F0AA49-51B1-4254-BD21-A450640C83E1) - [Pajamas > Breadcrumb](https://design.gitlab.com/components/breadcrumb) - [GitLab UI > Breadcrumb](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-breadcrumb--default)
5
4,456,656
123,176,841
2023-02-07 07:51:38.155
Dropdown > Document height options
### Description Document height options (fit contents height vs. fixed height). There are use cases where we want the dropdown to shrink to it's content (fit contents) and others where we want to keep its initial height (fixed height). | Contents size | Keep initial height | | ------ | ------ | | ![image](/uploads/79f6e6c264a0dce355312c72599dc237/image.png) | ![image](/uploads/d3d6b212f69cc7da039ccde5184051cc/image.png) | ### Checklist Make sure the following are completed before closing the issue: 1. [X] Assign the correct component label to this issue. 1. [ ] Create an MR with the additions or updates needed. 1. [ ] When applicable, [create an issue using the `Figma update` issue template][pajamas-figma-update-template] to update the component in Figma, and mark it as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create an MR in GitLab UI][gitlab-ui-mr] to update the component. If you do not have capacity or are unable to update the component directly, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template]. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one. 1. [ ] When introducing a major or breaking change, communicate the changes within the Engineering Week in Review and UX Weekly meeting. 1. [ ] 🎉 Congrats, you made it! You can now close this issue. <!-- ### Resources * [Component Lifecycle][component-lifecycle] --> [gitlab-ui-mr]: https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/new [component-lifecycle]: https://design.gitlab.com/get-started/lifecycle [pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component
1
4,456,656
122,956,530
2023-02-02 17:03:00.874
fix: Add missing "Contribute" tabs
## Purpose Some component pages are missing the "Contribute" tab.
2
4,456,656
122,852,029
2023-02-01 15:14:25.849
Figma > Button - Add states
## Description This MR adds missing states to the main components (hover, focus, active). ### Figma file [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/4VRjxqlOB94BomdQfBNioe/%F0%9F%93%99-Component-library?node-id=425%3A7&t=XFUiIlIv43Z2bxqU-11) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [X] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [X] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [X] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [X] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [ ] Make sure all layers are correctly named and organized. 1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [ ] Ensure component descriptions and external documentation links are clear and accurate. 1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
122,830,518
2023-02-01 10:46:33.881
Figma > Toggle - Add states
## Description This MR adds the missing states to the badge component. | Before | After | | ------ | ------ | | ![image](/uploads/7a40accf6d25e1528a7fcf4cd8bf2755/image.png) | ![image](/uploads/11a641db0eeb9e9a2dc3b51f84dfb24c/image.png) | ### Figma file [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/QXWDiFqaiOZVtKXdheEc49/%F0%9F%93%99-Component-library?node-id=425%3A140&t=WDnJTGhTFcT4t2TZ-11) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [X] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [X] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360038512093) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [-] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [-] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [-] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=manage-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
122,729,768
2023-01-31 05:05:26.187
Update inline text link hover/focus style to align with docs
From !3205 We currently don't change the color for inline text links on design.gitlab.com so this might be something we should update to align with guidance here in later iterations.
1
4,456,656
122,515,620
2023-01-26 21:30:20.938
Figma > Tertiary button multiply
## Description The tertiary buttons use `mix-blend-mode: multiply` ([source](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/button/button.scss#L326)) to keep contrast consistent when on different background colors. This updates them in the UI kit to match. <!-- - For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching. - For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design. - For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts. To move a duplicate file: Open the duplicate, then use the dropdown next to the file name to select “Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.” --> ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/TT1EM05P5ALuyJv017MFXf/%F0%9F%93%99-Component-library?node-id=425%3A7&t=qOSChFXfSNeeKAdK-11) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [-] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [-] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [-] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [ ] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [ ] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
122,318,319
2023-01-23 17:42:41.455
Dropdown > Update design spec to include min/max width
## Purpose Based on the implementation plan in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1507#implementation-plan, the **dropdown** design specs should be updated to include the recommended minimum and maximum widths. This doesn't have to be a component setting, but that is an option if the configuration is easy enough to implement and the design experience isn't impacted. ## Specs Make dropdown's width more flexible: * [x] min-width: 16rem (256px) * [x] max-width: 28.5rem (456px) * [x] max-height: 19.5rem (312px)
2
4,456,656
121,186,565
2023-01-03 19:31:36.320
Broadcast message > Update variants and instances
## Description Updating the broadcast message component in Figma to: - Better account for fixed vs. fluid layout behavior. - Max-width (954px) is calculated based on the [990px fixed width](https://design.gitlab.com/product-foundations/layout#fixed-layout) minus 16px margin on each side. - Add description for each variants. Description is visible in the properties panel when an instance is selected. - Add ability to toggle × close icon. - Add instances for different states and [example] themes. - Remove unnecessary todo and note. The changes are modeled after what's currently in place for the [alert component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=425%3A1&t=zd18xI1uNlssCjAi-11). ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/J0xjeC3YBsx0AeJJx3cGf7/%F0%9F%93%99-Component-library?t=mg4lYg8ii8OcZgwZ-11) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [ ] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [ ] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
121,174,687
2023-01-03 16:25:24.204
Dropdown > Direction for rendering overflowing, non-wrapping text within items
In some cases, we might need to display long non-wrapping texts within a dropdown's items. For example, the notification settings display the user's emails, which might overflow the dropdown menu: ![Screenshot_2023-01-03_at_8.41.24_AM](/uploads/5ca3d1a413d52a539ce89f18ad5e5e4e/Screenshot_2023-01-03_at_8.41.24_AM.png) ## Implementation plan - [ ] `GlTruncate`: ensure the rendered element has an accessible `aria-label` attribute. - [ ] `GlCollapsibleListbox` - [ ] Make dropdown's width more flexible: - [ ] `min-width: 15rem` - [ ] `max-width: 28.5rem` - [ ] Leverage `GlTruncate` to truncate long items' names. This should be probably be the consumer's responsibility, so this can be a recommendation in the docs. - [ ] Ensure the notifications settings render properly as per https://gitlab.com/gitlab-org/gitlab/-/issues/373843#note_1227467886.
2
4,456,656
120,713,314
2022-12-20 20:03:20.601
Figma > File uploader enhancements
## Description Address the following items from https://gitlab.com/gitlab-org/gitlab-ui/-/issues/297: <details><summary>Component overrides</summary> ### Component property user experience #### Conditional properties Changing some of the component properties can override previously selected options. ![Kapture_2022-11-30_at_15.19.17](/uploads/ff617a5bfb49c1054ef5bb697db961cf/Kapture_2022-11-30_at_15.19.17.gif) There is opportunity to improve the user experience here by only showing properties relevant to the selected variation. #### Retaining overrides Some overrides are not retained when switching versions ![Kapture_2022-11-30_at_15.22.57](/uploads/e9a020087165a8d6bf15b796219edbb4/Kapture_2022-11-30_at_15.22.57.gif) </details> <details><summary>Recreating the current UI</summary> ### Recreating the current UI Using this component it is not possible to recreate the current UI. ![Kapture_2022-11-30_at_15.26.26](/uploads/7055daa9f66fad5173f801cb439a3885/Kapture_2022-11-30_at_15.26.26.gif) </details> <details><summary>Slider considerations</summary> Moved to it's own issue -> https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1511+ </details> ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/ccOwOGUNWttGmmMalGjzMQ/%F0%9F%93%99-Component-library?node-id=8000%3A0&t=OsyuPWkvpYs3s9jK-11) ![CleanShot_2022-12-20_at_14.01.51_2x](/uploads/9f073beb69617b24bea4f703e2dbde79/CleanShot_2022-12-20_at_14.01.51_2x.png) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [ ] Make sure all layers are correctly named and organized. 1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [ ] Ensure component descriptions and external documentation links are clear and accurate. 1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
2
4,456,656
120,437,029
2022-12-14 21:43:28.735
Figma > Form elements remove warning state
## Description The warning (orange) state for form elements isn't present in GitLab UI, and it was determined that there isn't a need for it via https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1809. This issue is to remove the warning state from the form elements in Figma, and to remove any mention of it Pajamas. ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/qnl2lq49gLpti4TFUCNlhm/%F0%9F%93%99-Component-library?node-id=49840%3A75722&t=0qOhvYOSwOznoAf7-11) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [-] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [-] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [-] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [-] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [-] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [-] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [-] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [ ] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
2
4,456,656
120,174,557
2022-12-09 19:05:39.341
Figma > Tooltip – Update tooltip component to resize based on content
## Description The tooltip component currently doesn't resize based on content. Additionally, if you change the tip position, the content isn’t persisted. See [discussion in Slack](https://gitlab.slack.com/archives/CNDGX396C/p1670605977187449) and example: ![Kapture_2022-12-09_at_11.12.03](/uploads/365dd3e332c3d83c3144d6906a2420af/Kapture_2022-12-09_at_11.12.03.mp4) We should update the component to fix these issues. <!-- Add a short description of your contribution. Consider adding a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. --> <!-- - For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching. - For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design. - For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts. To move a duplicate file: Open the duplicate, then use the dropdown next to the file name to select “Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.” --> ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/UXgoH1IanB4jxRctxXEt50/%231469-tooltip-resize-danmh?node-id=425-142) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [~] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Consider adding a new version to the file's [version history](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history) to indicate the state prior to merging the changes. The name of the version and description of the changes are saved in the file history and provide a meaningful reference point. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. 1. [x] If the file's version history isn't clear, [name the latest version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Name_an_existing_version) and update the details so it's clear what change had been made. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
2
4,456,656
119,333,804
2022-11-24 14:14:01.574
Figma > Pagination - Refactor component
## Description Refactored the Pagination component to use Variants for the pagination items. Also updated the focus style of the component. ### Figma file [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/LbJ6WDv08Iznll87TfoOin/%F0%9F%93%99-Component-library?node-id=425%3A130&t=4ijE7d28kTS0Ys92-0) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
2
4,456,656
119,246,695
2022-11-23 10:16:26.707
Figma > Dropbutton - Friendly text first
## Description This is a follow-up to https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1465+ and updates the Dropbutton component to use the friendly text first for filters. ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/NJNiIFOFovDtXJWmMHQY16/%F0%9F%93%99-Component-library?node-id=65182%3A99209&t=Pj6CvbqbaGv71jCQ-1) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [ ] Make sure all layers are correctly named and organized. 1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [ ] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
119,246,302
2022-11-23 10:10:08.478
Figma > Token - Update Focus
## Description Updates the focus to make use of the focus helper component. ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/v4EklPE0xEbS54bngpqjgx/%F0%9F%93%99-Component-library?node-id=425%3A141&t=1OP5Fz5ygJ9NcnCr-0) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [x] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [x] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [x] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [x] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
118,936,476
2022-11-17 19:57:44.973
Button > Add note about icon indicating action
## Purpose Icon only buttons shouldn't act as a toggle where the icon might change depending on state. For example, ![eye.svg](/uploads/8d7f9c533374ec1ef07ab58fcfbc184f/eye.svg) changing to ![eye-slash.svg](/uploads/c8cdb864cae90e67f1534b8d2f527f92/eye-slash.svg) on click because the state can be confusing. Does it mean that the current state is A and clicking goes to B, or the opposite? This issue is to initiate documenting the recommendation.
1
4,456,656
118,776,570
2022-11-15 22:42:35.204
Update severity guides for errors
## Purpose In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/contents/usability/error-prevention.md?plain=1#L13 there's reference to old button content that can be updated. Along with the the entire section will reviewed to make sure it's accurate. >The destructive action can easily be undone and no actual data was lost. Consider adding no friction at all in order to streamline the interface, especially in places where the action needs to be performed in bulk. These kinds of destructive actions can be exempt of being **[elementary](/components/button/#elementary) styled and can instead be [neutral](/components/button/#neutral) styled buttons.** (Emphasis added)
1
4,456,656
118,773,554
2022-11-15 21:26:13.349
Pajamas navigation refinements
## Purpose A followup from #1443 to further refine the navigation with the following: - Update the Pajamas lockup and ensure a common left edge (alignment) for all elements. - Ability to expand multiple sections at once. This is a common accordion-like pattern that would allow a user to compare the options in different sections. While this UX might not be ideal for some sites, it can be a benefit for a user of Pajamas to get a better understanding why there are **Form elements** in one section, and **Forms** in another. - Sticky expanded sections. Since some sections (like **Components**) are quite long, having the parent category item sticky when expanded can help a user maintain context for the current section they're navigating. - Update design of search to be more integrated into the sidebar (inspired by the recent update to the dropdown design). | **Before** | **After** | | ------ | ------ | | ![CleanShot_2022-11-15_at_15.27.07_2x](/uploads/8301cb427469b78bf66e01a215e5c87f/CleanShot_2022-11-15_at_15.27.07_2x.png) | ![image](/uploads/8f6ee6079020c5cc846a22404d1bfb37/image.png) | [![Figmacon.svg](/uploads/45f9a446f4122aef0e50b97cb651f039/Figmacon.svg) View the working file in Figma →](https://www.figma.com/file/qYQOk3DhrswWIsRnoUTJ6J/%231378-Pajamas-IA-JE?node-id=708%3A4482&t=TDoghMezobgvIbnA-11) **Note:** The _before_ screenshot is from !3115's review app.
3
4,456,656
118,771,757
2022-11-15 20:29:49.833
Figma > Update button size and position in dropdowns
## Description - Buttons in a dropdown ([disclosure](https://design.gitlab.com/components/dropdown-disclosure) only) could use the sm size since they're already in a smaller container and supporting a larger context. - Buttons in a dropdown ([disclosure](https://design.gitlab.com/components/dropdown-disclosure) only) should be right positioned to follow [alignment](https://4456656-review-1443-updat-77up3w.design-staging.gitlab.com/) guidelines since they are in a constrained container. | **Before** | **After** | | ------ | ------ | | ![image](/uploads/44a76d2d78c9ab223e76791c52280f37/image.png) | ![image](/uploads/2fcc11088865066ced77ba6ced3f89c3/image.png) | | ![image](/uploads/1c5acead1180d98d9518df9e797e2794/image.png) | ![image](/uploads/f8594eaaf113b20436b9ec6f78a6abdd/image.png) | [![Figmacon.svg](/uploads/8e37dee9c9a9f3f31a0fd70b2cfb721d/Figmacon.svg) View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/Ec1j6iY0dkjujPqhR8mxMw/%F0%9F%93%99-Component-library?node-id=65182%3A99209&viewport=-2770%2C229%2C1&t=KsEY2muucemu16ht-11) ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/Ec1j6iY0dkjujPqhR8mxMw/%F0%9F%93%99-Component-library) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
118,758,205
2022-11-15 16:03:32.458
Pajamas site mobile nav
## Purpose As a followup to !3115 there are some additional improvements needed for the mobile navigation of the Pajamas website. From https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/3115#note_1171724042: > …move from a partial cover to a full-width/overlay menu to: > > 1. Add a close button in correct focus order, potentially using a × icon > 1. Remove overflow scroll of page content while menu is open (swipe moves content body not menu items) > 1. Allow increase in touch targets in menu for mobile > 1. Rethink ≡ overlapping page content on scroll
3
4,456,656
118,643,439
2022-11-14 04:49:31.441
Homepage images sizing on small screens
Update homepage styles so that images load correctly on mobile. Fix layout to avoid x-axis overflow on smaller screens e.g. `320px`.
1
4,456,656
118,458,939
2022-11-10 00:20:20.315
Update documentation heading border styles
Update heading `border-bottom` styles to be consistent with tab border color. Tighten `padding-bottom` to improve vertical rhythm between headings and related content.
1
4,456,656
118,368,014
2022-11-08 16:38:04.314
Figma > Remove alert in modal example
## Description Per [Pajamas](https://design.gitlab.com/usability/error-prevention#severity-guidelines): >Avoid using alerts to emphasize the content inside a modal. and… >Any final confirmation that is destructive must use the danger variant (unless a browser dialog is used). This removes the alert from the modal example content and reformats the text. | **Before** | **After** | | ------ | ------ | | ![image](/uploads/375ceb61324612f7b54d67b80a426155/image.png) | ![image](/uploads/fc0002aa8606373b49ffd65a39ad1506/image.png) | ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/WaECLxx4sHP5BfyWgIXYmp/%F0%9F%93%99-Component-library?node-id=425%3A129&viewport=-90%2C25%2C0.93) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [x] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [x] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [x] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
118,308,894
2022-11-07 20:54:31.002
Figma > Broadcast message use paragraph style
## Description Use paragraph style instead of label and address any layout regressions (will match GitLab UI). | **Before** | **After** | | ------ | ------ | | ![image](/uploads/c7a7b17ae050a2a3c97bb0fa2b0c58b3/image.png) | ![image](/uploads/ec71c03708b64d10d151f5f5f41c6cee/image.png) | ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/7pJYvD1VtVfHDvWW7zWump/%F0%9F%93%99-Component-library?node-id=425%3A6&viewport=835%2C400%2C0.8) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [x] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [x] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [ ] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
118,308,781
2022-11-07 20:51:23.656
Figma > Accordion use paragraph instead of labels style
Update text styles and address any layout regressions (will match GitLab UI). | **Before** | **After** | | ------ | ------ | | ![image](/uploads/54da8cd9b4f6e8399c75d4c7d01fe1e4/image.png) | ![image](/uploads/a3e5f1efae318904ed0268d36cef599e/image.png) | [View working branch in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/4ytND6X78TA9d8IPJGpYJv/%F0%9F%93%99-Component-library?node-id=425%3A0)
1
4,456,656
118,136,795
2022-11-04 10:34:40.096
Figma > Merge request reports - update non-ui kit components
## Description <!-- Add a short description of your contribution. Consider adding a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. --> <!-- - For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching. - For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design. - For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts. To move a duplicate file: Open the duplicate, then use the dropdown next to the file name to select “Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.” --> Merge request reports page uses non-ui kit components. Issue to switch them to use UI Kit versions. | Before | After | | ------ | ------ | | ![Screenshot_2022-11-04_at_10.51.28](/uploads/75a009e39285b507cc0341f6b64752c0/Screenshot_2022-11-04_at_10.51.28.png) | ![Screenshot_2022-11-04_at_10.52.31](/uploads/476033e2c464c7e9ca6d34bd16198088/Screenshot_2022-11-04_at_10.52.31.png) | Also added the full stop :smile: ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/fAr4qmF4D71mTFF7s8Bn6D/%F0%9F%93%99-Component-library) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [x] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [x] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [x] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [x] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [x] Update the link to the working file under the **Figma link** section below. 1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [x] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [x] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [x] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [x] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [x] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [x] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [x] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [x] From the dropdown to the right of the file name, select "Request review". 1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Make sure all layers are correctly named and organized. 1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [ ] Ensure component descriptions and external documentation links are clear and accurate. 1. [x] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [x] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [x] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [x] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [x] Merge the branch or add the changes or additions to the target file. 1. [x] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [x] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
1
4,456,656
118,079,628
2022-11-03 12:47:46.558
Figma > File uploader - Fix instances to use linked components
## Description <!-- Add a short description of your contribution. Consider adding a checklist of variations, states, and breakpoints to the description so that reviewers can be sure to cross reference everything that has been completed. --> <!-- - For changes or additions to an existing file, create a branch in Figma (this new file is considered the “working file”). Include the issue or MR number in the branch name. Make changes in the working file and request a review when ready. See https://www.figma.com/best-practices/branching-in-figma/ for details about branching. - For new files, duplicate the template that is most relevant (https://www.figma.com/files/project/5846042/Templates) to the project that also is the most relevant. Update the file name and cover details (this new file is considered the “working file”) and proceed with the design. - For community contributions, create a new file in your drafts, or duplicate an existing file to your drafts. To move a duplicate file: Open the duplicate, then use the dropdown next to the file name to select “Move to Project…” and select the desired project as the new location. The duplicate is now the “working file.” --> There are detached instances in the file uploaded examples. Issue to reattach those that can be and ensure correct styles and components are used. https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=8000%3A1 ### Figma file <!-- Before pasting the link to your Figma file/frame, in the file sharing settings, make sure that “anyone with the link” can view or that a specific user has been invited to the file. --> [❖ View working file in Figma →](ADD LINK TO FIGMA FILE/FRAME) ## Checklist Make sure the following are completed before closing the issue: ### Assignee tasks: <details><summary>Getting started:</summary> 1. [ ] Title the issue using this structure "Figma > [Component name] - [Description]". For example, Figma > Badges - Fix icon override bug. 1. [ ] Add the relevant [component label](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/labels?subscribed=&search=component%3A). For example ~"component:badge". 1. [ ] If you’re making updates or breaking changes to an existing component in the [Pajamas UI Kit](https://www.figma.com/community/file/781156790581391771), start with a [branch](https://www.figma.com/best-practices/branching-in-figma/) of the UI kit. Prefix the branch name with the issue, MR, or epic number, and add your GitLab username as the suffix. For example, `#860-table-component-updates-lvanc`. 1. [ ] When applicable, follow our [structure][structure], [building][building], and [annotation][annotation] guidelines. If you have any questions, reach out to a [Foundations designer][foundations-team]. 1. [ ] Update the link to the working file under the **Figma link** section below. 1. [ ] If work was not done in a branch (a merged branch will automatically be archived), move your working file to the shared Figma project: 1. For Component library changes, move your file to the [**Component archive**][component-archive] project. 1. For all other changes, move your file to the [**Misc archive**][misc-archive] project. 1. If you’re a community contributor, please consider [transferring ownership of your draft file](https://help.figma.com/hc/en-us/articles/360040530853) to the maintainer so they can move it to our archive, along with its version history and comments. </details> <details><summary>Prior to review:</summary> The purpose of these tasks is to ensure consistency with the rest of the components and to save time during the review process. When you are finished with your update, please go through the following clean-up tasks in Figma: 1. [ ] **Canvas**: Make sure no hidden elements have been accidentally left behind. Use **View > Show Outlines** (<kbd>⌘</kbd> + <kbd>Y</kbd>) to reveal invisible objects. Use **View > Zoom to Fit** (<kbd>Shift</kbd> + <kbd>1</kbd>) to view all items on the page. 1. [ ] **Components**: Where applicable, make sure all components have updated descriptions and have external documentation links. 1. [ ] **Frames**: Make spacing within and between frames consistent with components found on other pages. 1. [ ] **Layers**: Make sure all your layers are correctly named and the order match visual from left to right. In the case of Auto Layout, Figma will determine layer order. 1. [ ] **Variants**: Remove the default dashed purple stroke, border radius, and padding from all variants. 1. [ ] **Variants**: Reorder variants in properties panel to match visual order. In the case of Auto Layout, Figma will determine layer order. 1. [ ] **Comments**: Make sure all comments and discussion are resolved. If any of these tasks are unclear, see the [Table component](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=47785%3A58915) for reference. </details> <details><summary>Requesting a review:</summary> Ask a [Foundations designer][foundations-team] to review your design. 1. [ ] Ensure the designer that will be reviewing your file has edit permissions in Figma. 1. [ ] From the dropdown to the right of the file name, select "Request review". 1. [ ] Then from the modal window, remember to include a description of the changes being made and select a reviewer from the right hand column. 1. [ ] Consider [creating a new version](https://help.figma.com/hc/en-us/articles/360038006754-View-a-file-s-version-history#Create_a_new_version) (optional) titled "Review requested" in the history which will create a reference point in the file's history. Once your file is in review, you should see a yellow "In review" badge to the right of the file name. </details> <details><summary>Post review:</summary> Once the Reviewer or Maintainer has approved your update, consider the following tasks: 1. [ ] If it’s a new pattern or a significant change, add an agenda item to the next UX weekly call to inform the team. 1. [ ] When applicable, add or update relevant documentation and create an MR with your changes using the `Documentation` MR template. If you do not have the capacity, [create another issue using the `Component documentation` issue template][issue-component-template] so we don't forget about it. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] When applicable, [create a GitLab UI issue using the `Component` issue template][gitlab-ui-component-template] to build or update the component code. Mark the new issue as related to this one. Bring the issue to your team planning session for prioritization and scheduling. 1. [ ] 🎉 Congrats, you made it! You can now close this issue. </details> ### Reviewer tasks: <details><summary>See tasks:</summary> 1. [ ] Review and approve assignee’s design. Specific design questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [ ] Make sure all layers are correctly named and organized. 1. [ ] Stress test final component by changing the component's size, editing content, and changing any available variants and properties. 1. [ ] Ensure component descriptions and external documentation links are clear and accurate. 1. [ ] Approve assignee’s design. Let the assigning know that their changes have been approved by mentioning them in this issue. 1. [ ] Assign to a [Figma maintainer][figma-maintainer] for final review (make sure they have edit permissions in Figma). 1. [ ] Ask a [Foundations designer][foundations-team] to review your design (ensure they have edit permissions in Figma). </details> ### Maintainer tasks: <details><summary>See tasks:</summary> 1. [ ] Review and approve assignee’s changes. questions can be addressed with comments in Figma. Comment in this issue when the content is less specific to the design or requires greater visibility. 1. [ ] Merge the branch or add the changes or additions to the target file. 1. [ ] Ensure that all styles and components now belong to the target file. 1. [ ] For changes to the **Component Library** file, view the components in the Assets panel to ensure they align with our [asset library structure guidelines][structure]. 1. [ ] When applicable, [publish][publishing] any library changes along with a clear commit message. </details> [annotation]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#adding-descriptions-notes-and-annotations [building]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#building-components [foundations-team]: https://about.gitlab.com/company/team/?department=ecosystem-foundations-team [figma-maintainer]: https://about.gitlab.com/handbook/engineering/projects/#design.gitlab.com [publishing]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#publishing-changes [structure]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/blob/main/doc/pajamas-ui-kit.md#structure [component-archive]: https://www.figma.com/files/project/5472112/Component-archive [misc-archive]: https://www.figma.com/files/project/10620392/Misc-archive [gitlab-ui-component-template]: https://gitlab.com/gitlab-org/gitlab-ui/-/issues/new?issuable_template=Component [issue-component-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation <!-- Do not delete below this line -->
2