idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
|---|---|---|---|---|---|
7,071,551 | 21,414,491 |
2019-05-29 15:39:28.971
|
Ensure avatar examples don't rely on external images
|
Currently, for our [Avatar stories and examples](https://gitlab.com/gitlab-org/gitlab-ui/blob/6232eb434adf190c8085aafd5787b17dd3b895b4/components/base/avatar/avatar.stories.js#L14), we use an image which is sourced from gitlab.com
This is not ideal and could potentially cause our visual regression test suite to fail in the event that the image changes or becomes unavailable.
## Solution
Ideally, we should be using an image from within gitlab-ui.
| 2 |
7,071,551 | 20,640,280 |
2019-05-07 06:48:49.965
|
Improve/simplify toast styling
|
## Summary
Currently, we use vue-toasted as a dependency for our toast component, which means that we're forced to override vue-toasted's styles in order to apply our own styling.
Since we're overriding vue-toasted's styling we end up with nested CSS which becomes difficult to maintain.
## Improvements
We should come up with a way to make us less dependent on vue-toasted's stylesheet and make our CSS more maintainable.
Perhaps there's a way we can disable their stylesheet entirely?
| 3 |
7,071,551 | 20,443,271 |
2019-04-29 15:27:51.403
|
Switch from vue-toasted to BootstrapVue's toast component
|
Our [current toast component](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-toast--default) relies on `vue-toasted`.
BootstrapVue now includes its [own toast component](https://bootstrap-vue.js.org/docs/components/toast), which is in beta as of writing this.
Let's remove the extra dependency on `vue-toasted` by switching to BootstrapVue's component once it's out of beta.
This plan was discussed here: https://gitlab.com/gitlab-org/gitlab-ui/issues/238#note_162944906
| 3 |
7,071,551 | 20,440,205 |
2019-04-29 14:05:38.803
|
Internationalization on chart legend - avg and max
|
I noticed that the chart legend `Avg` and `Max` text isn't internationalizable:
It is not possible to internationalize text within gitlab-ui. This could become a bigger issue as more components that contain text are added to gitlab-ui.
This instance could be solved by making the text directly configurable via a prop.
| 2 |
7,071,551 | 19,939,655 |
2019-04-10 20:09:47.635
|
Prettier job failures are confusing
|
When Prettier fails in CI, it doesn't print a useful error message. All we get is a lousy `console.log` warning from eslint
Example output:
```
$ yarn lint
yarn run v1.13.0
$ eslint --ext .js,.vue .
/builds/gitlab-org/gitlab-ui/components/base/loading_icon/loading_icon.vue
68:7 warning Unexpected console statement no-console
✖ 1 problem (0 errors, 1 warning)
Done in 7.92s.
$ yarn prettier --list-different '**/*.{js,vue}'
yarn run v1.13.0
$ /builds/gitlab-org/gitlab-ui/node_modules/.bin/prettier --list-different '**/*.{js,vue}'
components/base/form/form_select/form_select.vue
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: Job failed: exit code 1
```
Better would be message saying "please run `prettier --write` to fix the errors"
| 1 |
7,071,551 | 19,767,198 |
2019-04-05 12:05:39.740
|
Add label component
|
https://design.gitlab.com/components/label/
**Note** This should encompass both regular labels and scoped labels
- Specs: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/labels-spec-previews/
| 2 |
7,071,551 | 25,764,601 |
2019-03-28 00:40:56.149
|
Scoped labels restyled
|
From https://gitlab.com/gitlab-org/gitlab-ee/issues/9175#note_154807790
| Different sizes/colors | In sidebar |
| ------ | ------ |
|  |  |
Note that for this iteration, **the question mark icon will still be in the label**, so they'll look like this:
<img src="/uploads/e1373d2696407ef76440aee03924f603/Screen_Shot_2019-04-11_at_2.31.10_PM.png" width="400px">
### Design notes/specs
* Border on large labels is `2px`; on small labels it's `1px`
* We currently choose the text color based on which color the user selected as background. If the label background is dark, it has white text, if it is light, it has dark text
* For labels with white text, the label value should have a white background, and the text color should match the background of the scope portion (revert the 2 colors)
* For labels with dark text, the label value should still have a white background, but the text color should still be the standard dark text color
* The question mark icon is `$gray-500`: `#a7a7a7`
* Specs- https://gitlab-org.gitlab.io/gitlab-design/hosted/annabel/%23282-scoped-labels-spec-previews/
| 2 |
7,071,551 | 25,729,794 |
2019-03-14 12:01:50.531
|
Update labels in gitlab-ui to use interactive popover
|
gitlab-ce~9594407 since GitLabbers use labels heavily.
---
### Problem to solve
We currently have links included in label tooltips, which are not particularly helpful as tooltips disappear as soon as you hover outside the element.
### Design Solution
| Labels | New label form |
| ------ | ------ |
|  |  |
<details>
| New label form | Labels |
| ------ | ------ |
|  |  |
| Links should be blue, scoped labels `?` should link to docs | Convert description `input` to `textarea`; add markdown help text |
<summary>Previous design</summary>
From @cperessini's comment in https://gitlab.com/gitlab-org/gitlab-design/issues/282#note_150466105
</details>
**Blocked by:** https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/855
| 2 |
7,071,551 | 18,765,462 |
2019-03-04 07:47:55.125
|
Standalone `gl-form-radio` components do not work without a `gl-form-radio-group` ancestor
|
As of writing, our `gl-form-radio` component wrapper is unusable. Once !192 is merged, it will be usable, but *only* as a descendant of a `gl-form-radio-group` component.
The underlying `b-form-radio` components we wrap *can* be used *without* any ancestor `b-form-radio-group` component, however. The issue is that we're not correctly forwarding the `v-model` directive from the `gl-form-radio` component down to the `b-form-radio`.
Part of #135.
| 2 |
7,071,551 | 17,389,480 |
2019-01-16 12:47:23.127
|
Search box icon is positioned incorrectly in Safari
|
spotted in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8591#note_132045635
The dropdown search icon appears to be positioned incorrectly in Safari
| 1 |
7,071,551 | 16,752,951 |
2018-12-18 12:28:18.551
|
Add bootstrap-vue's radio button components
|
To support browser consistent radio buttons we need to wrap https://bootstrap-vue.js.org/docs/components/form-radio for https://design.gitlab.com/components/radio-buttons/ and https://design.gitlab.com/components/segmented-control
| 2 |
7,071,551 | 16,630,702 |
2018-12-13 12:20:58.363
|
Fix spacing in search box component
|
From https://gitlab.com/gitlab-org/gitlab-ui/issues/93#note_119655757:
For the paddings I currently use the Bootstrap helpers which results in a different spacing than in the design specs:
> I would prefer to have a new css file in gitlab-ce specifically for these kind of use cases, that way it's easier to remove them later on and they aren't scoped to these vue files
> I created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23760 now.
> The padding helper classes are now merged but the existing paddings (for example of `.form-control`) take precedence. :disappointed: Do we want to go down the `!important` route as Bootstrap does? Or should we go with https://gitlab.com/gitlab-org/gitlab-ce/issues/55256?
| 1 |
7,071,551 | 16,239,820 |
2018-11-30 11:58:26.931
|
Add bootstrap-vue`s Breadcrumb component
|
Wrap the component from here https://bootstrap-vue.js.org/docs/components/breadcrumb/
| 2 |
7,071,551 | 15,869,192 |
2018-11-15 11:14:21.875
|
Create a search / filter input field component
|
We need a new component that follows the criteria of "Search by typing" from https://design.gitlab.com/components/search:
> - The search action is triggered immediately after users start typing
> - a spinner is added in the right corner of the search box
> - A clear icon appears in the right corner when the search box contains content and there is no search activity happening in the background
> - Clicking the clear icon removes the content, focuses the input field (if not already), and hides itself
> - A magnifying glass icon is placed in the left corner of the search box
> - The placeholder in a search box should ideally be just “Search”
design specs: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/search-spec-previews/
| 3 |
7,071,551 | 15,868,541 |
2018-11-15 10:49:16.907
|
Wrap Vue bootstrap dropdown components
|
The following components from https://bootstrap-vue.js.org/docs/components/dropdown need to be wrapped:
- [x] `<b-dropdown>`
- [x] `<b-dropdown-item>`
- [x] `<b-dropdown-item-button>`
- [x] `<b-dropdown-header>`
- [x] `<b-dropdown-divider>`
| 5 |
7,071,551 | 15,795,769 |
2018-11-13 14:22:58.115
|
Create avatar component
|
Migrate existing or create new avatar component in gitlab-ui.
Design documentation to be added via https://gitlab.com/gitlab-org/design.gitlab.com/issues/129. Documented avatar sizes can be found at https://gitlab.com/gitlab-org/gitlab-design/issues/196
Should leverage vue-bootstrap where possible, such as rounding corners: https://bootstrap-vue.js.org/docs/components/image. Perhaps it should wrap `b-img`?
| 3 |
7,071,551 | 14,665,658 |
2018-10-03 21:03:47.560
|
Move package to new npm namespace
|
Now that we've reclaimed the `@gitlab` namespace in npm, let's rename our packages.
1. Update the namespace from `@gitlab-org` to `@gitlab`.
2. Update the package from `gitlab-ui` to just `ui`, since the namespace makes this redundant.
Ultimately we can change our package imports in gitlab-ce like so:
```javascript
// old
import { ProgressBar } from '@gitlab-org/gitlab-ui';
// new
import { ProgressBar } from '@gitlab/ui';
```
Let's also make sure we deprecate the old package namespace with `npm deprecate`. This will place a friendly warning at the top of the npm page, and in the console when a user installs the old package (we need to make sure this warning message doesn't break old GitLab stable branches).
See [jade (renamed to pug)](https://www.npmjs.com/package/jade) as an example of this.
| 3 |
7,071,551 | 14,384,275 |
2018-09-21 19:14:17.028
|
Follow up from the link component
|
In order to preserve the `rel` attribute state, this is required to do
https://gitlab.com/gitlab-org/gitlab-ui/merge_requests/39#note_103511198
Also for href's which target the same domain, we might not want to set the `rel` attribute with `noreferrer noopener`
| 2 |
7,071,551 | 14,324,673 |
2018-09-20 05:44:11.873
|
Toggle > Add to gitlab-ui
|
- Add a new button with on, off, and loading state.
- Can have **label** (above) and **help text** (below), using the existing [`form-group` component](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-form-form-group--default)
From the comments we are going to roll our own based on [our current implementation](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/toggle_button.vue)
| 2 |
7,071,551 | 14,034,828 |
2018-09-10 14:11:59.549
|
Move skeleton loading container from gitlab-ce to gitlab-ui
|
Move https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/skeleton_loading_container.vue to gitlab-ui
| 2 |
7,071,551 | 14,034,744 |
2018-09-10 14:09:20.593
|
Move loading icon from CE to gitlab-ui
|
Move https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/loading_icon.vue to gitlab-ui
| 2 |
7,071,551 | 14,034,604 |
2018-09-10 14:03:55.615
|
Add Text Button
|
Create a wrapped component using bootstrap-vue's button that only works for text.
This should also include button links (html that renders href but visually looks like buttons)
| 5 |
7,071,551 | 14,034,558 |
2018-09-10 14:01:48.101
|
Add Bootstrap Vue's links
|
Add https://bootstrap-vue.js.org/docs/components/link to gitlab-ui
| 4 |
7,071,551 | 85,278,252 |
2021-04-15 22:57:41.609
|
F/u/f gitlab!59537: Add needed CSS utility classes
|
Moves the needed CSS utility classes from the `gitlab` codebase to the `gitlab-ui` codebase as part of the cleanup of [the “Highlight Paid Features During Active Trial” experiment](https://gitlab.com/groups/gitlab-org/-/epics/4721) (clean-up issue yet to be made).
The following utility classes need to be migrated over:
```scss
.gl-order-1 {
order: 1;
}
.gl-sm-order-init {
@media (min-width: $breakpoint-sm) {
order: initial;
}
}
.gl-xs-ml-3 {
@media (max-width: $breakpoint-sm) {
@include gl-ml-3;
}
}
.gl-sm-mr-3 {
@media (min-width: $breakpoint-sm) {
@include gl-mr-3;
}
}
```
| 1 |
7,071,551 | 85,228,948 |
2021-04-15 08:18:13.357
|
Allow only safe urls in GlButton
|
### Proposal
[GlButton](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/button/button.vue) component should accept only secure and valid URLs. This means that it should prevent `javascript://` links.
* should allow URLs only with the following protocols (http, https, ftp, mailto)
* should take care of encoded URIs
* should render as `span` tag when the `href` is unsafe
[`GlSafeLinkDirective`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/directives-safe-html-directive--default) can be used for that purpose.
Since GitLab also relies on data URLs in some cases, we'll want to provide a way to set "unsafe" URLs that will skip the sanitization step. An idea would be to expose an `unsafe-url` prop.
### Why
The javascript links can lead to cross-site scripting bugs. For example, https://gitlab.com/gitlab-org/gitlab/-/issues/212630. It has been fixed by validating the zoom meeting links which should fix this particular security issue. However, other `GlButton` usages are still vulnerable if we miss any such validations.
### Related Issues
- [Allow only safe urls in GlLink](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/823)
- [Preventing URL Injection](https://gitlab.com/gitlab-org/gitlab/-/issues/219124#prevent-url-injection)
- [XSS Retrospective](https://gitlab.com/gitlab-org/gitlab/-/issues/327824)
| 2 |
7,071,551 | 84,613,078 |
2021-04-04 21:04:58.776
|
Safe Html v-safe-html Documentation Confusion
|
Sorry I'm not overly familiar with the project (gitlab-ui) and the documentation etc but there are a few things that strike me as odd:
https://gitlab-org.gitlab.io/gitlab-ui/?path=/docs/directives-safe-html-directive--default
Renders the example like:
So the `<img` tag is actually being rendered? Isn't the entire purpose of `v-safe-html` to NOT render HTML?
I also find it slightly niggling at my OCD that the example https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/directives/safe_html/examples/safe_html.basic.example.vue has a few subtle differences from that https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/directives/safe_html/safe_html.md
Should we align them? And/or is there an effort to prevent the need to duplicate the examples?
Thanks!
| 1 |
7,071,551 | 82,139,816 |
2021-04-01 18:05:11.288
|
Enable smooth scrolling in Safari
|
## Context
The following discussion from !2067 should be addressed:
- [ ] @pslaughter started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2067#note_542567216): (+2 comments)
> **issue (ux, safari):** Unfortunately, it looks like the `scrollTo` with options is not supported by Safari ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollTo#browser_compatibility)), which I believe is one of our support browsers...
>
> 
>
> WDYT @jareko & @fguibert? You'll also notice the gradient blur isn't quite working the way we expect here :disappointed:
>
> @fguibert, if needed we might also have a smooth scroll function in GitLab which has some polyfilled support :thinking:
Our list of supported browsers changed in %15.2: https://docs.gitlab.com/ee/update/removals.html#support-for-older-browsers. So it looks like we only need to worry about Safari >=14.1.
| 3 |
7,071,551 | 81,933,792 |
2021-03-30 14:22:28.732
|
GlAvatar: size validator fails for valid values
|
In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2102 we introduced some custom logic in `GlAvatar`'s `size` prop validator to log a more helpful error message when the provided size is invalid. A conditional was unfortunately reversed, which resulted in errors being thrown for any valid value.
| 1 |
7,071,551 | 81,672,516 |
2021-03-25 21:24:48.829
|
Form select > Validation > Remove background image icon
|
On select fields, we should remove the background image icon that appears on validations (red explanation mark in circle)
| 1 |
7,071,551 | 81,672,460 |
2021-03-25 21:22:43.620
|
Form inputs > Validation > Correct resting state
|
From https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2107#note_538237248, resting states of our form validations should utilize `red-400` for the border color. `red-500` should be used on hover/focus. Currently `red-500` is being used for all states.
| 1 |
7,071,551 | 95,058,282 |
2021-03-22 14:45:44.188
|
Badge > Linked badges > Make examples in Pajamas the SSoT
|
## Problem
Embedded badge examples in Pajamas are different from GitLab UI. Having a SSoT will help accurately complete the badge accessibility audit https://gitlab.com/groups/gitlab-org/-/epics/5664.
| **Pajamas** | **GitLab UI** |
| ------ | ------ |
|  |  |
## Solution
Ensure badge examples align with the [badge design specs](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=425%3A3) and that action badges dont underline text on hover.
| 2 |
7,071,551 | 81,191,940 |
2021-03-18 14:15:31.549
|
Migrate base/form/form_group stories to Component Story Format
|
Migrate `base/form/form_group` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [ ] Migrated or removed examples.
- [ ] Migrated props, slots and events documentation.
- [ ] If needed, migrated the `bootstrapComponent` parameter.
- [ ] Cleanup
- [ ] Component's README:
- [ ] Removed `<!-- STORY -->`.
- [ ] Removed component's title.
- [ ] `documentation/documented_stories.js`:
- [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,949 |
2021-03-18 14:15:31.497
|
Migrate charts/line stories to Component Story Format
|
Migrate `charts/line` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [ ] Migrated or removed examples.
- [ ] Migrated props, slots and events documentation.
- [ ] If needed, migrated the `bootstrapComponent` parameter.
- [ ] Cleanup
- [ ] Component's README:
- [ ] Removed `<!-- STORY -->`.
- [ ] Removed component's title.
- [ ] `documentation/documented_stories.js`:
- [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,912 |
2021-03-18 14:15:31.461
|
Migrate charts/legend stories to Component Story Format
|
Migrate `charts/legend` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [ ] Migrated or removed examples.
- [ ] Migrated props, slots and events documentation.
- [ ] If needed, migrated the `bootstrapComponent` parameter.
- [ ] Cleanup
- [ ] Component's README:
- [ ] Removed `<!-- STORY -->`.
- [ ] Removed component's title.
- [ ] `documentation/documented_stories.js`:
- [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,901 |
2021-03-18 14:15:30.995
|
Migrate base/navbar stories to Component Story Format
|
Migrate `base/navbar` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,902 |
2021-03-18 14:15:30.922
|
Migrate utilities/intersection_observer stories to Component Story Format
|
Migrate `utilities/intersection_observer` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [ ] Migrated or removed examples.
- [ ] Migrated props, slots and events documentation.
- [ ] If needed, migrated the `bootstrapComponent` parameter.
- [ ] Cleanup
- [ ] Component's README:
- [ ] Removed `<!-- STORY -->`.
- [ ] Removed component's title.
- [ ] `documentation/documented_stories.js`:
- [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,948 |
2021-03-18 14:15:30.768
|
Migrate base/toggle stories to Component Story Format
|
Migrate `base/toggle` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,950 |
2021-03-18 14:15:30.755
|
Migrate base/tooltip stories to Component Story Format
|
Migrate `base/tooltip` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [x] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [x] Migrated or removed examples.
- [x] Migrated props, slots and events documentation.
- [x] If needed, migrated the `bootstrapComponent` parameter.
- [x] Cleanup
- [x] Component's README:
- [x] Removed `<!-- STORY -->`.
- [x] Removed component's title.
- [x] `documentation/documented_stories.js`:
- [x] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,915 |
2021-03-18 14:15:30.673
|
Migrate regions/empty_state stories to Component Story Format
|
Migrate `regions/empty_state` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,974 |
2021-03-18 14:15:30.656
|
Migrate base/tabs stories to Component Story Format
|
Migrate `base/tabs` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [ ] Migrated or removed examples.
- [ ] Migrated props, slots and events documentation.
- [ ] If needed, migrated the `bootstrapComponent` parameter.
- [ ] Cleanup
- [ ] Component's README:
- [ ] Removed `<!-- STORY -->`.
- [ ] Removed component's title.
- [ ] `documentation/documented_stories.js`:
- [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,955 |
2021-03-18 14:15:30.640
|
Migrate base/button stories to Component Story Format
|
Migrate `base/button` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,967 |
2021-03-18 14:15:30.580
|
Migrate base/path stories to Component Story Format
|
Migrate `base/path` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [x] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [x] Migrated or removed examples.
- [x] Migrated props, slots and events documentation.
- [x] If needed, migrated the `bootstrapComponent` parameter.
- [x] Cleanup
- [x] Component's README:
- [x] Removed `<!-- STORY -->`.
- [x] Removed component's title.
- [x] `documentation/documented_stories.js`:
- [x] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,925 |
2021-03-18 14:15:30.551
|
Migrate base/token stories to Component Story Format
|
Migrate `base/token` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,972 |
2021-03-18 14:15:30.548
|
Migrate base/progress_bar stories to Component Story Format
|
Migrate `base/progress_bar` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,926 |
2021-03-18 14:15:30.548
|
Migrate utilities/sprintf stories to Component Story Format
|
Migrate `utilities/sprintf` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,939 |
2021-03-18 14:15:30.546
|
Migrate base/dropdown stories to Component Story Format
|
Migrate `base/dropdown` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [ ] Migrated or removed examples.
- [ ] Migrated props, slots and events documentation.
- [ ] If needed, migrated the `bootstrapComponent` parameter.
- [ ] Cleanup
- [ ] Component's README:
- [ ] Removed `<!-- STORY -->`.
- [ ] Removed component's title.
- [ ] `documentation/documented_stories.js`:
- [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,956 |
2021-03-18 14:15:30.546
|
Migrate utilities/friendly_wrap stories to Component Story Format
|
Migrate `utilities/friendly_wrap` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [x] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [x] Migrated or removed examples.
- [x] Migrated props, slots and events documentation.
- [x] If needed, migrated the `bootstrapComponent` parameter.
- [x] Cleanup
- [x] Component's README:
- [x] Removed `<!-- STORY -->`.
- [x] Removed component's title.
- [x] `documentation/documented_stories.js`:
- [x] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,891 |
2021-03-18 14:15:30.539
|
Migrate charts/chart stories to Component Story Format
|
Migrate `charts/chart` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,895 |
2021-03-18 14:15:30.532
|
Migrate base/datepicker stories to Component Story Format
|
Migrate `base/datepicker` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
- [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
- [ ] Migrated or removed examples.
- [ ] Migrated props, slots and events documentation.
- [ ] If needed, migrated the `bootstrapComponent` parameter.
- [ ] Cleanup
- [ ] Component's README:
- [ ] Removed `<!-- STORY -->`.
- [ ] Removed component's title.
- [ ] `documentation/documented_stories.js`:
- [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,191,528 |
2021-03-18 14:12:04.577
|
Migrate regions/dashboard_skeleton stories to Component Story Format
|
Migrate `regions/dashboard_skeleton` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 81,190,918 |
2021-03-18 14:07:21.943
|
Migrate base/alert stories to Component Story Format
|
Migrate `base/alert` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
Follow the steps described in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 80,701,091 |
2021-03-11 09:21:01.974
|
Form: Add GlFormInvalidFeedback Component
|
https://bootstrap-vue.org/docs/components/input-group#input-groups
> Bootstrap v4 currently does not support contextual state styling (i.e. valid or invalid) of input groups. However, the inputs inside the input group do support contextual state.
So we end up having something like this:
| GlFormInputGroup | Other form input (for comparison) |
| ------ | ------ |
|  |  |
## Problem: No feedback message shown
We use the general sibling selector `~` to display the invalid feedback message, like this:
<img src="/uploads/2cf3f585f86b103e8e99f4a79379e69e/image.png" height=300px>
However, this doesn't work for `GlFormInputGroup` because the HTML structure is different. So the general sibling selector doesn't work here.
<img src="/uploads/2d4192a16796778a69490f7fc28e5834/image.png" height=300px>
## Proposal
Let's ensure the feedback is displayed, so it looks like this:
## Solution
Alternatively, we can just use the `b-form-invalid-feedback` > https://bootstrap-vue.org/docs/components/form#comp-ref-b-form-invalid-feedback
It was suggested here > https://github.com/bootstrap-vue/bootstrap-vue/issues/1251#issuecomment-340065341
(So instead of doing some funky css magic, I think this is the best route to take. I've tested it locally and it works perfectly 👍)
## Follow-up
~~1. We might also want to consider look into changing the default message if it's a `<select>` field. As the user doesn't "fill", it "selects". So a more appropriate default message could be: `Please select an option`.~~
A sibling component would be the `gl-form-valid-feedback`, we might want to also consider creating a follow-up issue to ensure that's available in PJ 👍
## Note
This issue was created as a follow-up to MR > https://gitlab.com/gitlab-org/gitlab/-/merge_requests/55838
| 3 |
7,071,551 | 80,620,276 |
2021-03-10 09:40:00.271
|
Update GlFormGroup stylings to be aligned with Pajamas
|
### Context
The following discussion from !55728 should be addressed:
- [x] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/55728#note_525469956): (+1 comment)
> **thought:** Having to manually add this margin might indicate that the GitLab UI component might not be following Pajamas specifications :thinking: Do you think that there some change we could do in GitLab UI to make this more consistent?
### Proposal
We should add necessary margins for labels in GlFormGroup and make sure it conforms with ~Pajamas.
### Implementation Plan
- [x] Tweak form styling in GitLab UI, something very similar to [this](https://gitlab.com/gitlab-org/gitlab-ui/blob/15e9c17724049fdf26acb11abc67ff5d87cb1cb5/src/components/base/form/form_group/form_group.scss#L21), as per [suggestion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/55728#note_525469956)
- [x] Remove the `gl-mt-3` class from the gitlab codebase
- [x] This should apply for `<gl-form-text class="gl-mt-3">` elements
- [x] Make sure it affects only the field labels
| 2 |
7,071,551 | 80,480,173 |
2021-03-08 15:03:58.760
|
Add `gl-focus-outline-none:focus` utility class
|
### Problem to solve
The GitLab application has several instances of Bootstrap Vue's `bv-no-focus-ring` class.
GitLab issue: https://gitlab.com/gitlab-org/gitlab/-/issues/296949
### Proposed solution
Add a new utility class to replicate `bv-no-focus-ring`'s style.
```css
.bv-no-focus-ring:focus {
outline: none;
}
.gl-focus-outline-none:focus {
outline: none;
}
```
| 1 |
7,071,551 | 80,332,539 |
2021-03-05 13:01:26.672
|
Add character count support to GlFormTextarea
|
### Proposal
Add character counter to `form-textarea` component which should conform the design specs at https://design.gitlab.com/components/form/#character-counter
- This can be added by using a prop `counter`
| specs | example usage |
| ------ | ------ |
|  |  |
| 1 |
7,071,551 | 80,083,748 |
2021-03-02 11:48:00.240
|
Instant Load Directive
|
As we want to leverage a preloading trick in our Vue apps where you already start loading when the mouse hovers over an element. This issue is about creating an Directive that makes it easy to use that technique in the future.
* Call function after a debounced delay of 100ms
Base version was implemented in POC in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/52912/diffs#diff-content-733c824a6df375caae37ccea0ce422a3f384f4d8
| 3 |
7,071,551 | 79,802,162 |
2021-02-25 12:41:17.795
|
Vue Test Utils: migrate usages of find/findAll to findComponent/findAllComponents where applicable
| null | 2 |
7,071,551 | 79,582,543 |
2021-02-22 19:57:03.273
|
Rich Text Editor: Set up test environment
|
The Rich Text Editor edits HTML produced by the [Markdown API endpoint](https://docs.gitlab.com/ee/api/markdown.html).
<img src="/uploads/ff57cab6e332b65fc56dd42aa4c01aa2/image.png" width="25%" />
We have to make sure to catch disparities between the API output and the Rich Text Editor’s assumptions about this output. For this purpose, we want to create a test environment where fixtures are generated for each type of content supported by the editor using the Markdown API endpoint.
We also want to define testing patterns to verify the accuracy of Markdown generation and testing TipTap extensions.
## Tasks
- [ ] [MR: Set up test fixtures for Rich Text Editor](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2070) - This MR is simply a first iteration of proving we can call the API and generate a file.
- [ ] Add support for generating fixtures and committing the files to git to the CI pipeline config.
- [ ] Add initial Bold extension test that uses the generated fixture.
- [ ] Document how to create a new test fixture.
## Context
See for a big picture of the Rich Text Editor development: https://gitlab.com/gitlab-org/gitlab/-/issues/321442
| 3 |
7,071,551 | 79,580,883 |
2021-02-22 19:33:45.337
|
Rich Text Editor: Create rich text editor component directory and storybook section
|
Create a new component directory for the Rich Text Editor. The Rich Text Editor will contain the following types of artifacts
- Vue components
- Documentation
- TipTap extensions
- Markdown serializers.
## Context
See for a big picture of the Rich Text Editor development: https://gitlab.com/gitlab-org/gitlab/-/issues/321442
| 1 |
7,071,551 | 79,580,562 |
2021-02-22 19:26:28.242
|
Rich Text Editor: Add TipTap and ProseMirror dependencies to GitLab UI
|
## Proposal
Add ProseMirror and TipTap dependencies to GitLab UI. The editor team will use these dependencies to implement a Rich Text Editor component.
## License compatibility
TipTap and ProseMirror have compatible licenses with GitLab. See https://gitlab.com/gitlab-org/gitlab/-/issues/231725#note_413595037 for more information.
## Requirements
We have to include the Rich Text Editor 3rd party dependencies in the GitLab application while meeting the following expectations
### Performance
- We want to load these dependencies asynchronously.
- If the dependencies are not updated, we want to maintain them in the web browser’s cache.
To meet this expectation, the bundle where the dependencies is distributed should be independent from the bundle where the Rich Text Editor is located. The reason is that we will update the Rich Text Editor more often than its dependencies.
### Smooth transition to TipTap v2
The methodology we use to load the dependencies should not become a hindrance for the transition from TipTap 1 to TipTap 2 (currently in private development).
To meet this expectation. We should be aware of the differences between TipTap 1 and TipTap 2 distribution. [TipTap 1 groups all its dependencies](https://tiptap.dev/docs/guide/editor.html) and core components in two packages: `tiptap` and `tiptap-extensions`.
```html
<script>
import { Editor, EditorContent } from 'tiptap';
import { Bold } from 'tiptap-extensions';
export default {
components: {
EditorContent,
},
data() {
return {
editor: new Editor({
content: '<p>Initial editor content</p>',
extensions: [
new Bold(),
],
})
}
},
beforeDestroy() {
this.editor.destroy()
},
}
</script>
<template>
<editor-content :editor="editor" />
</template>
```
TipTap 2 distributes extensions and Vue components in different packages.
```javascript
import { Editor } from '@tiptap/core'
import Document from '@tiptap/extension-document'
import Paragraph from '@tiptap/extension-paragraph'
import Text from '@tiptap/extension-text'
new Editor({
element: document.querySelector('.element'),
extensions: [
Document,
Paragraph,
Text,
],
content: '<p>Example Text</p>',
autofocus: true,
editable: true,
injectCSS: false,
})
```
## Implementation guide
- Encapsulate the responsibility of loading tiptap packages in a single factory function. The advantage of putting all import calls in a single place is that we will only have to replace TipTap 1 packages with TipTap 2 packages in that location.
- Put all tiptap packages in the same bundle using [webpack module methods](https://webpack.js.org/api/module-methods/)
## Context
See for a big picture of the Rich Text Editor development: https://gitlab.com/gitlab-org/gitlab/-/issues/321442
| 1 |
7,071,551 | 80,504,754 |
2021-02-15 17:21:31.530
|
[VSA] Fix stage shape outline and active shape
|
### Problem
- Path component has a slight 1px bump and isn't completely rounded on the pointy part of a stage... this keeps me up at night.
- Path component active highlight is a bit strange too
| Imperfect rounding | Active |
| ------ | ------ |
|  |  |
### Proposal
1. Fix the pixel bump
1. Make active state the same shape as stage outline
| 1 |
7,071,551 | 78,986,543 |
2021-02-12 16:45:49.135
|
Toast > Accessibility Audit
|
Refer to the [parent epic description](https://gitlab.com/groups/gitlab-org/-/epics/5387) for more information on this effort.
## Purpose
Audit the accessibility of the GitLab UI Toast component in all variants and states in order to update the Pajamas component [Status table](https://design.gitlab.com/components/status), and provide more documentation on the component’s page in Pajamas.
## Component description
A toast displays a short system message as a result of a user's action.
## Methods and Tools
Review the [initial testing methods in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#initial-methods-and-tools). List the testing methods used for your audit below, including any additional testing methods needed for this component that is not listed in the parent epic.
* Evaluate all of the [toast](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-toast--default) variants and options in GitLab UI.
* Visual review for contrast and states.
* Semantic and functional review that assumes a [status](https://www.w3.org/TR/wai-aria-1.2/#status) role.
* Screen reader: VoiceOver + Safari on macOS
* Screen reader: NVDA + Chrome on Windows
* axe DevTools extension in browser) variants and configurations in GitLab UI.
## Audit Criteria
Review the [general audit criteria in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#audit-criteria). Add applicable criteria to this section, including any additional criteria needed for this component that is not listed in the parent epic. **A check indicates that the audit has been performed, not that it passes.**
* [x] [WCAG SC 2.2.1 Timing Adjustable](https://www.w3.org/TR/WCAG21/#timing-adjustable) (level A) must be satisfied. See [how to meet timing adjustable](https://www.w3.org/WAI/WCAG21/quickref/#timing-adjustable).
* [x] If the toast message is considered a status (`role="status"`) then it should have no interactive content within. As a live region, semantics are lost and the content is read as a single string. For example, if the current toast was a status it would be announced as "Undo. Close. This is a toast message."
* [x] If a critical message or action was referenced in a toast, it should be available permanently on the page as well.
* [x] A toast shouldn't receive focus.
* [x] All content is presented in text or with a text equivalent. For example, alt text for SVG, or `aria-label` for icons that have meaning or perform actions.
* [x] There should be no negative impact to a user or the experience if a toast is missed.
* [x] Color combinations have [sufficient contrast](https://design.gitlab.com/product-foundations/colors#accessibility).
## Resources
- [Defining 'Toast' Messages](https://adrianroselli.com/2020/01/defining-toast-messages.html), by Adrian Roselli
- [A toast to an accessible toast…](https://www.scottohara.me/blog/2019/07/08/a-toast-to-a11y-toasts.html), by Scott O'Hara
## Results
### Summary
After research, `role="status"` seems to be the best fit for a pattern, which will assume certain expectations and requirements for timing and function. [This example](https://scottaohara.github.io/tests/html-output/toastput-aria.html) seems to be the best reference for behavior (although the example mentions updates to make it more robust).
| **Problem** | **Solution** | **Related Issue/MR** |
| ----------- | ------------ | -------------- |
| Toast is using `role="alert"` and `aria-live="assertive"`. | Only use `role="status"` which has an implicit value of `aria-live="polite"`. | TBD |
| Toast is placed near the bottom of the DOM, making it difficult to move focus there fast enough to access the controls. | Don't include actions (link, button) within the toast message. | TBD |
| Toast can have critical actions in it. For example, "Undo". I think this would be a failure of WCAG SC 2.2.1 Timing Adjustable, since a user couldn't adjust timing to access critical functionality. The toast doesn't (and shouldn't) receive focus, so again, anything interactive within the toast isn't easily accessed. | Don't include actions (link, button) within the toast message. | TBD |
| Close button is before the toast content in the DOM, so it get's announced first. | Keep the close button outside of the `role="status"` and place at the end. | TBD |
| [Toast guidelines](https://design.gitlab.com/components/toast) promote including an action. | Update guidelines to not include an action. | TBD |
## Completing the audit
After the solutions have been explored and applied, review the [completing the audit section in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#completing-the-audit). Complete all items prior to closing this issue.
~accessibility ~"Category:FE/UX Foundations" ~"component:toast"
| 5 |
7,071,551 | 78,986,541 |
2021-02-12 16:45:48.928
|
Table > Accessibility Audit
|
Refer to the [parent epic description](https://gitlab.com/groups/gitlab-org/-/epics/5387) for more information on this effort.
## Purpose
Audit the accessibility of the GitLab UI Table component in all variants and states in order to update the Pajamas component [Status table](https://design.gitlab.com/components/status), and provide more documentation on the component’s page in Pajamas.
## Component description
Tables display tabular data in a basic grid composed of cells, columns, and rows. This format makes it easy for users to scan and compare large amounts of data. Tables are not for layout.
## Methods and Tools
Review the [initial testing methods in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#initial-methods-and-tools). List the testing methods used for your audit below, including any additional testing methods needed for this component that is not listed in the parent epic.
* Evaluate all of the [table](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-table-table--default) variants and configurations in GitLab UI.
* Visual review for contrast and states.
# Semantic and functional review for tables using the `<table>` element.
* Semantic and functional review for tables not using the `<table>` element align with [WAI-ARIA Authoring Practices for tables](https://www.w3.org/TR/wai-aria-practices/#table) (if present).
* Keyboard only
* Screen reader: VoiceOver + Safari on macOS
* Screen reader: NVDA + Chrome on Windows
* axe DevTools extension in browser
## Audit Criteria
Review the [general audit criteria in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#audit-criteria). Add applicable criteria to this section, including any additional criteria needed for this component that is not listed in the parent epic. A check indicates that the audit has been performed, not that it passes.
* [ ] All actions and functionality can be done with a [keyboard](https://design.gitlab.com/accessibility-audits/2-keyboard-only).
* [ ] Color combinations have [sufficient contrast](https://design.gitlab.com/product-foundations/colors#accessibility).
* [ ] Table heading, column, and row relationships are clearly defined and communicated with the correct scope.
* [ ] Tables include a `caption` or are directly preceded by a heading (a `caption` is preferred).
## Results
| **Problem** | **Solution** | **Related MR** |
| ----------- | ------------ | -------------- |
| Some ARIA attributes and roles are either unnecessary or not allowed on a `<table>` and sub elements. | Evaluate each ARIA attribute a/role and either remove or document correct use. | TBD |
| No `<caption>` element is present to explain the table's purpose. | Include a `<caption>` element that describes the purpose of the table. | TBD |
| The ability to select a row interferes with expected behavior. `tab-index="0"` shouldn't be used at all here. | Introduce plain table examples and document requirements of expected behavior for selectable table elements (if they should exist). | TBD |
| Using literal "column one" and "column two" text in the examples makes testing confusion, since columns are also announced. | Update text in Storybook stories. | TBD |
| Stacked layout has several issues that make it difficult or impossible to use or understand. Including, but not limited to no table headers, pseudo content, and other items that are already mentioned. | Rethink responsive tables and accessible options. | TBD |
| Filter variant unusable in NVDA. | Update filter capabilities, see the [Web Experience Toolkit Tables](https://wet-boew.github.io/v4.0-ci/demos/tables/tables-en.html) for examples. | TBD |
## Completing the audit
After the solutions have been explored and applied, review the [completing the audit section in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#completing-the-audit). Complete all items prior to closing this issue.
## Resources and reference
- [Data Tables](https://inclusive-components.design/data-tables/) by Heydon Pickering
- [Tables, CSS Display Properties, and ARIA](https://adrianroselli.com/2018/02/tables-css-display-properties-and-aria.html#TheTweet) by Adrian Roselli
- [Web Experience Toolkit Tables](https://wet-boew.github.io/v4.0-ci/demos/tables/tables-en.html), great examples of tables with filtering, sorting, and pagination.
~accessibility ~"Category:FE/UX Foundations" ~"component:table"
| 5 |
7,071,551 | 78,986,521 |
2021-02-12 16:45:46.855
|
Dropdown > Accessibility Audit
|
Refer to the [parent epic description](https://gitlab.com/groups/gitlab-org/-/epics/5387) for more information on this effort.
## Purpose
Audit the accessibility of the GitLab UI Dropdown component in all variants and states in order to provide more documentation on the component’s page in Pajamas and address any items that need fixed.
## Initial methods and tools
Review the [initial testing methods in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#initial-methods-and-tools). List the testing methods used for your audit below, including any additional testing methods needed for this component that is not listed in the parent epic.
### Methods
- Visual scan
- Code/semantics review
- Keyboarding text
- Screen reader test
### Tools
- NVDA + Chrome version 92
- VoiceOver + Safari
## Audit criteria
Review the [general audit criteria in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#audit-criteria). Add applicable criteria to this section, including any additional criteria needed for this component that is not listed in the parent epic.
A completed task here indicates that testing has been done, not that the result was passing.
* [x] All actions and functionality can be done with a [keyboard](https://design.gitlab.com/accessibility-audits/2-keyboard-only).
* [x] Links, buttons, and controls have a visible [focus state](https://design.gitlab.com/accessibility-audits/2-keyboard-only#focus-states).
* [x] All content is presented in text or with a text equivalent. For example, alt text for SVG, or `aria-label` for icons that have meaning or perform actions.
* [x] Changes in a component’s state are announced by a screen reader. For example, changing `aria-expanded="false"` to `aria-expanded="true"` when an accordion is expanded.
* [x] Color combinations have [sufficient contrast](https://design.gitlab.com/product-foundations/colors#accessibility).
## Results
**Watch recordings of the audit** (internal)
1. [▶︎ Intro](https://drive.google.com/file/d/1dNbOpgUOJb6s8R8r01gdXU9J9gs2XdQO/view?usp=sharing)
1. [▶︎ Visual scan](https://drive.google.com/file/d/1qCB9-KfC1p-D7ao0QiwzQQMehERZZvUS/view?usp=sharing)
1. [▶︎ Code and semantic review](https://drive.google.com/file/d/1z-Epc8tTuH32PzPq6Pr9jrOqI9KKXbNx/view?usp=sharing)
1. [▶︎ Screen reader demo](https://drive.google.com/file/d/12K20wzxrMuMrAq4T4HNXC_MiDXhE8NlO/view?usp=sharing)
| **Problem** | **Solution** | **Related Issue/MR** |
| ----------- | ------------ | -------------- |
| From the visual scan, I don't think there are any large issues, but I would like to consider the focus ring in general based on potential forthcoming WCAG updates. [This article](https://www.sarasoueidan.com/blog/focus-indicators/) summarizes it well. | Explore global updates to the focus ring. | |
| In general, the way the dropdown is currently built is too prescriptive to a _menu_ and is not appropriate for all of the [use cases](https://design.gitlab.com/components/dropdown#usage) a dropdown should support. This will be explained further in the related issue. There are also issues with the code semantics/structure of the current dropdown. | Provide examples of different types of dropdowns, along with semantic differences, that support each type of use case. | |
## Completing the audit
After the solutions have been explored and applied, review the [completing the audit section in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#completing-the-audit). Complete all items prior to closing this issue.
~accessibility ~"Category:FE/UX Foundations" ~"component:dropdown"
| 3 |
7,071,551 | 78,986,515 |
2021-02-12 16:45:46.144
|
Broadcast message > Accessibility Audit
|
Refer to the [parent epic description](https://gitlab.com/groups/gitlab-org/-/epics/5387) for more information on this effort.
## Purpose
Audit the accessibility of the GitLab UI Broadcast Message component in all variants and states in order to update the Pajamas component [Status table](https://design.gitlab.com/components/status), and provide more documentation on the component’s page in Pajamas.
## Component Description
A banner promotes awareness of a new feature or high-priority research initiative.
## Methods and Tools
Review the [initial testing methods in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#initial-methods-and-tools). List the testing methods used for your audit below, including any additional testing methods needed for this component that is not listed in the parent epic.
- Evaluate all of the [broadcast message](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-broadcast-message--default) variants in GitLab UI.
* Visual review for contrast and states.
* Semantic and functional review
* Keyboard only
* Screen reader: VoiceOver + Safari on macOS
* Screen reader: NVDA + Chrome on Windows
* axe DevTools extension in browser
## Audit Criteria
Review the [general audit criteria in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#audit-criteria). Add applicable criteria to this section, including any additional criteria needed for this component that is not listed in the parent epic. **A check indicates that the audit has been performed, not that it passes.**
* [x] All actions and functionality can be done with a [keyboard](https://design.gitlab.com/accessibility-audits/2-keyboard-only).
* [x] Color combinations have [sufficient contrast](https://design.gitlab.com/product-foundations/colors#accessibility).
* [x] Broadcast is easily discoverable with screen reader. Since navigating headings is by far the most common way to find information ([source](https://webaim.org/projects/screenreadersurvey9/#finding)), and a broadcast message is static content on page load, and deemed important, it should probably have a meaningful heading.
## Results
| **Problem** | **Solution** | **Related Issue/MR** |
| ----------- | ------------ | -------------- |
| `role="alert"` is used, but per [WAI-ARIA Authoring Practices](https://www.w3.org/TR/wai-aria-practices/#alert) "It is important to note that, at this time, screen readers do not inform users of alerts that are present on the page before page load completes." | Remove `role="alert"` since it's not the correct use here for static content present on page load. | TBD |
| No heading in broadcast message. As-is, without the broadcast being announced on page load, it's only discoverable when reading through the page content. | Since navigating headings is by far the most common way to find information ([source](https://webaim.org/projects/screenreadersurvey9/#finding)), and a broadcast message is static content on page load, and deemed important, it should probably have a meaningful heading. | TBD |
## Completing the audit
After the solutions have been explored and applied, review the [completing the audit section in the parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5387#completing-the-audit). Complete all items prior to closing this issue.
~accessibility ~"Category:FE/UX Foundations" ~"component:broadcast-message"
| 2 |
7,071,551 | 78,673,875 |
2021-02-08 21:49:04.263
|
Remove examples templates and start transition to Component Story Format
|
Prevent new component examples from being added and update stories template to produce Component Story Format compatible stories.
| 2 |
7,071,551 | 78,323,869 |
2021-02-03 00:46:30.674
|
Upgrade Vue Test Utils to latest version
|
Upgrade VTU to v1.1.2
| 1 |
7,071,551 | 78,497,535 |
2021-01-29 15:57:20.645
|
Component: Single Stat [Animation]
|
## Problem
- Single Stats are often used with filters
- Sometimes it is not always clear whether the filter has been applied to Single Stats (and other components like tables)
## Proposal
- Introduce a `counting number` transition to the Single Stat when a filter has been applied and it is changing from one value to the next
- This will provide a signifier that the filter has been applied and look pretty slick
- Out o scope (done in separate issues): Apply to Value Stream Analytics (group-level) and Merge Request Analytics
See Tesla example...
| 3 |
7,071,551 | 77,692,058 |
2021-01-22 15:13:58.023
|
Date picker: add alert to component
|
## Problem
Our [date picker](https://app.mural.co/t/gitlab2474/m/gitlab2474/1611148388781/3710a8c5ca11221336e5c17ea6ac084d6677e767?wid=0-1611326570640) currently doesn't have a way of signalling if there are any data limits.
This has led to this (rather inelegant) solution in MR analytics & VSA which occupies a lot of horizontal space in the filter bar...
## Proposal
Provide an option for an alert within the date picker component. This provides some "feed-forward" advice for users.
| Proposal | Clubhouse example |
| ------ | ------ |
|  |  |
| 2 |
7,071,551 | 77,564,782 |
2021-01-20 18:13:13.746
|
GlTokenSelector: Add a `textInputAttrs` prop
|
When writing feature specs and E2E QA specs the text input needs to be filled in. To do this it is preferable to add a `data-qa-selector` attribute to the text input. This currently isn't possible. Adding a `textInputAttrs` prop would make this possible.
| 1 |
7,071,551 | 77,463,525 |
2021-01-19 10:31:45.251
|
Badge component: implement 12px icon variant
|
# Problem
- From: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/785
- New 12px badge variant (for small and medium) has been created in [Figma](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=19947%3A329)
# Proposal
1. Implement new variant in GitLab-UI: leverages 12px badge size and different padding
1. Update single stat component to use this variation of the badge
| small | medium |
| ------ | ------ |
|  |  |
| 2 |
7,071,551 | 77,317,273 |
2021-01-15 22:59:12.717
|
Duplicated stories for area and line charts
|
There are duplicated stories in the following files:
* `src/components/charts/line/line.stories.js`
* `src/components/charts/area/area.stories.js`
They both define a `with annotations as option series` two times. Let's remove the ones we don't need, or rename them if we want to keep them all.
| 1 |
7,071,551 | 77,123,919 |
2021-01-12 22:04:26.551
|
Use GlButton to close Toast
|
## Problem
The Toast component uses a plain anchor and should instead use the GlButton.
| 2 |
7,071,551 | 77,083,897 |
2021-01-12 11:55:58.822
|
GlAvatarLabeled: Add <slot> for label and sublabel
|
### Problem to solve
The `GlAvatarLabeled` can only display text for `label` & `sublabel`.
The `label` & `sublabel` need to be customizable to enable the following GitLab admin/users https://gitlab.com/groups/gitlab-org/-/epics/4961 features:
- The `label` is a GlAvatarLink
- The `sublabel` is a mailto link
### Potential solution
Similar to `meta`, add a `<slot>` for both `label` & `sublabel` with default content.
| 1 |
7,071,551 | 76,890,798 |
2021-01-07 16:40:36.078
|
Mention dark mode testing in MR template checklist
|
With GitLab's dark mode being used by more users, we should be cautious about any CSS change that might affect how a component looks in dark mode. Let's add a task to our MR template's checklist to remember to take that into account with every change.
| 0 |
7,071,551 | 76,722,191 |
2021-01-04 21:20:25.152
|
Roulette doesn't take all eligible maintainers into account
|
According to the [handbook](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ui), every frontend engineer is a reviewer of GitLab UI, but not all of then are marked as such in the [`team.yml`](https://gitlab.com/gitlab-com/www-gitlab-com/-/blob/master/data/team.yml). Similarly, not all GitLab maintainers are marked as GitLab UI maintainers. This results in some discrepancies in the reviewers & maintainers lists between GitLab and GitLab UI, as can be seen in https://about.gitlab.com/handbook/engineering/projects/.
For this reason, the reviewers roulette currently pulls data from GitLab's team, which better represents the workforce, but it's not perfect either. For example, I'm myself a maintainer of GitLab UI, but _not_ of GitLab, which means that the roulette still considers me as a reviewer.
Let's review the roulette's logic to improve the reliability of its picks.
| 1 |
7,071,551 | 76,715,643 |
2021-01-04 18:30:50.388
|
Add 'OR' token to filtered-search
|
### Problem To Solve
When filtering issues, I want to filter by ~"group::portfolio management" `OR` ~"group::certify", so that I can see issues that have one `OR` (:rofl:) the other label.
When filtering issues, I want to filter by assignee is @gweaver `OR` @hollyreynolds `OR` @kokeefe, so that I see issues that have...
### Proposal
- Add support for OR between values of a given filterable key within the filter bar.
- Only add support for OR to the `gitlab-ui` filter bar to prevent duplicating effort in parts of the code that need to be refactored to GitLab UI.
### Constraints
- `OR` is limited to individual types of parameters `assignee = me OR you AND label = foo OR bar`, not `assignee = me OR label = foo`
### UI Prototype
https://www.figma.com/proto/7NSXzJaHq5eOtuJ11cOoKC/23532-Using-OR-in-issue-mr-epic-list-views-and-boards?node-id=175%3A1465&viewport=564%2C352%2C0.3289112150669098&scaling=min-zoom
To navigate:
1. Click on filter bar (launches primary options menu)
1. Select Assignee
1. Select `= is`
1. Select names in list. All 3 will auto-select - this is due to a limitation in the prototyping tool. The actual checkbox functionality will work as normal.
1. Click on Assignees list to close
1. Click filter bar again to launch primary options menu again for a new top level selection
### Tier
gitlab~13116818
### Implementation Parts
- [ ] UX for using `OR` on a per parameter basis
- [ ] Frontend
- [ ] Issue Boards Side
<!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION -->
*This page may contain information related to upcoming products, features and functionality.
It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes.
Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.*
<!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION -->
| 3 |
7,071,551 | 76,711,640 |
2021-01-04 17:16:55.347
|
GlDaterangerPicker: flaky visual test
|
`GlDaterangerPicker` properly mocks the month and day, but not the year, which caused its visual tests to fail now that we've switched from 2020 to 2021: https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/943094911
Let's fix this by setting a static year as well.
| 1 |
7,071,551 | 76,704,481 |
2021-01-04 15:10:10.851
|
GlCarousel: flaky visual test
|
`GlCarousel` sometimes [fails](https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/886328002) with some unnoticeable differences that don' seem to be ever caused by any of our changes.
The fact that we're loading images from a remote source to populate the slides might be responsible for those inconsistent results. Let's try storing them locally to see if it helps in the long run.
| 1 |
7,071,551 | 76,561,914 |
2020-12-29 17:00:40.786
|
Scoped labels: scoped text needs visible underline on hover
|
## Problem
The scoped text portion of the label doesn’t have a visible underline when text is reversed (white) on the left, but should, for interactive states.
## Solution
Figma: https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=1531%3A2
| 1 |
7,071,551 | 75,831,887 |
2020-12-09 13:43:47.948
|
Add additional percentage width utility classes
|
We need additional utility classes for percentage widths for https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49551.
`10p` `20p` `40p`
**Proposal**
```
.gl-w-10p {
width: 10%;
}
.gl-w-20p {
width: 20%;
}
.gl-w-40p {
width: 40%;
}
```
| 1 |
7,071,551 | 75,781,681 |
2020-12-08 17:48:18.979
|
GlTab: Misalignment when mixing tabs with and without counters
|
## Problem to solve
When mixing tabs with and without counters it causes the selected border of the tab without a counter to be misaligned.
## Screenshots
## Proposed solution
1. Set `GlTab` to use `display: flex`
2. Add spacing between the label and counter
## Additional notes
_Tested in Chrome Version 86.0.4240.198 (Official Build) (x86_64)._
| 1 |
7,071,551 | 75,714,788 |
2020-12-07 14:44:37.364
|
GlSingleStat: Update component to match the updated Pajamas specs
|
Let's update the `GlSingleStat` component to match https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/739
**Note:** This might result in a breaking change if we decide to change props of the existing component.
| 3 |
7,071,551 | 75,498,048 |
2020-12-02 16:23:43.835
|
GlCarousel: flaky visual test
|
`GlCarousel` sometimes [fails](https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/886328002) with some unnoticeable differences that don' seem to be ever caused by any of our changes.
The fact that we're loading images from a remote source to populate the slides might be responsible for those inconsistent results. Let's try storing them locally to see if it helps in the long run.
| 1 |
7,071,551 | 74,590,767 |
2020-11-18 21:56:01.888
|
Remove (or document) duplicate buttons in tab component
|
#### Background
I was working on [pipeline tabs](https://gitlab.com/gitlab-org/gitlab/-/issues/230728) to our tabs component and noticed we duplicate the buttons on the right, show them on desktop view, and hide them on mobile (where the "mobile" block of buttons appears).
| Desktop | Mobile |
| ------ | ------ |
|  |  |
Before migrating, we are just using the usual classes to change alignment/styling based on screen width. After migrating, the buttons have to be duplicated and then hidden/shown.
#### Questions
- Assuming the above is the design we want to achieve (@tauriedavis is it?), is there another way we could go about this without duplicating code? Is there a way to account for an optional button section within the tab component?
#### What next?
I'm not on the frontend or foundations team so it's not really my call, but here are a few ideas:
1. Leave everything as-is, and continue duplicating the buttons
- if we want to refactor this later, we should keep track of these somehow
- update the tab migration epic to include instructions for duplicating buttons
2. Stop the tab migration altogether and either
- Update the tabs component to account for buttons
OR
- Change the design
cc @agulina @afontaine
| 3 |
7,071,551 | 74,559,453 |
2020-11-18 11:38:39.927
|
GlEmptyState - Image doesn't fill space
|
### Summary
The `GlEmptyState` has a `svgHeight` parameter, but setting it only sets the height. The width doesn't auto fill.
### Screenshots
### Proposed Solution
Set the img class to `gl-max-w-full!`.
| 1 |
7,071,551 | 74,449,025 |
2020-11-16 18:25:19.396
|
Style Accordions component
|
# What
After Accordions being built in https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1066 this will ensure it's styled (~"pajamas::style") properly according to spec:
* [Design specifications](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=3463%3A0)
* [Documentation](https://design.gitlab.com/components/accordions)
| 1 |
7,071,551 | 74,448,864 |
2020-11-16 18:21:40.457
|
Build Accordion component in gitlab-ui
|
# What
There is already an existing component to show/hide content, Collapse.
However, it doesn't follow the Pajamas specification:
* [Design specifications](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=3463%3A0)
* [Documentation](https://design.gitlab.com/components/accordions)
| 2 |
7,071,551 | 74,342,086 |
2020-11-13 19:05:36.991
|
Remove visual_gitlab_integration CI job
|
We [recently](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1762) had to allow the `visual_gitlab_integration` job to fail when it started failing for no obvious reason.
While this job has been useful to prevent some CSS leak issues in the past, it doesn't seem like we've had such issues lately thanks to some CSS structure changes.
We feel like the cost of fixing the job might be greater than the resulting benefit. In consequence, let's remove this job altogether!
Let's also remove the `Include GitLab CSS` checkbox which produces the same results as the CI job.
Related internal discussion: https://gitlab.slack.com/archives/CH9QG9TAQ/p1606510558271600
| 1 |
7,071,551 | 74,184,902 |
2020-11-11 07:37:10.627
|
Update component code adding description for form input fields
|
In https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/642, we added an optional description area below the title of an input field. This issue is to update the component code.
| Former text input limitations | Proposed change - adds description field under label |
| ------ | ------ |
|  |  |
| Descriptions could only go below the text input ("help text") | Adds a description field under the label (doesn't limit designers to using the help text below the input field for a description |
## Implementation Plan
- In gitlab-ui add a `labelDescription` and `label` prop to https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/form/form_group/form_group.vue
- Add `label` slot to https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/form/form_group/form_group.vue
so end up with something like
- Update story book examples + add examples
- Update unit tests and manually test in gitlab codebase.
```
<template>
<b-form-group v-bind="$attrs" class="gl-form-group" :label-class="actualLabelClass">
<template #label>
<template v-if="label">{{ label }}</template>
<gl-form-text v-if="labelDescription" class="gl-mt-3">{{ labelDescription }}</gl-form-text>
</template>
<slot v-for="slot in Object.keys($slots)" :slot="slot" :name="slot"></slot>
</b-form-group>
</template>
```
| 2 |
7,071,551 | 74,010,423 |
2020-11-07 13:52:55.288
|
Add `inputAttrs` prop to datepicker
|
# Context
Identified in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46569#note_443497441
Sometimes we need to set the `id`, `name` and other properties for the input element used in the datepicker. Let's add an `inputAttrs` prop which we'll add a `v-bind` to.
| 1 |
7,071,551 | 73,911,450 |
2020-11-05 12:00:38.210
|
Improve modal with tertiary icon button for close action
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label:
- https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=regression
- https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
<!-- Summarize the bug encountered concisely. -->
The modal component could be improved with a tertiary icon button for the close action. This will yield the result that the close action has a dedicated background upon interaction. This improves the intractability now that the tertiary button component is ready for use.
### Steps to reproduce
<!-- Describe how one can reproduce the issue - this is very important. Please use an ordered list. -->
1. Open a modal at for example [/feature_flags](https://gitlab.com/gitlab-org/gitlab/-/feature_flags) by pressing the configure feature flags button
1. Hover the close `X` button in the top right corner
1. See almost no difference in visual interaction
### Example Project
<!-- If possible, please create an example project here on GitLab.com that exhibits the problematic
behavior, and link to it here in the bug report. If you are using an older version of GitLab, this
will also determine whether the bug is fixed in a more recent version. -->
Open the configure feature flags modal at [/feature_flags](https://gitlab.com/gitlab-org/gitlab/-/feature_flags) by pressing the configure feature flags button.
### What is the current *bug* behavior?
<!-- Describe what actually happens. -->
See almost no difference in visual interaction
### What is the expected *correct* behavior?
<!-- Describe what you should see instead. -->
See a clear visual change upon interaction
### Relevant logs and/or screenshots
<!-- Paste any relevant logs - please use code blocks (```) to format console output, logs, and code
as it's tough to read otherwise. -->
| gif of interaction with current close button of a modal |
| --- |
|  |
| Gif of visual change on interaction with tertiary buttons |
| --- |
|  |
### Output of checks
<!-- If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com -->
This bug happens on GitLab.com
#### Results of GitLab environment info
<!-- Input any relevant GitLab environment information if needed. -->
<details>
<summary>Expand for output related to GitLab environment info</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
</pre>
</details>
#### Results of GitLab application Check
<!-- Input any relevant GitLab application check information if needed. -->
<details>
<summary>Expand for output related to the GitLab application check</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:check SANITIZE=true`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
(we will only investigate if the tests are passing)
</pre>
</details>
### Possible fixes
<!-- If you can, link to the line of code that might be responsible for the problem. -->
| 1 |
7,071,551 | 73,492,249 |
2020-10-28 02:41:59.347
|
Allow setting full width on GlDatepicker
|
To handle this use case, we would need to add this custom CSS.
```css
.board-sidebar-due-date .gl-datepicker,
.board-sidebar-due-date .gl-datepicker-input {
width: 100%;
}
```
Adding the `.gl-w-full` utility does widen the container, but not the input.
<details>
<summary>Screenshot: full width datepicker input and container</summary>
</details>
----
As a proposal, we can add a `block` prop as we do on `GlDropdown`.
| 1 |
7,071,551 | 72,131,097 |
2020-10-04 04:24:29.219
|
Official support of Node.js 14.x
|
Node.js 14.x, released on 2020-04-21, was marked as LTS on 2020-10-27, so gitlab-ui has to support that version of Node.js.
cf.
- https://nodejs.org/ja/blog/release/v14.15.0/
- !1689 (#975)
- gitlab!43808 (gitlab#258963 gitlab#258964)
| 2 |
7,071,551 | 72,008,373 |
2020-10-01 10:57:44.522
|
GlButton: label variant should not render a <button>
|
This follows-up on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38421#note_421432692
`GlButton` supports a `label` mode that can be used to render text with some basic button styles. Currently, this variant renders an inactive `<button>`, which seems bad practice in terms of accessibility as the label should be presentational only, so it would be preferable to render a `<span>` or a `<div>` instead.
When used in a button group, the actual button in the group could leverage the `aria-labelledby` attribute to reference the label button.
| 2 |
7,071,551 | 71,370,350 |
2020-09-18 14:52:21.549
|
Let GlTab extend `title-link-class` prop value
|
When using `GlTab` it would be convenient to pass a class to the link, such as [in this scenario](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/42236/diffs#note_415030061).
Given the [current implementation](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/tabs/tab/tab.vue#L12) it is not possible.
We should add support for it.
| 1 |
7,071,551 | 70,821,392 |
2020-09-07 11:43:48.183
|
Css utilities in display.css do not follow responsive naming pattern
|
The following discussion from !1704 should be addressed:
- [ ] @rob.hunt started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1704#note_408495978): (+1 comment)
> **Question (non-blocking):** This file doesn't seem to follow our [naming pattern](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/doc/contributing/adding_css.md#responsive-utilities) for responsive utilities. Should we create an issue to fix these or are you aware of one already? :thinking:
| 2 |
7,071,551 | 70,674,655 |
2020-09-03 09:22:13.754
|
Provide option to trigger event on GlBanner button click
|
## Issue
From the discussion https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37658#note_40484599, currently the GlBanner takes props to allow adding a link for the Call to Action button component that gets rendered, but this does not cover scenarios where the action we want to perform is not simply navigating to a new url, for example triggering a modal window.
Additionally, if we have not already done so, we should migrate the `GlDeprecatedButton`
## Possible solutions
* The could be updated to emit a `click` event when the Call to action button is clicked, this would allow users to hook perform an action after the button click
* We could convert the Call to Action to a `<slot>`, allowing the user to provide their own code in place of the Call to Action button.
| 2 |
7,071,551 | 70,524,846 |
2020-08-31 21:29:47.273
|
Migrate GlAlert stories to CSF + MDX
|
Once `@storybook/addon-docs` is setup, let's migrate `GlAlert`'s stories to CSF + MDX as a proof of concept.
| 2 |
7,071,551 | 70,524,710 |
2020-08-31 21:23:17.938
|
Setup @storybook/addon-docs
|
Install and setup `@storybook/addon-docs` to enable [DocsPage](https://storybook.js.org/docs/vue/writing-docs/docs-page), [Component Story Format (CSF)](https://storybook.js.org/docs/vue/api/csf) and [MDX](https://storybook.js.org/docs/vue/api/mdx).
| 2 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.