idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
|---|---|---|---|---|---|
7,071,551 | 70,427,023 |
2020-08-28 15:19:28.219
|
Expose GlInputGroupText component
|
We currently don't wrap BootstrapVue's `BInputGroupText` component which is used directly in `GlFormInputGroup` stories.
Let's create the `GlInputGroupText` wrapper so that it can be used in GitLab and other consuming projects without having to import BootstrapVue's own component.
| 1 |
7,071,551 | 70,421,412 |
2020-08-28 13:19:36.348
|
GlToggle: Clicking on the icon doesn't switch the toggle
|
When clicking on the icon in `GlToggle`, the toggle stays in its initial state. To actually switch to the other state, one needs to click in the area behind the icon.
| 2 |
7,071,551 | 70,219,994 |
2020-08-24 13:24:52.591
|
Follow-up from "feat(css): add gl-pt-md-n2/gl-mt-md-n2 classes"
|
The following discussion from !1664 should be addressed:
- [ ] @sarahghp started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1664#note_400841497): (+1 comment)
> Thanks, @dstull and @oregand.
>
> 
| 1 |
7,071,551 | 70,218,361 |
2020-08-24 12:51:02.724
|
Follow-up from "feat(css): add gl-display-md-block class"
|
Replace `d-md-block` with `gl-display-md-block` class in GitLab
The following discussion from !1660 should be addressed:
- [ ] @dstull started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1660#note_399607631): (+2 comments)
> should we do a follow up to replace any use of `d-md-block` in GitLab after this is released? How is that handled usually and how often do we update `gitlab-ui` in GitLab?
| 1 |
7,071,551 | 70,120,539 |
2020-08-21 16:09:28.817
|
Migrate default export to named export(s) in src/directives/safe_html/safe_html.js
|
- [ ] Convert the default export to named export(s) in `src/directives/safe_html/safe_html.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,538 |
2020-08-21 16:09:28.740
|
Migrate default export to named export(s) in src/utils/use_fake_date.js
|
- [ ] Convert the default export to named export(s) in `src/utils/use_fake_date.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,537 |
2020-08-21 16:09:28.630
|
Migrate default export to named export(s) in src/utils/charts/data.js
|
- [ ] Convert the default export to named export(s) in `src/utils/charts/data.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,535 |
2020-08-21 16:09:28.504
|
Migrate default export to named export(s) in src/directives/tooltip.js
|
- [ ] Convert the default export to named export(s) in `src/directives/tooltip.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,534 |
2020-08-21 16:09:28.445
|
Migrate default export to named export(s) in src/utils/validation_utils.js
|
- [ ] Convert the default export to named export(s) in `src/utils/validation_utils.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,532 |
2020-08-21 16:09:27.990
|
Migrate default export to named export(s) in src/components/mixins/button_mixin.js
|
- [ ] Convert the default export to named export(s) in `src/components/mixins/button_mixin.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,528 |
2020-08-21 16:09:25.917
|
Migrate default export to named export(s) in src/directives/resize_observer/resize_observer.js
|
- [ ] Convert the default export to named export(s) in `src/directives/resize_observer/resize_observer.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,523 |
2020-08-21 16:09:25.377
|
Migrate default export to named export(s) in src/directives/collapse_toggle.js
|
- [ ] Convert the default export to named export(s) in `src/directives/collapse_toggle.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,522 |
2020-08-21 16:09:25.128
|
Migrate default export to named export(s) in src/directives/modal.js
|
- [ ] Convert the default export to named export(s) in `src/directives/modal.js`.
- [ ] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [ ] Remove the override from `.eslintrc.yml`.
- [ ] Put an MR up, and integration MRs if needed.
- [ ] Follow the standard review process.
| 1 |
7,071,551 | 70,120,496 |
2020-08-21 16:08:24.336
|
Migrate default export to named export(s) in src/components/base/form/form_checkbox_tree/models/tree.js
|
- [x] Convert the default export to named export(s) in `src/components/base/form/form_checkbox_tree/models/tree.js`.
- [x] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [x] Remove the override from `.eslintrc.yml`.
- [x] Put an MR up, and integration MRs if needed.
- [x] Follow the standard review process.
| 1 |
7,071,551 | 70,120,464 |
2020-08-21 16:07:21.145
|
Migrate default export to named export(s) in src/components/base/form/form_checkbox_tree/models/node.js
|
- [x] Convert the default export to named export(s) in `src/components/base/form/form_checkbox_tree/models/node.js`.
- [x] Make sure that internal `import` statements are also updated to reflect this change.
* WARNING: some of the default exports might be used outside of GitLab UI. Use your best judgement to determine when a given export might be used in consuming projects. Those cases should be flagged as breaking changes and should be submitted along with integration MRs in the projects we control.
- [x] Remove the override from `.eslintrc.yml`.
- [x] Put an MR up, and integration MRs if needed.
- [x] Follow the standard review process.
| 1 |
7,071,551 | 70,077,512 |
2020-08-18 16:32:59.012
|
add gl-display-md-block
|
The following discussion from gitlab!39348 should be addressed:
- [ ] @afontaine started a [discussion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/39348#note_397872160): (+2 comments)
> can we make a follow up to add any non-gitlab utilities to gitlab ui?
| 2 |
7,071,551 | 69,946,762 |
2020-08-18 00:08:55.044
|
GlSearchBoxByType calls input listener twice
|
The following discussion from gitlab!39630 should be addressed:
- [ ] @markrian started a [discussion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/39630#note_397284845): (+6 comments)
> **thought**: Rather than `watch`ing the model, we could instead just add an `input` event listener to the `GlSearchBoxByType`. WDYT?
| 1 |
7,071,551 | 69,693,538 |
2020-08-11 12:45:25.878
|
Add 2nd Y-axis for column chart and stacked column chart
|
Broken down from https://gitlab.com/gitlab-org/gitlab-ui/-/issues/889#note_393850965
Add 2nd Y-axis for column chart (and stacked column chart)
| 2 |
7,071,551 | 69,693,457 |
2020-08-11 12:43:39.261
|
Add line for column chart and stacked column chart
|
Broken down from https://gitlab.com/gitlab-org/gitlab-ui/-/issues/889#note_393850965
Implement a variant for both the column and the stacked column chart that allows for rendering an additional line series.
{{image.png}}
| 2 |
7,071,551 | 68,958,280 |
2020-07-24 17:56:38.260
|
Add size (or similar) prop to form input
|
Our [design specs for inputs](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Pajamas-UI-Kit?node-id=2977%3A1) indicate that there are certain sizes (widths) that are allowed.
While the underlying `BFormInput` component already has a `size` prop, that changes the padding/margins around the input. In any case, our styles override that behaviour anyway. I suggest we repurpose the existing `size` prop to implement these widths.
The sizes are (based on the design spec):
| Name | (Max) Width |
| ------ | ------ |
| xs | 80px |
| sm | 160px |
| md | 240px |
| lg | 320px |
| xl | 560px |
## Questions
- What would be the _default_ size? Currently, inputs take up all available width; i.e., they're unbounded. Should that still be possible?
- Is setting this via `max-width` sufficient?
| 2 |
7,071,551 | 68,838,700 |
2020-07-22 07:31:32.571
|
GlAlert: Add slot for title
|
Add a title slot to the `GlAlert` component.
Why? It's sometimes necessary to add custom elements or styles to the title. For example the design in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/36962#modal:
| 1 |
7,071,551 | 59,851,170 |
2020-07-15 21:47:59.786
|
Proposal: change border and box-shadow units from `rem` to `px`
|
## Background
There are a number of instances where we use `px-to-rem(1px)`. This causes some rounding errors and in turn can cause issues with rendering.
```
px-to-rem(1px) == 0.06rem
0.06 * 16 = 0.96, i.e. less than 1px!
```
Stollen from https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/1534
## Proposal
Replace `border` and `box-shadow` properties that are using `rem` with `px`. Here is a list of places to replace:
- [src/components/base/button/button.scss#L6](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/button/button.scss#L6)
- [src/components/base/button/button.scss#L11](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/button/button.scss#L11)
- [src/components/base/button/button.scss#L16](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/button/button.scss#L16)
- [src/components/base/button/button.scss#L21](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/button/button.scss#L21)
- [src/components/base/button/button.scss#L65](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/button/button.scss#L65)
- [src/components/base/button/button.scss#L90](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/button/button.scss#L90)
- [src/components/base/path/path.scss#L8](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/path/path.scss#L8)
- [src/components/base/segmented_control/segmented_control.scss#L5](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/master/src/components/base/segmented_control/segmented_control.scss#L5)
| 2 |
7,071,551 | 57,064,598 |
2020-07-14 11:29:40.905
|
Column + Line chart with 2 Y-axes
|
### Problem
When showing a chart containing data sets at different orders of magnitude (e.g. issues closed, 10; issues opened, 10; total issues 1,000), this reduces the size of the visualisations at lower orders of magnitude to a point where they aren't useful.
### Solution
* Add a variant to our [charts](https://design.gitlab.com/components/charts) component which has a second Y-axis.
* Add guidance to our documentation on using this (potentially confusing) pattern
* [See Figma prototype](https://www.figma.com/proto/GevTEMYLCPyWn2bo564C2V/Grouped-Stacked-Column?node-id=55%3A916&viewport=95%2C316%2C0.8319990634918213&scaling=min-zoom)
| 2 |
7,071,551 | 127,111,587 |
2023-04-24 14:12:15.060
|
Remove SparklineChart storyshots
|
Continuation of #2176
Storyshots for GlSparklineChart are proving to be flakey, so we should remove them for the time being
---
**Update:**
This may be unnecessary depending on the result of #2215.
I'm adding ~"workflow::blocked" until I can determine if removing the storyshots is necessary
| 1 |
7,071,551 | 126,995,058 |
2023-04-20 15:40:12.154
|
Storyshots > Increase failure threshold for chart components
|
Our chart components tend to make visual tests flaky due to `echarts` being non-deterministic in some of the drawing it does. To address this, we are thinking that raising the failure threshold for charts might be the simplest solution. This should be doable with the `getMatchOptions` function: https://storybook.js.org/addons/@storybook/addon-storyshots-puppeteer
/cc @markrian
| 2 |
7,071,551 | 126,672,382 |
2023-04-14 13:35:37.277
|
Dropdowns > Make fluid-width opt-in
|
Follows-up on https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/3384#note_1352998790.
We have recently made the dropdowns's width a bit more flexible by removing the fixed width in favor of a minimum and a maximum width.
In some cases, we might still want to prevent the dropdowns from auto-sizing themselves. E.g.:
| **Wrapping example** | **Disclosure example** |
| ------ | ------ |
|  |  |
### Implementation plan
- [x] Restore the fixed width at `15.5rem`. This should be the default.
- [x] The fluid layout `15.5rem <= width <= 28.5rem` can be opted in via a new prop.
| 1 |
7,071,551 | 125,379,808 |
2023-03-16 15:02:52.925
|
Code for stories isn't consistently available
|
When looking at some story within a docs page, it's not always possible to expand the code panel to copy the source code.
The panel seems to become available when navigating to a story via Storybook's navigation.
Let's make sure the code panel is always available.
| 1 |
7,071,551 | 125,253,619 |
2023-03-14 16:24:52.763
|
Add same styling for DisclosureDropdown toggle as for other buttons in a button group
|
### Description
Style `DisclosureDropdown` toggle the same way as other buttons inside `GlButtonGroup`. Currently the styles of the DisclosureDropdown take precedence there.
#### Figma file
<!-- If design specs exist in Figma, link them below. Otherwise, remove the link and add a link to the issue to add the component to Figma -->
[View design specs in Figma →](ADD LINK TO FIGMA FILE/FRAME)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [x] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [x] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
| 1 |
7,071,551 | 125,252,213 |
2023-03-14 16:14:52.569
|
Add disabled styling for the DisclosureDropdownItem component
|
### Description
Add `disabled` styling for the `DisclosureDropdownItem` component. Currently the `disabled` attribute is set correctly on `DisclosureDropdownItem` (= the button is not clickable) but it is still styled the same as normal button.
Expected behavior: when `disabled` attribute is set the button has a light grey color.
Current behavior:
Code example of how to reproduce this behavior
```
const actionItems = [
{
text: __('scheduled action'),
},
{
text: __('expired action'),
extraAttrs: {
disabled: true,
},
},
];
<template>
<gl-disclosure-dropdown
:text="title"
:title="title"
:aria-label="title"
:items="actionItems"
>
<gl-disclosure-dropdown-item
v-for="item in actionItems"
:key="item.text"
:item="item"
>
<template #list-item>
<span class="gl-flex-grow-1">{{ item.text }}</span>
</template>
</gl-disclosure-dropdown-item>
</gl-disclosure-dropdown>
</template>
```
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [x] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
| 1 |
7,071,551 | 125,233,091 |
2023-03-14 10:15:30.568
|
Add placeholder/not selected state for dropdown button
|
In the new dropdown we don't have a state which indicates the placeholder/not selected state like we had in the old dropdown.
| New dropdown button | Old dropdown button |
| ------ | ------ |
|  |  |
**Proposed solution**
Add `gl-text-gray-500` when there is no selection to the dropdown button.
| Before | After |
| ------ | ------ |
|  |  |
| 1 |
7,071,551 | 124,206,478 |
2023-02-23 16:47:57.046
|
Add option to remove header from GlModal
|
## Problem
In https://gitlab.com/gitlab-org/gitlab/-/issues/378542 we need to create a search modal that is headerless. There's no way to do that with the current GitLab UI component
## Proposal
Add that ability. It should be possible with a v-if statement hooked up to a boolean prop. We want the whole header to disappear, including the close icon.
https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/modal/modal.vue
| 2 |
7,071,551 | 124,134,737 |
2023-02-22 15:26:58.871
|
GlLineChart: Chart does not fill container height when `auto`
|
## Problem to solve
In the ~"group::product analytics" dashboard setting the chart height to `auto` and setting `responsive` creates a chart with `0` height.
This can be fixed by setting the chart height to full or using flex grow. However there is no API to style the `GlChart` component inside `GlLineChart`.
Needed for https://gitlab.com/gitlab-org/gitlab/-/issues/385181+.
### Screenshots
Chart with height: `auto`
### Proposed solution
Add an optional property to `GlLineChart` to set the CSS class on its `GlChart` element.
Note: This could also potentially be applied to all other chart components.
### Implementation plan
There are two options:
1. Add a `chartStyle` to `GlLineChart` that sets the style on its `GlChart`.
1. Add a `chartStyle` to `GlChart` which would be passed by `GlLineChart`'s `v-bind="$attrs"`.
My preference would be to go with the second since it would solve it for all components that wrap `GlChart`.
| 3 |
7,071,551 | 123,823,683 |
2023-02-16 16:25:29.143
|
GlFilteredSearch: Stop treating spaces specially
|
This is a follow-up for https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1803. The goal of this issue is to get https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/3226 merged. That includes:
- Add an opt in flag to enable the new behaviour. The old behaviour must remain.
- Add tests covering the new behaviour.
- Add documentation for new behaviour.
| 3 |
7,071,551 | 123,419,039 |
2023-02-08 16:55:10.222
|
Improve the semantics of the disclosure content wrapper when it has custom content
|
The following discussion from gitlab!110683 should be addressed:
- [ ] @sdejonge started a [discussion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/110683#note_1269738234): (+2 comments)
> **question:** Can we remove this `<div role="group">`? I think the `<slot>` inside `<gl-disclosure-dropdown>` should already get an associated role from the computed `<ul>` or `<div role="group">`.
>
> The HTML output has `<div>` children of `<ul>` which is invalid.
>
> ```html
> <ul id="disclosure-6" aria-labelledby="dropdown-toggle-btn-2" data-testid="disclosure-content" tabindex="-1" class="gl-new-dropdown-contents">
> <div>
> <ul role="group" class="gl-mb-0 gl-pl-0 gl-list-style-none">...</ul>
> </div>
> <div class="gl-border-t gl-pt-2 gl-mt-2">
> <ul role="group" class="gl-mb-0 gl-pl-0 gl-list-style-none">...</ul>
> </div>
> <div class="gl-border-t gl-pt-2 gl-mt-2">
> <ul role="group" class="gl-mb-0 gl-pl-0 gl-list-style-none">...</ul>
> </div>
> </ul>
> ```
>
> The `isAllGroups` util to set the parent as `<div role="group">` checks the `items` but not the `<slot>` contents as in this case.
>
> **question:** would it be silly to make the root element of `<gl-disclosure-dropdown-group>` a `<li>` and always render the slot contents of `<gl-disclosure-dropdown>` in a `<ul>`? Or is there a better way to set the parent as `<div role="group">` when the `<slot>` content only contains `<gl-disclosure-dropdown-group>`?
| 1 |
7,071,551 | 123,269,126 |
2023-02-08 09:03:19.110
|
feat(toggle): Add description field and inline variant
|
### Description
In Pajamas we have defined a `description` field, see https://design.gitlab.com/components/toggle \
But we currently do not have it present in GitLab UI. Also the inline variant is currently not implemented in GitLab UI. This MR adds both.
| Before | After |
| ------ | ------ |
|  |  |
| Inline variant |
| ------ |
|  |
#### Figma file
[View design specs in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=20182%3A110&t=OdVE7sYmYcq4g41C-11)
### Checklist
Make sure the following are completed before closing the issue:
1. [X] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[pajamas-mr]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/new
[pajamas-issue]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[adding-components]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_components.md
[adding-css]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_css.md
[breaking-changes]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/breaking_changes_to_components.md
[eng-week-in-review-doc]: https://docs.google.com/document/d/1GQbnOP_lr9KVMVaBQx19WwKITCmh7H3YlgO-XqVwv0M/edit
| 1 |
7,071,551 | 123,028,299 |
2023-02-03 21:13:40.026
|
bug(GlCollapsibleListbox): keyboard navigation doesn't work when there is no item selected
|
A fairly common use case for `GlCollapsibleListbox` is to initially have no item selected. However, if you set the `selected` prop to `null` then the keyboard navigation doesn't work. See video below:
Normally in this use case you would use the `toggle-text` prop to set the toggle button text when no item is selected. In the above video I didn't set this prop which is why the toggle button is empty.
If you set the `selected` prop to `undefined` the keyboard navigation does work :shrug:
### How to reproduce
1. Run storybook locally
2. Change [src/components/base/new_dropdowns/listbox/listbox.stories.js#L144](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/new_dropdowns/listbox/listbox.stories.js#L144) to `null`
| 1 |
7,071,551 | 123,015,705 |
2023-02-03 16:19:53.150
|
Set focus on the first child of the custom toggle in new dropdowns
|
Currently, the custom toggle's container ('div') element gets the focus. The problem is that the user might want to style the focus ring differently
| Focus on `div` | Focus on custom content |
| ------ | ------ |
| |  |
As @pgascouvaillancourt we could solve it by setting the focus on the first child of the custom toggle instead of the wrapper. Then user can have control of how it looks
| 2 |
7,071,551 | 122,985,249 |
2023-02-03 08:33:32.134
|
Toggle - Add states
|
### Description
Update the toggle component's states according to changes introduced with https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1530+
#### Figma file
[View design specs in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=425%3A140&t=gXmjFsqGayYbQbgH-11)
### Checklist
Make sure the following are completed before closing the issue:
1. [X] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[pajamas-mr]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/new
[pajamas-issue]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[adding-components]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_components.md
[adding-css]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_css.md
[breaking-changes]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/breaking_changes_to_components.md
[eng-week-in-review-doc]: https://docs.google.com/document/d/1GQbnOP_lr9KVMVaBQx19WwKITCmh7H3YlgO-XqVwv0M/edit
| 1 |
7,071,551 | 121,359,809 |
2023-01-06 15:46:48.951
|
Fix Listbox group header padding according to design
|
Follow up for this [comment](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/106738#note_1223712370)
As it was suggested by @cam.x , `y-padding` for needs to be adjusted according to [design documentation](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=66756%3A108021&t=a82xCnl6M4N2MyUf-0)
Now it is `4px` and according to design specs, it needs to be `8px`
<details><summary>Screenshot</summary>
</details>
| 1 |
7,071,551 | 121,352,874 |
2023-01-06 13:41:58.064
|
Create `gl-focus-ring` utility
|
We have `gl-focus` mixin. It would be nice to have the default focus CSS class available. We could name it `gl-focus-ring` for instance. When the class is available - replace focus-related CSS in `base_dropdown.css` and use the utility instead,
| 1 |
7,071,551 | 121,304,750 |
2023-01-05 16:02:45.354
|
Consider upgrading to Storybook 7 (and webpack@5)
|
Storybook 7 [will soon be](https://storybook.js.org/blog/7-0-beta/)/[is available](https://storybook.js.org/releases/7.0). We should consider upgrading to it.
See the [migration guide](https://storybook.js.org/migration-guides/7.0) for details.
Possible improvements:
- Faster builds
- Keeping up to date
Possible issues:
- Dropping webpack support
- CSF API changes
| 2 |
7,071,551 | 121,295,953 |
2023-01-05 14:22:58.102
|
Upgrade bootstrap-vue to 2.23.1
|
I'm creating separate issue to track this effort, cause it is important for ~"vue3-migration"
Previous attempt at !3116 was reverted, because it caused regressions in gitlab due to tables rendering
We need to upgrade bootstrap-vue to latest version to unlock @vue/compat compatibility
Prior work:
* https://gitlab.com/gitlab-org/gitlab/-/merge_requests/102067
| 3 |
7,071,551 | 121,293,990 |
2023-01-05 14:03:55.702
|
Backport CSS utils from GitLab to GitLab UI
|
We have written a number of CSS utils within GitLab directly in `app/assets/stylesheets/utilities.scss`. Let's move those to GitLab UI and cleanup GitLab's stylesheet.
- [x] Add CSS utils to GitLab UI.
- [x] Upon upgrading `@gitlab/ui` in GitLab, remove the unnecessary utils.
| 2 |
7,071,551 | 126,297,668 |
2023-01-03 16:25:24.204
|
Dropdown > Direction for rendering overflowing, non-wrapping text within items
|
In some cases, we might need to display long non-wrapping texts within a dropdown's items. For example, the notification settings display the user's emails, which might overflow the dropdown menu:
## Implementation plan
- [x] `GlTruncate`: ensure the rendered element has an accessible `aria-label` attribute.
- [x] `GlCollapsibleListbox`
- [x] Make dropdown's width more flexible:
- [x] `min-width: 15.5rem`
- [x] `max-width: 28.5rem`
- [x] Leverage `GlTruncate` to truncate long items' names. This should be probably be the consumer's responsibility, so this can be a recommendation in the docs.
- [x] Ensure the notifications settings render properly as per https://gitlab.com/gitlab-org/gitlab/-/issues/373843#note_1227467886.
| 2 |
7,071,551 | 120,345,219 |
2022-12-13 15:38:42.905
|
Code blocks with only one line render as one or more `[object Object]` strings on first load
|
1. Load a docs page from scratch, e.g. https://gitlab-org.gitlab.io/gitlab-ui/?path=/docs/base-button--default
2. Observe some code blocks render as `[object Object]`, or similar
3. Click on another component's story from the nav, and then click on the original story in the nav
4. Observe that the code block renders correctly
It _seems_ to only affect code blocks which have one line, e.g., https://gitlab.com/gitlab-org/gitlab-ui/blob/81a8250e2421022d885afb59b587bd5766a00480/src/components/base/badge/badge.md#L7-9.
## Expected
From https://gitlab-org.gitlab.io/gitlab-ui/?path=/docs/base-button--default:
## Actual
## Another example
From https://gitlab-org.gitlab.io/gitlab-ui/?path=/docs/utilities-sprintf--sentence-with-link
| 1 |
7,071,551 | 118,908,608 |
2022-11-17 12:30:36.360
|
Fix horizontal padding in a drawer
|
From [this discussion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/102290#note_1175263842).
According to [Pajamas UI Kit in Figma](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=48150%3A59274), horizontal padding should be `16px horizontal`.
All current drawers have bigger `padding` that calculates to `24px`
Goal of this MR is to change drawer `padding` from `24px` -> `16px`.
| 1 |
7,071,551 | 118,576,345 |
2022-11-11 17:00:37.748
|
Remove GlListbox alias
|
Once #2085 and gitlab#382423 are done, the `GlListbox` alias can be removed in a major breaking change for GitLab UI.
| 1 |
7,071,551 | 118,576,293 |
2022-11-11 16:59:03.426
|
Add GlCollapsibleListbox export
| null | 1 |
7,071,551 | 117,594,383 |
2022-10-26 10:04:47.569
|
Follow-up from "Searchbar clear button events"
|
This issue is about fixing a bug that was raised from the [Merge Request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93687) review.
I need to expose events of the clear button that's inside of the search_box_by_type component.
In the Header Search component, I need to be able to control the appearance of the whole component (search_box_by_type) based on the state of this button, subtracting and contracting the search field in the header with an awareness of focus, blur, click on the clear button.
| 1 |
7,071,551 | 116,890,780 |
2022-10-14 11:39:08.800
|
Add @vue/compat storybook support
|
https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/3087+ adds support for running our unit tests with vue3 (and if we ignore snapshots all are green, so our codebase is somewhat `@vue/compat` ready)
We need to implement same approach for storybook to allow playing with our components using `@vue/compat` instead of vue
| 3 |
7,071,551 | 116,885,708 |
2022-10-14 10:05:53.156
|
Badge component: implement 12px icon variant to show import status
|
This issue is created following a comment [here](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1142#note_1134746521).
# Problem
- From: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/785
- New 12px badge variant (for small and medium) has been created in [Figma](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=19947%3A329)
# Proposal
1. Implement new variant in GitLab-UI: leverages 12px badge size and different padding
1. Update single stat component to use this variation of the badge
| small | medium |
| ------ | ------ |
|  |  |
| 1 |
7,071,551 | 122,071,990 |
2022-10-04 21:56:57.404
|
Dropdown styles update according to new designs
|
## Purpose
Update current dropdown styles according to the latest [design specs](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/%F0%9F%93%99-Component-library?node-id=425%3A14).
As discussed in this [thread](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/2125#note_1244779781) we'll create separate styles only for new dropdowns - listbox and disclosure but will keep old styles for the dropdowns implemented with `GlDropdown`.
The redesign will be done in 3 steps
- [x] :feet: Create separate stylesheets for the new dropdowns, pick CSS classes so that they do not overlap with the current GlDropdown's classes and there is no specificity battle.
- [ ] ~:feet: Add overflow scrim. [Some ideas here](https://css-tricks.com/scroll-shadows-with-javascript/)~ https://gitlab.com/gitlab-org/gitlab-ui/-/issues/2179
- [ ] ~:feet: Add dropdown panel tips pointing at the toggle~ https://gitlab.com/gitlab-org/gitlab-ui/-/issues/2180
| 3 |
7,071,551 | 116,225,136 |
2022-10-04 04:07:15.342
|
Fix rounded borders in Segmented Control component
|
In the segmented control, `border-radius` should not be applied to the side of the buttons that are adjacent or next to each other.
| 1 |
7,071,551 | 115,526,438 |
2022-09-21 18:05:12.843
|
Listbox: Support for reset action
|
We need a way to add a reset button to listboxes' headers.
The reset button should...
* ...have a customizable label to reflect the context the listbox is being used in.
* ...only show up if the listbox has a header. Showing the reset button in an empty header is not allowed.
* ...be hidden if no item is selected in the listbox.
## Implementation plan
- [x] Expose an `resetButtonLabel` prop.
- [x] If the prop is omitted, the button never shows up.
- [x] On click, the `cleared` event is emitted.
- [x] Left-align the header to match the designs in https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/branch/5YYrJSrszk6dw9619HHPt9/%F0%9F%93%99-Component-library?node-id=425%3A14.
| 2 |
7,071,551 | 114,701,618 |
2022-09-09 01:23:57.253
|
Add gl-sm-mt-6 utility class
|
## Summary
We should add a `gl-sm-mt-6` utility CSS class, we currently have `gl-sm-mt-5` and `gl-sm-mt-7` available but now have a use case for `6`.
## Improvements
* Once the utility is available in `gitlab` we can replace the custom css in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/97387/diffs#fb723e851b8926f6532eeed94f1de1874c3221c7_288_288
## Involved components
<!--
List files or directories that will be changed by the refactoring.
-->
## Optional: Intended side effects
* Additional class available for use
| 1 |
7,071,551 | 113,269,991 |
2022-08-15 04:28:09.548
|
Lint against `gl-media-breakpoint-down` to promote mobile-first CSS
|
## Description
We have a few instances of `gl-xs-` utility classes in the codebase which use `gl-media-breakpoint-down`. These violate the mobile-first approach we are aiming for (see [relevant comment](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2975#note_1060307382)).
Let's lint against using `gl-media-breakpoint-down` in our scss.
| 2 |
7,071,551 | 112,040,336 |
2022-07-22 12:13:05.432
|
Dropdown > Add invalid state
|
### Description
Add the ability to show invalid dropdown input.
For more context see this discussion https://gitlab.com/gitlab-org/gitlab/-/merge_requests/92899#note_1034671442.
#### Design
### Implementation
1. Update `dropdown.vue` and add a `state` property. See [`GlFormSelect`](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-form-form-select--default&args=state:false) as an example.
- When the `state` is invalid, set the dropdown button's box shadow color to `red-400`.
1. Update specs.
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, update `followsDesignSystem:` with the correct value inside the `[component].documentation.js` file.
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[pajamas-mr]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/new
[pajamas-issue]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[adding-components]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_components.md
[adding-css]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_css.md
[breaking-changes]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/breaking_changes_to_components.md
[eng-week-in-review-doc]: https://docs.google.com/document/d/1GQbnOP_lr9KVMVaBQx19WwKITCmh7H3YlgO-XqVwv0M/edit
| 1 |
7,071,551 | 111,608,695 |
2022-07-13 22:04:52.062
|
Listbox: Support for filtering
|
We should consider adding support for filtering in the ~"dropdown::listbox" component.
| 5 |
7,071,551 | 111,608,670 |
2022-07-13 22:04:03.788
|
Listbox: Support for separators/dividers
|
We should consider adding support for seperators / dividers in the ~"dropdown::listbox" component
| 3 |
7,071,551 | 111,608,639 |
2022-07-13 22:02:23.000
|
Listbox: Support for grouping
|
We should consider adding group support (similar to native select `<optgroup>` to ~"dropdown::listbox".
| 5 |
7,071,551 | 111,217,989 |
2022-07-06 00:15:49.594
|
Refactor GlCombobox to use native focus
|
Currently, GlCombobox component uses a hard coded keyboard navigation, focus and selection implementation, making is tricky to expand upon. It should be refactored to use native focus and scroll to selection.
| 2 |
7,071,551 | 109,320,448 |
2022-05-30 14:15:09.847
|
GlLabel - Render label as text when target is empty
|
### Description
When a `GlLabel` doesn't have a `target` it's still rendered as a link.
We should instead render it as plain text with no hover behaviour.
This is needed for compliance framework labels.
### Checklist
Make sure the following are completed before closing the issue:
1. [ ] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, update `followsDesignSystem:` with the correct value inside the `[component].documentation.js` file.
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[pajamas-mr]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/new
[pajamas-issue]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[adding-components]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_components.md
[adding-css]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_css.md
[breaking-changes]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/breaking_changes_to_components.md
[eng-week-in-review-doc]: https://docs.google.com/document/d/1GQbnOP_lr9KVMVaBQx19WwKITCmh7H3YlgO-XqVwv0M/edit
| 2 |
7,071,551 | 109,309,479 |
2022-05-30 11:49:18.333
|
Fluid type scale: use clamp() to reduce involved code
|
## What does this MR do and why?
Let's change the title's to use fluid typography to make use of the `clamp()` CSS function to reduce the involved code quite a bit.
### Proposal
e.g. `h1`: Let's use `clamp()` for the fluid type scale. Scales from the defined minimum (23px) to the maxinum value (32px).
```
h1 {
font-size: clamp(23px, 2.75vw, 32px);
}
```
## Screenshots or screen recordings
See it in action:\
Related to gitlab#361641
| 1 |
7,071,551 | 110,811,678 |
2022-05-19 08:40:04.948
|
Duration for `type: stacked-bar` on Insight pages is not adjustable by UI
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "type::bug" label:
- https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=regression
- https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=type::bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
<!-- Summarize the bug encountered concisely. -->
Not like `type: bar` and `type: line`, durations for `type: stacked-bar` on Insight pages are not adjustable by UI.
An Ultimate customer reported this: https://gitlab.my.salesforce.com/0014M00001wX5OM (Internal only)
### Steps to reproduce
<!-- Describe how one can reproduce the issue - this is very important. Please use an ordered list. -->
1. Put the `.gitlab/insights.yml` in a GitLab project and then visit "Analytics > Insights"
1. Try to drag :pig_nose: for "Issues closed per month - Stacked Bar"
```yaml
issues:
title: Issue Dashboard
charts:
- title: Issues closed per month - Bar
type: bar
query:
issuable_type: issue
issuable_state: closed
group_by: month
- title: Issues closed per month - Line
type: line
query:
issuable_type: issue
issuable_state: closed
group_by: month
collection_labels:
- P::1
- P::2
- P::3
- P::4
- title: Issues closed per month - Stacked Bar
type: stacked-bar
query:
issuable_type: issue
issuable_state: closed
group_by: month
collection_labels:
- P::1
- P::2
- P::3
- P::4
```
### Example Project
<!-- If possible, please create an example project here on GitLab.com that exhibits the problematic
behavior, and link to it here in the bug report. If you are using an older version of GitLab, this
will also determine whether the bug is fixed in a more recent version. -->
### What is the current *bug* behavior?
<!-- Describe what actually happens. -->
:pig_nose: can't be draggable.
### What is the expected *correct* behavior?
<!-- Describe what you should see instead. -->
:pig_nose: should be draggable.
### Relevant logs and/or screenshots
<!-- Paste any relevant logs - please use code blocks (```) to format console output, logs, and code
as it's tough to read otherwise. -->
### Output of checks
<!-- If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com -->
#### Results of GitLab environment info
<!-- Input any relevant GitLab environment information if needed. -->
GitLab.com (GitLab Enterprise Edition 15.0.0-pre gitlab@a81a1e8bf2e8d71bf20cd23b22d94d4225ea4310)
<details>
<summary>Expand for output related to GitLab environment info</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
</pre>
</details>
#### Results of GitLab application Check
<!-- Input any relevant GitLab application check information if needed. -->
<details>
<summary>Expand for output related to the GitLab application check</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:check SANITIZE=true`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
(we will only investigate if the tests are passing)
</pre>
</details>
### Possible fixes
<!-- If you can, link to the line of code that might be responsible for the problem. -->
| 2 |
7,071,551 | 108,024,346 |
2022-05-04 16:26:34.765
|
Spike: GlFilteredSearch: Stop treating spaces specially
|
This is a spin-off issue based on the discussion in https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1438#note_906619217, and this (private) recording: https://www.youtube.com/watch?v=FgJBT7iX_6w.
The goal is to time box a proof-of-concept such that `GlFilteredSearch` no longer treats spaces specially. More concretely, the changes we want to implement are:
- [x] Free text (search terms) must be completed into tokens, via a new “free text” suggestion dropdown.
- [x] Clicking away/out from free text that hasn’t yet been tokenised gets tokenised.
- [ ] When typing in the third segment of a token, a new “free text value” option is displayed, allowing for arbitrary tokens containing spaces to be used/searched for
- [x] Pasting text with spaces would behave just like typing them manually (see above)
The goals of the spike would be to:
- [x] Get a better sense of the engineering effort to implement these robustly in GitLab UI
- [x] Get a better sense of the downstream impact in GitLab, in the various places these components are used
- [x] Get a better grasp on how to feature flag this, if we want to start trialling it
| 3 |
7,071,551 | 106,958,557 |
2022-04-21 09:32:36.356
|
GlDropdown: Dropdown should shrink to fit parent container width
|
## Problem to solve
Unlike other form inputs in GitLab UI, the `GlDropdown` doesn't shrink to fit its parent container. This is being resolved in GitLab https://gitlab.com/gitlab-org/gitlab/-/merge_requests/85499, but it should be also be resolved in GitLab UI.
## Suggested solution
Setting the dropdown button's width to 100% would make it fit the parent container.
| 1 |
7,071,551 | 106,853,462 |
2022-04-19 18:35:51.790
|
Add utility classes for billing plan page
|
```css
.gl-text-purple-800 {
color: $purple-800;
}
.gl-bg-theme-indigo-800 {
background-color: $theme-indigo-800;
}
.gl-border-indigo-700 {
border-color: $theme-indigo-700;
}
.gl-border-gray-75 {
border-color: $gl-text-color-quaternary;
}
.gl-min-h-8 {
min-height: $gl-spacing-scale-8;
}
```
# Plan
- [x] Add to `gitlab-ui` !2811
- [x] Remove from `gitlab` [here](http://gitlab.com/gitlab-org/gitlab/blob/921b31bc43af65f1871457407489e72ddc1a061e/app/assets/stylesheets/utilities.scss#L372-372) https://gitlab.com/gitlab-org/gitlab/-/merge_requests/87116
| 2 |
7,071,551 | 105,674,988 |
2022-03-29 10:17:41.414
|
Fix font colors for GlBadge variants when used in GlTabs
|
Background:
GlBadge has variants:
https://gitlab-org.gitlab.io/gitlab-ui/?path=%2Fstory%2Fbase-badge--variants
## Problem
When GlBadge is used within GlTabs, variants don't seem to work. The text font stays black.
- We need to define the correct color for selected and unselected GlBadge variants with a tab.
## Expected
## Actual
## Default muted variant used in tabs
| 2 |
7,071,551 | 105,513,200 |
2022-03-25 17:54:10.463
|
Migrate base/form/form-checkbox-tree stories to Component Story Format
|
Migrate `base/form/form-checkbox-tree` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
* [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
* [ ] Migrated or removed examples.
* [ ] Migrated props, slots and events documentation.
* [ ] If needed, migrated the `bootstrapComponent` parameter.
* [ ] Cleanup
* [ ] Component's README:
* [ ] Removed `<!-- STORY -->`.
* [ ] Removed component's title.
* [ ] `documentation/documented_stories.js`:
* [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 105,444,634 |
2022-03-24 17:05:04.446
|
Migrate typescale stories to Component Story Format
|
Migrate `src/scss/typescale/typescale.stories.js` stories to the [Component Story Format (CSF)](https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format).
* [ ] Migrated `documentedStoriesOf` usages to the Component Story Format.
* [ ] Migrated or removed examples.
* [ ] Migrated props, slots and events documentation.
* [ ] If needed, migrated the `bootstrapComponent` parameter.
* [ ] Cleanup
* [ ] Component's README:
* [ ] Removed `<!-- STORY -->`.
* [ ] Removed component's title.
* [ ] `documentation/documented_stories.js`:
* [ ] Added component's PascalCase name to `disableForComponents`.
More details about the migration can be found in the epic: https://gitlab.com/groups/gitlab-org/-/epics/5651
| 2 |
7,071,551 | 104,553,864 |
2022-03-10 14:10:25.662
|
Add .nvmrc
|
Add missing `.nvmrc`
Support working with different node versions locally (nvm).
Sets node version to `14.17.5` (same as GDK). [Required is v14](https://gitlab.com/gitlab-org/gitlab-ui/#quick-start-development)
| 1 |
7,071,551 | 104,287,993 |
2022-03-07 12:51:17.376
|
GlEmptyState: Add the ability to style title & description container
|
## Problem to solve
The `GlEmptyState` component doesn't provide a way to style the title & description container.
This is causing some misalignments on GitLab.com. Originally raised in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/81889#note_863257787.
## Screenshots
## Proposed solution
Add a property that allows the consumer to define classes on the title & description container.
| 1 |
7,071,551 | 102,212,215 |
2022-02-10 14:23:26.437
|
GlFilteredSearch - Add readonly state to search bar and tokens
|
## Problem to solve
For https://gitlab.com/gitlab-org/gitlab/-/issues/344452 we need to show the `GlFilteredSearch` and tokens as read-only as certain roles don't have access to other terms.
## Designs
[Figma](https://www.figma.com/file/n7rywDkSHdt8hsKlZhf6zG/KR-UI-redesign-session-5%3A-Filtering?node-id=8%3A33)
## Proposal
1. Add a `readonly` property to `GlFilteredSearch`. When true:
1. Don't show the suggestions list.
1. Don't show the clear `X` button.
1. Don't allow the user to type or clear any existing text or tokens.
1. Add a `disabled` property to `GlFilteredSearchToken`. When true:
1. Don't allow the user to change it.
1. Don't show the clear `X` postfix.
| 3 |
7,071,551 | 102,128,185 |
2022-02-09 09:26:27.094
|
GlAlert: drop contained behavior
|
In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79235, we have decided to drop alerts' contained behavior so that their content can expand to the full width in fluid layouts. We'll need to reflect this decision on the GitLab UI component.
/cc @jeldergl @justin_ho
| 2 |
7,071,551 | 101,777,332 |
2022-02-03 01:52:45.242
|
Add gl-max-w-48 & gl-max-w-58 CSS utilities
|
Needed for the design of https://gitlab.com/gitlab-org/gitlab/-/issues/348494. We in Growth Conversion plan to implement as part of our experiment promotion task (if the experiment is a success).
```scss
$gl-spacing-scale-48: 48 * $grid-size;
$gl-spacing-scale-58: 58 * $grid-size;
.gl-max-w-48 {
max-width: $gl-spacing-scale-48;
}
.gl-max-w-58 {
max-width: $gl-spacing-scale-58;
}
```
| 1 |
7,071,551 | 101,247,323 |
2022-01-25 20:16:59.446
|
Buttons > Update selected state
|
### Description
Update selected state to match Figma UI Kit
#### Figma file
[View design specs in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=2956%3A3364)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [x] Create an MR with the additions or updates needed.
1. [ ] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, update `followsDesignSystem:` with the correct value inside the `[component].documentation.js` file.
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[pajamas-mr]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/new
[pajamas-issue]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[adding-components]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_components.md
[adding-css]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_css.md
[breaking-changes]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/breaking_changes_to_components.md
[eng-week-in-review-doc]: https://docs.google.com/document/d/1GQbnOP_lr9KVMVaBQx19WwKITCmh7H3YlgO-XqVwv0M/edit
| 1 |
7,071,551 | 100,818,037 |
2022-01-18 08:11:41.858
|
Run minimal visual regression testing in MRs
|
When creating an MR, the `visual` job runs in every pipeline and tests all of GitLab UI's components.
Generally, an MR only changes a single component though. There is a possibility that one component is being used in others, and that changing it would affect other visual tests indirectly. But in most cases, it should be reasonable to run visual tests only for the component being changed. At least until the initial approval at which point we should run a full pipeline to make sure all visual tests are still green.
Let's improve our CI setup so that MR pipelines only run storyshots on the changed `*.stories.js` files by default.
| 2 |
7,071,551 | 100,418,329 |
2022-01-11 10:55:29.928
|
GlEmptyState: Text overflows illustration
|
In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2581, we converted a few Bootstrap utilities to GitLab UI ones in `GlEmptyState`. In the process, we applied a `gl-flex-wrap` class to the main container, which preserves some styles from the `.row` util, but is causing some display issues due to the illustration's container not inheriting the `width: 100%` from the `col-*` class we removed.
| 1 |
7,071,551 | 100,407,544 |
2022-01-11 08:52:53.413
|
GlPopover: Add support for a close button
|
In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/64540, we implemented a popover that appears on page load and that can be closed with a close button displayed in its header:
<img src="https://gitlab.com/gitlab-org/gitlab/uploads/f5cecda79a81f728bcaee9b14559434c/Screen_Shot_2022-01-10_at_2.06.07_PM.png" width="450" />
The implementation was done entirely in GitLab by adding some style overrides there, as well as rendering the close button via the `#title` slot.
As part of https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1465, we later moved the style overrides to GitLab UI, but the close button itself is still being implemented in GitLab.
## Proposal
Having style overrides for a close button that does not exist in GitLab feels a bit odd. Let's add out-of-the-box support for a close button in `GlPopover`.
Here are a few things to consider:
- [x] The close button should be a `small` button using the `close` icon. The GitLab implementation relies on a `<span class="gl-display-inline-block" aria-hidden="true">×</span>` to render the `X`, which doesn't align with the design specs.
- [x] Re-adjust the spacing to account for the change above.
- [x] The close button's visibility should be controlled by a prop (eg. `has-close-button`).
- [ ] Once the close button is implemented, remove all custom code from `ee/app/assets/javascripts/contextual_sidebar/components/trial_status_popover.vue` in favor of using the built-in feature.
cc @dreedy @kcomoli
| 2 |
7,071,551 | 100,359,316 |
2022-01-10 12:14:15.343
|
Limit drawer component to 100% width on smaller devices
|
On smaller devices, it has been noted that the drawer component can overflow if the width of the device is smaller than the width of the drawer as defined in: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/drawer/drawer.scss.
The CSS is defining a small breakpoint width of `gl-w-full` but appears to be overridden by the `gl-drawer-default` and `gl-drawer-sidebar` classes as they have higher specificity.
## Implementation Guide
The simplest fix would be to make sure the small breakpoint is given to these classes as well
| 1 |
7,071,551 | 100,358,964 |
2022-01-10 12:08:09.730
|
Move .gl-md-pr-5 classes to gitlab-ui
|
The MR https://gitlab.com/gitlab-org/gitlab/-/merge_requests/77012 adds the `gl-md-pr-5` class in GitLab, this should be moved to GitLab UI.
Once the class has been added to GitLab UI we can then remove it from the main GitLab codebase https://gitlab.com/gitlab-org/gitlab/-/issues/350247.
| 1 |
7,071,551 | 100,262,276 |
2022-01-07 15:45:16.566
|
Enable eslint-plugin-storybook
|
Storybook now provides an official ESLint plugin to ensure stories are written properly: https://github.com/storybookjs/eslint-plugin-storybook.
It currently reports errors for all stories that haven't been migrated to CSF yet, which is expected.
Let's enable this plugin sometime soon. This could be done now by ignoring offenses in non-CSF stories, or we could also wait until the migration is done.
Recommended setup in `.eslintrc.yml`:
```yaml
extends:
- 'plugin:storybook/csf'
```
| 1 |
7,071,551 | 100,616,823 |
2021-12-21 15:56:33.292
|
Clearing a token from gl-filtered-search immediately starts editing prior token name
|
I want to remove a label filter and add a different one. I click the X, but it then starts immediately editing the prior label name. If I hit space, it strangely auto selects a different label. See below video for example.
I feel like clearing using the X should leave the prior label filter in place and allow you to start adding a new one.
| 2 |
7,071,551 | 98,852,851 |
2021-12-10 20:17:38.172
|
Add max-w-26 & max-w-62
|
In support of [this Growth experiment](https://gitlab.com/groups/gitlab-org/-/epics/3695) ([MR which adds these utility classes](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75148/diffs)), if the experiment is successful & is promoted, we would like to add the following utility CSS styles:
```scss
.gl-max-w-26 {
max-width: $grid-size * 26;
}
.gl-max-w-62 {
max-width: $grid-size * 62;
}
```
(Or something akin to that.)
| 1 |
7,071,551 | 101,177,127 |
2021-12-09 18:32:10.740
|
GlFilteredSearch problems with editing, issue filter bar
|
The issues page, which uses `GlFilteredSearch`, is having difficulty with simple editing such as cursor movement via key or clicking.
Video shows the behavior I'm seeing.
I consider this a semi-serious usability issue.
| 3 |
7,071,551 | 97,809,717 |
2021-11-23 13:32:38.227
|
GlDisclosure: First iteration of a Disclosure
|
In order to reduce the complexity of our existing GlDropdown implementation, we want to implement a semantically correct GlDisclosure component.
> Disclosure: A disclosure dropdown is a button that toggles a panel containing a list of links or navigational items where each item has its own tab stop. If a dropdown contains both a link and an action, it should be a disclosure with a tab stop for each item.
https://design.gitlab.com/components/dropdown-disclosure
| 5 |
7,071,551 | 97,212,914 |
2021-11-12 05:58:59.837
|
Set `type="search"` on input fields for SearchBoxByType and SearchBoxByClick
|
### Description
`SearchBoxByType` and `SearchBoxByClick` are search boxes, but we don't set the `type` HTML attribute to `"search"`. This means (among other things) that screenreaders interpret the box as a regular text field, not a search field.
Example:
When this input field is focused, Apple Voiceover produces the following output:
| Current state | with type="search" |
| ------ | ------ |
| `Search or jump to..., edit text` | `Search or jump to..., search text field` |
`type="search"` yields better accessibility.
#### Concerns
When making this change, we must check all supported browsers. Each browser styles `type="search"` fields differently, and we need to ensure our gitlab-ui styles are not affected by the change.
### Checklist
Make sure the following are completed before closing the issue:
1. [ ] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, update `followsDesignSystem:` with the correct value inside the `[component].documentation.js` file.
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[pajamas-mr]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/new
[pajamas-issue]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[adding-components]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_components.md
[adding-css]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_css.md
[breaking-changes]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/breaking_changes_to_components.md
[eng-week-in-review-doc]: https://docs.google.com/document/d/1GQbnOP_lr9KVMVaBQx19WwKITCmh7H3YlgO-XqVwv0M/edit
| 1 |
7,071,551 | 96,292,045 |
2021-10-28 03:08:59.733
|
Gl-Empty-State > Make "title" not required
|
There are a couple of instances in the code base where a `title` is unwanted
Remove `title`'s required status
- Instances
- https://gitlab.com/gitlab-org/gitlab/blob/master/app/assets/javascripts/jira_import/components/jira_import_setup.vue
- https://gitlab.com/gitlab-org/gitlab/blob/80f1ea7e3f11063a4f15bdd4a2e4a1ca7f770d87/app/assets/javascripts/monitoring/components/empty_state.vue
- https://gitlab.com/gitlab-org/gitlab/blob/2f57df6053e2e8dea8a0b1d6c477d761aad23468/ee/app/assets/javascripts/threat_monitoring/components/policy_editor/scan_execution_policy/scan_execution_policy_editor.vue
| 3 |
7,071,551 | 95,618,089 |
2021-10-18 14:24:22.014
|
Enhance GlTable component to return GlTableLite if circumstances allow
|
In [32.14.0](https://gitlab.com/gitlab-org/gitlab-ui/-/releases/v32.14.0) GlTableLite was introduced to GitLabUI.
GlTableLite supports a subset of the features GlTable does, but is much lighter on the pagebundle.
All those features which are not supported in GlTableLite are triggered via Props in GlTable.
### What needs to be done
Enhance the GlTable component so that it checks for the need of a GlTable and if not return a GlTableLite, this will have a great effect on our overall Page Bundles.
Implementation Plan:
- [ ] Check props in GlTable Lite
- [ ] Return the best fit for given props (GlTable or GlTableLite)
| 3 |
7,071,551 | 95,366,358 |
2021-10-13 14:40:13.444
|
Breadcrumb > Identify current page with aria-current
|
The active page link (last item in the breadcrumb) should have `aria-current="page"` to indicate that it's the current page.
See https://www.w3.org/TR/wai-aria-practices/examples/breadcrumb/index.html for an example.
| 3 |
7,071,551 | 95,102,062 |
2021-10-08 10:56:02.874
|
GlDaterangePicker CSF - datepicker cut inside story container
|
This was raised in the review of !2415
After migration to CSF open datepicker is hidden inside the story container - the container is scrollable though to accommodate its content
To reproduce
1. Go to [daterange picker story](http://localhost:9001/?path=/docs/base-daterange-picker--default)
1. Open docs tab
1. Note that open datepicker is displayed cut inside the story container - the container should either expand ot datepicker should be displayed over it as before the migration
| Before | After |
| ------ | ------ |
|  |  |
| 1 |
7,071,551 | 94,783,965 |
2021-10-04 09:15:07.082
|
Date picker - add disabled cursor to month/year/arrows/days
|
# Problem
Currently, there is no disabled cursor for the disabled buttons of the date picker. Related to #1563.
# Proposal
Add the cursor!
| 1 |
7,071,551 | 94,783,593 |
2021-10-04 09:10:31.238
|
Date picker - add hover state to arrows
|
# Problem
Date picker arrows don't look interactive. Related to #1561.
# Proposal
Add hover state to calendar arrow buttons.
| 1 |
7,071,551 | 94,676,145 |
2021-09-29 10:36:14.286
|
Date picker - make month/year look more interactive
|
# Problem
- The date picker has a dropdown for the month and year and nobody knows about it!
- Related to gitlab-org/gitlab-services/design.gitlab.com#601. From this thread: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/601#note_689319507
# Proposal
- Use a similar pattern to the sidebar - with a tertiary button that goes to `gray-50` on-hover to show interaction...
# Other ideas
| 1 |
7,071,551 | 92,978,362 |
2021-09-02 07:15:08.067
|
Audit and prevent `v-html` usages
|
Related epic - https://gitlab.com/gitlab-com/gl-security/appsec/appsec-team/-/issues/184
### Proposal
We should add an ESLint rule to prevent usage of `v-html` in the codebase.
### Why
`v-html` is bad and can lead to XSS attacks https://vuejs.org/v2/api/#v-html
### Goal
Our aim is to make sure we don't use `v-html` for any new codebase and audit every possible usage of `v-html` being used.
### Implementation Plan
* [ ] Add `vue/no-v-html` rule in eslint
* [ ] Audit existing `v-html` usages
* [ ] Replace `v-html` with `v-safe-html`
### Outcome
- Two usages found
- [`src/components/base/form/form_checkbox/form_checkbox_group.vue`](https://gitlab.com/gitlab-org/gitlab-ui/blob/ec54f68fcda42481bd8f967026644d4bb2676a75/src/components/base/form/form_checkbox/form_checkbox_group.vue#L35)
- [`src/components/base/form/form_checkbox/form_checkbox_group.vue`](https://gitlab.com/gitlab-org/gitlab-ui/blob/ec54f68fcda42481bd8f967026644d4bb2676a75/src/components/base/form/form_checkbox/form_checkbox_group.vue#L35)
| 2 |
7,071,551 | 92,590,100 |
2021-08-25 18:33:03.882
|
Avatar > Stacked (inline) avatars > Update to match new Figma specs
|
### Description
The stacked (inline) avatar component was [recently updated in Figma](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1104).
Subsequently, https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-avatar-avatars-inline--default also needs updating to match the new style.
#### Figma file
<!-- If design specs exist in Figma, link them below. Otherwise, remove the link and add a link to the issue to add the component to Figma -->
[View design specs in Figma →](https://www.figma.com/file/qEddyqCrI7kPSBjGmwkZzQ/Component-library?node-id=1833%3A2791)
### Checklist
Make sure the following are completed before closing the issue:
1. [x] Assign the correct component label to this issue.
1. [ ] Create an MR with the additions or updates needed.
1. [ ] Be sure to get your MR reviewed by a [FE/UX Foundations designer][foundations-team].
1. [ ] When applicable, update `followsDesignSystem:` with the correct value inside the `[component].documentation.js` file.
1. [ ] When applicable, create an [MR in Pajamas][pajamas-mr] to update the demos. If you do not have capacity to complete the demos, [create an issue in Pajamas][pajamas-issue] and bring the issue to your team planning session for prioritization and scheduling. Mark the issue as related to this one.
1. [ ] When applicable, [create an MR in Pajamas][pajamas-mr] to update the component status.
1. [ ] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Component Documentation"][pajamas-component-documentation-template] issue template to update guidelines. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [x] When applicable, [create an issue in Pajamas][pajamas-issue] using the ["Figma update"][pajamas-figma-update-template] issue template to update the Figma UI Kit. Ping a designer on your team for awareness and bring the issue to your team planning meeting for prioritization and scheduling.
1. [ ] When introducing a major or breaking change, communicate the changes within the [Engineering Week in Review][eng-week-in-review-doc].
1. [ ] 🎉 Congrats, you made it! You can now close this issue.
<!--
### Resources
* [Compontent Lifecycle][component-lifecycle]
* [Adding component][adding-components]
* [Adding CSS][adding-css]
* [Breaking changes][breaking-changes]
-->
[foundations-team]: https://about.gitlab.com/company/team/?department=fe-ux-foundations-team
[pajamas-mr]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/new
[pajamas-issue]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new
[pajamas-component-documentation-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Component%20documentation
[pajamas-figma-update-template]: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/new?issuable_template=Figma%20update
[component-lifecycle]: https://design.gitlab.com/get-started/lifecycle
[adding-components]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_components.md
[adding-css]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/adding_css.md
[breaking-changes]: https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/breaking_changes_to_components.md
[eng-week-in-review-doc]: https://docs.google.com/document/d/1GQbnOP_lr9KVMVaBQx19WwKITCmh7H3YlgO-XqVwv0M/edit
| 1 |
7,071,551 | 92,261,649 |
2021-08-19 10:58:16.870
|
Fix size prop on GlButtonGroup
|
In https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2339#note_654465742 it was discovered that the `size` prop on `GlButtonGroup` doesn't work.
That is, if you supply `sm`, `md` or `lg`, you get styles inconsistent with our design system. If you supply `small` or `medium` (the supported `GlButton` sizes), nothing happens.
## Implementation Guide
Supply the `size` prop directly to the `GlButton` children.
Since `BButtonGroup` is so simple, we could re-implement it completely in GitLab UI to fix this, _if_ we want to.
It's a little more complex, but the better solution.
| 1 |
7,071,551 | 92,062,407 |
2021-08-16 19:18:55.852
|
Dropdown: Support different dropdown use cases with variants
|
## Purpose
As a result of the audit in the parent epic, the dropdown component requires updates to satisfy UX and accessibility requirements.
**Watch recordings of the audit** (internal)
1. [▶︎ Code and semantic review](https://drive.google.com/file/d/1z-Epc8tTuH32PzPq6Pr9jrOqI9KKXbNx/view?usp=sharing)
1. [▶︎ Screen reader demo](https://drive.google.com/file/d/12K20wzxrMuMrAq4T4HNXC_MiDXhE8NlO/view?usp=sharing)
## Background
A dropdown can actually mean many things, from a select element in a form to navigation or a menu of functions. As it's defined in [Pajamas](https://design.gitlab.com/components/dropdown#usage), it indeed is used for several different things:
- Opening a list of navigation items.
- Opening a menu of actions.
- Opening a listbox or combobox.
The current implementation of a [dropdown](https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-dropdown--default) in GitLab UI is specific to only one of these use cases, a menu. And the menu itself comes with many caveats and has implications for assistive technology (covered under definitions below). Additionally, I believe that the audit uncovered problems with the semantic structure of the current implementation. More details are in the audit recordings, but as a quick summary the unordered list semantics don't include a list item as the first child, and additionally `role="menu"` requires some fairly strict semantics that I don't believe are 100% correct.
### Definitions
<details><summary>Menu</summary>
A menu is a widget that offers a list of choices to the user, such as a set of actions or functions. A menu is usually opened, or made visible, by activating a menu button, choosing an item in a menu that opens a sub menu, or by invoking a command, such as Shift + F10 in Windows, that opens a context specific menu. When a user activates a choice in a menu, the menu usually closes unless the choice opened a submenu. ([source](https://www.w3.org/TR/wai-aria-practices/#menu))
An item with `role="menu"` places a screen reader in application mode, which then uses keyboarding different from regular web browsing and navigation. For this reason it isn't suitable for navigation where tabbing typically moves from one link to the next.
</details>
<details><summary>Disclosure widget</summary>
A disclosure is a button that controls visibility of a section of content. When the controlled content is hidden, it is often styled as a typical push button with a right-pointing arrow or triangle to hint that activating the button will display additional content. When the content is visible, the arrow or triangle typically points down. ([source](https://www.w3.org/TR/wai-aria-practices/#disclosure))
</details>
<details><summary>Menu button</summary>
A menu button is a button that opens a menu. It is often styled as a typical push button with a downward pointing arrow or triangle to hint that activating the button will display a menu. ([source](https://www.w3.org/TR/wai-aria-practices/#menubutton))
</details>
<details><summary>Combobox</summary>
A combobox is a widget made up of the combination of two distinct elements: 1) a single-line textbox, and 2) an associated pop-up element for helping users set the value of the textbox. The popup may be a listbox, grid, tree, or dialog. Many implementations also include a third optional element -- a graphical button adjacent to the textbox, indicating the availability of the popup. Activating the button displays the popup if suggestions are available. (https://www.w3.org/TR/wai-aria-practices/#combobox)
</details>
<details><summary>Listbox</summary>
A listbox widget presents a list of options and allows a user to select one or more of them. A listbox that allows a single option to be chosen is a single-select listbox; one that allows multiple options to be selected is a multi-select listbox. ([source](https://www.w3.org/TR/wai-aria-practices/#Listbox))
</details>
## Proposal
As-is, a single format for a dropdown will not satisfy the different use cases. The dropdown component should configurable to support various use cases.
## Resources
- [Menus & Menu Buttons](https://inclusive-components.design/menus-menu-buttons/) by Heydon Pickering
- [Link + Disclosure Widget Navigation](https://adrianroselli.com/2019/06/link-disclosure-widget-navigation.html) by Adrian Roselli
- [A11y Nav Menus – an in-depth overview of three patterns for accessible navigation](https://www.evinced.com/blog/a11y-nav-menus/) by Illai Zeevi
- [Menu (or not)](https://marcus.io/blog/menu-or-not) by Marcus Herrmann
Additional implementation examples and resources are mentioned in the [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1534#note_653127372) that follows.
| 8 |
7,071,551 | 91,793,592 |
2021-08-11 07:46:11.827
|
Rename newButton* constants to button*
|
The following discussion from !2332 should be addressed:
- [ ] @pgascouvaillancourt started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2332#note_648261333):
> **thought:** It would be great if we could rename those `newButton*` constants to `button*` now that we only have one button component. But let's do that in a follow-up :slight_smile:
| 1 |
7,071,551 | 90,925,175 |
2021-07-27 14:17:29.591
|
GFM Typescale > Inline diff > implement
|
Implement GitLab Flavored Markdown inline diff styles following the design specs created in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1076
See parent epic for detailed information about this component.
Figma assets:
- [Documentation markdown - Inline diff](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=988%3A10)
- [Compact markdown - Inline diff](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=893%3A4)
### Implementation guidelines
- The markdown typescale implementation file is in [`src/components/base/markdown/markdown.scss`](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/markdown/markdown.scss#L1)
- Add compact markdown variation as a child class selector of `.gl-compact-markdown`
- Use the following CSS selectors to ensure compatibility with GitLab Flavored Markdowns
- `idiff`
- `idiff.deletion` for deletion styles
- `idiff.addition` for addition styles
- Add a demo of this component in `src/components/base/markdown/markdown_typescale_demo.html`.
| 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.