idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
|---|---|---|---|---|---|
7,071,551 | 90,843,324 |
2021-07-26 12:10:43.020
|
GFM Typescale > Code block > implement
|
Implement GitLab Flavored Markdown code span styles following the design specs created in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1068
See parent epic for detailed information about this component.
Figma assets:
- [Documentation markdown - Code block](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=985%3A10)
- [Compact markdown - Code block](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=890%3A8)
### Implementation guidelines
- The markdown typescale implementation file is in [`src/components/base/markdown/markdown.scss`](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/markdown/markdown.scss#L1)
- This component shares font styling with the [`gl-monospace` class selector](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/markdown/markdown.scss#L121)
- Add compact markdown variation as a child class selector of `.gl-compact-markdown`
- Use the following CSS selectors to ensure compatibility with GitLab Flavored Markdown:
- `pre`
- `pre code`
- Add a demo of this component in `src/components/base/markdown/markdown_typescale_demo.html`.
| 1 |
7,071,551 | 90,680,039 |
2021-07-22 12:50:37.246
|
GFM Typescale > Code span > implement
|
Implement GitLab Flavored Markdown code span styles following the design specs created in https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/1048
See parent epic for detailed information about this component.
Figma assets:
- [Documentation markdown - Code span](https://www.figma.com/file/V3HKN83B7rf2T6sseLMrxa/Type-scale---Documentation-Markdown?node-id=909%3A10)
- [Compact markdown - Code span](https://www.figma.com/file/mjAZxHkK95TlQ6L14aNp2M/Type-scale---Compact-Markdown?node-id=862%3A4)
### Implementation guidelines
- The markdown typescale implementation file is in [`src/components/base/markdown/markdown.scss`](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/markdown/markdown.scss#L1)
- Use the following CSS selector to implement these styles: `code`
- This component shares font styling with the [`gl-monospace` class selector](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/markdown/markdown.scss#L121)
- Add compact markdown variation as a child class selector of `.gl-compact-markdown`
- Add a demo of this component in `src/components/base/markdown/markdown_typescale_demo.html`.
| 1 |
7,071,551 | 90,184,132 |
2021-07-13 09:17:10.691
|
Ensure GlSingleStat animates when data is changed
|
### Problem
With the introduction of `animateOnMount` being `false` for the animated number utility in gitlab-ui, an animation is only triggered on the `GlSingleStat` component when the value prop is changed, after the component has been mounted.
Our current implementations of `GlSingleStat` conditionally render and remove the component based on the loading states of API requests, which instead of resulting in a simple prop update, results in an entire component remount. This causes the animation to never be triggered.
### Solution
We can refactor our implementations of `GlSingleStat` from using `v-if` to `v-show`. This will ensure that the component only mounts once and each subsequent update triggers a prop update instead of a component remount.
### Steps
- Inspect each instance of `GlSingleStat`
- Where updates to data can occur, i.e. filters available etc, replace `v-if` with `v-show`
- Update tests as these will break on `exists`
#### Notes
There are 6 instances of `GlSingleStat` looks like 3 or 4 instances are subject to data changes requiring animation.
| 3 |
7,071,551 | 90,159,804 |
2021-07-13 00:37:01.272
|
Add CSS utility class for setting mix-blend-mode to luminosity
|
To make some images (SVGs) go from their color version to grayscale, we’d like to introduce a utility for setting the `mix-blend-mode`:
```scss
.gl-mix-blend-mode-luminosity {
mix-blend-mode: luminosity;
}
```
| 1 |
7,071,551 | 90,126,309 |
2021-07-12 13:11:41.035
|
Add utility class for focus rings
|
## Problem to solve
There are no utility classes to add just the focus ring around buttons and inputs.
## Proposed solution
Add a utility class for button & input focus ring styles.
| 1 |
7,071,551 | 89,932,783 |
2021-07-07 23:14:36.640
|
Add CSS utility class for setting a min-width of scale * 7 and/or * 8
|
As part of the cleanup of [this experiment](https://gitlab.com/groups/gitlab-org/-/epics/6300) – specifically [this line from gitlab!61639](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61639/diffs#fb723e851b8926f6532eeed94f1de1874c3221c7_243_250) – we would like to add a utility class for setting the min-width to `32px`, which is `$gl-spacing-scale-7`, and/or another for setting the min-width to `40px`, which is `$gl-spacing-scale-8`.
```scss
.gl-min-w-7 {
min-width: $gl-spacing-scale-7;
}
.gl-min-w-8 {
min-width: $gl-spacing-scale-8;
}
```
| 1 |
7,071,551 | 89,932,738 |
2021-07-07 23:10:47.678
|
Add utility CSS class for setting width of $grid-size × 28
|
As part of the cleanup of [this experiment](https://gitlab.com/groups/gitlab-org/-/epics/6300) – specifically [this line from gitlab!61639](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61639/diffs#fb723e851b8926f6532eeed94f1de1874c3221c7_243_245) – we would like to add a utility class for setting the width to `224px`, which is `$grid-size * 28`.
```scss
$gl-spacing-scale-28: 28 * $grid-size;
.gl-w-28 {
width: $gl-spacing-scale-28;
}
```
We could also follow another pattern found in the `gitlab-org/gitlab` project’s `utilities.scss` file:
```scss
.gl-w-grid-size-28 {
width: $grid-size * 28;
}
```
| 1 |
7,071,551 | 89,878,956 |
2021-07-07 06:46:16.727
|
Single stat - add option for adding/removing hover state
|
# Problem
From https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1407#note_611185618 - Hover state on single stat is confusing when there are no popovers.
# Proposal
Add option for adding/removing hover state depending on whether there is a popover.
| 1 |
7,071,551 | 89,605,554 |
2021-07-01 11:47:39.621
|
Fix vue/no-deprecated-slot-attribute violation(s) in src/components/charts/tooltip/tooltip.vue
|
The file [`src/components/charts/tooltip/tooltip.vue`](https://gitlab.com/gitlab-org/gitlab-ui/-/tree/adea5ac1e4513c72153a773621cc495a9bf219cb/src/components/charts/tooltip/tooltip.vue) violates the [recently](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2269) enabled [`vue/no-deprecated-slot-attribute` rule](https://eslint.vuejs.org/rules/no-deprecated-slot-attribute.html#vue-no-deprecated-slot-attribute).
Migrating to the newer slot syntax is a requirement for us to be able to adopt Vue 3.
## What to do
In broad strokes, migrating this component will involve:
1. Updating the template to use the newer slot syntax
1. Fixing tests and/or adding tests in GitLab UI
1. Creating an integration MR with GitLab, and fixing _its_ tests
### Updating the template
This is the easy part! It's usually as simple as one of these example diffs:
```diff
- <template slot="first">
+ <template #first>
```
```diff
- <div slot="foo">Slot content</div>
+ <template #foo>
+ <div>Slot content</div>
+ </template>
```
```diff
- <slot slot="foo" name="foo">Slot default content</slot>
+ <template #foo>
+ <slot name="foo">Slot default content</slot>
+ </template>
```
```diff
- <slot v-for="slot in Object.keys($slots)" :slot="slot" :name="slot"></slot>
+ <template v-for="slot in Object.keys($slots)" #[slot]>
+ <slot :name="slot"></slot>
+ </template>
```
```diff
- <slot v-for="slot in Object.keys($scopedSlots)" :slot="slot" :name="slot" slot-scope="scope"></slot>
+ <template v-for="slot in Object.keys($scopedSlots)" #[slot]="scope">
+ <slot :name="slot" v-bind="scope"></slot>
+ </template>
```
Some components will require more work if they have conditional slot rendering.
### Fixing GitLab UI tests
1. If there are no failing tests, verify that the slot content is actually being tested somehow, and write a new test covering this if not.
1. If there are failing tests, fix them!
### Creating an integration MR with GitLab
1. Once your MR for GitLab UI is in good shape, create an [integration MR against GitLab](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/doc/contributing/gitlab_integration_test.md#using-the-remote-development-package) using the `create_integration_branch` manual CI job.
1. Fix any test failures.
| 2 |
7,071,551 | 89,435,701 |
2021-06-28 22:54:01.652
|
Lint all Markdown files with markdownlint
|
Let's enforce consistent rules for writing documentation in GitLab UI. We recently [setup markdown lint](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2250), but a lot of `.md` files aren't being linted yet.
- [x] Include all `.md` files in the lint script (except for `CHANGELOG.md` which is auto-generated).
- [x] Fix all formatting errors.
| 2 |
7,071,551 | 89,192,962 |
2021-06-23 19:22:11.609
|
Add .gl-font-size-inherit
|
```scss
.gl-font-size-inherit { font-size: inherit; }
```
Used instead of the existing `.font-size-inherit` utility as part of https://gitlab.com/gitlab-org/gitlab/-/merge_requests/64540
| 1 |
7,071,551 | 89,192,826 |
2021-06-23 19:19:28.280
|
Add styles for .gl-button.close in .gl-popover .popover-header
|
```scss
.gl-popover {
.popover-header {
.gl-button.close {
margin-top: -$gl-spacing-scale-3;
margin-right: -$gl-spacing-scale-4;
}
}
}
```
Used as part of https://gitlab.com/gitlab-org/gitlab/-/merge_requests/64540
| 1 |
7,071,551 | 88,748,757 |
2021-06-15 13:32:53.144
|
Setup lefthook
|
We should setup `lefthook` to run linters in a pre-commit or pre-push Git hooks in order to catch formatting issues before they trigger a pipeline on the remote.
| 2 |
7,071,551 | 88,118,316 |
2021-06-02 17:38:36.000
|
Follow-up from "feat(echarts): update to echarts@5"
|
The following discussion from !2185 should be addressed:
- [ ] @leipert started a [discussion](https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2185#note_565928329): (+5 comments)
> Seems like there is a significant diff on the timelines...
## What's this issue about
Currently the only chart component that sets the options related to a chart's zoom-bar in accordance with the [design specs](https://www.figma.com/file/17NxNEMa7i28Is8sMetO2H/Data-Visualization?node-id=63%3A697) is `GlLineChart`.
https://gitlab.com/gitlab-org/gitlab-ui/-/merge_requests/2185 removes the option that controls this will be removed from the line-chart component.
In order to keep the existing functionality aligned to the design-specs and increase overall consistency, this MR moves the zoom-bar options into the globally shared chart's theme.
### Components affected
* `GlAreaChart`
* `GlBarChart`
* `GlColumnChart`
* `GlDiscreteScatterChart`
* `GlLineChart`
* `GlStackedColumnChart`
| current implementation | design |
| ------ | ------ |
|  |  |
Here's the design spec: https://www.figma.com/file/17NxNEMa7i28Is8sMetO2H/Data-Visualization?node-id=63%3A697
## Steps to reach this chart
1. `yarn storybook` to start a local development server
2. Open the browser
3. On the left navigation menu, find **Charts** > **Line Chart** > **With zoom and scroll** (or simply visit `?path=/story/charts-line-chart--with-zoom-and-scroll`)
## Implementation plan
1. `src/utils/charts/theme.js` seems to contain a `dataZoom` property. My initial guess is that this property can be used to define a background color for the highlight. You can check the eCharts docs here: https://echarts.apache.org/en/option.html#title
| 2 |
7,071,551 | 88,115,395 |
2021-06-02 16:22:24.310
|
GlAvatar: Identicon fallback inconsistent with GitLab implementation
|
## What/Why
Found as part of https://gitlab.com/gitlab-org/gitlab/-/merge_requests/62419
The classes and colors used for the `identicon` component in GitLab are different than here in GitLab UI. I am unclear on which is correct so part of this issue if determining **where** to fix this.
GitLab UI does its class calculations in the [avatar.vue](https://gitlab.com/gitlab-org/gitlab-ui/-/blob/main/src/components/base/avatar/avatar.vue) file. <br />
GitLab does its class calculations in the [avatar_helper.js](https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/helpers/avatar_helper.js) file.
## Examples of inconsistencies
**Background color**
- GitLab UI class `.gl-avatar-identicon-bg7` => `#bfbfbf ($gray-200)`
- GitLab class `.identicon.bg7` => `#eee ($identicon-gray)`
**Font color (Single Letter)**
- GitLab UI class `.gl-avatar-identicon` => `#303030 ($gl-text-gray-900)`
- GitLab class `.identicon` => `#525252 ($identicon-text-color)`
## Screenshot
| GitLab | GitLab UI |
| ------ | ------ |
|  |  |
## Proposal
I would like to determine which color set is correct so that we can update the other to match the styles. There is a huge upside in depending on `GlAvatar` to handle the `identicon` fallback as it really cleans up the template. However, until we clean up the old usages of `identicon` we want to be sure to keep these color patterns inline as they help users identify their projects/groups at a glance.
cc/ @nickbrandt
| 1 |
7,071,551 | 89,409,518 |
2021-05-26 16:06:54.695
|
GlTable > Set rows primary hover background to match design sytem
|
This follows up on @cam.x's comment: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/62134#note_580549583
In the **Threat Monitoring** app, policy rows' background color on hover should be `#e9f3fc` (`blue-50`).
Let's update `GlTable`'s styles to align with the design system.
| 1 |
7,071,551 | 87,387,951 |
2021-05-19 19:16:13.725
|
GlDrawer's close button should be top-aligned
|
Currently, `GlDrawer`'s close button is vertically centered in the header. Here's an example of how it looks in **Threat Monitoring**:
According to some ~"group::container security" [designs](https://gitlab.com/gitlab-org/gitlab/-/issues/267346/designs/3b_drawer_container.png), and to the [Sketch exports](https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/drawer-spec-previews/), the close button should be aligned to the top of the header.
Let's update `GlDrawer` to match the specs.
| 2 |
7,071,551 | 87,068,165 |
2021-05-14 07:14:10.299
|
GlSingleStat: Fade in units when animation is complete
|
When `GlSingleStat` has `shouldAnimate=true` we should fade in units once the animation is complete.
This was brought up in https://gitlab.com/gitlab-org/gitlab/-/issues/329702#note_567594091
| 2 |
7,071,551 | 87,063,176 |
2021-05-10 03:03:50.384
|
Make table sorting options more obvious
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label:
- https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=regression
- https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
Following on from discussion in https://gitlab.com/gitlab-org/gitlab/-/issues/301082#note_570459360, are there options we can explore to make the table sorting more obvious to users?
> Ahh, I have to click on the Time column for the arrow to display. It wasn't obvious to me that sorting by the Time column
> was even an option because I didn't see the arrow.
>
> 
>
> I wonder if there is some way to make this more obvious @ekigbo ?
> This feels familiar like it tripped me up once before in the UI. Ah yes, in the DevOps Adoption table.
>
> @npost Do we have any other design options for sorting?
### Proposal
Add blue hover highlighting as described in [@ameliabauerly's comment](https://gitlab.com/gitlab-org/gitlab/-/issues/330464#note_571675576)
| 1 |
7,071,551 | 86,314,582 |
2021-05-01 07:59:58.859
|
Replace Node Sass (node-sass) with Dart Sass (sass) in JavaScript
|
- [x] [plentycode/sass-export#69](https://github.com/plentycode/sass-export/issues/69)
- [x] ~~!2175: Update sass-export to 2.1.0 to partially migrate to sass~~
- [x] !2846: Update sass-export to 2.0.1 to partially migrate to sass
- [x] !2176: Replace node-sass with sass
Part of &5923
| 32 |
7,071,551 | 86,264,890 |
2021-04-30 06:35:40.768
|
VSA - Add light gray background to metrics on hover
|
Follow-up from https://gitlab.com/gitlab-org/gitlab/-/merge_requests/59732#note_563635269
Let's add a light gray background (`gray-50` when hovering over a metric in group-level VSA.
/cc @npost
| 1 |
7,071,551 | 85,809,015 |
2021-04-23 10:38:51.214
|
GlTabs > flaky visual test: tabs-with-scroll-and-growing-1-diff
|
The `tabs-with-scroll-and-growing-1-diff` story seems to be flaky as it's been causing the `visual` job to fail inconsistently.
https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/1204315526
| 1 |
7,071,551 | 85,729,888 |
2021-04-22 09:50:15.191
|
Group Overview Analytics: Replace metric card with single stat
|
Let's replace the existing metric card on the group overview page with the `GlSingleStat` component.
| 1 |
7,128,869 | 16,190,013 |
2018-11-28 16:18:45.264
|
Add pagination to insight-ui
|
- Bump jwt lifetime to 1 hour (so we have a workaround for pagination/timeout interactions)
- A user can view multiple pages of insight logs
- Resolve differences in api parameters
Frontend sends POST request in the following format
**REQUEST**
```JavaScript
METHOD: POST
Request URL: `https://${insight_log_endpoint}/fetch?page=0&rowsPerPage=10`
Parameters: page=0 & rowsPerPage=10
Request Headers:{
Content-type: application/json
}
Request Payload:{
JWT-Base64-token
}
```
**Expected RESPONSE**
```JavaScript
{
records:[{...},{...}],
page: 0,
rowCount: 2
}
```
| 2 |
7,128,869 | 16,189,995 |
2018-11-28 16:17:51.070
|
Add pagination to insight-api (backend)
|
Frontend sends POST request in the following format
**REQUEST**
```JavaScript
METHOD: POST
Request URL: `https://${insight_log_endpoint}/fetch?page=0&rowsPerPage=10`
Parameters: page=0 & rowsPerPage=10
Request Headers:{
Content-type: application/json
}
Request Payload:{
JWT-Base64-token
}
```
**Expected RESPONSE**
```JavaScript
{
records:[{...},{...}],
page: 0,
rowCount: 2,
rowsPerPage: 10
}
```
| 2 |
7,128,869 | 16,187,374 |
2018-11-28 14:46:17.485
|
Demo: Create content for all steps
| null | 5 |
7,128,869 | 16,187,328 |
2018-11-28 14:44:20.860
|
Demo: Create needed components
|
* [ ] Stepper
* [x] Title (design system)
* [x] Button (design system)
* [x] Small (design system)
* [x] Paragraph (design system)
Stepper: Quick solution (later pas opnemen in de common-ui library, om nu tijd te winnen)
| 8 |
7,128,869 | 16,187,302 |
2018-11-28 14:43:00.487
|
Demo: Finalize design and structure of content
| null | 5 |
7,128,869 | 16,179,692 |
2018-11-28 10:49:05.535
|
Deploy common-ui to design-system.nlx.io
|
Common-ui should contain a Dockerfile that builds a static version of the Storybook and automatically deploys it to design-system.nlx.io.
| 5 |
7,128,869 | 16,157,729 |
2018-11-27 15:49:08.242
|
Invalid URL to x-road on nlx.io
|
```$ muffet https://nlx.io
https://nlx.io/about/
404 https://www.x-road.com
```
There's an invalid link to www.x-road.com, which is not an existing webpage.
| 1 |
7,128,869 | 16,144,782 |
2018-11-27 10:30:15.580
|
Create and use strict TLS configuration in all communication between components
|
**As a**
<br>**I want to**
<br>**so that**
**:white\_check\_mark: Acceptance criteria**
1. All components use a secure TLS configuration
1. TLS configuration can be managed in one separate package
1. Link to TLS config from docs
**:hammer\_and\_wrench: Proposed technical solution**
* Create a `common` package that sets the security parameters on a `*tls.Config` to strict values. Only the latest TLS and best ciphers. This only applies to communication between components we build.
**:link: Reference links**
*
| 3 |
7,128,869 | 16,068,101 |
2018-11-23 13:20:12.100
|
Remove sorting in Insight app
|
Sorting of dates appears to be bugged, as 11/7 comes before 11/23
Remove sorting completely, so that it will have default sorting by date (from backend)
| 1 |
7,128,869 | 16,016,734 |
2018-11-21 15:19:16.887
|
[Investigate] Docker image outway:latest does not work
|
The latest docker image for the nlx outway does not work. All services have NO inway addresses.
This may be due to the day docker handles `:latest`, could a non-stable push have resulted in this error? Or has `:latest` not properly been tagged for a while? Start checking the CI/CD first and find out which version `:latest` currently is.
$ docker pull nlxio/outway:latest
latest: Pulling from nlxio/outway
Digest: sha256:c28f77c3c50043e96c35ac3ba124bd7b27b086f0e52c806f3e1c048b5b07ecfa
Timebox: 2 uur
| 0 |
7,128,869 | 16,009,054 |
2018-11-21 10:17:32.320
|
[Investigate] Create solution (incl concrete stories) for solving Linked Data challenges
|
Timebox: 2x3 uur (GJ en Bart)
| 0 |
7,128,869 | 16,008,866 |
2018-11-21 10:10:34.363
|
Sort organizations in insight app menu list
|
- Sort list consistently using frontend filter
| 1 |
7,128,869 | 15,954,593 |
2018-11-19 15:11:09.698
|
Insight app doesn't regenerate QR and doesn't switch IRMA backend when selecting an other organization.
|
In the insight app, when you've selected an organization and then select a different organization, the app doesn't switch to the new IRMA api and doesn't generate a new QR. A page reload is needed to fix the problem.
| 3 |
7,128,869 | 15,840,551 |
2018-11-14 11:27:36.269
|
Move CDN dependencies into local projects
|
Move CDN dependencies into a projects (like bootstrap, jquery and others)
In general, CDN is used in non-react projects.
NLX Certportal (on test): https://certportal.test.nlx.io/
Haarlem Parkeervegunning: https://application.test.haarlem.commonground.nl/
NLX Docs https://docs.test.nlx.io/
| 1 |
7,128,869 | 15,582,541 |
2018-11-05 17:55:01.584
|
Design user-based authentication within NLX
|
It would be great if NLX offers a generic way of handling user-based authentication. We would like to draft a design document to accumulate all the ideas we have on this topic. This design should be a starting point for actually implementing this feature in NLX.
| 1 |
7,128,869 | 15,445,623 |
2018-10-31 14:59:40.629
|
Create a solid plan/stories for implementing autorisation
|
As a PO
I want to have a clear plan for implementing autorisation
so that can present NLX as a good solution for organizations that need authorisation
Acceptance criteria, for example:
- Clear technical plan for implementation
- Necessary stories are added and refined and an epic is created
Notes
- Brainstorm / Experiment
- Write story(ies)
- Check with Sergei to prevent unnecessary double work, they just implemented a similar solution in ZDS 2.0 API reference components
| 2 |
7,128,869 | 14,852,178 |
2018-10-11 10:51:25.942
|
Create a common-ui library
|
As a developer
I want to have a common ui library
so that I can reuse components in multiple frontends
Acceptance criteria, for example:
- There is a common ui package
- All currently required components are available in the common ui package
- Stories are created on the backlog for all parts that are not part of this story
Notes
- This story is not concerned with actually replacing the components in the interfaces with the common ui components.
- But stories should be created for what needs to be done later.
- Relative imports
- Imports through an own npm namespace `@nlx/common-ui` and use [npm link](https://docs.npmjs.com/cli/link)
| 3 |
7,128,869 | 14,738,850 |
2018-10-06 16:39:13.561
|
Setup initial NLX performance benchmarking
|
Benchmarking number of requests per second, find the boundaries for becoming io-bound, cpu-bound, memory-bound, on several systems.
Ideal would be to integrate those tests in deployment pipeline.
This user story replaces #27, more precise the following aspect:
Performance and scalability benchmarks. E.g. number of requests per second NLX can perform on a certain system.
DoD:
1. Create `nlx-bench` repo for the following:
1. Create server application to serve predictable-duration responses. w/ ansible script to deploy
1. Setup ansible scripts for inway/outway on servers. Use acc NLX network.
1. Create client application which measures round-trip time. w/ ansible script to deploy
1. Let client write output to files, no need for public dashboard / automation.
Proposed tech solutions:
vegeta or apache benchmark
https://github.com/tsenart/vegeta
| 8 |
7,128,869 | 14,508,345 |
2018-09-27 07:30:46.082
|
Add NLX preprod and prod environment to current cluster and CI
|
**As a customer**
<br>**I want to use the NLX production environment**
<br>**so that I can have confidence in the stability of my solution that makes use of NLX**
**:white\_check\_mark: Acceptance criteria**
1. Note: MVP production environment means a "best effort" production environment reserved for specific partners
1. Pre-prod: New customers show that they are ready to join production
<br>Prod: New customers that succeed in pre-prod run their business in this NLX network
1. Those environments should have a secure process to provide certificates to organisations, with a manual verification step (see #317)
1. pre-prod and production environment should always be at same version.
1. demo environment needs to stay close to pre-prod and prod but intended deviations should be possible.
1. directory.nlx.io should show prod directory content.
1. directory.preprod.nlx.io should show pre-prod directory content
**:hammer\_and\_wrench: Proposed technical solution**
* Update helm charts
* remove cert portal/cf ssl CA from helm charts
* add gitlab CI jobs to manual trigger pre-prod prod release
* DNS record management
**:link: Reference links**
*
- Deploy a preprod and prod environment from gitlab CI as manual release (same as demo)
| 5 |
7,128,869 | 14,507,498 |
2018-09-27 07:18:51.613
|
Create onboarding process for preprod and prod environment
|
**As** a API provider
<br>**I want** to get a certificate for pre-prod and prod environment
<br>**So that** can start using NLX on pre-prod and prod
**:white\_check\_mark: Acceptance criteria**
1. There is a document describing the process of providing a certificate
2. Create a new CA and save keys in nlx-pass
3. Add docs to docs.nlx.io on how to request a certificate
**:hammer\_and\_wrench: Proposed technical solution**
* CF ssl
**:link: Reference links**
*
| 3 |
7,128,869 | 14,441,884 |
2018-09-25 07:27:52.014
|
Setup link checker for docs in CI
|
As a **manitainer**
<br>I want to **automatically check if all used URLs in docs are still valid when committing**
<br>so that **we prevent dead links and solve them as quickly as possible when they happen anyway**
**:white\_check\_mark: Acceptance criteria**
1. docs.nlx.io and appstore.commonground.nl/docs
1. build fails when internal links are dead
1. daily job running for link checking (only give warning in ci/cd)
**:hammer\_and\_wrench: Proposed technical solution**
* In the CI: use [muffet](https://github.com/raviqqe/muffet) in a container linked to the to-be-released docs container to verify all URL's to be valid.
*
**:link: Reference links**
*
| 3 |
7,128,869 | 14,086,084 |
2018-09-12 08:48:56.215
|
Add better graphs of NLX components and their interactions to docs
| null | 1 |
7,128,869 | 14,041,125 |
2018-09-10 19:02:51.930
|
Mutual TLS ability for inway -> service connection
|
**As a** sysadmin
**I want** mutual TLS encrypted connections between inway and API
**so that** all data connections are secure
There is no protection mechanism yet that can be used to secure services behind an inway. We would like to add some kind of mechanism to protect communication between the inway and the service as well.
**Acceptance criteria**
1. Ability to add client certificates to the inway service definition. This certificate is then used by the inway to connect to the service.
1. Ability to add trust configuration to the inway to determin whitch certificates from the api should be trusted by the inway.
1. Updated Documentation
1. Update all demo deployments
| 5 |
7,128,869 | 14,028,148 |
2018-09-10 10:58:51.120
|
Setup unit tests for inway
|
- Write unit tests for code that is currently testable
- Add todo comments for code that needs to be refactored for what needs to be refactored
- Add separate stories for these todos
| 5 |
7,128,869 | 12,247,771 |
2018-06-22 11:32:02.082
|
Add pagination to txlog and txlog-ui
|
Maybe look into [postgraphile](https://github.com/graphile/postgraphile)
| 1 |
7,128,869 | 12,125,104 |
2018-05-04 11:47:46.000
|
Let healthchecker watch db using LISTEN/NOTIFY
|
Search for issue number in code TODO's.
| 1 |
7,128,869 | 12,125,109 |
2018-05-04 11:43:22.000
|
Split directory inspection and registration API's into separate components/processes
|
Search for issue number in code TODO's.
| 1 |
7,128,869 | 24,458,820 |
2019-09-04 11:59:59.121
|
Streamline process obtaining production certificates
|
**As an** administrator
<br>**I want to** to obtain pre-production and production certificates
<br>**so that** I can run NLX components in the production environment
**:white\_check\_mark: Acceptance criteria**
1. Explain the process for how to obtain certificates
1. Create 'Production` section on docs.nlx.io
1. ~~Maintainer documentation on how to help/validate customers that need a certificate~~
1. ~~Determine who is responsible in the team~~
1. ~~There is a backup of the PKI of the CA~~
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
| 5 |
7,128,869 | 24,242,141 |
2019-08-28 12:02:32.531
|
Let inway use the config-api
|
**As an** administrator
<br>**I want to** be able to use the config-api to configure my inway
<br>**so that** i do not have to use the toml any more
**:white\_check\_mark: Acceptance criteria**
1. We add a new experimental flag `CONFIG_API` to tell the inway where the configuration API lives
1. The inway adopts the inway configuration, configures the corresponding services and checks every x seconds for new configuration, applies and reloads on a change.
| 3 |
7,128,869 | 24,210,180 |
2019-08-27 16:47:21.619
|
Add authentication to management-api
|
**As an** administrator
<br>**I want to** have a secure management-api
<br>**so that** no unauthenticated people can make changes to the API
**:white\_check\_mark: Acceptance criteria**
1. Every API endpoint (except /login) is secured and will check if the user is authenticated
1. There should be a login screen as part of the UI
1. There should be an option to logout from the UI
1. Only support the roles 'admin', 'readonly' for now
1. When not authenticated, the UI should always redirect to the login screen
1. The authenticatie mechanism should be pluggable. Looking up logins from a plain text file is fine for now.
1. Token should expire after 60 minutes (don't implement refresh logic for now)
**:hammer\_and\_wrench: Proposed technical solution**
1. Add & implement a /login endpoint
1. It is possible to specify multiple users, passwords (hashed) and a role in a plain text file
# LATER
1. When logged in, user name should be shown top right in Management UI.
1. When clicking on user name, there should be option to log out
*The overall idea is that one Management Dashboard gives infra admins the possibility to manage their NLX components (while not being able to access functional logs) and gives privacy auditors and / or functional managers the ability to look up transaction logs (while not being able to alter the NLX network config)*
| 8 |
7,128,869 | 24,210,043 |
2019-08-27 16:42:20.212
|
Create initial management-ui
|
**As a** administrator
<br>**I want to** administer my NLX components from a fancy UI
<br>**so that** I do not have to use the CLI anymore
**:white\_check\_mark: Acceptance criteria**
1. A new React app is setup with create-react-app in `management-ui`
1. An initial Router setup is done with react-router with an inway page and service page
1. The system shows a list of Inways and Services
1. It is possible to create a new service, update an existing service and delete a service
| 13 |
7,128,869 | 23,908,820 |
2019-08-19 11:41:48.563
|
Document header specifications
|
**As a** end-user developer
<br>**I want to** know the specifications of the NLX http headers
<br>**so that** I can design my datamodel to store the data.
**:white\_check\_mark: Acceptance criteria**
1. Document NLX header specifications (type, size, optional or not)
1. Add this as content on docs.nlx.io including navigation
1. Link to this page frrom relevant sections
**:hammer\_and\_wrench: Proposed technical solution**
* n/a
**:link: Reference links**
* [Header documentation currently](https://docs.nlx.io/further-reading/transaction-logs/)
| 2 |
7,128,869 | 23,424,852 |
2019-08-02 09:35:46.193
|
Make insight-api and irma-api-server configurable and disable on the minikube by default
|
**As a** developer
<br>**I want to** have a fast developer environment
<br>**so that** I can develop quickly
**:white\_check\_mark: Acceptance criteria**
1. The services insight-api and irma-api-server are configurable in the organization Helm chart
1. These services are disabled by default on the minikube environment
| 1 |
7,128,869 | 23,199,269 |
2019-07-26 13:53:43.808
|
Clean up Gitlab runners
|
I cleaned up our Gitlab runners. We should change some of the tags in our jobs to be consistent across projects.
| 1 |
7,128,869 | 22,932,308 |
2019-07-17 14:38:04.571
|
Create a management API to manage inway and service configuration from UI
|
**As a** developer
<br>**I want to** by able to manage the inway and service configuration through the management-api
<br>**so that** we can start building the management-ui
**:white\_check\_mark: Acceptance criteria**
1. A new service `management-api` is added to the codebase
1. It is possible to PUT new inway configurations to the `management-api`
1. These inway configuration updates are persisted in etcd
1. There is no authentication or authorisation performed yet on this service (later enhancement)
**Technical implementation**
No gRPC, use REST/JSON
| 8 |
7,128,869 | 22,930,844 |
2019-07-17 14:11:24.022
|
Enhance the quality of NLX error messages
|
**As a** user
<br>**I want** error messages that tell me exactly what is going on
<br>**so that** I don't have to waste time analyzing
**:white\_check\_mark: Acceptance criteria**
1. Possible errors are identified and no longer ambiguous
1. Errors during setup / usage inway and outway are clear
1. Possible errors are documented with a short explanation
1. +kudos if error message links to docs
**:hammer\_and\_wrench: Proposed technical solution**
1) identifield possible failures.
client -> outway -> F1 -> inway -> F2 -> service.
directory health check -> F3 inway.
directory list 'unhealty' services.
Cases F1, F2 now produces clear logs.
Case F3 now no longer is cause for removal from directory.
*
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
*
| 8 |
7,128,869 | 22,930,841 |
2019-07-17 14:11:20.878
|
Build the config API
|
**As a** user
<br>**I want to** have configuration API
<br>**so that** I don't need to start all xways with complex cli commands
---
**:white\_check\_mark: Acceptance criteria**
1. Configuration API with persistent storage backend
1. Configurations can be saved and retrieved
1. Configuration template for an inway
1. Configuration is validated by the API
**:hammer\_and\_wrench: Proposed technical solution**
* etcd as persistent storage
* communication between API and component GRPC
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
*
| 13 |
7,128,869 | 22,835,917 |
2019-07-16 10:57:42.391
|
Zap logger failed to sync
|
When stopping an outway or inway with ctrl+c, you see the following message:
```
failed to sync zap logger: sync /dev/stderr: invalid argument
```
*Expected behaviour*
* The Zap logger is successfully synced and no error is shown.
*Actual behaviour*
* Failed to sync the logger and displaying an error.
**:clipboard: Steps to reproduce**
1. Start outway (or inway) from console
1. Stop outway (or inway) with ctrl+c
**:beetle: Cause**
Not yet known
**:mag: Details**
N/A
---
| 2 |
7,128,869 | 22,834,631 |
2019-07-16 10:09:15.187
|
Enable HTTP2 between outway and inway
|
**As a** customer
<br>**I want to** have HTTP2 enabled between the outway and inway
<br>**so that** we use less CPU and gain an higher throughput
**:white\_check\_mark: Acceptance criteria**
1. Running an outway with `GODEBUG=http2debug=1` displays the usage of http2
**:hammer\_and\_wrench: Proposed technical solution**
* Enable http2 transport in the outway
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
| 1 |
7,128,869 | 22,804,784 |
2019-07-15 14:08:53.749
|
Switch back to Gitlab Gosec image for SAST
|
The following discussion from !657 should be addressed:
- [x] @RonaldKoster started a [discussion](https://gitlab.com/commonground/nlx/merge_requests/657#note_191689116): (+1 comment)
> `registry.gitlab.com/bartjkdp/gosec:feature-upgrade-to-gosec-2` image in personal registry? I would prefer something like`registry.gitlab.com/nlx/gosec:feature-upgrade-to-gosec-2`
Switch back to Gitlab image when MR is accepted.
| 1 |
7,128,869 | 22,732,336 |
2019-07-12 09:51:18.661
|
Directory inspection API get service api spec database error
|
The `/directory/get-service-api-spec` endpoint on the directory-inspection-api returns `Database error.`.
*Expected behaviour*
* `200 Ok` response with the service api spec or `404 Not Found` when no spec exists.
*Actual behaviour*
* 500 Internel Server error response: `{"error":"Database error.","message":"Database error.","code":13}`
**:clipboard: Steps to reproduce**
1. GET request to https://directory.demo.nlx.io/api/directory/get-service-api-spec/convenantgemeenten/AppointmentDataService
**:beetle: Cause**
* Error is caused by `Scan` that returns an error. See https://gitlab.com/commonground/nlx/blob/master/directory-inspection-api/inspectionservice/get-service-api-spec-doc.go#L63
**:mag: Details**
* When there are no inways registered:
```
inspectionservice/get-service-api-spec-doc.go:65 failed to execute stmtSelectServiceInway {"version": "v0.73.0", "handler": "list-services", "error": "sql: no rows in result set"}
```
* When there is a inway registered:
```
inspectionservice/get-service-api-spec-doc.go:65 failed to execute stmtSelectServiceInway {"version": "v0.73.0", "handler": "list-services", "error": "sql: Scan error on column index 1, name \"api_specification_type\": unsupported Scan, storing driver.Value type <nil> into type *string"}
```
---
| 3 |
7,128,869 | 22,636,492 |
2019-07-09 15:04:08.706
|
Implement 503 HTTP status code for offline services
|
**As a** developer
<br>**I want to** use nlx and have sane error messages
<br>**so that** I can debug my new inway / outway
```
$ curl http://outway:9090/nlx/afval/
nlx outway: invalid path in url
```
Above error could have **many** causes which can be explained. A most of all the *PATH IS CORRECT.*
Communication failure between Inway and directory means no outway will be able to access the service. This makes nlx quite fragile.
Possible causes:
* Inway can't connect to upstream API: `[inway] http: proxy error: dial tcp 127.0.0.1:3000: connect: connection refused`
**:white\_check\_mark: Acceptance criteria**
1. A temporarily unavailable service should give back 503. Not a 4xx. since the user is not at fault.<br>
2. Make Outway work even when communication between inway and directory fails.
**:hammer\_and\_wrench: Proposed technical solution**
* The outway should also have knowlegde of offline services from the directory service.
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
| 1 |
7,128,869 | 22,511,556 |
2019-07-04 08:10:35.700
|
golangci-lint run outway solve marked issues .
|
*Expected behaviour*
* No golangci-lint comments.
*Actual behaviour*
the output of `golangci-lint` should be empty but it is not.
```
auth_test.go:124:25: bodyclose: response body must be closed (bodyclose)
resp, err := client.Do(req)
^
listen_test.go:64:25: bodyclose: response body must be closed (bodyclose)
resp, err := client.Do(req)
^
cmd/nlx-outway/main.go:70:2: importShadow: shadow of imported from 'go.nlx.io/nlx/common/process' package 'process' (gocritic)
process := process.NewProcess(logger)
^
listen.go:28:33: importShadow: shadow of imported from 'go.nlx.io/nlx/common/process' package 'process' (gocritic)
func (o *Outway) ListenAndServe(process *process.Process, address string) error {
^
listen.go:50:36: importShadow: shadow of imported from 'go.nlx.io/nlx/common/process' package 'process' (gocritic)
func (o *Outway) ListenAndServeTLS(process *process.Process, address string, certFile, keyFile string) error {
^
outway.go:85:6: emptyStringTest: replace `len(authCAPath) == 0` with `authCAPath == ""` (gocritic)
if len(authCAPath) == 0 {
^
outway.go:88:3: importShadow: shadow of imported package 'url' (gocritic)
url, err := url.Parse(authServiceURL)
^
service.go:65:1: paramTypeCombine: func(logger *zap.Logger, roots *x509.CertPool, certFile string, keyFile string, organizationName, serviceName string, inwayAddresses []string) (*RoundRobinLoadBalancedHTTPService, error) could be replaced with func(logger *zap.Logger, roots *x509.CertPool, certFile, keyFile, organizationName, serviceName string, inwayAddresses []string) (*RoundRobinLoadBalancedHTTPService, error) (gocritic)
func NewRoundRobinLoadBalancedHTTPService(logger *zap.Logger, roots *x509.CertPool, certFile string, keyFile string, organizationName, serviceName string, inwayAddresses []string) (*RoundRobinLoadBalancedHTTPService, error) {
^
outway_internal_test.go:53: File is not `gofmt`-ed with `-s` (gofmt)
&inspectionapi.ListServicesResponse_Service{ServiceName: "mock-service-a", OrganizationName: "mock-org-a", InwayAddresses: mockServiceAInwayAddresses},
&inspectionapi.ListServicesResponse_Service{ServiceName: "mock-service-b", OrganizationName: "mock-org-b", InwayAddresses: mockServiceBInwayAddresses},
&inspectionapi.ListServicesResponse_Service{ServiceName: "mock-service-c", OrganizationName: "mock-org-c"},
cmd/nlx-outway/main.go:39:1: cyclomatic complexity 12 of func `main` is high (> 10) (gocyclo)
func main() {
^
service_test.go:16:22: string `mockorg` has 2 occurrences, make it a constant (goconst)
organisationName := "mockorg"
^
service_test.go:17:17: string `mockservicename` has 2 occurrences, make it a constant (goconst)
serviceName := "mockservicename"
^
service_test.go:19:14: string `../testing/org-nlx-test.crt` has 2 occurrences, make it a constant (goconst)
certFile := "../testing/org-nlx-test.crt"
^
service_test.go:20:13: string `../testing/org-nlx-test.key` has 2 occurrences, make it a constant (goconst)
keyFile := "../testing/org-nlx-test.key"
^
service.go:38:2: `endPoints` is unused (structcheck)
endPoints []*url.URL
^
outway.go:49:2: `headersStripList` is unused (structcheck)
headersStripList *http.Header
^
auth_test.go:86:29: Error return value of `(*encoding/json.Encoder).Encode` is not checked (errcheck)
json.NewEncoder(w).Encode(authResponse)
^
auth_test.go:92:28: Error return value of `(*encoding/json.Encoder).Encode` is not checked (errcheck)
json.NewEncoder(w).Encode(authResponse)
^
listen.go:103:17: shadow: declaration of "err" shadows declaration at line 94 (govet)
authResponse, err := o.authorizeRequest(r.Header, destination)
^
listen_test.go:86:2: SA4006: this value of `destination` is never used (staticcheck)
destination, err = parseURLPath("/organization/service")
^
```
**:clipboard: Steps to reproduce**
1. golangci-lint run outway solve all issues.
**:mag: Details**
(Paste any relevant logs - please use code blocks to format console output, logs, and code)
(Add screenshots using `Attach a file`)
---
| 2 |
7,128,869 | 22,479,450 |
2019-07-03 11:54:40.254
|
Add first version of configuration API
|
**As a** user
<br>**I want to** configure and manage inways and outways from a central point
<br>**so that** I don't need to start all xways with complex cli commands
---
Out of scope (will be done later):
* Keyless
**:white\_check\_mark: Acceptance criteria**
1. xway registration flow implemented
1. xway self init and registration
1. management API for self init acknowledgement
1. Configuration API with persistent storage backend
1. xway watches configuration for changes
1. toml's are gone
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
*
| 20 |
7,128,869 | 22,381,848 |
2019-06-30 10:27:26.340
|
Move scheduled security scanning to nlx-security repo
|
**As a** developer
<br>**I want to** move scheduled security scan to a seperate repo
<br>**so that** it doesn't interfere with the dev pipelines
---
Moving it to a separate repo allows us to:
* Reserve the gitlab-ci.yml for development pipelines, keeping it clean
**:white\_check\_mark: Acceptance criteria**
* [x] Move scheduled security scan pipeline to repo nlx-security
* [x] Security scans run on demo, preprod and prod
* [x] Dependency scanning
* [x] Static application security testing (SAST)
* [x] Container scanning
* [x] Dynamic application security testing (DAST)
* [x] Report findings in the security dashboard, building a consistent history
* [x] Add security scans to the nlx repo development pipelines that do NOT report to security dashboard
* [x] Dependency scanning
* [x] Static application security testing (SAST)
| 3 |
7,128,869 | 22,331,361 |
2019-06-27 20:05:38.458
|
Changes in inway configuration do not propagate to directory
|
When attributes of services change (e.g. api specification url or documentation url) these changes are not propagated to the directory. This can be solved by manually deleting the service from the PostgreSQL database. A new service is created with the correct information.
*Expected behaviour*
* When a change occurs in the inway configuration of a service, this is automatically propagated through tot the directory.
*Actual behaviour*
* The information is not updated in the directory.
**:clipboard: Steps to reproduce**
1. Start a service without an api spec URL on an inway and register to the directory
1. Add an API spec URL
1. See the spec URL is not visible within the directory.
**:beetle: Cause**
* (if cause is known, details here)
* (if you can pinpoint a piece of code, link to line number)
**:mag: Details**
Regression, worked before
(Paste any relevant logs - please use code blocks to format console output, logs, and code)
(Add screenshots using `Attach a file`)
---
| 2 |
7,128,869 | 22,272,224 |
2019-06-26 13:38:50.106
|
Directory: add a link to the documentation of an API
|
**As a** user
<br>**I want to** , when using the directory-ui, navigate to the documentation-url provided by the provider of an API
<br>**so that** I can read the documentation of an API
**:white\_check\_mark: Acceptance criteria**
1. documentation-url link is available on the drawer of the Directory UI
**:hammer\_and\_wrench: Proposed technical solution**
* Display value of property `documentation_url` if present.
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
*
**:camera_with_flash: Screenshot**
| 1 |
7,128,869 | 22,090,288 |
2019-06-20 10:46:35.050
|
Enable gitlab-ci on nlx-demo repository
|
**As a** developer
<br>**I want to** automatically release Docker images for nlx-demo
<br>**so that** I do not have to do this manually
**Background**
When we moved from Jenkins to Gitlab CI we forgot to create a new configuration for the nlx-demo repo.
**:white\_check\_mark: Acceptance criteria**
1. Gitlab CI automatically Docker images when commits land on master
| 1 |
7,128,869 | 22,086,017 |
2019-06-20 08:25:47.295
|
The /about page on nlx.io is not working any more
|
The /about page on nlx.io is not working any more
**:clipboard: Steps to reproduce**
1. Go to www.nlx.io/about
**:beetle: Cause**
* An incorrect nginx configuration
| 1 |
7,128,869 | 22,074,389 |
2019-06-19 20:12:36.038
|
Links in Docs don't work
|
In the Getting Started guide, links intended to lead from page to page are broken.
Requesting pages without trailing slash does not work
*Expected behaviour*
Links lead to a page
* consume-an-api.md: `[part 2](../create-certificates)` & `[part 4](../provide-an-api)`
* create-certificates.md: `[part 1](../setup-your-environment)`
* provide-an-api.md: `[part 2](../create-certificates)` & `[part 2](../create-certificates)`
*Actual behaviour*
Every link without trailing slash fails. Instead it attempts to load something from port 8080.
**:clipboard: Steps to reproduce**
1. Visit https://docs.nlx.io/get-started/setup-your-environment/
1. Follow the guide
1. Click every link in the guide
It's not just the guide but everything on docs
**:beetle: Cause**
* Might be an Nginx configuration error
**:mag: Details**
---
| 2 |
7,128,869 | 22,069,104 |
2019-06-19 16:13:25.955
|
Incorrect port for "Consume an API" in docs
|
Update incorrect port in docs.
*Expected behaviour*
* “You will get back the container id of the container you created from this image. By running this command, we’ve launched our very own NLX outway. It is running on http://localhost:8080.”
*Actual behaviour*
* “You will get back the container id of the container you created from this image. By running this command, we’ve launched our very own NLX outway. It is running on http://localhost:4080.”
**:clipboard: Steps to reproduce**
1. Go to docs "consume an API" page: https://docs.acc.nlx.io/get-started/consume-an-api/
1. Navigate to section "Setting up the outway"
**:beetle: Cause**
* (if cause is known, details here)
* (if you can pinpoint a piece of code, link to line number)
**:mag: Details**
(Paste any relevant logs - please use code blocks to format console output, logs, and code)
(Add screenshots using `Attach a file`)
---
| 1 |
7,128,869 | 22,060,011 |
2019-06-19 11:50:23.660
|
insight-api unit tests
|
**As a** developer
<br>**I want to** have unit tests on the insight-api
<br>**so that** I am kinda sure everything is working
**:white\_check\_mark: Acceptance criteria**
1. Test what can be tested on the insight-api
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
*
| 2 |
7,128,869 | 22,052,521 |
2019-06-19 09:14:15.265
|
Eliminate txlog-ui and txlog-api
|
**As a** developer
<br>**I don't want to** maintain a deprecated application
<br>**so that** I can spend my energy on more useful tasks
TX Log UI is unsecure technical debt and should be eliminated.
Will be replaced later with UI in Management Dashboard.
**:white\_check\_mark: Acceptance criteria**
1. update the docs - remove txlog UI and show Postgres guideline to show logs
1. txlog-ui directory removed from repository
1. txlog-api directory removed from repository
1. pipelines updated
1. helm / skaffold updated
1. remove from Uptime Robot
1. update nlx-compose repo
**:hammer\_and\_wrench: Proposed technical solution**
* Copy Postgres query from txlog-api for guideline
**:link: Reference links**
* [Project Definition of Done](https://gitlab.com/commonground/nlx/blob/master/CONTRIBUTING.md#4-2-definition-of-done)
*
| 3 |
7,128,869 | 21,935,617 |
2019-06-15 10:12:51.884
|
Add different issue templates
|
**As a** user
<br>**I want to** submit feature requests, bugs, support questions, etc.
<br>**so that**
**:white\_check\_mark: Acceptance criteria**
1. Issue template for User story
1. Issue template for Bug
1. Issue template for Support tickets
1. Issue template for Security reports
1. Template for Merge requests
**:hammer\_and\_wrench: Proposed technical solution**
* https://gitlab.com/help/user/project/description_templates.md#using-the-templates
**:link: Reference links**
*
| 1 |
7,128,869 | 21,907,597 |
2019-06-14 09:09:01.636
|
Reduce noise from Renovate bot
|
**As a** developer
<br>**I want** to reduce the number of Pull Requests generated by Renovate Bot
<br>**so that** runners are available when I need them and I don't have to review and merge so many PR's every day
---
Renovate bot is great but generates too many PR's to comfortably process.
Let's reduce the noise.
**:white\_check\_mark: Acceptance criteria**
1. Groups of dependencies are grouped into aggregated Pull Requests
1. Renovate Bot only generates new PR's between 2:00h AM CET and 8:00 AM CET to keep runners available when devs need them
**:hammer\_and\_wrench: Proposed technical solution**
* Enable Package Grouping: https://renovatebot.com/docs/noise-reduction/#package-grouping
* Limit Renovate to the night with scheduling: https://renovatebot.com/docs/noise-reduction/#scheduling-renovate
**:link: Reference links**
* https://renovatebot.com/docs/noise-reduction/
| 2 |
7,128,869 | 21,859,481 |
2019-06-13 06:23:00.943
|
Remove FIELDLAB-WALKTROUGH.md
|
**As a** PO
<br>**I want to** remove the old fieldlab walktrough
<br>**so that** people don't start a guide that isn't accurate anymore
**:white\_check\_mark: Acceptance criteria**
1. File FIELDLAB-WALKTROUGH.md is removed from repo root
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
*
| 0 |
7,128,869 | 21,834,539 |
2019-06-12 11:58:05.674
|
Rename NLX Stelsel to NLX System
|
**As a** PO
<br>**I want** the Readme.md to be in English
<br>**so that** everyone can understand it
**:white\_check\_mark: Acceptance criteria**
1. Change title in Readme.md from NLX Stelsel to NLX System
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
*
| 0 |
7,128,869 | 21,833,752 |
2019-06-12 11:31:28.109
|
Add security e-mail address
|
**As a** responsible security researcher
<br>**I want to** report security issues securely
<br>**so that** the world does not abuse the issue while NLX team is fixing it
**:white\_check\_mark: Acceptance criteria**
1. We have a "security@nlx.io" e-mail address where the world can report security issues (see #143)
1. This e-mail address creates confidential issues in new repo `nlx-security`
1. This new repo has limited access rights - need to know
**:hammer\_and\_wrench: Proposed technical solution**
* Add email forwarder in TransIP
**:link: Reference links**
*
| 2 |
7,128,869 | 21,832,398 |
2019-06-12 10:32:51.686
|
Scheduled pipelines for security scans
|
**As a** DevSecOps dude
<br>**I want to** schedule a pipeline running regular scans on our containers and deployed endpoints
<br>**so that** we keep an eye on security after building / deploying
**:white\_check\_mark: Acceptance criteria**
1. Scheduled pipeline configured in Gitlab
2. Security scans that we use in build pipelines are added to this pipeline
3. Results are added to Gitlab Security Dashboard
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
*
| 8 |
7,128,869 | 21,832,269 |
2019-06-12 10:28:01.727
|
Document Definition of Done
|
**As a** PO
<br>**I want** a clear Definition of Done for NLX stories
<br>**so that** it is clear to everyone when a story is truly 'done'
**:white\_check\_mark: Acceptance criteria**
1. Definition of Done is available as an .md in repo root
2. Issue template links to DoD
3. Contribute.md links to DoD
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
*
| 1 |
7,128,869 | 21,829,363 |
2019-06-12 08:52:00.970
|
Document deployment flow
|
**As a** PO
<br>**I want** a documented deployment flow
<br>**so that** everyone involved knows exactly what to do
**:white\_check\_mark: Acceptance criteria**
1. New flow documented in contribute.md
1. Includes detailed actions for all roles, as a manual
**:hammer\_and\_wrench: Proposed technical solution**
* Add to contribute
**:link: Reference links**
*
| 2 |
7,128,869 | 21,785,012 |
2019-06-11 08:59:56.430
|
Adding logrecords by inway & outway is unreliable
|
**As a** presentor of the NLX demo
<br>**I want to** be sure the logrecords are always persisted to the database
<br>**so that** I can rely on our software
---
Currently, logrecords are not consistently written to the database. Happens to both inway (more often) and outway.
**:white\_check\_mark: Acceptance criteria**
1. Prevent the following Postgres error when inserting a logrecord to the database:
> failed to start db transaction for log insertion: read tcp 10.130.69.221:42778->10.130.60.248:5432: read: connection reset by peer
**:hammer\_and\_wrench: Proposed technical solution**
* Reason for this to happen is unclear.
* Investigate issue, Might be the Postgres driver. Check open issues postgres drivers
**:link: Reference links**
* [Errors in Kibana](https://kibana.charlie.k8s.nlx.io/app/kibana#/discover?_g=(refreshInterval:(pause:!f,value:5000),time:(from:'2019-06-11T08:12:04.024Z',mode:absolute,to:'2019-06-11T08:27:04.024Z'))&_a=(columns:!(_source),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'379f7480-85e6-11e9-897a-49a1f312e0a7',key:kubernetes.namespace_name,negate:!f,params:(query:nlx-demo-brp,type:phrase),type:phrase,value:nlx-demo-brp),query:(match:(kubernetes.namespace_name:(query:nlx-demo-brp,type:phrase))))),index:'379f7480-85e6-11e9-897a-49a1f312e0a7',interval:auto,query:(language:lucene,query:ERROR),sort:!('@timestamp',desc))).
**Screenshot**
| 5 |
7,128,869 | 21,641,231 |
2019-06-06 13:24:33.194
|
Fix Minikube after previous changes to the Helm charts
|
**As a** developer
<br>**I want to** run NLX on minikube again
<br>**so that** I can develop
**:white\_check\_mark: Acceptance criteria**
1. NLX is running on minikube again
**:hammer\_and\_wrench: Proposed technical solution**
NLX is not working on minikube any more because minikube does not offer a LoadBalancer service type.
* Use Kubernetes internal DNS to redirect internal calls to internal service
| 2 |
7,128,869 | 21,562,727 |
2019-06-04 10:16:34.252
|
Docs: wrong description --publish parameter
|
In the docs https://docs.nlx.io/get-started/provide-an-api/ the description of the --publish parameter is wrong.
`--publish 4443:4443 connects port 4443 on the host machine to port 443 inside the container. This way, we can send requests to the inway.`
should be
`--publish 4443:8443 connects port 4443 on the host machine to port 8443 inside the container. This way, we can send requests to the inway.`
| 1 |
7,128,869 | 21,407,059 |
2019-05-29 12:25:55.249
|
Change deployment flow
|
**:white\_check\_mark: Acceptance criteria**
1. Semantic release for every push on master
1. Container release and deploy to test on every version tag
1. Manual deploy step to deploy version to acc
1. Manual deploy step to deploy version to prod, etc.
| 2 |
7,128,869 | 21,405,755 |
2019-05-29 11:44:19.723
|
Fix support e-mail
|
**As a** user
<br>**I want to** get support by sending e-mail to support@nlx.io
<br>**so that** it's easy to get support
---
Current solution with external mail provider forwarding to Gitlab servicedesk stopped working.
**:white\_check\_mark: Acceptance criteria**
1. E-mail addressed to support@nlx.io ends up in Gitlab Servicedesk
**:hammer\_and\_wrench: Proposed technical solution**
* Use TransIP e-mail
| 5 |
7,128,869 | 21,402,518 |
2019-05-29 11:02:56.151
|
Filterable log messages for nlx-components
|
**As a** developer
<br>**I want to** have elasticsearch-readable log output on live environments
<br>**so that** I can filter through log individual log fields
**:white\_check\_mark: Acceptance criteria**
1. Logs outputted in JSON format for all NLX components
**:hammer\_and\_wrench: Proposed technical solution**
* Configure zap and logrus outputs to be json formatted
| 2 |
7,128,869 | 21,398,177 |
2019-05-29 09:01:36.555
|
Enhance visual link between overview and detail pane insight UI
|
**As a** user of the Insight UI
<br>**I want to** see some visual indication that something changes in detail pane when selecting another row
<br>**so that** my attention is drawn to the detail pane
---
Currently it is hard to see that content of detail pane changes due high similarity of content in all records
**:white\_check\_mark: Acceptance criteria**
1. Visual indication when content of detail pane changes after selecting another record
**:hammer\_and\_wrench: Proposed technical solution**
* Add visual indication using :hover :active and maybe a border
**:link: Reference links**
*
| 2 |
7,128,869 | 21,215,990 |
2019-05-23 10:34:39.956
|
Directory UI doesn't give correct feedback for API link
|
**As a** user of the Insight UI
<br>**I want to** see some visual indication that url is copied
<br>**so that** I
---
When hovering the icon to API url in directory UI, there is no indication to where it will lead.
Urgent because current UI gives no clue about what the user should do to use an API via NLX.
**:white\_check\_mark: Acceptance criteria**
1. When clicking the icon to API url in directory UI, there is feedback that the url is copied to clipboard
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
*
| 3 |
7,128,869 | 20,924,840 |
2019-05-15 12:10:13.794
|
Create sequence diagrams for automatic onboarding w/ admin dashboard and certificate generation
|
**As a** developer
<br>**I want to** have sequence diagrams on future systems
<br>**so that** I can understand their inner workings and work towards implementation
**:white\_check\_mark: Acceptance criteria**
1. Sequence diagrams for onboarding with the admin dashboard and automatic certificate creation
**:hammer\_and\_wrench: Proposed technical solution**
* Sequence diagrams for goseq or websequencediagrams.com
| 8 |
7,128,869 | 20,923,841 |
2019-05-15 11:29:59.251
|
Add ElasticSearch, LogStash, Kibana to get insight in NLX sys logs
|
**As an** NLX developer
<br>**I want to** have ELK stack to get great insight in NLX sys logs
<br>**so that** I can find and analyse errors in an efficient manner
<br>**and** we can solve #556
**:white\_check\_mark: Acceptance criteria**
1. ELK (ElasticSearch, Logstash, Kibana) deployed on our own NLX environments
1. All standard output from NLX components can be written to ELK
1. We can search / analyse those logs with Kibana
**:hammer\_and\_wrench: Proposed technical solution**
* For now quick 'n dirty on non-persistent storage
* Will wait for Haven to add persistent storage
**:link: Reference links**
*
| 5 |
7,128,869 | 20,914,764 |
2019-05-15 07:31:15.180
|
Make `go` available in gitlab shell runners
|
**As a** Developer
<br>**I want to** Have go available in $PATH in the gitlab shell runners
<br>**so that** golangci-lint can do it's job
**:white\_check\_mark: Acceptance criteria**
1. This should be succeeding: https://gitlab.com/commonground/nlx/-/jobs/212261241
**:hammer\_and\_wrench: Proposed technical solution**
* Find out why the ansible role doesn't add go to PATH, or if it does, why golanci-lint doesn't have that same PATH. Then fix it.
| 2 |
7,128,869 | 20,234,701 |
2019-04-22 08:06:35.943
|
Create some initial sketches for the management-ui
|
**As an** administrator
<br>**I want to** configure the NLX components in a fancy dashboard
<br>**so that** I don't need the CLI after the initial configuration
**:white\_check\_mark: Acceptance criteria**
1. We have some initial sketches what the dashboard could look like
1. These initial sketches are the basis for some initial UI work
Intial sketches can be found on https://sketch.cloud/s/7dDVY
| 3 |
7,128,869 | 20,202,281 |
2019-04-19 15:50:13.181
|
Review app for NLX repo
|
**As a** PO
<br>**I want to** be able to judge merge requests for frontend in Review App environments
<br>**so that** I don't have to run the full app locally to review and get a more realistic preview
**:white\_check\_mark: Acceptance criteria**
1. Review app added in pipeline
1. Merge requests with frontend impact spawn a temporary environment
1. New flow is documented
1. New flow is demonstrated and understood by the whole team
**:hammer\_and\_wrench: Proposed technical solution**
* Complication is that we use multiple namespaces for deployment of multiple (demo) organisations. Let's try and add multiple namespaces by Review app
* Loadbalancers are seriously complicated - so we will keep internal trafic inside cluster (no public IP)
**:link: Reference links**
*
| 8 |
7,128,869 | 20,202,241 |
2019-04-19 15:47:28.493
|
Renovate bot for NLX repo
|
**As a** PO
<br>**I want** our repo dependencies to be automatically updated by Renovate Bot
<br>**so that** we are always up-to-date with minimal effort
---
Appears to be successful for DON repo, let's implement the same way for consistency
**:white\_check\_mark: Acceptance criteria**
1. Renovate Bot proposes merge requests which are reviewed and merged manually.
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
*
| 1 |
7,128,869 | 20,139,950 |
2019-04-17 13:01:52.619
|
Implement log detail pane + pagination for the Insight UI
|
**As a**
<br>**I want to**
<br>**so that**
**:white\_check\_mark: Acceptance criteria**
1. Remaining functionalities from #506
1. Remove search logs functionality - we don't support search in the API
**:hammer\_and\_wrench: Proposed technical solution**
*
**:link: Reference links**
*
| 5 |
7,128,869 | 19,969,290 |
2019-04-11 14:24:30.305
|
Insight API endpoint /fetch returns incorrect content-type
|
* URL
`https://insight-api.test.voorbeeld-haarlem.nl/fetch`
* Response
```
{"records":[],"page":0,"rowsPerPage":0,"rowCount":0}
```
**Expected**
Header `Content-Type` with `application/json` as value
**Actual**
Header `Content-Type` with `'text/plain; charset=utf-8` as value
**Add test!**
| 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.